Compare commits

...

3610 Commits

Author SHA1 Message Date
Morris Jobke 1462508b80 Merge pull request #11588 from nextcloud/version/noid/14.0.1RC1
14.0.2 RC 1
2018-10-04 17:53:32 +02:00
Morris Jobke 84f7d23116 14.0.2 RC 1
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-04 16:35:05 +02:00
Morris Jobke 0afef27860 Merge pull request #11610 from nextcloud/bugfix/noid/stable14-fix-call-to-logger
[14] Fix call to logger
2018-10-04 15:45:04 +02:00
Daniel Kesselberg 718e34a075 Append error from exception for message
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-04 11:34:27 +02:00
Roeland Jago Douma ded541408c Merge pull request #11608 from nextcloud/users-table-header-fix-14
[stable14] Fix header border on users list
2018-10-04 10:21:48 +02:00
John Molakvoæ (skjnldsv) a623f96e86 Fix header border on users list
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-04 09:01:23 +02:00
Nextcloud bot e87ec7d2c9 [tx-robot] updated from transifex 2018-10-04 00:12:17 +00:00
Nextcloud bot 1302b6f267 [tx-robot] updated from transifex 2018-10-03 16:58:57 +00:00
Morris Jobke 5b33cbd507 Merge pull request #11582 from nextcloud/stb14-users-table-header-fix
[stable14] Fix sticky header on users list
2018-10-03 14:54:37 +02:00
Morris Jobke 0ca305b1c1 Merge pull request #11575 from nextcloud/stb14-add-group-settings
[stable14] Add new group entry on users list + fixes
2018-10-03 14:53:48 +02:00
Roeland Jago Douma 316a3a501c Merge pull request #11579 from nextcloud/stb14-dropdown-bottom-users-list-fix
[stable14] Force multiselect max-height to 5.5 items
2018-10-03 13:36:17 +02:00
Roeland Jago Douma 6734e434bc Merge pull request #11580 from nextcloud/backport/11568/stable14
[stable14] Just update password hash without validating
2018-10-03 13:35:51 +02:00
Morris Jobke 7d850c35aa Merge pull request #11577 from nextcloud/backport/11185/stable14
[stable14] Redirect guests to login if they follow the link of a comment mention-notifications
2018-10-03 12:58:27 +02:00
John Molakvoæ (skjnldsv) 0c4e27005a Fixed js error
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-03 12:16:16 +02:00
John Molakvoæ (skjnldsv) b9d273bdac Fix sticky header on users list
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-03 12:12:06 +02:00
Roeland Jago Douma 5e143f1f52 Just update password hash without validating
Fixes #11097

If your password hash changed (becuse your are on 7.2 and we moved to
ARGON2). Then we shold not 'set a new password' but just update the
hash. As else we invoke the password policy again which might lock out
users.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-03 12:09:43 +02:00
John Molakvoæ (skjnldsv) 22973fafee Force multiselect max-height to 5.5 items
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-03 12:06:25 +02:00
Joas Schilling cd435ab6b2 Redirect guests to login if they follow the link of a comment mention-notification
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-03 11:55:16 +02:00
John Molakvoæ (skjnldsv) 1f8a34f438 Add new group entry on users list + fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-03 11:38:29 +02:00
Roeland Jago Douma 029aa8e9c0 Merge pull request #11558 from nextcloud/stable14-header-overflow
[stable14] Fix header overflow, fix more apps menu, fix #11552
2018-10-02 23:06:17 +02:00
Morris Jobke 591669a2b4 Merge pull request #11556 from nextcloud/stable14-files-list-width-sharing
[stable14] Reduce the min-width of the files table so it works on sharing pages on mobile
2018-10-02 21:46:13 +02:00
Morris Jobke 540c0017ae Merge pull request #11554 from nextcloud/backport/11111/fix-app-menu-ios
[stable14] Added kinetic scrolling for iOS to apps dropdown menu #10281
2018-10-02 21:45:39 +02:00
Roeland Jago Douma 5d0946aaa5 Merge pull request #11555 from nextcloud/backport/11435/stable14
throw an error if a node is smaller than expected in assemblystream
2018-10-02 21:37:27 +02:00
Jan-Christoph Borchardt 745e27e0cc Fix header overflow, fix more apps menu, fix #11552
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-02 21:13:11 +02:00
Robin Appelman 90fa65900b throw an error if a node is smaller than expected in assemblystream
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-02 20:31:45 +02:00
Jan-Christoph Borchardt 0bad377f4c Reduce the min-width of the files table so it works on sharing pages on mobile
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-02 20:30:57 +02:00
kevin147147 d05b13d3fd Added kinetic scrolling for iOS to apps dropdown menu #10281
this is tested with nc14
2018-10-02 20:26:06 +02:00
Roeland Jago Douma 27323c977f Merge pull request #11530 from nextcloud/stb14-brdcrmb-fx
Fix breadcrumbs
2018-10-02 10:10:58 +02:00
John Molakvoæ (skjnldsv) 720d195043 Fix breadcrumbs
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-02 08:59:35 +02:00
John Molakvoæ 086171918f Merge pull request #11525 from nextcloud/fix/11315/filepicker-buttons-nc14
[14] Fixes the move/copy picker buttons
2018-10-02 07:10:44 +02:00
Michael Weimann 72533658fe Fixes file/folder move/copy buttons
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-10-01 23:16:56 +02:00
Jan-Christoph Borchardt 0f827ea1f4 Fix buttons wrapping on long folder names
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-01 23:16:45 +02:00
Roeland Jago Douma 491db08e42 Merge pull request #11516 from nextcloud/backport/11515/mimteype-list-update
[stable14] Add missing compiled mimetype list
2018-10-01 21:53:40 +02:00
Roeland Jago Douma e7cdacfbf3 Merge pull request #11511 from nextcloud/stable14-share-header
[stable14] Fix share header text on small widths
2018-10-01 17:36:51 +02:00
Roeland Jago Douma 7841c95f3f Merge pull request #11510 from nextcloud/stable14-public-footer
[stable14] Fix public page footer link wrap
2018-10-01 17:36:34 +02:00
Roeland Jago Douma c3a72ba10c Merge pull request #11505 from nextcloud/drone/14/no_branch_wildcard
[Stable14] Drone: do not check stable* but only stable14
2018-10-01 16:43:56 +02:00
Morris Jobke d026c424cd Add missing compiled mimetype list - see #10135
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-01 15:55:17 +02:00
Jan-Christoph Borchardt 687d050d90 Remove non-clickable right margin from 3-dot-menu in share page header
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-01 15:23:58 +02:00
Jan-Christoph Borchardt 1b92ec06b0 Ellipsize long filenames and sharee names in public share page header
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-01 15:23:53 +02:00
Jan-Christoph Borchardt 4e5849058b Fix public page footer link wrap
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-01 14:56:48 +02:00
Morris Jobke 565220adb6 Merge pull request #11492 from nextcloud/backport/11316/container-queryexception-only-14
[stable14] only catch QueryException when trying to build class
2018-10-01 14:21:43 +02:00
Morris Jobke 520eb52b26 Merge pull request #11493 from nextcloud/backport/11416/show-email-authtype-none-14
[stable14] Show auth type "None" in email settings
2018-10-01 12:34:48 +02:00
Roeland Jago Douma 6a9d244541 [Stable14] Drone: do not check stable* but only stable14
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-01 12:24:21 +02:00
Morris Jobke 8096ad5010 Merge pull request #11488 from nextcloud/backport/11047/typo-config-sample
[stable14] Fix typo in config.sample.php
2018-10-01 12:11:21 +02:00
Roeland Jago Douma 7529d43e7e Merge pull request #11490 from nextcloud/stable14-babel-npm-webpack-fixes
[stable14] Update config and babel for ie11
2018-10-01 12:01:40 +02:00
Roeland Jago Douma b7b91ba8b0 Merge pull request #11489 from nextcloud/backport/11123/2fa-button
[stable14] Bugfix 2FA theme: buttons white
2018-10-01 12:01:26 +02:00
Morris Jobke 1636393332 Show auth type "None" in email settings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-01 10:48:53 +02:00
Robin Appelman e46092d7f6 only catch QueryException when trying to build class
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-01 10:44:58 +02:00
EASY f2a5a4d622 Used CSS Variables 2018-10-01 10:25:01 +02:00
John Molakvoæ (skjnldsv) 01b0a74df6 Update config and babel for ie11
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-01 10:25:00 +02:00
EASY d5876fe98a Update theming.scss 2018-10-01 10:24:57 +02:00
Marius Blüm f5851cda80 Fix typo in config.sample.php
Signed-off-by: Marius Blüm <marius@lineone.io>
2018-10-01 10:21:42 +02:00
Morris Jobke 99a705f69f Merge pull request #11451 from nextcloud/stable14_10833
[stable14] Re-enable upload button after updating Avatar
2018-10-01 10:19:07 +02:00
Tobia De Koninck 875d1b08ae Re-enable upload button after updating Avatar fixes #8623
Signed-off-by: Tobia De Koninck <LEDfan@users.noreply.github.com>
2018-09-29 10:39:34 +02:00
Roeland Jago Douma 48b48fad16 Merge pull request #11436 from nextcloud/assemblystream-eof-14
[14] AssemblyStream is also eof if we have no more source stream
2018-09-28 16:56:34 +02:00
Robin Appelman e3dab24a2a AssemblyStream is also eof if we have no more source stream
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-09-28 15:41:25 +02:00
Morris Jobke 3894e59e9c Merge pull request #11418 from nextcloud/stable14-11411-fix-checkWellKnownUrl-not-being-executed
[stable14] Fix "checkWellKnownUrl" not being run
2018-09-28 15:30:32 +02:00
Morris Jobke ae163ee42d Merge pull request #11421 from nextcloud/backport/11262/stable14
[stable14] use a dummy database name for the default postgres database name
2018-09-28 15:30:11 +02:00
Morris Jobke 72abd625b4 Merge pull request #11425 from nextcloud/stable14-hover-quota-used-space-regression
[stable14] Add back the total used space per user
2018-09-28 15:28:22 +02:00
Roeland Jago Douma d29b996072 Merge pull request #11430 from nextcloud/stable14-history-icon-center-fix
[stable14] Center back the history icon
2018-09-28 15:22:21 +02:00
John Molakvoæ (skjnldsv) fccd9c3c09 Cleanup
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-09-28 14:11:29 +02:00
John Molakvoæ (skjnldsv) a8a4d79a14 Center back the history icon
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-09-28 14:11:25 +02:00
Morris Jobke a646dba992 Merge pull request #11426 from nextcloud/stable14-inline-input-error-fix
[stable14] Fix invalid inline input confirm border
2018-09-28 11:32:31 +02:00
John Molakvoæ (skjnldsv) 79f1650e69 Fix invalid inline input confirm border
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-09-28 10:12:50 +02:00
Roeland Jago Douma c12689be8b Merge pull request #11422 from nextcloud/fix/acceptance-apps
Fix acceptance tests as app title changed
2018-09-28 09:16:09 +02:00
John Molakvoæ (skjnldsv) 1e5bcd0496 Add back the total used space per user
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-09-28 09:03:04 +02:00
Roeland Jago Douma 947f3b41be Fix acceptance tests as app title changed
The redundant app was removed. So we need to update the tests to make it
green.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-27 21:58:49 +02:00
Robin Appelman 0d626809f5 use a dummy database name for the default postgres database name
For some reason the docker image does not setup the permissions correctly,
by using a different name the nextcloud installer will create the database instead
with the correct permissions

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-09-27 20:41:40 +02:00
Daniel Calviño Sánchez 79643ab4a2 Fix "checkWellKnownUrl" not being run
The check is run only if its last parameter is true; data() tries to
convert the HTML attribute string to an actual JavaScript value, so
"true" is returned as an actual boolean instead of an string; as a
strict comparison against "true" was used the result was false and thus
the checks were not run.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-27 18:13:57 +02:00
Roeland Jago Douma c2a9899656 Merge pull request #11385 from nextcloud/11372/fix/14-logo-height
[14] Fixes the logo height
2018-09-27 15:41:49 +02:00
Morris Jobke 5d84475e11 Merge pull request #11399 from nextcloud/stable14-11112-do-not-hide-the-progress-bar-while-the-chunked-upload-is-being-assembled
[stable14] Do not hide the progress bar while the chunked upload is being assembled
2018-09-27 14:05:48 +02:00
blizzz 6eab0d0ece Merge pull request #11389 from nextcloud/backport/11383/stable14
[stable14] do not explode when getting permissions from a FailedStorage
2018-09-27 10:51:43 +02:00
blizzz 1b493b783d Merge pull request #11350 from nextcloud/stable14-11258-fix-contacts-menu-on-mentions
[stable14] Fix contacts menu on mentions
2018-09-26 15:30:36 +02:00
Arthur Schiwon 5a20ac9863 do not explode when getting permissions from a FailedStorage
for instance if a user of an external user backend is not available
currently, the whole Files UI would be frozen.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-09-26 13:33:59 +02:00
Michael Weimann 2ece32b028 Fixes the logo height
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-09-26 12:38:48 +02:00
Daniel Calviño Sánchez e82fe088c8 Do not hide the progress bar while the chunked upload is being assembled
Large files are not uploaded in a single operation, but uploaded in
several chunks; once all the chunks are uploaded then the server needs
to assemble them to get the final file.

Before, once the chunks were uploaded the progress bar was hidden.
However, this was confusing for the users, as the file could still need
some time to appear in the file list due to the assembling. Now once all
the chunks are uploaded the text in the progress bar changes to inform
the user that there are still some pending operations, and only when the
file is finally assembled the progress bar is hidden.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-26 12:35:50 +02:00
blizzz 6c4f3ac1d6 Merge pull request #11373 from nextcloud/gs-and-saml-stable14
[stable14] make the server ready to use global scale with SAML as auth back-end
2018-09-26 11:04:54 +02:00
Morris Jobke 7bdf3f1a94 Merge pull request #11374 from nextcloud/stable14-content-list-flex-fixes
[stable14] Fix default flex shrink on list
2018-09-26 10:11:32 +02:00
John Molakvoæ (skjnldsv) 8f9571bc3b Fix default flex shrink on list
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-09-25 14:33:03 +02:00
Bjoern Schiessle 28d60274ce add back-end as parameter to the pre-login hook
This is needed for the Global Scale setup to allow the master
node to perform different operations during login, depending
on the user management. Because in case of SAML, the authentication
at the idp happens at the master node.

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-09-25 14:17:10 +02:00
Joas Schilling d96adc01b7 Merge pull request #11361 from nextcloud/rel-14.0.1
Increase version for 14.0.1
2018-09-25 08:33:42 +02:00
Joas Schilling 884ac1e117 Increase version for 14.0.1
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-09-25 08:19:39 +02:00
Morris Jobke c35401110a Merge pull request #11340 from nextcloud/stable14-add-unit-test-findlanguagefromlocale
[14] Add unit test for findLanguageFromLocale
2018-09-24 12:20:31 +02:00
Daniel Calviño Sánchez c274344160 Fix position of contacts menu shown on mentions
There are no default CSS rules for the contacts menu, as its position
depends on the element on which it is shown. Note, however, that if no
explicit rules are provided the contacts menu on mentions is affected by
the rules for the contacts menu on shares from the sharing tab.

The contacts menu is now positioned to show the tip of the arrow
horizontally aligned with the center of the avatar, and with the top of
the menu slightly below the bottom border of the mention.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-24 09:58:23 +02:00
Daniel Calviño Sánchez d0c3b45f0f Fix contacts menu not triggered on certain areas of a mention
The contacts menu was triggered only when the avatar or the name of the
user were clicked. Due to this, clicking on certain (small) areas of a
mention (like the right end, or the space between the avatar and the
name) did not show the contacts menu. Now the contacts menu is shown
when any area of the mention is clicked.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-24 09:58:23 +02:00
Daniel Kesselberg 62b9ae21fe Add simple unit test for findLanguageFromLocale
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-09-23 23:15:05 +02:00
Joas Schilling 1f714124bb Merge pull request #11259 from nextcloud/fix/11144/backport14
[14] Fixes empty favorite names for trailing slashes
2018-09-20 13:43:24 +02:00
Joas Schilling 4d8f69f7a4 Merge pull request #11173 from nextcloud/update-version-14.0.1
Prepare 14.0.1 release
2018-09-20 12:48:49 +02:00
Joas Schilling e77bd8a894 Prepare 14.0.1 release
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-09-20 10:58:49 +02:00
blizzz ea73f30d77 Merge pull request #11302 from nextcloud/backport/11297/this-database-dude
[stable14] Fix expiration code of tokens
2018-09-20 10:52:15 +02:00
blizzz 0c85cb1ea9 Merge pull request #11077 from nextcloud/stable14-11064-fix-markup-and-style-of-mentions-in-comments
[stable14] Fix markup and style of mentions in comments
2018-09-20 10:37:23 +02:00
blizzz a0f2bd8d28 Merge pull request #11294 from nextcloud/stable14-locale-template-fix
[stable14] Use user locale as default in the template
2018-09-20 10:37:00 +02:00
Joas Schilling e5176960ce Merge pull request #11288 from nextcloud/backport/11171/shared-by-info-for-room-shares-without-names
[stable14] Shared by info for room shares without names
2018-09-20 10:26:18 +02:00
Joas Schilling 9a4ad9cd17 Merge pull request #11287 from nextcloud/backport/11041/get_permission_of_storage_for_shares
[stable14] Get permission of storage for shares
2018-09-20 10:25:34 +02:00
Joas Schilling 2153bcfea8 Merge pull request #11293 from nextcloud/backport/11292/do-not-apcu-cache-the-autoloader
[stable14] Revert "Use APCu caching of composer"
2018-09-20 10:08:02 +02:00
Joas Schilling 6718bfb83d Also adjust the expiration of PublicKeyTokenProvider
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-09-20 10:00:08 +02:00
Joas Schilling 3a179b2519 Copy the expiration from 480864b3e3 to getTokenById
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-09-20 09:59:53 +02:00
blizzz 8dff9460b8 Merge pull request #11291 from nextcloud/stable14-fix-icons-cacher
[stable14] Fix icons cacher regex for compressed output
2018-09-19 22:40:15 +02:00
Michael Weimann 43889d1a49 Fixes empty favorite names for trailing slashes
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-09-19 17:44:54 +02:00
John Molakvoæ (skjnldsv) fcda1f7124 Fix since tag
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-09-19 16:13:26 +02:00
John Molakvoæ (skjnldsv) efbd98183d Fallback to $lang if no $locale match
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-09-19 16:13:22 +02:00
John Molakvoæ (skjnldsv) d69ddd94de Typehint
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-09-19 16:13:19 +02:00
John Molakvoæ (skjnldsv) ccb8838854 Since requirement
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-09-19 16:13:14 +02:00
John Molakvoæ (skjnldsv) 19350c4b95 Fix public l10n
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-09-19 16:13:10 +02:00
John Molakvoæ (skjnldsv) 258330d64d Use user locale as default in the template
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-09-19 16:13:06 +02:00
Joas Schilling c02c63f53a Merge pull request #11282 from nextcloud/backport/11183/fix-link-for-update-notifications
[stable14] Fix the link and anchor for the update notifications
2018-09-19 15:59:25 +02:00
Joas Schilling 86a2d1fecd Revert "Use APCu caching of composer"
This reverts commit 948ab8a4d0.

For details why see https://github.com/nextcloud/server/issues/11290
2018-09-19 15:56:30 +02:00
John Molakvoæ (skjnldsv) e2991d55c7 Fix icons cacher regex for compressed output
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-09-19 15:47:33 +02:00
blizzz bea36f9992 Merge pull request #11283 from nextcloud/stable14-11268-include-empty-directories-in-the-default-state-of-acceptance-tests
[stable14] Include empty directories in the default state of acceptance tests
2018-09-19 15:24:28 +02:00
blizzz 64d8f74c32 Merge pull request #11280 from nextcloud/backport/11080/stable14
[stable14] replace setcookie value with '' instead of null.
2018-09-19 15:18:01 +02:00
blizzz cfca80ef69 Merge pull request #11277 from nextcloud/stable14-11257-prevent-comment-being-composed-from-overlapping-the-submit-button
[stable14] Prevent comment being composed from overlapping the submit button
2018-09-19 15:17:12 +02:00
blizzz 27a3867094 Merge pull request #11276 from nextcloud/stable14-11054-fix-size-of-icons-in-menus-inside-apps-when-shown-as-images
[stable14] Fix size of icons in menus inside apps when shown as images
2018-09-19 15:16:23 +02:00
Joas Schilling 7b3e3ee898 Better shared-by info for conversations without names
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-09-19 13:46:13 +02:00
Roeland Jago Douma 5e13368299 Update test now that we check permissions properly
Now that we actually check thepermissions properly we have to update the
tests.

* We checked an invalid path
* We checked from wrong permissions (files never have CREATE permissions
for example)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-19 13:28:21 +02:00
Roeland Jago Douma b66b2de6ff Properly check share permissions
isCreatable only works on folders
isUpdatable if the file is not there but it is a part file also has to
be checked on the folder

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-19 13:28:13 +02:00
Roeland Jago Douma 43f73ad808 Fix shared cache
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-19 13:28:04 +02:00
Roeland Jago Douma 4cc8cdc276 Check the permission of the underlying storage
Else shares might expose more permissions than the storage actually
providers.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-19 13:27:57 +02:00
Daniel Calviño Sánchez 3a30fa1235 Include empty directories in the default state of acceptance tests
Before each scenario of the acceptance tests is run the Nextcloud server
is reset to a default state. To do this the full directory of the
Nextcloud server is commited to a local Git repository and then reset to
that commit when needed.

Unfortunately, Git does not support including empty directories in a
commit. Due to this, when the default state was restored, it could
happen that the file cache listed an empty directory that did not exist
because it was not properly restored (for example,
"data/appdata_*/css/icons"), and that in turn could lead to an error
when the directory was used.

Currently the only way to force Git to include an empty directory is to
add a dummy file to the directory (so it will no longer be empty,
but that should not be a problem in the affected directories, even if
the dummy file is not included in the file cache); although Git FAQ
suggests using a ".gitignore" file a ".keep" file was used instead, as
it conveys better its purpose.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-19 12:50:32 +02:00
Joas Schilling d50fa1bdb8 Fix the link and anchor for the update notifications
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-09-19 12:12:13 +02:00
MartB fbc1f5cd38 replace setcookie value with '' instead of null.
The php documentation states that an empty string should be used for a cookie when it has no real value.
null leads to the following error: expects parameter 2 to be string, null given

Signed-off-by: Martin Böh <mart.b@outlook.de>
2018-09-19 11:47:40 +02:00
Daniel Calviño Sánchez 896c8df6ad Prevent comment being composed from overlapping the submit button
The submit button is placed in the text area using absolute positioning,
so it is not taken into account when calculating the text layout. Due to
this it is necessary to add an explicit padding to the right of the text
area to prevent the text from overlapping the submit button.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-19 08:51:42 +02:00
Daniel Calviño Sánchez a9fa17eb7e Fix size of icons in menus inside apps when shown as images
Some popover menus, like the contacts menu, still show their icon using
an img element. The main CSS rules assume that a "content-box" sizing is
being used, and thus set the size and padding of the image to add up to
the line height.

However, ".app-*" descendants use a "border-box" sizing, so when a menu
with an image was shown in an app the icon was not properly shown. Now
both the width and height of the image is set to the item height in
those cases, which causes the visible size of the icon to be the item
height minus the padding (the same as when "content-box" sizing is
used).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-19 08:46:53 +02:00
Joas Schilling fb9379db3e Merge pull request #11237 from nextcloud/backport/11042/stable14
[stable14] Remove filter_var flags due to PHP 7.3 deprecation, fixes #10894
2018-09-17 10:10:54 +02:00
Patrik Kernstock 5058333445 Remove filter_var flags due to PHP 7.3 deprecation, fixes #10894
Signed-off-by: Patrik Kernstock <info@pkern.at>
2018-09-16 04:45:15 +02:00
Joas Schilling 5bf377463e Merge pull request #11201 from nextcloud/backport/11036/stable14
[stable14]  fix check for more users in sharing dialogue
2018-09-13 11:21:08 +02:00
blizzz 2823d7a6f5 Merge pull request #11191 from nextcloud/backport/11091-cannot-read-passwd
[14] Remove posix_getpwuid and compare only userid
2018-09-13 10:32:29 +02:00
Arthur Schiwon 72588b69bb Backport of #11036 to stable14
fix check for more users

after a refactor users et al were undefined. The check condition was moved.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

don't user a higher paging size than max autocomplete entries are set

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

adjust and extend js unit tests

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-09-13 10:20:55 +02:00
Daniel Kesselberg 843df1c009 Add int-typehint
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-09-12 15:08:30 +02:00
Daniel Kesselberg 53ecdfec51 Remove posix_getpwuid and compare only userid
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-09-12 15:08:19 +02:00
blizzz 4165f332de Merge pull request #11187 from nextcloud/backport/11133/invalid-exception
[stable14] Fix exception class
2018-09-12 13:21:50 +02:00
blizzz 8e3e25a057 Merge pull request #11186 from nextcloud/backport/11181/user-list-broken-with-integer-only-users
[stable14] Fix user and group listing with users that have an integer user id
2018-09-12 13:17:13 +02:00
Joas Schilling 2518cdd2d9 Fix exception class
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-09-12 11:57:43 +02:00
Joas Schilling 73e870bd78 Fix user and group listing with users that have an integer user id
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-09-12 11:54:22 +02:00
John Molakvoæ 5209348c64 Merge pull request #11152 from nextcloud/davclient-js-decode-14
[14] fix js files client for user names with spaces
2018-09-11 10:46:12 +02:00
Robin Appelman 9b64c27ce2 fix js files client for user names with spaces
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-09-10 22:39:06 +02:00
Roeland Jago Douma e296f7d348 Merge pull request #11090 from nextcloud/backport/11082/stable14
[stable14] Do not invalidate main token on OAuth
2018-09-07 13:59:45 +02:00
Roeland Jago Douma 5b89eff367 Merge pull request #11103 from nextcloud/backport/token_expire_hardening
[stable14] Expire tokens hardening
2018-09-07 13:59:10 +02:00
Roeland Jago Douma b580ef18c8 Merge pull request #11039 from nextcloud/backport/fix/10968/upload-progress
Fixes the upload progress bar layout - 14 backport
2018-09-07 13:58:58 +02:00
Roeland Jago Douma c83ac2472d Expire tokens hardening
Just to be sure that the field is also not 0

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-07 10:02:56 +02:00
Roeland Jago Douma 54859329ef Do not invalidate main token on OAuth
Fixes #10584

We deleted the main token when using the login flow else mutliple tokens
would show up for a single user.

However in the case of OAuth this is perfectly fine as the
authentication happens really in your browser:

1. You are already logged in, no need to log you out
2. You are not logged in yet, but since you log in into the exact same
browser the expected behavior is to stay logged in.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-06 13:28:48 +02:00
Roeland Jago Douma 1b35dc1cba Merge pull request #11069 from nextcloud/release/14.0.0
14.0.0 final
2018-09-06 09:25:18 +02:00
Roeland Jago Douma b619e8ddde 14.0.0 final
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-06 08:35:10 +02:00
Daniel Calviño Sánchez 51b978d3f0 Add new line at the end of file
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Daniel Calviño Sánchez 2e424d84a4 Ensure that the avatar and the user name will be kept together
Otherwise a line break could be added between the avatar and the user
name when the wrapper is close to the right border of the message.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Daniel Calviño Sánchez e7d4d3a34b Remove unneeded CSS rule for mentions
Most of the properties of the rule are not needed for mentions, so the
rule is no longer applied to them; the only needed property was moved to
the main rule for mentions.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Daniel Calviño Sánchez 7c851b5b77 Fix pointer cursor not shown on avatars
When the cursor is on an avatar wrapper the cursor is shown as a pointer
to inform the user that it can be clicked (which will either show the
contacts menu or insert a mention, depending on the case); the cursor
must be explicitly defined for the "img" element that shows the avatar
too, or otherwise the default cursor would be shown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Daniel Calviño Sánchez b14425ef6f Highlight mentions to the current user
Like done in Talk, mentions to the current user are now shown with the
primary colors to make them more prominent.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Daniel Calviño Sánchez 3c63850117 Ensure that the user name is shown in bold in mentions
Different browsers use different font weights for strong elements
(Chromium uses "bold", but Firefox uses "bolder", which is relative to
the font weight of the parent), so now the user name in mentions is
explicitly shown with a bold weight.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Daniel Calviño Sánchez 6b7e049288 Reformat embedded HTML code to resemble HTML code
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Daniel Calviño Sánchez 3ee07ac770 Remove space between avatar and user name
The avatar should be shown immediately after the avatar to be able to
accurately define the space between them using only CSS rules.

Note that in the case of the "atwho" menu it is not really needed, as a
whitespace removal seems to be done automatically by the plugin, but it
was modified for its displayed elements too for consistency.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Daniel Calviño Sánchez da75c7ff6d Show avatar using "span" instead of "div"
Visually it makes no difference, but as the ".avatar" element is inside
a "span" element it can not be a block element to be compliant with the
HTML specification.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Georg Ehrke 4173f9d588 Merge pull request #11071 from nextcloud/bugfix-stable14/10727
[stable14] remove LogicException, because it's also triggered with legitimate pa…
2018-09-05 18:08:55 +02:00
Georg Ehrke 2bdc407a82 remove LogicException, because it's also triggered with legitimate parameters
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-09-05 14:12:27 +02:00
Roeland Jago Douma b08f67085d Merge pull request #11052 from nextcloud/backport/10963/stable14
[stable14] Updates logo scss to regard default values
2018-09-05 10:30:29 +02:00
Michael Weimann b0d9030388 Updates logo scss to regard default values
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-09-04 21:27:45 +02:00
Michael Weimann 209b3bee68 Fixes the upload progress bar layout
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-09-03 21:13:28 +02:00
Morris Jobke c31632ccdf Merge pull request #10861 from nextcloud/version/noid/14.0.0RC2
14.0.0 RC 2
2018-08-31 15:09:46 +02:00
Morris Jobke 9cc6634776 14.0.0 RC 2
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-08-31 14:44:50 +02:00
Morris Jobke 7159ac1233 Merge pull request #10943 from nextcloud/fix/2fa-provider-dao-concurrent-insert
Fix handlng of concurrent inserts of the 2FA provider registry DAO
2018-08-31 14:42:55 +02:00
Roeland Jago Douma 3693d9568e Merge pull request #10944 from nextcloud/content-list-overflow-fix
Fix overflow x scroll on app content list
2018-08-31 14:19:06 +02:00
Morris Jobke f4ffa1737e Merge pull request #10942 from nextcloud/feature/10776/longer-password-reset-time
Change password expiration time from 12h to 7d
2018-08-31 14:13:14 +02:00
Morris Jobke cf3f4888cc Change password expiration time from 12h to 7d
We use the same logic for creating accounts without a password and there the 12h is a bit short. Users don't expect that the signup link needs to be clicked within 12h - 7d should be a more expected behavior.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-08-31 13:31:03 +02:00
Christoph Wurst fb98db7da7 Fix handlng of concurrent inserts of the 2FA provider registry DAO
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-31 11:46:27 +02:00
John Molakvoæ (skjnldsv) 27f14cf91b Fix overflow x scroll on app content list
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-31 09:17:54 +02:00
Nextcloud bot 2a22615879 [tx-robot] updated from transifex 2018-08-31 00:12:09 +00:00
Morris Jobke 1ddde36e93 Merge pull request #10939 from nextcloud/bugfix/10930/perm-checker-wrong-path
Fix path when app has wrong permission
2018-08-30 21:43:25 +02:00
Morris Jobke 8ea2f8dea4 Merge pull request #10910 from nextcloud/customproperties-ignored-list
use the same ignored properties list for both CustomerPropertiesBackends
2018-08-30 21:23:36 +02:00
Roeland Jago Douma 625c81bd11 Merge pull request #10906 from nextcloud/request-params-array
ensure we always return an array from `Request::getParams`
2018-08-30 21:07:49 +02:00
Morris Jobke f393cb71ce Merge pull request #10936 from nextcloud/make-possible-to-pick-both-files-and-folders
Make possible to pick both files and folders
2018-08-30 21:03:25 +02:00
Morris Jobke df7dc9c4ab Merge pull request #10925 from nextcloud/use-main-text-color-for-editable-divs-and-text-areas
Use main text color for editable divs and text areas
2018-08-30 20:59:47 +02:00
Daniel Kesselberg a6bb19fa11 Fix path when app has wrong permission
Replace slow array function used in loop: https://github.com/kalessil/phpinspectionsea/blob/master/docs/performance.md#slow-array-function-used-in-loop

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-08-30 20:52:43 +02:00
Morris Jobke ab9672a32f Merge pull request #10913 from nextcloud/do-not-parse-html-in-user-id-and-display-name
Do not parse HTML in user id and display name
2018-08-30 20:52:20 +02:00
Julius Härtl 25857c4900 Merge pull request #10924 from nextcloud/bugfix/10901/theming-bugfix-primary
Fix SCSS variable management with the theming app
2018-08-30 17:35:40 +02:00
Julius Härtl cdc4eee278 Merge pull request #10853 from nextcloud/apps-menu-fix-mobile
Fix apps menu on mobile
2018-08-30 14:51:09 +02:00
Julius Härtl a791bdb3ab Fix capabilities test
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-30 14:45:06 +02:00
Daniel Calviño Sánchez c14c6e5ccf Make possible to pick both files and folders
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-30 14:40:12 +02:00
Daniel Calviño Sánchez f080fa55ac Store the mime type filter always as an array
This will make easier to check if both directories and files should be
pickable.

This also removes an unused assignment to the mime type.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-30 14:23:47 +02:00
Daniel Calviño Sánchez 66f2b155ce Fix empty mime type filter
When the mime type is an empty array no filter should be applied.
However, the filter was loosely compared to an empty array, but as
arrays are objects then it became an implicit strict equality comparison
which always failed due to being different objects. Now the length of
the array is compared instead, and also moved outside the loop as it is
not needed to check it for each file.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-30 14:02:50 +02:00
Julius Härtl 5bae5bf3eb Make the default element color for bright theming colors lighter
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-30 10:37:05 +02:00
Daniel Calviño Sánchez 4508a12188 Prevent default action from being executed when the button is disabled
When "enter" is pressed in the file picker a "click" event is triggered
on the primary action button. However, in some cases, like when the file
picker is in "Choose" mode and the current directory in the file picker
is the root folder, the primary action button is disabled. In those
cases pressing enter should not trigger a click action on the button and
be ignored instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-30 10:25:09 +02:00
Nextcloud bot 4da9a15b32 [tx-robot] updated from transifex 2018-08-30 00:12:07 +00:00
Daniel Calviño Sánchez 13e749190e Use main text color for editable divs and text areas
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-29 17:37:46 +02:00
Julius Härtl 3a62890a13 Merge pull request #10876 from nextcloud/bugfix/10873/theming-settingsbutton
Theming: apply proper size to the remove background button
2018-08-29 17:24:05 +02:00
Julius Härtl 2bdc3b1d27 Remove border from primary button when color is bright
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-29 16:47:39 +02:00
Julius Härtl e8938df198 Move SCSS variable fetching before the variables.scss to properly calculate color values
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-29 16:47:39 +02:00
Nextcloud bot 27141a960f [tx-robot] updated from transifex 2018-08-29 00:12:07 +00:00
Joas Schilling 5ba881ba41 Do not parse HTML in user id and display name
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-28 18:57:07 +02:00
Robin Appelman 3806ecb242 use the same ignored properties list for both CustomerPropertiesBackends
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-28 18:27:53 +02:00
Robin Appelman c0a283fefb ensure we always return an array from Request::getParams
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-28 18:11:42 +02:00
Morris Jobke c6b1c21b8f Merge pull request #10854 from nextcloud/fix-10764
Allow same section class for multiple section types (fix #10764)
2018-08-28 17:50:20 +02:00
Morris Jobke e9dd6aec61 Merge pull request #10871 from cviereck/patch-1
cast timestamps older than unix epoch to 0
2018-08-28 16:52:20 +02:00
John Molakvoæ (skjnldsv) 10d51c3440 Fix apps menu and typo
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-28 13:48:06 +02:00
John Molakvoæ 90581a44c0 Merge pull request #10892 from nextcloud/fix-drag-shadow-in-files-app
Fix drag shadow in Files app
2018-08-28 13:13:52 +02:00
John Molakvoæ a3d61b49b8 Merge pull request #10881 from nextcloud/fix/10705/notification-width
Makes the notifications area width equal to the contents
2018-08-28 13:08:09 +02:00
Julius Härtl a14fddc2d5 Merge pull request #10875 from nextcloud/bugfix/10024/theming-footer-link
Theming: Only link Entity in footer if a url is set
2018-08-28 13:01:20 +02:00
Nextcloud bot a768550177 [tx-robot] updated from transifex 2018-08-28 00:13:06 +00:00
Daniel Calviño Sánchez c3610d1d17 Remove limit on "max-width" for file names in drag shadow
The general file list sets "max-width: 0" in the file names, which
causes the file names in the drag shadow to have no width for their
content and thus to overlap with the file size.

As that limit is needed for proper layout in the general file list it is
removed only for file names in drag shadows.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-27 18:12:50 +02:00
Daniel Calviño Sánchez 8824af324d Increase z-index of drag shadow for files
The drag shadow is a sibling of "#content" so its z-index must be higher
than the z-index of the content children (navigation bar, app content
and app sidebar) to appear in front of them.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-27 18:08:45 +02:00
Michael Weimann a958ddf01a Makes the notifications area width equal to the contents
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-27 15:29:08 +02:00
Julius Härtl c4f34ccc4c Theming: Fix footer tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-27 15:22:49 +02:00
Julius Härtl 5175e33e31 Theming: Only Entity in footer if a url is set
fixes #10024

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-27 13:59:16 +02:00
Julius Härtl e94c2bbb3b Theming: apply proper size to the remove background button
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-27 12:35:02 +02:00
Joas Schilling 148e9cacb0 Merge pull request #10867 from nextcloud/bugfix/noid/a11y
Use empty alt tag for avatars since there is always the name next to it
2018-08-27 11:16:28 +02:00
Christian e2a64c713f cast timestamps older than unix epoch to 0
This change solves issues #10870, which is caused by method castValue of class FileSearchBackend: It casts the timestamps older than the unix epoch to false., see my comment https://github.com/nextcloud/server/pull/10835#discussion_r212806153.
2018-08-27 07:44:24 +02:00
Nextcloud bot 8b47f45afa [tx-robot] updated from transifex 2018-08-27 00:12:14 +00:00
Roeland Jago Douma de24be2464 Merge pull request #10858 from nextcloud/public-logo-fixes
Fix public pages conflicting
2018-08-26 21:34:08 +02:00
Joas Schilling 3177714574 Make the color important
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-26 19:12:57 +02:00
Joas Schilling 1edf345d4d Use empty alt tag for avatars since there is always the name next to it
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-26 18:29:02 +02:00
John Molakvoæ 2ea820cd6e Merge pull request #10856 from nextcloud/bugfix/noid/comments-contactsmenu
Fix contactsmenu for mentioned users in comments
2018-08-26 14:32:45 +02:00
John Molakvoæ (skjnldsv) 00351adbd9 Fix public pages conflicting
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-26 10:33:26 +02:00
Roeland Jago Douma 40bbf6d548 Merge pull request #10855 from nextcloud/stefan-niedermann-patch-1
Add "Join the Team" section to README.md
2018-08-26 10:32:16 +02:00
Nextcloud bot d8147cbba7 [tx-robot] updated from transifex 2018-08-26 00:12:33 +00:00
Julius Härtl e312766783 Fix contactsmenu for mentioned users in comments
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-25 18:25:47 +02:00
Niedermann IT-Dienstleistungen 153ab96d91 Add "Join the Team" section to README.md
Written at the Nextcloud Conf workshop
2018-08-25 17:51:20 +02:00
sualko 61370549f3 Allow same section class for multiple section types (fix #10764)
Signed-off-by: Klaus Herberth <klaus@jsxc.org>
2018-08-25 17:32:19 +02:00
Morris Jobke ce87537b81 Merge pull request #10846 from nextcloud/bugfix/noid/add-the-new-share-type-to-the-app-info-xsd
Add the new share type
2018-08-25 15:41:53 +02:00
John Molakvoæ (skjnldsv) f47b59ac7a Fix apps menu on mobile
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-25 15:12:08 +02:00
Nextcloud bot d644cafae7 [tx-robot] updated from transifex 2018-08-25 00:12:33 +00:00
Joas Schilling d7246edc94 Add the new share type
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-24 23:08:17 +02:00
Morris Jobke 9823c71971 Merge pull request #10844 from nextcloud/version/noid/14.0.0RC1
14.0.0 RC 1
2018-08-24 22:51:45 +02:00
Morris Jobke 0c5d42488f 14.0.0 RC 1
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-08-24 22:25:22 +02:00
Morris Jobke 8761856a71 Merge pull request #10838 from nextcloud/header-fixes-and-public-note
Header fixes and public note
2018-08-24 22:21:55 +02:00
John Molakvoæ (skjnldsv) 13230f180a Fix jsunit
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 22:05:48 +02:00
Roeland Jago Douma ac932309a2 Merge pull request #10827 from steiny2k/HEICHEIF
HEIC previews as JPG rather than PNGs to save space.
2018-08-24 21:49:33 +02:00
Morris Jobke c850b3ac20 Merge pull request #10820 from nextcloud/fix/noid/emptydefaultprefix
[LDAP] The WebUI Wizard also should not assign empty config IDs
2018-08-24 21:37:00 +02:00
Roeland Jago Douma 4758942121 Fixes
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-24 21:27:21 +02:00
Roeland Jago Douma ede9e38be7 Merge pull request #10834 from nextcloud/add-support-for-room-shares
Add support for room shares
2018-08-24 21:15:54 +02:00
Morris Jobke 29f215a90d Merge pull request #10835 from nextcloud/dav-search-no-negative-mtime
disallow negative mtime in dav search
2018-08-24 20:32:26 +02:00
John Molakvoæ (skjnldsv) 719f9288b9 Tests fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 20:31:29 +02:00
Morris Jobke b1410df18e Merge pull request #10803 from nextcloud/smb-dir-instead-of-allinfo
prefer using dir instead of allinfo for getting smb file info
2018-08-24 19:30:30 +02:00
Morris Jobke 48f5cbe439 Merge pull request #10841 from nextcloud/load-app-catch-exceptions
also catch exceptions when loading apps
2018-08-24 19:29:47 +02:00
Roeland Jago Douma 79a88ed458 Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-24 18:20:04 +02:00
Daniel Calviño Sánchez 7ce520e83e Add support for rooms in the list of candidates to share with UI
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-24 18:06:48 +02:00
Daniel Calviño Sánchez 5c07f9c2ec Add rooms in the default candidate types to look for when sharing
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-24 18:06:46 +02:00
Morris Jobke 7bc9b9a76e Merge pull request #10773 from nextcloud/collapsible-dark-fix
Accessibility theme fixes
2018-08-24 17:56:00 +02:00
John Molakvoæ (skjnldsv) 03b112c486 Merge branch 'header-fixes-and-public-note' of https://github.com/nextcloud/server into header-fixes-and-public-note
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 17:41:07 +02:00
John Molakvoæ (skjnldsv) 421daf6ab0 Fix public share link order
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 17:40:05 +02:00
Robin Appelman 4ff1d287d2 fix missing import
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-24 17:34:36 +02:00
Julius Härtl fb40627c8c Fix header logo padding
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-24 17:32:31 +02:00
Morris Jobke d8e876c0da Merge pull request #10828 from nextcloud/bugfix/fac-108/mimetype-detection-broken-for-junked-uploads
Fix mimetype detection for junked uploads
2018-08-24 17:22:56 +02:00
Robin Appelman be9ab8b879 also catch exceptions when loading apps
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-24 17:16:54 +02:00
Morris Jobke e8817ed3ea Merge pull request #10724 from nextcloud/large-share-count-performance
Improve performance when dealing with large numbers of shares
2018-08-24 17:10:17 +02:00
John Molakvoæ (skjnldsv) ddd18aa375 Fix public link order and fix skip to content
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 16:54:01 +02:00
John Molakvoæ (skjnldsv) ac2c925231 Fix mobile view and add public share note view
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 16:45:40 +02:00
Morris Jobke 6099786c8d Merge pull request #10670 from nextcloud/fix/login-throttle-username-length
Fix max length requirements for the throttler metadata
2018-08-24 16:25:35 +02:00
Robin Appelman b76e6be441 disallow negative mtime in dav search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-24 16:20:07 +02:00
John Molakvoæ (skjnldsv) 3cb52b868a Fix header calculation and better public design
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 15:45:39 +02:00
Denis Mosolov a0b84bc0fc Merge pull request #10334 from denismosolov/group-add
Add options to create/remove groups via occ
2018-08-24 13:46:16 +03:00
Joas Schilling c574212422 Fix mimetype detection for junked uploads
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-24 10:42:59 +02:00
Sebastian Steinmetz ed15a6f2a2 HEIC previews as JPG rather than PNGs to save space.
Signed-off-by: Sebastian Steinmetz <me@sebastiansteinmetz.ch>
2018-08-24 08:58:28 +02:00
Morris Jobke 8563ab94aa Merge pull request #10589 from nextcloud/smb-stat-retry
retry smb stat on timeout
2018-08-24 07:00:40 +02:00
Morris Jobke d1daf65b78 Merge pull request #10801 from nextcloud/documentation/10526/add-sample-config-for-heic
Add sample config for HEIC image previews
2018-08-24 06:59:44 +02:00
Nextcloud bot 503fbc953e [tx-robot] updated from transifex 2018-08-24 00:12:20 +00:00
Arthur Schiwon 7807add02d [LDAP] The WebUI Wizard also should not assign empty config IDs
With 689df9a843 the behaviour to assign only
non-empty config IDs was introduced. Only, this was only effective for CLI
and OCS API.

Related to #3270.

The web UI creates now also a full configuration on first load. This fixes
#5094.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-23 17:58:35 +02:00
Robin Appelman bf7fb2b0a2 assume the same timezone when using local domain names for smb
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-23 16:09:33 +02:00
Robin Appelman 50463e2d13 improved fallback of timezone detection
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-23 16:09:33 +02:00
Morris Jobke 162b16b505 Merge pull request #10822 from nextcloud/feature/noid/show-link-to-simple-sign-up
Show link to simple sign up page
2018-08-23 15:31:51 +02:00
Morris Jobke 2219d35207 Merge pull request #10815 from nextcloud/fix/noid/missingreturnval
returning of $tr is expected, otherwise ending up in a JS error
2018-08-23 14:53:00 +02:00
Morris Jobke ad5093b7a6 Show link to simple sign up page
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-08-23 14:41:19 +02:00
Nextcloud bot c0f48a7b40 [tx-robot] updated from transifex 2018-08-23 00:12:59 +00:00
Arthur Schiwon 78f61b2ade returning of $tr is expected, otherwise ending up in a JS error
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-23 00:28:03 +02:00
John Molakvoæ 04a744742a Merge pull request #10787 from nextcloud/fix/10786/click-the-last-app
Fixes the app menu
2018-08-22 16:11:15 +02:00
Robin Appelman c1389070fa use dir instead of allinfo where possible 2018-08-22 14:16:33 +02:00
Morris Jobke b98e0d3bda Add sample config for HEIC image previews
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-08-22 13:44:05 +02:00
Morris Jobke bb2336f389 Merge pull request #10526 from steiny2k/HEICHEIF
Support HEIC for previews
2018-08-22 13:41:19 +02:00
Morris Jobke e27817aeda Merge pull request #10789 from nextcloud/fix/2fa-app-multiple-providers
Fix loading providers of 2FA app with more than one provider
2018-08-22 10:50:22 +02:00
Morris Jobke 3dc31e4231 Merge pull request #10780 from danielkesselberg/bugfix/7654/apply-patch-for-sabre-dav
[3rdparty] Apply upstream patch #1025 for sabre-dav
2018-08-22 10:49:27 +02:00
John Molakvoæ (skjnldsv) ba66cad1b4 Fix keyboard menu element event detection
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-22 09:54:40 +02:00
Nextcloud bot 65410ab1cb [tx-robot] updated from transifex 2018-08-22 00:12:11 +00:00
Christoph Wurst 024a70a188 Fix loading providers of 2FA app with more than one provider
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-21 22:53:38 +02:00
Michael Weimann e0f29cadaf Fixes the app menu
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-21 21:47:04 +02:00
blizzz 1a7516dd93 Merge pull request #10775 from nextcloud/fix/10431/ldap-groups
Resolve all group memberships properly
2018-08-21 17:05:12 +02:00
Daniel Kesselberg dfed516316 Apply patch for sabre dav
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-08-21 15:09:58 +02:00
Morris Jobke eba447987c Merge pull request #10771 from nextcloud/fix/10766/backup-codes-column-length-argon
Fix backup codes column length for Argon2 values
2018-08-21 11:08:46 +02:00
Morris Jobke 04d6cefaa1 raise version to trigger migration
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-08-21 11:08:14 +02:00
Morris Jobke 3d8f174774 Resolve all group memberships properly
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-08-21 10:57:50 +02:00
Morris Jobke 383699398f Merge pull request #10539 from nextcloud/feature-8642-memory-check
Adds a setup and cli check for the recommended memory limit
2018-08-21 09:51:33 +02:00
Morris Jobke 20839a422b Refactor some code
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-08-21 09:51:05 +02:00
Christoph Wurst 2f34df4982 Fix integration test execution on Dron
Apparently the Nextcloud server ignores tests that have `Integration` in their
fully-qualified class name, hence the backup codes integration tests were removed.
This moves them up one directory (out of `Integration`) to fix that.
Real unit tests remain in the `Unit` directory.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-21 09:09:15 +02:00
Morris Jobke bac545e754 Merge pull request #10772 from nextcloud/fix/generated-migration-code-since
Fix generated migration class code
2018-08-21 08:31:37 +02:00
Morris Jobke 6ad0ba0448 Merge pull request #10710 from nextcloud/fix/iusermanager-createuser-typo
Fix typo in IUserManager::createUser doc
2018-08-21 08:13:54 +02:00
Christoph Wurst eada4cccfc Fix generated migration class code
The `@since` documentation is out of place here.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-21 07:50:12 +02:00
Christoph Wurst 82748a482e Fix backup codes column length to fix Argon2 hash values
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-21 06:53:37 +02:00
Christoph Wurst 42035cab9d Add an integration test that inserts long back codes values
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-21 06:49:26 +02:00
Nextcloud bot be3438ca97 [tx-robot] updated from transifex 2018-08-21 00:12:16 +00:00
John Molakvoæ (skjnldsv) 2e57324629 Update contrast theme to better readability on icons and files action
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-20 22:12:55 +02:00
John Molakvoæ (skjnldsv) 14a099d648 Move collapsible triangle to svg api
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-20 22:06:27 +02:00
Michael Weimann 2bab916c53 Adds license to files. Updates the branch.
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 20:46:23 +02:00
Morris Jobke 6d749bf021 Merge pull request #10700 from nextcloud/fix/10516/sharepermissions
Fix share dialog sidebar in share views
2018-08-20 17:14:12 +02:00
Morris Jobke a6fb5c5dba Merge pull request #10663 from nextcloud/dependabot/composer/build/integration/behat/behat-approx-3.5.0
Update behat/behat requirement from ~3.3.0 to ~3.5.0 in /build/integration
2018-08-20 17:09:04 +02:00
Morris Jobke 37869d9b2f Merge pull request #10628 from nextcloud/feature/10154/app-directory-permission-check
Adds a permission check for app directories
2018-08-20 17:08:18 +02:00
Roeland Jago Douma ce1e213760 Bump autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-20 15:25:07 +02:00
Michael Weimann 7aed47f776 Adds tests for the memory checks
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 15:24:10 +02:00
Michael Weimann c164409ee7 Adds a memory limit warning for console commands if the limit is below the recommended value
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 15:24:10 +02:00
Michael Weimann 1d2bc9c45e Adds tests for the setup memory limit checks
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 15:24:10 +02:00
Michael Weimann c2fced4463 Adds a setup check for the memory limit
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 15:24:10 +02:00
John Molakvoæ 080572993e Merge pull request #10723 from nextcloud/fix/10722/10716/header-fixes
Fixes more apps menu and settings/user menu positions
2018-08-20 15:22:48 +02:00
Julius Härtl 6e10358e5d Merge pull request #10747 from nextcloud/fix/10745/sticky-safari
Adds a vendor prefix for position sticky
2018-08-20 15:11:55 +02:00
blizzz 1b1c8b3e76 Merge pull request #10738 from nextcloud/fix/10669/store-sorting-only-for-loggedin-users
Only send an update sort order request if there is an user
2018-08-20 14:54:50 +02:00
Morris Jobke 1c13e78633 Merge pull request #10697 from nextcloud/smb-log-removed-entries
log entries that are hidden during file listing
2018-08-20 14:48:48 +02:00
Morris Jobke 9cf11bd73c Merge pull request #10687 from nextcloud/fix/noid/false-positive-change-mention
don't blame randome people for background email updates
2018-08-20 14:37:41 +02:00
Morris Jobke e33670ebcd Merge pull request #10755 from nextcloud/documentation/noid/fix-comments-in-config-sample
Fix comment style in config sample
2018-08-20 14:05:58 +02:00
blizzz 4b92a0986c Merge pull request #10712 from nextcloud/fix/noid/check_if_provider_is_available_before_use
Check if a preview provider is available before using it
2018-08-20 13:21:16 +02:00
Morris Jobke 260ef64946 Fix comment style in config sample
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-08-20 11:21:23 +02:00
Morris Jobke c260e4403d Merge pull request #10744 from nextcloud/update-help-php
Update help.php
2018-08-20 09:15:49 +02:00
Nextcloud bot 1958a710d8 [tx-robot] updated from transifex 2018-08-20 00:12:26 +00:00
Michael Weimann 18b677ee02 Adds a vendor prefix for position sticky
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-19 12:02:27 +02:00
Roeland Jago Douma 4b71df7b15 Merge pull request #10734 from ReekyMarko/master
Fixed a typo
2018-08-19 11:25:26 +02:00
Marius Blüm 214c950d42 Update help.php
Signed-off-by: Marius Blüm <marius@lineone.io>
2018-08-18 18:47:56 +02:00
Roeland Jago Douma 4c138b2042 Recompile settings
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-18 13:35:46 +02:00
Julius Härtl de119eefd6 Merge pull request #10707 from nextcloud/dark-theme-fixes
Fix public pages background
2018-08-18 11:41:39 +02:00
Nextcloud bot 82854b5042 [tx-robot] updated from transifex 2018-08-18 00:12:35 +00:00
Roeland Jago Douma 5b103744c8 Check if a preview provider is available before using it
Else if a preview provider is registerd but not available (for example
missing support in some external lib). It will do 💥. This way the
providers can at least do the sanity checks required.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-17 20:51:35 +02:00
Michael Weimann 2de34d7778 Improves the tests
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-17 20:35:23 +02:00
Michael Weimann 887737f706 Stores the sorting only if there is an user
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-17 20:09:11 +02:00
Michael Weimann f18fc851c0 Adds a test to check that the sorting isn't stored without an user
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-17 20:08:57 +02:00
Michael Weimann 36dfaf097a Removes doubled styles
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-17 18:44:40 +02:00
Sebastian Steinmetz 5a996b5f87 Address comments from @rullzer:
- implement isAvailable
 - run tests only if ImageMagick with HEIC support is available in the
   environment

Signed-off-by: Sebastian Steinmetz <me@sebastiansteinmetz.ch>
2018-08-17 18:37:23 +02:00
Michael Weimann 3bcc0e0ff6 Header style tweaks
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-17 18:26:58 +02:00
Marko Korhonen f081553ba1 Fixed a typo 2018-08-17 17:23:10 +03:00
Björn Schießle 20aa21c908 Merge pull request #10731 from nextcloud/update-bundles
add deck and mail to the groupware bundle, remove talk
2018-08-17 15:08:29 +02:00
Bjoern Schiessle 325e8bea16 add deck and mail to the groupware bundle, remove talk
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-08-17 13:27:48 +02:00
Björn Schießle 3a44cce5cc Merge pull request #10718 from nextcloud/occ-recover-encryption
add occ command to recover encrypted files in case of password lost
2018-08-17 10:07:16 +02:00
Arthur Schiwon be873c234b adapt jsunit test
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-16 23:08:15 +02:00
Robin Appelman 67f3d6f0a6 cache parent exists status during share setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 21:28:01 +02:00
Robin Appelman 4c0cbdff36 tokens can't be valid local user names
this saves searching for shares on non-public link dav requests

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 21:27:57 +02:00
Robin Appelman 720b27d60b only determine is sharing is disabled for a user once
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 21:27:54 +02:00
Robin Appelman b5217b6f63 don't check if target dir exists when using the default share target directory
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 21:27:51 +02:00
Robin Appelman b79f338e71 re-use view instances for shared storages
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 21:27:48 +02:00
Robin Appelman bc4f10ad83 more efficient way to detect added and removed mounts
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 21:27:45 +02:00
Robin Appelman c300516e51 more efficient way to detect added and removed mounts
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 19:56:49 +02:00
Robin Appelman 3155c1bd9a more efficient unique share target generation
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 19:54:42 +02:00
Michael Weimann ccb8f7dff6 Fixes some header style issues
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-16 19:02:56 +02:00
Robin Appelman f7ae235372 cache OC\Files\Mount\Manager::findIn results
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 19:02:00 +02:00
Robin Appelman f8116ad4cf use more efficient method to find mountpoint for path
this changes the complexity from the number of mounts to the depth of
the path

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 18:55:52 +02:00
Robin Appelman 95981810c0 remove double loop for detecting changed mounts
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 18:24:56 +02:00
Bjoern Schiessle 3adc2aca53 add occ command to recover encrypted files in case of password lost
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-08-16 15:51:01 +02:00
Roeland Jago Douma bcc1a53f05 Merge pull request #10715 from nextcloud/fix/noid/filterwhatsnew
fix wrong return value of filtered whats new info
2018-08-16 14:17:48 +02:00
Arthur Schiwon e4720b6056 and the user popover needs a higher z-index, to make it visible again
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-16 13:26:51 +02:00
Arthur Schiwon 6645c014e9 fix wrong return value of filtered whats new info
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-16 12:50:44 +02:00
Roeland Jago Douma bdead84ec6 Merge pull request #10703 from nextcloud/release/noid/14_beta4
Nextcloud 14 Beta 4
2018-08-16 10:48:21 +02:00
Roeland Jago Douma 713fa76859 Nextcloud 14 Beta 4
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-16 10:18:01 +02:00
Julius Härtl d79943f498 Merge pull request #10608 from nextcloud/header-menu-fixes
Fix header menu & contact popover
2018-08-16 09:50:25 +02:00
Julius Härtl a4e042c706 Merge pull request #10695 from nextcloud/sharing-public-settings-fixes
Fix password enforce on public links
2018-08-16 09:38:58 +02:00
Denis Mosolov 0b18e2c75d Add an options to create and remove groups via occ
Signed-off-by: Denis Mosolov <denismosolov@gmail.com>
2018-08-16 10:31:20 +03:00
Christoph Wurst 60625de9e4 Fix typo in IUserManager::createUser doc
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-16 08:37:27 +02:00
Roeland Jago Douma 2b5ec3755e Merge pull request #10692 from nextcloud/deleted-share-remove-actions
Do not show action menu if no actions are available
2018-08-16 08:32:19 +02:00
John Molakvoæ (skjnldsv) 5647f85a3c Object.values polyfill
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-16 07:43:57 +02:00
John Molakvoæ (skjnldsv) c435bfe703 Disabled checkboxes and design fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-16 07:31:17 +02:00
John Molakvoæ (skjnldsv) 7299eb3e20 Fix public pages background
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-16 07:17:28 +02:00
Nextcloud bot b0af604d0e [tx-robot] updated from transifex 2018-08-16 00:12:17 +00:00
Robin Appelman bdc6d0b5a1 log entries that are hidden during file listing
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 01:20:05 +02:00
Roeland Jago Douma 8c1a0a5540 Merge pull request #10702 from nextcloud/bugfix/10622/user-management-actions
Fix missing actions menu on small screens in the user management
2018-08-15 20:36:46 +02:00
Julius Härtl 815cf9ba6f Fix missing actions menu on small screens in the user management
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-15 20:07:54 +02:00
John Molakvoæ 8809dc764b Merge pull request #10701 from nextcloud/bugfix/noid/timepicker-zindex
Fix timepicker z-index to be above the sidebar
2018-08-15 17:13:10 +02:00
Björn Schießle 78ca6f9f87 Merge pull request #10645 from nextcloud/fix-password-reset
only warn about data lose on password reset if per-user keys are used
2018-08-15 17:08:27 +02:00
Julius Härtl e171d004e6 Fix timepicker z-index to be above the sidebar
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-15 16:44:10 +02:00
Arthur Schiwon 2b903aa267 fix unit tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-15 16:11:07 +02:00
Arthur Schiwon e89567eb53 Take base permissions from DAV, fixes #10516
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-15 15:27:31 +02:00
Arthur Schiwon 7f58f36b18 remove unexecutable code
OCA.Sharing.SharedFileInfo was never defined and that stopped execution.
Interestingly, FF never showed me an error.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-15 15:20:41 +02:00
Bjoern Schiessle 3c5fb2b52b update unit tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-08-15 15:08:36 +02:00
Bjoern Schiessle dfec66ca02 only warn about data lose on password reset if per-user keys are used
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-08-15 15:08:34 +02:00
Julius Härtl f7ae4771c8 Merge pull request #10691 from nextcloud/various-beta14-design-fixes
Various beta14 design fixes
2018-08-15 14:46:45 +02:00
John Molakvoæ (skjnldsv) b9c448d855 Fix password enforce on public links
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-15 11:51:25 +02:00
Julius Härtl 52995a0175 Merge pull request #10689 from nextcloud/darktheme-theming-fixes
Add default theming into accessibility compiler
2018-08-15 10:42:40 +02:00
John Molakvoæ (skjnldsv) b082278f04 Do not show action menu if no actions are available
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-15 09:39:12 +02:00
Roeland Jago Douma 6ed87c0c6b Merge pull request #10688 from nextcloud/fix/10492/disabled-users-navigation
Fixes hiding the disabled users nav item if there are no disabled users
2018-08-15 09:24:30 +02:00
John Molakvoæ (skjnldsv) 0e23193b32 Added feedback on autocomplete ui
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-15 08:59:06 +02:00
John Molakvoæ (skjnldsv) 3d169ae4f8 Typo
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-15 08:46:40 +02:00
John Molakvoæ (skjnldsv) a95dc4d3a7 Ellipsis long username/mails in share view
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-15 08:45:07 +02:00
John Molakvoæ (skjnldsv) 5e867d6415 Fix footer and public min-height
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-15 08:38:20 +02:00
John Molakvoæ (skjnldsv) f014d31551 Undo button fix in theming
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-15 07:31:04 +02:00
John Molakvoæ (skjnldsv) a7c426aa5c Add default theming into accessibility compiler
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-15 07:25:31 +02:00
Nextcloud bot 62a9ec12bc [tx-robot] updated from transifex 2018-08-15 00:13:40 +00:00
Michael Weimann cfcdcbed35 Fixes hiding the disabled users nav item if there are no disabled users
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-14 22:28:53 +02:00
Michael Weimann 55cf7c35e1 Adds an acceptance test for the users settings navigation without disabled users
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-14 22:28:11 +02:00
Arthur Schiwon b497b06867 don't force LDAP updates on userExists anymore
and remove some deprecated code

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-14 17:57:24 +02:00
Arthur Schiwon 6f24865bf8 don't blame email address changers
the information is being collected with admin_audit

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-14 17:25:46 +02:00
blizzz d05c815796 Merge pull request #8855 from nextcloud/feature/noid/ldap-integration-autotests
behat integration tests for LDAP
2018-08-14 14:14:22 +02:00
Roeland Jago Douma ff50ef4b21 Merge pull request #10680 from nextcloud/fix/noid/update_lockdownmanagerscope
Update the scope of the lockdownmanager
2018-08-14 13:13:49 +02:00
Roeland Jago Douma ac4735a4f2 Update the scope of the lockdownmanager
We have the token anyway. So better the scope as well.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-14 09:45:52 +02:00
Roeland Jago Douma 4b3587b5f8 Merge pull request #10679 from nextcloud/fix/10667/dialog-button-layout
switches the oc dialog button row to flex
2018-08-14 09:20:25 +02:00
Nextcloud bot ba4c42abaa [tx-robot] updated from transifex 2018-08-14 00:12:05 +00:00
Julius Härtl 23801be55f Merge pull request #10660 from danielkesselberg/bugfix/noid/fix-warning-signoff-checker
Pass HttpHeader as array
2018-08-13 22:51:43 +02:00
Michael Weimann db31bf8a64 switches the oc dialog button row to flex
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-13 21:51:58 +02:00
Christoph Wurst 42300d19e9 Fix max length requirements for the throttler metadata
If a failed login is logged, we save the username as metadata
in the bruteforce throttler. To prevent database error due to
very long strings, this truncates the username at 64 bytes in
the assumption that no real username is longer than that.long strings,

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-13 15:52:09 +02:00
blizzz 8601bbc35d Merge pull request #10621 from nextcloud/feature/noid/add-tos-to-enterprise-bundle
Add the ToS app to the enterprise bundle
2018-08-13 15:47:15 +02:00
Roeland Jago Douma 7ba57233bf Merge pull request #10592 from nextcloud/allow-external-actions-userslist
Allow external actions to users list
2018-08-13 15:39:22 +02:00
Roeland Jago Douma 05b249844e Merge pull request #10659 from danielkesselberg/feature/noid/remove-xcache
Drop support for xcache
2018-08-13 13:55:26 +02:00
John Molakvoæ (skjnldsv) b9a24bfef8 Allow external actions to users list
+ Created fix

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-13 11:33:48 +02:00
Roeland Jago Douma b0c18b8117 Merge pull request #10666 from nextcloud/update/crl2
Another CRL bump
2018-08-13 11:31:03 +02:00
Roeland Jago Douma 0fb2c50f17 Another CRL bump
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-13 10:28:23 +02:00
Roeland Jago Douma 6e009c790f Merge pull request #10664 from nextcloud/update/crl
Update CRL
2018-08-13 10:19:05 +02:00
Roeland Jago Douma 45385e8114 Update CRL
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-13 09:53:19 +02:00
dependabot[bot] 9fc47bf66e Update behat/behat requirement from ~3.3.0 to ~3.5.0 in /build/integration
Updates the requirements on [behat/behat](https://github.com/Behat/Behat) to permit the latest version.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/commits/v3.5.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-08-13 01:14:46 +00:00
Nextcloud bot ccb040ee01 [tx-robot] updated from transifex 2018-08-13 00:12:09 +00:00
Arthur Schiwon 24ef41454c don't add new LDAP configs if one is already present
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-12 23:49:59 +02:00
Arthur Schiwon 919c7b8531 improve fail info and disable cache for a case
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-12 22:45:22 +02:00
Daniel Kesselberg 0d7f9e1b8c Update autoloader
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-08-12 18:26:50 +02:00
Daniel Kesselberg 58106b0a73 Pass HttpHeader as array
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-08-12 18:21:38 +02:00
Daniel Kesselberg bfa49410a2 Drop support for xcache
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-08-12 17:14:08 +02:00
Arthur Schiwon 96f5210fc4 Phpunit changed, use proper Assert class
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-12 14:46:22 +02:00
Nextcloud bot 4cdad9b69f [tx-robot] updated from transifex 2018-08-11 00:12:30 +00:00
Sebastian Steinmetz 8a7bc3fb03 Testcase for HEIC image (similar to the ImageTest)
Signed-off-by: Sebastian Steinmetz <me@sebastiansteinmetz.ch>
2018-08-11 01:22:57 +02:00
Sebastian Steinmetz 6973b82e20 Develop HEIC/HEIF preview support #7406
Signed-off-by: Sebastian Steinmetz <me@sebastiansteinmetz.ch>
2018-08-11 00:13:43 +02:00
Roeland Jago Douma 2afd37331e Merge pull request #10610 from nextcloud/fix/noid/dontcountwithldap
do not trigger counting on LDAP
2018-08-10 20:54:18 +02:00
Roeland Jago Douma c2dfea57c8 Merge pull request #10639 from nextcloud/bugfix/10607/appsettings-fixes
Fix apps management sorting and app removal
2018-08-10 16:18:46 +02:00
Roeland Jago Douma e22d15c3a1 Merge pull request #10642 from nextcloud/bump/autoloaders
Bump autoloaders
2018-08-10 16:18:00 +02:00
Arthur Schiwon 1b74bfc999 do not trigger counting on LDAP
it's probably too many, degregading performance

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-10 15:39:52 +02:00
Roeland Jago Douma 9cb1b1b76e Recompile
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-10 15:22:53 +02:00
Roeland Jago Douma 80dd312e74 Merge pull request #10615 from nextcloud/fix-trashbin-actions
Fix trashbin file actions
2018-08-10 15:09:28 +02:00
Roeland Jago Douma 90a656305b Bump autoloaders
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-10 15:03:22 +02:00
Roeland Jago Douma 7aad5b7721 Merge pull request #10543 from nextcloud/ignore-deactivated-users
Do not show deactivated users in sharees and contacts
2018-08-10 15:01:14 +02:00
Roeland Jago Douma 674d5f2924 Merge pull request #10623 from nextcloud/bugfix/10622/mobile-header
Apply flex-basis to right header
2018-08-10 14:55:06 +02:00
Julius Härtl da60031b54 Bump bundled javascript from settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-10 13:56:52 +02:00
Julius Härtl e74181b84b Sort apps by a proper hierarchical order (active, update, name)
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-10 13:56:14 +02:00
John Molakvoæ (skjnldsv) 846b8572ed Tests fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-10 13:54:21 +02:00
Julius Härtl 1abf0717df Fix removeing apps in the sidebar
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-10 13:38:06 +02:00
Roeland Jago Douma 7191d676ab Merge pull request #10619 from nextcloud/bugfix/4550/redirect-page-update
Redirect to the same page after an update
2018-08-10 11:14:03 +02:00
blizzz d2b9b78c70 Merge pull request #10636 from nextcloud/fix/2fa-enforced-backup-codes
Fix 2FA being enforced if only backup codes provider is active
2018-08-10 11:06:40 +02:00
Roeland Jago Douma a080c425cd Merge pull request #10618 from nextcloud/mimetype-insert-if-not-exists
use insertIfNotExists to store new mimetypes.
2018-08-10 10:31:55 +02:00
Christoph Wurst 3254b85c12 Merge pull request #10546 from nextcloud/popover-tokens
Popovermenu fix and token settings design fixes
2018-08-10 09:38:27 +02:00
Christoph Wurst 5c70aa2a22 Remove unused import
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-10 09:30:17 +02:00
Christoph Wurst 1124b87bc0 Fix 2FA being enforced if only backup codes provider is active
Fixes https://github.com/nextcloud/server/issues/10634.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-10 09:26:40 +02:00
Nextcloud bot 103a2c30fb [tx-robot] updated from transifex 2018-08-10 00:12:26 +00:00
Arthur Schiwon 59e35e3bf7 tests for user storage location
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-10 00:28:44 +02:00
Arthur Schiwon b069b13226 convert pagination tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:12 +02:00
Arthur Schiwon 0f6d98eed2 convert connection tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:12 +02:00
Arthur Schiwon f1cd4bc0c2 fix prov tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:12 +02:00
Arthur Schiwon 8808da816d simplify tests and move some out to a new feature as we need a pristine
database for them

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:12 +02:00
Arthur Schiwon eaf352b8d1 integration test to ensure entries without displayname don't cause trouble
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
Arthur Schiwon d1a8a909de login does not save the response
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
Arthur Schiwon 4e8db8aa11 convert LDAP offline and backup server integration tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
Arthur Schiwon a39c995083 FIX: emit assignedUserId only for users
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
Arthur Schiwon 3450ed4536 integration test checking the group filter
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:10 +02:00
Arthur Schiwon b4eeb9eff5 check user details
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:10 +02:00
Arthur Schiwon 86d145f069 behat integration tests for LDAP, basic setup
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:04 +02:00
Roeland Jago Douma f630b12fc7 Merge pull request #10614 from nextcloud/bugfix/noid/fix_including_invalid_file
Do not use file as template parameter
2018-08-09 19:49:47 +02:00
Michael Weimann 3f790bb85b Excludes not writable app roots from the directory permission check
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-09 19:49:01 +02:00
Michael Weimann ebcfe33d0d Extends the setup check js tests
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-09 19:48:39 +02:00
Michael Weimann 0017cbe18a Adds a test for the app directory permission check.
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-09 19:48:19 +02:00
Michael Weimann b2e60e365d Adds a setup check for app directory permissions.
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-09 19:47:55 +02:00
Roeland Jago Douma 7dc4fadc21 Merge pull request #10626 from nextcloud/bugfix/noid/quickaccess-spaces
Fix quickaccess active indicator for folders with spaces
2018-08-09 19:44:17 +02:00
Julius Härtl d54635fc7d Fix quickaccess active indicator for folders with spaces
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-09 18:31:02 +02:00
Roeland Jago Douma 46d340045d Merge pull request #10598 from schoonc/patch-1
Removed unused variable isFile
2018-08-09 17:00:03 +02:00
Julius Härtl c954eb1d12 Apply flex-basis to right header
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-09 16:46:43 +02:00
Roeland Jago Douma 8c1e75e052 Do not use file as template parameter
Using file will overwrite the $file parameter in the template base.
Leading to trying to include a file that is the exception message. Which
will of course fail.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-09 16:45:25 +02:00
Joas Schilling e1d3965883 Add the ToS app to the enterprise bundle
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-09 16:12:48 +02:00
Roeland Jago Douma 88603e98f8 Merge pull request #10611 from nextcloud/fix/2fa-provider-user-dao-duplicate-key
Fix duplicate key violation in 2FA provider registry DAO
2018-08-09 15:52:51 +02:00
Robin Appelman 5e9d6b1585 use insertIfNotExists to store new mimetypes.
Also throw an error if we can't find the mimetype after insert

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-09 15:20:55 +02:00
Julius Härtl 4823b2746e Redirect to the same page after an update
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-09 15:19:58 +02:00
Robin Appelman 16909f04c2 Fix trashbin file actions
Fixes #10491

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-09 14:31:02 +02:00
Christoph Wurst 8db66d5dfb Fix double-inserts of the same provider state
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-09 13:56:04 +02:00
Christoph Wurst 85bc5edb5e Add integration/unit test for the double-insert of same values
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-09 13:43:00 +02:00
John Molakvoæ (skjnldsv) fc4f122881 Align to the left
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-09 12:47:50 +02:00
John Molakvoæ (skjnldsv) 1d05e457d6 Typo
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-09 12:46:08 +02:00
John Molakvoæ (skjnldsv) fd806366ca Fix header menu & contact popover
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-09 12:42:59 +02:00
Roeland Jago Douma 0757c52980 Merge pull request #10588 from nextcloud/fix/single-2fa-provider-login-redirect
Fix login redirection if only one 2FA provider is active
2018-08-09 12:27:29 +02:00
Roeland Jago Douma def2bf2086 Merge pull request #10604 from nextcloud/release/14/beta3
Nextcloud 14.0.0 beta3
2018-08-09 11:29:01 +02:00
Roeland Jago Douma dff35edaca Nextcloud 14.0.0 beta3
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-09 11:18:21 +02:00
Björn Schießle 6aa6d2186c Merge pull request #10255 from nextcloud/add-support-for-room-shares
Add support for room shares
2018-08-09 10:44:11 +02:00
Roeland Jago Douma ca0f2f63eb Merge pull request #10537 from MartB/mselect_fix
Fix multiSelectMenu for public shares #10536
2018-08-09 10:41:38 +02:00
Roeland Jago Douma a21c93a3cf Merge pull request #8690 from nextcloud/feature/8565/make-thunderbird-and-outlook-addons-identifyable
[Part2] Make thunderbird and outlook addons identifyable
2018-08-09 09:55:26 +02:00
Roeland Jago Douma ad8e7d8665 Merge pull request #10597 from nextcloud/fix/10583/guest-icon-paths
Restores the guest icons
2018-08-09 09:45:45 +02:00
Roeland Jago Douma b4e282e477 Merge pull request #10599 from nextcloud/fix/app-code-checker-ignore-build-dir
Fix app code checker to ignore `build` directory
2018-08-09 08:50:31 +02:00
Julius Härtl 473be0fb01 Merge pull request #10600 from nextcloud/fix/info-xsd-out-of-sync
Fix info.xsd to sync with the appstore one
2018-08-09 08:20:03 +02:00
Christoph Wurst e53c048bc8 Fix info.xsd to sync with the appstore one
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-09 06:58:18 +02:00
Christoph Wurst 201cbf2d33 Fix app code checker to ignore build directory
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-09 06:44:52 +02:00
schoonc b0917dfac9 Removed unused variable isFile 2018-08-09 00:30:42 +03:00
Michael Weimann 9135e10062 Restores the guest icons 2018-08-08 23:19:37 +02:00
Christoph Wurst d8197f2b97 Rename providerset method to get primary providers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-08 20:28:21 +02:00
Roeland Jago Douma 7648bb05e9 Merge pull request #10548 from nextcloud/fix/10430/update_icewind_streams
Update icewind/streams
2018-08-08 20:18:59 +02:00
Björn Schießle 11e99859ef Merge pull request #10397 from nextcloud/encryption-s3-fix
make file cache updates more robust
2018-08-08 18:27:18 +02:00
Robin Appelman 24aaa3bc97 retry stat on timeout
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-08 16:07:41 +02:00
Christoph Wurst c6e47e8a51 Fix login redirection if only one 2FA provider is active
Fixes https://github.com/nextcloud/server/issues/10500.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-08 15:25:59 +02:00
Daniel Calviño Sánchez 4b7fa4ac2e Add support for tokens in room shares
Tokens will be used to give access to a share to guests in public rooms.
Although the token itself is created in the provider of room shares and
no changes are needed for that, due to the code structure it is
necessary to explicitly call the provider from the manager when getting
a room share by token.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:44 +02:00
Daniel Calviño Sánchez e2e6f23b67 Suppress Phan warnings about calling undeclared class methods
The DeletedShareAPIController and ShareAPIController helpers for room
shares are defined in Talk, so the classes do not exist when Talk is not
installed. Due to this when the object returned by "getRoomShareHelper"
is used Phan complains that the class is not declared.

This is not a problem, though, because when the class is not available
"getRoomShareHelper" throws an exception, which is then caught where
that method was called. Therefore now those warnings from Phan are
suppressed (it would be better to use "@phan-suppress-next-line"
instead, but it is not yet available in our Phan version).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:44 +02:00
Daniel Calviño Sánchez e1561f0e8f Add custom handling for room shares to the resharer information
Like done with group shares, received room shares are described as such
in the UI.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:44 +02:00
Daniel Calviño Sánchez 2d062daa11 Add custom handling for room shares to the list of sharees
Like done for other types of shares, room shares are now explicitly
described as such in the UI.

The avatar used is the image provided in the "shareWithAvatar" property
of the share. If none is given then the avatar is the first letter of
the display name of the room share with a coloured background seeded
from the room token. If the display name of the room is empty then no
letter is shown in the avatar; no special handling is done in that case.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 0fab46c817 Log sharing and unsharing with a room in the auditing app
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 30d8e3ee05 Transfer room shares too with the "files:transfer-ownership" command
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 523fdb612c Add room shares to DAV and recent files "share-types" property
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 1ccc99ed83 Add support for room shares to the share owner updater
A user can move her own shares into a received share. When that happens
she is effectively handing over the ownership of the file, so the share
needs to be updated to reflect the new owner.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 8084ba516f Add room shares to the MountProvider for shares
The MountProvider for shares creates mount points for the files shared
with the user, which makes possible to use the received shared files and
folders as regular files and folders.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez de403f2f3d Add integration test for creating room shares when Talk is not enabled
The test just ensures that the controller will gracefully reject the
creation instead of failing miserably; the integration tests when Talk
is enabled are in the Talk repository.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 382b27d035 Add support for room shares to DeletedShareAPIController
In some cases, the DeletedShareAPIController requires explicit handling
of each type of share (for example, to format a share for a
DataResponse). Room shares are implemented in an external app (Nextcloud
Talk), so in order to keep the controller as isolated as possible from
room share specifics all that explicit handling is done in a helper
class provided by the Talk app.

In other cases it is just enough to call the share manager specifying a
room share type; note that the share manager is guarded against share
types for which there is no provider, so it is not necessary to
explicitly check that before passing room shares to the share manager.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 4ed7131e26 Add support for room shares to ShareAPIController
In some cases, the ShareAPIController requires explicit handling of each
type of share (for example, to format a share for a DataResponse). Room
shares are implemented in an external app (Nextcloud Talk), so in order
to keep the controller as isolated as possible from room share specifics
all that explicit handling is done in a helper class provided by the
Talk app.

In other cases it is just enough to call the share manager specifying a
room share type; note that the share manager is guarded against share
types for which there is no provider, so it is not necessary to
explicitly check that before passing room shares to the share manager.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez d9458b303a Add support for room shares to the share manager
Room shares are implemented in an external app (Nextcloud Talk), so in
order to keep the share manager as isolated as possible from room share
specifics all the validity checks are done in the provider of room
shares. However, due to the code structure it is necessary to explicitly
check for room shares in "generalCreateChecks" to prevent an exception
from being thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 4ee839d69c Add provider for room shares
The RoomShareProvider is provided by the Talk app, so it is necessary to
check whether the app is available or not, and also whether the class
itself exists or not (just in case an older version of the app that did
not have support yet for room shares is being used).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 857bb45366 Add comment with IDs of internal share types
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 7292a986a0 Add type for room shares
This type represents shares with a Nextcloud Talk conversation.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Roeland Jago Douma 6b1ba9cdaf Merge pull request #10553 from nextcloud/bugfix/10518/disable-oracle-enforcement-for-now
Disable Oracle enforcement for now until the following issues are sol…
2018-08-08 14:10:18 +02:00
Roeland Jago Douma e7e30ac25f Merge pull request #10586 from nextcloud/fix/noid/check_if_ua_is_set
Check if HTTP_USER_AGENT is set before using it
2018-08-08 13:59:31 +02:00
Roeland Jago Douma c74a5250e5 Check if HTTP_USER_AGENT is set before using it
Sentry reported some errors regarding this. Apparently not everybody
sets a user agent. If it is not set we assume this is not IE ;)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-08 13:32:03 +02:00
Roeland Jago Douma fe286e21ca Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-08 12:58:50 +02:00
John Molakvoæ 3884038765 Merge pull request #10582 from nextcloud/fix/app-password-enter-this-context
Fix `this` context for enter-key handler on app tokens
2018-08-08 12:38:50 +02:00
John Molakvoæ f8e9f860eb Merge pull request #10320 from nextcloud/feature/10176/Quick-Access-Cleanup
Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720
2018-08-08 12:27:12 +02:00
John Molakvoæ (skjnldsv) 91737b591e js fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-08 11:24:13 +02:00
Roeland Jago Douma a3fdec7d4b Merge pull request #10578 from nextcloud/fix/2fa-provider-registry-population
Fix 2FA provider registry population on login
2018-08-08 11:12:00 +02:00
Christoph Wurst b85e1188e1 Fix this context for enter-key handler on app tokens
Fixes https://sentry.io/share/issue/e07c5560b6154212832e4cd6598464c7/.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-08 11:07:47 +02:00
fnuesse 7a78e0c641 Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-08 09:23:54 +02:00
John Molakvoæ e595cad880 Merge pull request #10561 from nextcloud/fix/10476/applist-layout
Fixes the apps list layout
2018-08-08 09:23:14 +02:00
John Molakvoæ b198e17071 Merge pull request #10568 from nextcloud/apps-menu-fixes
Fix apps max-height
2018-08-08 09:22:21 +02:00
Roeland Jago Douma 75de67a98f Merge pull request #10525 from nextcloud/notifications-fix
Fixed notifications position
2018-08-08 09:15:26 +02:00
Roeland Jago Douma bee65f8053 Merge pull request #10572 from nextcloud/bugfix/10464/security-password-change
Fix security settings if password change is disabled
2018-08-08 08:32:54 +02:00
Christoph Wurst d248a0bd1e Fix 2FA provider registry population on login
If the 2FA provider registry has not been populated yet, we have to make
sure all available providers are loaded and queried on login. Otherwise
previously active 2FA providers aren't detected as enabled.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-08 06:57:52 +02:00
Nextcloud bot 1cb8fe3cb0 [tx-robot] updated from transifex 2018-08-08 00:13:19 +00:00
Roeland Jago Douma 70dab08dc8 Merge pull request #10569 from nextcloud/custom-avatar-userconfig
get avatar custom status from user config
2018-08-07 20:44:40 +02:00
blizzz 5685ed4c7d Merge pull request #10567 from nextcloud/icons-cacher-fix
Icons cacher css url fix
2018-08-07 18:23:36 +02:00
Michael Weimann 978fc50c65 Updates the built files
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-07 18:02:14 +02:00
Michael Weimann d1636147eb Fixes the apps list layout
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-07 18:02:13 +02:00
Julius Härtl 318682dd6d Fix security settings if password change is disabled
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-07 17:41:01 +02:00
Robin Appelman ec8ab83ea5 get avatar custom status from user config
this saves a cache operation because the user config is already cached

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-07 14:55:33 +02:00
John Molakvoæ (skjnldsv) 2b15b4cb74 Fix apps max-height
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-07 10:27:39 +02:00
John Molakvoæ (skjnldsv) 7e6fa90fa1 Icons cacher css url fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-07 10:18:46 +02:00
Björn Schießle f8de12c014 Merge pull request #10558 from nextcloud/fix/noid/failing_sync_job_is_no_error
A failing federation sync job is not an error
2018-08-07 10:09:24 +02:00
Nextcloud bot 35342b4b7d [tx-robot] updated from transifex 2018-08-07 00:12:06 +00:00
Roeland Jago Douma dd5862e270 A failing federation sync job is not an error
This is an INFO warning at best. Else it spams the logs continiously.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-06 21:07:15 +02:00
Roeland Jago Douma aa5956f1eb Merge pull request #10550 from nextcloud/fix/noid/do_not_log_to_error
Do not log to error loglevel when converting the error
2018-08-06 19:59:29 +02:00
Joas Schilling f5c63d7a6e Disable Oracle enforcement for now until the following issues are solved:
* Only apps should be checked which say they support oracle
* Only check newly added items, to allow forward migration from an existing database structure

Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-06 17:34:40 +02:00
blizzz db941a3f2e Merge pull request #10523 from janLo/fix-8825
Adding test for table schedulingobjects and fixing postgres LOB
2018-08-06 17:17:47 +02:00
Roeland Jago Douma 01bbd28530 Do not log to error loglevel when converting the error
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-06 16:31:30 +02:00
Joas Schilling f67d942fad Merge pull request #10530 from nextcloud/bugfix/10528/public-template
Fix issues when using the public layout without a PublicTemplateResponse
2018-08-06 15:41:54 +02:00
Roeland Jago Douma 49662f3def Merge pull request #10485 from nextcloud/update-triangle
Fix design of update error page
2018-08-06 15:38:43 +02:00
Thomas Müller c05a0b9fa6 Adding test for table schedulingobjects and fixing postgres LOB
(cherry picked from commit afd4ebf0404e8bcd7cba0bec2dce177e97632f8a)

Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
2018-08-06 13:53:32 +02:00
Roeland Jago Douma db4235d587 Update icewind/streams
Fixes #10430

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-06 13:14:08 +02:00
MartB 5109743383 Fix multiSelectMenu for public shares #10536
Signed-off-by: Martin Böh (MartB) <mart.b@outlook.de>
2018-08-06 12:42:13 +02:00
Thomas Citharel c800495169 Test sync service when user is deactivated
I feel like this could probably be handled better :/

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-08-06 12:34:56 +02:00
John Molakvoæ (skjnldsv) 4ba40385a4 POpovermenu fix and token settings design fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-06 10:48:07 +02:00
Thomas Citharel 03f1fef160 Ignore deactivated users in collaborators user search plugin
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-08-06 09:55:24 +02:00
Thomas Citharel a311798674 Remove users from system addressbook when user deactivated
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-08-06 09:30:21 +02:00
Nextcloud bot ca54166e35 [tx-robot] updated from transifex 2018-08-06 00:12:21 +00:00
Nextcloud bot a625a4d704 [tx-robot] updated from transifex 2018-08-05 00:12:29 +00:00
Nextcloud bot 752ee28b1b [tx-robot] updated from transifex 2018-08-04 00:12:38 +00:00
Julius Härtl 4f2013bd40 Make public layout also usable without a PublicTemplateResponse
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-03 20:41:56 +02:00
Julius Härtl b4ea19c981 Fix base layout content padding
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-03 19:21:10 +02:00
Julius Härtl 2d3e5c817c Remove header-classes since it is never used
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-03 18:25:06 +02:00
Roeland Jago Douma c623345027 Merge pull request #10509 from nextcloud/bugfix/10398/acceptance-files-changedir
Always replace the app sidebar view when switching from a different file list
2018-08-03 15:10:53 +02:00
John Molakvoæ (skjnldsv) 05b53aaf8c Fixed notifications position
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-03 15:07:55 +02:00
Julius Härtl 1b4d502bfd Adjust acceptance test to check if the correct sidebar view is shown
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-03 14:06:04 +02:00
Roeland Jago Douma 755f13ee9f Merge pull request #10519 from nextcloud/min-height-wrapper
Min height 100% on content-wrapper
2018-08-03 14:05:28 +02:00
Jan-Christoph Borchardt 6d7bf81421 Fix HTML on update error page
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-08-03 13:30:49 +02:00
Jan-Christoph Borchardt 49cbd8cd95 Add margin below detailed logs
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-08-03 13:30:36 +02:00
Jan-Christoph Borchardt 2fb6799ad6 Use images instead of inline SVG and unicode
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-08-03 13:20:45 +02:00
John Molakvoæ (skjnldsv) 49189190b9 Min height 100% on content-wrapper
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-03 12:02:23 +02:00
Julius Härtl 16f6c07173 Always call render to replace the app-sidebar if the detail view is updated
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-03 11:47:53 +02:00
Julius Härtl bcdbc4e19e Fix return value of change directory
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-03 11:47:10 +02:00
Roeland Jago Douma af6f93b025 Merge pull request #10515 from nextcloud/revert-zindex
Fixed design zindex
2018-08-03 11:27:48 +02:00
John Molakvoæ (skjnldsv) 248b786bd0 Fixed design zindex
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-03 10:27:38 +02:00
Nextcloud bot bf88448f87 [tx-robot] updated from transifex 2018-08-03 00:12:22 +00:00
Roeland Jago Douma 01298cfa72 Merge pull request #10480 from nextcloud/bugfix/10420/settings
Settings design polishing
2018-08-02 20:23:21 +02:00
Roeland Jago Douma 9057621d64 Merge pull request #10506 from nextcloud/fix/10504/not_all_apps_are_appstore
Not all apps are from the appstore
2018-08-02 19:32:51 +02:00
Roeland Jago Douma 8d08cfc87f Merge pull request #10508 from nextcloud/bugfix/noid/app-management
Fix app management not providing updates for apps which got disabled
2018-08-02 19:32:13 +02:00
Joas Schilling 483ad01a09 There is no update available if the app didnt have a version (aka was not installed)
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-02 14:27:16 +02:00
Joas Schilling a9f8ee4e9d Also allow to update apps which are currently not enabled
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-02 14:26:31 +02:00
Joas Schilling 2dcae4e8ea Keep the data of the local app (especially the version)
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-02 13:47:42 +02:00
Roeland Jago Douma 106ce3368d Not all apps are from the appstore
Fixes #10504

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-02 12:56:23 +02:00
Roeland Jago Douma 94c35d542f Merge pull request #10482 from nextcloud/content-list-checkbox-visibility-fix
Only show checkbox on hover/focus + accessibility fixes
2018-08-02 12:36:10 +02:00
Julius Härtl 84f99db7ab files_external: Fix jsunit tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-02 11:45:04 +02:00
Roeland Jago Douma 9891eae232 Merge pull request #10495 from nextcloud/14beta2
14 Beta 2
2018-08-02 10:50:32 +02:00
John Molakvoæ (skjnldsv) 5f372b1cd5 Add class to show all checkboxes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-02 10:31:36 +02:00
Julius Härtl 0dd519cff1 Fix encryption admin section tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-02 10:26:09 +02:00
Roeland Jago Douma 5525c2fdfa 14 Beta 2
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-02 10:16:04 +02:00
Roeland Jago Douma e194dc7139 Merge pull request #10465 from nextcloud/fix/backup-codes-state-propagation
Fix state propragation of the backup codes provider
2018-08-02 10:13:59 +02:00
Nextcloud bot 62af5bf033 [tx-robot] updated from transifex 2018-08-02 00:12:37 +00:00
Roeland Jago Douma 494f9fb86c Merge pull request #10486 from nextcloud/detect-hidden-navigation
Mobile fixes
2018-08-01 22:57:28 +02:00
Roeland Jago Douma fae7e516b5 Merge pull request #10481 from nextcloud/feature/noid/make-info-available-if-the-avatar-was-uploaded
Make the info available if the avatar was uploaded or generated
2018-08-01 22:54:38 +02:00
Christoph Wurst f8fe7488a5 Fix state propragation of the backup codes provider
Starting with Nextcloud 14, the server knows the enabled/disabled
state of 2fa providers. While it will query that information if it's
unknown (on first use), it won't notice any changes. Thus, providers
have to propagate that information themselves.

Ref https://github.com/nextcloud/twofactor_totp/pull/263
Ref https://github.com/nextcloud/twofactor_u2f/pull/210

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-01 21:21:30 +02:00
Jan-Christoph Borchardt 4574698443 Fix double container on 'Possible CSRF attack' page
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-08-01 18:54:48 +02:00
Joas Schilling 38fffffe18 Fix unit test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-01 14:46:44 +02:00
John Molakvoæ (skjnldsv) 0a967818db Mobile fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-01 14:29:26 +02:00
Jan-Christoph Borchardt ede469a240 Inline error svg icon because there is no SCSS on guest page
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-08-01 13:51:23 +02:00
Jan-Christoph Borchardt d64a9f3d0d Fix text overflow on update page
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-08-01 13:36:44 +02:00
Jan-Christoph Borchardt 81dc12a77b Fix triangle on update page
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-08-01 13:30:31 +02:00
Roeland Jago Douma b5c5faebfc Merge pull request #10484 from nextcloud/bugfix/noid/theming-cache-update
Append cache bump parameter to scss files URL
2018-08-01 13:28:53 +02:00
Roeland Jago Douma e65ca39993 Merge pull request #10479 from nextcloud/bugfix/noid/personal-settings-icon-visibility
Use icon classes in personal settings
2018-08-01 12:57:48 +02:00
Roeland Jago Douma 369a6c13eb Merge pull request #10474 from danielkesselberg/bugfix/10379/no-files-in-here
Set emptyText depending on filepicker type
2018-08-01 12:56:08 +02:00
Roeland Jago Douma 8162b349e7 Merge pull request #10483 from nextcloud/detect-hidden-navigation
No margin left if the navigation is hidden
2018-08-01 12:54:42 +02:00
Julius Härtl 6ce474518c Append cache bump parameter to scss files URL
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-01 12:42:49 +02:00
Joas Schilling 6690197ff1 Merge pull request #10471 from nextcloud/bugfix/noid/improve-url-detection
Improve URL detection
2018-08-01 12:13:17 +02:00
Joas Schilling 90fe6bffd6 Merge pull request #10466 from nextcloud/rakekniven-patch-1
Fixed tiny grammar issue
2018-08-01 12:12:47 +02:00
John Molakvoæ (skjnldsv) 36a45597bb No margin left if the navigation is hidden
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-01 11:31:37 +02:00
Joas Schilling decd196162 Make the info available if the avatar was uploaded or generated
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-01 10:56:22 +02:00
John Molakvoæ (skjnldsv) cbe54e096b Only show checkbox on hover/focus + accessibility fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-01 10:52:01 +02:00
Julius Härtl bee78a475e Use icon classes in personal settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-01 10:05:42 +02:00
Julius Härtl b46b7d7591 systemtags: Submit input on enter
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-01 09:45:34 +02:00
Roeland Jago Douma 27d4ff8b4e Merge pull request #10448 from nextcloud/list-opacity-fix
Only lower opacity of the avatar if the checkbox is checked on the content-list
2018-08-01 09:42:38 +02:00
Julius Härtl 03971d3695 Move encryption settings to security
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-01 09:41:09 +02:00
Julius Härtl 10de5f219c files_external: Add description to settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-01 09:41:09 +02:00
Julius Härtl 635575f271 files_external: Move delete option to 3-dots menu
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-01 09:41:08 +02:00
Julius Härtl 9b46814320 Rename CalDAV to Calendar settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-01 09:41:08 +02:00
Julius Härtl 8abec697b0 Make user management heading font size lighter
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-01 09:41:08 +02:00
Julius Härtl f499f1b9a1 Move locale preview to two lines to reduce grid height
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-01 09:41:08 +02:00
Nextcloud bot 6a9bee478d [tx-robot] updated from transifex 2018-08-01 00:11:59 +00:00
Daniel Kesselberg 6b9093ce6d Set emptyText depending on filepicker type
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-07-31 22:49:01 +02:00
Roeland Jago Douma 9886805ad4 Merge pull request #10472 from nextcloud/add-notification-container-to-public-layout-template
Add notification container to public layout template
2018-07-31 20:02:06 +02:00
Roeland Jago Douma 411387d37d Merge pull request #9242 from nextcloud/fix-display-name-ignored-when-creating-new-user
Fix display name ignored when creating new user
2018-07-31 19:59:38 +02:00
Daniel Calviño Sánchez 84c46dd3dd Add notification container to public layout template
This is needed to show notifications using the standard
"OC.Notification.show" function.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-31 18:57:10 +02:00
Joas Schilling 3f45ab97da Improve URL detection
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-31 17:11:46 +02:00
Roeland Jago Douma 3e0668e348 Merge pull request #10469 from nextcloud/bugfix/10420/tags-management
Revert to regular buttons in system tags management
2018-07-31 16:37:21 +02:00
Roeland Jago Douma bf522bc4b9 Merge pull request #10468 from nextcloud/bugfix/10094/apps-management-space
Add more spacing to the apps management sidebar
2018-07-31 16:14:01 +02:00
Julius Härtl cfcb90214f Revert to regular buttons in system tags management
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-31 15:35:57 +02:00
Roeland Jago Douma 3ae66a76e1 Merge pull request #10467 from nextcloud/fix/10403/reword_note
Reword share comment feature
2018-07-31 15:19:22 +02:00
Julius Härtl 2359efce3d Add more spacing to the apps management sidebar
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-31 15:08:08 +02:00
Roeland Jago Douma f05d30c5b0 Compile vue
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-31 15:03:40 +02:00
Roeland Jago Douma bc83656604 Reword share comment feature
Fixes #10403

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-31 14:20:22 +02:00
Daniel Calviño Sánchez 029b33a664 Add acceptance test for creating a user with a custom display name
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-31 13:40:47 +02:00
Daniel Calviño Sánchez ab6688fe0b Set display name (if specified) when a new user is created
Although the form to create a new user included a field to set the
display name its value was not taken into account, so the new user ended
with the default display name (the same as the user name).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-31 13:40:47 +02:00
rakekniven ed026ce4df Fixed tiny grammar issue
ID in uppercase.

Signed-off-by: Mark Ziegler <mark.ziegler@rakekniven.de>
2018-07-31 13:34:14 +02:00
Daniel Calviño Sánchez 36326e38a0 Add optional "displayName" parameter to add user endpoint
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-31 13:33:55 +02:00
Bjoern Schiessle a9e22c5f1c make file cache updates more robust
only update the encrypted version after the write operation is finished and the stream is closed

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-31 12:24:38 +02:00
blizzz c39bc1638b Merge pull request #10444 from nextcloud/feature/noid/allow-to-filter-unread-count-by-verb
Allow to filter the unread count by verb
2018-07-31 12:05:52 +02:00
Roeland Jago Douma ef85ef0786 Merge pull request #10459 from nextcloud/bugfix/noid/install-page
Fix caret icon on installation page
2018-07-31 11:53:04 +02:00
Roeland Jago Douma b16f1093af Merge pull request #10460 from nextcloud/bugfix/10443/theming-icons
Use icon mixins for the theming scss
2018-07-31 11:50:21 +02:00
Roeland Jago Douma eedfb0d8a4 Merge pull request #10462 from nextcloud/fix/provider-registry-duplicate-entries
Fix duplicate inserts in the 2fa provider registry DAO
2018-07-31 08:58:02 +02:00
Christoph Wurst fc149bab3c Fix duplicate inserts in the 2fa provider registry DAO
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-07-31 06:43:44 +02:00
Nextcloud bot 5e43f3c6a6 [tx-robot] updated from transifex 2018-07-31 00:12:12 +00:00
Julius Härtl 5d7c0b8cd2 Use icon mixins for the theming scss
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-31 00:10:34 +02:00
Julius Härtl d13f1cd017 Fix caret icon on installation page
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-30 23:56:07 +02:00
Roeland Jago Douma 1f610b4d1f Merge pull request #10451 from nextcloud/fix/9693/move_logcondition_up
Fetch logcondition earlier
2018-07-30 22:07:06 +02:00
Roeland Jago Douma f208ce920d Merge pull request #10221 from nextcloud/bugfix/noid/prevent-too-long-identifiers
Prevent too long identifier names
2018-07-30 21:00:53 +02:00
Joas Schilling 168d6f7c44 Merge pull request #10435 from nextcloud/rakekniven-patch-1
Typo fix: Triple dot to ellipsis
2018-07-30 20:12:17 +02:00
Roeland Jago Douma 75589badf3 Merge pull request #8357 from nextcloud/ui-regression
Frontend testing using puppeteer
2018-07-30 16:47:07 +02:00
Julius Härtl 412002906f Keep timestamp replacements at the beginning
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-30 15:24:46 +02:00
rakekniven 6c5670f6d2 Update IMipPlugin.php
Added space before ellipsis
2018-07-30 15:05:55 +02:00
Roeland Jago Douma 8cdd134e7e Fetch logcondition earlier
Fixes #9693

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-30 14:57:19 +02:00
Roeland Jago Douma b1af610069 Merge pull request #10421 from nextcloud/content-wrapper-cleanup
Really cleanup the content-wrapper
2018-07-30 14:01:55 +02:00
Roeland Jago Douma d29e86b395 Merge pull request #10447 from nextcloud/contactsmenu-height-fix
Fix contactsmenu overflow
2018-07-30 14:00:26 +02:00
John Molakvoæ (skjnldsv) 733a015a93 Only lower opacity of the avatar if the checkbox is cheked on the content-list
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-30 13:20:37 +02:00
John Molakvoæ (skjnldsv) fa54668bbc Fix contactsmenu overflow
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-30 13:05:37 +02:00
John Molakvoæ (skjnldsv) 2be323d195 Mobile scroll fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-30 12:48:24 +02:00
Joas Schilling 66945f9574 Allow to filter the unread count by verb
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-30 09:41:51 +02:00
Nextcloud bot 566800b29c [tx-robot] updated from transifex 2018-07-30 00:12:08 +00:00
Julius Härtl 4bd7cb7a2d Fix install button layout to avoid irregular test failures
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-30 00:40:09 +02:00
Julius Härtl 5ef077840f Improve test duration
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Reincrement network idle to 3 s

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-30 00:40:07 +02:00
Julius Härtl d40f26b4c5 Add custom network idle waiting and some JS injection to make tests more stable
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-29 22:52:53 +02:00
Julius Härtl f7d2cdbd97 Fix new settings and login tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-29 22:52:35 +02:00
Julius Härtl 138a527cc4 Use correct domain for ci-assets
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-29 22:52:34 +02:00
Morris Jobke c96d64b083 Update object storage
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-29 22:52:34 +02:00
Julius Härtl 33f26c8da2 Frontend regression testing with puppeteer
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-29 22:51:58 +02:00
rakekniven c94ac53e60 Typo fix: Triple dot to ellipsis
Signed-off-by: Mark Ziegler <mark.ziegler@rakekniven.de>
2018-07-29 10:15:02 +02:00
Nextcloud bot 0c7a17795b [tx-robot] updated from transifex 2018-07-28 00:12:07 +00:00
John Molakvoæ (skjnldsv) 3de1eb480e Mobile fixes and list fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-27 19:43:51 +02:00
John Molakvoæ (skjnldsv) e3d1353dc6 App-content list fixes for new layout
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-27 18:45:33 +02:00
John Molakvoæ (skjnldsv) 09f80df011 Height fix for content
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-27 18:41:34 +02:00
Joas Schilling ef5074adaa Fix primary key handling on postgres
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-27 14:45:22 +02:00
Joas Schilling 008c8dde1a Ignore custom prefixes which are longer
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-27 14:45:22 +02:00
Joas Schilling 5e0bfe5c16 Ignore automatic generated sequences
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-27 14:45:21 +02:00
Joas Schilling 960961148e Fix calculation of default name
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-27 14:45:21 +02:00
Joas Schilling 14682dfa7c Add unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-27 14:45:21 +02:00
Joas Schilling 8a45cb1d20 Prevent too long identifier names
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-27 14:45:21 +02:00
John Molakvoæ (skjnldsv) 88db07d28e Really cleanup the content-wrapper
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-27 09:42:34 +02:00
Roeland Jago Douma 5edab3b311 Merge pull request #10416 from nextcloud/bugfix/10414/fix-preview-url
Use OC.generateUrl to properly prefix preview images
2018-07-27 09:33:00 +02:00
Roeland Jago Douma 6ab9f3ef99 Merge pull request #10417 from nextcloud/bugfix/noid/fix-undefined-constant-status-service
Fix undefined constant error for STATUS_SERVICE_UNAVAILABLE
2018-07-27 09:32:05 +02:00
Roeland Jago Douma 7b23cf3dc6 Merge pull request #10415 from nextcloud/bugfix/noid/regex-icons
Fix regex for icon urls
2018-07-27 07:23:04 +02:00
Nextcloud bot 6ccc34f5af [tx-robot] updated from transifex 2018-07-27 00:12:20 +00:00
Julius Härtl 3e21033dfc Fix undefined constant error for STATUS_SERVICE_UNAVAILABLE
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-26 22:56:17 +02:00
Julius Härtl 093799f4b0 Use OC.generateUrl to properly prefix preview images
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-26 22:41:41 +02:00
Julius Härtl f77cc11a28 Fix tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-26 22:26:05 +02:00
Julius Härtl 8aa0f0485d Fix regex for icon urls
Use the version from the url rather than hardcoding v=1.
Also allow uppercase chars in the url, so that uppercase
hex color values will also be included

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-26 22:08:48 +02:00
Morris Jobke 6514bf1e18 Merge pull request #10406 from nextcloud/bugfix/10405/undefined-index-classes
Not all sidebar entries have the "classes" attribute
2018-07-26 16:05:34 +02:00
Morris Jobke 03689a8d94 Merge pull request #10408 from nextcloud/bugfix/noid/If_fav_fails_empty_array
Set the favorites to the empty array on failure
2018-07-26 16:01:28 +02:00
Morris Jobke bf61067d8f Merge pull request #10409 from nextcloud/bugfix/noid/dont_fail_no_fav_tag
Check if the favorite tag exists
2018-07-26 16:01:03 +02:00
Roeland Jago Douma ece41318b8 Check if the favorite tag exists
If the tag does not exist there is no need to do 💥 and log an
exception on error level

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-26 15:33:26 +02:00
Roeland Jago Douma 309ae6d9c0 Set the favorites to the empty array on failure
Else it will start throwing errors because null is not iteratable.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-26 15:14:28 +02:00
Morris Jobke 68ba96a7d5 Not all sidebar entries have the "classes" attribute
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-26 15:05:00 +02:00
Morris Jobke adcc061166 Merge pull request #10370 from nextcloud/version/noid/14.0.0beta1
14.0.0 Beta 1
2018-07-26 13:30:09 +02:00
Morris Jobke 6d9b8e4a85 14.0.0 Beta 1
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-26 11:38:07 +02:00
Nextcloud bot e98f4de66a [tx-robot] updated from transifex 2018-07-26 00:12:01 +00:00
Morris Jobke 61397ee091 Merge pull request #9222 from nextcloud/feature/noid/search-for-files-by-comments
Allow to search files by comments
2018-07-25 20:30:00 +02:00
Morris Jobke 2dd55b0550 Brighter comments icon
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-25 20:28:49 +02:00
Joas Schilling ac2314e3d0 Add pagination support
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-25 18:53:45 +02:00
Daniel Calviño Sánchez 1e16f7ecd9 Add integration tests for searching files by comments
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-25 18:53:45 +02:00
Joas Schilling 8c7969e730 Allow to search by comments
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-25 18:53:44 +02:00
Morris Jobke 8255faada4 Merge pull request #10377 from nextcloud/sccs-cache-iscached
cache isCached state for scss resources
2018-07-25 17:33:01 +02:00
Morris Jobke 801e5a4523 Fix unit tests to pass the folder now via the appData dependency
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-25 16:57:36 +02:00
Morris Jobke 28b234935d Merge pull request #10396 from nextcloud/feature/noid/support-is-shipped
Support app is shipped
2018-07-25 16:51:36 +02:00
Morris Jobke fd041eb475 Support app is shipped
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-25 15:42:36 +02:00
Morris Jobke cf98d9c8d3 Merge pull request #10394 from nextcloud/bugfix/10381/fix-avatar-sizing
Fix avatar sizing for comments
2018-07-25 15:04:48 +02:00
Julius Härtl 1f635bb892 Use small loading indicator for avatars smaller than 32px
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-25 14:26:27 +02:00
Julius Härtl 6d29b36200 Limit small avatar rendering only to inline mentions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-25 14:26:04 +02:00
Morris Jobke 70fa73404f Merge pull request #10391 from nextcloud/bugfix/10389/fix-app-navigation-controller
Fix app navigation controller to return an array
2018-07-25 14:11:49 +02:00
Julius Härtl 4c773891d7 Fix app navigation controller to return an array
This is required to not break compatibility with existing consumers of that endpoint like the apps management or the client

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-25 13:50:46 +02:00
Morris Jobke ebeaa37da2 Merge pull request #10385 from nextcloud/search-init-fix
Fix search on public pages
2018-07-25 13:43:23 +02:00
Morris Jobke a5d163ac3b Merge pull request #10388 from nextcloud/dialog-overlay-index
Fix overlay dialog zindex
2018-07-25 13:37:35 +02:00
Morris Jobke 35afd4ea5f Merge pull request #10383 from nextcloud/bugfix/noid/allow-to-access-svgs-as-guest
Allow to access SVGs as guest
2018-07-25 13:35:34 +02:00
Morris Jobke 90eced4b3f Merge pull request #10386 from nextcloud/bg-transition-safari-fix
Fix safari submenu navigation positionning
2018-07-25 13:32:08 +02:00
John Molakvoæ (skjnldsv) 85bcc61604 Fix overlay dialog zindex
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-25 12:39:17 +02:00
John Molakvoæ (skjnldsv) 8e81bc7895 Fix safari submenu navigation positionning
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-25 12:30:17 +02:00
John Molakvoæ (skjnldsv) a1d7d60685 Fix search on public pages
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-25 12:20:46 +02:00
Morris Jobke 0e4f465094 Merge pull request #10382 from nextcloud/bugfix/noid/fix-settings-sidebar
Fix sidebar position in app settings
2018-07-25 12:18:16 +02:00
Joas Schilling 12efde520d Allow to access SVGs as guest
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-25 12:05:18 +02:00
Morris Jobke 7eb74186ef Merge pull request #8380 from nextcloud/bugfix/noid/reenable-disabled-apps
Re-enable apps that got automatically disabled while updating
2018-07-25 11:37:10 +02:00
Julius Härtl 64468fc232 Fix sidebar position in app settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-25 10:48:12 +02:00
Joas Schilling 80207d72fa Correctly register everything via the Application class
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-25 10:26:06 +02:00
Nextcloud bot fb77ff9da4 [tx-robot] updated from transifex 2018-07-25 00:12:34 +00:00
Morris Jobke a96137ef0b Merge pull request #10310 from nextcloud/accessibility-header
Accessibility fixes for header and global elements
2018-07-25 00:07:37 +02:00
Morris Jobke f5e4fcadd9 Merge pull request #10378 from nextcloud/bugfix/noid/fix-icon-name-14
Fix icon file names
2018-07-25 00:05:13 +02:00
Roeland Jago Douma 71028fde6b Merge pull request #10322 from weeman1337/feature-9978-improve-disabled-user-login-message
Login: Implements the "user disabled" message like the "wrong password" message
2018-07-24 20:00:20 +02:00
Kevin Ndung'u fe25092312 Remove deprecated keyboard events & properties
Signed-off-by: Kevin Ndung'u <kevgathuku@gmail.com>
2018-07-24 19:02:56 +02:00
Kevin Ndung'u 1cdf808197 Trigger upload actions only for Enter & Space keys
Signed-off-by: Kevin Ndung'u <kevgathuku@gmail.com>
2018-07-24 19:02:56 +02:00
Jan-Christoph Borchardt d06e00ffe3 Trigger upload action also with keyboard navigation on enter
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-07-24 19:02:56 +02:00
Julius Härtl dd5f1803db Readd starred icon since it is used in activity renderings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-24 19:01:07 +02:00
Jan-Christoph Borchardt a2ad1b9aa9 Fix ability to open file or folder via keyboard, fix #10008
Before, the file or folder was opened when clicking on the name span,
but not when clicking on the link that contains the name; clicking on
the link highlighted the file and opened the sidebar, just like clicking
on the file size or date. Now clicking on the link opens the file or
folder, so the unit tests that tested clicks on the link were changed to
test clicking on the file size instead.

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-07-24 18:58:35 +02:00
Julius Härtl 4e53888784 Replace contacts-dark icon
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-24 18:53:59 +02:00
Julius Härtl a66481932d Add group icon
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-24 18:48:25 +02:00
Julius Härtl 1a156c298e Replace contacts-dark icon with contacts
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-24 18:47:54 +02:00
Michael Weimann 801bf81317 Adds disabled user acceptance tests
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-07-24 17:31:03 +02:00
Robin Appelman 6686ca9b2a cache isCached state for scss resources
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-24 17:30:39 +02:00
Morris Jobke 9b9d729acf Merge pull request #10238 from nextcloud/add-support-for-sending-the-password-for-a-share-by-nextcloud-talk
Add support for sending the password for a share by Nextcloud Talk
2018-07-24 17:06:56 +02:00
Morris Jobke 7da815bb04 Merge pull request #10298 from nextcloud/bugfix/talk-714/only-migrate-the-schema-when-moving-database
Only create the schema when moving between databases
2018-07-24 16:14:05 +02:00
Morris Jobke d67e18b28e Merge pull request #10348 from nextcloud/fix-transfering-ownership-of-a-share-to-user-with-same-id-as-receiver
Fix transfering ownership of a share to user with same id as receiver
2018-07-24 15:34:45 +02:00
Morris Jobke 0280245fdd Merge pull request #10375 from nextcloud/background-scan-root
Do scan the root storage in background scan
2018-07-24 15:20:49 +02:00
Daniel Calviño Sánchez b7474ed482 Fix transfering ownership of a share to user with same id as receiver
When the ownership of a user share is transfered to the receiver the
share is removed, as the receiver now owns the original file. However,
due to a missing condition, any share with a group, link or remote with
the same id as the user was removed, not only the user shares.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-24 15:05:42 +02:00
Daniel Calviño Sánchez 911093549e Make possible to enable "sending password by Talk" from the share menu
Until now the password to be sent by mail was set by enabling a checkbox
in the share menu and then entering the password in an input field shown
below. Now, when Talk is enabled, another item is added to the share
menu to do the same for a password to be sent by Talk.

Sending the password by mail and sending it by Talk are mutually
exclusive actions, so when one of the checkboxes is enabled the other
one is automatically disabled.

Note that the icon set for the field, "icon-passwordtalk", does not
currently exist; it simply mimics the "icon-passwordmail" (which does
not exist either) used for the field of the password protect by mail to
get the right padding in the menu.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-24 14:45:42 +02:00
Morris Jobke 5cfac8ecea Merge pull request #10353 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/webpack-4.16.2
Bump webpack from 4.16.0 to 4.16.2 in /apps/updatenotification
2018-07-24 14:34:12 +02:00
Robin Appelman 5e940366c2 Do scan the root storage in background scan
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-24 14:15:27 +02:00
Daniel Calviño Sánchez 96108ab858 Add event to load additional scripts in the auth page for public shares
Before the public share authentication page is rendered now an event to
load additional scripts is dispatched. Thanks to this any app can load
its own scripts that, when run on the browser, adjust as needed the page
generated by the server.

Note, however, that during the handling of the event apps are only able
to add scripts or styles to be loaded; they can not render arbitrary
content on the page, or change how the content is rendered by the
original template; all those changes have to be done by the scripts at
run-time.

This implies that the scripts of the apps can use only those parameters,
like the token of the share, added to the page when it is generated by
the "publicshareauth" template. Due to this, and given that the event is
being introduced to be used by Talk to inject the UI needed to request
the password for a share, the token of the share is now provided in the
generated page, just like done in the public share page.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-24 14:04:22 +02:00
Daniel Calviño Sánchez 7849630cef Add support for sending the password by Talk to ShareAPIController
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-24 14:04:17 +02:00
Daniel Calviño Sánchez d582a66bea Honour "sendPasswordByTalk" property in mail shares
When a password was set for a mail share an e-mail was sent to the
recipient with the password. Now the e-mail is no longer sent if the
password is meant to be sent by Talk.

However, before the e-mail was not sent when the share was updated but
the password was not changed. Now an e-mail is sent in that case too if
switching from a password sent by Talk to a password sent by mail.

On the other hand, when switching from a password sent by mail to a
password sent by Talk it is mandatory to change the password; otherwise
the recipient would already have access to the share without having to
call the sharer to verify her identity.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-24 13:56:29 +02:00
Daniel Calviño Sánchez dd0c5e297e Store "sendPasswordByTalk" property of mail shares in the database
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-24 13:56:28 +02:00
Daniel Calviño Sánchez 88600f4ecf Add "sendPasswordByTalk" property to shares
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-24 13:56:28 +02:00
Daniel Calviño Sánchez 49fd17ff14 Add "password_by_talk" column to "share" table in the database
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-24 13:56:25 +02:00
Morris Jobke f7c7ff5f85 Merge pull request #10326 from nextcloud/svg-api-suf-fixes
Fix regex of iconsCacher
2018-07-24 13:36:39 +02:00
Morris Jobke e8b0868b58 Merge pull request #10327 from nextcloud/focus-comment-on-tabs-select
Focus comment on tabs select + design fixes
2018-07-24 13:34:51 +02:00
Morris Jobke 147ada54fa Merge pull request #10369 from nextcloud/techdebt/noid/avoid-404-on-developer-console
Remove hint to .map.js files on vendor projects that we do not ship
2018-07-24 13:34:16 +02:00
Roeland Jago Douma c2b04634bb Rerun js build
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-24 13:23:43 +02:00
John Molakvoæ (skjnldsv) 52af49ead5 Fixed comments design
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 12:34:03 +02:00
John Molakvoæ (skjnldsv) b7317a35e7 Focus the comment input on tab select/loading
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 12:34:02 +02:00
John Molakvoæ (skjnldsv) f62d4d174d new tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 12:21:07 +02:00
John Molakvoæ (skjnldsv) 6bcfe8d628 Uppercase
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 12:15:14 +02:00
John Molakvoæ (skjnldsv) 85a481d2b6 Fix regex of iconsCacher
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 12:15:14 +02:00
John Molakvoæ (skjnldsv) a9e554beec Fix header controls sticky positioning
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 12:08:31 +02:00
Morris Jobke e341367030 Remove hint to .map.js files on vendor projects that we do not ship
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-24 11:32:09 +02:00
Morris Jobke dfe6c1b7e2 Merge pull request #10363 from nextcloud/structure-mobile-and-public-fixes
Structure mobile and public fixes
2018-07-24 11:26:22 +02:00
Roeland Jago Douma c8b476c9cd Rebuild updatenotifications
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-24 11:19:43 +02:00
dependabot[bot] 97c874161d Bump webpack from 4.16.0 to 4.16.2 in /apps/updatenotification
Bumps [webpack](https://github.com/webpack/webpack) from 4.16.0 to 4.16.2.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.16.0...v4.16.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-24 11:19:21 +02:00
John Molakvoæ (skjnldsv) 84bc30200e Phpunit tests fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 11:01:11 +02:00
John Molakvoæ (skjnldsv) 440b5c944f Fixed scrolling container
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 11:01:11 +02:00
John Molakvoæ (skjnldsv) 0274507cb1 Acceptance and mobile navigation fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 11:01:11 +02:00
Morris Jobke 262cb04c3a Merge pull request #10331 from weeman1337/fix-10330-files-multi-select-header
Adjusts the files multi select header width
2018-07-24 10:48:55 +02:00
Roeland Jago Douma b41d0d32e2 Merge pull request #10218 from nextcloud/share-comments
allow to add a personal note to a share
2018-07-24 09:12:03 +02:00
Nextcloud bot 241e5705cb [tx-robot] updated from transifex 2018-07-24 00:12:01 +00:00
Morris Jobke 1e431bf6ba Merge pull request #10338 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/vue-loader-15.2.6
Bump vue-loader from 15.2.4 to 15.2.6 in /apps/updatenotification
2018-07-23 22:14:34 +02:00
Morris Jobke fa0f98059b Merge pull request #10342 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/vue-loader-15.2.6
Bump vue-loader from 15.2.4 to 15.2.6 in /apps/oauth2
2018-07-23 22:14:12 +02:00
Morris Jobke 89211d5e9b Merge pull request #10344 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/webpack-cli-3.1.0
Bump webpack-cli from 3.0.8 to 3.1.0 in /apps/accessibility
2018-07-23 22:13:52 +02:00
Morris Jobke b91e758baa Merge pull request #10356 from nextcloud/bugfix/noid/dont-call-getuid-on-null
Don't call getUID on null when the app is loaded for a guest
2018-07-23 22:12:39 +02:00
dependabot[bot] 44811b52b8 Bump vue-loader from 15.2.4 to 15.2.6 in /apps/oauth2
Bumps [vue-loader](https://github.com/vuejs/vue-loader) from 15.2.4 to 15.2.6.
- [Release notes](https://github.com/vuejs/vue-loader/releases)
- [Changelog](https://github.com/vuejs/vue-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-loader/compare/v15.2.4...v15.2.6)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-23 19:19:15 +00:00
Roeland Jago Douma f25d34b293 Merge pull request #10355 from nextcloud/bugfix/noid/make-sure-error-log-always-receives-a-string
Make sure error_log() always receives a string
2018-07-23 21:17:38 +02:00
dependabot[bot] 7509bd224f Bump vue-loader from 15.2.4 to 15.2.6 in /apps/updatenotification
Bumps [vue-loader](https://github.com/vuejs/vue-loader) from 15.2.4 to 15.2.6.
- [Release notes](https://github.com/vuejs/vue-loader/releases)
- [Changelog](https://github.com/vuejs/vue-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-loader/compare/v15.2.4...v15.2.6)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-23 19:17:14 +00:00
dependabot[bot] 09373b1f41 Bump webpack-cli from 3.0.8 to 3.1.0 in /apps/accessibility
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.0.8 to 3.1.0.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-23 19:17:11 +00:00
Roeland Jago Douma a5b76d7932 Merge pull request #10343 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/vue-loader-15.2.6
Bump vue-loader from 15.2.4 to 15.2.6 in /apps/accessibility
2018-07-23 21:14:51 +02:00
dependabot[bot] a3fd5cebc0 Bump vue-loader from 15.2.4 to 15.2.6 in /apps/accessibility
Bumps [vue-loader](https://github.com/vuejs/vue-loader) from 15.2.4 to 15.2.6.
- [Release notes](https://github.com/vuejs/vue-loader/releases)
- [Changelog](https://github.com/vuejs/vue-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-loader/compare/v15.2.4...v15.2.6)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-23 17:57:14 +00:00
Roeland Jago Douma 4cb9f35dea Merge pull request #10341 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/webpack-cli-3.1.0
Bump webpack-cli from 3.0.8 to 3.1.0 in /apps/oauth2
2018-07-23 19:54:55 +02:00
Michael Weimann 9977b1415d Uses a variable for the multiselect header offset
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-07-23 18:59:00 +02:00
Joas Schilling 3cac54b955 Don't call getUID on null when the app is loaded for a guest
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-23 16:39:03 +02:00
Joas Schilling b788f0a456 Make sure error_log() always receives a string
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-23 16:30:38 +02:00
dependabot[bot] eeab309515 Bump webpack-cli from 3.0.8 to 3.1.0 in /apps/oauth2
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.0.8 to 3.1.0.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-23 14:14:22 +00:00
Morris Jobke 29fd761301 Merge pull request #10337 from nextcloud/dependabot/npm_and_yarn/settings/vue-loader-15.2.6
Bump vue-loader from 15.2.4 to 15.2.6 in /settings
2018-07-23 16:12:28 +02:00
Morris Jobke 1755ae1cb8 Merge pull request #10335 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/webpack-cli-3.1.0
Bump webpack-cli from 3.0.8 to 3.1.0 in /apps/updatenotification
2018-07-23 15:56:21 +02:00
Morris Jobke c559e1dc6a Merge pull request #10340 from nextcloud/dependabot/npm_and_yarn/settings/webpack-cli-3.1.0
Bump webpack-cli from 3.0.8 to 3.1.0 in /settings
2018-07-23 15:54:42 +02:00
Morris Jobke 5edf36dc53 Merge pull request #10325 from nextcloud/lost-password-ldap-fix
Do not bind reset password link if an url is set
2018-07-23 15:53:18 +02:00
Roeland Jago Douma 08395b8338 Update map
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-23 15:24:28 +02:00
John Molakvoæ (skjnldsv) fee62fd20b Comply @since requirements
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-23 15:17:38 +02:00
John Molakvoæ (skjnldsv) 705439ca7b Do not bind reset password link if an url is set
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-23 15:01:03 +02:00
dependabot[bot] 83f56d0136 Bump vue-loader from 15.2.4 to 15.2.6 in /settings
Bumps [vue-loader](https://github.com/vuejs/vue-loader) from 15.2.4 to 15.2.6.
- [Release notes](https://github.com/vuejs/vue-loader/releases)
- [Changelog](https://github.com/vuejs/vue-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-loader/compare/v15.2.4...v15.2.6)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-23 14:59:25 +02:00
dependabot[bot] fa6172fa7d Bump webpack-cli from 3.0.8 to 3.1.0 in /settings
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.0.8 to 3.1.0.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-23 14:58:36 +02:00
dependabot[bot] 0119546a3a Bump webpack-cli from 3.0.8 to 3.1.0 in /apps/updatenotification
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.0.8 to 3.1.0.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-23 01:12:53 +00:00
Nextcloud bot 4d060755e5 [tx-robot] updated from transifex 2018-07-23 00:12:05 +00:00
Michael Weimann 353bd8ee8a Adjusts the files multi select header width
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-07-22 11:44:06 +02:00
Nextcloud bot 8ac1f4168d [tx-robot] updated from transifex 2018-07-22 00:12:42 +00:00
John Molakvoæ (skjnldsv) e6ded2ad5e Design fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 18:31:06 +02:00
Daniel Calviño Sánchez 70262fb11a Adjust acceptance tests to the new share link UI
The share link UI no longer uses its own layout below the other shares;
now it is shown as a share row with a menu for the actions (except
enabling it, which is shown in the row itself), just like the other
shares.

The share link is no longer shown, either; now the link is got by
clicking on a "Copy URL" menu item, which copies the link to the
clipboard. As the clipboard is not accessible from the acceptance tests
the URL is now extracted from the attributes of that menu item (although
the menu item is clicked anyway to mimic the user behaviour).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-21 17:31:11 +02:00
John Molakvoæ (skjnldsv) da0bdd1391 Design structure fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 16:09:13 +02:00
John Molakvoæ (skjnldsv) 58debbe42c Tests fixes and design bump
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:21 +02:00
Julius Härtl e302cadae2 Don't use shorthand syntax for functions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-21 15:02:21 +02:00
John Molakvoæ (skjnldsv) d4de77afb9 No remote note and various fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:21 +02:00
Bjoern Schiessle 977c462698 move the note up, so that it is also visible in the file drop view
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:21 +02:00
John Molakvoæ (skjnldsv) 3a11c26cb4 Public fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
John Molakvoæ (skjnldsv) c71d3dc9bf Public share
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
Bjoern Schiessle e951ad5034 fix unit tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:20 +02:00
Bjoern Schiessle 967a97904f fix post url
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:20 +02:00
John Molakvoæ (skjnldsv) fc2767bbbb Autoresize + autoloader
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
John Molakvoæ (skjnldsv) 0a7e34f6c8 Popovermenu migration
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
Bjoern Schiessle fa44300016 unit tests updated
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:20 +02:00
John Molakvoæ (skjnldsv) 4e08d8342e UI set share note!
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
Bjoern Schiessle 72d2455577 return the as well note if we fetch a share
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:19 +02:00
Bjoern Schiessle 660b5d1af6 fix unit tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:19 +02:00
Bjoern Schiessle 7bdedfba48 explicitely mention that the note column can be null
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:19 +02:00
Bjoern Schiessle eab4d96c4c some small template fixes
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:19 +02:00
Bjoern Schiessle 94c7052482 allow 'note' to be null
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:19 +02:00
Bjoern Schiessle b81962e3e8 fix unit tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:19 +02:00
Bjoern Schiessle 2250dbec21 add a nice looking button as direct link to the sharre
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:19 +02:00
Bjoern Schiessle 1ce519ad38 add direct link to the share
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:18 +02:00
Bjoern Schiessle b56ccef564 add direct link to the file for user/group shares
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:18 +02:00
Bjoern Schiessle a29261175d fix mail templates
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:18 +02:00
Bjoern Schiessle 4f59c8e8ae show note on public link page
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:18 +02:00
Bjoern Schiessle 73b88deeb8 add note to share object when reading it from the db
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:18 +02:00
Bjoern Schiessle c116d116fa improve mail template and escape html code
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:18 +02:00
Bjoern Schiessle a93f2a648b allow to add a personal note to a share
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:18 +02:00
Michael Weimann de7606dc68 Adds disabled user unit tests
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-07-21 13:05:25 +02:00
Michael Weimann c92d7429d7 Implements handling for deactivated users
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-07-21 13:05:13 +02:00
Nextcloud bot cce12f0ca3 [tx-robot] updated from transifex 2018-07-21 00:12:01 +00:00
Morris Jobke 53aaa62572 Merge pull request #9982 from nextcloud/global-flow-rebuild
Cleanup structure
2018-07-20 23:40:00 +02:00
John Molakvoæ (skjnldsv) 89ee10a536 Jsunit fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:38:49 +02:00
John Molakvoæ (skjnldsv) 4877cd050b Bump karma config
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:38:04 +02:00
John Molakvoæ (skjnldsv) 8d3f58c391 Jsunit fixes 1
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:38:04 +02:00
John Molakvoæ (skjnldsv) 43ab2082db Fixed filestable min-width
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:38:04 +02:00
Jan-Christoph Borchardt a9f65390f6 Widen left navigation to 300px and set max-width of right sidebar to 500px
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:38:04 +02:00
John Molakvoæ (skjnldsv) ecaf4d7008 Fix sidebar close button
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:38:04 +02:00
John Molakvoæ (skjnldsv) e27e430f1f use flex for main content
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:38:04 +02:00
John Molakvoæ (skjnldsv) 562e2aa30b Adjust acceptance tests to sidebar changes in Files app
Before, each section of the Files app ("All files", "Favorites"...) had
its own sidebar element. Now there is a single sidebar element for all
the sections in the Files app.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:38:03 +02:00
John Molakvoæ (skjnldsv) fe6f444928 Fixed sticky controls
since controls are not directly into the scollable element (app-content)
we need to make the parent the scrollable element (app-content-files)

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:37:00 +02:00
John Molakvoæ (skjnldsv) d6b718584e Sidebar fix
Fix sidebar and scrollbar on content
Sidebar fixes, and sidebar-width + header-height variables

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:37:00 +02:00
John Molakvoæ (skjnldsv) 842583038b Cleanup structure
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:35:21 +02:00
Jan-Christoph Borchardt 3e6ac57abe Add visual feedback for keyboard tab in breadcrumbs
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-07-20 23:19:55 +02:00
Jan-Christoph Borchardt e9581f2126 Make Upload entry in +Menu focusable
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-07-20 23:19:55 +02:00
John Molakvoæ (skjnldsv) 7f0d60fefc Enter key on menu registration
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:19:55 +02:00
Jan-Christoph Borchardt fe38e33d10 Fix visual keyboard tab feedback for Contacts menu icon in header
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-07-20 23:19:55 +02:00
Jan-Christoph Borchardt 9bf4827c12 Fix visual keyboard tab feedback for avatar / settings icon in header
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-07-20 23:19:55 +02:00
Jan-Christoph Borchardt 6d083c4de9 Make left sidebar toggle also work with keyboard
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-07-20 23:19:55 +02:00
Jan-Christoph Borchardt a21be0ad97 Show skip navigation links above everything, also on narrow screens
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-07-20 23:20:12 +02:00
Jan-Christoph Borchardt 98adee5579 Fix tooltip for More apps showing on focus
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-07-20 23:19:55 +02:00
Morris Jobke 52ec71c4b0 Merge pull request #10311 from nextcloud/bugfix/8702/ie11-icon-white
Add icon-black-white mixin to automatically generate icon classes
2018-07-20 20:27:49 +02:00
Julius Härtl 7b8ee2730b Move icons over to the new mixin
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-20 17:44:35 +02:00
Morris Jobke 700aafb3ee Merge pull request #10283 from nextcloud/bugfix/10094/user-management
User management polishing
2018-07-20 17:31:10 +02:00
Julius Härtl 4d5c01e066 Fix accceptance tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-20 16:49:05 +02:00
Julius Härtl 784eef16f6 Bump settings build
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-20 14:39:20 +02:00
Julius Härtl 0a14157c3b Add some responsiveness to the user management
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-20 14:37:42 +02:00
Julius Härtl a28a8f1ccb Fix cut-off name input field
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-20 14:37:41 +02:00
Julius Härtl 160ede24f6 Remove reset button from new user form
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-20 14:37:41 +02:00
Julius Härtl fd9bc638a3 Adjust user table font color
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-20 14:37:41 +02:00
Julius Härtl c5e82fc21c Only show groups header in the sidebar, if groups are available
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-20 14:37:41 +02:00
Julius Härtl 1a0792b083 Hide no more results note
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-20 14:37:41 +02:00
Julius Härtl 527a90367a Fix user management field label naming
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-20 14:37:41 +02:00
Julius Härtl 46be8e69c7 Add icon-black-white mixin to automatically generate icon classes
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-20 12:49:16 +02:00
Roeland Jago Douma a2df728fb8 Merge pull request #9581 from nextcloud/dav-acl-no-files
disable dav acl plugin for files resource
2018-07-20 12:16:45 +02:00
Morris Jobke 4536635e2a Merge pull request #10229 from nextcloud/feature/noid/allow-notifiers-to-know-if-we-prepare-push-notifications
Allow notifiers to know if we prepare push notifications
2018-07-20 11:53:12 +02:00
Morris Jobke e0d9c43c95 Merge pull request #8188 from arnowelzel/master
Avoid error messages for restricted opcache API
2018-07-20 11:48:44 +02:00
Roeland Jago Douma c6b0df6710 Merge pull request #10290 from weeman1337/fix-10234-delete-empty-groups
Fixes delete empty groups
2018-07-20 11:22:03 +02:00
Michael Weimann 37e0f85ad0 Adds tests for testing removing an empty group
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-07-20 09:51:23 +02:00
Joas Schilling 6b440cc365 Merge pull request #10296 from nextcloud/bug/noid/dont_fail_on_unkown_user
Don't fail contacts menu on unkown user
2018-07-20 03:08:32 +02:00
Nextcloud bot a927d2fc08 [tx-robot] updated from transifex 2018-07-20 00:12:09 +00:00
Morris Jobke b033669894 Merge pull request #10299 from nextcloud/fs-mtime-index
Add filecache index on mtime
2018-07-19 23:57:41 +02:00
Morris Jobke 4751f1e7f7 Merge pull request #9984 from nextcloud/inverted-svg-api
Svg color api
2018-07-19 23:54:29 +02:00
Roeland Jago Douma 9d94cc1697 Fix unit tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-19 23:18:35 +02:00
John Molakvoæ (skjnldsv) 37a4d2bbbc Php code bump
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 22:46:32 +02:00
Morris Jobke 8032e362ec Merge pull request #10291 from nextcloud/bugfix/10052/fix-lotus-notes
EMailTemplate: Fix button background in Lotus Notes
2018-07-19 19:47:22 +02:00
Robin Appelman 91d3e48ab3 Add filecache index on mtime
Gives searching by mtime and "recent" a proper index to use

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-19 17:43:20 +02:00
Joas Schilling 891de38080 Only create the schema when moving between databases
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-19 15:32:36 +02:00
Roeland Jago Douma 596655fa1a Merge pull request #10295 from nextcloud/fix/noid/fix-failing-test
Disable failing test in legacy sharing tests
2018-07-19 12:02:59 +02:00
Julius Härtl 1213a7c6a2 Fix email template tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-19 11:43:16 +02:00
Julius Härtl 7a4c23a720 Use index for format string parameters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-19 11:43:15 +02:00
Roeland Jago Douma 16bfbb78ca Don't fail contacts menu on unkown user
If for some reason the system addressbook holds a user that is no longer
accessible from the usermanager (so it got somehow out of sync) we
should not fail hard but rather just ignore the entry.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-19 11:39:28 +02:00
Morris Jobke 20f25f1b81 Merge pull request #10294 from nextcloud/bugfix/fac-104/expected-array-got-object
Make sure to always use an array as parameter
2018-07-19 11:07:00 +02:00
Morris Jobke 6a06745e57 Disable failing test in legacy sharing tests
* seems to be a race condition

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-19 11:06:23 +02:00
Joas Schilling 1e137a85b8 Make sure to always use an array as parameter
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-19 10:38:15 +02:00
Morris Jobke 9732712dda Merge pull request #10286 from nextcloud/bugfix/noid/comments-layout
Fix comment input overlay on empty discussion
2018-07-19 10:36:25 +02:00
Morris Jobke cc14ec962b Merge pull request #10288 from nextcloud/bugfix/noid/comments-mention-inline
Fix inline avatar display for mentions in comments
2018-07-19 10:35:34 +02:00
Julius Härtl bfc6fc8e50 Fix settings icon fetching
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-19 08:17:00 +02:00
Julius Härtl 9159ed3d76 Fix icon url regex
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-19 08:16:59 +02:00
Julius Härtl 6ed8c19ab9 Use proper URL prefix for icons
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-19 08:16:59 +02:00
John Molakvoæ (skjnldsv) 61946819ba Fixed svg generator regex && added missing icons
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:59 +02:00
John Molakvoæ (skjnldsv) dccfed8d1c Add versionning to icon svg color api function
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:59 +02:00
John Molakvoæ (skjnldsv) 14bc9ffda4 Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:59 +02:00
John Molakvoæ (skjnldsv) 59db5250f9 Autoloader bump
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:59 +02:00
John Molakvoæ (skjnldsv) cd6f00a102 Only dark
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:59 +02:00
John Molakvoæ (skjnldsv) a24cad1a1c Fix accessibility invert
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:58 +02:00
John Molakvoæ (skjnldsv) 9e5885963c Fixed icons detection and caching
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:58 +02:00
John Molakvoæ (skjnldsv) 8977c71f88 Mixin scss icon api
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:58 +02:00
John Molakvoæ (skjnldsv) d904293ba3 autoloader bump
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:58 +02:00
John Molakvoæ (skjnldsv) 09f591f56f Dark theme fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:58 +02:00
John Molakvoæ (skjnldsv) ccd70a4099 use built in response cacheFor function
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:58 +02:00
John Molakvoæ (skjnldsv) 29ff7efe9a Svg icon api sass function and upgrade of all styles
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:57 +02:00
John Molakvoæ (skjnldsv) 98a0113d40 Svg from app
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:30 +02:00
John Molakvoæ (skjnldsv) 84e90e26c0 Svg color api
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:30 +02:00
Julius Härtl 185cb494c0 EMailTemplate: Move background color of buttons to the table to fix rendering in lotus notes
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-19 07:49:48 +02:00
Nextcloud bot b7e32df660 [tx-robot] updated from transifex 2018-07-19 00:12:05 +00:00
Michael Weimann c17b191dfb Display the remove item even for elements without a count
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-07-18 23:09:49 +02:00
Julius Härtl 9771b70c8f Fix inline avatar display for mentions in comments
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-18 20:28:02 +02:00
Julius Härtl 750b204ac7 Fix comment input overlay on empty discussion
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-18 19:52:16 +02:00
Morris Jobke ddebdb02fb Merge pull request #10277 from nextcloud/ocs-permissions-storage-not-available
Fix getting ocs share permissions if a storage is not available
2018-07-18 17:57:55 +02:00
Roeland Jago Douma 844c740868 Merge pull request #10284 from nextcloud/exceptionserializer-isset
make exception serializer a bit more robust
2018-07-18 17:55:45 +02:00
Robin Appelman 99c00972a0 make exception serializer a bit more robust
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-18 16:56:34 +02:00
Robin Appelman d4a51447d1 Fix getting ocs share permissions if a storage is not available
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-18 14:42:39 +02:00
Nextcloud bot ad9b458c74 [tx-robot] updated from transifex 2018-07-18 00:12:04 +00:00
Roeland Jago Douma 81148e64f8 Merge pull request #10273 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/webpack-4.16.1
Bump webpack from 4.16.0 to 4.16.1 in /apps/oauth2
2018-07-17 22:48:13 +02:00
Roeland Jago Douma c7dd5f31d6 Rebuild js
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-17 22:19:59 +02:00
dependabot[bot] 4affe71e6f Bump webpack from 4.16.0 to 4.16.1 in /apps/oauth2
Bumps [webpack](https://github.com/webpack/webpack) from 4.16.0 to 4.16.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.16.0...v4.16.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-17 18:46:02 +00:00
Roeland Jago Douma c326caf101 Merge pull request #10272 from nextcloud/dependabot/npm_and_yarn/settings/webpack-4.16.1
Bump webpack from 4.16.0 to 4.16.1 in /settings
2018-07-17 20:44:05 +02:00
Roeland Jago Douma 82a39e6fdb Rebuild js
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-17 17:43:18 +02:00
dependabot[bot] afea9f2125 Bump webpack from 4.16.0 to 4.16.1 in /settings
Bumps [webpack](https://github.com/webpack/webpack) from 4.16.0 to 4.16.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.16.0...v4.16.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-17 15:42:29 +00:00
Roeland Jago Douma 8304e56872 Merge pull request #10271 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/webpack-4.16.1
Bump webpack from 4.16.0 to 4.16.1 in /apps/accessibility
2018-07-17 16:40:35 +01:00
Roeland Jago Douma d4cbddd019 rebuild js
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-17 17:13:25 +02:00
Morris Jobke 682f7b616a Merge pull request #10274 from nextcloud/bugfix/10094/filepicker-buttons-safari
Fix filepicker button layout on safari
2018-07-17 16:02:20 +02:00
Morris Jobke ee11fee93b Merge pull request #10269 from nextcloud/darktheme-beta
Clarify beta state of dark theme
2018-07-17 15:13:04 +02:00
Roeland Jago Douma 3148e9b171 Merge pull request #10268 from nextcloud/whatsnew-icon
Change what's new popover icon to checkmark, fix #10047
2018-07-17 13:46:25 +01:00
Julius Härtl c90d7c15e9 Fix filepicker button layout on safari
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-17 14:37:18 +02:00
dependabot[bot] 05198a06a0 Bump webpack from 4.16.0 to 4.16.1 in /apps/accessibility
Bumps [webpack](https://github.com/webpack/webpack) from 4.16.0 to 4.16.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.16.0...v4.16.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-17 12:24:54 +00:00
Roeland Jago Douma c36ccde417 Merge pull request #10252 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/webpack-4.16.0
Bump webpack from 4.15.1 to 4.16.0 in /apps/accessibility
2018-07-17 13:24:17 +01:00
Roeland Jago Douma d8c69b6d46 Merge pull request #10251 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/webpack-4.16.0
Bump webpack from 4.15.1 to 4.16.0 in /apps/oauth2
2018-07-17 13:23:55 +01:00
Roeland Jago Douma 9c1917606a Merge pull request #10250 from nextcloud/dependabot/npm_and_yarn/settings/webpack-4.16.0
Bump webpack from 4.15.1 to 4.16.0 in /settings
2018-07-17 13:23:33 +01:00
Roeland Jago Douma 40c9230a6b Merge pull request #10249 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/webpack-4.16.0
Bump webpack from 4.15.1 to 4.16.0 in /apps/updatenotification
2018-07-17 13:23:09 +01:00
Morris Jobke 07271087b0 Fix style of the user facing whats new popup
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-17 14:02:14 +02:00
Jan-Christoph Borchardt 4b5d7b15ff Change what's new popover icon to checkmark, fix #10047
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-07-17 13:41:57 +02:00
Jan-Christoph Borchardt 82047f2d43 Clarify beta state of dark theme
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-07-17 13:41:23 +02:00
Morris Jobke a7adc4cb3c Merge pull request #10260 from nextcloud/bugfix/7974/improved-sql-for-fetching-quota
Use the path_hash instead of the path to query the filecache
2018-07-17 13:04:18 +02:00
Morris Jobke a155f80485 Merge pull request #10230 from nextcloud/feature/shareoverview
Feature/shares overview
2018-07-17 12:53:45 +02:00
John Molakvoæ (skjnldsv) cdb42432c3 Jsuinit fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-17 12:26:57 +02:00
Nextcloud bot f78db18201 [tx-robot] updated from transifex 2018-07-17 00:12:08 +00:00
Morris Jobke 92e30698bb Reorder position of "Shared by me" and "Shared with me"
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-16 16:29:17 +02:00
Morris Jobke c0fcc0e45c Make section "deleted shares" a subsection of "shares"
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-16 16:28:57 +02:00
Morris Jobke 98cf2bab48 Rename "Shares overview" to "Shares"
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-16 16:28:26 +02:00
Morris Jobke 19c49c8473 Use the path_hash instead of the path to query the filecache
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-16 16:10:34 +02:00
dependabot[bot] 2dca8da90e Bump webpack from 4.15.1 to 4.16.0 in /apps/accessibility
Bumps [webpack](https://github.com/webpack/webpack) from 4.15.1 to 4.16.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.15.1...v4.16.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-16 01:14:51 +00:00
dependabot[bot] 0e88d62f97 Bump webpack from 4.15.1 to 4.16.0 in /apps/oauth2
Bumps [webpack](https://github.com/webpack/webpack) from 4.15.1 to 4.16.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.15.1...v4.16.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-16 01:14:06 +00:00
dependabot[bot] 35b1acef84 Bump webpack from 4.15.1 to 4.16.0 in /settings
Bumps [webpack](https://github.com/webpack/webpack) from 4.15.1 to 4.16.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.15.1...v4.16.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-16 01:13:16 +00:00
dependabot[bot] 5b2120f2e8 Bump webpack from 4.15.1 to 4.16.0 in /apps/updatenotification
Bumps [webpack](https://github.com/webpack/webpack) from 4.15.1 to 4.16.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.15.1...v4.16.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-16 01:12:52 +00:00
Nextcloud bot 23785d108d [tx-robot] updated from transifex 2018-07-16 00:12:11 +00:00
Nextcloud bot 31de711465 [tx-robot] updated from transifex 2018-07-15 00:12:06 +00:00
John Molakvoæ (skjnldsv) 18790858ca Fix share by/with check
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-14 12:14:21 +02:00
Nextcloud bot b9211c2e50 [tx-robot] updated from transifex 2018-07-14 00:12:16 +00:00
Morris Jobke 82021b2b1b Merge pull request #5280 from nextcloud/shared-with-display-name
sharedWithDisplayName & sharedWithAvatar
2018-07-13 17:29:57 +02:00
Morris Jobke 14314584ba Merge pull request #10110 from nextcloud/feature/100500/whats-new-info-users
Display What's New info to users
2018-07-13 17:25:51 +02:00
Morris Jobke 1801e4e03f Merge pull request #10168 from nextcloud/bugfix/10163/allow-utf8mb4-on-maria-10.3-or-later
MySQL 8.0+ and MariaDB 10.3+ are large prefix and barracuda by default
2018-07-13 16:23:36 +02:00
Morris Jobke 45cf2c2747 Update documentation for #10198
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-13 16:22:25 +02:00
Morris Jobke 7a5768e259 Merge pull request #10198 from tml1024/master
No need to convert to PDF with LibreOffice, just convert to PNG
2018-07-13 16:21:36 +02:00
Morris Jobke c7f8085cc2 Merge pull request #10226 from nextcloud/enable-scss-for-guest-pages
Enable SCSS for guest pages
2018-07-13 16:09:42 +02:00
Morris Jobke 0343d59c65 Merge pull request #10227 from nextcloud/bugfix/10160/ldap-bind-loop
Only bind to ldap if configuration for the first server is set
2018-07-13 15:12:34 +02:00
Morris Jobke f2b92c44a3 Merge pull request #10224 from nextcloud/fix-formatting-of-email-and-circle-shares
Fix formatting of email and circle shares
2018-07-13 14:57:47 +02:00
John Molakvoæ 9f186e1d26 Merge pull request #10225 from danielkesselberg/bugfix/8529/fix-url-generation-dav-app
Fix call to OC.generateUrl for caldav birthday calendar on/off
2018-07-13 14:54:53 +02:00
John Molakvoæ (skjnldsv) a349f2a9f5 Fixed phpunit
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-13 14:47:00 +02:00
Joas Schilling 79b540ecc3 Add return types and fully qualified function calls
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-13 13:27:52 +02:00
Joas Schilling 28d8d15a98 Allow notifiers to know whether we are preparing push notifications
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-13 13:27:51 +02:00
John Molakvoæ (skjnldsv) 34368cc031 Fixed sharing coding style and display - Added all shares overview
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Fixed if condition

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-13 12:24:12 +02:00
Björn Schießle fdb873f451 Merge pull request #10223 from nextcloud/fix-sharing
fix selection of share provider
2018-07-13 10:29:44 +02:00
John Molakvoæ (skjnldsv) e1a2bb9d69 Fix fav quickaccess ressource addition
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-13 09:57:54 +02:00
John Molakvoæ (skjnldsv) 6f45607f57 Upgraded navigation submenu management and api + created sharing submenu
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-13 09:33:57 +02:00
Julius Härtl 858bd67eff Fix tests for backup ldap server connection
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-13 09:16:57 +02:00
Julius Härtl c2616df541 Only bind if configuration for the first server is available
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-13 08:25:10 +02:00
Roeland Jago Douma 1f9e50086c Tiny start of the share overview
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-13 07:31:02 +02:00
Daniel Calviño Sánchez e062057cf6 Override server SCSS rules for confirm button in guest pages
As the server defines some SCSS rules using "XXX + .icon-confirm" the
selector is more specific than just "input" used in "guest.css", so
the server SCSS rules took precedence over the guest CSS rules. Now a
more specific selector was added to the guest and public share auth
rules; as the guest and public share auth rules are loaded after the
server ones now the guest rules for input elements take precedence over
the server ones.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-13 05:48:59 +02:00
Daniel Calviño Sánchez 06b2952cee Override server SCSS rules for inputs in guest pages
As the server defines some SCSS rules using "input:not([type='range'])"
the selector is more specific than just "input" used in "guest.css", so
the server SCSS rules took precedence over the guest CSS rules. Now that
selector was added to the guest rules too; as the guest rules are loaded
after the server ones now the guest rules for input elements take
precedence over the server ones.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-13 03:40:47 +02:00
Daniel Calviño Sánchez 26db9540d4 Remove SCSS rules for "#body-login" elements
"#body-login" is only used in the layout for guest pages. Therefore,
before SCSS was enabled for guest pages, all "#body-login" rules in SCSS
files were ignored. Now that SCSS is enabled for guest pages those rules
break the guest pages, but given that they were ignored until now they
can be safely removed.

Note, however, that all of the above refers to regular SCSS rules; those
defined in the Theming app are different, as they were converted to CSS
and used in the guest pages even when SCSS was disabled, so they do not
need to be adjusted due to SCSS being enabled now.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-13 03:11:47 +02:00
Nextcloud bot ca65b82f04 [tx-robot] updated from transifex 2018-07-13 00:12:02 +00:00
Daniel Calviño Sánchez 8c004fdc64 Enable SCSS for guest pages
SCSS is disabled for several types of pages, as the SCSS compiler uses
the cache system, which is not available for example when Nextcloud is
not installed yet. However, in regular guest pages the cache system is
available, so SCSS is now enabled for them too.

To keep the same behaviour for guest pages the guest style is
automatically added for them, as before this commit it was automatically
added due to SCSS not being used.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-13 01:55:12 +02:00
John Molakvoæ 052221abbe Merge pull request #10176 from nextcloud/newhinton/master
Add Quick-Access to favorite folder in left sidepanel in files-app #9720
2018-07-12 22:54:20 +02:00
Daniel Kesselberg 684945c1a1 Fix call to OC.generateUrl for caldav birthday calendar on/off
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-07-12 21:49:02 +02:00
Daniel Calviño Sánchez 243df99fcf Fix formatting of email and circle shares
Due to a misplaced "||" instead of "===" the condition was always met,
so every share type in the conditional chain after the remote and remote
group shares was formatted as a remote/remote group share.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-12 21:24:55 +02:00
Roeland Jago Douma 49a701eabf No draggable list anymore
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-12 20:22:35 +02:00
Bjoern Schiessle c668c5b997 fix selection of share provider
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-12 19:42:36 +02:00
Roeland Jago Douma 999dc64c72 Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-12 17:50:06 +02:00
Roeland Jago Douma e56a907dde Inject helper
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-12 17:49:52 +02:00
John Molakvoæ (skjnldsv) bd1929a3b1 Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-12 16:49:39 +02:00
John Molakvoæ (skjnldsv) ae86845062 Fixed favorite folder view display
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-12 16:49:39 +02:00
John Molakvoæ (skjnldsv) 5bac969351 Fixed invalid uid
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-12 16:49:39 +02:00
John Molakvoæ (skjnldsv) 5470b9521a Default state to collapsed and fixed code styling
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-12 16:49:39 +02:00
John Molakvoæ (skjnldsv) d8c69df018 Fix app nav menu highlight
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-12 16:49:39 +02:00
fnuesse c9995de2db Added drop-animation to sortable-list
Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Added icon-change on drag

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed Navbar-closing in app when favorites-list is toggled on mobile

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Refactored Code

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Changed to alphabetical sorting

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed deletion of folder with identical names

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Removed ability to add files to the quickaccess

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed wrong path-generation when added from favorites-star

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Removed Element from navbar when favorite-star in detailview is toggled off

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Changed Quota-Text to prevent boundarybreaks

Reverted last commit
2018-07-12 16:49:39 +02:00
fnuesse 55ebdc9344 Fix collapsible-Button when list was emptied (or got first element)
Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed Bad url-generation in javascript for new quickaccessitems

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed vertical scrolling in sortable-list which leads to "hidden" navbar

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Removed unnessessary console logs

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed Bounds in custom sorting

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Reformatted code

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed horizontalscroll on sortable-list
Fixed "stuck element" where you could not switch back to the original ordering in the sortable-list

Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2018-07-12 16:49:38 +02:00
fnuesse 9b914bd68d Set Quickaccess-ordering to custom order
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2018-07-12 16:49:38 +02:00
fnuesse df9bae41bb Removed old code
Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Removed duplicate collapse-button and changed api-endpoints

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Removed app-navigation-caption from apps.scss

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Changed api-endpoints

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed Codestyle (.js)

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Hid away extended Settings

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed reverse state

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed Missing reverse after changing sort-strategy

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed Copyright-Header

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Removed UI-Flickering

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

hid dotmenu on toggle while favorites are empty

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Added Draggable to listelements (WIP)

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Rebuild appnavigation.php with recursive function to allow easy implementation of sublists

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed draggable Sublist-Elements

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed draggable Sublist-Elements

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Added date-modified sorting option to quickaccess

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Added custom order sorting option to quickaccess

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Added custom order sorting option to quickaccess

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Added fallback for custom ordering

Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2018-07-12 16:49:38 +02:00
fnuesse edd2ab2194 Added copyright notice
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2018-07-12 16:49:38 +02:00
fnuesse bff99c6e26 Changed toggle
Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed Codestyle and changed linkgeneration

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed Codestyle

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed Codestyle (Renamed Variables)

Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2018-07-12 16:49:38 +02:00
fnuesse 60e6ac3b6e Fixed css-flashing
Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Fixed menu if initially empty

Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2018-07-12 16:49:38 +02:00
fnuesse 9cd4b53a51 Added responsive folderadding
Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Added collapsible to quickaccesslist

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Refactored Code

Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2018-07-12 16:49:38 +02:00
fnuesse ce05cb371b Fixed complete app-breakdown if no favorites are set
Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Hid three-dot menu if no favorites are selected

Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2018-07-12 16:49:38 +02:00
fnuesse fc4baed6e5 Added toggleable QuickAccess
Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Deleted wrongly commited File

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Added quickaccess-state persistence

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Started implementing sorting-algorithm for proper alphabetical display

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Finished Sorting of Quickaccess elements

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Implemented persistence for reverse-list and sorting-strategy

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Implemented initial sorting for reverse-list and sorting-strategy

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Refactored Code

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Refactored Code

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Refactored Code

Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2018-07-12 16:49:37 +02:00
fnuesse 72ace9697c Added FavoritesQuickaccess-Sidebar
Added FavoritesQuickaccess-Sidebar

Added Files-FavoritesQuickaccess-Toggle

Fixed CSS for SpacerElement

Removed Unnessessary Alerts and added Translations

Tried fixing initial Quick-Access Checkboxstate

Signed-off-by: fnuesse <fnuesse@techfak.uni-bielefeld.de>

Tried fixing initial Quick-Access Checkboxstate

Changed double-Quotes to single-Quotes

Revert webdavurl which was changed by mistake

Revert quota-icon which was changed by mistake

Changed the Folderhandling from custom-designed to nextcloud-NavigationManager-handling

Signed-off-by: fnuesse <fnuesse@techfak.uni-bielefeld.de>

Moved CSS-Spacerclass to apps.scss for global usage

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Renamed settings-caption in apps.scss to app-navigation-caption

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Removed old input-tag for showQuickAccess-state

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Removed old spacer element in files.scss

Signed-off-by: fnuesse <felix.nuesse@t-online.de>

Changed style of favorites-sublist and disabled the ability to disable files-quickaccess

Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2018-07-12 16:49:37 +02:00
Morris Jobke 09d5b61c9e Merge pull request #10213 from nextcloud/bugfix/noid/shorten-resource-table-names-to-allow-install-on-oracle
Shorten resource table names to allow install on oracle again
2018-07-12 12:30:52 +02:00
Morris Jobke 1fd7ffec03 Merge pull request #10211 from nextcloud/bugfix/10203/correctly-init-empty-arrays
Correctly init empty arrays
2018-07-12 12:23:45 +02:00
Joas Schilling daed1bed57 Also shorten the name of the invitation tokens
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-12 12:11:11 +02:00
Joas Schilling b7de6d7a24 Shorten resource table names to allow install on oracle again
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-12 11:55:19 +02:00
Joas Schilling 50ee4e1397 Correctly init empty arrays
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-12 10:41:19 +02:00
Tor Lillqvist 37c8ed4b5c No need to convert to PDF with LibreOffice, just convert to PNG
Exporting all pages of a document to a PDF is a waste of time. All we
need is a thumbnail of the first page anyway. Plus, reading that PDF
(even just the first page of it) into imagick is presumably much
slower than reading a simple PNG.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
2018-07-12 11:40:41 +03:00
Nextcloud bot e3126fa091 [tx-robot] updated from transifex 2018-07-12 00:12:42 +00:00
Morris Jobke 6f0bdb12a4 Merge pull request #10206 from nextcloud/bugfix/noid/fix-unit-tests
Fix JS unit tests
2018-07-11 22:25:14 +02:00
Morris Jobke b242044127 Merge pull request #10204 from nextcloud/fix/noid/strict_csp_eval
Disallow eval on the StrictEvalCSP
2018-07-11 22:12:46 +02:00
Morris Jobke 83b1de4493 Fix unit tests - follow up to #10197
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-11 22:02:45 +02:00
Morris Jobke 3036b1d03d Merge pull request #9895 from nextcloud/fed-group-shares
implement federated group sharing
2018-07-11 21:44:48 +02:00
Morris Jobke a89f9a238f Merge pull request #10143 from nextcloud/3rdparty/noid/aws-sdk-3.62.9
[3rdparty] Bump AWS-SDK to 3.62.9
2018-07-11 21:40:12 +02:00
Roeland Jago Douma c21cee248c Disallow eval on the StrictEvalCSP
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-11 21:12:36 +02:00
Roeland Jago Douma e2d31088ea [3rdparty] Bump AWS-SDK to 3.62.9
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-11 19:54:12 +02:00
Roeland Jago Douma d9aa5ed96d Merge pull request #9942 from nextcloud/feature/2338/invitation_response_in_email
Include accept / decline links in CalDAV invitation emails
2018-07-11 19:53:22 +02:00
Roeland Jago Douma 5262d60e94 Merge pull request #10197 from nextcloud/feature/9410/improve-opcache-feedback
Improve opcache feedback
2018-07-11 19:27:09 +02:00
Morris Jobke 3ece7b66b8 Merge pull request #10199 from nextcloud/bugfix/noid/improve-url-detection-in-comments
Improve url detection in comments
2018-07-11 17:25:50 +02:00
Morris Jobke cc9073c251 Merge pull request #10179 from nextcloud/mount-filter
Add the option to filter mounts for a user
2018-07-11 16:29:09 +02:00
Morris Jobke e35451fd4e Merge pull request #10025 from nextcloud/smb-rename-invalidargument-retry
also retry rename operation on InvalidArgumentException
2018-07-11 16:25:22 +02:00
Joas Schilling 72d17ff02c Improve url detection in comments
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-11 16:23:56 +02:00
Morris Jobke 882aab9d70 Fix detection if opcache extension is loaded
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-11 16:08:41 +02:00
Morris Jobke 7c6c3d0d76 Fix tests
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-11 16:08:41 +02:00
Cthulhux f6f49c77f7 opcache module check
Improved the speed of isOpcacheProperlySetup() (instant return instead of continuing when we're already failed), added a check for the opcache extension itself. Potentially fixes #9410

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-11 16:08:40 +02:00
Morris Jobke e8bd72ebdc Merge pull request #10193 from nextcloud/bugfix/10175/sanitize-parameter
Sanitize parameters in createSessionToken() while logging
2018-07-11 14:55:08 +02:00
Morris Jobke a11d198a06 Sanitize parameters in createSessionToken() while logging
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-11 14:26:57 +02:00
Morris Jobke 229289d206 Merge pull request #10122 from nextcloud/feature/noid/appdata-fopen-stream
Add fopen method to ISimpleFile
2018-07-11 13:40:09 +02:00
Morris Jobke 8ccb99f416 Merge pull request #10098 from nextcloud/feature/noid/ldap-image-attribute
allow admin to disable fetching of avatars as well as a specific attribute
2018-07-11 12:19:58 +02:00
Julius Härtl 6da2b7c4f6 Separate fopen into read and write methods
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-11 12:08:37 +02:00
Julius Härtl f1469e34aa Add fopen method to ISimpleFile
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-11 10:29:03 +02:00
Bjoern Schiessle 412f6a6ecc fix unit tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:21:00 +02:00
Bjoern Schiessle 0c09f566c2 add some integration tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:49 +02:00
Bjoern Schiessle f0aaf62b24 fix js tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:49 +02:00
Bjoern Schiessle 3942d731d2 update unit tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:48 +02:00
Bjoern Schiessle 5b06a7d773 update autoloader
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:48 +02:00
Bjoern Schiessle 2abc705632 start to get fed group shares into the share dialog
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:47 +02:00
Bjoern Schiessle 1d5a9c3f97 handle unshare request from owner
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:47 +02:00
Bjoern Schiessle 7d2add622e unshare from self
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:46 +02:00
Bjoern Schiessle f5a816262c accept/decline group shares
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:46 +02:00
Bjoern Schiessle 7a48a85dca fix notification when a group share is received
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:45 +02:00
Bjoern Schiessle 4c00c80a83 translate nextcloud share types to OCM share types
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:45 +02:00
Bjoern Schiessle 8bc0de3469 log error messgage
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:44 +02:00
Bjoern Schiessle b23032e4c5 implement federated group shares
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:44 +02:00
Bjoern Schiessle c8631d607e add setting to enable/disable federated group sharing
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:41 +02:00
Morris Jobke af20f1dd4b Merge pull request #10125 from nextcloud/feature/9496/comic_mimetypes
Add comicbook mimetypes
2018-07-11 09:21:29 +02:00
Morris Jobke 029219a9e7 Merge pull request #10177 from nextcloud/bugfix/noid/theming-load-with-custom-theme
Load theming app css as well if legacy theme is enabled
2018-07-11 09:09:09 +02:00
Nextcloud bot 0e0dd2a90b [tx-robot] updated from transifex 2018-07-11 00:12:15 +00:00
Roeland Jago Douma 0fe115a536 Add repair step
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-10 21:27:35 +02:00
John Oyler 489103eede Give the various comic book file formats distinct mime types so that they can be handled correctly by the preview functionality without file type checking at that point. 2018-07-10 21:23:35 +02:00
Robin Appelman 3ad6084891 Add the option to filter mounts for a user
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-10 16:49:26 +02:00
Julius Härtl 805f503814 Load theming app css as well if legacy theme is enabled
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-10 14:59:15 +02:00
Nextcloud bot a22bc0e787 [tx-robot] updated from transifex 2018-07-10 08:21:14 +00:00
Morris Jobke ed6352af0e Merge pull request #10010 from nextcloud/bugfix/9992/fix-blocking-cron-job
Unlock failed cron jobs and set a high "last_checked" value to avoid continous re-check
2018-07-09 15:49:41 +02:00
Morris Jobke 5244501f0f Merge pull request #10162 from nextcloud/sabre-put-log-exception
always log exceptions on dav write
2018-07-09 15:48:58 +02:00
Morris Jobke 6afb8af4d1 Merge pull request #10161 from nextcloud/bugfix/10158/correctly-handle-users-with-numeric-user-ids
Correctly handle users with numeric user ids
2018-07-09 15:38:16 +02:00
Joas Schilling 011fe9e0f9 MySQL 8.0+ and MariaDB 10.3+ are large prefix and barracuda by default
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-09 15:37:22 +02:00
Morris Jobke 79801ad263 Suppress potential SQL injection warning as they are false positives
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-09 14:55:47 +02:00
Morris Jobke 8a64433ec9 Add repair job for pending cron jobs
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-09 14:53:37 +02:00
Morris Jobke 8b1084adfe Only wait for cron if fix for endless wait is included
* see https://github.com/nextcloud/server/issues/9992

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-09 14:53:37 +02:00
Morris Jobke a1a29d14c8 Unlock failed cron jobs and set a high "last_checked" value to avoid continous re-check
* fixes issue where cronjobs of a not-loaded app are marked as "still running" because there is a "reserved_at" value stored
* fixed #9992

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-09 14:51:02 +02:00
Robin Appelman 8399d6070e always log exceptions on dav write
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-09 14:25:54 +02:00
Joas Schilling 1ca075a113 Correctly handle users with numeric user ids
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-09 14:22:10 +02:00
Morris Jobke ecbc1b10ae Merge pull request #10139 from chiyi4488/patch-1
Small text error
2018-07-09 13:58:43 +02:00
Morris Jobke e2320e3ded Merge pull request #10153 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/webpack-4.15.1
Bump webpack from 4.14.0 to 4.15.1 in /apps/updatenotification
2018-07-09 13:57:58 +02:00
Morris Jobke 103c8c373a Merge pull request #10120 from nextcloud/allow-to-disable-encryption
allow to disable encryption
2018-07-09 13:39:57 +02:00
dependabot[bot] ee30530bde Bump webpack from 4.14.0 to 4.15.1 in /apps/updatenotification
Bumps [webpack](https://github.com/webpack/webpack) from 4.14.0 to 4.15.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.14.0...v4.15.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-09 11:09:30 +00:00
Roeland Jago Douma a85dc8585b Merge pull request #10152 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/webpack-4.15.1
Bump webpack from 4.14.0 to 4.15.1 in /apps/accessibility
2018-07-09 13:06:32 +02:00
Roeland Jago Douma 97ee31e9f0 Merge pull request #10151 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/css-loader-1.0.0
Bump css-loader from 0.28.11 to 1.0.0 in /apps/updatenotification
2018-07-09 13:06:03 +02:00
Roeland Jago Douma e7dd94a81a Merge pull request #10150 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/babel-loader-7.1.5
Bump babel-loader from 7.1.4 to 7.1.5 in /apps/accessibility
2018-07-09 13:05:41 +02:00
dependabot[bot] 0da2178d19 Bump webpack from 4.14.0 to 4.15.1 in /apps/accessibility
Bumps [webpack](https://github.com/webpack/webpack) from 4.14.0 to 4.15.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.14.0...v4.15.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-09 10:20:04 +00:00
Roeland Jago Douma b9caed2c39 Merge pull request #10156 from nextcloud/bugfix/noid/fix-behat-version
Fix the behat version to 3.3.*
2018-07-09 12:19:48 +02:00
Roeland Jago Douma d19955d5fb Merge pull request #10148 from nextcloud/dependabot/npm_and_yarn/settings/webpack-4.15.1
Bump webpack from 4.14.0 to 4.15.1 in /settings
2018-07-09 12:18:07 +02:00
Joas Schilling e3b5ed602c Fix the behat version to 3.3.*
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-09 11:10:25 +02:00
dependabot[bot] c8b9a89da7 Bump babel-loader from 7.1.4 to 7.1.5 in /apps/accessibility
Bumps [babel-loader](https://github.com/babel/babel-loader) from 7.1.4 to 7.1.5.
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel-loader/compare/v7.1.4...v7.1.5)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-09 08:53:06 +00:00
dependabot[bot] cf574ce69d Bump css-loader from 0.28.11 to 1.0.0 in /apps/updatenotification
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 0.28.11 to 1.0.0.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v0.28.11...v1.0.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-09 08:52:58 +00:00
Roeland Jago Douma 3067dfe49e Merge pull request #10149 from nextcloud/dependabot/npm_and_yarn/settings/babel-loader-7.1.5
Bump babel-loader from 7.1.4 to 7.1.5 in /settings
2018-07-09 10:51:17 +02:00
Morris Jobke 732394396b Merge pull request #10135 from nextcloud/feature/noid/add-visio-mimetypes
Add visio mimetypes
2018-07-09 10:40:10 +02:00
dependabot[bot] 873840a110 Bump webpack from 4.14.0 to 4.15.1 in /settings
Bumps [webpack](https://github.com/webpack/webpack) from 4.14.0 to 4.15.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.14.0...v4.15.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-09 08:32:09 +00:00
Roeland Jago Douma 89bd037e07 Merge pull request #10144 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/css-loader-1.0.0
Bump css-loader from 0.28.11 to 1.0.0 in /apps/oauth2
2018-07-09 10:31:11 +02:00
Roeland Jago Douma 07e501a911 Merge pull request #10145 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/webpack-4.15.1
Bump webpack from 4.14.0 to 4.15.1 in /apps/oauth2
2018-07-09 10:29:44 +02:00
dependabot[bot] b587aa5f79 Bump css-loader from 0.28.11 to 1.0.0 in /apps/oauth2
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 0.28.11 to 1.0.0.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v0.28.11...v1.0.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-09 07:49:05 +00:00
dependabot[bot] 7a74483016 Bump babel-loader from 7.1.4 to 7.1.5 in /settings
Bumps [babel-loader](https://github.com/babel/babel-loader) from 7.1.4 to 7.1.5.
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel-loader/compare/v7.1.4...v7.1.5)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-09 07:48:59 +00:00
Roeland Jago Douma f0b356620f Merge pull request #10147 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/css-loader-1.0.0
Bump css-loader from 0.28.11 to 1.0.0 in /apps/accessibility
2018-07-09 09:46:42 +02:00
Roeland Jago Douma 5d75633814 Merge pull request #10146 from nextcloud/dependabot/npm_and_yarn/settings/css-loader-1.0.0
Bump css-loader from 0.28.11 to 1.0.0 in /settings
2018-07-09 09:46:16 +02:00
dependabot[bot] 6c7ff83a0c Bump css-loader from 0.28.11 to 1.0.0 in /apps/accessibility
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 0.28.11 to 1.0.0.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v0.28.11...v1.0.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-08 09:36:18 +00:00
dependabot[bot] f346f96206 Bump css-loader from 0.28.11 to 1.0.0 in /settings
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 0.28.11 to 1.0.0.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v0.28.11...v1.0.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-08 09:36:10 +00:00
dependabot[bot] 1c8ba34655 Bump webpack from 4.14.0 to 4.15.1 in /apps/oauth2
Bumps [webpack](https://github.com/webpack/webpack) from 4.14.0 to 4.15.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.14.0...v4.15.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-08 09:36:05 +00:00
chiyi4488 e4c583c186 Small text error
Small text error
2018-07-07 01:26:07 +08:00
Joas Schilling 5541d3dd84 Add visio mimetypes
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-06 15:16:21 +02:00
Morris Jobke 422c805e26 Merge pull request #10116 from nextcloud/lock-negative
prevent lock values from going negative with memcache backend
2018-07-06 14:50:18 +02:00
Roeland Jago Douma 3c9b12139e Merge pull request #10130 from nextcloud/3rdparty/noid/symfony-3.4.12
[3rdparty] Bump symfony depts to 3.4.12
2018-07-06 14:06:42 +02:00
Roeland Jago Douma 8f12c9d85d [3rdparty] Bump symfony depts to 3.4.12
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-06 13:18:10 +02:00
Joas Schilling 3ade347b0d Merge pull request #9791 from nextcloud/3rdparty/noid/bump_swiftmailer
Upgrade to swiftmailer-6
2018-07-06 10:39:09 +02:00
Morris Jobke 8969e100a0 Merge pull request #10128 from nextcloud/fix/noid/add_locale_to_templates
Add locale to templates
2018-07-06 10:15:51 +02:00
Roeland Jago Douma 7b848368d5 Add locale to templates
It was already added to the user template but we should add it to all
templates. Else apps that want the locale but use special templating (hi
richdocuments!) will fail.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-06 09:23:01 +02:00
Arthur Schiwon ca6094f390 wire the frontend
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-05 20:29:00 +02:00
Roeland Jago Douma de9ab49558 Merge pull request #10119 from nextcloud/bugfix/noid/fix-remnants-of-refactoring
Fix remnants of refactoring
2018-07-05 20:26:00 +02:00
Bjoern Schiessle 5d0fa12e12 allow to disable encryption
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-05 17:24:44 +02:00
Morris Jobke a9b8fb090c Fix remnants of refactoring
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-05 17:09:38 +02:00
Robin Appelman 3d5acbb1d0 prevent lock values from going negative with memcache backend
This can be caused by the code releasing more locks then it acquires,
once the lock value becomes negative it's likely that it will never be able
to change into an exclusive lock again.

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-05 14:39:10 +02:00
Arthur Schiwon 772bbd99be Backend work to provide NC whats New info to users
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-05 14:33:08 +02:00
Morris Jobke cbfcfb236f Merge pull request #9909 from nextcloud/feature/2192/allow_group_share_undeletion
Add API to undelete delete group shares
2018-07-05 13:31:58 +02:00
John Molakvoæ (skjnldsv) f39dfc7ab8 Fixed jsunit
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-05 12:43:57 +02:00
Roeland Jago Douma b49bc11fb3 Fix exception
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-05 12:43:57 +02:00
Roeland Jago Douma a1a845693b Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-05 12:43:57 +02:00
Morris Jobke ced8789f5c Fix PHPDoc
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-05 12:43:57 +02:00
John Molakvoæ (skjnldsv) 33f85f64c7 Always show menu
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-05 12:43:57 +02:00
John Molakvoæ (skjnldsv) d86c1e9503 Disable sidebar on deleted share
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-05 12:43:57 +02:00
John Molakvoæ (skjnldsv) 3b835d8076 Js magic for deleted shares
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-05 12:43:57 +02:00
John Molakvoæ (skjnldsv) 6a0552224d getDeletedSharedWith method
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-05 12:43:57 +02:00
Roeland Jago Douma d805959e81 Add API to undelete delete group shares
When a group share is deleted we keep track of this in the DB.
Right now it is only possible for a recipient to get back the share by
asking the sharer to delete it and to share it again. This doesn't
scale.

This endpoint makes it possible to get back the share.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-05 12:43:56 +02:00
Arthur Schiwon 846ab25fc0 adjust and add more unit tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-05 11:50:49 +02:00
Arthur Schiwon 343036e55c allow admin to disable fetching of avatars as well as a specific attribute
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-05 11:12:51 +02:00
Morris Jobke 86d9528bc9 Merge pull request #10103 from nextcloud/bugfix/9767/apps-management-issues
Fix remaining apps management issues
2018-07-05 10:37:26 +02:00
Julius Härtl 1e1f164ff5 Update settings js
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-04 16:19:33 +02:00
Julius Härtl ebeb2da3d3 Fix displaying errors
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-04 15:40:51 +02:00
Julius Härtl 96e65c677b Hide uninstalled apps when removing them
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-04 15:40:51 +02:00
Julius Härtl 2f332651d3 Add transition when enabling/disabling apps
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-04 15:40:51 +02:00
Julius Härtl ba13880147 Fix invalid limit parameter when fetching groups
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-04 15:40:51 +02:00
blizzz 42912a0e25 Merge pull request #10083 from nextcloud/fix/noid/ldap-unsupported-avatar-format
LDAP user should be able to set avatar if directory provides incompatible image
2018-07-04 14:37:21 +02:00
Morris Jobke 4051a23305 Merge pull request #10102 from nextcloud/bugfix/noid/fix-integration-tests-federation-2.0
Fix integration tests for Federation 2.0
2018-07-04 11:59:19 +02:00
Morris Jobke 021bd261bc Fix integration tests for Federation 2.0
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-04 11:23:39 +02:00
Morris Jobke 16d5883680 Merge pull request #10101 from nextcloud/papercut/10094/oauth_table
Do not show OAuth2 table if it is empty
2018-07-04 11:22:56 +02:00
Roeland Jago Douma 6a0c54d5bf Add warning to setup checks if the default mailer is still php
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-04 08:28:33 +02:00
Roeland Jago Douma 0cf0bcba61 Fix settings tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-04 08:28:33 +02:00
Roeland Jago Douma be7db1573d Swift to \Swift_Mailer as abstraction
* \Swift_Mailer handles starting the transport etc properly
* Fixed tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-04 08:28:33 +02:00
Roeland Jago Douma e6e6b5648a Make swift 6 compatible
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-04 08:28:33 +02:00
Roeland Jago Douma 0dd4a3e0cf Kill php mail from settings
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-04 08:28:33 +02:00
Roeland Jago Douma 65bcef8fb3 [3rdparty] Bump swiftmailer 6.0.2
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-04 08:28:33 +02:00
Roeland Jago Douma c92fe76f77 Merge pull request #10065 from nextcloud/rakekniven-patch-1
Update SettingsController.php
2018-07-04 08:26:27 +02:00
Roeland Jago Douma ba08019429 Do not show OAuth2 table if it is empty
For #10094

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-04 08:23:21 +02:00
Morris Jobke 7025f16017 Merge pull request #9345 from nextcloud/federation20
Federation 2.0
2018-07-03 23:13:47 +02:00
Roeland Jago Douma 8b683feca2 Merge pull request #10088 from nextcloud/bugfix/noid/rebuild-navigation-first
Properly insert app icons into navigation
2018-07-03 20:09:29 +02:00
Roeland Jago Douma df84c3c421 Merge pull request #10090 from nextcloud/smb-log-connection-errors
Improved logging of smb connection errors
2018-07-03 17:55:46 +02:00
Morris Jobke e97191e1de Merge pull request #10092 from nextcloud/revert/10080/undeclared-phan-warning
Revert "Fix undeclared method warning in phan"
2018-07-03 17:55:24 +02:00
Morris Jobke 10b8a4a8b1 Revert "Fix undeclared method warning in phan"
This reverts commit f3093b2401.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-03 17:46:11 +02:00
Robin Appelman 27089422e1 Improved logging of smb connection errors
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-03 14:56:37 +02:00
Julius Härtl 7b87e00db1 Properly insert app icons into navigation
If the app menu is rebuild with the first icon being updated, the whole
list was empty, therefore we need a fallback to properly insert the
element then.

Fixes https://github.com/nextcloud/dashboard/issues/10

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-03 12:14:39 +02:00
Arthur Schiwon a4dda465c2 let user set avatar in nextcloud von LDAP provides invalid image data
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-03 01:45:07 +02:00
Arthur Schiwon 552da85df8 Iron User_LDAP tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-03 00:29:34 +02:00
Morris Jobke aa64584d67 Merge pull request #10080 from nextcloud/bugfix/noid/fix-phan-warning
Fix undeclared method warning in phan
2018-07-02 17:40:39 +02:00
Morris Jobke 48b7499fa4 Merge pull request #10079 from nextcloud/search-double-slash
fix double slash in search result path when the result is in a submount
2018-07-02 15:49:27 +02:00
Morris Jobke 6e9dbe7d15 Merge pull request #10078 from nextcloud/bugfix/activity-277/invalid-actor-and-calendar-for-link-shares
Correctly parse the subject parameters for link (un)shares of calendars
2018-07-02 15:43:36 +02:00
Morris Jobke f3093b2401 Fix undeclared method warning in phan
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-02 15:38:49 +02:00
Morris Jobke fe807823d2 Merge pull request #10077 from nextcloud/lazy-search-fix
Fix lazy search backend
2018-07-02 15:37:29 +02:00
Robin Appelman 922c851494 fix double slash in search result path when the result is in a submount
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-02 14:17:38 +02:00
Joas Schilling a0a6aff772 Correctly parse the subject parameters for link (un)shares of calendars
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-02 13:57:48 +02:00
Robin Appelman 1f9f5e2e5e Fix lazy search backend
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-02 13:42:41 +02:00
Bjoern Schiessle 7ff74ae8ed cache results from ocm end-point discovery
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 12:43:43 +02:00
Bjoern Schiessle ce567b6121 remove unused code
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 12:43:43 +02:00
Bjoern Schiessle 411bae5163 fix return type from send share
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 12:43:43 +02:00
Bjoern Schiessle 511a34b08f always enable cloud federation api
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 12:43:43 +02:00
Morris Jobke 6142cd6fb4 Merge pull request #10070 from weeman1337/bug9949-2
Updates the maintenance command output
2018-07-02 12:21:11 +02:00
Bjoern Schiessle cdf8abb060 look for correct OCM permissions
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:31 +02:00
Bjoern Schiessle 086e7a0aa2 remove debug output 2018-07-02 11:29:31 +02:00
Bjoern Schiessle cfb3e80d1b remove the makefile 2018-07-02 11:29:31 +02:00
Bjoern Schiessle 8d4da30bf5 add support for different share types
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:31 +02:00
Bjoern Schiessle e251b34a8c cleanup variable naming, it is actually a resource type
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:31 +02:00
Bjoern Schiessle 5c8b26248b let the actual federated share provider check if incoming/outgoing shares are enabled for the specific resource type
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:30 +02:00
Bjoern Schiessle 22d9246134 send the display name back after a federated share was received
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:30 +02:00
Bjoern Schiessle 27814127dd make sure that remote url gets stored with a trailing '/'
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:30 +02:00
Bjoern Schiessle 21b8a873d5 implement config check
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:30 +02:00
Bjoern Schiessle 9365fd2534 fix external manager tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:30 +02:00
Bjoern Schiessle 2e19213695 fix notification tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:30 +02:00
Bjoern Schiessle 9d145bb5dd update tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:30 +02:00
Bjoern Schiessle 5d0d33a0d4 remove unused method
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:29 +02:00
Bjoern Schiessle 34c4527cc4 add ocm-provider to the list of expected files
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:29 +02:00
Bjoern Schiessle 84fc188dfc some minor fixes and clode cleanup
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:29 +02:00
Bjoern Schiessle 957b27f282 replace \OCP\Federation\Exception\ShareNotFoundException with the generic \OCP\Share\Exception\ShareNotFound exception
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:29 +02:00
Bjoern Schiessle 61485e3e60 fix check for reshare permissions
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:29 +02:00
Bjoern Schiessle ed415726d3 send RESHARE_CHANGE_PERMISSION message
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:29 +02:00
Bjoern Schiessle 2bb1956c1f implement RESHARE_UNDO notification
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:29 +02:00
Bjoern Schiessle d77eedd23b - Don't remove share before all notifications are created, otherwise we miss information necessary to create the notifications
- Don't send message to owner/sharer about revoked re-shares twice.

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:29 +02:00
Bjoern Schiessle a176a1f318 implement unshare notification
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:28 +02:00
Bjoern Schiessle fab4e561f4 send reshare over OCM API
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:28 +02:00
Bjoern Schiessle 41a1528888 implement decline share
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:28 +02:00
Bjoern Schiessle b7b84305a3 fix capabilities
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:28 +02:00
Bjoern Schiessle c572e84ad9 detect correctly if a share was send successful
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:28 +02:00
Bjoern Schiessle 8889e14c7c implement accept share notification
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:28 +02:00
Bjoern Schiessle bbce8c3ea1 adjust to latest api version
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:28 +02:00
Bjoern Schiessle daba042d26 update capabilities
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:27 +02:00
Bjoern Schiessle af178ef19a check API Version
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:27 +02:00
Bjoern Schiessle db428ea547 send accept share notification (WIP)
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:27 +02:00
Bjoern Schiessle a3948e8a12 use new API to send a federated share if possible
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:27 +02:00
Bjoern Schiessle 6208f250e8 check if cloud federation api is ready
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:27 +02:00
Bjoern Schiessle 4c8f3d6d77 add cloud federation api app
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:27 +02:00
Bjoern Schiessle 21e64ec7f4 implement receiving of federated shares
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:27 +02:00
Bjoern Schiessle 5cfe20675d start implementing federated sharing 2.0
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:27 +02:00
Roeland Jago Douma 22bb834c48 Merge pull request #10071 from nextcloud/apps-fix-message-translation
Fix hardcoded messages in app details view
2018-07-02 09:39:20 +02:00
Kevin Ndung'u f4c2a81258 Fix hardcoded message in app details view 2018-07-02 00:19:16 +03:00
Michael Weimann 9bd48e7c0d Adds an info if the maintenance mode is already enabled/disabled.
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-07-01 20:56:27 +02:00
Michael Weimann 03a5856541 Disables the maintenance warning for the maintenance command itself.
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-07-01 20:54:19 +02:00
dependabot[bot] a014129804 Merge pull request #10062 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/webpack-4.14.0 2018-06-30 08:15:34 +00:00
dependabot[bot] 32f6f56ae7 Bump webpack from 4.12.2 to 4.14.0 in /apps/oauth2
Bumps [webpack](https://github.com/webpack/webpack) from 4.12.2 to 4.14.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.12.2...v4.14.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-30 07:21:27 +00:00
dependabot[bot] 99e6191dd8 Merge pull request #10064 from nextcloud/dependabot/npm_and_yarn/settings/webpack-4.14.0 2018-06-30 07:20:21 +00:00
dependabot[bot] 31270e7cb2 Merge pull request #10063 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/webpack-4.14.0 2018-06-30 07:19:51 +00:00
rakekniven b24b5bd297 Update SettingsControllerTest.php
adapted test for grammar change of URL
2018-06-30 08:51:58 +02:00
rakekniven 8370111cf4 Update SettingsController.php
Grammar fix. Uppercase URL
See https://www.transifex.com/nextcloud/nextcloud/translate/#de/$/146983238?q=issue%3Aopen
2018-06-30 08:49:44 +02:00
blizzz 2f8ebe2b35 Merge pull request #10048 from nextcloud/feature/9760/systemd-logger
Systemd Logger
2018-06-30 00:57:30 +02:00
Arthur Schiwon 83339ae10c use older image for disabled redis tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-30 00:29:46 +02:00
dependabot[bot] 6e0c822112 Bump webpack from 4.12.2 to 4.14.0 in /settings
Bumps [webpack](https://github.com/webpack/webpack) from 4.12.2 to 4.14.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.12.2...v4.14.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-29 20:14:52 +00:00
dependabot[bot] 57410e9e17 Bump webpack from 4.12.2 to 4.14.0 in /apps/updatenotification
Bumps [webpack](https://github.com/webpack/webpack) from 4.12.2 to 4.14.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.12.2...v4.14.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-29 20:13:00 +00:00
Roeland Jago Douma 0f46ba43b3 Merge pull request #10061 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/webpack-4.14.0
Bump webpack from 4.12.2 to 4.14.0 in /apps/accessibility
2018-06-29 22:00:48 +02:00
Roeland Jago Douma 9b6c0ac13c Merge pull request #10041 from liamdennehy/10001/trashbin-defaults
Safe default behaviour when no users are specified on trashbin:cleanup
2018-06-29 21:39:16 +02:00
dependabot[bot] 52855d8a6a Bump webpack from 4.12.2 to 4.14.0 in /apps/accessibility
Bumps [webpack](https://github.com/webpack/webpack) from 4.12.2 to 4.14.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.12.2...v4.14.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-29 19:25:47 +00:00
Roeland Jago Douma 68f403cea2 Fix and extend tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-29 20:48:09 +02:00
Morris Jobke 501ee33554 Merge pull request #10054 from nextcloud/controls-bg
Fix controls background
2018-06-29 15:24:27 +02:00
Morris Jobke e4c3c481a2 Merge pull request #10038 from nextcloud/files-scan-home-only
Add option to only scan the home storage
2018-06-29 15:23:15 +02:00
Morris Jobke 69e92ea71a Merge pull request #10053 from nextcloud/feature/7378/password-security-move
Move password change to security settings
2018-06-29 14:53:09 +02:00
Morris Jobke c76c8a69dc Merge pull request #10028 from nextcloud/feature/noid/settings-papercuts
Fix some minor settings UI issues
2018-06-29 14:38:38 +02:00
Julius Härtl 94dcddc45e Do not hide reset button
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-29 14:12:07 +02:00
Julius Härtl b47085c8fe Fix grid layout after rebase
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-29 14:12:07 +02:00
Julius Härtl 78e1d9fbd5 Bump autoloader and fix tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-29 14:12:06 +02:00
Julius Härtl d6947a56c0 Adjust collaborative tags and automated tagging settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-29 14:12:06 +02:00
Julius Härtl 0ec483b668 Fix padding in devices/sessions list
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-29 14:12:06 +02:00
Julius Härtl ff2c819ed3 Move social buttons to the personal settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-29 14:12:05 +02:00
Julius Härtl 97c13debdc Remove unneeded param from personal settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-29 13:35:07 +02:00
Julius Härtl 77f0633e59 Fix tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-29 13:35:07 +02:00
Julius Härtl 3f77b0fc8b Move user password form to security settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-29 13:35:07 +02:00
Morris Jobke a788f49114 Merge pull request #10046 from nextcloud/fix-getting-the-information-of-a-group-share-as-a-sharee
Fix getting the information of a group share as a sharee
2018-06-29 13:14:41 +02:00
John Molakvoæ (skjnldsv) 6de49f7dc6 Fix controls background
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-29 13:12:56 +02:00
Morris Jobke bff20585c7 Merge pull request #10045 from nextcloud/groups-creation-fixes
Fix new group selection
2018-06-29 12:55:53 +02:00
John Molakvoæ (skjnldsv) b495716daf Fix new group selection
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-29 12:27:34 +02:00
Morris Jobke 322a113cc5 Merge pull request #10049 from nextcloud/fix-code-integrity-check-link
Fix code integrity check-warning link
2018-06-29 12:20:10 +02:00
Marius Blüm f824ff500d Fix code integrity check-warning link
Signed-off-by: Marius Blüm <marius@lineone.io>
2018-06-29 11:33:29 +02:00
Morris Jobke 478b95cc20 Try to not run into the white page of death and still log something in the web server error log
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-29 11:22:05 +02:00
Arthur Schiwon eded07f28f whitelist audit.log
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-29 11:03:13 +02:00
Roeland Jago Douma f12922c7bf Bump version of app else migrations don't run
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-29 10:45:47 +02:00
Georg Ehrke 4aa4e4080c Include accept / decline links in CalDAV invitation emails
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-29 10:44:44 +02:00
Morris Jobke 326f07e756 Merge pull request #8854 from nextcloud/drop-old-sharing-code
Get rid of shareItem
2018-06-29 10:40:32 +02:00
Johannes Ernst 32647a4855 Applied patch for CI to work per https://github.com/nextcloud/server/pull/9760#issuecomment-396888591
Signed-off-by: Johannes Ernst <jernst@indiecomputing.com>
2018-06-29 10:37:46 +02:00
Johannes Ernst 72340b2230 Added Systemd.log documentation to config.sample.php
Changed name of default system (not systemd) logger from ownCloud to Nextcloud, to be consistent
Fixed license per https://github.com/nextcloud/server/pull/9760#discussion_r195026784
Pulled upstream updates

Signed-off-by: Johannes Ernst <jernst@indiecomputing.com>
2018-06-29 10:37:46 +02:00
Johannes Ernst 0a65e62f29 Added a logger for systemd/journald
Added a unit test

Signed-off-by: Johannes Ernst <jernst@indiecomputing.com>
2018-06-29 10:37:45 +02:00
Morris Jobke 3ff3141a1e Merge pull request #9705 from nextcloud/feature/9163/whatsnew-admin-gui
display whats new info in admin settings
2018-06-29 10:36:04 +02:00
Morris Jobke 17a9024fac Improved wording
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-29 10:33:12 +02:00
Morris Jobke 79f16f9d46 Merge pull request #10037 from nextcloud/dav-options-search
Fix search related results in OPTIONS requests
2018-06-29 09:36:12 +02:00
Morris Jobke 11f26be545 Bump version to trigger migration
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-29 09:11:04 +02:00
Roeland Jago Douma 000c302505 Update Vue settings
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-29 09:11:04 +02:00
Arthur Schiwon 241b59f458 adjust tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-29 09:11:04 +02:00
Arthur Schiwon 6044733b2d fix build step
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-29 09:11:04 +02:00
Arthur Schiwon 89c3010d14 fix updating the db row due to lacking id col
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-29 09:11:04 +02:00
Roeland Jago Douma 4e073010df Rebuild
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-29 09:11:04 +02:00
Arthur Schiwon c7728c9a16 updated production js files
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-29 09:11:04 +02:00
Arthur Schiwon 25d9c3e529 adjust backend and gui to update and changelog server
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-29 09:11:04 +02:00
John Molakvoæ (skjnldsv) 4ed8ee1c1e Unify vue template design
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-29 09:08:33 +02:00
John Molakvoæ (skjnldsv) 790c897d98 various fixes, typo, center popover, updated build
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-29 09:08:33 +02:00
John Molakvoæ (skjnldsv) a9e59ff732 Popover design fixes and settings update
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-29 09:08:33 +02:00
Arthur Schiwon 427ac19e91 adjust and reuse apps.css, makes additional class and rules unnecessary
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-29 09:08:33 +02:00
Arthur Schiwon 3fa5e46019 CSS fixes
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-29 09:08:33 +02:00
Arthur Schiwon dfc56e4f03 do things with npm so make build-js-production succeeds without complaints
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-29 09:08:33 +02:00
Arthur Schiwon 7ad0a43cc1 fix method declaration
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-29 09:08:33 +02:00
Arthur Schiwon 1e0761c6b8 adjust tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-29 09:08:33 +02:00
Arthur Schiwon bafb6b3c29 display whats new info in admin settings
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-29 09:08:33 +02:00
Daniel Calviño Sánchez d523777843 Extend integration tests to get the info of a group share as a sharee
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-29 08:20:19 +02:00
Daniel Calviño Sánchez 6cb2cb33ac Fix getting the information of group share as a sharee
When the receiver of a group share modifies it (for example, by moving
it to a different folder) the original share is not modified, but a
"ghost" share that keeps track of the changes made by that specific user
is used instead.

By default, the method "getShareById" in the share provider returns the
share from the point of view of the sharer, but it can be used too to
get the share from the point of view of a sharee by providing the
"recipient" parameter (and if the sharee is not found then the share is
returned from the point of view of the sharer).

The "ShareAPIController" always formats the share from the point of view
of the current user, but when getting the information of a specific
share the "recipient" parameter was not given, so it was always returned
from the point of view of the sharer, even if the current user was a
sharee. Now the "recipient" parameter is set to the current user, and
thus the information of the share is returned from the point of view of
the current user, be it the sharer or a sharee.

Note that this special behaviour of "getShareById" happens only with
group shares; with other types of shares the share is the same for the
sharer and the sharee, and thus the parameter is ignored; it was added
for them too just for consistency.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-29 08:20:19 +02:00
Morris Jobke 61842f66ee Merge pull request #5623 from nextcloud/locale-setting
Add user locale/region setting
2018-06-29 08:03:43 +02:00
Morris Jobke c1682f4228 Update PHPDoc
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-29 08:02:50 +02:00
Morris Jobke 89b6ee1a45 Merge pull request #9773 from nextcloud/feature/noid/resource_booking
resource booking
2018-06-29 06:51:49 +02:00
Morris Jobke e6780c4fc7 Merge pull request #10043 from nextcloud/bugfix/noid/mergejs-css-vars
Run mergejs to add css-vars-ponyfill
2018-06-29 06:51:16 +02:00
Nextcloud bot ab1b848268 [tx-robot] updated from transifex 2018-06-29 00:12:08 +00:00
blizzz 28e64afb8c Merge pull request #10034 from nextcloud/fix/noid/ldap-silence-quota-logmsgs
lower log level for quota manipulation cases
2018-06-28 23:06:23 +02:00
Liam Dennehy 68e41a3aae trashbin:cleanup exceptions for invalid options
* throw on no parameters provided
* throw on --all-users and userid provided

Signed-off-by: Liam Dennehy <liam@wiemax.net>
2018-06-28 22:31:27 +02:00
Julius Härtl c04060243a Run mergejs to add css-vars-ponyfill
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-28 22:16:32 +02:00
Arthur Schiwon cc51a00c93 lower log level for quota manipulation cases
and simplify the forest of ifs a little bit

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-28 21:10:07 +02:00
Roeland Jago Douma 9ad0e61df6 Merge pull request #10040 from nextcloud/fix-filenames-in-sharing-integration-tests
Fix filenames in sharing integration tests
2018-06-28 19:32:24 +02:00
Roeland Jago Douma dd880d1319 Merge pull request #10042 from nextcloud/fix-variable-not-replaced-in-behat-yml-when-default-value-was-used
Fix variable not replaced in "behat.yml" when default value was used
2018-06-28 19:31:19 +02:00
Georg Ehrke 4c1e581f47 docblock version fixes
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-28 17:37:16 +02:00
Daniel Calviño Sánchez ea6b5063b5 Fix variable not replaced in "behat.yml" when default value was used
As "selenium.server" is a simulated variable it is not recognized by
Mink, so it must be always replaced by its value in "behat.yml" before
the file is parsed by Behat.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-28 17:32:38 +02:00
John Molakvoæ (skjnldsv) 325403ac24 Design fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-28 17:28:27 +02:00
Morris Jobke 111c6ceef9 Merge pull request #10039 from nextcloud/ci/noid/disable-codecov-status-and-comment
Disable codecov status and comment
2018-06-28 17:17:25 +02:00
Liam Dennehy 6bc3d3781d Default behaviour when no users are specified on trashbin:cleanup
* Add option --all-users to explicitly clean all trashbins
* Reject no users on commandline and no --all-users
* Warn when --all-users and userids are specified

Signed-off-by: Liam Dennehy <liam@wiemax.net>
2018-06-28 17:14:45 +02:00
Daniel Calviño Sánchez b506ec1c89 Check all paths for own files and shares
Add "PARENT (2)" and its subdirectories to the paths to be checked, as
before only the own "PARENT" folder was being checked, but not the
shared one.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-28 16:45:42 +02:00
Daniel Calviño Sánchez e1c28c403d Fix filenames in sharing integration tests
When a file is shared and the receiver of the share already has a file
with the same name that file is left untouched, and "(2)" is appended to
the name of the shared file.

As "textfile0.txt" is included in the user folder skeleton all the users
in the integration test have that file, so when it is shared the
receiver sees the share as "/textfile0 (2).txt", and her own file as
"/textfile0.txt".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-28 16:36:19 +02:00
Morris Jobke 096c92cbee Disable codecov status and comment
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-28 16:34:16 +02:00
Robin Appelman b9e685236f Add option to only scan the home storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-28 16:09:25 +02:00
Robin Appelman b21bec5c73 Fix search related results in OPTIONS requests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-28 14:54:46 +02:00
Roeland Jago Douma 388ea2234f Merge pull request #10036 from nextcloud/feature/9221/show-path-in-log
Log path of file that failed to be parsed
2018-06-28 11:36:24 +02:00
Morris Jobke d4692d1fbe Log path of file that failed to be parsed
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-28 11:09:50 +02:00
Georg Ehrke ab43251a45 Call Backgroundjob with parameter, as interface requires
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-28 10:55:47 +02:00
Morris Jobke a077c129c8 Merge pull request #10031 from nextcloud/fix/9987/ldap-backupserver-connect
LDAP backup server should not be queried when auth fails
2018-06-28 08:38:52 +02:00
Nextcloud bot 1bf486d93f [tx-robot] updated from transifex 2018-06-28 00:12:20 +00:00
Arthur Schiwon 7a728f2154 LDAP backup server should not be queried when auth fails
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-27 23:12:07 +02:00
Georg Ehrke 8c73b13ac8 move locales file to /resources/
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-27 21:52:19 +02:00
Georg Ehrke b17d256761 fix use of findLocale
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-27 21:52:19 +02:00
Georg Ehrke 9157086c23 properly handle force_locale setting
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-27 21:52:19 +02:00
Georg Ehrke b3921c65a6 cache available locales to minimize fs access
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-27 21:52:19 +02:00
Georg Ehrke 51a35c23f6 fix camelCase for localesForLanguage
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-27 21:52:18 +02:00
Georg Ehrke 3ffeb4ae06 fix tests / mistakes made during rebase
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-27 21:52:04 +02:00
Roeland Jago Douma ad2ef3a81f Merge pull request #10020 from nextcloud/bugfix/spreed-1007/email-address-misparsed-in-comments-and-chat
Fix "parsing" of email-addresses in comments and chat messages
2018-06-27 20:40:47 +02:00
Roeland Jago Douma 0872f0b4b2 Merge pull request #10018 from nextcloud/rakekniven-patch-2
Update root.vue
2018-06-27 20:22:31 +02:00
Morris Jobke aa99be29ba Merge pull request #10027 from nextcloud/feature/noid/settings-groupware
Add groupware settings section
2018-06-27 20:04:02 +02:00
Julius Härtl f3949cf1a8 Add groupware settings section
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-27 19:16:21 +02:00
Morris Jobke 9b2d855d19 Merge pull request #10023 from nextcloud/bugfix/noid/class-name-already-in-use
Use the correct Base class
2018-06-27 17:21:37 +02:00
Robin Appelman 431710a5aa also retry rename operation on InvalidArgumentException
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-27 15:33:51 +02:00
Joas Schilling 826ea8c3f9 Use the correct Base class
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-06-27 14:17:00 +02:00
Morris Jobke 314ad266d5 Compile app
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-27 13:47:31 +02:00
Georg Ehrke 0cacdd3132 show locale example and apply new locale right away
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-27 13:19:50 +02:00
Georg Ehrke fd41192bb4 fix OC.getLocale()
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-27 13:19:49 +02:00
Georg Ehrke 9af82296c7 fix position of locale input
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-27 13:19:48 +02:00
Thomas Citharel bf6bfad76b OC.getLocale() now returns Locale and no longer Language
Added OC.getLanguage() to get Language
<html lang=''> still gets language, though according to IETF BCP47 locale should be good.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-06-27 13:19:40 +02:00
Thomas Citharel 7d8124ad66 add findLocale() to public interface
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-06-27 13:19:23 +02:00
Thomas Citharel abab7eb7f0 handle config.php values
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-27 13:19:23 +02:00
Thomas Citharel 4a9f8623b5 Fix review & tests
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-06-27 13:19:21 +02:00
Thomas Citharel 93011579fe Add tests
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-06-27 13:17:43 +02:00
Thomas Citharel ea380b2918 Allow apps to specify locale for localisation
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-06-27 13:17:26 +02:00
Thomas Citharel d8921ccd85 Allow user to choose locale
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-06-27 13:15:19 +02:00
Joas Schilling e1936a49e7 Fix "parsing" of email-addresses in comments and chat messages
\\b matches any non-word character, including \@ and \-
In order to not detect urls in the middle of email-addresses,
we need to check for white space characters and beginning of the
message instead.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-06-27 13:04:05 +02:00
Roeland Jago Douma 221f558f66 Merge pull request #10016 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/webpack-4.12.2
Bump webpack from 4.12.1 to 4.12.2 in /apps/accessibility
2018-06-27 12:47:53 +02:00
Roeland Jago Douma 719f62b9c9 Merge pull request #10013 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/webpack-4.12.2
Bump webpack from 4.12.1 to 4.12.2 in /apps/oauth2
2018-06-27 12:47:08 +02:00
Morris Jobke e4e3387417 Merge pull request #10009 from nextcloud/techdebt/noid/replace-headers-with-http_response_code-calls
Replace hard coded HTTP status codes with proper calls to http_response_code
2018-06-27 12:14:52 +02:00
Morris Jobke d984be7e2a Merge pull request #10019 from nextcloud/accessibility-skip-translatable
Make skip navigation links translatable
2018-06-27 12:09:56 +02:00
Nextcloud bot 46b62ff579 [tx-robot] updated from transifex 2018-06-27 10:06:12 +00:00
Jan-Christoph Borchardt 4afdf922f2 Make skip navigation links translatable
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-06-27 11:37:08 +02:00
rakekniven 94f5a21b48 Update root.vue
Fix for #8897 (Description of stable is not suitable )
2018-06-27 11:30:24 +02:00
dependabot[bot] fab3377ebb Bump webpack from 4.12.1 to 4.12.2 in /apps/accessibility
Bumps [webpack](https://github.com/webpack/webpack) from 4.12.1 to 4.12.2.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.12.1...v4.12.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-27 09:17:57 +00:00
dependabot[bot] e7cc2dd01c Bump webpack from 4.12.1 to 4.12.2 in /apps/oauth2
Bumps [webpack](https://github.com/webpack/webpack) from 4.12.1 to 4.12.2.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.12.1...v4.12.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-27 09:17:55 +00:00
Julius Härtl 81ad19b4e2 Merge pull request #10015 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/webpack-4.12.2
Bump webpack from 4.12.1 to 4.12.2 in /apps/updatenotification
2018-06-27 11:15:34 +02:00
dependabot[bot] 08aebce923 Bump webpack from 4.12.1 to 4.12.2 in /apps/updatenotification
Bumps [webpack](https://github.com/webpack/webpack) from 4.12.1 to 4.12.2.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.12.1...v4.12.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-27 08:08:42 +00:00
John Molakvoæ 3d44c1e6ac Merge pull request #10014 from nextcloud/dependabot/npm_and_yarn/settings/webpack-4.12.2
Bump webpack from 4.12.1 to 4.12.2 in /settings
2018-06-27 10:06:37 +02:00
dependabot[bot] 11853855ee Bump webpack from 4.12.1 to 4.12.2 in /settings
Bumps [webpack](https://github.com/webpack/webpack) from 4.12.1 to 4.12.2.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.12.1...v4.12.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-27 07:32:56 +00:00
Nextcloud bot a6666071be [tx-robot] updated from transifex 2018-06-27 00:11:52 +00:00
Morris Jobke e9001fecb6 Merge pull request #10005 from nextcloud/group-exists-error
show error message when group exists
2018-06-26 17:35:55 +02:00
Morris Jobke 2b8a4f1aeb Merge pull request #10007 from nextcloud/feature/noid/oauth_valid_redirect_uri
Validate OAuth2 redirect uri
2018-06-26 17:31:54 +02:00
Roeland Jago Douma 555de27567 Validate OAuth2 redirect uri
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-26 16:15:53 +02:00
Morris Jobke b0a296e2e1 Do not use HTTP code OC_Response constants anymore
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-26 16:14:15 +02:00
Morris Jobke 79d9841bce Replace hardcoded status headers with calls to http_response_code()
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-26 16:14:15 +02:00
Morris Jobke d9d557a5ef Merge pull request #10004 from nextcloud/accessibility-skip
Add skip navigation / skip to content links for accessibility
2018-06-26 16:11:19 +02:00
Morris Jobke cfb50fdeaf Merge pull request #10006 from nextcloud/group-exists-details
Fix groupExists when a backend provides group details
2018-06-26 16:09:53 +02:00
Roeland Jago Douma 890cd746e4 Merge pull request #10003 from nextcloud/accessibility-package-deps-fix
Fix deps security
2018-06-26 15:29:49 +02:00
Robin Appelman 290b5b5461 show error message when group exists
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-26 15:00:54 +02:00
Robin Appelman 605ba57086 Fix groupExists when a backend provides group details
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-26 15:00:08 +02:00
Jan-Christoph Borchardt de5d5ee0e7 Add skip navigation / skip to content links
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-06-26 14:26:30 +02:00
Morris Jobke 43f7ea5852 Merge pull request #10002 from nextcloud/docs/noid/phpdoc-putContent-resource
Add resource type phpDoc for putContent methods
2018-06-26 13:59:21 +02:00
Julius Härtl 73cf71a20f Add resource type phpDoc for putContent methods
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-26 13:58:58 +02:00
John Molakvoæ (skjnldsv) 66f71ac42e Fix deps security
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-26 13:49:33 +02:00
Roeland Jago Douma beea287516 Merge pull request #10000 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/webpack-4.12.1
Bump webpack from 4.12.0 to 4.12.1 in /apps/accessibility
2018-06-26 13:48:39 +02:00
Robin Appelman 3281c74bc1 Merge pull request #9635 from nextcloud/smb-kerberos
Add support for using kerberos ticket to authenticate to smb servers
2018-06-26 13:21:40 +02:00
dependabot[bot] 77e39493ce Bump webpack from 4.12.0 to 4.12.1 in /apps/accessibility
Bumps [webpack](https://github.com/webpack/webpack) from 4.12.0 to 4.12.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.12.0...v4.12.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-26 10:56:20 +00:00
Roeland Jago Douma c4ef8acce7 Merge pull request #9999 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/webpack-cli-3.0.8
Bump webpack-cli from 3.0.4 to 3.0.8 in /apps/accessibility
2018-06-26 12:54:45 +02:00
Morris Jobke 1bb552761b Merge pull request #9995 from nextcloud/bugfix/noid/error-page-with-500-http-code
Server error/hint pages with a 500 error code to avoid it being seen …
2018-06-26 12:30:37 +02:00
dependabot[bot] 78e6324b69 Bump webpack-cli from 3.0.4 to 3.0.8 in /apps/accessibility
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.0.4 to 3.0.8.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/compare/v3.0.4...v3.0.8)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-26 10:07:52 +00:00
Roeland Jago Douma 684ee622a1 Merge pull request #9998 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/webpack-merge-4.1.3
Bump webpack-merge from 4.1.2 to 4.1.3 in /apps/accessibility
2018-06-26 12:05:45 +02:00
Morris Jobke 1399f6bece Server exception error pages by default with a 500 status code
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-26 11:44:24 +02:00
Morris Jobke 8c155cd51c Server error/hint pages with a 500 error code to avoid it being seen instead of the actual resource
* found while reviewing #7205
* allow to specify a special status code

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-26 11:44:24 +02:00
Morris Jobke a97cc293b5 Merge pull request #9966 from nextcloud/resend-welcome-email
Resend activation email for new users as admin
2018-06-26 11:41:27 +02:00
Morris Jobke f5698910fc Merge pull request #9996 from nextcloud/bugfix/noid/Morikko-config-write-code-error
Change status code when config is write protected
2018-06-26 11:39:50 +02:00
dependabot[bot] 542fa32452 Bump webpack-merge from 4.1.2 to 4.1.3 in /apps/accessibility
Bumps [webpack-merge](https://github.com/survivejs/webpack-merge) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/survivejs/webpack-merge/releases)
- [Changelog](https://github.com/survivejs/webpack-merge/blob/master/CHANGELOG.md)
- [Commits](https://github.com/survivejs/webpack-merge/compare/v4.1.2...v4.1.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-26 08:42:50 +00:00
Eric Masseran a34f70ce0a Change status code when config is write protected
Add hint msg, you can make config file read only

If the config.php is not writable, print an error message: #6893
 - set config writable
 - or set option to keep it read only

Signed-off-by: Eric Masseran <rico.masseran@gmail.com>
2018-06-26 09:36:17 +02:00
John Molakvoæ (skjnldsv) d3d357fb94 Resend activation email for new users as admin
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-26 09:18:49 +02:00
Joas Schilling 4b49f810b7 Re-enable apps that got automatically disabled while updating
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-06-26 09:15:52 +02:00
John Molakvoæ f148e3fb29 Merge pull request #9862 from nextcloud/accessibility
Accessibility 
2018-06-26 09:04:17 +02:00
Roeland Jago Douma dfbc21d806 Merge pull request #9991 from nextcloud/i10n/noid/use-translation-placeholder
Use a placeholder instead of magic string concatenation
2018-06-26 08:59:14 +02:00
Joas Schilling 3784ef9fbb Use a placeholder instead of magic string concatenation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-06-26 08:22:20 +02:00
Morris Jobke 4b8637fa85 Merge pull request #9980 from nextcloud/dependabot/npm_and_yarn/settings/webpack-4.12.1
Bump webpack from 4.12.0 to 4.12.1 in /settings
2018-06-26 08:04:32 +02:00
Morris Jobke a17750df7e Merge pull request #9956 from kevgathuku/enable-outline
Add focus indicator to File Details tabs view
2018-06-26 08:03:45 +02:00
Morris Jobke d611399027 Merge pull request #9979 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/webpack-4.12.1
Bump webpack from 4.12.0 to 4.12.1 in /apps/oauth2
2018-06-26 08:01:33 +02:00
Nextcloud bot 18cf85d264 [tx-robot] updated from transifex 2018-06-26 00:12:07 +00:00
Roeland Jago Douma 2e36069e24 Merge pull request #9977 from nextcloud/settings-padding
No more extra padding for the app settings
2018-06-25 23:06:39 +02:00
Roeland Jago Douma 3bc3ff38f3 Bump webpack
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-25 20:27:06 +02:00
John Molakvoæ (skjnldsv) 8765231782 Bump build
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 20:26:06 +02:00
dependabot[bot] 69cef3d6cd Bump webpack from 4.12.0 to 4.12.1 in /apps/oauth2
Bumps [webpack](https://github.com/webpack/webpack) from 4.12.0 to 4.12.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.12.0...v4.12.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-25 20:26:06 +02:00
dependabot[bot] 6595636b2e Bump webpack from 4.12.0 to 4.12.1 in /settings
Bumps [webpack](https://github.com/webpack/webpack) from 4.12.0 to 4.12.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.12.0...v4.12.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-25 20:25:37 +02:00
Roeland Jago Douma ef0d50032d Merge pull request #9981 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/webpack-4.12.1
Bump webpack from 4.12.0 to 4.12.1 in /apps/updatenotification
2018-06-25 20:25:00 +02:00
John Molakvoæ (skjnldsv) fa137d3ea9 Keyboard navigation on app
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 18:44:59 +02:00
Kevin Ndung'u 4e1feb5c7b Add focus indicator for file details view tabs
Signed-off-by: Kevin Ndung'u <kevgathuku@gmail.com>
2018-06-25 18:38:38 +03:00
John Molakvoæ (skjnldsv) 3b67353b12 Fixed accessibility contrast theme and header tab focus
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:19:40 +02:00
John Molakvoæ (skjnldsv) 94f7a8db13 Apps menu focus keyboard accessibility fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:28 +02:00
John Molakvoæ (skjnldsv) 6806c589d0 Merging highcontrast themes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:28 +02:00
John Molakvoæ (skjnldsv) 7672406573 Improved dark theme 2
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:28 +02:00
John Molakvoæ (skjnldsv) 3e1cd2a74f Improved dark theme
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:28 +02:00
John Molakvoæ (skjnldsv) 1de8f6dd37 Fix webroot
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:28 +02:00
John Molakvoæ (skjnldsv) 2e08cc958c Compliance
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:28 +02:00
Morris Jobke 6fb3cd50c2 Enable accessibility by default
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-25 17:12:28 +02:00
John Molakvoæ (skjnldsv) fc0e62185c Fixed webroot detection
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:28 +02:00
John Molakvoæ (skjnldsv) 1aa7fd8917 Bump preview
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:27 +02:00
John Molakvoæ (skjnldsv) 95f06d071d Fix css url
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:27 +02:00
John Molakvoæ (skjnldsv) 627df8f247 Fixed default font and highcontrast font
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:27 +02:00
John Molakvoæ (skjnldsv) 66d472501f Bump proper preview image
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:27 +02:00
John Molakvoæ (skjnldsv) b2c21dbb14 OpenSans font contrast option
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:27 +02:00
John Molakvoæ (skjnldsv) 263d2c89fb Config set and drone
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:27 +02:00
John Molakvoæ (skjnldsv) a23a6004a5 Fix integration tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:27 +02:00
John Molakvoæ (skjnldsv) c972e3dc31 Live css update, cache fix, design updates and various stuff
+ AppName fixes and compile bump
+ Bump dark theme and added highcontrast + various fixes

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:27 +02:00
John Molakvoæ (skjnldsv) 7781779770 Accessibility
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:26 +02:00
Morris Jobke ab266a7798 Merge pull request #9626 from lars-sh/patch-1
Workaround for interrupting expired files deletion
2018-06-25 16:44:55 +02:00
Morris Jobke 9444a3fad1 Merge pull request #9632 from nextcloud/enhancement/stateful-2fa-providers
Stateful 2fa providers
2018-06-25 15:49:58 +02:00
Morris Jobke e3be9efd57 Merge pull request #9970 from nextcloud/users-line-height-fix
Fixed multi line in users list
2018-06-25 15:35:15 +02:00
John Molakvoæ (skjnldsv) ccdf3e6f74 Bump build
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 14:51:18 +02:00
John Molakvoæ (skjnldsv) ab22ffada5 Css clamp
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 14:27:23 +02:00
John Molakvoæ (skjnldsv) 910a431653 Real ellipsis and better line height
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 14:08:38 +02:00
John Molakvoæ (skjnldsv) f8f6529653 Fixed multi line in users list
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 14:08:38 +02:00
Robin Appelman 587d7cc7d2 Merge pull request #9526 from Blaok/files-scan-shallow
allow shallow (non-recursive) scan when scanning file storage
2018-06-25 13:01:22 +02:00
dependabot[bot] d772bda213 Bump webpack from 4.12.0 to 4.12.1 in /apps/updatenotification
Bumps [webpack](https://github.com/webpack/webpack) from 4.12.0 to 4.12.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.12.0...v4.12.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-25 06:43:40 +00:00
Christoph Wurst 7be465febe Make new classes strict and fix license header
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-06-25 07:38:52 +02:00
Georg Ehrke cba783f5df Calendar resource booking: unit tests / adding missing annotations
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-25 04:59:04 +02:00
Georg Ehrke da533d7470 update classloader/classmap for calendar resource booking changes
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-25 04:59:03 +02:00
Georg Ehrke 8f061f5407 periodically query calendar resource / room backends for updated resource / room information
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-25 04:59:01 +02:00
Georg Ehrke 9aca92c441 hook up calendar resource managers/backends with server container
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-25 04:58:08 +02:00
Georg Ehrke c83629674e update resource booking interfaces and add managers
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-25 04:58:08 +02:00
Georg Ehrke b832edabbf apply group restrictions to resources
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-25 04:58:07 +02:00
Georg Ehrke 2da510af0b add resource / room principals
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-25 04:58:07 +02:00
Georg Ehrke 29b777e7d1 add resource and room interfaces
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-25 04:58:07 +02:00
Nextcloud bot a431cc3b58 [tx-robot] updated from transifex 2018-06-25 00:11:48 +00:00
John Molakvoæ (skjnldsv) bb1b6c898c No more extra padding for the app settings
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-24 19:40:57 +02:00
Lars Knickrehm 436c4f8954 Improved logging statement 2018-06-24 13:41:16 +02:00
Nextcloud bot a4b5ff8420 [tx-robot] updated from transifex 2018-06-24 00:12:06 +00:00
Nextcloud bot 5428cd2f50 [tx-robot] updated from transifex 2018-06-23 00:12:41 +00:00
Roeland Jago Douma 1f1bd36af8 Merge pull request #9967 from nextcloud/replace-wd-host-directly-in-behat-yml-instead-of-through-behat-params
Replace "wd_host" directly in "behat.yml" instead of through "BEHAT_PARAMS"
2018-06-22 22:10:06 +02:00
Daniel Calviño Sánchez e9012021fe Fix documentation
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-22 19:47:46 +02:00
Daniel Calviño Sánchez d70b6bc94b Set "wd_host" directly in "behat.yml" instead of through "BEHAT_PARAMS"
The "wd_host" parameter of Selenium2 sessions specify the URL used by
the Selenium driver to connect with the Selenium server. Thus, when the
Selenium server is at a different host or port than the default one (for
example, when run on Drone) the "wd_host" parameter must be set for each
of the Selenium2 sessions defined in "behat.yml".

The "BEHAT_PARAMS" environment variable, which extends the "behat.yml"
configuration file, was used for that. However, this required adding to
the "BEHAT_PARAMS" in "run-local.sh" each new session added to
"behat.yml", including those added in the acceptance tests of apps.

To address that limitation, this commit introduces a simulated variable,
"selenium.server"; just before the acceptance tests are run the
"selenium.server" variable in the "wd_host" parameter is replaced in the
"behat.yml" file used by the acceptance tests. Note that the file that
is modified is the one inside the Docker container used to run the
acceptance tests, so the original file is not touched.

Note that a simulated variable is needed because Behat does not support
overridding nor setting configuration parameters with environment
variables.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-22 19:46:44 +02:00
Roeland Jago Douma 082646f7e5 Merge pull request #9955 from nextcloud/bug/noid/onedrive_propfind
Request a valid property for DAV opendir
2018-06-22 15:02:20 +02:00
Morris Jobke 144d1aa29d Merge pull request #9965 from nextcloud/bugfix/8402/do-not-log-if-user-was-deleted-already
Use info log level to inform about a deleted user and thus the verification is not needed anymore
2018-06-22 14:48:40 +02:00
Robin Appelman 90be8f336c Add support for using kerberos ticket to authenticate to smb servers
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-22 14:25:36 +02:00
Morris Jobke dc12f24f73 Use info log level to inform about a deleted user and thus the verification is not needed anymore
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-22 14:11:25 +02:00
Morris Jobke ebea6d37c3 Merge pull request #9964 from nextcloud/bugfix/noid/typo-tripl-dot-instead-of-ellipsis
Use ellipsis instead of triple dot
2018-06-22 14:02:17 +02:00
Joas Schilling 6eb2653897 Use ellipsis instead of triple dot
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-06-22 11:08:26 +02:00
Julius Härtl 11e73b7a4f Merge pull request #9962 from nextcloud/polish-user-list
Added icons to users list and improved design
2018-06-22 10:54:32 +02:00
John Molakvoæ (skjnldsv) 006deecb00 removed debug
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-22 09:50:17 +02:00
John Molakvoæ (skjnldsv) bd4cba4fb2 Added icons to users list and improved design
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-22 09:48:19 +02:00
Nextcloud bot e4551106f5 [tx-robot] updated from transifex 2018-06-22 00:12:11 +00:00
Roeland Jago Douma 45018a0e83 Merge pull request #9921 from nextcloud/resetpassword-login-prefill
prefill userid for login after password reset
2018-06-21 23:45:22 +02:00
Morris Jobke 7ab0335eaf Merge pull request #9954 from nextcloud/search-form-preventdefaults
Prevent search form submit
2018-06-21 23:37:14 +02:00
Morris Jobke 1bedfce928 Merge pull request #9578 from nextcloud/smb-3.0.0
update icewind/smb to 3.0.0
2018-06-21 23:21:43 +02:00
Roeland Jago Douma ed29984501 Merge pull request #9868 from nextcloud/user-backend-table
make table name configurable for db user backend
2018-06-21 19:23:23 +02:00
Roeland Jago Douma 54c4d95a11 Request a valid property for DAV opendir
Apperently Sabre and Onedrive are not friends when requesting a single
404 property. I need to dig deeper on why this is. Anyways requesting a
valid property makes it work like a charm.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-21 19:01:27 +02:00
Morris Jobke 5efd5cee48 Merge pull request #9925 from nextcloud/select-only-visible-files
Select only searched files
2018-06-21 18:40:48 +02:00
John Molakvoæ (skjnldsv) f4e988c314 Prevent search form submit
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-21 18:06:41 +02:00
Robin Appelman 60816a2e4a use DAV instead of SMB for deletion tests
SMB storages can't be constructed on drone because of missing dependencies

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-21 16:03:57 +02:00
Robin Appelman 4a424f86db update icewind/smb to 3.0.0
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-21 16:02:51 +02:00
John Molakvoæ 912a657d94 Merge pull request #9951 from nextcloud/navigation-accessibility
Fix navigation keyboard accessibility
2018-06-21 15:45:30 +02:00
Robin Appelman 8ed50d4b63 prefill userid for login after password reset
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-21 15:18:07 +02:00
Jan-Christoph Borchardt c6aff097c6 Fix navigation keyboard accessibility
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-06-21 14:35:22 +02:00
John Molakvoæ a10690c1e9 Merge pull request #9946 from nextcloud/bugfix/noid/files-external-settings-layout
Fix files_external settings layout
2018-06-21 13:59:53 +02:00
Julius Härtl effee32bb7 Fix files_external setings layout
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-21 13:34:13 +02:00
Morris Jobke f996da45d1 Merge pull request #9941 from nextcloud/browserstack
Add browserstack logo
2018-06-21 12:16:29 +02:00
Roeland Jago Douma 8ebc3d90a0 Merge pull request #9518 from nextcloud/feature/5986/public_share_controller_middleware
Public share middleware & controller
2018-06-21 10:09:20 +02:00
John Molakvoæ (skjnldsv) de7275becd Remove debug
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-21 09:34:05 +02:00
Nextcloud bot f9c98d8621 [tx-robot] updated from transifex 2018-06-21 00:12:47 +00:00
John Molakvoæ (skjnldsv) ae6bbbdfb8 Fix folder selection
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 22:37:59 +02:00
Roeland Jago Douma a5d8f50ab2 Add browserstack to tools we use
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 20:02:56 +02:00
Morris Jobke 9b6f235015 Merge pull request #9723 from nextcloud/css4-variables
Css4 variables migration
2018-06-20 19:54:10 +02:00
John Molakvoæ (skjnldsv) b188b2d133 Rebase settings build
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:22:48 +02:00
John Molakvoæ (skjnldsv) 6d5cb3503f revert unwanted changes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:22:07 +02:00
Daniel Calviño Sánchez 2cfb3832fa Adjust theming acceptance tests to new header colour transition
Before, the acceptance tests checked the header colour just once, as the
header colour was immediately changed once the new theming colour was
saved. This is no longer the case, as currently a transition is used to
change between the original colour and the new one, so now the
acceptance tests check repeteadly for the expected header colour until
it matches or the timeout expires.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-20 19:21:54 +02:00
John Molakvoæ (skjnldsv) e01f004a13 Fixed tests and improved app-navigation-caption
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:21:54 +02:00
John Molakvoæ (skjnldsv) 938553ab07 IE11 css vars compatibility
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:21:54 +02:00
John Molakvoæ (skjnldsv) 4f0a318e02 Fixed theming tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:20:51 +02:00
Julius Härtl 80efb51a1a [theming] reload css variables instead of the whole server css
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-20 19:20:51 +02:00
John Molakvoæ (skjnldsv) b69d345677 More default variables fallbacks
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:20:51 +02:00
John Molakvoæ (skjnldsv) 1dc76f2f6b More vars fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:20:51 +02:00
John Molakvoæ (skjnldsv) 26918e4103 Various apps scss
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:20:51 +02:00
John Molakvoæ (skjnldsv) 4dd9490490 RGBA and variables fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:20:51 +02:00
John Molakvoæ (skjnldsv) f2cc3a1ab6 Files scss
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:20:51 +02:00
John Molakvoæ (skjnldsv) 4d9f20113d Fix for darken/lighten vars and new global colours vars to unify design
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:20:50 +02:00
John Molakvoæ (skjnldsv) 71ce8f3107 Split css variables and fix url variables
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:06 +02:00
John Molakvoæ (skjnldsv) 8aaf2c3272 Theming update on url
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:06 +02:00
John Molakvoæ (skjnldsv) c367cb20fa Jquery ocdialog scss
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:06 +02:00
John Molakvoæ (skjnldsv) 1977d846b7 Jquery ui fixes scss
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:06 +02:00
John Molakvoæ (skjnldsv) 4ac9d1d87f Styles scss
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:06 +02:00
John Molakvoæ (skjnldsv) eb257b8dd3 Share scss
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:06 +02:00
John Molakvoæ (skjnldsv) 1d95e6532f Public scss
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:06 +02:00
John Molakvoæ (skjnldsv) 08f1edd119 Tooltip scss
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:05 +02:00
John Molakvoæ (skjnldsv) 7a4cee5070 Multiselect scss
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:05 +02:00
John Molakvoæ (skjnldsv) f2de6568a3 Mobile scss
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:05 +02:00
John Molakvoæ (skjnldsv) e8ccdb8644 Inputs scss
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:05 +02:00
John Molakvoæ (skjnldsv) d44e6b7266 Icons scss
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:05 +02:00
John Molakvoæ (skjnldsv) 5e4e5531cf Fixes scss
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:05 +02:00
John Molakvoæ (skjnldsv) e8f13c3026 Header scss
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:05 +02:00
John Molakvoæ (skjnldsv) 734e26850b Apps scss
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:05 +02:00
John Molakvoæ (skjnldsv) 49dc8c5397 Css4 vars root init
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:05 +02:00
Roeland Jago Douma a596b062f5 Fix index.php links
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 17:54:11 +02:00
Roeland Jago Douma 9d37c191a3 Merge pull request #9927 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/webpack-4.12.0
Bump webpack from 4.11.1 to 4.12.0 in /apps/oauth2
2018-06-20 14:30:36 +02:00
Morris Jobke 50df29ded0 Merge pull request #9900 from nextcloud/feature/noid/wait-for-cron-to-finish
Wait for cron to finish before running upgrade command
2018-06-20 14:14:07 +02:00
dependabot[bot] ff476c8b55 Bump webpack from 4.11.1 to 4.12.0 in /apps/oauth2
Bumps [webpack](https://github.com/webpack/webpack) from 4.11.1 to 4.12.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.11.1...v4.12.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-20 10:10:45 +00:00
John Molakvoæ f9b24cbb23 Merge pull request #9929 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/webpack-cli-3.0.8
Bump webpack-cli from 3.0.3 to 3.0.8 in /apps/oauth2
2018-06-20 12:07:56 +02:00
dependabot[bot] 410a546c8b Bump webpack-cli from 3.0.3 to 3.0.8 in /apps/oauth2
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.0.3 to 3.0.8.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/compare/v3.0.3...v3.0.8)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-20 09:23:39 +00:00
John Molakvoæ 8142ee548c Merge pull request #9928 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/webpack-merge-4.1.3
Bump webpack-merge from 4.1.2 to 4.1.3 in /apps/oauth2
2018-06-20 11:21:11 +02:00
John Molakvoæ (skjnldsv) 5c555e6b4b Properly parse deselection and improved detection
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 11:02:03 +02:00
dependabot[bot] f0316c8b61 Bump webpack-merge from 4.1.2 to 4.1.3 in /apps/oauth2
Bumps [webpack-merge](https://github.com/survivejs/webpack-merge) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/survivejs/webpack-merge/releases)
- [Changelog](https://github.com/survivejs/webpack-merge/blob/master/CHANGELOG.md)
- [Commits](https://github.com/survivejs/webpack-merge/compare/v4.1.2...v4.1.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-20 08:40:45 +00:00
John Molakvoæ 1a1c0e7ac0 Merge pull request #9930 from nextcloud/tests/noid/add-oauth2-build
Add vue build for oauth2 app to drone
2018-06-20 10:35:33 +02:00
John Molakvoæ (skjnldsv) 48016f00a4 Bump build and config
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 10:12:21 +02:00
Julius Härtl 2791bedfa9 Add vue build for oauth2 app to drone
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-20 09:32:23 +02:00
Roeland Jago Douma 5805159487 Fix acceptance test
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:57:13 +02:00
Roeland Jago Douma 5455045a9b Fix direct access to authen page
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:57:13 +02:00
Roeland Jago Douma 6de656e435 Update token on regeneration for public login
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:53:38 +02:00
Roeland Jago Douma 1bb8bc8ff9 Add AuthPublicShareControllerTest
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:53:38 +02:00
Roeland Jago Douma 61e445da88 Add PublicShareControllerTests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:53:38 +02:00
Roeland Jago Douma e7338173e8 Add PublicShareMiddlewareTest
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:53:37 +02:00
Roeland Jago Douma 58376db92e Update SharingCheckMiddlewareTest
* They are handled now by the overal sharing public page middleware

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:53:37 +02:00
Roeland Jago Douma 9f658febca Fix ShareControllerTest
* Removed tests that are now handled by the middleware
* Updated tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:53:37 +02:00
Roeland Jago Douma ff3f63fd47 Fix PublicPreviewControllerTests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:53:37 +02:00
Roeland Jago Douma 20e514690c Don't allow public share pages if link sharing is disabled
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:53:37 +02:00
Roeland Jago Douma 31392c2443 Move public auth page over
Now this is in core so the basics (that 99% of the app will want to
use) looks always the same.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:53:37 +02:00
Roeland Jago Douma 366981fba6 Move public preview endpoint over
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:53:37 +02:00
Roeland Jago Douma 53a1b9a84e Quick hack to make the files sharing app work with this properly
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:53:37 +02:00
Roeland Jago Douma f36ef8ca80 Add the new PublicShareController and PublicShareMiddleware
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:53:35 +02:00
Christoph Wurst 13d93f5b25 Make 2FA providers stateful
This adds persistence to the Nextcloud server 2FA logic so that the server
knows which 2FA providers are enabled for a specific user at any time, even
when the provider is not available.

The `IStatefulProvider` interface was added as tagging interface for providers
that are compatible with this new API.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-06-20 08:30:26 +02:00
Nextcloud bot cad8824a8e [tx-robot] updated from transifex 2018-06-20 00:12:26 +00:00
John Molakvoæ (skjnldsv) 0afd0af156 IE11 compatibility
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 01:21:04 +02:00
John Molakvoæ (skjnldsv) 5ef3499efb Select only searched files
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 01:15:22 +02:00
John Molakvoæ 625bdf0e6c Merge pull request #9912 from nextcloud/search-standard
New search standard and user search
2018-06-20 00:45:02 +02:00
John Molakvoæ (skjnldsv) 259f70d640 Apps search
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-19 23:55:44 +02:00
John Molakvoæ (skjnldsv) 8f88c5acdd Debounce search and reset
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-19 23:54:00 +02:00
Morris Jobke 4fc9bdea4e Run vue builds in parallel
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-19 23:54:00 +02:00
John Molakvoæ (skjnldsv) 0281e9dafc Fit user search to new standard
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-19 23:54:00 +02:00
John Molakvoæ (skjnldsv) 21441fad9b Added new search standard
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-19 23:53:20 +02:00
John Molakvoæ (skjnldsv) 2f38f2b707 Add user search support
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-19 23:53:20 +02:00
John Molakvoæ (skjnldsv) e5f08620d4 Better design for core search, fixes and style to scss
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-19 23:53:19 +02:00
John Molakvoæ 7fdba6f607 Merge pull request #9919 from nextcloud/immutable-groups
Don't pretend we can add/remove users to/from groups when we can't
2018-06-19 23:52:04 +02:00
John Molakvoæ (skjnldsv) a53dbb8c0b New user support, provisionning api and design fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-19 23:20:33 +02:00
Morris Jobke 0cf0ef024f Merge pull request #9920 from nextcloud/fix/9867/fix_setup_check
If cronErros is empty json_decode will return NULL
2018-06-19 18:15:57 +02:00
Morris Jobke def12a9be9 Fix tests
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-19 17:17:34 +02:00
Roeland Jago Douma 3cbe40ffac If cronErros is empty json_decode will return NULL
Fixes #9867

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-19 16:26:06 +02:00
Robin Appelman 8a1cbbd90e Don't pretend we can add/remove users to/from groups when we can't
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-19 16:23:02 +02:00
Morris Jobke c3aea9cdf6 Merge pull request #9830 from nextcloud/feature/noid/oauth_vue_redirect_validate
Migrate OAuth Admin settings to vue
2018-06-19 14:50:03 +02:00
Morris Jobke 18e9631810 Wait for cron to finish before running upgrade command
* fixes #9562

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-19 14:22:45 +02:00
Robin Appelman 3392302d22 make table name configurable for db user backend
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-19 14:14:44 +02:00
Morris Jobke 8646f01320 Merge pull request #9881 from nextcloud/user-db-backend-querybuilder
use query builder in all places in the db user backend
2018-06-19 14:12:22 +02:00
Morris Jobke 1d65e44dae Merge pull request #9914 from Jaczel/new-settings-grammatical-fix
Fixed English grammatical error on Settings page - template
2018-06-19 13:12:47 +02:00
Roeland Jago Douma bb0ff54d82 Merge pull request #9904 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/webpack-merge-4.1.3
Bump webpack-merge from 4.1.2 to 4.1.3 in /apps/updatenotification
2018-06-19 13:05:24 +02:00
Jaczel 7672716ccf Fixed English grammatical error on Settings page. 2018-06-19 20:30:49 +10:00
dependabot[bot] 9ebf4eaff6 Bump webpack-merge from 4.1.2 to 4.1.3 in /apps/updatenotification
Bumps [webpack-merge](https://github.com/survivejs/webpack-merge) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/survivejs/webpack-merge/releases)
- [Changelog](https://github.com/survivejs/webpack-merge/blob/master/CHANGELOG.md)
- [Commits](https://github.com/survivejs/webpack-merge/compare/v4.1.2...v4.1.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-19 10:11:36 +00:00
Roeland Jago Douma b5616578df Merge pull request #9906 from nextcloud/dependabot/npm_and_yarn/settings/webpack-cli-3.0.8
Bump webpack-cli from 3.0.3 to 3.0.8 in /settings
2018-06-19 12:08:17 +02:00
Roeland Jago Douma f520a6bceb Fix redirctUri
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-19 11:42:42 +02:00
Roeland Jago Douma 1ff3f57898 js-src => src
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-19 11:42:41 +02:00
Roeland Jago Douma 27259ea2a2 Fix AdminTests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-19 11:42:41 +02:00
Roeland Jago Douma 1ccb36a0f1 Cleanup Controller
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-19 11:42:41 +02:00
Roeland Jago Douma b6182489be Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-19 11:42:41 +02:00
Julius Härtl 976f478a98 [oauth2] Fix css for admin settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-19 11:42:41 +02:00
Roeland Jago Douma d2d1e8e375 Migrate OAuth Admin settings to vue
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-19 11:42:41 +02:00
dependabot[bot] c00380f2b0 Bump webpack-cli from 3.0.3 to 3.0.8 in /settings
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.0.3 to 3.0.8.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/compare/v3.0.3...v3.0.8)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-19 09:38:42 +00:00
Roeland Jago Douma 7b8063a242 Merge pull request #9903 from nextcloud/dependabot/npm_and_yarn/settings/webpack-merge-4.1.3
Bump webpack-merge from 4.1.2 to 4.1.3 in /settings
2018-06-19 11:36:55 +02:00
blizzz 7ef722e7a6 Merge pull request #9485 from nextcloud/feature/9441/multiple_token_providers
Add new public key token provider (tokens survive password change)
2018-06-19 10:11:09 +02:00
dependabot[bot] 9a247a77d4 Bump webpack-merge from 4.1.2 to 4.1.3 in /settings
Bumps [webpack-merge](https://github.com/survivejs/webpack-merge) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/survivejs/webpack-merge/releases)
- [Changelog](https://github.com/survivejs/webpack-merge/blob/master/CHANGELOG.md)
- [Commits](https://github.com/survivejs/webpack-merge/compare/v4.1.2...v4.1.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-19 07:54:40 +00:00
Julius Härtl b8492c6944 Merge pull request #9905 from nextcloud/dependabot/npm_and_yarn/settings/v-tooltip-2.0.0-rc.33
Bump v-tooltip from 2.0.0-rc.32 to 2.0.0-rc.33 in /settings
2018-06-19 09:53:49 +02:00
Julius Härtl babad50875 Merge pull request #9902 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/webpack-cli-3.0.8
Bump webpack-cli from 3.0.3 to 3.0.8 in /apps/updatenotification
2018-06-19 09:51:19 +02:00
Roeland Jago Douma 82959ca93e Comments
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-19 07:46:43 +02:00
John Molakvoæ (skjnldsv) 9546e939fb Bump compilation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-19 06:38:26 +02:00
Nextcloud bot b8c728de6d [tx-robot] updated from transifex 2018-06-19 00:12:55 +00:00
dependabot[bot] 1a9faa5320 Bump v-tooltip from 2.0.0-rc.32 to 2.0.0-rc.33 in /settings
Bumps [v-tooltip](https://github.com/Akryum/vue-tooltip) from 2.0.0-rc.32 to 2.0.0-rc.33.
- [Release notes](https://github.com/Akryum/vue-tooltip/releases)
- [Commits](https://github.com/Akryum/vue-tooltip/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-18 22:13:54 +00:00
dependabot[bot] 255fbe0ee8 Bump webpack-cli from 3.0.3 to 3.0.8 in /apps/updatenotification
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.0.3 to 3.0.8.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/compare/v3.0.3...v3.0.8)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-18 22:13:19 +00:00
Roeland Jago Douma 970dea9264 Add getProvider helper function
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-18 22:11:55 +02:00
Roeland Jago Douma df34571d1d Use constant for token version
And don't set the version in the constructor. That would possible cause
to many updates.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-18 22:11:55 +02:00
Roeland Jago Douma 9e7a95fe58 Add more tests
* Add a lot of tests
* Fixes related to those tests
* Fix tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-18 22:11:55 +02:00
Roeland Jago Douma 1999f7ce7b Generate the new publicKey tokens by default!
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-18 22:11:55 +02:00
Roeland Jago Douma f168ecfa7a Actually convert the token
* When getting the token
* When rotating the token

* Also store the encrypted password as base64 to avoid weird binary
stuff

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-18 22:11:55 +02:00
Roeland Jago Douma d03d16a936 Add publickey provider to manager
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-18 22:11:55 +02:00
Roeland Jago Douma 4bbc21cb21 SetPassword on PublicKeyTokens
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-18 22:11:55 +02:00
Roeland Jago Douma 4c0d710479 Just pass uid to the Token stuff
We don't have user objects in the code everywhere

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-18 22:11:54 +02:00
Roeland Jago Douma 1f17010e0b Add first tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-18 22:11:54 +02:00
Roeland Jago Douma 02e0af1287 Initial PKT implementation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-18 22:11:54 +02:00
Roeland Jago Douma 8eec3a9c9a Add new authtoken v2 columns to the authtoken table
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-18 22:11:54 +02:00
Roeland Jago Douma 3dd5f3d5f6 Abstract the Provider via a manager
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-18 22:11:53 +02:00
Julius Härtl 5b60508af4 Merge pull request #9893 from kevgathuku/update-unshare-message
Update message shown when unsharing a file
2018-06-18 16:44:54 +02:00
Julius Härtl 6b6c43bf79 Merge pull request #9884 from nextcloud/groups-search-use-proper-keys
Add search to users details groups
2018-06-18 16:43:06 +02:00
blizzz 60adc92eb5 Merge pull request #9823 from nextcloud/bufgix/noid/update_token_on_session_id_regenerate
Update the token on session regeneration
2018-06-18 13:25:18 +02:00
Kevin Ndung'u 5d9c1d3fea Update message shown when unsharing a file
Signed-off-by: Kevin Ndung'u <kevgathuku@gmail.com>
2018-06-18 13:12:23 +03:00
John Molakvoæ 0ad1f19a74 Merge pull request #9717 from nextcloud/feature/actions-menu
New Feature/actions file menu
2018-06-18 08:01:52 +02:00
Abijeet 419d72e0ee Adds a test case for the loading symbol in deleted files.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-06-18 07:39:44 +02:00
Abijeet 55216e6b95 Fixes the restore loading icon appearing continuously.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-06-18 07:39:44 +02:00
Abijeet 470310b3bf Fixes issue with action being displayed incorrectly.
Also fixes the issue with the loading icon on copy & move.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-06-18 07:39:44 +02:00
Morris Jobke 57b649d665 Fix alignment of more icon
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-18 07:39:44 +02:00
Abijeet 5d95911537 Fixes UI issues with the design,
1. Removes an unnecessary width
2. Content of the table header moving down on selection. Happening due to increase in height of header.
3. Invalid font-size for the actions menu.
4. Vertical position of the action menu

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-06-18 07:39:44 +02:00
Abijeet 0c77b93b86 Fixes issues found during running of test cases.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-06-18 07:39:44 +02:00
Abijeet e89f6590e2 Fixed failing test cases for the new actions menu.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-06-18 07:39:44 +02:00
Abijeet 0ca9ce0f84 Fixes the position of the navigation toggle menu icon in mobile.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-06-18 07:39:44 +02:00
Abijeet 45db89f3e6 Added a new action menu in files and trash list.
Uses the new file-multi-select-menu component.

Towards #7647

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-06-18 07:39:43 +02:00
Abijeet 174ba1f012 Adds an action dropdown that is shown on file selection.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-06-18 07:39:43 +02:00
Nextcloud bot c8e61cc252 [tx-robot] updated from transifex 2018-06-18 00:12:35 +00:00
Nextcloud bot 5e5671983c [tx-robot] updated from transifex 2018-06-17 00:12:48 +00:00
Nextcloud bot db9ad32d75 [tx-robot] updated from transifex 2018-06-16 00:13:15 +00:00
John Molakvoæ (skjnldsv) 0f84351a76 Tests fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-15 23:00:59 +02:00
John Molakvoæ (skjnldsv) cc2d58a850 Keep userids as keys on group search
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-15 22:54:28 +02:00
Morris Jobke 2ec4fb4327 Merge pull request #9883 from nextcloud/return-user-groups-ids
Return groups IDs and not Names
2018-06-15 17:16:45 +02:00
Morris Jobke 8f6acbff62 Merge pull request #9258 from nextcloud/theming-logo-png
Convert theming app logo to PNG to show it properly in emails
2018-06-15 17:02:14 +02:00
John Molakvoæ (skjnldsv) f0ce44fedf Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-15 16:51:53 +02:00
John Molakvoæ (skjnldsv) d666723cb0 Return groups IDs and not Names
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-15 16:42:39 +02:00
Morris Jobke d82ef72161 Merge pull request #9197 from nextcloud/fix-avatar-center
Fix avatar generator centering
2018-06-15 16:16:13 +02:00
John Molakvoæ (skjnldsv) 543188d0cb Removed debug stack
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-15 15:40:10 +02:00
Robin Appelman 4187d2cdb3 use query builder in all places in the db user backend
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-15 14:16:10 +02:00
Morris Jobke a0496b2a78 Merge pull request #9875 from wiyh12nf89x/Issue#9864_WebDAV_timeout_fix_maxDelay
Fix #9864: Decrease $maxDelay in Throttler.php
2018-06-15 07:34:28 +02:00
Morris Jobke 3ea9f18871 Merge pull request #9873 from nextcloud/fix-http-client-given-options-being-overriden-by-default-options
Fix HTTP client given options being overriden by default options
2018-06-15 07:27:31 +02:00
Mark Berezovsky ad66c6bf08 Fix #9864: Decrease $maxDelay in Throttler.php
Signed-off-by: Mark Berezovsky <xpnf@yandex.ru>
2018-06-15 04:58:08 +03:00
Nextcloud bot 84a1c915e6 [tx-robot] updated from transifex 2018-06-15 00:12:49 +00:00
Daniel Calviño Sánchez 00c3a7eb4c Fix HTTP client given options being overriden by default options
According to the array_merge documentation, "If the input arrays have
the same string keys, then the later value for that key will overwrite
the previous one." Thus, the default options must be the first parameter
passed to array_merge.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-14 21:36:04 +02:00
Julius Härtl ceee91d9d4 Add info message if an exception occurs during the svg to png conversion
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-14 17:36:02 +02:00
Robin Appelman 3047ef31bd Add count to function builder
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-14 14:32:22 +02:00
Roeland Jago Douma 8c47a632e0 Allow updating the token on session regeneration
Sometimes when we force a session regeneration we want to update the
current token for this session.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-14 08:09:36 +02:00
Nextcloud bot 479e31997f [tx-robot] updated from transifex 2018-06-14 00:13:06 +00:00
John Molakvoæ 90f9e0a88e Merge pull request #9846 from nextcloud/feature/noid/add_stricter_csps
Add stricter CSPs
2018-06-13 23:19:10 +02:00
Morris Jobke e2795b0202 Merge pull request #9859 from nextcloud/fix/noid/iconcontroller_timing_fix
Fix possible test timing issues in IconController
2018-06-13 23:14:42 +02:00
Roeland Jago Douma e4db293cc1 Fix possible test timing issues in IconController
Since the response now handles the caching. We need to provide a default
ITimeFactory mock. Else you might have failing tests.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-13 22:54:08 +02:00
Roeland Jago Douma 699049be1b Merge pull request #9855 from nextcloud/feature/noid/cleanup-old-updater-backup-dirs
Background job to clean up old backups of the updater
2018-06-13 22:16:24 +02:00
John Molakvoæ (skjnldsv) fd4330c38f Fix indent
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-13 22:07:40 +02:00
Morris Jobke b6457d9968 Merge pull request #9852 from nextcloud/feature/noid/merge-setup-checks-into-one-controller
Merge all setup checks into one controller
2018-06-13 20:36:14 +02:00
John Molakvoæ (skjnldsv) 16ec9d9670 Removed old route, fix tests and fix var type
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-13 18:46:05 +02:00
John Molakvoæ (skjnldsv) 156da29cea Avatar imagick bump
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-13 18:46:05 +02:00
John Molakvoæ (skjnldsv) 4432cfd445 Embedded font
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-13 18:46:05 +02:00
John Molakvoæ (skjnldsv) eb3f43a0b5 Fixed since requirement
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-13 18:46:05 +02:00
John Molakvoæ (skjnldsv) 03d6be0877 Added new tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-13 18:46:04 +02:00
John Molakvoæ (skjnldsv) ed4309ce41 Unify colour algorithm output
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-13 18:46:04 +02:00
John Molakvoæ (skjnldsv) eea6f74ca4 Controller tests fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-13 18:46:04 +02:00
John Molakvoæ (skjnldsv) c1766b2abc Use base image size
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-13 18:46:04 +02:00
John Molakvoæ (skjnldsv) adf3856d35 Return Svg avatars
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-13 18:46:04 +02:00
John Molakvoæ (skjnldsv) 8e3382ceda Fix avatar generator centering
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-13 18:46:04 +02:00
Morris Jobke dc4c158ea7 Background job to clean up old backups of the updater
* a one-time job gets scheduled after each update via a repair job
* the job remove all directories inside data/updater-INSTANCEID/backups except the 3 most recent ones (determined by mtime of the folder)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-13 17:43:29 +02:00
Morris Jobke 9c4aecb539 Merge all setup checks into one controller
* renamed hasMissingIndexes to missingIndexes

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-13 15:25:08 +02:00
Roeland Jago Douma b38fa573e1 Add stricter CSPs
* Deprecate our default CSP
* Add strict CSP that is always our strictest setting
* Add strict eval CSP (disable unsafe-eval)
* Add strict inline CSP (disables inline styles)

This is just to move forward and have a incremental improvement of our
CSP

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-13 14:47:57 +02:00
Morris Jobke cd87a40eb3 Merge pull request #9836 from nextcloud/feature/noid/merge-tips-and-tricks-into-setup-checks
Merge tips & tricks section into setup checks
2018-06-13 13:18:40 +02:00
Morris Jobke 6756c8d2b5 Merge pull request #9850 from nextcloud/fix/noid/setup-check-empty-index
Fix wrong hint about missing indexes
2018-06-13 12:21:02 +02:00
Morris Jobke 4a0b7aaf6c Merge tips & tricks section into setup checks
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-13 12:05:38 +02:00
Morris Jobke 624d191ef6 Fix wrong hint about missing indexes
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-13 11:56:43 +02:00
John Molakvoæ c4a2632d95 Merge pull request #9833 from nextcloud/dependabot/composer/build/integration/phpunit/phpunit-approx-6.5
Update phpunit/phpunit requirement to ~6.5 in /build/integration
2018-06-13 08:40:45 +02:00
John Molakvoæ (skjnldsv) 49d0f0c499 Fixed phpunit Test class
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-13 07:24:41 +02:00
dependabot[bot] 9a32592aca Update phpunit/phpunit requirement to ~6.5 in /build/integration
Updates the requirements on [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) to permit the latest version.
- [Release notes](https://github.com/sebastianbergmann/phpunit/releases)
- [Changelog](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-6.5.md)
- [Commits](https://github.com/sebastianbergmann/phpunit/commits/6.5.8)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-13 07:24:40 +02:00
Nextcloud bot 5ecfd80f07 [tx-robot] updated from transifex 2018-06-13 00:12:59 +00:00
John Molakvoæ ed25fc3440 Merge pull request #9834 from nextcloud/copy-fix
Copyright fix, changed vue settings output name and fixes template name
2018-06-12 11:28:57 +02:00
John Molakvoæ (skjnldsv) 885b6be733 Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-12 11:13:24 +02:00
Morris Jobke dbd4da2e91 Merge pull request #9828 from nextcloud/gc-s3-list
Fix listing s3 objects when using google cloud aws compatibility
2018-06-12 10:39:28 +02:00
John Molakvoæ (skjnldsv) 27e68964a0 Indent fix and copy2
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-12 10:32:18 +02:00
John Molakvoæ (skjnldsv) 62667914a0 Copyright fix, changed vue settings output name and fixes template name
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-12 10:26:53 +02:00
Nextcloud bot d91bed9490 [tx-robot] updated from transifex 2018-06-12 00:12:46 +00:00
Robin Appelman 47fd3499a3 Fix listing s3 objects when using google cloud aws compatibility
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-11 17:10:57 +02:00
Morris Jobke 61fa284d07 Merge pull request #9473 from nextcloud/dav-upload-no-partfile-lock
properly lock the target file on dav upload when not using part files
2018-06-11 16:54:05 +02:00
Robin Appelman f017f431f6 properly lock the target file on dav upload when not using part files
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-11 15:26:41 +02:00
Morris Jobke c923ee7419 Merge pull request #9558 from nextcloud/fix/9489/trashbin_previews
Previews on for all trashbin files
2018-06-11 14:49:51 +02:00
Morris Jobke cc78e17d5f Merge pull request #9814 from nextcloud/bugfix/6032/delete_group_with_slash
Make the DELETION of groups match greedy on the groupID
2018-06-11 09:42:12 +02:00
John Molakvoæ 142505ecb2 Merge pull request #9810 from nextcloud/tests/9769/apps-management-acceptance
Acceptance tests for apps management and minor fixes
2018-06-11 09:30:18 +02:00
John Molakvoæ a1496d7cc1 Merge pull request #9807 from nextcloud/fix-highlighting-of-the-upload-drop-zone
Fix highlighting of the upload drop zone
2018-06-11 09:17:48 +02:00
Morris Jobke 51d867c5d7 Merge pull request #9798 from nextcloud/bugfix/noid/enable_caldav_for_public_calendars
enable caldav for webdav subtree public-calendars
2018-06-11 09:17:28 +02:00
Nextcloud bot e13f90ebe2 [tx-robot] updated from transifex 2018-06-11 00:12:38 +00:00
Nextcloud bot c1d3515952 [tx-robot] updated from transifex 2018-06-10 00:12:59 +00:00
Roeland Jago Douma 228d1cfbd7 Make the DELETION of groups match greedy on the groupID
fixes #6032

Now since the match is greedy it will also eat the /

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-09 19:55:09 +02:00
Julius Härtl b61e72fe00 Update asettings bundled javascript
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-09 12:07:55 +02:00
Julius Härtl c8be44be90 Add key and fix disabled apps listing
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-09 12:07:12 +02:00
Julius Härtl cdbe39d006 Properly check for the sidebar
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-09 12:06:14 +02:00
Julius Härtl f5ecd1c100 Add category field to apps that are only known from the app store
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-09 11:38:44 +02:00
Julius Härtl de66336f9c Add basic acceptance tests for apps management
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-09 11:37:41 +02:00
Morris Jobke 0c2f016b67 Merge pull request #9802 from nextcloud/bugfix/noid/token_check_expire_better
Make the token expiration also work for autocasting 0
2018-06-09 11:25:58 +02:00
Nextcloud bot ae3bdb4fb9 [tx-robot] updated from transifex 2018-06-09 00:13:06 +00:00
Daniel Calviño Sánchez 4eafae4178 Do not show an error message when draging and dropping text
When the browser reports a drag of items other than files (for example,
text) and then triggers a drop event with no files no error message
should be shown to the user, as in that case there would be no highlight
of the drop zone and no indication that the drop would be valid (except
for the mouse cursor); the error message should be shown only when
the drop event with no files follows a file drag.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-08 20:37:43 +02:00
Daniel Calviño Sánchez 463d92c339 Remove no longer needed special handling for Firefox
The highlighting was removed in Firefox when the cursor was no longer
moving to handle the behaviour of reporting a file drag and then
providing no files in the drop event. That behaviour (which was only
present in Firefox 48 and 49) is already handled with the "dropnofiles"
callback, so that special handling is no longer needed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-08 20:01:41 +02:00
Daniel Calviño Sánchez d8251344c1 Use "dropnofiles" callback to disable the drop state in the UI
When a file is dragged from the desktop to the file list the file list
is highlighted, and when the file is finally dropped or the drag
operation is cancelled the highlighting is removed. In some cases, due
to a wrong implementation, a browser may end a file drag with a drop
with no files (for example, when a folder or text is dragged), which
would cause the highlight to not be removed. Now those cases are handled
with the "dropnofiles" callback, which restores the UI and also shows a
message to the user.

The error message is just a generic one, as in some cases it is not even
possible to know whether the problem came from a text drag or a folder
drag, and whether the problem appears or not depends on the browser,
version and even operating system.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-08 19:15:28 +02:00
Daniel Calviño Sánchez bb64b6f87c Add callback to clean up after misbehaved drag and drop events
The jQuery Plugin triggers the "dragover" callback when the browser
triggers the "dragover" event and the types in their DataTransfer
include a "Files" item. It also triggers the "drop" callback when the
browser triggers the "drop" event and the list of files in its
DataTransfer is not empty.

Unfortunately some browsers may trigger "dragover" events with a
DataTransfer that includes a "Files" item and then trigger a "drop"
event with an empty list of files. When that happens the actions
performed in the "dragXXX" callbacks could be left hanging if they were
expected to be finished in the "drop" callback (for example, if the drop
zone was highlighted during the drag to be then restored when the file
was finally dropped). This commit adds the "dropnofiles" callback to be
able to handle those situations.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-08 19:15:27 +02:00
John Molakvoæ fd1498a171 Merge pull request #9793 from nextcloud/fix-mention-regex
Fix mentions regex
2018-06-08 18:02:46 +02:00
Mario Danic d959ca8eb0 Add another test
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-06-08 17:21:46 +02:00
Mario Danic 5acdd45b77 Add a new regex test
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-06-08 17:15:41 +02:00
Roeland Jago Douma 480864b3e3 Make the token expiration also work for autocasting 0
Some bad databases don't respect the default null apprently.
Now even if they cast it to 0 it should work just fine.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-08 16:20:43 +02:00
Georg Ehrke 7ea41a1461 enable caldav for webdav subtree public-calendars
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-08 13:12:34 +02:00
John Molakvoæ 8d26f9cd6d Merge pull request #9796 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/webpack-4.12.0
Bump webpack from 4.11.1 to 4.12.0 in /apps/updatenotification
2018-06-08 11:54:45 +02:00
John Molakvoæ aefc680e61 Merge pull request #9797 from nextcloud/dependabot/npm_and_yarn/settings/webpack-4.12.0
Bump webpack from 4.11.1 to 4.12.0 in /settings
2018-06-08 11:54:27 +02:00
dependabot[bot] 0c297d4943 Bump webpack from 4.11.1 to 4.12.0 in /settings
Bumps [webpack](https://github.com/webpack/webpack) from 4.11.1 to 4.12.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.11.1...v4.12.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-08 09:11:39 +00:00
dependabot[bot] 6e676ee62d Bump webpack from 4.11.1 to 4.12.0 in /apps/updatenotification
Bumps [webpack](https://github.com/webpack/webpack) from 4.11.1 to 4.12.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.11.1...v4.12.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-08 09:11:24 +00:00
Daniel Calviño Sánchez 74ab68872f Remove duplicated code
"disableDropState" was set as the event handler in 8d4e5747f3, but
the duplicated code was accidentally added back in 786e858d23.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-08 11:10:46 +02:00
Mario Danic 47769d2640 New regex to match mentions
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-06-08 10:21:19 +02:00
Morris Jobke bbfc028169 Merge pull request #9786 from nextcloud/feature/noid/external_sftp_password_and_key
Add SFTP auth mechanism to use a password and private key for SFTP
2018-06-08 09:23:47 +02:00
Nextcloud bot b34111bfc9 [tx-robot] updated from transifex 2018-06-08 00:12:51 +00:00
Mario Danic dc7beda308 Remove unsupported modifier
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-06-08 00:59:31 +02:00
Mario Danic 6bf8fca574 Fix mentions regex
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-06-08 00:35:51 +02:00
Morris Jobke be30c09e9e Merge pull request #9787 from nextcloud/notify-credentials-env
allow setting notify credentials in environment
2018-06-07 16:13:10 +02:00
Morris Jobke c60c8ac675 Merge pull request #9772 from nextcloud/feature/8123/same_site_cookie_config_php
Move samesite cookie opt-out to config.php
2018-06-07 15:36:33 +02:00
Robin Appelman 48fb126505 allow setting notify credentials in environment
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-07 15:33:58 +02:00
Morris Jobke 43edffa93c Merge pull request #9783 from nextcloud/3rdparty/noid/kill_cssmin
[3rdparty] Kill CssMin
2018-06-07 15:17:21 +02:00
Roeland Jago Douma 776641025a [3rdparty] Kill CssMin
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-07 14:42:25 +02:00
John Molakvoæ 44c6d22b22 Merge pull request #9616 from nextcloud/zero-quota-fix
Allow 0 quota by provisioning api
2018-06-07 13:54:44 +02:00
Roeland Jago Douma 2b19add6b0 Add SFTP auth mechanism to use a password and public key for SFTP
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-07 13:35:43 +02:00
John Molakvoæ 1ef32e0e59 Merge pull request #9775 from nextcloud/3rdparty/noid/bump_patchwork_utf8
[3rdparty] Bump patchwork/utf8
2018-06-07 12:44:43 +02:00
John Molakvoæ 444c2911d4 Merge pull request #9780 from nextcloud/bug/noid/mock_timefactory_theming
Mock the timefactory in the theming tests
2018-06-07 12:34:02 +02:00
Roeland Jago Douma 6f5c7c1888 Merge pull request #9777 from nextcloud/dependabot/npm_and_yarn/settings/webpack-cli-3.0.3
Bump webpack-cli from 3.0.2 to 3.0.3 in /settings
2018-06-07 12:10:07 +02:00
Roeland Jago Douma 49145a78e9 Make sure initial files can be properly created
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-07 12:07:37 +02:00
Roeland Jago Douma f65a6e782c Mock the timefactory in the theming tests
Now that the cache logic is moved to the theming controller we must
properly overwrite this service. Else it could do 💥 in tests.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-07 11:42:21 +02:00
John Molakvoæ (skjnldsv) da583f05fc Allow 0 quota by provisioning api
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-07 11:30:37 +02:00
dependabot[bot] 2aea13ad05 Bump webpack-cli from 3.0.2 to 3.0.3 in /settings
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.0.2 to 3.0.3.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/compare/v3.0.2...v3.0.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-07 09:24:24 +00:00
Morris Jobke 132597bbd3 Merge pull request #9766 from nextcloud/vue-build-tests
Add vue apps build tests
2018-06-07 11:10:31 +02:00
Roeland Jago Douma 79867e1b68 [3rdparty] Bump patchwork/utf8
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-07 10:43:23 +02:00
John Molakvoæ (skjnldsv) b5d2c1b031 Fix updatenotifications vars and groups request
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-07 10:08:56 +02:00
Morris Jobke b24db1e491 Merge pull request #9762 from nextcloud/feature/noid/setupcheck-design
Add visual indicator for setup checks
2018-06-07 09:59:46 +02:00
John Molakvoæ (skjnldsv) c5c18a483c Makefile updatenotification fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-07 09:34:24 +02:00
John Molakvoæ (skjnldsv) fd147cc3fd Bump updatenotification
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-07 09:28:06 +02:00
John Molakvoæ 4972283803 Merge pull request #9747 from nextcloud/3rdparty/noid/bump_scss
Bump scssphp
2018-06-07 09:16:49 +02:00
John Molakvoæ (skjnldsv) 14cb805cf1 Bump settings config
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-07 08:35:02 +02:00
John Molakvoæ (skjnldsv) 62e29abc5b Add vue apps build tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-07 08:35:02 +02:00
Roeland Jago Douma 4618f17654 Merge pull request #9676 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/vue-template-compiler-2.5.16
Bump vue-template-compiler from 2.5.13 to 2.5.16 in /apps/updatenotification
2018-06-07 08:31:48 +02:00
Nextcloud bot cc61c6ea15 [tx-robot] updated from transifex 2018-06-07 00:12:44 +00:00
John Molakvoæ ad46af8558 Merge pull request #9771 from nextcloud/bugfix/noid/app-settings-missing-file
Missing svg filter mixin for apps management
2018-06-06 22:43:13 +02:00
Roeland Jago Douma 199fe0a347 Add warning
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-06 22:13:39 +02:00
jaltek c79dc0e08f Configurable list for opt out from same site cookie protection
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-06 22:13:35 +02:00
Roeland Jago Douma e3652c8c12 Bump scssphp
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-06 21:30:16 +02:00
Roeland Jago Douma ebdd3fb64a Merge pull request #9768 from nextcloud/fix/noid/continue-button-on-public-page
Fix style of password button on protected link shares
2018-06-06 20:34:12 +02:00
Julius Härtl e007e66a91 Add svg filter mixin
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 20:26:18 +02:00
Roeland Jago Douma 3fc1d60482 Merge pull request #9678 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/vue-2.5.16
Bump vue from 2.5.13 to 2.5.16 in /apps/updatenotification
2018-06-06 19:51:39 +02:00
John Molakvoæ 59b086eae3 Merge pull request #9744 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/cross-env-5.1.6
Bump cross-env from 5.1.3 to 5.1.6 in /apps/updatenotification
2018-06-06 19:04:31 +02:00
Morris Jobke c5a2510980 Fix style of password button on protected link shares
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-06 18:23:17 +02:00
Morris Jobke b49f8e43bd Merge pull request #9565 from nextcloud/feature/noid/app-settings
Migrate apps management to Vue.js
2018-06-06 18:05:04 +02:00
Julius Härtl 5a20ac7df2 Add warning state to setup checks
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 17:34:38 +02:00
Julius Härtl 6afe3e42f3 Add visual indicator for setup checks
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 17:34:37 +02:00
Morris Jobke 55d0f35576 Merge pull request #9735 from nextcloud/feature/noid/missing-index-hint
Add a hint that some indexes are not added yet
2018-06-06 17:18:17 +02:00
Morris Jobke 393d9aae74 Add a hint that some indexes are not added yet
* gives the admin a chance to discover the missing indexes and improve the performance of the instance without digging through the manual
* nicely integrated in the setup checks where this kind of hints belong to
* also adds an option to integrate this from an app based on events
* fix style of setting warnings

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-06 16:55:01 +02:00
Morris Jobke f13c2b20b6 Merge pull request #9692 from nextcloud/bugfix/noid/logsecret_fix_file_put
Make sure the log doesn't try to read from PUT if it can't
2018-06-06 16:01:24 +02:00
Julius Härtl 5b0ce806a3 Minor fixes and cleanup
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 13:15:52 +02:00
Julius Härtl bf03d43c2f Remove old app settings test
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 12:29:08 +02:00
Julius Härtl 23ca2a4429 Fix AppSettingsControllerTest
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:49:50 +02:00
Julius Härtl f30c14a6a2 Keep AppConfig for now
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:49:40 +02:00
Julius Härtl c30af9bfe6 Remove space if no rating is available
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl facce73c7f Remove unused import
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 008832665f Add bundled code
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 523cd0af88 Add search/offset/limit parameters to group fetching
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 9d6aa333d4 Make view in store text translatable
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 29f1c9b7a2 Remove unneeded class
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl a045159637 Use icon instead of screenshot in the list view
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 7152414903 Remove debug output
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl a5509aa253 Move filtering to javascript
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 64c2e946f4 Some code cleanup
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl b4a7be20c8 Properly clear cache
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 67753321b3 Block other actions during update
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 1a034ce699 Implement update functionality
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 5128f7ea30 Reset search when switching categories
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 5326ba0064 Check for server health
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 52895cb41e Add loading indicator and disable buttons during actions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 5ac8af27dc Cleanup controller code
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl d7753eceee Rebuild navigation on changes
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 664bc37a80 Remove old js code except for app navigation rebuild
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 127b21b493 Implement app bundle management
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 5f8b935c8e Restructure main view layout
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 30cd8ed837 Proper rendering of bundles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 334f0ad61b Add hint for shipped apps
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl bf7cef10be Simplify backend code
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl a646389cff Add tooltips
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 3672c6fc88 Make search empty by default
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 1ad8ea75b5 Fix active indicator and add proper separation between screenshot and preview
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 92b31e49a7 Hide app navigation settings when not provided
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 7c639a5399 Implement loading indicators
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 8b919ecdc4 Properly search for other apps
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl d52aa55a4f Improve sidebar handling
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl cd60e5b634 Move logic to app management mixin
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 923e8598b0 Fix app store and sidebar view
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 492b76935c Add link to developer docs and fix view if appstore is disabled
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl c7f145cce1 Remove old template code
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 0a7ab6f66f Reorder routes to avoid conflicts
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 7fc2a29c22 Implement app details in sidebar
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl d7b928fd9b Add install/remove to the new controller methods
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl eccc391bda Load marked and return proper Template with CSP
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl a8a655b1c0 Add group fetching to vuex group store
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl bb50ee08e9 Fix app enabling for groups and allow requesting all apps
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 3b39e9c971 More app management implementation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 23462275ba Add AppStore Manager
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 05b60ee170 Fix category navigation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl d9d5e975d8 Remove default categories from route endpoint
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 125d1d3d4e Add file skeleton for app settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
Julius Härtl 8594fdc493 Move to AppFramework Controller
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Move app management ajax code to AppSettingsController

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:06 +02:00
Nextcloud bot bba1663350 [tx-robot] updated from transifex 2018-06-06 00:12:36 +00:00
Julius Härtl d132527aa9 Use svg opt out as parameter
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-05 16:47:38 +02:00
Julius Härtl 9b919245f6 Adjust ImageManager tests for png generation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-05 16:47:38 +02:00
Julius Härtl 4a5826cddb Generate PNG version of the theming app logo for mails
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-05 16:47:38 +02:00
Roeland Jago Douma 608456d2a9 Previews on for all trashbin files
* Previews possible for all files in the trashbin
* Set caching
* Use the fileid to find the file

* Fix test

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-05 10:17:22 +02:00
Roeland Jago Douma 88f657b71c Merge pull request #9701 from nextcloud/3rdparty/noid/bump_symfony
[3rdparty] Bump symfony packages
2018-06-05 08:40:28 +02:00
Roeland Jago Douma 25320c169a [3rdparty] Bump symfony packages
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-05 08:18:06 +02:00
dependabot[bot] d9a371f71b Bump cross-env from 5.1.3 to 5.1.6 in /apps/updatenotification
Bumps [cross-env](https://github.com/kentcdodds/cross-env) from 5.1.3 to 5.1.6.
- [Release notes](https://github.com/kentcdodds/cross-env/releases)
- [Changelog](https://github.com/kentcdodds/cross-env/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kentcdodds/cross-env/compare/v5.1.3...v5.1.6)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-04 22:13:54 +00:00
Morris Jobke bc008f8d5f Merge pull request #9483 from nextcloud/azure-blob
add azure object storage backend
2018-06-04 16:54:21 +02:00
Robin Appelman ac26175a17 add azure unit tests with azurite
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-04 16:18:03 +02:00
Morris Jobke 2d2c9ec8db Merge pull request #9724 from nextcloud/feature/9327/parent_share_index
Add parent index to share table
2018-06-04 15:39:51 +02:00
Morris Jobke 2794d62f60 Merge pull request #9641 from nextcloud/techdep/noid/caching_explicit_in_response
Move caching logic to response
2018-06-04 15:25:17 +02:00
Morris Jobke 15bd898ffc Merge pull request #9721 from nextcloud/feature/9122/referrer-policy
Add referrer policy setup check
2018-06-04 15:21:37 +02:00
Morris Jobke 8c3ec5f589 Merge pull request #9725 from nextcloud/fix/contacts-menu-local-null-check
Fix local users check in contacts menu
2018-06-04 14:58:23 +02:00
Roeland Jago Douma 3f82ed377c Bump autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-04 11:23:55 +02:00
Robin Appelman 60b7cbc0f0 add azure object storage backend
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-04 10:57:52 +02:00
Robin Appelman 9b0919da76 add azure blob storage sdk
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-04 10:55:24 +02:00
Morris Jobke 367b1be15c Merge pull request #9425 from nextcloud/db-reconnect-timeout
Check connection status and attempt to reconnect each each minute
2018-06-04 10:40:12 +02:00
Roeland Jago Douma 4b70c9f89d Add referrer policy setup check
Fixes #9122

Based on https://www.w3.org/TR/referrer-policy/ and
https://scotthelme.co.uk/a-new-security-header-referrer-policy/

Setting a sane Referrer-Policy will tell the browser if/when to send
referrer headers when accessing a link from Nextcloud. When configured
properly this results in less tracking and less leaking of (possibly)
sensitive urls

* Fix tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-04 09:21:35 +02:00
Roeland Jago Douma e5cc8be9d5 Fix usage
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-04 08:48:54 +02:00
Roeland Jago Douma a34495933e Move caching logic to response
This avoids having to do it at all the places we want cached responses.

We can't inject the ITimeFactor without breaking public API.
However we can perfectly overwrite the service (resulting in the same
testable effect).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-04 08:48:54 +02:00
Christoph Wurst 9f8617a439 Fix local users check in contacts menu
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-06-04 08:45:04 +02:00
Nextcloud bot a00cb2c5d7 [tx-robot] updated from transifex 2018-06-04 00:12:26 +00:00
Roeland Jago Douma 2f59f389d2 Add parent index to share table
Fixes #9327

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-03 13:36:02 +02:00
Nextcloud bot 36d74047f7 [tx-robot] updated from transifex 2018-06-03 00:12:47 +00:00
Nextcloud bot d9238b810a [tx-robot] updated from transifex 2018-06-02 00:12:30 +00:00
Morris Jobke 80a993ca47 Merge pull request #9542 from nextcloud/anonymous-options
Add sabre plugin to allow anonymous options requests to the dav root
2018-06-01 18:57:35 +02:00
Robin Appelman c52326f084 Add tests for handling anonymous auth
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-01 17:22:21 +02:00
Robin Appelman ea4f4b8417 Add sabre plugin to allow anonymous options requests to the dav root
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-01 17:20:42 +02:00
Morris Jobke 38c38eec79 Merge pull request #9711 from nextcloud/fix/noid/fixmaster_unittests
Fix the master unit tests
2018-06-01 14:10:42 +02:00
Roeland Jago Douma 3ca15255f7 Fix the master unit tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-01 13:24:04 +02:00
Morris Jobke f5e16dfaa7 Merge pull request #9609 from nextcloud/bugfix/3830/invitations_for_shared_calendars
send invitations for shared calendars
2018-06-01 12:40:53 +02:00
Morris Jobke c3fc789b2c Merge pull request #9550 from nextcloud/bugfix/noid/override_freebusy_sharing_rules
allow admins to disable FreeBusy without modifying ShareAPI capabilities
2018-06-01 12:00:56 +02:00
Nextcloud bot d3fceb9b83 [tx-robot] updated from transifex 2018-06-01 00:12:28 +00:00
Roeland Jago Douma 45f2e48175 Merge pull request #9704 from nextcloud/fix/noid/remove-unneeded-imports
Remove not needed change
2018-05-31 19:51:48 +02:00
Morris Jobke 5aca062100 Remove not needed change
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-05-31 17:23:36 +02:00
Nextcloud bot 9ac36dc30b [tx-robot] updated from transifex 2018-05-31 00:12:36 +00:00
Roeland Jago Douma d2f5daf08a Merge pull request #9167 from nextcloud/migration-description
Add human readable description to migration steps
2018-05-30 21:48:36 +02:00
Roeland Jago Douma fcc6eb8427 Add since tags
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-30 21:28:55 +02:00
Robin Appelman b40629ac8c Add human readable description to migration steps
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-30 21:28:05 +02:00
Roeland Jago Douma a52d206684 Make sure the log doesn't try to read from PUT if it can't
If a PUT request comes in that is not JSON or from encoded. Then we can
only read it (exactly) once. If that is the case we must assume no
shared secret is set.

If we don't then we either are the first to read it, thus causing the
real read of the data to fail.

Or we are later and then it throws an exception (also failing the
request).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-30 20:18:19 +02:00
Julius Härtl 2dd49206c7 Merge pull request #9673 from nextcloud/dependabot/composer/build/integration/guzzlehttp/guzzle-6.3.3
Update guzzlehttp/guzzle requirement to 6.3.3 in /build/integration
2018-05-30 14:44:04 +02:00
John Molakvoæ 619b0eece1 Merge pull request #9666 from nextcloud/enhancement/noid/preview_check_file_readbale
Make sure the file is readable before attempting to create a preview
2018-05-30 13:25:24 +02:00
John Molakvoæ 50f6015821 Merge pull request #9680 from nextcloud/dependabot/npm_and_yarn/build/karma-viewport-tw-1.0.2
Update karma-viewport requirement to ^1.0.2 in /build
2018-05-30 13:21:43 +02:00
John Molakvoæ d24859ba00 Merge pull request #9682 from nextcloud/dependabot/npm_and_yarn/build/karma-tw-2.0.2
Update karma requirement to ^2.0.2 in /build
2018-05-30 13:21:20 +02:00
John Molakvoæ 6d81ea0258 Merge pull request #9681 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/css-loader-0.28.11
Bump css-loader from 0.28.9 to 0.28.11 in /apps/updatenotification
2018-05-30 13:17:54 +02:00
dependabot[bot] 120c6a27d8 Bump vue from 2.5.13 to 2.5.16 in /apps/updatenotification
Bumps [vue](https://github.com/vuejs/vue) from 2.5.13 to 2.5.16.
- [Release notes](https://github.com/vuejs/vue/releases)
- [Commits](https://github.com/vuejs/vue/compare/v2.5.13...v2.5.16)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-05-30 10:12:58 +00:00
dependabot[bot] 59a8bb5547 Bump vue-template-compiler from 2.5.13 to 2.5.16 in /apps/updatenotification
Bumps [vue-template-compiler](https://github.com/vuejs/vue) from 2.5.13 to 2.5.16.
- [Release notes](https://github.com/vuejs/vue/releases)
- [Commits](https://github.com/vuejs/vue/compare/v2.5.13...v2.5.16)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-05-30 10:12:39 +00:00
Julius Härtl 3988c89ea9 Merge pull request #9688 from nextcloud/dependabot/npm_and_yarn/settings/webpack-cli-2.1.4
Bump webpack-cli from 2.1.3 to 2.1.4 in /settings
2018-05-30 12:10:41 +02:00
dependabot[bot] 4d78f2e45b Update karma-viewport requirement to ^1.0.2 in /build
Updates the requirements on [karma-viewport](https://github.com/squidfunk/karma-viewport) to permit the latest version.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases)
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG)
- [Commits](https://github.com/squidfunk/karma-viewport/commits/1.0.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-05-30 10:00:57 +00:00
dependabot[bot] d7f725008f Update karma requirement to ^2.0.2 in /build
Updates the requirements on [karma](https://github.com/karma-runner/karma) to permit the latest version.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/commits/v2.0.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-05-30 10:00:50 +00:00
Julius Härtl 20b0658ff6 Merge pull request #9685 from nextcloud/dependabot/npm_and_yarn/build/node-sass-approx-4.9.0
Update node-sass requirement to ~4.9.0 in /build
2018-05-30 11:59:16 +02:00
Morris Jobke 69d633c403 Merge pull request #9679 from nextcloud/dependabot/npm_and_yarn/build/jsdoc-approx-3.5.5
Update jsdoc requirement to ~3.5.5 in /build
2018-05-30 11:35:28 +02:00
dependabot[bot] 81ccf33db4 Update guzzlehttp/guzzle requirement to 6.3.3 in /build/integration
Updates the requirements on [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) to permit the latest version.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/master/CHANGELOG.md)
- [Commits](https://github.com/guzzle/guzzle/commits/6.3.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-05-30 09:34:25 +00:00
Roeland Jago Douma 14acded171 Make sure the file is readable before attempting to create a preview
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-30 11:34:02 +02:00
Morris Jobke 182910b136 Merge pull request #9675 from nextcloud/dependabot/composer/build/integration/sabre/dav-3.2.2
Update sabre/dav requirement to 3.2.2 in /build/integration
2018-05-30 11:32:20 +02:00
dependabot[bot] fcc0dabfc6 Bump webpack-cli from 2.1.3 to 2.1.4 in /settings
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 2.1.3 to 2.1.4.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/compare/v2.1.3...v2.1.4)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-05-30 08:25:47 +00:00
dependabot[bot] 04764cf568 Update node-sass requirement to ~4.9.0 in /build
Updates the requirements on [node-sass](https://github.com/sass/node-sass) to permit the latest version.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/commits/v4.9.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-05-30 08:23:54 +00:00
dependabot[bot] f39ed3d449 Bump css-loader from 0.28.9 to 0.28.11 in /apps/updatenotification
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 0.28.9 to 0.28.11.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v0.28.9...v0.28.11)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-05-30 08:23:38 +00:00
dependabot[bot] fd107bc0e5 Update jsdoc requirement to ~3.5.5 in /build
Updates the requirements on [jsdoc](https://github.com/jsdoc3/jsdoc) to permit the latest version.
- [Release notes](https://github.com/jsdoc3/jsdoc/releases)
- [Changelog](https://github.com/jsdoc3/jsdoc/blob/master/CHANGES.md)
- [Commits](https://github.com/jsdoc3/jsdoc/commits/3.5.5)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-05-30 08:23:35 +00:00
dependabot[bot] 354cac145c Update sabre/dav requirement to 3.2.2 in /build/integration
Updates the requirements on [sabre/dav](https://github.com/sabre-io/dav) to permit the latest version.
- [Release notes](https://github.com/sabre-io/dav/releases)
- [Changelog](https://github.com/sabre-io/dav/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sabre-io/dav/commits/3.2.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-05-30 08:23:11 +00:00
Roeland Jago Douma e8c680f74a Merge pull request #9670 from nextcloud/drone-mysqlmb4-fix
Fix drone mysqlmb4 tests
2018-05-30 08:52:44 +02:00
John Molakvoæ (skjnldsv) aec85bf04f Fix drone mysqlmb4 tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-30 08:33:27 +02:00
Nextcloud bot 7df563ee39 [tx-robot] updated from transifex 2018-05-30 00:12:08 +00:00
Morris Jobke 8376ca3eb7 Merge pull request #9665 from nextcloud/add-workaround-for-parameter-not-available-in-mink-extension
Add workaround for parameter not available in Mink Extension
2018-05-29 20:59:46 +02:00
Daniel Calviño Sánchez aedcbb64da Use "paths.base" parameter for the path to the custom Firefox profile
Although in the case of the acceptance tests for the server it is not
strictly needed it was modified for consistency with the configuration
used for the acceptance tests in apps.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-05-29 20:25:18 +02:00
Daniel Calviño Sánchez 3bdb07320d Add workaround for parameter not available in Mink Extension
Due to a bug in the Mink Extension for Behat it is not possible to use
the "paths.base" parameter in the path to the custom Firefox profile.
"paths.base" is a special parameter in the Behat configuration that
refers to the directory in which "behat.yml" is stored. This comes in
very handy to set the path to custom Firefox profiles in the acceptance
tests for apps, as even if the "behat.yml" file belongs to an app its
paths are relative to the directory in which the tests are run, that is,
the "tests/acceptance" directory of the server.

Until the bug is fixed, just before the acceptance tests are run the
"paths.base" parameter in the path to the custom Firefox profile is
replaced by its value in the "behat.yml" file used by the acceptance
tests. Note that the file that is modified is the one inside the Docker
container used to run the acceptance tests, so the original file is not
touched.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-05-29 20:24:32 +02:00
Daniel Calviño Sánchez f4a64051b6 Extract path to configuration dir to its own variable
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-05-29 18:20:58 +02:00
blizzz c0ed6f91a8 Merge pull request #9640 from nextcloud/fix/9502/missedstatecheck
check user state when fetching to avoid dealing with offline objects, fixes #9502
2018-05-29 16:55:14 +02:00
Morris Jobke 7f301be188 Merge pull request #9583 from nextcloud/files-home-userfolder
use getUserFolder instead of getFileInfo when constructing FilesHome
2018-05-29 16:50:01 +02:00
Morris Jobke 1924fed83e Merge pull request #9589 from nextcloud/bugfix/noid/allow-empty-route-navigation
Allow empty route for navigation entries
2018-05-29 16:26:32 +02:00
Roeland Jago Douma e37b77fa28 Merge pull request #9653 from nextcloud/bugfix/noid/oauth_basic_auth
The OAuth endpoint needs to support Basic Auth
2018-05-29 16:24:14 +02:00
Roeland Jago Douma 3556e78c25 The OAuth endpoint needs to support Basic Auth
* Add test

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-29 15:17:54 +02:00
Nextcloud bot 645eaaa434 [tx-robot] updated from transifex 2018-05-29 00:12:21 +00:00
Arthur Schiwon 73cacb8896 check user state when fetching to avoid dealing with offline objects
fixes #9502

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-05-29 01:10:03 +02:00
Morris Jobke 9ddff6ff35 Merge pull request #9617 from nextcloud/users-sort-case-fix
Ignore case when sorting users
2018-05-28 15:52:37 +02:00
Morris Jobke b76f806857 Merge pull request #9559 from nextcloud/sabre-head-dont-open-file
dont open the file on dav HEAD request
2018-05-28 14:38:44 +02:00
Morris Jobke 0947ddb33e Merge pull request #9268 from nextcloud/bugfix/6711
Do not load calendar/addressbook plugins if not needed
2018-05-28 13:52:12 +02:00
Roeland Jago Douma 26c1e33d11 Move repairstep to a custom command
People that have issues can run it manually

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-28 13:26:55 +02:00
Morris Jobke 188b96d521 Merge pull request #9584 from nextcloud/file-cache-gc-isdir
remove unneeded is_dir from file cache gc
2018-05-28 11:36:19 +02:00
Morris Jobke 4ea7dbbc1c Merge pull request #9627 from nextcloud/limit-sinon-version-to-5.0.7-at-most
Limit Sinon version to 5.0.7 at most
2018-05-28 11:05:59 +02:00
Daniel Calviño Sánchez 268a92731f Limit Sinon version to 5.0.7 at most
When using fake servers with Sinon.JS, the JavaScript test framework,
the XHR objects are also fake. In Sinon 5.0.8 the "setRequestHeader" of
XMLHttpRequest was modified to normalize the header values (as requested
by the spec), but since then only string values are accepted; null or
integer values can no longer be passed to "setRequestHeader", as it
expects the "replace" function to be available in the object. However,
in the tests null and integer values are passed to "setRequestHeader",
which causes them to fail.

Both Firefox and Chromium accept passing non-string values to their
"setRequestHeader" implementation, and it is done, for example, in
davclient.js; it is not clear yet whether Sinon got too restrictive or
the code calling "setRequestHeader" was too loose. Given that
davclient.js is an external dependency, as a temporary measure Sinon
version is forced to be 5.0.7 at most until either Sinon or davclient.js
are updated.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-05-28 08:06:20 +02:00
Nextcloud bot 2b2bbe359e [tx-robot] updated from transifex 2018-05-28 00:12:45 +00:00
Lars Knickrehm e360885eb0 Workaround for interrupting expired files deletion
Workaround avoiding "Error while running background job (class: OCA\Files_Trashbin\BackgroundJob\ExpireTrash, arguments: ): {"Exception":"OCP\\Files\\NotPermittedException","Message":"","Code":0,"Trace":"#0 \/var\/www\/cloud\/apps\/files_trashbin\/lib\/Trashbin.php(590): OC\\Files\\Node\\File->delete() [...]"
2018-05-28 00:59:20 +02:00
Roeland Jago Douma f9a64d3e1b Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-27 20:51:36 +02:00
Roeland Jago Douma 8bf8e92092 Adding repair step which cleans shares of invalid principals
https://github.com/owncloud/core/pull/30149/commits/edacf22fbce4deefc181c53dd84c5fb278a9a28d

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-27 20:51:36 +02:00
Roeland Jago Douma 69e650d0e8 CalDAV and CardDAV plugins need to be registered for the principals collection as well
https://github.com/owncloud/core/pull/30149/commits/9f2e6431b88a9635b291b0e824abf74ba766616d

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-27 20:51:36 +02:00
Roeland Jago Douma 240006bdf5 When sharing calendars and addressbooks the principal has to be verified to be valid
https://github.com/owncloud/core/pull/30149/commits/d3fb8fcdd3a6b00bde0c3c9eb4039876e7fc1967

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-27 20:51:36 +02:00
Roeland Jago Douma c5d5c7dc12 Do not load calendar/addressbook plugins if not needed
Fixes #6711
Based on https://github.com/owncloud/core/pull/30149/commits/f0fb21cf3563088284c56be4eac48c7d9725cb21

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-27 20:51:32 +02:00
Nextcloud bot 9e00b51c87 [tx-robot] updated from transifex 2018-05-27 00:13:07 +00:00
Robin Appelman c8076f5f9d dont open the file on dav HEAD request
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-26 13:17:19 +02:00
John Molakvoæ (skjnldsv) ad6e548411 Added case example to tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-26 12:07:49 +02:00
John Molakvoæ (skjnldsv) 0bfe3da664 Ignore case when sorting users
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-26 12:01:13 +02:00
Morris Jobke a27e2bfcfd Merge pull request #9585 from nextcloud/feature/noid/rename-syncclients
Rename sync clients section to mobile & desktop
2018-05-26 11:18:47 +02:00
Nextcloud bot f0fdac8078 [tx-robot] updated from transifex 2018-05-26 00:13:01 +00:00
Georg Ehrke a9c313ce45 send invitations for shared calendars
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-05-25 20:41:50 +02:00
blizzz 760b28ba4c Merge pull request #9488 from nextcloud/disabled-users-fix
Added disabled count per groups & fixed disabled users query
2018-05-25 15:54:47 +02:00
John Molakvoæ (skjnldsv) 4644841ba6 Do not show count on empty groups
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-25 15:00:52 +02:00
John Molakvoæ (skjnldsv) 7b57c1a905 Tabs fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-25 14:46:11 +02:00
Julius Härtl 441cedf1df Fix Settings\ManagerTest
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-25 10:41:17 +02:00
Morris Jobke d4a0af7e5e Merge pull request #9593 from nextcloud/fwdport/9586/master
add privacy link to theming and fix scrollbars
2018-05-25 09:49:36 +02:00
Nextcloud bot 60734cd79d [tx-robot] updated from transifex 2018-05-25 00:14:54 +00:00
Arthur Schiwon 0847c98aaf addjust footer height when legal links are present. fixes #9572
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-05-24 23:39:50 +02:00
Arthur Schiwon 16c061818e also add a privacy link
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-05-24 23:32:07 +02:00
Roeland Jago Douma eefe256abc Merge pull request #9576 from nextcloud/feature/noid/missing_index_event
Emit event when running ./occ db:add-missing-indices
2018-05-24 20:33:26 +02:00
Roeland Jago Douma 80cc8d0028 Emit event when running ./occ db:add-missing-indices
This allows apps to listen to this event in order to also update
indecies there.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-24 18:03:10 +02:00
John Molakvoæ (skjnldsv) a093a67b5a Fixed app navigation order
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-24 17:52:16 +02:00
John Molakvoæ (skjnldsv) cd73cd3a6e Fixed error throw and disablign count group update
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-24 17:52:15 +02:00
John Molakvoæ (skjnldsv) f5d0f14045 Fix the navigation component
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-24 17:52:15 +02:00
John Molakvoæ (skjnldsv) c55cf79453 Added total count for subadmins
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-24 17:52:15 +02:00
John Molakvoæ (skjnldsv) ddd1c8bc86 Disabled fix since new users list
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-24 17:52:15 +02:00
John Molakvoæ (skjnldsv) 5518415829 Fixes since requirement
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-24 17:52:15 +02:00
John Molakvoæ (skjnldsv) 97af7566e4 Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-24 17:52:15 +02:00
John Molakvoæ (skjnldsv) 10c135ca34 Added disabled count per groups
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-24 17:52:15 +02:00
Morris Jobke 6689a3e37b Merge pull request #9582 from nextcloud/feature/2593/password-confirm-texts
Allow custom text for OC.PasswordConfirmation
2018-05-24 17:47:02 +02:00
Julius Härtl 354c6e95d5 Allow empty route for navigation entries
Navigation entries might be handled by javascript, as the about section
from https://github.com/nextcloud/firstrunwizard/pull/64 so we don't
need a route for that.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-24 16:28:05 +02:00
Julius Härtl e1af2f4766 Rename sync clients section to mobile & desktop
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-24 15:06:28 +02:00
Robin Appelman 07e5b30b90 remove unneeded is_dir from file cache gc
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-24 14:24:10 +02:00
Robin Appelman 51724a35a4 use getUserFolder instead of getFileInfo when constructing FilesHome
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-24 14:17:53 +02:00
Julius Härtl d44cbc8118 Add custom texts to apps management password checks
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-24 14:02:56 +02:00
Julius Härtl 10b33cd5d0 Add placeholder to input in OCdialog prompt
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-24 14:02:25 +02:00
Julius Härtl 33b65faba0 Allow to specify custom text on admin password confirmation dialogs
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-24 14:01:58 +02:00
Robin Appelman 491f01efba disable dav acl plugin for files resource
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-24 14:00:14 +02:00
Morris Jobke fd4a7bf72a Merge pull request #9574 from nextcloud/search-category
Add search category icon
2018-05-24 09:20:51 +02:00
John Molakvoæ (skjnldsv) 54de42109e Add search category icon
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-24 07:18:44 +02:00
Nextcloud bot caa3953245 [tx-robot] updated from transifex 2018-05-24 00:13:48 +00:00
Roeland Jago Douma 84482eb25a Merge pull request #9435 from nextcloud/bugfix/noid/fix_force_language_html_attr
make sure force language is reflected in html lang attribute
2018-05-23 23:45:24 +02:00
Roeland Jago Douma 4286e17777 Always set the request language to the force language
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-23 21:19:46 +02:00
Morris Jobke 6b6d522969 Merge pull request #9395 from nextcloud/scanner-error-lock-cleanup
cleanup locks in scanner on error
2018-05-23 20:05:01 +02:00
Roeland Jago Douma 9fed7aa2da Backends are legacy code as well and need to go
so no need to fix the tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-23 19:51:37 +02:00
Morris Jobke bc34a7f4e9 Get rid of shareItem
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-05-23 19:51:37 +02:00
Morris Jobke 3a41db7f67 Merge pull request #9564 from nextcloud/techdebt/noid/new-sharing
Improve test code to be done with new sharing
2018-05-23 19:49:02 +02:00
Roeland Jago Douma 9c23c7c821 Fix ViewTest
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-23 19:12:51 +02:00
Roeland Jago Douma 33b639d23c Fix ExpiresSharesJobTest
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-23 19:12:02 +02:00
Roeland Jago Douma c5042f1545 Use node api
* delete old test that can't happen anymore since we check for a valid
node

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-23 19:10:11 +02:00
Roeland Jago Douma d42515a934 Merge pull request #9561 from nextcloud/techdebt/noid/cron.php
Fix code style
2018-05-23 18:27:33 +02:00
Joas Schilling 7860c81523 Fix code style
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-05-23 17:33:11 +02:00
Roeland Jago Douma e11a523ce9 Merge pull request #9557 from nextcloud/fix/noid/cleanup
Remove .lgtm file
2018-05-23 16:00:04 +02:00
Roeland Jago Douma b3aec38e5e Remove .lgtm file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-23 14:49:22 +02:00
Morris Jobke d0942e135a Merge pull request #9556 from nextcloud/package-security-fix
Updated settings package deps
2018-05-23 14:49:07 +02:00
John Molakvoæ (skjnldsv) 193df8304d Updated settings package deps
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-23 13:55:11 +02:00
John Molakvoæ 9296b81c8d Merge pull request #9555 from nextcloud/users-list-improvements
Fixed IE design, subadmins groups update and multiselect base width
2018-05-23 10:23:34 +02:00
John Molakvoæ (skjnldsv) aa1c6fb6b4 Fixed IE design, subadmins groups update and multiselect base width
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-23 09:43:33 +02:00
Nextcloud bot 4bbad8f88a [tx-robot] updated from transifex 2018-05-23 00:15:44 +00:00
Morris Jobke a2c518ee5a Merge pull request #8824 from nextcloud/settings-vue
Vue migration: settings
2018-05-23 00:32:46 +02:00
Georg Ehrke 2a21471c74 make sure force language is reflected in html lang attribute
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-05-22 19:30:25 +02:00
Georg Ehrke 367ca563b4 allow admins to override FreeBusy capabilities without modifying ShareAPI capabilities
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-05-22 19:16:26 +02:00
Morris Jobke b40bae816a Merge pull request #9545 from nextcloud/bugfix/noid/ellipsis-below-public-textfiles
Remove ellipsis below public text file shares
2018-05-22 16:33:29 +02:00
Morris Jobke 245d20f9ac Merge pull request #9531 from remyj38/master
Fix translation bug on lost password page
2018-05-22 16:31:30 +02:00
Jan-Christoph Borchardt cbe5c193d0 Merge pull request #9538 from nextcloud/bugfix/noid/active-indicator-width
Increase width of other active navigation indicators to 4px
2018-05-22 15:53:42 +02:00
Roeland Jago Douma 0c7a797652 Merge pull request #9544 from nextcloud/bugfix/noid/fix-phpdoc
Fix PHPDoc
2018-05-22 15:39:07 +02:00
Morris Jobke 8c043dd00d Remove ellipsis below public text file shares
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-05-22 15:14:23 +02:00
Morris Jobke 96efc42584 Fix PHPDoc
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-05-22 15:11:32 +02:00
John Molakvoæ (skjnldsv) 760b01e8db Fix api error
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-22 10:33:48 +02:00
Roeland Jago Douma 57d4a16cfb Merge pull request #9517 from nextcloud/feature/noid/improve_oauth_handling
Improve OAuth handling
2018-05-22 10:16:45 +02:00
Roeland Jago Douma 6fac639747 Merge pull request #9520 from nextcloud/3rdparty/noid/bump_phpseclib
[3rdparty] Bump phpseclib to 2.0.11
2018-05-22 09:24:53 +02:00
Roeland Jago Douma 461998dd15 Add tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-22 09:24:17 +02:00
Roeland Jago Douma 5a97148863 Don't use special chars to avoid confusion
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-22 09:24:17 +02:00
Roeland Jago Douma f7ecec855b Rotate token
On a refresh token request:
* rorate
* reset expire

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-22 09:24:17 +02:00
Roeland Jago Douma c28b25c4f0 Authenticate the clients on requesting a token
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-22 09:24:17 +02:00
Roeland Jago Douma 4e3aef22a1 Fail if the response type is not properly set
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-22 09:24:17 +02:00
Roeland Jago Douma 49795d2006 Set OAuth token expiration
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-22 09:24:17 +02:00
Roeland Jago Douma bbcb36cd60 Merge pull request #9513 from nextcloud/3rdparty/noid/bump_autosize
Bump autosize to 4.0.2
2018-05-22 09:22:39 +02:00
Roeland Jago Douma d4464cc3ef Merge pull request #9515 from nextcloud/bugfix/noid/reset_session_when_auth_against_protected_share
Regenerate session id after public share auth
2018-05-22 09:21:39 +02:00
Julius Härtl 3c011c6d50 Increase width of other active navigation indicators to 4px
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-22 09:03:31 +02:00
Nextcloud bot 0d90c5ebc4 [tx-robot] updated from transifex 2018-05-22 00:13:31 +00:00
Nextcloud bot 7161d8eaee [tx-robot] updated from transifex 2018-05-21 00:13:41 +00:00
Maxence Lange 4f5814c27b tests
Signed-off-by: Maxence Lange <maxence@nextcloud.com>
2018-05-21 01:24:45 +02:00
Maxence Lange 2e3517eb00 display details on sharing panel
Signed-off-by: Maxence Lange <maxence@nextcloud.com>
2018-05-21 01:24:45 +02:00
Maxence Lange 0009adae80 SharedWithDisplayName + SharedWithAvatar
Signed-off-by: Maxence Lange <maxence@nextcloud.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-05-21 01:24:45 +02:00
Rémy Jacquin 04e1cab5ee Fix translation bug on lost password page
Fix nextcloud/password_policy#26

Signed-off-by: Rémy Jacquin <remy@remyj.fr>
2018-05-20 12:51:50 +02:00
Nextcloud bot ca089b9412 [tx-robot] updated from transifex 2018-05-20 00:13:24 +00:00
Nextcloud bot e2f1f7b8f5 [tx-robot] updated from transifex 2018-05-19 00:13:41 +00:00
John Molakvoæ b7fa89800d Merge pull request #9521 from nextcloud/add-firefox-profile-with-support-for-css-grid-to-acceptance-tests
Add Firefox profile with support for CSS grid to acceptance tests
2018-05-19 00:29:47 +02:00
Blaok 4a3471595a test: add unit test for files:scan --shallow
Signed-off-by: Yuze Chi <i@blaok.me>
2018-05-18 14:51:08 -07:00
Blaok 21b9ad3978 feat: allow files:scan --shallow
Signed-off-by: Yuze Chi <i@blaok.me>
2018-05-18 14:50:32 -07:00
Roeland Jago Douma 03a6f8e14e Merge pull request #9490 from marco44/faster_large_filehelper_32bits
Make LargeFileHelper.php faster by avoiding execs as much as possible
2018-05-18 21:09:17 +02:00
John Molakvoæ (skjnldsv) 16af12e0a0 Fixed webpack config, groups flex thanks to @juliushaertl and groups tooltip
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-18 17:47:10 +02:00
Daniel Calviño Sánchez cb20503341 Add Firefox profile with support for CSS grid to acceptance tests
The acceptance tests are currently run on Firefox 47; in that version
the CSS grid support was not enabled by default, but it could be enabled
through a setting in the Firefox profile.

By default Selenium uses a clean Firefox profile when a new session is
started, but it also allows the customization of the profile through a
zipped "user.js" file. The contents of that file have to be provided in
the "firefox_profile" capability when the Firefox session is created.

In the Mink extension for Behat several Mink sessions can be defined in
the "behat.yml" file. Each Mink session uses a different browser session
in Selenium, and each of those browser sessions is initialized with the
capabilities provided in the "behat.yml" file.

From the point of view of the acceptance tests each Mink session is an
actor, so different actors can use different browsers with different
capabilities.

Due to all this a new actor was introduced, "Rubeus", who uses a Firefox
browser that has CSS grid support; this actor is meant to be used only
in those acceptance tests that require proper support for CSS grids.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-05-18 17:44:43 +02:00
John Molakvoæ (skjnldsv) 38b1020f52 Bump webpack, config, deps, fixes groups selects, improved design and added tooltip to groups +x indicator
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-18 16:39:34 +02:00
Roeland Jago Douma 2cd633f21f [3rdparty] Bump phpseclib to 2.0.11
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-18 12:55:40 +02:00
Roeland Jago Douma 9cc15bc9b0 Merge pull request #9508 from nextcloud/3rdparty/noid/bump_symfony
[3rdparty] Bump symfony components
2018-05-18 11:40:35 +02:00
Nextcloud bot 514b374923 [tx-robot] updated from transifex 2018-05-18 00:13:45 +00:00
Roeland Jago Douma d6d0e60136 Regenerate session id after public share auth
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-17 22:07:20 +02:00
Roeland Jago Douma 9236c20a28 Merge pull request #9437 from nextcloud/feature/noid/imprint
allow to specify a link to a legal notice
2018-05-17 21:16:03 +02:00
Roeland Jago Douma 8696651cfb Merge pull request #9491 from nextcloud/feature/noid/tokens_can_expire
Allow token to expire
2018-05-17 20:07:08 +02:00
Roeland Jago Douma 4a19079b06 Bump autosize to 4.0.2
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-17 16:42:16 +02:00
Roeland Jago Douma c7ffb66b2c [3rdparty] Bump symfony components
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-17 16:32:42 +02:00
Roeland Jago Douma 6b7cf46727 Certain tokens can expire
However due to the nature of what we store in the token (encrypted
passwords etc). We can't just delete the tokens because that would make
the oauth refresh useless.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-17 16:10:19 +02:00
Morris Jobke 9f064b08b3 Merge pull request #9507 from nextcloud/dep/noid/update_dompurify_1_0_4
Bump DOMPurify to 1.0.4
2018-05-17 16:02:38 +02:00
Morris Jobke 63d5491a73 Merge pull request #9503 from nextcloud/bugfix/noid/theming-mime-check
Check mime type properly in theming app
2018-05-17 15:48:44 +02:00
marco44 32fd0919c1 Make LargeFileHelper.php faster by avoiding execs as much as possible
Signed-off-by: Marc Cousin <cousinmarc@gmail.com>
2018-05-17 14:28:32 +02:00
Roeland Jago Douma 972bc9491a Bump DOMPurity to 1.0.4
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-17 13:24:00 +02:00
Julius Härtl 5b3ca8f7c6 Add Content-Disposition header
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-17 12:21:57 +02:00
Julius Härtl 2bf51c7b9e Properly check mime type of the uploaded file
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-17 11:46:01 +02:00
Nextcloud bot ef665fde42 [tx-robot] updated from transifex 2018-05-17 00:13:46 +00:00
Roeland Jago Douma 81ab924389 Merge pull request #9484 from nextcloud/feature/noid/support_rotating_tokens
Allow the rotation of tokens
2018-05-16 20:03:00 +02:00
Roeland Jago Douma aba255997a Allow the rotation of tokens
This for example will allow rotating the apptoken for oauth

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-16 19:27:19 +02:00
Morris Jobke 0011bfb64b Merge pull request #9475 from nextcloud/bug/9469/delete_preview_on_version_restore
Delete the previews when a version is restored
2018-05-16 11:37:12 +02:00
John Molakvoæ (skjnldsv) 746f3c9053 Proper error message and group order fix in select
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:25 +02:00
John Molakvoæ (skjnldsv) e23e28b3cc Various fixes
* Fixed  subadmin group management
* Fixed pass policy prop retrieving
* Fixed fields subadmins were not supposed to see

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:25 +02:00
John Molakvoæ (skjnldsv) bcffbab6f8 IE11 compatibility
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:24 +02:00
John Molakvoæ (skjnldsv) 549940ddb9 Fixed root url detection, new tests, default new user group to current
opened group and user removal update fix

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:24 +02:00
John Molakvoæ (skjnldsv) a62c796f07 Production build, router base url fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:24 +02:00
John Molakvoæ (skjnldsv) 170746dada Design fixes
- Gap between columns
- Click on icon more closes the menu
- Fixed select height
- Focus input on new user click
- Cursor fix on select

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:24 +02:00
John Molakvoæ (skjnldsv) b2389d0f01 Add feature to drone
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:24 +02:00
John Molakvoæ (skjnldsv) 6b1452bd7b Bump script and fixed copyright template
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:24 +02:00
John Molakvoæ (skjnldsv) a434077251 Tabs fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:24 +02:00
John Molakvoæ (skjnldsv) 07a592bd27 Users list acceptance tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:23 +02:00
John Molakvoæ (skjnldsv) f3a06259e4 newt acceptance tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:23 +02:00
John Molakvoæ (skjnldsv) e45147d7d6 Fixed router
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:23 +02:00
John Molakvoæ (skjnldsv) a30eacccbf Fixed new user form detection in acceptance
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:23 +02:00
John Molakvoæ (skjnldsv) 64eb43b1a3 Composer autoloader bump
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:23 +02:00
John Molakvoæ (skjnldsv) f9143f8db4 Fix row detection acceptance test
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:23 +02:00
John Molakvoæ (skjnldsv) 720ef48d92 Fix Applicationtest
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:23 +02:00
John Molakvoæ (skjnldsv) ae8ea57793 Bump tests and editorconfig
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:23 +02:00
John Molakvoæ (skjnldsv) 62e1014b2e Bump popovermenu item options and tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:22 +02:00
John Molakvoæ (skjnldsv) f4cec587d9 Bump makefile, readme, fix typo and cleanup
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:22 +02:00
John Molakvoæ (skjnldsv) f0586b2eb1 Last login tooltip and v-tooltip server compatibility css
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:22 +02:00
John Molakvoæ (skjnldsv) 72a76060bf Fixed settings menu entry and group deletion
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:22 +02:00
John Molakvoæ (skjnldsv) 0e5b0fcef0 new OC api and default quota fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:22 +02:00
John Molakvoæ (skjnldsv) ff2c23d9e2 Added default quota selector
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:22 +02:00
John Molakvoæ (skjnldsv) 45f1efe953 Continued the upgrade to proper router link and added navigationItem router linkTo capability
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:22 +02:00
John Molakvoæ (skjnldsv) 2963fdc879 Bump user controller, cleaned old legacy and added route history mode
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:22 +02:00
John Molakvoæ (skjnldsv) 422ecc4eda Supports app navigation loading state
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:21 +02:00
Joas Schilling 28776b72e6 Allow icon urls too
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-05-16 09:50:21 +02:00
John Molakvoæ (skjnldsv) e1297f1fde Various fixes and group deletion
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:21 +02:00
John Molakvoæ (skjnldsv) 8bca1558c3 Settings users list new user language
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:21 +02:00
John Molakvoæ (skjnldsv) 82e1f182c8 Loading state to vue and not css
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:21 +02:00
John Molakvoæ (skjnldsv) f33065523d Fixed tabs and Language support
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:21 +02:00
John Molakvoæ (skjnldsv) 6ada8254c9 Added language support in users list
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:21 +02:00
John Molakvoæ (skjnldsv) 85f5ae9264 Redirect if disabled list is empty
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:21 +02:00
John Molakvoæ (skjnldsv) a2d96128be Makefile
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:21 +02:00
John Molakvoæ (skjnldsv) 2ae82137cd Group filtering, disable state, ocs api final update
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:20 +02:00
John Molakvoæ (skjnldsv) c8f670dd8f Settings to vuejs
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:20 +02:00
Arthur Schiwon feff9f5bd1 Use link not address in labels for URLs
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-05-16 00:56:08 +02:00
Roeland Jago Douma 7de6c06c66 Merge pull request #9481 from nextcloud/techdep/noid/make_token_code_strict
Make the Token Auth code strict
2018-05-15 14:03:20 +02:00
Roeland Jago Douma 4ea2daf04d Refix scope
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-15 11:41:27 +02:00
Roeland Jago Douma 991d9b5c3a Fix session tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-15 11:32:25 +02:00
Roeland Jago Douma 466297829e Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-15 10:56:40 +02:00
Roeland Jago Douma 47388e1cfe Make the Token Auth code strict
In preparation for #9441

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-15 10:32:30 +02:00
Roeland Jago Douma 497a4facdf Merge pull request #9444 from nextcloud/techdep/noid/appframework_mapper_to_qb
Add a QueryBuilder based Mapper
2018-05-14 21:12:12 +02:00
Roeland Jago Douma 8657f56418 Merge pull request #9442 from nextcloud/feature/noid/use_composer_apcu
Use APCu caching of composer
2018-05-14 21:05:24 +02:00
Roeland Jago Douma 39bb9c06d1 Delete the previews when a version is restored
Fixes #9469

When a version of a file is restored the previews are no longer valid.
Thus we should remove them so they are regenerated.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-14 19:58:19 +02:00
Roeland Jago Douma ed7b4839d9 The column is not user input so suppress the phan warning
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-14 14:46:33 +02:00
Morris Jobke 0dcb6b2675 Merge pull request #9420 from nextcloud/feature/5263/cleanup_previes
Cleanup previews in the background
2018-05-14 14:28:55 +02:00
Roeland Jago Douma 4202b68ee2 Bump integration test image
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-14 14:20:55 +02:00
Morris Jobke d2cc48c6dd Merge pull request #9446 from nextcloud/feature/9416/fileid_trashbin_dav_endpoint
Support fileid propfind on trash endpoint
2018-05-14 14:09:28 +02:00
Morris Jobke 3e513809c2 Merge pull request #9429 from nextcloud/feature/noid/move_webui_to_new_dav
Move the webui over to the new dav endpoint
2018-05-14 13:35:23 +02:00
Roeland Jago Douma 0dffd07a60 Add tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-14 13:30:22 +02:00
Roeland Jago Douma 047cf5de07 Move to join
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-14 13:30:22 +02:00
Roeland Jago Douma 362e6b2903 Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-14 13:30:22 +02:00
Roeland Jago Douma 3e07c4f73a Kill the dete preview watcher
This code had the potential to time out. If a huge folder with pictures
for example was deleted then this could easily grow the number of files
to clean with a factor 5 (or more).

Now the previews just get cleaned up in the background. Which is good
enough for the 99% case

As a bonus this now also keeps the previews when in the trashbin so you
don't have a spiking server load when a user opens the trashbin view.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-14 13:30:06 +02:00
Roeland Jago Douma 253f962241 Add the job
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-14 13:25:55 +02:00
Roeland Jago Douma 3bfa031f38 Add backgroundcleanup job
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-14 13:25:55 +02:00
Roeland Jago Douma 575dc29c27 Make Appdata static
* Add fileid for simpleroot folders (only internal)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-14 13:25:54 +02:00
Morris Jobke 95592ff65c Merge pull request #9464 from nextcloud/fix/noid/version_expiration_DI
Use more magic DI in files_versions
2018-05-14 09:34:18 +02:00
Nextcloud bot 68dc6a306e [tx-robot] updated from transifex 2018-05-14 00:13:27 +00:00
Nextcloud bot 05df524472 [tx-robot] updated from transifex 2018-05-13 00:12:56 +00:00
Roeland Jago Douma d341a96701 Merge pull request #9288 from GitHubUser4234/ldap_password_renew_nc13fix
Ldap password renewal fixes for NC13
2018-05-12 10:46:57 +02:00
Nextcloud bot 5fcb3dd1dc [tx-robot] updated from transifex 2018-05-12 00:13:00 +00:00
Roeland Jago Douma cd53498256 Use more magic DI in files_versions
There is no need to register this. The system can figure out by itself
what it needs to do :)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-11 22:25:07 +02:00
Roeland Jago Douma 5eb72a8a57 Support fileid propfind on trash endpoint
Fixes #9416

In order to support previews on mobile clients they will need the fileid
of files in the trashbin.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-11 20:45:03 +02:00
Roeland Jago Douma 8d17d7f6cd Merge pull request #9447 from nextcloud/feature/noid/trashbin_propfind_oc_size
Trashbin propfind respond to oc:size
2018-05-11 20:24:38 +02:00
Arthur Schiwon 84ab102146 fix undo for url-typed inputs
and minor adjustments

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-05-11 15:57:32 +02:00
Arthur Schiwon 850e2256f3 fix tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-05-11 15:37:24 +02:00
Nextcloud bot 4b1c315dca [tx-robot] updated from transifex 2018-05-11 00:13:00 +00:00
Roeland Jago Douma 610c66520b Move over TokenMapper
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-10 19:47:43 +02:00
Roeland Jago Douma 6d299883ba Bump autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-10 19:47:43 +02:00
Roeland Jago Douma 74d7f6d4ca Add a QueryBuilder Mapper
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-10 19:47:43 +02:00
Roeland Jago Douma 58219638d7 Trashbin propfind respond to oc:size
In order to display the total size of folders also in the clients (and
web) we should return the oc:size.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-10 16:12:33 +02:00
Roeland Jago Douma 948ab8a4d0 Use APCu caching of composer
Should potentially shave of a few ms when loading classes of apps that
don't ship their own autoloader.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-10 12:35:56 +02:00
Roeland Jago Douma 58e4ddd638 Merge pull request #9360 from GitHubUser4234/ldap_password_renew_invarg_fix
Fix "Invalid argument supplied for foreach()"
2018-05-10 09:32:07 +02:00
Roeland Jago Douma 48034bdc4a Merge pull request #9427 from nextcloud/bugfix/noid/no_listing_if_not_in_debug_trash_version
If not in debug disable principal listing
2018-05-10 09:31:19 +02:00
Nextcloud bot 01c21601e8 [tx-robot] updated from transifex 2018-05-10 00:13:09 +00:00
blizzz 72dc01460e Merge pull request #9390 from nextcloud/bugfix/noid/no-body-for-no-content
Do not send a body for "No content", "Not modified" and others
2018-05-09 23:41:56 +02:00
Arthur Schiwon 62f1156a56 allow to specify a link to a legal notice
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-05-09 15:52:41 +02:00
Roger Szabo ced15ab756 adjust unit tests for \"Invalid argument supplied for foreach()\" fix
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2018-05-09 20:24:41 +08:00
Morris Jobke 57ea462474 Merge pull request #9415 from nextcloud/feature/noid/trashbin_dav_deletion_time
Propfind for deletion time of trash files
2018-05-09 08:40:53 +02:00
Nextcloud bot 412925e71d [tx-robot] updated from transifex 2018-05-09 00:11:27 +00:00
Roeland Jago Douma d607e7b924 Move the webui over to the new dav endpoint
We should use the new dav endpoint everywhere now.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-08 23:02:19 +02:00
Roeland Jago Douma 17f1653ceb If not in debug disable principal listing
Trashbin and Version should have the same behaviour as the other
collections.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-08 20:52:14 +02:00
Robin Appelman 335619f6a4 Check connection status and attempt to reconnect each each minute
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-08 19:25:58 +02:00
Morris Jobke 4327eea121 Merge pull request #9418 from nextcloud/php-message-indexphp
Add PHP missing message to index.php
2018-05-08 17:01:34 +02:00
Roeland Jago Douma 7d3e7f4341 Merge pull request #9421 from nextcloud/navigation-settings-data-id
Add data-id to settings navigation
2018-05-08 15:42:18 +02:00
Roeland Jago Douma c40f7cd283 Merge pull request #9419 from nextcloud/feature/noid/isCLI_parameter
Expose isCLI to DI
2018-05-08 14:16:15 +02:00
Roeland Jago Douma c37bc4fdf9 Expose isCLI to DI
This allows apps/backgroundjobs to find out if they are run from the CLI
or not. Some apps/backgroundjobs might do more if they are not at risk
of timing out.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-08 13:32:37 +02:00
Julius Härtl 897898a93b Add data-id to settings navigation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-08 13:14:02 +02:00
Marius Blüm a64aad9c4b Add PHP missing message to index.php
Signed-off-by: Marius Blüm <marius@lineone.io>
2018-05-08 12:01:08 +02:00
Roeland Jago Douma 21d4ce926e Propfind for deletion time of trash files
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-08 09:08:43 +02:00
Nextcloud bot 9fe95e8a7c [tx-robot] updated from transifex 2018-05-08 00:11:34 +00:00
Morris Jobke 6180feeb9d Merge pull request #9381 from nextcloud/feature/noid/add-autocomplete-to-migration-commands
Add autocomplete to migration commands
2018-05-07 18:46:50 +02:00
Morris Jobke b348431bce Merge pull request #8842 from lanxenet/patch-1
fix(AmazonS3):  fix loop $result['Contents'] error
2018-05-07 18:41:39 +02:00
Morris Jobke 43c1e51a5f Merge pull request #9151 from UncleAlbie/dialog-sort
Sort files in dialog by name.
2018-05-07 18:39:24 +02:00
Morris Jobke cc359be048 Merge pull request #9411 from nextcloud/new-help-icon
Replace help icon with ? to avoid conflict with the new about section
2018-05-07 18:18:54 +02:00
Morris Jobke 7639f680a2 Merge pull request #9397 from nextcloud/log-fileinfo-not-found
Debug log file not found when getting fileinfo
2018-05-07 16:43:38 +02:00
Morris Jobke 7f5567e758 Merge pull request #9388 from nextcloud/log-lock-state-on-conflict
Log lock state on conflict
2018-05-07 16:42:26 +02:00
Morris Jobke 6d5f4432cd Merge pull request #9313 from nextcloud/phan-check-php-doc
Check doc block signature to match the specified return type
2018-05-07 15:45:41 +02:00
Morris Jobke 8b0616347c Merge pull request #9374 from nextcloud/federation-share-popover-fix
Federation share popover fix
2018-05-07 15:34:44 +02:00
blizzz ec0623045b Merge pull request #9393 from nextcloud/bugfix/noid/fix-workflow-rules
Fix workflow rules
2018-05-07 14:57:55 +02:00
John Molakvoæ eb063fdb6e Merge pull request #9363 from nextcloud/bugfix/noid/highlighted-navigation-counter
Add support for a highlighted navigation counter
2018-05-07 14:44:16 +02:00
Julius Härtl cbe49ef5c2 Replace help icon with ? to avoid conflict with the new about section
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-07 14:42:50 +02:00
John Molakvoæ (skjnldsv) 16231da19f Fix position and template
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-07 14:37:40 +02:00
John Molakvoæ (skjnldsv) eadc143d91 Fixed federation scope popovermenu
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-07 14:37:40 +02:00
Morris Jobke 986070e1fe Merge pull request #9406 from nextcloud/security-devices-sessions
Rename "Security" to "Devices & sessions"
2018-05-07 14:24:20 +02:00
John Molakvoæ e5b61781ec Fixed padding
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-07 14:11:00 +02:00
John Molakvoæ (skjnldsv) fbe9166076 Highlight element change and alignement fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-07 14:11:00 +02:00
Joas Schilling b045272951 Add support for a highlighted navigation counter
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-05-07 14:11:00 +02:00
Morris Jobke d161d4473e Merge pull request #9029 from nextcloud/settings-restructure
Restructure server settings
2018-05-07 12:29:53 +02:00
John Molakvoæ 94010e91d1 Merge pull request #9407 from nextcloud/fix-jsunit
Fix jsunit tests
2018-05-07 12:16:07 +02:00
Julius Härtl 951ac518e1 Fix jsunit tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-07 11:19:50 +02:00
Marius Blüm 6fea0ddffb Rename "Security" to "Devices & sessions"
Signed-off-by: Marius Blüm <marius@lineone.io>
2018-05-07 10:49:30 +02:00
Morris Jobke 5484260569 Merge pull request #9372 from nextcloud/bugfix/4577
Do not allow folder creation with quota of 0
2018-05-07 10:11:44 +02:00
Morris Jobke 0da6f6b356 Merge pull request #9371 from nextcloud/bugfix/7444
Cache is not part of the quota
2018-05-07 10:11:04 +02:00
Nextcloud bot 94e3bdf703 [tx-robot] updated from transifex 2018-05-07 00:11:36 +00:00
Nextcloud bot cc09226564 [tx-robot] updated from transifex 2018-05-06 00:11:39 +00:00
Nextcloud bot 1ce3a618a8 [tx-robot] updated from transifex 2018-05-05 00:11:47 +00:00
Robin Appelman e3de7ec867 Debug log file not found when getting fileinfo
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-04 18:48:12 +02:00
Robin Appelman 63caf331e5 cleanup locks in scanner on error
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-04 18:05:46 +02:00
Joas Schilling fc582d6253 Do not error when the tag does not exist
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-05-04 16:11:56 +02:00
Joas Schilling 2dd8e90a9f Reset the value when changing the check class (because it might be invalid)
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-05-04 16:11:24 +02:00
Joas Schilling a61fa70bcd Revert back to tabs
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-05-04 15:57:06 +02:00
Joas Schilling bd9209b316 Fix "data is undefined" by adjusting the name of the parameter
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-05-04 15:54:54 +02:00
Morris Jobke fb296342b9 Merge pull request #9387 from nextcloud/getcachentry-lock
remove unneeded locks in getCacheEntry
2018-05-04 14:57:09 +02:00
Joas Schilling b4bacf46f3 Do not send a body for "No content", "Not modified" and others
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-05-04 13:46:13 +02:00
Robin Appelman 94c15efad0 always log locking errors
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-04 13:30:43 +02:00
Robin Appelman 25565dd7d8 Log more info about locking conflicts for memcache locking backends
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-04 13:30:18 +02:00
Robin Appelman 734aec1522 remove unneeded locks in getCacheEntry
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-04 12:51:41 +02:00
Morris Jobke 2780bb0b2b Merge pull request #9364 from nextcloud/log-invalid-storage
Log mount and storage issues in getFileInfo
2018-05-04 12:01:33 +02:00
Nextcloud bot bd2aede6a3 [tx-robot] updated from transifex 2018-05-04 00:11:52 +00:00
Morris Jobke 3f2a5c9335 Merge pull request #9290 from nextcloud/streams-0.6.1
Use better way to determine stream type in stream wrapper
2018-05-03 17:15:02 +02:00
Morris Jobke 2d66f04aa0 Merge pull request #9340 from gboudreau/dev/chrome-devconsole-sourcemap-warnings
Resolves warnings in Chrome Dev Console
2018-05-03 16:58:41 +02:00
Joas Schilling f772b7b4dd Add autocomplete to migration commands
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-05-03 16:52:56 +02:00
Morris Jobke dc5c4b2e1f Merge pull request #9353 from nextcloud/feature/4724/versions_dav
Add versions DAV endpoint
2018-05-03 16:52:32 +02:00
Morris Jobke fb9cb6d4c6 Merge pull request #9373 from nextcloud/bugfix/8929/actual_fetch_version
Get correct version of an app
2018-05-03 16:45:18 +02:00
Morris Jobke 7cb467b476 Merge pull request #9355 from nextcloud/dav-upload-lock
only allow a single concurrent dav write to a file
2018-05-03 16:28:39 +02:00
Morris Jobke ceb674632c Merge pull request #9332 from nextcloud/personal-settings-fixes
Small improvements for personal settings
2018-05-03 13:55:52 +02:00
Roeland Jago Douma 0ff83f7230 Do not allow folder creation with quota of 0
Fixes #4577

Users with a quota of 0 are a special case. Since they can't (ever)
create files on their own storage. Therefor it makes no real that they
can create folders (and possible share those etc).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-03 11:31:23 +02:00
Morris Jobke b6457e4135 Only show used amount for unlimited quota users
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-05-03 10:50:08 +02:00
Julius Härtl 94528ad2be Move quota icon to core
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 10:32:16 +02:00
Julius Härtl d0efe1bf6c Translate details text
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 10:32:15 +02:00
Julius Härtl 4b550eb699 Move quota bar to info section and make it a bit simpler
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 10:32:14 +02:00
Julius Härtl e6a463d1f3 Personal settings: Fix visibility alignment and avatar description text
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 10:32:13 +02:00
Morris Jobke 0f8210792c Merge pull request #9352 from nextcloud/9318_SCSSCacher_resetCache_catch_exception
Issue #9318: catch exceptions in SCSSCacher::resetCache()
2018-05-03 09:56:26 +02:00
Julius Härtl ea8e80c20b Adjust updatenotification app settings section/priority
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:25 +02:00
Julius Härtl 35cb529df3 Fix settings tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:25 +02:00
Julius Härtl e81b1399d4 Remove border from personal settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:25 +02:00
Julius Härtl 5f9503abdb Dump autoloader
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:25 +02:00
Julius Härtl 9bfc108b79 Cleanup and fix tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:24 +02:00
Julius Härtl 1f2f701931 Readd space in app store view
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:24 +02:00
Julius Härtl 4251856218 Increase space of settings headers
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:24 +02:00
Julius Härtl 154a579651 Increase visibility of the warning color
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:24 +02:00
Julius Härtl 2b840250c3 Move documentation link in relation to the heading
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:24 +02:00
Julius Härtl 8b0c6c6df1 Do not hide additional settings if there are only legacy forms
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:24 +02:00
Julius Härtl 9a6b2d28fa Move additional settings to main server settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:23 +02:00
Julius Härtl f6f0f5be40 Add separator between settings sections
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:23 +02:00
Julius Härtl d30109c316 Make mail settings form width equal
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:23 +02:00
Julius Härtl 82ff26f4ec Fix styling of system check list
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:23 +02:00
Julius Härtl adef21ba71 Update autoloader
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:23 +02:00
Julius Härtl cea4c9d000 Move files settings to main server settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:23 +02:00
Julius Härtl a77efe0a55 Move dav settings to main server settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:22 +02:00
Julius Härtl f2f5371d89 Add overview settings section
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:22 +02:00
Roeland Jago Douma f7b518fdbf Get correct version of an app
Related to #8929

We should get the version of the app. Not of the appfolder. Else there
is no way to properly compare the versions.

Now note that installing in 1 go will still fail. But at least on the
next page load the new version will be properly detected.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-03 08:22:03 +02:00
Nextcloud bot 346e46af49 [tx-robot] updated from transifex 2018-05-03 00:11:58 +00:00
Roeland Jago Douma f2d05120b4 Cache is not part of the quota
Fixes #7444

Since the quota is calculated on the files. We should allow apps etc to
store temp stuff in the <user>/cache

Else users can't upload avatars for example.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-02 21:46:28 +02:00
Roland Tapken 6270a01cab Issue #9318: catch exceptions in SCSSCacher::resetCache()
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2018-05-02 21:23:13 +02:00
Morris Jobke 2aa108000c Merge pull request #9293 from nextcloud/feature/9166/custom-auditlogfile
option for a seperate audit log file
2018-05-02 16:16:28 +02:00
Morris Jobke a56ec1062a Merge pull request #9346 from nextcloud/techdep/noid/needsPartFile_to_storage
Use an actual function of the storage to determine needsPartFile
2018-05-02 16:03:31 +02:00
Robin Appelman d71783fb93 Log mount and storage issues in getFileInfo
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-02 15:11:59 +02:00
Roger Szabo 856164e578 Fix "Invalid argument supplied for foreach()"
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2018-05-02 18:17:21 +08:00
Roeland Jago Douma dfe6d65410 Merge pull request #9310 from nextcloud/bugfix/noid/allow-to-inject-collaboration-search-result
Allow to inject ISearchResult
2018-05-02 09:45:25 +02:00
Morris Jobke e9c6ec4b22 Merge pull request #8564 from nextcloud/files_external_read_only
Make it possible to make external storages read only
2018-05-01 23:39:30 +02:00
Roeland Jago Douma ea5393e9f8 Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-01 15:20:20 +02:00
Roeland Jago Douma 953691abb2 External mount does not get DELETE and UPDATE if readonly
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-01 15:18:56 +02:00
Roeland Jago Douma db96b0bb0b Make it possible to make external storages read only
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-01 15:18:56 +02:00
Robin Appelman 57ba18f47f Use better way to determine stream type in encryption stream wrapper
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-01 15:06:21 +02:00
Robin Appelman c27016b1d1 update icewind/streams to 0.6.1
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-01 15:06:21 +02:00
Roeland Jago Douma 055a003661 Use an actual function of the storage to determine needsPartFile
We have a function for it so better to override that. Also because other
codes that might check this should get the right value.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-01 15:02:36 +02:00
Morris Jobke f212c692ac Merge pull request #9178 from nextcloud/feature/9142/directdownload
Add directdownload endpoint
2018-05-01 14:54:44 +02:00
Roeland Jago Douma 7f194be3ab Merge pull request #9202 from nextcloud/feature/1332/trashbin_dav
Trashbin endpoint in DAV
2018-05-01 14:24:38 +02:00
Roeland Jago Douma 5401732cd2 Allow to read get old versions
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-01 08:38:59 +02:00
Roeland Jago Douma dd47ebb062 Add rollback
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-01 08:38:59 +02:00
Roeland Jago Douma d40afac1b9 Add version collection to DAV
listed as
versions/<username>/versions/<file id>/<timastamp>

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-01 08:38:59 +02:00
Nextcloud bot c8cb42fd26 [tx-robot] updated from transifex 2018-05-01 00:11:52 +00:00
John Molakvoæ 49f26d1221 Merge pull request #9348 from nextcloud/fix-js-tests
Replace deprecated sinon reset() call with resetHistory()
2018-04-30 14:54:34 +02:00
Julius Härtl 16865e59dd Replace deprecated sinon reset() call with resetHistory()
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-30 13:52:58 +02:00
Nextcloud bot b87b0689c5 [tx-robot] updated from transifex 2018-04-30 00:11:48 +00:00
Guillaume Boudreau eb97035312 Resolves warnings in Chrome Dev Console:
"DevTools failed to parse SourceMap: .../core/vendor/..."
2018-04-29 09:29:56 -04:00
Nextcloud bot a546dcfcb3 [tx-robot] updated from transifex 2018-04-29 00:11:47 +00:00
Nextcloud bot 6ee00a8be5 [tx-robot] updated from transifex 2018-04-28 00:11:58 +00:00
Morris Jobke d8350c69ef Merge pull request #9309 from nextcloud/feature/noid/no_js_sharepermission_logic
Do not add sharePermission logic in JS
2018-04-27 14:01:40 +02:00
Morris Jobke 7102ddad50 Merge pull request #9325 from GitHubUser4234/ldap_cloned_connection_nc13fix
Fix for unbound cloned LDAP connections
2018-04-27 14:01:15 +02:00
Morris Jobke 7306d30708 Merge pull request #9321 from nextcloud/bugfix/noid/return_root_folder_when_at_root
Actually return the root folder when traversing up the tree
2018-04-27 13:59:29 +02:00
Morris Jobke 21da3594f6 Merge pull request #9322 from nextcloud/bugfix/noid/swift_token_cache
Better swift V3 token handling
2018-04-27 13:51:44 +02:00
Roger Szabo 8637b90e15 unbound cloned connection fix
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2018-04-27 17:29:15 +08:00
Morris Jobke 7da1e968f9 Merge pull request #9319 from nextcloud/rakekniven-patch-1
Fixed typo
2018-04-27 09:15:21 +02:00
Nextcloud bot 9e3522af54 [tx-robot] updated from transifex 2018-04-27 00:11:53 +00:00
Arthur Schiwon aff5fe68b3 use SystemConfig, less dependencies, and not publicly needed
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 23:54:11 +02:00
Roeland Jago Douma a0e038f912 generateTokenFromCache is only valid for V3
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 20:51:05 +02:00
Roeland Jago Douma 7318882357 json_decode an associative array for the swift cached token
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 20:47:47 +02:00
Roeland Jago Douma 235e3480e6 Actually return the root folder when traversing up the tree
If you now keep calling $node->getParent() you will at some point get
the RootFolder back. This is a nice termination check and will prevent
endless loops if an exit condition is slightly off.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 20:04:19 +02:00
rakekniven ace2063f21 Fixed typo 2018-04-26 18:12:21 +02:00
Roeland Jago Douma d379770cf2 Fix sharedfilelistSpec.js tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 16:34:24 +02:00
Morris Jobke 13b503a1a4 Check doc block signature to match the specified return type
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-26 14:35:24 +02:00
Morris Jobke bb82bfac6d Merge pull request #9302 from nextcloud/update-phan-config
Improve phan config
2018-04-26 13:53:14 +02:00
Joas Schilling f5b143e318 Allow to inject ISearchResult
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-04-26 12:19:15 +02:00
Roeland Jago Douma 0771dad57f Do not add sharePermission logic in JS
We have a dedicated dav property. We should do all the magic in 1 place.
Not several.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 12:14:37 +02:00
Arthur Schiwon b841a477c6 log to $datadir/audit.log by default and add rotation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 12:10:53 +02:00
Arthur Schiwon ab7a4b8693 fix dav test
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 12:10:53 +02:00
Arthur Schiwon 5751788282 add missing php doc and type hints
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 12:10:53 +02:00
Arthur Schiwon a21a5bc4ec improve Syslog a little
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 12:10:53 +02:00
Arthur Schiwon 0e6a317516 revert Log's dependency to SystemConfig to work during Installation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 12:10:53 +02:00
Arthur Schiwon 69592408c4 move IFileBased to public namespace, logreader needs it
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 12:10:52 +02:00
Arthur Schiwon cfc3ab0119 offer API to create own File log. admin_audit makes use of it
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 12:10:52 +02:00
Arthur Schiwon 5fbf184134 destaticfy Log classes
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 12:00:06 +02:00
Morris Jobke b7e8ab97e7 Merge pull request #9308 from nextcloud/proper-ocp-constants
Move log constants to ILogger
2018-04-26 11:53:21 +02:00
Lukas Reschke 3aaa2307e9 Improve phan config
* exclude routes

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-26 11:51:05 +02:00
Robin Appelman dd1b0799a4 only allow a single concurrent dav write to a file
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-26 11:16:51 +02:00
Arthur Schiwon 38a90130ce move log constants to ILogger
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 10:45:52 +02:00
Roeland Jago Douma 1c75ddac45 Improve the directContoller
* Tests
* No directdownload from storage yet (as it is not tested at all)
* No direct links for folders

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:38 +02:00
Roeland Jago Douma d5222d68f0 Add tests for DirectFile and DirectHome
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
Roeland Jago Douma 392337fa13 Throttle requests to unknown tokens
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
Roeland Jago Douma b6c58e75b7 Add backgroundjob to cleanup expired direct links
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
Roeland Jago Douma 042340ccf6 Check if a direct link is expired
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
Roeland Jago Douma 6a385dd20b Add directDownload support of storage
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
Roeland Jago Douma 164d998856 No listing
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
Roeland Jago Douma b3e7865d9b Dav endpoint returns proper data
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
Roeland Jago Douma 5c6d3b4f41 Request a direct link
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
Roeland Jago Douma f984664bee First step of DAV endpoint
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
Roeland Jago Douma 9ab5b6a4f1 Add DB mapping
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
Roeland Jago Douma b0c801c764 Add directdownload table
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
Nextcloud bot 12c5db9032 [tx-robot] updated from transifex 2018-04-26 00:12:10 +00:00
Roeland Jago Douma c625fc5931 Add folder for trashbin
The trashbin home now contains 2 entries restore and trash.

Made all files strict. Added more types.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-25 20:25:10 +02:00
Roeland Jago Douma dadc740db5 Use getType to determine type of entry
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-25 20:25:10 +02:00
Roeland Jago Douma d5937e0fd6 Add propfind properties to trashbin
* get original filename (without the weird timestamp)
* get original location

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-25 20:25:10 +02:00
Roeland Jago Douma cb617c4949 Add special restore folder
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-25 20:25:10 +02:00
Roeland Jago Douma f7ca6149d6 Emptry trashbin
A delete on a users trashbin will empty it (the trashbin won't be
deleted of course)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-25 20:25:10 +02:00
Roeland Jago Douma 09940bcde6 List trashbin in DAV
First steps for #1332

* Add a new DAV collection
* List all files in the trashbin for this user
* Deleting files from trashbin
* Get files from trashbin (just read)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-25 20:25:10 +02:00
Morris Jobke 9c64a203e3 Merge pull request #9256 from nextcloud/fed-sharing-improvements
improve error reporting and move format parameter to the options
2018-04-25 15:49:30 +02:00
Bjoern Schiessle 0e0cfa0fa1 improve error reporting and move format parameter to the options
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-04-25 13:53:56 +02:00
Morris Jobke 5a4a0add3c Merge pull request #9296 from nextcloud/migrate-groups-fetch-to-ocs-api
Migrate groups fetch to ocs api
2018-04-25 13:45:35 +02:00
Morris Jobke c907b68842 Merge pull request #9284 from nextcloud/bugfix/9279/strict_sharee_api
Make ShareesAPIController strict
2018-04-25 11:53:52 +02:00
Roger Szabo aa85418c68 Remove unneeded semicolon and parentheses
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2018-04-25 15:54:33 +08:00
Roger Szabo cc40917e5e css indent alignment
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2018-04-25 14:47:16 +08:00
Morris Jobke b3a0dec8d5 Merge pull request #8540 from nextcloud/theming-advanced
Add option for header logo and favicon in theming app
2018-04-25 08:47:14 +02:00
John Molakvoæ (skjnldsv) 8c845be11c Workflow engine to ocs api
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-25 07:47:16 +02:00
John Molakvoæ (skjnldsv) d53193fd8e Settings groups to ocs
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-25 07:37:20 +02:00
Nextcloud bot 3e14f21ae7 [tx-robot] updated from transifex 2018-04-25 00:11:50 +00:00
Roeland Jago Douma 0dc019370d Merge pull request #9248 from nextcloud/fix-files-ellipsis
Fix ellipsis in filename column
2018-04-24 20:36:41 +02:00
Roeland Jago Douma d59791ab6f Merge pull request #9292 from nextcloud/bugfix/9279/cast_db_backend_numeric
Cast retrieved DB fields to string
2018-04-24 20:04:38 +02:00
Roeland Jago Douma 81f71cb1f9 Numeric only uids are no fun
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-24 14:23:50 +02:00
Roeland Jago Douma 074a0e0665 Cast retrieved DB fields to string
Fixes #9279

If a pure numerical user is in the DB the value might be casted to a int
when returned. Cast it all to a string so we don't break the strict
typing.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-24 12:48:52 +02:00
Joas Schilling 09398397b3 Merge pull request #9282 from nextcloud/bugfix/9279/scrit_type_share_api
Make the ShareAPIController strict
2018-04-24 11:57:52 +02:00
Roger Szabo 571b337a5e adjust css to nc13 core changes
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2018-04-24 15:53:48 +08:00
Roeland Jago Douma 1ceb081c9b Merge pull request #9280 from nextcloud/bugfix/noid/swift-v3-scope
Swift v3 requires setting a scope
2018-04-24 09:49:27 +02:00
Roger Szabo 15fb3bb73a remove reset password link
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2018-04-24 15:47:31 +08:00
Roeland Jago Douma 4d5a2cce8d Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-24 08:07:25 +02:00
Nextcloud bot 9339c7d20f [tx-robot] updated from transifex 2018-04-24 00:11:53 +00:00
Roeland Jago Douma 3b3ff39431 Make ShareesAPIController strict
Fixes #9279

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-23 22:05:21 +02:00
Roeland Jago Douma 3b34a77c58 Make the ShareAPIController strict
Fixes #9279

With types we can force php to not cast a full nummeric user to an int.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-23 20:31:57 +02:00
Roeland Jago Douma ba71918ad2 Swift v3 requires setting a scope
Unscoped auth is not guaranteed to return a catalog. So require the
scope to be set properly.

See https://developer.openstack.org/api-ref/identity/v3/index.html#password-authentication-with-unscoped-authorization

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-23 19:34:09 +02:00
Morris Jobke 83b0ce0955 Merge pull request #9278 from nextcloud/bug/noid/ldap-wizard-newaccess
Access needs UserManager, missed to add in #8833
2018-04-23 17:49:07 +02:00
Daniel Calviño Sánchez 9b150001ff Merge pull request #9272 from nextcloud/bugfix/noid/save-a-query-help-saving-the-world
Only query last comment info, when there is one
2018-04-23 16:43:09 +02:00
Morris Jobke 351255b216 Merge pull request #9276 from nextcloud/remove-unused-config-sample
Remove unused config option
2018-04-23 16:29:06 +02:00
Arthur Schiwon ed5f53bd49 Access needs UserManager, missed to add in #8833
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-23 15:58:50 +02:00
Joas Schilling 05a6b71a61 Merge pull request #9271 from nextcloud/fix-undefined-variable
Fix undefined variable - found by Phan
2018-04-23 15:51:15 +02:00
Roeland Jago Douma 000f41ba01 Merge pull request #9275 from nextcloud/group_backends
Make the group backends also possible using interfaces
2018-04-23 15:37:34 +02:00
Morris Jobke f2e18d496e Remove unused config option
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-23 15:06:38 +02:00
Morris Jobke 6c6feeaa1e Merge pull request #9269 from nextcloud/fix-DI-for-federeatedfilesharing-controller
Fix DI for federated file sharing controller
2018-04-23 15:06:11 +02:00
Roeland Jago Douma 961b27eeb0 Convert group Database backend
This now uses the new interfaces

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-23 14:39:30 +02:00
Morris Jobke 093cd01ac2 Fix DI for federated file sharing controller
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-23 13:49:28 +02:00
Roeland Jago Douma 5fcd97dcb6 Bump autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-23 13:27:14 +02:00
Morris Jobke 4fd697e733 Remove a check for an unused variable
Left over from a refactoring

https://github.com/nextcloud/server/pull/1940

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-23 11:53:48 +02:00
Joas Schilling 446efa4625 Only query last comment info, when there is one
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-04-23 11:50:30 +02:00
Roeland Jago Douma cf0501d632 Make the group backends also possible using interfaces
Just like for the user backends the group backends should also be
properly done using interfaces.

This adds the interfaces and abstract class to get started

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-23 11:49:28 +02:00
Morris Jobke 431ccb6386 Fix undefined variable - found by phan
Added in https://github.com/nextcloud/server/pull/8314/files#diff-a55c10804586cd797b7f3f16556c1457R157

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-23 11:34:41 +02:00
Morris Jobke 67dcff7a1f Fix undefined variable - found by Phan
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-23 11:30:22 +02:00
Roeland Jago Douma 3ff041f86d Merge pull request #9245 from nextcloud/fix-race-condition-when-preparing-upload-folder
Fix race condition when preparing upload folder
2018-04-23 08:50:16 +02:00
Roeland Jago Douma a80fcf177b Merge pull request #9255 from nextcloud/less-deprecated-calls
Less deprecated calls to OCP\Util::writeLog
2018-04-23 08:04:50 +02:00
Nextcloud bot a74fbe78a7 [tx-robot] updated from transifex 2018-04-23 00:11:49 +00:00
Julius Härtl cbdaa8b7ce Add min-width to trick the table width calculation in safari
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-22 23:09:15 +02:00
Roeland Jago Douma 0ed6f9c2da Merge pull request #9129 from nextcloud/feature/noid/proper-comments-offset
Add proper comment offset support
2018-04-22 20:47:30 +02:00
Roeland Jago Douma 9f4e928c0f Merge pull request #9225 from nextcloud/bugfix/9157/ipv6-database-host
Allow IPv6 database hosts
2018-04-22 20:43:29 +02:00
Morris Jobke dd34cb7540 Less deprecated calls to OCP\Util::writeLog
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-22 20:41:49 +02:00
Daniel Calviño Sánchez 375a55b0ad Fix race condition when preparing upload folder
Before any upload is submitted the upload is registered in a list of
known uploads; this is needed to retrieve the upload object at several
points of the upload process. When a chunked upload is submitted first a
directory to upload all the chunks is created and, once that is done,
the chunks are sent; in order to send a chunk the upload object needs to
be retrieved from the list of known uploads.

When all the active uploads were finished the list of known uploads was
cleared. However, an upload is not active until it actually starts
sending the data, so while waiting for the upload directory to be
created the upload is already in the list of known uploads yet not
active. Due to all this, if the active uploads finished while another
pending upload was waiting for the upload directory to be created that
pending upload would be removed from the list of known uploads too, and
once the directory was created and thus the chunks were sent a field of
a null upload object would be accessed thus causing a failure.

Instead of removing all the known uploads at once when the active
uploads finish now each upload is explicitly removed when it finishes.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-22 20:38:11 +02:00
Nextcloud bot 74b5ab8d39 [tx-robot] updated from transifex 2018-04-22 00:11:51 +00:00
Nextcloud bot 6b5132502e [tx-robot] updated from transifex 2018-04-21 00:11:39 +00:00
Morris Jobke 0580f498f2 Merge pull request #9254 from nextcloud/fix-app-sidebar-offset
Also adjust app sidebar offset to new header height
2018-04-20 17:13:52 +02:00
Julius Härtl dbfd00897f Also adjust app sidebar offset to new header height
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-20 14:22:06 +02:00
Nextcloud bot 8748e636f6 [tx-robot] updated from transifex 2018-04-20 00:12:00 +00:00
Julius Härtl d771f65911 Add more tests for ImageManager
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-19 20:14:40 +02:00
Julius Härtl b385f1c7d5 Fix theming tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-19 20:14:40 +02:00
Julius Härtl 7f9dabd984 Make sure the custom favicon is used
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-19 20:14:40 +02:00
Julius Härtl 39f44e1452 Add typehints
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-19 20:14:40 +02:00
Julius Härtl daadc1c892 Fix background color
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-19 20:14:39 +02:00
Julius Härtl 5a5c125b23 Return value
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-19 20:14:39 +02:00
Julius Härtl 3ad2768909 Remove unneeded preview image handling
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-19 20:14:39 +02:00
Julius Härtl d8045966de Fix undo preview and remove duplicate code
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-19 20:14:39 +02:00
Julius Härtl d8b57924fb Add advanced theming options to frontend
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-19 20:14:39 +02:00
Julius Härtl ee44dec0ac Use generic image upload in theming JS
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-19 20:14:38 +02:00
Julius Härtl dfda5c683d Use SCSS for previewing images as well
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-19 20:14:38 +02:00
Julius Härtl 02d3e09c86 Move theming settings to SCSS
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-19 20:14:38 +02:00
Julius Härtl 272b392cac Move to more generic image handling and add extra images
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-19 20:14:38 +02:00
Julius Härtl fb7d73708b Use flex based layout inside the filename table cell
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-19 20:13:26 +02:00
Joas Schilling cccdfaa6e9 Fix FakeManager
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-04-19 17:12:07 +02:00
Joas Schilling 5157349b69 Fix docs
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-04-19 17:10:03 +02:00
Morris Jobke 0bae516c66 Merge pull request #9224 from nextcloud/accessibility-improvements
Add labels for Contacts menu and Settings, thanks to @MarcoZehe
2018-04-19 14:47:17 +02:00
Morris Jobke 4d71e12a43 Merge pull request #9237 from nextcloud/fix-ids-of-permission-checkboxes-for-shares
Fix ids of permission checkboxes for shares
2018-04-19 14:11:51 +02:00
Morris Jobke a4cb83df27 Add tests for special domain name
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-19 13:59:08 +02:00
Morris Jobke d686b19a16 Add tests for domains
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-19 13:58:02 +02:00
Joas Schilling 78ee3abb78 Move regex to a function and add tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-04-19 12:49:36 +02:00
Joas Schilling 1fbfe7b72c Add an option for mail addons
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-04-19 10:32:05 +02:00
Joas Schilling a6458745bd Fix code errors
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-04-19 10:30:43 +02:00
Nextcloud bot 7ca526f8ac [tx-robot] updated from transifex 2018-04-19 00:11:50 +00:00
Roeland Jago Douma 307a2a17c3 Merge pull request #9106 from nextcloud/feature/7488/run_federated_discoverjob_in_cron
Run federated discoverjob in cron
2018-04-18 21:29:21 +02:00
Morris Jobke fa76b49cd2 Fix PHPDoc
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-18 19:20:26 +02:00
Roeland Jago Douma 0b6e197491 Add background job to refresh federated discovery
Once a day refresh the information automatically in cron

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-18 19:20:26 +02:00
Roeland Jago Douma a0028a2a5f Allow to skip retrieving from cache in the DiscoveryService
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-18 19:18:34 +02:00
Daniel Calviño Sánchez f8e3b572c8 Remove no longer needed escaping of special characters
The escaping of special characters was needed when the ids of the
permission checkboxes for shares were based on the "shareWith" field.
Since they are based on the "shareId" field the escaping is no longer
needed, as the "sharedId" is expected to always contain compatible
characters.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-18 17:03:45 +02:00
Jan-Christoph Borchardt 0f9ba852bc Fix form labels and main landmark on log in page
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 16:14:09 +02:00
Jan-Christoph Borchardt 1c00f82ea5 Do not restrict zooming in
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 15:51:52 +02:00
Jan-Christoph Borchardt 0ee9924b16 Add aria-label to more-apps menu as well
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 15:40:47 +02:00
Jan-Christoph Borchardt 0d675eca56 Ensure proper color contrast according to WCAG AA
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 15:38:30 +02:00
Daniel Calviño Sánchez 1466586033 Fix ids of permission checkboxes for shares
The ids of permission checkboxes for shares were generated using the
"shareWith" field of the share. The "shareWith" field can contain spaces
(as spaces are allowed, for example, in user or circle names), so this
could cause the id attribute of the HTML element to contain spaces too,
which is forbidden by the HTML specification.

It is not just a "formal" issue, though; when the list was rendered, if
the id contained a space the selector to get the checkbox element was
wrong (as it ended being something like
"#canEdit-view1-name with spaces") and thus the initial state of the
checkbox was not properly set.

Besides that, "shareWith" can contain too single quotes, which would
even cause the jQuery selector to abort the search and leave the UI in
an invalid state.

Instead of adding more cases to the regular expression to escape special
characters and apply it too when the ids are created now the ids of
permission checkboxes for shares are based on the "shareId" field
instead of on "shareWith", as "shareId" is expected to always contain
compatible characters.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-18 15:25:23 +02:00
Jan-Christoph Borchardt df3c1ac283 Add proper ARIA attributes and structure to header for accessibility, thanks to @MarcoZehe
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 15:07:42 +02:00
Joas Schilling 8f7a0af951 Allow IPv6 database hosts
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-04-18 14:48:21 +02:00
Joas Schilling f50abde7ac Add proper comment offset support
The offset is based on the last known comment instead of limit-offset,
so new comments don't mess up requests which get the history of an object-

Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-04-18 14:23:15 +02:00
John Molakvoæ b2a87f84c4 Merge pull request #9218 from nextcloud/personal-settings
Move personal settings to css grid layout
2018-04-18 10:14:25 +02:00
Patrik Novotný e977246d7c Sort files in dialog by name.
Signed-off-by: Patrik Novotný <patrik.novotny@gmx.com>
2018-04-18 08:44:40 +02:00
Nextcloud bot d4aa4ff1f4 [tx-robot] updated from transifex 2018-04-18 00:13:30 +00:00
Morris Jobke 13d21f5989 Merge pull request #9174 from nextcloud/dav-free-space-message
log more information about insufficient storage in dav plugin
2018-04-17 23:01:01 +02:00
Julius Härtl 09ada4ec2b Move personal settings to css grid layout
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-17 22:40:03 +02:00
Roeland Jago Douma b7d00ff5ef Merge pull request #9217 from nextcloud/show-link-trusted-domains
Show a link to the docs instead of a button on the untrusted domain page
2018-04-17 21:21:37 +02:00
Morris Jobke 0d5142be70 Show a link to the docs instead of a button on the untrusted domain page
Before there was a button to "quickly" add the untrusted domain to the config. This button often didn't worked, because the generated URL was often untrusted as well. Thus removing it and providing proper docs seems to be the better approach to handle this rare case.

Also the log should not be spammed by messages for the untrusted domain accesses, because they are user related and not necessarily an administrative issue.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-17 17:47:11 +02:00
Morris Jobke 748b51a225 Merge pull request #9211 from nextcloud/update-crl
Update CRL to include old quicknotes cert
2018-04-17 17:15:58 +02:00
Robin Appelman bc3fde9f75 log more information about insufficient storage in dav plugin
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-17 15:29:37 +02:00
Robin Appelman 991790686a Merge pull request #9177 from nextcloud/log-exception-argument-classes
Log classnames of arguments in exception trace
2018-04-17 15:26:39 +02:00
Robin Appelman f399e1591f Log classnames of arguments in exception trace
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-17 13:46:36 +02:00
Morris Jobke 42b7dfe9ac Merge pull request #9159 from nextcloud/appinfo-single-localized
fix appinfo parsing when a single localized option is provided
2018-04-17 13:45:43 +02:00
Morris Jobke 1bc192fbd4 Merge pull request #9203 from nextcloud/declare-func-as-safe
Declare func() as safe method in phan
2018-04-17 13:45:27 +02:00
Morris Jobke 7dcab39f34 Update CRL to include old quicknotes cert
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-17 11:40:56 +02:00
Robin Appelman 46d0d0cda1 fix appinfo parsing when a single localized option is provided
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-17 11:14:03 +02:00
Roeland Jago Douma 63dfbb2127 Merge pull request #9162 from nextcloud/allow-lang-ocs-api
Add language support for user creation
2018-04-17 11:01:46 +02:00
Morris Jobke dfffc0fdda Merge pull request #9184 from nextcloud/bug-9150
Fixes issue with the large cursor on Safari in the comment section.
2018-04-17 11:00:26 +02:00
Morris Jobke 1f06bc246c Declare func() as safe method in phan
We added a special `func()` method to the query builder, which is a plain text function by definition. It uses the string and does no escaping on purpose. It has the potential for an injection but requiring to add the "supress warning" to all surrounding code makes it harder to spot actual problems, that this plugin want to find. So it's better to only need to check the func() and not all the surrounding code as well.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-17 10:58:00 +02:00
Roeland Jago Douma cf27310505 Merge pull request #9206 from nextcloud/fix-select-text
Fix user selectable text for public links for text files
2018-04-17 10:56:32 +02:00
Nextcloud bot 3c250b1a35 [tx-robot] updated from transifex 2018-04-17 00:13:08 +00:00
Morris Jobke 8c085e7645 Merge pull request #9205 from nextcloud/plaintext-emails
Provide an option to disable HTML emails
2018-04-16 22:06:09 +02:00
Morris Jobke 9ee1febf62 Provide an option to disable HTML emails
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-16 19:00:05 +02:00
Morris Jobke d93948426c Merge pull request #9168 from nextcloud/enabled-state-proper-return-and-tests-fixes
Return proper boolean user enabled state api
2018-04-16 18:09:11 +02:00
Morris Jobke 66c92872ab Fix user selectable text for public links for text files
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-16 16:36:29 +02:00
John Molakvoæ (skjnldsv) 5bd02a63a8 Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-16 15:18:33 +02:00
John Molakvoæ (skjnldsv) 6028d60038 Add language support for user creation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-16 15:18:33 +02:00
John Molakvoæ (skjnldsv) 3e5ea9b0a9 Return proper boolean user enabled state api
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-16 15:17:02 +02:00
blizzz 056660bf7c Merge pull request #9200 from nextcloud/fix-invalid-phan-detection
Fixes false positive possible sql injection by phan
2018-04-16 13:19:26 +02:00
Morris Jobke 4d832cd4e3 Fixes false positive possible sql injection by phan
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-16 11:47:11 +02:00
Morris Jobke db8bcfc5f6 Merge pull request #9172 from nextcloud/karma-avatar-tests-fix
Fix js tests with placeholder
2018-04-16 11:32:30 +02:00
Nextcloud bot 85d4d9c592 [tx-robot] updated from transifex 2018-04-16 00:11:49 +00:00
Abijeet 0489643f50 Fixes issue with the large cursor on Safari in the comment section.
This was being caused due to the `display: inline-block` on the contenteditable div.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-04-14 20:28:32 +05:30
Nextcloud bot 13b5e257ab [tx-robot] updated from transifex 2018-04-14 00:11:46 +00:00
John Molakvoæ (skjnldsv) 6cb40cf0c4 Fix js tests with placeholder
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-13 10:20:51 +02:00
Nextcloud bot b7a64f9c13 [tx-robot] updated from transifex 2018-04-13 00:11:47 +00:00
blizzz e2877c4999 Merge pull request #9164 from nextcloud/fix-autoloader
Fix autoloader
2018-04-12 19:31:12 +02:00
Morris Jobke 1517b1452e Fix autoloader
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-12 16:24:44 +02:00
Jan-Christoph Borchardt 04f47a7653 Merge pull request #8535 from nextcloud/new-color-generator
New color generator algorithm
2018-04-12 14:37:53 +02:00
Robin Appelman fb34ef1093 Merge pull request #9134 from nextcloud/db-locks-cli
dont keep shared database locks when running cli scripts
2018-04-12 12:09:43 +02:00
Morris Jobke e275b9a2cf Merge pull request #9158 from nextcloud/revert-9144-allow-lang-ocs-api
Revert "Add language support for user creation in api"
2018-04-12 11:01:06 +02:00
Morris Jobke 10b37a074c Revert "Add language support for user creation in api" 2018-04-12 11:00:54 +02:00
Morris Jobke d3f2b6aef4 Merge pull request #8820 from nextcloud/mtime-sort
Sorts filepicker files by modified date
2018-04-12 10:54:44 +02:00
Nextcloud bot af53f48ce2 [tx-robot] updated from transifex 2018-04-12 00:19:20 +00:00
Robin Appelman 89a9d35d90 dont keep shared database locks when running cli scripts
For cli scripts we don't have the assumption that the universe will be cleaned up soon

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-11 19:21:45 +02:00
Morris Jobke 9260474ab6 Merge pull request #8452 from sagorika1996/folder
Descend into newly created folder by clicking enter again
2018-04-11 17:58:42 +02:00
Morris Jobke 2094fcf5f0 Merge pull request #9145 from nextcloud/use-authorized-github-checks
Add auth token to github requests
2018-04-11 16:27:13 +02:00
Morris Jobke e6c146121e Merge pull request #9144 from nextcloud/allow-lang-ocs-api
Add language support for user creation in api
2018-04-11 16:21:32 +02:00
Roeland Jago Douma fed9140abd Merge pull request #9148 from nextcloud/dav-read-exception
transform exception during file read to sabre exceptions
2018-04-11 16:03:12 +02:00
Julius Härtl 2626d11f78 Merge pull request #9097 from nextcloud/bugfix/7661/use_mb_substr
Use multibyte substring
2018-04-11 15:55:55 +02:00
Morris Jobke 88c1b8edbd Merge pull request #9024 from nextcloud/fix/app-fetcher-major-minor-versions
Fix version comparison with minor and patch level requirements
2018-04-11 15:48:23 +02:00
Morris Jobke a18a853e68 Merge pull request #7800 from Abijeet/bug-7281
Fixes the usability issues with the comment section delete and edit
2018-04-11 15:27:12 +02:00
Morris Jobke 2c15f4003e Add auth token to github requests
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-11 15:15:49 +02:00
Morris Jobke b7009753b3 Merge pull request #9147 from nextcloud/log-previous-exception
log previous exception
2018-04-11 15:11:46 +02:00
Robin Appelman e6a7ddc1c6 transform exception during file read to sabre exceptions
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-11 14:45:35 +02:00
Robin Appelman 96f14a2e90 log previous exception
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-11 14:35:08 +02:00
Morris Jobke 7a3ce073da Merge pull request #8946 from nextcloud/log-exceptions-as-nested-array-2
Log exceptions as nested array instead of encoded json
2018-04-11 14:24:47 +02:00
Morris Jobke 0dabb26cc2 Merge pull request #9143 from nextcloud/disable-broken-swift
Disable unreliable swift tests
2018-04-11 11:51:40 +02:00
Robin Appelman 15815c034f adjust tests to new exception log format
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-11 11:46:36 +02:00
Morris Jobke 185a260f6b Merge pull request #9074 from nextcloud/ARGON2I
Add ARGON2I support to the hasher
2018-04-11 11:04:42 +02:00
John Molakvoæ (skjnldsv) 89da1af889 Add language support for user creation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-11 10:59:56 +02:00
Morris Jobke 4ef2fb36d0 Disable unreliable swift tests
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-11 10:57:21 +02:00
Roeland Jago Douma 52f1f047d6 Bump autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-11 10:08:43 +02:00
Morris Jobke 3d80ade8d7 Log possible exception caused by wrong version number
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-11 10:08:23 +02:00
Christoph Wurst ac939e8fd4 Fix version comparison with minor and patch level requirements
If an app requires a specific minor or path level server version,
the version_compare prevented the installation as only the major
version had been compared and that checks obviously returns `false`.

Now the full version is used for comparison, making it possible to
release apps for a specific minor or patch level version of Nextcloud.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-04-11 10:08:23 +02:00
Nextcloud bot ecc3bc64aa [tx-robot] updated from transifex 2018-04-11 00:21:34 +00:00
Morris Jobke a655401382 Merge pull request #9136 from nextcloud/bugfix/noid/fix_provisioning_integrationtests
The integrationtests expect a string
2018-04-11 02:11:33 +02:00
Morris Jobke e302266a6a Merge pull request #9137 from nextcloud/default-log-rotate-size
Set the default log rotate size to 100 MB
2018-04-11 02:10:54 +02:00
Morris Jobke 52c0e02bdc Merge pull request #8910 from nextcloud/fix-login-error
Avoid to leak a user ID that is not a string to reach a user backend
2018-04-11 01:06:38 +02:00
Morris Jobke 38961a725f Merge pull request #8833 from nextcloud/feature/noid/add_ldap_user_hooks
add anounce- and (pre/|post)RevokeUser signals for non-native backends
2018-04-11 00:44:39 +02:00
Roeland Jago Douma a3c2035674 Merge pull request #9128 from nextcloud/bugfix/9076/make_oracle_happy
Also make the uid_lower migration work on oracle
2018-04-11 00:41:53 +02:00
Morris Jobke 0d7d064788 Merge pull request #9132 from nextcloud/remove-navigation-ajax
Replace the ajax navigationdetect endpoint with the new one from NavigationController
2018-04-11 00:31:52 +02:00
Roeland Jago Douma a8d4b0688e Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-11 00:30:14 +02:00
Morris Jobke 058f8123e6 Set the default log rotate size to 100 MB
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-11 00:27:51 +02:00
Roeland Jago Douma a07f6d46e3 Use proper types
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-11 00:21:25 +02:00
Morris Jobke fd3c97b93b Avoid to leak a user ID that is not a string to reach a user backend
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-11 00:03:30 +02:00
Roeland Jago Douma d363e2f0e3 The integrationtests expect a string
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-10 23:29:09 +02:00
Roeland Jago Douma 3955cf1412 Merge pull request #9130 from nextcloud/fix/app-fetcher-phpdoc
Fix AppFetcher::setVersion phpdoc
2018-04-10 23:06:28 +02:00
Jan-Christoph Borchardt 8d27dce716 Merge pull request #9002 from nextcloud/whitespace
More whitespace: Increase header height from 45px to 50
2018-04-10 23:05:01 +02:00
Julius Härtl 85cb130510 Fix max-width to fit the new margin
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-10 21:34:51 +02:00
Robin Appelman b9583c6dce Log exceptions as nested array instead of encoded json
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-10 15:53:43 +02:00
Julius Härtl 570ee078a0 Use new navigation endpoint and get rid of the legacy navigationdetect ajax
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-10 14:23:30 +02:00
Christoph Wurst 6248b61193 Fix AppFetcher::setVersion phpdoc
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-04-10 12:32:56 +02:00
Roeland Jago Douma 24cfee8cdd Also make it the uid_lower migration work on oracle
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-10 10:47:31 +02:00
Nextcloud bot 323ee3cbdc [tx-robot] updated from transifex 2018-04-10 00:12:10 +00:00
Morris Jobke c4c6943c1e Merge pull request #9127 from nextcloud/make-possible-to-run-acceptance-tests-on-apache
Make possible to run acceptance tests on Apache
2018-04-09 23:50:44 +02:00
Morris Jobke acbcc607ea Merge pull request #9111 from nextcloud/use-proper-bool-user-disabled-state
Return proper boolean and do not save enabled state in db
2018-04-09 23:39:02 +02:00
Morris Jobke 0fa796fb85 Merge pull request #7972 from nextcloud/fix_7782
Use zip32 if possible
2018-04-09 23:11:30 +02:00
Morris Jobke 0327ef1044 Merge pull request #9108 from nextcloud/ocs-api-subadmins-quota-adduser
Allow user creation with subadmins and quota
2018-04-09 22:54:57 +02:00
Daniel Calviño Sánchez 4341d8731e Rename helper for PHP built-in web server
For consistency with the helper for the Apache web server the helper for
the PHP built-in web server was renamed too.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-09 21:50:30 +02:00
Daniel Calviño Sánchez aa96dfd173 Add helper to run acceptance tests on an Apache server
The default and only helper to run acceptance tests run them on the PHP
built-in web server. This commit introduces a new helper that can be
used to run them on an Apache web server instead.

This helper is meant to be used by the acceptance tests of apps that
require a multi-threaded web server to run (like Talk, due to its use of
long polling). To use the helper it is only needed to set it in the
Behat configuration for the acceptance tests of the app, as explained in
the "NextcloudTestServerContext" documentation.

It is assumed that the acceptance tests are run using the default setup,
and therefore inside a Docker container based on the image for
acceptance tests from Nextcloud. Due to that the helper is expected to
have root permissions, and thus it starts and stops the Apache web
server directly using "service start/stop apache2". In the same way it
also restores the owner and group for "apps", "config" and "data" to
"www-data", as it is the user that Apache sub-processes are run as.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-09 21:50:30 +02:00
Daniel Calviño Sánchez ea21fe2dbc Add support for setting the domain also when a specific helper is used
Before, the domain was automatically added assuming that the
NextcloudTestServerContext had no parameters defined in the Behat
configuration. However, in order to use a helper for Apache it would
need to be specified in the configuration with something like:

- NextcloudTestServerContext:
    nextcloudTestServerHelper: NextcloudTestServerLocalApacheHelper

The substitution now works both when a helper is specified and when it
is not; note, however, that providing custom parameters to the helper is
not supported, although they are not needed anyway so it is not really a
problem.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-09 21:50:30 +02:00
Daniel Calviño Sánchez a09b787a01 Install and configure Nextcloud server as www-data
Apache sub-processes are run as the www-data user, and they need to be
able to write to the "apps", "config" and "data" directories, so they
have to belong to that user, and therefore the Nextcloud server has to
be installed and configured too as the www-data user. The PHP built-in
web server will still be run as the root user, but in that case the
owner of those directories makes no difference, so this is compatible
with both cases.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-09 21:50:30 +02:00
Daniel Calviño Sánchez f6d34587a2 Use Docker image for acceptance tests
The Docker image for acceptance tests provides support for both the PHP
built-in web server and the Apache web server; the acceptance tests for
the server are run on the PHP built-in web server, but the acceptance
tests for some apps will have to be run on the Apache web server (for
example, Talk, as it uses long polling), so a Docker image to support
both cases has to be used in "run.sh". ".drone.yml" was just updated for
consistency, although it was not really needed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-09 21:50:30 +02:00
Morris Jobke db6fa03ad6 Merge pull request #9114 from nextcloud/make-possible-to-provide-acceptance-tests-for-apps
Make possible to provide acceptance tests for apps
2018-04-09 17:31:28 +02:00
Roeland Jago Douma 2620e16731 Merge pull request #9116 from nextcloud/rakekniven-patch-1
Update settings.php
2018-04-09 16:21:06 +02:00
John Molakvoæ (skjnldsv) 8b9bd37e4e Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-09 15:13:11 +02:00
rakekniven cde721fd0b Update settings.php
Changed according to discussion.
2018-04-09 13:26:28 +02:00
Morris Jobke 21dd28e6fb Merge pull request #9090 from nextcloud/fix/noid/ldap-format-strict-param
parameter provided to L10N::n() could have been a string
2018-04-09 13:00:25 +02:00
John Molakvoæ (skjnldsv) eae55761de Properly return boolean on enable state
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-09 11:26:26 +02:00
Roeland Jago Douma 123d9f0ce9 Merge pull request #8777 from nextcloud/various-css-fixes
Various css fixes
2018-04-09 10:19:50 +02:00
Roeland Jago Douma b2350810e0 Merge pull request #9115 from nextcloud/feature/noid/login_flow_wording
Improve login flow
2018-04-09 08:45:27 +02:00
Roeland Jago Douma 04f8b99dce Merge pull request #9118 from nextcloud/video-switch
Add video switch icon
2018-04-09 07:12:24 +02:00
Nextcloud bot 5bbe6bb44e [tx-robot] updated from transifex 2018-04-09 00:11:59 +00:00
Roeland Jago Douma 177c8972cc Improve login flow
* Add page explaining you are about to grant access
* Show grant access page after login

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-08 13:42:36 +02:00
Nextcloud bot 72e8ab14ac [tx-robot] updated from transifex 2018-04-08 00:12:00 +00:00
Jan-Christoph Borchardt 203a8f293b Add video switch icon
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-07 20:53:36 +02:00
rakekniven 014446447b Update settings.php
Tiny l10n improvement.

Reported at Transifex: https://www.transifex.com/nextcloud/nextcloud/translate/#de_DE/user_ldap/91002448
2018-04-07 09:29:10 +02:00
Nextcloud bot 9f194bc682 [tx-robot] updated from transifex 2018-04-07 00:11:49 +00:00
Roeland Jago Douma a13440d46a Merge pull request #9109 from nextcloud/feature/8004/always_remember
Always remember me
2018-04-06 22:26:05 +02:00
Daniel Calviño Sánchez c8df4f5df4 Make possible to set the acceptance tests directory to use
When the acceptance tests were run they were always loaded from the
"tests/acceptance" directory of the Nextcloud server. Now it is possible
to set the directory used to look for the Behat configuration and the
Nextcloud installation script, which makes possible to run acceptance
tests for the apps too instead of only for the server (although if no
directory is explicitly given the tests for the server are the ones
run).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-06 21:56:12 +02:00
Roeland Jago Douma 33b93db953 Remove unused parameter
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 21:44:23 +02:00
John Molakvoæ (skjnldsv) 275b9868b2 Fixed documentation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-06 21:32:45 +02:00
John Molakvoæ (skjnldsv) d5cfd09d47 fixup! Updated php generator
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-06 21:32:45 +02:00
John Molakvoæ (skjnldsv) 57a1dc1231 Updated php generator
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-06 21:32:44 +02:00
John Molakvoæ (skjnldsv) bca8d83f02 New algorithm
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-06 21:32:44 +02:00
Roeland Jago Douma 2b7d4d5069 Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 19:58:37 +02:00
Daniel Calviño Sánchez 50ee978aa8 Do not run download scenarios tagged as "large" in Drone
Large scenarios take too long to run, so they would be cancelled before
they were finished. Therefore, now they are not even run.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-06 15:59:31 +02:00
Daniel Calviño Sánchez 1d7bf328f8 Make possible to provide "--tags=XXX" parameter to Behat
"--tags=XXX" limits the features or scenarios to be run to those
matching the tag filter expression.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-06 15:59:31 +02:00
Daniel Calviño Sánchez 65bc12960f Add integration tests for zip32/zip64 boundaries of number of files
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-06 15:59:31 +02:00
Daniel Calviño Sánchez 6ee5469a03 Add integration tests for downloading basic zip files
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-06 15:59:31 +02:00
Daniel Calviño Sánchez 5a7986c25d Fix use of data directory in integration tests
The data directory is not necessarily located at "../..". The proper
directory is now got by running "php console.php config:system:get
datadirectory".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-06 15:59:30 +02:00
Daniel Calviño Sánchez 90fdf83ca7 Use zip32 only if there are less than 65536 files
A zip32 file can contain, at most, 65535 files (and folders), so take
that constraint into account.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-06 15:59:30 +02:00
Roeland Jago Douma 4a73f645e5 Use zip32 if possible
* OSX doesn't handle 64zip that well
* Some other implentations don't handle it perfectly either
* If the file is belog 4GiB (some overhead) => zip32
* This covers the 99% case I bet

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 15:59:30 +02:00
Roeland Jago Douma caee215120 Always remember me
Fixes #8004

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 15:44:28 +02:00
John Molakvoæ (skjnldsv) 18ec4ddd2b Allow user creation with subadmins and quota
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-06 15:30:41 +02:00
Roeland Jago Douma e970e9f710 Merge pull request #9076 from nextcloud/feature/7573/user_db_backend_index
Make select queries on user DB backend indexable
2018-04-06 14:56:19 +02:00
Roeland Jago Douma 31454c2072 Bump autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 14:14:58 +02:00
Roeland Jago Douma f90299face Silence phan
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 13:46:32 +02:00
Roeland Jago Douma 8edbeb159e Use the uid_lower column
This can use a proper index

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 13:42:52 +02:00
Roeland Jago Douma 7a7d424e91 Add an uid_lower column to the oc_users table
Add a new column.
In the postSchemaChange copy over the values (with lower).

This should work just fine as this is a very simple operation.
Even if you have 1M users in the db backend this should be fast
enough.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 13:42:50 +02:00
Roeland Jago Douma ca644c768f Merge pull request #9101 from nextcloud/3rdparty/switch_zipstreamer
Switch ZipSteamer lib
2018-04-06 13:34:08 +02:00
Morris Jobke 2a2ab1b871 Merge pull request #9084 from nextcloud/public-page-template-extend
Public page template enhancements
2018-04-06 13:16:26 +02:00
Roeland Jago Douma 2a3b308f58 Switch ZipSteamer lib
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 12:42:13 +02:00
Roeland Jago Douma 4a6e31c91d Merge pull request #8904 from nextcloud/ocs-api-get-users-details-per-groups
Api: return users details by groups
2018-04-06 10:52:20 +02:00
blizzz 50442b265d Merge pull request #9100 from JaredBoone/bugfix/8387-master
Do not convert email addresses with idn_to_ascii if INTL_IDNA_VARIANT…
2018-04-06 10:36:07 +02:00
blizzz b19735fb84 Merge pull request #9096 from nextcloud/feature/noid/ping_better_hosts
Ping more privacy respecting organizations
2018-04-06 10:32:14 +02:00
Daniel Calviño Sánchez 50d35bee9f Add context classes to Composer autoload
In order to autoload the server context classes the "bootstrap"
directory was explicitly listed in Behat autoload configuration. This is
fine in the configuration of acceptance tests for the server, but it
would force the configuration of acceptance tests for the apps to
explicitly include the path for the server context classes to be able to
use them (for example, for the login step).

Besides with its own configuration Behat also supports autoloading
classes using Composer, so now context classes are autoloaded using
Composer instead; thanks to this the server context classes are
autoloaded also in the acceptance tests for apps without any explicit
configuration in them.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-06 04:13:42 +02:00
Nextcloud bot a97b9bf605 [tx-robot] updated from transifex 2018-04-06 00:14:22 +00:00
Jared Boone a5b50e487e Do not convert email addresses with idn_to_ascii if INTL_IDNA_VARIANT_UTS46 is undefined.
Fixes https://github.com/nextcloud/server/issues/8387.

Signed-off-by: Jared Boone <jared.boone@gmail.com>
2018-04-05 16:09:08 -07:00
Roeland Jago Douma 0864d1c51d Use multibyte substring
Fixes #7661

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-05 22:26:38 +02:00
Roeland Jago Douma bbc4c6036a Merge pull request #9092 from nextcloud/log-objectstorage-stuff
Add more logging for the object storage during creation of the buckets
2018-04-05 21:44:48 +02:00
Roeland Jago Douma 176b4d6832 Ping more privacy respecting organizations
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-05 21:43:51 +02:00
Julius Härtl 5598d30ef1 Fix files acceptance test
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 21:10:33 +02:00
Morris Jobke 2f068bc9d1 Add more logging for the object storage during creation of the buckets
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-05 17:26:09 +02:00
John Molakvoæ (skjnldsv) eb4d7fba20 Rebase to master
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-05 17:12:52 +02:00
Joas Schilling 348171f311 Use abstract subclass so members can be defined
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-04-05 17:11:41 +02:00
John Molakvoæ (skjnldsv) 762002ec2e Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-05 17:11:41 +02:00
John Molakvoæ (skjnldsv) c103aaaf25 Trait bump
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-05 17:11:41 +02:00
John Molakvoæ (skjnldsv) b023bfe38f Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-05 17:09:00 +02:00
John Molakvoæ (skjnldsv) 4011ea97b1 Cast types directly
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-05 17:09:00 +02:00
John Molakvoæ (skjnldsv) f4e84e1727 Limit and offset
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-05 17:09:00 +02:00
John Molakvoæ (skjnldsv) 68ae4394f7 Api, return users details by groups
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-05 17:08:59 +02:00
Julius Härtl 1624762d2f Fix tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 15:40:58 +02:00
Roeland Jago Douma 6ea444b243 Merge pull request #9082 from nextcloud/feature/8795/new_webdav_url_in_web
Show the new dav url in the web UI
2018-04-05 14:51:52 +02:00
Arthur Schiwon 16d4ff4d39 parameter provided to L10N::n() could have been a string
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 14:50:28 +02:00
Julius Härtl 50a763e4c8 Update composer autoloader
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 14:27:34 +02:00
Morris Jobke 1f605cb841 Merge pull request #9087 from nextcloud/bugfix/3523/windows10_webdav_netdrive
Allow usage of Windows 10 WebDav Netdrive
2018-04-05 14:22:27 +02:00
Morris Jobke 6b39186e4f Merge pull request #9085 from nextcloud/fix-progress-bar-hidden-before-the-upload-ends
Fix progress bar hidden before the upload ends
2018-04-05 14:11:36 +02:00
Roeland Jago Douma 9b05413bcb Show the new dav url in the web UI
Fixes #8795

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-05 13:59:45 +02:00
Julius Härtl 6ded1c46b7 Add since tags
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 13:18:17 +02:00
Roeland Jago Douma f5d3d3f72a Allow usage of Windows 10 WebDav Netdrive
Fixes #3523

As long as we don't have #8123 lets not leave our Window10 netdrive
users hanging.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-05 13:16:29 +02:00
Julius Härtl 2e60f91ab1 Move external share saving to template
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 13:11:55 +02:00
Arthur Schiwon f1565336bd DI for NC's user manager
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 12:46:24 +02:00
Arthur Schiwon 373a1d5391 more consistent naming
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 12:46:15 +02:00
Arthur Schiwon 2ebf26e444 admin_audit and dav listen to announce and revoke signals
also place them in doc

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 12:38:43 +02:00
Arthur Schiwon 8fe914f07e LDAP backend to emit announce and revoke signals on mapping changes
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 12:38:39 +02:00
Julius Härtl 30e76f9f14 Add footer to public page template
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 12:22:01 +02:00
Julius Härtl bbeb3402b6 Move styling and menu handling to publicpage.js
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 12:21:39 +02:00
Julius Härtl cc3b1179fc Do not hide primary action text
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 11:32:11 +02:00
Daniel Calviño Sánchez bcfe8431b4 Fix progress bar hidden before the upload ends
The jQuery File Upload plugin triggers the "stop" event once there are
no more files being uploaded (even if some of them were added when
another upload was already in progress). Therefore, the progress bar
should be hidden in the "fileuploadstop" callback.

In some cases the "stop" event is not triggered and thus the progress
bar is not hidden once no more files are being uploaded. This is caused
by a race condition and it will be fixed in another commit; except in
buggy cases like that one (that need to be fixed anyway) it is safe to
hide the progress bar in the "fileuploadstop" callback.

In any case, note that the callbacks in "fileuploaddone" may be called
after the "stop" event was triggered and handled when using chunked
uploads. In that case once all the chunks are uploaded the assembled
file is moved to its final destination, so its promise could be resolved
after the "stop" event was triggered. Therefore a different approach
would be needed to keep the progress bar visible until the chunked
upload is truly finished, but for the time being the current one is good
enough.

Before this commit the progress bar was being hidden when the first
upload finished, either successfully or with an error, no matter if
there were other files being uploaded too.

The progress bar was being explicitly hidden also when the upload was
cancelled. When an upload is cancelled all the single uploads are
aborted, which triggers a "fail" event for each of them. However, the
"stop" event is always triggered when no more files are being uploaded,
so it is triggered too once all the single uploads were aborted. As all
the single uploads are immediately aborted in a loop when the general
upload is cancelled it makes no difference to hide the progress bar when
the first single upload is aborted or when all the single uploads were
aborted, so the progress bar is no longer explicitly hidden in the
former case.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-05 11:12:33 +02:00
Julius Härtl eb19899f8e Move common menu templates to public API
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 11:09:19 +02:00
Roeland Jago Douma feef3cbba0 Merge pull request #9081 from nextcloud/bugfix/9080/groupby_typo
Fix Array to String conversion in QueryBuilder
2018-04-05 10:06:25 +02:00
Roeland Jago Douma ab04f3cb19 Fix Array to String conversion in QueryBuilder
Fixes #9080

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-05 09:08:32 +02:00
Roeland Jago Douma 3e390a3451 Merge pull request #9075 from coliff/patch-1
Update link to Nextcloud 13 Developer Manual
2018-04-05 08:55:40 +02:00
Nextcloud bot 0c12c06325 [tx-robot] updated from transifex 2018-04-05 00:11:47 +00:00
blizzz 3678d3b14a Merge pull request #8926 from nextcloud/ocs-api-quota-fallback
Return quota even if user is not initialised
2018-04-04 17:19:54 +02:00
Christian Oliff eba6b079af Update link to Nextcloud 13 Developer Manual 2018-04-04 23:40:26 +09:00
Roeland Jago Douma 84316aec66 Add ARGON2I support to the hasher
When on php7.2 we can use the new and improved ARGON2I hashing.
This adds support for that to the hasher. When verifying an old hash
we'll update rehash to move all hashes eventually to the new hash
function.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-04 15:43:50 +02:00
Julius Härtl 2887b9bdab Fix arrow position on mobile
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-04 15:05:59 +02:00
Julius Härtl f37f145c55 Fix settings menu offset
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-04 15:05:59 +02:00
Julius Härtl 4a3538bbd8 Fix app menu, popovers and searchbox
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-04 15:05:58 +02:00
Julius Härtl bb37bdbfc4 Add more space to the logo
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-04 15:05:58 +02:00
Jan-Christoph Borchardt 8089838f57 Increase header height from 45px to 50
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-04 15:05:58 +02:00
Morris Jobke 9c4d562808 Merge pull request #9063 from nextcloud/fix-callForSeenUsers
Move on with the next user if we found the user on one user back-end
2018-04-04 15:01:04 +02:00
Roeland Jago Douma a3a66859d3 Merge pull request #8995 from nextcloud/improve_mountmanager
Improve mountmanager
2018-04-04 13:35:58 +02:00
Roeland Jago Douma 73e6eea57e Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-04 12:50:54 +02:00
Roeland Jago Douma 37233471b6 Add pathcache
* If we find the mountpoint for a path cache it
* If we modify the mount points empty the pathCache

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-04 12:44:56 +02:00
Roeland Jago Douma 6868da9958 Make normalized cache path larger
On larger instances with a large number of shares this can make a real
impact as the default 512 entries are easily filled.

Making this contain max 2048 entries has basically no effect on smaller
installations (as they probably never hit the 512 now). But makes sure
we don't evict entries in the larger case.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-04 12:44:52 +02:00
Roeland Jago Douma dc222aa3a5 Comparing stringlength is cheaper than strpos
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-04 12:44:28 +02:00
Roeland Jago Douma e48d4c4aad Cache the $foundMountPointLength
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-04 12:44:28 +02:00
Roeland Jago Douma 003c624596 Inspections
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-04 12:44:28 +02:00
Roeland Jago Douma 7f1141f7e9 Make the MountManager strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-04 12:44:28 +02:00
Morris Jobke 18676a8ee2 Merge pull request #9070 from nextcloud/bugfix/9028/guessing_without_target_is_useles
When formatting a share node an Empty target is invalid
2018-04-04 11:56:33 +02:00
Roeland Jago Douma d6cda3f2a6 When formatting a share node an Empty target is invalid
Fixes #9028

For federated shares the share table holds no target information (since
it is on the other server). So when a node is actually invalid and not
found we should not display it anymore in the shared with sections etc
and thus throw the proper exceptions.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-04 11:33:05 +02:00
Nextcloud bot b90b73df6f [tx-robot] updated from transifex 2018-04-04 00:13:26 +00:00
Björn Schießle c3900c9d0d Merge pull request #9018 from nextcloud/fix-copy-encrypted-files
reset encryptionVersion to '1' if a file was stream copied
2018-04-03 18:24:27 +02:00
Bjoern Schiessle a0923d9ffb reset encryptionVersion to '1' if a file was stream copied, because this means that we basically write the file from scratch
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-04-03 18:01:23 +02:00
Bjoern Schiessle 6795b35cdf Move on with the next user if we found the user on one user back-end
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-04-03 17:00:18 +02:00
Morris Jobke 75cf631fd6 Merge pull request #9008 from nextcloud/disable-if-no-appinfo
Do not fail hard if no appinfo is returned during update
2018-04-03 13:32:50 +02:00
Morris Jobke bd8352d4c4 Merge pull request #8996 from brandonkirsch/fix-onenote-dav
Fix webdav support for OneNote clients
2018-04-03 13:27:29 +02:00
Morris Jobke f0fcf88a4f Merge pull request #9006 from nextcloud/bugfix/8977/ignore_encrypted_custom_properties
Do not treat is-encrypted as custom property
2018-04-03 11:44:58 +02:00
Morris Jobke 56fa44b71d Merge pull request #8945 from nextcloud/fix-files-copy-in-recent-favorites
Fixed files copy/move when in favorites or recent section
2018-04-03 10:30:08 +02:00
Morris Jobke 6dca0bbd79 Merge pull request #9014 from nextcloud/smb-2.0.5
update icewind/smb to 2.0.5
2018-04-03 10:21:26 +02:00
Nextcloud bot 5105f1d466 [tx-robot] updated from transifex 2018-04-03 00:11:47 +00:00
Nextcloud bot 25c479c0c5 [tx-robot] updated from transifex 2018-04-02 00:11:49 +00:00
Nextcloud bot 21b7611457 [tx-robot] updated from transifex 2018-04-01 00:11:48 +00:00
Nextcloud bot 0f398e7611 [tx-robot] updated from transifex 2018-03-31 00:13:51 +00:00
Nextcloud bot 660ae73e5f [tx-robot] updated from transifex 2018-03-30 00:11:34 +00:00
Nextcloud bot 65908bacd2 [tx-robot] updated from transifex 2018-03-29 00:13:35 +00:00
Julius Härtl 1c97ef6da2 Merge pull request #9009 from nextcloud/appstore-link-external
Open app store links in new tab
2018-03-28 17:25:20 +02:00
Robin Appelman d91d84b485 update icewind/smb to 2.0.5
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-03-28 16:09:27 +02:00
Roeland Jago Douma cdb2cc1814 Merge pull request #8999 from nextcloud/css-js-name-based-on-apps-versions
Use app version to generate scss filename
2018-03-28 15:59:07 +02:00
Jan-Christoph Borchardt 1313e38dac Open app store links in new tab
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-03-28 12:17:43 +02:00
Julius Härtl eb6e5a27a3 Do not fail hard if no appinfo is returned during update
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-28 11:12:56 +02:00
Roeland Jago Douma e8b7e9e75d Do not treat is-encrypted as customer property
fixes #8977

Else for all files in a folder we would launch off more queries.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-28 08:34:50 +02:00
John Molakvoæ (skjnldsv) 1d7b14dfb1 Use app version to generate scss filename
Fixed scsscacher tests

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-28 08:33:46 +02:00
Roeland Jago Douma 2124ebae72 Merge pull request #8737 from nextcloud/file_return_put_contents
Pass on the return value of file_put_content
2018-03-28 08:25:04 +02:00
Roeland Jago Douma b2e34167eb Merge pull request #8976 from nextcloud/dep_user_code
Remove deprecated functions from OCP\User
2018-03-28 08:23:57 +02:00
Roeland Jago Douma 1e13b3a8fa Merge pull request #8994 from nextcloud/deprecate-theme-sync-clients
Deprecate theme sync clients
2018-03-28 08:23:16 +02:00
Nextcloud bot 9dad5ac59b [tx-robot] updated from transifex 2018-03-28 00:21:16 +00:00
Roeland Jago Douma 06f52ead31 Merge pull request #8993 from nextcloud/theming-allow-ui-with-theme
Show UI when using a custom theme
2018-03-27 19:27:49 +02:00
Daniel Calviño Sánchez c5cc1d80e6 Fix typo
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-27 16:48:19 +02:00
Roeland Jago Douma f5b378fa84 Update autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-27 16:23:26 +02:00
Roeland Jago Douma 53447ae2b2 Throw an exception if file_put_contents fails
* This will help with AppData hardening etc
* Introduced a GenericFileException for if nothing else is appropiate
  - Maybe the other File exceptions should base on this?

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-27 16:23:06 +02:00
Joas Schilling 709589f2db Merge pull request #8780 from nextcloud/bugfix/noid/query-builder-database-backends
Move the group database backend fully to query builder
2018-03-27 16:10:26 +02:00
Joas Schilling b98c218201 Remove orderBy so the query works correctly on postgres
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-27 14:50:09 +02:00
Roeland Jago Douma 41215c9d78 Merge pull request #8951 from nextcloud/searchdav-1.0.1
update icewind/searchdav to 1.0.1
2018-03-27 09:56:41 +02:00
Nextcloud bot 7b4e51dbc7 [tx-robot] updated from transifex 2018-03-27 00:11:40 +00:00
Roeland Jago Douma 5bfad25e83 Merge pull request #8968 from nextcloud/filter_method_not_allowed
MethodNotAllowed is not a Fatal error
2018-03-26 22:41:49 +02:00
Abijeet 16bf9326cb Fixing failing test cases due to change in functionality.
Also fixes scrutinizer warnings.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 01:34:00 +05:30
Roeland Jago Douma fa09e0e670 Merge pull request #8983 from nextcloud/fix-8888
Clear any theming prefixed cache on cache buster increase
2018-03-26 21:46:46 +02:00
Roeland Jago Douma 36dbd7ec8f Merge pull request #8985 from nextcloud/cleanup_ocp_db
Cleanup ocp db
2018-03-26 21:45:25 +02:00
Roeland Jago Douma 4edcaa945f Merge pull request #8981 from nextcloud/strict_2fa
Strict 2FA
2018-03-26 21:40:36 +02:00
Brandon Kirsch c5005bbab5 Fix webdav support for OneNote clients 2018-03-26 15:32:12 -04:00
Abijeet 18096f55d0 Disabled comment changes opacity only for message text.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
Abijeet 01c5a31a4a Adds a tooltip for the submit / save button in comments.
Towards #7281

Also hiding the menu before triggering click action.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
Abijeet 6d2716dceb Added ellipsis for longer usernames.
Towards #7281

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
Abijeet 872853af58 Moves the edit and delete options into a dropdown menu.
Fixes #7281

- Added a new View to render the dropdown.
- Modified the existing code.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
Abijeet 001cd986ed Converts the css file to scss file, and adds border-top to comments.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
Abijeet 61b38a16fa Fixes the following UI issues,
1. Increased the size of the delete, edit, close and submit buttons to take up 44x44px.
2. Now showing the delete button at all times when editing to avoid usability issues with touch screens.
3. Edit icon is also shown at all times, rather than only on hover.
4. Reduced the gap between comments a wee bit.
5. Fixed issues with focus event now working properly for edit and delete.
6. Removed absolute positioning of elements for alignment.
7. Fixed issue with tooltips becoming too high due to padding around actions. Occurred due to my changes.
8. Changed the position of the submit and close icons.
9. Fixed issue with jumping of the delete icon in Firefox. Occurred due to my changes.
10. Fixed issue with wrapping of content due to long author names. Occurred due to my changes.
11. Fixed issue with longer comments not appearing properly. This might have occurred due to my changes.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
Abijeet b3e1026cab Fixes div being added placed directly under ul during editing of comments.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
Abijeet facd1cae2f Fixes issue where saving a non-modified comment kept the edit window open.
Now irrespective of the whether the comment has been modified we are going to go back to the view mode.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
Roeland Jago Douma 8cdbb1ccd8 Merge pull request #8988 from nextcloud/techdep/noid/removeDeprecatedPrivateBackend
Remove deprecated OC_Group_Backend
2018-03-26 20:11:55 +02:00
Julius Härtl cf4d27b115 Use customclient_* values by default and do not use them in custom themes anymore
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-26 19:26:36 +02:00
Julius Härtl b6501ae966 Show UI when using a custom theme
Do not hide the theming app UI when using a custom theme besides it, but warn the users about some settings being overwritten by that.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-26 18:23:51 +02:00
Roeland Jago Douma 8a28bacb8c Remove \OCP\DB
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-26 14:40:23 +02:00
Roeland Jago Douma f4fd0224db Do not use \OCP\DB anymore
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-26 14:40:23 +02:00
Julius Härtl af4acdc6d6 Fix tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-26 14:29:28 +02:00
Roeland Jago Douma 91cc44a4e6 Remove deprecated OC_Group_Backend
* Private class
* Has been deprecated since NC10

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-26 14:19:04 +02:00
Julius Härtl e7c3b8da77 Clear any theming prefixed cache on cache buster increase
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-26 12:34:26 +02:00
Roeland Jago Douma e6a2c13ac1 MethodNotAllowed is not a Fatal error
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-26 12:15:31 +02:00
Joas Schilling 421a00854c Make sure DI is done
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-26 11:35:07 +02:00
Joas Schilling 7ea00b7b5f Move the group database backend fully to query builder
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-26 11:35:07 +02:00
Roeland Jago Douma b52c935c09 Make 2FA backupcodes strict
* and follow the interface again

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-26 11:31:02 +02:00
Roeland Jago Douma 24b12385d0 Strict 2FA
* make OCP\Authentication\TwoFactorAuth strict
* scalar types
* return types

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-26 11:31:02 +02:00
Roeland Jago Douma 74f0e37233 Remove deprecated \OCP\User::userExists
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-26 11:16:23 +02:00
Nextcloud bot e2b44d199b [tx-robot] updated from transifex 2018-03-26 00:13:15 +00:00
Roeland Jago Douma 7ebd96416c Remove deprecated OCP\User::getDisplayname
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-25 20:42:03 +02:00
Roeland Jago Douma 6c8caa1641 Remove deprecated \OCP\User::getUsers
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-25 20:33:24 +02:00
Nextcloud bot 89ebb8a663 [tx-robot] updated from transifex 2018-03-25 01:09:58 +00:00
Nextcloud bot 3b6a45b926 [tx-robot] updated from transifex 2018-03-24 01:12:19 +00:00
Robin Appelman fcd48aec1b update icewind/searchdav to 1.0.1
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-03-23 20:25:24 +01:00
Roeland Jago Douma e2866091bc Merge pull request #8943 from nextcloud/dep_oc_json
Remove \OCP\JSON
2018-03-23 15:20:38 +01:00
Joas Schilling 3d8fcad88b Merge pull request #8865 from nextcloud/ocs-groups-displayname
Return groups displayname in provisioning api
2018-03-23 14:44:13 +01:00
Roeland Jago Douma 2c9fd794b8 Update autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-23 13:31:16 +01:00
John Molakvoæ (skjnldsv) 5f38cfbc80 Return groups displayname in provisioning api
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-23 12:06:50 +01:00
Roeland Jago Douma 26073eac0c Finally remove \OCP\JSON
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-23 08:50:17 +01:00
Roeland Jago Douma 34cb8ea161 Merge pull request #8935 from nextcloud/backend_interfaces
Backend interfaces
2018-03-23 08:48:03 +01:00
Morris Jobke 6a31203793 Merge pull request #8856 from nextcloud/ocs-api-new-user-password-email
Allow admin to create users without password by sending mail automatic…
2018-03-23 08:17:41 +01:00
Morris Jobke 7892a0e293 Merge pull request #8936 from nextcloud/fix-gallery-selectors
Fix gallery buttons selector
2018-03-23 08:16:16 +01:00
Nextcloud bot 64948bf30c [tx-robot] updated from transifex 2018-03-23 01:11:28 +00:00
Morris Jobke 750bb4d7e1 Merge pull request #8948 from nextcloud/search-dav-selectable_displayname
Make displayname selectable
2018-03-22 20:06:21 +01:00
John Molakvoæ (skjnldsv) 24ecf3f4c9 Fixed files copy/move when in favorites or recent section
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-22 18:09:30 +01:00
Roeland Jago Douma c306bc29d1 Make displayname selectable
It is dav. so if it is not properly set we just return a 404 anyway.
2018-03-22 16:46:21 +01:00
Roeland Jago Douma f5ce2531d8 Update autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-22 16:32:05 +01:00
Roeland Jago Douma b723a2b8ca Document parameters
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-22 16:32:05 +01:00
Roeland Jago Douma 471272d456 Move to ABackend
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-22 16:32:05 +01:00
Roeland Jago Douma cbd2be583a Move Database backend over to new User/Backend interfaces
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-22 16:32:05 +01:00
Roeland Jago Douma 5aa0d83268 Remove type declarations where not yet possible
Because we don't return consistent things yet :(

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-22 16:32:04 +01:00
Roeland Jago Douma c30b9dacae Deprecate implementsActions
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-22 16:32:04 +01:00
Roeland Jago Douma 140e7b609f Fix phpdoc
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-22 16:32:04 +01:00
Roeland Jago Douma 355abbc96d Add abstract bakend to still be backwards compatible with the old logic
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-22 16:32:04 +01:00
Roeland Jago Douma 226439a31c Add interfaces for user backend functionality
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-22 16:32:04 +01:00
Roeland Jago Douma 874f134f3a Merge pull request #8891 from nextcloud/fix_8890
Fix proper permissions for multiple file access
2018-03-22 15:57:15 +01:00
John Molakvoæ (skjnldsv) 41b690ed53 Allow admin to create users withoutpassword by sending mail automatically
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-22 15:06:04 +01:00
Morris Jobke 8c6b6b1f0d Merge pull request #8886 from nextcloud/navigation-indicator
Make active navigation indicator more obvious
2018-03-22 14:19:03 +01:00
Roeland Jago Douma 3dac15a891 Move calls to \OCP\JSON to private \OC_JSON
They should be properly fixed at some point.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-22 13:19:29 +01:00
John Molakvoæ (skjnldsv) 25ea0e68cf Fix gallery buttons selector
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-22 12:59:05 +01:00
Roeland Jago Douma 6eb2088dd9 Merge pull request #8939 from nextcloud/fix-8701
Fix search text overlapping close button
2018-03-22 12:52:46 +01:00
Roeland Jago Douma af31fa82e8 Fix test
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-22 12:06:45 +01:00
Roeland Jago Douma 4e1161d254 Fix proper permissions for multiple file access
Fixes #8890

In case you have access to a file via multiple ways, for example:
1. the file is shared with you with permission read only
2. the folder containing the file is shared with your read/write

Requesting the getById function on the userFolder would give back two
entries but both with the same permissions. Depending on the node you
picked this is not right.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-22 12:06:41 +01:00
Morris Jobke 91b9c0d2c4 Merge pull request #8909 from nextcloud/feature/noid/make-the-autocomplete-endpoint-ocs
Make the new autocomplete endpoint OCS
2018-03-22 11:53:23 +01:00
Julius Härtl 138ae59901 Make text of edit entry being aligned with other entries
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-22 11:24:13 +01:00
Julius Härtl dd92923afa Make active navigation indicator more obvious
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-22 11:19:54 +01:00
Julius Härtl dc169857a7 Fix search text overlapping clode button
fixes #8701

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-22 10:57:13 +01:00
John Molakvoæ (skjnldsv) 63fa245461 Fix quota return if unlimited
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-22 10:14:15 +01:00
John Molakvoæ (skjnldsv) 6e7b7749bd Return quota even if user is not initialized
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-22 10:14:15 +01:00
Morris Jobke f843b7edfe Merge pull request #8506 from nextcloud/use-appmanager
Use isInstalled of AppManger instead of reimplement it
2018-03-22 09:55:19 +01:00
Morris Jobke be35b54f69 Merge pull request #8791 from nextcloud/cleanup-oc_json
Remove unused methods of OC_Json
2018-03-22 09:54:55 +01:00
Roeland Jago Douma dc4ba31e7e Merge pull request #8922 from nextcloud/deprecated-ocp-files-methods
Deprecated some methods of OCP\Files
2018-03-22 08:33:32 +01:00
Nextcloud bot c1b36e165e [tx-robot] updated from transifex 2018-03-22 01:11:40 +00:00
Morris Jobke de3297848e Merge pull request #8918 from nextcloud/remove-deprecated-ocp-response
Remove deprecated and unused OCP\Response
2018-03-21 16:54:19 +01:00
Morris Jobke d435061f8e Remove deprecated and unused OCP\Response
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-21 16:53:56 +01:00
Morris Jobke cd201686a7 Merge pull request #8920 from nextcloud/hint-files-api
Add hint about OCP\Folder::getById
2018-03-21 16:53:12 +01:00
Morris Jobke 6f455d5c41 Merge pull request #7196 from nextcloud/sharing-confirm-button
Add confirmation button to share input
2018-03-21 15:08:39 +01:00
Morris Jobke 24292be917 Merge pull request #8919 from nextcloud/remove-deprecated-method-of-ocp-user
Remove deprecated and unused method OCP\User::getDisplayNames
2018-03-21 15:05:24 +01:00
Morris Jobke 39bb32af71 Add hint about OCP\Folder::getById
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-21 14:49:32 +01:00
Morris Jobke 24f1b8f01a Merge pull request #8923 from nextcloud/typos
Fix some typos
2018-03-21 14:43:32 +01:00
Morris Jobke 78211a58e6 Remove unused methods of OC_Json
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-21 14:36:34 +01:00
Morris Jobke 2b73779568 Fix some typos
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-21 14:30:56 +01:00
Morris Jobke 8eb57dd835 Deprecate OCP\Files
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-21 14:29:35 +01:00
Morris Jobke 591d84f5fd Remove deprecated and unused method OCP\User::getDisplayNames
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-21 14:19:59 +01:00
Morris Jobke 98b1f3fd57 Merge pull request #8914 from nextcloud/remove-unused-db-methods
Remove unused and deprecated methods of OCP\DB
2018-03-21 13:28:27 +01:00
Morris Jobke 76a59ff913 Merge pull request #8911 from nextcloud/cleanup-tests
Migrate tests for contacts manager to correct test class
2018-03-21 13:28:04 +01:00
Morris Jobke 3579487798 Remove unused and deprecated methods of OCP\DB
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-21 12:17:55 +01:00
Morris Jobke 514de5dfa1 Use isInstalled of AppManger instead of reimplement it
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-21 11:34:18 +01:00
Morris Jobke 934eade56f Migrate tests for contacts manager to correct test class
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-21 10:43:18 +01:00
John Molakvoæ (skjnldsv) ffa2eaeb56 Fixed inline confirm icon index
Fixed bullet/icon combination visibility

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-21 10:36:17 +01:00
Joas Schilling dabd7291c3 Make the new autocomplete endpoint OCS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-21 09:46:52 +01:00
Morris Jobke c8340ace5c Merge pull request #7904 from nextcloud/fix_7224
Add Cache-control: immutable
2018-03-21 08:27:09 +01:00
Daniel Calviño Sánchez 203bf51543 Keep showing the working icon while there are pending operations
Before, whenever a pending operation (getting the suggestions,
confirming a share or selecting a recipient) finished the working icon
was hidden and the confirm button was shown again, even if there were
other pending operations (the most common case is typing slowly on the
input field, as several operations to get the suggestions could pile if
the server response is not received fast enough). Now, the working icon
is not hidden until the last pending operation finishes.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-21 04:35:26 +01:00
Daniel Calviño Sánchez a2c52cd6a5 Extract code to restore the UI after confirming a share
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-21 04:35:23 +01:00
Daniel Calviño Sánchez 9a0fbe307d Discard cached suggestions when adding a share
The suggestions depend on the results returned by the server, but also
on the sharees already shared with. Due to that adding a share changes
the suggestions, so now the cached suggestions are discarded when a
share is added.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-21 04:34:14 +01:00
Daniel Calviño Sánchez 6eb5cc5412 Reuse last suggestions if the same parameters are used
When a share is confirmed the suggestions are got to check if there is
an exact match. Usually the suggestions were already got with the same
parameters in order to fill the autocomplete dropdown, so to avoid a
superfluous request now the last suggestions are reused when got again,
although only if the same parameters as the last time are used.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-21 04:31:08 +01:00
Nextcloud bot af3ab1de10 [tx-robot] updated from transifex 2018-03-21 01:11:55 +00:00
Morris Jobke 18994cd700 Merge pull request #8821 from nextcloud/feature/noid/show-eol-warning
Show EOL warning in the update section
2018-03-20 22:39:00 +01:00
Daniel Calviño Sánchez 10a4f8e45e Confirm a share also by pressing enter on the input field
Besides confirming a share by clicking on the confirm button now it is
possible to do it by pressing enter on the input field.

Clicking on the confirm button implicitly hides the autocomplete
dropdown. On the other hand, pressing enter on the input field does not,
so the autocompletion must be disabled and closed when the confirmation
begins and then enabled again once it finishes. Otherwise the
autocomplete dropdown would be visible and it would be possible to
interact with it while the share is being confirmed.

The order in which the input field and the autompletion are disabled is
important. Internally, the autocompletion sets a timeout when the input
field is modified that requests the suggestions to the server and then
shows them in the dropdown. That timeout is not cancelled when the
autocompletion is disabled, but when the input field loses its focus and
the autocompletion is not disabled. Therefore, the input field has to be
disabled (which causes it to lose the focus) before the autocompletion
is disabled. Otherwise it could happen that while a share is being
confirmed the timeout ends, so an autocompletion request is sent and
then, once the share is successfully confirmed and thus the
autocompletion is enabled again, the request is received and the
autocomplete dropdown is shown with the old suggestions. Strange, but
possible nevertheless ;-)

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:05 +01:00
Daniel Calviño Sánchez 9371b61c4d Add a share when clicking on the confirm button
Clicking on the confirm button now adds a share, but only if there is
just a single exact match. If there are no exact matches or there is
more than one exact match no share is added, and the autocomplete
dropdown is shown again with all the suggestions.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:05 +01:00
Daniel Calviño Sánchez 5e2a8cca1b Return also exact matches besides all suggestions
"_getSuggestions" returned all the suggestions from the server, which
are composed by exact matches and partial matches. Now the exact matches
are also returned on their own parameter. This will be used by the
button to confirm a share.

Note that until now the order of the suggestions was "exact users,
partial users, exact groups, partial groups, exact..."; this commit also
changes that order to become "exact users, exact groups, exact...,
partial users, partial groups, partial...". This is not a problem, as
the suggestions were used in the autocomplete dropdown, and this new
order is arguably better than the old one, as all exact matches appear
now at the beginning.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez 89b0e34d9b Extract code to filter suggestions to its own function
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez 1c440519c2 Show an error when getting the suggestions succeeds with failure content
Instead of silently failing now an error is shown to the user when the
ajax call to get the suggestions succeeds yet it returns failure content
(for example, if an "OCSBadRequestException" was thrown in the server).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez ed1452d7a0 Use "showTemporary" instead of explicitly hiding the notification
"OC.Notification.hide" expects the notification to be hidden to be
passed as an argument. As it was being used to show a temporary
notification the combination of "OC.Notification.show" and
"OC.Notification.hide" was replaced by a single call to
"OC.Notification.showTemporary".

The timeout could have been specified in the options of the call, but it
was left to the default value (7 seconds) for consistency with other
notifications.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez fcef15af80 Move stub setup outside the test method
Stubs should be restored outside the test method in which they are used
to ensure that they are properly restored no matter the result of the
test (for example, if an exception is thrown).

Besides that, this will make possible to reuse the stub in other sibling
tests without having to explicitly setup it in them.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez d606219576 Extract code to get suggestions to its own method
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez 3980364b6d Add autocompletion tests for each type of share
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez 8af9c553e6 Add tests for exact search results already shared with
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez 375eab9df3 Add tests for emails and circles already shared with
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez 6fef01c481 Adjust search term to test
As the server response is faked the search term is ignored in the tests.
However, it is clearer to use a search term that would make the server
return what the faked response contains.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:03 +01:00
Jan-Christoph Borchardt ce7775acd0 Replace information icon with confirmation button in share input
The confirmation button right now is just an icon; its behaviour will be
added in the following commits.

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-03-20 19:09:03 +01:00
Morris Jobke 29c551c88f Merge pull request #8847 from nextcloud/ocs-api-userdetails
Add userdetails to ocs api
2018-03-20 18:12:25 +01:00
Joas Schilling ec1e039790 Show EOL warning in the update section
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-20 15:52:30 +01:00
Joas Schilling 64feb3f391 Merge pull request #8861 from nextcloud/rakekniven-patch-1
Update ThemingController.php
2018-03-20 13:45:20 +01:00
Roeland Jago Douma 99abe3bc8e Merge pull request #8864 from nextcloud/ocs-allow-empty-email-displayname
Allow empty emails provisioning api
2018-03-20 09:44:38 +01:00
Roeland Jago Douma 16ae91330c Merge pull request #8887 from nextcloud/fix-appmenu-min-width
Add min width of two icons to the app menu
2018-03-20 08:03:52 +01:00
Nextcloud bot 615258ba26 [tx-robot] updated from transifex 2018-03-20 01:11:33 +00:00
blizzz 7ae42f1f5d Merge pull request #8822 from nextcloud/fix/8641/undefined-index
the FN is optional, carrying the displayname if present
2018-03-19 17:57:12 +01:00
Julius Härtl 1699b119dd Add min width of two icons to the app menu
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-19 17:12:59 +01:00
John Molakvoæ (skjnldsv) 24659342f5 fixup! Check if groups is array, return empty do not throw
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-19 15:12:32 +01:00
rakekniven 789221a0fc Update ThemingControllerTest.php
Adjusted test
2018-03-19 15:07:49 +01:00
rakekniven d88db9b496 Update ThemingController.php
Changed file according to discussion on PR.
2018-03-19 15:00:27 +01:00
Roeland Jago Douma 796b4f19f8 Add Cache-control: immutable
Cache generated CSS forever!
Also cache combined JS forever
Fix tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-19 14:21:53 +01:00
Roeland Jago Douma 734cddfa97 Merge pull request #8880 from nextcloud/delete_unused_download
Remove unused download.php
2018-03-19 14:18:51 +01:00
Roeland Jago Douma 1c1608cddb Merge pull request #8871 from nextcloud/3rdparty-bump-openstack-3-0-5
[3rdparty] Bump php-opencloud/openstack to 3.0.5
2018-03-19 14:18:27 +01:00
Roeland Jago Douma ce0c896d8f Merge pull request #8881 from nextcloud/setUserValue_opt
Store setUserValue as string in cache
2018-03-19 14:17:59 +01:00
Roeland Jago Douma 431750828e Store setUserValue as string in cache
We cache the values we set in the setUserValue function.
However since the values are strings in the database we check if a value
is equal with string comparison

Now if the function was called with a $value of int or float. It would
be stored in the DB (and thus converted to string) and in the cache (not
converted thus as int/float).

Now if another call comes in that sets it to the same value (I'm looking
at you LDAP!). The check would fail since we would be comparing
int/float to string which fails by definition.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-19 12:57:48 +01:00
Roeland Jago Douma 9834f33d56 Merge pull request #8878 from nextcloud/remove_tmpfile
Remove deprecated tmpFile/tmpFolder
2018-03-19 12:29:08 +01:00
Roeland Jago Douma 0929e048f8 Merge pull request #8879 from nextcloud/dep_json
Remove unused deprecated functions from OCP\JSON
2018-03-19 12:28:23 +01:00
Roeland Jago Douma 1d6a2a7019 Remove unused download.php
There were two routes apps/files/ajax/download.php but apparently also
apps/files/download.php I could not find any use of it.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-19 11:45:48 +01:00
Roeland Jago Douma 68871caf3c Remove unused private function
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-19 11:32:10 +01:00
Roeland Jago Douma d984c8d633 Remove unused deprecated functions from OCP\JSON
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-19 11:30:35 +01:00
Roeland Jago Douma 05203e3fc0 Merge pull request #8877 from nextcloud/deprecated_bgj_delete
Remove old deprecated function from the BackgroundJob
2018-03-19 11:25:45 +01:00
Roeland Jago Douma 17bfa1c74e Merge pull request #8815 from nextcloud/channel-description
Provide a description of the update channels inline
2018-03-19 11:25:15 +01:00
Roeland Jago Douma 1088068c60 Remove \OCP\Files::tmpFolder
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-19 10:54:39 +01:00
Roeland Jago Douma 47a3008141 Remove \OCP\Files::tmpFile
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-19 10:52:35 +01:00
Roeland Jago Douma d304f4bebb Remove old deprecated function from the BackgroundJob
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-19 10:47:31 +01:00
Roeland Jago Douma ba611594b7 [3rdparty] Bump php-opencloud/openstack to 3.0.5
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-19 10:28:33 +01:00
Morris Jobke 63bc633d89 Merge pull request #8857 from nextcloud/swift-verify-cached-token
verify cached swift token
2018-03-19 10:10:04 +01:00
Nextcloud bot 2fab6b2620 [tx-robot] updated from transifex 2018-03-19 01:11:34 +00:00
Nextcloud bot d6bfc98df1 [tx-robot] updated from transifex 2018-03-18 01:11:46 +00:00
John Molakvoæ (skjnldsv) ccd57ce1b1 Allow empty emails provisionning api
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-17 12:18:22 +01:00
Nextcloud bot 3cac7911d5 [tx-robot] updated from transifex 2018-03-17 01:11:30 +00:00
Morris Jobke 9aced256c2 Merge pull request #8853 from nextcloud/remove-resolve-reshare
Remove unused resolveReshare of old sharing code
2018-03-16 20:23:01 +01:00
rakekniven b2ceb29484 Update ThemingController.php
Changed wording according to discussion at Transifex. See https://www.transifex.com/nextcloud/nextcloud/translate/#de/$/121491259?issue=yes
Aligned ending of error messages
2018-03-16 18:45:20 +01:00
blizzz e56759917b Merge pull request #8843 from nextcloud/set-share-with-field-to-the-id-of-the-circle
Set "share with" field to the ID of the circle
2018-03-16 16:42:31 +01:00
John Molakvoæ (skjnldsv) 2493e9426d Check if groups is array, return empty do not throw
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-16 15:32:36 +01:00
Robin Appelman 41954d2903 verify cached swift token
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-03-16 15:20:16 +01:00
Morris Jobke ade05f40ec Remove unused resolveReshare of old sharing code
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-16 12:26:38 +01:00
John Molakvoæ (skjnldsv) f5137fef6c Fixed tests and improved code
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-16 11:44:20 +01:00
John Molakvoæ (skjnldsv) aa1e8713fb Fixed throw error on unreachable users
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-16 09:38:09 +01:00
Morris Jobke f83aa58d1f Merge pull request #8835 from nextcloud/fix/noid/ldap_existence_check
group existence check works without attribute (like with users)
2018-03-16 09:31:49 +01:00
John Molakvoæ (skjnldsv) ce625bbad5 Add userdetails to ocs api
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-16 09:19:47 +01:00
Daniel Calviño Sánchez ed4b4458eb Use the display name in the avatar for a circle share
Before, the avatar for a circle share was generated using the
"share_with" field as the seed for "imageplaceholder". Due to this, when
the "share_with" field is set to the circle ID the character shown in
the avatar was just a random character instead of the first character of
the display name. Now the "share_with" is still used as the seed for the
colour, but the display name is used as the text of the avatar.

This adds support for "share_with" fields set to the circle ID while
being backwards compatible with "share_with" fields set to the circle
name.

Note that when "share_with" fields is set to the circle name the colour
of the avatar is different in the list of suggested sharees and in the
list of current sharees, but that also happened before these changes
(due to a different seed being used in each place).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-16 04:58:25 +01:00
Daniel Calviño Sánchez 2c073dc53d Set "share_with" field to the ID of the circle
When a share is shared with a circle the "share_with" field returned by
the API endpoint was always set to the name of the circle. However, the
name is not enough to identify a circle. The Circles app now provides
the ID of the circle in the "shared with" field of a Share, so this
commit modifies the API endpoint to set the "share_with" field to the ID
of the circle when provided by the Circles app.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-16 04:58:00 +01:00
enoch 6212992c0a fix(AmazonS3): fix loop $result['Contents'] error
Invalid argument supplied for foreach() at /var/www/html/apps/files_external/lib/Lib/Storage/AmazonS3.php#295
2018-03-16 11:51:27 +08:00
Nextcloud bot b7e7ae5d6d [tx-robot] updated from transifex 2018-03-16 01:11:31 +00:00
Arthur Schiwon cbf60f2e91 existence check works without attribute (like with users)
cn is not necessarily given everywhere

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-03-15 15:47:44 +01:00
Roeland Jago Douma fa886ef4eb Merge pull request #8830 from nextcloud/node_emit_read
Emit read for nodes
2018-03-15 14:04:14 +01:00
blizzz 208e38e84e Merge pull request #8255 from nextcloud/bugfix/noid/group-display-name
Full implement group display names
2018-03-15 12:07:30 +01:00
Roeland Jago Douma d6b326650b Emit read for nodes
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-15 11:18:39 +01:00
Roeland Jago Douma fde08a9619 Merge pull request #8793 from nextcloud/swift-config
Swift uses `containter` not `bucket`
2018-03-15 08:34:58 +01:00
Roeland Jago Douma f2b93f5246 Merge pull request #8828 from nextcloud/fix-configuration-values-matched-in-user-searches
Fix configuration values matched in user searches
2018-03-15 08:34:21 +01:00
Morris Jobke b01b3454e6 Provide a description of the update channels inline
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-15 07:11:50 +01:00
Nextcloud bot 055d15e305 [tx-robot] updated from transifex 2018-03-15 01:11:41 +00:00
Daniel Calviño Sánchez 0b96a71a68 Fix configuration values matched in user searches
Due to a misplaced closing parenthesis the condition of the left join
clause was just "userid = uid"; the other conditions were passed as
additional parameters to "leftJoin", and thus they were ignored.
Therefore, the result set contained every preference of each user
instead of only the email, so the "WHERE configvalue LIKE XXX" matched
any configuration value of the user.

Besides the closing parenthesis this commit also fixes the literal
values. Although "Literal" objects represent literal values they must be
created through "IExpressionBuilder::literal()" to be properly quoted;
otherwise it is just a plain string, which is treated as a column name.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-14 23:31:42 +01:00
Arthur Schiwon f42c29ebac the FN is optional, carrying the displayname if present
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-03-14 14:30:45 +01:00
Roeland Jago Douma d3e7996e80 Fix bucket and container usage
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-14 13:57:14 +01:00
Roeland Jago Douma 23a02eaf14 Merge pull request #8818 from nextcloud/remove-alternative-logins-title
Remove "Alternative logins" title on login page
2018-03-14 13:52:35 +01:00
Sagorika Das 6bac63adec sorts filepicker files by modified date
Signed-off-by: Sagorika Das <sagorika1996@gmail.com>
2018-03-14 18:11:50 +05:30
Morris Jobke 990ca145d7 Remove "Alternative logins" title on login page
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-14 11:38:57 +01:00
Morris Jobke 8e47f10714 Merge pull request #8816 from nextcloud/cleanup-ocp-contacts
Remove deprecated OCP\Contacts
2018-03-14 11:21:49 +01:00
Morris Jobke 8d4b76c0e2 Remove deprecated OCP\Contacts
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-14 10:47:09 +01:00
Roeland Jago Douma 2d5febd0b9 Merge pull request #8811 from nextcloud/remove_dep_util_link
Remove deprecated URL functions for OCP\Util
2018-03-14 09:49:51 +01:00
Roeland Jago Douma 0e48afafed Merge pull request #8804 from nextcloud/remove_httphelper
Remove deprecated HTTPHelper
2018-03-14 09:49:24 +01:00
Nextcloud bot 7f00de841b [tx-robot] updated from transifex 2018-03-14 01:11:29 +00:00
Roeland Jago Douma b93d26a209 Replace ContactsManager
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 22:18:38 +01:00
Roeland Jago Douma 83873e3da1 Remove deprecated URL functions for OCP\Util
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 22:04:08 +01:00
Roeland Jago Douma 7785c3752f Remove deprecated HTTPHelper
* Remove the HTTP Helper
* Remove from Server Containter
* Removed legacy share tests that use it

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 21:54:56 +01:00
blizzz 76d23a1600 Merge pull request #8806 from nextcloud/add-local-memcache-check
Properly provide local memcache check to ICacheFactory
2018-03-13 21:27:24 +01:00
Morris Jobke dde5353f98 Properly provide local memcache check to ICacheFactory
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-13 18:18:04 +01:00
Morris Jobke ede723f1b1 Merge pull request #8796 from nextcloud/varadic_qb
Make QueryBuilder varadic
2018-03-13 14:11:19 +01:00
Morris Jobke 274106b80b Merge pull request #8800 from nextcloud/getstoragestats_to_controller
Move storagestats endpoint to proper controller
2018-03-13 14:08:30 +01:00
Roeland Jago Douma f52ba44edb Move storagestats endpoint to proper controller
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 12:44:48 +01:00
Morris Jobke 58599e0360 Merge pull request #8781 from nextcloud/cleanup-old-federation-code
Remove old code to be compatible with Nextcloud 9 and before
2018-03-13 11:53:21 +01:00
Morris Jobke 45895de531 Merge pull request #8794 from nextcloud/swift-v3-cache-token
Properly cache swift v3 token
2018-03-13 11:35:38 +01:00
Morris Jobke a827160cfa Merge pull request #8797 from nextcloud/inject-public-igroupmanager-instead-of-private-groupmanager
Inject public IGroupManager instead of private GroupManager
2018-03-13 10:42:10 +01:00
Daniel Calviño Sánchez 044d5a8d01 Inject public IGroupManager instead of private GroupManager
The public "IGroupManager" service returned by the dependency injection
system is automatically initialized with an "OC\Group\Database" backend.
However, no backend is automatically set in private "GroupManager"
instances. Therefore, a private "GroupManager" instance does not work as
expected when initialized through the dependency injection system.

Due to that this commit reverts a previous change in which the public
"IGroupManager" was replaced by a private "GroupManager" instance. That
change was needed when strict types were set, as "getSubAdmin()" is not
part of "IGroupManager" API, so the type had to be changed to
"GroupManager". Until a better solution is found strict types are
disabled again to be able to inject "IGroupManager" and also use
"getSubAdmin()".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-13 09:52:27 +01:00
Morris Jobke 7488218535 Merge pull request #8792 from nextcloud/cleanup-oc_response
Remove unused methods of OC_Response
2018-03-13 09:47:29 +01:00
Roeland Jago Douma 46c195b58b Made IExpressionBuilder varadic
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 09:35:09 +01:00
Roeland Jago Douma 0009358c17 Made orHaving varadic
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 09:32:31 +01:00
Roeland Jago Douma 408c2103db Made addHaving varadic
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 09:31:33 +01:00
Roeland Jago Douma 2c585afea1 Make having varadic
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 09:31:04 +01:00
Roeland Jago Douma c6eba3c925 Made addGroupBy varadic
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 09:30:14 +01:00
Roeland Jago Douma afbad7e15e Made groupBy varadic
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 09:29:36 +01:00
Roeland Jago Douma d6b93e6620 Made orWhere varadic
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 09:28:27 +01:00
Roeland Jago Douma 07cb6aaeff Made andWhere varadic
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 09:27:43 +01:00
Roeland Jago Douma 222dbb7bc9 Made where varadic
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 09:27:11 +01:00
Roeland Jago Douma 2976b39102 Made AddSelect varadic
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 09:25:32 +01:00
Morris Jobke 53a899a1f5 Fix the HTTP 1.0 status code and properly detect 1.0 vs 1.1&2.0
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-13 09:22:26 +01:00
Morris Jobke 57eaa48e3d Merge pull request #8788 from nextcloud/cleanup-oc_api
Remove unused methods and constants from legacy OC_API
2018-03-13 08:52:24 +01:00
Roeland Jago Douma c8aee70a0b Made select varadic
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 08:07:08 +01:00
Nextcloud bot 3cae276149 [tx-robot] updated from transifex 2018-03-13 01:12:01 +00:00
Roeland Jago Douma 66173e9b52 Merge pull request #8789 from nextcloud/proper-exception-logging
Use proper method to log exceptions
2018-03-12 22:01:10 +01:00
Roeland Jago Douma 4e8d5504d2 Properly cache swift v3 token
The V3 token has an export function. Without this the token is
effectively never cached.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-12 20:53:50 +01:00
Morris Jobke fac0a11576 Merge pull request #8786 from nextcloud/remove-insert-if-not-exists
Use insertIfNotExist of the new interface
2018-03-12 18:44:16 +01:00
Morris Jobke e758cfcdc8 Remove unused methods of OC_Response
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 18:42:30 +01:00
Morris Jobke 044d01d0e1 Use proper method to log exceptions
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 18:10:59 +01:00
Morris Jobke a1232f46ca Remove unused methods and constants from legacy OC_API
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 18:03:25 +01:00
Morris Jobke 2b335fd607 Use insertIfNotExist of the new interface
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 17:45:49 +01:00
Morris Jobke 3655951dd7 Merge pull request #8787 from nextcloud/remove-deprecated-and-unused-methods-of-db
Remove deprecated and unsused methods of OCP\DB
2018-03-12 16:34:37 +01:00
Morris Jobke 432e529827 Merge pull request #8784 from nextcloud/remove-unused-deprecated-apphelper
Remove unused and deprecated class and interface AppHelper
2018-03-12 16:33:46 +01:00
Morris Jobke 324ce5a993 Merge pull request #8783 from nextcloud/remove-unused-deprecated-methods
Remove unused and deprecated methods from OCP\Util
2018-03-12 16:33:14 +01:00
Morris Jobke 3df2fb7af6 Merge pull request #8782 from nextcloud/properly-use-new-method-to-format-date
Use proper method to format absolute timestamp
2018-03-12 16:32:38 +01:00
Morris Jobke f5c5c5181f Remove unused and deprecated class and interface AppHelper
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 15:27:10 +01:00
Morris Jobke 44289ff134 Use proper method to format absolute timestamp
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 15:16:52 +01:00
Morris Jobke 8195b17ed7 Remove deprecated and unsused methods of OCP\DB
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 15:13:37 +01:00
Morris Jobke e1d95974bf Remove unused and deprecated methods from OCP\Util
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 14:37:02 +01:00
Morris Jobke 4cbcf6f920 Remove old code to be compatible with Nextcloud 9 and before
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 14:21:12 +01:00
Roeland Jago Douma af89db3407 Merge pull request #8743 from nextcloud/strict_settings
Strict settings
2018-03-12 12:37:03 +01:00
Morris Jobke 430c478ba3 Merge pull request #8769 from nextcloud/admin_audit_strict
Make admin_audit strict
2018-03-12 11:57:37 +01:00
Nextcloud bot 4e56a02450 [tx-robot] updated from transifex 2018-03-12 01:12:21 +00:00
Morris Jobke 15c099df4d Merge pull request #8633 from nextcloud/rakekniven-i18n-fix
Improved translation strings
2018-03-11 19:33:26 +01:00
Nextcloud bot 2c503ccdee [tx-robot] updated from transifex 2018-03-11 01:12:13 +00:00
Roeland Jago Douma 4d5830c4aa Make admin_audit strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-10 19:40:19 +01:00
Roeland Jago Douma f4bcf2db60 Use variable for proper translations
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-10 13:00:25 +01:00
rakekniven bcdbbb56b0 Update ThemingControllerTest.php
Fixed tests for https://github.com/nextcloud/server/pull/8633
2018-03-10 12:57:09 +01:00
rakekniven 746022ce46 Update wizardTabElementary.js
Fixed grammar.
Reported at Transifex. See https://www.transifex.com/nextcloud/nextcloud/translate/#de/$/91002422?issue=yes
2018-03-10 12:57:09 +01:00
rakekniven 2b0c523cc0 Update settings.js
Added question mark.
Reported at Transifex. See https://www.transifex.com/nextcloud/nextcloud/translate/#de/$/120539223?issue=yes
2018-03-10 12:57:09 +01:00
rakekniven 4fc4e6dcaa Update ThemingController.php
Improved translation string.
Reported at Transifex. See https://www.transifex.com/nextcloud/nextcloud/translate/#de/$/121491256?issue=yes
2018-03-10 12:57:05 +01:00
Nextcloud bot f08bc1bc6f [tx-robot] updated from transifex 2018-03-10 01:11:58 +00:00
Morris Jobke dc5d4f96b0 Merge pull request #8731 from nextcloud/acceptance-header-tests
Header acceptance features
2018-03-09 21:14:44 +01:00
Morris Jobke f35c447525 Merge pull request #8757 from nextcloud/search_controller
Move search to proper Controller
2018-03-09 16:15:55 +01:00
Roeland Jago Douma f7eee0b173 Update autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-09 15:25:01 +01:00
Roeland Jago Douma 7674e591bd Move search to proper Controller
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-09 14:36:48 +01:00
John Molakvoæ (skjnldsv) 3d99a9d24e Header acceptance features
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-09 14:33:22 +01:00
Nextcloud bot 20f1f757c4 [tx-robot] updated from transifex 2018-03-09 13:31:21 +00:00
Roeland Jago Douma 7fc85bbf78 Obsolete test
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-09 14:10:20 +01:00
Roeland Jago Douma 1cc7db32cd Merge pull request #8747 from nextcloud/bugfix/noid/apps-are-updated
Revert wording back to updates
2018-03-09 12:13:05 +01:00
blizzz 054a45c079 Merge pull request #8710 from nextcloud/followup/8596/tests-for-user-pagination
Tests for email collaborators pagination
2018-03-09 11:21:21 +01:00
Morris Jobke 5924f9cb30 Merge pull request #8594 from nextcloud/add-acceptance-tests-for-permissions-on-public-shared-folders
Add acceptance tests for permissions on public shared folders
2018-03-09 11:12:04 +01:00
Morris Jobke ed5008597f Merge pull request #8112 from nextcloud/fix-integer-overflow
Fix integer overflow in ChunkingPlugin
2018-03-09 10:27:17 +01:00
Joas Schilling 528ffaf250 Merge pull request #8742 from nextcloud/strict_app
OCP\AppFramework\App strict
2018-03-09 10:13:08 +01:00
Joas Schilling 81a3ac1226 Merge pull request #8736 from nextcloud/rakekniven-patch-1
Update login.php
2018-03-09 09:51:36 +01:00
Joas Schilling dc51d28fcd Revert wording back to updates
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-09 09:49:22 +01:00
Roeland Jago Douma d9d33d14e7 Make UserController strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-09 08:59:08 +01:00
Roeland Jago Douma 5ad89371ed Make ChangePasswordController strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-09 08:52:14 +01:00
Roeland Jago Douma 129a608ebe OCP\AppFramework\App strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-09 08:42:03 +01:00
Roeland Jago Douma d2a8dbeac6 Merge pull request #8741 from nextcloud/fix_autoloader
Fix autoloader
2018-03-09 08:30:54 +01:00
Roeland Jago Douma f17627c1c1 Fix autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-09 07:58:42 +01:00
Daniel Calviño Sánchez 15c12eb027 Add acceptance tests for creation of subfolders in public shared folders
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-09 03:37:08 +01:00
Daniel Calviño Sánchez 1a2d9a2fdd Extract common "wait for" functions to a helper class
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-09 03:37:08 +01:00
Daniel Calviño Sánchez fcd6cf08e0 Generalize file list steps so a specific ancestor can be used
The "FileListContext" provides steps to interact with and check the
behaviour of a file list. However, the "FileListContext" does not know
the right file list ancestor that has to be used by the file list steps,
so until now the file list steps were explicitly wired to the Files app
and they could be used only in that case.

Instead of duplicating the steps with a slightly different name (for
example, "I create a new folder named :folderName in the public shared
folder" instead of "I create a new folder named :folderName") the steps
were generalized; now contexts that "know" that certain file list
ancestor has to be used by the FileListContext steps performed by
certain actor from that point on (until changed again) set it
explicitly. For example, when the current page is the Files app then the
ancestor of the file list is the main view of the current section of the
Files app, but when the current page is a shared link then the ancestor
is set to null (because there will be just one file list, and thus its
ancestor is not relevant to differentiate between instances)

A helper trait, "FileListAncestorSetter", was introduced to reduce the
boilerplate needed to set the file list ancestor from other contexts.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-09 03:37:08 +01:00
Daniel Calviño Sánchez 766135cb64 Generalize file list locators so a specific ancestor can be used
The file list is used in other places besides the Files app (for
example, the File sharing app); in those cases the locators for the file
list elements are the same, but not for the ancestor of the file list.
To make possible to reuse the file list locators in those cases too now
they receive the ancestor to use.

Note that the locators for the file actions menu were not using an
ancestor locator because it is expected that there is only one file
actions menu at a time in the whole page; that may change in the future,
but for the time being it is a valid assumption and thus the ancestor
was not added to those locators in this commit.

Although the locators were generalized the steps themselves still use
the "FilesAppContext::currentSectionMainView" locator as ancestor; the
steps will be generalized in a following commit.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-09 03:37:08 +01:00
Daniel Calviño Sánchez 10490f2ac3 Store the name of the actor in the Actor object
This is needed to be able to easily use the actor as a key in an array.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-09 03:37:08 +01:00
Daniel Calviño Sánchez 49f2ba16f0 Extract file list locators and steps to its own class
Besides the extraction some minor adjustments (sorting locators for file
action menu entries to reflect the order of the menu entries in the UI,
moving parametrized locators like "createMenuItemFor" above the locators
that use them and placing "descendantOf" calls always in a new line)
were made too.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-09 03:37:08 +01:00
Nextcloud bot a20e9d7891 [tx-robot] updated from transifex 2018-03-09 01:12:12 +00:00
Roeland Jago Douma 1329061d31 Merge pull request #8648 from nextcloud/feature/csrf-token-controller
Use session heartbeat to update CSRF token
2018-03-08 21:15:24 +01:00
Roeland Jago Douma 7a7c350a2d Merge pull request #8716 from nextcloud/fix-cache-prefixing
Remove base url from global cache prefix
2018-03-08 21:12:54 +01:00
Roeland Jago Douma 7e374200c4 Merge pull request #8575 from nextcloud/new-folder-button
Updated popover rules to allow form inputs and added input submit for…
2018-03-08 21:09:44 +01:00
Roeland Jago Douma 633d0581a3 Merge pull request #8728 from nextcloud/better-handling-of-invisible-elements-in-acceptance-tests
Better handling of invisible elements in acceptance tests
2018-03-08 21:04:20 +01:00
Roeland Jago Douma d05469959e Merge pull request #8715 from nextcloud/objectstore-no-part-files
disable part files for object stores
2018-03-08 20:52:16 +01:00
rakekniven 1046fb5111 Update login.php
Fixed grammar issue.
Reported at Transifex. See https://www.transifex.com/nextcloud/nextcloud/translate/#af/$/124614533?issue=yes
2018-03-08 20:08:11 +01:00
John Molakvoæ (skjnldsv) 23a1553539 Fixed api tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:52 +01:00
John Molakvoæ (skjnldsv) f1478ea440 No ES6 :(
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:51 +01:00
John Molakvoæ (skjnldsv) d435c91fda fixup! Fixed sharing groups select and fixed search
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:51 +01:00
John Molakvoæ (skjnldsv) 6e0044b668 Fixed sharing groups select and fixed search
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:51 +01:00
Joas Schilling 51ec928623 Send the group ids to the server on user creation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:50 +01:00
Joas Schilling 1f9a5c0d7f Remove resolved FIXME
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:50 +01:00
John Molakvoæ (skjnldsv) 720e64ba55 Fixed caldav tests and metadata 2
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:50 +01:00
John Molakvoæ (skjnldsv) d80f13ef99 Fix Metadata tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:50 +01:00
John Molakvoæ (skjnldsv) 9440e9bb1e Fixed Controller Test
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:50 +01:00
John Molakvoæ (skjnldsv) e6a7a9f251 Fixed select2 workflow
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:50 +01:00
John Molakvoæ (skjnldsv) ddcd37121f Fix users loading on group click and group creation on select
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:49 +01:00
John Molakvoæ (skjnldsv) 00122fa027 Use group displayNames in users list
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:49 +01:00
Joas Schilling cb2fbdd214 Fix group display name in the sidebar of the user management
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:49 +01:00
Joas Schilling db9b2398dd Fix group displaynames in activity
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:49 +01:00
Joas Schilling 0e2366233a Start fixing Select2 options
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:49 +01:00
Joas Schilling 82137f443d Correctly return the group name
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:48 +01:00
Joas Schilling aef86a5f5a Show the displayname in the users group list
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:48 +01:00
Christoph Wurst b9720703e8 Add CSRF token controller to retrieve the current CSRF token
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-03-08 16:48:50 +01:00
Joas Schilling 882096653e Fix calculation if there are more results
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 16:22:16 +01:00
Daniel Calviño Sánchez c1fa0f8b86 Add automatic handling of NoSuchElement exceptions
NoSuchElement exceptions are sometimes thrown instead of
StaleElementReference exceptions. This can happen when the Selenium2
driver for Mink performs an action on an element through the WebDriver
session instead of directly through the WebDriver element. In that case,
if the element with the given ID does not exist, a NoSuchElement
exception would be thrown instead of a StaleElementReference exception,
so those cases are handled like StaleElementReference exceptions.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-08 14:54:01 +01:00
Daniel Calviño Sánchez deb2495f89 Add automatic handling of MoveTargetOutOfBounds exceptions
MoveTargetOutOfBounds exceptions are sometimes thrown instead of
ElementNotVisible exceptions. This can happen when the Selenium2 driver
for Mink moves the cursor on an element using the "moveto" method of the
Webdriver session, for example, before clicking on an element. In that
case, if the element is not visible, "moveto" would throw a
MoveTargetOutOfBounds exception instead of an ElementNotVisible
exception, so those cases are handled like ElementNotVisible exceptions.

Note that MoveTargetOutOfBounds exceptions could be thrown too if the
element was visible but "out of reach"; there is no problem in handling
those cases as if the element was not visible, as the exception will be
thrown again anyway once it is verified that the element is indeed
visible.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-08 14:53:15 +01:00
Joas Schilling 3d7ae4aa97 Add tests for finding own email and user results pagination
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 13:26:26 +01:00
Morris Jobke cccf6f4d5f Merge pull request #8221 from Cybso/8220_applyLdapUserFilter_on_members
Apply ldapUserFilter on members of group
2018-03-08 13:19:02 +01:00
Robin Appelman f5ef9e02b2 emit pre-hooks earlier when not using part files
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-03-08 13:02:35 +01:00
Morris Jobke a2db959f5c Merge pull request #8593 from eneiluj/master
Allow public page access to apps with group restrictions
2018-03-08 11:27:52 +01:00
Roeland Jago Douma 3ad7daeda5 Add tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-08 11:05:18 +01:00
John Molakvoæ (skjnldsv) cee5be6ff2 Fixed jsunit
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 10:31:33 +01:00
Roeland Jago Douma 340e8ef16c Make SecurityMiddleware strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-08 10:11:47 +01:00
Morris Jobke 069e3f50a7 Merge pull request #8711 from nextcloud/objectstore-write-only-fopen
don't read existing file when overwriting using object store
2018-03-08 09:32:39 +01:00
Roeland Jago Douma af55b03386 Merge pull request #8662 from nextcloud/better-debugging-unit-tests
Better debugging for "Your test case is not allowed to access the dat…
2018-03-07 21:53:34 +01:00
John Molakvoæ (skjnldsv) 3ef4131533 Fixed event propagation on safari
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 17:10:46 +01:00
Joas Schilling 1dd40b1f45 Single quotes
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-07 16:50:18 +01:00
Joas Schilling 559978c50e Suppress phan error
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-07 16:43:16 +01:00
John Molakvoæ (skjnldsv) e1ec4514cc Use label for better focus on external share
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 15:28:03 +01:00
John Molakvoæ (skjnldsv) 5dbd09f07c Align radio & checkboxes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 15:17:54 +01:00
John Molakvoæ (skjnldsv) 446a3a9d5a Fixed ext share style and use varable for popover height
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 15:12:06 +01:00
Julius Härtl 573b940761 Use cache prefix for theming as well
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-07 15:09:43 +01:00
Julius Härtl 95366bbd1f Fix tests to use ICacheFactory
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-07 15:09:43 +01:00
Julius Härtl 63e261b444 Actually clear cache values for all base urls
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-07 15:09:43 +01:00
Julius Härtl f652c28b21 Use JSCombiner from server container when searching for JS files
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-07 15:09:43 +01:00
Julius Härtl 50a9beb4bb Move base url from global cache prefix to frontend related ones
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-07 15:09:43 +01:00
Morris Jobke 8d865483f4 Merge pull request #8714 from nextcloud/8705
Check if the cached js file exists
2018-03-07 14:45:43 +01:00
Roeland Jago Douma 448a5e574e Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-07 14:04:21 +01:00
Robin Appelman fc35352122 disable part files for object stores
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-03-07 13:33:35 +01:00
John Molakvoæ (skjnldsv) e2910e17b0 Default left margin for entries without icons
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 13:17:38 +01:00
John Molakvoæ (skjnldsv) e77bddf56b Css hack to add margin on first or last visible inputs
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 13:17:38 +01:00
John Molakvoæ (skjnldsv) 966ceca8ea Removed unwanted conflicting props
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 13:17:37 +01:00
John Molakvoæ (skjnldsv) 8d986160b8 Improved inline confirm icon with opacity and fixed ext share loading state
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 13:17:37 +01:00
John Molakvoæ (skjnldsv) 4e6043fd6b Fixed tooltip positionning & error display
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 13:17:37 +01:00
John Molakvoæ (skjnldsv) 955c2ee1a7 PoC inline icon-confirm with inputs
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 13:17:37 +01:00
John Molakvoæ (skjnldsv) a7a3640224 fixup! Updated popover rules to allow form inputs and added input submit for new File
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 13:17:37 +01:00
John Molakvoæ (skjnldsv) 3964616a9e Updated popover rules to allow form inputs and added input submit for new File
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 13:17:36 +01:00
Roeland Jago Douma 34b86edc34 Check if the cached js file exists
Fixes #8705

If the file does not exist (for whatever reason). It is never cached. No
matter what the depscache etc tell you.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-07 12:55:05 +01:00
Morris Jobke d1aa96fef9 Merge pull request #8373 from nextcloud/right-header-stdrd
New standard for top right header
2018-03-07 12:33:11 +01:00
Roland Tapken 2472b93fd9 dn2ocname: also apply group filter to readAttribute()
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2018-03-07 12:18:46 +01:00
Robin Appelman 9764e70494 don't read existing file when overwriting using object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-03-07 12:05:57 +01:00
John Molakvoæ (skjnldsv) d9bd6f3253 Fixed public template
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 11:05:23 +01:00
blizzz 076b49b9fe Merge pull request #8696 from nextcloud/fix-public-api-doc
Fix PHPDoc for public API
2018-03-07 10:53:31 +01:00
Morris Jobke 3156d95e14 Merge pull request #8652 from nextcloud/navigation-controller-etag
Add ETag to NavigationController
2018-03-07 10:03:00 +01:00
Julius Härtl 16ac8eaac9 Fix tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-07 09:17:18 +01:00
Morris Jobke 65cc155a11 Merge pull request #8596 from nextcloud/bugfix/8454/sharee-email-matches-not-limited
Also array_slice wide email matches of local users
2018-03-06 22:21:03 +01:00
Morris Jobke aea8b30cf7 Fix PHPDoc for public API
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-06 21:55:04 +01:00
Morris Jobke de56915605 Merge pull request #7419 from Abijeet/feature-7175
Fixes #7175 - Allow to search for email address in user management
2018-03-06 21:53:37 +01:00
Morris Jobke c88112bb41 Merge pull request #8579 from nextcloud/feature/2692/merge-can-i-update
Display a list of unavailable apps for updates (aka. merge "Can I update?")
2018-03-06 21:31:06 +01:00
Morris Jobke fc4e0501f0 Fix integer overflow in ChunkingPlugin
Avoids errors when the size exceeds MAX_INT because of the cast to int. Better cast it to float to avoid this.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-06 18:47:26 +01:00
Morris Jobke 846b0d6a42 Merge pull request #5833 from nextcloud/fix_uninstall_rep_step
Run repair steps on uninstall in all cases
2018-03-06 17:57:10 +01:00
Morris Jobke b2a9ea08a3 Remove unused and outdated hook
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-06 17:56:44 +01:00
Morris Jobke d0de8e4905 Merge pull request #8666 from nextcloud/strict_idproof
Make \OC\Security\IdentityProof strict
2018-03-06 17:53:09 +01:00
Joas Schilling c7b322b863 Fix the cursor on the icon
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-06 17:28:20 +01:00
Joas Schilling 303085421e Add a little arrow to indicate that the list can be opened
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-06 17:24:24 +01:00
Joas Schilling f9eb5c85a3 Fix the available list
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-06 17:14:07 +01:00
Joas Schilling 2d72c16ecd Show a loading message while we determinate the status of the updates
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-06 17:13:35 +01:00
Joas Schilling 09d8387b00 Try without autoloading
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-06 13:56:44 +01:00
Tobia De Koninck 96a5752340 Remove unused $enableAppsCache in OC_App
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
2018-03-06 10:47:16 +01:00
Tobia De Koninck 55b9a5d886 Remove OC_App::disable method
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
2018-03-06 10:45:20 +01:00
Tobia De Koninck 539fdaea1e Run repair steps on uninstall in all cases
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
2018-03-06 10:41:55 +01:00
Julius Härtl 11b6cc3f68 Replace logout href to avoid new etag on every request
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-06 09:51:28 +01:00
Nextcloud bot 3867a74f0d [tx-robot] updated from transifex 2018-03-06 01:12:16 +00:00
Roeland Jago Douma c2320aea22 Merge pull request #8634 from nextcloud/ldap-no-empty-names
do not create empty userid when attribute does not have allowed chars
2018-03-05 19:37:17 +01:00
Roeland Jago Douma 444159ddb0 Merge pull request #8664 from nextcloud/bugfix/noid/add-missing-settings-page-title-again
Set the correct active navigation entry
2018-03-05 19:35:00 +01:00
Roeland Jago Douma d8332d43f8 Make \OC\Security\IdentityProof strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-05 19:33:16 +01:00
Roeland Jago Douma 5457373407 Merge pull request #8659 from nextcloud/csrf_token_strict
Make \OC\Security\CSRF strict
2018-03-05 19:28:10 +01:00
Joas Schilling 4fa1d9628d Set the correct active navigation entry
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-05 17:06:28 +01:00
Morris Jobke f72e9ae8a6 Merge pull request #8650 from nextcloud/fix-ie11-datepicker-display
Fixed date/time picker on IE11
2018-03-05 16:37:56 +01:00
Morris Jobke 11057d5948 Merge pull request #8661 from nextcloud/strict_security_csp
Make OC\Security\CSP strict
2018-03-05 16:27:01 +01:00
Roeland Jago Douma d179186430 Remove testcase
Since a token now always requires a string we don't need to test for
null

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-05 16:14:46 +01:00
Joas Schilling 97c4c00e3f Better debugging for "Your test case is not allowed to access the database."
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-05 16:06:29 +01:00
Roeland Jago Douma 4ed9b74a6b Make OC\Security\CSP strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-05 15:27:05 +01:00
Roeland Jago Douma 2c8402aa17 Make \OC\Security\CSRF strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-05 15:01:02 +01:00
Arthur Schiwon 47a10bd25a treat iconv issues
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-03-05 14:03:08 +01:00
Arthur Schiwon 4f8c724318 typo + phpdoc
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-03-05 13:30:28 +01:00
Joas Schilling c85c64c787 Merge pull request #8630 from nextcloud/ldap-cachekey-sha256
use hash algo that's robust against collisions
2018-03-05 12:34:07 +01:00
Julius Härtl 723b8764d1 Add ETag to NavigationController
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-05 12:19:20 +01:00
Morris Jobke 3ced2c7ab2 Merge pull request #8601 from nextcloud/theming-fix-background-color
Remove too restrict check for background image/color
2018-03-05 11:28:41 +01:00
Morris Jobke a8f56ac8c7 Merge pull request #8603 from nextcloud/enc-cleanup
kill old encryption migration steps
2018-03-05 11:16:27 +01:00
Roeland Jago Douma 05ef2d70e7 Merge pull request #8590 from nextcloud/redirect-to-download-after-share
Sharing: redirect to download after authentification if requested
2018-03-05 11:11:43 +01:00
Morris Jobke 36d89a9223 Merge pull request #8614 from nextcloud/strict_mail
Make \OCP\Mail strict
2018-03-05 10:15:52 +01:00
Roeland Jago Douma f6fe04f3d7 Fix comments
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-05 09:06:51 +01:00
Roeland Jago Douma 0c500e460f Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-05 09:06:51 +01:00
Roeland Jago Douma 0cef938299 Make \OCP\Mail strict
* Fix typehints
* Made strict

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-05 09:06:51 +01:00
Nextcloud bot 6c49cc0294 [tx-robot] updated from transifex 2018-03-05 01:12:12 +00:00
John Molakvoæ (skjnldsv) c401a8cf26 Fixed loading state in apps nav menu
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-04 16:24:14 +01:00
John Molakvoæ (skjnldsv) e70570cbd7 Fixed appsmenu
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-04 16:10:45 +01:00
John Molakvoæ (skjnldsv) 7f712ae466 Fixed centering of the nav/picker popup
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-04 15:22:49 +01:00
John Molakvoæ (skjnldsv) 262ce3f19d App menu fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-04 14:12:29 +01:00
John Molakvoæ (skjnldsv) 72861f2dfb Use correct variables
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-04 14:12:29 +01:00
John Molakvoæ (skjnldsv) 15a3caedc0 Create special option to toggle header menu container
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-04 14:12:29 +01:00
John Molakvoæ (skjnldsv) 67699f9506 Clean scss, use proper loading icon and menu position on narrow screens
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-04 14:12:28 +01:00
John Molakvoæ (skjnldsv) c3016d3291 New standard for top right header
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-04 14:12:28 +01:00
Nextcloud bot 6975cef00b [tx-robot] updated from transifex 2018-03-04 01:12:42 +00:00
Nextcloud bot 3b000d4f91 [tx-robot] updated from transifex 2018-03-03 01:12:14 +00:00
Roeland Jago Douma 5053877c45 Merge pull request #8619 from coliff/patch-1
Use correct input type for the url entry
2018-03-02 21:26:36 +01:00
Arthur Schiwon 8607992e85 do not create empty userid when attribute does not have allowed chars
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-03-02 17:44:06 +01:00
Arthur Schiwon 04f7252fc4 use hash algo that's robust against collisions
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-03-02 16:26:36 +01:00
Björn Schießle 1953a11dfa Merge pull request #6805 from nextcloud/can-not-change-encryption-directory
Can not change encryption directory
2018-03-02 16:10:49 +01:00
Bjoern Schiessle 3a33683364 update unit tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-03-02 15:20:35 +01:00
Roeland Jago Douma ed239d72dc Merge pull request #8606 from nextcloud/strengthify-unification
Unify look of the strengthify password hint
2018-03-02 15:05:04 +01:00
Joas Schilling e05f338ff1 Add the users result only when non empty so tests stay the same
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-02 11:42:57 +01:00
Joas Schilling 158aac00a0 Merge pull request #8289 from nextcloud/appdata_hardening
AppData hardening
2018-03-02 11:26:36 +01:00
Morris Jobke 064cb5ebce Merge pull request #8612 from nextcloud/rakekniven-i18n-fix
Update commentstabview.js
2018-03-02 10:36:36 +01:00
Bjoern Schiessle 8042e6b8fb this was a migration step to ownCloud 8.0 to restructure the encryption folder which is no longer needed
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-03-02 10:09:52 +01:00
Christian Oliff d838789259 Use correct input type for the url entry
Change `type="text"` to `type="url"`
2018-03-02 16:49:56 +09:00
Nextcloud bot 777313db42 [tx-robot] updated from transifex 2018-03-02 01:12:16 +00:00
John Molakvoæ (skjnldsv) 31c7fcd004 Fixed date/time picker on IE11
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-01 21:44:01 +01:00
Roeland Jago Douma e8f9257ec9 Merge pull request #8605 from nextcloud/user-page-ellipsize
Ellipsize long values in the user management
2018-03-01 21:17:50 +01:00
rakekniven b348cd170a Update commentstabview.js
Changed typo reported at GitHub.
See https://www.transifex.com/nextcloud/nextcloud/translate/#de_DE/$/91002505?issue=yes
2018-03-01 20:53:50 +01:00
John Molakvoæ (skjnldsv) 4db556e784 fixup! Unify look of the strengthify password hint
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-01 20:39:56 +01:00
Roeland Jago Douma 7f736923d9 Merge pull request #8284 from nextcloud/lib_log-storage-test-failed
External storage test: log exceptions
2018-03-01 20:32:09 +01:00
Julius Härtl c820ee8779 Ellipsize long values in the user management
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-01 20:17:36 +01:00
Roeland Jago Douma d70a35b382 Merge pull request #8573 from nextcloud/appnav-ie11-fixes
Fixed app navigation for IE11
2018-03-01 20:13:51 +01:00
Roeland Jago Douma 6b931eb64b Merge pull request #8588 from nextcloud/fix-breadcrumbs-width-calculation
Fix breadcrumbs width calculation
2018-03-01 20:13:26 +01:00
Roeland Jago Douma e1e16510a8 Merge pull request #8587 from nextcloud/email-to-new-user-fix
Fixed email form on new user
2018-03-01 20:13:01 +01:00
Roeland Jago Douma effc00c940 Merge pull request #8585 from nextcloud/avatar-loading-disable-fix
Prevent double selection of avatar and loading fix
2018-03-01 20:12:25 +01:00
Bjoern Schiessle 9259b8a90e s/ownCloud/Nextcloud
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-03-01 17:49:53 +01:00
Bjoern Schiessle 31397debaf fix check and improve error message
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-03-01 17:49:20 +01:00
Joas Schilling 5080080a36 Anything but true means it failed
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-01 17:30:59 +01:00
John Molakvoæ (skjnldsv) 8d9c6f0e02 Unify look of the strengthify password hint
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-01 17:09:22 +01:00
Julius Härtl c521791653 Remove to restrict check for background image/color
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-01 14:39:31 +01:00
Sagorika Das 5d9d0b00e0 updated js
Signed-off-by: Sagorika Das <sagorika1996@gmail.com>
2018-03-01 18:20:37 +05:30
John Molakvoæ (skjnldsv) 3824e6f631 fixup! fixup! Sharing: redirect to download after authentification if requested
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-01 13:17:08 +01:00
John Molakvoæ (skjnldsv) 4c2aff0807 fixup! Sharing: redirect to download after authentification if requested
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-01 13:12:24 +01:00
John Molakvoæ (skjnldsv) 2d4896e2a7 fixup! Acceptance fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-01 12:57:00 +01:00
Sagorika Das d78e314d51 New folder creation flow
Descend into newly created folder by clicking enter again.
Signed-off-by: Sagorika Das <sagorika1996@gmail.com>
2018-03-01 17:19:07 +05:30
Joas Schilling 12420aef42 Also array_slice wide email matches of local users
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-01 12:18:44 +01:00
Joas Schilling 0f3ba9444e Merge pull request #8298 from nextcloud/bugfix/e2e-45/fix-activities-for-end2end-encryption
Fix activities for e2e encryption
2018-03-01 10:51:27 +01:00
John Molakvoæ (skjnldsv) 484568e995 Acceptance fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-01 10:45:56 +01:00
Morris Jobke 6b4a2d01c3 Merge pull request #8574 from nextcloud/breadcrumb-flash-fix
Fixed breadcrumb menu flashing
2018-03-01 09:39:29 +01:00
Morris Jobke 560c0ef783 Merge pull request #8582 from nextcloud/icon-for-desktop-client
Show icon in security settings for desktop clients
2018-03-01 07:19:11 +01:00
Nextcloud bot a7fb9ff8da [tx-robot] updated from transifex 2018-03-01 01:12:11 +00:00
Roeland Jago Douma fb322322fc Merge pull request #8581 from callahad/fix-8578
Correct mistaken regex wildcard in .htaccess
2018-02-28 22:36:14 +01:00
Roeland Jago Douma faca634606 Merge pull request #8589 from nextcloud/fix-upload-button-visible-on-read-only-folders
Fix upload button visible on read-only folders
2018-02-28 22:31:21 +01:00
Julien Veyssier 7da0812186 Do not throw AppNotEnabledException for app public pages - refs #6962, refs #5309
It allows non-logged user to access public pages of applications restricted to a group

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2018-02-28 20:35:53 +01:00
John Molakvoæ (skjnldsv) 7bcc821642 fixup! Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 19:03:00 +01:00
John Molakvoæ (skjnldsv) 8c69d783e0 Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 17:35:42 +01:00
Daniel Calviño Sánchez 542dc2b335 Fix upload button visible on read-only folders
The div that contains the elements related to the creation of new files,
and thus the upload button, is always present in the DOM; it is hidden
or shown based on the folder permissions by adding or removing the
"hidden" CSS class. However, as the other CSS classes for the div are
"actions" and "creatable" and a "display: flex" rule was defined for
".actions.creatable" below the "display: none" rule for
".actions.hidden" the last one took precedence and the div ended being
always visible, even if the "hidden" CSS class was set. Now the rules
for the ".actions.hidden" selector are defined below the rules for the
".actions.creatable" selector and thus the "display: none" rule is
applied as expected.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 17:26:36 +01:00
John Molakvoæ (skjnldsv) a0641e43dc fixup! Sharing: redirect to download after authentification if requested
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 17:08:25 +01:00
John Molakvoæ (skjnldsv) fb890807c0 Sharing: redirect to download after authentification if requested
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 17:05:55 +01:00
John Molakvoæ (skjnldsv) aa0190dff1 Fixed email form on new user
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 16:28:40 +01:00
John Molakvoæ (skjnldsv) d9e936e9f8 Prevent double selection of avatar and loading fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 16:08:22 +01:00
Joas Schilling 8b73560cac Fix unit test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 16:04:45 +01:00
Joas Schilling 0b883ab9d9 Catch exception when the parent is deleted as well
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 15:40:01 +01:00
Joas Schilling 825c276e84 Do a recursion instead of an endless loop
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 15:16:18 +01:00
Joas Schilling 62e982a91f Fix problem with deleted files
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 15:06:06 +01:00
Joas Schilling d202bae3b5 Fix path handling for activities
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 15:06:06 +01:00
Joas Schilling f8c27cb57d Add special handling for e2e encryption
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 15:06:06 +01:00
Joas Schilling 03a25410f1 Extract duplicated logic into a method
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 15:06:05 +01:00
Daniel Calviño Sánchez ad71abca6f Update comments in tests
Menu and home are not always visible; home is always visible, but menu
is shown only when needed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez 292476911f Improve documentation of "getTotalWidth"
"getTotalWidth" is not more accurate; it is simply not clamped.
Moreover, "width/outerWidth" could be used in tests too, and also even
if "getTotalWidth" could be used in tests while others not that would
not be something to be stated in the API documentation, but in a
comment.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez d122d054d3 Do not show the crumbs again after hiding them
After the changes in the previous commit "_showCrumb" no longer shows
the menu, only the same crumb that was hidden by the last call to
"_hideCrumb". Therefore, if the crumb was hidden because it did not fit
there is no need to try to show it again, as it will still not fit.

Moreover, the calculated width for a hidden element is not always
accurate; in some cases the calculated width is lower than the actual
width (it happens, for example, when using a background image like the
"Share" icon), which causea the crumb to be shown even if there is not
enough room, which in the end causes the siblings to overflow the
contents.

No unit tests for this one, though; you will have to trust me on this,
sorry ;-)

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez 10e9eeec45 Fix menu visibility
The crumb for the menu was shown like any other crumb when calling
"_showCrumb", but it was also shown when other crumbs were hidden
without taking into account the available width. This caused several
related problems, like the breadcrumbs taking too much space when the
menu was sometimes shown after the rest of the crumbs were adjusted to
the available width, or the menu being shown instead of the last crumb
even if there was room for it when the available width was increased.

Now the menu is always hidden before starting the resizing of the crumbs
to ensure that whether it was previously shown or not does not affect
the result. In a similar way, the menu will no longer be shown by
"_showCrumb", as it is not a regular crumb that has to be shown simply
if there is enough room. The menu is now shown as soon as any other
crumb is hidden; this ensures that the menu width will be taken into
account in further width checks. As when _updateMenu" is called it no
longer needs to take care of showing the menu this fixes the issue
revealed when fixing the test setup in the previous commit.

Finally, this implicitly fixes the failure in the breadcrumbs tests when
run on Firefox, as it was caused by the menu interfering in the
calculations of the other crumbs when increasing the width.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez 1bcba56d8f Fix setup to test the breadcrumbs menu
The "Shows only items not in the breadcrumb" test was failing when run
on Firefox, but not on PhantomJS. This was caused by the differences in
the starting width between both browsers and an incorrect setup of the
test (the width set for the crumbs was overriden when the breadcrumbs
were rendered again, and the breadcrumb was resized to 300 from an
indeterminate initial width).

Now the crumbs are rendered and then its width, padding and margin are
set to a known value. Then it is resized to 1000px, which ensures that
there will be enough room for all the crumbs and thus the menu will be
hidden, and finally it is resized to 300, which causes the middle crumb
to be hidden and the menu to be shown.

Note, however, that the test now always fails, no matter if it is run on
PhantomJS or on Firefox; if the menu crumb is hidden when "_updateMenu"
is called it will show it, but it will also wrongly try to add the menu
itself to the menu. As the "crumb-id" of the menu crumb is "-1" this
causes the last regular crumb to be added to the menu. This will be
fixed with other related issues in the next commit.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez 92345f2c38 Take padding and margins of crumbs into account
When calculating the total width of the crumbs only its padding was
taken into account; now the margin is too. In a similar way, before
showing a crumb only its width was taken into account; now its padding
and margin are taken into account too.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez 29c924f74b Use hard-coded values for paddings and margins
This ensures that the resize tests do not depend on the values set in
the CSS files.

Note that this change causes a test to fail with Firefox, but not with
PhantomJS. This is due to a difference in the starting width used by
Firefox and by PhantomJS, and it will be fixed in a following commit.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez acdf091f84 Compress siblings before calculating the available width for crumbs
When the parent element of the breadcrumbs was resized to a larger width
and the siblings of the breadcrumbs expanded to fill all the available
width some crumbs could be hidden even if there was enough room for
them. The reason was that the width of the siblings being used to
calculate the available width for the breadcrumbs was the expanded width
of the siblings. Now as many crumbs as possible (that is, fitting in the
parent, no matter the siblings) are first shown so the expanding
siblings are compressed before calculating the available width.

Due to the lack of support for flexboxes in PhantomJS the related unit
test is skipped; it has to be run in other browser, like Firefox.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez a37007f872 Take all visible siblings into account
Other apps could add elements to the controls outside the creatable
actions div (for example, the button to switch to the gallery), so the
widths of all the visible siblings of the breadcrumbs have to be taken
into account in the size calculations.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez e37c4fd7f3 Take padding and margin of the creatable actions div into account
There are some differences in width handling between the browsers used
to run the tests, most likely due to their support (or lack of) of
certain CSS features: PhantomJS requires "width" to be set (probably
because it does not handle flex displays and treats it like a block, so
"min-width" does not matter in this case), while Firefox requires
"min-width" to be set (otherwise the children of "#controls" could be
compressed due to its use of flex display and the elements would end
with a different width than the one needed for the tests). Due to all
that the width of the breadcrumb siblings must be specified in the tests
using both "width" and "min-width".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez 3850221ae1 Do not render the breadcrumbs again in resize tests
There is no need to call "setDirectory" again in resize tests; it is
enough to simply resize them (and isolates them better to just test the
resizing behaviour).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez a828e7b12a Replace attribute with local variable
The "usedWidth" attribute was not used elsewhere outside the "_resize"
method, so it was replaced with a local variable. Moreover, it was also
renamed to a more suitable name ("availableWidth").

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
Daniel Calviño Sánchez a9552de089 Set the width of the parent element in breadcrumb tests
Setting the width of the parent element of the breadcrumbs and then
explicitly calling "_resize" is enough to test the resizing behaviour.
This makes possible to remove the "setMaxWidth" method and its related
code, which was used only for testing purposes.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
Dan Callahan 8797590099 Correct mistaken regex wildcard in .htaccess
Fixes #8578

Signed-off-by: Dan Callahan <dan.callahan@gmail.com>
2018-02-28 13:50:54 +00:00
Morris Jobke 23f35027d5 Show icon in security settings for desktop clients
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-28 14:32:42 +01:00
Joas Schilling bb58d12bca Check for app updates when there is a new major version available
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 14:27:35 +01:00
Morris Jobke 0cfdf4748f Merge pull request #8576 from nextcloud/mail_share_password_autocomplete
Set autocomplete=new-password for mail share password
2018-02-28 14:17:03 +01:00
Roeland Jago Douma 0e0d852b89 Merge pull request #8566 from nextcloud/provisioning_strict
Make the provisioning api app strict
2018-02-28 14:09:34 +01:00
Roeland Jago Douma ad7ddbc068 Set autocomplete=new-password for mail share password
This avoids the browser to do autocompletion on the mail share password
field.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-28 13:47:06 +01:00
Roeland Jago Douma 4b05f03c34 Merge pull request #8569 from nextcloud/cleanup_unused_static_sharing
Remove unused static sharing helper code
2018-02-28 13:09:06 +01:00
Roeland Jago Douma 926419e15c Merge pull request #7600 from nextcloud/new-user-button-to-sidebar
New user button to sidebar
2018-02-28 12:33:30 +01:00
Joas Schilling 9ae3a5fe2f Ignore dev files
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 11:32:39 +01:00
Joas Schilling 029e8cdc5b Also allow to specify the cache file name
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 11:31:33 +01:00
John Molakvoæ (skjnldsv) 35144a72ad fixup! Sticky header in users list
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 11:17:39 +01:00
John Molakvoæ (skjnldsv) 0bac32a410 Sticky header in users list
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 11:17:39 +01:00
John Molakvoæ (skjnldsv) 907234fde2 Fix acceptance tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 11:17:39 +01:00
John Molakvoæ (skjnldsv) d78026c3b4 Fixed breadcrumb menu flashing
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 11:04:27 +01:00
John Molakvoæ (skjnldsv) 958463e1c7 fixup! Fixed app navigation for IE11
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 10:26:36 +01:00
John Molakvoæ (skjnldsv) 615f3b497d Fixed app navigation for IE11
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 10:11:10 +01:00
Nextcloud bot 533e8351ad [tx-robot] updated from transifex 2018-02-28 01:12:31 +00:00
Roeland Jago Douma 7e8c84ec20 Remove unused static sharing helper code
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-27 22:40:59 +01:00
Roeland Jago Douma b369abc378 Merge pull request #8565 from nextcloud/bugfix/fat-48/make-outlook-and-thunderbird-addons-identifyable
Make the Outlook and Thunderbird addons identifyable
2018-02-27 22:27:26 +01:00
Roeland Jago Douma fbeaacdf1b Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-27 22:03:40 +01:00
Morris Jobke 77927442a6 Merge pull request #8496 from nextcloud/ext-strg-design-fixes
External storage design fixes and update
2018-02-27 15:59:06 +01:00
Roeland Jago Douma 24b58a7683 Make the provisioning api app strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-27 15:47:59 +01:00
Joas Schilling f81d4eb060 Make the Outlook and Thunderbird addons identifyable
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-27 14:37:32 +01:00
Morris Jobke 640db3d5fe Merge pull request #8219 from nextcloud/fix-overwrite-url-on-cli-install
Fix proper overwrite URL on CLI install
2018-02-27 13:49:39 +01:00
Morris Jobke 7bc3c2e057 Merge pull request #7363 from nextcloud/default-share-perms
Let the admin configure the default share permissions
2018-02-27 13:44:34 +01:00
Roeland Jago Douma 8b5997483c Hardening of SimpleFile getContent
if file_get_contents fails remove the file. And traverse up the tree
checking if the other folders are there.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-27 13:35:09 +01:00
Roeland Jago Douma 01f420c7ac Merge pull request #8051 from nextcloud/public-template
Public page template response
2018-02-27 13:33:19 +01:00
John Molakvoæ (skjnldsv) 5f217e2d83 fixup! Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 13:25:42 +01:00
Roeland Jago Douma 017e1325f1 Merge pull request #8285 from nextcloud/apps_files-smb-catch-exceptions-on-listing
Make SMB module more fault-tolerant
2018-02-27 13:10:54 +01:00
John Molakvoæ (skjnldsv) 8af3b5d377 Primary to confirm button
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 13:10:12 +01:00
John Molakvoæ (skjnldsv) 6ee9a2b35b fixup! Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 13:05:39 +01:00
John Molakvoæ (skjnldsv) 042617b707 Unify input looks
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 12:50:18 +01:00
John Molakvoæ (skjnldsv) bb5d4c8c21 Changed button types and do not hide form on outside click
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 12:50:18 +01:00
John Molakvoæ (skjnldsv) 7f6b27aef7 New user form in table
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Added value and empty check to properly display a confirm button/input

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

w3c html form table compliance and menu fixes

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Various design fixes

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Fix wording to consistent 'Add user'

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Focus new username input on toggle

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Removed  unwanted th after rebase

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

quote fix

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Th to td

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

🙈

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Email input to email type

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Fixed table template cells and fix email input enabling

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Always show email and fixed min-width of name, username, mail and fullname columns

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Use button id

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 12:50:18 +01:00
John Molakvoæ (skjnldsv) 2f1aa25130 New button standard
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

USer menu in popover

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Multiselect fixes

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Register menu & copyright

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Allow form and label in popover standard

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

New menu NOT in popover

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Stop autofilling user and password...
SHAME TO THEM: https://bugzilla.mozilla.org/show_bug.cgi?id=956906#c100

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Hide men by default

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 12:50:18 +01:00
Morris Jobke 20ec0344a2 Fix JSDoc
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-27 12:29:25 +01:00
Vincent Petry 7466468af1 Fix share capabilities JS tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-02-27 12:29:25 +01:00
Bjoern Schiessle 3285becdc1 fix unit tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-02-27 12:29:25 +01:00
Bjoern Schiessle ebb15283a6 share api: use default permission of no permission is given
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-02-27 12:29:25 +01:00
Bjoern Schiessle 7741429229 improved layout of the admin settings
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-02-27 12:29:25 +01:00
Bjoern Schiessle 1615312bf1 add share permissions to settings page
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-02-27 12:29:25 +01:00
Bjoern Schiessle 7d0102bf73 expose capabilities in js
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-02-27 12:29:25 +01:00
John Molakvoæ (skjnldsv) f1634cd3e2 fixup! Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 12:27:25 +01:00
Julius Härtl 36563d4a4b Remove setters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:53 +01:00
Julius Härtl 9cf49873fa Rework array handling to avoid phan error
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:53 +01:00
Julius Härtl 2b6c00fc0f Add id to list element
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:53 +01:00
Julius Härtl fd830b90eb Fix acceptance test for new menu structure
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:53 +01:00
Julius Härtl 5a4aa2b7dd Add test for PublicTemplateResponse
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:53 +01:00
Julius Härtl 7cd0340366 Sort menu by priority
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:53 +01:00
Julius Härtl 4a1cbefc90 Fix files_sharing tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:53 +01:00
Julius Härtl 038aad73c7 Add missing phpdoc for public API
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:53 +01:00
Julius Härtl 4f83462f67 Add phpdoc, typehints and sanitize HTML
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:52 +01:00
Julius Härtl faeb277ece Fix popovermenu
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:52 +01:00
Julius Härtl 8a13851da8 Use PublicTemplateResponse for files_sharing
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:52 +01:00
Julius Härtl e5df804834 Expose parameters as variables to templates
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:52 +01:00
Julius Härtl 2fcadf4606 update autoloader
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:52 +01:00
Julius Härtl 4f78980fad Add menu item abstraction
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:52 +01:00
Julius Härtl b89827d761 Enable renderAs public page
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:52 +01:00
Julius Härtl d07d66e24b Add public template
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:52 +01:00
Julius Härtl 0655df09d6 Pass template parameters to parent template
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:52 +01:00
John Molakvoæ (skjnldsv) 324e96b780 Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 12:11:36 +01:00
John Molakvoæ (skjnldsv) 6b45d7e549 Fixed actions and header missing th
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 11:35:11 +01:00
Morris Jobke 048ad0df1d Merge pull request #8475 from sagorika1996/theme
Empty name not allowed in theming app
2018-02-27 11:30:59 +01:00
Morris Jobke 7081bdbea6 Merge pull request #8553 from nextcloud/strict_logger
Make ILogger strict
2018-02-27 11:20:06 +01:00
Sagorika Das 7394e8ae58 Empty name not allowed
Do not allow empty name in theming app.

Signed-off-by: Sagorika Das <sagorika1996@gmail.com>
2018-02-27 10:54:21 +01:00
Morris Jobke 8d8b22e294 Merge pull request #8552 from nextcloud/strict_session
Make ISession strict
2018-02-27 10:52:55 +01:00
Roeland Jago Douma d0a6368a8b Merge pull request #8557 from nextcloud/fix-theming-defaults
Fix check if theming defaults instance is available
2018-02-27 10:49:02 +01:00
Roeland Jago Douma 6994bce951 Loglevel is an int
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-27 10:45:35 +01:00
Roeland Jago Douma 83eb548d23 Typehint Throwable
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-27 10:43:34 +01:00
Roeland Jago Douma 4077f16aec Make ILogger strict
* Make implementations strict
* Add scalar typehints

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-27 10:41:46 +01:00
Morris Jobke e2cd33adfe Fix check if theming defaults instance is available
The check in URLGenerator.php#169 and Server.php#945 are different and thus the DI container could return a \OC_Defaults object which does not provide the wanted method caising a PHP error.

Fixes #8420

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-27 10:15:31 +01:00
Roeland Jago Douma cd3eb80ef4 Merge pull request #8548 from BernieO/patch-1
fix: change 'sqlite' to 'sqlite3'
2018-02-27 08:59:25 +01:00
Nextcloud bot ad2eefe896 [tx-robot] updated from transifex 2018-02-27 01:14:26 +00:00
Roeland Jago Douma 8cb6bb3987 Make ISession strict
* Make all implementations strict
* Add scalar types

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-26 22:20:21 +01:00
Roeland Jago Douma 350b66b73d Merge pull request #8485 from sagorika1996/rename
Rename dialog closed when not active
2018-02-26 21:36:39 +01:00
Joas Schilling abb0a08ed5 Merge pull request #7933 from nextcloud/update-notification-vuejs
Migrate Update notifications to Vue.js
2018-02-26 18:55:08 +01:00
BernieO 7b8ff8d858 fix: change 'sqlite' to 'sqlite3'
@MorrisJobke asked me to open this pull request in the server repo instead of the documentation repo:
https://github.com/nextcloud/documentation/pull/690

Text from the documentation pull request:
On a fresh Nextcloud 13 Installation the default value for dbtype in config.php is 'sqlite3' (and not 'sqlite'). I also noticed that on previous versions.
Despite the fact that Nextcloud 13 also works though, if that value is manually changed to 'sqlite', I would suggest to change that in the documentation to the actually used value created when installing Nextcloud - and that is 'sqlite3'.
2018-02-26 18:42:27 +01:00
Morris Jobke 8867629cf1 Merge pull request #8359 from nextcloud/swift-v3
Support swift v3 authentication
2018-02-26 18:30:00 +01:00
Morris Jobke 4076c09195 Merge pull request #8463 from kyrofa/bugfix/8462/theming_app_outside_root
theming: handle not being in the serverroot
2018-02-26 18:27:54 +01:00
Morris Jobke a60d7a8563 Merge pull request #8541 from nextcloud/translate-permission-error-page
Provide translated error message for permission error
2018-02-26 17:50:21 +01:00
Morris Jobke 67a76b00e8 Merge pull request #6481 from nextcloud/occ-app-install-enable
add enable flag to occ app:install
2018-02-26 17:49:37 +01:00
Morris Jobke 955e136fd9 Fix appname
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-26 17:47:42 +01:00
Morris Jobke 950e7e0467 Merge pull request #8455 from nextcloud/proper_mount_type_external
Properly set the mount type for external storages
2018-02-26 17:19:54 +01:00
Morris Jobke 612e875f60 Merge pull request #8355 from nextcloud/fix-comments-num-index
Fix comments (and systemtags) when involving users with numerical ids
2018-02-26 17:12:57 +01:00
Morris Jobke cf35c4b03a Provide translated error message for permission error
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-26 17:00:29 +01:00
sualko 84f6477ce5 enable app by default after occ app:install
Signed-off-by: Klaus Herberth <klaus@jsxc.org>
2018-02-26 16:34:52 +01:00
sualko 323eb2e8ba add enable flag to occ app:install (fix #5834)
Signed-off-by: Klaus Herberth <klaus@jsxc.org>
2018-02-26 16:34:52 +01:00
Morris Jobke 4154a56536 Merge pull request #8412 from agates/master
Add mtime and storage_mtime to db:convert-filecache-bigint
2018-02-26 16:33:58 +01:00
Morris Jobke 452e96e2a7 Merge pull request #8390 from dasisdormax/master
Add indeterminate state to share permission checkbox
2018-02-26 16:17:35 +01:00
Morris Jobke a3c09f51c6 Merge pull request #8203 from Cybso/split-move-copy
Split move and copy operations
2018-02-26 16:06:20 +01:00
Morris Jobke 07a6821ab2 Merge pull request #8511 from nextcloud/ext-storage-error-warning-fix
Ext storage error warning fix
2018-02-26 15:36:46 +01:00
Robin Appelman d40c61a71a adjust external storage config format to the one used in primary storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-26 14:54:30 +01:00
Roeland Jago Douma 3afc41a49b Kill objectstore CI if we can't create a file
This is more of a hack. But one of the nodes won't properly run this. No
sense in waiting 60 minutes

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-26 14:54:27 +01:00
Roeland Jago Douma ae720b3881 Some swift v3 example config
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-26 14:54:24 +01:00
Roeland Jago Douma 9a201bd7fa Use username + pass in config
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-26 14:54:21 +01:00
Roeland Jago Douma 812ea354d0 User proper username + pass
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-26 14:54:18 +01:00
Roeland Jago Douma fe05ecfd16 Other config
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-26 14:54:15 +01:00
Roeland Jago Douma 4bcc282a48 Add v3.0 auth run
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-26 14:54:12 +01:00
Robin Appelman 31dd6d6aae add support for v3 swift auth
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-26 14:54:08 +01:00
Robin Appelman 4d380d21b5 Merge pull request #8539 from nextcloud/openstack-304
update php-opencloud/openstack to 3.0.4
2018-02-26 14:52:12 +01:00
Robin Appelman 205a18f018 update php-opencloud/openstack to 3.0.4
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-26 14:35:07 +01:00
Roeland Jago Douma 0c4c3676f6 Merge pull request #8504 from nextcloud/bugfix/noid/well-its-not-an-array
Dont use $info as array when its not an array
2018-02-26 13:44:57 +01:00
Joas Schilling 226e63695f Merge pull request #8026 from nextcloud/feature/noid/allow-custom-html-in-html-emails
Allow custom HTML in HTML Emails
2018-02-26 13:38:39 +01:00
John Molakvoæ (skjnldsv) 0f229d23f7 fixup! Fixed icons padding
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-26 13:03:44 +01:00
John Molakvoæ (skjnldsv) da2aafa5cf Fixed icons padding
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-26 13:02:07 +01:00
Joas Schilling 695e32d0a6 Merge pull request #8491 from nextcloud/strict_request
Make Request strict
2018-02-26 11:02:30 +01:00
Morris Jobke 2f12094ea8 Merge pull request #8522 from nextcloud/fix-groupmembers-numids
Fix retrieval of group members with numerical uids from LDAP
2018-02-26 09:01:38 +01:00
Kyle Fazzari 8dcbea124e Remove null check
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
2018-02-25 07:08:59 -08:00
Kyle Fazzari 25c89a6feb Add mock to setup
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
2018-02-24 08:16:42 -08:00
Roeland Jago Douma 7144d7a1e3 Merge pull request #8497 from nextcloud/relax_l10n
Relax what t accepts so we don't break it all
2018-02-24 16:26:36 +01:00
Nextcloud bot a210247559 [tx-robot] updated from transifex 2018-02-24 01:12:16 +00:00
Morris Jobke cf959af8eb Merge pull request #8519 from nextcloud/fix-l10n-exception
Use array in t() calls in exception template
2018-02-23 13:08:26 +01:00
John Molakvoæ (skjnldsv) fdfa934078 Updated error message
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-23 12:13:10 +01:00
Arthur Schiwon 238c3a5201 fix retrieving group members with numerical uids from LDAP
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-23 12:05:50 +01:00
Arthur Schiwon 72af741e78 tests for retrieving group members with numerical uids
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-23 12:04:48 +01:00
Julius Härtl 74325f1f94 Use array in t() calls in exception template
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-23 11:18:29 +01:00
Morris Jobke e01e1696da Merge pull request #8507 from nextcloud/fix-change-icon
Add some whitespace around change.svg icon
2018-02-23 10:36:32 +01:00
Morris Jobke 98baf8915d Merge pull request #8502 from nextcloud/properly-show-hints-in-ocs
Show hint in OCS API for user creation
2018-02-23 10:02:31 +01:00
Joas Schilling 69c88ad075 Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-23 09:06:43 +01:00
Nextcloud bot 68187e6036 [tx-robot] updated from transifex 2018-02-23 01:12:16 +00:00
Morris Jobke 930aad5aaa Merge pull request #8499 from nextcloud/avoid-fruitless-login-attempts
Avoid fruitless login attempts
2018-02-22 19:19:40 +01:00
John Molakvoæ (skjnldsv) 4a429cc810 Fixed default urls
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 18:17:42 +01:00
John Molakvoæ (skjnldsv) 887241b355 Show error if no external storage configured
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 18:14:19 +01:00
John Molakvoæ (skjnldsv) 47af421e80 fixup! Add vselect theming into server
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 17:03:35 +01:00
John Molakvoæ (skjnldsv) 5c3672ae36 Add vselect theming into server
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 17:00:00 +01:00
Marin Treselj 83227b6a61 Update the change.svg icon in the Settings app
Signed-off-by: Marin Treselj <marin@pixelipo.com>
2018-02-22 16:02:50 +01:00
blizzz 627023e9c3 Merge pull request #8416 from nextcloud/bugfix/8401/usermanagement-popover
Fix hiding and event propagation issues with the user management popover
2018-02-22 15:57:43 +01:00
Roeland Jago Douma 043a824e6a Fix comments
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-22 15:51:19 +01:00
Roeland Jago Douma 6335c6c5ec Fix dav server test
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-22 15:51:19 +01:00
Roeland Jago Douma 0ee45d3d20 Fix proper types
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-22 15:51:19 +01:00
Roeland Jago Douma a229095af1 Make Request strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-22 15:51:19 +01:00
Marin Treselj dc6ae9e622 Add some whitespace around change.svg icon
Signed-off-by: Marin Treselj <marin@pixelipo.com>
2018-02-22 15:46:21 +01:00
John Molakvoæ (skjnldsv) dab83c4a49 Select in popover fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:37 +01:00
John Molakvoæ (skjnldsv) 323dd31056 Tooltip fix on status icon
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:37 +01:00
John Molakvoæ (skjnldsv) 1f3eef9460 fixup! Changed config saving feedback design
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:34 +01:00
John Molakvoæ (skjnldsv) 884605ac18 Better label styling
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:32 +01:00
John Molakvoæ (skjnldsv) 0cc520f3a0 Changed config saving feedback design
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:32 +01:00
John Molakvoæ (skjnldsv) 3d2b3a1309 fixup! Use popovermenu instead of dropdown and small fix to popovermenu
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:22 +01:00
Morris Jobke 3c30f29179 Merge pull request #8495 from nextcloud/fix-ldap-settings-l10nt
2nd parameter to t() must be array
2018-02-22 15:02:25 +01:00
Joas Schilling 1aa846107d Dont use $info as array when its not an array
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 14:43:56 +01:00
Morris Jobke 9aaf1c2a06 Show hint in OCS API for user creation
* adds a 107 error code together with the hint of the exception
* logs the exception as warning
* fixes #7946

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-22 14:16:49 +01:00
Arthur Schiwon ffc05e2fed don't try login with the same name that just failed
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-22 13:05:48 +01:00
Arthur Schiwon 9bc75307e7 track the state of the bind result
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-22 13:05:33 +01:00
Roeland Jago Douma a423860f42 Relax what t accepts so we don't break it all
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-22 12:37:29 +01:00
John Molakvoæ (skjnldsv) 1e2a082cd2 Use popovermenu instead of dropdown and small fix to popovermenu
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 12:15:32 +01:00
Arthur Schiwon 49ec5ff4e4 2nd parameter to t() must be array
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-22 12:10:30 +01:00
Joas Schilling 96e9173b73 Ignore the map file too
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 10:24:42 +01:00
Joas Schilling 6340e78be8 Use mixin for translations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 10:19:55 +01:00
Joas Schilling 59c007bedd Use VueSelect instead of select2
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 10:17:42 +01:00
Joas Schilling 308c7db333 Move updatenotifications to webpack with .vue file
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 10:17:42 +01:00
Joas Schilling b12b391d7c Migrate the app to Vue.js
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 10:17:41 +01:00
Joas Schilling 52f8d75d1a Rename legacy notification so it's less confusing
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 10:17:41 +01:00
Roeland Jago Douma c2c2c06546 Merge pull request #8476 from nextcloud/strict_l10n
Make OCP\IL10N strict
2018-02-22 10:03:18 +01:00
Roeland Jago Douma e1bdeb786e Merge pull request #8472 from nextcloud/strict_integritycheck
Make OC\IntegrityCheck strict
2018-02-22 10:01:50 +01:00
Roeland Jago Douma a660946ac6 Merge pull request #8490 from nextcloud/strict_systemtags
Make SystemTag strict
2018-02-22 10:01:20 +01:00
Nextcloud bot 4b352a345b [tx-robot] updated from transifex 2018-02-22 01:12:26 +00:00
Roeland Jago Douma fb41a93a95 Merge pull request #8473 from nextcloud/strict_cmr
Strict OCP\AppFramework\Utility\IControllerMethodReflector
2018-02-21 22:56:40 +01:00
Roeland Jago Douma 096ea2c390 Properly cast
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 22:45:28 +01:00
Roeland Jago Douma 8e5657014d Make SystemTag strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 22:08:27 +01:00
Roeland Jago Douma 72e745be26 Handle strict typing in Checker and fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 21:09:08 +01:00
Roeland Jago Douma 4859775893 Don't try to match on false
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 20:38:14 +01:00
Roeland Jago Douma cacfe3a360 Fix more templates
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 20:30:44 +01:00
Roeland Jago Douma aa060f5332 Strict OCP\AppFramework\Utility\IControllerMethodReflector
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 19:55:49 +01:00
Roeland Jago Douma 8b17f0d224 Fix other tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 19:53:44 +01:00
Roeland Jago Douma 2b0d640225 Proper closure for function
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 19:46:29 +01:00
Sagorika Das dca75448d0 rename dialog closed when not active
Signed-off-by: Sagorika Das <sagorika1996@gmail.com>
2018-02-21 23:16:27 +05:30
Morris Jobke f01754a389 Merge pull request #8474 from nextcloud/bugfix/ciu-12/log-exceptions-that-happen-when-writing-to-storage
Log exceptions that happen when writing the app store reply to storage
2018-02-21 15:21:31 +01:00
Morris Jobke 3e6e292ada Merge pull request #8456 from nextcloud/bugfix/noid/phpunit-can-now-handle-directories-too
Use phpunit's directory feature
2018-02-21 15:14:49 +01:00
Roeland Jago Douma 541056f6c2 Make OCP\IL10N strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 14:32:04 +01:00
Joas Schilling 2c840ca278 Log exceptions that happen when writing the app store reply to storage
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-21 14:14:33 +01:00
Roeland Jago Douma 4b50fe7560 Merge pull request #8466 from nextcloud/strict_middlewaredipatcher
Make the middlewareDispatcher strict
2018-02-21 13:57:04 +01:00
Roeland Jago Douma 5825c27a12 Make sure that render always returns a string
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 13:28:40 +01:00
Roeland Jago Douma 8b44c16ddc Merge pull request #8471 from nextcloud/fix_upgrade
getIncompatibleApps needs a string not an array
2018-02-21 13:28:10 +01:00
Roeland Jago Douma 4d5f2e64a5 Make OC\IntegrityCheck strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 13:27:29 +01:00
Roeland Jago Douma 4a41e0cc42 getIncompatibleApps needs a string not an array
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 13:00:41 +01:00
Roeland Jago Douma 7c6cc013eb Merge pull request #8468 from nextcloud/fix-unicode-avatars
Use mb_* string methods to extract first character for generated avatars
2018-02-21 11:08:33 +01:00
Roeland Jago Douma ca9f364fd4 Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 10:55:52 +01:00
Roeland Jago Douma a773b055fc Make the middlewareDispatcher strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 10:55:24 +01:00
Morris Jobke 09857e5a95 Merge pull request #8465 from nextcloud/strict_dispatcher
Make AppFramework/Http/Dispatcher strict
2018-02-21 10:48:06 +01:00
Morris Jobke 3bea8e05ad Use mb_* string methods to extract first character for generated avatars
This fixes #8451 where the first character is a non-ASCII character. The `$string[0]` notation only extracted one byte and thus resulting in an invalid code. The `mb_strtoupper` method also allows to convert characters independently from the current locale on the server.

See also http://php.net/manual/en/function.mb-strtoupper.php

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-21 10:32:46 +01:00
Roeland Jago Douma bb0c7b2943 Make AppFramework/Http/Dispatcher strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 08:51:46 +01:00
Kyle Fazzari a1f1824116 theming: handle not being in the serverroot
Currently, the theming app assumes it's in the serverroot. However, with
Nextcloud's flexibility regarding configurable app paths, this is not a
safe assumption to make. If it happens to be an incorrect assumption,
the theming app fails to work.

Instead of relying on the serverroot, just use the path from the
AppManager and utilize relative paths for assets from there.

Fix #8462

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
2018-02-20 22:45:10 -08:00
Nextcloud bot 6591a3bc36 [tx-robot] updated from transifex 2018-02-21 01:12:10 +00:00
blizzz 8e5120ce66 Merge pull request #8206 from nextcloud/bugfix/noid/fix-collaboration-result-size
Better result handling of email search
2018-02-20 23:02:53 +01:00
Joas Schilling 13e04bc7d4 Use phpunit's directory feature
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-20 17:40:09 +01:00
Joas Schilling b30e035e25 Better result handling of email search
1. Local users should not be returned when searching for empty string
2. The limit of the response should be respected

Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-20 17:38:32 +01:00
Roeland Jago Douma 30017e3364 Properly set the mount type for external storages
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-20 15:51:12 +01:00
Roeland Jago Douma cf83eb5e77 Merge pull request #8336 from nextcloud/cleanup-unused-parameter
Cleanup unused parameter
2018-02-20 10:16:59 +01:00
Nextcloud bot c48332a14f [tx-robot] updated from transifex 2018-02-20 01:11:55 +00:00
Roeland Jago Douma 980c78048b Merge pull request #8314 from nextcloud/openstack
update openstack sdk
2018-02-19 22:22:55 +01:00
Roeland Jago Douma 26a741fd36 Merge pull request #8428 from nextcloud/fix_8189
Use TTF fonts for avatar generation
2018-02-19 22:12:05 +01:00
Roeland Jago Douma 1541af432e Use a proper wait for create of the container
* Also create a test file so we know for sure it all works

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-19 21:49:38 +01:00
Robin Appelman 2a9b3b31aa use more precise method for waiting for swift
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-19 19:41:16 +01:00
Robin Appelman a80f72c6c8 fix controller test
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-19 19:41:16 +01:00
Robin Appelman 817f2f8f49 adjust swift external storage to new openstack sdk
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-19 19:41:16 +01:00
Robin Appelman 3192efc415 adjust swift object storage to new openstack sdk
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-19 19:41:16 +01:00
Robin Appelman 2abfe3347e switch from rackspace/php-opencloud to php-opencloud/openstack
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-19 19:41:16 +01:00
Roeland Jago Douma 7ad1e13961 Merge pull request #8158 from nextcloud/s3-minio
Use a more widely available method to test s3 settings
2018-02-19 17:09:36 +01:00
Roeland Jago Douma 4e6d98ea8c Merge pull request #8424 from nextcloud/fix/update-app
Fix updating an app
2018-02-19 15:54:49 +01:00
Roeland Jago Douma 543e1626de Merge pull request #8426 from nextcloud/refactor/notification-showTempoary-unused-var
Remove unused var in OC.Notification.showTemporary
2018-02-19 12:42:59 +01:00
Roeland Jago Douma 0f57bce06c Avatar generation use ttf (for ancient compatibility)
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-19 12:35:35 +01:00
Roeland Jago Douma 6721774102 Add TTF of OpenSand-{Ligh,Semibold}
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-19 12:34:49 +01:00
Christoph Wurst 3992484323 Remove unused var in OC.Notification.showTemporary
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-02-19 11:00:58 +01:00
Roeland Jago Douma bffdcd76f0 Merge pull request #8334 from nextcloud/lib-strict-typing
Make lib/autoloader.php strictly typed and p…
2018-02-19 10:50:38 +01:00
Roeland Jago Douma 9c33ebad5d Merge pull request #8366 from nextcloud/remove-disable-caching-headers
Use normal header() calls instead of private method calls
2018-02-19 10:40:45 +01:00
Christoph Wurst 1a8916af59 Fix updating an up
OC_App has been made strict recently and the updater code was not
compatible to this. This adds the array to string conversion of the
Nextcloud version and fixes a typo in OC_App (sstring -> string)

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-02-19 10:28:41 +01:00
Morris Jobke 70b1f510f2 Use normal header() calls instead of private method calls
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-19 09:40:25 +01:00
Nextcloud bot b3ca73dc27 [tx-robot] updated from transifex 2018-02-19 01:11:54 +00:00
Julius Härtl 014fa8c686 Fix hiding and event propagation issues with the user management popover
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-18 13:45:40 +01:00
Nextcloud bot 667d21ac7d [tx-robot] updated from transifex 2018-02-18 01:12:03 +00:00
Morris Jobke ac63c207a9 Merge pull request #8411 from nextcloud/add-strict-types-to-oc_app
Add strict types to OC_App
2018-02-17 21:34:20 +01:00
Alecks Gates 3be2c558a5 Add mtime and storage_mtime to db:convert-filecache-bigint 2018-02-17 09:27:25 -06:00
Morris Jobke 9b68f80c4b Add remaining type hints, that were already okay
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 16:05:23 +01:00
Morris Jobke 9fcf185c7d Always return a string in OC_App::getCurrentApp and no boolean
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 16:05:23 +01:00
Morris Jobke e4077672e1 Use empty array as group list in OC_App::enable
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 16:05:23 +01:00
Morris Jobke 2e15c0d871 Refactor dependencies in setAppTypes
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 16:05:23 +01:00
Morris Jobke 9dc3b04802 Fix app version to be always string and neither array nor null
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 16:05:13 +01:00
Morris Jobke edee243b27 OC_App::loadApps now only accepts an array as type list
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 15:27:43 +01:00
Morris Jobke 2a2833e30f Migrate to short array syntax
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 15:18:34 +01:00
Nextcloud bot d953db8683 [tx-robot] updated from transifex 2018-02-17 01:12:04 +00:00
Morris Jobke 57e0881a9e Merge pull request #8232 from nextcloud/bugfix/8007/validate-appinfo-against-appstore-schema
Validate appinfo against appstore schema
2018-02-16 22:56:10 +01:00
Morris Jobke 45e7bb7f40 Merge pull request #8391 from coder-hugo/feature/mysql_ansi_quotes
Don't use double quotes in MySQL queries
2018-02-16 22:55:23 +01:00
Joas Schilling 211212f4b3 App manager is not needed anymore
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-16 17:13:36 +01:00
Robin Müller 6aa816915a Don't use double quotes in MySQL queries
MySQL databases with the ANSI_QUOTES mode enabled treat " as an identifier
quote (see https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sqlmode_ansi_quotes).
So for such databases the 'occ upgrade' fails with an error message like this:
... unknown column 'oc_*' in where clause.

This fix replaces the doulbe quotes with single quotes that should be always
used in MySQL queries to quote literal strings.

Signed-off-by: Robin Müller <robin.mueller@1und1.de>
2018-02-16 15:03:12 +01:00
Morris Jobke 8b3e703c53 Merge pull request #8396 from nextcloud/fix-typo-in-build-matrix-of-drone-yml
Fix typo in build matrix of ".drone.yml"
2018-02-16 13:33:32 +01:00
Daniel Calviño Sánchez 32c6cfe7df Fix typo in build matrix of .drone.yml
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-16 12:38:46 +01:00
Maximilian Wende 7c453b2425 Update tests for indeterminate state, fix slashes not being escaped
Signed-off-by: Maximilian Wende <dasisdormax@mailbox.org>
2018-02-16 11:42:41 +01:00
Morris Jobke 66654bbd18 Merge pull request #8382 from nextcloud/make-acceptance-tests-for-comments-more-consistent-with-the-others
Make acceptance tests for comments more consistent with the others
2018-02-16 10:27:25 +01:00
Joas Schilling f095001e4b Fix info.xml files of shipped apps
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-16 10:24:03 +01:00
Joas Schilling 17a26dfcc1 Validate the info.xml against the appstore schema file
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-16 10:23:51 +01:00
Joas Schilling a097ecded7 Add info also to public interface
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-16 09:44:35 +01:00
Nextcloud bot 620ee00ac5 [tx-robot] updated from transifex 2018-02-16 01:12:10 +00:00
Maximilian Wende 602f50b2d4 Fix indeterminate checkbox state not showing correctly
Also, the checkbox is updated to the correct state while a
permission change is in progress.

should fix issue #8371

Signed-off-by: Maximilian Wende <dasisdormax@secure.mailbox.org>
2018-02-15 22:41:09 +01:00
Maximilian Wende d4238a52b2 Add indeterminate state to 'can edit' share permission checkbox, see #8371
Signed-off-by: Maximilian Wende <dasisdormax@secure.mailbox.org>
2018-02-15 21:10:39 +01:00
Roland Tapken 38ba64af77 Split move and copy operations
The new 'Move and copy' operation from #6040 requires UPDATE permissions
on the selected files. However, READ would be sufficient to create a
copy of a file (if not viewed as a public share). For this reason this patch:

- changes the permission of the 'MoveCopy' action to PERMISSION_READ
- changes the label of the action depending on the permissions
- changes the available buttons in the Move/Copy dialog depending on the
  permissions.

The same changes are done to the filelist view for bulk actions.

Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2018-02-15 18:51:12 +01:00
Daniel Calviño Sánchez 81fdbc6554 Take into account the comment message when looking for it
Instead of checking that the list contains one comment it is now checked
that a comment with certain message is visible. This makes the step (and
the locator) more reusable in future tests and also simplifies the code.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-15 17:48:07 +01:00
Daniel Calviño Sánchez 0a2c98ac89 Adjust timeouts in the step to create a new comment
Depending on the previous steps the new comment field may be already
shown or not when the step to create a new comment is executed.
Therefore, the timeout was increased from 2 to the "standard" 10 seconds
used in other tests.

If the new comment field was found there is no need to use a timeout
when looking for the new comment button; it is either there or not, it
will not appear after some time.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-15 17:48:07 +01:00
Daniel Calviño Sánchez 28d5862643 Move locators above step definitions
The locators are moved above the step definitions for consistency with
other context files; besides that I made some minor adjustments for
consistency too in the locator descriptions and identation, and moved
the locators for ".newCommentRow" descendants together.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-15 17:48:07 +01:00
Daniel Calviño Sánchez c4478f6297 Add acceptance tests for comments to Drone
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-15 17:48:07 +01:00
Morris Jobke 14bc9b1714 Merge pull request #8095 from nextcloud/webapps-capabilities
Expose navigation entries as API endpoint
2018-02-15 16:55:12 +01:00
Morris Jobke 8a505e8767 Merge pull request #8376 from nextcloud/devgals
Fix edit tag textbox size
2018-02-15 15:50:50 +01:00
Morris Jobke e97ae9aac5 Merge pull request #8372 from nextcloud/encapsulate-app-require
Properly encapsulate require_once for app.php
2018-02-15 15:47:22 +01:00
Aastha Gupta fd39d35138 Fix edit tag textbox size
Fixes #7586

Signed-off-by: Aastha Gupta <aastha.gupta4104@gmail.com>
2018-02-15 17:34:42 +05:30
Morris Jobke b7ee624988 Merge pull request #8280 from coliff/coliff-email-inputtype
Correct input type for email
2018-02-15 12:49:27 +01:00
Julius Härtl f36e8313ff Add throws annotation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-15 12:23:49 +01:00
Joas Schilling 339e320064 Fix existing usages
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-15 12:18:51 +01:00
Julius Härtl c300a64520 Merge pull request #8277 from nextcloud/avatars-shared-all
Show share owner avatars on all file lists
2018-02-15 12:11:09 +01:00
Joas Schilling 350e38396f Allow custom HTML in HTML Emails
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-15 12:09:19 +01:00
Morris Jobke 07e91d2d62 Merge pull request #7754 from pierlon/master
Add icons to devices/sessions
2018-02-15 11:27:54 +01:00
Julius Härtl 04053311ee Properly encapsulate require_once for app.php
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-15 11:20:22 +01:00
Julius Härtl e694b30a4f Update phpDoc comments and add more type hinting
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-15 10:38:25 +01:00
Morris Jobke cd2e5b549c Merge pull request #8365 from nextcloud/fix-phpdoc
Fix typo in PHPDoc
2018-02-15 10:35:24 +01:00
Morris Jobke 9cb2aaa596 Fix typo in PHPDoc
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-15 10:21:31 +01:00
Nextcloud bot 01623d4aca [tx-robot] updated from transifex 2018-02-14 21:37:31 +00:00
Morris Jobke 24f96513fd Merge pull request #8259 from nextcloud/guzzle6
update guzzlehttp/guzzle to 6.3.0
2018-02-14 22:26:19 +01:00
Morris Jobke 236086c457 Merge pull request #8335 from nextcloud/remove-unused-import
Remove unused import statements
2018-02-14 22:23:07 +01:00
Arthur Schiwon aeb7503feb fix systemtags event with numeric user ids
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-14 17:02:54 +01:00
Arthur Schiwon 011dab246d tests for systemtags related to numeric user ids
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-14 17:02:35 +01:00
Morris Jobke d3d045dd5c Remove unused import statements
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-14 16:55:43 +01:00
Arthur Schiwon 023d028c57 fix creating comments when file is accessible to users with numeric ids
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-14 14:39:39 +01:00
Arthur Schiwon a5a0a938f2 test creating comments with numeric user ids
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-14 14:39:10 +01:00
Joas Schilling a966d5256c Merge pull request #8328 from nextcloud/bugfix/noid/filter-out-the-current-user-by-email-too
Filter out the current user when searching for emails too
2018-02-14 11:53:48 +01:00
Joas Schilling c32a94b78d Merge pull request #8337 from nextcloud/use-non-alias-method
Use non aliased method instead
2018-02-14 10:09:09 +01:00
Joas Schilling d1fb939e86 Merge pull request #8338 from nextcloud/simplify-return-statement
Simplify return statement
2018-02-14 10:08:28 +01:00
Nextcloud bot ff1b343c4a [tx-robot] updated from transifex 2018-02-14 01:11:53 +00:00
Morris Jobke 5819e5e5b3 Make lib/autoloader.php strictly typed and properly type hinted
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-13 22:07:58 +01:00
Morris Jobke e2974f1133 Simplify return statement
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-13 21:55:24 +01:00
Morris Jobke 954da26e26 Use non aliased method instead
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-13 21:48:24 +01:00
Morris Jobke d18d323f21 Remove fromMailAddress from MailSettingsController
Was removed in https://github.com/nextcloud/server/pull/4379 (0a54d5a) and https://github.com/nextcloud/server/pull/4380 (bae64e8)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-13 21:40:38 +01:00
Morris Jobke bcf1668cc8 Remove config from AutoCompleteController
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-13 21:40:30 +01:00
Morris Jobke b7c944fac1 Remove crypto and timefactory from UsersController
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-13 21:39:57 +01:00
Joas Schilling cf216ecff2 Filter out the current user when searching for emails too
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-13 17:32:58 +01:00
Nextcloud bot 3fc6d6234e [tx-robot] updated from transifex 2018-02-13 10:48:27 +00:00
Nextcloud bot 91c67eb667 [tx-robot] updated from transifex 2018-02-12 21:33:37 +00:00
Julius Härtl 5a23b35ddb Also rewrite icon url
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-12 21:20:21 +01:00
Julius Härtl ada5aed35e Deprecate static methods and use Navigation manager
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-12 17:22:33 +01:00
Roeland Jago Douma 39529851a8 Update autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-12 17:22:33 +01:00
Julius Härtl 922cf44c81 Move to OCS endpoint
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-12 17:22:33 +01:00
Julius Härtl 8ecac56543 Allow requesting absolute URLs
They might be useful when requesting the navigation from the clients

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-12 17:22:32 +01:00
Julius Härtl 6211d18dc1 Add tests for NavigationController
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-12 17:22:32 +01:00
Julius Härtl b6da8c5279 Add getAll to public INavigationManager
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-12 17:22:32 +01:00
Julius Härtl 96480af159 Add navigation endpoint
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-12 17:22:32 +01:00
Julius Härtl f9dbaf6f2a Make sure we test the proper order in the NavigationManagerTest
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-12 17:22:32 +01:00
Julius Härtl 864474b858 Move navigation processing to the NavigationManager
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-12 17:22:32 +01:00
Robin Appelman a815185bb4 fix redundant namespace
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-12 15:41:23 +01:00
Joas Schilling 4bd14ef308 Merge pull request #8308 from nextcloud/public_link_wa_preview
Show open graph preview in WhatsApp
2018-02-12 11:09:08 +01:00
Morris Jobke 825975b322 Merge pull request #8297 from nextcloud/bugfix/noid/fix-example-regex-for-user-agent-matching
Fix example regex for user agent matching
2018-02-12 10:56:36 +01:00
Roeland Jago Douma 20844c828a Show open graph preview in WhatsApp
Whatsapp is picky about the size of the open graph images.
So we do some special handling.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-12 10:42:18 +01:00
Roland Tapken dc99442bc1 External storage test: log exceptions
If an external storage test fails the exception's message is now written
into the logfile (level INFO). Additionally, the stack trace is printed
as DEBUG. This helps to resolve the reason for a failing connection.

Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2018-02-11 16:45:32 +01:00
Joas Schilling a11415b167 Fix example regex for user agent matching
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-10 16:39:53 +01:00
Roland Tapken 8e251e5d5a Make SMB module more fault-tolerant
Ignore unavailable files when fetching the share's mtime
or reading directory listings. This can happen on servers using a
distributed file system (DFS) with unavailable destinations, for example
when the remote server is offline.

Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2018-02-09 17:40:00 +01:00
Robin Appelman fe23bb5916 adjust post body for new guzzle
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-09 17:13:33 +01:00
Robin Appelman 359ccbc023 Adjust integration tests to new guzzle
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-09 17:13:30 +01:00
Robin Appelman 97b44605f4 Adjust dav client to new guzzle
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-09 17:13:24 +01:00
Robin Appelman 9b25ff9fcb adjust httpclient to guzzle6
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-09 17:13:21 +01:00
Robin Appelman 18215eb01d update guzzlehttp/guzzle to 6.3.0
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-09 17:13:17 +01:00
Nextcloud bot ee77f37df2 [tx-robot] updated from transifex 2018-02-09 15:28:58 +00:00
Christian Oliff 458ddf8cb4 Correct input type for email
Correct input type for email
2018-02-09 21:46:25 +09:00
Julius Härtl cae311460a Show share owner avatars on all file lists
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-09 11:42:47 +01:00
Morris Jobke 0841d29c4c Merge pull request #6265 from nextcloud/unperl-l10n
Remove old perl script to update l10n files
2018-02-09 09:57:58 +01:00
Morris Jobke 5d75fb140c Merge pull request #8270 from nextcloud/revoke-files_rightclick
Update CRL to revoke files_rightclick
2018-02-09 09:56:04 +01:00
Morris Jobke a76d850b40 Update CRL to revoke files_rightclick
See https://github.com/nextcloud/app-certificate-requests/pull/134

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-09 09:42:57 +01:00
Nextcloud bot 15b4797629 [tx-robot] updated from transifex 2018-02-09 01:10:53 +00:00
Morris Jobke ba9711f5d3 Merge pull request #8263 from nextcloud/fix_dev_man_link
Link to NC 14 dev manual
2018-02-08 23:18:00 +01:00
Morris Jobke b63ea2c771 Merge pull request #8235 from nextcloud/swift-primairy-ci
Add ci for swift primary storage
2018-02-08 23:14:21 +01:00
Roeland Jago Douma f07d3a3b55 Link to NC 14 dev manual
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-08 21:26:04 +01:00
Morris Jobke 23f9ef54e3 Remove old perl script to update l10n files
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-08 18:21:14 +01:00
Robin Appelman 2e3ed7db90 sleep more
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-08 15:18:26 +01:00
Roeland Jago Douma 3e0ef7e3f2 Try to silence phan
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-08 15:18:26 +01:00
Robin Appelman e34c20af7d don't swallow exception from touch
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-08 15:18:26 +01:00
Robin Appelman 85d23dd6fc better error message on catalog error
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-08 15:18:26 +01:00
Robin Appelman df6e23c98c add ci for swift primary storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-08 15:18:25 +01:00
Morris Jobke 26e0c14c6d Merge pull request #8033 from nextcloud/s3-uploader
Use S3Client::upload instead of splitting single/multipart upload ourselves
2018-02-08 14:30:02 +01:00
Morris Jobke 12c9bad5b2 Merge pull request #8100 from nextcloud/s3-folder-delete
Fix deleting folders when using s3 external storage
2018-02-08 14:11:12 +01:00
Morris Jobke d767d01a0c Merge pull request #8218 from nextcloud/display_proper_lang_string
Display the proper language strings in setttings
2018-02-08 11:13:10 +01:00
Joas Schilling 5b3843ca8f Merge pull request #8252 from nextcloud/remove-wrong-documentation-link
Remove invalid link to documentation
2018-02-08 10:20:16 +01:00
Robin Appelman 48ea714341 Use a more widely available method to test s3 settings
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-08 09:34:05 +01:00
Joas Schilling b7321b6a05 Merge pull request #8214 from axllent/referrer-fix
Block referrer information with "no-referrer"
2018-02-08 09:19:22 +01:00
Morris Jobke e5c08621af Merge pull request #8023 from nextcloud/webdavsearch_limit_order_fixing
Respect limit and order in webdav search
2018-02-08 09:11:39 +01:00
Morris Jobke 32b5c02419 Remove invalid link to documentation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-08 08:44:39 +01:00
Roeland Jago Douma b939383049 Merge pull request #8233 from nextcloud/swift-return-stream
actually return stream from swift
2018-02-08 08:15:35 +01:00
Nextcloud bot 71382daf67 [tx-robot] updated from transifex 2018-02-08 01:10:28 +00:00
Ralph Slooten be42df8e48 Referrer fix (no-referrer)
Blocking referrer information should be done with "no-referrer" and not "never". See
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Referrer-Policy

Signed-off-by: Ralph Slooten <axllent@gmail.com>
2018-02-08 08:31:24 +13:00
Robin Appelman fd09c06eb4 actually return stream from swift
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-07 17:10:59 +01:00
Robin Appelman e4129b0dc7 adjust tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-07 14:55:50 +01:00
Robin Appelman 8281378e5b Merge pull request #8224 from nextcloud/dav-dir-exception-previous
keep previous exception when transforming to dav exception
2018-02-07 14:43:20 +01:00
Roeland Jago Douma c1ff12e234 CacheJail should apply limit and offset after searching
Else the results might not be correct.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-07 13:41:15 +01:00
Robin Appelman 6b5419ddf0 Adjust to updated searchdav library
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-07 13:41:15 +01:00
Roeland Jago Douma ec144281ef Respect limit and order in webdav search
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-07 13:41:15 +01:00
Robin Appelman 9d6d23d1f7 keep previous exception when transforming to dav exception
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-07 13:34:30 +01:00
Nextcloud bot 3063131e6d [tx-robot] updated from transifex 2018-02-07 11:31:55 +00:00
Roland Tapken cf4ec7a4b6 Apply ldapUserFilter on members of group
Refers to issue #8220

user_ldap configured with custom filters for active directory access
(group-member-association is "member"). Then it can happen that the
members of a group contain members that don't belong to the users
available in Nextcloud (the most trivial reason is that the user filter
contains "(!(UserAccountControl:1.2.840.113556.1.4.803:=2))" to exclude
disabled users from being imported).

This can be fixed by applying the ldapUserFilter when resolving the UID
for a DN fetched from the group's member list.

Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2018-02-07 12:02:58 +01:00
Morris Jobke 4ee539fde8 Fix proper overwrite URL on CLI install
* regression from #7835

Steps

* having a my.config.php with a proper `overwrite.cli.url` and `htaccess.RewriteBase` set
* install with this
* before: short URLs where broken and you need to call `occ maintenance:update:htaccess` additionally to fix this
* after: occ install results in a proper htaccess like on stable13

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-07 11:40:35 +01:00
Morris Jobke 8d57d68846 Merge pull request #8217 from nextcloud/fix_8180
Use proper lanugage in langauge code
2018-02-07 11:37:51 +01:00
Roeland Jago Douma 4ee9315a68 Display the proper language strings in setttings
Since this was moved to lib, we have to the lib language files.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-07 11:13:55 +01:00
Roeland Jago Douma e5be299101 Use proper lanugage in langauge code
Fixes #8180

The _ is not valid in language codes use - instead.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-07 11:04:37 +01:00
Nextcloud bot 2a3272331f [tx-robot] updated from transifex 2018-02-07 01:10:23 +00:00
Morris Jobke 27f505667c Merge pull request #8182 from robert-scheck/pki-validation
Handle SSL certificate verifications for others than Let's Encrypt
2018-02-06 16:43:39 +01:00
Morris Jobke c688da7195 Merge pull request #8175 from LorbusChris/patch-1
Sort dependencies in bower.json alphabetically
2018-02-06 11:21:29 +01:00
Morris Jobke 8fa86bf68b Merge pull request #8173 from michaelletzgus/fix_for_each
Fix "undefined index" problem
2018-02-06 10:23:52 +01:00
Nextcloud bot 2b848e483b [tx-robot] updated from transifex 2018-02-06 01:10:22 +00:00
Daniel Calviño Sánchez 3d5c67b7d7 Merge pull request #8172 from nextcloud/phan-version
Use a phan version instead of master
2018-02-06 00:40:37 +01:00
Roeland Jago Douma 67a876b7ec Bump php7.2 image
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-05 20:42:43 +01:00
Arno Welzel e7c35d720d Avoid error messages for restricted opcache API 2018-02-05 19:45:06 +01:00
Robert Scheck 7583615bab Handle SSL certificate verifications for others than Let's Encrypt
Do no longer (wrongly) rewrite URLs like

  * http://example.net/.well-known/pki-validation/file.txt (Comodo)
  * http://example.net/.well-known/pki-validation/fileauth.txt (DigiCert, Thawte, GeoTrust)
  * http://example.net/.well-known/pki-validation/gsdv.txt (GlobalSign)
  * http://example.net/.well-known/pki-validation/starfield.htm (Starfield, GoDaddy)
  * http://example.net/.well-known/pki-validation/swisssign-check.txt (SwissSign)

for automated SSL certificate verifications. All (common commercial)
certificate authorities (CA) except Let's Encrypt (via ACME) seem to
use "pki-validation" rather "acme-challenge" for their domain control
validation (DCV).

Signed-off-by: Robert Scheck <robert@fedoraproject.org>
2018-02-05 15:33:42 +01:00
Morris Jobke 847bd0cf74 Merge pull request #8144 from nextcloud/cache-update-occ
Repair step to clear frontend related caches
2018-02-05 12:15:52 +01:00
Morris Jobke 1424b30213 Merge pull request #8135 from coliff/patch-3
Use correct input type for website url
2018-02-05 12:15:19 +01:00
Morris Jobke 0225ea1b9a Merge pull request #8155 from nextcloud/use-guest-css
Fix styling issues of guest pages
2018-02-05 12:14:09 +01:00
Morris Jobke 30d6fd7f01 Merge pull request #8160 from nextcloud/fix_8047
Do not try to get the jailed path if we can't find the id
2018-02-05 11:40:26 +01:00
Morris Jobke c592abe8ba Merge pull request #8165 from nextcloud/jquery-ui-missing-img
Remove jquery ui background image
2018-02-05 11:33:38 +01:00
michaelletzgus 05b8eb140c using isset()
using isset() instead of array_key_exists()
2018-02-05 10:50:32 +01:00
Nextcloud bot a0dfc7d34a [tx-robot] updated from transifex 2018-02-05 01:10:16 +00:00
Christian Glombek e6309ffc67 Sort dependencies in bower.json alphabetically
Signed-off-by: Christian Glombek <christian.glombek@rwth-aachen.de>
2018-02-05 01:57:40 +01:00
michaelletzgus cfa694ea73 Fix undefined index problem
Nextcloud 13RC4, error in logfile, triggered by "occ config:list":

Invalid argument supplied for foreach() at lib/private/AppConfig.php#297
PHP	Undefined index: workflowengine at lib/private/AppConfig.php#297

Fix: Check if index exists in array before using it.
2018-02-04 15:59:23 +01:00
Roeland Jago Douma 5b5b9cbeca Use 7.2 image
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-04 14:09:54 +01:00
Roeland Jago Douma 1e75f007ac Use a phan version instead of master
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-04 14:08:48 +01:00
Nextcloud bot 58b568fd5d [tx-robot] updated from transifex 2018-02-04 01:10:28 +00:00
Roeland Jago Douma 047fb6d2c5 Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-03 22:16:09 +01:00
Julius Härtl 36fd2353a5 Remove jquery ui background image
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-03 22:10:51 +01:00
Julius Härtl b87e5a0f2e Move depsCache clearing to SCSSCacher/JSCombiner
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-03 15:21:51 +01:00
Julius Härtl 5460166ff5 Add tests and class mapping
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-03 15:21:51 +01:00
Julius Härtl 7381a81d30 Add repair step to clear frontend related caches
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-03 15:21:51 +01:00
Roeland Jago Douma 53a780e31c Do not try to get the jailed path if we can't find the id
Fixes #8047

If we can't find the file by id there we should just return null instead
of trying to get the jailed path of null.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-03 14:45:28 +01:00
Roeland Jago Douma 79e81c15c5 Merge pull request #8163 from nextcloud/fix_themeing_test
Fix theming test
2018-02-03 14:11:03 +01:00
Nextcloud bot 7af48b4187 [tx-robot] updated from transifex 2018-02-03 01:10:30 +00:00
Roeland Jago Douma 0bde91600a Fix theming test
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-02 21:26:33 +01:00
Julius Härtl 1ac352de6c Add space on guest pages with custom logo
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-02 14:20:13 +01:00
Julius Härtl c29bf24440 Load guest css on any guest and error page
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-02 14:20:13 +01:00
Julius Härtl 39461a2e09 Make sure theming logo css only applies when a logo is set
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-02 14:20:12 +01:00
Christian Oliff f94b53e8dd Update settings.scss 2018-02-02 22:17:12 +09:00
Roeland Jago Douma 737e7f9f29 Merge pull request #8150 from nextcloud/update-crl
Update CRL because user_sql cert was lost
2018-02-02 13:02:10 +01:00
Joas Schilling c314a07e7f Merge pull request #8134 from coliff/patch-2
Update iOS link to geo-detect & show correct store listing
2018-02-02 12:43:10 +01:00
Christian Oliff 18898383c5 Update defaults.php 2018-02-02 20:37:58 +09:00
Morris Jobke e2d5f3cc12 Update CRL because user_sql cert was lost
* see https://github.com/nextcloud/app-certificate-requests/pull/129

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-02 12:00:25 +01:00
Morris Jobke 6428cf552c Merge pull request #8122 from nextcloud/fix-6851
fix reading the ldapIgnoreNamingRule config value
2018-02-02 09:34:03 +01:00
Nextcloud bot 17a2dbb7de [tx-robot] updated from transifex 2018-02-02 01:10:15 +00:00
Nextcloud bot b78da27d0a [tx-robot] updated from transifex 2018-02-01 18:28:02 +00:00
Nextcloud bot b006f25457 [tx-robot] updated from transifex 2018-02-01 17:19:47 +00:00
Morris Jobke e28c40788f Merge pull request #8136 from nextcloud/use-correct-update-server
Use correct update server
2018-02-01 14:40:44 +01:00
Christoph Wurst c176a7a78b Merge pull request #8137 from nextcloud/update-doc-version
Update doc link version to 14
2018-02-01 14:24:48 +01:00
Morris Jobke cbbc6187c2 Update doc link version to 14
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-01 13:52:11 +01:00
Morris Jobke 4739076474 Use correct update server
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-01 13:22:36 +01:00
Christian Oliff d2f616b545 Use correct input type for website url
type="url"
2018-02-01 20:31:00 +09:00
Christian Oliff 4257d0a566 Update iOS link to geo-detect show correct store listing
Adding 'geo.' at beginning of the URL will automatically show users the store listing for their region so it's a better experience.

For example users in Japan will see: https://itunes.apple.com/jp/app/nextcloud/id1125420102?mt=8 which has local customer reviews and certain other information in Japanese.
2018-02-01 19:43:24 +09:00
Nextcloud bot 009874a4c2 [tx-robot] updated from transifex 2018-02-01 01:10:52 +00:00
blizzz 8f29f9a59b typo
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-31 21:50:55 +01:00
Morris Jobke 46a34f1e27 Merge pull request #8128 from nextcloud/forwardport-8124
Fixed app navigation flex margins
2018-01-31 21:06:54 +01:00
Roeland Jago Douma 367b5a794d Merge pull request #8097 from nextcloud/deprecate-static-app
Deprecate static methods from  \OCP\App
2018-01-31 16:23:11 +01:00
John Molakvoæ (skjnldsv) 70fbaa93e5 Fixed app navigation flex margins
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-01-31 16:13:56 +01:00
Morris Jobke c95f6a1dc9 Merge pull request #8121 from nextcloud/bugfix/8085/migrations-table-has-old-collation
Create the migrations table also with the UTF8mb4 collation
2018-01-31 14:43:40 +01:00
Morris Jobke 3fa92a03e5 Add deprecation checks
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-31 14:15:12 +01:00
Julius Härtl 372e06d742 Add all parameters to returnValueMap
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-31 14:15:12 +01:00
Julius Härtl efbdad2d0c Remove OC_App::removeApp
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-31 14:15:12 +01:00
Julius Härtl a68895e334 Remove OC_App::installApp since it is not used anymore
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-31 14:15:10 +01:00
Julius Härtl 6d3c8d5546 Remove long time deprecated functions and deprecate \OCP\App
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-31 14:13:15 +01:00
Julius Härtl 44b002665c Remove deprecated isEnabled call from files_trashbin
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-31 14:13:15 +01:00
Julius Härtl 19a0a9a4e7 Move getAppInfo and getAppVersion to IAppManager
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-31 14:13:15 +01:00
Arthur Schiwon 8753a816d8 fixes reading the sysconfig value
settings without the entry in the translation array are computed

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-31 13:46:13 +01:00
Joas Schilling 352a48e273 Create the migrations table also with the UTF8mb4 collation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-31 13:15:00 +01:00
Roeland Jago Douma 1429146083 Merge pull request #8096 from nextcloud/feature/6382/do-not-cache-settings-in-db-anymore
Do not cache the settings/sections in the database anymore
2018-01-31 12:49:45 +01:00
Nextcloud bot cb26f6d014 [tx-robot] updated from transifex 2018-01-31 01:10:51 +00:00
Morris Jobke 78e4f6f312 Merge pull request #8000 from nextcloud/fix_7983
Provide list of editable fields via OCS API
2018-01-30 22:46:20 +01:00
Roeland Jago Douma ad5595c5c3 Merge pull request #8114 from nextcloud/settings-initalization-fix
Only initialize settings application if the instance is installed
2018-01-30 22:28:10 +01:00
Roeland Jago Douma 48884c9b6a Merge pull request #8111 from nextcloud/only_encrypted_prop_on_folders
Only handle encrypted property on folders
2018-01-30 21:54:18 +01:00
Julius Härtl f23ed5e0ea Make sure we don't query the AppManager before the installation started
Otherwise we end up with the database not being instantiated

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-30 19:05:49 +01:00
Roeland Jago Douma 9896b15ec8 Only handle encrypted property on folders
Exposing the encrypted property is required for E2E. However, there is
no need to expose this on files as then it is server side encryption
(which the clients don't care about).

Better to not confuse the output.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-30 12:25:49 +01:00
Roeland Jago Douma 9a73a1f063 Merge pull request #8103 from nextcloud/bump_clipboard
[js] Bump clipboard
2018-01-30 09:34:55 +01:00
Nextcloud bot 3867717107 [tx-robot] updated from transifex 2018-01-30 01:11:04 +00:00
Roeland Jago Douma 7cbcbab5a6 Update core.js
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-29 16:58:03 +01:00
Roeland Jago Douma 6bca362ce9 Bump clipboardjs
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-29 16:57:15 +01:00
Morris Jobke 4fcdfbf5de Merge pull request #8078 from nextcloud/theming-validate-scss
SCSS hardening
2018-01-29 16:12:10 +01:00
Joas Schilling d971b104ed Do not cache the settings/sections in the database anymore
This caused more troubles then it had benefits, especially
when an app got disabled or was removed without being disabled.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-29 15:47:37 +01:00
Morris Jobke 01482b32a1 Merge pull request #8062 from nextcloud/use-class
Use ::class statement instead of string
2018-01-29 15:25:08 +01:00
Robin Appelman 84bd2b6bc9 fix invalidating folder cache for s3
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-01-29 15:09:15 +01:00
Robin Appelman 7afd77604e adjust s3 bulk delete to new sdk syntax
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-01-29 15:06:10 +01:00
Roeland Jago Douma 6d86dcb265 Merge pull request #7873 from nextcloud/fix_5694
Don't perform CSRF check on OCS routes with Bearer auth
2018-01-29 15:02:22 +01:00
Roeland Jago Douma 7405dfb544 Update tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-29 14:37:18 +01:00
Roeland Jago Douma c0adfa4375 Don't perform CSRF check on OCS routes with Bearer auth
Fixes #5694

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-29 14:37:18 +01:00
Morris Jobke eb51f06a3b Use ::class statement instead of string
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-29 12:03:47 +01:00
Nextcloud bot 1d8b90b8d3 [tx-robot] updated from transifex 2018-01-29 01:10:53 +00:00
Morris Jobke e43138a658 Merge pull request #8076 from nextcloud/bump_autosize
[js] Bump autosize
2018-01-27 13:51:17 +01:00
Roeland Jago Douma ed59019b0c Merge pull request #8079 from nextcloud/remove-unneeded-semicolon-and-parentheses
Remove unneeded semicolon and parentheses
2018-01-27 11:23:36 +01:00
Nextcloud bot 513f70b1c3 [tx-robot] updated from transifex 2018-01-27 01:10:50 +00:00
Morris Jobke a661f043e1 Remove unneeded semicolon and parentheses
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 23:46:40 +01:00
Julius Härtl 5dbf733395 Fix theming tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 20:13:28 +01:00
Julius Härtl e4c58fc473 Add typehinting an fix some minor cleanup
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 20:11:37 +01:00
Julius Härtl 5ec7296f6d Add tests for URL rewriting
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 19:56:13 +01:00
Julius Härtl 6770213649 Do not rewrite absolute URLs
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 19:08:45 +01:00
Julius Härtl 68db09ddce Clear injectect variables when resetting the cache
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 19:07:30 +01:00
Julius Härtl 60e601f4ab Only override image styles if the theming values are set
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 19:05:10 +01:00
Morris Jobke 9be6050cc4 Merge pull request #8072 from nextcloud/type-casting
Use type casting instead of *val() method
2018-01-26 17:34:55 +01:00
Julius Härtl 5eae4819bf Make sure that injected variables do not break the CSS generation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 17:03:22 +01:00
Julius Härtl 92e93704be SCSS files are only cached if their size is > 0
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 17:02:54 +01:00
Roeland Jago Douma 45ca65ec82 Regenerate core.js
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-26 15:47:19 +01:00
Morris Jobke 97c216ea06 Merge pull request #8071 from nextcloud/remove-silly-code
Cleanup unused code
2018-01-26 15:47:06 +01:00
Morris Jobke c67736a542 Merge pull request #7707 from nextcloud/bugfix/noid/birthdaycalendar-different-uids
generate different UIDs for Birthday, Anniversary and Death event
2018-01-26 15:46:46 +01:00
Morris Jobke 08d184816f Merge pull request #8070 from nextcloud/remove-theming-migration
Remove theming migration
2018-01-26 15:46:29 +01:00
Roeland Jago Douma e908f60315 Bump autosize to 4.0.0
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-26 15:44:54 +01:00
Morris Jobke 4c38d1ed01 Merge pull request #8054 from nextcloud/substr-use-index
Use index based string access for substr with length of 1
2018-01-26 15:40:44 +01:00
Morris Jobke c005fc6755 Cleanup unused code
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 15:25:19 +01:00
Julius Härtl 5e325730d6 Remove theming migration
Those images are alredy migrated after the instance has been updated to NC12

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 15:10:22 +01:00
Morris Jobke 2ad2eb38e8 Use type casting instead of *val() method
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 15:01:27 +01:00
Morris Jobke ca493ab5b1 Merge pull request #8069 from nextcloud/no-catch-serverdown
do not catch and ignore ServerNotAvailable in the wrong spot
2018-01-26 14:01:07 +01:00
Morris Jobke 9ff51aafc5 Use index based string access for substr with length of 1
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 13:38:34 +01:00
Morris Jobke 01d362d870 Merge pull request #8068 from nextcloud/simplify-ternary
Simplify ternary operator statements
2018-01-26 13:22:06 +01:00
Roeland Jago Douma 119896a8d7 Fix tests
* Add factory for the federatedfilesharing app

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-26 12:49:11 +01:00
Arthur Schiwon b61b906abe do not catch ServerNotAvailable
might cause the user to be unavailable (race condition).

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-26 12:47:19 +01:00
Morris Jobke 6bbea33133 Simplify ternary operator statements
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 12:36:25 +01:00
Morris Jobke 26682b6936 Merge pull request #8061 from nextcloud/use-typecasting
Use type casting instead of *val() method
2018-01-26 12:25:50 +01:00
Morris Jobke c1e4f9f305 Use type casting instead of *val() method
It should be up to 6x faster

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 11:35:42 +01:00
Roeland Jago Douma f3723434ee Don't expose language and password as editable
* Password might not always be editable
  - Also chaging that will invalide apptokens etc which will directly
  lock out your phone
* Chaging the language also doesn't make that much sense to me currently

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-26 11:22:20 +01:00
Roeland Jago Douma 70b19761aa Provide list of editable fields via OCS API
Fixes #7983

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-26 11:20:58 +01:00
Morris Jobke fe7e726ab2 Merge pull request #8064 from nextcloud/background-jobs
Deprecated OCP interface to fetch background job type
2018-01-26 10:43:21 +01:00
Morris Jobke 9ef6148bfa Deprecated OCP interface to fetch background job type
* was not used by apps and also is not needed
* migrated the documentation to IJobList

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 10:43:01 +01:00
Joas Schilling a7ad7cb08e Merge pull request #8053 from nextcloud/simplify-substr
Use short for of substr to not need strlen()
2018-01-26 10:25:09 +01:00
Joas Schilling c2b1bd92d6 Merge pull request #8063 from nextcloud/inline-value
Return value immediately instead of assigning to a one-time variable
2018-01-26 10:15:39 +01:00
Roeland Jago Douma fab951e4b3 Merge pull request #8057 from nextcloud/unneeded-implements
Implements are not needed because they are already done by base class
2018-01-26 10:00:25 +01:00
Roeland Jago Douma e97165e0b5 Merge pull request #8055 from nextcloud/improve-loop
Improve conditional of loop
2018-01-26 09:59:45 +01:00
Roeland Jago Douma ec1d94c629 Merge pull request #8052 from nextcloud/fix-array-methods
Fix array method usages with a proper call
2018-01-26 09:53:13 +01:00
Roeland Jago Douma 5a7a5e5352 Merge pull request #8058 from nextcloud/useless-return
Remove useless return statements
2018-01-26 09:51:26 +01:00
Roeland Jago Douma 68f44a9a93 Merge pull request #8059 from nextcloud/use-stripos
Use stripos instead of strpos(strtolower(), 'something')
2018-01-26 09:50:31 +01:00
Roeland Jago Douma 43ed8b446c Merge pull request #8060 from nextcloud/proper-codeflow
Use proper code flow instead of not needed else branch
2018-01-26 09:49:30 +01:00
Roeland Jago Douma aebb443ca5 Merge pull request #8056 from nextcloud/array-push
Use $var[] = $a instead of array_push - 2x faster
2018-01-26 09:41:31 +01:00
Nextcloud bot 469b3724b5 [tx-robot] updated from transifex 2018-01-26 01:10:52 +00:00
Morris Jobke 0a56d2185e Return value immediately instead of assigning to a one-time variable
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 00:02:03 +01:00
Morris Jobke 16a558871c Use proper code flow instead of not needed else branch
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 23:01:03 +01:00
Morris Jobke 464f024fa9 Use stripos instead of strpos(strtolower(), 'something')
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:59:50 +01:00
Morris Jobke 4dbee99b7b Remove useless return statements
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:50:40 +01:00
Morris Jobke 55ef34b23b Implements are not needed because they are already done by base class
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:42:24 +01:00
Morris Jobke 870fe20acc Use $var[] = $a instead of array_push - 2x faster
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:36:03 +01:00
Morris Jobke c314eb74a9 Improve conditional of loop
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:33:43 +01:00
Morris Jobke e6efa755c9 Use short for of substr to not need strlen()
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:23:48 +01:00
Morris Jobke 7800a9bc24 Fix array method usages with a proper call
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:20:10 +01:00
Morris Jobke b9bbb894f8 Merge pull request #7916 from nextcloud/2fa_log
Add 2FA to logfile
2018-01-25 15:57:32 +01:00
Roeland Jago Douma 8160d0bc2a Merge pull request #8036 from nextcloud/phpunit6
Require PHPUnit 6.5 or higher
2018-01-25 14:50:46 +01:00
Roeland Jago Douma 9e76577ead Add tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-25 13:44:47 +01:00
Morris Jobke 4718d2b80d Update memcached image
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 13:40:57 +01:00
Roeland Jago Douma a5fe6a6118 Update autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-25 13:25:09 +01:00
Roeland Jago Douma c92eff919e Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-25 13:25:09 +01:00
Roeland Jago Douma b2ca1d6553 Make admin_audit listen to 2fa events
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-25 13:25:09 +01:00
Roeland Jago Douma eddd135f14 Dispatch event on twofactor failure and success
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-25 13:25:09 +01:00
Joas Schilling 3917a54113 Class "ProgressBar" is declared "final" and cannot be mocked.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-25 11:33:26 +01:00
Joas Schilling bf2be08c9f Fix risky tests without assertions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-25 11:33:25 +01:00
Nextcloud bot fe88e7f926 [tx-robot] updated from transifex 2018-01-25 01:11:06 +00:00
Roeland Jago Douma 24af5c20bd Bump docker containers used
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-24 20:35:28 +01:00
Joas Schilling 870023365c Fix "Undefined method setExpectedException()"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-24 18:10:16 +01:00
Morris Jobke e0b329c59d Merge pull request #8032 from nextcloud/fix-missing-clipboard-icon-in-shared-links
Fix missing clipboard icon in shared links
2018-01-24 17:27:10 +01:00
Joas Schilling c3424df1f0 Require PHPUnit 6.5 or higher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-24 17:23:59 +01:00
Robin Appelman 3499cbdb76 Use S3Client::upload instead of splitting single/multipart upload ourselves
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-01-24 17:22:05 +01:00
Daniel Calviño Sánchez 5d7eded809 Fix missing clipboard icon in shared links
The clipboard icon in shared links appears either directly on the link
input field or, if any social sharing app is enabled, in a menu. The
clipboard icon uses the same CSS rules as other icons (like the
information icon) to be posioned on the end of the input field, and
those rules have to be "cancelled" when the icon is shown in the menu.

Fixes #7990

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-24 16:40:21 +01:00
Morris Jobke 0e9009989f Merge pull request #8020 from nextcloud/fix-avatar-migration
Make sure we always know for sure if an avatar is generated or not
2018-01-24 15:18:19 +01:00
Roeland Jago Douma abb17589b1 Merge pull request #7991 from nextcloud/show-trusted-domain-error-in-status.php
Send a proper response for status.php on trusted domain error
2018-01-24 15:05:49 +01:00
Morris Jobke 03072c3914 Merge pull request #7921 from nextcloud/fix_redirect_on_pw_reset
Removed additional and uneccessary request on password reset
2018-01-24 14:21:44 +01:00
Morris Jobke 1daddd678e Merge pull request #8002 from nextcloud/dont_polutelog_dav_emaillogin
Dont polute the log on DAV emaillogin
2018-01-24 14:00:01 +01:00
Morris Jobke abd33bb619 Properly catch InvalidTokenException for better error response
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-24 13:56:12 +01:00
Luca Adrian Lindhorst 269ca40784 Removed additional and uneccessary request on password reset, to fix redirection afterwards.
Signed-off-by: Luca Adrian Lindhorst <info@lucalindhorst.de>
2018-01-24 13:37:06 +01:00
Julius Härtl ef1265e5f5 Make sure we always know for sure if an avatar is generated or not
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-24 13:10:20 +01:00
Morris Jobke 5520ba3d15 Merge pull request #7902 from nextcloud/fix_7700
Add fileid preview endpoint
2018-01-24 12:25:55 +01:00
Julius Härtl 25c62be9d7 Merge pull request #7980 from nextcloud/3rdparty_pimple
[3rdparty] Bump pimpe to 3.2.3
2018-01-24 11:24:32 +01:00
Roeland Jago Douma cda811b6b4 Make filelist and sidebar use the fileid preview endpoint
This makes sure the preview is cached even after rename! yay!

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-24 11:24:18 +01:00
Roeland Jago Douma 0224c61530 Add preview endpoint for the fileid
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-24 11:24:18 +01:00
Morris Jobke f39f95e4e8 Merge pull request #7917 from nextcloud/warn_old_ocs_route_cons
Warn about the old OCP\API::register construct for OCS
2018-01-24 08:36:54 +01:00
Nextcloud bot d427250d87 [tx-robot] updated from transifex 2018-01-24 01:10:48 +00:00
Roeland Jago Douma 79b7f39753 [3rdparty] Bump pimpe to 3.2.3
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-23 14:09:31 +01:00
Roeland Jago Douma 4537faa5da Merge pull request #7918 from nextcloud/properly-log-exceptions
Properly log the full exception instead of only the message
2018-01-23 11:56:02 +01:00
Morris Jobke 9cb3a79b18 Merge pull request #7971 from nextcloud/comradekingu-patch-1
Spelling: There was an error loading → could not load
2018-01-23 10:58:43 +01:00
Morris Jobke 2a38605545 Properly log the full exception instead of only the message
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-23 10:57:21 +01:00
Morris Jobke 5c360a41e9 Merge pull request #7858 from nextcloud/fix-local-storage
Use fallback path if data dir is not available for Storage/Local.php
2018-01-23 10:52:41 +01:00
Roeland Jago Douma ef127a30ec Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-23 10:35:37 +01:00
Morris Jobke caccf7a2e9 Merge pull request #7989 from nextcloud/cleanup-unused-share-methods
Remove not used methods of legacy share.php
2018-01-23 10:00:24 +01:00
Roeland Jago Douma 0660e57b1f Don't polute log when loggin into dav with email
* We first try the email as username but this fails
* Then we get the uid from the email and try again

We should not log the first attempt since it polutes the log with failed
login attempts while the login actually is valid.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-23 09:41:44 +01:00
Nextcloud bot cc4f9986cf [tx-robot] updated from transifex 2018-01-23 01:10:50 +00:00
blizzz c7d9e5fd63 Merge pull request #7354 from nextcloud/refacor-update-page-print
Refactor method to check if update is needed
2018-01-22 22:50:05 +01:00
Roeland Jago Douma 23768d5fea Merge pull request #7985 from nextcloud/remove-public-video
Remove video preview from files_sharing
2018-01-22 21:05:41 +01:00
Roeland Jago Douma eb3fd4bce6 Merge pull request #7988 from nextcloud/cleanup-old-repair-steps
Remove old repair steps that aren't executed anymore
2018-01-22 19:54:46 +01:00
Roeland Jago Douma 97aff2dbe0 Merge pull request #7994 from nextcloud/smb-notify-test-timeout
increase the time we wait for smb notifications in the test
2018-01-22 19:54:00 +01:00
Robin Appelman 80aef8ed08 increase the time we wait for smb notifications in the test
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-01-22 17:08:24 +01:00
Morris Jobke 37026d8b9d Send a proper response for status.php on trusted domain error
* fixes #7732

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-22 15:58:57 +01:00
Morris Jobke 520f2fd6ea Merge pull request #7986 from nextcloud/fix_7749
If the preview is size 0 it is invalid
2018-01-22 15:37:49 +01:00
Morris Jobke 71cf31f211 Remove not used methods of legacy share.php
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-22 14:54:07 +01:00
Morris Jobke d9b1492e03 Remove old repair steps that aren't executed anymore
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-22 14:51:02 +01:00
Roeland Jago Douma 8703df3233 If the preview is size 0 it is invalid
* delete it
* throw a NotFound Exception
  - This should a proper 404 to the user
  - Next time it is then regenerated

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-22 13:57:00 +01:00
Julius Härtl 4d3dbb345f Remove video preview from files_sharing
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-22 13:22:52 +01:00
Roeland Jago Douma 1194e4c2bd Merge pull request #7975 from nextcloud/3rdparty_rm_polyfill
[3rdparty] Remove polyfill-php70
2018-01-22 09:06:23 +01:00
Nextcloud bot 4b4931905c [tx-robot] updated from transifex 2018-01-22 01:10:39 +00:00
Roeland Jago Douma 226e75d9ca [3rdparty] Remove polyfill-php70
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-21 10:43:31 +01:00
Nextcloud bot 5845b177c7 [tx-robot] updated from transifex 2018-01-21 01:10:50 +00:00
Roeland Jago Douma c450dba1a0 Merge pull request #7956 from nextcloud/remove-vendor-detection
Remove vendor detection
2018-01-20 11:42:48 +01:00
Morris Jobke 80a36380fc Disable vendor detection when upgrading from 11.0.x
Upgrade from 11 to 14 is not supported anyways.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-20 11:14:06 +01:00
Julius Härtl 4d99faae4f Merge pull request #7955 from nextcloud/remove-app-disable-upgrade
Remove not needed 3rdparty app disabling during upgrade for PHP 5.x
2018-01-20 11:01:31 +01:00
Allan Nordhøy 7fb1e458fa There was an error loading → Could not load 2018-01-20 09:17:26 +01:00
Allan Nordhøy 29d68d7a35 There was an error loading → could not load 2018-01-20 09:15:50 +01:00
Pierre Gordon 05d8537078 Use generic icons for clients
Signed off by: Pierre Gordon <pierregordon@protonmail.com>
2018-01-20 02:34:18 -05:00
Pierre Gordon d83ab0d94f Align icons with text
Signed off by: Pierre Gordon <pierregordon@protonmail.com>
2018-01-19 20:37:06 -05:00
Pierre Gordon cd9de001f7 Centralize icons
Signed off by: Pierre Gordon <pierregordon@protonmail.com>
2018-01-19 20:36:48 -05:00
Pierre Gordon 50ac20a42a Make icons consistent
Signed off by: Pierre Gordon <pierregordon@protonmail.com>
2018-01-19 20:36:28 -05:00
Pierre Gordon 7109604c01 Add icons to devices/sessions
Signed off by: Pierre Gordon <pierregordon@protonmail.com>
2018-01-19 20:35:50 -05:00
Nextcloud bot 2635073909 [tx-robot] updated from transifex 2018-01-20 01:10:57 +00:00
Roeland Jago Douma 0599d9284d Merge pull request #7961 from nextcloud/smb-2.0.4
update icewind/smb to 2.0.4
2018-01-19 20:23:14 +01:00
Robin Appelman f6c95ca850 update icewind/smb to 2.0.4
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-01-19 16:22:36 +01:00
Morris Jobke 34a3613a64 Merge pull request #7953 from nextcloud/theming-background-highres
Theming: adjust background image resizing
2018-01-19 14:14:25 +01:00
Morris Jobke c70927eaa0 Remove not needed 3rdparty app disabling during upgrade for PHP 5.x
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-19 14:00:27 +01:00
Julius Härtl 422e20569b Theming: adjust background image resizing
Support high resolution login images by resizing only images that are wider than 4096px

fixes #7459

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-19 13:34:43 +01:00
Nextcloud bot fdd7a53250 [tx-robot] updated from transifex 2018-01-19 01:10:55 +00:00
Morris Jobke bcba1a97ad Use fallback path if data dir is not available for Storage/Local.php
Found while testing strict types for PHP7+.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-01-18 16:38:01 +01:00
Roeland Jago Douma fc49e77093 Merge pull request #7941 from nextcloud/fix-7934
remove hardcoded sharepoint icon path
2018-01-18 15:55:25 +01:00
Morris Jobke 9247c48e04 Merge pull request #7939 from nextcloud/do-not-show-non-installed-warning-on-install
Do not show "Not installed warning" during occ install
2018-01-18 15:43:29 +01:00
Arthur Schiwon 116bcb9c60 remove hardcoded sharepoint icon path
it does not exist and if it would, it was not themable

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-18 15:32:19 +01:00
Morris Jobke 0d9f73a814 Do not show "Not installed warning" during occ install
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-18 14:55:32 +01:00
Julius Härtl f0b7b2dedf Merge pull request #7911 from nextcloud/improve-oc_image
Improve OC_Image code to not guess the type of input
2018-01-18 14:39:08 +01:00
Morris Jobke 3d4c698f44 Improve OC_Image code to not guess the type of input, but actually request the specific methods to be called
Followup to #7836

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-18 13:40:55 +01:00
Morris Jobke d0c46ab45e Merge pull request #7923 from nextcloud/files_external_ocscontroller
[files_external] OCS endpoint to proper OCSController
2018-01-18 12:17:46 +01:00
Morris Jobke d78a4daf7e Merge pull request #7924 from nextcloud/dep_iappconfig
Remove deprecated function from IAppConfig
2018-01-18 12:03:55 +01:00
Morris Jobke 4836a5e536 Merge pull request #7930 from nextcloud/update-notification-strict
Make Update notficiations strict and fix all inspections
2018-01-18 12:00:35 +01:00
Roeland Jago Douma 05f75f803a [files_external] OCS endpoint to proper OCSController
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-18 11:15:03 +01:00
Joas Schilling 19f7cc9e92 Make Update notficiations strict and fix all inspections
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-18 10:55:44 +01:00
Morris Jobke 9296116297 Merge pull request #7863 from nextcloud/update-notifications-plusplus
Update notifications ++
2018-01-18 10:51:14 +01:00
Nextcloud bot b6eb50069b [tx-robot] updated from transifex 2018-01-18 01:10:40 +00:00
Roeland Jago Douma 1e7b20f615 Remove IAppConfig::setValue
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-17 21:41:57 +01:00
Roeland Jago Douma 09f8a755ec Remove IAppConfig::getValue
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-17 21:41:56 +01:00
Roeland Jago Douma ee2617d88c Simple IAppConfig deprecations
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-17 21:03:04 +01:00
Roeland Jago Douma e628424ccf Warn about the old OCP\API::register construct for OCS
* Add sleep
* Add log message

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-17 15:18:22 +01:00
Roeland Jago Douma 6e29b8731e Merge pull request #7914 from nextcloud/fix-7254
format self-mentions, but don't offer them
2018-01-17 14:59:46 +01:00
Arthur Schiwon 39f34603f2 add types to php doc
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-17 13:58:42 +01:00
Arthur Schiwon 6fdd686111 do not offer the handle of the current user for auto completion
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-17 13:49:18 +01:00
Arthur Schiwon 3784fa2074 comments should compile mentions also if done by author
it is used by clients for formatting reasons, there is no reason not format
the author if her handle is included in the comment body.
It is unrelated to sending out notifications.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-17 13:48:43 +01:00
Morris Jobke 24c58d39f4 Merge pull request #7909 from nextcloud/fix-migration-type-hints
Fix the type hints of migrations and correctly inject the wrapped sch…
2018-01-17 13:47:58 +01:00
Roeland Jago Douma f8756d96bc Merge pull request #7847 from nextcloud/avatarmanager_strict
Fixes for avatarmanager
2018-01-17 13:46:18 +01:00
Roeland Jago Douma 73cc4ac1f6 Merge pull request #7912 from nextcloud/bugfix/noid/correctly-drop-owncloud-migrations-table
Correctly drop the ownCloud migrations table
2018-01-17 13:45:36 +01:00
Joas Schilling 0d37d24b4b Correctly drop the ownCloud migrations table
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-17 12:17:41 +01:00
Morris Jobke c121610d5a Merge pull request #7813 from nextcloud/getHeader-should-only-return-string
Request->getHeader() should always return a string
2018-01-17 11:42:31 +01:00
Morris Jobke 9222dcd940 Merge pull request #7836 from nextcloud/image-type-hinting
Fix float/integer handling in image API
2018-01-17 11:40:35 +01:00
Joas Schilling 4a5282ba21 Fix the type hints of migrations and correctly inject the wrapped schema into migrations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-17 11:37:36 +01:00
Roeland Jago Douma 6e95bd7a51 Merge pull request #7899 from nextcloud/strict_discservice
Strict DiscoveryService
2018-01-17 10:01:56 +01:00
Morris Jobke e4b3ee8d8f Fix float/integer handling in image API
* IImage::crop/preciseResize now have type hinting for integers
* found while testing strict typing for PHP 7+

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-17 10:00:33 +01:00
Morris Jobke 4ef302c0be Request->getHeader() should always return a string
PHPDoc (of the public API) says that this method returns string but it also returns null, which is not allowed in some method calls. This fixes that behaviour and returns an empty string and fixes all code paths that explicitly checked for null to be still compliant.

Found while enabling the strict_typing for lib/private for the PHP7+ migration.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-17 09:51:31 +01:00
Morris Jobke 22b3280ac2 Merge pull request #7897 from nextcloud/strict_lockingproviders
Made locking providers strict
2018-01-17 09:33:52 +01:00
Morris Jobke cb0dbfa987 Merge pull request #7900 from nextcloud/strict_security
Make OCP\Security stricter
2018-01-17 09:29:32 +01:00
Roeland Jago Douma d1420ef481 Merge pull request #7901 from nextcloud/strict_cache_factory
Made the cache factory strict
2018-01-17 06:51:04 +01:00
Morris Jobke 0b464e5274 Merge pull request #7884 from nextcloud/cleanup-oc_user
Cleanup OC_User and OCP\User
2018-01-17 05:33:07 +01:00
Nextcloud bot ca2904a017 [tx-robot] updated from transifex 2018-01-17 01:10:58 +00:00
Roeland Jago Douma 569b8413d4 Add extra check so we don't error out on type
json_decode can return false if we have invalid data.
In that case just assume there was nothing cached

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 22:06:57 +01:00
Roeland Jago Douma 0e0db37658 Make OCP\Security stricter
* Add typehints
* Add return types
* Opcode opts from phpstorm
* Made strict
* Fixed tests: No need to test bogus values anymore strict typing fixes
this

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 22:01:19 +01:00
Roeland Jago Douma c5fcfb0709 Made the cache factory strict
* Return types
* Typehints
* made strict
* fix tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 21:58:20 +01:00
Roeland Jago Douma 8edbfdb291 Made locking providers strict
* Added typehints
* Added return types
* Made strict

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 21:54:20 +01:00
Morris Jobke 117c1c90df Merge pull request #7894 from nextcloud/strict_http_client
Make OCP\Http strict
2018-01-16 21:49:18 +01:00
Julius Härtl e7605d9adc Merge pull request #7892 from nextcloud/cloudid_strict
Make OCP\Federation strict
2018-01-16 21:10:53 +01:00
Roeland Jago Douma 34e112739d Merge pull request #7895 from nextcloud/proper-codcov-config
Improve codecov config to recognize drone
2018-01-16 21:02:41 +01:00
Roeland Jago Douma cdfffe7bda Strict DiscoveryService
* Made strict
* Type hints
* Return types

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 20:01:38 +01:00
Roeland Jago Douma 2b70c708ab Merge pull request #7882 from nextcloud/search-and
Support arbitrary number of arguments for d:or and d:and in search queries
2018-01-16 19:53:01 +01:00
Roeland Jago Douma fde1ada916 Fix federatedshareprovidertest
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 19:25:08 +01:00
Roeland Jago Douma 50acde36b7 Make OCP\Federation strict
* Also internal classes
* Added scalar typehints
* Added return type
* Made strict

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 19:25:08 +01:00
Roeland Jago Douma a345605ec1 Make OCP\Http strict
* Handle private files
* Add return types
* Add scalar typehints
* Made strict
* Fixed requiring proper guzzle message interface that is passed around

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 19:19:58 +01:00
Morris Jobke 0db466719f Improve codecov config to recognize drone
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-16 18:56:05 +01:00
Morris Jobke 55532f19d9 Cleanup OC_User and OCP\User
* mainly removes deprecated methods and old static code

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-16 18:39:11 +01:00
Morris Jobke a159d7c28c Merge pull request #7891 from nextcloud/fix-systemtags-list
Fix systemtags/list to be compliant
2018-01-16 18:38:06 +01:00
Morris Jobke c2cc30741a Fix systemtags/list to be compliant
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-16 15:55:01 +01:00
Roeland Jago Douma 8614eb91db Fix avatarHome
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 15:37:47 +01:00
Joas Schilling 13a787e2f5 Merge pull request #7885 from nextcloud/ocp-user-app-code-check
Add OCP\User deprecations to app code checker
2018-01-16 14:17:07 +01:00
Morris Jobke 61b0d65353 Merge pull request #7848 from nextcloud/fix_7701
Show message when connection is throttled
2018-01-16 14:00:15 +01:00
Morris Jobke 9a99fc0623 Merge pull request #7879 from nextcloud/bugfix/7865/dont-disable-shipped-apps-on-errors
Keep all shipped apps enabled because they should be okay
2018-01-16 13:36:45 +01:00
Morris Jobke e13fe076d2 Add OCP\User deprecations to app code checker
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-16 13:32:37 +01:00
Robin Appelman 326d55db81 Support arbitrary number of arguments for d:or and d:and in search queries
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-01-16 13:22:28 +01:00
Morris Jobke 4ae04c3d63 Merge pull request #7877 from nextcloud/deprecated-ocp-user
Deprecated checkLoggedIn and other old ways to access control
2018-01-16 11:59:21 +01:00
Joas Schilling c95890f9b0 Keep all shipped apps enabled because they should be okay
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-16 11:39:48 +01:00
Joas Schilling 7deb76e405 Split controller and settings
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-16 11:34:16 +01:00
Morris Jobke 0f18085df6 Deprecated checkLoggedIn and other old ways to access control
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-16 10:41:55 +01:00
Nextcloud bot a02a7593cf [tx-robot] updated from transifex 2018-01-16 01:10:52 +00:00
Roeland Jago Douma a607d737c6 Fix wording
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-15 21:44:03 +01:00
Roeland Jago Douma b1d8084700 Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-15 21:43:11 +01:00
Roeland Jago Douma 7cab7feb38 Display message when connection is throttled on logi page
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-15 21:43:09 +01:00
Morris Jobke 2997bb9c69 Merge pull request #7870 from nextcloud/remove-core-api
Remove deprecated core API
2018-01-15 18:47:34 +01:00
Morris Jobke fc9f5fdfc4 Merge pull request #7835 from nextcloud/fix-empty-overwrite-url-in-setup
Fix case when overwrite URL is empty during setup
2018-01-15 17:55:23 +01:00
Joas Schilling 7bc9a69c3f Remove deprecated core API
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-15 17:54:50 +01:00
Morris Jobke 82869b6d81 Fix case when overwrite URL is empty during setup
Found while testing strict typing for PHP 7+.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-15 11:15:38 +01:00
Morris Jobke 9ddfccc52f Merge pull request #7854 from nextcloud/comradekingu-patch-1
Spelling: FreeType
2018-01-15 11:05:36 +01:00
Joas Schilling dbd1620cef Merge pull request #7859 from nextcloud/master-7806
Fix bug with proxies
2018-01-15 10:59:04 +01:00
Joas Schilling 088505058a Refactor all the logic from app.php to Application class
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-15 09:55:03 +01:00
Joas Schilling 50e1cee5c7 Automatic DI for Controllers also works
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-15 09:55:03 +01:00
Joas Schilling ffb3a3e33a Improve ResetTokenBackgroundJob and unit test
* Automatic DI is implemented since 11
* Correctly type hint parameters
* Optimise the tests

Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-15 09:55:03 +01:00
Roeland Jago Douma 0023cb12fd Merge pull request #7853 from nextcloud/strict_urlgenerator
Make the URLGenerator strict
2018-01-15 09:32:29 +01:00
Roeland Jago Douma d44de92c31 Merge pull request #7838 from nextcloud/timefactory_strict
Make the ITimeFactory strict + return types
2018-01-15 09:27:37 +01:00
Nextcloud bot 0f729e2cd3 [tx-robot] updated from transifex 2018-01-15 01:10:43 +00:00
Joas Schilling 7789fbdea6 Add unit test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-15 00:50:52 +01:00
Mario Danic cc742ce9e7 Fix bug with proxies
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-01-15 00:50:49 +01:00
Morris Jobke c14dad90e8 Merge pull request #7857 from nextcloud/dep_template
Remove deprecated template functions from OCP directly
2018-01-15 00:01:49 +01:00
Morris Jobke bf680adaa8 Merge pull request #7856 from nextcloud/fix-strict-type
Move strict type declare statement below PHP tag
2018-01-14 23:38:55 +01:00
Christoph Wurst bdd99b096f Merge pull request #7833 from nextcloud/fix-code-checker
Fix casting in app code checker
2018-01-14 22:36:59 +01:00
Roeland Jago Douma 419de27b6d Merge pull request #7840 from nextcloud/dep_config
Remove deprecated \OCP\Config
2018-01-14 22:21:37 +01:00
Roeland Jago Douma 7ffd62bf95 Make the ITimeFactory strict + return types
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-14 21:55:40 +01:00
Roeland Jago Douma 4b9890fefd Remove deprecated template functions from OCP directly
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-14 21:39:36 +01:00
Roeland Jago Douma 48ea7251d7 Use \OC\User\Manager internally in the avatarmanager
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-14 21:32:54 +01:00
Roeland Jago Douma 4c56acffd1 Made AvatarManager string and add return types
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-14 21:32:54 +01:00
Roeland Jago Douma a3b33bea03 Make the URLGenerator strict
* Add scalar argument types
* Add return types
* Make strict
* General phpstorm cleanup

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-14 21:18:48 +01:00
Morris Jobke c0c4263546 Merge pull request #7850 from nextcloud/strict_ipaddress
Make IPAddress typed and strict
2018-01-14 21:16:06 +01:00
Roeland Jago Douma bb2938a47d Make IPAddress typed and strict
* Added scalar typehints
* Added return statements
* Added strict declaration

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-14 21:15:44 +01:00
Morris Jobke 2ed4bea18f Merge pull request #7852 from nextcloud/strict_ratelimiting
Make OC\Security\RateLimiting strict
2018-01-14 21:08:45 +01:00
Roeland Jago Douma cf0a339997 Make OC\Security\RateLimiting strict
* Add return types
* Add scalar argument types
* Made strict
* Cleaned up phpstorm inspections

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-14 21:08:23 +01:00
Morris Jobke fcea6e1564 Merge pull request #7849 from nextcloud/strict_securerandom
Strict ISecure random
2018-01-14 21:05:19 +01:00
Roeland Jago Douma 6e1ee1e7a7 Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-14 21:04:52 +01:00
Morris Jobke fc94d1b573 Move strict type declare statement below PHP tag
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-14 20:59:17 +01:00
Morris Jobke 7d9146db38 Merge pull request #7846 from nextcloud/this_is_14
Bump version number
2018-01-14 20:54:16 +01:00
Morris Jobke 3f2007025a Merge pull request #7845 from nextcloud/capabilties_manager_strict
Make the capabilities manager strict
2018-01-14 20:53:17 +01:00
Morris Jobke 3ade5ccb27 Merge pull request #7839 from nextcloud/dep_dicontainer
Remove deprecated functions from DI Container
2018-01-14 20:51:21 +01:00
Morris Jobke 50e4abb46b Merge pull request #7844 from nextcloud/dep_constants
Remove deprecated constants
2018-01-14 20:49:39 +01:00
Christoph Wurst 9e7fce7213 Merge pull request #7834 from nextcloud/database-schema-checker-casts
Add casts to XML parser in DatabaseSchemaChecker
2018-01-14 18:58:15 +01:00
Allan Nordhøy e81f30b124 Spelling: FreeType 2018-01-14 16:01:23 +01:00
Allan Nordhøy 13d8b7f190 Spelling: FreeType 2018-01-14 15:58:36 +01:00
Morris Jobke 3adda336a5 Merge pull request #7843 from nextcloud/dep_util
Remove deprecated functions for OCP\Util
2018-01-14 14:56:38 +01:00
Morris Jobke a2678d56aa Merge pull request #7842 from nextcloud/dep_isearch
Removed deprecated search function from ISearch
2018-01-14 14:47:23 +01:00
Roeland Jago Douma db411f8771 Bump apps
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-14 11:40:53 +01:00
Nextcloud bot cbce239c8c [tx-robot] updated from transifex 2018-01-14 01:10:43 +00:00
Roeland Jago Douma de5d7aa331 Strict ISecure random
* Declare strict
* Scalar arguments
* Return type
* Use fully qualified name for strlen

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 21:39:34 +01:00
Roeland Jago Douma c14af47fd9 Bump version number
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 20:16:38 +01:00
Roeland Jago Douma 758cb4d008 Make the capabilities manager strict
* Add return types
* Add scalar type hints
* Use [] instead of array_push (PHPStromg inspection recommendation)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 19:53:31 +01:00
Roeland Jago Douma 5ca0ad4f67 Remove deprecated constants
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 19:46:19 +01:00
Roeland Jago Douma dffa922c0b Remove deprecated functions for OCP\Util
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 19:41:34 +01:00
Roeland Jago Douma 704133d732 Remove deprecated functions from DI Container
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 19:29:52 +01:00
Roeland Jago Douma 21a720e026 Removed deprecated search function from ISearch
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 19:27:25 +01:00
Roeland Jago Douma 60f38d37fe Merge pull request #7825 from nextcloud/add-type-hinting-for-ICrypto-decrypt
Adds type hinting for scalar types in ICrypto->decrypt
2018-01-13 15:11:16 +01:00
Roeland Jago Douma 647ce91395 Update autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 14:31:07 +01:00
Roeland Jago Douma 8a41d05761 Remove deprecated \OCP\Config
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 14:25:04 +01:00
Roeland Jago Douma 8d1dd1945f Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 13:58:06 +01:00
Morris Jobke 1faef0c459 Merge pull request #7832 from nextcloud/update-composer
Update composer
2018-01-13 00:45:00 +01:00
Morris Jobke ca28df6fcc Adds type hinting for scalar types in ICrypto->decrypt
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-13 00:06:03 +01:00
Morris Jobke 16f4d71efd Merge pull request #7824 from nextcloud/fix-type-in-CryptoSessionData
Fix type in CryptoSessionData
2018-01-13 00:01:52 +01:00
Morris Jobke 24bc8c44da Add casts to XML parser in DatabaseSchemaChecker
Preparation for strict_typing for PHP7+.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 23:38:10 +01:00
Morris Jobke c739ca3c50 Fix casting in app code checker
Found while adding strict typing for PHP7+. This adds type hinting to all methods in CodeChecker.php and fixes one implicit cast.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 23:24:11 +01:00
Morris Jobke f578b69729 Update composer
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 23:16:10 +01:00
Morris Jobke fe0dbe7fb7 Fix type in CryptoSessionData
Found while adding strict typing for PHP7+.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 22:41:03 +01:00
Roeland Jago Douma 3dc7d0fb90 Merge pull request #7822 from nextcloud/check-if-realpath-returns-false
Check if realpath() returns false
2018-01-12 22:29:10 +01:00
Morris Jobke 1efde41333 Check if realpath() returns false
realpath() returns false in case the directory does not exist. Found it while preparing strict_typing for PHP7+.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 19:40:25 +01:00
Morris Jobke e4e39910f3 Merge pull request #7819 from nextcloud/fix-explode-in-legacy-helper.php
Fix explode() call in legacy/helper.php to have correct types
2018-01-12 17:59:15 +01:00
Morris Jobke b6e4f34a79 Merge pull request #7820 from nextcloud/13-7818
[stable13] Log full exception in cron instead of only the message
2018-01-12 17:58:31 +01:00
Morris Jobke 1a93e57316 Merge pull request #7818 from nextcloud/log-full-exception-in-cron
Log full exception in cron instead of only the message
2018-01-12 17:42:37 +01:00
Morris Jobke 84a17f0821 Merge pull request #7815 from nextcloud/php7-and-higher
Raise PHP version number to PHP 7.0
2018-01-12 17:07:17 +01:00
Roeland Jago Douma 15bbf08774 Merge pull request #7816 from nextcloud/fix-strpos-for-current-app
Fix strpos if needle is not found
2018-01-12 16:55:27 +01:00
Roeland Jago Douma 9d508a022e Merge pull request #7814 from nextcloud/base.php-strict-typing
Fix strict typing issues in lib/base.php
2018-01-12 16:32:23 +01:00
Roeland Jago Douma daa33938a6 Merge pull request #7811 from nextcloud/fix-clearstatcache
Fix call to clearstatcache to actually use the file path
2018-01-12 15:35:49 +01:00
Morris Jobke 7bc1001309 Log full exception in cron instead of only the message
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 15:31:43 +01:00
Roeland Jago Douma 1993eb05cc Merge pull request #7812 from nextcloud/make-sure-the-arrays-are-arrays
Make sure the arrays are arrays
2018-01-12 15:30:59 +01:00
Morris Jobke b356d0dfc4 Fix explode() call in legacy/helper.php to have correct types
Found while enabling strict_typing for PHP7+.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 15:26:49 +01:00
Morris Jobke e70edb33db Log full exception in cron instead of only the message
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 15:24:28 +01:00
Morris Jobke e3c0fd6882 Fix strpos if needle is not found
Found while testing strict_typing for PHP 7+. If `$script` does not contain a `/` then it should extract a string of the length 0.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 15:01:45 +01:00
Morris Jobke 6d95f90361 Raise PHP version number to PHP 7.0
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 14:26:10 +01:00
Morris Jobke 6bf1fca6f0 Fix strict typing issues in lib/base.php
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 14:22:31 +01:00
Joas Schilling 91d3677446 Make sure the arrays are arrays
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-12 14:08:00 +01:00
Morris Jobke 01040daf02 Fix call to clearstatcache to actually use the file path
* found while adding the strict_typing for PHP 7+ migration
* first argument is a boolean - second one is the path
* see http://php.net/manual/en/function.clearstatcache.php

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 13:59:58 +01:00
Robin Appelman 42b3aa3a0a reuse query builder
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-01-12 13:57:55 +01:00
Nextcloud bot 33a6e265b2 [tx-robot] updated from transifex 2018-01-12 01:11:34 +00:00
Georg Ehrke 1b8fc260c6 generate different UIDs for Birthday, Anniversary and Death event
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-01-04 20:15:24 +01:00
Robin Appelman aad01894e3 refactor user searching
add additional user searching tests

Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-12-20 15:51:37 +01:00
Abijeet ac14d02e1e Added newline to end of htaccess file
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2017-12-18 21:40:02 +05:30
Abijeet ec28c54dbc Adds search by email function on the users screen.
Fixes #7175.

- Updated the query to fetch the users in users > everyone tab.
- Updated the query to fetch the users in users > admin tab.
- Tested to ensure that the disabled users are also being fetched.
- Added test cases.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2017-12-16 17:18:05 +05:30
Morris Jobke 0f35ef3727 Reuse systemconfig
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-30 16:04:07 +01:00
Morris Jobke f22e02cd79 Refactor method to check if update is needed
There was only one call, that actually needed the parameter to be set to true. So this change moved the print of the page to that location and replaces all other occurences with a direct call to the underlying OCP API.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-30 16:04:07 +01:00
4392 changed files with 169147 additions and 94442 deletions
+7 -3
View File
@@ -1,11 +1,15 @@
codecov:
branch: master
ci:
- drone.nextcloud.com
- !scrutinizer-ci.com
coverage:
precision: 2
round: down
range: "70...100"
status:
project: off
patch: off
comment:
layout: "header, diff, changes, uncovered, tree"
behavior: default
comment: off
+259 -152
View File
@@ -14,23 +14,44 @@ pipeline:
when:
matrix:
TESTS: jsunit
vue-build-settings:
image: node
commands:
- ./build/vue-builds.sh ./settings/js/settings-vue.js
when:
matrix:
TESTS: vue-build-settings
vue-build-updatenotification:
image: node
commands:
- ./build/vue-builds.sh ./apps/updatenotification/js/updatenotification.js
when:
matrix:
TESTS: vue-build-updatenotification
vue-build-oauth2:
image: node
commands:
- ./build/vue-builds.sh ./apps/oauth2/js/oauth2.js
when:
matrix:
TESTS: vue-build-oauth2
vue-build-accessibility:
image: node
commands:
- ./build/vue-builds.sh ./apps/accessibility/js/accessibility.js
when:
matrix:
TESTS: vue-build-accessibility
checkers:
image: nextcloudci/php7.0:php7.0-16
image: nextcloudci/php7.0:php7.0-19
commands:
- ./autotest-checkers.sh
secrets: [ github_token ]
when:
matrix:
TESTS: checkers
syntax-php5.6:
image: nextcloudci/php5.6:php5.6-8
commands:
- composer install
- ./lib/composer/bin/parallel-lint --exclude build/.phan/ --exclude lib/composer/jakub-onderka/ --exclude 3rdparty/symfony/polyfill-php70/Resources/stubs/ --exclude 3rdparty/patchwork/utf8/src/Patchwork/Utf8/Bootup/ --exclude 3rdparty/paragonie/random_compat/lib/ --exclude lib/composer/composer/autoload_static.php --exclude 3rdparty/composer/autoload_static.php .
when:
matrix:
TESTS: syntax-php5.6
syntax-php7.0:
image: nextcloudci/php7.0:php7.0-16
image: nextcloudci/php7.0:php7.0-19
commands:
- composer install
- ./lib/composer/bin/parallel-lint --exclude lib/composer/jakub-onderka/ --exclude 3rdparty/symfony/polyfill-php70/Resources/stubs/ --exclude 3rdparty/patchwork/utf8/src/Patchwork/Utf8/Bootup/ --exclude 3rdparty/paragonie/random_compat/lib/ --exclude lib/composer/composer/autoload_static.php --exclude 3rdparty/composer/autoload_static.php .
@@ -38,7 +59,7 @@ pipeline:
matrix:
TESTS: syntax-php7.0
syntax-php7.1:
image: nextcloudci/php7.1:php7.1-15
image: nextcloudci/php7.1:php7.1-16
commands:
- composer install
- ./lib/composer/bin/parallel-lint --exclude lib/composer/jakub-onderka/ --exclude 3rdparty/symfony/polyfill-php70/Resources/stubs/ --exclude 3rdparty/patchwork/utf8/src/Patchwork/Utf8/Bootup/ --exclude 3rdparty/paragonie/random_compat/lib/ --exclude lib/composer/composer/autoload_static.php --exclude 3rdparty/composer/autoload_static.php .
@@ -46,10 +67,10 @@ pipeline:
matrix:
TESTS: syntax-php7.1
phan:
image: nextcloudci/php7.1:php7.1-15
image: nextcloudci/php7.2:php7.2-12
commands:
- composer install
- composer require --dev "phan/phan:dev-master"
- composer require --dev "phan/phan:0.11.1"
- ./lib/composer/phan/phan/phan -k build/.phan/config.php
- php ./build/.phan/plugin-checker.php
when:
@@ -146,16 +167,8 @@ pipeline:
when:
matrix:
TESTS: sqlite-php7.0-webdav-apache
nodb-php5.6:
image: nextcloudci/php5.6:php5.6-8
commands:
- NOCOVERAGE=true TEST_SELECTION=NODB ./autotest.sh sqlite
when:
matrix:
DB: NODB
PHP: 5.6
nodb-php7.0:
image: nextcloudci/php7.0:php7.0-16
image: nextcloudci/php7.0:php7.0-19
commands:
- NOCOVERAGE=true TEST_SELECTION=NODB ./autotest.sh sqlite
when:
@@ -163,7 +176,7 @@ pipeline:
DB: NODB
PHP: "7.0"
nodb-php7.1:
image: nextcloudci/php7.1:php7.1-15
image: nextcloudci/php7.1:php7.1-16
commands:
- NOCOVERAGE=true TEST_SELECTION=NODB ./autotest.sh sqlite
when:
@@ -171,23 +184,15 @@ pipeline:
DB: NODB
PHP: 7.1
nodb-php7.2:
image: nextcloudci/php7.2:php7.2-9
image: nextcloudci/php7.2:php7.2-11
commands:
- NOCOVERAGE=true TEST_SELECTION=NODB ./autotest.sh sqlite
when:
matrix:
DB: NODB
PHP: 7.2
sqlite-php5.6:
image: nextcloudci/php5.6:php5.6-8
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh sqlite
when:
matrix:
DB: sqlite
PHP: 5.6
sqlite-php7.0:
image: nextcloudci/php7.0:php7.0-16
image: nextcloudci/php7.0:php7.0-19
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh sqlite
when:
@@ -195,7 +200,7 @@ pipeline:
DB: sqlite
PHP: "7.0"
sqlite-php7.1:
image: nextcloudci/php7.1:php7.1-15
image: nextcloudci/php7.1:php7.1-16
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh sqlite
when:
@@ -203,23 +208,15 @@ pipeline:
DB: sqlite
PHP: 7.1
sqlite-php7.2:
image: nextcloudci/php7.2:php7.2-9
image: nextcloudci/php7.2:php7.2-12
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh sqlite
when:
matrix:
DB: sqlite
PHP: 7.2
mysql-php5.6:
image: nextcloudci/php5.6:php5.6-8
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mysql
when:
matrix:
DB: mysql
PHP: 5.6
mysql-php7.0:
image: nextcloudci/php7.0:php7.0-16
image: nextcloudci/php7.0:php7.0-19
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mysql
when:
@@ -227,7 +224,7 @@ pipeline:
DB: mysql
PHP: "7.0"
mysql-php7.1:
image: nextcloudci/php7.1:php7.1-15
image: nextcloudci/php7.1:php7.1-16
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mysql
when:
@@ -235,23 +232,15 @@ pipeline:
DB: mysql
PHP: 7.1
mysql-php7.2:
image: nextcloudci/php7.2:php7.2-9
image: nextcloudci/php7.2:php7.2-12
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mysql
when:
matrix:
DB: mysql
PHP: 7.2
mysql5.6-php5.6:
image: nextcloudci/php5.6:php5.6-8
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mysql
when:
matrix:
DB: mysql5.6
PHP: 5.6
mysql5.6-php7.0:
image: nextcloudci/php7.0:php7.0-16
image: nextcloudci/php7.0:php7.0-19
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mysql
when:
@@ -259,23 +248,15 @@ pipeline:
DB: mysql5.6
PHP: "7.0"
mysql5.6-php7.1:
image: nextcloudci/php7.1:php7.1-15
image: nextcloudci/php7.1:php7.1-16
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mysql
when:
matrix:
DB: mysql5.6
PHP: 7.1
mysql5.5-php5.6:
image: nextcloudci/php5.6:php5.6-8
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mysql
when:
matrix:
DB: mysql5.5
PHP: 5.6
mysql5.5-php7.0:
image: nextcloudci/php7.0:php7.0-16
image: nextcloudci/php7.0:php7.0-19
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mysql
when:
@@ -283,25 +264,15 @@ pipeline:
DB: mysql5.5
PHP: "7.0"
mysql5.5-php7.1:
image: nextcloudci/php7.1:php7.1-15
image: nextcloudci/php7.1:php7.1-16
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mysql
when:
matrix:
DB: mysql5.5
PHP: 7.1
postgres-php5.6:
image: nextcloudci/php5.6:php5.6-8
commands:
- sleep 10 # gives the database enough time to initialize
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh pgsql
when:
matrix:
DB: postgres
PHP: 5.6
POSTGRES: 9
postgres-php7.0:
image: nextcloudci/php7.0:php7.0-16
image: nextcloudci/php7.0:php7.0-19
commands:
- sleep 10 # gives the database enough time to initialize
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh pgsql
@@ -310,24 +281,16 @@ pipeline:
DB: postgres
PHP: "7.0"
postgres-php7.1:
image: nextcloudci/php7.1:php7.1-15
image: nextcloudci/php7.1:php7.1-16
commands:
- sleep 10 # gives the database enough time to initialize
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh pgsql
- POSTGRES=${POSTGRES} NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh pgsql
when:
matrix:
DB: postgres
PHP: 7.1
mysqlmb4-php5.6:
image: nextcloudci/php5.6:php5.6-8
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mysqlmb4
when:
matrix:
DB: mysqlmb4
PHP: 5.6
mysqlmb4-php7.0:
image: nextcloudci/php7.0:php7.0-16
image: nextcloudci/php7.0:php7.0-19
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mysqlmb4
when:
@@ -335,7 +298,7 @@ pipeline:
DB: mysqlmb4
PHP: "7.0"
mysqlmb4-php7.1:
image: nextcloudci/php7.1:php7.1-15
image: nextcloudci/php7.1:php7.1-16
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mysqlmb4
when:
@@ -343,7 +306,7 @@ pipeline:
DB: mysqlmb4
PHP: 7.1
mysqlmb4-php7.2:
image: nextcloudci/php7.2:php7.2-9
image: nextcloudci/php7.2:php7.2-12
commands:
- NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mysqlmb4
when:
@@ -351,7 +314,7 @@ pipeline:
DB: mysqlmb4
PHP: 7.2
integration-capabilities_features:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -360,7 +323,7 @@ pipeline:
matrix:
TESTS: integration-capabilities_features
integration-federation_features:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin
- cd build/integration
@@ -369,7 +332,7 @@ pipeline:
matrix:
TESTS: integration-federation_features
integration-auth:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -378,7 +341,7 @@ pipeline:
matrix:
TESTS: integration-auth
integration-maintenance-mode:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -387,7 +350,7 @@ pipeline:
matrix:
TESTS: integration-maintenance-mode
integration-ratelimiting:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- ./occ config:system:set redis host --value=cache
@@ -402,7 +365,7 @@ pipeline:
matrix:
TESTS: integration-ratelimiting
integration-carddav:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -411,7 +374,7 @@ pipeline:
matrix:
TESTS: integration-carddav
integration-dav-v2:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -420,7 +383,7 @@ pipeline:
matrix:
TESTS: integration-dav-v2
integration-ocs-v1:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -429,7 +392,7 @@ pipeline:
matrix:
TESTS: integration-ocs-v1
integration-sharing-v1:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -438,7 +401,7 @@ pipeline:
matrix:
TESTS: integration-sharing-v1
integration-sharing-v1-part2:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -447,7 +410,7 @@ pipeline:
matrix:
TESTS: integration-sharing-v1-part2
integration-sharing-v1-part3:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -456,7 +419,7 @@ pipeline:
matrix:
TESTS: integration-sharing-v1-part3
integration-checksums-v1:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -465,7 +428,7 @@ pipeline:
matrix:
TESTS: integration-checksums
integration-external-storage:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -474,7 +437,7 @@ pipeline:
matrix:
TESTS: integration-external-storage
integration-provisioning-v1:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -483,7 +446,7 @@ pipeline:
matrix:
TESTS: integration-provisioning-v1
integration-tags:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -492,7 +455,7 @@ pipeline:
matrix:
TESTS: integration-tags
integration-caldav:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -501,7 +464,7 @@ pipeline:
matrix:
TESTS: integration-caldav
integration-comments:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -509,8 +472,17 @@ pipeline:
when:
matrix:
TESTS: integration-comments
integration-comments-search:
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh features/comments-search.feature
when:
matrix:
TESTS: integration-comments-search
integration-favorites:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -519,7 +491,7 @@ pipeline:
matrix:
TESTS: integration-favorites
integration-provisioning-v2:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -528,7 +500,7 @@ pipeline:
matrix:
TESTS: integration-provisioning-v2
integration-webdav-related:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -537,7 +509,7 @@ pipeline:
matrix:
TESTS: integration-webdav-related
integration-sharees-features:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -546,7 +518,7 @@ pipeline:
matrix:
TESTS: integration-sharees-features
integration-sharees-v2-features:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -555,7 +527,7 @@ pipeline:
matrix:
TESTS: integration-sharees-v2-features
integration-setup-features:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- cd build/integration
- ./run.sh setup_features/setup.feature
@@ -563,7 +535,7 @@ pipeline:
matrix:
TESTS: integration-setup-features
integration-filesdrop-features:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -572,7 +544,7 @@ pipeline:
matrix:
TESTS: integration-filesdrop-features
integration-transfer-ownership-features:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -581,7 +553,7 @@ pipeline:
matrix:
TESTS: integration-transfer-ownership-features
integration-ldap-features:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- ./occ app:enable user_ldap
@@ -590,8 +562,28 @@ pipeline:
when:
matrix:
TESTS: integration-ldap-features
integration-ldap-openldap-features:
image: nextcloudci/integration-php7.0:integration-php7.0-6
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- ./occ app:enable user_ldap
- cd build/integration
- ./run.sh ldap_features/ldap-openldap.feature
when:
matrix:
TESTS: integration-ldap-openldap-features
integration-ldap-openldap-uid-features:
image: nextcloudci/integration-php7.0:integration-php7.0-6
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- ./occ app:enable user_ldap
- cd build/integration
- ./run.sh ldap_features/openldap-uid-username.feature
when:
matrix:
TESTS: integration-ldap-openldap-uid-features
integration-trashbin:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -600,7 +592,7 @@ pipeline:
matrix:
TESTS: integration-trashbin
integration-remote-api:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
@@ -608,36 +600,73 @@ pipeline:
when:
matrix:
TESTS: integration-remote-api
integration-download:
image: nextcloudci/integration-php7.0:integration-php7.0-8
commands:
- ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
- cd build/integration
- ./run.sh --tags ~@large features/download.feature
when:
matrix:
TESTS: integration-download
acceptance-access-levels:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/acceptance-php7.1:acceptance-php7.1-2
commands:
- tests/acceptance/run-local.sh --timeout-multiplier 10 --nextcloud-server-domain acceptance-access-levels --selenium-server selenium:4444 allow-git-repository-modifications features/access-levels.feature
when:
matrix:
TESTS-ACCEPTANCE: access-levels
acceptance-app-comments:
image: nextcloudci/acceptance-php7.1:acceptance-php7.1-2
commands:
- tests/acceptance/run-local.sh --timeout-multiplier 10 --nextcloud-server-domain acceptance-app-comments --selenium-server selenium:4444 allow-git-repository-modifications features/app-comments.feature
when:
matrix:
TESTS-ACCEPTANCE: app-comments
acceptance-app-files:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/acceptance-php7.1:acceptance-php7.1-2
commands:
- tests/acceptance/run-local.sh --timeout-multiplier 10 --nextcloud-server-domain acceptance-app-files --selenium-server selenium:4444 allow-git-repository-modifications features/app-files.feature
when:
matrix:
TESTS-ACCEPTANCE: app-files
acceptance-app-theming:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/acceptance-php7.1:acceptance-php7.1-2
commands:
- tests/acceptance/run-local.sh --timeout-multiplier 10 --nextcloud-server-domain acceptance-app-theming --selenium-server selenium:4444 allow-git-repository-modifications features/app-theming.feature
when:
matrix:
TESTS-ACCEPTANCE: app-theming
acceptance-header:
image: nextcloudci/acceptance-php7.1:acceptance-php7.1-2
commands:
- tests/acceptance/run-local.sh --timeout-multiplier 10 --nextcloud-server-domain acceptance-header --selenium-server selenium:4444 allow-git-repository-modifications features/header.feature
when:
matrix:
TESTS-ACCEPTANCE: header
acceptance-login:
image: nextcloudci/integration-php7.0:integration-php7.0-6
image: nextcloudci/acceptance-php7.1:acceptance-php7.1-2
commands:
- tests/acceptance/run-local.sh --timeout-multiplier 10 --nextcloud-server-domain acceptance-login --selenium-server selenium:4444 allow-git-repository-modifications features/login.feature
when:
matrix:
TESTS-ACCEPTANCE: login
acceptance-users:
image: nextcloudci/acceptance-php7.1:acceptance-php7.1-2
commands:
- tests/acceptance/run-local.sh --timeout-multiplier 10 --nextcloud-server-domain acceptance-users --selenium-server selenium:4444 allow-git-repository-modifications features/users.feature
when:
matrix:
TESTS-ACCEPTANCE: users
acceptance-apps:
image: nextcloudci/acceptance-php7.1:acceptance-php7.1-2
commands:
- tests/acceptance/run-local.sh --timeout-multiplier 10 --nextcloud-server-domain acceptance-apps --selenium-server selenium:4444 allow-git-repository-modifications features/apps.feature
when:
matrix:
TESTS-ACCEPTANCE: apps
nodb-codecov:
image: nextcloudci/php7.0:php7.0-16
image: nextcloudci/php7.0:php7.0-19
commands:
- phpenmod xdebug
- TEST_SELECTION=NODB ./autotest.sh sqlite
@@ -648,7 +677,7 @@ pipeline:
matrix:
TESTS: nodb-codecov
db-codecov:
image: nextcloudci/php7.0:php7.0-16
image: nextcloudci/php7.0:php7.0-19
commands:
- phpenmod xdebug
- TEST_SELECTION=QUICKDB ./autotest.sh sqlite
@@ -659,9 +688,10 @@ pipeline:
matrix:
TESTS: db-codecov
object-store:
image: nextcloudci/php7.0:php7.0-16
image: nextcloudci/php7.0:php7.0-19
commands:
- phpenmod xdebug
- ./tests/drone-wait-objectstore.sh
- TEST_SELECTION=PRIMARY-${OBJECT_STORE} ./autotest.sh sqlite
- wget https://codecov.io/bash -O codecov.sh
- sh -c "if [ '$DRONE_BUILD_EVENT' = 'pull_request' ]; then bash codecov.sh -B $DRONE_BRANCH -C $DRONE_COMMIT -P $DRONE_PULL_REQUEST -t 117641e2-a9e8-4b7b-984b-ae872d9b05f5 -f tests/autotest-clover-sqlite.xml; fi"
@@ -670,7 +700,7 @@ pipeline:
matrix:
TESTS: object-store
memcache-memcached:
image: nextcloudci/php7.0-memcached:php7.0-memcached-8
image: nextcloudci/php7.0-memcached:php7.0-memcached-9
commands:
- phpenmod xdebug
- service memcached restart
@@ -682,7 +712,7 @@ pipeline:
matrix:
TEST: memcache-memcached
memcache-redis-cluster:
image: nextcloudci/php7.0:php7.0-17
image: nextcloudci/php7.0:php7.0-19
commands:
- phpenmod xdebug
- sleep 20
@@ -693,16 +723,43 @@ pipeline:
when:
matrix:
TEST: memcache-redis-cluster
ui-regression:
image: nextcloudci/ui-regression:ui-regression-1
commands:
- cd tests/ui-regression
- npm install
- chown -R pptruser out node_modules
- bash -c "until curl -s http://ui-regression-php-master > /dev/null && curl -s http://ui-regression-php > /dev/null; do sleep 2; done"
- sudo -u pptruser node runTests.js || true
- echo "The result can be found at https://s3.bitgrid.net/nextcloud-ui-regression/nextcloud/server/${DRONE_PULL_REQUEST}/index.html"
shm_size: '1gb'
when:
matrix:
TESTS: ui-regression
publish-s3:
image: plugins/s3
endpoint: https://ci-assets.nextcloud.com
bucket: nextcloud-ui-regression
path_style: true
source: tests/ui-regression/out/**/*
strip_prefix: tests/ui-regression/out/
acl: public-read
target: ${DRONE_REPO_OWNER}/${DRONE_REPO_NAME}/${DRONE_PULL_REQUEST}
secrets: [ aws_access_key_id, aws_secret_access_key ]
when:
matrix:
TESTS: ui-regression
matrix:
include:
- TESTS: checkers
- TESTS: vue-build-settings
- TESTS: vue-build-updatenotification
- TESTS: vue-build-oauth2
- TESTS: vue-build-accessibility
- TESTS: nodb-codecov
ENABLE_REDIS: true
- TESTS: db-codecov
ENABLE_REDIS: true
- DB: NODB
PHP: 5.6
ENABLE_REDIS: true
- DB: NODB
PHP: 7.0
ENABLE_REDIS: true
@@ -712,9 +769,6 @@ matrix:
- DB: NODB
PHP: 7.2
ENABLE_REDIS: false
- DB: sqlite
PHP: 5.6
ENABLE_REDIS: true
- DB: sqlite
PHP: 7.0
ENABLE_REDIS: true
@@ -724,9 +778,6 @@ matrix:
- DB: sqlite
PHP: 7.2
ENABLE_REDIS: false
- DB: mysql
PHP: 5.6
ENABLE_REDIS: true
- DB: mysql
PHP: 7.0
ENABLE_REDIS: true
@@ -736,28 +787,18 @@ matrix:
- DB: mysql
PHP: 7.2
ENABLE_REDIS: false
- DB: mysql5.6
PHP: 5.6
ENABLE_REDIS: true
- DB: mysql5.6
PHP: 7.0
ENABLE_REDIS: true
- DB: mysql5.6
PHP: 7.1
ENABLE_REDIS: true
- DB: mysql5.5
PHP: 5.6
ENABLE_REDIS: true
- DB: mysql5.5
PHP: 7.0
ENABLE_REDIS: true
- DB: mysql5.5
PHP: 7.1
ENABLE_REDIS: true
- DB: postgres
PHP: 5.6
POSTGRES: 9
ENABLE_REDIS: true
- DB: postgres
PHP: 7.0
POSTGRES: 9
@@ -770,9 +811,6 @@ matrix:
PHP: 7.1
POSTGRES: 10
ENABLE_REDIS: true
- DB: mysqlmb4
PHP: 5.6
ENABLE_REDIS: true
- DB: mysqlmb4
PHP: 7.0
ENABLE_REDIS: true
@@ -800,6 +838,7 @@ matrix:
- TESTS: integration-tags
- TESTS: integration-caldav
- TESTS: integration-comments
- TESTS: integration-comments-search
- TESTS: integration-favorites
- TESTS: integration-provisioning-v2
- TESTS: integration-webdav-related
@@ -809,18 +848,30 @@ matrix:
- TESTS: integration-filesdrop-features
- TESTS: integration-transfer-ownership-features
- TESTS: integration-ldap-features
- TESTS: integration-ldap-openldap-features
ENABLE_OPENLDAP: true
- TESTS: integration-ldap-openldap-uid-features
ENABLE_OPENLDAP: true
- TESTS: integration-trashbin
- TESTS: integration-remote-api
- TESTS: integration-download
- TESTS: acceptance
TESTS-ACCEPTANCE: access-levels
- TESTS: acceptance
TESTS-ACCEPTANCE: app-comments
- TESTS: acceptance
TESTS-ACCEPTANCE: app-files
- TESTS: acceptance
TESTS-ACCEPTANCE: app-theming
- TESTS: acceptance
TESTS-ACCEPTANCE: header
- TESTS: acceptance
TESTS-ACCEPTANCE: login
- TESTS: acceptance
TESTS-ACCEPTANCE: users
- TESTS: acceptance
TESTS-ACCEPTANCE: apps
- TESTS: jsunit
- TESTS: syntax-php5.6
- TESTS: syntax-php7.0
- TESTS: syntax-php7.1
- TESTS: phan
@@ -832,6 +883,14 @@ matrix:
- TESTS: carddavtester-old-endpoint
- TESTS: object-store
OBJECT_STORE: s3
- TESTS: object-store
OBJECT_STORE: azure
# - TESTS: object-store
# OBJECT_STORE: swift
# SWIFT-AUTH: v2.0
# - TESTS: object-store
# OBJECT_STORE: swift
# SWIFT-AUTH: v3
- TESTS: sqlite-php7.0-samba-native
- TESTS: sqlite-php7.0-samba-non-native
- TEST: memcache-memcached
@@ -839,6 +898,7 @@ matrix:
ENABLE_REDIS_CLUSTER: true
- TESTS: sqlite-php7.0-webdav-apache
ENABLE_REDIS: true
- TESTS: ui-regression
services:
cache:
@@ -846,6 +906,27 @@ services:
when:
matrix:
ENABLE_REDIS: true
ui-regression-php:
image: nextcloudci/server:server-1
commands:
- . /etc/apache2/envvars
- rm -fr /var/www/html
- mkdir /var/www/html && cp -rT . /var/www/html && chown -R www-data:www-data /var/www/html
- rm -fr /var/www/html/config/config.php /var/www/html/data/*
- apache2 -DFOREGROUND
when:
matrix:
TESTS: ui-regression
ui-regression-php-master:
image: nextcloudci/server:server-1
commands:
- . /etc/apache2/envvars
- rm -fr /var/www/html/config/config.php /var/www/html/data/*
- su www-data -c "cd /var/www/html/ && git checkout $DRONE_REPO_BRANCH && git pull && git submodule update"
- apache2 -DFOREGROUND
when:
matrix:
TESTS: ui-regression
cache-cluster:
image: morrisjobke/redis-cluster
when:
@@ -855,6 +936,7 @@ services:
image: postgres:9
environment:
- POSTGRES_USER=oc_autotest
- POSTGRES_DB=oc_autotest_dummy
- POSTGRES_PASSWORD=owncloud
tmpfs:
- /var/lib/postgresql/data
@@ -866,6 +948,7 @@ services:
image: postgres:10
environment:
- POSTGRES_USER=oc_autotest
- POSTGRES_DB=oc_autotest_dummy
- POSTGRES_PASSWORD=owncloud
tmpfs:
- /var/lib/postgresql/data
@@ -910,7 +993,7 @@ services:
matrix:
DB: mysql5.5
mysqlmb4:
image: mysql
image: mysql:5.7.22
environment:
- MYSQL_ROOT_PASSWORD=owncloud
- MYSQL_USER=oc_autotest
@@ -927,6 +1010,20 @@ services:
when:
matrix:
OBJECT_STORE: s3
azurite:
image: arafato/azurite
environment:
- executable=blob
when:
matrix:
OBJECT_STORE: azure
dockswift:
image: icewind1991/dockswift:nextcloud-ci
environment:
- IPADDRESS=dockswift
when:
matrix:
OBJECT_STORE: swift
selenium:
image: selenium/standalone-firefox:2.53.1-beryllium
environment:
@@ -936,5 +1033,15 @@ services:
when:
matrix:
TESTS: acceptance
openldap:
image: nextcloudci/openldap:openldap-4
environment:
- SLAPD_DOMAIN=nextcloud.ci
- SLAPD_ORGANIZATION=Nextcloud
- SLAPD_PASSWORD=admin
- SLAPD_ADDITIONAL_MODULES=memberof
when:
matrix:
ENABLE_OPENLDAP: true
branches: [ master, stable* ]
branches: [ master, stable14 ]
+10 -1
View File
@@ -1,6 +1,5 @@
# the default generated dir + db file
/data
/owncloud
/config/config.php
/config/*.config.php
/config/mimetype*.json
@@ -8,9 +7,12 @@
/apps/inc.php
/assets
/.htaccess
/translationfiles
/translationtool.phar
# ignore all apps except core ones
/apps*/*
!/apps/accessibility
!/apps/comments
!/apps/dav
!/apps/files
@@ -40,6 +42,9 @@
/apps/files_external/3rdparty/irodsphp/prods/test*
/apps/files_external/tests/config.*.php
# apps modules
/apps/*/node_modules
# ignore themes except the example and the README
/themes/*
@@ -116,6 +121,7 @@ nbproject
/build/jsdocs/
/npm-debug.log
/PhantomJS_*
/build/package-lock.json
# puphpet
puphpet
@@ -133,6 +139,9 @@ Vagrantfile
/tests/autotest*
/tests/data/lorem-copy.txt
/tests/data/testimage-copy.png
/tests/ui-regression/out/
/tests/ui-regression/node_modules/
/tests/ui-regression/package-lock.json
/config/config-autotest-backup.php
/config/autoconfig.php
clover.xml
+2 -2
View File
@@ -23,7 +23,7 @@
<FilesMatch "\.(css|js|svg|gif)$">
Header set Cache-Control "max-age=15778463"
</FilesMatch>
# Let browsers cache WOFF files for a week
<FilesMatch "\.woff$">
Header set Cache-Control "max-age=604800"
@@ -63,7 +63,7 @@
RewriteRule ^\.well-known/caldav /remote.php/dav/ [R=301,L]
RewriteRule ^remote/(.*) remote.php [QSA,L]
RewriteRule ^(?:build|tests|config|lib|3rdparty|templates)/.* - [R=404,L]
RewriteCond %{REQUEST_URI} !^/.well-known/acme-challenge/.*
RewriteCond %{REQUEST_URI} !^/\.well-known/(acme-challenge|pki-validation)/.*
RewriteRule ^(?:\.|autotest|occ|issue|indie|db_|console).* - [R=404,L]
</IfModule>
<IfModule mod_mime.c>
-2
View File
@@ -1,2 +0,0 @@
pattern = "(?i):shipit:|:\\+1:|LGTM|👍"
self_approval_off = true
+129
View File
@@ -0,0 +1,129 @@
[main]
host = https://www.transifex.com
lang_map = bg_BG: bg, cs_CZ: cs, fi_FI: fi, hu_HU: hu, nb_NO: nb, sk_SK: sk, th_TH: th, ja_JP: ja
[nextcloud.core]
file_filter = translationfiles/<lang>/core.po
source_file = translationfiles/templates/core.pot
source_lang = en
type = PO
[nextcloud.files]
file_filter = translationfiles/<lang>/files.po
source_file = translationfiles/templates/files.pot
source_lang = en
type = PO
[nextcloud.settings-1]
file_filter = translationfiles/<lang>/settings.po
source_file = translationfiles/templates/settings.pot
source_lang = en
type = PO
[nextcloud.lib]
file_filter = translationfiles/<lang>/lib.po
source_file = translationfiles/templates/lib.pot
source_lang = en
type = PO
[nextcloud.dav]
file_filter = translationfiles/<lang>/dav.po
source_file = translationfiles/templates/dav.pot
source_lang = en
type = PO
[nextcloud.files_encryption]
file_filter = translationfiles/<lang>/encryption.po
source_file = translationfiles/templates/encryption.pot
source_lang = en
type = PO
[nextcloud.files_external]
file_filter = translationfiles/<lang>/files_external.po
source_file = translationfiles/templates/files_external.pot
source_lang = en
type = PO
[nextcloud.files_sharing]
file_filter = translationfiles/<lang>/files_sharing.po
source_file = translationfiles/templates/files_sharing.pot
source_lang = en
type = PO
[nextcloud.files_trashbin]
file_filter = translationfiles/<lang>/files_trashbin.po
source_file = translationfiles/templates/files_trashbin.pot
source_lang = en
type = PO
[nextcloud.files_versions]
file_filter = translationfiles/<lang>/files_versions.po
source_file = translationfiles/templates/files_versions.pot
source_lang = en
type = PO
[nextcloud.user_ldap]
file_filter = translationfiles/<lang>/user_ldap.po
source_file = translationfiles/templates/user_ldap.pot
source_lang = en
type = PO
[nextcloud.comments]
file_filter = translationfiles/<lang>/comments.po
source_file = translationfiles/templates/comments.pot
source_lang = en
type = PO
[nextcloud.federatedfilesharing]
file_filter = translationfiles/<lang>/federatedfilesharing.po
source_file = translationfiles/templates/federatedfilesharing.pot
source_lang = en
type = PO
[nextcloud.federation]
file_filter = translationfiles/<lang>/federation.po
source_file = translationfiles/templates/federation.pot
source_lang = en
type = PO
[nextcloud.oauth2]
file_filter = translationfiles/<lang>/oauth2.po
source_file = translationfiles/templates/oauth2.pot
source_lang = en
type = PO
[nextcloud.sharebymail]
file_filter = translationfiles/<lang>/sharebymail.po
source_file = translationfiles/templates/sharebymail.pot
source_lang = en
type = PO
[nextcloud.systemtags]
file_filter = translationfiles/<lang>/systemtags.po
source_file = translationfiles/templates/systemtags.pot
source_lang = en
type = PO
[nextcloud.updatenotification]
file_filter = translationfiles/<lang>/updatenotification.po
source_file = translationfiles/templates/updatenotification.pot
source_lang = en
type = PO
[nextcloud.theming]
file_filter = translationfiles/<lang>/theming.po
source_file = translationfiles/templates/theming.pot
source_lang = en
type = PO
[nextcloud.twofactor_backupcodes]
file_filter = translationfiles/<lang>/twofactor_backupcodes.po
source_file = translationfiles/templates/twofactor_backupcodes.pot
source_lang = en
type = PO
[nextcloud.workflowengine]
file_filter = translationfiles/<lang>/workflowengine.po
source_file = translationfiles/templates/workflowengine.pot
source_lang = en
type = PO
+1 -1
View File
@@ -58,7 +58,7 @@ like `git config --global alias.ci 'commit -s'`. Now you can commit with
In case you are not sure how to add or update the license header correctly please have a look at [contribute/HowToApplyALicense.md][applyalicense]
[devmanual]: https://docs.nextcloud.org/server/12/developer_manual/
[devmanual]: https://docs.nextcloud.org/server/13/developer_manual/
[dcofile]: https://github.com/nextcloud/server/blob/master/contribute/developer-certificate-of-origin
[applyalicense]: https://github.com/nextcloud/server/blob/master/contribute/HowToApplyALicense.md
+15 -2
View File
@@ -36,7 +36,16 @@
[…learn more about how to get support for Nextcloud here!](https://nextcloud.com/support)
## Contribution Guidelines
## Join the team :family:
### How to contribute
1. [Set up your local development environment](https://docs.nextcloud.com/server/14/developer_manual/general/devenv.html) :rocket:
2. [Pick a good first issue](https://github.com/nextcloud/server/labels/good%20first%20issue) :notebook:
3. Create a branch, a [Pull Request](https://opensource.guide/how-to-contribute/#opening-a-pull-request) and `@mention` the people from the issue :computer:
4. Wait for it to get merged and :tada:
### Contribution Guidelines
All contributions to this repository from June, 16 2016 on are considered to be
licensed under the AGPLv3 or any later version.
@@ -56,7 +65,7 @@ Please review the [guidelines for contributing](https://github.com/nextcloud/ser
More information how to contribute: [https://nextcloud.com/contribute/](https://nextcloud.com/contribute/)
## Running master checkouts
### Running master checkouts
Third-party components are handled as git submodules which have to be initialized first. So aside from the regular git checkout invoking `git submodule update --init` or a similar command is needed, for details see Git documentation.
@@ -65,3 +74,7 @@ Several apps that are included by default in regular releases such as [firstrunw
That aside Git checkouts can be handled the same as release archives.
Note they should never be used on production systems.
## Tools we use
[![BrowserStack](https://user-images.githubusercontent.com/45821/41675934-61fa3442-74c4-11e8-8c8e-90768c56ba08.png)](https://www.browserstack.com/)
+12
View File
@@ -0,0 +1,12 @@
{
"presets": [
[
"env",
{
"targets": {
"browsers": ["last 2 versions", "not ie <= 11"]
}
}
]
]
}
+9
View File
@@ -0,0 +1,9 @@
root = true
[*]
charset = utf-8
indent_style = tab
indent_size = 4
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true
+16
View File
@@ -0,0 +1,16 @@
module.exports = {
env: {
browser: true,
es6: true
},
extends: 'eslint:recommended',
parserOptions: {
sourceType: 'module'
},
rules: {
indent: ['error', 'tab'],
'linebreak-style': ['error', 'unix'],
quotes: ['error', 'single'],
semi: ['error', 'always']
}
};
+12
View File
@@ -0,0 +1,12 @@
.DS_Store
node_modules/
dist/
npm-debug.log
yarn-error.log
# Editor directories and files
.idea
*.suo
*.ntvs*
*.njsproj
*.sln
+3
View File
@@ -0,0 +1,3 @@
{
"esversion": 6
}
+26
View File
@@ -0,0 +1,26 @@
all: dev-setup build-js-production
dev-setup: clean clean-dev npm-init
npm-init:
npm install
npm-update:
npm update
build-js:
npm run dev
build-js-production:
npm run build
watch-js:
npm run watch
clean:
rm -f js/accessibility.js
rm -f js/accessibility.js.map
clean-dev:
rm -rf node_modules
+22
View File
@@ -0,0 +1,22 @@
# Accessibility ♿
> This app provide multiple features to ease the use of nextcloud.
## Build Setup
``` bash
# install dependencies
make dev-setup
# build for development
make build-js
# build for development and watch edits
make watch-js
# build for production with minification
make build-js-production
# clean output files
make clean
```
+30
View File
@@ -0,0 +1,30 @@
<?php
declare (strict_types = 1);
/**
* @copyright Copyright (c) 2018 John Molakvoæ <skjnldsv@protonmail.com>
*
* @author John Molakvoæ <skjnldsv@protonmail.com>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
$app = new \OCA\Accessibility\AppInfo\Application();
// Separate from the constructor since the route are not initialized before that
// 1. create the app
// 2. generate css route and inject
$app->injectCss();
+23
View File
@@ -0,0 +1,23 @@
<?xml version="1.0"?>
<info xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd">
<id>accessibility</id>
<name>Accessibility</name>
<summary>Accessibility options for nextcloud</summary>
<description><![CDATA[Provides multiple accessibilities options to ease your use of nextcloud]]></description>
<version>1.0.1</version>
<licence>agpl</licence>
<author>John Molakvoæ</author>
<namespace>Accessibility</namespace>
<category>accessibility</category>
<default_enable/>
<dependencies>
<nextcloud min-version="14" max-version="14"/>
</dependencies>
<default_enable/>
<bugs>https://github.com/nextcloud/server/issues</bugs>
<settings>
<personal>OCA\Accessibility\Settings\Personal</personal>
<personal-section>OCA\Accessibility\Settings\PersonalSection</personal-section>
</settings>
</info>
+40
View File
@@ -0,0 +1,40 @@
<?php
/**
* @copyright Copyright (c) 2018 John Molakvoæ <skjnldsv@protonmail.com>
*
* @author John Molakvoæ <skjnldsv@protonmail.com>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
return [
'routes' => [
['name' => 'accessibility#getCss', 'url' => '/css/user-{md5}.css', 'verb' => 'GET'],
],
'ocs' => [
[
'name' => 'Config#getConfig',
'url' => '/api/v1/config',
'verb' => 'GET',
],
[
'name' => 'Config#setConfig',
'url' => '/api/v1/config/{key}',
'verb' => 'POST',
],
]
];
+22
View File
@@ -0,0 +1,22 @@
@font-face {
font-family: 'OpenDyslexic';
font-style: normal;
font-weight: 300;
src: url('../fonts/OpenDyslexic-Regular.woff') format('woff');
}
@font-face {
font-family: 'OpenDyslexic';
font-style: normal;
font-weight: normal;
src: url('../fonts/OpenDyslexic-Regular.woff') format('woff');
}
@font-face {
font-family: 'OpenDyslexic';
font-style: normal;
font-weight: 600;
src: url('../fonts/OpenDyslexic-Bold.woff') format('woff');
}
$font-face: OpenDyslexic, 'Open Sans', Frutiger, Calibri, 'Myriad Pro', Myriad, sans-serif;
+59
View File
@@ -0,0 +1,59 @@
.preview-list {
display: flex;
flex-wrap: wrap;
}
.preview {
display: flex;
flex-direction: column;
min-width: 250px;
max-width: 400px;
flex: 1 1 300px;
border: 1px solid var(--color-border);
padding: 10px;
border-radius: var(--border-radius);
transition: all 200ms ease-in-out;
filter: drop-shadow(0 1px 2px var(--color-box-shadow));
background-color: var(--color-main-background);
opacity: 0.9;
margin: 10px;
position: relative;
&,
* {
cursor: pointer;
user-select: none;
}
&:hover,
&:focus,
&.selected {
filter: drop-shadow(0 1px 4px var(--color-box-shadow));
opacity: 1;
}
.preview-image {
height: 200px;
background-position: top left;
background-size: cover;
background-repeat: no-repeat;
}
h3 {
display: flex;
justify-content: space-between;
line-height: 1em;
align-items: center;
}
p {
text-align: justify;
}
.icon-checkmark-color {
transition: all 100ms ease-in-out;
border-radius: 1em;
padding: 4px 5px 4px 20px;
background-position: 4px center;
opacity: 0;
visibility: hidden;
}
&.selected .icon-checkmark-color {
opacity: 1;
visibility: visible;
box-shadow: 0 0 0 1px var(--color-success);
}
}
+52
View File
@@ -0,0 +1,52 @@
// SCSS variables
$color-main-text: #d8d8d8;
$color-main-background: #181818;
$color-background-dark: lighten($color-main-background, 4%);
$color-background-darker: lighten($color-main-background, 8%);
$color-text-maxcontrast: darken($color-main-text, 30%);
$color-text-light: darken($color-main-text, 10%);
$color-text-lighter: darken($color-main-text, 20%);
$color-loading-light: #777;
$color-loading-dark: #ccc;
$color-box-shadow: rgba(darken($color-main-background, 70%), 0.5);
$color-border: lighten($color-main-background, 7%);
$color-border-dark: lighten($color-main-background, 14%);
#app-navigation > ul > li > a:first-child,
#app-navigation > ul > li > ul > li > a:first-child,
#expanddiv a {
img {
filter: invert(100%);
}
}
.bubble,
.app-navigation-entry-menu,
.popovermenu {
li {
> button,
> a,
> .menuitem {
> img {
filter: invert(100%);
}
}
}
}
.bubble,
.app-navigation-entry-menu,
.popovermenu,
#header .menu {
border: 1px solid var(--color-border);
}
// since svg icons are inverted, revert to white for the header
.header-right > * {
[class^='icon-'], [class*=' icon-'] {
filter: invert(100%);
}
}
@@ -0,0 +1,57 @@
// Fonts
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: normal;
src: local('Open Sans'), local('OpenSans'),
url('../../../core/fonts/OpenSans-Regular.woff') format('woff');
}
/* overriding default light */
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 300;
src: local('Open Sans'), local('OpenSans'),
url('../../../core/fonts/OpenSans-Regular.woff') format('woff');
}
@font-face {
font-family: 'Open Sans';
font-style: normal;
font-weight: 500 700;
src: local('Open Sans Bold'), local('OpenSans-Bold'),
url('../../../core/fonts/OpenSans-Bold.woff') format('woff');
}
// SCSS variables
$color-main-text: #000;
$color-main-background: #fff;
$color-background-dark: darken($color-main-background, 30%);
$color-background-darker: darken($color-main-background, 30%);
$color-text-maxcontrast: $color-main-text;
$color-text-light: $color-main-text;
$color-text-lighter: $color-main-text;
$color-loading-light: #ddd;
$color-loading-dark: #000;
$color-box-shadow: $color-main-text;
$color-border: darken($color-main-background, 50%);
$color-border-dark: darken($color-main-background, 50%);
$font-face: 'Open Sans', Frutiger, Calibri, 'Myriad Pro', Myriad, sans-serif;
// Font weight reset
body {
font-weight: 400;
}
[class^='icon-'], [class*=' icon-'],
.action {
opacity: 1 !important;
}
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
+76
View File
@@ -0,0 +1,76 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg
xmlns:dc="http://purl.org/dc/elements/1.1/"
xmlns:cc="http://creativecommons.org/ns#"
xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
xmlns:svg="http://www.w3.org/2000/svg"
xmlns="http://www.w3.org/2000/svg"
xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
version="1.1"
id="svg2"
width="16"
height="16"
viewBox="0 0 16 16"
sodipodi:docname="app-dark.svg"
inkscape:version="0.92.2 5c3e80d, 2017-08-06">
<metadata
id="metadata8">
<rdf:RDF>
<cc:Work
rdf:about="">
<dc:format>image/svg+xml</dc:format>
<dc:type
rdf:resource="http://purl.org/dc/dcmitype/StillImage" />
<dc:title></dc:title>
</cc:Work>
</rdf:RDF>
</metadata>
<defs
id="defs6" />
<sodipodi:namedview
pagecolor="#ffffff"
bordercolor="#666666"
borderopacity="1"
objecttolerance="10"
gridtolerance="10"
guidetolerance="10"
inkscape:pageopacity="0"
inkscape:pageshadow="2"
inkscape:window-width="1880"
inkscape:window-height="993"
id="namedview4"
showgrid="false"
showguides="true"
inkscape:guide-bbox="true"
inkscape:zoom="36.460193"
inkscape:cx="8.4752826"
inkscape:cy="18.273624"
inkscape:window-x="20"
inkscape:window-y="67"
inkscape:window-maximized="0"
inkscape:current-layer="g848"
fit-margin-top="0"
fit-margin-left="0"
fit-margin-right="0"
fit-margin-bottom="0" />
<g
id="g848"
transform="matrix(1.1307959,0,0,1.0801738,-1.0463882,-0.84269722)"
style="stroke-width:0.90481776;fill:#000000">
<circle
r="1.9587879"
cy="2.8315151"
cx="7.990303"
id="path844"
style="opacity:1;fill:#000000;fill-opacity:1;stroke:none;stroke-width:0.90481776;stroke-linecap:round;stroke-linejoin:round;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;paint-order:stroke markers fill" />
<path
sodipodi:nodetypes="scsssscsccccczzcccccssssccsscs"
inkscape:connector-curvature="0"
id="path843"
d="m 2.3519709,4.2557871 c -0.3126291,0 -0.4819578,0.1287194 -0.5322266,0.4028321 -0.053173,0.2899914 0.1062609,0.5159057 0.4370117,0.6274414 1.420521,0.4790277 2.4256503,0.6675279 3.8410483,0.9800416 0.327839,0.072385 0.6900295,0.2893751 0.6520998,1.0948483 C 6.6985575,8.451345 6.6372144,9.7041167 6.2631031,11.323353 6.0397526,12.290062 5.6782112,13.622766 5.4305838,14.3922 5.3416728,14.668443 5.281658,14.922355 5.281658,15.031849 c 0,0.08257 0.053443,0.249642 0.097656,0.307617 0.023823,0.03125 0.075039,0.07397 0.1147462,0.09522 0.062879,0.03361 0.096262,0.03787 0.2612304,0.03663 0.3361373,-0.0026 0.4608113,-0.08245 0.6665037,-0.429687 0.4838657,-0.939315 0.7378785,-2.132191 0.9402993,-3.014266 0.092189,-0.517235 0.2624476,-1.66347 0.6710287,-1.66347 0.4085811,0 0.4979093,0.95008 0.6812062,1.687228 0.1832969,0.737148 0.6122738,2.295202 0.7738717,2.704862 0.2137476,0.54186 0.5742238,0.836985 0.8764648,0.717774 0.03316,-0.01301 0.116937,-0.04526 0.187989,-0.0708 0.147435,-0.053 0.186715,-0.07824 0.219726,-0.156249 0.0655,-0.154793 -0.01013,-0.454047 -0.349121,-1.41114 C 9.7721847,11.597192 9.2651806,9.3990255 9.3334308,7.2974743 9.3630343,6.3859259 9.6837054,6.305369 10.075725,6.2075087 c 1.17285,-0.2927798 2.00228,-0.379973 3.387085,-0.8579717 0.468513,-0.1617184 0.727539,-0.2608264 0.727539,-0.5590819 0,-0.2554049 -0.153084,-0.4346541 -0.437011,-0.5102538 -0.116851,-0.031101 -0.318383,-0.028905 -0.632326,0.00243 -1.085189,0.10834 -2.939683,0.5153868 -4.0234365,0.6710819 -0.529944,0.076133 -1.7229392,0.094015 -2.2729489,0 C 5.6763224,4.7574297 4.1363176,4.4147025 2.9061699,4.2997326 2.6560099,4.2763537 2.4068766,4.2557871 2.3519709,4.2557871 Z"
style="fill:#000000;stroke-width:0.9048177" />
</g>
</svg>

After

Width:  |  Height:  |  Size: 4.0 KiB

+76
View File
@@ -0,0 +1,76 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg
xmlns:dc="http://purl.org/dc/elements/1.1/"
xmlns:cc="http://creativecommons.org/ns#"
xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
xmlns:svg="http://www.w3.org/2000/svg"
xmlns="http://www.w3.org/2000/svg"
xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
version="1.1"
id="svg2"
width="16"
height="16"
viewBox="0 0 16 16"
sodipodi:docname="app.svg"
inkscape:version="0.92.2 5c3e80d, 2017-08-06">
<metadata
id="metadata8">
<rdf:RDF>
<cc:Work
rdf:about="">
<dc:format>image/svg+xml</dc:format>
<dc:type
rdf:resource="http://purl.org/dc/dcmitype/StillImage" />
<dc:title></dc:title>
</cc:Work>
</rdf:RDF>
</metadata>
<defs
id="defs6" />
<sodipodi:namedview
pagecolor="#ffffff"
bordercolor="#666666"
borderopacity="1"
objecttolerance="10"
gridtolerance="10"
guidetolerance="10"
inkscape:pageopacity="0"
inkscape:pageshadow="2"
inkscape:window-width="1880"
inkscape:window-height="993"
id="namedview4"
showgrid="false"
showguides="true"
inkscape:guide-bbox="true"
inkscape:zoom="36.460193"
inkscape:cx="8.4752826"
inkscape:cy="18.273624"
inkscape:window-x="20"
inkscape:window-y="67"
inkscape:window-maximized="0"
inkscape:current-layer="g848"
fit-margin-top="0"
fit-margin-left="0"
fit-margin-right="0"
fit-margin-bottom="0" />
<g
id="g848"
transform="matrix(1.1307959,0,0,1.0801738,-1.0463882,-0.84269722)"
style="stroke-width:0.90481776;fill:#000000">
<circle
r="1.9587879"
cy="2.8315151"
cx="7.990303"
id="path844"
style="opacity:1;fill:#ffffff;fill-opacity:1;stroke:none;stroke-width:0.90481776;stroke-linecap:round;stroke-linejoin:round;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;paint-order:stroke markers fill" />
<path
sodipodi:nodetypes="scsssscsccccczzcccccssssccsscs"
inkscape:connector-curvature="0"
id="path843"
d="m 2.3519709,4.2557871 c -0.3126291,0 -0.4819578,0.1287194 -0.5322266,0.4028321 -0.053173,0.2899914 0.1062609,0.5159057 0.4370117,0.6274414 1.420521,0.4790277 2.4256503,0.6675279 3.8410483,0.9800416 0.327839,0.072385 0.6900295,0.2893751 0.6520998,1.0948483 C 6.6985575,8.451345 6.6372144,9.7041167 6.2631031,11.323353 6.0397526,12.290062 5.6782112,13.622766 5.4305838,14.3922 5.3416728,14.668443 5.281658,14.922355 5.281658,15.031849 c 0,0.08257 0.053443,0.249642 0.097656,0.307617 0.023823,0.03125 0.075039,0.07397 0.1147462,0.09522 0.062879,0.03361 0.096262,0.03787 0.2612304,0.03663 0.3361373,-0.0026 0.4608113,-0.08245 0.6665037,-0.429687 0.4838657,-0.939315 0.7378785,-2.132191 0.9402993,-3.014266 0.092189,-0.517235 0.2624476,-1.66347 0.6710287,-1.66347 0.4085811,0 0.4979093,0.95008 0.6812062,1.687228 0.1832969,0.737148 0.6122738,2.295202 0.7738717,2.704862 0.2137476,0.54186 0.5742238,0.836985 0.8764648,0.717774 0.03316,-0.01301 0.116937,-0.04526 0.187989,-0.0708 0.147435,-0.053 0.186715,-0.07824 0.219726,-0.156249 0.0655,-0.154793 -0.01013,-0.454047 -0.349121,-1.41114 C 9.7721847,11.597192 9.2651806,9.3990255 9.3334308,7.2974743 9.3630343,6.3859259 9.6837054,6.305369 10.075725,6.2075087 c 1.17285,-0.2927798 2.00228,-0.379973 3.387085,-0.8579717 0.468513,-0.1617184 0.727539,-0.2608264 0.727539,-0.5590819 0,-0.2554049 -0.153084,-0.4346541 -0.437011,-0.5102538 -0.116851,-0.031101 -0.318383,-0.028905 -0.632326,0.00243 -1.085189,0.10834 -2.939683,0.5153868 -4.0234365,0.6710819 -0.529944,0.076133 -1.7229392,0.094015 -2.2729489,0 C 5.6763224,4.7574297 4.1363176,4.4147025 2.9061699,4.2997326 2.6560099,4.2763537 2.4068766,4.2557871 2.3519709,4.2557871 Z"
style="fill:#ffffff;stroke-width:0.9048177" />
</g>
</svg>

After

Width:  |  Height:  |  Size: 3.9 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 64 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 60 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 65 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 54 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 65 KiB

File diff suppressed because one or more lines are too long
File diff suppressed because one or more lines are too long
@@ -0,0 +1,83 @@
<?php
/**
* @copyright Copyright (c) 2018 John Molakvoæ <skjnldsv@protonmail.com>
*
* @author John Molakvoæ <skjnldsv@protonmail.com>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
namespace OCA\Accessibility;
use OCP\IL10N;
use OCP\IURLGenerator;
class AccessibilityProvider {
/** @var string */
protected $appName;
/** @var IURLGenerator */
private $urlGenerator;
/** @var IL10N */
private $l;
/**
* Account constructor.
*
* @param string $appName
* @param IURLGenerator $urlGenerator
* @param IL10N $l
*/
public function __construct(string $appName,
IURLGenerator $urlGenerator,
IL10N $l) {
$this->appName = $appName;
$this->urlGenerator = $urlGenerator;
$this->l = $l;
}
public function getThemes() {
return array(
[
'id' => 'themehighcontrast',
'img' => $this->urlGenerator->imagePath($this->appName, 'theme-highcontrast.jpg'),
'title' => $this->l->t('High contrast theme'),
'text' => $this->l->t('A high contrast theme to ease your navigation. Visual quality will be reduced but clarity will be increased.')
], [
'id' => 'themedark',
'img' => $this->urlGenerator->imagePath($this->appName, 'theme-dark.jpg'),
'title' => $this->l->t('Dark theme (beta)'),
'text' => $this->l->t('A dark theme to ease your eyes by reducing the overall luminosity and brightness. It is still under development, so please report any issues you may find.')
]
);
}
public function getFonts() {
return array(
[
'id' => 'fontdyslexic',
'img' => $this->urlGenerator->imagePath($this->appName, 'font-opendyslexic.jpg'),
'title' => $this->l->t('Dyslexia font'),
'text' => $this->l->t('OpenDyslexic is a free typeface/font designed to mitigate some of the common reading errors caused by dyslexia. The typeface was created by Abelardo Gonzalez, who released it through an open-source license.')
]
);
}
}
@@ -0,0 +1,63 @@
<?php
/**
* @copyright Copyright (c) 2018 John Molakvoæ <skjnldsv@protonmail.com>
*
* @author John Molakvoæ <skjnldsv@protonmail.com>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
namespace OCA\Accessibility\AppInfo;
use OCP\AppFramework\App;
use OCP\IConfig;
use OCP\IUserSession;
use OCP\IURLGenerator;
class Application extends App {
/** @var string */
protected $appName = 'accessibility';
/** @var IConfig */
private $config;
/** @var IUserSession */
private $userSession;
/** @var IURLGenerator */
private $urlGenerator;
public function __construct() {
parent::__construct($this->appName);
$this->config = \OC::$server->getConfig();
$this->userSession = \OC::$server->getUserSession();
$this->urlGenerator = \OC::$server->getURLGenerator();
}
public function injectCss() {
// Inject the fake css on all pages if enabled and user is logged
$loggedUser = $this->userSession->getUser();
if (!is_null($loggedUser)) {
$userValues = $this->config->getUserKeys($loggedUser->getUID(), $this->appName);
if (count($userValues) > 0) {
$linkToCSS = $this->urlGenerator->linkToRoute($this->appName . '.accessibility.getCss', ['md5' => md5(implode('-', $userValues))]);
\OCP\Util::addHeader('link', ['rel' => 'stylesheet', 'href' => $linkToCSS]);
}
}
}
}
@@ -0,0 +1,256 @@
<?php
declare (strict_types = 1);
/**
* @copyright Copyright (c) 2018 John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
namespace OCA\Accessibility\Controller;
use Leafo\ScssPhp\Compiler;
use Leafo\ScssPhp\Exception\ParserException;
use Leafo\ScssPhp\Formatter\Crunched;
use OCP\AppFramework\Controller;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\DataDisplayResponse;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\App\IAppManager;
use OCP\IConfig;
use OCP\ILogger;
use OCP\IRequest;
use OCP\IURLGenerator;
use OCP\IUserManager;
use OCP\IUserSession;
use OC\Template\IconsCacher;
class AccessibilityController extends Controller {
/** @var string */
protected $appName;
/** @var string */
protected $serverRoot;
/** @var IConfig */
private $config;
/** @var IUserManager */
private $userManager;
/** @var ILogger */
private $logger;
/** @var IURLGenerator */
private $urlGenerator;
/** @var ITimeFactory */
protected $timeFactory;
/** @var IUserSession */
private $userSession;
/** @var IAppManager */
private $appManager;
/** @var IconsCacher */
protected $iconsCacher;
/** @var \OC_Defaults */
private $defaults;
/** @var null|string */
private $injectedVariables;
/**
* Account constructor.
*
* @param string $appName
* @param IRequest $request
* @param IConfig $config
* @param IUserManager $userManager
* @param ILogger $logger
* @param IURLGenerator $urlGenerator
* @param ITimeFactory $timeFactory
* @param IUserSession $userSession
* @param IAppManager $appManager
* @param \OC_Defaults $defaults
*/
public function __construct(string $appName,
IRequest $request,
IConfig $config,
IUserManager $userManager,
ILogger $logger,
IURLGenerator $urlGenerator,
ITimeFactory $timeFactory,
IUserSession $userSession,
IAppManager $appManager,
IconsCacher $iconsCacher,
\OC_Defaults $defaults) {
parent::__construct($appName, $request);
$this->appName = $appName;
$this->config = $config;
$this->userManager = $userManager;
$this->logger = $logger;
$this->urlGenerator = $urlGenerator;
$this->timeFactory = $timeFactory;
$this->userSession = $userSession;
$this->appManager = $appManager;
$this->iconsCacher = $iconsCacher;
$this->defaults = $defaults;
$this->serverRoot = \OC::$SERVERROOT;
$this->appRoot = $this->appManager->getAppPath($this->appName);
}
/**
* @NoAdminRequired
* @NoCSRFRequired
*
* @return DataDisplayResponse
*/
public function getCss(): DataDisplayResponse {
$css = '';
$imports = '';
$userValues = $this->getUserValues();
foreach ($userValues as $key => $scssFile) {
if ($scssFile !== false) {
$imports .= '@import "' . $scssFile . '";';
}
}
if ($imports !== '') {
$scss = new Compiler();
$scss->setImportPaths([
$this->appRoot . '/css/',
$this->serverRoot . '/core/css/'
]);
// Continue after throw
$scss->setIgnoreErrors(true);
$scss->setFormatter(Crunched::class);
// Import theme, variables and compile css4 variables
try {
$css .= $scss->compile(
$imports .
$this->getInjectedVariables() .
'@import "variables.scss";' .
'@import "css-variables.scss";'
);
} catch (ParserException $e) {
$this->logger->error($e->getMessage(), ['app' => 'core']);
}
}
// We don't want to override vars with url since path is different
$css = $this->filterOutRule('/--[a-z-:]+url\([^;]+\)/mi', $css);
// Rebase all urls
$appWebRoot = substr($this->appRoot, strlen($this->serverRoot) - strlen(\OC::$WEBROOT));
$css = $this->rebaseUrls($css, $appWebRoot . '/css');
if (in_array('themedark', $userValues) && $this->iconsCacher->getCachedCSS() && $this->iconsCacher->getCachedCSS()->getSize() > 0) {
$iconsCss = $this->invertSvgIconsColor($this->iconsCacher->getCachedCSS()->getContent());
$css = $css . $iconsCss;
}
$response = new DataDisplayResponse($css, Http::STATUS_OK, ['Content-Type' => 'text/css']);
// Set cache control
$ttl = 31536000;
$response->addHeader('Cache-Control', 'max-age=' . $ttl . ', immutable');
$expires = new \DateTime();
$expires->setTimestamp($this->timeFactory->getTime());
$expires->add(new \DateInterval('PT' . $ttl . 'S'));
$response->addHeader('Expires', $expires->format(\DateTime::RFC1123));
$response->addHeader('Pragma', 'cache');
return $response;
}
/**
* Return an array with the user theme & font settings
*
* @return array
*/
private function getUserValues(): array{
$userTheme = $this->config->getUserValue($this->userSession->getUser()->getUID(), $this->appName, 'theme', false);
$userFont = $this->config->getUserValue($this->userSession->getUser()->getUID(), $this->appName, 'font', false);
return [$userTheme, $userFont];
}
/**
* Remove all matches from the $rule regex
*
* @param string $rule regex to match
* @param string $css string to parse
* @return string
*/
private function filterOutRule(string $rule, string $css): string {
return preg_replace($rule, '', $css);
}
/**
* Add the correct uri prefix to make uri valid again
*
* @param string $css
* @param string $webDir
* @return string
*/
private function rebaseUrls(string $css, string $webDir): string {
$re = '/url\([\'"]([^\/][\.\w?=\/-]*)[\'"]\)/x';
$subst = 'url(\'' . $webDir . '/$1\')';
return preg_replace($re, $subst, $css);
}
/**
* Remove all matches from the $rule regex
*
* @param string $css string to parse
* @return string
*/
private function invertSvgIconsColor(string $css) {
return str_replace(['/000', '/fff', '/***'], ['/***', '/000', '/fff'], $css);
}
/**
* @return string SCSS code for variables from OC_Defaults
*/
private function getInjectedVariables(): string {
if ($this->injectedVariables !== null) {
return $this->injectedVariables;
}
$variables = '';
foreach ($this->defaults->getScssVariables() as $key => $value) {
$variables .= '$' . $key . ': ' . $value . ';';
}
// check for valid variables / otherwise fall back to defaults
try {
$scss = new Compiler();
$scss->compile($variables);
$this->injectedVariables = $variables;
} catch (ParserException $e) {
$this->logger->error($e, ['app' => 'core']);
}
return $variables;
}
}
@@ -0,0 +1,121 @@
<?php
declare (strict_types = 1);
/**
* @copyright Copyright (c) 2018 John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
namespace OCA\Accessibility\Controller;
use OCA\Accessibility\AccessibilityProvider;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\DataResponse;
use OCP\AppFramework\OCSController;
use OCP\AppFramework\OCS\OCSBadRequestException;
use OCP\IConfig;
use OCP\IRequest;
use OCP\IUserSession;
class ConfigController extends OCSController {
/** @var string */
protected $appName;
/** @var string */
protected $serverRoot;
/** @var IConfig */
private $config;
/** @var IUserSession */
private $userSession;
/** @var AccessibilityProvider */
private $accessibilityProvider;
/**
* Config constructor.
*
* @param string $appName
* @param IRequest $request
* @param IConfig $config
* @param IUserSession $userSession
* @param AccessibilityProvider $accessibilityProvider
*/
public function __construct(string $appName,
IRequest $request,
IConfig $config,
IUserSession $userSession,
AccessibilityProvider $accessibilityProvider) {
parent::__construct($appName, $request);
$this->appName = $appName;
$this->config = $config;
$this->userSession = $userSession;
$this->accessibilityProvider = $accessibilityProvider;
}
/**
* @NoAdminRequired
*
* Get user accessibility config
*
* @param string $key theme or font
* @return DataResponse
*/
public function getConfig(): DataResponse {
return new DataResponse([
'theme' => $this->config->getUserValue($this->userSession->getUser()->getUID(), $this->appName, 'theme', false),
'font' => $this->config->getUserValue($this->userSession->getUser()->getUID(), $this->appName, 'font', false)
]);
}
/**
* @NoAdminRequired
*
* Set theme or font config
*
* @param string $key theme or font
* @return DataResponse
* @throws Exception
*/
public function setConfig(string $key, $value): DataResponse {
if ($key === 'theme' || $key === 'font') {
$themes = $this->accessibilityProvider->getThemes();
$fonts = $this->accessibilityProvider->getFonts();
if ($value === false) {
$this->config->deleteUserValue($this->userSession->getUser()->getUID(), $this->appName, $key);
return new DataResponse();
}
$availableOptions = array_map(function($option) {
return $option['id'];
}, array_merge($themes, $fonts));
if (in_array($value, $availableOptions)) {
$this->config->setUserValue($this->userSession->getUser()->getUID(), $this->appName, $key, $value);
return new DataResponse();
}
throw new OCSBadRequestException('Invalid value: ' . $value);
}
throw new OCSBadRequestException('Invalid key: ' . $key);
}
}
@@ -0,0 +1,113 @@
<?php
/**
* @copyright Copyright (c) 2018 John Molakvoæ <skjnldsv@protonmail.com>
*
* @author John Molakvoæ <skjnldsv@protonmail.com>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
namespace OCA\Accessibility\Settings;
use OCA\Accessibility\AccessibilityProvider;
use OCP\AppFramework\Http\TemplateResponse;
use OCP\IConfig;
use OCP\IL10N;
use OCP\IURLGenerator;
use OCP\IUserSession;
use OCP\Settings\ISettings;
class Personal implements ISettings {
/** @var string */
protected $appName;
/** @var IConfig */
private $config;
/** @var IUserSession */
private $userSession;
/** @var IL10N */
private $l;
/** @var IURLGenerator */
private $urlGenerator;
/** @var AccessibilityProvider */
private $accessibilityProvider;
/**
* Settings constructor.
*
* @param string $appName
* @param IConfig $config
* @param IUserSession $userSession
* @param IL10N $l
* @param IURLGenerator $urlGenerator
* @param AccessibilityProvider $accessibilityProvider
*/
public function __construct(string $appName,
IConfig $config,
IUserSession $userSession,
IL10N $l,
IURLGenerator $urlGenerator,
AccessibilityProvider $accessibilityProvider) {
$this->appName = $appName;
$this->config = $config;
$this->userSession = $userSession;
$this->l = $l;
$this->urlGenerator = $urlGenerator;
$this->accessibilityProvider = $accessibilityProvider;
}
/**
* @return TemplateResponse returns the instance with all parameters set, ready to be rendered
* @since 9.1
*/
public function getForm() {
$serverData = [
'themes' => $this->accessibilityProvider->getThemes(),
'fonts' => $this->accessibilityProvider->getFonts(),
'theme' => $this->config->getUserValue($this->userSession->getUser()->getUID(), $this->appName, 'theme', false),
'font' => $this->config->getUserValue($this->userSession->getUser()->getUID(), $this->appName, 'font', false)
];
return new TemplateResponse($this->appName, 'settings-personal', ['serverData' => $serverData]);
}
/**
* @return string the section ID, e.g. 'sharing'
* @since 9.1
*/
public function getSection() {
return $this->appName;
}
/**
* @return int whether the form should be rather on the top or bottom of
* the admin section. The forms are arranged in ascending order of the
* priority values. It is required to return a value between 0 and 100.
*
* E.g.: 70
* @since 9.1
*/
public function getPriority() {
return 40;
}
}
@@ -0,0 +1,100 @@
<?php
/**
* @copyright Copyright (c) 2018 John Molakvoæ <skjnldsv@protonmail.com>
*
* @author John Molakvoæ <skjnldsv@protonmail.com>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
namespace OCA\Accessibility\Settings;
use OCP\IL10N;
use OCP\IURLGenerator;
use OCP\Settings\IIconSection;
class PersonalSection implements IIconSection {
/** @var string */
protected $appName;
/** @var IURLGenerator */
private $urlGenerator;
/** @var IL10N */
private $l;
/**
* Personal Section constructor.
*
* @param string $appName
* @param IURLGenerator $urlGenerator
* @param IL10N $l
*/
public function __construct(string $appName,
IURLGenerator $urlGenerator,
IL10N $l) {
$this->appName = $appName;
$this->urlGenerator = $urlGenerator;
$this->l = $l;
}
/**
* returns the relative path to an 16*16 icon describing the section.
* e.g. '/core/img/places/files.svg'
*
* @returns string
* @since 13.0.0
*/
public function getIcon() {
return $this->urlGenerator->imagePath($this->appName, 'app-dark.svg');
}
/**
* returns the ID of the section. It is supposed to be a lower case string,
* e.g. 'ldap'
*
* @returns string
* @since 9.1
*/
public function getID() {
return $this->appName;
}
/**
* returns the translated name as it should be displayed, e.g. 'LDAP / AD
* integration'. Use the L10N service to translate it.
*
* @return string
* @since 9.1
*/
public function getName() {
return $this->l->t('Accessibility');
}
/**
* @return int whether the form should be rather on the top or bottom of
* the settings navigation. The sections are arranged in ascending order of
* the priority values. It is required to return a value between 0 and 99.
*
* E.g.: 70
* @since 9.1
*/
public function getPriority() {
return 15;
}
}
File diff suppressed because it is too large Load Diff
+33
View File
@@ -0,0 +1,33 @@
{
"name": "accessibility",
"description": "Provides multiple accessibilities options to ease your use of nextcloud",
"version": "1.0.1",
"author": "John Molakvoæ <skjnldsv@protonmail.com>",
"license": "agpl",
"private": true,
"scripts": {
"dev": "webpack --config webpack.dev.js",
"watch": "webpack --progress --watch --config webpack.dev.js",
"build": "webpack --progress --hide-modules --config webpack.prod.js"
},
"dependencies": {
"axios": "^0.18.0",
"vue": "^2.5.16"
},
"browserslist": [
"last 2 versions",
"not ie <= 11"
],
"devDependencies": {
"babel-core": "^6.26.3",
"babel-loader": "^7.1.5",
"babel-preset-env": "^1.7.0",
"css-loader": "^1.0.0",
"file-loader": "^1.1.11",
"vue-loader": "^15.2.6",
"vue-template-compiler": "^2.5.16",
"webpack": "^4.16.1",
"webpack-cli": "^3.1.0",
"webpack-merge": "^4.1.3"
}
}
+101
View File
@@ -0,0 +1,101 @@
<template>
<div id="accessibility">
<div id="themes" class="section">
<h2>{{t('accessibility', 'Themes')}}</h2>
<div class="themes-list preview-list">
<preview v-for="preview in themes" :preview="preview"
:key="preview.id" :selected="selected.theme"
v-on:select="selectTheme"></preview>
</div>
</div>
<div id="fonts" class="section">
<h2>{{t('accessibility', 'Fonts')}}</h2>
<div class="fonts-list preview-list">
<preview v-for="preview in fonts" :preview="preview"
:key="preview.id" :selected="selected.font"
v-on:select="selectFont"></preview>
</div>
</div>
</div>
</template>
<script>
import preview from './components/itemPreview';
import axios from 'axios';
export default {
name: 'app',
components: { preview },
beforeMount() {
// importing server data into the app
const serverDataElmt = document.getElementById('serverData');
if (serverDataElmt !== null) {
this.serverData = JSON.parse(
document.getElementById('serverData').dataset.server
);
}
},
data() {
return {
serverData: []
};
},
computed: {
themes() {
return this.serverData.themes;
},
fonts() {
return this.serverData.fonts;
},
selected() {
return {
theme: this.serverData.theme,
font: this.serverData.font
};
},
tokenHeaders() {
return { headers: { requesttoken: OC.requestToken } }
}
},
methods: {
selectTheme(id) {
this.selectItem('theme', id);
},
selectFont(id) {
this.selectItem('font', id);
},
/**
* Commit a change and force reload css
* Fetching the file again will trigger the server update
*
* @param {string} type type of the change (font or theme)
* @param {string} id the data of the change
*/
selectItem(type, id) {
axios
.post(OC.linkToOCS('apps/accessibility/api/v1/config', 2) + type, {value: id}, this.tokenHeaders)
.then(response => {
this.serverData[type] = id;
// Remove old link
let link = document.querySelector('link[rel=stylesheet][href*=accessibility][href*=user-]');
if (!link) {
// insert new css
let link = document.createElement('link');
link.rel = 'stylesheet';
link.href = OC.generateUrl('/apps/accessibility/css/user-style.css');
document.head.appendChild(link)
} else {
// force update
link.href = link.href.split('?')[0] + '?v=' + new Date().getTime();
}
})
.catch(err => {
console.log(err, err.response);
OC.Notification.showTemporary(t('accessibility', err.response.data.ocs.meta.message + '. Unable to apply the setting.'));
});
}
}
};
</script>
@@ -0,0 +1,27 @@
<template>
<a :class="{preview: true, selected: preview.id === selected}"
href="#" @click="selectItem">
<div class="preview-image" :style="{backgroundImage: 'url(' + preview.img + ')'}"></div>
<h3>
<span>{{preview.title}}</span>
<div class="icon-checkmark-color">{{t('accessibility', 'enabled')}}</div>
</h3>
<p>{{preview.text}}</p>
</a>
</template>
<script>
export default {
name: 'itemPreview',
props: ['preview', 'selected'],
methods: {
selectItem() {
this.$emit(
'select',
// if we clicked the already selected one: disable it
this.preview.id === this.selected ? false : this.preview.id
);
}
}
};
</script>
+12
View File
@@ -0,0 +1,12 @@
import Vue from 'vue';
import App from './App.vue';
/* global t */
// bind to window
Vue.prototype.OC = OC;
Vue.prototype.t = t;
new Vue({
el: '#accessibility',
render: h => h(App)
});
@@ -0,0 +1,29 @@
<?php
/**
* @copyright Copyright (c) 2018 John Molakvoæ <skjnldsv@protonmail.com>
*
* @author John Molakvoæ <skjnldsv@protonmail.com>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
script('accessibility', 'accessibility');
style('accessibility', 'style');
?>
<span id="serverData" data-server="<?php p(json_encode($_['serverData']));?>"></span>
<span id="accessibility"></span>
+42
View File
@@ -0,0 +1,42 @@
const path = require('path');
const { VueLoaderPlugin } = require('vue-loader');
module.exports = {
entry: path.join(__dirname, 'src', 'main.js'),
output: {
path: path.resolve(__dirname, './js'),
publicPath: '/js/',
filename: 'accessibility.js'
},
module: {
rules: [
{
test: /\.css$/,
use: ['vue-style-loader', 'css-loader']
},
{
test: /\.vue$/,
loader: 'vue-loader'
},
{
test: /\.js$/,
loader: 'babel-loader',
exclude: /node_modules/
},
{
test: /\.(png|jpg|gif|svg)$/,
loader: 'file-loader',
options: {
name: '[name].[ext]?[hash]'
}
}
]
},
plugins: [new VueLoaderPlugin()],
resolve: {
alias: {
vue$: 'vue/dist/vue.esm.js'
},
extensions: ['*', '.js', '.vue', '.json']
}
};
+12
View File
@@ -0,0 +1,12 @@
const merge = require('webpack-merge');
const common = require('./webpack.common.js');
module.exports = merge(common, {
mode: 'development',
devServer: {
historyApiFallback: true,
noInfo: true,
overlay: true
},
devtool: '#eval-source-map'
});
+7
View File
@@ -0,0 +1,7 @@
const merge = require('webpack-merge');
const common = require('./webpack.common.js');
module.exports = merge(common, {
mode: 'production',
devtool: '#source-map'
});
+1
View File
@@ -1,4 +1,5 @@
<?php
declare(strict_types=1);
/**
* @copyright Copyright (c) 2016 Bjoern Schiessle <bjoern@schiessle.org>
* @copyright Copyright (c) 2017 Lukas Reschke <lukas@statuscode.ch>
+13 -6
View File
@@ -1,16 +1,23 @@
<?xml version="1.0"?>
<info>
<info xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd">
<id>admin_audit</id>
<name>Auditing / Logging</name>
<summary>Provides logging abilities for Nextcloud such as logging file accesses or otherwise sensitive actions.</summary>
<description>Provides logging abilities for Nextcloud such as logging file accesses or otherwise sensitive actions.</description>
<licence>AGPL</licence>
<version>1.4.0</version>
<licence>agpl</licence>
<author>Nextcloud</author>
<version>1.3.0</version>
<namespace>AdminAudit</namespace>
<dependencies>
<nextcloud min-version="13" max-version="13" />
</dependencies>
<types>
<logging/>
</types>
<category>monitoring</category>
<bugs>https://github.com/nextcloud/server/issues</bugs>
<dependencies>
<nextcloud min-version="14" max-version="14" />
</dependencies>
<background-jobs>
<job>OCA\AdminAudit\BackgroundJobs\Rotate</job>
</background-jobs>
</info>
@@ -43,8 +43,7 @@ namespace Composer\Autoload;
class ClassLoader
{
// PSR-4
private $firstCharsPsr4 = array();
private $prefixLengthsPsr4 = array(); // For BC with legacy static maps
private $prefixLengthsPsr4 = array();
private $prefixDirsPsr4 = array();
private $fallbackDirsPsr4 = array();
@@ -171,10 +170,11 @@ class ClassLoader
}
} elseif (!isset($this->prefixDirsPsr4[$prefix])) {
// Register directories for a new namespace.
if ('\\' !== substr($prefix, -1)) {
$length = strlen($prefix);
if ('\\' !== $prefix[$length - 1]) {
throw new \InvalidArgumentException("A non-empty PSR-4 prefix must end with a namespace separator.");
}
$this->firstCharsPsr4[$prefix[0]] = true;
$this->prefixLengthsPsr4[$prefix[0]][$prefix] = $length;
$this->prefixDirsPsr4[$prefix] = (array) $paths;
} elseif ($prepend) {
// Prepend directories for an already registered namespace.
@@ -221,10 +221,11 @@ class ClassLoader
if (!$prefix) {
$this->fallbackDirsPsr4 = (array) $paths;
} else {
if ('\\' !== substr($prefix, -1)) {
$length = strlen($prefix);
if ('\\' !== $prefix[$length - 1]) {
throw new \InvalidArgumentException("A non-empty PSR-4 prefix must end with a namespace separator.");
}
$this->firstCharsPsr4[$prefix[0]] = true;
$this->prefixLengthsPsr4[$prefix[0]][$prefix] = $length;
$this->prefixDirsPsr4[$prefix] = (array) $paths;
}
}
@@ -372,11 +373,11 @@ class ClassLoader
$logicalPathPsr4 = strtr($class, '\\', DIRECTORY_SEPARATOR) . $ext;
$first = $class[0];
if (isset($this->firstCharsPsr4[$first]) || isset($this->prefixLengthsPsr4[$first])) {
if (isset($this->prefixLengthsPsr4[$first])) {
$subPath = $class;
while (false !== $lastPos = strrpos($subPath, '\\')) {
$subPath = substr($subPath, 0, $lastPos);
$search = $subPath.'\\';
$search = $subPath . '\\';
if (isset($this->prefixDirsPsr4[$search])) {
$pathEnd = DIRECTORY_SEPARATOR . substr($logicalPathPsr4, $lastPos + 1);
foreach ($this->prefixDirsPsr4[$search] as $dir) {
@@ -12,9 +12,11 @@ return array(
'OCA\\AdminAudit\\Actions\\Console' => $baseDir . '/../lib/Actions/Console.php',
'OCA\\AdminAudit\\Actions\\Files' => $baseDir . '/../lib/Actions/Files.php',
'OCA\\AdminAudit\\Actions\\GroupManagement' => $baseDir . '/../lib/Actions/GroupManagement.php',
'OCA\\AdminAudit\\Actions\\Security' => $baseDir . '/../lib/Actions/Security.php',
'OCA\\AdminAudit\\Actions\\Sharing' => $baseDir . '/../lib/Actions/Sharing.php',
'OCA\\AdminAudit\\Actions\\Trashbin' => $baseDir . '/../lib/Actions/Trashbin.php',
'OCA\\AdminAudit\\Actions\\UserManagement' => $baseDir . '/../lib/Actions/UserManagement.php',
'OCA\\AdminAudit\\Actions\\Versions' => $baseDir . '/../lib/Actions/Versions.php',
'OCA\\AdminAudit\\AppInfo\\Application' => $baseDir . '/../lib/AppInfo/Application.php',
'OCA\\AdminAudit\\BackgroundJobs\\Rotate' => $baseDir . '/../lib/BackgroundJobs/Rotate.php',
);
@@ -6,8 +6,11 @@ namespace Composer\Autoload;
class ComposerStaticInitAdminAudit
{
public static $firstCharsPsr4 = array (
'O' => true,
public static $prefixLengthsPsr4 = array (
'O' =>
array (
'OCA\\AdminAudit\\' => 15,
),
);
public static $prefixDirsPsr4 = array (
@@ -24,17 +27,19 @@ class ComposerStaticInitAdminAudit
'OCA\\AdminAudit\\Actions\\Console' => __DIR__ . '/..' . '/../lib/Actions/Console.php',
'OCA\\AdminAudit\\Actions\\Files' => __DIR__ . '/..' . '/../lib/Actions/Files.php',
'OCA\\AdminAudit\\Actions\\GroupManagement' => __DIR__ . '/..' . '/../lib/Actions/GroupManagement.php',
'OCA\\AdminAudit\\Actions\\Security' => __DIR__ . '/..' . '/../lib/Actions/Security.php',
'OCA\\AdminAudit\\Actions\\Sharing' => __DIR__ . '/..' . '/../lib/Actions/Sharing.php',
'OCA\\AdminAudit\\Actions\\Trashbin' => __DIR__ . '/..' . '/../lib/Actions/Trashbin.php',
'OCA\\AdminAudit\\Actions\\UserManagement' => __DIR__ . '/..' . '/../lib/Actions/UserManagement.php',
'OCA\\AdminAudit\\Actions\\Versions' => __DIR__ . '/..' . '/../lib/Actions/Versions.php',
'OCA\\AdminAudit\\AppInfo\\Application' => __DIR__ . '/..' . '/../lib/AppInfo/Application.php',
'OCA\\AdminAudit\\BackgroundJobs\\Rotate' => __DIR__ . '/..' . '/../lib/BackgroundJobs/Rotate.php',
);
public static function getInitializer(ClassLoader $loader)
{
return \Closure::bind(function () use ($loader) {
$loader->firstCharsPsr4 = ComposerStaticInitAdminAudit::$firstCharsPsr4;
$loader->prefixLengthsPsr4 = ComposerStaticInitAdminAudit::$prefixLengthsPsr4;
$loader->prefixDirsPsr4 = ComposerStaticInitAdminAudit::$prefixDirsPsr4;
$loader->classMap = ComposerStaticInitAdminAudit::$classMap;
+3 -2
View File
@@ -1,4 +1,5 @@
<?php
declare(strict_types=1);
/**
* @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch>
*
@@ -45,10 +46,10 @@ class Action {
* @param array $elements
* @param bool $obfuscateParameters
*/
public function log($text,
public function log(string $text,
array $params,
array $elements,
$obfuscateParameters = false) {
bool $obfuscateParameters = false) {
foreach($elements as $element) {
if(!isset($params[$element])) {
if ($obfuscateParameters) {
@@ -1,4 +1,5 @@
<?php
declare(strict_types=1);
/**
* @copyright Copyright (c) 2017 Joas Schilling <coding@schilljs.com>
*
@@ -28,7 +29,7 @@ class AppManagement extends Action {
/**
* @param string $appName
*/
public function enableApp($appName) {
public function enableApp(string $appName) {
$this->log('App "%s" enabled',
['app' => $appName],
['app']
@@ -39,7 +40,7 @@ class AppManagement extends Action {
* @param string $appName
* @param string[] $groups
*/
public function enableAppForGroups($appName, array $groups) {
public function enableAppForGroups(string $appName, array $groups) {
$this->log('App "%s" enabled for groups: %s',
['app' => $appName, 'groups' => implode(', ', $groups)],
['app', 'groups']
@@ -49,7 +50,7 @@ class AppManagement extends Action {
/**
* @param string $appName
*/
public function disableApp($appName) {
public function disableApp(string $appName) {
$this->log('App "%s" disabled',
['app' => $appName],
['app']
+1
View File
@@ -1,4 +1,5 @@
<?php
declare(strict_types=1);
/**
* @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch>
*
+2 -1
View File
@@ -1,4 +1,5 @@
<?php
declare(strict_types=1);
/**
* @copyright Copyright (c) 2017 Joas Schilling <coding@schilljs.com>
*
@@ -28,7 +29,7 @@ class Console extends Action {
/**
* @param $arguments
*/
public function runCommand($arguments) {
public function runCommand(array $arguments) {
if ($arguments[1] === '_completion') {
// Don't log autocompletion
return;
+1
View File
@@ -1,4 +1,5 @@
<?php
declare(strict_types=1);
/**
* @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch>
*
@@ -1,4 +1,5 @@
<?php
declare(strict_types=1);
/**
* @copyright Copyright (c) 2016 Bjoern Schiessle <bjoern@schiessle.org>
*
+75
View File
@@ -0,0 +1,75 @@
<?php
declare(strict_types=1);
/**
* @copyright Copyright (c) 2018 Roeland Jago Douma <roeland@famdouma.nl>
*
* @author Roeland Jago Douma <roeland@famdouma.nl>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
namespace OCA\AdminAudit\Actions;
use OCP\IUser;
/**
* Class Sharing logs the sharing actions
*
* @package OCA\AdminAudit\Actions
*/
class Security extends Action {
/**
* Log twofactor auth enabled
*
* @param IUser $user
* @param array $params
*/
public function twofactorFailed(IUser $user, array $params) {
$params['uid'] = $user->getUID();
$params['displayName'] = $user->getDisplayName();
$this->log(
'Failed two factor attempt by user %s (%s) with provider %s',
$params,
[
'displayName',
'uid',
'provider',
]
);
}
/**
* Logs unsharing of data
*
* @param IUser $user
* @param array $params
*/
public function twofactorSuccess(IUser $user, array $params) {
$params['uid'] = $user->getUID();
$params['displayName'] = $user->getDisplayName();
$this->log(
'Successful two factor attempt by user %s (%s) with provider %s',
$params,
[
'displayName',
'uid',
'provider',
]
);
}
}
+26
View File
@@ -1,4 +1,5 @@
<?php
declare(strict_types=1);
/**
* @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch>
*
@@ -77,6 +78,19 @@ class Sharing extends Action {
'id',
]
);
} elseif($params['shareType'] === Share::SHARE_TYPE_ROOM) {
$this->log(
'The %s "%s" with ID "%s" has been shared to the room "%s" with permissions "%s" (Share ID: %s)',
$params,
[
'itemType',
'itemTarget',
'itemSource',
'shareWith',
'permissions',
'id',
]
);
}
}
@@ -121,6 +135,18 @@ class Sharing extends Action {
'id',
]
);
} elseif($params['shareType'] === Share::SHARE_TYPE_ROOM) {
$this->log(
'The %s "%s" with ID "%s" has been unshared from the room "%s" (Share ID: %s)',
$params,
[
'itemType',
'fileTarget',
'itemSource',
'shareWith',
'id',
]
);
}
}
+3 -2
View File
@@ -1,4 +1,5 @@
<?php
declare(strict_types=1);
/**
* @copyright Copyright (c) 2016 Bjoern Schiessle <bjoern@schiessle.org>
*
@@ -27,13 +28,13 @@ namespace OCA\AdminAudit\Actions;
class Trashbin extends Action {
public function delete($params) {
public function delete(array $params) {
$this->log('File "%s" deleted from trash bin.',
['path' => $params['path']], ['path']
);
}
public function restore($params) {
public function restore(array $params) {
$this->log('File "%s" restored from trash bin.',
['path' => $params['filePath']], ['path']
);
@@ -1,4 +1,5 @@
<?php
declare(strict_types=1);
/**
* @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch>
*
@@ -49,6 +50,19 @@ class UserManagement extends Action {
);
}
/**
* Log assignments of users (typically user backends)
*
* @param string $uid
*/
public function assign(string $uid) {
$this->log(
'UserID assigned: "%s"',
[ 'uid' => $uid ],
[ 'uid' ]
);
}
/**
* Log deletion of users
*
@@ -64,20 +78,44 @@ class UserManagement extends Action {
);
}
/**
* Log unassignments of users (typically user backends, no data removed)
*
* @param string $uid
*/
public function unassign(string $uid) {
$this->log(
'UserID unassigned: "%s"',
[ 'uid' => $uid ],
[ 'uid' ]
);
}
/**
* Log enabling of users
*
* @param array $params
*/
public function change(array $params) {
if ($params['feature'] === 'enabled') {
$this->log(
$params['value'] === 'true' ? 'User enabled: "%s"' : 'User disabled: "%s"',
['user' => $params['user']->getUID()],
[
'user',
]
);
switch($params['feature']) {
case 'enabled':
$this->log(
$params['value'] === 'true' ? 'User enabled: "%s"' : 'User disabled: "%s"',
['user' => $params['user']->getUID()],
[
'user',
]
);
break;
case 'eMailAddress':
$this->log(
'Email address changed for user %s',
['user' => $params['user']->getUID()],
[
'user',
]
);
break;
}
}
+3 -2
View File
@@ -1,4 +1,5 @@
<?php
declare(strict_types=1);
/**
* @copyright Bjoern Schiessle <bjoern@schiessle.org>
*
@@ -27,7 +28,7 @@ namespace OCA\AdminAudit\Actions;
class Versions extends Action {
public function rollback($params) {
public function rollback(array $params) {
$this->log('Version "%s" of "%s" was restored.',
[
'version' => $params['revision'],
@@ -37,7 +38,7 @@ class Versions extends Action {
);
}
public function delete($params) {
public function delete(array $params) {
$this->log('Version "%s" was deleted.',
['path' => $params['path']],
['path']
+76 -40
View File
@@ -1,4 +1,5 @@
<?php
declare(strict_types=1);
/**
* @copyright Copyright (c) 2017 Joas Schilling <coding@schilljs.com>
*
@@ -33,12 +34,14 @@ use OCA\AdminAudit\Actions\Auth;
use OCA\AdminAudit\Actions\Console;
use OCA\AdminAudit\Actions\Files;
use OCA\AdminAudit\Actions\GroupManagement;
use OCA\AdminAudit\Actions\Security;
use OCA\AdminAudit\Actions\Sharing;
use OCA\AdminAudit\Actions\Trashbin;
use OCA\AdminAudit\Actions\UserManagement;
use OCA\AdminAudit\Actions\Versions;
use OCP\App\ManagerEvent;
use OCP\AppFramework\App;
use OCP\Authentication\TwoFactorAuth\IProvider;
use OCP\Console\ConsoleEvent;
use OCP\IGroupManager;
use OCP\ILogger;
@@ -46,11 +49,30 @@ use OCP\IPreview;
use OCP\IUserSession;
use OCP\Util;
use Symfony\Component\EventDispatcher\GenericEvent;
use OCP\Share;
class Application extends App {
/** @var ILogger */
protected $logger;
public function __construct() {
parent::__construct('admin_audit');
$this->initLogger();
}
public function initLogger() {
$c = $this->getContainer()->getServer();
$config = $c->getConfig();
$default = $config->getSystemValue('datadirectory', \OC::$SERVERROOT . '/data') . '/audit.log';
$logFile = $config->getAppValue('admin_audit', 'logfile', $default);
if($logFile === null) {
$this->logger = $c->getLogger();
return;
}
$this->logger = $c->getLogFactory()->getCustomLogger($logFile);
}
public function register() {
@@ -61,24 +83,24 @@ class Application extends App {
* Register hooks in order to log them
*/
protected function registerHooks() {
$logger = $this->getContainer()->getServer()->getLogger();
$this->userManagementHooks();
$this->groupHooks();
$this->authHooks();
$this->userManagementHooks($logger);
$this->groupHooks($logger);
$this->authHooks($logger);
$this->consoleHooks();
$this->appHooks();
$this->consoleHooks($logger);
$this->appHooks($logger);
$this->sharingHooks();
$this->sharingHooks($logger);
$this->fileHooks();
$this->trashbinHooks();
$this->versionsHooks();
$this->fileHooks($logger);
$this->trashbinHooks($logger);
$this->versionsHooks($logger);
$this->securityHooks();
}
protected function userManagementHooks(ILogger $logger) {
$userActions = new UserManagement($logger);
protected function userManagementHooks() {
$userActions = new UserManagement($this->logger);
Util::connectHook('OC_User', 'post_createUser', $userActions, 'create');
Util::connectHook('OC_User', 'post_deleteUser', $userActions, 'delete');
@@ -87,10 +109,12 @@ class Application extends App {
/** @var IUserSession|Session $userSession */
$userSession = $this->getContainer()->getServer()->getUserSession();
$userSession->listen('\OC\User', 'postSetPassword', [$userActions, 'setPassword']);
$userSession->listen('\OC\User', 'assignedUserId', [$userActions, 'assign']);
$userSession->listen('\OC\User', 'postUnassignedUserId', [$userActions, 'unassign']);
}
protected function groupHooks(ILogger $logger) {
$groupActions = new GroupManagement($logger);
protected function groupHooks() {
$groupActions = new GroupManagement($this->logger);
/** @var IGroupManager|Manager $groupManager */
$groupManager = $this->getContainer()->getServer()->getGroupManager();
@@ -100,53 +124,53 @@ class Application extends App {
$groupManager->listen('\OC\Group', 'postCreate', [$groupActions, 'createGroup']);
}
protected function sharingHooks(ILogger $logger) {
$shareActions = new Sharing($logger);
protected function sharingHooks() {
$shareActions = new Sharing($this->logger);
Util::connectHook('OCP\Share', 'post_shared', $shareActions, 'shared');
Util::connectHook('OCP\Share', 'post_unshare', $shareActions, 'unshare');
Util::connectHook('OCP\Share', 'post_update_permissions', $shareActions, 'updatePermissions');
Util::connectHook('OCP\Share', 'post_update_password', $shareActions, 'updatePassword');
Util::connectHook('OCP\Share', 'post_set_expiration_date', $shareActions, 'updateExpirationDate');
Util::connectHook('OCP\Share', 'share_link_access', $shareActions, 'shareAccessed');
Util::connectHook(Share::class, 'post_shared', $shareActions, 'shared');
Util::connectHook(Share::class, 'post_unshare', $shareActions, 'unshare');
Util::connectHook(Share::class, 'post_update_permissions', $shareActions, 'updatePermissions');
Util::connectHook(Share::class, 'post_update_password', $shareActions, 'updatePassword');
Util::connectHook(Share::class, 'post_set_expiration_date', $shareActions, 'updateExpirationDate');
Util::connectHook(Share::class, 'share_link_access', $shareActions, 'shareAccessed');
}
protected function authHooks(ILogger $logger) {
$authActions = new Auth($logger);
protected function authHooks() {
$authActions = new Auth($this->logger);
Util::connectHook('OC_User', 'pre_login', $authActions, 'loginAttempt');
Util::connectHook('OC_User', 'post_login', $authActions, 'loginSuccessful');
Util::connectHook('OC_User', 'logout', $authActions, 'logout');
}
protected function appHooks(ILogger $logger) {
protected function appHooks() {
$eventDispatcher = $this->getContainer()->getServer()->getEventDispatcher();
$eventDispatcher->addListener(ManagerEvent::EVENT_APP_ENABLE, function(ManagerEvent $event) use ($logger) {
$appActions = new AppManagement($logger);
$eventDispatcher->addListener(ManagerEvent::EVENT_APP_ENABLE, function(ManagerEvent $event) {
$appActions = new AppManagement($this->logger);
$appActions->enableApp($event->getAppID());
});
$eventDispatcher->addListener(ManagerEvent::EVENT_APP_ENABLE_FOR_GROUPS, function(ManagerEvent $event) use ($logger) {
$appActions = new AppManagement($logger);
$eventDispatcher->addListener(ManagerEvent::EVENT_APP_ENABLE_FOR_GROUPS, function(ManagerEvent $event) {
$appActions = new AppManagement($this->logger);
$appActions->enableAppForGroups($event->getAppID(), $event->getGroups());
});
$eventDispatcher->addListener(ManagerEvent::EVENT_APP_DISABLE, function(ManagerEvent $event) use ($logger) {
$appActions = new AppManagement($logger);
$eventDispatcher->addListener(ManagerEvent::EVENT_APP_DISABLE, function(ManagerEvent $event) {
$appActions = new AppManagement($this->logger);
$appActions->disableApp($event->getAppID());
});
}
protected function consoleHooks(ILogger $logger) {
protected function consoleHooks() {
$eventDispatcher = $this->getContainer()->getServer()->getEventDispatcher();
$eventDispatcher->addListener(ConsoleEvent::EVENT_RUN, function(ConsoleEvent $event) use ($logger) {
$appActions = new Console($logger);
$eventDispatcher->addListener(ConsoleEvent::EVENT_RUN, function(ConsoleEvent $event) {
$appActions = new Console($this->logger);
$appActions->runCommand($event->getArguments());
});
}
protected function fileHooks(ILogger $logger) {
$fileActions = new Files($logger);
protected function fileHooks() {
$fileActions = new Files($this->logger);
$eventDispatcher = $this->getContainer()->getServer()->getEventDispatcher();
$eventDispatcher->addListener(
IPreview::EVENT,
@@ -207,15 +231,27 @@ class Application extends App {
);
}
protected function versionsHooks(ILogger $logger) {
$versionsActions = new Versions($logger);
protected function versionsHooks() {
$versionsActions = new Versions($this->logger);
Util::connectHook('\OCP\Versions', 'rollback', $versionsActions, 'rollback');
Util::connectHook('\OCP\Versions', 'delete',$versionsActions, 'delete');
}
protected function trashbinHooks(ILogger $logger) {
$trashActions = new Trashbin($logger);
protected function trashbinHooks() {
$trashActions = new Trashbin($this->logger);
Util::connectHook('\OCP\Trashbin', 'preDelete', $trashActions, 'delete');
Util::connectHook('\OCA\Files_Trashbin\Trashbin', 'post_restore', $trashActions, 'restore');
}
protected function securityHooks() {
$eventDispatcher = $this->getContainer()->getServer()->getEventDispatcher();
$eventDispatcher->addListener(IProvider::EVENT_SUCCESS, function(GenericEvent $event) {
$security = new Security($this->logger);
$security->twofactorSuccess($event->getSubject(), $event->getArguments());
});
$eventDispatcher->addListener(IProvider::EVENT_FAILED, function(GenericEvent $event) {
$security = new Security($this->logger);
$security->twofactorFailed($event->getSubject(), $event->getArguments());
});
}
}
@@ -0,0 +1,52 @@
<?php
/**
* @copyright Copyright (c) 2018 Arthur Schiwon <blizzz@arthur-schiwon.de>
*
* @author Arthur Schiwon <blizzz@arthur-schiwon.de>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
namespace OCA\AdminAudit\BackgroundJobs;
use OC\BackgroundJob\TimedJob;
use OCP\Log\RotationTrait;
class Rotate extends TimedJob {
use RotationTrait;
public function __construct() {
$this->setInterval(60*60*3);
}
protected function run($argument) {
$config = \OC::$server->getConfig();
$default = $config->getSystemValue('datadirectory', \OC::$SERVERROOT . '/data') . '/audit.log';
$this->filePath = $config->getAppValue('admin_audit', 'logfile', $default);
if($this->filePath === '') {
// default log file, nothing to do
return;
}
$this->maxSize = $config->getSystemValue('log_rotate_size', 100 * 1024 * 1024);
if($this->shouldRotateBySize()) {
$this->rotate();
}
}
}
@@ -0,0 +1,75 @@
<?php
declare(strict_types=1);
/**
* @copyright Copyright (c) 2018 Roeland Jago Douma <roeland@famdouma.nl>
*
* @author Roeland Jago Douma <roeland@famdouma.nl>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
namespace OCA\AdminAudit\Tests\Actions;
use OCA\AdminAudit\Actions\Security;
use OCP\ILogger;
use OCP\IUser;
use Test\TestCase;
class SecurityTest extends TestCase {
/** @var ILogger|\PHPUnit_Framework_MockObject_MockObject */
private $logger;
/** @var Security */
private $security;
/** @var IUser|\PHPUnit_Framework_MockObject_MockObject */
private $user;
public function setUp() {
parent::setUp();
$this->logger = $this->createMock(ILogger::class);
$this->security = new Security($this->logger);
$this->user = $this->createMock(IUser::class);
$this->user->method('getUID')->willReturn('myuid');
$this->user->method('getDisplayName')->willReturn('mydisplayname');
}
public function testTwofactorFailed() {
$this->logger->expects($this->once())
->method('info')
->with(
$this->equalTo('Failed two factor attempt by user mydisplayname (myuid) with provider myprovider'),
['app' => 'admin_audit']
);
$this->security->twofactorFailed($this->user, ['provider' => 'myprovider']);
}
public function testTwofactorSuccess() {
$this->logger->expects($this->once())
->method('info')
->with(
$this->equalTo('Successful two factor attempt by user mydisplayname (myuid) with provider myprovider'),
['app' => 'admin_audit']
);
$this->security->twofactorSuccess($this->user, ['provider' => 'myprovider']);
}
}
+661
View File
@@ -0,0 +1,661 @@
GNU AFFERO GENERAL PUBLIC LICENSE
Version 3, 19 November 2007
Copyright (C) 2007 Free Software Foundation, Inc. <http://fsf.org/>
Everyone is permitted to copy and distribute verbatim copies
of this license document, but changing it is not allowed.
Preamble
The GNU Affero General Public License is a free, copyleft license for
software and other kinds of works, specifically designed to ensure
cooperation with the community in the case of network server software.
The licenses for most software and other practical works are designed
to take away your freedom to share and change the works. By contrast,
our General Public Licenses are intended to guarantee your freedom to
share and change all versions of a program--to make sure it remains free
software for all its users.
When we speak of free software, we are referring to freedom, not
price. Our General Public Licenses are designed to make sure that you
have the freedom to distribute copies of free software (and charge for
them if you wish), that you receive source code or can get it if you
want it, that you can change the software or use pieces of it in new
free programs, and that you know you can do these things.
Developers that use our General Public Licenses protect your rights
with two steps: (1) assert copyright on the software, and (2) offer
you this License which gives you legal permission to copy, distribute
and/or modify the software.
A secondary benefit of defending all users' freedom is that
improvements made in alternate versions of the program, if they
receive widespread use, become available for other developers to
incorporate. Many developers of free software are heartened and
encouraged by the resulting cooperation. However, in the case of
software used on network servers, this result may fail to come about.
The GNU General Public License permits making a modified version and
letting the public access it on a server without ever releasing its
source code to the public.
The GNU Affero General Public License is designed specifically to
ensure that, in such cases, the modified source code becomes available
to the community. It requires the operator of a network server to
provide the source code of the modified version running there to the
users of that server. Therefore, public use of a modified version, on
a publicly accessible server, gives the public access to the source
code of the modified version.
An older license, called the Affero General Public License and
published by Affero, was designed to accomplish similar goals. This is
a different license, not a version of the Affero GPL, but Affero has
released a new version of the Affero GPL which permits relicensing under
this license.
The precise terms and conditions for copying, distribution and
modification follow.
TERMS AND CONDITIONS
0. Definitions.
"This License" refers to version 3 of the GNU Affero General Public License.
"Copyright" also means copyright-like laws that apply to other kinds of
works, such as semiconductor masks.
"The Program" refers to any copyrightable work licensed under this
License. Each licensee is addressed as "you". "Licensees" and
"recipients" may be individuals or organizations.
To "modify" a work means to copy from or adapt all or part of the work
in a fashion requiring copyright permission, other than the making of an
exact copy. The resulting work is called a "modified version" of the
earlier work or a work "based on" the earlier work.
A "covered work" means either the unmodified Program or a work based
on the Program.
To "propagate" a work means to do anything with it that, without
permission, would make you directly or secondarily liable for
infringement under applicable copyright law, except executing it on a
computer or modifying a private copy. Propagation includes copying,
distribution (with or without modification), making available to the
public, and in some countries other activities as well.
To "convey" a work means any kind of propagation that enables other
parties to make or receive copies. Mere interaction with a user through
a computer network, with no transfer of a copy, is not conveying.
An interactive user interface displays "Appropriate Legal Notices"
to the extent that it includes a convenient and prominently visible
feature that (1) displays an appropriate copyright notice, and (2)
tells the user that there is no warranty for the work (except to the
extent that warranties are provided), that licensees may convey the
work under this License, and how to view a copy of this License. If
the interface presents a list of user commands or options, such as a
menu, a prominent item in the list meets this criterion.
1. Source Code.
The "source code" for a work means the preferred form of the work
for making modifications to it. "Object code" means any non-source
form of a work.
A "Standard Interface" means an interface that either is an official
standard defined by a recognized standards body, or, in the case of
interfaces specified for a particular programming language, one that
is widely used among developers working in that language.
The "System Libraries" of an executable work include anything, other
than the work as a whole, that (a) is included in the normal form of
packaging a Major Component, but which is not part of that Major
Component, and (b) serves only to enable use of the work with that
Major Component, or to implement a Standard Interface for which an
implementation is available to the public in source code form. A
"Major Component", in this context, means a major essential component
(kernel, window system, and so on) of the specific operating system
(if any) on which the executable work runs, or a compiler used to
produce the work, or an object code interpreter used to run it.
The "Corresponding Source" for a work in object code form means all
the source code needed to generate, install, and (for an executable
work) run the object code and to modify the work, including scripts to
control those activities. However, it does not include the work's
System Libraries, or general-purpose tools or generally available free
programs which are used unmodified in performing those activities but
which are not part of the work. For example, Corresponding Source
includes interface definition files associated with source files for
the work, and the source code for shared libraries and dynamically
linked subprograms that the work is specifically designed to require,
such as by intimate data communication or control flow between those
subprograms and other parts of the work.
The Corresponding Source need not include anything that users
can regenerate automatically from other parts of the Corresponding
Source.
The Corresponding Source for a work in source code form is that
same work.
2. Basic Permissions.
All rights granted under this License are granted for the term of
copyright on the Program, and are irrevocable provided the stated
conditions are met. This License explicitly affirms your unlimited
permission to run the unmodified Program. The output from running a
covered work is covered by this License only if the output, given its
content, constitutes a covered work. This License acknowledges your
rights of fair use or other equivalent, as provided by copyright law.
You may make, run and propagate covered works that you do not
convey, without conditions so long as your license otherwise remains
in force. You may convey covered works to others for the sole purpose
of having them make modifications exclusively for you, or provide you
with facilities for running those works, provided that you comply with
the terms of this License in conveying all material for which you do
not control copyright. Those thus making or running the covered works
for you must do so exclusively on your behalf, under your direction
and control, on terms that prohibit them from making any copies of
your copyrighted material outside their relationship with you.
Conveying under any other circumstances is permitted solely under
the conditions stated below. Sublicensing is not allowed; section 10
makes it unnecessary.
3. Protecting Users' Legal Rights From Anti-Circumvention Law.
No covered work shall be deemed part of an effective technological
measure under any applicable law fulfilling obligations under article
11 of the WIPO copyright treaty adopted on 20 December 1996, or
similar laws prohibiting or restricting circumvention of such
measures.
When you convey a covered work, you waive any legal power to forbid
circumvention of technological measures to the extent such circumvention
is effected by exercising rights under this License with respect to
the covered work, and you disclaim any intention to limit operation or
modification of the work as a means of enforcing, against the work's
users, your or third parties' legal rights to forbid circumvention of
technological measures.
4. Conveying Verbatim Copies.
You may convey verbatim copies of the Program's source code as you
receive it, in any medium, provided that you conspicuously and
appropriately publish on each copy an appropriate copyright notice;
keep intact all notices stating that this License and any
non-permissive terms added in accord with section 7 apply to the code;
keep intact all notices of the absence of any warranty; and give all
recipients a copy of this License along with the Program.
You may charge any price or no price for each copy that you convey,
and you may offer support or warranty protection for a fee.
5. Conveying Modified Source Versions.
You may convey a work based on the Program, or the modifications to
produce it from the Program, in the form of source code under the
terms of section 4, provided that you also meet all of these conditions:
a) The work must carry prominent notices stating that you modified
it, and giving a relevant date.
b) The work must carry prominent notices stating that it is
released under this License and any conditions added under section
7. This requirement modifies the requirement in section 4 to
"keep intact all notices".
c) You must license the entire work, as a whole, under this
License to anyone who comes into possession of a copy. This
License will therefore apply, along with any applicable section 7
additional terms, to the whole of the work, and all its parts,
regardless of how they are packaged. This License gives no
permission to license the work in any other way, but it does not
invalidate such permission if you have separately received it.
d) If the work has interactive user interfaces, each must display
Appropriate Legal Notices; however, if the Program has interactive
interfaces that do not display Appropriate Legal Notices, your
work need not make them do so.
A compilation of a covered work with other separate and independent
works, which are not by their nature extensions of the covered work,
and which are not combined with it such as to form a larger program,
in or on a volume of a storage or distribution medium, is called an
"aggregate" if the compilation and its resulting copyright are not
used to limit the access or legal rights of the compilation's users
beyond what the individual works permit. Inclusion of a covered work
in an aggregate does not cause this License to apply to the other
parts of the aggregate.
6. Conveying Non-Source Forms.
You may convey a covered work in object code form under the terms
of sections 4 and 5, provided that you also convey the
machine-readable Corresponding Source under the terms of this License,
in one of these ways:
a) Convey the object code in, or embodied in, a physical product
(including a physical distribution medium), accompanied by the
Corresponding Source fixed on a durable physical medium
customarily used for software interchange.
b) Convey the object code in, or embodied in, a physical product
(including a physical distribution medium), accompanied by a
written offer, valid for at least three years and valid for as
long as you offer spare parts or customer support for that product
model, to give anyone who possesses the object code either (1) a
copy of the Corresponding Source for all the software in the
product that is covered by this License, on a durable physical
medium customarily used for software interchange, for a price no
more than your reasonable cost of physically performing this
conveying of source, or (2) access to copy the
Corresponding Source from a network server at no charge.
c) Convey individual copies of the object code with a copy of the
written offer to provide the Corresponding Source. This
alternative is allowed only occasionally and noncommercially, and
only if you received the object code with such an offer, in accord
with subsection 6b.
d) Convey the object code by offering access from a designated
place (gratis or for a charge), and offer equivalent access to the
Corresponding Source in the same way through the same place at no
further charge. You need not require recipients to copy the
Corresponding Source along with the object code. If the place to
copy the object code is a network server, the Corresponding Source
may be on a different server (operated by you or a third party)
that supports equivalent copying facilities, provided you maintain
clear directions next to the object code saying where to find the
Corresponding Source. Regardless of what server hosts the
Corresponding Source, you remain obligated to ensure that it is
available for as long as needed to satisfy these requirements.
e) Convey the object code using peer-to-peer transmission, provided
you inform other peers where the object code and Corresponding
Source of the work are being offered to the general public at no
charge under subsection 6d.
A separable portion of the object code, whose source code is excluded
from the Corresponding Source as a System Library, need not be
included in conveying the object code work.
A "User Product" is either (1) a "consumer product", which means any
tangible personal property which is normally used for personal, family,
or household purposes, or (2) anything designed or sold for incorporation
into a dwelling. In determining whether a product is a consumer product,
doubtful cases shall be resolved in favor of coverage. For a particular
product received by a particular user, "normally used" refers to a
typical or common use of that class of product, regardless of the status
of the particular user or of the way in which the particular user
actually uses, or expects or is expected to use, the product. A product
is a consumer product regardless of whether the product has substantial
commercial, industrial or non-consumer uses, unless such uses represent
the only significant mode of use of the product.
"Installation Information" for a User Product means any methods,
procedures, authorization keys, or other information required to install
and execute modified versions of a covered work in that User Product from
a modified version of its Corresponding Source. The information must
suffice to ensure that the continued functioning of the modified object
code is in no case prevented or interfered with solely because
modification has been made.
If you convey an object code work under this section in, or with, or
specifically for use in, a User Product, and the conveying occurs as
part of a transaction in which the right of possession and use of the
User Product is transferred to the recipient in perpetuity or for a
fixed term (regardless of how the transaction is characterized), the
Corresponding Source conveyed under this section must be accompanied
by the Installation Information. But this requirement does not apply
if neither you nor any third party retains the ability to install
modified object code on the User Product (for example, the work has
been installed in ROM).
The requirement to provide Installation Information does not include a
requirement to continue to provide support service, warranty, or updates
for a work that has been modified or installed by the recipient, or for
the User Product in which it has been modified or installed. Access to a
network may be denied when the modification itself materially and
adversely affects the operation of the network or violates the rules and
protocols for communication across the network.
Corresponding Source conveyed, and Installation Information provided,
in accord with this section must be in a format that is publicly
documented (and with an implementation available to the public in
source code form), and must require no special password or key for
unpacking, reading or copying.
7. Additional Terms.
"Additional permissions" are terms that supplement the terms of this
License by making exceptions from one or more of its conditions.
Additional permissions that are applicable to the entire Program shall
be treated as though they were included in this License, to the extent
that they are valid under applicable law. If additional permissions
apply only to part of the Program, that part may be used separately
under those permissions, but the entire Program remains governed by
this License without regard to the additional permissions.
When you convey a copy of a covered work, you may at your option
remove any additional permissions from that copy, or from any part of
it. (Additional permissions may be written to require their own
removal in certain cases when you modify the work.) You may place
additional permissions on material, added by you to a covered work,
for which you have or can give appropriate copyright permission.
Notwithstanding any other provision of this License, for material you
add to a covered work, you may (if authorized by the copyright holders of
that material) supplement the terms of this License with terms:
a) Disclaiming warranty or limiting liability differently from the
terms of sections 15 and 16 of this License; or
b) Requiring preservation of specified reasonable legal notices or
author attributions in that material or in the Appropriate Legal
Notices displayed by works containing it; or
c) Prohibiting misrepresentation of the origin of that material, or
requiring that modified versions of such material be marked in
reasonable ways as different from the original version; or
d) Limiting the use for publicity purposes of names of licensors or
authors of the material; or
e) Declining to grant rights under trademark law for use of some
trade names, trademarks, or service marks; or
f) Requiring indemnification of licensors and authors of that
material by anyone who conveys the material (or modified versions of
it) with contractual assumptions of liability to the recipient, for
any liability that these contractual assumptions directly impose on
those licensors and authors.
All other non-permissive additional terms are considered "further
restrictions" within the meaning of section 10. If the Program as you
received it, or any part of it, contains a notice stating that it is
governed by this License along with a term that is a further
restriction, you may remove that term. If a license document contains
a further restriction but permits relicensing or conveying under this
License, you may add to a covered work material governed by the terms
of that license document, provided that the further restriction does
not survive such relicensing or conveying.
If you add terms to a covered work in accord with this section, you
must place, in the relevant source files, a statement of the
additional terms that apply to those files, or a notice indicating
where to find the applicable terms.
Additional terms, permissive or non-permissive, may be stated in the
form of a separately written license, or stated as exceptions;
the above requirements apply either way.
8. Termination.
You may not propagate or modify a covered work except as expressly
provided under this License. Any attempt otherwise to propagate or
modify it is void, and will automatically terminate your rights under
this License (including any patent licenses granted under the third
paragraph of section 11).
However, if you cease all violation of this License, then your
license from a particular copyright holder is reinstated (a)
provisionally, unless and until the copyright holder explicitly and
finally terminates your license, and (b) permanently, if the copyright
holder fails to notify you of the violation by some reasonable means
prior to 60 days after the cessation.
Moreover, your license from a particular copyright holder is
reinstated permanently if the copyright holder notifies you of the
violation by some reasonable means, this is the first time you have
received notice of violation of this License (for any work) from that
copyright holder, and you cure the violation prior to 30 days after
your receipt of the notice.
Termination of your rights under this section does not terminate the
licenses of parties who have received copies or rights from you under
this License. If your rights have been terminated and not permanently
reinstated, you do not qualify to receive new licenses for the same
material under section 10.
9. Acceptance Not Required for Having Copies.
You are not required to accept this License in order to receive or
run a copy of the Program. Ancillary propagation of a covered work
occurring solely as a consequence of using peer-to-peer transmission
to receive a copy likewise does not require acceptance. However,
nothing other than this License grants you permission to propagate or
modify any covered work. These actions infringe copyright if you do
not accept this License. Therefore, by modifying or propagating a
covered work, you indicate your acceptance of this License to do so.
10. Automatic Licensing of Downstream Recipients.
Each time you convey a covered work, the recipient automatically
receives a license from the original licensors, to run, modify and
propagate that work, subject to this License. You are not responsible
for enforcing compliance by third parties with this License.
An "entity transaction" is a transaction transferring control of an
organization, or substantially all assets of one, or subdividing an
organization, or merging organizations. If propagation of a covered
work results from an entity transaction, each party to that
transaction who receives a copy of the work also receives whatever
licenses to the work the party's predecessor in interest had or could
give under the previous paragraph, plus a right to possession of the
Corresponding Source of the work from the predecessor in interest, if
the predecessor has it or can get it with reasonable efforts.
You may not impose any further restrictions on the exercise of the
rights granted or affirmed under this License. For example, you may
not impose a license fee, royalty, or other charge for exercise of
rights granted under this License, and you may not initiate litigation
(including a cross-claim or counterclaim in a lawsuit) alleging that
any patent claim is infringed by making, using, selling, offering for
sale, or importing the Program or any portion of it.
11. Patents.
A "contributor" is a copyright holder who authorizes use under this
License of the Program or a work on which the Program is based. The
work thus licensed is called the contributor's "contributor version".
A contributor's "essential patent claims" are all patent claims
owned or controlled by the contributor, whether already acquired or
hereafter acquired, that would be infringed by some manner, permitted
by this License, of making, using, or selling its contributor version,
but do not include claims that would be infringed only as a
consequence of further modification of the contributor version. For
purposes of this definition, "control" includes the right to grant
patent sublicenses in a manner consistent with the requirements of
this License.
Each contributor grants you a non-exclusive, worldwide, royalty-free
patent license under the contributor's essential patent claims, to
make, use, sell, offer for sale, import and otherwise run, modify and
propagate the contents of its contributor version.
In the following three paragraphs, a "patent license" is any express
agreement or commitment, however denominated, not to enforce a patent
(such as an express permission to practice a patent or covenant not to
sue for patent infringement). To "grant" such a patent license to a
party means to make such an agreement or commitment not to enforce a
patent against the party.
If you convey a covered work, knowingly relying on a patent license,
and the Corresponding Source of the work is not available for anyone
to copy, free of charge and under the terms of this License, through a
publicly available network server or other readily accessible means,
then you must either (1) cause the Corresponding Source to be so
available, or (2) arrange to deprive yourself of the benefit of the
patent license for this particular work, or (3) arrange, in a manner
consistent with the requirements of this License, to extend the patent
license to downstream recipients. "Knowingly relying" means you have
actual knowledge that, but for the patent license, your conveying the
covered work in a country, or your recipient's use of the covered work
in a country, would infringe one or more identifiable patents in that
country that you have reason to believe are valid.
If, pursuant to or in connection with a single transaction or
arrangement, you convey, or propagate by procuring conveyance of, a
covered work, and grant a patent license to some of the parties
receiving the covered work authorizing them to use, propagate, modify
or convey a specific copy of the covered work, then the patent license
you grant is automatically extended to all recipients of the covered
work and works based on it.
A patent license is "discriminatory" if it does not include within
the scope of its coverage, prohibits the exercise of, or is
conditioned on the non-exercise of one or more of the rights that are
specifically granted under this License. You may not convey a covered
work if you are a party to an arrangement with a third party that is
in the business of distributing software, under which you make payment
to the third party based on the extent of your activity of conveying
the work, and under which the third party grants, to any of the
parties who would receive the covered work from you, a discriminatory
patent license (a) in connection with copies of the covered work
conveyed by you (or copies made from those copies), or (b) primarily
for and in connection with specific products or compilations that
contain the covered work, unless you entered into that arrangement,
or that patent license was granted, prior to 28 March 2007.
Nothing in this License shall be construed as excluding or limiting
any implied license or other defenses to infringement that may
otherwise be available to you under applicable patent law.
12. No Surrender of Others' Freedom.
If conditions are imposed on you (whether by court order, agreement or
otherwise) that contradict the conditions of this License, they do not
excuse you from the conditions of this License. If you cannot convey a
covered work so as to satisfy simultaneously your obligations under this
License and any other pertinent obligations, then as a consequence you may
not convey it at all. For example, if you agree to terms that obligate you
to collect a royalty for further conveying from those to whom you convey
the Program, the only way you could satisfy both those terms and this
License would be to refrain entirely from conveying the Program.
13. Remote Network Interaction; Use with the GNU General Public License.
Notwithstanding any other provision of this License, if you modify the
Program, your modified version must prominently offer all users
interacting with it remotely through a computer network (if your version
supports such interaction) an opportunity to receive the Corresponding
Source of your version by providing access to the Corresponding Source
from a network server at no charge, through some standard or customary
means of facilitating copying of software. This Corresponding Source
shall include the Corresponding Source for any work covered by version 3
of the GNU General Public License that is incorporated pursuant to the
following paragraph.
Notwithstanding any other provision of this License, you have
permission to link or combine any covered work with a work licensed
under version 3 of the GNU General Public License into a single
combined work, and to convey the resulting work. The terms of this
License will continue to apply to the part which is the covered work,
but the work with which it is combined will remain governed by version
3 of the GNU General Public License.
14. Revised Versions of this License.
The Free Software Foundation may publish revised and/or new versions of
the GNU Affero General Public License from time to time. Such new versions
will be similar in spirit to the present version, but may differ in detail to
address new problems or concerns.
Each version is given a distinguishing version number. If the
Program specifies that a certain numbered version of the GNU Affero General
Public License "or any later version" applies to it, you have the
option of following the terms and conditions either of that numbered
version or of any later version published by the Free Software
Foundation. If the Program does not specify a version number of the
GNU Affero General Public License, you may choose any version ever published
by the Free Software Foundation.
If the Program specifies that a proxy can decide which future
versions of the GNU Affero General Public License can be used, that proxy's
public statement of acceptance of a version permanently authorizes you
to choose that version for the Program.
Later license versions may give you additional or different
permissions. However, no additional obligations are imposed on any
author or copyright holder as a result of your choosing to follow a
later version.
15. Disclaimer of Warranty.
THERE IS NO WARRANTY FOR THE PROGRAM, TO THE EXTENT PERMITTED BY
APPLICABLE LAW. EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT
HOLDERS AND/OR OTHER PARTIES PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY
OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO,
THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
PURPOSE. THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE PROGRAM
IS WITH YOU. SHOULD THE PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF
ALL NECESSARY SERVICING, REPAIR OR CORRECTION.
16. Limitation of Liability.
IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR CONVEYS
THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, INCLUDING ANY
GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE
USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED TO LOSS OF
DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD
PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER PROGRAMS),
EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF
SUCH DAMAGES.
17. Interpretation of Sections 15 and 16.
If the disclaimer of warranty and limitation of liability provided
above cannot be given local legal effect according to their terms,
reviewing courts shall apply local law that most closely approximates
an absolute waiver of all civil liability in connection with the
Program, unless a warranty or assumption of liability accompanies a
copy of the Program in return for a fee.
END OF TERMS AND CONDITIONS
How to Apply These Terms to Your New Programs
If you develop a new program, and you want it to be of the greatest
possible use to the public, the best way to achieve this is to make it
free software which everyone can redistribute and change under these terms.
To do so, attach the following notices to the program. It is safest
to attach them to the start of each source file to most effectively
state the exclusion of warranty; and each file should have at least
the "copyright" line and a pointer to where the full notice is found.
<one line to give the program's name and a brief idea of what it does.>
Copyright (C) <year> <name of author>
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU Affero General Public License as published
by the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU Affero General Public License for more details.
You should have received a copy of the GNU Affero General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
Also add information on how to contact you by electronic and paper mail.
If your software can interact with users remotely through a computer
network, you should also make sure that it provides a way for users to
get its source. For example, if your program is a web application, its
interface could display a "Source" link that leads users to an archive
of the code. There are many ways you could offer source, and different
solutions will be better for different programs; see section 13 for the
specific requirements.
You should also get your employer (if you work as a programmer) or school,
if any, to sign a "copyright disclaimer" for the program, if necessary.
For more information on this, and how to apply and follow the GNU AGPL, see
<http://www.gnu.org/licenses/>.
+2
View File
@@ -0,0 +1,2 @@
# cloud_federation_api
The cloud federation API allows to share information like files, contacts, calendars, incoming calls, etc accross Nextcloud instances
+22
View File
@@ -0,0 +1,22 @@
<?php
/**
* @copyright Copyright (c) 2018 Bjoern Schiessle <bjoern@schiessle.org>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
$app = new \OCA\CloudFederationAPI\AppInfo\Application();
@@ -0,0 +1,20 @@
<?xml version="1.0"?>
<info xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd">
<id>cloud_federation_api</id>
<name>Cloud Federation API</name>
<summary>Enable clouds to communicate with each other and exchange data</summary>
<description>The Coud Federation API enabled various Nextcloud instances to communitcate with each other and to exchange data</description>
<version>0.0.1</version>
<licence>agpl</licence>
<author>Bjoern Schiessle</author>
<namespace>CloudFederationAPI</namespace>
<types>
<filesystem/>
</types>
<category>files</category>
<bugs>https://github.com/nextcloud/cloud_federation/issues</bugs>
<dependencies>
<nextcloud min-version="14" max-version="14"/>
</dependencies>
</info>
@@ -0,0 +1,37 @@
<?php
/**
* @copyright Copyright (c) 2018 Bjoern Schiessle <bjoern@schiessle.org>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
namespace OCA\CloudFederationAPI\AppInfo;
use OCA\CloudFederationAPI\Capabilities;
use OCP\AppFramework\App;
class Application extends App {
public function __construct() {
parent::__construct('cloud_federation_api');
$container = $this->getContainer();
$container->registerCapability(Capabilities::class);
}
}
@@ -0,0 +1,64 @@
<?php
/**
* @copyright Copyright (c) 2017 Bjoern Schiessle <bjoern@schiessle.org>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
namespace OCA\CloudFederationAPI;
use OCP\Capabilities\ICapability;
use OCP\IURLGenerator;
class Capabilities implements ICapability {
/** @var IURLGenerator */
private $urlGenerator;
public function __construct(IURLGenerator $urlGenerator) {
$this->urlGenerator = $urlGenerator;
}
/**
* Function an app uses to return the capabilities
*
* @return array Array containing the apps capabilities
* @since 8.2.0
*/
public function getCapabilities() {
$url = $this->urlGenerator->linkToRouteAbsolute('cloud_federation_api.requesthandlercontroller.addShare');
$capabilities = ['ocm' =>
[
'enabled' => true,
'apiVersion' => '1.0-proposal1',
'endPoint' => substr($url, 0, strrpos($url, '/')),
'shareTypes' => [
[
'name' => 'file',
'protocols' => [
'webdav' => '/public.php/webdav/',
]
],
]
]
];
return $capabilities;
}
}
+60
View File
@@ -0,0 +1,60 @@
<?php
/**
* @copyright Copyright (c) 2018 Bjoern Schiessle <bjoern@schiessle.org>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
namespace OCA\CloudFederationAPI;
use OCP\Federation\ICloudFederationProviderManager;
use OCP\GlobalScale\IConfig as IGsConfig;
use OCP\IConfig;
/**
* Class config
*
* handles all the config parameters
*
* @package OCA\CloudFederationAPI
*/
class Config {
/** @var ICloudFederationProviderManager */
private $cloudFederationProviderManager;
public function __construct(ICloudFederationProviderManager $cloudFederationProviderManager) {
$this->cloudFederationProviderManager = $cloudFederationProviderManager;
}
/**
* get a list of supported share types
*
* @param string $resourceType
* @return array
*/
public function getSupportedShareTypes($resourceType) {
try {
$provider = $this->cloudFederationProviderManager->getCloudFederationProvider($resourceType);
return $provider->getSupportedShareTypes();
} catch (\Exception $e) {
return [];
}
}
}
@@ -0,0 +1,300 @@
<?php
/**
* @copyright Copyright (c) 2018 Bjoern Schiessle <bjoern@schiessle.org>
*
* @author Bjoern Schiessle <bjoern@schiessle.org>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
namespace OCA\CloudFederationAPI\Controller;
use OCA\CloudFederationAPI\Config;
use OCP\AppFramework\Controller;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\JSONResponse;
use OCP\Federation\Exceptions\ActionNotSupportedException;
use OCP\Federation\Exceptions\AuthenticationFailedException;
use OCP\Federation\Exceptions\BadRequestException;
use OCP\Federation\Exceptions\ProviderCouldNotAddShareException;
use OCP\Federation\ICloudFederationFactory;
use OCP\Federation\ICloudFederationProviderManager;
use OCP\Federation\Exceptions\ProviderDoesNotExistsException;
use OCP\Federation\ICloudIdManager;
use OCP\IGroupManager;
use OCP\ILogger;
use OCP\IRequest;
use OCP\IURLGenerator;
use OCP\IUserManager;
use OCP\Share\Exceptions\ShareNotFound;
/**
* Class RequestHandlerController
*
* handle API between different Cloud instances
*
* @package OCA\CloudFederationAPI\Controller
*/
class RequestHandlerController extends Controller {
/** @var ILogger */
private $logger;
/** @var IUserManager */
private $userManager;
/** @var IGroupManager */
private $groupManager;
/** @var IURLGenerator */
private $urlGenerator;
/** @var ICloudFederationProviderManager */
private $cloudFederationProviderManager;
/** @var Config */
private $config;
/** @var ICloudFederationFactory */
private $factory;
/** @var ICloudIdManager */
private $cloudIdManager;
public function __construct($appName,
IRequest $request,
ILogger $logger,
IUserManager $userManager,
IGroupManager $groupManager,
IURLGenerator $urlGenerator,
ICloudFederationProviderManager $cloudFederationProviderManager,
Config $config,
ICloudFederationFactory $factory,
ICloudIdManager $cloudIdManager
) {
parent::__construct($appName, $request);
$this->logger = $logger;
$this->userManager = $userManager;
$this->groupManager = $groupManager;
$this->urlGenerator = $urlGenerator;
$this->cloudFederationProviderManager = $cloudFederationProviderManager;
$this->config = $config;
$this->factory = $factory;
$this->cloudIdManager = $cloudIdManager;
}
/**
* add share
*
* @NoCSRFRequired
* @PublicPage
* @BruteForceProtection(action=receiveFederatedShare)
*
* @param string $shareWith
* @param string $name resource name (e.g. document.odt)
* @param string $description share description (optional)
* @param string $providerId resource UID on the provider side
* @param string $owner provider specific UID of the user who owns the resource
* @param string $ownerDisplayName display name of the user who shared the item
* @param string $sharedBy provider specific UID of the user who shared the resource
* @param string $sharedByDisplayName display name of the user who shared the resource
* @param array $protocol (e,.g. ['name' => 'webdav', 'options' => ['username' => 'john', 'permissions' => 31]])
* @param string $shareType ('group' or 'user' share)
* @param $resourceType ('file', 'calendar',...)
* @return Http\DataResponse|JSONResponse
*
* Example: curl -H "Content-Type: application/json" -X POST -d '{"shareWith":"admin1@serve1","name":"welcome server2.txt","description":"desc","providerId":"2","owner":"admin2@http://localhost/server2","ownerDisplayName":"admin2 display","shareType":"user","resourceType":"file","protocol":{"name":"webdav","options":{"sharedSecret":"secret","permissions":"webdav-property"}}}' http://localhost/server/index.php/ocm/shares
*/
public function addShare($shareWith, $name, $description, $providerId, $owner, $ownerDisplayName, $sharedBy, $sharedByDisplayName, $protocol, $shareType, $resourceType) {
// check if all required parameters are set
if ($shareWith === null ||
$name === null ||
$providerId === null ||
$owner === null ||
$resourceType === null ||
$shareType === null ||
!is_array($protocol) ||
!isset($protocol['name']) ||
!isset ($protocol['options']) ||
!is_array($protocol['options']) ||
!isset($protocol['options']['sharedSecret'])
) {
return new JSONResponse(
['message' => 'Missing arguments'],
Http::STATUS_BAD_REQUEST
);
}
$supportedShareTypes = $this->config->getSupportedShareTypes($resourceType);
if (!in_array($shareType, $supportedShareTypes)) {
return new JSONResponse(
['message' => 'Share type "' . $shareType . '" not implemented'],
Http::STATUS_NOT_IMPLEMENTED
);
}
$cloudId = $this->cloudIdManager->resolveCloudId($shareWith);
$shareWith = $cloudId->getUser();
if ($shareType === 'user') {
$shareWith = $this->mapUid($shareWith);
if (!$this->userManager->userExists($shareWith)) {
return new JSONResponse(
['message' => 'User "' . $shareWith . '" does not exists at ' . $this->urlGenerator->getBaseUrl()],
Http::STATUS_BAD_REQUEST
);
}
}
if ($shareType === 'group') {
if(!$this->groupManager->groupExists($shareWith)) {
return new JSONResponse(
['message' => 'Group "' . $shareWith . '" does not exists at ' . $this->urlGenerator->getBaseUrl()],
Http::STATUS_BAD_REQUEST
);
}
}
// if no explicit display name is given, we use the uid as display name
$ownerDisplayName = $ownerDisplayName === null ? $owner : $ownerDisplayName;
$sharedByDisplayName = $sharedByDisplayName === null ? $sharedBy : $sharedByDisplayName;
// sharedBy* parameter is optional, if nothing is set we assume that it is the same user as the owner
if ($sharedBy === null) {
$sharedBy = $owner;
$sharedByDisplayName = $ownerDisplayName;
}
try {
$provider = $this->cloudFederationProviderManager->getCloudFederationProvider($resourceType);
$share = $this->factory->getCloudFederationShare($shareWith, $name, $description, $providerId, $owner, $ownerDisplayName, $sharedBy, $sharedByDisplayName, '', $shareType, $resourceType);
$share->setProtocol($protocol);
$provider->shareReceived($share);
} catch (ProviderDoesNotExistsException $e) {
return new JSONResponse(
['message' => $e->getMessage()],
Http::STATUS_NOT_IMPLEMENTED
);
} catch (ProviderCouldNotAddShareException $e) {
return new JSONResponse(
['message' => $e->getMessage()],
$e->getCode()
);
} catch (\Exception $e) {
return new JSONResponse(
['message' => 'Internal error at ' . $this->urlGenerator->getBaseUrl()],
Http::STATUS_BAD_REQUEST
);
}
$user = $this->userManager->get($shareWith);
$recipientDisplayName = '';
if($user) {
$recipientDisplayName = $user->getDisplayName();
}
return new JSONResponse(
['recipientDisplayName' => $recipientDisplayName],
Http::STATUS_CREATED);
}
/**
* receive notification about existing share
*
* @NoCSRFRequired
* @PublicPage
* @BruteForceProtection(action=receiveFederatedShareNotification)
*
* @param string $notificationType (notification type, e.g. SHARE_ACCEPTED)
* @param string $resourceType (calendar, file, contact,...)
* @param string $providerId id of the share
* @param array $notification the actual payload of the notification
* @return JSONResponse
*/
public function receiveNotification($notificationType, $resourceType, $providerId, array $notification) {
// check if all required parameters are set
if ($notificationType === null ||
$resourceType === null ||
$providerId === null ||
!is_array($notification)
) {
return new JSONResponse(
['message' => 'Missing arguments'],
Http::STATUS_BAD_REQUEST
);
}
try {
$provider = $this->cloudFederationProviderManager->getCloudFederationProvider($resourceType);
$result = $provider->notificationReceived($notificationType, $providerId, $notification);
} catch (ProviderDoesNotExistsException $e) {
return new JSONResponse(
['message' => $e->getMessage()],
Http::STATUS_BAD_REQUEST
);
} catch (ShareNotFound $e) {
return new JSONResponse(
['message' => $e->getMessage()],
Http::STATUS_BAD_REQUEST
);
} catch (ActionNotSupportedException $e) {
return new JSONResponse(
['message' => $e->getMessage()],
Http::STATUS_NOT_IMPLEMENTED
);
} catch (BadRequestException $e) {
return new JSONResponse($e->getReturnMessage(), Http::STATUS_BAD_REQUEST);
} catch (AuthenticationFailedException $e) {
return new JSONResponse(["message" => "RESOURCE_NOT_FOUND"], Http::STATUS_FORBIDDEN);
}
catch (\Exception $e) {
return new JSONResponse(
['message' => 'Internal error at ' . $this->urlGenerator->getBaseUrl()],
Http::STATUS_BAD_REQUEST
);
}
return new JSONResponse($result,Http::STATUS_CREATED);
}
/**
* map login name to internal LDAP UID if a LDAP backend is in use
*
* @param string $uid
* @return string mixed
*/
private function mapUid($uid) {
// FIXME this should be a method in the user management instead
$this->logger->debug('shareWith before, ' . $uid, ['app' => $this->appName]);
\OCP\Util::emitHook(
'\OCA\Files_Sharing\API\Server2Server',
'preLoginNameUsedAsUserName',
array('uid' => &$uid)
);
$this->logger->debug('shareWith after, ' . $uid, ['app' => $this->appName]);
return $uid;
}
}
+11 -48
View File
@@ -1,62 +1,25 @@
<?php
/**
* @copyright Copyright (c) 2016, ownCloud, Inc.
* @copyright Copyright (c) 2018, Joas Schilling <coding@schilljs.com>
*
* @author Arthur Schiwon <blizzz@arthur-schiwon.de>
* @author Joas Schilling <coding@schilljs.com>
* @author Lukas Reschke <lukas@statuscode.ch>
* @author Vincent Petry <pvince81@owncloud.com>
*
* @license AGPL-3.0
* @license GNU AGPL version 3 or any later version
*
* This code is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License, version 3,
* as published by the Free Software Foundation.
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License, version 3,
* along with this program. If not, see <http://www.gnu.org/licenses/>
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
$eventDispatcher = \OC::$server->getEventDispatcher();
$eventDispatcher->addListener(
'OCA\Files::loadAdditionalScripts',
function() {
\OCP\Util::addScript('oc-backbone-webdav');
\OCP\Util::addScript('comments', 'merged');
\OCP\Util::addStyle('comments', 'autocomplete');
\OCP\Util::addStyle('comments', 'comments');
}
);
$eventDispatcher->addListener(\OCP\Comments\CommentsEntityEvent::EVENT_ENTITY, function(\OCP\Comments\CommentsEntityEvent $event) {
$event->addEntityCollection('files', function($name) {
$nodes = \OC::$server->getUserFolder()->getById(intval($name));
return !empty($nodes);
});
});
$notificationManager = \OC::$server->getNotificationManager();
$notificationManager->registerNotifier(
function() {
$application = new \OCP\AppFramework\App('comments');
return $application->getContainer()->query(\OCA\Comments\Notification\Notifier::class);
},
function () {
$l = \OC::$server->getL10N('comments');
return ['id' => 'comments', 'name' => $l->t('Comments')];
}
);
$commentsManager = \OC::$server->getCommentsManager();
$commentsManager->registerEventHandler(function () {
$application = new \OCP\AppFramework\App('comments');
/** @var \OCA\Comments\EventHandler $handler */
$handler = $application->getContainer()->query(\OCA\Comments\EventHandler::class);
return $handler;
});
$application = new \OCA\Comments\AppInfo\Application();
$application->register();
+11 -6
View File
@@ -1,19 +1,24 @@
<?xml version="1.0"?>
<info>
<info xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd">
<id>comments</id>
<name>Comments</name>
<summary>Files app plugin to add comments to files</summary>
<description>Files app plugin to add comments to files</description>
<licence>AGPL</licence>
<version>1.4.0</version>
<licence>agpl</licence>
<author>Arthur Schiwon</author>
<author>Vincent Petry</author>
<default_enable/>
<version>1.3.0</version>
<dependencies>
<nextcloud min-version="13" max-version="13" />
</dependencies>
<types>
<logging/>
</types>
<category>office</category>
<category>social</category>
<bugs>https://github.com/nextcloud/server/issues</bugs>
<dependencies>
<nextcloud min-version="14" max-version="14" />
</dependencies>
<activity>
<settings>
@@ -43,8 +43,7 @@ namespace Composer\Autoload;
class ClassLoader
{
// PSR-4
private $firstCharsPsr4 = array();
private $prefixLengthsPsr4 = array(); // For BC with legacy static maps
private $prefixLengthsPsr4 = array();
private $prefixDirsPsr4 = array();
private $fallbackDirsPsr4 = array();
@@ -171,10 +170,11 @@ class ClassLoader
}
} elseif (!isset($this->prefixDirsPsr4[$prefix])) {
// Register directories for a new namespace.
if ('\\' !== substr($prefix, -1)) {
$length = strlen($prefix);
if ('\\' !== $prefix[$length - 1]) {
throw new \InvalidArgumentException("A non-empty PSR-4 prefix must end with a namespace separator.");
}
$this->firstCharsPsr4[$prefix[0]] = true;
$this->prefixLengthsPsr4[$prefix[0]][$prefix] = $length;
$this->prefixDirsPsr4[$prefix] = (array) $paths;
} elseif ($prepend) {
// Prepend directories for an already registered namespace.
@@ -221,10 +221,11 @@ class ClassLoader
if (!$prefix) {
$this->fallbackDirsPsr4 = (array) $paths;
} else {
if ('\\' !== substr($prefix, -1)) {
$length = strlen($prefix);
if ('\\' !== $prefix[$length - 1]) {
throw new \InvalidArgumentException("A non-empty PSR-4 prefix must end with a namespace separator.");
}
$this->firstCharsPsr4[$prefix[0]] = true;
$this->prefixLengthsPsr4[$prefix[0]][$prefix] = $length;
$this->prefixDirsPsr4[$prefix] = (array) $paths;
}
}
@@ -372,11 +373,11 @@ class ClassLoader
$logicalPathPsr4 = strtr($class, '\\', DIRECTORY_SEPARATOR) . $ext;
$first = $class[0];
if (isset($this->firstCharsPsr4[$first]) || isset($this->prefixLengthsPsr4[$first])) {
if (isset($this->prefixLengthsPsr4[$first])) {
$subPath = $class;
while (false !== $lastPos = strrpos($subPath, '\\')) {
$subPath = substr($subPath, 0, $lastPos);
$search = $subPath.'\\';
$search = $subPath . '\\';
if (isset($this->prefixDirsPsr4[$search])) {
$pathEnd = DIRECTORY_SEPARATOR . substr($logicalPathPsr4, $lastPos + 1);
foreach ($this->prefixDirsPsr4[$search] as $dir) {
@@ -17,4 +17,6 @@ return array(
'OCA\\Comments\\JSSettingsHelper' => $baseDir . '/../lib/JSSettingsHelper.php',
'OCA\\Comments\\Notification\\Listener' => $baseDir . '/../lib/Notification/Listener.php',
'OCA\\Comments\\Notification\\Notifier' => $baseDir . '/../lib/Notification/Notifier.php',
'OCA\\Comments\\Search\\Provider' => $baseDir . '/../lib/Search/Provider.php',
'OCA\\Comments\\Search\\Result' => $baseDir . '/../lib/Search/Result.php',
);
@@ -6,8 +6,11 @@ namespace Composer\Autoload;
class ComposerStaticInitComments
{
public static $firstCharsPsr4 = array (
'O' => true,
public static $prefixLengthsPsr4 = array (
'O' =>
array (
'OCA\\Comments\\' => 13,
),
);
public static $prefixDirsPsr4 = array (
@@ -29,12 +32,14 @@ class ComposerStaticInitComments
'OCA\\Comments\\JSSettingsHelper' => __DIR__ . '/..' . '/../lib/JSSettingsHelper.php',
'OCA\\Comments\\Notification\\Listener' => __DIR__ . '/..' . '/../lib/Notification/Listener.php',
'OCA\\Comments\\Notification\\Notifier' => __DIR__ . '/..' . '/../lib/Notification/Notifier.php',
'OCA\\Comments\\Search\\Provider' => __DIR__ . '/..' . '/../lib/Search/Provider.php',
'OCA\\Comments\\Search\\Result' => __DIR__ . '/..' . '/../lib/Search/Result.php',
);
public static function getInitializer(ClassLoader $loader)
{
return \Closure::bind(function () use ($loader) {
$loader->firstCharsPsr4 = ComposerStaticInitComments::$firstCharsPsr4;
$loader->prefixLengthsPsr4 = ComposerStaticInitComments::$prefixLengthsPsr4;
$loader->prefixDirsPsr4 = ComposerStaticInitComments::$prefixDirsPsr4;
$loader->classMap = ComposerStaticInitComments::$classMap;
+15 -15
View File
@@ -9,11 +9,11 @@
left: 0;
display: none;
margin-top: 18px;
background: $color-main-background;
color: $color-main-text;
border: 1px solid $color-border;
border-radius: $border-radius;
box-shadow: 0 0 5px $color-box-shadow;
background: var(--color-main-background);
color: var(--color-main-text);
border: 1px solid var(--color-border);
border-radius: var(--border-radius);
box-shadow: 0 0 5px var(--color-box-shadow);
min-width: 120px;
z-index: 11110 !important;
}
@@ -22,14 +22,14 @@
padding: 5px;
margin: 5px;
cursor: pointer;
border-bottom: solid 1px $color-border;
color: $color-main-text;
border-bottom: solid 1px var(--color-border);
color: var(--color-main-text);
font-size: 11px;
font-weight: bold;
}
.atwho-view .atwho-header .small {
color: $color-main-text;
color: var(--color-main-text);
float: right;
padding-top: 2px;
margin-right: -5px;
@@ -42,18 +42,18 @@
}
.atwho-view .cur {
background: $color-primary;
color: $color-primary-text;
background: var(--color-primary);
color: var(--color-primary-text);
}
.atwho-view .cur small {
color: $color-primary-text;
color: var(--color-primary-text);
}
.atwho-view strong {
color: $color-main-text;
color: var(--color-main-text);
font-weight: normal;
}
.atwho-view .cur strong {
color: $color-primary-text;
color: var(--color-primary-text);
font-weight: normal;
}
.atwho-view ul {
@@ -67,11 +67,11 @@
.atwho-view ul li {
display: block;
padding: 5px 10px;
border-bottom: 1px solid $color-border;
border-bottom: 1px solid var(--color-border);
cursor: pointer;
}
.atwho-view small {
font-size: smaller;
color: $color-main-text;
color: var(--color-main-text);
font-weight: normal;
}
@@ -13,55 +13,46 @@
}
#commentsTabView .newCommentForm {
margin-left: 36px;
position: relative;
margin-bottom: 20px;
}
#commentsTabView .newCommentForm .message {
width: calc(100% - 81px); /* 36 (left margin) + 30 (right padding) + 15 (right padding of surrounding box) */
margin-left: 36px;
width: 100%;
padding: 10px;
min-height: 44px;
margin: 0;
/* Prevent the text from overlapping with the submit button. */
padding-right: 30px;
display: block;
}
#commentsTabView .newCommentForm .submit {
position: absolute;
bottom: 0px;
right: 8px;
width: 30px;
margin: 0;
padding: 7px 9px;
background-color: transparent;
border: none;
opacity: .3;
#commentsTabView .newCommentForm {
.submit,
.submitLoading {
width: 44px;
height: 44px;
margin: 0;
padding: 13px;
background-color: transparent;
border: none;
opacity: .3;
position: absolute;
bottom: 0;
right: 0;
}
}
#commentsTabView .deleteLoading {
padding: 14px;
vertical-align: middle;
}
#commentsTabView .newCommentForm .submit:not(:disabled):hover,
#commentsTabView .newCommentForm .submit:not(:disabled):focus {
opacity: 1;
}
#commentsTabView .newCommentForm .submitLoading {
background-position: left;
/* Match rules for '#commentsTabView .newCommentForm .submit' to place the
loading icon at the same position as the confirm icon */
position: absolute;
bottom: 0px;
right: 8px;
width: 30px;
margin: 0;
padding: 7px 9px;
/* Match rules for 'input[type="submit"]' to place the loading icon at the
same position as the confirm icon */
min-height: 34px;
box-sizing: border-box;
}
#commentsTabView .newCommentForm .cancel {
margin-right: 6px;
}
#commentsTabView .newCommentForm div.message {
resize: none;
}
@@ -73,9 +64,12 @@
#commentsTabView .comment {
position: relative;
margin-bottom: 30px;
word-wrap: break-word;
overflow-wrap: break-word;
/** padding bottom is little more so that the top and bottom gap look uniform **/
padding: 10px 0px 15px;
}
#commentsTabView .comments .comment {
border-top: 1px solid var(--color-border);
}
#commentsTabView .comment .avatar,
@@ -123,20 +117,23 @@
background: -o-linear-gradient(rgba(255,255,255,0), rgba(255,255,255,1));
background: -ms-linear-gradient(rgba(255,255,255,0), rgba(255,255,255,1));
background: linear-gradient(rgba(255,255,255,0), rgba(255,255,255,1));
filter: progid:DXImageTransform.Microsoft.gradient(GradientType=0,startColorstr='#00FFFFFF', endColorstr='#FFFFFFFF');
background-repeat: no-repeat;
}
#commentsTabView .authorRow>div:not(.contactsmenu-popover) {
display: inline-block;
vertical-align: middle;
}
#commentsTabView .authorRow>div.hidden {
#commentsTabView .hidden {
display: none !important;
}
#commentsTabView .comments li .message .avatar-name-wrapper,
/** set min-height as 44px to ensure that it fits the button sizes. **/
#commentsTabView .comment .authorRow {
min-height: 44px;
}
#commentsTabView .comment .authorRow .tooltip {
/** because of the padding on the element, the tooltip appear too far up,
adding this brings them closer to the element**/
margin-top: 5px;
}
.atwho-view-ul * .avatar-name-wrapper,
#commentsTabView .comment .authorRow {
position: relative;
@@ -147,64 +144,105 @@
#commentsTabView .comment:not(.newCommentRow) .message .avatar-name-wrapper:not(.currentUser),
#commentsTabView .comment:not(.newCommentRow) .message .avatar-name-wrapper:not(.currentUser) .avatar,
#commentsTabView .comment:not(.newCommentRow) .message .avatar-name-wrapper:not(.currentUser) .avatar img,
#commentsTabView .comment .authorRow .avatar:not(.currentUser),
#commentsTabView .comment .authorRow .author:not(.currentUser) {
cursor: pointer;
}
.atwho-view-ul .avatar-name-wrapper,
.atwho-view-ul .avatar-name-wrapper .avatar {
.atwho-view-ul .avatar-name-wrapper .avatar,
.atwho-view-ul .avatar-name-wrapper .avatar img {
cursor: pointer;
}
#commentsTabView .comments li .message .atwho-inserted {
margin-left: 5px;
#commentsTabView .comments li .message .atwho-inserted,
#commentsTabView .newCommentForm .atwho-inserted {
.avatar-name-wrapper {
/* Make the wrapper the positioning context of its child contacts
* menu. */
position: relative;
display: inline;
vertical-align: top;
background-color: var(--color-background-dark);
border-radius: 50vh;
padding: 1px 7px 1px 1px;
/* Ensure that the avatar and the user name will be kept together. */
white-space: nowrap;
.avatar {
img {
vertical-align: top;
}
height: 16px;
width: 16px;
vertical-align: middle;
padding: 1px;
margin-top: -3px;
margin-left: 0;
margin-right: 2px;
}
strong {
/* Ensure that the user name is shown in bold, as different browsers
* use different font weights for strong elements. */
font-weight: bold;
}
}
.avatar-name-wrapper.currentUser {
background-color: var(--color-primary);
color: var(--color-primary-text);
}
}
.atwho-view-ul * .avatar-name-wrapper {
white-space: nowrap;
}
#commentsTabView .comment .author,
#commentsTabView .comment .date {
opacity: .5;
}
#commentsTabView .comment .author {
max-width: 210px;
text-overflow: ellipsis;
overflow: hidden;
white-space: nowrap;
}
#commentsTabView .comment .date {
margin-left: auto;
/** this is to fix the tooltip being too close due to the margin-top applied
to bring the tooltip closer for the action icons **/
padding: 10px 0px;
}
#commentsTabView .comments li .message {
#commentsTabView .comments > li:not(.newCommentRow) .message {
padding-left: 40px;
display: inline-flex;
flex-wrap: wrap;
align-items: center;
word-wrap: break-word;
overflow-wrap: break-word;
}
#commentsTabView .comment .action {
opacity: 0;
padding: 5px;
}
#commentsTabView .comment:hover .action {
opacity: 0.3;
padding: 14px;
display: block;
}
#commentsTabView .comment .action:hover {
#commentsTabView .comment .action:hover,
#commentsTabView .comment .action:focus {
opacity: 1;
}
#commentsTabView .comment .action.delete,
#commentsTabView .comment .deleteLoading {
position: absolute;
right: 0;
#commentsTabView .newCommentRow .action-container {
margin-left: auto;
}
#commentsTabView .comment.disabled {
#commentsTabView .comment.disabled .message {
opacity: 0.3;
}
#commentsTabView .comment.disabled .action {
visibility: hidden;
display: none;
}
#commentsTabView .message.error {
@@ -216,3 +254,8 @@
.app-files .action-comment {
padding: 16px 14px;
}
#commentsTabView .comment .message .contactsmenu-popover {
left: -6px;
top: 24px;
}
+124
View File
@@ -0,0 +1,124 @@
/*
* Copyright (c) 2018
*
* This file is licensed under the Affero General Public License version 3
* or later.
*
* See the COPYING-README file.
*
*/
/* global Handlebars */
(function() {
var TEMPLATE_MENU =
'<ul>' +
'{{#each items}}' +
'<li>' +
'<a href="#" class="menuitem action {{name}} permanent" data-action="{{name}}">' +
'{{#if iconClass}}' +
'<span class="icon {{iconClass}}"></span>' +
'{{else}}' +
'<span class="no-icon"></span>' +
'{{/if}}' +
'<span>{{displayName}}</span>' +
'</li>' +
'{{/each}}' +
'</ul>';
/**
* Construct a new CommentsModifyMenuinstance
* @constructs CommentsModifyMenu
* @memberof OC.Comments
*/
var CommentsModifyMenu = OC.Backbone.View.extend({
tagName: 'div',
className: 'commentsModifyMenu popovermenu bubble menu',
_scopes: [
{
name: 'edit',
displayName: t('comments', 'Edit comment'),
iconClass: 'icon-rename'
},
{
name: 'delete',
displayName: t('comments', 'Delete comment'),
iconClass: 'icon-delete'
}
],
initialize: function() {
},
events: {
'click a.action': '_onClickAction'
},
template: Handlebars.compile(TEMPLATE_MENU),
/**
* Event handler whenever an action has been clicked within the menu
*
* @param {Object} event event object
*/
_onClickAction: function(event) {
var $target = $(event.currentTarget);
if (!$target.hasClass('menuitem')) {
$target = $target.closest('.menuitem');
}
OC.hideMenus();
this.trigger('select:menu-item-clicked', event, $target.data('action'));
},
/**
* Renders the menu with the currently set items
*/
render: function() {
this.$el.html(this.template({
items: this._scopes
}));
},
/**
* Displays the menu
*/
show: function(context) {
this._context = context;
for(var i in this._scopes) {
this._scopes[i].active = false;
}
var $el = $(context.target);
var offsetIcon = $el.offset();
var offsetContainer = $el.closest('.authorRow').offset();
// adding some extra top offset to push the menu below the button.
var position = {
top: offsetIcon.top - offsetContainer.top + 48,
left: '',
right: ''
};
position.left = offsetIcon.left - offsetContainer.left;
if (position.left > 200) {
// we need to position the menu to the right.
position.left = '';
position.right = this.$el.closest('.comment').find('.date').width();
this.$el.removeClass('menu-left').addClass('menu-right');
} else {
this.$el.removeClass('menu-right').addClass('menu-left');
}
this.$el.css(position);
this.render();
this.$el.removeClass('hidden');
OC.showMenu(null, this.$el);
}
});
OCA.Comments = OCA.Comments || {};
OCA.Comments.CommentsModifyMenu = CommentsModifyMenu;
})(OC, OCA);
+105 -66
View File
@@ -21,24 +21,22 @@
'<div class="loading hidden" style="height: 50px"></div>';
var EDIT_COMMENT_TEMPLATE =
'<div class="newCommentRow comment" data-id="{{id}}">' +
'<{{tag}} class="newCommentRow comment" data-id="{{id}}">' +
' <div class="authorRow">' +
' <div class="avatar currentUser" data-username="{{actorId}}"></div>' +
' <div class="author currentUser">{{actorDisplayName}}</div>' +
'{{#if isEditMode}}' +
' <a href="#" class="action delete icon icon-delete has-tooltip" title="{{deleteTooltip}}"></a>' +
' <div class="deleteLoading icon-loading-small hidden"></div>'+
' <div class="action-container">' +
' <a href="#" class="action cancel icon icon-close has-tooltip" title="{{cancelText}}"></a>' +
' </div>' +
'{{/if}}' +
' </div>' +
' <form class="newCommentForm">' +
' <div contentEditable="true" class="message" data-placeholder="{{newMessagePlaceholder}}">{{message}}</div>' +
' <input class="submit icon-confirm" type="submit" value="" />' +
'{{#if isEditMode}}' +
' <input class="cancel pull-right" type="button" value="{{cancelText}}" />' +
'{{/if}}' +
' <input class="submit icon-confirm has-tooltip" type="submit" value="" title="{{submitText}}"/>' +
' <div class="submitLoading icon-loading-small hidden"></div>'+
' </form>' +
'</div>';
'</{{tag}}>';
var COMMENT_TEMPLATE =
'<li class="comment{{#if isUnread}} unread{{/if}}{{#if isLong}} collapsed{{/if}}" data-id="{{id}}">' +
@@ -46,7 +44,8 @@
' <div class="avatar{{#if isUserAuthor}} currentUser{{/if}}" {{#if actorId}}data-username="{{actorId}}"{{/if}}> </div>' +
' <div class="author{{#if isUserAuthor}} currentUser{{/if}}">{{actorDisplayName}}</div>' +
'{{#if isUserAuthor}}' +
' <a href="#" class="action edit icon icon-rename has-tooltip" title="{{editTooltip}}"></a>' +
' <a href="#" class="action more icon icon-more has-tooltip"></a>' +
' <div class="deleteLoading icon-loading-small hidden"></div>' +
'{{/if}}' +
' <div class="date has-tooltip live-relative-timestamp" data-timestamp="{{timestamp}}" title="{{altDate}}">{{date}}</div>' +
' </div>' +
@@ -64,12 +63,11 @@
id: 'commentsTabView',
className: 'tab commentsTabView',
_autoCompleteData: undefined,
_commentsModifyMenu: undefined,
events: {
'submit .newCommentForm': '_onSubmitComment',
'click .showMore': '_onClickShowMore',
'click .action.edit': '_onClickEditComment',
'click .action.delete': '_onClickDeleteComment',
'click .cancel': '_onClickCloseComment',
'click .comment': '_onClickComment',
'keyup div.message': '_onTextChange',
@@ -114,9 +112,9 @@
actorId: currentUser.uid,
actorDisplayName: currentUser.displayName,
newMessagePlaceholder: t('comments', 'New comment …'),
deleteTooltip: t('comments', 'Delete comment'),
submitText: t('comments', 'Post'),
cancelText: t('comments', 'Cancel')
cancelText: t('comments', 'Cancel'),
tag: 'li'
}, params));
},
@@ -166,7 +164,7 @@
emptyResultLabel: t('comments', 'No comments yet, start the conversation!'),
moreLabel: t('comments', 'More comments …')
}));
this.$el.find('.comments').before(this.editCommentTemplate({}));
this.$el.find('.comments').before(this.editCommentTemplate({ tag: 'div'}));
this.$el.find('.has-tooltip').tooltip();
this.$container = this.$el.find('ul.comments');
this.$el.find('.avatar').avatar(OC.getCurrentUser().uid, 32);
@@ -174,6 +172,7 @@
this.$el.find('.message').on('keydown input change', this._onTypeComment);
autosize(this.$el.find('.newCommentRow .message'))
this.$el.find('.newCommentForm .message').focus();
},
_initAutoComplete: function($target) {
@@ -196,22 +195,28 @@
},
sorter: function (q, items) { return items; }
},
displayTpl: '<li>'
+ '<span class="avatar-name-wrapper">'
+ '<div class="avatar" '
+ 'data-username="${id}"' // for avatars
+ ' data-user="${id}"' // for contactsmenu
+ ' data-user-display-name="${label}"></div>'
+ ' <strong>${label}</strong>'
+ '</span></li>',
insertTpl: ''
+ '<span class="avatar-name-wrapper">'
+ '<div class="avatar" '
+ 'data-username="${id}"' // for avatars
+ ' data-user="${id}"' // for contactsmenu
+ ' data-user-display-name="${label}"></div>'
+ ' <strong>${label}</strong>'
+ '</span>',
displayTpl: function (item) {
return '<li>' +
'<span class="avatar-name-wrapper">' +
'<span class="avatar" ' +
'data-username="' + escapeHTML(item.id) + '" ' + // for avatars
'data-user="' + escapeHTML(item.id) + '" ' + // for contactsmenu
'data-user-display-name="' + escapeHTML(item.label) + '">' +
'</span>' +
'<strong>' + escapeHTML(item.label) + '</strong>' +
'</span></li>';
},
insertTpl: function (item) {
return '' +
'<span class="avatar-name-wrapper">' +
'<span class="avatar" ' +
'data-username="' + escapeHTML(item.id) + '" ' + // for avatars
'data-user="' + escapeHTML(item.id) + '" ' + // for contactsmenu
'data-user-display-name="' + escapeHTML(item.label) + '">' +
'</span>' +
'<strong>' + escapeHTML(item.label) + '</strong>' +
'</span>';
},
searchKey: "label"
});
$target.on('inserted.atwho', function (je, $el) {
@@ -221,7 +226,7 @@
// passing the whole comments form would re-apply and request
// avatars from the server
$(je.target).find(
'div[data-username="' + $el.find('[data-username]').data('username') + '"]'
'span[data-username="' + $el.find('[data-username]').data('username') + '"]'
).parent(),
editionMode
);
@@ -240,19 +245,22 @@
if(!_.isUndefined(this._autoCompleteRequestCall)) {
this._autoCompleteRequestCall.abort();
}
this._autoCompleteRequestCall = $.get(
OC.generateUrl('/autocomplete/get'),
{
this._autoCompleteRequestCall = $.ajax({
url: OC.linkToOCS('core', 2) + 'autocomplete/get',
data: {
search: query,
itemType: 'files',
itemId: s.model.get('id'),
sorter: 'commenters|share-recipients',
limit: OC.appConfig.comments.maxAutoCompleteResults
},
function (data) {
callback(data);
beforeSend: function (request) {
request.setRequestHeader('Accept', 'application/json');
},
success: function (result) {
callback(result.ocs.data);
}
);
});
}, 400);
},
@@ -302,6 +310,8 @@
}
);
}
this.$el.find('.newCommentForm .message').focus();
},
/**
@@ -382,7 +392,15 @@
_postRenderItem: function($el, editionMode) {
$el.find('.has-tooltip').tooltip();
$el.find('.avatar').each(function() {
var inlineAvatars = $el.find('.message .avatar');
if ($($el.context).hasClass('message')) {
inlineAvatars = $el.find('.avatar');
}
inlineAvatars.each(function () {
var $this = $(this);
$this.avatar($this.attr('data-username'), 16);
});
$el.find('.authorRow .avatar').each(function () {
var $this = $(this);
$this.avatar($this.attr('data-username'), 32);
});
@@ -398,6 +416,24 @@
// it is the case when writing a comment and mentioning a person
$message = $el;
}
if (!editionMode) {
var self = this;
// add the dropdown menu to display the edit and delete option
var modifyCommentMenu = new OCA.Comments.CommentsModifyMenu();
$el.find('.authorRow').append(modifyCommentMenu.$el);
$el.find('.more').on('click', _.bind(modifyCommentMenu.show, modifyCommentMenu));
self.listenTo(modifyCommentMenu, 'select:menu-item-clicked', function(ev, action) {
if (action === 'edit') {
self._onClickEditComment(ev);
} else if (action === 'delete') {
self._onClickDeleteComment(ev);
}
});
}
this._postRenderMessage($message, editionMode);
},
@@ -406,14 +442,13 @@
return;
}
$el.find('.avatar').each(function() {
var avatar = $(this);
var strong = $(this).next();
var appendTo = $(this).parent();
$el.find('.avatar-name-wrapper').each(function() {
var $this = $(this);
var $avatar = $this.find('.avatar');
var username = $(this).data('username');
if (username !== oc_current_user) {
$.merge(avatar, strong).contactsMenu(avatar.data('user'), 0, appendTo);
var user = $avatar.data('user');
if (user !== OC.getCurrentUser().uid) {
$this.contactsMenu(user, 0, $this);
}
});
},
@@ -452,20 +487,22 @@
},
_composeHTMLMention: function(uid, displayName) {
var avatar = '<div class="avatar" '
+ 'data-username="' + _.escape(uid) + '"'
+ ' data-user="' + _.escape(uid) + '"'
+ ' data-user-display-name="'
+ _.escape(displayName) + '"></div>';
var avatar = '' +
'<span class="avatar" ' +
'data-username="' + _.escape(uid) + '" ' +
'data-user="' + _.escape(uid) + '" ' +
'data-user-display-name="' + _.escape(displayName) + '">' +
'</span>';
var isCurrentUser = (uid === OC.getCurrentUser().uid);
return ''
+ '<span class="atwho-inserted" contenteditable="false">'
+ '<span class="avatar-name-wrapper' + (isCurrentUser ? ' currentUser' : '') + '">'
+ avatar + ' <strong>'+ _.escape(displayName)+'</strong>'
+ '</span>'
+ '</span>';
return '' +
'<span class="atwho-inserted" contenteditable="false">' +
'<span class="avatar-name-wrapper' + (isCurrentUser ? ' currentUser' : '') + '">' +
avatar +
'<strong>' + _.escape(displayName) + '</strong>' +
'</span>' +
'</span>';
},
nextPage: function() {
@@ -564,15 +601,13 @@
var $comment = $(ev.target).closest('.comment');
var commentId = $comment.data('id');
var $loading = $comment.find('.deleteLoading');
var $commentField = $comment.find('.message');
var $submit = $comment.find('.submit');
var $cancel = $comment.find('.cancel');
var $moreIcon = $comment.find('.more');
$commentField.prop('contenteditable', false);
$submit.prop('disabled', true);
$cancel.prop('disabled', true);
$comment.addClass('disabled');
$loading.removeClass('hidden');
$moreIcon.addClass('hidden');
$comment.data('commentEl', $comment);
this.collection.get(commentId).destroy({
success: function() {
@@ -581,12 +616,10 @@
},
error: function() {
$loading.addClass('hidden');
$moreIcon.removeClass('hidden');
$comment.removeClass('disabled');
$commentField.prop('contenteditable', true);
$submit.prop('disabled', false);
$cancel.prop('disabled', false);
OC.Notification.showTemporary(t('comments', 'Error occurred while retrieving comment with id {id}', {id: commentId}));
OC.Notification.showTemporary(t('comments', 'Error occurred while retrieving comment with ID {id}', {id: commentId}));
}
});
@@ -665,6 +698,12 @@
}, {
success: function(model) {
self._onSubmitSuccess(model, $form);
if(model.get('message').trim() === model.previous('message').trim()) {
// model change event doesn't trigger, manually remove the row.
var $row = $form.closest('.comment');
$row.data('commentEl').removeClass('hidden');
$row.remove();
}
},
error: function() {
self._onSubmitError($form, commentId);
+2
View File
@@ -4,8 +4,10 @@
"commentcollection.js",
"commentsummarymodel.js",
"commentstabview.js",
"commentsmodifymenu.js",
"filesplugin.js",
"activitytabviewplugin.js",
"search.js",
"vendor/Caret.js/dist/jquery.caret.min.js",
"vendor/At.js/dist/js/jquery.atwho.min.js"
]
+134
View File
@@ -0,0 +1,134 @@
/*
* Copyright (c) 2014
*
* This file is licensed under the Affero General Public License version 3
* or later.
*
* See the COPYING-README file.
*
*/
(function(OC, OCA, $) {
"use strict";
/**
* Construct a new FileActions instance
* @constructs Files
*/
var Comment = function() {
this.initialize();
};
Comment.prototype = {
fileList: null,
/**
* Initialize the file search
*/
initialize: function() {
var self = this;
this.fileAppLoaded = function() {
return !!OCA.Files && !!OCA.Files.App;
};
function inFileList($row, result) {
return false;
if (! self.fileAppLoaded()) {
return false;
}
var dir = self.fileList.getCurrentDirectory().replace(/\/+$/,'');
var resultDir = OC.dirname(result.path);
return dir === resultDir && self.fileList.inList(result.name);
}
function hideNoFilterResults() {
var $nofilterresults = $('.nofilterresults');
if ( ! $nofilterresults.hasClass('hidden') ) {
$nofilterresults.addClass('hidden');
}
}
/**
*
* @param {jQuery} $row
* @param {Object} result
* @param {int} result.id
* @param {string} result.comment
* @param {string} result.authorId
* @param {string} result.authorName
* @param {string} result.link
* @param {string} result.fileName
* @param {string} result.path
* @returns {*}
*/
this.renderCommentResult = function($row, result) {
if (inFileList($row, result)) {
return null;
}
hideNoFilterResults();
/*render preview icon, show path beneath filename,
show size and last modified date on the right */
this.updateLegacyMimetype(result);
var $pathDiv = $('<div>').addClass('path').text(result.path);
var $avatar = $('<div>');
$avatar.addClass('avatar')
.css('display', 'inline-block')
.css('vertical-align', 'middle')
.css('margin', '0 5px 2px 3px');
if (result.authorName) {
$avatar.avatar(result.authorId, 21, undefined, false, undefined, result.authorName);
} else {
$avatar.avatar(result.authorId, 21);
}
$row.find('td.info div.name').after($pathDiv).text(result.comment).prepend($('<span>').addClass('path').css('margin-right', '5px').text(result.authorName)).prepend($avatar);
$row.find('td.result a').attr('href', result.link);
$row.find('td.icon')
.css('background-image', 'url(' + OC.imagePath('core', 'actions/comment') + ')')
.css('opacity', '.4');
var dir = OC.dirname(result.path);
if (dir === '') {
dir = '/';
}
$row.find('td.info a').attr('href',
OC.generateUrl('/apps/files/?dir={dir}&scrollto={scrollto}', {dir: dir, scrollto: result.fileName})
);
return $row;
};
this.handleCommentClick = function($row, result, event) {
if (self.fileAppLoaded() && self.fileList.id === 'files') {
self.fileList.changeDirectory(OC.dirname(result.path));
self.fileList.scrollTo(result.name);
return false;
} else {
return true;
}
};
this.updateLegacyMimetype = function (result) {
// backward compatibility:
if (!result.mime && result.mime_type) {
result.mime = result.mime_type;
}
};
this.setFileList = function (fileList) {
this.fileList = fileList;
};
OC.Plugins.register('OCA.Search.Core', this);
},
attach: function(search) {
search.setRenderer('comment', this.renderCommentResult.bind(this));
search.setHandler('comment', this.handleCommentClick.bind(this));
}
};
OCA.Search.comment = new Comment();
})(OC, OCA, $);
+6 -4
View File
@@ -1,18 +1,18 @@
OC.L10N.register(
"comments",
{
"Comments" : "Kommentare",
"New comment …" : "Nuwe kommentaar…",
"Edit comment" : "Wysig kommentaar",
"Delete comment" : "Skrap kommentaar",
"New comment …" : "Nuwe kommentaar…",
"Post" : "Plaas",
"Cancel" : "Kanselleer",
"Edit comment" : "Wysig kommentaar",
"[Deleted user]" : "[Geskrapte gebruiker]",
"Comments" : "Kommentare",
"No comments yet, start the conversation!" : "Nog geen kommentaar, begin die gesprek!",
"More comments …" : "Nog kommentare …",
"Save" : "Bewaar",
"Allowed characters {count} of {max}" : "Toegelate karakters {telling} van {maks}",
"Error occurred while retrieving comment with id {id}" : "n Fout het voorgekom toe kommentaar met id {id} opgehaal is",
"Error occurred while retrieving comment with ID {id}" : "n Fout het voorgekom toe kommentaar met id {id} opgehaal is",
"Error occurred while updating comment with id {id}" : "n Fout het voorgekom toe kommentaar met id {id} bygewerk is",
"Error occurred while posting comment" : "n Fout het voorgekom toe kommentaar geplaas is",
"_%n unread comment_::_%n unread comments_" : ["%n ongeleesde kommentaar","%n ongeleeste kommentare"],
@@ -25,6 +25,8 @@ OC.L10N.register(
"%1$s commented on %2$s" : "%1$s het op %2$s kommentaar gelewer",
"{author} commented on {file}" : "{outeur} het op {lêer} kommentaar gelewer",
"<strong>Comments</strong> for files" : "<strong>Kommentare</strong> vir lêers",
"You were mentioned on “%s”, in a comment by a user that has since been deleted" : "Jy was genoem op \"%s\", in die kommentaar van 'n gebruiker wat intussen geskrap is.",
"You were mentioned on “{file}”, in a comment by a user that has since been deleted" : "Jy was genoem op “{lêer}”, in die kommentaar van 'n gebruiker wat intussen geskrap is.",
"%1$s mentioned you in a comment on “%2$s”" : "%1$s het u in n kommentaar op “%2$s” genoem",
"{user} mentioned you in a comment on “{file}”" : "{gebruiker} het u in n kommentaar oor “{lêer}” genoem",
"Unknown user" : "Onbekende gebruiker",
+6 -4
View File
@@ -1,16 +1,16 @@
{ "translations": {
"Comments" : "Kommentare",
"New comment …" : "Nuwe kommentaar…",
"Edit comment" : "Wysig kommentaar",
"Delete comment" : "Skrap kommentaar",
"New comment …" : "Nuwe kommentaar…",
"Post" : "Plaas",
"Cancel" : "Kanselleer",
"Edit comment" : "Wysig kommentaar",
"[Deleted user]" : "[Geskrapte gebruiker]",
"Comments" : "Kommentare",
"No comments yet, start the conversation!" : "Nog geen kommentaar, begin die gesprek!",
"More comments …" : "Nog kommentare …",
"Save" : "Bewaar",
"Allowed characters {count} of {max}" : "Toegelate karakters {telling} van {maks}",
"Error occurred while retrieving comment with id {id}" : "n Fout het voorgekom toe kommentaar met id {id} opgehaal is",
"Error occurred while retrieving comment with ID {id}" : "n Fout het voorgekom toe kommentaar met id {id} opgehaal is",
"Error occurred while updating comment with id {id}" : "n Fout het voorgekom toe kommentaar met id {id} bygewerk is",
"Error occurred while posting comment" : "n Fout het voorgekom toe kommentaar geplaas is",
"_%n unread comment_::_%n unread comments_" : ["%n ongeleesde kommentaar","%n ongeleeste kommentare"],
@@ -23,6 +23,8 @@
"%1$s commented on %2$s" : "%1$s het op %2$s kommentaar gelewer",
"{author} commented on {file}" : "{outeur} het op {lêer} kommentaar gelewer",
"<strong>Comments</strong> for files" : "<strong>Kommentare</strong> vir lêers",
"You were mentioned on “%s”, in a comment by a user that has since been deleted" : "Jy was genoem op \"%s\", in die kommentaar van 'n gebruiker wat intussen geskrap is.",
"You were mentioned on “{file}”, in a comment by a user that has since been deleted" : "Jy was genoem op “{lêer}”, in die kommentaar van 'n gebruiker wat intussen geskrap is.",
"%1$s mentioned you in a comment on “%2$s”" : "%1$s het u in n kommentaar op “%2$s” genoem",
"{user} mentioned you in a comment on “{file}”" : "{gebruiker} het u in n kommentaar oor “{lêer}” genoem",
"Unknown user" : "Onbekende gebruiker",
+5 -6
View File
@@ -1,19 +1,17 @@
OC.L10N.register(
"comments",
{
"Comments" : "تعليقات",
"Unknown user" : "مستخدم غير معروف",
"New comment …" : "تعليق جديد",
"Edit comment" : "تعديل التعليق",
"Delete comment" : "حذف التعليق",
"New comment …" : "تعليق جديد",
"Post" : "ارسال",
"Cancel" : "إلغاء",
"Edit comment" : "تعديل التعليق",
"[Deleted user]" : "[مستخدم محذوف]",
"Comments" : "تعليقات",
"No comments yet, start the conversation!" : "لا يوجد تعليقات, ابدأ النقاش الآن!",
"More comments …" : "مزيد من التعليقات...",
"Save" : "حفظ",
"Allowed characters {count} of {max}" : "عدد الأحرف المسموح بها {count} من {max}",
"Error occurred while retrieving comment with id {id}" : "حصل خطأ أثناء عرض التعليق رقم {id}",
"Error occurred while updating comment with id {id}" : "حصل خطأ أثناء تعديل التعليق رقم {id}",
"Error occurred while posting comment" : "حصل خطأ أثناء إرسال التعليق",
"Comment" : "تعليق",
@@ -22,6 +20,7 @@ OC.L10N.register(
"You commented on {file}" : "علقت على {file}",
"%1$s commented on %2$s" : "%1$s كتب تعليق على %2$s",
"{author} commented on {file}" : "{author} علّق على {file}",
"<strong>Comments</strong> for files" : "<strong>تعليقات</strong> على الملفات"
"<strong>Comments</strong> for files" : "<strong>تعليقات</strong> على الملفات",
"Unknown user" : "مستخدم غير معروف"
},
"nplurals=6; plural=n==0 ? 0 : n==1 ? 1 : n==2 ? 2 : n%100>=3 && n%100<=10 ? 3 : n%100>=11 && n%100<=99 ? 4 : 5;");
+5 -6
View File
@@ -1,17 +1,15 @@
{ "translations": {
"Comments" : "تعليقات",
"Unknown user" : "مستخدم غير معروف",
"New comment …" : "تعليق جديد",
"Edit comment" : "تعديل التعليق",
"Delete comment" : "حذف التعليق",
"New comment …" : "تعليق جديد",
"Post" : "ارسال",
"Cancel" : "إلغاء",
"Edit comment" : "تعديل التعليق",
"[Deleted user]" : "[مستخدم محذوف]",
"Comments" : "تعليقات",
"No comments yet, start the conversation!" : "لا يوجد تعليقات, ابدأ النقاش الآن!",
"More comments …" : "مزيد من التعليقات...",
"Save" : "حفظ",
"Allowed characters {count} of {max}" : "عدد الأحرف المسموح بها {count} من {max}",
"Error occurred while retrieving comment with id {id}" : "حصل خطأ أثناء عرض التعليق رقم {id}",
"Error occurred while updating comment with id {id}" : "حصل خطأ أثناء تعديل التعليق رقم {id}",
"Error occurred while posting comment" : "حصل خطأ أثناء إرسال التعليق",
"Comment" : "تعليق",
@@ -20,6 +18,7 @@
"You commented on {file}" : "علقت على {file}",
"%1$s commented on %2$s" : "%1$s كتب تعليق على %2$s",
"{author} commented on {file}" : "{author} علّق على {file}",
"<strong>Comments</strong> for files" : "<strong>تعليقات</strong> على الملفات"
"<strong>Comments</strong> for files" : "<strong>تعليقات</strong> على الملفات",
"Unknown user" : "مستخدم غير معروف"
},"pluralForm" :"nplurals=6; plural=n==0 ? 0 : n==1 ? 1 : n==2 ? 2 : n%100>=3 && n%100<=10 ? 3 : n%100>=11 && n%100<=99 ? 4 : 5;"
}
+3 -4
View File
@@ -1,18 +1,17 @@
OC.L10N.register(
"comments",
{
"Comments" : "Comentarios",
"New comment …" : "Comentariu nuevu...",
"Edit comment" : "Editar comentariu",
"Delete comment" : "Desaniciar comentariu",
"New comment …" : "Comentariu nuevu...",
"Post" : "Espublizar",
"Cancel" : "Encaboxar",
"Edit comment" : "Editar comentariu",
"[Deleted user]" : "[Usuariu desaniciáu]",
"Comments" : "Comentarios",
"No comments yet, start the conversation!" : "Entá nun hai comentarios. ¡Entama una conversación!",
"More comments …" : "Más comentarios...",
"Save" : "Guardar",
"Allowed characters {count} of {max}" : "{count} caráuteres almitíos de {max}",
"Error occurred while retrieving comment with id {id}" : "Asocedió un fallu entrín se recibía'l comentariu cola ID {id}",
"Error occurred while updating comment with id {id}" : "Asocedió un fallu entrín s'anovaba'l comentariu cola ID {id}",
"Error occurred while posting comment" : "Asocedieron fallos entrín s'espublizaba'l comentariu",
"_%n unread comment_::_%n unread comments_" : ["%n comentariu ensin lleer","%n comentarios ensin lleer"],
+3 -4
View File
@@ -1,16 +1,15 @@
{ "translations": {
"Comments" : "Comentarios",
"New comment …" : "Comentariu nuevu...",
"Edit comment" : "Editar comentariu",
"Delete comment" : "Desaniciar comentariu",
"New comment …" : "Comentariu nuevu...",
"Post" : "Espublizar",
"Cancel" : "Encaboxar",
"Edit comment" : "Editar comentariu",
"[Deleted user]" : "[Usuariu desaniciáu]",
"Comments" : "Comentarios",
"No comments yet, start the conversation!" : "Entá nun hai comentarios. ¡Entama una conversación!",
"More comments …" : "Más comentarios...",
"Save" : "Guardar",
"Allowed characters {count} of {max}" : "{count} caráuteres almitíos de {max}",
"Error occurred while retrieving comment with id {id}" : "Asocedió un fallu entrín se recibía'l comentariu cola ID {id}",
"Error occurred while updating comment with id {id}" : "Asocedió un fallu entrín s'anovaba'l comentariu cola ID {id}",
"Error occurred while posting comment" : "Asocedieron fallos entrín s'espublizaba'l comentariu",
"_%n unread comment_::_%n unread comments_" : ["%n comentariu ensin lleer","%n comentarios ensin lleer"],
+5 -4
View File
@@ -1,18 +1,17 @@
OC.L10N.register(
"comments",
{
"Comments" : "Коментари",
"New comment …" : "Нов коментар...",
"Edit comment" : "Редактирай коментра",
"Delete comment" : "Изтрий коментар",
"New comment …" : "Нов коментар...",
"Post" : "Публикация",
"Cancel" : "Отказ",
"Edit comment" : "Редактирай коментра",
"[Deleted user]" : "[Изтрит потребител]",
"Comments" : "Коментари",
"No comments yet, start the conversation!" : "Все-още няма коментари, започни разговор!",
"More comments …" : "Още коментари...",
"Save" : "Запазване",
"Allowed characters {count} of {max}" : "Позволени символи {count} от {max}",
"Error occurred while retrieving comment with id {id}" : "Възникна грешка по време на извличане на коментар с код {id}",
"Error occurred while updating comment with id {id}" : "Възникна грешка по време на обновяване на коментар с код {id}",
"Error occurred while posting comment" : "Възникна грешка по време на изпращане на коментар",
"_%n unread comment_::_%n unread comments_" : ["%n непрочетен коментар","%n непрочетени коментари"],
@@ -25,6 +24,8 @@ OC.L10N.register(
"%1$s commented on %2$s" : "%1$s коментиран за %2$s",
"{author} commented on {file}" : "{author} коментира за {file}",
"<strong>Comments</strong> for files" : "<strong>Коментари</strong> за файлове",
"You were mentioned on “%s”, in a comment by a user that has since been deleted" : "Бяхте споменат/а на “%s”, в коментар от потребител, който вече е изтрит",
"You were mentioned on “{file}”, in a comment by a user that has since been deleted" : "Бяхте споменат/а към “{file}”, в коментар от потребител, който вече е изтрит",
"%1$s mentioned you in a comment on “%2$s”" : "%1$s те спомена в коментар за “%2$s”",
"{user} mentioned you in a comment on “{file}”" : "{user} те спомена в коментар за “{file}”",
"Unknown user" : "Непознат потребител",
+5 -4
View File
@@ -1,16 +1,15 @@
{ "translations": {
"Comments" : "Коментари",
"New comment …" : "Нов коментар...",
"Edit comment" : "Редактирай коментра",
"Delete comment" : "Изтрий коментар",
"New comment …" : "Нов коментар...",
"Post" : "Публикация",
"Cancel" : "Отказ",
"Edit comment" : "Редактирай коментра",
"[Deleted user]" : "[Изтрит потребител]",
"Comments" : "Коментари",
"No comments yet, start the conversation!" : "Все-още няма коментари, започни разговор!",
"More comments …" : "Още коментари...",
"Save" : "Запазване",
"Allowed characters {count} of {max}" : "Позволени символи {count} от {max}",
"Error occurred while retrieving comment with id {id}" : "Възникна грешка по време на извличане на коментар с код {id}",
"Error occurred while updating comment with id {id}" : "Възникна грешка по време на обновяване на коментар с код {id}",
"Error occurred while posting comment" : "Възникна грешка по време на изпращане на коментар",
"_%n unread comment_::_%n unread comments_" : ["%n непрочетен коментар","%n непрочетени коментари"],
@@ -23,6 +22,8 @@
"%1$s commented on %2$s" : "%1$s коментиран за %2$s",
"{author} commented on {file}" : "{author} коментира за {file}",
"<strong>Comments</strong> for files" : "<strong>Коментари</strong> за файлове",
"You were mentioned on “%s”, in a comment by a user that has since been deleted" : "Бяхте споменат/а на “%s”, в коментар от потребител, който вече е изтрит",
"You were mentioned on “{file}”, in a comment by a user that has since been deleted" : "Бяхте споменат/а към “{file}”, в коментар от потребител, който вече е изтрит",
"%1$s mentioned you in a comment on “%2$s”" : "%1$s те спомена в коментар за “%2$s”",
"{user} mentioned you in a comment on “{file}”" : "{user} те спомена в коментар за “{file}”",
"Unknown user" : "Непознат потребител",
+5 -4
View File
@@ -1,18 +1,17 @@
OC.L10N.register(
"comments",
{
"Comments" : "Comentaris",
"New comment …" : "Nou comentari...",
"Edit comment" : "Editar comentari",
"Delete comment" : "Esborrar comentari",
"New comment …" : "Nou comentari...",
"Post" : "Publica",
"Cancel" : "Cancel·la",
"Edit comment" : "Editar comentari",
"[Deleted user]" : "[usuari Esborrat]",
"Comments" : "Comentaris",
"No comments yet, start the conversation!" : "Encara no hi ha comentaris. Comenceu la conversa!",
"More comments …" : "Més comentaris...",
"Save" : "Desa",
"Allowed characters {count} of {max}" : "{count} caràcters permesos de {max}",
"Error occurred while retrieving comment with id {id}" : "Hi ha hagut un error en extraure el comentari amb id {id}",
"Error occurred while updating comment with id {id}" : "Hi ha hagut un error en actualitzar el comentari amb id {id}",
"Error occurred while posting comment" : "Hi ha hagut un error en publicar el comentari",
"_%n unread comment_::_%n unread comments_" : ["%n comentari no llegit","%n comentaris no llegits"],
@@ -25,6 +24,8 @@ OC.L10N.register(
"%1$s commented on %2$s" : "%1$s ha comentat a %2$s",
"{author} commented on {file}" : "{author} ha comentat a {file}",
"<strong>Comments</strong> for files" : "<strong>Comentaris</strong> per arxius",
"You were mentioned on “%s”, in a comment by a user that has since been deleted" : "Has estat mencionat a \"%s\" en un comentari d'un usuari que ja no existeix",
"You were mentioned on “{file}”, in a comment by a user that has since been deleted" : "Has estat mencionat a \"{file}\" en un comentari d'un usuari que ja no existeix",
"%1$s mentioned you in a comment on “%2$s”" : "%1$s us ha nomenat en un comentari a “%2$s”",
"{user} mentioned you in a comment on “{file}”" : "{user} us ha nomenat en un comentari de “{file}”",
"Unknown user" : "Usuari desconegut",
+5 -4
View File
@@ -1,16 +1,15 @@
{ "translations": {
"Comments" : "Comentaris",
"New comment …" : "Nou comentari...",
"Edit comment" : "Editar comentari",
"Delete comment" : "Esborrar comentari",
"New comment …" : "Nou comentari...",
"Post" : "Publica",
"Cancel" : "Cancel·la",
"Edit comment" : "Editar comentari",
"[Deleted user]" : "[usuari Esborrat]",
"Comments" : "Comentaris",
"No comments yet, start the conversation!" : "Encara no hi ha comentaris. Comenceu la conversa!",
"More comments …" : "Més comentaris...",
"Save" : "Desa",
"Allowed characters {count} of {max}" : "{count} caràcters permesos de {max}",
"Error occurred while retrieving comment with id {id}" : "Hi ha hagut un error en extraure el comentari amb id {id}",
"Error occurred while updating comment with id {id}" : "Hi ha hagut un error en actualitzar el comentari amb id {id}",
"Error occurred while posting comment" : "Hi ha hagut un error en publicar el comentari",
"_%n unread comment_::_%n unread comments_" : ["%n comentari no llegit","%n comentaris no llegits"],
@@ -23,6 +22,8 @@
"%1$s commented on %2$s" : "%1$s ha comentat a %2$s",
"{author} commented on {file}" : "{author} ha comentat a {file}",
"<strong>Comments</strong> for files" : "<strong>Comentaris</strong> per arxius",
"You were mentioned on “%s”, in a comment by a user that has since been deleted" : "Has estat mencionat a \"%s\" en un comentari d'un usuari que ja no existeix",
"You were mentioned on “{file}”, in a comment by a user that has since been deleted" : "Has estat mencionat a \"{file}\" en un comentari d'un usuari que ja no existeix",
"%1$s mentioned you in a comment on “%2$s”" : "%1$s us ha nomenat en un comentari a “%2$s”",
"{user} mentioned you in a comment on “{file}”" : "{user} us ha nomenat en un comentari de “{file}”",
"Unknown user" : "Usuari desconegut",
+17 -16
View File
@@ -1,36 +1,37 @@
OC.L10N.register(
"comments",
{
"Comments" : "Komentáře",
"New comment …" : "Nový komentář ...",
"Delete comment" : "Smazat komentář",
"Post" : "Zveřejnit",
"Cancel" : "Zrušit",
"Edit comment" : "Upravit komentář",
"Delete comment" : "Smazat komentář",
"New comment …" : "Nový komentář…",
"Post" : "Zveřejnit",
"Cancel" : "Storno",
"[Deleted user]" : "[Smazaný uživatel]",
"Comments" : "Komentáře",
"No comments yet, start the conversation!" : "Zatím bez komentářů, začněte konverzaci!",
"More comments …" : "Více komentářů ...",
"More comments …" : "Více komentářů",
"Save" : "Uložit",
"Allowed characters {count} of {max}" : "Povolených znaků {count} z {max}",
"Error occurred while retrieving comment with id {id}" : "Došlo k chybě při načítání komentáře s id {id}",
"Error occurred while retrieving comment with ID {id}" : "Došlo k chybě při načítání komentáře s ID {id}",
"Error occurred while updating comment with id {id}" : "Došlo k chybě při aktualizování komentáře s id {id}",
"Error occurred while posting comment" : "Došlo k chybě při zveřejňování komentáře",
"_%n unread comment_::_%n unread comments_" : ["%n nepřečtený komentář","%n nepřečtené komentáře","%n nepřečtených komentářů"],
"_%n unread comment_::_%n unread comments_" : ["%n nepřečtený komentář","%n nepřečtené komentáře","%n nepřečtených komentářů","%n nepřečtených komentářů"],
"Comment" : "Komentář",
"You commented" : "Okomentoval(a) jsi",
"You commented" : "Okomentovali jste",
"%1$s commented" : "%1$s okomentován",
"{author} commented" : "{author} okomentoval(a)",
"You commented on %1$s" : "Okomentoval(a) jste %1$s",
"You commented on {file}" : "Okomentoval(a) jste {file}",
"You commented on %1$s" : "Okomentovali jste %1$s",
"You commented on {file}" : "Okomentovali jste {file}",
"%1$s commented on %2$s" : "%1$s okomentoval %2$s",
"{author} commented on {file}" : "{author} okomentoval(a) {file}",
"<strong>Comments</strong> for files" : "<strong>Komentáře</strong> souborů",
"You were mentioned on “%s”, in a comment by a user that has since been deleted" : "Byli jste zmíněni v %s, v komentáři od uživatele, který byl později smazán",
"You were mentioned on “%s”, in a comment by a user that has since been deleted" : "Byli jste zmíněni v %s, v komentáři od uživatele, který byl později smazán",
"You were mentioned on “{file}”, in a comment by a user that has since been deleted" : "Byli jste zmíněni v souboru “{file}”, v komentáři od uživatele, který byl později smazán",
"%1$s mentioned you in a comment on “%2$s”" : "%1$s vás zmínil(a) v komentáři u %2$s",
"{user} mentioned you in a comment on “{file}”" : "{user} vás zmínil v komentáři u {file}",
"{user} mentioned you in a comment on “{file}”" : "{user} vás zmínil(a) v komentáři u {file}",
"Files app plugin to add comments to files" : "Zásuvný modul do aplikace Soubory pro přidávání komentářů k souborům",
"Unknown user" : "Neznámý uživatel",
"A (now) deleted user mentioned you in a comment on “%s”" : "A (now) deleted user mentioned you in a comment on “%s”",
"A (now) deleted user mentioned you in a comment on “{file}”" : "Nyní již smazaný uživatel vás zmínil v komentáři u \"{file}\""
"A (now) deleted user mentioned you in a comment on “%s”" : "(Nyní) už smazaný uživatel vás zmínil v komentáři na „%s“.",
"A (now) deleted user mentioned you in a comment on “{file}”" : "Nyní už smazaný uživatel vás zmínil v komentáři u {file}"
},
"nplurals=3; plural=(n==1) ? 0 : (n>=2 && n<=4) ? 1 : 2;");
"nplurals=4; plural=(n == 1 && n % 1 == 0) ? 0 : (n >= 2 && n <= 4 && n % 1 == 0) ? 1: (n % 1 != 0 ) ? 2 : 3;");

Some files were not shown because too many files have changed in this diff Show More