refactor: use strict operator

.github/CODEOWNERS

@@ -24,7 +24,7 @@ package.json                                  @nextcloud/server-dependabot @next
 package-lock.json                             @nextcloud/server-dependabot
 
 # App maintainers
-/apps/admin_audit/appinfo/info.xml            @luka-nextcloud @samin-z
+/apps/admin_audit/appinfo/info.xml            @luka-nextcloud @blizzz
 /apps/cloud_federation_api/appinfo/info.xml   @nfebe @mejo-
 /apps/comments/appinfo/info.xml               @edward-ly @sorbaugh
 /apps/contactsinteraction/appinfo/info.xml    @kesselb @SebastianKrupinski
@@ -46,16 +46,16 @@ package-lock.json                             @nextcloud/server-dependabot
 /apps/files_versions/appinfo/info.xml         @artonge @icewind1991
 /apps/oauth2/appinfo/info.xml                 @julien-nc @ChristophWurst
 /apps/provisioning_api/appinfo/info.xml       @provokateurin @nickvergessen
-/apps/settings/appinfo/info.xml               @hweihwang @sorbaugh
+/apps/settings/appinfo/info.xml               @JuliaKirschenheuter @sorbaugh
 /apps/sharebymail/appinfo/info.xml            @Altahrim @skjnldsv
 /apps/systemtags/appinfo/info.xml             @Antreesy @marcelklehr
 /apps/theming/appinfo/info.xml                @skjnldsv @juliusknorr
 /apps/twofactor_backupcodes/appinfo/info.xml  @miaulalala @ChristophWurst
-/apps/updatenotification/appinfo/info.xml     @enjeck @sorbaugh
+/apps/updatenotification/appinfo/info.xml     @JuliaKirschenheuter @sorbaugh
 /apps/user_ldap/appinfo/info.xml              @come-nc @blizzz
 /apps/user_status/appinfo/info.xml            @Antreesy @nickvergessen
 /apps/weather_status/appinfo/info.xml         @julien-nc @juliusknorr
-/apps/webhook_listeners/appinfo/info.xml      @janepie @julien-nc
+/apps/webhook_listeners/appinfo/info.xml      @come-nc @julien-nc
 /apps/workflowengine/appinfo/info.xml         @blizzz @juliusknorr
 
 # Files frontend expertise

.github/ISSUE_TEMPLATE/BUG_REPORT.yml

@@ -73,7 +73,7 @@ body:
       options:
         - "32"
         - "33"
-        - "34 (master)"
+        - "master"
     validations:
       required: true
   - type: dropdown

.github/dependabot.yml

@@ -165,3 +165,46 @@ updates:
     # no major updates on stable branches
     - dependency-name: "*"
       update-types: ["version-update:semver-major"]
+
+# Composer dependencies for linting and testing
+- package-ecosystem: composer
+  target-branch: stable31
+  directories:
+    - "/"
+    - "/build/integration"
+    - "/vendor-bin/cs-fixer"
+    - "/vendor-bin/openapi-extractor"
+    - "/vendor-bin/phpunit"
+    - "/vendor-bin/psalm"
+  schedule:
+    interval: weekly
+    day: saturday
+    time: "04:00"
+    timezone: Europe/Paris
+  labels:
+    - "3. to review"
+    - "feature: dependencies"
+  ignore:
+    # only patch updates on stable branches
+    - dependency-name: "*"
+      update-types: ["version-update:semver-major", "version-update:semver-minor"]
+
+# frontend dependencies
+- package-ecosystem: npm
+  target-branch: stable31
+  directory: "/"
+  schedule:
+    interval: weekly
+    day: saturday
+    time: "04:00"
+    timezone: Europe/Paris
+  open-pull-requests-limit: 20
+  labels:
+    - "3. to review"
+    - "feature: dependencies"
+  # Disable automatic rebasing because without a build CI will likely fail anyway
+  rebase-strategy: "disabled"
+  ignore:
+    # no major updates on stable branches
+    - dependency-name: "*"
+      update-types: ["version-update:semver-major"]

.github/pull_request_template.md

@@ -23,7 +23,3 @@
 - [ ] [Backports requested](https://github.com/nextcloud/backportbot/#usage) where applicable (ex: critical bugfixes)
 - [ ] [Labels added](https://github.com/nextcloud/server/labels) where applicable (ex: bug/enhancement, `3. to review`, feature component)
 - [ ] [Milestone added](https://github.com/nextcloud/server/milestones) for target branch/version (ex: 32.x for `stable32`)
-
-## AI (if applicable)
-
-- [ ] The content of this PR was partly or fully generated using AI

.github/workflows/autocheckers.yml

@@ -20,7 +20,7 @@ jobs:
       src: ${{ steps.changes.outputs.src }}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -52,13 +52,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -74,9 +74,6 @@ jobs:
   autocheckers:
     runs-on: ubuntu-latest-low
 
-    needs: changes
-    if: needs.changes.outputs.src != 'false'
-
     strategy:
       matrix:
         php-versions: ['8.2']
@@ -85,13 +82,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -128,4 +125,4 @@ jobs:
 
     steps:
       - name: Summary status
-        run: if ${{ needs.changes.outputs.src != 'false' && (needs.autocheckers.result != 'success' || needs.autoloader.result != 'success') }}; then exit 1; fi
+        run: if ${{ needs.autocheckers.result != 'success' || (needs.changes.outputs.src != 'false' && needs.autoloader.result != 'success') }}; then exit 1; fi

.github/workflows/block-outdated-3rdparty.yml

@@ -21,7 +21,7 @@ jobs:
 
     steps:
       - name: Check requirement
-        uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+        uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -31,7 +31,7 @@ jobs:
               - 'version.php'
 
       - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
 

.github/workflows/block-unconventional-commits.yml

@@ -27,7 +27,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
 

.github/workflows/bug-report-labeler.yml

@@ -1,45 +0,0 @@
-# SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
-# SPDX-License-Identifier: AGPL-3.0-or-later
-
-name: Auto-label bug reports
-on:
-  issues:
-    types: [opened]
-
-jobs:
-  add-version-label:
-    if: contains(github.event.issue.title, '[Bug]')
-    runs-on: ubuntu-latest
-    permissions:
-      issues: write
-    steps:
-      - name: Extract version number and apply label
-        uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
-        with:
-          script: |
-            const body = context.payload.issue.body || '';
-            const normalizedBody = body.replace(/\r\n?/g, '\n');
-            let label = '';
-
-            // Extract Nextcloud Server version number from a block like:
-            // ### Nextcloud Server version
-            // 32
-            const versionMatch = normalizedBody.match(/### Nextcloud Server version\s*\n+([0-9]{1,3})\b/);
-            let nextcloudVersion = null;
-            if (versionMatch) {
-              nextcloudVersion = parseInt(versionMatch[1], 10);
-              label = nextcloudVersion + '-feedback';
-            }
-            
-            if (label) {
-              try {
-                await github.rest.issues.addLabels({
-                  issue_number: context.issue.number,
-                  owner: context.repo.owner,
-                  repo: context.repo.repo,
-                  labels: [label]
-                });
-              } catch (error) {
-                core.setFailed(`Failed to add label "${label}": ${error.message || error}`);
-              }
-            }

.github/workflows/codeql.yml

@@ -32,18 +32,18 @@ jobs:
           build-mode: none
     steps:
     - name: Checkout repository
-      uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+      uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
       with:
         persist-credentials: false
 
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@c10b8064de6f491fea524254123dbe5e09572f13 # v4.35.1
+      uses: github/codeql-action/init@cdefb33c0f6224e58673d9004f47f7cb3e328b89 # v4.31.10
       with:
         languages: ${{ matrix.language }}
         build-mode: ${{ matrix.build-mode }}
         config-file: ./.github/codeql-config.yml
 
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@c10b8064de6f491fea524254123dbe5e09572f13 # v4.35.1
+      uses: github/codeql-action/analyze@cdefb33c0f6224e58673d9004f47f7cb3e328b89 # v4.31.10
       with:
         category: "/language:${{matrix.language}}"

.github/workflows/command-compile.yml

@@ -103,7 +103,7 @@ jobs:
           key: git-repo
 
       - name: Checkout ${{ needs.init.outputs.head_ref }}
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           # Needed to allow force push later
           persist-credentials: true
@@ -124,7 +124,7 @@ jobs:
           fallbackNpm: '^11.3'
 
       - name: Set up node ${{ steps.package-engines-versions.outputs.nodeVersion }}
-        uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
         with:
           node-version: ${{ steps.package-engines-versions.outputs.nodeVersion }}
           cache: npm

.github/workflows/command-pull-3rdparty.yml

@@ -14,7 +14,6 @@ jobs:
     runs-on: ubuntu-latest
     permissions:
       contents: none
-      pull-requests: read
 
     # On pull requests and if the comment starts with `/update-3rdparty`
     if: github.event.issue.pull_request != '' && startsWith(github.event.comment.body, '/update-3rdparty')
@@ -28,25 +27,8 @@ jobs:
           comment-id: ${{ github.event.comment.id }}
           reactions: '+1'
 
-      # issue_comment events carry no pull_request context in their payload, so we
-      # must fetch the PR via the API. This also gives us base.ref for free, avoiding
-      # a second API call. The GITHUB_TOKEN needs pull-requests:read (granted above).
-      - name: Get pull request metadata
-        uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
-        id: get-pr
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          script: |
-            const pull = await github.rest.pulls.get({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              pull_number: context.issue.number,
-            });
-            core.setOutput('head_repo', pull.data.head.repo?.full_name ?? '');
-            core.setOutput('base_ref',  pull.data.base.ref);
-
       - name: Disabled on forks
-        if: steps.get-pr.outputs.head_repo != github.repository
+        if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
         run: |
           echo 'Can not execute /update-3rdparty on forks'
           exit 1
@@ -56,7 +38,7 @@ jobs:
         id: comment-branch
 
       - name: Checkout ${{ steps.comment-branch.outputs.head_ref }}
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           fetch-depth: 0
@@ -64,17 +46,24 @@ jobs:
           ref: ${{ steps.comment-branch.outputs.head_ref }}
 
       - name: Register server reference to fallback to master branch
-        run: |
-          base_ref="${{ steps.get-pr.outputs.base_ref }}"
-          if [[ "$base_ref" == "main" || "$base_ref" == "master" ]]; then
-            echo "server_ref=master" >> "$GITHUB_ENV"
-            echo "Setting server_ref to master"
-          elif [[ "$base_ref" =~ ^stable[0-9]+$ ]]; then
-            echo "server_ref=$base_ref" >> "$GITHUB_ENV"
-            echo "Setting server_ref to $base_ref"
-          else
-            echo "Not based on master/main/stable*, so skipping pull 3rdparty command"
-          fi
+        uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
+        with:
+          github-token: ${{secrets.GITHUB_TOKEN}}
+          script: |
+            const baseRef = context.payload.pull_request.base.ref
+            if (baseRef === 'main' || baseRef === 'master') {
+              core.exportVariable('server_ref', 'master');
+              console.log('Setting server_ref to master');
+            } else {
+              const regex = /^stable(\d+)$/
+              const match = baseRef.match(regex)
+              if (match) {
+                core.exportVariable('server_ref', match[0]);
+                console.log('Setting server_ref to ' + match[0]);
+              } else {
+                console.log('Not based on master/main/stable*, so skipping pull 3rdparty command');
+              }
+            }
 
       - name: Setup git
         run: |

.github/workflows/cypress.yml

@@ -41,8 +41,14 @@ jobs:
       PUPPETEER_SKIP_DOWNLOAD: true
 
     steps:
+      - name: Disabled on forks
+        if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
+        run: |
+          echo 'Can not run cypress on forks'
+          exit 1
+
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           # We need to checkout submodules for 3rdparty
@@ -66,7 +72,7 @@ jobs:
           fallbackNpm: '^11.3'
 
       - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
-        uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
         with:
           node-version: ${{ steps.versions.outputs.nodeVersion }}
 
@@ -154,7 +160,7 @@ jobs:
           path: ./
 
       - name: Set up node ${{ needs.init.outputs.nodeVersion }}
-        uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
         with:
           node-version: ${{ needs.init.outputs.nodeVersion }}
 
@@ -165,11 +171,15 @@ jobs:
         run: ./node_modules/cypress/bin/cypress install
 
       - name: Run ${{ matrix.containers == 'component' && 'component' || 'E2E' }} cypress tests
-        uses: cypress-io/github-action@783cb3f07983868532cabaedaa1e6c00ff4786a8 # v7.1.9
+        uses: cypress-io/github-action@dca986193e4336cb32820819b07e9ecacacaaaf6 # v7.0.0
         with:
           # We already installed the dependencies in the init job
           install: false
           component: ${{ matrix.containers == 'component' }}
+          group: ${{ matrix.use-cypress-cloud && matrix.containers == 'component' && 'Run component' || matrix.use-cypress-cloud && 'Run E2E' || '' }}
+          # cypress env
+          ci-build-id: ${{ matrix.use-cypress-cloud && format('{0}-{1}', github.sha, github.run_number) || '' }}
+          tag: ${{ matrix.use-cypress-cloud && github.event_name || '' }}
         env:
           # Needs to be prefixed with CYPRESS_
           CYPRESS_BRANCH: ${{ env.BRANCH }}
@@ -178,13 +188,14 @@ jobs:
           # Needed for some specific code workarounds
           TESTING: true
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
           SPLIT: ${{ matrix.total-containers }}
           SPLIT_INDEX: ${{ matrix.containers == 'component' && 0 || matrix.containers }}
           SPLIT_RANDOM_SEED: ${{ github.run_id }}
           SETUP_TESTING: ${{ matrix.containers == 'setup' && 'true' || '' }}
 
       - name: Upload snapshots and videos
-        uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
+        uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
         if: always()
         with:
           name: snapshots_${{ matrix.containers }}
@@ -207,7 +218,7 @@ jobs:
         run: docker exec nextcloud-e2e-test-server_${{ env.APP_NAME }} tar -cvjf - data > data.tar
 
       - name: Upload data archive
-        uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
+        uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
         if: failure() && matrix.containers != 'component'
         with:
           name: nc_data_${{ matrix.containers }}

.github/workflows/files-external-ftp.yml

@@ -21,7 +21,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -65,7 +65,7 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
@@ -81,7 +81,7 @@ jobs:
           if [[ "${{ matrix.ftpd }}" == 'pure-ftpd' ]]; then docker run --name ftp -d --net host -e "PUBLICHOST=localhost" -e FTP_USER_NAME=test -e FTP_USER_PASS=test -e FTP_USER_HOME=/home/test -v /tmp/ftp:/home/test -v /tmp/ftp:/etc/pure-ftpd/passwd stilliard/pure-ftpd; fi
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -115,7 +115,7 @@ jobs:
 
       - name: Upload code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.xml
           flags: phpunit-files-external-ftp

.github/workflows/files-external-s3.yml

@@ -21,7 +21,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -74,13 +74,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -115,7 +115,7 @@ jobs:
 
       - name: Upload code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.xml
           flags: phpunit-files-external-s3
@@ -163,13 +163,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -197,7 +197,7 @@ jobs:
 
       - name: Upload code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.xml
           flags: phpunit-files-external-s3

.github/workflows/files-external-sftp.yml

@@ -21,7 +21,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -65,7 +65,7 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
@@ -73,11 +73,11 @@ jobs:
       - name: Set up sftpd
         run: |
           sudo mkdir /tmp/sftp
-          sudo chmod -R 0777 /tmp/sftp
+          sudo chown -R 0777 /tmp/sftp
           if [[ '${{ matrix.sftpd }}' == 'openssh' ]]; then docker run -p 2222:22 --name sftp -d -v /tmp/sftp:/home/test atmoz/sftp 'test:test:::data'; fi
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -104,7 +104,7 @@ jobs:
 
       - name: Upload code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.xml
           flags: phpunit-files-external-sftp

.github/workflows/files-external-smb-kerberos.yml

@@ -21,7 +21,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -56,13 +56,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Checkout user_saml
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           repository: nextcloud/user_saml

.github/workflows/files-external-smb.yml

@@ -21,7 +21,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -75,13 +75,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -116,7 +116,7 @@ jobs:
 
       - name: Upload code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.xml
           flags: phpunit-files-external-smb

.github/workflows/files-external-webdav.yml

@@ -21,7 +21,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -70,13 +70,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -108,7 +108,7 @@ jobs:
 
       - name: Upload code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.xml
           flags: phpunit-files-external-webdav

.github/workflows/files-external.yml

@@ -21,7 +21,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -64,13 +64,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -97,7 +97,7 @@ jobs:
 
       - name: Upload code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.xml
           flags: phpunit-files-external-generic

.github/workflows/generate-release-changelog.yml

@@ -24,14 +24,14 @@ jobs:
           require: write
 
       - name: Checkout github_helper
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           repository: nextcloud/github_helper
           path: github_helper
 
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           path: server
@@ -73,7 +73,7 @@ jobs:
          fi
 
       - name: Set up php 8.2
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
         timeout-minutes: 5
         with:
           php-version: 8.2

.github/workflows/integration-dav.yml

@@ -19,7 +19,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -52,69 +52,69 @@ jobs:
     name: ${{ matrix.service }} (${{ matrix.endpoint }} endpoint) php${{ matrix.php-versions }}
 
     steps:
-      - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
-        with:
-          persist-credentials: false
-          submodules: true
+        - name: Checkout server
+          uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+          with:
+            persist-credentials: false
+            submodules: true
 
-      - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
-        timeout-minutes: 5
-        with:
-          php-version: ${{ matrix.php-versions }}
-          # https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
-          extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
-          coverage: 'none'
-          ini-file: development
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        - name: Set up php ${{ matrix.php-versions }}
+          uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
+          timeout-minutes: 5
+          with:
+            php-version: ${{ matrix.php-versions }}
+            # https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
+            extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
+            coverage: 'none'
+            ini-file: development
+          env:
+            GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Set up Python
-        uses: LizardByte/actions/actions/setup_python@0affa4f7bcb27562658960eee840eff8ff844578 # v2026.328.161128
-        with:
-          python-version: '2.7'
+        - name: Set up Python
+          uses: LizardByte/actions/actions/setup_python@e6bc045033a5614035b66daafc38ff86faecb23a # v2026.116.208
+          with:
+            python-version: '2.7'
 
-      - name: Set up CalDAVTester
-        run: |
-          git clone --depth=1 https://github.com/apple/ccs-caldavtester.git CalDAVTester
-          git clone --depth=1 https://github.com/apple/ccs-pycalendar.git pycalendar
+        - name: Set up CalDAVTester
+          run: |
+            git clone --depth=1 https://github.com/apple/ccs-caldavtester.git CalDAVTester
+            git clone --depth=1 https://github.com/apple/ccs-pycalendar.git pycalendar
 
-      - name: Set up Nextcloud
-        run: |
-          mkdir data
-          ./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
-          # disable the trashbin, so recurrent deletion of the same object works
-          ./occ config:app:set dav calendarRetentionObligation --value=0
-          # Prepare users
-          OC_PASS=user01 ./occ user:add --password-from-env user01
-          OC_PASS=user02 ./occ user:add --password-from-env user02
-          # Prepare calendars
-          ./occ dav:create-calendar user01 calendar
-          ./occ dav:create-calendar user01 shared
-          ./occ dav:create-calendar user02 calendar
-          # Prepare address books
-          ./occ dav:create-addressbook user01 addressbook
-          ./occ dav:create-addressbook user02 addressbook
+        - name: Set up Nextcloud
+          run: |
+            mkdir data
+            ./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
+            # disable the trashbin, so recurrent deletion of the same object works
+            ./occ config:app:set dav calendarRetentionObligation --value=0
+            # Prepare users
+            OC_PASS=user01 ./occ user:add --password-from-env user01
+            OC_PASS=user02 ./occ user:add --password-from-env user02
+            # Prepare calendars
+            ./occ dav:create-calendar user01 calendar
+            ./occ dav:create-calendar user01 shared
+            ./occ dav:create-calendar user02 calendar
+            # Prepare address books
+            ./occ dav:create-addressbook user01 addressbook
+            ./occ dav:create-addressbook user02 addressbook
 
-      - name: Run Nextcloud
-        run: |
-          php -S localhost:8888 &
+        - name: Run Nextcloud
+          run: |
+            php -S localhost:8888 &
 
-      - name: Run CalDAVTester
-        run: |
-          cp "apps/dav/tests/testsuits/caldavtest/serverinfo-${{ matrix.endpoint }}${{ matrix.endpoint == 'old' && (matrix.service == 'CardDAV' && '-carddav' || '-caldav') || '' }}-endpoint.xml" "apps/dav/tests/testsuits/caldavtest/serverinfo.xml"
-          pushd CalDAVTester
-          PYTHONPATH="../pycalendar/src" python testcaldav.py --print-details-onfail --basedir "../apps/dav/tests/testsuits/caldavtest" -o cdt.txt \
-            "${{ matrix.service }}/current-user-principal.xml" \
-            "${{ matrix.service }}/sync-report.xml" \
-            ${{ matrix.endpoint == 'new' && format('{0}/sharing-{1}.xml', matrix.service, matrix.service == 'CalDAV' && 'calendars' || 'addressbooks') || ';' }}
-          popd
+        - name: Run CalDAVTester
+          run: |
+            cp "apps/dav/tests/testsuits/caldavtest/serverinfo-${{ matrix.endpoint }}${{ matrix.endpoint == 'old' && (matrix.service == 'CardDAV' && '-carddav' || '-caldav') || '' }}-endpoint.xml" "apps/dav/tests/testsuits/caldavtest/serverinfo.xml"
+            pushd CalDAVTester
+            PYTHONPATH="../pycalendar/src" python testcaldav.py --print-details-onfail --basedir "../apps/dav/tests/testsuits/caldavtest" -o cdt.txt \
+              "${{ matrix.service }}/current-user-principal.xml" \
+              "${{ matrix.service }}/sync-report.xml" \
+              ${{ matrix.endpoint == 'new' && format('{0}/sharing-{1}.xml', matrix.service, matrix.service == 'CalDAV' && 'calendars' || 'addressbooks') || ';' }}
+            popd
 
-      - name: Print Nextcloud logs
-        if: always()
-        run: |
-          cat data/nextcloud.log
+        - name: Print Nextcloud logs
+          if: always()
+          run: |
+            cat data/nextcloud.log
 
   caldav-integration-summary:
     permissions:

.github/workflows/integration-litmus.yml

@@ -19,7 +19,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -52,13 +52,13 @@ jobs:
 
     steps:
         - name: Checkout server
-          uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+          uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
           with:
             persist-credentials: false
             submodules: true
 
         - name: Set up php ${{ matrix.php-versions }}
-          uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+          uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
           timeout-minutes: 5
           with:
             php-version: ${{ matrix.php-versions }}

.github/workflows/integration-s3-primary.yml

@@ -19,7 +19,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -76,13 +76,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -95,6 +95,7 @@ jobs:
 
       - name: Wait for S3
         run: |
+          sleep 10
           curl -f -m 1 --retry-connrefused --retry 10 --retry-delay 10 http://localhost:9000/minio/health/ready
 
       - name: Set up Nextcloud

.github/workflows/integration-sqlite.yml

@@ -25,7 +25,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -97,14 +97,14 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Checkout Talk app
         if: ${{ matrix.test-suite == 'videoverification_features' }}
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           repository: nextcloud/spreed
@@ -113,7 +113,7 @@ jobs:
 
       - name: Checkout Activity app
         if: ${{ matrix.test-suite == 'sharing_features' }}
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           repository: nextcloud/activity
@@ -121,7 +121,7 @@ jobs:
           ref: ${{ matrix.activity-versions }}
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}

.github/workflows/lint-eslint.yml

@@ -28,7 +28,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -56,7 +56,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
 
@@ -68,7 +68,7 @@ jobs:
           fallbackNpm: '^11.3'
 
       - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
-        uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
         with:
           node-version: ${{ steps.versions.outputs.nodeVersion }}
 

.github/workflows/lint-php-cs.yml

@@ -25,7 +25,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -44,19 +44,16 @@ jobs:
   lint:
     runs-on: ubuntu-latest
 
-    needs: changes
-    if: needs.changes.outputs.src != 'false'
-
     name: php-cs
 
     steps:
       - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
 
       - name: Set up php
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
         timeout-minutes: 5
         with:
           php-version: 8.2

.github/workflows/lint-php.yml

@@ -23,7 +23,7 @@ jobs:
     outputs:
       src: ${{ steps.changes.outputs.src}}
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -53,12 +53,12 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}

.github/workflows/lint-stylelint.yml

@@ -18,42 +18,14 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  changes:
-    runs-on: ubuntu-latest-low
-    permissions:
-      contents: read
-      pull-requests: read
-
-    outputs:
-      src: ${{ steps.changes.outputs.src }}
-
-    steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
-        id: changes
-        continue-on-error: true
-        with:
-          filters: |
-            src:
-              - '.github/workflows/**'
-              - '**/src/**'
-              - '**/appinfo/info.xml'
-              - 'package.json'
-              - 'package-lock.json'
-              - '**.css'
-              - '**.scss'
-              - '**.vue'
-
   lint:
     runs-on: ubuntu-latest
 
-    needs: changes
-    if: needs.changes.outputs.src != 'false'
-
     name: stylelint
 
     steps:
       - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
 
@@ -65,7 +37,7 @@ jobs:
           fallbackNpm: '^11.3'
 
       - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
-        uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
         with:
           node-version: ${{ steps.versions.outputs.nodeVersion }}
 
@@ -79,18 +51,3 @@ jobs:
 
       - name: Lint
         run: npm run stylelint
-
-  summary:
-    permissions:
-      contents: none
-    runs-on: ubuntu-latest-low
-    needs: [changes, lint]
-
-    if: always()
-
-    # This is the summary, we just avoid to rename it so that branch protection rules still match
-    name: stylelint
-
-    steps:
-      - name: Summary status
-        run: if ${{ needs.changes.outputs.src != 'false' && needs.lint.result != 'success' }}; then exit 1; fi

.github/workflows/node-test-handlebars.yml

@@ -29,7 +29,7 @@ jobs:
       src: ${{ steps.changes.outputs.src }}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -59,7 +59,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
 
@@ -71,7 +71,7 @@ jobs:
           fallbackNpm: '^11.3'
 
       - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
-        uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
         with:
           node-version: ${{ steps.versions.outputs.nodeVersion }}
 

.github/workflows/node-test.yml

@@ -31,7 +31,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -58,7 +58,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
 
@@ -70,7 +70,7 @@ jobs:
           fallbackNpm: '^11.3'
 
       - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
-        uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
         with:
           node-version: ${{ steps.versions.outputs.nodeVersion }}
 
@@ -83,11 +83,14 @@ jobs:
         run: |
           npm ci
 
+#      - name: Test
+#        run: npm run test --if-present
+
       - name: Test and process coverage
         run: npm run test:coverage
 
       - name: Collect coverage
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./coverage/lcov.info,./coverage/legacy/lcov.info
 

.github/workflows/node.yml

@@ -28,7 +28,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -56,7 +56,7 @@ jobs:
     name: NPM build
     steps:
       - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
 
@@ -68,7 +68,7 @@ jobs:
           fallbackNpm: '^11.3'
 
       - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
-        uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
         with:
           node-version: ${{ steps.versions.outputs.nodeVersion }}
 

.github/workflows/npm-audit-fix.yml

@@ -35,7 +35,7 @@ jobs:
     steps:
       - name: Checkout
         id: checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           ref: ${{ matrix.branches }}
@@ -49,7 +49,7 @@ jobs:
           fallbackNpm: '^11.3'
 
       - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
-        uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
         with:
           node-version: ${{ steps.versions.outputs.nodeVersion }}
 

.github/workflows/object-storage-azure.yml

@@ -21,7 +21,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -79,13 +79,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -117,7 +117,7 @@ jobs:
 
       - name: Upload code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.xml
           flags: phpunit-azure

.github/workflows/object-storage-s3.yml

@@ -21,7 +21,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -80,13 +80,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -111,6 +111,7 @@ jobs:
 
       - name: Wait for S3
         run: |
+          sleep 10
           curl -f -m 1 --retry-connrefused --retry 10 --retry-delay 10 http://localhost:9000/minio/health/ready
 
       - name: PHPUnit
@@ -122,7 +123,7 @@ jobs:
 
       - name: Upload code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.xml
           flags: phpunit-s3

.github/workflows/object-storage-swift.yml

@@ -21,7 +21,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -77,13 +77,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -113,7 +113,7 @@ jobs:
 
       - name: Upload code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.xml
           flags: phpunit-swift

.github/workflows/openapi.yml

@@ -26,12 +26,12 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
 
       - name: Set up php
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
         timeout-minutes: 5
         with:
           php-version: '8.2'

.github/workflows/performance.yml

@@ -15,13 +15,7 @@ jobs:
   performance-testing:
     runs-on: ubuntu-latest
 
-    # Skip entirely on fork PRs so the job result is 'skipped' rather than
-    # 'failure'. The profiler action uses github.event.pull_request.head.repo.clone_url
-    # and GITHUB_TOKEN in ways that do not work reliably from forks, and a
-    # clean skip is far less confusing for contributors than a mid-run error.
-    if: >-
-      github.repository_owner != 'nextcloud-gmbh' &&
-      github.event.pull_request.head.repo.full_name == github.repository
+    if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
 
     permissions:
       pull-requests: write
@@ -34,16 +28,21 @@ jobs:
     name: performance-${{ matrix.php-versions }}
 
     steps:
+      - name: Disabled on forks
+        if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
+        run: |
+          echo 'Can not run performance tests on forks'
+          exit 1
 
       - name: Checkout server before PR
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
           ref: ${{ github.event.pull_request.base.ref }}
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -64,7 +63,7 @@ jobs:
           ref: ${{ github.event.pull_request.head.ref }}
 
       - name: Run before measurements
-        uses: nextcloud/profiler@6a74c915048285b35b8e1cd96c0835a635945044
+        uses: nextcloud/profiler@6801ee10fc80f10b444388fb6ca9b36ad8a2ea83
         with:
           run: |
             curl -s -X PROPFIND -u test:test http://localhost:8080/remote.php/dav/files/test
@@ -86,7 +85,7 @@ jobs:
 
       - name: Run after measurements
         id: compare
-        uses: nextcloud/profiler@6a74c915048285b35b8e1cd96c0835a635945044
+        uses: nextcloud/profiler@6801ee10fc80f10b444388fb6ca9b36ad8a2ea83
         with:
           run: |
             curl -s -X PROPFIND -u test:test http://localhost:8080/remote.php/dav/files/test
@@ -100,7 +99,7 @@ jobs:
 
       - name: Upload profiles
         if: always()
-        uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f
+        uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f
         with:
           name: profiles
           path: |

.github/workflows/phpunit-32bits.yml

@@ -9,7 +9,6 @@ on:
       - ".github/workflows/phpunit-32bits.yml"
       - "tests/phpunit-autotest.xml"
       - "lib/private/Snowflake/*"
-      - "tests/lib/Preview/PreviewMapperTest.php"
   workflow_dispatch:
   schedule:
     - cron: "15 1 * * 1-6"
@@ -34,7 +33,7 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
@@ -57,4 +56,4 @@ jobs:
       - name: PHPUnit
         uses: docker://ghcr.io/nextcloud/continuous-integration-php8.4-32bit:latest
         with:
-          args: /bin/sh -c "composer run test -- --exclude-group PRIMARY-azure --exclude-group PRIMARY-s3 --exclude-group PRIMARY-swift --exclude-group Memcached --exclude-group Redis --exclude-group RoutingWeirdness"
+          args: /bin/sh -c "composer run test -- --exclude-group PRIMARY-azure,PRIMARY-s3,PRIMARY-swift,Memcached,Redis,RoutingWeirdness"

.github/workflows/phpunit-mariadb.yml

@@ -31,7 +31,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -92,13 +92,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -132,7 +132,7 @@ jobs:
 
       - name: Upload db code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.db.xml
           flags: phpunit-mariadb

.github/workflows/phpunit-memcached.yml

@@ -28,7 +28,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -72,13 +72,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -104,7 +104,7 @@ jobs:
 
       - name: Upload code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.xml
           flags: phpunit-memcached

.github/workflows/phpunit-mysql-sharding.yml

@@ -28,7 +28,7 @@ jobs:
       src: ${{ steps.changes.outputs.src }}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -121,13 +121,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -162,7 +162,7 @@ jobs:
 
       - name: Upload db code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.db.xml
           flags: phpunit-mysql

.github/workflows/phpunit-mysql.yml

@@ -31,7 +31,7 @@ jobs:
       src: ${{ steps.changes.outputs.src }}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -92,13 +92,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -132,7 +132,7 @@ jobs:
 
       - name: Upload db code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.db.xml
           flags: phpunit-mysql

.github/workflows/phpunit-nodb.yml

@@ -30,7 +30,7 @@ jobs:
       src: ${{ steps.changes.outputs.src }}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -75,13 +75,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -110,7 +110,7 @@ jobs:
 
       - name: Upload nodb code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.nodb.xml
           flags: phpunit-nodb

.github/workflows/phpunit-object-store-primary.yml

@@ -21,7 +21,7 @@ jobs:
       src: ${{ steps.changes.outputs.src}}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -72,13 +72,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -104,7 +104,7 @@ jobs:
           curl -f -m 1 --retry-connrefused --retry 10 --retry-delay 10 http://localhost:9000/minio/health/ready
 
       - name: PHPUnit
-        run: composer run test:db -- --log-junit junit.xml
+        run: composer run test:db
 
       - name: S3 logs
         if: always()

.github/workflows/phpunit-oci.yml

@@ -31,7 +31,7 @@ jobs:
       src: ${{ steps.changes.outputs.src }}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -99,13 +99,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -132,7 +132,7 @@ jobs:
 
       - name: Upload db code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.db.xml
           flags: phpunit-oci

.github/workflows/phpunit-pgsql.yml

@@ -31,7 +31,7 @@ jobs:
       src: ${{ steps.changes.outputs.src }}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -92,13 +92,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -127,7 +127,7 @@ jobs:
 
       - name: Upload db code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.db.xml
           flags: phpunit-postgres

.github/workflows/phpunit-sqlite.yml

@@ -31,7 +31,7 @@ jobs:
       src: ${{ steps.changes.outputs.src }}
 
     steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         continue-on-error: true
         with:
@@ -75,13 +75,13 @@ jobs:
 
     steps:
       - name: Checkout server
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
         timeout-minutes: 5
         with:
           php-version: ${{ matrix.php-versions }}
@@ -114,7 +114,7 @@ jobs:
 
       - name: Upload db code coverage
         if: ${{ !cancelled() && matrix.coverage }}
-        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
         with:
           files: ./clover.db.xml
           flags: phpunit-sqlite

.github/workflows/rector-apply.yml

@@ -1,70 +0,0 @@
-# This workflow is provided via the organization template repository
-#
-# https://github.com/nextcloud/.github
-# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
-#
-# SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
-# SPDX-License-Identifier: MIT
-
-name: Apply rector changes
-
-on:
-  workflow_dispatch:
-  schedule:
-    # At 14:30 on Sundays
-    - cron: '30 14 * * 0'
-
-permissions:
-  contents: read
-
-jobs:
-  build:
-    runs-on: ubuntu-latest
-
-    strategy:
-      fail-fast: false
-      matrix:
-        php-versions: [ '8.2' ]
-
-    name: rector-apply
-
-    steps:
-      - name: Checkout
-        id: checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
-        with:
-          persist-credentials: false
-          ref: ${{ github.event.repository.default_branch }}
-
-      - name: Set up php${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2.37.0
-        with:
-          php-version: ${{ matrix.php-versions }}
-          extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
-          coverage: none
-          ini-file: development
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: Install dependencies
-        run: |
-          composer remove nextcloud/ocp --dev --no-scripts
-          composer i
-          git restore lib/composer/composer
-
-      - name: Rector
-        run: composer run rector
-
-      - name: Create Pull Request
-        uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0 # v8.1.0
-        with:
-          token: ${{ secrets.COMMAND_BOT_PAT }}
-          commit-message: 'refactor: Apply rector changes'
-          committer: GitHub <noreply@github.com>
-          author: nextcloud-command <nextcloud-command@users.noreply.github.com>
-          signoff: true
-          branch: automated/noid/rector-changes
-          title: 'Apply rector changes'
-          labels: |
-            technical debt
-            3. to review

.github/workflows/rector.yml

@@ -13,44 +13,20 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  changes:
-    runs-on: ubuntu-latest-low
-
-    outputs:
-      src: ${{ steps.changes.outputs.src}}
-
-    steps:
-      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
-        id: changes
-        continue-on-error: true
-        with:
-          filters: |
-            src:
-              - '.github/workflows/**'
-              - '3rdparty/**'
-              - '**/lib/**'
-              - '**/tests/**'
-              - '**/vendor-bin/**'
-              - '.php-cs-fixer.dist.php'
-              - 'composer.json'
-              - 'composer.lock'
-              - '**.php'
-
   strict:
     runs-on: ubuntu-latest
 
-    needs: changes
-    if: ${{ needs.changes.outputs.src != 'false' && github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
+    if: ${{ github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
 
     steps:
       - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         with:
           php-version: '8.2'
           extensions: apcu,ctype,curl,dom,fileinfo,ftp,gd,imagick,intl,json,ldap,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
@@ -67,17 +43,3 @@ jobs:
       - name: Show changes
         if: always()
         run: git diff --exit-code -- . ':!lib/composer'
-
-  summary:
-    permissions:
-      contents: none
-    runs-on: ubuntu-latest-low
-    needs: [changes, strict]
-
-    if: always()
-
-    name: rector-summary
-
-    steps:
-      - name: Summary status
-        run: if ${{ needs.changes.outputs.src != 'false' && needs.strict.result != 'success' }}; then exit 1; fi

.github/workflows/reuse.yml

@@ -19,7 +19,7 @@ jobs:
     runs-on: ubuntu-latest-low
     steps:
       - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
 

.github/workflows/stale.yml

@@ -20,7 +20,7 @@ jobs:
       issues: write
 
     steps:
-    - uses: actions/stale@b5d41d4e1d5dceea10e7104786b73624c18a190f # v9
+    - uses: actions/stale@997185467fa4f803885201cee163a9f38240193d # v9
       with:
         repo-token: ${{ secrets.COMMAND_BOT_PAT }}
         stale-issue-message: >

.github/workflows/static-code-analysis.yml

@@ -21,45 +21,20 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  changes:
-    runs-on: ubuntu-latest-low
-
-    outputs:
-      src: ${{ steps.changes.outputs.src }}
-
-    steps:
-      - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
-        id: changes
-        continue-on-error: true
-        with:
-          filters: |
-            src:
-              - '.github/workflows/**'
-              - '3rdparty/**'
-              - '**/appinfo/**'
-              - '**/lib/**'
-              - '**/templates/**'
-              - 'vendor/**'
-              - 'vendor-bin/**'
-              - 'composer.json'
-              - 'composer.lock'
-              - '**.php'
-
   static-code-analysis:
     runs-on: ubuntu-latest
 
-    needs: changes
-    if: ${{ needs.changes.outputs.src != 'false' && github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
+    if: ${{ github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
 
     steps:
       - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: '8.2'
@@ -81,21 +56,20 @@ jobs:
   static-code-analysis-security:
     runs-on: ubuntu-latest
 
-    needs: changes
-    if: ${{ needs.changes.outputs.src != 'false' && github.repository_owner != 'nextcloud-gmbh' }}
+    if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
 
     permissions:
       security-events: write
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: '8.2'
@@ -114,25 +88,24 @@ jobs:
 
       - name: Upload Security Analysis results to GitHub
         if: always()
-        uses: github/codeql-action/upload-sarif@c10b8064de6f491fea524254123dbe5e09572f13 # v3
+        uses: github/codeql-action/upload-sarif@cdefb33c0f6224e58673d9004f47f7cb3e328b89 # v3
         with:
           sarif_file: results.sarif
 
   static-code-analysis-ocp:
     runs-on: ubuntu-latest
 
-    needs: changes
-    if: ${{ needs.changes.outputs.src != 'false' && github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
+    if: ${{ github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
 
     steps:
       - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: '8.2'
@@ -154,18 +127,17 @@ jobs:
   static-code-analysis-ncu:
     runs-on: ubuntu-latest
 
-    needs: changes
-    if: ${{ needs.changes.outputs.src != 'false' && github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
+    if: ${{ github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
 
     steps:
       - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
         timeout-minutes: 5
         with:
           php-version: '8.2'
@@ -183,18 +155,17 @@ jobs:
   static-code-analysis-strict:
     runs-on: ubuntu-latest
 
-    needs: changes
-    if: ${{ needs.changes.outputs.src != 'false' && github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
+    if: ${{ github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
 
     steps:
       - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
         with:
           persist-credentials: false
           submodules: true
 
       - name: Set up php
-        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f #v2.37.0
+        uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
         with:
           php-version: '8.2'
           extensions: ctype,curl,dom,fileinfo,gd,imagick,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
@@ -207,28 +178,3 @@ jobs:
 
       - name: Psalm
         run: composer run psalm:strict -- --threads=1 --monochrome --no-progress --output-format=github
-
-  summary:
-    permissions:
-      contents: none
-    runs-on: ubuntu-latest-low
-    needs: [changes, static-code-analysis, static-code-analysis-security, static-code-analysis-ocp, static-code-analysis-ncu, static-code-analysis-strict]
-
-    if: always()
-
-    name: static-code-analysis-summary
-
-    steps:
-      - name: Summary status
-        run: |
-          if ${{ needs.changes.outputs.src != 'false' && (
-            needs.static-code-analysis-security.result != 'success' ||
-            (github.event_name != 'push' && (
-              needs.static-code-analysis.result != 'success' ||
-              needs.static-code-analysis-ocp.result != 'success' ||
-              needs.static-code-analysis-ncu.result != 'success' ||
-              needs.static-code-analysis-strict.result != 'success'
-            ))
-          ) }}; then
-            exit 1
-          fi

.github/workflows/update-cacert-bundle.yml

@@ -22,7 +22,7 @@ jobs:
     name: update-ca-certificate-bundle-${{ matrix.branches }}
 
     steps:
-      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           ref: ${{ matrix.branches }}

.github/workflows/update-code-signing-crl.yml

@@ -22,7 +22,7 @@ jobs:
     name: update-code-signing-crl-${{ matrix.branches }}
 
     steps:
-      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           ref: ${{ matrix.branches }}

.github/workflows/update-min-supported-desktop.yml

@@ -16,7 +16,7 @@ jobs:
     runs-on: ubuntu-latest-low
 
     steps:
-      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           persist-credentials: false
           submodules: true
@@ -115,7 +115,7 @@ jobs:
           committer: GitHub <noreply@github.com>
           author: nextcloud-command <nextcloud-command@users.noreply.github.com>
           signoff: true
-          branch: "automated/noid/update-min-supported-desktop-version"
+          branch: "automated/noid/${{ matrix.branches }}-update-min-supported-desktop-version"
           title: "chore: Update minimum supported desktop version to ${{ steps.extract-version.outputs.VERSION }}"
           base: "master"
           body: |

.htaccess

@@ -129,10 +129,11 @@
 ## Rule: Map /remote* --> /remote.php* including the query string
 ##
 ## Context:
+##    - XXX: `QSA` seems unnecessary (no-op) here (query string is passed by default when the replacement URI doesn't contain a query string)
 ##    - XXX: Is this even used anymore? Seems a relic from <NC12
 ##
 
-    RewriteRule ^remote/(.*) remote.php [L]
+    RewriteRule ^remote/(.*) remote.php [QSA,L]
 
 ##
 ## Rule: Prevent access to non-public files
@@ -147,19 +148,21 @@
 ##    - Intentionally excludes URIs used for HTTPS certificate verifications
 ##        - RFC 8555 / ACME HTTP Challenges (acme-challenge) 
 ##        - File-based Validations (pki-validation)
+##    - XXX: `QSA` seems unnecessary (no-op) here (query string is passed by default when the replacement URI doesn't contain a query string)
 ##    - XXX: Sometimes we are using `/index.php` and other times `index.php` as our replacement URI; this may be incorrect
 ##
 
-    RewriteRule ^\.well-known/(?!acme-challenge|pki-validation) /index.php [L]
+    RewriteRule ^\.well-known/(?!acme-challenge|pki-validation) /index.php [QSA,L]
 
 ##
 ## Rule: Map the ocm-provider handling to our main frontend controller (/index.php)
 ##
 ## Context:
+##    - XXX: `QSA` seems unnecessary (no-op) here (query string is passed by default when the replacement URI doesn't contain a query string)
 ##    - XXX: Sometimes we are using `/index.php` and other times `index.php` as our replacement URI; this may be incorrect
 ##
 
-    RewriteRule ^ocm-provider/?$ index.php [L]
+    RewriteRule ^ocm-provider/?$ index.php [QSA,L]
 
 ##
 ## Rule: Prevent access to more non-public files

.nextcloudignore

@@ -4,7 +4,6 @@
 
 # Global exclude
 .editorconfig
-.envrc
 .git
 .git-blame-ignore-revs
 .gitattributes
@@ -12,44 +11,12 @@
 .gitignore
 .gitmodules
 .idea
-.jshint
-.jshintrc
 .l10nignore
-.mailmap
 .nextcloudignore
 .noopenapi
-.npmignore
-.php-cs-fixer*
-.pre-commit-config.yaml
-.tag
 .tx
-CHANGELOG.md
-CODE_OF_CONDUCT.md
-COPYING-README
-DESIGN.md
-Makefile
-README.md
-SECURITY.md
-codecov.yml
-cs-fixer
-csfixer
-custom.d.ts
 cypress
-cypress.config.ts
-eslint.config.js
-flake.lock
-flake.nix
-openapi-extractor
-phpunit
-psalm
-psalm*.xml
-rector
-stylelint.config.js
 tests
-tsconfig.json
-vite.config.ts
-vitest.config.ts
-window.d.ts
 
 # Server specific
 /.devcontainer
@@ -60,5 +27,3 @@ window.d.ts
 /config/config.php
 /contribute
 /data
-/openapi.json
-/vendor-bin

apps/admin_audit/l10n/bn_BD.js

@@ -1,7 +0,0 @@
-OC.L10N.register(
-    "admin_audit",
-    {
-    "Auditing / Logging" : "নিরীক্ষা",
-    "Provides logging abilities for Nextcloud such as logging file accesses or otherwise sensitive actions." : "নেক্সটক্লাউডের নিরীক্ষামূলক সক্ষমতা প্রদান করে যেমন লগিং ফাইল অ্যাক্সেস বা অন্য কোনো জরুরী পদক্ষেপসমূহ"
-},
-"nplurals=2; plural=(n != 1);");

apps/admin_audit/l10n/bn_BD.json

@@ -1,5 +0,0 @@
-{ "translations": {
-    "Auditing / Logging" : "নিরীক্ষা",
-    "Provides logging abilities for Nextcloud such as logging file accesses or otherwise sensitive actions." : "নেক্সটক্লাউডের নিরীক্ষামূলক সক্ষমতা প্রদান করে যেমন লগিং ফাইল অ্যাক্সেস বা অন্য কোনো জরুরী পদক্ষেপসমূহ"
-},"pluralForm" :"nplurals=2; plural=(n != 1);"
-}

apps/admin_audit/l10n/mn.js

@@ -1,7 +0,0 @@
-OC.L10N.register(
-    "admin_audit",
-    {
-    "Auditing / Logging" : "Аудит / Лог",
-    "Provides logging abilities for Nextcloud such as logging file accesses or otherwise sensitive actions." : "Nextcloud-д файл нэвтрэлт болон мэдрэмтгий үйлдлүүдийг бүртгэх зэрэг лог хөтлөх чадварыг олгодог."
-},
-"nplurals=2; plural=(n != 1);");

apps/admin_audit/l10n/mn.json

@@ -1,5 +0,0 @@
-{ "translations": {
-    "Auditing / Logging" : "Аудит / Лог",
-    "Provides logging abilities for Nextcloud such as logging file accesses or otherwise sensitive actions." : "Nextcloud-д файл нэвтрэлт болон мэдрэмтгий үйлдлүүдийг бүртгэх зэрэг лог хөтлөх чадварыг олгодог."
-},"pluralForm" :"nplurals=2; plural=(n != 1);"
-}

apps/admin_audit/lib/IAuditLogger.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later

apps/cloud_federation_api/l10n/mn.js

@@ -1,8 +0,0 @@
-OC.L10N.register(
-    "cloud_federation_api",
-    {
-    "Cloud Federation API" : "Cloud Federation API",
-    "Enable clouds to communicate with each other and exchange data" : "Үүлнүүдийг хоорондоо холбогдож өгөгдөл солилцох боломжтой болгох",
-    "The Cloud Federation API enables various Nextcloud instances to communicate with each other and to exchange data." : "Cloud Federation API нь янз бүрийн Nextcloud инстанцуудад хоорондоо харилцах болон өгөгдөл солилцох боломжийг олгодог."
-},
-"nplurals=2; plural=(n != 1);");

apps/cloud_federation_api/l10n/mn.json

@@ -1,6 +0,0 @@
-{ "translations": {
-    "Cloud Federation API" : "Cloud Federation API",
-    "Enable clouds to communicate with each other and exchange data" : "Үүлнүүдийг хоорондоо холбогдож өгөгдөл солилцох боломжтой болгох",
-    "The Cloud Federation API enables various Nextcloud instances to communicate with each other and to exchange data." : "Cloud Federation API нь янз бүрийн Nextcloud инстанцуудад хоорондоо харилцах болон өгөгдөл солилцох боломжийг олгодог."
-},"pluralForm" :"nplurals=2; plural=(n != 1);"
-}

apps/cloud_federation_api/l10n/uz.js

@@ -1,8 +1,8 @@
 OC.L10N.register(
     "cloud_federation_api",
     {
-    "Cloud Federation API" : "Jamg'armaning bulutli APIsi",
+    "Cloud Federation API" : "Asl faylni o'chirishda kutilmagan xatolik yuz berdi.",
     "Enable clouds to communicate with each other and exchange data" : "Bulutlar bir-biri bilan aloqa qilish va ma'lumot almashish imkonini beradi",
-    "The Cloud Federation API enables various Nextcloud instances to communicate with each other and to exchange data." : "Cloud Jamoada API turli xil Nextcloud misollariga bir-biri bilan muloqot qilish va ma'lumotlarni almashish imkonini beradi."
+    "The Cloud Federation API enables various Nextcloud instances to communicate with each other and to exchange data." : "Cloud Federation API turli xil Nextcloud misollariga bir-biri bilan muloqot qilish va ma'lumotlarni almashish imkonini beradi."
 },
 "nplurals=1; plural=0;");

apps/cloud_federation_api/l10n/uz.json

@@ -1,6 +1,6 @@
 { "translations": {
-    "Cloud Federation API" : "Jamg'armaning bulutli APIsi",
+    "Cloud Federation API" : "Asl faylni o'chirishda kutilmagan xatolik yuz berdi.",
     "Enable clouds to communicate with each other and exchange data" : "Bulutlar bir-biri bilan aloqa qilish va ma'lumot almashish imkonini beradi",
-    "The Cloud Federation API enables various Nextcloud instances to communicate with each other and to exchange data." : "Cloud Jamoada API turli xil Nextcloud misollariga bir-biri bilan muloqot qilish va ma'lumotlarni almashish imkonini beradi."
+    "The Cloud Federation API enables various Nextcloud instances to communicate with each other and to exchange data." : "Cloud Federation API turli xil Nextcloud misollariga bir-biri bilan muloqot qilish va ma'lumotlarni almashish imkonini beradi."
 },"pluralForm" :"nplurals=1; plural=0;"
 }

apps/comments/appinfo/routes.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * SPDX-FileCopyrightText: 2017-2024 Nextcloud GmbH and Nextcloud contributors
  * SPDX-FileCopyrightText: 2016 ownCloud, Inc.

apps/comments/l10n/de.js

@@ -32,6 +32,6 @@ OC.L10N.register(
     "Comment deleted" : "Kommentar gelöscht",
     "An error occurred while trying to delete the comment" : "Es ist ein Fehler beim Löschen des Kommentars aufgetreten",
     "An error occurred while trying to create the comment" : "Es ist ein Fehler beim Erstellen des Kommentars aufgetreten",
-    "Write a comment …" : "Einen Kommentar schreiben …"
+    "Write a comment …" : "Einen Kommentar schreiben …"
 },
 "nplurals=2; plural=(n != 1);");

apps/comments/l10n/de.json

@@ -30,6 +30,6 @@
     "Comment deleted" : "Kommentar gelöscht",
     "An error occurred while trying to delete the comment" : "Es ist ein Fehler beim Löschen des Kommentars aufgetreten",
     "An error occurred while trying to create the comment" : "Es ist ein Fehler beim Erstellen des Kommentars aufgetreten",
-    "Write a comment …" : "Einen Kommentar schreiben …"
+    "Write a comment …" : "Einen Kommentar schreiben …"
 },"pluralForm" :"nplurals=2; plural=(n != 1);"
 }

apps/comments/l10n/de_DE.js

@@ -32,6 +32,6 @@ OC.L10N.register(
     "Comment deleted" : "Kommentar gelöscht",
     "An error occurred while trying to delete the comment" : "Es ist ein Fehler beim Löschen des Kommentars aufgetreten",
     "An error occurred while trying to create the comment" : "Es ist ein Fehler beim Erstellen des Kommentars aufgetreten",
-    "Write a comment …" : "Einen Kommentar schreiben …"
+    "Write a comment …" : "Schreiben Sie einen Kommentar …"
 },
 "nplurals=2; plural=(n != 1);");

apps/comments/l10n/de_DE.json

@@ -30,6 +30,6 @@
     "Comment deleted" : "Kommentar gelöscht",
     "An error occurred while trying to delete the comment" : "Es ist ein Fehler beim Löschen des Kommentars aufgetreten",
     "An error occurred while trying to create the comment" : "Es ist ein Fehler beim Erstellen des Kommentars aufgetreten",
-    "Write a comment …" : "Einen Kommentar schreiben …"
+    "Write a comment …" : "Schreiben Sie einen Kommentar …"
 },"pluralForm" :"nplurals=2; plural=(n != 1);"
 }

apps/comments/l10n/ka.js

@@ -1,37 +1,32 @@
 OC.L10N.register(
     "comments",
     {
-    "Comments" : "კომენტარები",
-    "You commented" : "თქვენი კომენტარი",
-    "{author} commented" : "{author}-ის კომენტარი",
-    "You commented on %1$s" : "თქვენი კომენტარი %1$s-ზე",
-    "You commented on {file}" : "თქვენი კომენტარი {file}-ზე",
-    "%1$s commented on %2$s" : "%1$s-მა დატოვა კომენტარი %2$s-ზე",
-    "{author} commented on {file}" : "{author}-მა დატოვა კომენტარი {file}-ზე",
-    "<strong>Comments</strong> for files" : "<strong>კომენტარები</strong> ფაილებისთვის",
-    "Files" : "ფაილები",
-    "You were mentioned on \"{file}\", in a comment by an account that has since been deleted" : "თქვენ გახსენეს \"{file}\"-ის კომენტარში ანგარიშიდან, რომელიც მის შემდეგ წაიშალა",
-    "{user} mentioned you in a comment on \"{file}\"" : "{user}-მა გახსენათ კომენტარში ფაილზე \"{file}\"",
-    "Files app plugin to add comments to files" : "Files აპის დამატება ფაილებზე კომენტარების დასამატებლად",
-    "Edit comment" : "კომენტარის ჩასწორება",
-    "Delete comment" : "კომენტარის წაშლა",
-    "Cancel edit" : "ჩასწორების გაუქმება",
-    "New comment" : "ახალი კომენტარი",
-    "Write a comment …" : "კომენტარის დაწერა …",
-    "Post comment" : "კომენტარის დაპოსტვა",
-    "@ for mentions, : for emoji, / for smart picker" : "@ ხსენებისთვის, : ემოჯისთვის, / ჭკვიანი ამრჩევისთვის",
-    "Could not reload comments" : "კომენტარების თავიდან ჩატვირთვა შეუძლებელია",
-    "Failed to mark comments as read" : "კომენტარების წაკითხულად მონიშვნა ჩავარდა",
-    "Unable to load the comments list" : "კომენტარების სიის ჩატვირთვა ჩავარდა",
-    "No comments yet, start the conversation!" : "ჯერ კომენტარები არაა. დაიწყეთ საუბარი!",
-    "No more messages" : "მეტი შეტყობინება აღარაა",
-    "Retry" : "თავიდან ცდა",
-    "_1 new comment_::_{unread} new comments_" : ["1 ახალი კომენტარი","{unread} ახალი კომენტარი"],
-    "Comment" : "კომენტარი",
-    "An error occurred while trying to edit the comment" : "კომენტარის ჩასწორებისას აღმოჩენილია შეცდომა",
-    "Comment deleted" : "კომენტარი წაიშალა",
-    "An error occurred while trying to delete the comment" : "კომენტარის წაშლისას აღმოჩენილია შეცდომა",
-    "An error occurred while trying to create the comment" : "კომენტარის შექმნისას აღმოჩენილია შეცდომა",
-    "Write a comment …" : "კომენტარის დაწერა …"
+    "Comments" : "Comments",
+    "You commented" : "You commented",
+    "{author} commented" : "{author} commented",
+    "You commented on %1$s" : "You commented on %1$s",
+    "You commented on {file}" : "You commented on {file}",
+    "%1$s commented on %2$s" : "%1$s commented on %2$s",
+    "{author} commented on {file}" : "{author} commented on {file}",
+    "<strong>Comments</strong> for files" : "<strong>Comments</strong> for files",
+    "{user} mentioned you in a comment on \"{file}\"" : "{user} mentioned you in a comment on \"{file}\"",
+    "Files app plugin to add comments to files" : "Files app plugin to add comments to files",
+    "Edit comment" : "Edit comment",
+    "Delete comment" : "Delete comment",
+    "Cancel edit" : "Cancel edit",
+    "Post comment" : "Post comment",
+    "@ for mentions, : for emoji, / for smart picker" : "@ for mentions, : for emoji, / for smart picker",
+    "Could not reload comments" : "Could not reload comments",
+    "Failed to mark comments as read" : "Failed to mark comments as read",
+    "Unable to load the comments list" : "Unable to load the comments list",
+    "No comments yet, start the conversation!" : "No comments yet, start the conversation!",
+    "No more messages" : "No more messages",
+    "Retry" : "Retry",
+    "_1 new comment_::_{unread} new comments_" : ["1 new comment","{unread} new comments"],
+    "Comment" : "Comment",
+    "An error occurred while trying to edit the comment" : "An error occurred while trying to edit the comment",
+    "Comment deleted" : "Comment deleted",
+    "An error occurred while trying to delete the comment" : "An error occurred while trying to delete the comment",
+    "An error occurred while trying to create the comment" : "An error occurred while trying to create the comment"
 },
 "nplurals=2; plural=(n!=1);");

apps/comments/l10n/ka.json

@@ -1,35 +1,30 @@
 { "translations": {
-    "Comments" : "კომენტარები",
-    "You commented" : "თქვენი კომენტარი",
-    "{author} commented" : "{author}-ის კომენტარი",
-    "You commented on %1$s" : "თქვენი კომენტარი %1$s-ზე",
-    "You commented on {file}" : "თქვენი კომენტარი {file}-ზე",
-    "%1$s commented on %2$s" : "%1$s-მა დატოვა კომენტარი %2$s-ზე",
-    "{author} commented on {file}" : "{author}-მა დატოვა კომენტარი {file}-ზე",
-    "<strong>Comments</strong> for files" : "<strong>კომენტარები</strong> ფაილებისთვის",
-    "Files" : "ფაილები",
-    "You were mentioned on \"{file}\", in a comment by an account that has since been deleted" : "თქვენ გახსენეს \"{file}\"-ის კომენტარში ანგარიშიდან, რომელიც მის შემდეგ წაიშალა",
-    "{user} mentioned you in a comment on \"{file}\"" : "{user}-მა გახსენათ კომენტარში ფაილზე \"{file}\"",
-    "Files app plugin to add comments to files" : "Files აპის დამატება ფაილებზე კომენტარების დასამატებლად",
-    "Edit comment" : "კომენტარის ჩასწორება",
-    "Delete comment" : "კომენტარის წაშლა",
-    "Cancel edit" : "ჩასწორების გაუქმება",
-    "New comment" : "ახალი კომენტარი",
-    "Write a comment …" : "კომენტარის დაწერა …",
-    "Post comment" : "კომენტარის დაპოსტვა",
-    "@ for mentions, : for emoji, / for smart picker" : "@ ხსენებისთვის, : ემოჯისთვის, / ჭკვიანი ამრჩევისთვის",
-    "Could not reload comments" : "კომენტარების თავიდან ჩატვირთვა შეუძლებელია",
-    "Failed to mark comments as read" : "კომენტარების წაკითხულად მონიშვნა ჩავარდა",
-    "Unable to load the comments list" : "კომენტარების სიის ჩატვირთვა ჩავარდა",
-    "No comments yet, start the conversation!" : "ჯერ კომენტარები არაა. დაიწყეთ საუბარი!",
-    "No more messages" : "მეტი შეტყობინება აღარაა",
-    "Retry" : "თავიდან ცდა",
-    "_1 new comment_::_{unread} new comments_" : ["1 ახალი კომენტარი","{unread} ახალი კომენტარი"],
-    "Comment" : "კომენტარი",
-    "An error occurred while trying to edit the comment" : "კომენტარის ჩასწორებისას აღმოჩენილია შეცდომა",
-    "Comment deleted" : "კომენტარი წაიშალა",
-    "An error occurred while trying to delete the comment" : "კომენტარის წაშლისას აღმოჩენილია შეცდომა",
-    "An error occurred while trying to create the comment" : "კომენტარის შექმნისას აღმოჩენილია შეცდომა",
-    "Write a comment …" : "კომენტარის დაწერა …"
+    "Comments" : "Comments",
+    "You commented" : "You commented",
+    "{author} commented" : "{author} commented",
+    "You commented on %1$s" : "You commented on %1$s",
+    "You commented on {file}" : "You commented on {file}",
+    "%1$s commented on %2$s" : "%1$s commented on %2$s",
+    "{author} commented on {file}" : "{author} commented on {file}",
+    "<strong>Comments</strong> for files" : "<strong>Comments</strong> for files",
+    "{user} mentioned you in a comment on \"{file}\"" : "{user} mentioned you in a comment on \"{file}\"",
+    "Files app plugin to add comments to files" : "Files app plugin to add comments to files",
+    "Edit comment" : "Edit comment",
+    "Delete comment" : "Delete comment",
+    "Cancel edit" : "Cancel edit",
+    "Post comment" : "Post comment",
+    "@ for mentions, : for emoji, / for smart picker" : "@ for mentions, : for emoji, / for smart picker",
+    "Could not reload comments" : "Could not reload comments",
+    "Failed to mark comments as read" : "Failed to mark comments as read",
+    "Unable to load the comments list" : "Unable to load the comments list",
+    "No comments yet, start the conversation!" : "No comments yet, start the conversation!",
+    "No more messages" : "No more messages",
+    "Retry" : "Retry",
+    "_1 new comment_::_{unread} new comments_" : ["1 new comment","{unread} new comments"],
+    "Comment" : "Comment",
+    "An error occurred while trying to edit the comment" : "An error occurred while trying to edit the comment",
+    "Comment deleted" : "Comment deleted",
+    "An error occurred while trying to delete the comment" : "An error occurred while trying to delete the comment",
+    "An error occurred while trying to create the comment" : "An error occurred while trying to create the comment"
 },"pluralForm" :"nplurals=2; plural=(n!=1);"
 }

apps/comments/l10n/lt_LT.js

@@ -10,28 +10,20 @@ OC.L10N.register(
     "{author} commented on {file}" : "{author} pakomentavo {file}",
     "<strong>Comments</strong> for files" : "Failų <strong>komentarai</strong>",
     "Files" : "Failai",
-    "You were mentioned on \"{file}\", in a comment by an account that has since been deleted" : "Buvote paminėtas „{file}“, komentare, kuris buvo parašytas iš paskyros, kuri vėliau buvo ištrinta.",
-    "{user} mentioned you in a comment on \"{file}\"" : "{user} minėjo jus \"{file}\" komentare",
     "Files app plugin to add comments to files" : "Failų programėlės įskiepis, skirtas prie failų pridėti komentarus",
     "Edit comment" : "Taisyti komentarą",
     "Delete comment" : "Ištrinti komentarą",
     "Cancel edit" : "Atsisakyti taisymo",
     "New comment" : "Naujas komentaras",
-    "Write a comment …" : "Rašyti komentarą ...",
     "Post comment" : "Paskelbti komentarą",
-    "@ for mentions, : for emoji, / for smart picker" : "@ paminėjimams, : jaustukams, / išmaniajam rinkikliui",
-    "Could not reload comments" : "Nepavyko įkelti komentarų iš naujo",
-    "Failed to mark comments as read" : "Nepavyko pažymėti komentarų kaip perskaitytų",
     "Unable to load the comments list" : "Nepavyko įkelti komentarų sąrašo",
     "No comments yet, start the conversation!" : "Komentarų kol kas nėra, pradėkite pokalbį!",
-    "No more messages" : "Daugiau jokių pranešimų",
     "Retry" : "Bandyti dar kartą",
     "_1 new comment_::_{unread} new comments_" : ["1 neskaitytas komentaras","{unread} neskaityti komentarai","{unread} neskaitytų komentarų","{unread} neskaitytas komentaras"],
     "Comment" : "Komentaras",
     "An error occurred while trying to edit the comment" : "Bandant taisyti komentarą, įvyko klaida",
     "Comment deleted" : "Komentaras ištrintas",
     "An error occurred while trying to delete the comment" : "Bandant ištrinti komentarą, įvyko klaida",
-    "An error occurred while trying to create the comment" : "Bandant sukurti komentarą, įvyko klaida",
-    "Write a comment …" : "Rašyti komentarą..."
+    "An error occurred while trying to create the comment" : "Bandant sukurti komentarą, įvyko klaida"
 },
 "nplurals=4; plural=(n % 10 == 1 && (n % 100 > 19 || n % 100 < 11) ? 0 : (n % 10 >= 2 && n % 10 <=9) && (n % 100 > 19 || n % 100 < 11) ? 1 : n % 1 != 0 ? 2: 3);");

apps/comments/l10n/lt_LT.json

@@ -8,28 +8,20 @@
     "{author} commented on {file}" : "{author} pakomentavo {file}",
     "<strong>Comments</strong> for files" : "Failų <strong>komentarai</strong>",
     "Files" : "Failai",
-    "You were mentioned on \"{file}\", in a comment by an account that has since been deleted" : "Buvote paminėtas „{file}“, komentare, kuris buvo parašytas iš paskyros, kuri vėliau buvo ištrinta.",
-    "{user} mentioned you in a comment on \"{file}\"" : "{user} minėjo jus \"{file}\" komentare",
     "Files app plugin to add comments to files" : "Failų programėlės įskiepis, skirtas prie failų pridėti komentarus",
     "Edit comment" : "Taisyti komentarą",
     "Delete comment" : "Ištrinti komentarą",
     "Cancel edit" : "Atsisakyti taisymo",
     "New comment" : "Naujas komentaras",
-    "Write a comment …" : "Rašyti komentarą ...",
     "Post comment" : "Paskelbti komentarą",
-    "@ for mentions, : for emoji, / for smart picker" : "@ paminėjimams, : jaustukams, / išmaniajam rinkikliui",
-    "Could not reload comments" : "Nepavyko įkelti komentarų iš naujo",
-    "Failed to mark comments as read" : "Nepavyko pažymėti komentarų kaip perskaitytų",
     "Unable to load the comments list" : "Nepavyko įkelti komentarų sąrašo",
     "No comments yet, start the conversation!" : "Komentarų kol kas nėra, pradėkite pokalbį!",
-    "No more messages" : "Daugiau jokių pranešimų",
     "Retry" : "Bandyti dar kartą",
     "_1 new comment_::_{unread} new comments_" : ["1 neskaitytas komentaras","{unread} neskaityti komentarai","{unread} neskaitytų komentarų","{unread} neskaitytas komentaras"],
     "Comment" : "Komentaras",
     "An error occurred while trying to edit the comment" : "Bandant taisyti komentarą, įvyko klaida",
     "Comment deleted" : "Komentaras ištrintas",
     "An error occurred while trying to delete the comment" : "Bandant ištrinti komentarą, įvyko klaida",
-    "An error occurred while trying to create the comment" : "Bandant sukurti komentarą, įvyko klaida",
-    "Write a comment …" : "Rašyti komentarą..."
+    "An error occurred while trying to create the comment" : "Bandant sukurti komentarą, įvyko klaida"
 },"pluralForm" :"nplurals=4; plural=(n % 10 == 1 && (n % 100 > 19 || n % 100 < 11) ? 0 : (n % 10 >= 2 && n % 10 <=9) && (n % 100 > 19 || n % 100 < 11) ? 1 : n % 1 != 0 ? 2: 3);"
 }

apps/comments/l10n/mn.js

@@ -1,37 +0,0 @@
-OC.L10N.register(
-    "comments",
-    {
-    "Comments" : "Сэтгэгдэл",
-    "You commented" : "Та сэтгэгдэл бичсэн байна",
-    "{author} commented" : "{author} сэтгэгдэл бичсэн",
-    "You commented on %1$s" : "Та %1$s нийтлэл дээр сэтгэгдэл бичсэн байна",
-    "You commented on {file}" : "Та {file} сэтгэгдэл бичсэн байна",
-    "%1$s commented on %2$s" : "%1$s нь %2$s-д сэтгэгдэл бичсэн",
-    "{author} commented on {file}" : "{author} нь {file}-д сэтгэгдэл бичсэн",
-    "<strong>Comments</strong> for files" : "Файлууд дахь<strong>Сэтгэгдэлүүд</strong>",
-    "Files" : "Файлууд",
-    "You were mentioned on \"{file}\", in a comment by an account that has since been deleted" : "Та \"{file}\" дээр, устгагдсан акаунтын сэтгэгдэлд дурдагдсан байна",
-    "{user} mentioned you in a comment on \"{file}\"" : "{user} таныг \"{file}\" дээрх сэтгэгдэлд дурдсан",
-    "Files app plugin to add comments to files" : "Файлд сэтгэгдэл нэмэх Файлын апп плагин",
-    "Edit comment" : "Сэтгэгдэл засах",
-    "Delete comment" : "Сэтгэгдэл устгах",
-    "Cancel edit" : "Засварлахыг болих",
-    "New comment" : "Шинэ сэтгэгдэл",
-    "Write a comment …" : "Сэтгэгдэл бичих …",
-    "Post comment" : "Сэтгэгдэл илгээх",
-    "@ for mentions, : for emoji, / for smart picker" : "@ дурдахад, : эможид, / ухаалаг сонгогчид",
-    "Could not reload comments" : "Сэтгэгдлүүдийг дахин ачаалж чадсангүй",
-    "Failed to mark comments as read" : "Сэтгэгдлүүдийг уншсан гэж тэмдэглэж чадсангүй",
-    "Unable to load the comments list" : "Сэтгэгдлүүдийн жагсаалтыг ачаалж чадсангүй",
-    "No comments yet, start the conversation!" : "Сэтгэгдэл байхгүй байна",
-    "No more messages" : "Илүү мессеж байхгүй",
-    "Retry" : "Дахин оролдох",
-    "_1 new comment_::_{unread} new comments_" : ["1 шинэ сэтгэгдэл","{unread} шинэ сэтгэгдэл"],
-    "Comment" : "Сэтгэгдэл",
-    "An error occurred while trying to edit the comment" : "Сэтгэгдэл засварлах үед алдаа гарлаа",
-    "Comment deleted" : "Сэтгэгдэл устгагдсан",
-    "An error occurred while trying to delete the comment" : "Сэтгэгдэл устгах үед алдаа гарлаа",
-    "An error occurred while trying to create the comment" : "Сэтгэгдэл үүсгэх үед алдаа гарлаа",
-    "Write a comment …" : "Сэтгэгдэл бичих …"
-},
-"nplurals=2; plural=(n != 1);");

apps/comments/l10n/mn.json

@@ -1,35 +0,0 @@
-{ "translations": {
-    "Comments" : "Сэтгэгдэл",
-    "You commented" : "Та сэтгэгдэл бичсэн байна",
-    "{author} commented" : "{author} сэтгэгдэл бичсэн",
-    "You commented on %1$s" : "Та %1$s нийтлэл дээр сэтгэгдэл бичсэн байна",
-    "You commented on {file}" : "Та {file} сэтгэгдэл бичсэн байна",
-    "%1$s commented on %2$s" : "%1$s нь %2$s-д сэтгэгдэл бичсэн",
-    "{author} commented on {file}" : "{author} нь {file}-д сэтгэгдэл бичсэн",
-    "<strong>Comments</strong> for files" : "Файлууд дахь<strong>Сэтгэгдэлүүд</strong>",
-    "Files" : "Файлууд",
-    "You were mentioned on \"{file}\", in a comment by an account that has since been deleted" : "Та \"{file}\" дээр, устгагдсан акаунтын сэтгэгдэлд дурдагдсан байна",
-    "{user} mentioned you in a comment on \"{file}\"" : "{user} таныг \"{file}\" дээрх сэтгэгдэлд дурдсан",
-    "Files app plugin to add comments to files" : "Файлд сэтгэгдэл нэмэх Файлын апп плагин",
-    "Edit comment" : "Сэтгэгдэл засах",
-    "Delete comment" : "Сэтгэгдэл устгах",
-    "Cancel edit" : "Засварлахыг болих",
-    "New comment" : "Шинэ сэтгэгдэл",
-    "Write a comment …" : "Сэтгэгдэл бичих …",
-    "Post comment" : "Сэтгэгдэл илгээх",
-    "@ for mentions, : for emoji, / for smart picker" : "@ дурдахад, : эможид, / ухаалаг сонгогчид",
-    "Could not reload comments" : "Сэтгэгдлүүдийг дахин ачаалж чадсангүй",
-    "Failed to mark comments as read" : "Сэтгэгдлүүдийг уншсан гэж тэмдэглэж чадсангүй",
-    "Unable to load the comments list" : "Сэтгэгдлүүдийн жагсаалтыг ачаалж чадсангүй",
-    "No comments yet, start the conversation!" : "Сэтгэгдэл байхгүй байна",
-    "No more messages" : "Илүү мессеж байхгүй",
-    "Retry" : "Дахин оролдох",
-    "_1 new comment_::_{unread} new comments_" : ["1 шинэ сэтгэгдэл","{unread} шинэ сэтгэгдэл"],
-    "Comment" : "Сэтгэгдэл",
-    "An error occurred while trying to edit the comment" : "Сэтгэгдэл засварлах үед алдаа гарлаа",
-    "Comment deleted" : "Сэтгэгдэл устгагдсан",
-    "An error occurred while trying to delete the comment" : "Сэтгэгдэл устгах үед алдаа гарлаа",
-    "An error occurred while trying to create the comment" : "Сэтгэгдэл үүсгэх үед алдаа гарлаа",
-    "Write a comment …" : "Сэтгэгдэл бичих …"
-},"pluralForm" :"nplurals=2; plural=(n != 1);"
-}

apps/comments/l10n/nl.js

@@ -10,20 +10,20 @@ OC.L10N.register(
     "{author} commented on {file}" : "{author} reageerde op {file}",
     "<strong>Comments</strong> for files" : "<strong>Reacties</strong> voor bestanden",
     "Files" : "Bestanden",
-    "You were mentioned on \"{file}\", in a comment by an account that has since been deleted" : "Je werd genoemd op \"{file}\", in een reactie van een account dat intussen is verwijderd",
+    "You were mentioned on \"{file}\", in a comment by an account that has since been deleted" : "Je werd genoemd op \"{file}\", in een opmerking van een account dat intussen is verwijderd",
     "{user} mentioned you in a comment on \"{file}\"" : "{user} noemde jou in een reactie op \"{file}\"",
     "Files app plugin to add comments to files" : "Bestanden app plugin om reacties aan bestanden toe te voegen",
     "Edit comment" : "Reactie bewerken",
     "Delete comment" : "Reactie verwijderen",
     "Cancel edit" : "Bewerking annuleren",
     "New comment" : "Nieuwe reactie",
-    "Write a comment …" : "Schrijf een reactie …",
+    "Write a comment …" : "Schrijf een commentaar …",
     "Post comment" : "Reactie plaatsen",
     "@ for mentions, : for emoji, / for smart picker" : "@ voor vermeldingen, : voor emoji, / voor Smart Picker",
     "Could not reload comments" : "Kon reactie niet opnieuw laden",
     "Failed to mark comments as read" : "Kon reacties niet als gelezen markeren",
     "Unable to load the comments list" : "Kan reactielijst niet laden",
-    "No comments yet, start the conversation!" : "Nog geen reacties, start het gesprek!",
+    "No comments yet, start the conversation!" : "Nog geen reacties, start de discussie!",
     "No more messages" : "Geen berichten meer",
     "Retry" : "Opnieuw proberen",
     "_1 new comment_::_{unread} new comments_" : ["1 nieuwe reactie","{unread} nieuwe reacties"],

apps/comments/l10n/nl.json

@@ -8,20 +8,20 @@
     "{author} commented on {file}" : "{author} reageerde op {file}",
     "<strong>Comments</strong> for files" : "<strong>Reacties</strong> voor bestanden",
     "Files" : "Bestanden",
-    "You were mentioned on \"{file}\", in a comment by an account that has since been deleted" : "Je werd genoemd op \"{file}\", in een reactie van een account dat intussen is verwijderd",
+    "You were mentioned on \"{file}\", in a comment by an account that has since been deleted" : "Je werd genoemd op \"{file}\", in een opmerking van een account dat intussen is verwijderd",
     "{user} mentioned you in a comment on \"{file}\"" : "{user} noemde jou in een reactie op \"{file}\"",
     "Files app plugin to add comments to files" : "Bestanden app plugin om reacties aan bestanden toe te voegen",
     "Edit comment" : "Reactie bewerken",
     "Delete comment" : "Reactie verwijderen",
     "Cancel edit" : "Bewerking annuleren",
     "New comment" : "Nieuwe reactie",
-    "Write a comment …" : "Schrijf een reactie …",
+    "Write a comment …" : "Schrijf een commentaar …",
     "Post comment" : "Reactie plaatsen",
     "@ for mentions, : for emoji, / for smart picker" : "@ voor vermeldingen, : voor emoji, / voor Smart Picker",
     "Could not reload comments" : "Kon reactie niet opnieuw laden",
     "Failed to mark comments as read" : "Kon reacties niet als gelezen markeren",
     "Unable to load the comments list" : "Kan reactielijst niet laden",
-    "No comments yet, start the conversation!" : "Nog geen reacties, start het gesprek!",
+    "No comments yet, start the conversation!" : "Nog geen reacties, start de discussie!",
     "No more messages" : "Geen berichten meer",
     "Retry" : "Opnieuw proberen",
     "_1 new comment_::_{unread} new comments_" : ["1 nieuwe reactie","{unread} nieuwe reacties"],

apps/comments/l10n/sk.js

@@ -17,7 +17,6 @@ OC.L10N.register(
     "Delete comment" : "Zmazať komentár",
     "Cancel edit" : "Zrušiť upravovanie",
     "New comment" : "Nový komentár",
-    "Write a comment …" : "Napísať komentár ...",
     "Post comment" : "Odoslať komentár",
     "@ for mentions, : for emoji, / for smart picker" : "@ pre spomienky, : pre emotikony, / pre inteligentný výber",
     "Could not reload comments" : "Nepodarilo sa obnoviť komentáre",

apps/comments/l10n/sk.json

@@ -15,7 +15,6 @@
     "Delete comment" : "Zmazať komentár",
     "Cancel edit" : "Zrušiť upravovanie",
     "New comment" : "Nový komentár",
-    "Write a comment …" : "Napísať komentár ...",
     "Post comment" : "Odoslať komentár",
     "@ for mentions, : for emoji, / for smart picker" : "@ pre spomienky, : pre emotikony, / pre inteligentný výber",
     "Could not reload comments" : "Nepodarilo sa obnoviť komentáre",

apps/comments/l10n/uz.js

@@ -1,37 +0,0 @@
-OC.L10N.register(
-    "comments",
-    {
-    "Comments" : "Izohlar",
-    "You commented" : "Siz fikr bildirgansiz",
-    "{author} commented" : "{author} izoh qoldirdi",
-    "You commented on %1$s" : "Siz %1$s haqida fikr bildirdingiz",
-    "You commented on {file}" : "Siz {file} ga izoh qoldirdingiz",
-    "%1$s commented on %2$s" : "%1$s %2$s haqida fikr bildirdi",
-    "{author} commented on {file}" : "{author} {file} ga izoh qoldirdi",
-    "<strong>Comments</strong> for files" : "Fayllar uchun <strong>Izohlar</strong>",
-    "Files" : "Fayllar",
-    "You were mentioned on \"{file}\", in a comment by an account that has since been deleted" : "Siz \"{file}\"da, keyinchalik o'chirilgan hisob tomonidan izohda tilga olingansiz",
-    "{user} mentioned you in a comment on \"{file}\"" : "{user} sizni \"{file}\" dagi izohda tilga oldi",
-    "Files app plugin to add comments to files" : "Fayllarga izohlar qo'shish ilova plagini",
-    "Edit comment" : "Izohni tahrirlash",
-    "Delete comment" : "Izohni o'chirish",
-    "Cancel edit" : "Tahrirni bekor qilish",
-    "New comment" : "Yangi izoh",
-    "Write a comment …" : "Fikr yozing…",
-    "Post comment" : "Fikr qoldirish",
-    "@ for mentions, : for emoji, / for smart picker" : "@ eslatmalar uchun, : emojilar uchun, / aqlli tanlovclar uchun",
-    "Could not reload comments" : "Izohlarni qayta yuklab bo'lmadi",
-    "Failed to mark comments as read" : "Izohlarni o'qilgan deb belgilashda xatolik yuz berdi",
-    "Unable to load the comments list" : "Izohlar ro'yxatini yuklab bo'lmadi",
-    "No comments yet, start the conversation!" : "Hali izohlar yo'q, suhbatni boshlang!",
-    "No more messages" : "Boshqa xabarlar yo'q",
-    "Retry" : "Qayta urinish",
-    "_1 new comment_::_{unread} new comments_" : ["{unread} ta yangi izoh"],
-    "Comment" : "Izoh",
-    "An error occurred while trying to edit the comment" : "Izohni tahrirlashda xatolik yuz berdi",
-    "Comment deleted" : "Izoh o'chirildi",
-    "An error occurred while trying to delete the comment" : "Izohni o'chirishda xatolik yuz berdi",
-    "An error occurred while trying to create the comment" : "Izoh yaratishda xatolik yuz berdi",
-    "Write a comment …" : "Izoh yozing..."
-},
-"nplurals=1; plural=0;");

apps/comments/l10n/uz.json

@@ -1,35 +0,0 @@
-{ "translations": {
-    "Comments" : "Izohlar",
-    "You commented" : "Siz fikr bildirgansiz",
-    "{author} commented" : "{author} izoh qoldirdi",
-    "You commented on %1$s" : "Siz %1$s haqida fikr bildirdingiz",
-    "You commented on {file}" : "Siz {file} ga izoh qoldirdingiz",
-    "%1$s commented on %2$s" : "%1$s %2$s haqida fikr bildirdi",
-    "{author} commented on {file}" : "{author} {file} ga izoh qoldirdi",
-    "<strong>Comments</strong> for files" : "Fayllar uchun <strong>Izohlar</strong>",
-    "Files" : "Fayllar",
-    "You were mentioned on \"{file}\", in a comment by an account that has since been deleted" : "Siz \"{file}\"da, keyinchalik o'chirilgan hisob tomonidan izohda tilga olingansiz",
-    "{user} mentioned you in a comment on \"{file}\"" : "{user} sizni \"{file}\" dagi izohda tilga oldi",
-    "Files app plugin to add comments to files" : "Fayllarga izohlar qo'shish ilova plagini",
-    "Edit comment" : "Izohni tahrirlash",
-    "Delete comment" : "Izohni o'chirish",
-    "Cancel edit" : "Tahrirni bekor qilish",
-    "New comment" : "Yangi izoh",
-    "Write a comment …" : "Fikr yozing…",
-    "Post comment" : "Fikr qoldirish",
-    "@ for mentions, : for emoji, / for smart picker" : "@ eslatmalar uchun, : emojilar uchun, / aqlli tanlovclar uchun",
-    "Could not reload comments" : "Izohlarni qayta yuklab bo'lmadi",
-    "Failed to mark comments as read" : "Izohlarni o'qilgan deb belgilashda xatolik yuz berdi",
-    "Unable to load the comments list" : "Izohlar ro'yxatini yuklab bo'lmadi",
-    "No comments yet, start the conversation!" : "Hali izohlar yo'q, suhbatni boshlang!",
-    "No more messages" : "Boshqa xabarlar yo'q",
-    "Retry" : "Qayta urinish",
-    "_1 new comment_::_{unread} new comments_" : ["{unread} ta yangi izoh"],
-    "Comment" : "Izoh",
-    "An error occurred while trying to edit the comment" : "Izohni tahrirlashda xatolik yuz berdi",
-    "Comment deleted" : "Izoh o'chirildi",
-    "An error occurred while trying to delete the comment" : "Izohni o'chirishda xatolik yuz berdi",
-    "An error occurred while trying to create the comment" : "Izoh yaratishda xatolik yuz berdi",
-    "Write a comment …" : "Izoh yozing..."
-},"pluralForm" :"nplurals=1; plural=0;"
-}

apps/comments/lib/Activity/Filter.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * SPDX-FileCopyrightText: 2016 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later

apps/comments/lib/Activity/Listener.php

@@ -12,6 +12,7 @@ use OCP\App\IAppManager;
 use OCP\Comments\CommentsEvent;
 use OCP\Files\Config\IMountProviderCollection;
 use OCP\Files\IRootFolder;
+use OCP\Files\Node;
 use OCP\IUser;
 use OCP\IUserSession;
 use OCP\Share\IShareHelper;
@@ -46,8 +47,10 @@ class Listener {
 		foreach ($mounts as $mount) {
 			$owner = $mount->getUser()->getUID();
 			$ownerFolder = $this->rootFolder->getUserFolder($owner);
-			$node = $ownerFolder->getFirstNodeById((int)$event->getComment()->getObjectId());
-			if ($node !== null) {
+			$nodes = $ownerFolder->getById((int)$event->getComment()->getObjectId());
+			if (!empty($nodes)) {
+				/** @var Node $node */
+				$node = array_shift($nodes);
 				$al = $this->shareHelper->getPathsForAccessList($node);
 				$users += $al['users'];
 			}

apps/comments/lib/Activity/Setting.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * SPDX-FileCopyrightText: 2016 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later

apps/comments/lib/AppInfo/Application.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * SPDX-FileCopyrightText: 2016 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later

apps/comments/lib/Controller/NotificationsController.php

@@ -70,11 +70,11 @@ class NotificationsController extends Controller {
 				return new NotFoundResponse();
 			}
 			$userFolder = $this->rootFolder->getUserFolder($currentUser->getUID());
-			$file = $userFolder->getFirstNodeById((int)$comment->getObjectId());
+			$files = $userFolder->getById((int)$comment->getObjectId());
 
 			$this->markProcessed($comment, $currentUser);
 
-			if ($file === null) {
+			if (empty($files)) {
 				return new NotFoundResponse();
 			}
 

apps/comments/lib/Listener/CommentsEntityEventListener.php

@@ -32,8 +32,8 @@ class CommentsEntityEventListener implements IEventListener {
 		}
 
 		$event->addEntityCollection('files', function ($name): bool {
-			$node = $this->rootFolder->getUserFolder($this->userId)->getFirstNodeById((int)$name);
-			return $node !== null;
+			$nodes = $this->rootFolder->getUserFolder($this->userId)->getById((int)$name);
+			return !empty($nodes);
 		});
 	}
 }

apps/comments/lib/Listener/LoadSidebarScripts.php

@@ -34,8 +34,7 @@ class LoadSidebarScripts implements IEventListener {
 		$this->commentsManager->load();
 
 		$this->initialState->provideInitialState('activityEnabled', $this->appManager->isEnabledForUser('activity'));
-		// Add comments sidebar tab script/style
-		Util::addStyle(Application::APP_ID, 'comments-tab');
+		// Add comments sidebar tab script
 		Util::addScript(Application::APP_ID, 'comments-tab', 'files');
 	}
 }

apps/comments/lib/Notification/Notifier.php

@@ -84,10 +84,11 @@ class Notifier implements INotifier {
 					throw new UnknownNotificationException('Unsupported comment object');
 				}
 				$userFolder = $this->rootFolder->getUserFolder($notification->getUser());
-				$node = $userFolder->getFirstNodeById((int)$parameters[1]);
-				if ($node === null) {
+				$nodes = $userFolder->getById((int)$parameters[1]);
+				if (empty($nodes)) {
 					throw new AlreadyProcessedException();
 				}
+				$node = $nodes[0];
 
 				$path = rtrim($node->getPath(), '/');
 				if (str_starts_with($path, '/' . $notification->getUser() . '/files/')) {

apps/comments/lib/Search/CommentsSearchProvider.php

@@ -116,11 +116,11 @@ class CommentsSearchProvider implements IProvider {
 	 * @throws NotFoundException
 	 */
 	protected function getFileForComment(Folder $userFolder, IComment $comment): Node {
-		$node = $userFolder->getFirstNodeById((int)$comment->getObjectId());
-		if ($node === null) {
+		$nodes = $userFolder->getById((int)$comment->getObjectId());
+		if (empty($nodes)) {
 			throw new NotFoundException('File not found');
 		}
 
-		return $node;
+		return array_shift($nodes);
 	}
 }

apps/comments/src/actions/inlineUnreadCommentsAction.spec.ts

@@ -1,19 +1,19 @@
-/*!
+/**
  * SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import type { IFolder, IView } from '@nextcloud/files'
+import type { Folder, View } from '@nextcloud/files'
 
-import { File, Permission } from '@nextcloud/files'
+import { File, FileAction, Permission } from '@nextcloud/files'
 import { describe, expect, test, vi } from 'vitest'
-import logger from '../logger.ts'
+import logger from '../logger.js'
 import { action } from './inlineUnreadCommentsAction.ts'
 
 const view = {
 	id: 'files',
 	name: 'Files',
-} as IView
+} as View
 
 describe('Inline unread comments action display name tests', () => {
 	test('Default values', () => {
@@ -29,35 +29,36 @@ describe('Inline unread comments action display name tests', () => {
 			root: '/files/admin',
 		})
 
+		expect(action).toBeInstanceOf(FileAction)
 		expect(action.id).toBe('comments-unread')
 		expect(action.displayName({
 			nodes: [file],
 			view,
-			folder: {} as IFolder,
+			folder: {} as Folder,
 			contents: [],
 		})).toBe('')
 		expect(action.title!({
 			nodes: [file],
 			view,
-			folder: {} as IFolder,
+			folder: {} as Folder,
 			contents: [],
 		})).toBe('1 new comment')
 		expect(action.iconSvgInline({
 			nodes: [file],
 			view,
-			folder: {} as IFolder,
+			folder: {} as Folder,
 			contents: [],
 		})).toMatch(/<svg.+<\/svg>/)
 		expect(action.enabled!({
 			nodes: [file],
 			view,
-			folder: {} as IFolder,
+			folder: {} as Folder,
 			contents: [],
 		})).toBe(true)
 		expect(action.inline!({
 			nodes: [file],
 			view,
-			folder: {} as IFolder,
+			folder: {} as Folder,
 			contents: [],
 		})).toBe(true)
 		expect(action.default).toBeUndefined()
@@ -80,13 +81,13 @@ describe('Inline unread comments action display name tests', () => {
 		expect(action.displayName({
 			nodes: [file],
 			view,
-			folder: {} as IFolder,
+			folder: {} as Folder,
 			contents: [],
 		})).toBe('')
 		expect(action.title!({
 			nodes: [file],
 			view,
-			folder: {} as IFolder,
+			folder: {} as Folder,
 			contents: [],
 		})).toBe('2 new comments')
 	})
@@ -107,7 +108,7 @@ describe('Inline unread comments action enabled tests', () => {
 		expect(action.enabled!({
 			nodes: [file],
 			view,
-			folder: {} as IFolder,
+			folder: {} as Folder,
 			contents: [],
 		})).toBe(false)
 	})
@@ -128,7 +129,7 @@ describe('Inline unread comments action enabled tests', () => {
 		expect(action.enabled!({
 			nodes: [file],
 			view,
-			folder: {} as IFolder,
+			folder: {} as Folder,
 			contents: [],
 		})).toBe(false)
 	})
@@ -149,7 +150,7 @@ describe('Inline unread comments action enabled tests', () => {
 		expect(action.enabled!({
 			nodes: [file],
 			view,
-			folder: {} as IFolder,
+			folder: {} as Folder,
 			contents: [],
 		})).toBe(true)
 	})
@@ -170,7 +171,7 @@ describe('Inline unread comments action enabled tests', () => {
 		expect(action.enabled!({
 			nodes: [file],
 			view,
-			folder: {} as IFolder,
+			folder: {} as Folder,
 			contents: [],
 		})).toBe(true)
 	})
@@ -203,7 +204,7 @@ describe('Inline unread comments action execute tests', () => {
 		const result = await action.exec!({
 			nodes: [file],
 			view,
-			folder: {} as IFolder,
+			folder: {} as Folder,
 			contents: [],
 		})
 
@@ -240,7 +241,7 @@ describe('Inline unread comments action execute tests', () => {
 		const result = await action.exec!({
 			nodes: [file],
 			view,
-			folder: {} as IFolder,
+			folder: {} as Folder,
 			contents: [],
 		})
 

apps/comments/src/actions/inlineUnreadCommentsAction.ts

@@ -3,15 +3,12 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import type { IFileAction } from '@nextcloud/files'
-
 import CommentProcessingSvg from '@mdi/svg/svg/comment-processing.svg?raw'
-import { getSidebar } from '@nextcloud/files'
+import { FileAction, getSidebar } from '@nextcloud/files'
 import { n, t } from '@nextcloud/l10n'
-import logger from '../logger.ts'
-import { isUsingActivityIntegration } from '../utils/activity.ts'
+import logger from '../logger.js'
 
-export const action: IFileAction = {
+export const action = new FileAction({
 	id: 'comments-unread',
 
 	title({ nodes }) {
@@ -39,13 +36,7 @@ export const action: IFileAction = {
 
 		try {
 			const sidebar = getSidebar()
-			const sidebarTabId = isUsingActivityIntegration() ? 'activity' : 'comments'
-			if (sidebar.isOpen && sidebar.node?.source === nodes[0].source) {
-				logger.debug('Sidebar already open for this node, just activating comments tab')
-				sidebar.setActiveTab(sidebarTabId)
-				return null
-			}
-			sidebar.open(nodes[0], sidebarTabId)
+			sidebar.open(nodes[0], 'comments')
 			return null
 		} catch (error) {
 			logger.error('Error while opening sidebar', { error })
@@ -56,4 +47,4 @@ export const action: IFileAction = {
 	inline: () => true,
 
 	order: -140,
-}
+})

apps/comments/src/comments-activity-tab.ts

@@ -4,40 +4,46 @@
  */
 
 import type { INode } from '@nextcloud/files'
-import type { App } from 'vue'
 
-import { createPinia } from 'pinia'
-import { createApp } from 'vue'
-import logger from './logger.ts'
-import { getComments } from './services/GetComments.ts'
+import moment from '@nextcloud/moment'
+import { createPinia, PiniaVuePlugin } from 'pinia'
+import Vue, { type ComponentPublicInstance } from 'vue'
+import logger from './logger.js'
+import { getComments } from './services/GetComments.js'
+
+Vue.use(PiniaVuePlugin)
+
+let ActivityTabPluginView
+let ActivityTabPluginInstance
 
 /**
  * Register the comments plugins for the Activity sidebar
  */
 export function registerCommentsPlugins() {
-	let app: App
-
 	window.OCA.Activity.registerSidebarAction({
 		mount: async (el: HTMLElement, { node, reload }: { node: INode, reload: () => void }) => {
 			const pinia = createPinia()
 
-			if (!app) {
+			if (!ActivityTabPluginView) {
 				const { default: ActivityCommentAction } = await import('./views/ActivityCommentAction.vue')
-				app = createApp(
-					ActivityCommentAction,
-					{
-						reloadCallback: reload,
-						resourceId: node.fileid,
-					},
-				)
+				// @ts-expect-error Types are broken for Vue2
+				ActivityTabPluginView = Vue.extend(ActivityCommentAction)
 			}
-			app.use(pinia)
-			app.mount(el)
+			ActivityTabPluginInstance = new ActivityTabPluginView({
+				el,
+				pinia,
+				propsData: {
+					reloadCallback: reload,
+					resourceId: node.fileid,
+				},
+			})
 			logger.info('Comments plugin mounted in Activity sidebar action', { node })
 		},
 		unmount: () => {
 			// destroy previous instance if available
-			app?.unmount()
+			if (ActivityTabPluginInstance) {
+				ActivityTabPluginInstance.$destroy()
+			}
 		},
 	})
 
@@ -51,26 +57,26 @@ export function registerCommentsPlugins() {
 		)
 		logger.debug('Loaded comments', { node, comments })
 		const { default: CommentView } = await import('./views/ActivityCommentEntry.vue')
+		// @ts-expect-error Types are broken for Vue2
+		const CommentsViewObject = Vue.extend(CommentView)
 
 		return comments.map((comment) => ({
-			_CommentsViewInstance: undefined as App | undefined,
+			_CommentsViewInstance: undefined as ComponentPublicInstance | undefined,
 
-			timestamp: Date.parse(comment.props?.creationDateTime as string | undefined ?? ''),
+			timestamp: moment(comment.props?.creationDateTime).toDate().getTime(),
 
 			mount(element: HTMLElement, { reload }) {
-				const app = createApp(
-					CommentView,
-					{
+				this._CommentsViewInstance = new CommentsViewObject({
+					el: element,
+					propsData: {
 						comment,
 						resourceId: node.fileid,
 						reloadCallback: reload,
 					},
-				)
-				app.mount(element)
-				this._CommentsViewInstance = app
+				})
 			},
 			unmount() {
-				this._CommentsViewInstance?.unmount()
+				this._CommentsViewInstance?.$destroy()
 			},
 		}))
 	})

apps/comments/src/comments-app.js

@@ -3,8 +3,8 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import logger from './logger.ts'
-import CommentsInstance from './services/CommentsInstance.ts'
+import logger from './logger.js'
+import CommentsInstance from './services/CommentsInstance.js'
 
 // Init Comments
 if (window.OCA && !window.OCA.Comments) {

apps/comments/src/components/Comment.vue

@@ -13,7 +13,7 @@
 			<!-- Author -->
 			<NcAvatar
 				class="comment__avatar"
-				:displayName="actorDisplayName"
+				:display-name="actorDisplayName"
 				:user="actorId"
 				:size="32" />
 		</div>
@@ -26,7 +26,7 @@
 				<NcActions v-if="isOwnComment && id && !loading" class="comment__actions">
 					<template v-if="!editing">
 						<NcActionButton
-							closeAfterClick
+							close-after-click
 							@click="onEdit">
 							<template #icon>
 								<IconPencilOutline :size="20" />
@@ -35,7 +35,7 @@
 						</NcActionButton>
 						<NcActionSeparator />
 						<NcActionButton
-							closeAfterClick
+							close-after-click
 							@click="onDeleteWithUndo">
 							<template #icon>
 								<IconTrashCanOutline :size="20" />
@@ -60,7 +60,7 @@
 					v-else-if="creationDateTime"
 					class="comment__timestamp"
 					:timestamp="timestamp"
-					:ignoreSeconds="true" />
+					:ignore-seconds="true" />
 			</div>
 
 			<!-- Message editor -->
@@ -68,14 +68,14 @@
 				<div class="comment__editor-group">
 					<NcRichContenteditable
 						ref="editor"
-						v-model="localMessage"
-						:autoComplete
+						:auto-complete="autoComplete"
 						:contenteditable="!loading"
 						:label="editor ? t('comments', 'New comment') : t('comments', 'Edit comment')"
 						:placeholder="t('comments', 'Write a comment …')"
-						:userData
+						:model-value="localMessage"
+						:user-data="userData"
 						aria-describedby="tab-comments__editor-description"
-						@update:modelValue="submitted = false"
+						@update:value="updateLocalMessage"
 						@submit="onSubmit" />
 					<div class="comment__submit">
 						<NcButton
@@ -103,8 +103,8 @@
 				:class="{ 'comment__message--expanded': expanded }"
 				:text="richContent.message"
 				:arguments="richContent.mentions"
-				useMarkdown
-				@click="onExpand" />
+				use-markdown
+				@click.native="onExpand" />
 		</div>
 	</component>
 </template>
@@ -113,7 +113,6 @@
 import { getCurrentUser } from '@nextcloud/auth'
 import { translate as t } from '@nextcloud/l10n'
 import { mapStores } from 'pinia'
-import { defineAsyncComponent } from 'vue'
 import NcActionButton from '@nextcloud/vue/components/NcActionButton'
 import NcActions from '@nextcloud/vue/components/NcActions'
 import NcActionSeparator from '@nextcloud/vue/components/NcActionSeparator'
@@ -126,12 +125,12 @@ import IconArrowRight from 'vue-material-design-icons/ArrowRight.vue'
 import IconClose from 'vue-material-design-icons/Close.vue'
 import IconPencilOutline from 'vue-material-design-icons/PencilOutline.vue'
 import IconTrashCanOutline from 'vue-material-design-icons/TrashCanOutline.vue'
-import CommentMixin from '../mixins/CommentMixin.ts'
-import { useDeletedCommentLimbo } from '../store/deletedCommentLimbo.ts'
+import CommentMixin from '../mixins/CommentMixin.js'
+import { useDeletedCommentLimbo } from '../store/deletedCommentLimbo.js'
 
 // Dynamic loading
-const NcRichContenteditable = defineAsyncComponent(() => import('@nextcloud/vue/components/NcRichContenteditable'))
-const NcRichText = defineAsyncComponent(() => import('@nextcloud/vue/components/NcRichText'))
+const NcRichContenteditable = () => import('@nextcloud/vue/components/NcRichContenteditable')
+const NcRichText = () => import('@nextcloud/vue/components/NcRichText')
 
 export default {
 	/* eslint vue/multi-word-component-names: "warn" */

apps/comments/src/files-sidebar.ts

@@ -1,19 +1,23 @@
-/*!
+/**
  * SPDX-FileCopyrightText: 2020 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
 import MessageReplyText from '@mdi/svg/svg/message-reply-text.svg?raw'
+import { getCSPNonce } from '@nextcloud/auth'
 import { registerSidebarTab } from '@nextcloud/files'
+import { loadState } from '@nextcloud/initial-state'
 import { t } from '@nextcloud/l10n'
-import { createPinia } from 'pinia'
-import { defineCustomElement } from 'vue'
+import wrap from '@vue/web-component-wrapper'
+import { createPinia, PiniaVuePlugin } from 'pinia'
+import Vue from 'vue'
 import { registerCommentsPlugins } from './comments-activity-tab.ts'
-import { isUsingActivityIntegration } from './utils/activity.ts'
+
+__webpack_nonce__ = getCSPNonce()
 
 const tagName = 'comments_files-sidebar-tab'
 
-if (isUsingActivityIntegration()) {
+if (loadState('comments', 'activityEnabled', false) && OCA?.Activity?.registerSidebarAction !== undefined) {
 	// Do not mount own tab but mount into activity
 	window.addEventListener('DOMContentLoaded', function() {
 		registerCommentsPlugins()
@@ -28,15 +32,17 @@ if (isUsingActivityIntegration()) {
 		async onInit() {
 			const { default: FilesSidebarTab } = await import('./views/FilesSidebarTab.vue')
 
-			const FilesSidebarTabElement = defineCustomElement(FilesSidebarTab, {
-				configureApp(app) {
-					const pinia = createPinia()
-					app.use(pinia)
-				},
-				shadowRoot: false,
+			Vue.use(PiniaVuePlugin)
+			Vue.mixin({ pinia: createPinia() })
+			const webComponent = wrap(Vue, FilesSidebarTab)
+			// In Vue 2, wrap doesn't support disabling shadow. Disable with a hack
+			Object.defineProperty(webComponent.prototype, 'attachShadow', {
+				value() { return this },
 			})
-
-			window.customElements.define(tagName, FilesSidebarTabElement)
+			Object.defineProperty(webComponent.prototype, 'shadowRoot', {
+				get() { return this },
+			})
+			window.customElements.define(tagName, webComponent)
 		},
 	})
 }