Compare commits

..

1984 Commits

Author SHA1 Message Date
Joas Schilling 9757559df3 Merge pull request #41131 from nextcloud/backport/41123/stable20
[stable20] fix(external): Get storage before update it
2023-10-26 09:35:54 +02:00
Joas Schilling d4946b6bfa fix(external): Get storage before update it
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-26 07:00:46 +02:00
Arthur Schiwon 3f61e6d196 Merge pull request #39498 from nextcloud/backport/39490/stable20
[stable20] fix(apps): Fix loading info.xml file
2023-07-20 16:22:30 +02:00
Joas Schilling 5574c12371 fix(apps): Fix loading info.xml file
Ref: https://bugs.php.net/bug.php?id=62577

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-20 15:06:11 +02:00
Arthur Schiwon 7d870b503b Merge pull request #39363 from nextcloud/backport/39323/39323-stable20
[stable20] getStorage before remove
2023-07-17 17:37:45 +02:00
Joas Schilling d7694bc782 Merge pull request #39424 from nextcloud/backport/39416/stable20
[stable20] fix(core): Add password confirmation requirement for getapppassword
2023-07-17 17:13:12 +02:00
Côme Chilliet b1f198ac34 Merge pull request #39433 from nextcloud/backport/39024/stable20
[stable20] [stable21] Increase from 100000 to 600000 iterations for hash_pbkdf2
2023-07-17 16:45:37 +02:00
Côme Chilliet ec0869f596 Merge pull request #38584 from nextcloud/backport/38206/stable24
[stable24] Increase from 100000 to 600000 iterations for hash_pbkdf2

(cherry picked from commit a7dc41fb5e)
2023-07-17 12:44:20 +00:00
Joas Schilling f775138816 fix(core): Add password confirmation requirement for getapppassword
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-17 12:20:53 +02:00
Maxence Lange 596b8e58cc getStorage before remove
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-07-13 11:20:03 -01:00
Andy Scherzinger 34eface515 Merge pull request #39351 from nextcloud/ci/sign-drone-stable20
[stable20] chore(CI): Sign .drone.yml file
2023-07-13 12:49:42 +02:00
Joas Schilling 7226a03071 chore(CI): Sign .drone.yml file
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-13 11:58:50 +02:00
Arthur Schiwon 5bfae1c230 Merge pull request #38466 from nextcloud/fix/read-only-system-addres-book-acls-stable20
[stable20] fix(carddav): Mark system address book as read-only
2023-05-25 16:02:08 +02:00
Robin Appelman b4557262cc Merge pull request #38287 from nextcloud/session-auth-check-username-20
[20] check the username when doing external storage session auth
2023-05-15 23:51:29 +02:00
Robin Appelman 9b5c9648a4 check the username when doing external storage session auth
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-15 17:09:09 +02:00
Christoph Wurst 3a7074bc3e fix(carddav): Mark system address book as read-only
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-15 10:52:14 +02:00
Arthur Schiwon d49e40b6ae Merge pull request #38001 from nextcloud/backport/37909/stable20
[stable20] Update crl after revoke shifts.csr
2023-05-04 10:56:14 +02:00
Vitor Mattos f3beca8468 Update crl after revoke shifts.csr
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-05-01 07:49:47 -03:00
Joas Schilling 9f1e3e049d Merge pull request #37839 from nextcloud/bump/guzzle-psr7/stable20
[stable20] sec(deps): Update guzzlehttp/psr7
2023-04-27 09:37:55 +02:00
Joas Schilling 8929fcd5f1 sec(deps): Update guzzlehttp/psr7
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-26 15:55:08 +02:00
Joas Schilling d9450481bb Merge pull request #37260 from nextcloud/backport/37252/stable20
[stable20] fix(workflow): Check tag attribute
2023-03-16 15:08:29 +01:00
Joas Schilling 87255e61a7 fix(workflow): Check tag attribute
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-16 08:59:59 +01:00
John Molakvoæ fbc5007e0d Merge pull request #36820 from nextcloud/backport/36814/stable20
[stable20] Validate the scope when validating operations
2023-02-23 07:54:23 +01:00
Joas Schilling b24a18a857 Also check the scope when reading operations from the database
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-23 06:26:44 +01:00
Joas Schilling 9cee3f29da Validate the scope when validating operations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-23 06:26:43 +01:00
Joas Schilling 50f7433a9a Merge pull request #36406 from nextcloud/bump-guzzlehttp-stable20
[stable20] Bump guzzlehttp/guzzle and guzzlehttp/psr7
2023-02-07 19:17:44 +01:00
Joas Schilling 66d11ae043 Bump guzzlehttp/guzzle and guzzlehttp/psr7
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-07 16:05:54 +01:00
Joas Schilling f93a3aedc4 Merge pull request #36025 from nextcloud/backport/35975/stable20
[stable20] Update crl after revoke files_bpm.csr
2023-01-06 18:15:52 +01:00
Vitor Mattos 032fc47b69 Update crl after revoke files_bpm.csr
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-01-05 13:15:36 -03:00
Vincent Petry f6bbf59c23 Merge pull request #35681 from nextcloud/backport/35391/stable20
[stable20] Make sure that path is normalized and then checked and not the other way around
2022-12-16 16:27:51 +01:00
Côme Chilliet 540d70a6fe Make sure that path is normalized and then checked,
and not the other way around

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-08 11:40:11 +00:00
blizzz 12f68d2028 Merge pull request #32967 from nextcloud/backport/32816/stable20
[stable20] handle stream wrappers in SeekableHttpStream
2022-11-03 13:35:14 +01:00
blizzz ac32a20a50 Merge pull request #33680 from nextcloud/backport/33624/stable20
[stable20] Update CRL
2022-08-25 13:11:32 +02:00
Arthur Schiwon 99921f4626 Update CRL
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-08-24 17:39:00 +02:00
blizzz 543522e2c6 Merge pull request #29634 from nextcloud/backport/29484/stable20
[stable20] Use unique combination of hostname/bucket/key for external storages
2022-07-18 21:41:10 +02:00
Julius Härtl 68a4285b5e Add migration to move over existing storage ids
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-07-07 15:23:22 +02:00
Robin Appelman 19d487838e handle stream wrappers in SeekableHttpStream
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-21 15:12:07 +00:00
Julius Härtl 71d59bc6fc Use unique combination of hostname/bucket/key for external storages
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-06-10 19:03:14 +02:00
blizzz cac6eed35a Merge pull request #31685 from nextcloud/backport/31620/stable20
[stable20] do not forget DB table prefix with truncate query
2022-05-19 16:02:15 +02:00
Arthur Schiwon 33ac5fc640 do not forget DB table prefix with truncate query
- as used in LDAP's AbstractMapping::clear() method
- and in Comment's ManagerTest::setUp()
- fixes a DB Exception with Oracle

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-05-19 15:09:39 +02:00
blizzz 4ccacc7f97 Merge pull request #32478 from nextcloud/backport/32428/stable20
[stable20] Add Email validation
2022-05-19 14:55:41 +02:00
Anna Larch 2881d9eae6 Add email validation
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-05-19 12:25:50 +02:00
blizzz ad989e8ab2 Merge pull request #31651 from nextcloud/backport/31425/stable20
[stable20] Update CRL after revoking some app certs
2022-03-21 17:42:56 +01:00
Arthur Schiwon b8365315cd Update CRL after revoking some app certs
- deckimportfromtrello
- vdirsyncerui

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-03-21 17:25:27 +01:00
blizzz 169090e583 Merge pull request #31648 from nextcloud/backport/31436/stable20
[stable20] be conservative when reading from fresh created column
2022-03-21 17:13:07 +01:00
Arthur Schiwon 3c91048ad4 be conservative when reading from fresh created column
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-03-21 14:04:20 +01:00
Vincent Petry c8db9d9906 Merge pull request #31391 from nextcloud/backport/29611/stable20
[stable20] Show most recently deleted files first in trash can
2022-03-03 17:14:29 +01:00
Christopher Ng d7aa293866 Show most recently deleted files first in trash can
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-01 20:04:45 +00:00
Nextcloud bot 3979ff5917 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-22 02:29:49 +00:00
Nextcloud bot b3a17540cd [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-21 02:28:05 +00:00
Nextcloud bot da1fdfcd96 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-20 02:27:14 +00:00
Nextcloud bot 80772e4cf3 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-19 02:27:31 +00:00
blizzz aa38e77b38 Merge pull request #31250 from nextcloud/backport/30114/stable20
[stable20] Prevent writing invalid mtime
2022-02-18 12:59:28 +01:00
John Molakvoæ 235e1ff2bd Prevent writing invalid mtime
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-02-18 09:11:59 +00:00
blizzz 287797307d Merge pull request #29765 from nextcloud/backport/29752/stable20
[stable20] Explicitly allow some routes without 2FA
2022-02-17 16:29:35 +01:00
Nextcloud bot 217b2852b0 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-17 02:28:17 +00:00
blizzz 34180ac34e Merge pull request #31125 from nextcloud/backport/31115/stable20
[stable20] Fix duplicated UUID migration issue
2022-02-17 00:38:41 +01:00
Arthur Schiwon f4f35a8466 fix unit test
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-16 19:48:17 +01:00
Nextcloud bot 9169c9e42c [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-16 02:28:09 +00:00
Arthur Schiwon a5228a0c42 adjust backport to stable20
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-15 13:23:26 +01:00
Arthur Schiwon 2208ed6f67 fix code style
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-15 13:23:25 +01:00
Arthur Schiwon c14dda9b44 fix use of executeQuery and -Statement
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-15 13:23:25 +01:00
Arthur Schiwon 6368c68a57 Setup warning for invalid LDAP user or group UUIDs.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-15 13:23:25 +01:00
Côme Chilliet 3188f5dc76 Fix psalm errors in apps/user_ldap/lib/Jobs/CleanUp.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-15 13:23:25 +01:00
Côme Chilliet 9c7b769cb2 Fix ldap:update-uuid
Generators cannot be iterated with while or returned by an other
 generator, using foreach instead.
And a few other problems.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-15 13:23:25 +01:00
Arthur Schiwon 66a9b77b37 add occ command to update UUIDs (incomplete)
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-15 13:23:25 +01:00
Arthur Schiwon bf31badac4 allow to re-run migration step when backup DB is already created
- to heal incomplete states from broken upgrades

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-15 13:23:24 +01:00
Arthur Schiwon 6813b38148 invalidated duplicated UUIDs prior to migration change
- in a proper setup there are no duplicated UUIDs
- not all setups are proper
- log warning to admin

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-15 13:23:24 +01:00
Nextcloud bot cac38c03bf [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-15 02:45:53 +00:00
Nextcloud bot 4b9241b6b2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-14 02:28:50 +00:00
Nextcloud bot 756352046e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-13 02:27:25 +00:00
Nextcloud bot 7568e0fdae [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-12 02:28:25 +00:00
Nextcloud bot 953ae8dccf [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-11 02:27:08 +00:00
Nextcloud bot 65aa5d7f40 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-10 02:26:33 +00:00
Nextcloud bot fe00d42ee7 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-09 02:27:20 +00:00
Nextcloud bot 1cbf563ca6 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-08 02:27:42 +00:00
Nextcloud bot 7c53f9dd0b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-07 02:27:10 +00:00
Nextcloud bot 74cbb95492 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-06 02:26:47 +00:00
Nextcloud bot 914dec488d [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-05 02:26:58 +00:00
Nextcloud bot f9c820b5ff [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-04 02:27:15 +00:00
Nextcloud bot 8f2b0c7751 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-03 02:27:23 +00:00
Nextcloud bot 6be2b224f4 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-02 02:27:37 +00:00
Nextcloud bot 491bdac3a2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-01 02:27:15 +00:00
Nextcloud bot 6a7a1b706e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-31 02:27:14 +00:00
Nextcloud bot 7ffb63b7a2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-30 02:27:08 +00:00
Nextcloud bot eac3ff9808 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-29 02:28:06 +00:00
Nextcloud bot 2ad88a820a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-28 02:27:37 +00:00
John Molakvoæ a432546ca2 Merge pull request #30879 from nextcloud/backport/30844/stable20 2022-01-27 12:31:22 +01:00
John Molakvoæ c1de2b7aae Prevent merging on EOL branches
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-01-27 11:24:22 +00:00
Nextcloud bot a7f3802b9b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-27 02:27:50 +00:00
Nextcloud bot baba24c3c1 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-26 02:28:01 +00:00
Joas Schilling d7a58f7f39 Merge pull request #30834 from nextcloud/backport/29902/stable20
[stable20] Check for invalid characters before trimming
2022-01-25 15:32:49 +01:00
Carl Schwan b7e352b84c Merge pull request #30835 from nextcloud/backport/29834/stable20
[stable20] Fix search results filtering
2022-01-25 14:13:19 +01:00
Carl Schwan 0c19c5c65a Fix search results filtering
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-25 10:10:12 +00:00
Joas Schilling a02ad813b2 Correctly set the response after a ClientException as well
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-25 09:43:37 +00:00
Joas Schilling 50bd62bf78 Add an integration test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-25 09:43:37 +00:00
Joas Schilling 787897bf5e Check for invalid characters before trimming
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-25 09:43:37 +00:00
Nextcloud bot c8ca2da5a6 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-25 02:27:57 +00:00
Nextcloud bot 4614179268 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-24 02:27:07 +00:00
Nextcloud bot 93e7319ede [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-23 02:26:51 +00:00
Nextcloud bot 5356d221e4 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-22 02:27:03 +00:00
Nextcloud bot d98c41f920 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-21 02:27:29 +00:00
John Molakvoæ 44dc53d5c1 Merge pull request #30657 from nextcloud/backport/29622/stable20 2022-01-20 10:22:55 +01:00
Nextcloud bot ccc86f80e9 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-20 02:27:48 +00:00
Nextcloud bot 468339b553 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-19 02:28:04 +00:00
Vincent Petry 900d68e741 Merge pull request #30681 from nextcloud/backport/30531/stable20
[stable20] Optimize FileSystemTags workflow for groupfolder
2022-01-18 10:37:09 +01:00
Nextcloud bot 36cc5f2d7e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-18 02:45:47 +00:00
Carl Schwan e5c54bd8ac Fix psalm issues
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-17 14:39:31 +01:00
Côme Chilliet eb570ad263 Merge pull request #30668 from nextcloud/backport/30568/stable20
[stable20] Fix primary key change in user_ldap migration
2022-01-17 14:10:40 +01:00
Côme Chilliet d6b0ff4163 Functions executeQuery and executeStatement do not exists in 20
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-17 12:00:02 +01:00
Côme Chilliet 02e78231f9 Fix Types namespace for version 20
Use Doctrine\DBAL\Types\Types instead of OCP\DB\Types

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-17 10:34:52 +01:00
Nextcloud bot 8240626c68 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-17 02:26:20 +00:00
Nextcloud bot 7bfa1e7cfe [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-16 02:27:35 +00:00
Nextcloud bot e5f712ed87 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-15 02:27:34 +00:00
Carl Schwan 33f49b13ed Add helper method in Wrapper
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-14 14:16:09 +00:00
Carl Schwan 27334942ca The storage is not static anymore
Don't call twice $cache->getId

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-14 14:16:06 +00:00
Carl Schwan a8539c8084 Optimize FileSystemTags workflow for groupfolder
In https://github.com/nextcloud/server/pull/28774 we disabled the
caching for the groupfolder application since it worked due to the fact
that in groupfolders, getFileIds could be called with the same $cacheId
and path for actually different groupfolders.

This revert this change and instead add the folderId from the
groupFolder to the cacheId. This solve the issue of the uniqueness of
the cacheId inside GroupFolder. Downside is that we introduce
groupfolder specific implementation inside the server repo.

The seconf optimization is to not consider paths starting with
__groupfolders in executeCheck. This is due to the fact that files in
the groupfolder application call two times executeCheck one time with
the url __groupfolder/<folderId>/<path> and the other time with <path>.
The first time will always return an empty systemTags array while the
second call will return the correct system tags.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-14 14:16:05 +00:00
Côme Chilliet e20548731f Remove useless indexes with duplicated names on backup table
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-14 08:46:46 +00:00
Joas Schilling 56644bb15e Update autoloader
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-14 08:46:45 +00:00
Côme Chilliet f2204af7b2 Fix user_ldap migration for long DNs support
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-14 08:46:44 +00:00
Côme Chilliet 85f5fe6dda Move duplicated code to a base class for group_mapping migrations
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
2022-01-14 08:46:44 +00:00
Côme Chilliet d6d5f3d2f3 Split dropTable and createTable in two migrations
It is not possible to drop and create the same table in one migration

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-14 08:46:43 +00:00
Côme Chilliet 4b40402821 Fix primary key change in user_ldap migration
Use a backup table to copy the data, drop table and recreate it with
 correct primary key, then copy the data back and drop the backup table.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-14 08:46:42 +00:00
John Molakvoæ 7ba126c00f Implement multibucket shift for ObjectStore
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-01-14 08:39:49 +01:00
Nextcloud bot 1ead55e45c [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-14 02:28:34 +00:00
Nextcloud bot b756fdbb78 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-13 02:27:01 +00:00
Nextcloud bot 9fe8dbda33 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-12 02:27:25 +00:00
Nextcloud bot 4a140589a7 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-11 02:27:32 +00:00
Nextcloud bot 1089e79d2e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-10 02:26:59 +00:00
Nextcloud bot e68f251dd1 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-09 02:26:48 +00:00
Nextcloud bot d2ab218f08 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-08 02:26:50 +00:00
Nextcloud bot 25678996b2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-07 02:28:30 +00:00
Côme Chilliet 84c4f8530b Merge pull request #30269 from nextcloud/backport/29523/stable20
[stable20] Support LDAP dns longer than 255 characters
2022-01-06 11:28:18 +01:00
Côme Chilliet 8001bc38ea Fix CI for mysql 5.6
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-06 10:11:44 +01:00
Nextcloud bot e6fab4288b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-06 02:28:47 +00:00
Nextcloud bot d37f0c84a2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-05 02:28:09 +00:00
Nextcloud bot d9df9456cf [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-04 02:28:00 +00:00
Nextcloud bot ec5ace6795 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-03 02:28:09 +00:00
Nextcloud bot 34495b5a84 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-01 02:27:35 +00:00
Nextcloud bot 3e03ef4b0c [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-31 02:28:00 +00:00
Louis a0a78158ad Merge pull request #30342 from nextcloud/backport/29329/stable20
[stable20] fix potential unwarranted memberships in nested groups from LDAP
2021-12-30 14:12:06 +01:00
Arthur Schiwon 55a27ead50 fix potential unwarranted memberships in nested groups from LDAP
- the issue was present only when using PHP based resolving of nested
  group members. Normally nested members are common in AD (and Samba4) and
  are resolved per LDAP_MATCHING_RULE_IN_CHAIN by default
- resolving nested members is recursive
- when the cache entry was created it happend for intermediate groups, too,
  containing members from the parent group
- the check was added to only cache the root group with its members
- a runtime cache stores intermediate ldap read results


Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-12-30 10:25:14 +00:00
Nextcloud bot d1d4c167df [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-30 02:28:31 +00:00
Nextcloud bot 901e8cac0a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-28 02:28:05 +00:00
Nextcloud bot 31b02ef9d8 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-27 02:27:41 +00:00
Nextcloud bot e06dafeeb6 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-25 02:27:46 +00:00
Nextcloud bot 38d59d7e9e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-24 02:29:39 +00:00
Nextcloud bot 8e3a1d166d [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-23 02:28:15 +00:00
Nextcloud bot 4e6a83e697 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-22 02:28:35 +00:00
Nextcloud bot 04b336a442 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-21 02:28:21 +00:00
Nextcloud bot 5170a6f2ca [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-20 02:30:13 +00:00
Nextcloud bot 41c7f3adba [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-19 02:29:46 +00:00
Nextcloud bot e29e86f1b0 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-18 02:27:55 +00:00
Nextcloud bot d5ef0ebc64 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-17 02:29:21 +00:00
Nextcloud bot 334e9f0519 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-16 02:28:15 +00:00
Nextcloud bot 7a94af34b1 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-15 02:28:20 +00:00
Côme Chilliet 5a2b7fbc46 Adapt execute function name for stable21
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-14 16:51:53 +01:00
Côme Chilliet 2b1bb599f1 Bump user_ldap version to make sure the migration runs
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-14 16:51:42 +01:00
Côme Chilliet e2d861313f Add missing copyright headers in migration steps
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-14 16:51:01 +01:00
Côme Chilliet e3d541bf32 Use clearer names for variables
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-14 16:50:55 +01:00
Côme Chilliet a51e366b0a Add an index for directory_uuid as well
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-14 16:50:49 +01:00
Côme Chilliet 2a726a33e8 Make sure that hash function returns a string
The documentation says it can return false, and even if that is highly
 unlikely for sha256, better safe than sorry.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-14 16:50:42 +01:00
Côme Chilliet 2aa748b782 Add the columns and alter the index in Version1010Date20200630192842
This is to ensure new installations do not need to go through migration
 history.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-14 16:50:35 +01:00
Côme Chilliet 0680271155 Fixes in migration step
We cannot set ldap_dn_hash column as notnull because it is empty for
 existing users before postSchemaChange is called

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-14 16:50:23 +01:00
Côme Chilliet c22c7fa7a4 Put back length check to have a clear error
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-14 16:50:17 +01:00
Côme Chilliet e5c8ea4f5d Fixed migration step for user_ldap
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-14 16:50:09 +01:00
Joas Schilling 462b421cdb Fix variable names
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-14 16:50:02 +01:00
Côme Chilliet 2ca7f31cbf Change column names to ldap_dn and ldap_dn_hash and add migration
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-14 16:49:55 +01:00
Côme Chilliet 3d8d4f8c1b Support LDAP dns longer than 255 characters
Adds an ldap_full_dn column to store the dn, and only store a sha256
 hash in the ldap_dn which is shorter and can be indexed without
 trouble.
Migration still needs to be implemented.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-14 16:49:31 +01:00
Nextcloud bot 5d54f65fd8 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-14 02:28:24 +00:00
Nextcloud bot bb7ec46126 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-13 02:28:12 +00:00
Nextcloud bot e4a9a72203 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-12 02:28:46 +00:00
Nextcloud bot 229724485e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-11 02:27:57 +00:00
John Molakvoæ cd02f3aee2 Merge pull request #30179 from nextcloud/backport/30168/stable20 2021-12-10 08:47:08 +01:00
Nextcloud bot 8044168d2d [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-10 02:27:50 +00:00
John Molakvoæ a8cdffa95c Allow to delete non-migrated previews instead of moving them
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-12-09 23:09:18 +00:00
Nextcloud bot b625b5bdc6 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-09 02:29:55 +00:00
Nextcloud bot e020446835 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-08 02:29:14 +00:00
Nextcloud bot a7de08612f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-07 02:40:29 +00:00
Nextcloud bot 822e28b88c [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-06 02:30:56 +00:00
Nextcloud bot 4a377abbf1 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-05 02:30:51 +00:00
Nextcloud bot 3229ca5660 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-04 02:31:13 +00:00
Nextcloud bot 5aa0a19e42 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-03 02:29:40 +00:00
Nextcloud bot 102ed86e52 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-02 02:29:42 +00:00
Nextcloud bot 607b043b4f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-01 02:31:20 +00:00
Nextcloud bot 960a933754 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-30 02:26:51 +00:00
John Molakvoæ b9753b22d3 Merge pull request #29955 from nextcloud/fix/20-is-EOL 2021-11-29 16:45:05 +01:00
John Molakvoæ 9aac463ea9 Delete update-psalm-baseline.yml 2021-11-29 15:56:01 +01:00
Nextcloud bot 4ea9f932c2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-29 02:25:38 +00:00
Nextcloud bot 05ca0ee5ad [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-28 02:24:14 +00:00
Nextcloud bot d1e21c0b00 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-27 02:26:28 +00:00
Nextcloud bot b2f75e2d51 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-26 02:46:41 +00:00
Nextcloud bot ec8484f224 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-25 02:25:32 +00:00
Nextcloud bot 934f04d4d8 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-24 02:26:25 +00:00
Nextcloud bot 89e392ad07 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-23 02:26:31 +00:00
Nextcloud bot 237a297135 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-22 02:46:03 +00:00
Nextcloud bot 03bf0d85e3 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-21 02:25:56 +00:00
Nextcloud bot a1e714723e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-20 02:42:36 +00:00
Nextcloud bot 4ebc733b70 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-19 02:38:47 +00:00
Christoph Wurst abfab44663 Explicitly allow some routes without 2FA
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-11-18 13:40:40 +01:00
Nextcloud bot 183a03830d [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-18 02:26:16 +00:00
Nextcloud bot 438e3d79e9 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-17 02:46:05 +00:00
Nextcloud bot d229a3abfa [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-16 02:24:48 +00:00
Louis a4c26f6d44 Merge pull request #29630 from nextcloud/dependabot/composer/build/integration/stable20/behat/behat-approx-3.10.0
Update behat/behat requirement from ~3.7.0 to ~3.10.0 in /build/integration
2021-11-15 13:46:31 +01:00
Nextcloud bot f8edadfbcd [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-15 02:24:58 +00:00
Nextcloud bot 71d6316e2e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-14 02:26:10 +00:00
Nextcloud bot 6909cfab99 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-13 02:26:18 +00:00
Nextcloud bot 77a2c06a26 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-12 02:23:24 +00:00
Arthur Schiwon 50221f94ab bump last version digit for rebuild
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-11-11 16:08:05 +01:00
blizzz bb04b67c39 Merge pull request #29669 from nextcloud/backport/29664/stable20
[stable20] Fix updating with apps
2021-11-11 16:07:24 +01:00
Joas Schilling b89e548879 Fix updating with apps
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-11 13:51:02 +00:00
Nextcloud bot f77bd4360c [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-11 02:23:36 +00:00
blizzz d2c539a9ab Merge pull request #29627 from nextcloud/version/20.0.14/final
20.0.14
2021-11-10 20:30:39 +01:00
dependabot[bot] fe1b589cf4 Update behat/behat requirement in /build/integration
Updates the requirements on [behat/behat](https://github.com/Behat/Behat) to permit the latest version.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.7.0...v3.10.0)

---
updated-dependencies:
- dependency-name: behat/behat
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-10 14:20:09 +00:00
Arthur Schiwon a552adf88a 20.0.14
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-11-10 14:47:27 +01:00
Nextcloud bot a1c6278247 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-10 02:24:57 +00:00
Nextcloud bot 1a3b144652 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-09 03:26:56 +00:00
Nextcloud bot c8d2e4b14d [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-08 02:33:35 +00:00
Nextcloud bot 8054db8f28 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-07 02:23:00 +00:00
Nextcloud bot 65942f837a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-06 02:23:09 +00:00
Nextcloud bot b648ad65fc [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-05 02:23:25 +00:00
John Molakvoæ 333199dd9b Merge pull request #29548 from nextcloud/backposkjnldsv/update-psalm-baseline-20 2021-11-04 13:39:11 +01:00
John Molakvoæ eed8bb7393 Add branch-suffix to update-psalm-baseline PR creation
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-11-04 11:43:54 +01:00
John Molakvoæ 0a64de5c8a [stable20] Update update-psalm-baseline workflow
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-11-04 11:05:02 +01:00
John Molakvoæ aab3d8fac9 Merge pull request #29540 from nextcloud/version/20.0.14/rc1 2021-11-04 09:22:48 +01:00
John Molakvoæ 7e8c3d7779 Merge pull request #29290 from nextcloud/backport/28768/stable20 2021-11-04 09:21:03 +01:00
John Molakvoæ 7a8b12ef10 Merge pull request #29505 from nextcloud/backport/29465/stable20 2021-11-04 09:19:47 +01:00
John Molakvoæ 1cb613bbfa Merge pull request #29417 from nextcloud/backport/27440/stable20 2021-11-04 09:19:38 +01:00
John Molakvoæ b06e32af26 Merge pull request #29314 from nextcloud/backport/29180/stable20 2021-11-04 09:19:18 +01:00
John Molakvoæ 72bd10fab7 Merge pull request #29095 from nextcloud/backport/29075/stable20 2021-11-04 09:18:04 +01:00
John Molakvoæ 31f30d54c2 Merge pull request #29072 from nextcloud/backport/29056/stable20 2021-11-04 09:17:45 +01:00
Arthur Schiwon 2814de5715 20.0.14 RC1
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-11-03 18:42:32 +01:00
Nextcloud bot 76b076d4d5 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-03 02:24:07 +00:00
Nextcloud bot e70ab5a768 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-02 02:22:44 +00:00
Arthur Schiwon 5220d7b4a0 update CRL
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-11-01 11:57:38 +01:00
Nextcloud bot fe1a64abae [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-01 02:23:09 +00:00
Nextcloud bot fb59aac4f3 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-31 02:22:29 +00:00
Nextcloud bot 8897e13bf2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-30 02:22:45 +00:00
acsfer 8925839f08 Update Tests 2021-10-30 00:20:42 +02:00
acsfer 4f5ef75d82 Tests update 2021-10-30 00:20:42 +02:00
acsfer 023c060305 Handle files with is_file instead of file_exists
Should fix things like `fread(): read of 8192 bytes failed with errno=21 Is a directory`
2021-10-30 00:20:42 +02:00
Côme Chilliet 349f4f6263 Fix Access constructor call
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-10-29 09:03:12 +00:00
Côme Chilliet 07c9dc0e4e Use Psr\Log\LoggerInterface where it can easily be used in user_ldap
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-10-29 09:03:12 +00:00
Côme Chilliet 63f29cac4b Fix two mistakes in previous migration to LoggerInterface in OCA\User_LDAP\Access
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-10-29 09:03:12 +00:00
Côme Chilliet 3f8ea18b45 Use Psr\Log\LoggerInterface in OCA\User_LDAP\Access
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-10-29 09:03:12 +00:00
Côme Chilliet 355bf52508 Avoid PHP errors when the LDAP attribute is not found
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-10-29 09:03:12 +00:00
Nextcloud bot e48efef351 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-29 02:22:51 +00:00
Julius Härtl 2835f62410 Merge pull request #29457 from nextcloud/backport/29454/stable20 2021-10-28 09:29:40 +02:00
Nextcloud bot a463d51bf4 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-28 02:23:23 +00:00
Joas Schilling c363479279 Detect mimetype by content only with content
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-27 13:47:20 +00:00
John Molakvoæ 882f2ab2ed Merge pull request #26630 from nextcloud/backport/25189/stable20 2021-10-27 09:59:48 +02:00
Nextcloud bot 7ffcd0f6d9 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-27 02:24:06 +00:00
John Molakvoæ ccdf898b50 Merge pull request #29441 from nextcloud/backport/stable20/26841 2021-10-26 16:46:59 +02:00
Julius Härtl 076a72238b Move to combined files entrypoint
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-10-26 10:02:41 +02:00
Joas Schilling 0e41175c5c Fix "No entries in this …" template
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-26 09:54:29 +02:00
Julius Härtl a2669b71f0 Implement local filtering in file list
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-10-26 09:54:23 +02:00
Nextcloud bot a0aebf71b2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-26 02:23:26 +00:00
Lukas Reschke 0f9e090f0c Merge pull request #29429 from nextcloud/fix/user_status_enumeration_20
Backport #29260: Respect user enumeration settings in user status lists
2021-10-25 14:53:55 +02:00
Carl Schwan 2a4e92dcbd Merge pull request #29291 from nextcloud/fix/unable-to-login
[stable20] Fix unable to login errors due to file system not being initialized
2021-10-25 13:11:10 +02:00
Carl Schwan 6e7094bcb6 Merge pull request #29426 from nextcloud/backport-icewind-streams-extra-fixes-for-0.7.2
Extra fixes needed for icewind/streams update to 0.7.2
2021-10-25 12:46:19 +02:00
Jonas Meurer f8719bce2f Add integration tests for user_status API
Signed-off-by: Jonas Meurer <jonas@freesources.org>
2021-10-25 10:11:17 +02:00
Jonas Meurer 50a25748c0 Respect user enumeration settings in user status lists
So far, the functions to find user statuses listed didn't respect user
enumeration settings (`shareapi_allow_share_dialog_user_enumeration`
and `shareapi_restrict_user_enumeration_to_group` core app settings).

Fix this privacy issue by returning an empty list in case
`shareapi_allow_share_dialog_user_enumeration` is unset or
`shareapi_restrict_user_enumeration_to_group` is set.

In the long run, we might want to return users from common groups if
`shareapi_restrict_user_enumeration_to_group` is set. It's complicated
to implement this in a way that scales, though. See the discussion at
https://github.com/nextcloud/server/pull/27879#pullrequestreview-753655308
for details.

Also, don't register the user_status dashboard widget at all if
`shareapi_allow_share_dialog_user_enumeration` is unset or
`shareapi_restrict_user_enumeration_to_group` is set.

Fixes: #27122

Signed-off-by: Jonas Meurer <jonas@freesources.org>
2021-10-25 10:10:14 +02:00
Vincent Petry 80dca60858 Extra fixes needed for icewind/streams update to 0.7.2
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-10-25 09:36:48 +02:00
Daniel ea92f783ac Merge pull request #29387 from nextcloud/backport/28997/stable20
[stable20] Scheduling plugin not updating responding attendee status
2021-10-25 08:56:33 +02:00
Nextcloud bot c4c6539f83 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-25 02:22:48 +00:00
Daniel Kesselberg d0eb977611 Update attendence for external users
For local users it's possible to select their calendar via the principal url and first update their own attendance status.
External users have no calendar event hence the recipient is the organizer.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-10-24 20:23:36 +02:00
Anna Larch 91da66a378 Scheduling plugin not updating responding attendee status take two
Signed-off-by: Anna Larch <anna@nextcloud.com>
2021-10-24 20:23:36 +02:00
MichaIng 8faaeda027 Merge pull request #29421 from nextcloud/backport/29400/stable20
[stable20] fixes an undefined index when getAccessList returns an empty array
2021-10-24 20:18:23 +02:00
Nextcloud bot c45316f61b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-24 02:22:49 +00:00
Arthur Schiwon 916b2e7164 fixes an undefined index when getAccessList returns an empty array
- [] is a valid return value that should be honored as having no access

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-10-23 12:53:23 +00:00
Daniel d7f9017038 Merge pull request #29396 from nextcloud/backport/24856/stable20
[stable20] Add whitelist for apps inside of the server repo
2021-10-23 14:23:16 +02:00
Nextcloud bot 449b430fc3 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-23 02:23:01 +00:00
Julius Härtl b6018271ee Add whitelist for apps inside of the server repo
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-10-22 20:03:02 +00:00
Julius Härtl 3e113eac2b Merge pull request #29388 from nextcloud/backport/29375/stable20 2021-10-22 20:13:03 +02:00
Julius Härtl 7811b38768 Make calendar schedule options translatable
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-10-22 10:38:14 +00:00
Vincent Petry e82157da9e Merge pull request #29366 from nextcloud/backport/29362/stable20
[stable20] Fix security issues when copying groupfolder with advanced ACL
2021-10-22 09:56:40 +02:00
Nextcloud bot 85de792b74 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-22 02:22:27 +00:00
Carl Schwan bd6b9e2dd1 Fix security issues when copying groupfolder with advanced ACL
Using advanced ACL, it is possible that an user has access to a
directory but not to a subdirectory, so the copying use
Common::copyFromStorage instead of Local::copyFromStorage.

Fix https://github.com/nextcloud/groupfolders/issues/1692

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-10-21 16:34:41 +00:00
acsfer d8ff7eadc6 Simplify :) 2021-10-21 07:36:22 +00:00
acsfer d845791968 Replace file_exists() method by is_file() 2021-10-21 07:36:22 +00:00
acsfer f902cfaffe Get filesize() if file_exists()
Should make sense.
2021-10-21 07:36:22 +00:00
Nextcloud bot 595d21c922 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-21 02:24:44 +00:00
Nextcloud bot 5534aa02f2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-20 02:43:31 +00:00
Vincent Petry 220004cf58 Merge pull request #29192 from nextcloud/backport/29080/stable20
[stable20] [21] generate a better optimized query for path prefix search filters
2021-10-19 16:45:27 +02:00
Vincent Petry 888b462043 Merge pull request #29297 from nextcloud/update-icewind-0.7.5-stable20
Update 3rdparty ref
2021-10-19 14:45:30 +02:00
Vincent Petry 3ca183df4d Merge pull request #29298 from nextcloud/files-external-icewind-streams-0.7.5-stable20
Bump icewind/streams from 0.7.3 to 0.7.5 in files_external
2021-10-19 14:43:44 +02:00
Joas Schilling b0f4d1984b Merge pull request #29303 from nextcloud/backport/29259/stable20
[stable20] Fix app upgrade
2021-10-19 13:36:38 +02:00
Robin Appelman f1b4d99481 cast ints
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-19 09:52:07 +00:00
Robin Appelman 343e4f35b7 handle the cache where a cache entry with the correct path has already been recreated
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-19 09:52:07 +00:00
Robin Appelman 4d499ece3c also repair storage id
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-19 09:52:07 +00:00
Robin Appelman cc98758237 add command to repair broken filesystem trees
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-19 09:52:07 +00:00
John Molakvoæ 66c615a146 Merge pull request #28971 from nextcloud/backport/28876/stable20 2021-10-19 11:13:19 +02:00
John Molakvoæ f8f4aa26ad Merge pull request #29181 from nextcloud/backport/29028/stable20 2021-10-19 11:11:14 +02:00
Joas Schilling d3dcde7ed9 Fix app upgrade
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-19 08:50:37 +02:00
Nextcloud bot 85ee6b4a76 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-19 02:23:18 +00:00
Vincent Petry 6b4ab2fe2e Bump icewind/streams from 0.7.3 to 0.7.5 in files_external
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-10-18 15:48:11 +02:00
Vincent Petry d94e92a963 Update 3rdparty ref
For icewind/streams 0.7.1 to 0.7.5 update

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-10-18 15:41:25 +02:00
Robin Appelman ff1029e8ef [21] generate a better optimized query for path prefix search filters
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-18 15:39:24 +02:00
Carl Schwan 51bff1f93b Fix unable to login errors due to file system not being initialized
This unifies the getStorageInfo with the stable21 and later branches and
fix a login problems sometimes encountered.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-10-18 10:24:57 +02:00
Nextcloud bot 8f041ca575 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-18 02:25:12 +00:00
Nextcloud bot d486d9c07e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-17 02:22:28 +00:00
Nextcloud bot 392a2ef0fc [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-16 02:23:49 +00:00
Daniel 400da8564d Merge pull request #29158 from nextcloud/backport/24185/stable20
[stable20] Properly handle folder deletion on external s3 storage
2021-10-15 11:38:28 +02:00
Daniel 4a15484710 Merge pull request #29253 from nextcloud/backport/29248/stable20
[stable20] Fix background scan doc in config
2021-10-15 10:46:13 +02:00
Vincent Petry 29cbc934fb Fix background scan doc in config
The background scanner only processes entries with size < 0

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-10-15 08:15:54 +00:00
Nextcloud bot cfdbe717c9 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-15 02:26:31 +00:00
blizzz 561c5bdf65 Merge pull request #29223 from nextcloud/backport/29214/stable20
[stable20] Don't setup the filesystem to check for a favicon we don't use anyway
2021-10-14 12:52:04 +02:00
Joas Schilling 790d6a5ff7 Merge pull request #29205 from nextcloud/backport/26688/stable20
[stable20] Add proper message to created share not found
2021-10-14 10:07:04 +02:00
Nextcloud bot b174357bb6 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-14 02:22:54 +00:00
Joas Schilling dc53aa4db0 Don't setup the filesystem to check for a favicon we don't use anyway
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-13 20:32:20 +00:00
Joas Schilling c8c203b527 Merge pull request #29198 from nextcloud/backport/29020/stable20
[stable20] Keep group restrictions when reenabling apps after an update
2021-10-13 22:24:39 +02:00
Christoph Wurst 90b0e82c51 Merge pull request #29219 from nextcloud/backport/29136/stable20
[stable20] Add documentation for files_no_background_scan
2021-10-13 19:52:38 +02:00
Daniel Kesselberg 8b7890966c Add documentation for files_no_background_scan
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-10-13 16:02:37 +00:00
Joas Schilling e642653a33 Keep group restrictions when reenabling apps after an update
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-13 14:15:42 +02:00
John Molakvoæ (skjnldsv) 259b6571ca Default message for ShareNotFound exception
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-10-13 09:48:12 +00:00
John Molakvoæ (skjnldsv) 191cc1d560 Add proper message to created share not found
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-10-13 09:48:12 +00:00
Nextcloud bot 13fc105138 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-13 02:23:04 +00:00
Bjoern Schiessle 60e6e06231 add 'supported'-label to all supported apps, also if they are not downloaded yet
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2021-10-12 11:47:17 +00:00
Nextcloud bot 4a3b1bdc0f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-12 02:24:06 +00:00
MichaIng c1207c6e6e Merge pull request #29167 from nextcloud/backport/29164/stable20
[stable20] Don't further setup disabled users when logging in with apache
2021-10-12 02:14:13 +02:00
MichaIng b91dc51f6c Merge pull request #29166 from nextcloud/backport/29122/stable20
[stable20] Tokens without password should not trigger changed password invalidation
2021-10-11 17:13:05 +02:00
Joas Schilling a6069d75c6 Merge pull request #29131 from nextcloud/backport/27886/stable20
[stable20] Keep pw based auth tokens valid when pw-less login happens
2021-10-11 15:33:43 +02:00
Joas Schilling a1c4c7fb8a Don't further setup disabled users when logging in with apache
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-11 15:12:41 +02:00
Julius Härtl 2377fdd8a9 Tokens without password should not trigger changed password invalidation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-10-11 12:39:53 +00:00
Julius Härtl d97fc4e3da Make sure that a empty directory can still be deleted when copied from another storage
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-10-11 08:01:03 +00:00
Julius Härtl e08a8bb92f Delete object to cleanup leftover of paths when removing directories
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-10-11 08:01:03 +00:00
Nextcloud bot 6bd85614df [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-11 02:23:00 +00:00
Nextcloud bot ecf0681885 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-10 02:21:43 +00:00
Nextcloud bot 2ce07cd93f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-09 02:39:56 +00:00
Tobias Assmann b52ebf5224 add spaces around operators
Signed-off-by: Tobias Assmann <tobias.assmann@ecsec.de>
2021-10-08 08:14:52 +02:00
Tobias Assmann 3dc6f0671a draft to prevent the invalidation of pw based authn tokens on a pw less login
Signed-off-by: Tobias Assmann <tobias.assmann@ecsec.de>
2021-10-08 08:14:49 +02:00
Nextcloud bot 4b5a653878 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-08 02:23:46 +00:00
Daniel c84ca47a3c Merge pull request #29098 from nextcloud/backport/29083/stable20
[stable20] Update the certificate bundle
2021-10-07 12:27:36 +02:00
Daniel Kesselberg 651fc1f28b Update the certificate bundle
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-10-07 09:37:32 +02:00
Nextcloud bot 005162d87a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-07 02:26:00 +00:00
acsfer e6a646c071 Fix path of file_get_contents 2021-10-06 15:04:58 +00:00
MichaIng 02955c88d8 Merge pull request #29085 from nextcloud/backport/29082/stable20
[stable20] Add a few sensitive config keys
2021-10-06 13:29:37 +02:00
Julien Veyssier 0690c601c9 consider some config keys under 'objectstore_multibucket' as sensitive
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2021-10-06 07:52:10 +00:00
Nextcloud bot 79a032cb5f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-06 02:21:29 +00:00
blizzz 031c89ae52 adjust to old db interfaces
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-10-05 13:02:07 +02:00
Louis 7e6f57962a Merge pull request #29069 from nextcloud/backport/stable20/25569
[stable20] file-upload: Correctly handle error responses for HTTP2
2021-10-05 10:50:05 +02:00
Nextcloud bot 0858c38c03 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-05 02:22:37 +00:00
Joas Schilling b9fe00aa96 Allow "TwoFactor Nextcloud Notifications" to pull the state of the 2FA again
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-04 19:14:29 +02:00
Jakub Onderka 7ab3efcc55 file-upload: Correctly handle error responses for HTTP2
Signed-off-by: Jakub Onderka <ahoj@jakubonderka.cz>
2021-10-04 18:55:40 +02:00
Nextcloud bot 295f0a4063 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-04 02:26:47 +00:00
Daniel 3967772a9f Merge pull request #29048 from nextcloud/backport/29044/stable20
[stable20] Change output format of Psalm to Github
2021-10-03 20:18:05 +02:00
MichaIng 31796d53c5 [stable20] Change output format of Psalm to Github
Manual backport of https://github.com/nextcloud/server/pull/29044

Signed-off-by: MichaIng <micha@dietpi.com>
2021-10-03 19:52:15 +02:00
Nextcloud bot 1554a7595f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-03 02:26:48 +00:00
Nextcloud bot 341aa006bc [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-02 02:26:43 +00:00
Nextcloud bot 43db32f49d [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-01 02:26:38 +00:00
Nextcloud bot f4380d9cc1 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-30 02:30:57 +00:00
blizzz 43a0a9a321 Merge pull request #28986 from nextcloud/version/20.0.13/final
20.0.13
2021-09-29 22:10:21 +02:00
szaimen 7303c09de0 Merge pull request #29000 from nextcloud/backport/28995/stable20
[stable20] Fix redirect during initial setup
2021-09-29 18:55:26 +02:00
Louis Chemineau 072d4bb0d0 Prevent empty base URL during installation
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-09-29 15:43:28 +00:00
Arthur Schiwon b894531211 20.0.13
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-29 11:38:00 +02:00
Nextcloud bot d63f6d8c18 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-29 02:26:32 +00:00
Nextcloud bot 0bb49b4493 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-28 02:25:48 +00:00
Arthur Schiwon e76211fdad ensure that user and group IDs in LDAP's tables are also max 64chars
- limitation by core tables (e.g. sharing), IDs are always 64chars
- when longer group IDs were requested they are hashed (does not affect
  displaynames)

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-27 17:59:52 +02:00
blizzz ff475146c7 Merge pull request #28946 from nextcloud/backport/28905/stable20
[stable20] explicitly close source stream on object store upload even if count…
2021-09-27 11:45:46 +02:00
szaimen dc4240ea02 Merge pull request #28964 from nextcloud/backport/28853/stable20
[stable20] Don't allow to change activity settings that don't work
2021-09-27 10:41:33 +02:00
Joas Schilling 5608dbbf4c Don't allow to change activity settings that don't work
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-09-27 06:24:25 +00:00
Nextcloud bot 4109a2eeee [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-26 02:27:49 +00:00
Nextcloud bot a018f9e87e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-25 02:27:04 +00:00
MichaIng eae7b69e61 Merge pull request #28951 from nextcloud/backport/28916/stable20
[stable20] fix caching of objectsid searches
2021-09-24 22:07:21 +02:00
Arthur Schiwon e1cac915e7 fix caching of objectsid searches
- store result when no name could be retrieved, too
- cached value is not an array, was treated wrongly

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-24 15:11:42 +00:00
Daniel Kesselberg e47903d3ea explicitly close source stream on object store upload even if countwrapper isn't needed
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-09-24 11:40:50 +00:00
Nextcloud bot d3ab9f2785 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-24 02:27:12 +00:00
blizzz 785515a2da Merge pull request #28936 from nextcloud/version/20.0.13/rc1
20.0.13 RC1
2021-09-23 12:30:05 +02:00
blizzz 4945199825 Merge pull request #28930 from nextcloud/3rdparty-20
[stable20] Bump 3rdparty ref
2021-09-23 11:42:17 +02:00
blizzz 8b095ce98b Merge pull request #28789 from nextcloud/backport/23065/stable20
[stable20] Fix null displayname crash as described in #21885
2021-09-23 10:11:09 +02:00
blizzz 8687bec176 Merge pull request #27407 from nextcloud/backport/24966/stable20
[stable20] avoid fread on directories and unencrypted files
2021-09-23 10:05:05 +02:00
Arthur Schiwon 2fee44a3b2 20.0.13 RC1
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-23 09:55:55 +02:00
Nextcloud bot 7a34dd4a97 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-23 02:30:13 +00:00
Lukas Reschke 45366a1140 Add Spomsky
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-22 17:01:58 +02:00
Lukas Reschke cd25119897 [stable20] Bump 3rdparty ref
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-22 16:21:10 +02:00
Nextcloud bot c30bcfa6a3 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-22 02:27:08 +00:00
MichaIng f99b048d94 Merge pull request #28908 from nextcloud/backport/28802/stable20
[stable20] Support seeking also from the end of file on S3 storage
2021-09-21 19:41:10 +02:00
kesselb 49157ca502 Merge pull request #28921 from nextcloud/backport/28918/stable20
[stable20] Use IRoomMetadata as source of truth for supported room types
2021-09-21 18:41:42 +02:00
Richard Steinmetz a56af8d654 Use IRoomMetadata as source of truth for supported room types
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2021-09-21 16:26:30 +00:00
Nextcloud bot 4dbf0658fa [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-21 02:27:38 +00:00
Pauli Järvinen 50729e2693 Support seeking also from the end of file on S3 storage
The PR https://github.com/nextcloud/server/pull/20033 added support
for `fseek` for  the S3 storage backend. However, the seek mode SEEK_END
was left out that time. This PR fills this gap.

Signed-off-by: Pauli Järvinen <pauli.jarvinen@gmail.com>
2021-09-20 18:13:04 +00:00
blizzz ceca64ca2e Merge pull request #28902 from nextcloud/backport/28868/stable20
[stable20] Update CRL due to revoked twofactor_email.crt
2021-09-20 17:45:36 +02:00
Vincent Petry 23a2344e48 Merge pull request #28897 from nextcloud/backport/28889/stable20
[stable20] Fall back to full file for video previews
2021-09-20 13:54:57 +02:00
Arthur Schiwon 78c1f33d0a Update CRL due to revoked twofactor_email.crt
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-20 11:27:57 +00:00
Vincent Petry d98a296b05 Fall back to full file for video previews
If the first 5 MB are not enough to grab a useful frame for the
thumbnail preview, fall back to reading the full file.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-09-20 09:34:50 +00:00
Nextcloud bot 247c53a7b1 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-20 02:26:11 +00:00
Nextcloud bot 6562d5ca0a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-19 02:26:09 +00:00
MichaIng c7371ed011 Merge pull request #28848 from nextcloud/backport/28285/stable20
[stable20] l10n: ignore packed js files from TX sync
2021-09-18 09:21:03 +02:00
dependabot[bot] 66f84b6943 Merge pull request #28886 from nextcloud/dependabot/npm_and_yarn/stable20/vue-clipboard2-0.3.3 2021-09-18 02:52:14 +00:00
Nextcloud bot b13f25e02f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-18 02:29:12 +00:00
dependabot[bot] 023b8d6042 Bump vue-clipboard2 from 0.3.2 to 0.3.3
Bumps [vue-clipboard2](https://github.com/Inndy/vue-clipboard2) from 0.3.2 to 0.3.3.
- [Release notes](https://github.com/Inndy/vue-clipboard2/releases)
- [Changelog](https://github.com/Inndy/vue-clipboard2/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Inndy/vue-clipboard2/compare/v0.3.2...v0.3.3)

---
updated-dependencies:
- dependency-name: vue-clipboard2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-09-18 01:06:53 +00:00
MichaIng b594b619bb Merge pull request #28880 from nextcloud/backport/28872/stable20
[stable20] Fix files view change and undefined currentFileList
2021-09-18 02:00:30 +02:00
John Molakvoæ 58b144d139 Fix files view change and undefined currentFileList
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-09-17 19:59:35 +00:00
Nextcloud bot 8f5b6b8386 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-17 02:28:37 +00:00
Robin Appelman c7ab27c28d Merge pull request #28820 from nextcloud/backport/24113/stable20
[stable20] extend cache events
2021-09-16 14:08:51 +00:00
Robin Appelman c0b701f7f1 make event constructor backwards compatible just in case
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-09-16 15:14:01 +02:00
Nextcloud bot a5b5e53b07 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-16 02:29:10 +00:00
rakekniven e8083e7072 l10n: ignore packed js files from TX sync
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-09-15 14:14:22 +00:00
Nextcloud bot d719a6082a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-15 02:28:28 +00:00
John Molakvoæ 607bdfd36d Merge pull request #28833 from nextcloud/backport/28774/stable20
[stable20] Do not cache file ids in FileSystemTags inside group folders
2021-09-14 18:07:01 +02:00
Richard Steinmetz 3aa21120bc Do not cache file ids in FileSystemTags inside group folders
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2021-09-14 14:12:39 +00:00
Nextcloud bot fefcd8652a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-14 02:31:11 +00:00
Lukas Reschke 4d0af347cd Merge pull request #28818 from nextcloud/backport/28728/stable20
[stable20] Add database ratelimiting backend
2021-09-13 18:38:30 +02:00
Lukas Reschke cb9d8cc50f Merge pull request #28812 from nextcloud/stable20-bump-refs
[stable20] Bump 3rdparty ref
2021-09-13 18:04:35 +02:00
Robin Appelman 1ed2550281 update @since for backport
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-09-13 18:01:28 +02:00
Robin Appelman 5e8e252a64 code style and dispatchTyped
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-09-13 15:56:44 +00:00
Robin Appelman e9234782a2 rename cache event to follow new naming standards
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-09-13 15:56:42 +00:00
Robin Appelman 11e81b340d extend cache events
- adds cache remove event
- expose storage id in event
- emit events during cache move

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-09-13 15:56:41 +00:00
Lukas Reschke 20c1ba6f4e Regenerate autoloader
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-13 17:23:49 +02:00
Lukas Reschke 201bf52c04 Add database ratelimiting backend
In case no distributed memory cache is specified this adds
a database backend for ratelimit purposes.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-13 17:23:49 +02:00
Vincent Petry 0cfbc41ab7 Merge pull request #28382 from nextcloud/backport/28318/stable20
[stable20] Make "name" column nullable for workflows
2021-09-13 12:11:16 +02:00
Lukas Reschke 9153bc07b9 [stable20] Bump 3rdparty ref
Includes https://github.com/nextcloud/3rdparty/pull/796 and https://github.com/nextcloud/3rdparty/pull/788

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-13 11:45:17 +02:00
Lukas Reschke 20b6ad2c6f Merge pull request #28808 from nextcloud/stable20-bump-ref
[stable20] Bump 3rdparty reference
2021-09-13 11:21:42 +02:00
Lukas Reschke cfdf1f3a5d [stable20] Bump 3rdparty reference
Contains https://github.com/nextcloud/3rdparty/pull/785 and https://github.com/nextcloud/3rdparty/pull/789

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-13 10:10:45 +02:00
Nextcloud bot 60def66208 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-13 02:28:51 +00:00
Nextcloud bot 0219ba9d3a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-12 02:28:55 +00:00
dependabot[bot] fe3dbebcd3 Merge pull request #28799 from nextcloud/dependabot/npm_and_yarn/stable20/vue-clipboard2-0.3.2 2021-09-11 23:03:59 +00:00
dependabot[bot] dd95d30650 Bump vue-clipboard2 from 0.3.1 to 0.3.2
Bumps [vue-clipboard2](https://github.com/Inndy/vue-clipboard2) from 0.3.1 to 0.3.2.
- [Release notes](https://github.com/Inndy/vue-clipboard2/releases)
- [Changelog](https://github.com/Inndy/vue-clipboard2/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Inndy/vue-clipboard2/compare/v0.3.1...v0.3.2)

---
updated-dependencies:
- dependency-name: vue-clipboard2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2021-09-11 22:20:36 +00:00
Nextcloud bot 5e41542e38 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-11 02:28:15 +00:00
Pytal b4ae248d5b Merge pull request #28783 from nextcloud/backport/28767/stable20
[stable20] Dashboard - fix touch layout
2021-09-10 10:56:20 -07:00
Pytal 11a54c7b33 Merge pull request #28787 from nextcloud/backport/28377/stable20
[stable20] Scan the shared external storage source on access
2021-09-10 10:24:51 -07:00
John Molakvoæ a79ffaba48 Return proper watcher if SharedStorage originates from ExternalMount 2021-09-10 15:27:39 +02:00
Tom Grant a67fcf09a8 Fix indentation error
Signed-off-by: tgrant <tom.grant760@gmail.com>
2021-09-10 10:47:31 +00:00
tgrant adec0af30e Fix null displayname crash as described in #21885
Signed-off-by: tgrant <tom.grant760@gmail.com>
2021-09-10 10:47:31 +00:00
szaimen b4e4f4c87a Merge pull request #28771 from nextcloud/backport/28754/stable20
[stable20] Fix trashbin files view sticky action bar
2021-09-10 11:09:35 +02:00
szaimen 4494734180 Dashboard - fix touch layout
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2021-09-10 08:24:50 +00:00
John Molakvoæ (skjnldsv) e71ce6f659 Return proper watcher if SharedStorage originates from ExternalMount
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-09-10 08:19:09 +00:00
Nextcloud bot 3174caddae [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-10 02:36:20 +00:00
Simounet 6dc519753c Fix trashbin files view sticky action bar
Signed-off-by: Simounet <contact@simounet.net>
2021-09-09 11:05:10 +00:00
Nextcloud bot 1d9b502729 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-09 02:28:25 +00:00
kesselb 48f3c19292 Merge pull request #28750 from nextcloud/backport/28692/stable20
[stable20] Send attendence links to required and optinal attendees of an event without an RSVP
2021-09-08 19:10:38 +02:00
Nextcloud bot 51bf981141 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-08 02:28:01 +00:00
Anna Larch 2f3dc4ea11 Send Invitation to Attendees with ROLE=REQ-PARTICIPANT
Signed-off-by: Anna Larch <anna@nextcloud.com>
2021-09-07 14:11:08 +00:00
Lukas Reschke a92d1d13eb Merge pull request #28742 from nextcloud/backport/28725/stable20
[stable20] Remove 2FA exemption from PublicPage annotation
2021-09-07 12:46:33 +02:00
Lukas Reschke 65b4c6f3f5 Adjust tests
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-07 08:52:29 +00:00
Lukas Reschke fde61e8a22 Remove 2FA exemption from PublicPage annotation
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-07 08:52:29 +00:00
Lukas Reschke e7f66922e6 Merge pull request #28736 from nextcloud/backport/28726/stable20
[stable20] Check if SVG path is valid
2021-09-07 09:49:50 +02:00
Lukas Reschke 89d9dada0f Resolve absolute path in tests
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-07 06:39:13 +00:00
Lukas Reschke 430e286ab6 Fix codestyle
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-07 06:39:12 +00:00
Lukas Reschke 40f158503c Check if SVG path is valid
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-07 06:39:11 +00:00
Nextcloud bot 07c1e2ad72 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-07 02:28:42 +00:00
Nextcloud bot 9a3b2931c8 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-06 02:28:13 +00:00
Nextcloud bot afa23e307b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-05 02:27:45 +00:00
Nextcloud bot c27b32b43b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-04 02:26:39 +00:00
Jasper Knockaert 8466c53e00 fix even more brackets
Signed-off-by: Jasper Knockaert jasper@knockaert.nl
2021-09-03 13:42:10 +00:00
Jasper Knockaert ac650a13d3 fix brakcets 2021-09-03 13:42:10 +00:00
Jasper Knockaert df3cd0f89e consolidation of boolean expression 2021-09-03 13:42:10 +00:00
Jasper Knockaert 76059da341 Update EncryptionTest.php 2021-09-03 13:42:09 +00:00
Jasper Knockaert ca501a6d88 2nd attempt to fix tests 2021-09-03 13:42:09 +00:00
Jasper Knockaert 0af8a0c8f0 attemtp to fix test 2021-09-03 13:42:09 +00:00
Jasper Knockaert 1bca62fa1a avoid fread on directories and unencrypted files
Reworking the logic in order to first check the filecache and only then reading the fileheader.
This in order to solve #21578.
2021-09-03 13:42:09 +00:00
szaimen 864dd06f0b Merge pull request #28672 from nextcloud/backport/28660/stable20
[stable20] Fix position of search bar
2021-09-03 15:30:45 +02:00
Nextcloud bot f506d45437 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-03 02:28:58 +00:00
Nextcloud bot fee066a416 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-02 02:27:41 +00:00
Carl Schwan 25a49143a4 Fix position of search bar
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2021-08-31 18:13:24 +00:00
MichaIng 3c7f6429b3 Merge pull request #28655 from nextcloud/backport/28332/stable20
[stable20] Only recommand for php-sodium on >= PHP 7.4
2021-08-31 11:57:46 +02:00
Carl Schwan 33cfc996b7 Only recommand for php-sodium on >= PHP 7.4
This is because php-sodium will solve the missing PASSWORD_ARGON2I
constant problem only on >= php 7.4, previously argon2 wasn't part of
the standard extension and was disabled on Centos/RHEL.

So installing php-sodium on php 7.2 for example wouldn't hide the
message. Tested on Fedora with php 7.4, Centos 7 with php 7.2,
Centos 8 with php 7.2 and openSUSE with php 7.4.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-08-31 07:11:15 +00:00
Nextcloud bot 66c65d4997 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-31 02:27:16 +00:00
szaimen 1de35a9fe5 Merge pull request #27991 from goyome/goyome-stable20-group-shares-limit
Manual backport of "No limit in the number of group shares" #27875
2021-08-31 03:47:13 +02:00
Nextcloud bot 9d303ae2ee [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-30 02:27:31 +00:00
Nextcloud bot 8335abdd10 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-29 02:27:38 +00:00
Nextcloud bot f33e95ce40 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-28 02:53:53 +00:00
Nextcloud bot ea195b04d4 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-27 02:26:49 +00:00
MichaIng 84d924534f Merge pull request #28605 from nextcloud/backport/28373/stable20
[stable20] Fix encrypted version to 0 when finding unencrypted file
2021-08-26 23:42:42 +02:00
Louis Chemineau c638ebd7a5 Merge branch 'stable20' of github.com:nextcloud/server into stable20 2021-08-26 16:07:58 +02:00
Vincent Petry 610e76555d Unregister enc stream wrapper for any exception
This prevents side effects in tests by properly cleaning up
even with expected exceptions.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-08-26 14:26:50 +02:00
Vincent Petry 32034af8c4 Fix encrypted version to 0 when finding unencrypted file
Whenever the command is run and a "legacy cipher" seems to be detected
when the legacy option is disabled, it's highly likely that the file is
actually unencrypted but the database contains a encrypted version
higher than 0 for some reason.

The command now detects this case and automatically sets the encrypted
version to 0 so that the file can be read again.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-08-26 14:26:40 +02:00
Louis 5de7803b8e Merge pull request #28598 from nextcloud/backport/28262/stable20
[stable20] Fix setting up 2FA providers when 2FA is enforced and bc are generated
2021-08-26 14:20:05 +02:00
Louis Chemineau 96369e14a9 Merge branch 'stable20' of github.com:nextcloud/server into stable20 2021-08-25 17:21:11 +02:00
Christoph Wurst c2d175a710 Fix setting up 2FA providers when 2FA is enforced and bc are generated
When a user has backup codes generated and got their 2FA enforced then
they should be able to set up TOTP and similar providers during the
login.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-08-25 12:44:13 +00:00
Pytal ab63c2e3d6 Merge pull request #28578 from nextcloud/backport/28574/stable20
[stable20] Log exception message during failed ownership transfer share restore
2021-08-24 17:59:31 -07:00
Christoph Wurst 3108f13253 Log exception message during failed ownership transfer share restore
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-08-24 10:04:03 +00:00
Nextcloud bot 0c9b022592 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-24 02:26:36 +00:00
Nextcloud bot 330ff407ef [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-22 02:26:18 +00:00
MichaIng ff6310598e Merge pull request #28547 from nextcloud/backport/28532/stable20
[stable20] Do not load versions tab view if the files app is not available
2021-08-21 02:08:47 +02:00
Julius Härtl a9b86de2f0 Do not load versions tab view if the files app is not available
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2021-08-20 21:00:59 +00:00
kesselb 7d1e95b7d9 Merge pull request #28538 from nextcloud/backport/28452/stable20
[stable20] Set alias for result of cast column function
2021-08-20 18:56:55 +02:00
Daniel Kesselberg 7b5ed40da9 Set alias for result of cast column function
On OCI an expression like to_char(events) end up as $row['to_char(events)'] in the query result.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-08-20 13:46:23 +00:00
Joas Schilling 64ff73c78a Merge pull request #28453 from nextcloud/backport/28303/stable20
[stable20] UnifiedSearchController: strip webroot from URL before finding a route
2021-08-20 11:13:16 +02:00
Nextcloud bot bb77903e5a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-20 02:26:44 +00:00
John Molakvoæ 33751f9735 Merge pull request #28524 from nextcloud/backport/28504/stable20
[stable20] Properly log errors in Movie previews generation
2021-08-19 23:27:21 +02:00
John Molakvoæ (skjnldsv) 5a26b3ff0c Properly log errors in Movie previews generation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-08-19 18:06:56 +00:00
Julius Härtl 10582585ea Merge pull request #28516 from nextcloud/backport/28512/sable20
[stable20] Output exception in cron
2021-08-19 18:34:04 +02:00
Louis Chemineau 0f713ee278 Output exception in cron
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-08-19 15:31:12 +02:00
Nextcloud bot 2f60cba17c [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-19 02:26:14 +00:00
Julius Härtl 94ccd10224 Merge pull request #28491 from nextcloud/backport/28413/stable20
[stable20] Emit an error log when the app token login name does not match
2021-08-18 16:34:52 +02:00
Christoph Wurst face6b174b Emit an error log when the app token login name does not match
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-08-18 12:16:47 +00:00
Nextcloud bot 33a5e7897d [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-18 02:26:24 +00:00
Louis be490f62ec Merge pull request #28471 from nextcloud/backport/28464/stable20
[stable20] Only trap E_ERROR in session handling
2021-08-17 15:29:50 +02:00
Julius Härtl cd01d63e49 Only trap E_ERROR in session handling
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-08-17 10:12:58 +00:00
Nextcloud bot 2305519757 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-17 02:27:34 +00:00
Pytal 0dfef2447c Merge pull request #28448 from nextcloud/backport/28211/stable20
[stable20] Improve auto expiration hint for trashbin and file versions
2021-08-16 18:16:47 -07:00
Jonas Meurer b08215e4cc Use IURLGenerator function to get value of \OC::$WEBROOT global
Signed-off-by: Jonas Meurer <jonas@freesources.org>
2021-08-16 13:11:50 +00:00
Jonas Meurer c53fa3e3d8 UnifiedSearchController: strip webroot from URL before finding a route
This should fix route matching in UnifiedSearchController on setups with
Nextcloud in a subfolder (webroot).

Fixes: #24144
Signed-off-by: Jonas Meurer <jonas@freesources.org>
2021-08-16 13:11:49 +00:00
szaimen e7bf15dafe Improve auto expiration hint
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: Pytal <24800714+Pytal@users.noreply.github.com>
2021-08-16 10:24:27 +00:00
Nextcloud bot 3542bed2ed [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-16 02:26:45 +00:00
dependabot[bot] 998442b534 Merge pull request #28186 from nextcloud/dependabot/npm_and_yarn/stable20/file-loader-6.1.1 2021-08-15 15:39:20 +00:00
dependabot[bot] fb83201bf5 Bump file-loader from 6.1.0 to 6.1.1
Bumps [file-loader](https://github.com/webpack-contrib/file-loader) from 6.1.0 to 6.1.1.
- [Release notes](https://github.com/webpack-contrib/file-loader/releases)
- [Changelog](https://github.com/webpack-contrib/file-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/file-loader/compare/v6.1.0...v6.1.1)

---
updated-dependencies:
- dependency-name: file-loader
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-15 14:59:44 +00:00
MichaIng aec579b0cd Merge pull request #28387 from nextcloud/backport/25605/stable20
[stable20] dont show trusted proxy warning when the proxy and remote are both localhost
2021-08-15 12:35:26 +02:00
MichaIng 03613b2666 Merge pull request #28414 from nextcloud/backport/28062/stable20
[stable20] Gracefully handle smb acls for users without a domain
2021-08-15 12:33:04 +02:00
Nextcloud bot 51a3f08c41 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-15 02:26:31 +00:00
Nextcloud bot 7dfa8e9834 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-14 02:27:07 +00:00
Richard Steinmetz b8a55117f9 Gracefully handle smb acls for users without a domain
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2021-08-13 08:41:07 +00:00
Nextcloud bot c49bbc23de [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-13 02:27:01 +00:00
Vincent Petry ffe7467187 Make "name" column nullable in workflow operations
The "name" column is now unused and the code is always inserting an
empty string. While this works with most databases, Oracle complains
because an empty string is equivalent to null.

To fix this, the column definition is changed to allow null values now.

Also added some logging in case of database exceptions, because without
this nothing would be logged to detect the above problem.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-08-12 14:11:11 +02:00
Julius Härtl 1b2e852f6c Merge pull request #28362 from nextcloud/backport/28220/stable20 2021-08-12 12:37:15 +02:00
Nextcloud bot 77e124c7f2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-12 02:27:46 +00:00
Robin Appelman 6061a28967 dont show trusted proxy warning when the proxy and remote are both localhost
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-08-11 21:12:42 +00:00
Robin Appelman a4cdebec62 fix Folder->getById() when a single storage is mounted multiple times
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-08-11 09:05:44 +02:00
Nextcloud bot 6ada5b93a7 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-11 02:27:08 +00:00
Nextcloud bot 1c31440aed [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-10 02:32:21 +00:00
szaimen d47a26d9a8 Merge pull request #28355 from nextcloud/backport/28352/stable20
[stable20] Change the concurrent upload limit to less than 10
2021-08-09 18:02:42 +02:00
szaimen 8d3b7ebc78 Change the concurrent upload limit to less than 10
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-08-09 08:34:03 +00:00
Nextcloud bot 2d9fa1fc56 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-09 02:27:13 +00:00
Nextcloud bot c608217acc [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-08 02:22:08 +00:00
dependabot[bot] f29045fa29 Merge pull request #28339 from nextcloud/dependabot/npm_and_yarn/stable20/vue-loader-15.9.8 2021-08-07 03:27:08 +00:00
Nextcloud bot 463a5e98b3 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-07 02:27:52 +00:00
dependabot[bot] 01c3454dc7 Bump vue-loader from 15.9.7 to 15.9.8
Bumps [vue-loader](https://github.com/vuejs/vue-loader) from 15.9.7 to 15.9.8.
- [Release notes](https://github.com/vuejs/vue-loader/releases)
- [Changelog](https://github.com/vuejs/vue-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-loader/compare/v15.9.7...v15.9.8)

---
updated-dependencies:
- dependency-name: vue-loader
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-07 02:14:05 +00:00
Nextcloud bot cf230cffd8 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-06 02:27:24 +00:00
Nextcloud bot f118db8f7a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-05 02:27:38 +00:00
Julius Härtl ccb4502350 Merge pull request #28305 from nextcloud/backport/28202/stable20 2021-08-04 08:50:09 +02:00
Nextcloud bot 61cc3990ea [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-04 02:27:04 +00:00
Christopher Ng c818894705 Build
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-08-04 00:31:54 +00:00
Christopher Ng c92453f31a Remove chunkhash
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 63c3b9a4cc)
2021-08-04 00:25:21 +00:00
John Molakvoæ bc73a9c66e Merge pull request #28248 from nextcloud/bug/noid/comments-autocompletion 2021-08-03 17:30:37 +02:00
John Molakvoæ a09a7fc6ae Merge pull request #28300 from nextcloud/version/22.0.12/Final 2021-08-03 17:11:56 +02:00
kesselb 6c27354dae Merge pull request #28289 from nextcloud/backport/28259/stable20
[stable20] Check that php was compiled with argon2 support or that the php-sodium extensions is installed
2021-08-03 12:43:48 +02:00
John Molakvoæ (skjnldsv) 88e51300f1 20.0.12
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-08-03 08:47:52 +02:00
Nextcloud bot 41e27c73d6 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-03 02:26:41 +00:00
Carl Schwan a5ae0524e8 Check that php was compiled with argon2 support or that the php-sodium
extensions is installed

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-08-02 09:19:10 +00:00
Nextcloud bot 78a3a01911 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-02 07:57:02 +00:00
Nextcloud bot 23a5b86922 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-02 07:36:02 +00:00
Vincent Petry b59353b0e1 Merge pull request #28241 from nextcloud/backport/28235/stable20
[stable20] dont apply jail search filter is on the root
2021-07-30 10:17:04 +02:00
John Molakvoæ 40c90ace71 Merge pull request #28187 from nextcloud/dependabot/npm_and_yarn/stable20/marked-1.1.2 2021-07-30 08:15:31 +02:00
Christopher Ng 15d0369e53 Build
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-07-29 22:06:40 +00:00
Daniel Kesselberg cc35d298f7 Fix autocompletion for usernames in comments
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-07-29 23:15:12 +02:00
Robin Appelman b3e238c731 dont apply jail search filter is on the root
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-07-29 14:40:00 +00:00
Robin Appelman f23a053f82 add test for searching within a "root jail"
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-07-29 14:39:59 +00:00
dependabot[bot] 0c0388b828 Bump marked from 1.1.1 to 1.1.2
Bumps [marked](https://github.com/markedjs/marked) from 1.1.1 to 1.1.2.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js)
- [Commits](https://github.com/markedjs/marked/compare/v1.1.1...v1.1.2)

---
updated-dependencies:
- dependency-name: marked
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-07-29 13:27:39 +02:00
John Molakvoæ f1d96edd6f Merge pull request #28159 from nextcloud/version/20.0.12/RC1
20.0.12 RC1
2021-07-29 10:17:05 +02:00
Louis e8753a5734 Merge pull request #28191 from nextcloud/backport/28173/stable20
[stable20] Fix variable override in file view
2021-07-29 10:06:32 +02:00
dependabot[bot] 103a0beee3 Merge pull request #28032 from nextcloud/dependabot/npm_and_yarn/stable20/sass-loader-10.0.5 2021-07-28 21:55:02 +00:00
dependabot[bot] 840013a17d Bump sass-loader from 10.0.2 to 10.0.5
Bumps [sass-loader](https://github.com/webpack-contrib/sass-loader) from 10.0.2 to 10.0.5.
- [Release notes](https://github.com/webpack-contrib/sass-loader/releases)
- [Changelog](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/sass-loader/compare/v10.0.2...v10.0.5)

---
updated-dependencies:
- dependency-name: sass-loader
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-28 21:20:33 +00:00
MichaIng c26814740c Merge pull request #28224 from nextcloud/backport/27920/stable20
[stable20] Fix Files breadcrumbs being hidden even if there is enough space
2021-07-28 21:09:12 +02:00
Julien Veyssier 8c9392c290 refs #21263 round numbers when checking if breadcrumbs should be hidden
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2021-07-28 16:53:38 +00:00
dependabot[bot] 726f5afd7e Merge pull request #28207 from nextcloud/dependabot/npm_and_yarn/stable20/regenerator-runtime-0.13.9 2021-07-28 14:39:34 +00:00
Louis Chemineau f5d4846c14 Fix variabable override in file view
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-07-28 15:56:16 +02:00
dependabot[bot] 47a57f46f1 Bump regenerator-runtime from 0.13.7 to 0.13.9
Bumps [regenerator-runtime](https://github.com/facebook/regenerator) from 0.13.7 to 0.13.9.
- [Release notes](https://github.com/facebook/regenerator/releases)
- [Commits](https://github.com/facebook/regenerator/compare/regenerator-runtime@0.13.7...regenerator-runtime@0.13.9)

---
updated-dependencies:
- dependency-name: regenerator-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-28 15:35:30 +02:00
dependabot[bot] 319133b7e3 Merge pull request #28208 from nextcloud/dependabot/npm_and_yarn/stable20/url-loader-4.1.1 2021-07-28 08:31:23 +00:00
dependabot[bot] 4ebc2ab2cf Bump url-loader from 4.1.0 to 4.1.1
Bumps [url-loader](https://github.com/webpack-contrib/url-loader) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/webpack-contrib/url-loader/releases)
- [Changelog](https://github.com/webpack-contrib/url-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/url-loader/compare/v4.1.0...v4.1.1)

---
updated-dependencies:
- dependency-name: url-loader
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-07-28 07:45:23 +00:00
John Molakvoæ 7405603b85 Merge pull request #27701 from nextcloud/dependabot/npm_and_yarn/stable20/vue-and-vue-template-compiler-2.6.14 2021-07-28 09:43:04 +02:00
John Molakvoæ (skjnldsv) ae4b1ec1f7 20.0.12 RC1
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-07-28 09:12:14 +02:00
dependabot[bot] 1b0ce5f786 Bump vue and vue-template-compiler
Bumps [vue](https://github.com/vuejs/vue) and [vue-template-compiler](https://github.com/vuejs/vue). These dependencies needed to be updated together.

Updates `vue` from 2.6.12 to 2.6.14
- [Release notes](https://github.com/vuejs/vue/releases)
- [Commits](https://github.com/vuejs/vue/compare/v2.6.12...v2.6.14)

Updates `vue-template-compiler` from 2.6.12 to 2.6.14
- [Release notes](https://github.com/vuejs/vue/releases)
- [Commits](https://github.com/vuejs/vue/compare/v2.6.12...v2.6.14)

---
updated-dependencies:
- dependency-name: vue
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: vue-template-compiler
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-28 08:58:23 +02:00
John Molakvoæ 721b32c271 Merge pull request #27988 from nextcloud/dependabot/npm_and_yarn/stable20/nextcloud/vue-dashboard-1.0.1 2021-07-28 07:52:42 +02:00
dependabot[bot] d93a84c6c3 Bump @nextcloud/vue-dashboard from 1.0.0 to 1.0.1
Bumps [@nextcloud/vue-dashboard](https://github.com/nextcloud/nextcloud-vue-dashboard) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/nextcloud/nextcloud-vue-dashboard/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-vue-dashboard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-vue-dashboard/compare/v1.0.0...v1.0.1)

---
updated-dependencies:
- dependency-name: "@nextcloud/vue-dashboard"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-28 05:45:45 +00:00
Louis Chemineau b7e29701ad Fix variabable override in file view
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-07-27 14:01:28 +02:00
John Molakvoæ 90f50ae82c Add files via upload 2021-07-27 11:59:33 +02:00
John Molakvoæ 381863a08d Merge pull request #27965 from nextcloud/dependabot/npm_and_yarn/stable20/bootstrap-4.5.3 2021-07-27 11:51:20 +02:00
John Molakvoæ d4ba2a0422 Merge pull request #27924 from nextcloud/dependabot/npm_and_yarn/stable20/moment-timezone-0.5.33
Bump moment-timezone from 0.5.31 to 0.5.33
2021-07-27 11:50:54 +02:00
szaimen fc3df840c0 Merge pull request #28172 from nextcloud/backport/28166/stable20
[stable20] User management - Add icon to user groups
2021-07-26 21:20:50 +02:00
szaimen 971ac9322b User management - Add icon to user groups
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-26 20:51:00 +02:00
Julius Härtl d683c92241 Merge pull request #28125 from nextcloud/backport/28122/stable20
[stable20] Let memory limit set in tests fit the used amount
2021-07-22 22:50:13 +02:00
Julius Härtl 010ececec7 Let memory limit set in tests fit the used amount
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-07-22 16:46:52 +00:00
szaimen f0a7b96e90 Merge pull request #28111 from nextcloud/backport/28101/stable20
[stable20] Fix dark theme in file exists dialog
2021-07-22 13:54:20 +02:00
szaimen e93ef0c431 Fix dark theme in file exists dialog
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-22 10:44:25 +00:00
rakekniven c7334cfcca Merge pull request #28107 from nextcloud/Valdnet-patch-1
l10n: HTTP in capital letters
2021-07-22 11:05:07 +02:00
Valdnet 01e08b1b53 l10n: HTTP in capital letters
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-07-22 10:22:32 +02:00
John Molakvoæ cacde6d79d Merge pull request #28091 from nextcloud/backport/28082/stable20
[stable20] Sanitize more functions from the encryption app
2021-07-22 08:44:19 +02:00
szaimen 7bca72c0a4 Merge pull request #28096 from nextcloud/backport/27674/stable20
[stable20] hide download button for public preview of audio files
2021-07-21 22:47:32 +02:00
Lukas Reschke 4b9245324a Sanitize more functions from the encryption app
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-07-21 22:01:42 +02:00
Lukas Reschke a26a2a61a0 Merge pull request #28087 from nextcloud/backport/28078/stable20
[stable20] Improve provider check
2021-07-21 21:46:17 +02:00
Florian Storz f4e8cd29d0 Remove trailing whitespace from comment
Signed-off-by: Florian Storz <florian.storz@devlix.de>
2021-07-21 17:45:11 +00:00
Florian Storz 895a93bc32 Add comment linking to PR
PR contains discussion about the implementation with pros and cons

Signed-off-by: Florian Storz <florian.storz@devlix.de>
2021-07-21 17:45:10 +00:00
Florian Storz 4700f88291 hide download button for public preview of audio files
When the option to hide downloads was selected at public link creation, the download button can be hidden by the audio html attribute controlsList="nodownload"

Signed-off-by: Florian Storz <florian.storz@devlix.de>
2021-07-21 17:45:09 +00:00
Lukas Reschke f5dd0f232f Improve provider check
Check if there is a provider missing.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-07-21 13:29:47 +00:00
Lukas Reschke ab28f297b2 Merge pull request #28081 from nextcloud/backport/28077/stable20
[stable20] Disable HEIC image preview provider for performance concerns
2021-07-21 12:30:16 +02:00
tobiasKaminsky df4d8671a2 Disable HEIC image preview provider for performance concerns
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-07-21 08:36:07 +00:00
Pytal 831e5848c9 Merge pull request #28072 from nextcloud/backport/28015/stable20
[stable20] fix overlapping of elements in certain views
2021-07-20 21:25:10 -07:00
szaimen d43f7b76d0 fix overlapping of elements in certain views
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-20 21:07:51 +00:00
kesselb 412272ec10 Merge pull request #28054 from nextcloud/backport/28051/stable20
[stable20] Mask password for Redis and RedisCluster on connection failure
2021-07-20 22:58:27 +02:00
Carl Schwan 262fd0c2a8 Merge pull request #28065 from nextcloud/backport/27950/stable20
[stable20] Fix missing theming for login button
2021-07-20 17:13:21 +02:00
Carl Schwan d031c55dc1 Fix missing theming for login button
Close #27495

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-07-20 12:07:47 +00:00
Daniel Kesselberg 5705fc7be3 Mask password for Redis and RedisCluster on connection failure
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-07-19 23:11:40 +00:00
szaimen 7244026783 Merge pull request #28018 from nextcloud/backport/27997/stable20
[stable20] Update CRL due to revoked twofactor_nextcloud_notification.crt
2021-07-19 19:32:15 +02:00
Louis 05e30b4e46 Merge pull request #28045 from nextcloud/backport/27994/stable20
[stable20] Increase footer height for longer menus
2021-07-19 11:38:22 +02:00
szaimen c66e402c05 Increase footer padding for longer menus
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: Julius Härtl <jus@bitgrid.net>
2021-07-19 08:52:17 +00:00
Nextcloud bot f1ef43eaf1 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-07-19 02:25:48 +00:00
Nextcloud bot 5e44f96241 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-07-18 02:25:58 +00:00
dependabot[bot] 26d7586596 Bump bootstrap from 4.5.2 to 4.5.3
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.5.2 to 4.5.3.
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](https://github.com/twbs/bootstrap/compare/v4.5.2...v4.5.3)

---
updated-dependencies:
- dependency-name: bootstrap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-17 14:39:55 +00:00
MichaIng 08163aa398 Merge pull request #27985 from nextcloud/dependabot/npm_and_yarn/stable20/nextcloud/capabilities-1.0.4
Bump @nextcloud/capabilities from 1.0.2 to 1.0.4
2021-07-17 16:30:04 +02:00
dependabot[bot] 2353b2f72d Bump @nextcloud/capabilities from 1.0.2 to 1.0.4
Bumps [@nextcloud/capabilities](https://github.com/nextcloud/nextcloud-capabilities) from 1.0.2 to 1.0.4.
- [Release notes](https://github.com/nextcloud/nextcloud-capabilities/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-capabilities/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-capabilities/commits)

---
updated-dependencies:
- dependency-name: "@nextcloud/capabilities"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-07-17 13:54:25 +00:00
dependabot[bot] 87adfd8e44 Bump moment-timezone from 0.5.31 to 0.5.33
Bumps [moment-timezone](https://github.com/moment/moment-timezone) from 0.5.31 to 0.5.33.
- [Release notes](https://github.com/moment/moment-timezone/releases)
- [Changelog](https://github.com/moment/moment-timezone/blob/develop/changelog.md)
- [Commits](https://github.com/moment/moment-timezone/compare/0.5.31...0.5.33)

---
updated-dependencies:
- dependency-name: moment-timezone
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-17 13:52:44 +00:00
Nextcloud bot 615c665595 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-07-17 02:44:48 +00:00
Arthur Schiwon 0e12b7b2f5 Update CRL due to revoked twofactor_nextcloud_notification.crt
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-07-16 21:41:47 +00:00
szaimen ae426188ea Merge pull request #27897 from nextcloud/backport/27887/stable20
[stable20] make user status usable on mobile
2021-07-16 13:03:22 +02:00
szaimen 684b5d5a1e Merge pull request #28006 from nextcloud/backport/27980/stable20
[stable20] Improve notcreatable permissions hint
2021-07-16 12:25:33 +02:00
szaimen 0fa8398e65 make user status usable on mobile
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-16 09:47:35 +00:00
szaimen d955a3c26c Improve notcreatable permissions hint
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-16 09:02:24 +00:00
John Molakvoæ 04e6e38f0d Add files via upload 2021-07-16 09:12:34 +02:00
Nextcloud bot fd888a11b0 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-07-16 02:26:57 +00:00
Guillaume Colson 44f4023155 Update UserAddedToGroupListener.php
Signed-off-by: Guillaume COLSON <guillaume.colson@univ-lorraine.fr>
2021-07-15 15:09:09 +02:00
Nextcloud bot f93fb228e8 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-07-15 10:38:11 +00:00
Louis ebe2529713 Merge pull request #27984 from nextcloud/dependabot/npm_and_yarn/stable20/exports-loader-1.1.1
Bump exports-loader from 1.1.0 to 1.1.1
2021-07-15 11:11:52 +02:00
Julius Härtl 17f855429c Merge pull request #27646 from nextcloud/dependabot/npm_and_yarn/stable20/debounce-1.2.1
Bump debounce from 1.2.0 to 1.2.1
2021-07-15 08:39:51 +02:00
dependabot[bot] baea7c5b4a Bump exports-loader from 1.1.0 to 1.1.1
Bumps [exports-loader](https://github.com/webpack-contrib/exports-loader) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/webpack-contrib/exports-loader/releases)
- [Changelog](https://github.com/webpack-contrib/exports-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/exports-loader/compare/v1.1.0...v1.1.1)

---
updated-dependencies:
- dependency-name: exports-loader
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-07-15 06:30:11 +00:00
Julius Härtl 57d3f76d7d Merge pull request #27236 from nextcloud/dependabot/npm_and_yarn/stable20/url-search-params-polyfill-8.1.1
Bump url-search-params-polyfill from 8.1.0 to 8.1.1
2021-07-15 08:29:58 +02:00
Nextcloud bot 62175e034b [tx-robot] updated from transifex 2021-07-15 02:27:01 +00:00
dependabot[bot] eea3f2b36e Bump debounce from 1.2.0 to 1.2.1
Bumps [debounce](https://github.com/component/debounce) from 1.2.0 to 1.2.1.
- [Release notes](https://github.com/component/debounce/releases)
- [Changelog](https://github.com/component/debounce/blob/master/History.md)
- [Commits](https://github.com/component/debounce/compare/1.2.0...1.2.1)

---
updated-dependencies:
- dependency-name: debounce
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-15 01:39:23 +00:00
Pytal a60c00acc1 Merge pull request #27976 from nextcloud/backport/27973/stable20
[stable20] Fix regression in file sidebar
2021-07-14 15:00:20 -07:00
dependabot[bot] 69f567f93e Bump url-search-params-polyfill from 8.1.0 to 8.1.1
Bumps [url-search-params-polyfill](https://github.com/jerrybendy/url-search-params-polyfill) from 8.1.0 to 8.1.1.
- [Release notes](https://github.com/jerrybendy/url-search-params-polyfill/releases)
- [Commits](https://github.com/jerrybendy/url-search-params-polyfill/compare/v8.1.0...v8.1.1)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-14 21:52:19 +00:00
Julius Härtl 970e5d6d65 Merge pull request #27913 from nextcloud/fix/26113/stable20-dashboard-escaped-display-name
[stable20] Do not escape display name in dashboard welcome text
2021-07-14 21:42:33 +02:00
Julius Härtl 707ee8878d Merge pull request #27970 from nextcloud/enh/stable20-breadcrumb-detail-view-in-menu
[stable20] Show registered breadcrumb detail views in breadcrumb menu
2021-07-14 21:10:13 +02:00
Carl Schwan a3ee7dbcce Fix regression in file sidebar
See https://github.com/nextcloud/server/pull/27936

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-07-14 18:34:36 +00:00
Julien Veyssier 42903ca204 show breadcrumb detail view in breadcrumb menu
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2021-07-14 15:43:15 +02:00
MichaIng 02fc2cc51c Merge pull request #27754 from nextcloud/backport/27586/stable20
[stable20] Reset checksum when writing files to object store
2021-07-14 14:39:26 +02:00
Julius Härtl cc45043bba Merge pull request #27836 from nextcloud/dependabot/npm_and_yarn/stable20/dompurify-2.2.9
Bump dompurify from 2.2.8 to 2.2.9
2021-07-14 13:08:56 +02:00
dependabot[bot] 04f15c88b5 Bump dompurify from 2.2.8 to 2.2.9
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.2.8 to 2.2.9.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](https://github.com/cure53/DOMPurify/compare/2.2.8...2.2.9)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-14 12:32:24 +02:00
Nextcloud bot ccb4d9c6a6 [tx-robot] updated from transifex 2021-07-14 02:26:44 +00:00
MichaIng 9516e3a8a7 Merge pull request #27955 from nextcloud/backport/27936/stable20
[stable20] Fix svg icons disapearing in app navigation when text overflows
2021-07-14 01:54:07 +02:00
Carl Schwan 1e88f2343b Fix svg icons disapearing in app navigation when text overflows
The issue is caused by the icon being positionned with negative margins
and the `overflow: hidden` rule when hide the icon when the text
overflows. Remove positioning with negative margins. This was only
happening in Firefox.

This fix #23849

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-07-13 22:53:41 +00:00
Julien Veyssier 9e9054276b refs #26113 do not escape display name in dashboard welcome text
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-13 12:45:59 +00:00
szaimen 82cf1dd14d Merge pull request #27941 from nextcloud/backport/27867/stable20
[stable20] fix newfileMenu on public page
2021-07-13 14:35:20 +02:00
szaimen e15351408a fix newfileMenu on public page
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-13 11:55:43 +00:00
Julius Härtl 6345abe9a4 Merge pull request #27745 from nextcloud/backport/27739/stable20
[stable20] design fixes to app-settings button
2021-07-13 08:55:05 +02:00
Julius Härtl fe57e2547a Merge pull request #27895 from nextcloud/backport/27854/stable20 2021-07-13 08:51:38 +02:00
Nextcloud bot df35e4eddd [tx-robot] updated from transifex 2021-07-13 02:26:57 +00:00
Louis 9eff1cb1e7 Merge pull request #27232 from nextcloud/dependabot/npm_and_yarn/stable20/v-click-outside-3.1.2
Bump v-click-outside from 3.1.1 to 3.1.2
2021-07-12 14:23:35 +02:00
Nextcloud bot 5bf7e5b81d [tx-robot] updated from transifex 2021-07-12 02:25:56 +00:00
szaimen d5fc733a58 Merge pull request #27863 from nextcloud/backport/27835/stable20
[stable20] Cache images on browser
2021-07-11 18:48:39 +02:00
dependabot[bot] 9cf6d3d007 Bump v-click-outside from 3.1.1 to 3.1.2
Bumps [v-click-outside](https://github.com/ndelvalle/v-click-outside) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/ndelvalle/v-click-outside/releases)
- [Commits](https://github.com/ndelvalle/v-click-outside/compare/v3.1.1...v3.1.2)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-11 12:27:55 +02:00
Nextcloud bot dd26b3f14a [tx-robot] updated from transifex 2021-07-11 02:26:12 +00:00
Nextcloud bot 92075538ac [tx-robot] updated from transifex 2021-07-10 02:31:52 +00:00
Joas Schilling 97e8cfe32c Fix accessibility theme for guests
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-09 11:27:15 +00:00
szaimen 1029c85307 fix filepicker bug in dark mode
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-09 11:11:22 +00:00
Nextcloud bot 2378048386 [tx-robot] updated from transifex 2021-07-09 02:26:42 +00:00
Nextcloud bot bed022cf16 [tx-robot] updated from transifex 2021-07-08 02:27:08 +00:00
Pytal 30e740e846 Merge pull request #27858 from nextcloud/backport/27844/stable20
[stable20] Make search popup usable on mobile, too
2021-07-07 11:55:42 -07:00
acsfer f1b906bd14 Cache images on browser
Fix #26851
2021-07-07 17:16:25 +00:00
szaimen a328ed4e05 Make search popup usable on mobile, too
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-07 15:31:19 +00:00
Nextcloud bot 3257bca680 [tx-robot] updated from transifex 2021-07-07 02:26:28 +00:00
MichaIng 8de9a77fa0 Merge pull request #27224 from nextcloud/dependabot/npm_and_yarn/stable20/vue-router-3.4.9
Bump vue-router from 3.4.3 to 3.4.9
2021-07-07 00:11:59 +02:00
Pytal 24a19e1a4c Merge pull request #27829 from nextcloud/backport/27818/stable20
[stable20] Fix in locking cache check
2021-07-06 11:34:13 -07:00
dependabot[bot] a09d4ddcbf Bump vue-router from 3.4.3 to 3.4.9
Bumps [vue-router](https://github.com/vuejs/vue-router) from 3.4.3 to 3.4.9.
- [Release notes](https://github.com/vuejs/vue-router/releases)
- [Changelog](https://github.com/vuejs/vue-router/blob/dev/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-router/compare/v3.4.3...v3.4.9)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-06 18:04:00 +00:00
MichaIng 8a8f95e56c Fix in locking cache check
The intention obviously was to check whether $lockingCacheClass is defined, and existing class, and available. It was however checked whether the $distributedCacheClass is an existing class, which would have caused an exception already in the previous distributed cache check.

Signed-off-by: MichaIng <micha@dietpi.com>
2021-07-06 17:11:22 +00:00
Nextcloud bot 7da87a8624 [tx-robot] updated from transifex 2021-07-06 02:26:22 +00:00
Lukas Reschke 732cf383af Merge pull request #27804 from nextcloud/backport/27198/stable20
[stable20] Run s3 tests again
2021-07-05 15:04:29 +02:00
Julius Härtl 8da867de75 Use minio for s3 tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-07-05 10:01:32 +00:00
Julius Härtl 15cf02a784 Run s3 tests again
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-07-05 10:01:31 +00:00
Nextcloud bot 4a28b8e525 [tx-robot] updated from transifex 2021-07-05 02:25:55 +00:00
Nextcloud bot 2c560870f5 [tx-robot] updated from transifex 2021-07-04 02:25:59 +00:00
Nextcloud bot 088aefff36 [tx-robot] updated from transifex 2021-07-03 02:26:19 +00:00
Nextcloud bot 5fd817b155 [tx-robot] updated from transifex 2021-07-02 02:25:42 +00:00
Julius Härtl ae8373df1c Reset checksum when writing files to object store
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-07-01 15:38:17 +00:00
John Molakvoæ 3eb0ce9892 Merge pull request #27708 from nextcloud/version/20.0.11/final
20.0.11
2021-07-01 11:43:08 +02:00
John Molakvoæ 54106a647e Merge pull request #27108 from nextcloud/backport/27043/stable20
[stable20] fix return value of getStorageInfo when 'quota_include_external_storage' is enabled
2021-07-01 11:42:34 +02:00
szaimen e744d3e3db design fixes to app-settings button
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-01 09:23:36 +00:00
Nextcloud bot 40e2e0fcd6 [tx-robot] updated from transifex 2021-07-01 02:25:14 +00:00
Vincent Petry 03617b9470 Merge pull request #27728 from nextcloud/backport/27638/stable20
[stable20] Downstream encryption:fix-encrypted-version for repairing "bad signature" errors
2021-06-30 17:22:24 +02:00
Vincent Petry 5588199812 Prevent running FixEncryptedVersion without master key
Return an error when running occ encryption:fix-encrypted-version
when master key encryption is not enabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-06-30 12:26:42 +00:00
Vincent Petry 3b7e6ea8c8 Fix FixEncryptedVersionTest test
Fixed setup to use EncryptionTrait like other existing tests.
Fix expectations to not rely on side effects from previous test cases.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-06-30 12:26:41 +00:00
Vincent Petry 41424e0a57 Fix warnings in FixEncryptedVersion command
Fixed code warnings

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-06-30 12:26:39 +00:00
Vincent Petry 69b2a33801 Detect disabled signature check when reparing
When running occ encryption:fix-encrypted-version, detect whether the
setting 'encryption_skip_signature_check' is set and abort if it is,
because the repair cannot detect version mismatch errors with it
enabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-06-30 12:26:39 +00:00
Vincent Petry 08b94a5fcf Downstream FixEncryptedVersionTest
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-06-30 12:26:38 +00:00
Vincent Petry bb331fda9b Downstream encryption:fix-encrypted-version
For fixing "Bad signature" errors.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-06-30 12:26:37 +00:00
John Molakvoæ dc287450bb Merge pull request #27552 from nextcloud/backport/26571/stable20 2021-06-30 07:12:25 +02:00
Nextcloud bot c2cd52f498 [tx-robot] updated from transifex 2021-06-30 02:25:51 +00:00
Julius Härtl 5c8ddb6ee0 Handle single action unshare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-29 19:07:49 +02:00
Julius Härtl 355352d910 Only allow removing existing shares that would not be allowed due to reshare restrictions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-29 19:07:49 +02:00
Julius Härtl e298e7482d When changing the share owner, downgrade permissions where needed
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-29 19:01:10 +02:00
Julius Härtl 86ef3539ad Drop share if moved to a parent share that does not allow resharing
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-29 19:01:10 +02:00
Arthur Schiwon 0a368a6b82 20.0.11
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-29 13:06:27 +02:00
Pytal a5c9193bc9 Merge pull request #27651 from nextcloud/dependabot/npm_and_yarn/stable20/eslint-plugin-standard-4.0.2
Bump eslint-plugin-standard from 4.0.1 to 4.0.2
2021-06-28 09:01:54 -07:00
John Molakvoæ 45cea9f772 Merge pull request #27680 from nextcloud/backport/27675/stable20
[stable20] Validate the theming color also on CLI
2021-06-28 07:43:06 +02:00
Nextcloud bot f395c32e6a [tx-robot] updated from transifex 2021-06-28 02:25:31 +00:00
Nextcloud bot 826a848058 [tx-robot] updated from transifex 2021-06-27 02:26:01 +00:00
Nextcloud bot 803e8407c0 [tx-robot] updated from transifex 2021-06-26 02:26:05 +00:00
Joas Schilling 2f64ab3e08 Validate the theming color also on CLI
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-25 16:22:27 +00:00
Nextcloud bot 710544c257 [tx-robot] updated from transifex 2021-06-25 02:25:53 +00:00
dependabot[bot] fef52cf455 Bump eslint-plugin-standard from 4.0.1 to 4.0.2
Bumps [eslint-plugin-standard](https://github.com/standard/eslint-plugin-standard) from 4.0.1 to 4.0.2.
- [Release notes](https://github.com/standard/eslint-plugin-standard/releases)
- [Commits](https://github.com/standard/eslint-plugin-standard/compare/v4.0.1...v4.0.2)

---
updated-dependencies:
- dependency-name: eslint-plugin-standard
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-06-24 12:22:42 +00:00
Julius Härtl d4d35c83fb Merge pull request #27226 from nextcloud/dependabot/npm_and_yarn/stable20/p-queue-6.6.2
Bump p-queue from 6.6.1 to 6.6.2
2021-06-24 14:21:16 +02:00
blizzz eada1ee43b Merge pull request #27620 from nextcloud/version/20.0.11/rc1
20.0.11 RC1
2021-06-24 13:38:41 +02:00
dependabot[bot] 1d12ca7072 Bump p-queue from 6.6.1 to 6.6.2
Bumps [p-queue](https://github.com/sindresorhus/p-queue) from 6.6.1 to 6.6.2.
- [Release notes](https://github.com/sindresorhus/p-queue/releases)
- [Commits](https://github.com/sindresorhus/p-queue/compare/v6.6.1...v6.6.2)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-06-24 10:43:20 +00:00
Julius Härtl e794b75e7f Merge pull request #27639 from nextcloud/dependabot/npm_and_yarn/stable20/vue-loader-15.9.7
Bump vue-loader from 15.9.3 to 15.9.7
2021-06-24 12:30:39 +02:00
dependabot[bot] 06753b7084 Bump vue-loader from 15.9.3 to 15.9.7
Bumps [vue-loader](https://github.com/vuejs/vue-loader) from 15.9.3 to 15.9.7.
- [Release notes](https://github.com/vuejs/vue-loader/releases)
- [Changelog](https://github.com/vuejs/vue-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-loader/compare/v15.9.3...v15.9.7)

---
updated-dependencies:
- dependency-name: vue-loader
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-06-24 11:22:04 +02:00
Nextcloud bot 7bd283debe [tx-robot] updated from transifex 2021-06-24 02:25:41 +00:00
Arthur Schiwon 8edae42be6 update CA bundle
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-24 01:31:05 +02:00
blizzz 900474bd2f Merge pull request #27027 from nextcloud/backport/26852/stable20
[stable20] fix error when using CORS with no auth credentials
2021-06-24 00:14:08 +02:00
korelstar 9257171b3d fix error when using CORS with no auth credentials 2021-06-23 20:49:45 +02:00
Julius Härtl e0a576d210 Merge pull request #27297 from nextcloud/dependabot/npm_and_yarn/stable20/webpack-4.44.2
Bump webpack from 4.44.1 to 4.44.2
2021-06-23 19:29:23 +02:00
dependabot[bot] 8d33bdaec0 Bump webpack from 4.44.1 to 4.44.2
Bumps [webpack](https://github.com/webpack/webpack) from 4.44.1 to 4.44.2.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.44.1...v4.44.2)

Signed-off-by: dependabot[bot] <support@github.com>
2021-06-23 16:14:15 +00:00
blizzz 369cb6f252 Merge pull request #27016 from nextcloud/backport/26980-stable20
[stable20] Use parent wrapper to properly handle moves on the same source/target storage
2021-06-23 12:56:01 +02:00
Lukas Reschke 3b437a1c52 Merge pull request #27617 from nextcloud/backport/27610/stable20
[stable20] Throttle on public DAV endpoint
2021-06-23 12:38:06 +02:00
Arthur Schiwon d02edae5c2 20.0.11 RC1
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-23 10:46:01 +02:00
Lukas Reschke 376f94ea48 Reference correct private variable
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-23 07:39:39 +00:00
Lukas Reschke 37224e43a1 Throttle on public DAV endpoint
We should throttle whenever an invalid request is sent to the public WebDAV endpoint.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-23 07:39:39 +00:00
Nextcloud bot 5fd5ef739a [tx-robot] updated from transifex 2021-06-23 02:26:38 +00:00
Julius Härtl 1257b11600 Merge pull request #27247 from nextcloud/dependabot/npm_and_yarn/stable20/browserslist-4.16.6
[Security] Bump browserslist from 4.14.0 to 4.16.6
2021-06-22 20:08:34 +02:00
Lukas Reschke d969686d41 Merge pull request #27596 from nextcloud/stable20-backport-27532
[stable20] Properly cleanup entries of WebAuthn on user deletion
2021-06-22 15:48:50 +02:00
Lukas Reschke 5a1faab167 Remove throwing annotation
This class was just introduced in Nc 21.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-22 13:55:49 +02:00
Lukas Reschke 481715c8f8 Use execute instead of executeStatement
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-22 13:54:03 +02:00
Morris Jobke a0bd1800e8 Properly cleanup entries of WebAuthn on user deletion
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-06-22 13:46:28 +02:00
Nextcloud bot e13dd99bd9 [tx-robot] updated from transifex 2021-06-22 02:27:21 +00:00
dependabot-preview[bot] 2ae0bde50c Merge pull request #27570 from nextcloud/dependabot/npm_and_yarn/stable20/ws-7.5.0 2021-06-21 06:57:36 +00:00
Nextcloud bot 92452883a6 [tx-robot] updated from transifex 2021-06-21 02:27:02 +00:00
Nextcloud bot a024b6b359 [tx-robot] updated from transifex 2021-06-20 02:27:25 +00:00
Nextcloud bot 7f5bb741bb [tx-robot] updated from transifex 2021-06-19 02:46:40 +00:00
dependabot-preview[bot] 2be40fcea4 [Security] Bump ws from 7.3.1 to 7.5.0
Bumps [ws](https://github.com/websockets/ws) from 7.3.1 to 7.5.0. **This update includes security fixes.**
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](https://github.com/websockets/ws/compare/7.3.1...7.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-06-19 01:16:09 +00:00
Nextcloud bot 4ccc1e4c3e [tx-robot] updated from transifex 2021-06-18 02:27:23 +00:00
Nextcloud bot 51551e6ac4 [tx-robot] updated from transifex 2021-06-17 02:26:11 +00:00
John Molakvoæ 1bff199b4a Merge pull request #27523 from nextcloud/bug/noid/unreachable-check-query-builder
[stable20] Activate constraint check for oracle / pqsql also for 20
2021-06-16 17:18:33 +02:00
Daniel Kesselberg 3b510bf0f6 Activate constraint check for oracle / pqsql also for 20.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-06-16 14:28:07 +02:00
Nextcloud bot 703bffd096 [tx-robot] updated from transifex 2021-06-16 02:26:40 +00:00
Nextcloud bot 5ab296142f [tx-robot] updated from transifex 2021-06-15 02:28:28 +00:00
Nextcloud bot 9112f96871 [tx-robot] updated from transifex 2021-06-14 02:26:51 +00:00
Nextcloud bot dbf79de762 [tx-robot] updated from transifex 2021-06-13 02:26:28 +00:00
Nextcloud bot 2bcbc80759 [tx-robot] updated from transifex 2021-06-12 02:27:22 +00:00
Christoph Wurst f86beba171 Merge pull request #27456 from nextcloud/backport/27444/stable20
[stable20] Header must contain a colon
2021-06-11 08:26:56 +02:00
Nextcloud bot c800f379f4 [tx-robot] updated from transifex 2021-06-11 02:28:32 +00:00
acsfer e0cbd275aa Header must contain a colon 2021-06-10 08:23:05 +00:00
Nextcloud bot 904adcde67 [tx-robot] updated from transifex 2021-06-10 02:32:35 +00:00
Morris Jobke 4843d2c613 Merge pull request #27308 from nextcloud/backport/27062/stable20
[stable20] properly use limit and offset for search in Jail wrapper
2021-06-09 08:49:29 +02:00
Robin Appelman 464aeb065c properly use limit and offset for search in Jail wrapper
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-09 08:08:55 +02:00
Nextcloud bot 68ec34a8df [tx-robot] updated from transifex 2021-06-09 02:26:37 +00:00
Nextcloud bot f423da2851 [tx-robot] updated from transifex 2021-06-08 02:26:42 +00:00
Robin Appelman 9f62c8023d Merge pull request #27349 from nextcloud/backport/25280/stable20
[stable20] Set umask before operations that create local files
2021-06-07 19:37:02 +00:00
Joas Schilling b486855783 Skip the test if Imagick is misconfigured
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-07 20:56:42 +02:00
Joas Schilling ac5d4a8bfc Merge pull request #27412 from nextcloud/backport/27375/stable20
[stable20] Don't update statuses to offline again and again
2021-06-07 17:00:36 +02:00
Robin Appelman b92440ca0a improve type handling of Avatar::generateAvatarFromSv
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-07 16:55:40 +02:00
Joas Schilling 924f58c370 Don't update statuses to offline again and again
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-07 10:17:09 +00:00
Morris Jobke 0168bef570 Merge pull request #27325 from nextcloud/stable20-backport-27024
[stable20] Properly log expiration date removal in audit log
2021-06-07 11:17:00 +02:00
Morris Jobke ecb22392df Merge pull request #27183 from nextcloud/dependabot/npm_and_yarn/stable20/various
[stable20] Bump patch dependencies
2021-06-07 10:48:25 +02:00
Morris Jobke 16ae1e8c3c Merge pull request #27209 from nextcloud/backport/27199/stable20
[stable20] Use noreply@ as email address for share emails
2021-06-07 10:47:09 +02:00
Morris Jobke c8275117a4 Merge pull request #27337 from nextcloud/backport/27329/stable20
[stable20] Propagate throttling on OCS response
2021-06-07 10:43:36 +02:00
Morris Jobke b52dc4ace8 Merge pull request #27360 from nextcloud/backport/27354/stable20
[stable20] Escape filename in Content-Disposition
2021-06-07 10:38:42 +02:00
Nextcloud bot 88355b0713 [tx-robot] updated from transifex 2021-06-07 02:25:32 +00:00
Nextcloud bot c4271ebbe1 [tx-robot] updated from transifex 2021-06-06 02:26:24 +00:00
Nextcloud bot e50704f794 [tx-robot] updated from transifex 2021-06-05 02:28:56 +00:00
Robin Appelman 252268e4d2 Set umask before operations that create local files
this solves issues where "other php stuff" is messing with the umask

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-04 15:42:05 +02:00
Nextcloud bot cd4a538fa4 [tx-robot] updated from transifex 2021-06-04 02:28:37 +00:00
Nextcloud bot 15d6770393 [tx-robot] updated from transifex 2021-06-03 02:29:10 +00:00
Lukas Reschke c4fd3c5e9d Escape filename in Content-Disposition
We should escape all occurences of ' and \ in here.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-02 19:19:41 +00:00
Nextcloud bot 458feef3d4 [tx-robot] updated from transifex 2021-06-02 02:28:52 +00:00
Lukas Reschke 1d9e6ab6dd Propagate throttling on OCS response
The BaseResponse converter did not take over any throttling state from the DataResponse.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-01 19:44:31 +00:00
John Molakvoæ 8246290b34 Merge pull request #27319 from nextcloud/backport/27099/stable20
[stable20] Make user:report command scale
2021-06-01 14:10:38 +02:00
Roeland Jago Douma 8abe437755 Properly log expiration date removal in audit log
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-06-01 13:26:49 +02:00
Joas Schilling e7adbbf80d Make user:report command scale
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-01 08:38:16 +00:00
Nextcloud bot 438a4429e9 [tx-robot] updated from transifex 2021-06-01 02:28:44 +00:00
Nextcloud bot 7f5e9ff7fc [tx-robot] updated from transifex 2021-05-31 02:35:47 +00:00
Nextcloud bot d63a757092 [tx-robot] updated from transifex 2021-05-30 02:25:27 +00:00
dependabot-preview[bot] 6f874b7811 [Security] Bump browserslist from 4.14.0 to 4.16.6
Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.14.0 to 4.16.6. **This update includes a security fix.**
- [Release notes](https://github.com/browserslist/browserslist/releases)
- [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md)
- [Commits](https://github.com/browserslist/browserslist/compare/4.14.0...4.16.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-05-29 01:14:47 +00:00
Morris Jobke d1e5039890 Use noreply@ as email address for share emails
Fixes #26683

Before it used the instance name, which a) doesn't make sense to randomly guess email addresses and b) could contain characters that are not allowed in email addresses like spaces.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-05-28 11:44:09 +00:00
Nextcloud bot b7fbab8726 [tx-robot] updated from transifex 2021-05-28 02:27:40 +00:00
John Molakvoæ (skjnldsv) e6a1d0e6bd Npm build
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-05-27 10:56:15 +02:00
dependabot[bot] 3f26437678 Bump vuedraggable from 2.24.1 to 2.24.3
Bumps [vuedraggable](https://github.com/SortableJS/Vue.Draggable) from 2.24.1 to 2.24.3.
- [Release notes](https://github.com/SortableJS/Vue.Draggable/releases)
- [Commits](https://github.com/SortableJS/Vue.Draggable/commits/v2.24.3)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-27 10:39:04 +02:00
dependabot[bot] 66820c9ae2 Bump eslint-plugin-import from 2.22.0 to 2.22.1
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.22.0 to 2.22.1.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases)
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md)
- [Commits](https://github.com/benmosher/eslint-plugin-import/compare/v2.22.0...v2.22.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-27 10:38:57 +02:00
dependabot[bot] 902e3dc8e6 Bump autosize from 4.0.2 to 4.0.4
Bumps [autosize](https://github.com/jackmoore/autosize) from 4.0.2 to 4.0.4.
- [Release notes](https://github.com/jackmoore/autosize/releases)
- [Changelog](https://github.com/jackmoore/autosize/blob/master/changelog.md)
- [Commits](https://github.com/jackmoore/autosize/compare/4.0.2...4.0.4)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-27 10:38:43 +02:00
dependabot[bot] 444f473234 Bump clipboard from 2.0.6 to 2.0.8
Bumps [clipboard](https://github.com/zenorocha/clipboard.js) from 2.0.6 to 2.0.8.
- [Release notes](https://github.com/zenorocha/clipboard.js/releases)
- [Commits](https://github.com/zenorocha/clipboard.js/compare/v2.0.6...v2.0.8)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-27 10:38:11 +02:00
dependabot[bot] 4ab1a3b0d2 Bump dompurify from 2.2.2 to 2.2.8
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.2.2 to 2.2.8.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](https://github.com/cure53/DOMPurify/compare/2.2.2...2.2.8)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-27 08:17:28 +00:00
Nextcloud bot 2ded52519b [tx-robot] updated from transifex 2021-05-27 02:28:14 +00:00
Nextcloud bot 5fd1b719d7 [tx-robot] updated from transifex 2021-05-26 02:28:51 +00:00
Robin Appelman 4a5364a9b2 fix return value of getStorageInfo when 'quota_include_external_storage' is enabled
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-25 20:01:40 +00:00
Nextcloud bot c87c3710f2 [tx-robot] updated from transifex 2021-05-25 02:27:40 +00:00
Nextcloud bot 8be87861a2 [tx-robot] updated from transifex 2021-05-24 02:26:51 +00:00
Nextcloud bot 694454ca0d [tx-robot] updated from transifex 2021-05-23 02:26:09 +00:00
Nextcloud bot 7ffae790ef [tx-robot] updated from transifex 2021-05-22 02:27:38 +00:00
Nextcloud bot 3a9c6eef44 [tx-robot] updated from transifex 2021-05-21 02:28:17 +00:00
Nextcloud bot 2f8c2c335a [tx-robot] updated from transifex 2021-05-20 02:28:18 +00:00
Roeland Jago Douma a8d144a35b Merge pull request #27014 from nextcloud/backport/27000/stable20
[stable20] Harden apptoken check
2021-05-19 08:40:37 +02:00
Nextcloud bot 99788d3d06 [tx-robot] updated from transifex 2021-05-19 02:31:56 +00:00
Julius Härtl ccfd28cbc3 Use parent wrapper to properly handle moves on the same source/target storage
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-05-18 16:15:12 +02:00
Roeland Jago Douma 998bcd92c6 Harden apptoken check
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-18 13:10:51 +00:00
dependabot-preview[bot] 2bc106ae13 Merge pull request #26900 from nextcloud/dependabot/npm_and_yarn/stable20/handlebars-4.7.7 2021-05-18 08:16:53 +00:00
Morris Jobke da32428c3e Merge pull request #26954 from nextcloud/backport/26879/stable20
[stable20]  Don't break OCC if an app is breaking in it's Application class
2021-05-18 09:32:22 +02:00
dependabot-preview[bot] 4122686afa [Security] Bump handlebars from 4.7.6 to 4.7.7
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.7.6 to 4.7.7. **This update includes a security fix.**
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.7.6...v4.7.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-05-18 06:53:34 +00:00
Morris Jobke 247c576533 Merge pull request #27001 from nextcloud/backport/26946/stable20
[stable20] Respect default share permissions for federated reshares
2021-05-18 08:27:07 +02:00
Roeland Jago Douma 00a0b5550d Respect default share permissions for federated reshares
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-17 10:06:12 +00:00
Nextcloud bot 18dd1177c7 [tx-robot] updated from transifex 2021-05-17 02:26:57 +00:00
Nextcloud bot f80b1fe0cb [tx-robot] updated from transifex 2021-05-16 02:27:10 +00:00
Nextcloud bot 39fa997f80 [tx-robot] updated from transifex 2021-05-15 02:29:40 +00:00
kesselb 3eff603dc5 Merge pull request #26965 from nextcloud/backport/26292/stable20
[stable20] ignore readonly flag for directories
2021-05-14 22:29:18 +02:00
Roeland Jago Douma 7d3bd5445c Merge pull request #26971 from nextcloud/backport/26958/stable20
[stable20] Throttle MountPublicLinkController when share is not found
2021-05-14 10:55:33 +02:00
Nextcloud bot 18c62accf8 [tx-robot] updated from transifex 2021-05-14 02:25:22 +00:00
Roeland Jago Douma 1bba950e5c Throttle MountPublicLinkController when share is not found
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-12 19:28:41 +00:00
Robin Appelman 23df35feb0 ignore readonly flag for directories
see http://support.microsoft.com/kb/326549

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-12 16:26:32 +00:00
Roeland Jago Douma 57e1ee8d8f Merge pull request #26956 from nextcloud/backport/26945/stable20
[stable20] Add bruteforce protection to the shareinfo endpoint
2021-05-12 14:13:00 +02:00
Roeland Jago Douma 94be523a40 Add bruteforce protection to the shareinfo endpoint
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-12 08:11:34 +00:00
Joas Schilling a0e0627de0 Don't break OCC if an app is breaking in it's Application class
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 07:42:04 +00:00
Nextcloud bot b8cb6a8e84 [tx-robot] updated from transifex 2021-05-12 02:26:38 +00:00
dependabot-preview[bot] 7dd0a2c147 Merge pull request #26909 from nextcloud/dependabot/npm_and_yarn/stable20/lodash-4.17.21 2021-05-11 09:21:11 +00:00
dependabot-preview[bot] d945d6a063 [Security] Bump lodash from 4.17.20 to 4.17.21
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. **This update includes a security fix.**
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.20...4.17.21)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-05-11 10:47:07 +02:00
Nextcloud bot e5f74851fa [tx-robot] updated from transifex 2021-05-11 02:26:21 +00:00
Nextcloud bot 6fbdbfa971 [tx-robot] updated from transifex 2021-05-10 02:32:02 +00:00
Nextcloud bot 6a63c535a0 [tx-robot] updated from transifex 2021-05-09 02:25:37 +00:00
Nextcloud bot b436c3a8df [tx-robot] updated from transifex 2021-05-08 02:25:13 +00:00
dependabot-preview[bot] 1954fb0f2f Merge pull request #26920 from nextcloud/dependabot/npm_and_yarn/stable20/hosted-git-info-2.8.9 2021-05-07 20:34:04 +00:00
dependabot-preview[bot] 8f08f0115a [Security] Bump hosted-git-info from 2.8.8 to 2.8.9
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. **This update includes a security fix.**
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](https://github.com/npm/hosted-git-info/compare/v2.8.8...v2.8.9)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-05-07 19:47:37 +00:00
Nextcloud bot c312a62e86 [tx-robot] updated from transifex 2021-05-07 02:27:08 +00:00
Morris Jobke 6e53742255 Merge pull request #26894 from nextcloud/version/20.0.10
20.0.10
2021-05-06 14:09:54 +02:00
Morris Jobke 96e2a9f20d 20.0.10
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-05-06 13:01:01 +02:00
Nextcloud bot edae9eb9a4 [tx-robot] updated from transifex 2021-05-06 02:25:54 +00:00
Morris Jobke 14b7313042 Merge pull request #26882 from nextcloud/backport/26869/stable20
[stable20] l10n: Spelling unification
2021-05-05 13:43:33 +02:00
Valdnet b893b5563a Fix test
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-05-05 11:02:10 +00:00
Valdnet 849130c011 l10n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-05-05 11:02:10 +00:00
Nextcloud bot 83ec0bd360 [tx-robot] updated from transifex 2021-05-04 02:26:38 +00:00
blizzz eca4717ca1 Merge pull request #26862 from nextcloud/backport/26149/stable20
[stable20] Only perform login check during ownership transfer for encryption
2021-05-03 15:02:16 +02:00
Christoph Wurst a82d72e5ce Only perform login check during ownership transfer for encryption
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-05-03 11:37:59 +00:00
Nextcloud bot cb58b11f19 [tx-robot] updated from transifex 2021-05-03 02:25:55 +00:00
Nextcloud bot 0ca700e916 [tx-robot] updated from transifex 2021-05-02 02:25:43 +00:00
Nextcloud bot a27a241d25 [tx-robot] updated from transifex 2021-05-01 02:26:54 +00:00
Roeland Jago Douma f2f15a7b42 Merge pull request #26836 from nextcloud/version/20.0.10/final
20.0.10 RC1
2021-04-30 12:47:19 +02:00
Roeland Jago Douma 12ed9c5cda Update bundle
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-30 12:17:11 +02:00
Roeland Jago Douma 31b6443091 Merge pull request #26542 from nextcloud/stable20-26433
[stable20] Limit size of properties to 2048 characters
2021-04-30 09:27:45 +02:00
Nextcloud bot 3b1ac61331 [tx-robot] updated from transifex 2021-04-30 02:28:11 +00:00
Roeland Jago Douma f8985dcd7c 20.0.10 RC1
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-29 20:56:12 +02:00
Roeland Jago Douma f902adf188 Merge pull request #25973 from nextcloud/backport/25417/stable20-fix-account-data-visibility-after-disabling-public-addressbook-upload
[stable20] Fix account data visibility after disabling public addressbook upload
2021-04-29 20:52:38 +02:00
Lukas Reschke 4ec4a99869 Limit size of properties to 2048 characters
It is unreasonable to expect that one of these fields would be longer
than 2048 characters. Whilst some have definitely lower limits (such as
for phone numbers or domain names), a upper bound as sanity check makes
sense.

Backport of https://github.com/nextcloud/server/pull/26433

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-29 20:45:11 +02:00
Morris Jobke c8374de7eb Merge pull request #26824 from nextcloud/backport/26811/stable20
[stable20] Do not try to contact lookup server if not needed
2021-04-29 15:50:18 +02:00
Roeland Jago Douma 02001520e0 Do not try to contact lookup server if not needed
In some cases (for example you never send data to the lookup server)
there is no need for this job to even try.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-29 09:23:02 +02:00
Nextcloud bot eb93e0dd29 [tx-robot] updated from transifex 2021-04-29 02:26:50 +00:00
Julius Härtl 82b93f1cf0 Merge pull request #26809 from nextcloud/backport/26647/stable20
[stable20] Fail when creating new files with an empty path
2021-04-28 15:56:49 -01:00
Julius Härtl 4f8c89f8a5 Fail when creating new files with an empty path
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-28 10:06:03 +00:00
Julius Härtl b5574db974 Merge pull request #26798 from nextcloud/backport/26785/stable20
[stable20] LDAP: do not bother to search after the last page
2021-04-28 08:46:08 -01:00
Joas Schilling f8f32d79d7 Merge pull request #26788 from nextcloud/backport/26718/stable20
[stable20] Fix ratelimit template
2021-04-28 09:54:14 +02:00
Nextcloud bot c5ac15925b [tx-robot] updated from transifex 2021-04-28 02:26:07 +00:00
Arthur Schiwon 46ae746379 do not try to search after the last page
- saves an LDAP requests in these cases
- prevents a Protocol Error logged on < 7.3 API (for backports)

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-27 17:41:58 +00:00
Joas Schilling 498ac1c6f5 Do not allow to overwrite some variables
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:39:53 +00:00
Joas Schilling 2b0fd23ecf Fix ratelimit template
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:39:52 +00:00
Morris Jobke f369fdaf94 Merge pull request #26779 from nextcloud/backport/26765/stable20
[stable20] No longer add trusted servers on federated share creation
2021-04-27 14:47:05 +02:00
Julius Härtl 2774ae508c Merge pull request #26705 from nextcloud/backport/26627/stable20
[stable20] update icewind/smb to 3.4.1
2021-04-27 05:51:19 -01:00
Roeland Jago Douma 42a6ac89bb No longer add trusted servers on federated share creation
It was disabled by default for ages. And often resulted in unwanted
behavior. If admins want trusted servers they just have to do it
manually.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-27 06:11:01 +00:00
Nextcloud bot b8fc36c6be [tx-robot] updated from transifex 2021-04-27 02:25:56 +00:00
Roeland Jago Douma 68fde88909 Merge pull request #26771 from nextcloud/backport/26763/stable20
[stable20] Improve federated permission handling
2021-04-26 20:51:49 +02:00
Julius Härtl 0f0c8debd9 Merge pull request #26767 from nextcloud/backport/26762/stable20 2021-04-26 16:16:17 -01:00
Roeland Jago Douma 9501514055 Improve federated permission handling
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-26 15:27:05 +00:00
Joas Schilling bcf9c14047 Log deprecation only as debug
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 15:14:55 +00:00
Joas Schilling 56d7b1a382 Respect the error level when logging
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 15:14:53 +00:00
Roeland Jago Douma 0cb66c5ca0 Merge pull request #26753 from nextcloud/backport/26721/stable20
[stable20] private cannot be final
2021-04-26 10:28:43 +02:00
Maxence Lange 0145fd0b5c private cannot be final
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2021-04-26 07:08:14 +00:00
Nextcloud bot 07b94975d4 [tx-robot] updated from transifex 2021-04-26 02:24:59 +00:00
Nextcloud bot 09c8c985e1 [tx-robot] updated from transifex 2021-04-25 02:25:15 +00:00
Nextcloud bot 1c784b1bf2 [tx-robot] updated from transifex 2021-04-24 02:26:59 +00:00
Daniel Calviño Sánchez 546be0ea63 Handle corrupted scope values
Due to a bug (fixed some commits ago) in the UsersController of the
settings app the scope of the properties can be null (for example, if
lookup server upload was disabled and the user then changed the display
name in the profile information). In that case now the scope menu icon
shows an error to inform the user.

The scope value will not change when other properties are modified until
the user chooses an explicit value from the menu. Note that until a
scope is explicitly set the property will behave as if it is private.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:58 +02:00
Daniel Calviño Sánchez e929d16bbb Fix settings scope menu hidden when lookup server upload is disabled
When upload to the lookup server is disabled the scope menu was hidden
in the personal information settings. However, even if the lookup server
upload is disabled the personal information is still accesible from the
local server as well as trusted servers. Users should be able to still
set if their information is available to other users or if it is
private, so now the scope menu is always show (although the "Public"
option is hidden if the lookup server upload is disabled).

If the user set the information as public before the upload to the
lookup server was disabled the menu will also show the "Public" option
as active, although disabled. Setting the visibility to any of the other
options will hide the "Public" option from the menu (until the lookup
server upload is enabled again).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:58 +02:00
Daniel Calviño Sánchez 4e05a486a3 Add integration tests for searching users in contacts menu
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:57 +02:00
Daniel Calviño Sánchez 67b49edac4 Make possible to set body in requesttoken requests in integration tests
"sendingAToWithRequesttoken" needs to be used to test some non OCS
endpoints which require the request token to be sent in the request. Now
it is possible to specify the body (or, rather, additional contents
beside the cookies and the request token) for those requests, as it will
be needed for example to update the user profile.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:57 +02:00
Daniel Calviño Sánchez 77aba3df3c Fix deleting properties of user settings when not given explicitly
The controller can receive an optional subset of the properties of the
user settings; values not given are set to "null" by default. However,
those null values overwrote the previously existing values, so in
practice any value not given was deleted from the user settings. Now
only non null values overwrite the previous values.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:57 +02:00
Daniel Calviño Sánchez 0ddd892736 Fix TypeError when "email" is not given in the controller request
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:57 +02:00
Daniel Calviño Sánchez 0dfd0ec77a Respect additional user settings not covered by the controller
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.

Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).

This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:56 +02:00
Daniel Calviño Sánchez bedb97fd57 Add more unit tests for setting user settings
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:55 +02:00
Daniel Calviño Sánchez 1c8295610b Change default test data to values less similar to empty values
Right now it makes no difference, but this should make future tests
clearer, specially in case of failure.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:52 +02:00
Daniel Calviño Sánchez 91e06bc08a Extract default test data to a helper getter
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:49 +02:00
Daniel Calviño Sánchez 32fd379b66 Use constants from interface rather than class
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:48 +02:00
Nextcloud bot a335ff969d [tx-robot] updated from transifex 2021-04-23 02:26:35 +00:00
Morris Jobke 35189a914b Merge pull request #26693 from nextcloud/backport/25714/stable20
[stable20] Explicitly check hex2bin input
2021-04-22 20:54:46 +02:00
Robin Appelman 9318f2d668 update icewind/smb to 3.4.1
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-22 18:01:54 +00:00
Roeland Jago Douma 86de5d9265 Explicitly check hex2bin input
For #23197

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-22 14:01:25 +02:00
Morris Jobke 3c9b923eb1 Merge pull request #26684 from nextcloud/backport/26474/stable20
[stable20] Mention MariaDB in MySQL support warning
2021-04-22 09:47:45 +02:00
Nextcloud bot bef596de06 [tx-robot] updated from transifex 2021-04-22 02:26:44 +00:00
Claas Augner 3082777bfd Mention MariaDB in MySQL support warning 2021-04-21 14:45:41 +00:00
Christoph Wurst 98472c2f85 Merge pull request #26640 from nextcloud/backport/26625/stable20
[stable20] Fix empty password check for mail shares
2021-04-21 15:43:30 +02:00
Morris Jobke adf259d6c7 Merge pull request #26678 from nextcloud/backport/26658/stable20
[stable20] Do not stop directory listing when ACL is blocking access
2021-04-21 14:21:11 +02:00
Julius Härtl 0a24fcfc34 Continue iterating over diretory contents and just hide file if denied by acl
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-21 07:24:25 +00:00
Vincent Petry 6bd49e256b Fix empty password check for mail shares
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-21 08:00:29 +02:00
Nextcloud bot 80d93acff0 [tx-robot] updated from transifex 2021-04-21 02:26:25 +00:00
Morris Jobke 72857fe0b1 Merge pull request #26656 from nextcloud/psalm/noid/update-psalm-baseline/stable20
[stable20] Update psalm baseline
2021-04-20 17:50:48 +02:00
Vincent Petry cea228ef50 Update psalm baseline
And backport error suppression from stable21 in SFTP class.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-20 17:13:31 +02:00
Roeland Jago Douma fc118f1291 Merge pull request #26642 from nextcloud/backport/26639/stable20
[stable20] ensure redis returns bool for hasKey
2021-04-20 16:25:32 +02:00
Roeland Jago Douma bf7eafcda3 Merge pull request #26620 from nextcloud/backport/26614/stable20
[stable20] Update root.crl due to revoked news.crt
2021-04-20 15:09:54 +02:00
Morris Jobke 342a6f51d2 Merge pull request #26643 from nextcloud/backport/26633/stable20
[stable20] Make lookup search explicit
2021-04-20 14:28:24 +02:00
Roeland Jago Douma e5edc58d11 Make lookup search explicit
Speedsup sharee lookup quite a bit.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-20 08:37:48 +00:00
Arthur Schiwon 89960468ae ensure redis returns bool for hasKey
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-20 08:36:55 +00:00
Morris Jobke bd16ddd675 Merge pull request #26637 from nextcloud/backport/26615/stable20
[stable20] Require read permissions for federated shares
2021-04-20 09:06:40 +02:00
Nextcloud bot a4c55e4601 [tx-robot] updated from transifex 2021-04-20 02:26:21 +00:00
Roeland Jago Douma 0324e078f8 Require read permissions for federated shares
Else they end up as weird shares that can't be properly utilized by
other parties anyway.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 19:54:24 +00:00
Morris Jobke db87149a47 Merge pull request #26622 from nextcloud/backport/26613/stable20
[stable20] Do not allow adding file drop shares to your own cloud
2021-04-19 21:48:52 +02:00
Roeland Jago Douma 12504d4ab7 Do not allow adding file drop shares to your own cloud
There is no reason for this and you can't create such shares normally
anyway.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 13:01:05 +00:00
Morris Jobke d42540fe8d Update root.crl due to revoked news.crt
See https://github.com/nextcloud/app-certificate-requests/pull/382

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-04-19 12:13:56 +00:00
Roeland Jago Douma 70d625fb50 Merge pull request #26602 from nextcloud/dependabot/npm_and_yarn/stable20/ssri-6.0.2
[Security] Bump ssri from 6.0.1 to 6.0.2
2021-04-19 12:46:12 +02:00
Nextcloud bot ed5f446ec1 [tx-robot] updated from transifex 2021-04-19 02:26:26 +00:00
Nextcloud bot 90ea283913 [tx-robot] updated from transifex 2021-04-18 02:24:30 +00:00
Nextcloud bot 36a16bcf63 [tx-robot] updated from transifex 2021-04-17 02:24:25 +00:00
dependabot-preview[bot] 8e4a93fc53 [Security] Bump ssri from 6.0.1 to 6.0.2
Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2. **This update includes a security fix.**
- [Release notes](https://github.com/npm/ssri/releases)
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md)
- [Commits](https://github.com/npm/ssri/compare/v6.0.1...v6.0.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-04-16 22:06:01 +00:00
Nextcloud bot e57f65cdfe [tx-robot] updated from transifex 2021-04-16 02:26:13 +00:00
Nextcloud bot 36d2bb05cf [tx-robot] updated from transifex 2021-04-15 02:25:32 +00:00
Nextcloud bot d35011b3f7 [tx-robot] updated from transifex 2021-04-14 02:27:12 +00:00
Nextcloud bot bb6dc44afb [tx-robot] updated from transifex 2021-04-13 02:25:18 +00:00
Roeland Jago Douma e5f30d010d Merge pull request #26515 from nextcloud/backport/26439/stable20
[stable20] Increase subnet matcher
2021-04-12 13:32:14 +02:00
Lukas Reschke 61545e7a89 Increase subnet matcher
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-12 10:36:26 +00:00
Roeland Jago Douma 5517ce19ce Merge pull request #26509 from nextcloud/backport/26230/stable20
[stable20] l10n: Add word user in FederatedShareProvider.php
2021-04-12 10:17:57 +02:00
Valdnet 1e4fc523fe l10n: Add word user in FederatedShareProvider.php
Standardizing text strings with other Nextcloud applications.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-12 06:43:54 +00:00
Nextcloud bot 0cdfea022d [tx-robot] updated from transifex 2021-04-12 02:25:16 +00:00
Nextcloud bot 7faa8e697b [tx-robot] updated from transifex 2021-04-11 02:25:03 +00:00
Nextcloud bot ff2a0b3126 [tx-robot] updated from transifex 2021-04-10 02:31:32 +00:00
Nextcloud bot e78e509618 [tx-robot] updated from transifex 2021-04-09 02:25:30 +00:00
Roeland Jago Douma 7022222ac2 Merge pull request #26454 from nextcloud/version/20.0.9/final
20.0.9 final
2021-04-08 14:39:29 +02:00
Roeland Jago Douma bb0966f1c7 Merge pull request #26449 from nextcloud/3rdparty/stable20/phpseclib-2.0.31
[3rdparty][stable20] phpseclib-2.0.31
2021-04-08 14:37:17 +02:00
Roeland Jago Douma a23bed0386 [3rdparty][stable20] phpseclib-2.0.31
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-08 11:47:56 +02:00
Roeland Jago Douma 96bf8a1a92 20.0.9 RC1
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-08 10:20:43 +02:00
Nextcloud bot e09760f2bc [tx-robot] updated from transifex 2021-04-08 02:24:23 +00:00
Nextcloud bot f1fd067db1 [tx-robot] updated from transifex 2021-04-07 02:24:36 +00:00
Lukas Reschke 90386ff920 Merge pull request #26399 from nextcloud/backport/26061/stable20
[stable20] Log and continue when failing to update encryption keys during for individual files
2021-04-06 13:43:55 +02:00
Nextcloud bot 45e63c949c [tx-robot] updated from transifex 2021-04-06 02:25:51 +00:00
Nextcloud bot ef6a2cfc8f [tx-robot] updated from transifex 2021-04-05 02:25:05 +00:00
Nextcloud bot bc1331f2c9 [tx-robot] updated from transifex 2021-04-04 02:25:07 +00:00
Nextcloud bot 9d0c2b1984 [tx-robot] updated from transifex 2021-04-03 02:43:54 +00:00
Nextcloud bot 7eb7a91b06 [tx-robot] updated from transifex 2021-04-02 02:26:26 +00:00
Roeland Jago Douma e7948c6738 Merge pull request #26312 from nextcloud/version/20.0.9/RC1
20.0.9 RC1
2021-04-01 20:01:30 +02:00
Morris Jobke 94c8e96a1f Merge pull request #26405 from nextcloud/backport/26403/stable20
[stable20] remove leftover debug @NoCSRFRequired introduced with #26198
2021-04-01 18:17:08 +02:00
Robin Appelman fb201a5747 remove leftover debug @NoCSRFRequired introduced with #26198
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-01 13:13:47 +00:00
Vincent Petry 3a1444ee71 Fix phpcs issues in encryption update
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-01 07:56:20 +00:00
Julius Härtl c2a072b27d Log and continue when failing to update encryption keys during for individual files
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 07:56:19 +00:00
Nextcloud bot 9df8953adf [tx-robot] updated from transifex 2021-04-01 02:24:59 +00:00
kesselb 1e3e339e69 Merge pull request #26378 from nextcloud/backport/25500/stable20
[stable20] fix(translation): replace static error message
2021-03-31 10:08:34 +02:00
Christoph Wurst 7c4fca57a5 Merge pull request #26381 from nextcloud/backport/26372/stable20
[stable20] gracefully handle deleteFromSelf when share is already gone
2021-03-31 07:43:11 +02:00
Nextcloud bot 35db1b5996 [tx-robot] updated from transifex 2021-03-31 02:25:11 +00:00
Arthur Schiwon 47abd1f37e gracefully handle deleteFromSelf when share is already gone
- handling race conditions

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-30 20:26:20 +00:00
Samuel 8b6706ea7d revert(comment)
Signed-off-by: Samuel <faust64@gmail.com>
2021-03-30 19:26:14 +00:00
Samuel 09a92dc7cd revert(exception): keep throwing an exception for now
Signed-off-by: Samuel <faust64@gmail.com>
2021-03-30 19:26:13 +00:00
Samuel 2703777014 fix(translation): replace static error message
as suggested by @kesselb in nextcloud/server#25490

Signed-off-by: Samuel <faust64@gmail.com>
2021-03-30 19:26:13 +00:00
Roeland Jago Douma 99e2e5f6b9 Merge pull request #26258 from nextcloud/backport/26198/stable20
[stable20] Handle limit offset and sorting in files search
2021-03-30 20:53:11 +02:00
Christoph Wurst f1cde6b4bc Merge pull request #26364 from nextcloud/backport/26325/stable20
[stable20] Update cipher defaults
2021-03-30 11:30:52 +02:00
Nextcloud bot 60aa785092 [tx-robot] updated from transifex 2021-03-30 02:24:39 +00:00
Roeland Jago Douma dd9890c5b8 Merge pull request #26262 from nextcloud/backport/26046/stable20
[stable20] update icewind/smb to 3.4.0
2021-03-29 21:14:39 +02:00
Roeland Jago Douma f94e8f3ee4 Merge pull request #26356 from nextcloud/backport/26342/stable20
[stable20] Fix broken Calendar Event Invite email icons in Gmail by using PNGs instead of SVGs
2021-03-29 21:03:36 +02:00
J0WI f4683a5fdf Update cipher defaults
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-03-29 18:41:46 +00:00
dependabot-preview[bot] 9f8757de81 Merge pull request #26360 from nextcloud/dependabot/npm_and_yarn/stable20/y18n-4.0.1 2021-03-29 17:29:01 +00:00
dependabot-preview[bot] 003049108f [Security] Bump y18n from 4.0.0 to 4.0.1
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. **This update includes a security fix.**
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-29 16:55:44 +00:00
Nick Sweeting 03df8abca3 change calendar invite emails to use pngs instead of svgs
Signed-off-by: Nick Sweeting <git@sweeting.me>
2021-03-29 16:16:33 +00:00
Nextcloud bot dae4431427 [tx-robot] updated from transifex 2021-03-29 02:24:18 +00:00
Nextcloud bot 86850feaf9 [tx-robot] updated from transifex 2021-03-28 02:24:24 +00:00
Nextcloud bot 53aa26b6c6 [tx-robot] updated from transifex 2021-03-27 02:24:47 +00:00
Morris Jobke a8c6ffaf9a Merge pull request #26290 from nextcloud/backport/21484/stable20
[stable20] show better error messages when a file with a forbidden path is encountered
2021-03-26 13:51:02 +01:00
Roeland Jago Douma 41375184eb 20.0.9 RC1
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-26 10:32:48 +01:00
John Molakvoæ 20cb2b49e6 Merge pull request #26305 from nextcloud/backport/22201/stable20
[stable20] Delete old birthday calendar object when moving contact to another ad…
2021-03-26 08:57:48 +01:00
John Molakvoæ 2262115043 Merge pull request #26297 from nextcloud/backport/26287/stable20
[stable20] Fix l10n
2021-03-26 08:08:53 +01:00
Christian Weiske 92ac67c3d2 Delete old birthday calendar object when moving contact to another address book
When an contact is moved to another address book, the contact is copied to
the second address book.
During copying, the birthday event is created - but it gets the same UID
as the contact's birthday event in the first address book.

To prevent the "Calendar object with uid already exists" error that followed,
we need to delete the old entry before the new one is created.

Resolves: https://github.com/nextcloud/server/issues/20492
Signed-off-by: Christian Weiske <cweiske@cweiske.de>
2021-03-26 07:01:33 +00:00
Nextcloud bot 1a05043008 [tx-robot] updated from transifex 2021-03-26 02:25:53 +00:00
Morris Jobke f3630edf45 Merge pull request #26176 from nextcloud/backport/26076/stable20
[stable20] adds ldap user:reset command
2021-03-25 20:37:06 +01:00
Morris Jobke a9df50c570 Merge pull request #26302 from nextcloud/backport/26299/stable20
[stable20] Log when a storage is marked as unavailable
2021-03-25 20:33:05 +01:00
Morris Jobke 3fe78684ad Log when a storage is marked as unavailable
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-25 16:12:12 +00:00
Valdnet ab374f2cde Fix l10n
Issue: #26286
2021-03-25 12:58:49 +00:00
Arthur Schiwon d78b213310 adds ldap user:reset command
- allows to delete data of existing LDAP users, which otherwise is safe
  guarded
- ensures that the user is not being deleted on LDAP through a plugin

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-25 13:36:16 +01:00
Robin Appelman 82a2492c33 show better error messages when a file with a forbidden path is encountered
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-25 10:56:44 +00:00
Nextcloud bot f6cbda9e60 [tx-robot] updated from transifex 2021-03-25 02:25:57 +00:00
Morris Jobke 5f9f997a33 Merge pull request #26275 from nextcloud/backport/26265/stable20
[stable20] Fix casing of core test folder, bring back missing tests
2021-03-24 21:45:42 +01:00
Vincent Petry d86c4f9662 Revert "Fix core tests command for app enabling/disabling"
This reverts commit acfffcc685.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-24 17:17:38 +01:00
Morris Jobke 07887d62c6 Merge pull request #26278 from nextcloud/backport/26255/stable20
[stable20] l10n: Separate ellipsis
2021-03-24 17:13:56 +01:00
Robin Appelman 4b65a1dcd7 fix type hints
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:35:08 +01:00
Robin Appelman 4ede9dbb07 use node search api for legacy file search endpoint
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:01:17 +01:00
Robin Appelman 10bf93aa24 pass order from unified search to file search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:01:11 +01:00
Robin Appelman 055af29371 handle ordering in folder search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:01:05 +01:00
Robin Appelman 671b99251e folder filtering in sql
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:00:58 +01:00
Robin Appelman 4e60b9ffe2 cleanup fileinfo creation
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:00:53 +01:00
Robin Appelman dbd8b0ae82 format
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:00:47 +01:00
Robin Appelman 6a639ec1d0 handle limit and offset in folder file search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:00:41 +01:00
Robin Appelman 4655f6feb1 only require user to be set in a query that handles tags
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:00:35 +01:00
Robin Appelman a624243236 unify handling of Folder::search methods into "new" query objects
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:00:29 +01:00
Robin Appelman 60551ced9e use "newer" node search api directly in unified search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:00:06 +01:00
Vincent Petry 945eb07497 Revert autocomplete controller tests to match stable20
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-24 15:24:30 +01:00
Vincent Petry 31f7257c30 Revert controller tests to match stable21 API
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-24 15:24:06 +01:00
Valdnet 680a54c47d l10n: Separate ellipsis
Unifying the text string with the others.
2021-03-24 13:26:48 +00:00
Morris Jobke 75871f76ad Merge pull request #26250 from nextcloud/backport/25529/stable20
[stable20] Fix non LGC glyphs in avatars and txt file previews
2021-03-24 14:18:19 +01:00
Morris Jobke 22626ae13f Merge pull request #26272 from nextcloud/backport/26270/stable20
[stable20] Catch invalid cache source storage path
2021-03-24 14:09:05 +01:00
Vincent Petry 6fcb1ab834 Fix language codes test result order
Fixes issue with Oracle by enforcing the order of the results to check.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-24 12:38:47 +00:00
Vincent Petry 522c319385 Bring back forgotten tests
Remove "ocs-provider" test folder reference as it doesn't exist any
more.
Added back "Test" test subdir and fixed the tests inside.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-24 12:38:46 +00:00
Vincent Petry a9a6f519fb Fix more controller tests in Core subdir
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-24 12:38:45 +00:00
Vincent Petry 97c11ff48b Fix more tests in the Core subdir
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-24 12:38:44 +00:00
Vincent Petry acfffcc685 Fix core tests command for app enabling/disabling
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-24 12:38:43 +00:00
Vincent Petry 74447816a4 Fix casing of core test folder
It seems Phpunit < 9 was case insensitive.
Fixed the phpunit config to target the correct name for the "Core" test
directory.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-24 12:38:42 +00:00
John Molakvoæ (skjnldsv) dfcf6ad106 Catch invalid cache source storage path
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-24 11:05:32 +00:00
Nextcloud bot c555e86e63 [tx-robot] updated from transifex 2021-03-24 02:25:25 +00:00
Robin Appelman 4bbf7058af update icewind/smb to 3.4.0
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-23 19:08:48 +01:00
Nextcloud bot 1c9904aafc [tx-robot] updated from transifex 2021-03-23 02:24:24 +00:00
Daniel Calviño Sánchez 24d853e754 Add OCC command to reset rendered texts
The command is meant to be used when the fonts used to render texts
("core/fonts/NotoSans-Regular.ttf" and "core/fonts/NotoSans-Bold.ttf")
are changed (for example, to add support for other scripts). The avatar
and text file previews will be removed, so they will be generated again
with the updated font when needed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-22 20:09:43 +00:00
Daniel Calviño Sánchez 6997e6f755 Include additional scripts in Noto fonts
Generated avatars as well as text file previews are rendered using the
"core/fonts/NotoSans-Regular.ttf" font. The file was the standard hinted
"NotoSans-Regular.ttf" file from https://www.google.com/get/noto/.
However that file does not cover some non LGC (Latin, Greek, Cyrillic)
scripts, like Arabic, Devanagari or Hebrew, to name a few.

Markdown file previews also use "core/fonts/NotoSans-Bold.ttf", which is
in the same situation as the regular one.

Due to limitations in the TTF format it is not possible to provide a
single file for each style that includes all Noto fonts. However, it is
possible to add more scripts to the standard "NotoSans-Regular.ttf" and
"NotoSans-Bold.ttf" files (although no CJK (Chinese, Japanese, Korean)
glyph can be included due to the aforementioned limitations).

This commit replaces the standard files with an extended version created
using the Noto Tools. The build script (as well as a patch for the Noto
Tools) is also included for reference and to be able to update the font
files in the future if needed.

Due to the additional scripts added the font files are now much larger,
although this does not seem to increase the time spent rendering LGC
scripts.

Note that the file for the bold style still contains less scripts than
the regular one, as not all scripts supported by Noto have a bold
weight.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-22 20:09:42 +00:00
John Molakvoæ 7d8aede6dc Merge pull request #26239 from nextcloud/backport/26231/stable20 2021-03-22 13:55:29 +01:00
Valdnet 70e89e44ec l10n: Add changes to text string for user 2021-03-22 10:30:52 +00:00
Valdnet 68a707c158 l10n: Add word user in ShareByMailProvider.php
Standardizing text strings with other Nextcloud applications.
2021-03-22 10:30:51 +00:00
Nextcloud bot 208f84d2e4 [tx-robot] updated from transifex 2021-03-22 02:24:06 +00:00
Nextcloud bot efdb5cc53c [tx-robot] updated from transifex 2021-03-21 02:23:27 +00:00
Roeland Jago Douma 7b294aee0d Merge pull request #26217 from nextcloud/backport/26145/stable20
[stable20] add (hidden) option to always show smb root as writable
2021-03-20 10:53:48 +01:00
Nextcloud bot 01d05c6435 [tx-robot] updated from transifex 2021-03-20 02:24:00 +00:00
Morris Jobke 019ccda25f Merge pull request #26209 from nextcloud/backport/23718/stable20
[stable20] expand 'path is already shared' error message
2021-03-19 20:04:07 +01:00
Robin Appelman fd29d77817 expand 'path is already shared' error message
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 17:32:14 +01:00
Robin Appelman 728488fcf5 add (hidden) option to always show smb root as writable
some smb servers are very insistent in reporting that the root of the share is readonly, even if it isn't.

This works around the problem by adding a hidden option to overwrite the permissions of the root of the share.

This can be enabled using

```bash
occ files_external:config <mount id> root_force_writable true
```

where you can find your mount id using

```bash
occ files_external:list
```

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 15:47:23 +00:00
Morris Jobke 37c3930f72 Merge pull request #26205 from nextcloud/backport/26200/stable20
[stable20] Update user share must use correct expiration validation
2021-03-19 15:19:30 +01:00
Vincent Petry 4ad89c1761 Update user share must use correct expiration validation
Updating a user or group share now uses the correct method for the
validation of the expiration date. Instead of using the one from links
it uses the one for internal shares.

To avoid future confusion, the method "validateExpirationDate" has been
renamed to "validateExpirationDateLink".

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-19 09:57:29 +00:00
Morris Jobke f088b942cb Merge pull request #26125 from nextcloud/backport/25533/stable20
[stable20] send share notification instead of erroring on duplicate share
2021-03-19 09:19:14 +01:00
Nextcloud bot 97d9b3fe0c [tx-robot] updated from transifex 2021-03-19 02:25:14 +00:00
Morris Jobke ffc4efb894 Merge pull request #26063 from nextcloud/backport/25915/stable20
[stable20] Add appconfig to always show the unique label of a sharee
2021-03-18 20:50:01 +01:00
Roeland Jago Douma 4e617bedda Merge pull request #26123 from nextcloud/backport/26004/stable20
[stable20] Allow overwriting isAuthenticated
2021-03-18 16:20:37 +01:00
Julius Härtl 96287f336e Add appconfig to always show the unique label of a sharee
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-18 13:07:03 +00:00
Morris Jobke 939db1f466 Merge pull request #26190 from nextcloud/backport/25331/stable20
[stable20] Fix valid storages removed when cleaning remote storages
2021-03-18 13:09:22 +01:00
Vincent Petry 7dfb3afdac Merge pull request #26088 from nextcloud/backport/26049/stable20
[stable20] limit constructing of result objects in file search
2021-03-18 11:22:53 +01:00
Daniel Calviño Sánchez ec454e7c2b Fix valid storages removed when cleaning remote storages
The remote URL of a share is always stored in the database with a
trailing slash. However, when a cloud ID is generated trailing slashes
are removed.

The ID of a remote storage is generated from the cloud ID, but the
"cleanup-remote-storage" command directly used the remote URL stored in
the database. Due to this, even if the remote storage was valid, its ID
did not match the ID of the remote share generated by the command and
ended being removed.

Now the command generates the ID of remote shares using the cloud ID
instead, just like done by the remote storage, so there is no longer a
mismatch.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-18 07:59:45 +00:00
Daniel Calviño Sánchez 92daa942b0 Add integration tests for "sharing:cleanup-remote-storages" OCC command
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-18 07:59:45 +00:00
Robin Appelman e36e4a571e implement PagedProvider for file search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:22:34 +01:00
Robin Appelman 57042ab107 limit constructing of result objects in file search
even thought we currently have no proper way of limiting the search itself, we can at least limit the construction of the result objects.

this saves about 40% of the time spend in the search request in my local testing

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:22:31 +01:00
Nextcloud bot a50f4a42bc [tx-robot] updated from transifex 2021-03-18 02:25:22 +00:00
Morris Jobke d3b279d98d Merge pull request #26052 from nextcloud/backport/26048/stable20
[stable20] cache baseurl in url generator
2021-03-17 20:14:05 +01:00
Morris Jobke 4f18ff9815 Merge pull request #25944 from nextcloud/backport/25659/stable20
[stable20] catch notfound and forbidden exception in smb::getmetadata
2021-03-17 20:13:57 +01:00
Morris Jobke 71b793f8a1 Merge pull request #26091 from nextcloud/backport/25722/stable20
[stable20] apply object store copy optimization when 'cross storage' copy is wit…
2021-03-17 20:09:56 +01:00
Morris Jobke c4da8d4e55 Merge pull request #26152 from nextcloud/backport/26137/stable20
[stable20] dont allow creating users with __groupfolders as uid
2021-03-17 20:06:56 +01:00
Morris Jobke 2982fa346b Merge pull request #26181 from nextcloud/backport/26003/stable20
[stable20] Add getID function to the simplefile implementation
2021-03-17 20:06:15 +01:00
Morris Jobke fe3b3a9cec Merge pull request #26147 from nextcloud/backport/26013/stable20
[stable20] Return the fileid from `copyFromCache` and use it instead of doing an extra query
2021-03-17 20:04:11 +01:00
Roeland Jago Douma 147134fc31 Add getID function to the simplefile implementation
Sometimes it is useful to get the actual fileid

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-17 16:15:46 +00:00
Morris Jobke 3c1402c2d9 Merge pull request #25876 from nextcloud/psalm/stable20/update
[stable20] Update psalm baseline
2021-03-17 14:17:20 +01:00
Morris Jobke fd53468d7b Merge pull request #26163 from nextcloud/backport/26153/stable20
[stable20] Use correct exception type hint in catch statement
2021-03-17 13:50:13 +01:00
Morris Jobke 94c47eddea Merge pull request #26168 from nextcloud/backport/26072/stable20
[stable20] remove explicit fclose from S3->writeStream
2021-03-17 13:46:48 +01:00
Vincent Petry 67e0b194b6 Update and fix baseline
Backported some bits of stable21 to make Psalm happy.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-17 12:04:08 +01:00
Robin Appelman 534a935433 remove explicit fclose from S3->writeStream
streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-17 09:36:11 +00:00
Vincent Petry f80f7a33e8 Fix baseline further
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-17 10:31:09 +01:00
Roeland Jago Douma 7bb7f4d936 Update psalm baseline
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-17 10:06:06 +01:00
Morris Jobke 9749514649 Use correct exception type hint in catch statement
Found by psalm update 4.6.2 to 4.6.3 in #26111

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-17 08:47:07 +00:00
Nextcloud bot fdabe1172b [tx-robot] updated from transifex 2021-03-17 02:24:39 +00:00
Robin Appelman 279f0d72f3 dont allow creating users with __groupfolders as uid
Fixes https://github.com/nextcloud/groupfolders/issues/338

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 18:51:58 +00:00
Robin Appelman 436cd31bd2 verify that cache entry is valid
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:04 +00:00
Robin Appelman 9bb73574c3 also implement for FailedCache and NullCache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:03 +00:00
Robin Appelman 20ab946c3f use returned file id for object store copy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:01 +00:00
Robin Appelman aaa4c071ed add ICopyFromCache trait to expose existing implementation
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:01 +00:00
Morris Jobke 2e14150889 Merge pull request #26134 from nextcloud/backport/25136/stable20
[stable20] do cachejail search filtering in sql
2021-03-16 17:00:29 +01:00
Robin Appelman bdd7f28fa6 only use share cacheentry when available
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:22:23 +01:00
Robin Appelman f500e2396e adjust tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:22:23 +01:00
Robin Appelman 7fd53b91c3 fix search in nested jails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:22:22 +01:00
Robin Appelman a20eb9a229 fix cachjail searching for root
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:22:22 +01:00
Robin Appelman 5d08beb3d2 do cachejail search filtering in sql
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:22:22 +01:00
Christoph Wurst a6357ebcba Merge pull request #26130 from nextcloud/backport/26115/stable20
[stable20] Log exceptions when creating share
2021-03-16 11:09:44 +01:00
Nextcloud bot 7332b6f75e [tx-robot] updated from transifex 2021-03-16 02:25:00 +00:00
Vincent Petry 20ebdf4fe0 Log exceptions when creating share
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.

In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-15 15:06:43 +00:00
Robin Appelman 797645bc49 send share notification instead of erroring on duplicate share
when creating a share that already exists, instead of erroring, resend the notifications

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 14:13:05 +00:00
Roeland Jago Douma ff64514bea Allow overwriting isAuthenticated
* Some implementations might check for different things
* IT will not change how the current ones work

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-15 13:59:10 +00:00
Christoph Wurst 3e18eca7a0 Merge pull request #26059 from nextcloud/backport/25911/stable20
[stable20] Only clear share password model when actually saved
2021-03-15 09:48:19 +01:00
Nextcloud bot 25f27569f5 [tx-robot] updated from transifex 2021-03-15 02:24:17 +00:00
Nextcloud bot 049895f3e7 [tx-robot] updated from transifex 2021-03-14 02:23:58 +00:00
Nextcloud bot b6af167c65 [tx-robot] updated from transifex 2021-03-13 02:23:14 +00:00
Robin Appelman 5827a156af apply object store copy optimization when 'cross storage' copy is within the same object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 16:16:32 +00:00
Nextcloud bot 60756e8e3e [tx-robot] updated from transifex 2021-03-12 02:23:01 +00:00
Vincent Petry 51ba0faeaf Only clear share password model when actually saved
Instead of always clearing the password in the share model, now only do
it when it was actually saved.

Fixes an issue where saving another field would clear the password too
early and prevent it to be saved when the dropdown closed.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-11 10:20:59 +00:00
Roeland Jago Douma b306b88a41 Merge pull request #26040 from nextcloud/backport/25916/stable20
[stable20] Remove trash items from other trash backends when deleting all
2021-03-11 10:34:32 +01:00
Nextcloud bot 28378720f1 [tx-robot] updated from transifex 2021-03-11 02:23:28 +00:00
Robin Appelman a1935d0f74 cache baseurl in url generator
Servers don't tend to change their url in the middle of a request

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-10 19:38:41 +00:00
Roeland Jago Douma ae6c5f2af4 Merge pull request #26027 from nextcloud/backport/25933/stable20
[stable20] Hide expiration date field for remote shares
2021-03-10 15:46:53 +01:00
Vincent Petry aad21777d4 Hide expiration date field for remote shares
Remote shares currently do not support expiration date.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-10 09:08:28 +00:00
Roeland Jago Douma f240f895e7 Merge pull request #25878 from nextcloud/backport/25568/stable20
[stable20] disable trasbin during the moveFromStorage fallback
2021-03-10 09:34:02 +01:00
Julius Härtl 0c98c15555 Remove trash items from other trash backends when deleting all
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-10 08:02:38 +00:00
Nextcloud bot 8dc2b22e35 [tx-robot] updated from transifex 2021-03-10 02:23:17 +00:00
Roeland Jago Douma 0d021249f8 Merge pull request #25938 from nextcloud/backport/25927/stable20
[stable20] Sharebymail: set expiration on creation
2021-03-09 20:20:49 +01:00
Roeland Jago Douma 791868fa25 Merge pull request #25994 from nextcloud/backport/25975/stable20
[stable20] Add missing waits and asserts in acceptance tests
2021-03-09 09:34:25 +01:00
Nextcloud bot df04689af7 [tx-robot] updated from transifex 2021-03-09 02:24:13 +00:00
Roeland Jago Douma 5f3955446a Merge pull request #26009 from nextcloud/dependabot/npm_and_yarn/stable20/elliptic-6.5.4
[Security] Bump elliptic from 6.5.3 to 6.5.4
2021-03-08 19:37:51 +01:00
dependabot-preview[bot] 7dffaabe8a [Security] Bump elliptic from 6.5.3 to 6.5.4
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. **This update includes a security fix.**
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.3...v6.5.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-08 16:52:54 +00:00
Daniel Calviño Sánchez ace7b9dfe1 Find directly the label instead of falling back to it
The input element is always hidden, so the check always ended falling
back to the label. Moreover, the label is the element that the user
interacts with, so it must be the one used.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:37 +00:00
Daniel Calviño Sánchez f92a216dcf Assert also element visibility instead of just finding it
Although if the element could not be found an exception would be thrown
and the test aborted if an element is in the DOM but hidden it would be
found and the test would pass.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:37 +00:00
Daniel Calviño Sánchez 30c91a7303 Add explicit locator for "Enable all" bundle button
Instead of looking for the bundle button and then checking its value now
the expected value is included in the locator and the button is checked
similarly to other elements.

No "Disable all" locator was added as it was not currently needed
anywhere.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:36 +00:00
Daniel Calviño Sánchez 00b38db77f Find elements through the actor rather than the driver
"Actor::find" is a more robust way to look for elements, as it handles
some exceptions that may be thrown. Therefore, even if the elements are
not actually used and it is only checked whether they exist or not using
the actor is the preferred way when possible (and it also makes it
consistent with the rest of the acceptance tests).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:35 +00:00
Daniel Calviño Sánchez d293751ba7 Add locator for apps list
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:35 +00:00
Daniel Calviño Sánchez 5859458c52 Fix identation
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:34 +00:00
Daniel Calviño Sánchez d548d212a2 Fix delete user acceptance test
Adding some missing asserts showed that the "delete user" acceptance
test was silently failing, as the deletion was not being confirmed in
the dialog and thus the user was not being deleted.

The dialog button contains a single quote ("user0's"), so the XPath
expression had to be adjusted (it seems that it is not possible to
escape a single quote in a string enclosed in single quotes in XPath
1.0).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:33 +00:00
Daniel Calviño Sánchez dd1a554c79 Verify WaitFor::element... results with an assertion
WaitFor::element... calls only perform the waiting and return whether
the condition succeeded or not, but that result needs to be explicitly
checked to prevent further steps from being executed if the wait failed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:32 +00:00
Daniel Calviño Sánchez 8077dbf097 Add missing waits when finding elements in the acceptance tests
As no timeout was specified the elements were tried to be found just
once. This caused the steps to fail if the elements did not appear yet
in the page when they were tried to be found.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:32 +00:00
Roeland Jago Douma 0b8f41f5af Merge pull request #25963 from nextcloud/backport/25712/stable20
[stable20] Fix admin password strengthify tooltip
2021-03-08 08:54:22 +01:00
Nextcloud bot 2046e71da2 [tx-robot] updated from transifex 2021-03-08 02:23:30 +00:00
Nextcloud bot 14b9c26b8a [tx-robot] updated from transifex 2021-03-07 02:22:25 +00:00
Roeland Jago Douma f78c3f475b Merge pull request #25956 from nextcloud/backport/25932/stable20
[stable20] Skip empty obsolete owner when adding to own NC
2021-03-06 10:55:08 +01:00
Nextcloud bot f209e862c2 [tx-robot] updated from transifex 2021-03-06 02:22:41 +00:00
Richard Steinmetz a8b780bdcb Fix admin password strengthify tooltip
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2021-03-05 18:20:43 +01:00
Vincent Petry e92afefba7 Skip empty obsolete owner when adding to own NC
The owner field is nowadays always empty when adding a federated share
using "Add to your Nextcloud", so don't check for it.

Fixes an issue where "Add to your Nextcloud" doesn't add anything.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-05 13:38:09 +00:00
Roeland Jago Douma 41405facde Merge pull request #25934 from nextcloud/backport/25926/stable20
[stable20] Activity: show if files are hidden or not
2021-03-05 14:29:27 +01:00
Roeland Jago Douma f70e6e8482 Merge pull request #25919 from nextcloud/backport/25805/stable20
[stable20] Clear multiselect after selection in share panel
2021-03-05 09:43:52 +01:00
Robin Appelman 326f7ac857 catch notfound and forbidden exception in smb::getmetadata
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-05 07:54:09 +00:00
Nextcloud bot b4d001db3a [tx-robot] updated from transifex 2021-03-05 02:22:16 +00:00
Roeland Jago Douma 3089c744d2 Sharebymail: set expiration on creation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 18:52:43 +00:00
Roeland Jago Douma ede08b0f09 Activity: show if files are hidden or not
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 16:04:27 +00:00
Nextcloud bot 21ff951ca3 [tx-robot] updated from transifex 2021-03-04 02:22:30 +00:00
Vincent Petry d3db0f5000 Clear multiselect after selection in share panel
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-03 16:43:57 +00:00
blizzz 6ee39e204f Merge pull request #25844 from nextcloud/backport/25757/stable20
[stable20] fix detecting cyclic group memberships
2021-03-03 10:43:21 +01:00
Roeland Jago Douma ff5491bf69 Merge pull request #25873 from nextcloud/backport/25869/stable20
[stable20] Fix namespacing
2021-03-03 08:46:21 +01:00
Roeland Jago Douma fbb719b29d Merge pull request #25900 from nextcloud/backport/25860/stable20
[stable20] do not die after LDAP auth failed with expired acc
2021-03-03 08:35:16 +01:00
Nextcloud bot 25fbc9fdd6 [tx-robot] updated from transifex 2021-03-03 02:21:42 +00:00
Arthur Schiwon 4b9037e849 do not die after LDAP auth failed with expired acc
- some servers return error code 53

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-02 20:40:06 +00:00
Robin Appelman 59d157f1f2 disable trasbin during the moveFromStorage fallback
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-02 13:28:00 +00:00
Anna Larch 4b9e638cca Fix namespacing
Signed-off-by: Anna Larch <anna@nextcloud.com>
2021-03-02 10:10:29 +00:00
Roeland Jago Douma 9fea75d7d7 Merge pull request #25858 from nextcloud/backport/25856/stable20
[stable20] Card::getOwner should return the actual value
2021-03-02 09:24:40 +01:00
Nextcloud bot 5c474ee142 [tx-robot] updated from transifex 2021-03-02 02:22:41 +00:00
Roeland Jago Douma 622a3b8c74 Card::getOwner should return the actual value
I guess we never call this at runtime or it would already ahve done boom
very loudly.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 17:30:33 +00:00
Roeland Jago Douma acb8fac983 Merge pull request #25848 from nextcloud/backport/25715/stable20
[stable20] Bump the ca location
2021-03-01 18:26:08 +01:00
Roeland Jago Douma 200a3db58e Bump the ca location
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 12:37:56 +00:00
Roeland Jago Douma b94ef32ed8 Merge pull request #25740 from nextcloud/backport/25602/stable20
[stable20] Avoid creating two share links when password is enforced
2021-03-01 12:49:36 +01:00
Arthur Schiwon ce6d64b122 fix detecting cyclic group memberships
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-01 11:13:14 +00:00
Julius Härtl fc935f1bc8 Avoid creating two share links when password is enforced
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-01 10:05:20 +01:00
Nextcloud bot 1c7829ce53 [tx-robot] updated from transifex 2021-03-01 02:20:37 +00:00
Nextcloud bot ccd6063eea [tx-robot] updated from transifex 2021-02-28 02:20:12 +00:00
Nextcloud bot 7f2985aecd [tx-robot] updated from transifex 2021-02-27 02:22:40 +00:00
Nextcloud bot 792d82b967 [tx-robot] updated from transifex 2021-02-26 02:22:05 +00:00
Nextcloud bot 1e4af96055 [tx-robot] updated from transifex 2021-02-25 02:21:40 +00:00
Roeland Jago Douma 1ff83111a6 Merge pull request #25719 from nextcloud/version/20.0.8/final
20.0.8 final
2021-02-24 19:36:24 +01:00
Nextcloud bot 147e2798d7 [tx-robot] updated from transifex 2021-02-24 02:22:24 +00:00
Joas Schilling 10a4a144d3 Merge pull request #25709 from nextcloud/backport/25707/stable20
[stable20] Send emails on password reset to the displayname
2021-02-23 11:59:04 +01:00
Nextcloud bot a85fa7b6d3 [tx-robot] updated from transifex 2021-02-23 02:39:44 +00:00
Nextcloud bot ea8e83a000 [tx-robot] updated from transifex 2021-02-21 02:40:17 +00:00
Nextcloud bot 3454f39642 [tx-robot] updated from transifex 2021-02-20 02:37:41 +00:00
Roeland Jago Douma 94099c9b80 20.0.8 final
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-19 14:10:43 +01:00
Nextcloud bot 17cc8c7579 [tx-robot] updated from transifex 2021-02-19 02:21:14 +00:00
Roeland Jago Douma f80a2bef59 Merge pull request #25494 from nextcloud/version/20.0.8/RC1
20.0.8 RC1
2021-02-18 20:23:58 +01:00
Roeland Jago Douma cb0c2243ac Merge pull request #25384 from nextcloud/backport/25218/stable20
[stable20] do not remove valid group shares
2021-02-18 20:13:58 +01:00
Roeland Jago Douma b986c9e4e5 Merge pull request #25132 from nextcloud/backport/24661/stable20
[stable20] dont offer to edit external config settings if we can't edit them
2021-02-18 19:41:49 +01:00
Robin Appelman e7805e5009 fix test
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-18 15:56:26 +01:00
Robin Appelman 590ef22935 Update apps/files_external/js/statusmanager.js
Co-authored-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-18 15:55:02 +01:00
Joas Schilling 42e28633f5 Send emails on password reset to the displayname
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-18 14:35:06 +00:00
Roeland Jago Douma d9186a2f46 Merge pull request #25703 from nextcloud/backport/25700/stable20
[stable20] Initialize \OCP\AppFramework\Http\ZipResponse::$resources
2021-02-18 08:31:41 +01:00
Nextcloud bot ae63016e06 [tx-robot] updated from transifex 2021-02-18 02:22:14 +00:00
Christoph Wurst 5b15e16706 Initialize \OCP\AppFramework\Http\ZipResponse::$resources
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-17 21:30:53 +00:00
Roeland Jago Douma 42de5042ba Merge pull request #25448 from nextcloud/backport/25393/stable20
[stable20] add repair job for unencoded group share uris
2021-02-17 20:59:18 +01:00
Arthur Schiwon 9b3bff87a0 bump affected version
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 17:10:29 +01:00
Arthur Schiwon c882bc68ba compatibility to Nc 20
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 17:09:33 +01:00
Arthur Schiwon ca7a7a5c85 add missing changes from backport source
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 15:59:50 +01:00
Arthur Schiwon 7c449cd0ba test: adjust expectation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 15:59:50 +01:00
Arthur Schiwon 04496a71ca show suggestion to clean up possible invalid shares later
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 15:59:50 +01:00
Arthur Schiwon a6414a7d05 take into account that UNIQUE index might not work as expected
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 15:59:50 +01:00
Arthur Schiwon c2ba3ca0ed add repair job for unencoded calendars
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 15:59:49 +01:00
Joas Schilling dbae210a06 Merge pull request #25379 from nextcloud/backport/25101/stable20
[stable20] LDAP: make actually use of batch read known groups
2021-02-17 14:56:45 +01:00
Arthur Schiwon 02ae52bb5b really use known groups
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 13:51:08 +01:00
Roeland Jago Douma 4be1dbe40e Merge pull request #25651 from nextcloud/backport/25594/stable20
[stable20] Use ownerDisplayName for SharingEntry Tooltip
2021-02-17 10:38:18 +01:00
Arthur Schiwon bf61a439d8 do not remove valid group shares
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 08:51:37 +01:00
Nextcloud bot 39a6ab6b42 [tx-robot] updated from transifex 2021-02-17 02:21:26 +00:00
Roeland Jago Douma c0696c54b5 Merge pull request #25666 from nextcloud/backport/25661/stable20
[stable20] Updated CRL
2021-02-16 08:27:08 +01:00
Nextcloud bot 4923eddaa6 [tx-robot] updated from transifex 2021-02-16 02:21:53 +00:00
Roeland Jago Douma fbf57e5aeb Updated CRL
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 21:09:41 +00:00
Roeland Jago Douma 476dcbcf01 Merge pull request #25663 from nextcloud/backport/25655/stable20
[stable20] Fix app icon list in dark mode
2021-02-15 22:05:18 +01:00
Joas Schilling e537a4254a Fix app icon list in dark mode
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-15 19:39:58 +00:00
Dan VerWeire d3df65e86f Use ownerDisplayName for SharingEntry Tooltip
Some NC installations may use a LDAP UUID for the username. If that
is the case, then the tooltip for who a file/folder was shared by may say something
like `Shared with Steve McQueen (smqueen@yada.com) by FKDJ39-38D794JG-4398GJODF9H3G-4534`.

This commit changes the value showed for the owner to the full display name.

Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-02-15 15:54:31 +00:00
Nextcloud bot e83b8fbfae [tx-robot] updated from transifex 2021-02-15 02:20:26 +00:00
Nextcloud bot 9fb792d1c1 [tx-robot] updated from transifex 2021-02-14 02:20:18 +00:00
Nextcloud bot 4799201c94 [tx-robot] updated from transifex 2021-02-13 02:20:46 +00:00
Roeland Jago Douma f6f6051b73 Merge pull request #25592 from nextcloud/backport/25582/stable20
[stable20] Do not send imip email to invalid recipients
2021-02-12 08:54:48 +01:00
Nextcloud bot 9b978a714d [tx-robot] updated from transifex 2021-02-12 02:20:35 +00:00
Christoph Wurst d5407764d7 Do not send imip email to invalid recipients
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 19:03:14 +00:00
Roeland Jago Douma 47a39803f3 Merge pull request #25382 from nextcloud/backport/25312/stable20
[stable20] do not lower case search provider names on web ui
2021-02-11 10:33:27 +01:00
Nextcloud bot 799ba83095 [tx-robot] updated from transifex 2021-02-11 02:20:54 +00:00
Nextcloud bot 0c4de17482 [tx-robot] updated from transifex 2021-02-10 02:21:17 +00:00
Roeland Jago Douma c3fc3e739e Merge pull request #25458 from nextcloud/backport/23588/stable20
[stable20] Override default dashboard background with theming one
2021-02-09 22:03:05 +01:00
Julien Veyssier 451cb39122 override default dashboard background with theming one
fix getAppValue default value in theming app
fix cacheBuster value injection

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-09 21:26:07 +01:00
Roeland Jago Douma 3042a5a833 Merge pull request #25550 from nextcloud/reconnectwrapper-wait-timeout
[20] change reconect wrapper to only check connection after inactivity
2021-02-09 21:14:46 +01:00
Robin Appelman b51f32ec08 change reconect wrapper to only check connection after inactivity
instead of always checking every minute, only check the connection after a minute of inactivity.
this should better reflect how idle timeouts of sql servers work and remove most of the cases where this check was previously done.

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-09 16:30:59 +01:00
Nextcloud bot b3ac30c4da [tx-robot] updated from transifex 2021-02-09 02:21:02 +00:00
Nextcloud bot 783b519886 [tx-robot] updated from transifex 2021-02-08 02:20:22 +00:00
Nextcloud bot 83cb1897f3 [tx-robot] updated from transifex 2021-02-07 02:21:08 +00:00
Roeland Jago Douma 30230a436e Merge pull request #25388 from nextcloud/backport/25302/stable20
[stable20] Use RFC-compliant URL encoding for cookies
2021-02-06 10:56:27 +01:00
Nextcloud bot a6ebb5be79 [tx-robot] updated from transifex 2021-02-06 02:21:08 +00:00
Roeland Jago Douma b6ac93dff9 Merge pull request #25497 from nextcloud/backport/25487/stable20
[stable20] Log deprecation notice of GenericEventWrapper just once
2021-02-05 16:17:16 +01:00
Roeland Jago Douma fa2ed5b93f Merge pull request #25504 from nextcloud/tests/node-build-clean/stable20
[stable20] Cleanup bundle files before checking the rebuild
2021-02-05 16:15:47 +01:00
Julius Härtl 88d4dcac44 Cleanup bundle files before checking the rebuild
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-02-05 15:08:50 +01:00
Vincent Petry efe9ef223d Merge pull request #25475 from nextcloud/backport/25443/stable20
[stable20] Make user list pagination more tolerant
2021-02-05 14:46:49 +01:00
Roeland Jago Douma 4717aeb6f7 Merge pull request #25477 from nextcloud/backport/25441/stable20
[stable20] Fix duplicate tag info view registration
2021-02-05 13:21:04 +01:00
Christoph Wurst 61278d2461 Log deprecation notice of GenericEventWrapper just once
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-05 10:17:16 +00:00
Vincent Petry 1936895a42 Fix duplicate tag info view registration
Only register the tag info view once as it's stored in a singleton.
This fixes an issue where the tag info view did not get rendered after
swiching between different file views.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-02-05 11:09:01 +01:00
Vincent Petry ccaa593a44 Make user list pagination more tolerant
In case the server returns more results than expected by the limit, it
is now still interpreted as there being more results to query.

This situation can happen when there are multiple user backends in
place.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-02-05 11:08:36 +01:00
Roeland Jago Douma e4bfbfe177 Merge pull request #25492 from nextcloud/bugfix/25491/ci-fix-notifications-branch/stable20
Fix CI branch for notifications app
2021-02-05 11:05:21 +01:00
Roeland Jago Douma c781bebf64 Merge pull request #25480 from nextcloud/stable20-stray-asset-deletion
[stable20] Remove stray compiled assets
2021-02-05 11:01:52 +01:00
Roeland Jago Douma 931ee2c0b8 20.0.8 RC1
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-05 10:53:29 +01:00
Vincent Petry 8abd227498 Fix CI branch for notifications app
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-02-05 10:38:37 +01:00
Nextcloud bot 6552f03d1f [tx-robot] updated from transifex 2021-02-05 02:21:51 +00:00
Vincent Petry cbc06719c2 Remove stray assets
This was automatically deleted and not regenerated by:
make dev-setup && make build-js-production

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-02-04 11:50:32 +01:00
Nextcloud bot 333ff64b40 [tx-robot] updated from transifex 2021-02-04 02:20:21 +00:00
Nextcloud bot bb32ba0c07 [tx-robot] updated from transifex 2021-02-03 02:20:01 +00:00
Roeland Jago Douma 841aa4d32c Merge pull request #25430 from nextcloud/backport/25424/stable20
[stable20] Keep direct login active when redirecting
2021-02-02 21:25:13 +01:00
Roeland Jago Douma 370ae8ac04 Merge pull request #25387 from nextcloud/version/20.0.7/final
20.0.7 final
2021-02-02 20:51:53 +01:00
Julius Härtl e70ad108f6 Merge pull request #25421 from nextcloud/backport/25383/stable20
[stable20] Properly handle SMB ACL blocking scanning a directory
2021-02-02 20:44:31 +01:00
Julius Härtl e7c07e722b Keep direct login active when redirecting
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-02-02 09:30:36 +00:00
Nextcloud bot 9bb3212433 [tx-robot] updated from transifex 2021-02-02 02:20:04 +00:00
Julius Härtl fcfa39183c Properly handle SMB ACL blocking scanning a directory
This makes sure that a possible ForbiddenException is properly passed
through the storage as a ForbiddenException and can be catched when
trying to fetch the quota info of a parent folder

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-02-01 11:13:44 +00:00
Nextcloud bot 20cc5584f9 [tx-robot] updated from transifex 2021-02-01 02:19:48 +00:00
Nextcloud bot a49a9a4945 [tx-robot] updated from transifex 2021-01-31 02:19:14 +00:00
Nextcloud bot dcce572b55 [tx-robot] updated from transifex 2021-01-30 02:20:45 +00:00
Marco Ziech 52229154a5 Use RFC-compliant URL encoding for cookies
PHP 7.4.2 changed the way how cookies are decoded, applying RFC-compliant raw URL decoding. This leads to a conflict Nextcloud's own cookie encoding, breaking the remember-me function if the UID contains a space character.

Fixes #24438

Signed-off-by: Marco Ziech <marco@ziech.net>
2021-01-29 12:41:59 +00:00
Roeland Jago Douma 173122846a 20.0.7 final
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-29 12:58:49 +01:00
Arthur Schiwon 28d521afcf built assets
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-29 11:23:23 +01:00
Arthur Schiwon d809fa3ae9 do not lower case search provider names on web ui
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-29 11:18:23 +01:00
Roeland Jago Douma 63a48cf5a9 Merge pull request #25368 from nextcloud/version/20.0.7/RC1
20.0.7 RC1
2021-01-29 09:00:24 +01:00
Roeland Jago Douma 2d63998bb7 Merge pull request #25374 from nextcloud/backport/25369/stable20
[stable20] The objectid is a string
2021-01-29 08:56:39 +01:00
Roeland Jago Douma b745acdc14 The objectid is a string
This allows the query to use the index. Else it has to resort on
scanning all the rows.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-29 07:15:16 +00:00
Nextcloud bot cde8b977a0 [tx-robot] updated from transifex 2021-01-29 02:21:27 +00:00
Julius Härtl e6fb478dbe Merge pull request #25366 from nextcloud/backport/25361/stable20
[stable20] fix parameter provided as string not array
2021-01-28 22:12:36 +01:00
Julius Härtl 2c23dd4b51 Merge pull request #25352 from nextcloud/backport/25185/stable20
[stable20] Show the actual error on share requests
2021-01-28 22:05:25 +01:00
Roeland Jago Douma ba6a0da73a 20.0.7 RC1
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-28 21:19:47 +01:00
Arthur Schiwon 71a762b3a7 fix parameter provided as string not array
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-28 19:40:13 +00:00
Nextcloud bot d7f6a4800c [tx-robot] updated from transifex 2021-01-28 02:24:21 +00:00
Roeland Jago Douma 5caf554d27 Merge pull request #25347 from nextcloud/backport/25335/stable20
[stable20] Fix/app fetcher php compat comparison
2021-01-27 21:01:11 +01:00
Julius Härtl a2476e19e6 Show the actual error on share requests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-01-27 19:00:45 +00:00
Christoph Wurst 9010937535 Fix app fetcher php comparison to allow wider ranges
When app app specifies php 7.4 as upper limit we have to allow the
installation on php>7.4.0. The previous version check didn't do that.
This adjusts the regexes to discard any irrelevant suffix after the
three version numbers so that we can use more fine granular checks than
php's version_compare can do out of the box, like for php 7.4 we only
compare the major and minor version numbers and ignore the patch level.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-27 14:51:54 +00:00
Christoph Wurst fbe893016f Revert "Fix comparison of PHP versions"
This reverts commit bedd9acf78.
2021-01-27 14:51:54 +00:00
Nextcloud bot b527ffc4c9 [tx-robot] updated from transifex 2021-01-27 02:20:58 +00:00
Christoph Wurst 891fbe100e Merge pull request #25324 from nextcloud/backport/25310/stable20
[stable20] [CalDAV] Validate notified emails
2021-01-26 10:48:21 +01:00
Nextcloud bot 7e2552f142 [tx-robot] updated from transifex 2021-01-26 02:21:43 +00:00
Thomas Citharel 9d0319446e [CalDAV] Validate notified emails
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2021-01-25 19:49:20 +00:00
Roeland Jago Douma 7ecb8d122e Merge pull request #25315 from nextcloud/backport/25313/stable20
[stable20] Catch NotFoundException when querying quota
2021-01-25 20:44:54 +01:00
Roeland Jago Douma fd26cb1870 Merge pull request #25294 from nextcloud/version/20.0.6/final
20.0.6
2021-01-25 15:56:13 +01:00
Vincent Petry ead953addd Catch NotFoundException when querying quota
Fixes parent folder that becomes inaccessible when it contains a
non-existing / broken entry because the quota check made the PROPFIND
on parent fail altogether.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-01-25 12:32:18 +00:00
Nextcloud bot 16509c61a0 [tx-robot] updated from transifex 2021-01-25 02:20:41 +00:00
Nextcloud bot d602b047ca [tx-robot] updated from transifex 2021-01-24 02:19:55 +00:00
Roeland Jago Douma 30af7ad53e 20.0.6
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-23 16:30:54 +01:00
Roeland Jago Douma 5663d3e463 Merge pull request #25244 from nextcloud/backport/25234/stable20
[stable20] Fix encoding issue with OC.Notification.show
2021-01-23 10:47:29 +01:00
Nextcloud bot 6cc8c337dc [tx-robot] updated from transifex 2021-01-23 02:20:14 +00:00
Morris Jobke 653db23551 Merge pull request #25278 from nextcloud/backport/25274/stable20
[stable20] Do not obtain userFolder of a federated user
2021-01-22 16:18:47 +01:00
Morris Jobke f7d13f1613 Merge pull request #25276 from nextcloud/backport/25128/stable20
[stable20] extend ILDAPProvider to allow reading arbitrairy ldap attributes for users
2021-01-22 16:15:21 +01:00
Roeland Jago Douma b249abc624 Do not obtain userFolder of a federated user
Federated shares are somewhat special. So we can't move the files from
the main user and we should try to get it from the intialized root
already.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-22 13:40:25 +00:00
Roeland Jago Douma 1a1beafeeb Merge pull request #25261 from nextcloud/backport/25255/stable20
[stable20] also use storage copy when dav copying directories
2021-01-22 14:37:01 +01:00
blizzz b6d175a609 adjust since
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Co-authored-by: Morris Jobke <hey@morrisjobke.de>
2021-01-22 13:33:33 +00:00
Robin Appelman b38149edaa extend ILDAPProvider to allow reading arbitrairy ldap attributes for users
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-22 13:33:32 +00:00
Morris Jobke 24a7772d6c Merge pull request #25263 from nextcloud/backport/25253/stable20
[stable20] silence log message
2021-01-22 10:24:53 +01:00
Nextcloud bot f92289f5a7 [tx-robot] updated from transifex 2021-01-22 02:20:07 +00:00
Arthur Schiwon 9d8b597605 silence log message
- this appears too often (in some configurations) when qualifying group
members which do not meet the criteria

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-21 21:09:57 +00:00
Robin Appelman e0598117e1 also use storage copy when dav copying directories
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-21 21:08:58 +00:00
Joas Schilling b7d8b3a72d Fix encoding issue with OC.Notification.show
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-21 10:43:20 +01:00
Nextcloud bot 5f5203a285 [tx-robot] updated from transifex 2021-01-21 02:20:47 +00:00
Morris Jobke 1dcfab0d76 Merge pull request #25225 from nextcloud/backport/24600/stable20
[stable20] Update handling of user credentials
2021-01-20 14:57:48 +01:00
Joas Schilling fcdbd4eca3 Fix potential empty result
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-20 10:11:56 +01:00
Joas Schilling 85781d8d36 Compare and store the login name via the event
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-20 09:09:15 +01:00
Roeland Jago Douma ae48e26d37 Merge pull request #25219 from nextcloud/backport/25216/stable20
[stable20] Bump CA bundle
2021-01-20 09:08:14 +01:00
Joas Schilling 0c7f0a7d89 Also fix the username when it changed
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-20 09:08:08 +01:00
Joas Schilling 8e3e1f9a32 Don't save credentials of another user
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-20 09:08:00 +01:00
Nextcloud bot 37f3195c6b [tx-robot] updated from transifex 2021-01-20 02:21:05 +00:00
Roeland Jago Douma 3c1a9a5e66 Bump CA bundle
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-19 21:56:28 +00:00
Roeland Jago Douma 0855173ae1 Merge pull request #25203 from nextcloud/version/20.0.6/RC1
20.0.6 RC1
2021-01-19 14:52:34 +01:00
Roeland Jago Douma c442f49162 20.0.6 RC1
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-19 13:48:34 +01:00
Morris Jobke 8395819a93 Merge pull request #25199 from nextcloud/update-3rdparty
[stable20] Update 3rdparty after Archive_Tar
2021-01-19 13:41:50 +01:00
Joas Schilling 31b704038a Update 3rdparty after Archive_Tar
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-19 13:05:00 +01:00
Roeland Jago Douma 18d43a012b Merge pull request #25190 from nextcloud/backport/25181/stable20
[stable20] Update CRL due to revoked gravatar.crl
2021-01-19 09:35:00 +01:00
Roeland Jago Douma b04d566c89 Merge pull request #25193 from nextcloud/backport/25186/stable20
[stable20] Don't log keys on checkSignature
2021-01-19 09:34:49 +01:00
Nextcloud bot f94215a58e [tx-robot] updated from transifex 2021-01-19 02:20:55 +00:00
Joas Schilling aa309afc59 Don't log keys on checkSignature
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 21:26:01 +00:00
Morris Jobke 55da2dce39 Update CRL due to revoked gravatar.crl
https://github.com/nextcloud/app-certificate-requests/pull/362

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-18 19:25:13 +00:00
Morris Jobke 2c643d7b9f Merge pull request #25178 from nextcloud/backport/25176/stable20
[stable20] Add "composer.lock" for acceptance tests to git
2021-01-18 13:33:33 +01:00
Daniel Calviño Sánchez 26a6e46eb3 Add "composer.lock" for acceptance tests to git
As "composer.lock" was not versioned the dependencies had to be resolved
everytime that the acceptance tests run, which took some precious time.

Besides that the dependency versions were also tightened for better
control.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-01-18 11:52:30 +00:00
Nextcloud bot 63a8349e1b [tx-robot] updated from transifex 2021-01-18 02:19:40 +00:00
Roeland Jago Douma 71f57e0b5e Merge pull request #25152 from nextcloud/backport/25138/stable20
[stable20] Fix comparison of PHP versions
2021-01-17 21:16:34 +01:00
Nextcloud bot 6ef830a7d9 [tx-robot] updated from transifex 2021-01-17 02:20:08 +00:00
Nextcloud bot 996d6ce994 [tx-robot] updated from transifex 2021-01-16 02:20:15 +00:00
Morris Jobke 8103fd98d1 Update psalm baseline to allow warning of implicit cast to string
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-15 16:55:47 +01:00
Morris Jobke 5ec9ce0bf1 Merge pull request #25146 from nextcloud/backport/25142/stable20
[stable20] Do not redirect to logout after login
2021-01-15 16:45:36 +01:00
Damien Goutte-Gattat 151abca91c Fix comparison of PHP versions
Use the builtin function `version_compare` to check an app's
compatibility with the available PHP version, instead of reusing
the `OC\App\CompareVersion::isCompatible` method which is intended
to compare Nextcloud versions. PHP version strings do not always
necessarily follow the simple Major.Minor.Patch format used by
Nextcloud and therefore cannot be properly compared by that method.

Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>
2021-01-15 14:20:51 +00:00
Roeland Jago Douma 23f466fb10 Do not redirect to logout after login
This can happen when the session was killed due to a timeout. Then
logout was triggered. Nobody wants to login only to be logged out again.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-15 10:56:18 +00:00
Morris Jobke ac14e42b49 Merge pull request #25143 from nextcloud/backport/25141/stable20
[stable20] Add a hint about the direction of priority
2021-01-15 10:10:04 +01:00
Joas Schilling b07ff57b2b Add a hint about the direction of priority
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-15 08:49:19 +00:00
Morris Jobke 48eea6f74b Merge pull request #25077 from nextcloud/backport/25034/stable20
[stable20] Make sure to do priority app upgrades first
2021-01-15 09:31:57 +01:00
Nextcloud bot 7c8d3709d9 [tx-robot] updated from transifex 2021-01-15 02:20:37 +00:00
blizzz 591c4fdd02 Merge pull request #25120 from nextcloud/backport/25036/stable20
[stable20] respect DB restrictions on number of arguments in statements and queries
2021-01-14 21:40:54 +01:00
Robin Appelman 6404627d0c adjust tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-14 16:33:13 +00:00
Robin Appelman e0d85ed9a8 dont offer to edit external config settings if we can't edit them
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-14 16:33:13 +00:00
Arthur Schiwon 26f77d879e CI satisfaction
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-14 13:16:02 +01:00
Arthur Schiwon 5dd7665f21 silence psalm false positive
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-14 13:04:02 +01:00
Arthur Schiwon b82efbdee5 DB: warn on parameter number constraints
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-14 13:03:54 +01:00
Arthur Schiwon b0ea654653 respect DB limits limit per statement and query
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-14 13:03:36 +01:00
Roeland Jago Douma 1ef9a3f039 Merge pull request #25102 from nextcloud/version/20.0.5/final
20.0.5
2021-01-14 10:22:39 +01:00
Nextcloud bot 631f28eb74 [tx-robot] updated from transifex 2021-01-14 02:19:15 +00:00
Nextcloud bot 4ca0fb2282 [tx-robot] updated from transifex 2021-01-13 02:20:30 +00:00
Roeland Jago Douma 5f56b1ac67 20.0.5
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-12 23:01:01 +01:00
Roeland Jago Douma a5738cc175 Merge pull request #25064 from nextcloud/version/20.0.5/rc2
20.0.5 RC2
2021-01-12 11:51:22 +01:00
Roeland Jago Douma e89d4a4f40 Merge pull request #25076 from nextcloud/backport/25016/stable20
[stable20] Add setup check to verify that the used DB version is still supported…
2021-01-12 11:50:52 +01:00
Morris Jobke 349c9ef74f Add setup check to verify that the used DB version is still supported in the next major release
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-12 10:18:19 +01:00
Nextcloud bot 6a1d17312c [tx-robot] updated from transifex 2021-01-12 02:20:00 +00:00
Julius Härtl f17033fa12 Make sure to do priority app upgrades first
Otherwise those apps might not be loaded when the others app migrations
are running. The previous loading of authentication apps in the upgrade
step never worked as it just returns in maintenance mode

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-11 13:46:47 +00:00
Morris Jobke 4ee41a7679 Merge pull request #25074 from nextcloud/backport/25069/stable20
[stable20] Don't remove assignable column for now
2021-01-11 14:26:14 +01:00
Vincent Petry c96f3e830a Don't remove assignable column for now
It causes side effects.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-01-11 12:19:54 +00:00
Roeland Jago Douma 6594ca4bbb Merge pull request #25066 from nextcloud/psalm/noid/update-psalm-baseline
[stable20] Update psalm-baseline.xml
2021-01-11 10:46:08 +01:00
Morris Jobke 08f6444474 Merge pull request #25019 from nextcloud/backport/24999/stable20
[stable20] Set the user language when adding the footer
2021-01-11 10:24:17 +01:00
Morris Jobke 568d46a3a5 [stable20] Update psalm-baseline.xml
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-11 10:18:58 +01:00
Morris Jobke 43ec70d43b Merge pull request #25035 from nextcloud/backport/25017/stable20
[stable20] Fix clearing the label of a share
2021-01-11 10:02:21 +01:00
Roeland Jago Douma f71f9a32ec 20.0.5 RC2
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-11 09:41:58 +01:00
Nextcloud bot a156722ece [tx-robot] updated from transifex 2021-01-11 02:20:05 +00:00
Nextcloud bot c7b9964b4a [tx-robot] updated from transifex 2021-01-10 02:22:51 +00:00
Nextcloud bot df3ba2fde2 [tx-robot] updated from transifex 2021-01-09 02:21:47 +00:00
Daniel Calviño Sánchez b078f28029 Fix clearing the label of a share
When the label is being edited its value is stored in "newLabel", and
the original label is shown only if "newLabel" is not set. However, as
it was checked against any falsy value instead of only undefined when
the label was cleared and thus it has an empty value the original label
was shown instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-01-08 17:30:17 +00:00
Roeland Jago Douma f66d88c85a Merge pull request #25030 from nextcloud/backport/25029/stable20
[stable20] Change defaultapp in config.sample.php to dashboard to improve docs and align it to source code
2021-01-08 12:17:42 +01:00
rakekniven a4e6c44581 Change defaultapp to dashboard
Result of discussion at https://help.nextcloud.com/t/enable-dashboard-on-per-user-basis/94872

Code reference:
https://github.com/nextcloud/server/blob/db86bea18ce41ad73e9c1a06f2b2d89d8d4f2ef8/lib/private/legacy/OC_Util.php#L1106

Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
2021-01-08 09:10:24 +00:00
Julius Härtl 36388085f6 Set the user language when adding the footer
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-08 10:09:41 +01:00
Nextcloud bot 0e20ce014a [tx-robot] updated from transifex 2021-01-08 02:22:41 +00:00
Roeland Jago Douma 6d5f5bfa61 Merge pull request #24960 from nextcloud/version/20.0.5/rc1
20.0.5 RC1
2021-01-07 20:43:19 +01:00
Roeland Jago Douma 102a6fedd0 Merge pull request #25009 from nextcloud/backport/25001/stable20
[stable20] Fix column name to check prior to deleting
2021-01-07 19:46:56 +01:00
blizzz b2cfd43b8f Merge pull request #25013 from nextcloud/backport/25011/stable20
[stable20] Catch throwable instead of exception
2021-01-07 18:14:22 +01:00
Roeland Jago Douma cb958df63a Catch throwable instead of exception
The error that gets thrown can also be a type error etc. So we should
properly catch the Throwable.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-07 14:25:15 +00:00
Morris Jobke 8295cc90d8 Merge pull request #24590 from nextcloud/backport/24358/stable20
[stable20] use storage copy implementation when doing dav copy
2021-01-07 14:08:17 +01:00
Joas Schilling 1142b17cda Fix column name to check prior to deleting
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-07 12:33:01 +00:00
Morris Jobke fb0067a777 Merge pull request #24592 from nextcloud/backport/23912/stable20
[stable20] use in objectstore copy
2021-01-07 13:28:10 +01:00
Roeland Jago Douma 7db2278ef9 Merge pull request #24716 from nextcloud/backport/24402/stable20
[stable20] LDAP: fix inGroup for memberUid type of group memberships
2021-01-07 13:17:59 +01:00
Roeland Jago Douma 0f395d8527 Merge pull request #24976 from nextcloud/backport/24961/stable20
[stable20] Fix unreliable ViewTest
2021-01-07 13:17:29 +01:00
Roeland Jago Douma 2dbf407f7e Merge pull request #24963 from nextcloud/backport/24829/stable20
[stable20] Add migration for oc_share_external columns
2021-01-07 13:16:56 +01:00
Roeland Jago Douma 2fa3f24d04 Merge pull request #24997 from nextcloud/backport/24988/stable20
[stable20] Set the JSCombiner cache if needed
2021-01-07 09:56:06 +01:00
Vincent Petry 9c7d733c01 Also add missing oc_share_external.share_type column
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-01-07 09:39:10 +01:00
Vincent Petry 9c54467c94 Adjust share_external table
Add column "parent" if missing.
Drop column "lastscan" if exists.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-01-07 09:38:59 +01:00
Roeland Jago Douma 9e6cc31f60 Merge pull request #24972 from nextcloud/backport/24964/stable20
[stable20] Don't throw a 500 when importing a broken ics reminder file
2021-01-07 09:08:11 +01:00
Roeland Jago Douma 82fab4d621 Set the JSCombiner cache if needed
Found while debugging a customer setup. They had to flush their Redis.
Hence the info was no longer there. Since they also used S3 this meant
requesting the files over and over on template render. Which on S3 is
not cheap.

Now we just write it back if we can't get it from the cache in the first
place. So that the next run has it cached properly again.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-07 07:43:25 +00:00
Nextcloud bot 2f1c118d3b [tx-robot] updated from transifex 2021-01-07 02:21:21 +00:00
Morris Jobke da150d49be Merge pull request #24990 from nextcloud/backport/24986/stable20
[stable20] Update root.crl due to revocation of transmission.crt
2021-01-06 21:06:29 +01:00
Morris Jobke 9fb384cf7c Update root.crl due to revocation of transmission.crt
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-06 19:44:38 +00:00
blizzz cb610c9b31 Merge pull request #24760 from nextcloud/backport/24703/stable20
[stable20] enables the file name check also to match name of mountpoints
2021-01-06 09:54:44 +01:00
Nextcloud bot bf0bbc0846 [tx-robot] updated from transifex 2021-01-06 02:20:12 +00:00
blizzz 25143fc87b Merge pull request #24763 from nextcloud/backport/24515/stable20
[stable20] fixes sharing to group ids with characters that are being url encoded
2021-01-05 23:35:26 +01:00
Arthur Schiwon f34202190c fixes sharing to group ids /w chars that are being url encoded, carddav
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-05 18:54:15 +01:00
Arthur Schiwon b4434833af fix finding of groups with decodable chars in their id via DAV
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-05 18:54:15 +01:00
Arthur Schiwon 3ce013fa14 fixes sharing to group ids with characters that are being url encoded
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-05 18:54:15 +01:00
Julius Härtl 8d9fa73371 Properly handle result when copying with failure and throw in tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-05 16:57:51 +01:00
Julius Härtl 865e4ab0ec Fix writeStream mocking
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-05 14:51:40 +00:00
Julius Härtl 2f6b2b6fa4 Merge pull request #24878 from nextcloud/backport/stable20/23017 2021-01-05 15:14:21 +01:00
Joas Schilling 088418fd91 Don't throw a 500 when importing a broken ics reminder file
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-05 11:59:40 +00:00
Julius Härtl 24053edf8a Bump bundles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-05 10:05:52 +01:00
Julius Härtl 61b574b130 Show unique displayname context in the user share list entries
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-05 10:05:52 +01:00
Julius Härtl 3666754be7 Show unique displayname context in the sharing input
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-05 10:05:52 +01:00
Julius Härtl defdaf1e18 Make share results distinguishable if there are more than one with the exact same display name
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-05 10:05:52 +01:00
Roeland Jago Douma f96e680fdf 20.0.5 RC1
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-05 09:20:14 +01:00
Nextcloud bot 48865b30f5 [tx-robot] updated from transifex 2021-01-05 02:21:38 +00:00
Nextcloud bot 13e5504dcc [tx-robot] updated from transifex 2021-01-04 02:21:58 +00:00
Nextcloud bot ddeb7446cb [tx-robot] updated from transifex 2021-01-03 02:21:07 +00:00
Nextcloud bot 85d5a815fc [tx-robot] updated from transifex 2021-01-01 02:21:13 +00:00
Nextcloud bot 0943120949 [tx-robot] updated from transifex 2020-12-31 02:27:13 +00:00
Roeland Jago Douma f16746e902 Merge pull request #24876 from nextcloud/backport/24874/stable20
[stable20] Avoid huge exception argument logging
2020-12-30 10:51:01 +01:00
Nextcloud bot f00e1e778a [tx-robot] updated from transifex 2020-12-30 02:19:19 +00:00
Roeland Jago Douma 6762e616f5 Avoid huge exception argument logging
In some cases it might happen that you have an argument that deep down
somewhere has an array with a lot of entries (think thousands). Now
before we would just happily print them all. Which would fill the log.

Now it will just print the first 5. And add a line that there are N
more.

If you are on debug level we will still print them all.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-29 10:46:56 +00:00
Nextcloud bot af77e89e67 [tx-robot] updated from transifex 2020-12-29 02:20:01 +00:00
Roeland Jago Douma d96555c413 Merge pull request #24854 from nextcloud/backport/24833/stable20
[stable20] Fix total upload size overwritten by next upload
2020-12-28 14:19:49 +01:00
Julius Härtl 530e637e35 Merge pull request #24853 from nextcloud/backport/24832/stable20
[stable20] Make oc_files_trash.auto_id a bigint
2020-12-28 12:40:20 +01:00
Roeland Jago Douma fc327ee9de Merge pull request #24728 from nextcloud/backport/24721/stable20
[stable20] Cancel user search requests to avoid duplicate results being added
2020-12-28 11:27:30 +01:00
Roeland Jago Douma 1935993e47 Merge pull request #24709 from nextcloud/backport/24683/stable20
[stable20] [Fix #24682]: ensure federation cloud id is retruned if FN property not found
2020-12-28 11:24:29 +01:00
Daniel Calviño Sánchez d4b1ba7785 Fix total upload size overwritten by next upload
The upload progress is based on the "totalToUpload" variable. However,
as the variable is set when an upload is submitted, if another upload is
submitted before the previous one finished the upload progress only took
into account the size of the new upload (although the upload itself
worked fine; the files of the new submitted upload are added to the
active one). Now "totalToUpload" is either increased or set depending on
whether an upload is active or not.

Note that although "data.total" holds the total size of the files being
uploaded "totalToUpload" needs to be used in "fileuploadprogressall"
instead; "totalToUpload" is calculated when the upload is submitted, but
since 7c4c5fe6ae the actual upload of the files, and thus updating the
value of "data.total", may be deferred until the parent folders were
created.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-12-28 10:21:13 +00:00
Roeland Jago Douma afbc2d5cd3 Merge pull request #24826 from nextcloud/backport/24824/stable20
[stable20] Catch the error on heartbeat update
2020-12-28 10:47:29 +01:00
Vincent Petry 558cf72a28 Make oc_files_trash.auto_id a bigint
Adjusted migration.
Added to occ command to update existing tables.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-28 09:46:02 +00:00
Nextcloud bot fab7e85bbb [tx-robot] updated from transifex 2020-12-28 02:19:20 +00:00
Nextcloud bot 3cb3125c4c [tx-robot] updated from transifex 2020-12-27 02:24:54 +00:00
Nextcloud bot 421244e777 [tx-robot] updated from transifex 2020-12-26 02:19:59 +00:00
Nextcloud bot 1524e7b431 [tx-robot] updated from transifex 2020-12-24 02:20:20 +00:00
Roeland Jago Douma 72c5356a55 Catch the error on heartbeat update
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-12-23 11:48:21 +00:00
Roeland Jago Douma e97a0c1307 Merge pull request #24823 from nextcloud/backport/24730/stable20
[stable20] Fix IPv6 localhost regex
2020-12-23 09:33:42 +01:00
Nextcloud bot f4a2a7302e [tx-robot] updated from transifex 2020-12-23 02:20:21 +00:00
J0WI d749f515de Fix IPv6 localhost regex
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-12-22 20:55:55 +00:00
John Molakvoæ 680e03c628 Merge pull request #24806 from nextcloud/backport/24604/stable20
[stable20] Allow to force rename a conflicting calendar
2020-12-22 10:59:08 +01:00
Roeland Jago Douma d5f4ca6e74 Merge pull request #24798 from nextcloud/backport/24796/stable20
[stable20] Actually set the TTL on redis set
2020-12-22 09:10:47 +01:00
John Molakvoæ (skjnldsv) 4fa34362a3 Allow to force rename a conflicting calendar
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-12-22 07:35:23 +00:00
Nextcloud bot 1b19cc5bae [tx-robot] updated from transifex 2020-12-22 02:19:17 +00:00
Guillaume Virlet a8f60c82e4 [Fix #24682]: ensure federation cloud id is retruned if FN property not found
Signed-off-by: Guillaume Virlet <github@virlet.org>
2020-12-21 22:59:43 +01:00
Roeland Jago Douma 34b8e42bf0 Actually set the TTL on redis set
Else well the keys remain for ever and ever.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-21 13:51:18 +00:00
Roeland Jago Douma db22392fd0 Merge pull request #24792 from nextcloud/backport/23319/stable20
[stable20] Fix Argon2 descriptions
2020-12-21 13:32:55 +01:00
Roeland Jago Douma 98c235a436 Merge pull request #24751 from nextcloud/backport/24737/stable20
[stable20] Also unset the other possible unused paramters
2020-12-21 11:43:49 +01:00
Roeland Jago Douma 2a91d7837b Merge pull request #24791 from nextcloud/backport/24715/stable20
[stable20] Limit getIncomplete query to one row
2020-12-21 10:32:28 +01:00
MichaIng d8ff570971 Fix Argon2 descriptions
The threads option for the password_hash function does not define the maximum allowed number of CPU threads to be used by the hashing algorithm but the exact number of threads that is used.

Similarly the memory_cost option for the password_hash function does not define the maximum allowed memory to be used by the hashing algorithm, but the exact amount of memory that is used by the hashing table. The minimum value is 8 KiB per thread.

The time_cost option for the password_hash function does not define the allowed time in seconds, but the number of iterations for the hash function.

If the minimum values are understood, the minimum values are used instead.

Signed-off-by: MichaIng <micha@dietpi.com>
2020-12-21 08:26:34 +00:00
Daniel Kesselberg d22ff8624b Limit getIncomplete query to one row
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-12-21 08:17:46 +00:00
Nextcloud bot 98c22e2c77 [tx-robot] updated from transifex 2020-12-21 02:19:05 +00:00
Nextcloud bot bfb8c07724 [tx-robot] updated from transifex 2020-12-20 02:19:39 +00:00
Nextcloud bot b47bbce075 [tx-robot] updated from transifex 2020-12-19 02:19:47 +00:00
Arthur Schiwon b432a9f5da consider local external storages, too
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-18 10:48:46 +00:00
Arthur Schiwon c0c88e3bd8 enables the file name check also to match name of mountpoints
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-18 10:48:42 +00:00
Roeland Jago Douma 5de0c3c5f7 Also unset the other possible unused paramters
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-18 07:41:00 +00:00
Nextcloud bot 5ea6481355 [tx-robot] updated from transifex 2020-12-18 02:20:20 +00:00
Nextcloud bot 8363530294 [tx-robot] updated from transifex 2020-12-17 02:20:29 +00:00
Julius Härtl 979331baae Bump bundles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-12-16 13:16:04 +00:00
Julius Härtl 824b10956f Only let the infinite handler fetch more results if the limit is hit
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-16 12:59:40 +00:00
Julius Härtl d2e63cd31a Cancel user search requests to avoid duplicate results being added
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-16 12:59:38 +00:00
Roeland Jago Douma 6c8cd720b8 Merge pull request #24714 from nextcloud/backport/24713/stable20
[stable20] Do not include non-required scripts on the upgrade page
2020-12-16 08:55:17 +01:00
Nextcloud bot 257e3dd50b [tx-robot] updated from transifex 2020-12-16 02:20:51 +00:00
Arthur Schiwon 270eb6c593 php-cs happyness
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-15 21:37:58 +00:00
Arthur Schiwon 43c6bc134e add unit tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-15 21:37:56 +00:00
Arthur Schiwon cca1fb792b check number of members after potential resolving of rdns
- the type check is not necessary anymore for the return type of
  _groupMembers()

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-15 21:37:54 +00:00
Arthur Schiwon 213464afca use faster and less hungry foreach
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-15 21:37:51 +00:00
Tobias Perschon 250c7535cd moved the array_reduce to fix large search case
also added some additional comments and renamed some vars to make it intuitive whats in them

Signed-off-by: Tobias Perschon <tobias@perschon.at>
2020-12-15 21:37:49 +00:00
Arthur Schiwon d818975d84 flatten result array as expected by following code
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-15 21:37:47 +00:00
Julius Härtl 55d7848384 Do not include non-required scripts on the upgrade page
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-15 20:42:07 +00:00
Roeland Jago Douma 9305a00414 Merge pull request #24546 from nextcloud/backport/24543/stable20
[stable20] Don't log params of imagecreatefromstring
2020-12-15 16:36:00 +01:00
Roeland Jago Douma e6e6725024 Merge pull request #24697 from nextcloud/backport/24589/stable20
[stable20] Add tel, note, org and title search
2020-12-15 09:17:30 +01:00
Roeland Jago Douma f0c2807cac Merge pull request #24698 from nextcloud/backport/24416/stable20
[stable20] Check php compatibility of app store app releases
2020-12-15 09:15:17 +01:00
Nextcloud bot 2304f1ef10 [tx-robot] updated from transifex 2020-12-15 02:22:22 +00:00
Roeland Jago Douma d50e8d85c7 Merge pull request #24693 from nextcloud/version/20.0.4/final
20.0.4
2020-12-14 19:40:45 +01:00
Christoph Wurst 0ae5c8dd3b Check php compatibility of app store app releases
Apps might increase the minimum php version requirement, in which case
an update could break the app or even the whole instance. We must not
install those releases, or better, don't even show them for
update/installation. This extends the app fetcher code to filter out the
releases that are not installable.

The filter respects minimum and maximum requirements. E.g. apps that are
still only released for php7.3 won't show up for php7.4 instances. This
behavior is new but if an app lists an explicit version requirement,
then we ought to repect that.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-14 17:22:10 +00:00
John Molakvoæ (skjnldsv) d44c6aa524 Add tel, note, org and title search
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-12-14 16:41:55 +00:00
Roeland Jago Douma 176a07895b Bump bundle
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-14 15:54:56 +01:00
Roeland Jago Douma 556a14f283 20.0.4
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-14 15:36:19 +01:00
Roeland Jago Douma 24fe3ee439 Merge pull request #24653 from nextcloud/backport/23044/stable20
[stable20] Handle owncloud migration to latest release
2020-12-14 15:35:00 +01:00
Roeland Jago Douma 209d4c0ff8 Merge pull request #24654 from nextcloud/backport/24247/stable20
[stable20] Use string for storing a OCM remote id
2020-12-14 15:31:12 +01:00
Roeland Jago Douma 8fc1ab560a Merge pull request #24636 from nextcloud/fix/noid/dashboard-without-accessibility
[stable20] Avoid dashboard crash when accessibility app is not installed
2020-12-14 15:14:52 +01:00
Julius Härtl be0936daed Bump dav app version
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:14:07 +01:00
Julius Härtl 5dbc94bfad Add missing table columns
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:52 +01:00
Julius Härtl b84bdb1080 Make sure the migrations table schema is always checked
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Revert "Make sure the migrations table schema is always checked"

This reverts commit 258955ef738a52d9da2ac2fe59466e6093d7e9bc.

Set current vendor during upgrade and perform migrations table change if needed

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:52 +01:00
Julius Härtl 0207be4c79 Change further columns to be nullable with a default of 0
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:52 +01:00
Julius Härtl 368dac3ba3 Properly migrate from new owncloud avatar location
as the files are not scanned we cannot use the OCP\Files api

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:52 +01:00
Julius Härtl 7c3d3c58d3 Dump autoloader
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:52 +01:00
Julius Härtl 7ce95a4fcb Readd repair steps that are relevant when migrating from ownCloud
This reverts commit d9b1492e03.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:52 +01:00
Julius Härtl de369fdeaa Handle oc_dav_properties migration
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:51 +01:00
Julius Härtl df44acfa07 Add missing index on oc_cards and rename if it previously existed
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:51 +01:00
Julius Härtl 8e72e8c622 Move authtoken login_name column to varchar(255)
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:51 +01:00
Julius Härtl 7c9fcc434f Add missing mount_id index
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:51 +01:00
Julius Härtl 1fe7836c8d Drop attributes on oc_share table
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:51 +01:00
Julius Härtl 3373eff308 Drop assignable systemtag column
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:51 +01:00
Julius Härtl a35cba722d Drop oc_dav_job_status table
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:50 +01:00
Vincent Petry d9bdb5b94b Adjust execution duration to 0
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-14 11:12:50 +01:00
Vincent Petry 958f7968e3 Adjust further columns
- calendarsubscriptions.lastmodified -> not null
- external_config.value -> allow null

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-14 11:12:50 +01:00
Vincent Petry 1fef301334 Adjust calendars.components to 64 chars
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-14 11:12:50 +01:00
Julius Härtl ab40a7c585 Allow major/minor match for owncloud version
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:50 +01:00
Julius Härtl 934f8a17f9 Avoid checking for brute force protection capabilities when upgrading
This might happen a releases that doesn't have this table yet

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:50 +01:00
Julius Härtl 7f1f8963e4 Fix missing authtoken scope
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:50 +01:00
Julius Härtl 5d2988e3bd Drop fk constraints on locks table
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:49 +01:00
Julius Härtl cc9825c70d Allow upgrade from oc 10.5
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:12:49 +01:00
Julius Härtl 5c0e8c648b Bump app versions for federatedfilesharing and files_sharing
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:11:56 +01:00
Julius Härtl 05919a27b8 Update psalm baseline
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:11:00 +01:00
Julius Härtl e155943a3b Resolve conflict in addShare parameters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:11:00 +01:00
Julius Härtl 0bbc0dde10 Update psalm baseline
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:10:59 +01:00
Julius Härtl ace90466d6 Add temporary test for migrating int to string
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:10:59 +01:00
Julius Härtl 3cf7041c94 Adjust default
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:10:59 +01:00
Julius Härtl ff544a2880 Do not register share menu in cases where the files app has not been registered yet
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:10:59 +01:00
Julius Härtl e97897cfa5 Get rid of database.xml in files_sharing
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:10:59 +01:00
Julius Härtl 58f6238af2 Move columns to bigint
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:10:58 +01:00
Julius Härtl 40a8bb53b1 Migrate files_sharing to migrations and move remote_id to a string in share_external
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:10:58 +01:00
Julius Härtl 62ecb57c7f Move remoteId of remote reshares to string
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:10:58 +01:00
Nextcloud bot adc00127ab [tx-robot] updated from transifex 2020-12-14 02:19:37 +00:00
Nextcloud bot cbad21aa2c [tx-robot] updated from transifex 2020-12-13 02:18:42 +00:00
Nextcloud bot c676da759e [tx-robot] updated from transifex 2020-12-12 02:18:57 +00:00
Julien Veyssier ec02f6f3a5 avoid dashboard js crash when accessibility app is not installed
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-12-11 12:22:27 +00:00
Roeland Jago Douma dec23ed599 Merge pull request #24649 from nextcloud/dependabot/npm_and_yarn/stable20/ini-1.3.7
[Security] Bump ini from 1.3.5 to 1.3.7
2020-12-11 13:05:42 +01:00
Nextcloud bot 62a7ec3d28 [tx-robot] updated from transifex 2020-12-11 02:20:27 +00:00
dependabot-preview[bot] 7f755a0718 [Security] Bump ini from 1.3.5 to 1.3.7
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. **This update includes a security fix.**
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-12-10 17:45:20 +00:00
Nextcloud bot 4a51875a73 [tx-robot] updated from transifex 2020-12-10 02:20:27 +00:00
Roeland Jago Douma 9c053c6660 Merge pull request #24621 from nextcloud/version/20.0.3/final
20.0.3
2020-12-09 20:24:07 +01:00
Roeland Jago Douma 7830a6dd14 20.0.3
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-09 20:05:53 +01:00
Nextcloud bot f413277fe1 [tx-robot] updated from transifex 2020-12-09 02:19:57 +00:00
Nextcloud bot c007cd01e9 [tx-robot] updated from transifex 2020-12-08 02:20:33 +00:00
Roeland Jago Douma 0576ca83fd Merge pull request #24584 from nextcloud/version/20.0.3/RC2
20.0.3 RC2
2020-12-07 21:20:14 +01:00
Robin Appelman 694032c54c use in objectstore copy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-12-07 16:07:21 +00:00
Robin Appelman 6790369cfe use storage copy implementation when doing dav copy
instead of using the sabredav fallback (which does a read+write stream copy)

this greatly speeds up dav copies

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-12-07 16:07:06 +00:00
Roeland Jago Douma b9011c1d1d Merge pull request #24563 from nextcloud/backport/24552/stable20
[stable20] Remember me is not an app_password
2020-12-07 11:52:17 +01:00
Roeland Jago Douma d73ba6595a 20.0.3 RC2
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 11:44:46 +01:00
Roeland Jago Douma 519ce1add9 Merge pull request #24582 from nextcloud/backport/24581/stable20
[stable20] Do not load nonexisting setup.js
2020-12-07 11:16:12 +01:00
Julius Härtl 6e2dc3e4f0 Do not load nonexisting setup.js
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-07 08:20:02 +00:00
Nextcloud bot b8e8bc5ddd [tx-robot] updated from transifex 2020-12-07 02:20:52 +00:00
Nextcloud bot 80ef7e14da [tx-robot] updated from transifex 2020-12-06 02:19:39 +00:00
Nextcloud bot 4a2abf3d49 [tx-robot] updated from transifex 2020-12-05 02:19:00 +00:00
Morris Jobke 607e902070 Fix typo
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-04 15:56:29 +00:00
Roeland Jago Douma e6947bd6ca Remember me is not an app_password
While technically they are stored the same. This session variable is
used to indicate that a user is using an app password to authenticate.
Like from a client. Or when having it generated automatically.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-04 15:56:24 +00:00
Christoph Wurst d22fb14d92 Merge pull request #24557 from nextcloud/bugfix/noid/force-composerv1/stable20
[stable20] dont use system composer for autoload checker
2020-12-04 16:17:26 +01:00
Roeland Jago Douma 233d4164a6 Merge pull request #24553 from nextcloud/backport/24550/stable20
[stable20] Generate a new session id if the decrypting the session data fails
2020-12-04 16:09:52 +01:00
Roeland Jago Douma c7cb8eb007 Merge pull request #24556 from nextcloud/revert/stable20/21090
Revert "Do not read certificate bundle from data dir by default"
2020-12-04 15:09:22 +01:00
Julius Härtl 55b9e554ec Force composer v1
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-04 14:27:35 +01:00
Robin Appelman c55197791a cleanup after autoloader generation
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-12-04 14:27:14 +01:00
Robin Appelman ec041c3ad5 dont use system composer for autoload checker
this ensures that the same composer version is used by everyone (and ci)

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-12-04 14:27:03 +01:00
Morris Jobke b1e9752169 Revert "Do not read certificate bundle from data dir by default"
This reverts commit 18b0d753f2.
2020-12-04 13:37:10 +01:00
Roeland Jago Douma f52337e8be Generate a new session id if the decrypting the session data fails
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-04 11:55:31 +00:00
Vincent Petry d4d009fc8e Don't log params of imagecreatefromstring
To prevent flooding the log with actual image data.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-04 09:45:29 +00:00
Nextcloud bot a53871f629 [tx-robot] updated from transifex 2020-12-04 02:19:34 +00:00
Morris Jobke 84250221d7 Merge pull request #24472 from nextcloud/version/20.0.3/RC1
20.0.3 RC1
2020-12-03 13:49:47 +01:00
Roeland Jago Douma 8f2ba14e0a 20.0.3 RC1
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-03 13:11:53 +01:00
Morris Jobke 55a76ab3e2 Merge pull request #24534 from nextcloud/3rdparty/stable20/archive_tar
[3rdparty][security] Archive TAR to 1.4.11
2020-12-03 13:11:12 +01:00
Roeland Jago Douma ce953d1571 Merge pull request #24532 from nextcloud/backport/24409/stable20
[stable20] Also run repair steps when encryption is disabled but a legacy key is present
2020-12-03 12:22:41 +01:00
Roeland Jago Douma a91320ff0c [3rdparty][security] Archive TAR to 1.4.11
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-03 11:28:41 +01:00
Morris Jobke 1a041f7ac7 Merge pull request #24530 from nextcloud/fix/stable20-nextcloud-log-normalizer
[stable20] Replace abandoned log normalizer with our fork
2020-12-03 11:14:46 +01:00
Morris Jobke 73f854dc0a Merge pull request #24531 from nextcloud/backport/24516/stable20
[stable20] Add icon to user limit notification
2020-12-03 11:14:03 +01:00
Roeland Jago Douma ff0d6c1cb9 Merge pull request #24527 from nextcloud/backport/24519/stable20
[stable20] Fix vsprint parameter
2020-12-03 11:00:56 +01:00
Julius Härtl 14d95cb2e3 Also handle legacy cipher support when encryption is disabled but an old master key is present
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-03 09:56:59 +00:00
Morris Jobke 4c5662a658 Improve wording
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-03 09:00:56 +00:00
Morris Jobke 3d132f293f Add icon to user limit notification
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-03 09:00:54 +00:00
Christoph Wurst 67e5af58ed Replace abandoned log normalizer with our fork
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-03 09:50:10 +01:00
Roeland Jago Douma f6c24133a4 Merge pull request #24517 from nextcloud/backport/24459/stable20
[stable20] Only execute plain mimetype check for directories and do the fallback…
2020-12-03 09:37:44 +01:00
Roeland Jago Douma 428f0ec151 Fix vsprint parameter
%2\$; is not valid. On php7 this is just ignored but on php8 it gives an
error. %2\$s; works.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-03 08:20:04 +00:00
Nextcloud bot 6093d1bcc1 [tx-robot] updated from transifex 2020-12-03 02:20:01 +00:00
Morris Jobke 1181058d18 Only execute plain mimetype check for directories and do the fallback only for non-directories
Ref #23096

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 20:02:27 +00:00
Morris Jobke 54ab2b9f28 Merge pull request #24513 from nextcloud/backport/24501/stable20
[stable20] set mountid for personal external storage mounts
2020-12-02 20:50:08 +01:00
Roeland Jago Douma bdbb60a67b Merge pull request #24509 from nextcloud/backport/23257/stable20
[stable20] Fix file size computation on 32bit platforms
2020-12-02 20:03:24 +01:00
Robin Appelman 987cd0d5ed set mountid for personal external storage mounts
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-12-02 18:50:58 +00:00
Roeland Jago Douma 4d68c618e3 Merge pull request #24511 from nextcloud/backport/23278/stable20
[stable20] Allow subscription to indicate that a userlimit is reached
2020-12-02 19:47:18 +01:00
Morris Jobke a8780debd3 Add notification for user limit
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 17:24:44 +00:00
Morris Jobke d2fd49c461 Allow subscription to indicate that a userlimit is reached
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 17:24:42 +00:00
Greta 02427cd76f Merge pull request #24491 from nextcloud/backport/24376/stable20
[stable20] fix loading mtime of new file in conflict dialog in firefox
2020-12-02 16:45:17 +01:00
aler9 dc7eb53a8f Fix file size computation on 32bit platforms
Signed-off-by: aler9 <46489434+aler9@users.noreply.github.com>
2020-12-02 15:27:30 +00:00
Morris Jobke e8b284e807 Merge pull request #24502 from nextcloud/backport/24499/stable20
[stable20] Harden setup check for TLS version if host is not reachable
2020-12-02 16:14:12 +01:00
Morris Jobke 03956c5862 Harden setup check for TLS version if host is not reachable
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 13:27:43 +00:00
Robin Appelman 1f6e5c6d8e fix loading mtime of new file in conflict dialog in firefox
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-12-02 07:37:19 +00:00
Nextcloud bot 2a0c0ea584 [tx-robot] updated from transifex 2020-12-02 02:20:20 +00:00
Morris Jobke 4949429567 Merge pull request #24477 from nextcloud/backport/24189/stable20
[stable20] Set frame-ancestors to none if none are filled
2020-12-01 23:44:35 +01:00
Morris Jobke 41cc1f7360 Merge pull request #24478 from nextcloud/backport/24186/stable20
[stable20] Move the password fiels of chaging passwords to post
2020-12-01 23:29:35 +01:00
Morris Jobke 74f734dc97 Merge pull request #24479 from nextcloud/backport/24188/stable20
[stable20] Move the global password for files external to post
2020-12-01 23:28:33 +01:00
Morris Jobke 910fecf8f8 Merge pull request #24483 from nextcloud/backport/24094/stable20
[stable20] Only attempt to move to trash if a file is not in appdata
2020-12-01 23:20:48 +01:00
Roeland Jago Douma 3fb850940f Set frame-ancestors to none if none are filled
frame-ancestors doesn't fall back to default-src. So when we apply a
very restricted CSP we should make sure to set it to 'none' and not
leave it empty.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-01 22:23:13 +01:00
Roeland Jago Douma 3e982a3346 Move the password fiels of chaging passwords to post
* This is not actually used with GET (obviously). But else some scanners
  trip on it

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-01 22:23:02 +01:00
Roeland Jago Douma c24534866b Move the global password for files external to post
Again more false positives in some scanners

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-01 22:22:33 +01:00
Julius Härtl 7d786a4e37 Only attempt to move to trash if a file is not in appdata
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-01 22:20:11 +01:00
Morris Jobke 86da5013c8 Merge pull request #24325 from nextcloud/backport/24103/stable20
[stable20] Only check path for being accessible when the storage is a object home
2020-12-01 11:04:22 +01:00
Roeland Jago Douma ebf046bc15 Merge pull request #24462 from nextcloud/backport/24460/stable20
[stable20] Use correct l10n source in files_sharing JS code
2020-12-01 08:48:16 +01:00
Nextcloud bot 965614f3e2 [tx-robot] updated from transifex 2020-12-01 02:19:56 +00:00
Morris Jobke fba0145bef Use correct l10n source in files_sharing JS code
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-30 19:30:28 +00:00
Morris Jobke d56300a86c Merge pull request #24455 from nextcloud/backport/24451/stable20
[stable20] external storages: save group ids not display names in configuration
2020-11-30 17:22:42 +01:00
Morris Jobke 4a2b72dcbe Merge pull request #24453 from nextcloud/backport/24449/stable20
[stable20] Store scss variables under a different prefix for each theming config version
2020-11-30 16:54:02 +01:00
Arthur Schiwon a6d288e1ac save group ids not display names in configuration
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-30 14:49:11 +00:00
Julius Härtl 7d57b2c317 Store scss variables under a different prefix for each theming config version
The main issue with using the general theming- prefix is that with APCu caching
the cache is not shared between processes, so when trying to reset the cache
through the CLI, e.g. when updating the theming config the old cache is never
invalidated.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-30 14:24:28 +00:00
Morris Jobke 6916240d98 Merge pull request #24446 from nextcloud/backport/23652/stable20
[stable20] Fix public calendars shared to circles
2020-11-30 11:24:38 +01:00
Morris Jobke b1f3f5d7cb Merge pull request #24443 from nextcloud/backport/24357/stable20
[stable20] Make sure we add new line between vcf groups exports
2020-11-30 10:24:27 +01:00
Daniel Kesselberg 6635dbb3bd A valid user session is required for circles.
The circles app depends on a valid userId. A public shared calender might be viewed by guests without a user session. For such requests the principal is null.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-11-30 09:01:53 +00:00
Daniel Kesselberg 761ee14fd7 Update phpdoc for circleToPrincipal
as the QueryException is already catched inside circleToPrincipal.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-11-30 09:01:51 +00:00
John Molakvoæ (skjnldsv) 8e262d9e59 Make sure we add new line between vcf groups exports
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-11-30 08:13:46 +00:00
Nextcloud bot c1e993333e [tx-robot] updated from transifex 2020-11-30 02:19:54 +00:00
Nextcloud bot 7ea0f2b936 [tx-robot] updated from transifex 2020-11-29 02:19:21 +00:00
Nextcloud bot 7ad1420e61 [tx-robot] updated from transifex 2020-11-28 02:18:33 +00:00
Christoph Wurst f4d1f01209 Merge pull request #24387 from nextcloud/backport/24382/stable20
[stable20] Properly encode path when fetching inherited shares
2020-11-27 09:44:45 +01:00
Nextcloud bot 80bf325bb0 [tx-robot] updated from transifex 2020-11-27 02:18:26 +00:00
blizzz e78989fd8a Merge pull request #24391 from nextcloud/backport/24375/stable20
[stable20] formatting remote sharer should take protocol, path into account
2020-11-26 22:13:43 +01:00
npmbuildbot-nextcloud[bot] ad79aa3f32 Compile assets
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-26 14:11:40 +00:00
Joas Schilling 61f1c12fb1 Merge pull request #24333 from nextcloud/backport/24315/stable20
[stable20] avoid empty null default with value that will be inserted anyways
2020-11-26 14:50:27 +01:00
Arthur Schiwon 8e8861f716 formatting remote sharer should take protocol, path into account
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-26 13:12:11 +00:00
Julius Härtl 72a3f5cd31 Properly encode path when fetching inherited shares
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-26 12:39:57 +00:00
Nextcloud bot 921f9441d3 [tx-robot] updated from transifex 2020-11-26 02:18:57 +00:00
blizzz 76671c2a46 Merge pull request #24377 from nextcloud/backport/24374/stable20
[stable20] Use proper bundles for files client and fileinfo
2020-11-25 20:38:29 +01:00
Julius Härtl 49bd82292c Files client and info bundles are always loaded so we don't need to load them again
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-25 16:11:36 +00:00
Roeland Jago Douma 2003995e32 Merge pull request #24353 from nextcloud/backport/24162/stable20
[stable20] set the display name of federated sharees from addressbook
2020-11-25 16:18:23 +01:00
Roeland Jago Douma ae9fd3e225 Merge pull request #24367 from nextcloud/backport/24363/stable20
[stable20] Catch storage not available in versions expire command
2020-11-25 16:17:34 +01:00
Arthur Schiwon 4e6f0df777 send expected format of cloud id
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-25 14:16:08 +01:00
Christoph Wurst 2ff42f6b1a Catch storage not available in versions expire command
External storage with session credentials is not accessible without a
user session, hence background jobs and CLI commands can't work with
them. The previously unhandled exception causes logged errors in the
nextcloud log. This patch catches the specific exception and logs it as
warnings. So for a production instance the error won't spam their logs
for this non-recoverable and technically unsolvable error if the minimum
log level is set to the default of 3 (error).

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-25 10:40:21 +00:00
Nextcloud bot 940e8c3a99 [tx-robot] updated from transifex 2020-11-25 02:19:04 +00:00
Arthur Schiwon c9814c716a set the display name of federated sharees from addressbook
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-24 22:52:31 +01:00
John Molakvoæ 6e279bf6c6 Merge pull request #24346 from nextcloud/backport/24341/stable20
[stable20] Fix the config key on the sharing expire checkbox
2020-11-24 18:38:46 +01:00
John Molakvoæ bd4931032e Merge pull request #24342 from nextcloud/backport/24331/stable20
[stable20] Fix contacts menu position and show uid as a tooltip
2020-11-24 18:37:23 +01:00
Julius Härtl a1a178eb53 Fix contacts menu position and show uid as a tooltip
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-24 14:55:21 +00:00
Christoph Wurst 4b9d8c75ec Fix the config key on the sharing expire checkbox
We don't use `shareapi_internal_enforce_expire_date` anywhere.
`shareapi_enforce_internal_expire_date` is the one we want.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-24 14:54:02 +00:00
Arthur Schiwon 4850019fcd avoid empty null default with value that will be inserted anyways
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-24 10:31:27 +00:00
Julius Härtl 866e273599 Only check path for being accessible when the storage is a object home
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-24 09:14:39 +00:00
Nextcloud bot 56cee9e405 [tx-robot] updated from transifex 2020-11-24 02:19:05 +00:00
Morris Jobke e375010589 Merge pull request #24297 from nextcloud/backport/stable20/23023
[stable20] Delete files that exceed trashbin size immediately
2020-11-23 21:06:33 +01:00
Christoph Wurst fcaa75858c Merge pull request #24311 from nextcloud/fix/stable20-sabre-parse-xml-errors
[stable20] Update sabre/xml to fix XML parsing errors
2020-11-23 14:40:34 +01:00
Christoph Wurst 55d9834c95 Update sabre/xml to fix XML parsing errors
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-23 14:00:19 +01:00
Julius Härtl e241f14f24 Delete files that exceed trashbin size immediately
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-23 09:11:53 +01:00
Nextcloud bot aaa9c0ba6c [tx-robot] updated from transifex 2020-11-23 02:18:57 +00:00
Nextcloud bot ac8bb267a3 [tx-robot] updated from transifex 2020-11-22 02:18:39 +00:00
Nextcloud bot 9a0c85d0cd [tx-robot] updated from transifex 2020-11-21 02:19:27 +00:00
Morris Jobke 347aaf23b2 Merge pull request #24249 from nextcloud/backport/24241/stable20
[stable20] Harden EncryptionLegacyCipher a bit
2020-11-20 22:42:17 +01:00
Morris Jobke e772fd6409 Merge pull request #24263 from nextcloud/backport/24108/stable20
[stable20] Use correct year for generated birthdays events
2020-11-20 22:41:51 +01:00
Sven Strickroth 5aac8a1b34 Use correct year for generated birthdays events
'X-APPLE-OMIT-YEAR' is not always present, at least iOS 12.4 uses the hard coded date of 1604 (the start of the gregorian calendar) when the year is unknown.

cf. https://forums.bitfire.at/topic/2050/bday-without-year-for-vcard-3-0-if-server-drops-property-x-apple-omit-year and https://gitlab.com/CardBook/CardBook/-/issues/586

Signed-off-by: Sven Strickroth <email@cs-ware.de>
2020-11-20 20:47:56 +00:00
Morris Jobke cb2bed6a8a Merge pull request #24258 from nextcloud/backport/24242/stable20
[stable20] Update ScanLegacyFormat.php
2020-11-20 21:31:17 +01:00
Morris Jobke 72ba3dfe3c Merge pull request #24259 from nextcloud/backport/24257/stable20
[stable20] Simple typo in comments
2020-11-20 21:29:15 +01:00
Carlos Ferreira a8ba2df8e6 Simple typo in comments 2020-11-20 19:45:23 +00:00
essys 8d44a1006a Update ScanLegacyFormat.php
Fixed a small typo on line 99.
2020-11-20 19:42:37 +00:00
Morris Jobke e0e3334fc2 Merge pull request #24230 from nextcloud/backport/24007/stable20
[stable20] allow selecting multiple columns with SELECT DISTINCT
2020-11-20 14:27:27 +01:00
Morris Jobke 7fa352b28c Merge pull request #24228 from nextcloud/backport/24135/stable20
[stable20] Fix nextcloud logo in email notifications misalignment
2020-11-20 14:23:00 +01:00
Roeland Jago Douma 06286f8c0e Harden EncryptionLegacyCipher a bit
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-20 13:18:25 +00:00
Roeland Jago Douma 322b0ab2b3 Merge pull request #24239 from nextcloud/backport/24203/stable20
[stable20] Use regex when searching on single file shares
2020-11-20 10:15:04 +01:00
Roeland Jago Douma 3839c8449a Merge pull request #24231 from nextcloud/backport/23757/stable20
[stable20] use file name instead of path in 'not allowed to share' message
2020-11-20 10:04:54 +01:00
Roeland Jago Douma 10086b3f43 Merge pull request #24232 from nextcloud/backport/24211/stable20
[stable20] Fix setting images through occ for theming
2020-11-20 10:04:30 +01:00
Roeland Jago Douma 37df208bd7 Limit shared cache search if it is just a file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-20 07:27:47 +00:00
Nextcloud bot 78b62b6b65 [tx-robot] updated from transifex 2020-11-20 02:20:19 +00:00
Julius Härtl c8e9694a69 Fix setting images through occ for theming
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-19 22:18:55 +00:00
Robin Appelman f65a89dd07 use file name instead of path in 'not allowed to share' message
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-19 21:44:42 +00:00
Robin Appelman 22bf656e02 allow selecting multiple columns with SELECT DISTINCT
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-19 21:41:13 +00:00
medcloud 7ccf700432 Fix #23357
Signed-off-by: medcloud <42641918+medcloud@users.noreply.github.com>
2020-11-19 20:38:54 +00:00
Roeland Jago Douma 8021bacbdc Merge pull request #24181 from nextcloud/backport/24102/stable20
[stable20] Check quota of subdirectories when uploading to them
2020-11-19 10:40:11 +01:00
Roeland Jago Douma 2c5a1fd636 Merge pull request #24196 from nextcloud/backport/24098/stable20
[stable20] circleId too short in some request
2020-11-19 10:09:45 +01:00
Roeland Jago Douma d0417e0d1f Merge pull request #24212 from nextcloud/backport/24207/stable20
[stable20] missing level in ScopedPsrLogger
2020-11-19 09:50:32 +01:00
Maxence Lange 8c398453ac missing level
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2020-11-19 07:40:38 +00:00
Nextcloud bot 6a4ced077e [tx-robot] updated from transifex 2020-11-19 02:20:21 +00:00
Roeland Jago Douma 96f99a40f5 Merge pull request #24172 from nextcloud/version/20.0.2/final
20.0.2
2020-11-18 20:35:11 +01:00
Maxence Lange d4ea5fd63f circleId too short in some request
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2020-11-18 07:57:22 +00:00
Nextcloud bot c03db79569 [tx-robot] updated from transifex 2020-11-18 02:18:47 +00:00
Roeland Jago Douma cc42b5e502 Merge pull request #24183 from nextcloud/revert-24178-backport/24098/stable20
Revert "[stable20] circleId too short in some request"
2020-11-17 21:53:22 +01:00
Julius Härtl 8c7030e0bd Bump bundles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-17 19:47:56 +01:00
Julius Härtl 892bb8cae5 Check for target folder available quota when uploading
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-17 15:33:54 +01:00
Julius Härtl b134107316 Fetch quota with files propfind
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-17 15:33:54 +01:00
Christoph Wurst 1941f1b1a8 Revert "[stable20] circleId too short in some request" 2020-11-17 14:20:02 +01:00
Christoph Wurst f06f9a91b3 Merge pull request #24178 from nextcloud/backport/24098/stable20
[stable20] circleId too short in some request
2020-11-17 13:31:57 +01:00
Maxence Lange 6db68e9ba3 circleId too short in some request
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2020-11-17 10:28:24 +00:00
Roeland Jago Douma 35c29b46ea 20.0.2
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-17 09:38:45 +01:00
Nextcloud bot 51d8134e50 [tx-robot] updated from transifex 2020-11-17 02:18:36 +00:00
Roeland Jago Douma f1da86e7a1 Merge pull request #24091 from nextcloud/version/20.0.2/rc2
20.0.2 RC2
2020-11-16 20:55:05 +01:00
Daniel Calviño Sánchez cdbb2b3e4b Merge pull request #24159 from nextcloud/backport/24069/stable20
[stable20] Fix default internal expiration date
2020-11-16 17:46:37 +01:00
Daniel Calviño Sánchez 34a143b05f Add integration tests for creating shares with default expiration dates
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 13:17:01 +00:00
Daniel Calviño Sánchez bf844567a5 Reset app configs by deleting the values instead of setting the defaults
This avoids the need to keep the default values in the integration tests
in sync with the code, and also makes possible to reset values with
"dynamic" defaults (defaults that depend on other values).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 13:17:00 +00:00
Daniel Calviño Sánchez 1464ace788 Add unit tests for "validateExpirationDateInternal"
They were copied and adjusted as needed from the tests for
"validateExpirationDate".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 13:16:59 +00:00
Daniel Calviño Sánchez 182e28bfbc Fix default internal expiration date
The default expiration date for internal shares was set from the default
link expiration date instead of the internal one.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 13:16:57 +00:00
Daniel Calviño Sánchez 709abd4fc7 Add explicit time to test date for clarity
This shows in a clearer way that the expected expiration date is the
original one, but without time.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 13:16:56 +00:00
Daniel Calviño Sánchez 731cce4542 Add unit test for expiration date with date and with default
This adds back what was being actually tested in the unit test fixed in
the previous commit.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 13:16:55 +00:00
Daniel Calviño Sánchez 115a988cd2 Fix unit test for expiration date without date but with default
The expiration date was explicitly given, so it was not testing what it
should. Moreover, "link_defaultExpDays" needs to be mapped when testing
the default value (even if it will just fallback to the value of
"shareapi_expire_after_n_days").

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 13:16:53 +00:00
Daniel Calviño Sánchez eaa43d22e2 Fix unit test method name
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 13:16:52 +00:00
Daniel Calviño Sánchez 4e418100bf Fix unit test for verifying enforced valid expiration date.
The enforced expiration date was not actually enabled, as for that
"shareapi_default_expire_date" needs to be explicitly set to "yes".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 13:16:51 +00:00
Daniel Calviño Sánchez 20c72ac03e Fix unit test for verifying enforced expire date too far in the future
The test should fail if no exception was thrown, and no exception was
thrown due to a missing configuration parameter. However, the use of
"addToAssertionCount(1)" made the test pass even if no exception was
thrown and, therefore, to silently fail.

Now the missing configuration parameter was added and the test will fail
if the expected exception is not thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 13:16:49 +00:00
Daniel Calviño Sánchez 22357a72e5 Add unit tests to enforce a relaxed default share expiration date
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 13:16:48 +00:00
Daniel Calviño Sánchez b75c171ee2 Remove wrong and misleading comment
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 13:16:47 +00:00
Daniel Calviño Sánchez d6ba3b2f7c Remove extra spaces
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 13:16:45 +00:00
Daniel Calviño Sánchez 76bbbca220 Fix typo in variable name
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 13:16:44 +00:00
Daniel Calviño Sánchez 446c90879f Fix typos in method names
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 13:16:42 +00:00
Roeland Jago Douma b14ec966c1 Merge pull request #24156 from nextcloud/backport/24112/stable20
[stable20] Set up FS before querying storage info in settings
2020-11-16 14:14:43 +01:00
John Molakvoæ f4d92d2e3a Merge pull request #24153 from nextcloud/dependencies/dompurify 2020-11-16 13:12:40 +01:00
Roeland Jago Douma bca0633e2b Merge pull request #24147 from nextcloud/backport/24146/stable20
[stable20] Don't throw on SHOW VERSION query
2020-11-16 12:08:56 +01:00
Vincent Petry 32758894a4 Set up FS before querying storage info in settings
The personal info section of the personal settings is querying the
storage quota information. For this it requires the FS to be setup which
is not always guaranteed.

This fixes an issue where refreshing the settings page would cause it to
fail after Redis caches are full. It is likely that when Redis cache is
populated, some code path is initializing the FS, so it works so far.
But when the cache is populated, that code path is skipped so the FS is
not guaranteed to be setup...

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-11-16 11:06:35 +00:00
Julius Härtl 889d162ab7 Bump bundles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-16 11:36:35 +01:00
Julius Härtl ccc845b1c4 Bump dompurify to 2.2.2
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-16 11:30:59 +01:00
Joas Schilling 7a821da1bc Merge pull request #24079 from nextcloud/backport/24053/stable20
[stable20] Make is_user_defined nullable so we can store false on oracle
2020-11-16 11:23:17 +01:00
John Molakvoæ 18f5ad1a34 Merge pull request #24114 from nextcloud/backport/24096/stable20
[stable20] Convert the card resource to a string if necessary
2020-11-16 10:15:18 +01:00
Joas Schilling f10327b245 Don't throw on SHOW VERSION query
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-16 08:59:47 +00:00
Joas Schilling 9b694e59f5 Bump versions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-16 08:54:30 +01:00
Joas Schilling d334dd1455 Merge pull request #24106 from nextcloud/backport/24085/stable20
[stable20] Register new command db:add-missing-primary-keys
2020-11-16 08:50:01 +01:00
Nextcloud bot 9abc65c573 [tx-robot] updated from transifex 2020-11-16 02:19:33 +00:00
Nextcloud bot c9001eb7ef [tx-robot] updated from transifex 2020-11-15 02:19:11 +00:00
Nextcloud bot 66b6ccc69e [tx-robot] updated from transifex 2020-11-14 02:19:47 +00:00
Christoph Wurst 07861fe52d Convert the card resource to a string if necessary
Apparently the fetched column can be a string or resource. Hence we have
to catch the resource type and convert it to a string.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-13 18:18:24 +00:00
MichaIng e0dbfdf575 Register new command db:add-missing-primary-keys
Introduced with: https://github.com/nextcloud/server/commit/d5df033ede1f2b19b87c365b1f808130023edf17

Signed-off-by: MichaIng <micha@dietpi.com>
2020-11-13 14:41:51 +00:00
Roeland Jago Douma bf95044a29 20.0.2 RC2
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-13 08:38:57 +01:00
Roeland Jago Douma 8ebafbb7dc Merge pull request #24081 from nextcloud/backport/24066/stable20
[stable20] Fix default internal expiration date enforce
2020-11-13 08:37:54 +01:00
John Molakvoæ (skjnldsv) 680853d077 Fix default internal expiration date enforce
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-13 06:31:16 +00:00
Nextcloud bot 584cfa4e2e [tx-robot] updated from transifex 2020-11-13 02:19:35 +00:00
Morris Jobke ca363131d9 Dump autoloader
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-12 20:46:59 +00:00
Joas Schilling 1def6f92ee Also make direct_edit.accessed nullable
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 20:46:57 +00:00
Joas Schilling 32d7459d8b Make is_user_defined nullable so we can store false on oracle
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 20:46:55 +00:00
Roeland Jago Douma 105fc60eb1 Merge pull request #23989 from nextcloud/version/20.0.2/rc1
20.0.2 RC1
2020-11-12 21:08:19 +01:00
Roeland Jago Douma e61e3f9eb3 20.0.2 RC1
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-12 19:57:13 +01:00
Morris Jobke 2e3637f826 Merge pull request #24049 from nextcloud/backport/23882/stable20
[stable20] Run unit tests against oracle
2020-11-12 19:54:36 +01:00
Morris Jobke 9497dca2b0 Update psalm-baseline
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-12 19:38:06 +01:00
Robin Appelman 388b3107eb fix migration of oc_credentials table
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-12 15:56:34 +01:00
Joas Schilling d09a22069f Update baseline, I'm sorry
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:52 +01:00
Joas Schilling dabed84bd4 Fix unique key in test table
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:52 +01:00
Joas Schilling 07c28f1576 Fix naming of jobs and steps
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:52 +01:00
Joas Schilling cd76043691 Fix CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:52 +01:00
Joas Schilling bb52911d16 Create primary keys on all tables and add a command to create the afterwards
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:52 +01:00
Joas Schilling f3c183b6c3 Replace the credentials table with one that can have empty user
Primary key columns on Oracle can not have empty strings

Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:52 +01:00
Joas Schilling dee42027ed Don't try to update on NotNullConstraintViolationException, only on unique or foreign key
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:51 +01:00
Joas Schilling a66591ee79 Fix comparing the empty string for global credentials
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:51 +01:00
Joas Schilling 97b0402984 Empty string is returned as null, but empty string in file cache is the root and exists
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:51 +01:00
Joas Schilling b6ce689e25 Fix public calendars as they are stored with null on oracle
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:51 +01:00
Joas Schilling 8ff0523c3d Make sure columns with an empty default are nullable for Oracle
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:51 +01:00
Joas Schilling fcef3c0e8a Fix "Invalid fetch style: 12" on Oracle
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:51 +01:00
Joas Schilling 48c2f6d5a0 Make the test pass on repeating calls
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:51 +01:00
Joas Schilling e3b3ff6d43 Skip the insertIfNotExists() tests on Oracle because it doesn't work with clob
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:51 +01:00
Joas Schilling 3ec48cd59f Easier debugging and spell fix
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:50 +01:00
Joas Schilling f58ffadb34 Use a different column for the primary key as we can not insert it on oracle
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:50 +01:00
Julius Härtl a35b0956f1 Add github action for oci8
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-12 12:57:50 +01:00
Nextcloud bot 140068e91d [tx-robot] updated from transifex 2020-11-12 02:19:35 +00:00
Roeland Jago Douma a0f95cd1d3 Merge pull request #24058 from nextcloud/backport/24054/stable20
[stable20] Manually iterate over calendardata when oracle is used
2020-11-11 21:54:55 +01:00
Roeland Jago Douma 8270aed206 Merge pull request #24050 from nextcloud/backport/23915/stable20
[stable20] Use png icons in caldav reminder emails
2020-11-11 21:27:53 +01:00
Julius Härtl bf0dbffe81 Manually iterate over calendardata when oracle is used
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-11 16:12:25 +00:00
Morris Jobke bcb6a71548 Merge pull request #24044 from nextcloud/backport/24042/stable20
[stable20] Fix sharing tab state not matching resharing admin settings
2020-11-11 13:45:46 +01:00
Richard Steinmetz b82b3b0140 Use png icons in caldav reminder emails
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2020-11-11 12:38:21 +00:00
Daniel Calviño Sánchez 487c603f95 Add integration tests for default share permissions
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-11 11:51:28 +01:00
Daniel Calviño Sánchez f58174fdd8 Add acceptance tests for reshares by link when resharing is disabled
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-11 11:51:28 +01:00
Daniel Calviño Sánchez 7d7169fdbe Add acceptance tests for reshares when resharing is disabled
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-11 11:51:28 +01:00
Daniel Calviño Sánchez bafab8af2d Disable share input for a received share if resharing is not allowed
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-11 11:51:26 +01:00
Daniel Calviño Sánchez c034dff408 Do not show "Can reshare" in the menu if resharing is not allowed
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-11 11:51:18 +01:00
Joas Schilling 60ca39bb53 Merge pull request #24033 from nextcloud/backport/23993/stable20
[stable20] Don't leave cursors open
2020-11-11 10:56:53 +01:00
Nextcloud bot 3d3cebc321 [tx-robot] updated from transifex 2020-11-11 02:20:23 +00:00
Joas Schilling 19816fe85f Don't leave cursors open when tests fail
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 14:18:02 +00:00
Morris Jobke 6a5b921284 Merge pull request #23950 from nextcloud/backport/23928/stable20
[stable20] Fix repair mimetype step to not leave stray cursors
2020-11-10 13:46:15 +01:00
Morris Jobke cecf579e81 Update psalm-baseline.xml to accept new errors
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-10 13:43:51 +01:00
Joas Schilling 5f3d62600e Fix repair mimetype step to not leave stray cursors
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 10:27:09 +01:00
Morris Jobke 73c2ad293b Merge pull request #23998 from nextcloud/backport/23937/stable20
[stable20] Use query builder instead of OC_DB in OC\Files\*
2020-11-10 10:26:04 +01:00
Morris Jobke bf6aa03eb3 Merge pull request #23995 from nextcloud/backport/23741/stable20
[stable20] Unlock when promoting to exclusive lock fails
2020-11-10 10:16:34 +01:00
Roeland Jago Douma 8edc29bfef Merge pull request #23955 from nextcloud/backport/23938/stable20
[stable20] Replace some usages of OC_DB in OC\Share\* with query builder
2020-11-10 08:59:54 +01:00
John Molakvoæ 7032c880f0 Merge pull request #24012 from nextcloud/backport/23981/stable20
[stable20] Fix js search in undefined ocs response
2020-11-10 07:00:19 +01:00
Nextcloud bot 34fae53598 [tx-robot] updated from transifex 2020-11-10 02:18:56 +00:00
John Molakvoæ (skjnldsv) 49676d909b Fix js search in undefined ocs response
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-09 19:28:15 +00:00
Roeland Jago Douma c1e43efa35 Merge pull request #24001 from nextcloud/backport/23889/stable20
[stable20] Shortcut to avoid file system setup when generating the logo URL
2020-11-09 19:55:38 +01:00
Roeland Jago Douma 0d52ba6239 Merge pull request #24004 from nextcloud/backport/23999/stable20
[stable20] Remove old legacy scripts references
2020-11-09 19:38:21 +01:00
John Molakvoæ 559acf83ed Removed config.js 2020-11-09 16:01:06 +00:00
John Molakvoæ 750455399d Remove old legacy search script 2020-11-09 16:01:05 +00:00
Morris Jobke 1a26b63246 Merge pull request #23996 from nextcloud/backport/23982/stable20
[stable20] Make sure root storage is valid before checking its size
2020-11-09 15:37:24 +01:00
Morris Jobke cc777911c2 Shortcut to avoid file system setup when generating the logo URL
If an SVG is requested and the app config value for logoMime is set then the logo is there. Otherwise we need to check it and maybe also generate a PNG from the SVG (that's done in getImage() which needs to be called then).

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-09 13:13:31 +00:00
Morris Jobke 3459db0472 Merge pull request #23992 from nextcloud/backport/23574/stable20
[stable20] Fix link share label placeholder not showing
2020-11-09 14:10:41 +01:00
Joas Schilling adcc942553 Use query builder instead of OC_DB in OC\Files\*
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-09 11:01:09 +00:00
John Molakvoæ (skjnldsv) 0c4297cee9 Make sure root storage is valid before checking its size
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-11-09 10:05:54 +00:00
Ashod Nakashian 7298d037b2 Unlock when promoting to exclusive lock fails
In certain cases changeLock to EXCLUSIVE fails
and throws LockedException. This leaves the
file locked as SHARED in file_put_contents,
which prevents retrying (because on second
call file_put_contents takes another SHARED
lock on the same file, and changeLock doesn't
allow more than a single SHARED lock to promote
to EXCLUSIVE).

To avoid this case, we catch the LockedException
and unlock before re-throwing.

Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-11-09 10:03:15 +00:00
Morris Jobke 20885847c8 Merge pull request #23971 from nextcloud/backport/23936/stable20
[stable20] Use query builder instead of OC_DB in trashbin
2020-11-09 10:27:29 +01:00
Morris Jobke f28c436fd5 Check in failing psalm checks
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-09 10:21:05 +01:00
Morris Jobke 40c4d24e31 Merge pull request #23975 from nextcloud/backport/23923/stable20
[stable20] Fix greatest/least order for oracle
2020-11-09 10:17:11 +01:00
Daniel Kesselberg a01da78f1d Add explicit typecast for $value.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-11-09 10:13:36 +01:00
Gary Kim baf06b9894 Fix link share label placeholder not showing
Signed-off-by: Gary Kim <gary@garykim.dev>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-09 08:29:05 +00:00
Nextcloud bot 0624ca3527 [tx-robot] updated from transifex 2020-11-09 02:19:02 +00:00
Nextcloud bot d34145f942 [tx-robot] updated from transifex 2020-11-08 02:18:33 +00:00
Joas Schilling b3dfa9290d Update parameters
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-07 15:57:47 +00:00
Joas Schilling 2e3cffc53b Make sure Oracle always casts everything in the best way
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-07 15:57:46 +00:00
Joas Schilling c71cc6824e Use Query builder function
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-07 15:57:45 +00:00
Joas Schilling d111e88d4c Fix order of GREATEST for Oracle
As per https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions060.htm
Oracle uses the first value to cast the rest or the values.
So when the first value is a plain int, instead of doing the math,
it will cast the expression to int and continue with a potential 0.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-07 15:57:44 +00:00
Roeland Jago Douma 71de05f775 Merge pull request #23951 from nextcloud/backport/23922/stable20
[stable20] Improve query type detection
2020-11-07 10:49:06 +01:00
Joas Schilling ef22580a32 Use query builder instead of OC_DB in trashbin
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-07 09:21:46 +00:00
Roeland Jago Douma bac92bb814 Merge pull request #23954 from nextcloud/backport/23943/stable20
[stable20] Fix iLike() falsely turning escaped % and _ into wildcards
2020-11-07 09:18:23 +01:00
Roeland Jago Douma a5c6abc93a Merge pull request #23948 from nextcloud/backport/23940/stable20
[stable20] Skip already loaded apps in loadApps
2020-11-07 07:59:52 +01:00
Nextcloud bot c9f3f2563f [tx-robot] updated from transifex 2020-11-07 02:19:08 +00:00
Joas Schilling 73a09a4f54 Replace some usages of OC_DB in OC\Share\* with query builder
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 21:43:46 +00:00
Joas Schilling 3a7e2fbff1 Fix iLike() falsely turning escaped % and _ into wildcards
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 21:29:48 +00:00
Morris Jobke f8b550dab7 Merge pull request #23935 from nextcloud/backport/23921/stable20
[stable20] Fix casting of integer and boolean on Oracle
2020-11-06 22:24:31 +01:00
Joas Schilling 3ffd31353c Improve query type detection
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 21:20:44 +00:00
Morris Jobke a2c9915ca4 Merge pull request #23924 from nextcloud/backport/23920/stable20
[stable20] Bearer must be in the start of the auth header
2020-11-06 22:10:01 +01:00
Roeland Jago Douma ef5cee12d1 Skip already loaded apps in loadApps
Otherwise you might end up calling a lot of functions unneeded.
And while the individual calls are cheap if you multiply them by 20k
they still get somewhat expensive.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-06 21:01:12 +00:00
Joas Schilling 990bb07002 Cast bool things to numbers as that is how they are stored in the database
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 13:36:57 +01:00
Joas Schilling 2b0b57d304 Fix casting to integer on Oracle
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 10:42:15 +00:00
Roeland Jago Douma 93211e7ded Merge pull request #23917 from nextcloud/backport/23887/stable20
[stable20] Do not emit UserCreatedEvent twice
2020-11-06 10:55:41 +01:00
Roeland Jago Douma c9bf32b454 Bearer must be in the start of the auth header
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-06 08:21:30 +00:00
Nextcloud bot 43a80714a7 [tx-robot] updated from transifex 2020-11-06 02:19:21 +00:00
Tobias Assmann 2b55a90ae4 fix: also remove use statement of UserCreatedEvent
Signed-off-by: Tobias Assmann <tobias.assmann@ecsec.de>
2020-11-05 23:08:14 +01:00
Tobias Assmann 6d1ecf2218 fix: no more translation from postCreateUser hook to UserCreatedEvent anymore, as event is already emitted in user manager
Signed-off-by: Tobias Assmann <tobias.assmann@ecsec.de>
2020-11-05 23:08:04 +01:00
Greta 7ad87937c8 Merge pull request #23902 from nextcloud/backport/23798/stable20
[stable20] Add default font size
2020-11-05 10:50:37 +01:00
GretaD 6787f5de50 Add default font size
Signed-off-by: GretaD <gretadoci@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-05 08:40:28 +00:00
Nextcloud bot 841801b9ac [tx-robot] updated from transifex 2020-11-05 02:18:59 +00:00
Morris Jobke e30c80c490 Merge pull request #23894 from nextcloud/backport/23799/stable20-minimal
[stable20] fix potentially passing null to events where IUser is expected
2020-11-04 21:14:51 +01:00
Morris Jobke 5e4debcd98 Merge pull request #23899 from nextcloud/backport/23898/stable20
[stable20] Make user status styles scoped
2020-11-04 19:34:55 +01:00
Morris Jobke cea90b9dcb Merge pull request #23900 from nextcloud/backport/23897/stable20
[stable20] Move help to separate stylesheet
2020-11-04 19:34:44 +01:00
Julius Härtl 2386f8e1cc Make user status styles scoped
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-04 14:51:48 +00:00
John Molakvoæ 54fd9bfecf Merge pull request #23884 from nextcloud/backport/23097/stable20
[stable20] Restrict query when searching for versions of trashbin files
2020-11-04 15:40:32 +01:00
Julius Härtl 0d457ce76d Move help to separate stylesheet
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-04 14:34:33 +00:00
Arthur Schiwon 59f9183ea1 fix potentially passing null to events where IUser is expected
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-04 11:59:09 +01:00
Morris Jobke 54fb4c28c4 Merge pull request #23419 from nextcloud/backport/23350/stable20
[stable20] Inidicate preview availability in share api responses
2020-11-04 08:45:44 +01:00
Julius Härtl 07506dd10c Restrict query when searching for versions of trashbin files
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-04 07:32:47 +00:00
Julius Härtl ba201aace6 Merge pull request #23874 from nextcloud/backport/23866/stable20
[stable20] Fix grid view toggle in tags view
2020-11-04 08:28:55 +01:00
Nextcloud bot c14defb527 [tx-robot] updated from transifex 2020-11-04 02:19:13 +00:00
Richard Steinmetz 4baeaeccdb Indicate preview availability in share api responses
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-03 19:55:35 +00:00
Morris Jobke 28b4420797 Merge pull request #23858 from nextcloud/backport/23842/stable20
[stable20] UserStatus: clear status message if message is null
2020-11-03 20:41:11 +01:00
Morris Jobke 33c27e61c2 Fix grid view in tags view
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 19:25:40 +00:00
Morris Jobke cb31977ba6 Merge pull request #23850 from nextcloud/backport/23841/stable20
[stable20] ensure filepicker list is empty before populating
2020-11-03 10:47:11 +01:00
Morris Jobke 59df41170a Merge pull request #23846 from nextcloud/backport/23839/stable20
[stable20] No need to check if there is an avatar available, because it is gener…
2020-11-03 10:46:41 +01:00
Simon Spannagel 9750efe5ab UserStatus: no message means clear status message. This fixes #23332
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2020-11-03 09:31:05 +00:00
Nextcloud bot a81b901c71 [tx-robot] updated from transifex 2020-11-03 02:19:28 +00:00
Robin Appelman 773bc3b496 ensure filepicker list is empty before populating
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-02 20:20:07 +00:00
Morris Jobke 23d3586865 No need to check if there is an avatar available, because it is generated on the fly nowadays
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-02 18:10:23 +00:00
Roeland Jago Douma 7e1c26ebea Merge pull request #23829 from nextcloud/backport/23267/stable20
[stable20] Remove bold font-weight and lower font-size for empty search box
2020-11-02 12:28:06 +01:00
Nextcloud bot 3b887153c4 [tx-robot] updated from transifex 2020-11-02 02:19:14 +00:00
Jacob Neplokh 633b760c6d Change font-weight and font-size for empty search
Signed-off-by: Jacob Neplokh <me@jacobneplokh.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-01 15:36:02 +00:00
Nextcloud bot d02186e985 [tx-robot] updated from transifex 2020-11-01 02:18:34 +00:00
Roeland Jago Douma d156a7c121 Merge pull request #23794 from nextcloud/backport/23788/stable20
[stable20] Only run phpunit when "php" changed
2020-10-31 08:49:39 +01:00
Nextcloud bot b1159294a8 [tx-robot] updated from transifex 2020-10-31 02:18:57 +00:00
Morris Jobke 7bf32677b8 Add script to old versions
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-30 13:37:49 +01:00
Joas Schilling 3f5d275e6d Also run for .sh and .json (when not package or package-lock)
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-30 12:12:39 +00:00
Joas Schilling 0a7fef6272 Also run all tests when drone config is modified
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-30 12:12:39 +00:00
Joas Schilling 53c18b8c26 Only run phpunit when php, xml or test files are modified
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-30 12:12:38 +00:00
Christoph Wurst c099469ece Merge pull request #23789 from nextcloud/backport/23742/stable20
[stable20] Type the event dispatcher listener callables with Psalm
2020-10-30 12:40:19 +01:00
Morris Jobke f2a0ba4b55 Merge pull request #23787 from nextcloud/backport/23783/stable20
[stable20] Fetch the logger and system config once for all query builder instances
2020-10-30 11:03:33 +01:00
Roeland Jago Douma 5e496cd2e8 Fix invalid usages of the new dispatcher
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-30 08:57:07 +00:00
Christoph Wurst 7ef3c95fa3 Type the event dispatcher listener callables with Psalm
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-30 08:57:06 +00:00
Morris Jobke 24e93bbba4 Fetch the logger and system config once for all query builder instances
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-30 06:40:43 +00:00
Nextcloud bot dac9c01eb5 [tx-robot] updated from transifex 2020-10-30 02:19:19 +00:00
Morris Jobke ebbb4857f1 Merge pull request #23779 from nextcloud/backport/23775/stable20
[stable20] Document the backend registered events of LDAP
2020-10-29 15:08:37 +01:00
Morris Jobke 0207d34d57 Document the backend registered events of LDAP
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-29 13:08:13 +00:00
Roeland Jago Douma fcd7bcfe2f Merge pull request #23774 from nextcloud/backport/23762/stable20
[stable20] catch errors when closing file conflict dialog
2020-10-29 10:30:42 +01:00
Robin Appelman eb59fd2baa catch errors when closing file conflict dialog
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-10-29 09:10:33 +00:00
Morris Jobke 62f81da02e Merge pull request #23759 from nextcloud/backport/23752/stable20
[stable20] inform the user when flow config data exceeds thresholds
2020-10-29 08:55:43 +01:00
Nextcloud bot 6f31880a63 [tx-robot] updated from transifex 2020-10-29 02:19:27 +00:00
Morris Jobke 2c69c7c863 Merge pull request #23763 from nextcloud/backport/23746/stable20
[stable20] Type the \OCP\IUserManager::callForSeenUsers closure with Psalm
2020-10-28 21:10:50 +01:00
Morris Jobke bce4ca7bf2 Merge pull request #23751 from nextcloud/backport/23744/stable20
[stable20] Type the \OCP\AppFramework\Services\IInitialState::provideLazyInitial…
2020-10-28 21:10:37 +01:00
Christoph Wurst c509410b1d Type the \OCP\IUserManager::callForSeenUsers closure with Psalm
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-28 19:08:14 +00:00
Arthur Schiwon e2577440b3 inform the user when flow config data exceeds thresholds
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-28 15:11:06 +00:00
Morris Jobke 9dbc227043 Merge pull request #23749 from nextcloud/backport/23743/stable20
[stable20] Type the \OCP\IUserManager::callForAllUsers closure with Psalm
2020-10-28 15:27:16 +01:00
Roeland Jago Douma 092f346d6e Merge pull request #23753 from nextcloud/backport/23750/stable20
[stable20] Don't overwrite the event if we use it later
2020-10-28 15:19:56 +01:00
Roeland Jago Douma f14c0dec40 Don't overwrite the event if we use it later
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-28 13:41:38 +00:00
Christoph Wurst 29aa60d65a Type the \OCP\AppFramework\Services\IInitialState::provideLazyInitialState closure with Psalm
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-28 13:05:58 +00:00
Christoph Wurst adc1b28419 Type the \OCP\IUserManager::callForAllUsers closure with Psalm
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-28 12:16:45 +00:00
Morris Jobke 3869c235de Merge pull request #23745 from nextcloud/backport/23723/stable20
[stable20] Also run the SabreAuthInitEvent for the main server
2020-10-28 13:13:18 +01:00
Roeland Jago Douma aa12dd403e Also run the SabreAuthInitEvent for the main server
else for example trusted servers breaks

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-28 08:10:21 +00:00
Morris Jobke ca4eaf9ab5 Merge pull request #23736 from nextcloud/backport/23721/stable20
[stable20] reset avatar cropper before showing
2020-10-28 08:49:49 +01:00
Morris Jobke 21e9ec1f08 Merge pull request #23733 from nextcloud/backport/23720/stable20
[stable20] save email as lower case
2020-10-28 08:49:29 +01:00
Roeland Jago Douma da92c70823 Merge pull request #23732 from nextcloud/backport/23725/stable20
[stable20] Specify accept argument to avatar upload input field
2020-10-28 08:43:16 +01:00
Nextcloud bot 9150a8bce6 [tx-robot] updated from transifex 2020-10-28 02:19:02 +00:00
Robin Appelman 5c93d08bc1 reset avatar cropper before showing
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-27 20:25:40 +00:00
Robin Appelman d4303b6e8a save email as lower case
email addresses are case insensitive

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-27 20:25:25 +00:00
Morris Jobke 2337ce2efd Specify accept argument to avatar upload input field
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-27 20:15:25 +00:00
Roeland Jago Douma 86c66c29a9 Merge pull request #23726 from nextcloud/backport/23711/stable20
[stable20] Fix default quota display value in user row
2020-10-27 20:07:29 +01:00
Roeland Jago Douma 9cfaf9081d Merge pull request #23727 from nextcloud/backport/23722/stable20
[stable20] Use lib instead if core as l10n module in OC_Files
2020-10-27 20:04:37 +01:00
Roeland Jago Douma bc8740a46a Merge pull request #23710 from nextcloud/backport/23701/stable20
[stable20] Make sure the function signatures of the backgroundjob match
2020-10-27 19:54:51 +01:00
Morris Jobke 017a3f86c2 Use lib instead if core as l10n module in OC_Files
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-27 16:30:26 +00:00
Vincent Petry 2230585765 Fix default quota display value in user row
When selecting default quota in the dropdown, the actual numeric value
or "Unlimited" will be displayed instead of "0 B". This matches whatever
is displayed after refreshing the page.

In the case where the default quota is unlimited, for which the server
returns -3 instead of "none", the frontend now also shows "Unlimited"
instead of "0 B".

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-10-27 16:58:03 +01:00
Morris Jobke 4ea4918b62 Merge pull request #23713 from nextcloud/backport/23645/stable20
[stable20] Check if array elements exist before using them
2020-10-27 16:25:35 +01:00
Roeland Jago Douma 42d56c9655 Check if array elements exist before using them
It seems that in some recent upgrade here. Not always the entries we
expect are returned. So we should first check if they exist. As to not
spam the log.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-27 10:57:51 +00:00
Roeland Jago Douma 0277829be8 Make sure the function signatures of the backgroundjob match
Else PHP says no

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-27 09:16:03 +00:00
John Molakvoæ b0eec52c85 Merge pull request #23702 from nextcloud/fix/noid/remnants-sharee-display-20-and-older 2020-10-27 09:46:24 +01:00
Morris Jobke c4d016887b Merge pull request #23699 from nextcloud/backport/23680/stable20
[stable20] Enable theming background transparency
2020-10-27 09:06:05 +01:00
Nextcloud bot e4534d8389 [tx-robot] updated from transifex 2020-10-27 02:18:45 +00:00
John Molakvoæ (skjnldsv) 3e4e05bb93 Enable theming background transparency
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-26 19:51:38 +00:00
Arthur Schiwon 37301a5378 fixes determining whether former user is a share owner
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-26 14:00:57 +01:00
Morris Jobke 429700ac3a Merge pull request #23690 from nextcloud/backport/23688/stable20
[stable20] Use bigint for fileid in filecache_extended
2020-10-26 13:57:41 +01:00
Arthur Schiwon 71c34876a6 split instantiation from business logic in OfflineUser
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-26 13:54:03 +01:00
Arthur Schiwon 2a1e5d8beb add test for active shares flag
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-26 13:52:27 +01:00
timm2k 6a3889b531 Update CheckSetupController.php 2020-10-26 09:00:18 +00:00
timm2k 67211199e1 Update ConvertFilecacheBigInt.php 2020-10-26 09:00:16 +00:00
Nextcloud bot 792e42d411 [tx-robot] updated from transifex 2020-10-26 02:18:16 +00:00
Morris Jobke badb56b952 Merge pull request #23636 from nextcloud/backport/23630/stable20
[stable20] Bring back the restore share button
2020-10-25 21:57:52 +01:00
Morris Jobke 2b12d71a0d Merge pull request #23641 from nextcloud/backport/23602/stable20
[stable20] Fix updates of NULL appconfig values
2020-10-25 21:38:49 +01:00
Nextcloud bot 42339e0cdc [tx-robot] updated from transifex 2020-10-25 02:18:40 +00:00
Roeland Jago Douma 1ab03a0d3e Merge pull request #23563 from nextcloud/backport/23497/stable20
[stable20] CalDavBackend: check if timerange is array before accessing
2020-10-24 10:57:58 +02:00
Roeland Jago Douma 5a7a0a2f64 Merge pull request #23583 from nextcloud/backport/23580/stable20
[stable20] Also expire share type email
2020-10-24 10:54:41 +02:00
Roeland Jago Douma 2d3a2e20ae Merge pull request #23575 from nextcloud/backport/23415/stable20
[stable20] Some emojis are in CHAR_CATEGORY_GENERAL_OTHER_TYPES
2020-10-24 10:54:29 +02:00
Roeland Jago Douma 0b46ebe3c6 Merge pull request #23611 from nextcloud/backport/23606/stable20
[stable20] Only use index of mount point when it is there
2020-10-24 10:53:45 +02:00
Roeland Jago Douma 50d39324a2 Merge pull request #23633 from nextcloud/backport/23374/stable20
[stable20] Only retry fetching app store data once every 5 minutes in case it fails
2020-10-24 10:53:01 +02:00
Roeland Jago Douma 0b67ea0d67 Merge pull request #23646 from nextcloud/backport/23627/stable20
[stable20] Fix sharing input placeholder for emails
2020-10-24 10:52:33 +02:00
Roeland Jago Douma 89d88b3ea5 Merge pull request #23639 from nextcloud/version/noid/20.0.1
20.0.1
2020-10-24 10:32:10 +02:00
Nextcloud bot 3674d341ea [tx-robot] updated from transifex 2020-10-24 02:18:55 +00:00
John Molakvoæ (skjnldsv) 2562d45af2 Fix sharing input placeholder for emails
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-23 13:06:01 +00:00
Roeland Jago Douma 1cc6a0f8e3 Fix updates of NULL appconfig values
The comparisson of NULL is a bit special.
So we need to handle this a tad beter else it might not replace NULL
values. or allow you to set NULL values on updates.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-23 08:45:29 +00:00
Nextcloud bot 526a392002 [tx-robot] updated from transifex 2020-10-23 02:18:59 +00:00
Morris Jobke dcc146a5c0 20.0.1
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-22 23:11:04 +02:00
Vincent Petry d391e7fe02 Bring back the restore share button
Fix disabled default file action to still use an anchor element, as this
is used in many other places (and potentially apps).

Adjusted anchor style to not look like it's clickable and added extras
to make sure everything inside still looks clickable as before.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-10-22 18:58:57 +00:00
Julius Härtl 367a7bd87e Only retry fetching app store data once every 5 minutes in case it fails
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-10-22 14:14:49 +00:00
Morris Jobke 820881168d Merge pull request #23621 from nextcloud/backport/23613/stable20
[stable20] Disable unreliable app-files.feature:108
2020-10-22 15:58:35 +02:00
Daniel Calviño Sánchez 0dcdb14966 Merge pull request #23622 from nextcloud/backport/23614/stable20
[stable20] Disable unreliable app-files-sharing.feature:108
2020-10-22 15:39:20 +02:00
Morris Jobke eba5eb8876 Disable unreliable app-files-sharing.feature:108
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-22 10:22:53 +00:00
Morris Jobke 78d233276f Disable unreliable app-files.feature:108
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-22 10:20:38 +00:00
Nextcloud bot f7798def38 [tx-robot] updated from transifex 2020-10-22 02:19:16 +00:00
Joas Schilling 2160dc9583 Only use index of mount point when it is there
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-21 18:46:13 +00:00
blizzz 36070d70d7 Merge pull request #23570 from nextcloud/backport/23566/stable20
[stable20] LDAP: when nesting is not enabled, the group filter can be applied right away
2020-10-21 16:12:58 +02:00
Nextcloud bot e6ed412c2a [tx-robot] updated from transifex 2020-10-21 02:18:54 +00:00
John Molakvoæ (skjnldsv) 2aa69ba895 Also expire share type email
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-20 09:35:45 +00:00
Nextcloud bot 2005119af2 [tx-robot] updated from transifex 2020-10-20 02:18:50 +00:00
Joas Schilling 57cfed3f3d Some emojis are in CHAR_CATEGORY_GENERAL_OTHER_TYPES
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-19 15:19:50 +00:00
Arthur Schiwon 7fad750a2d tame psalm. why does it ignore '@property'?
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-19 13:37:23 +00:00
Arthur Schiwon fbfac673c9 when nesting is not enabled, the group filter can be applied right away
- helps performance, but skipping unnecessary entries
- reduces reoccuring info-level log output against groups that do not
  qualify ("no or empty name")

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-19 13:37:22 +00:00
Morris Jobke 97ad590aea Merge pull request #23474 from nextcloud/version/noid/20.0.1RC1
20.0.1 RC 1
2020-10-19 13:31:27 +02:00
Simon Spannagel b1d3877625 CalDavBackend: check if timerange is array before accessing
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2020-10-19 10:56:51 +00:00
Morris Jobke b6bd757644 Update CA bundle
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-19 10:30:14 +02:00
Morris Jobke 9db12a5651 20.0.1 RC 1
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-19 10:16:43 +02:00
Morris Jobke 41090d0faa Merge pull request #23205 from nextcloud/backport/23012/stable20
[stable20] Make BeforeTemplateRenderedEvent aware of the actual response
2020-10-19 10:15:22 +02:00
Morris Jobke cbde9d878f Merge pull request #23514 from nextcloud/backport/23508/stable20
[stable20] fixes potential passing of null to getUserGroupIds
2020-10-19 10:14:06 +02:00
Morris Jobke 3f180d2946 Merge pull request #23422 from nextcloud/backport/23295/stable20
[stable20] Fix undefined index and consequential damages in versions code
2020-10-19 10:12:49 +02:00
Morris Jobke bd11c9c620 Merge pull request #23426 from nextcloud/backport/23021/stable20
[stable20] allow using saved login credentials for notify
2020-10-19 10:12:38 +02:00
Morris Jobke ae5500b0cb Merge pull request #23438 from nextcloud/disable-notify-self-check-20
[20] add option to disable notify self check
2020-10-19 10:12:09 +02:00
Morris Jobke a6b4770afc Update @since tag
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-19 10:00:15 +02:00
blizzz 52f873942c Merge pull request #23548 from nextcloud/backport/23264/stable20
[stable20] Add local version of escapeHTML
2020-10-19 09:32:26 +02:00
Nextcloud bot 6e8f9b7aef [tx-robot] updated from transifex 2020-10-19 02:18:07 +00:00
Daniel Kesselberg 732f65b5fd Add local version of escapeHTML
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-10-18 15:28:17 +00:00
Nextcloud bot 97eb117251 [tx-robot] updated from transifex 2020-10-18 02:17:52 +00:00
Nextcloud bot 5e52e63672 [tx-robot] updated from transifex 2020-10-17 02:18:57 +00:00
Morris Jobke 401c245101 Merge pull request #23513 from nextcloud/backport/23478/stable20
[stable20] Clear cached app config while waiting for the SCSSCache lock to return
2020-10-16 18:15:58 +02:00
Morris Jobke e95a1420f1 Clear cached app config while waiting for the SCSSCache to finish processing the file
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-16 15:46:59 +02:00
Arthur Schiwon a615e7dcfa fixes potential passing of null to getUserGroupIds
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-16 13:01:06 +00:00
Morris Jobke 130689ac2a Merge pull request #23510 from nextcloud/backport/23488/stable20
[stable20] SCSSCacher - Lock should not be removed
2020-10-16 14:55:47 +02:00
Morris Jobke 2dcf50cd78 SCSSCacher - Lock should not be removed
This is within the failed lock acquiring branch. So the lock is free by another process and should not be removed because the cached file (that was created by the process having the lock) appeared on the filesystem.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-16 11:27:36 +00:00
Morris Jobke bc41e93bf8 Merge pull request #23503 from nextcloud/backport/23490/stable20
[stable20] Provide log statements for SCSS cache
2020-10-16 13:23:40 +02:00
Morris Jobke 3c1a745301 Merge pull request #23480 from nextcloud/backport/23401/stable20
[stable20] Use own psalm instead of a global one
2020-10-16 13:22:33 +02:00
Morris Jobke 7054159cda Do not fail on changes to baseline.xml
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-16 13:17:19 +02:00
Morris Jobke 8c9fe98446 Update psalm-baseline
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-16 13:17:19 +02:00
Morris Jobke 8985f4679a Merge pull request #23498 from nextcloud/backport/23492/stable20
[stable20] SharedMountTest.php:367 is unreliable
2020-10-16 10:57:31 +02:00
Morris Jobke 3d765dafe7 Merge pull request #23472 from nextcloud/backport/23464/stable20
[stable20] Add psalm types for the migration schema closure
2020-10-16 09:50:22 +02:00
Morris Jobke 96e08a508e Provide log statements for SCSS cache
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-16 07:50:21 +00:00
Morris Jobke dd7c6d1947 Merge pull request #23491 from nextcloud/backport/23481/stable20
[stable20] Add psalm types for the event dispatcher
2020-10-16 09:32:47 +02:00
Morris Jobke 5994f66659 Merge pull request #23336 from nextcloud/backport/23239/stable20
[stable20] Fix database password visibility toggle
2020-10-16 09:31:53 +02:00
Christoph Wurst 6536501579 Update the baseline
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-16 09:15:54 +02:00
Christoph Wurst be3a46038f Use own psalm instead of a global one
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-16 08:45:07 +02:00
Morris Jobke 653596b2c9 SharedMountTest.php:367 is unreliable
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-16 06:41:23 +00:00
Richard Steinmetz a7b0778b4b Fix password visibility toggles
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-16 06:15:07 +00:00
Nextcloud bot 7aeb050124 [tx-robot] updated from transifex 2020-10-16 02:18:20 +00:00
Christoph Wurst 3a3d7ea6cd Type the authentication listeners
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-15 22:34:18 +00:00
Christoph Wurst dff399973f Add psalm types for the event dispatcher
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-15 22:34:18 +00:00
John Molakvoæ 904396c5d2 Merge pull request #23458 from nextcloud/backport/23448/stable20
[stable20] Fix app sidebar mountpoint
2020-10-15 16:43:30 +02:00
John Molakvoæ (skjnldsv) 1d5ffe3326 Fix app sidebar mountpoint
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-15 13:25:31 +00:00
Morris Jobke 646e0ac99d Merge pull request #23473 from nextcloud/backport/23436/stable20
[stable20] Remove posix_getpwuid and compare only userid
2020-10-15 14:04:34 +02:00
hoellen 0201154183 Adjust sudo command to UID instead of username
Signed-off-by: hoellen <dev@hoellen.eu>
2020-10-15 11:35:21 +00:00
hoellen 6e3513aa89 Remove posix_getpwuid and compare only userid
Signed-off-by: hoellen <dev@hoellen.eu>
2020-10-15 11:35:20 +00:00
Christoph Wurst 5290cc77bc Add psalm types for the migration schema closure
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-15 11:24:10 +00:00
Morris Jobke c9d196af78 Merge pull request #23466 from nextcloud/dependencies/nextcloud-vue-2.6.9
[stable20] Bump @nextcloud/vue to 2.6.9
2020-10-15 13:15:03 +02:00
Julius Härtl 8c132c30bf Bump @nextcloud/vue to 2.6.9
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-15 09:48:06 +00:00
Nextcloud bot 76f62e3891 [tx-robot] updated from transifex 2020-10-15 02:18:34 +00:00
Morris Jobke 5e9e90655e Merge pull request #23446 from nextcloud/backport/23377/stable20
[stable20] Annotate IContainer so Psalm knows what resove and query return
2020-10-14 17:40:06 +02:00
Christoph Wurst 327ec78e15 Annotate IContainer so Psalm knows what resove and query return
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-14 15:07:07 +00:00
Christoph Wurst d77ed81666 Merge pull request #23384 from nextcloud/backport/23284/stable20
[stable20] Fix adminpass strengthify margin
2020-10-14 15:58:46 +02:00
Robin Appelman 43778d8aae add option to disable notify self check
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-14 14:06:40 +02:00
Nextcloud bot 1b8d9e9c13 [tx-robot] updated from transifex 2020-10-14 02:18:55 +00:00
Morris Jobke dc972cc162 Merge pull request #23420 from nextcloud/backport/23402/stable20
[stable20] Encode requesttoken for logout url in auto logout
2020-10-13 21:43:53 +02:00
Robin Appelman d5e77685a4 also give storage backend it's change to manipulate the config
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-13 17:44:21 +00:00
Robin Appelman b750503f4a allow using saved login credentials for notify
when only the user is provided, we use to provided user to try and get saved login credentials

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-13 17:44:20 +00:00
Julius Härtl 098c631129 Encode requesttoken for logout url in auto logout
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-13 15:57:25 +00:00
Morris Jobke 09b4f9b13e Merge pull request #23395 from nextcloud/backport/23300/stable20
[stable20] Stop transfer of ownership between same users
2020-10-13 17:46:32 +02:00
Morris Jobke 2b1f3df3da Return all keys in getAllVersions() instead
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-13 15:39:33 +00:00
Christoph Wurst 8a25ded758 Fix undefined index and consequential damages in versions code
If the user has no space and there are no versions, there won't be an
`all` index in the versions entry. Hence this triggers a warning and
becomes `null`, afterwards `count`, `foreach` and friends will happily
throw even more warnings and errors because they don't want to play with
`null`. Thus adding a fallback to an empty array.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-13 15:39:32 +00:00
Christoph Wurst 4af8bf2468 Merge pull request #23403 from nextcloud/backport/23396/stable20
[stable20] VersioningTest.php:729 is unreliable and should be disabled
2020-10-13 11:45:24 +02:00
Morris Jobke 3fc4120ebb VersioningTest:729 is unreliable and should be disabled
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-13 07:10:52 +00:00
Morris Jobke f730812af3 Merge pull request #23281 from nextcloud/backport/23269/stable20
[stable20] Fix the user remove from group in UI
2020-10-13 00:29:44 +02:00
Sujith Haridasan 67fa9edef0 Stop transfer of ownership between same users
Stop the transfer of ownership between same user.

Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>
2020-10-12 20:03:17 +00:00
npmbuildbot[bot] 64da029df9 Compile assets
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-12 19:53:34 +00:00
Morris Jobke a70bbf1f4b Merge pull request #23388 from nextcloud/backport/23378/stable20
[stable20] Fix typo 'shared'
2020-10-12 21:50:14 +02:00
Morris Jobke cf9c643793 Merge pull request #23390 from nextcloud/backport/23379/stable20
[stable20] Expose CLOUD federation for local users in the recent addressbook
2020-10-12 21:38:25 +02:00
John Molakvoæ (skjnldsv) a9425c7ebf Drop X-NEXTCLOUD-UID
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-12 18:51:53 +00:00
John Molakvoæ (skjnldsv) a9a552ec95 Expose CLOUD federation for local users as well
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-12 18:51:53 +00:00
Morris Jobke a7ff7c47ab Fix code style
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-12 18:08:36 +00:00
Robin Windey 06895ef8cc Fix typo 'shared' 2020-10-12 18:08:36 +00:00
kesselb 830d911507 Merge pull request #23383 from nextcloud/backport/23371/stable20
[stable20] Add Psalm type for the bootstrap registration context
2020-10-12 19:12:21 +02:00
Richard Steinmetz a8e7b5ad3a Fix adminpass strengthify margin
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2020-10-12 15:43:13 +00:00
Christoph Wurst bab06f9bf9 Add Psalm type for the bootstrap registration context
This can potentially catch a few bugs with wrong class strings.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-12 15:16:34 +00:00
Morris Jobke aff015661f Merge pull request #23375 from nextcloud/backport/23310/stable20
[stable20] Add template typing to the QBMapper
2020-10-12 13:50:35 +02:00
Christoph Wurst a1856176d5 Add template typing to the QBMapper
The QBMapper is kind of a generic type, though this concept does not
exist in php. Hence you have a lot of type coercion in subtypes (mappers
in the individual apps) because you suddenly don't expect an Entity[]
but your specific type.

Luckily Psalm lets us type those. Then in the subclass you can
psalm-implement the mapper with a concrete type and psalm will do all
the magic to ensure types are used correctly.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-12 11:12:35 +00:00
Roeland Jago Douma e58134e0c9 Merge pull request #23288 from nextcloud/backport/23275/stable20
[stable20] Fix dashboard statuses sort
2020-10-08 20:06:03 +02:00
Julien Veyssier 07ad1978a8 fix dashboard statuses sort function
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-08 13:39:54 +00:00
Sujith Haridasan 22b24b8f5d Fix the user remove from group in UI
Fix the removal of user from the group in UI.

Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>
2020-10-08 11:21:02 +00:00
John Molakvoæ c578b11fe3 Merge pull request #23271 from nextcloud/fix/sidebar-updateTabs
Fix sidebar updateTabs method
2020-10-08 12:25:59 +02:00
Roeland Jago Douma 2d2cba3c9b Merge pull request #23256 from nextcloud/backport/23184/stable20
[stable20] Make sure getUsersFavoritingObject can be run without a user
2020-10-08 11:49:03 +02:00
John Molakvoæ (skjnldsv) fbf77cb653 Fix sidebar updateTabs method
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-08 09:36:24 +00:00
Joas Schilling d68d62f052 Make sure getUsersFavoritingObject can be run without a user
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-07 11:10:38 +00:00
Morris Jobke f4891da160 Merge pull request #23254 from nextcloud/backport/23252/stable20
[stable20] Use the correct l10n for activities
2020-10-07 12:24:28 +02:00
Roeland Jago Douma 1f3e3e782f Use the correct l10n for activities
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-07 09:37:23 +00:00
Roeland Jago Douma f26998364b Merge pull request #23216 from nextcloud/backport/23183/stable20
[stable20] Don't influence toastify errors and always use white
2020-10-07 11:06:53 +02:00
Morris Jobke 7581ba94f4 Merge pull request #23235 from nextcloud/backport/22974/stable20
[stable20] Fix appid in translation
2020-10-06 22:13:15 +02:00
Joas Schilling f3060b62c6 Fix appid in translation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-06 18:55:40 +02:00
Morris Jobke 21f00069fe Merge pull request #23213 from nextcloud/backport/22937/stable20
[stable20] Allow configuring the activity update interval of token
2020-10-06 16:07:54 +02:00
Roeland Jago Douma ca32ee1a65 Merge pull request #23220 from nextcloud/backport/23215/stable20
[stable20] Only run the query to get the account data once
2020-10-06 14:46:06 +02:00
Roeland Jago Douma ee1a6ad434 Merge pull request #23195 from nextcloud/backport/23175/stable20
[stable20] Fix legacy update notifications
2020-10-06 13:29:26 +02:00
Roeland Jago Douma a81ec17235 Merge pull request #23170 from nextcloud/backport/22913/stable20
[stable20] add mount point to quota warning message
2020-10-06 13:18:12 +02:00
Roeland Jago Douma 3bd9297bb1 Merge pull request #23211 from nextcloud/backport/23096/stable20
[stable20] Also check the path based mimetype for flow rule checks
2020-10-06 13:07:11 +02:00
Joas Schilling 851acc1d74 Only run the query to get the account data once
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-06 10:48:24 +00:00
Joas Schilling 27854f05a8 Don't influence toastify errors and always use white
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-06 09:09:01 +00:00
Roeland Jago Douma e0bc29d907 Allow configuring the activity update interval of token
On some systems with a lot of users this creates a lot of extra DB
writes.
Being able to increase this interval helps there.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-06 08:04:12 +00:00
Morris Jobke 76fe051ecb Merge pull request #23185 from nextcloud/backport/23109/stable20
[stable20] dont hold a transaction during the move to trash
2020-10-06 09:10:57 +02:00
Morris Jobke 853b17b2a9 Merge pull request #23207 from nextcloud/backport/23028/stable20
[stable20] Fix array to string conversion on event search
2020-10-06 09:09:34 +02:00
Julius Härtl 53ac186473 Make sure to check the mimetype on the path if a secure one could not be detemined though the content
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-10-06 06:08:04 +00:00
Joas Schilling 732cf6b8d3 Fix array to string conversion on event search
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-05 21:07:05 +00:00
Morris Jobke 20524cff33 Merge pull request #23203 from nextcloud/backport/23182/stable20
[stable20] Fix the user email issue while creating a user
2020-10-05 23:03:48 +02:00
Julius Härtl bc0a429822 Add acutal response to BeforeTemplateRenderedEvent
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-10-05 19:53:05 +00:00
Julius Härtl 7b65eecf72 Only load user status script when needed
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-10-05 19:53:04 +00:00
Sujith Haridasan c998209ec1 Fix the user email issue while creating a user
When the user is created, the provisioning api
was not adding the email address of the user
when provided if the `send email to new user`
is not set.

Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>
2020-10-05 19:34:24 +00:00
Roeland Jago Douma 453aafee73 Fix unit tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-05 21:33:40 +02:00
Roeland Jago Douma 4f5a24bb50 Merge pull request #23192 from nextcloud/backport/23179/stable20
[stable20] Fix dashboard rendering if accessibility app is disabled
2020-10-05 20:01:30 +02:00
Julius Härtl 2070ef6270 Fix dashboard rendering if accessibility app is disabled
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-05 14:13:56 +00:00
mrtnmtth 608fab3741 Fix legacy update notifications
Signed-off-by: mrtnmtth <mrtn.mtth@gmx.de>
2020-10-05 14:07:51 +00:00
Robin Appelman acef3620e0 dont hold a transaction during the move to trash
because moving to trash can take a long time, keeping a transaction active for the duration can lead to issues

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-05 15:25:36 +02:00
Robin Appelman aec422a874 add mount point to quota warning message
makes it more clear to the user what the quota applies to

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-04 11:05:24 +00:00
Roeland Jago Douma 615b994816 Merge pull request #23071 from nextcloud/version/20.0.0/final
20 final
2020-10-02 18:42:10 +02:00
Roeland Jago Douma c2eb39d662 Merge pull request #23143 from nextcloud/backport/23114/stable20
[stable20]  Show icon only with dnd status in the message
2020-10-02 18:33:17 +02:00
Joas Schilling d2bd0664be Show the full status and icon all the time
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-02 17:18:43 +02:00
Julius Härtl d3d7209be9 Show icon only with dnd status in the message
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-10-02 17:13:26 +02:00
Roeland Jago Douma 2c149fbd9a Merge pull request #23141 from nextcloud/backport/23136/stable20
[stable20] Mark all compiled JS as binary
2020-10-02 17:01:03 +02:00
Roeland Jago Douma 998ab15206 Merge pull request #23132 from nextcloud/backport/23130/stable20
[stable20] Move online status into modal
2020-10-02 16:58:35 +02:00
Joas Schilling d204e5855c Mark all compiled JS as binary
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-02 13:41:55 +00:00
John Molakvoæ (skjnldsv) bb662c20fe Bump @nextcloud/vue to v2.6.8
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-02 13:33:43 +02:00
John Molakvoæ (skjnldsv) 097d62049d Fix subline hint
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-02 13:22:42 +02:00
Joas Schilling be778c94e1 Show the subline
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-02 12:50:29 +02:00
Joas Schilling ac3a32f305 Set status is also there now
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-02 09:26:53 +00:00
Joas Schilling 28ae039588 Update @nextcloud/vue to 2.6.7
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-02 09:26:52 +00:00
Jan C. Borchardt 1f0a5aeae3 Status: Add subline for Invisible to explain it properly
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2020-10-02 09:26:50 +00:00
Jan C. Borchardt 741ebf5177 Enable scrollbar for too long content, same way as in Dashboard customize
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2020-10-02 09:26:50 +00:00
John Molakvoæ (skjnldsv) 4817005733 Move online status into modal
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-02 09:26:50 +00:00
Roeland Jago Douma fa4cd4435b Merge pull request #23089 from nextcloud/backport/23074/stable20
[stable20] Do not match sharees on an empty email address
2020-10-01 19:29:39 +02:00
Roeland Jago Douma 61a0069dd5 Merge pull request #23115 from nextcloud/backport/23108/stable20
[stable20] Reset the user status when clearing the custom message
2020-10-01 19:23:51 +02:00
Roeland Jago Douma 2433550eff Merge pull request #23121 from nextcloud/backport/23112/stable20
[stable20] Increase the timeout of statuses
2020-10-01 15:09:51 +02:00
Joas Schilling d7d805ef79 Increase the timeout of statuses
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-01 09:45:46 +00:00
Roeland Jago Douma 612306d290 Merge pull request #23116 from nextcloud/backport/23113/stable20
[stable20] Change wording from 'custom status' to 'status message'
2020-10-01 08:29:27 +02:00
Jan C. Borchardt b66f5c55e5 Change wording from 'custom status' to 'status message'
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-09-30 22:26:57 -04:00
Joas Schilling 413a6042f3 Reset the user status when clearing the custom message
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-30 17:27:14 +00:00
Roeland Jago Douma f0dc0d1347 Merge pull request #23098 from nextcloud/backport/22999/stable20
[stable20] Adjust scroll container height to make it a proper boundary element for actions
2020-09-30 13:48:05 +02:00
Roeland Jago Douma 6b8356ce35 Merge pull request #23095 from nextcloud/backport/23043/stable20
[stable20] Avoid crash when unauthenticated users make weather-related requests
2020-09-29 21:35:17 +02:00
Julius Härtl 143c6356c5 Adjust scroll container height to make it a proper boundary element for actions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-29 16:43:41 +00:00
Roeland Jago Douma 2e87668f77 Merge pull request #23092 from nextcloud/backport/23083/stable20
[stable20] Generate exception to log on php errors
2020-09-29 16:38:56 +02:00
Julien Veyssier 2364808913 avoid crash when unauthenticated users make weather-related requests, mention it in UI
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2020-09-29 12:18:55 +00:00
Roeland Jago Douma f72ebcd956 Merge pull request #23085 from nextcloud/backport/23013/stable20
[stable20] Show federation and email results also with exact user match unless c…
2020-09-29 12:16:00 +02:00
Roeland Jago Douma b1879c4fcb Merge pull request #23084 from nextcloud/backport/22983/stable20
[stable20] Sync all users to the system addresssbook
2020-09-29 11:52:15 +02:00
Julius Härtl 05fa5e4d9e Generate exception to log on php errors
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-29 08:17:21 +00:00
Christoph Wurst 851333edab Do not match sharees on an empty email address
When asking for sharees we compare not only UID and displayname but also
the email address. And if that matches we return the sharee as an exact
match. This logic had a flaw as in that it also matched the empty string
to users with no email address.

This is most noticeable when you disable sharee enumeration and open the
ownership transfer dialog. It suggested other users of the instance
before. This has stopped now.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-09-29 07:29:43 +00:00
Joas Schilling 71b33fb87a Show federation and email results also with exact user match unless containing @
Before when you have a user "smith" and a federated user "smith@example.com"
you could see the federation result with "smit" but not with "smith" anymore.
With most LDAP configurations and local backend setups this is disturbing and
causes issues.
The idea of not showing the email and federation on a matching user was with:
Local user registered with "smith@example.com" user id and having that same
email / cloud id in your contacts addressbook. So we now only hide those
"side results" when the search does contain an @

Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-29 07:16:12 +00:00
Joas Schilling 6365e7e162 Sync all users to the system addresssbook
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-29 07:15:49 +00:00
Roeland Jago Douma fb426c90b7 Merge pull request #23072 from nextcloud/backport/23051/stable20
[stable20] Fix app text going too far down on hover/focus
2020-09-28 12:40:18 +02:00
Roeland Jago Douma 15ff980583 Merge pull request #23029 from nextcloud/backport/23024/stable20
[stable20] Add occ command to set theming values
2020-09-28 12:24:23 +02:00
Jan C. Borchardt d358f9dddf Fix app text going too far down on hover/focus
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2020-09-28 07:34:29 +00:00
Roeland Jago Douma 7496a10227 Merge pull request #23032 from nextcloud/backport/23015/stable20
[stable20] Log slow dashboard widgets
2020-09-28 09:33:56 +02:00
Roeland Jago Douma 7630052a60 Merge pull request #23048 from nextcloud/backport/23034/stable20
[stable20] Fix numeric folders throwing on markDirty
2020-09-28 09:32:40 +02:00
Roeland Jago Douma 5ab7392d56 20 final
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-28 09:28:36 +02:00
Joas Schilling aefbf4c01d Fix numeric folders throwing on markDirty
TypeError: strpos() expects parameter 1 to be string, int given

The problem is that in cacheNode() we strip of any slashes, so
a folder "0/" will be trimmed to "0" and be used as an array key.
Since PHP automatically casts numeric array keys to integers,
you afterwards get $nodePath as int(0). Since it's now a number,
the strpos() function does not accept it anymore. Simply casting
$nodePath to a string again in the foreach solves the issue

Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-25 13:14:49 +00:00
Roeland Jago Douma d81b4e2ff7 Merge pull request #23030 from nextcloud/backport/22948/stable20
[stable20] Add more integration tests for "files:transfer-ownership" command
2020-09-24 21:32:28 +02:00
Roeland Jago Douma 3320d8ecf1 Merge pull request #23038 from nextcloud/fix-running-video-verification-integration-tests-in-drone-in-stable20
[stable20] Fix running video verification integration tests in Drone
2020-09-24 21:30:23 +02:00
Daniel Calviño Sánchez a1d3213e7d Fix running video verification integration tests in Drone in stable20
In order to run the video verification integration tests the Talk app
needs to be cloned in a branch compatible with the server.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-24 16:52:04 +02:00
Joas Schilling 5475bb4083 Log a warning if a "lazy" initial state loads longer than 1 second
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-24 13:00:19 +00:00
Joas Schilling 87f8e1e366 Log an error if a dashboard widget loads longer than 1 second
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-24 13:00:19 +00:00
Daniel Calviño Sánchez 0dd18e0356 Add integration tests to check that only the given path is transferred
Until recently (it was fixed in ac2999a26a) when a path was transferred
other shares with the target user were removed, so a test was added to
ensure that it does not happen again.

Besides that a test to ensure that other files with the target user are
not transferred was added too (it did not fail before, but seemed
convenient to have that covered too :-) ).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-24 12:47:47 +00:00
Daniel Calviño Sánchez bf9a24efbe Add integration tests for transferring files of a user with a risky name
The files:transfer-ownership performs a sanitization of users with
"risky" display names (including characters like "\" or "/").

In order to allow (escaped) double quotes in the display name the
regular expression used in the "user XXX with displayname YYY exists"
step had to be adjusted.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-24 12:47:47 +00:00
Daniel Calviño Sánchez 87b9dbdb56 Add integration test for transferring the path of a single file
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-24 12:47:47 +00:00
Julius Härtl 19390a4b5e Fix tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-24 12:38:53 +00:00
Julius Härtl 99b25ef3fe Add occ command to set theming values
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-24 12:38:53 +00:00
Roeland Jago Douma d247f198a9 Merge pull request #23000 from nextcloud/version/20.0.0/RC2
20 RC2
2020-09-24 13:41:12 +02:00
Roeland Jago Douma e29b5c6d92 Merge pull request #23026 from nextcloud/backport/23014/stable20
[stable20] Make 'Reasons to use Nextcloud' button translatable, fix #22977
2020-09-24 11:31:39 +02:00
Roeland Jago Douma fa0f815dda Merge pull request #23001 from nextcloud/backport/22940/stable20
[stable20] Never copy the share link when the password is forced
2020-09-24 09:37:22 +02:00
Jan C. Borchardt 2be71de5a1 Make 'Reasons to use Nextcloud' button translatable, fix #22977
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2020-09-24 07:26:18 +00:00
Roeland Jago Douma 724276c7a7 Merge pull request #23018 from nextcloud/backport/23016/stable20
[stable20] Don't log a known shared section
2020-09-24 09:24:42 +02:00
Joas Schilling 26603c7cdd Don't log "duplicate section" for the shared "connected-accounts" section
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-23 11:03:50 +00:00
Joas Schilling 7edced3807 Merge pull request #23009 from nextcloud/backport/23008/stable20
[stable20] Add padding to the empty content and center it
2020-09-23 10:46:50 +02:00
Joas Schilling 3daddfce14 Add padding to the empty content and center it
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-22 19:16:30 +00:00
Joas Schilling 9838d54cb5 Never copy the share link when the password is forced
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-22 11:45:58 +00:00
Roeland Jago Douma 46babff37b Merge pull request #22928 from nextcloud/backport/22915/stable20
[stable20] improve handling of out of space errors for smb
2020-09-22 13:08:21 +02:00
Roeland Jago Douma ff8eb8dfa2 20 RC2
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-22 13:05:52 +02:00
John Molakvoæ 289bc8e345 Merge pull request #22946 from nextcloud/backport/22924/stable20
[stable20] Make sure most app names don’t ellipsize, fix #22845, fix #22219
2020-09-19 00:02:01 +02:00
Morris Jobke a0e8a78945 Fix transifex name of dashboard app
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-18 20:47:38 +02:00
Morris Jobke 065f3e125e Merge pull request #22950 from nextcloud/backport/22949/stable20
[stable20] Add transifex config for all new apps
2020-09-18 20:43:29 +02:00
Morris Jobke bf58dcb247 Add transifex config for all new apps
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-18 18:42:09 +00:00
Jan C. Borchardt ada7ad6930 Make sure most app names don’t ellipsize, fix #22845, fix #22219
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2020-09-18 16:18:48 +00:00
Morris Jobke 5d81cb36b5 Merge pull request #22938 from nextcloud/backport/22911/stable20
[stable20] Allow to run occ preview:repair in parallel
2020-09-18 18:14:29 +02:00
Morris Jobke 03d00afe31 Merge pull request #22935 from nextcloud/backport/22868/stable20
[stable20] Fix/unified search papercuts
2020-09-18 18:14:17 +02:00
Morris Jobke b35daf665f Migrate verbose messages to inline syntax of writeln()
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-18 11:13:52 +00:00
Morris Jobke 55393939ce Show lock messages only in verbose mode
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-18 11:13:52 +00:00
Morris Jobke e9e5a02d7c Allow to run occ preview:repair in parallel
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-18 11:13:52 +00:00
John Molakvoæ (skjnldsv) 7ad973494a Prevent empty search placeholder
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-09-18 09:36:41 +00:00
John Molakvoæ (skjnldsv) 5646144fae Build assets and fix unified search event syntax
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-09-18 09:36:40 +00:00
John Molakvoæ (skjnldsv) 839f597921 Properly show loading state if there are still pending requests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-09-18 09:36:39 +00:00
John Molakvoæ (skjnldsv) 3c6319f275 Properly use form role=search and unify reset button
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-09-18 09:36:39 +00:00
John Molakvoæ (skjnldsv) 2672f5da59 Fix loading error catch
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-09-18 09:36:39 +00:00
Roeland Jago Douma 2000e2faa5 Merge pull request #22932 from nextcloud/backport/22925/stable20
[stable20] Dashboard: Fix accessibility skip links
2020-09-18 11:32:38 +02:00
Jan C. Borchardt 0504873a8a Dashboard: Fix accessibility skip links
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2020-09-18 06:35:28 +00:00
Robin Appelman eba4723428 improve handling of out of space errors for smb
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-17 18:47:33 +00:00
14688 changed files with 618543 additions and 1114555 deletions
+15
View File
@@ -0,0 +1,15 @@
codecov:
branch: master
ci:
- drone.nextcloud.com
- !scrutinizer-ci.com
coverage:
precision: 2
round: down
range: "70...100"
status:
project: off
patch: off
comment: off
-91
View File
@@ -1,91 +0,0 @@
FROM ubuntu:noble
ARG DEBIAN_FRONTEND=noninteractive
# PHP
RUN apt-get update -y && \
apt install -y apache2 vim software-properties-common sudo nano gnupg2 wget curl git \
lsb-release ca-certificates apt-transport-https && \
add-apt-repository ppa:ondrej/php -y && \
apt-get update -y
RUN apt-get install --no-install-recommends -y \
php8.4 \
php8.4-common \
php8.4-gd \
php8.4-zip \
php8.4-curl \
php8.4-xml \
php8.4-xmlrpc \
php8.4-mbstring \
php8.4-sqlite \
php8.4-xdebug \
php8.4-pgsql \
php8.4-intl \
php8.4-imagick \
php8.4-gmp \
php8.4-apcu \
php8.4-bcmath \
php8.4-redis \
php8.4-soap \
php8.4-imap \
php8.4-opcache \
php8.4-cli \
php8.4-dev \
libmagickcore-6.q16-7-extra \
lsof \
make \
unzip
# Composer
RUN curl -sS https://getcomposer.org/installer -o /tmp/composer-setup.php && \
curl -sS https://composer.github.io/installer.sig -o /tmp/composer-setup.sig && \
php -r "if (hash_file('sha384', '/tmp/composer-setup.php') !== trim(file_get_contents('/tmp/composer-setup.sig'))) { echo 'Composer installation failed, invalid hash'; exit(1); }" && \
php /tmp/composer-setup.php --install-dir=/usr/local/bin --filename=composer && \
rm /tmp/composer-setup.php /tmp/composer-setup.sig
RUN echo "xdebug.remote_enable = 1" >> /etc/php/8.4/cli/conf.d/20-xdebug.ini && \
echo "xdebug.remote_autostart = 1" >> /etc/php/8.4/cli/conf.d/20-xdebug.ini && \
echo "apc.enable_cli=1" >> /etc/php/8.4/cli/conf.d/20-apcu.ini
# Autostart XDebug for apache
RUN { \
echo "xdebug.mode=debug"; \
echo "xdebug.start_with_request=yes"; \
} >> /etc/php/8.4/apache2/conf.d/20-xdebug.ini
# Increase PHP memory limit to 512mb
RUN sed -i 's/memory_limit = .*/memory_limit = 512M/' /etc/php/8.4/apache2/php.ini
# Docker CLI only (for controlling host Docker via socket)
RUN install -m 0755 -d /etc/apt/keyrings && \
curl -fsSL https://download.docker.com/linux/ubuntu/gpg -o /etc/apt/keyrings/docker.asc && \
chmod a+r /etc/apt/keyrings/docker.asc && \
echo \
"deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/ubuntu \
$(. /etc/os-release && echo "${UBUNTU_CODENAME:-$VERSION_CODENAME}") stable" | \
tee /etc/apt/sources.list.d/docker.list > /dev/null && \
apt-get update -y && \
apt-get install -y docker-ce-cli && \
ln -s /var/run/docker-host.sock /var/run/docker.sock
# Dedicated DevContainer user runs Apache
ENV APACHE_RUN_USER=devcontainer
ENV APACHE_RUN_GROUP=devcontainer
# Delete any existing user/group with UID/GID 1000 first
RUN (getent passwd 1000 && userdel -r $(getent passwd 1000 | cut -d: -f1)) || true && \
(getent group 1000 && groupdel $(getent group 1000 | cut -d: -f1)) || true && \
groupadd -g 1000 ${APACHE_RUN_GROUP} && \
useradd -u 1000 -g 1000 -ms /bin/bash ${APACHE_RUN_USER} && \
adduser ${APACHE_RUN_USER} sudo && \
echo '%sudo ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers && \
sed -ri "s/^export APACHE_RUN_USER=.*$/export APACHE_RUN_USER=${APACHE_RUN_USER}/" "/etc/apache2/envvars" && \
sed -ri "s/^export APACHE_RUN_GROUP=.*$/export APACHE_RUN_GROUP=${APACHE_RUN_GROUP}/" "/etc/apache2/envvars"
USER devcontainer
# NVM
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.0/install.sh | bash
RUN bash --login -i -c 'source /home/devcontainer/.bashrc && nvm install 22'
WORKDIR /var/www/html
-2
View File
@@ -1,2 +0,0 @@
SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
SPDX-License-Identifier: AGPL-3.0-or-later
-76
View File
@@ -1,76 +0,0 @@
<!--
- SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
- SPDX-License-Identifier: AGPL-3.0-or-later
-->
# Nextcloud DevContainer
## Usage
Make sure you have the [VSCode DevContainer](https://code.visualstudio.com/docs/devcontainers/containers) extensions installed. If you open the project, VSCode will ask you if you want to open it inside of the DevContainer. If that's not the case, use <kbd>F1</kbd>&rarr;*Dev Containers: Open Folder in Container*.
Alternatively open the project directly in [GitHub Codespaces](https://github.com/codespaces/new?hide_repo_select=true&ref=master&repo=60243197&skip_quickstart=true).
That's already it. Everything else will be configured automatically by the Containers startup routine.
## Credentials
On first start the Container installs and configures Nextcloud with the following credentials:
**Nextcloud Admin Login**
Username: `admin` <br>
Password: `admin`
**Postgres credentials**
Username: `postgres` <br>
Password: `postgres` <br>
Database: `postgres`
## Services
The following services will be started:
| Service | Local port | Description |
|---------|------------|-------------|
| Nextcloud (served via Apache) | `80` | The main application |
| Mailhog | `8025` | SMTP email delivery for testing |
| Adminer | `8080` | Database viewer. Use credentials from above and connect to `localhost` to get access to the NC database |
## Permissions
The container runs with the user `devcontainer` who is also running the Apache2 process. All mounted source files have
proper permissions so that this user can access everything which is inside the current workspace. If you need to
get root permissions for whatever reason, use `sudo su` or `sudo <command>` (for example `sudo service apache2 restart`).
Everything else (like building the application, adjusting files, ...) should be done as `devcontainer` user.
## NodeJs and NVM
The container comes with [`nvm`](https://github.com/nvm-sh/nvm) and Node 16 installed. This should be sufficient to
build Nextcloud Core sources via `make`. If you need a different Node Version (for example for
app development), you can easily switch between different versions by running:
```bash
# Install and use Node 14
nvm install 14
nvm use 14
# Check version
node -v
# Switch back to Node 16
nvm use 16
# Check version
node -v
```
Note that `nvm` is only installed for the user `devcontainer` and won't work out of the box for
any other user.
## Debugging
The Apache webserver is already configured to automatically try to connect to a debugger process
listening on port `9003`. To start the VSCode debugger process, use the delivered debug profile `Listen for XDebug`.
After you started the VSCode debugger, just navigate to the appropriate Nextcloud URL to get your
debug hits.
-26
View File
@@ -1,26 +0,0 @@
<?php
/**
* SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
$codespaceName = getenv('CODESPACE_NAME');
$codespaceDomain = getenv('GITHUB_CODESPACES_PORT_FORWARDING_DOMAIN');
$CONFIG = [
'mail_from_address' => 'no-reply',
'mail_smtpmode' => 'smtp',
'mail_sendmailmode' => 'smtp',
'mail_domain' => 'example.com',
'mail_smtphost' => 'localhost',
'mail_smtpport' => '1025',
'memcache.local' => '\OC\Memcache\APCu',
];
if(is_string($codespaceName) && !empty($codespaceName) && is_string($codespaceDomain) && !empty($codespaceDomain)) {
$host = $codespaceName . '-80.' . $codespaceDomain;
$CONFIG['overwritehost'] = $host;
$CONFIG['overwrite.cli.url'] = 'https://' . $host;
$CONFIG['overwriteprotocol'] = 'https';
$CONFIG['trusted_domains'] = [ $host ];
}
-28
View File
@@ -1,28 +0,0 @@
{
"name": "NextcloudServer",
"dockerComposeFile": "docker-compose.yml",
"service": "nextclouddev",
"postCreateCommand": ".devcontainer/setup.sh",
"postStartCommand": ".devcontainer/postStart.sh",
"forwardPorts": [
80,
8080,
8025
],
"customizations": {
"vscode": {
"extensions": [
"felixfbecker.php-debug",
"felixfbecker.php-intellisense",
"ms-azuretools.vscode-docker",
"xdebug.php-debug",
"donjayamanne.githistory"
],
"settings": {
"php.suggest.basic": false
}
}
},
"workspaceFolder": "/var/www/html",
"remoteUser": "devcontainer"
}
-2
View File
@@ -1,2 +0,0 @@
SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
SPDX-License-Identifier: AGPL-3.0-or-later
-37
View File
@@ -1,37 +0,0 @@
# SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
services:
nextclouddev:
build: .
volumes:
- .:/workspace:cached
- /var/run/docker.sock:/var/run/docker-host.sock
- ..:/var/www/html
command: /var/www/html/.devcontainer/entrypoint.sh
ports:
- 80:80
- 8080:8080
- 8025:8025
db:
image: postgres
restart: always
environment:
POSTGRES_PASSWORD: postgres
PGDATA: /data/postgres
volumes:
- db:/data/postgres
network_mode: service:nextclouddev
adminer:
image: adminer
restart: always
network_mode: service:nextclouddev
mailhog:
image: mailhog/mailhog
restart: always
network_mode: service:nextclouddev
volumes:
db:
-8
View File
@@ -1,8 +0,0 @@
#!/bin/bash
#
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
#
sudo service apache2 start
while sleep 1000; do :; done
-14
View File
@@ -1,14 +0,0 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"name": "Listen for Xdebug",
"type": "php",
"request": "launch",
"port": 9003
}
]
}
-2
View File
@@ -1,2 +0,0 @@
SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
SPDX-License-Identifier: AGPL-3.0-or-later
-13
View File
@@ -1,13 +0,0 @@
#!/bin/bash
#
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
#
# Set git safe.directory
git config --global --add safe.directory /var/www/html
git config --global --add safe.directory /var/www/html/3rdparty
# Ensure devcontainer user has access to docker socket
if [ -S /var/run/docker.sock ]; then
sudo chmod 666 /var/run/docker.sock
fi
-33
View File
@@ -1,33 +0,0 @@
#!/bin/bash
#
# SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
#
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )/../" >/dev/null 2>&1 && pwd )"
cd $DIR/
git submodule update --init
# Codespace config
cp .devcontainer/codespace.config.php config/codespace.config.php
# VSCode debugger profile
mkdir -p .vscode && cp .devcontainer/launch.json .vscode/launch.json
# Onetime installation setup
if [[ ! $(sudo -u ${APACHE_RUN_USER} php occ status) =~ installed:[[:space:]]*true ]]; then
echo "Running NC installation"
sudo -u ${APACHE_RUN_USER} php occ maintenance:install \
--verbose \
--database=pgsql \
--database-name=postgres \
--database-host=127.0.0.1 \
--database-port=5432 \
--database-user=postgres \
--database-pass=postgres \
--admin-user admin \
--admin-pass admin
fi
sudo service apache2 restart
+2359
View File
File diff suppressed because it is too large Load Diff
+4 -15
View File
@@ -1,8 +1,5 @@
# https://editorconfig.org
# SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
root = true
[*]
@@ -13,6 +10,10 @@ indent_style = tab
insert_final_newline = true
trim_trailing_whitespace = true
[*.feature]
indent_size = 2
indent_style = space
[*.yml]
indent_size = 2
indent_style = space
@@ -22,15 +23,3 @@ trim_trailing_whitespace = false
[*.svg]
insert_final_newline = false
[package*.json]
indent_size = 2
indent_style = space
[build/psalm-baseline.xml]
indent_size = 2
indent_style = space
[config/*config.php]
indent_size = 2
indent_style = space
-3
View File
@@ -1,3 +0,0 @@
watch_file lib/versioncheck.php
watch_file package.json
use flake
+17
View File
@@ -0,0 +1,17 @@
module.exports = {
globals: {
__webpack_nonce__: true,
__webpack_public_path__: true,
_: true,
$: true,
moment: true,
escapeHTML: true,
oc_userconfig: true,
dayNames: true,
firstDay: true
},
extends: ['@nextcloud'],
rules: {
'no-tabs': 'warn',
}
}
-25
View File
@@ -1,25 +0,0 @@
# .git-blame-ignore-revs
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
# Format control structures
caff1023ea72bb2ea94130e18a2a6e2ccf819e5f
# Update to coding-standard 1.1.1
aa5f037af71c915424c6dcfd5ad2dc82797dc0d6
# Update to coding-standard 1.2.3
af6de04e9e141466dc229e444ff3f146f4a34765
0bd284cb81b6866338aaaa67aa1d81ef9bfbb2ab
8af7ecb2576071f170ecbb0aa2311b26581e40e2
# Update to coding-standard 1.3.1
9836e9b16484582d309c8437ab46d82e34956941
# Automated refactorings
49dd79eabb2b8902559a7a4e8f8fcad54f46b604
# @nextcloud/vue import paths
b06f5ba4c47450f355a8903c1a93ac68e8c6cfc2
# Update to coding-standard 1.4.0
5981b7eb512aa411f51cad541d01c5c6e93476f0
# Migrate `and` `or` operators to logical `&&` `||` operators
660f3f6fd1ae5539b8f74bfa48859d1b9f1e6abf
# Migrate to ESLint v9 enforced code style
91f3b6b4ee60e0f8bb6e21f92d5bc52e4cebe657
+32 -6
View File
@@ -1,6 +1,32 @@
# SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
/dist/* binary
/package-lock.json merge=binary
/core/css/*.css* binary
/.devcontainer/*.sh text eol=lf
/core/js/dist/*.js binary
/core/js/dist/*.js.map binary
/apps/accessibility/js/*.js binary
/apps/accessibility/js/*.js.map binary
/apps/comments/js/*.js binary
/apps/comments/js/*.js.map binary
/apps/dashboard/js/*.js binary
/apps/dashboard/js/*.js.map binary
/apps/files/js/dist/*.js binary
/apps/files/js/dist/*.js.map binary
/apps/files_sharing/js/dist/*.js binary
/apps/files_sharing/js/dist/*.js.map binary
/apps/files_trashbin/js/*.js binary
/apps/files_trashbin/js/*.js.map binary
/apps/files_versions/js/*.js binary
/apps/files_versions/js/*.js.map binary
/apps/oauth2/js/*.js binary
/apps/oauth2/js/*.js.map binary
/apps/settings/js/vue* binary
/apps/systemtags/js/systemtags.js binary
/apps/systemtags/js/systemtags.js.map binary
/apps/twofactor_backupcodes/js/*.js binary
/apps/twofactor_backupcodes/js/*.js.map binary
/apps/updatenotification/js/updatenotification.js binary
/apps/updatenotification/js/updatenotification.js.map binary
/apps/user_status/js/*.js binary
/apps/user_status/js/*.js.map binary
/apps/weather_status/js/*.js binary
/apps/weather_status/js/*.js.map binary
/apps/workflowengine/js/*.js binary
/apps/workflowengine/js/*.js.map binary
+2 -111
View File
@@ -1,111 +1,2 @@
# Fallback owners for code review - ensure all PRs have someone assigned for review.
# (the last match will used so this is only used if there is no more specific code owner below)
# Backend
# is the first and gets everything to make things easier from matching syntax
* @nextcloud/server-backend
# Frontend
# this will override the backend code owners if needed
/__mocks__ @nextcloud/server-frontend
/__tests__ @nextcloud/server-frontend
/dist @nextcloud/server-frontend
/cypress @nextcloud/server-frontend
**/css @nextcloud/server-frontend
**/js @nextcloud/server-frontend
**/src @nextcloud/server-frontend
*.js @nextcloud/server-frontend
*.cjs @nextcloud/server-frontend
*.mjs @nextcloud/server-frontend
*.ts @nextcloud/server-frontend
# dependency management
package.json @nextcloud/server-dependabot @nextcloud/server-frontend
package-lock.json @nextcloud/server-dependabot
# App maintainers
/apps/admin_audit/appinfo/info.xml @luka-nextcloud @blizzz
/apps/cloud_federation_api/appinfo/info.xml @nfebe @mejo-
/apps/comments/appinfo/info.xml @edward-ly @sorbaugh
/apps/contactsinteraction/appinfo/info.xml @kesselb @SebastianKrupinski
/apps/contactsinteraction/lib @kesselb @SebastianKrupinski
/apps/contactsinteraction/tests @kesselb @SebastianKrupinski
/apps/dashboard/appinfo/info.xml @julien-nc @juliusknorr
/apps/dav/lib/CalDAV @ChristophWurst @SebastianKrupinski @tcitworld
/apps/dav/lib/CardDAV @hamza221 @SebastianKrupinski
/apps/dav/tests/unit/CalDAV @ChristophWurst @SebastianKrupinski @tcitworld
/apps/dav/tests/unit/CardDAV @hamza221 @SebastianKrupinski
/apps/encryption/appinfo/info.xml @come-nc @icewind1991
/apps/federatedfilesharing/appinfo/info.xml @icewind1991 @danxuliu
/apps/federation/appinfo/info.xml @nfebe @sorbaugh
/apps/files/appinfo/info.xml @skjnldsv @ArtificialOwl @come-nc @artonge @icewind1991 @szaimen @susnux @nfebe
/apps/files_external/appinfo/info.xml @icewind1991 @artonge
/apps/files_reminders/appinfo/info.xml @skjnldsv @sorbaugh
/apps/files_sharing/appinfo/info.xml @skjnldsv @come-nc
/apps/files_trashbin/appinfo/info.xml @icewind1991 @sorbaugh
/apps/files_versions/appinfo/info.xml @artonge @icewind1991
/apps/oauth2/appinfo/info.xml @julien-nc @ChristophWurst
/apps/provisioning_api/appinfo/info.xml @provokateurin @nickvergessen
/apps/settings/appinfo/info.xml @JuliaKirschenheuter @sorbaugh
/apps/sharebymail/appinfo/info.xml @Altahrim @skjnldsv
/apps/systemtags/appinfo/info.xml @Antreesy @marcelklehr
/apps/theming/appinfo/info.xml @skjnldsv @juliusknorr
/apps/twofactor_backupcodes/appinfo/info.xml @miaulalala @ChristophWurst
/apps/updatenotification/appinfo/info.xml @JuliaKirschenheuter @sorbaugh
/apps/user_ldap/appinfo/info.xml @come-nc @blizzz
/apps/user_status/appinfo/info.xml @Antreesy @nickvergessen
/apps/weather_status/appinfo/info.xml @julien-nc @juliusknorr
/apps/webhook_listeners/appinfo/info.xml @come-nc @julien-nc
/apps/workflowengine/appinfo/info.xml @blizzz @juliusknorr
# Files frontend expertise
/apps/files/src* @skjnldsv @nextcloud/server-frontend
/apps/files_external/src* @skjnldsv @nextcloud/server-frontend
/apps/files_reminders/src* @skjnldsv @nextcloud/server-frontend
/apps/files_sharing/src/actions* @skjnldsv @nextcloud/server-frontend
/apps/files_trashbin/src* @skjnldsv @nextcloud/server-frontend
# Security team
/build/psalm-baseline-security.xml @nickvergessen @nextcloud/server-backend
/resources/codesigning @mgallien @miaulalala @nickvergessen
/resources/config/ca-bundle.crt @miaulalala @nickvergessen
# Two-Factor Authentication
# https://github.com/nextcloud/wg-two-factor-authentication#members
**/TwoFactorAuth @ChristophWurst @miaulalala @nickvergessen
/apps/twofactor_backupcodes @ChristophWurst @miaulalala @nickvergessen
/core/templates/twofactor* @ChristophWurst @miaulalala @nickvergessen
# Limit login to IP
# Watch login routes for https://github.com/nextcloud/limit_login_to_ip
/core/routes.php @Altahrim @nextcloud/server-backend
# OpenAPI
openapi*.json @provokateurin @nextcloud/server-backend
ResponseDefinitions.php @provokateurin @nextcloud/server-backend
# Talk team
/lib/private/Comments @nickvergessen @nextcloud/talk-backend
/lib/private/Federation @nickvergessen @nextcloud/talk-backend @nextcloud/server-backend
/lib/private/Talk @nickvergessen @nextcloud/talk-backend
/lib/public/Comments @nickvergessen @nextcloud/talk-backend
/lib/public/Federation @nickvergessen @nextcloud/talk-backend @nextcloud/server-backend
/lib/public/OCM @nickvergessen @nextcloud/talk-backend @nextcloud/server-backend
/lib/public/Talk @nickvergessen @nextcloud/talk-backend
/lib/public/UserStatus @nickvergessen @nextcloud/talk-backend
*/Notifications/* @nickvergessen @nextcloud/talk-backend
# Groupware team
/build/integration/dav_features/caldav.feature @ChristophWurst @SebastianKrupinski @tcitworld
/build/integration/dav_features/carddav.feature @hamza221 @SebastianKrupinski
/lib/private/Calendar @ChristophWurst @SebastianKrupinski @tcitworld
/lib/private/Contacts @hamza221 @SebastianKrupinski
/lib/public/Calendar @ChristophWurst @SebastianKrupinski @tcitworld
/lib/public/Contacts @hamza221 @SebastianKrupinski
# Desktop client teamn
/apps/dav/lib/Connector/Sabre/BlockLegacyClientPlugin.php @nextcloud/desktop
# Personal interest
*/Activity/* @nickvergessen @nextcloud/server-backend
/apps/workflowengine/lib @nickvergessen @blizzz
*/Activity/* @nickvergessen
*/Notifications/* @nickvergessen
+6 -17
View File
@@ -1,10 +1,6 @@
<!--
- SPDX-FileCopyrightText: 2016 Nextcloud GmbH and Nextcloud contributors
- SPDX-License-Identifier: AGPL-3.0-or-later
-->
## Submitting issues
If you have questions about how to install or use Nextcloud, please direct these to our [forum][forum]. We are also available on [IRC][irc] (unofficial).
If you have questions about how to install or use Nextcloud, please direct these to our [forum][forum]. We are also available on [IRC][irc].
### Short version
@@ -25,7 +21,7 @@ Help us to maximize the effort we can spend fixing issues and adding new feature
[templates]: ./ISSUE_TEMPLATE
[forum]: https://help.nextcloud.com/
[irc]: https://web.libera.chat/#nextcloud
[irc]: https://webchat.freenode.net/?channels=nextcloud
## Contributing to Source Code
@@ -33,13 +29,6 @@ Thanks for wanting to contribute source code to Nextcloud. That's great!
Please read the [Developer Manuals][devmanual] to learn how to create your first application or how to test the Nextcloud code with PHPUnit.
### Conventional Commits
Please use [Conventional Commits](https://www.conventionalcommits.org) for your commit messages. This helps maintain clarity and consistency across the project, making it easier to understand changes and automate versioning.
```
feat(files_sharing): allow sharing with contacts
```
### Tests
In order to constantly increase the quality of our software we can no longer accept pull request which submit un-tested code.
@@ -48,16 +37,16 @@ In some areas unit testing is hard (aka almost impossible) as of today - in thes
### Sign your work
We use the Developer Certificate of Origin (DCO) as an additional safeguard
We use the Developer Certificate of Origin (DCO) as a additional safeguard
for the Nextcloud project. This is a well established and widely used
mechanism to assure contributors have confirmed their right to license
their contribution under the project's license.
Please read [contribute/developer-certificate-of-origin][dcofile].
If you can certify it, then just add a line to every git commit message:
```
Signed-off-by: Random J Developer <random@developer.example.org>
```
````
Signed-off-by: Random J Developer <random@developer.example.org>
````
Use your real name (sorry, no pseudonyms or anonymous contributions).
If you set your `user.name` and `user.email` git configs, you can sign your
-3
View File
@@ -1,3 +0,0 @@
# SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
custom: https://nextcloud.com/include/
-212
View File
@@ -1,212 +0,0 @@
# SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
name: "🐛 Bug report: Nextcloud Server"
description: "Submit a report and help us improve Nextcloud Server"
title: "[Bug]: "
labels: ["bug", "0. Needs triage"]
type: "Bug"
body:
- type: markdown
attributes:
value: |
### 👍 Thank you for contributing to our project!
Please note this is a **free and open-source** project. Most people take on their own time to help you, so please, be patient.
You can obtain [Enterprise support](https://nextcloud.com/support/) if you run Nextcloud Server in a mission critical environment.
- type: markdown
attributes:
value: |
### 🚨 SECURITY INFO
If you are reporting a security concern, please report it via [our HackerOne page](https://hackerone.com/nextcloud) instead and review our [security policy](https://nextcloud.com/security/).
This allows us to coordinate the fix and release without potentially exposing all Nextcloud servers and users in the meantime.
It also may qualify your report for a bug bounty reward.
Thank you for helping make Nextcloud more secure!
- type: checkboxes
id: before-posting
attributes:
label: "⚠️ This issue respects the following points: ⚠️"
description: All conditions are **required**. Your issue can be closed if these are checked incorrectly.
options:
- label: This is a **bug**, not a question or a configuration/webserver/proxy issue.
required: true
- label: This issue is **not** already reported on [Github](https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3Abug) OR [Nextcloud Community Forum](https://help.nextcloud.com/) _(I've searched it)_.
required: true
- label: Nextcloud Server **is** up to date. See [Maintenance and Release Schedule](https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule) for supported versions.
required: true
- label: I agree to follow Nextcloud's [Code of Conduct](https://nextcloud.com/contribute/code-of-conduct/).
required: true
- type: textarea
id: bug-description
attributes:
label: Bug description
description: |
Provide a description of the bug you're experiencing.
Don't just expect someone will guess what your specific problem is and provide full details.
validations:
required: true
- type: textarea
id: reproduce
attributes:
label: Steps to reproduce
description: |
Describe the steps to reproduce the bug.
The better your description is _(go 'here', click 'there'...)_ the fastest you'll get an _(accurate)_ answer.
value: |
1.
2.
3.
validations:
required: true
- type: textarea
id: expected-behavior
attributes:
label: Expected behavior
description: Describe what you expected to happen instead.
validations:
required: true
- type: dropdown
id: nextcloud-version
attributes:
label: Nextcloud Server version
description: |
Select Nextcloud Server version.
_Versions not listed here are not maintained and not supported anymore_
options:
- "32"
- "33"
- "34 (master)"
validations:
required: true
- type: dropdown
id: system
attributes:
label: Operating system
description: |
Select operating system where Nextcloud Server is installed.
_Describe in the "Additional info" section if you chose "Other"._
options:
- "Debian/Ubuntu"
- "RHEL/CentOS"
- "Other"
- type: dropdown
id: php
attributes:
label: PHP engine version
description: |
Select PHP engine version serving Nextcloud Server.
_Describe in the "Additional info" section if you chose "Other"._
options:
- "PHP 8.5"
- "PHP 8.4"
- "PHP 8.3"
- "PHP 8.2"
- "PHP 8.1"
- "Other"
- type: dropdown
id: webserver
attributes:
label: Web server
description: |
Select Webserver serving Nextcloud Server.
_Describe in the "Additional info" section if you chose "Other"._
options:
- "Apache (supported)"
- "Nginx"
- "Other"
- type: dropdown
id: database
attributes:
label: Database engine version
description: |
Select Database engine serving Nextcloud Server.
_Describe in the "Additional info" section if you chose "Other"._
options:
- "MySQL"
- "MariaDB"
- "PostgreSQL"
- "SQlite"
- "Oracle"
- "Other"
- type: dropdown
id: fresh
attributes:
label: Is this bug present after an update or on a fresh install?
description: |
Select if bug is present after an update or on a fresh install.
options:
- "Updated from a MINOR version (ex. 32.0.1 to 32.0.2)"
- "Upgraded to a MAJOR version (ex. 31 to 32)"
- "Fresh Nextcloud Server install"
- type: dropdown
id: encryption
attributes:
label: Are you using the Nextcloud Server Encryption module?
description: Select if encryption is Enabled on your Nextcloud Server.
options:
- "Encryption is Enabled"
- "Encryption is Disabled"
- type: checkboxes
id: users
attributes:
label: What user-backends are you using?
description: |
Select **all** user-backends Enabled on your Nextcloud Server.
_Describe in the "Additional info" section if you chose "Other"._
options:
- label: "Default user-backend _(database)_"
- label: "LDAP/ Active Directory"
- label: "SSO - SAML"
- label: "Other"
- type: textarea
id: configs
attributes:
label: Configuration report
description: |
Provide information about your configuration.
To get this information, execute one of the following commands on the CLI:
```shell
sudo -u www-data php occ config:list system
php occ config:list system
./occ config:list system
```
> NOTE: This will be automatically formatted into code for better readability.
render: json
- type: textarea
id: apps
attributes:
label: List of activated Apps
description: |
Provide information about your apps.
To get this information, execute one of the following commands on the CLI:
```shell
sudo -u www-data php occ app:list
php occ app:list
./occ app:list
```
> NOTE: This will be automatically formatted into code for better readability.
render: shell
- type: textarea
id: nextcloud-signingstatus
attributes:
label: Nextcloud Signing status
description: |
Provide Nextcloud Signing status.
First, login as Admin user into your Nextcloud, then access this URL:
```shell
https://yournextcloud.tld/index.php/settings/integrity/failed
```
> NOTE: This will be automatically formatted into code for better readability.
render: shell
- type: textarea
id: nextcloud-log
attributes:
label: Nextcloud Logs
description: |
Provide relevant Nextcloud log entries (e.g. from the time period you reproduced the problem).
Copy full individual entries from `data/nextcloud.log` or use `Copy raw entry` from `/settings/admin/logging` section:
> NOTE: This will be automatically formatted into code for better readability.
render: json
- type: textarea
id: additional-info
attributes:
label: Additional info
description: Any additional information related to the issue (ex. browser console errors, software versions).
+166
View File
@@ -0,0 +1,166 @@
---
name: 🐛 Bug report
about: Help us improving by reporting a bug
labels: bug, 0. Needs triage
---
<!--
Thanks for reporting issues back to Nextcloud!
Note: This is the **issue tracker of Nextcloud**, please do NOT use this to get answers to your questions or get help for fixing your installation. This is a place to report bugs to developers, after your server has been debugged. You can find help debugging your system on our home user forums: https://help.nextcloud.com or, if you use Nextcloud in a large organization, ask our engineers on https://portal.nextcloud.com. See also https://nextcloud.com/support for support options.
Nextcloud is an open source project backed by Nextcloud GmbH. Most of our volunteers are home users and thus primarily care about issues that affect home users. Our paid engineers prioritize issues of our customers. If you are neither a home user nor a customer, consider paying somebody to fix your issue, do it yourself or become a customer.
Guidelines for submitting issues:
* Please search the existing issues first, it's likely that your issue was already reported or even fixed.
- Go to https://github.com/nextcloud and type any word in the top search/command bar. You probably see something like "We couldnt find any repositories matching ..." then click "Issues" in the left navigation.
- You can also filter by appending e. g. "state:open" to the search string.
- More info on search syntax within github: https://help.github.com/articles/searching-issues
* This repository https://github.com/nextcloud/server/issues is *only* for issues within the Nextcloud Server code. This also includes the apps: files, encryption, external storage, sharing, deleted files, versions, LDAP, and WebDAV Auth
* SECURITY: Report any potential security bug to us via our HackerOne page (https://hackerone.com/nextcloud) following our security policy (https://nextcloud.com/security/) instead of filing an issue in our bug tracker.
* The issues in other components should be reported in their respective repositories: You will find them in our GitHub Organization (https://github.com/nextcloud/)
* You can also use the Issue Template app to prefill most of the required information: https://apps.nextcloud.com/apps/issuetemplate
-->
<!--- Please keep this note for other contributors -->
### How to use GitHub
* Please use the 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to show that you are affected by the same issue.
* Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
* Subscribe to receive notifications on status change and new comments.
### Steps to reproduce
1.
2.
3.
### Expected behaviour
Tell us what should happen
### Actual behaviour
Tell us what happens instead
### Server configuration
**Operating system:**
**Web server:**
**Database:**
**PHP version:**
**Nextcloud version:** (see Nextcloud admin page)
**Updated from an older Nextcloud/ownCloud or fresh install:**
**Where did you install Nextcloud from:**
**Signing status:**
<details>
<summary>Signing status</summary>
```
Login as admin user into your Nextcloud and access
http://example.com/index.php/settings/integrity/failed
paste the results here.
```
</details>
**List of activated apps:**
<details>
<summary>App list</summary>
```
If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder
```
</details>
**Nextcloud configuration:**
<details>
<summary>Config report</summary>
```
If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder
or
Insert your config.php content here.
Make sure to remove all sensitive content such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …)
```
</details>
**Are you using external storage, if yes which one:** local/smb/sftp/...
**Are you using encryption:** yes/no
**Are you using an external user-backend, if yes which one:** LDAP/ActiveDirectory/Webdav/...
#### LDAP configuration (delete this part if not used)
<details>
<summary>LDAP config</summary>
```
With access to your command line run e.g.:
sudo -u www-data php occ ldap:show-config
from within your Nextcloud installation folder
Without access to your command line download the data/owncloud.db to your local
computer or access your SQL server remotely and run the select query:
SELECT * FROM `oc_appconfig` WHERE `appid` = 'user_ldap';
Eventually replace sensitive data as the name/IP-address of your LDAP server or groups.
```
</details>
### Client configuration
**Browser:**
**Operating system:**
### Logs
<!--- Reports without logs might be closed as unqualified reports! -->
#### Web server error log
<details>
<summary>Web server error log</summary>
```
Insert your webserver log here
```
</details>
#### Nextcloud log (data/nextcloud.log)
<details>
<summary>Nextcloud log</summary>
```
Insert your Nextcloud log here
```
</details>
#### Browser log
<details>
<summary>Browser log</summary>
```
Insert your browser log here, this could for example include:
a) The javascript console log
b) The network log
c) ...
```
</details>
+28 -25
View File
@@ -2,44 +2,47 @@
name: 🚀 Feature request
about: Suggest an idea for this project
labels: enhancement, 0. Needs triage
type: "Enhancement"
---
<!--
Have a security concern? Please report potential security issues via our HackerOne program (https://hackerone.com/nextcloud) instead of filing a public GitHub issue. See our security policy: https://nextcloud.com/security/
Thanks for reporting issues back to Nextcloud!
Note: This is the **issue tracker of Nextcloud**, please do NOT use this to get answers to your questions or get help for fixing your installation. This is a place to report bugs to developers, after your server has been debugged. You can find help debugging your system on our home user forums: https://help.nextcloud.com or, if you use Nextcloud in a large organization, ask our engineers on https://portal.nextcloud.com. See also https://nextcloud.com/support for support options.
Nextcloud is an open source project backed by Nextcloud GmbH. Most of our volunteers are home users and thus primarily care about issues that affect home users. Our paid engineers prioritize issues of our customers. If you are neither a home user nor a customer, consider paying somebody to fix your issue, do it yourself or become a customer.
Guidelines for submitting issues:
* Please search the existing issues first, it's likely that your issue was already reported or even fixed.
- Go to https://github.com/nextcloud and type any word in the top search/command bar. You probably see something like "We couldnt find any repositories matching ..." then click "Issues" in the left navigation.
- You can also filter by appending e. g. "state:open" to the search string.
- More info on search syntax within github: https://help.github.com/articles/searching-issues
* This repository https://github.com/nextcloud/server/issues is *only* for issues within the Nextcloud Server code. This also includes the apps: files, encryption, external storage, sharing, deleted files, versions, LDAP, and WebDAV Auth
* SECURITY: Report any potential security bug to us via our HackerOne page (https://hackerone.com/nextcloud) following our security policy (https://nextcloud.com/security/) instead of filing an issue in our bug tracker.
* The issues in other components should be reported in their respective repositories: You will find them in our GitHub Organization (https://github.com/nextcloud/)
-->
<!--
Thanks for taking the time to suggest improvements to Nextcloud! Use this form to request features or propose enhancements.
Guidelines:
<!--- Please keep this note for other contributors -->
* Please search existing issues first; your idea may already have been discussed or implemented.
* This repository (https://github.com/nextcloud/server/issues) is only for issues within the Nextcloud Server code. This includes shipped apps such as Files, DAV, Encryption, External Storage, Sharing, Deleted Files, Versions, Federation, and LDAP.
* Issues for other components should be reported in their respective repositories in the Nextcloud GitHub organization: https://github.com/nextcloud/
* Nextcloud is an open source project backed by Nextcloud GmbH. Many contributors are volunteers and primarily focus on issues affecting home users. Paid engineers prioritize customer-reported issues and critical defects.
* This is the development issue tracker. Please do NOT use it for support questions or help diagnosing your installation.
- For community/user help: https://help.nextcloud.com
- For professional / large deployment support options: https://nextcloud.com/support
-->
### How to use GitHub
* Please use the 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to show that you are interested into the same feature.
* Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
* Subscribe to receive notifications on status change and new comments.
<!-- Please keep the note below for other contributors -->
> [!TIP]
> ### Help move this idea forward
> * Use the 👍 reaction to show support for this feature.
> * Avoid commenting unless you have relevant information to add; unnecessary comments create noise for subscribers.
> * Subscribe to receive notifications about status changes and new comments.
---
<!-- DO NOT EDIT ABOVE THIS LINE -->
**Is your feature request related to a problem? Please describe.**
<!-- Provide a clear and concise description of the problem. For example: “I'm always frustrated when …” -->
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
**Describe the solution you'd like**
<!-- Provide a clear and concise description of what you want to happen. -->
A clear and concise description of what you want to happen.
**Describe alternatives you've considered**
<!-- Provide a clear and concise description of any alternative solutions or features you've considered. -->
A clear and concise description of any alternative solutions or features you've considered.
**Additional context**
<!-- Add any other context or screenshots related to the feature request here. -->
Add any other context or screenshots about the feature request here.
@@ -1,2 +0,0 @@
SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
SPDX-License-Identifier: AGPL-3.0-or-later
+4 -8
View File
@@ -1,12 +1,8 @@
# SPDX-FileCopyrightText: 2020 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
blank_issues_enabled: false
contact_links:
- name: 🚨 Report a security or privacy issue
url: https://hackerone.com/nextcloud
about: Report security and privacy related issues privately to the Nextcloud team, so we can coordinate the fix and release without potentially exposing all Nextcloud servers and users in the meantime.
- name: ❓ Community Support and Help
- name: ❓ Question
url: https://help.nextcloud.com/
about: Configuration, webserver/proxy or performance issues and other questions
about: I have a question
- name: 💼 Nextcloud Enterprise
url: https://portal.nextcloud.com/
about: If you are a Nextcloud Enterprise customer, or need Professional support, so it can be resolved directly by our dedicated engineers more quickly
about: If you are a customer and are using Nextcloud Enterprise, please submit your issue directly in the Nextcloud Portal so it can be resolved by our dedicated engineers more quickly.
-7
View File
@@ -1,7 +0,0 @@
# SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
name: "CodeQL config"
paths-ignore:
- dist
-2
View File
@@ -1,5 +1,3 @@
# SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
firstPRMergeComment: >
Thanks for your first pull request and welcome to the community!
Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
-167
View File
@@ -1,167 +0,0 @@
# SPDX-FileCopyrightText: 2020 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
version: 2
updates:
# GitHub Actions
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: monthly
timezone: Europe/Paris
groups:
github-actions:
patterns:
- "*"
labels:
- "3. to review"
- "feature: dependencies"
# Main composer (linting, testing, openapi)
- package-ecosystem: composer
directories:
- "/"
- "/vendor-bin/behat"
- "/vendor-bin/cs-fixer"
- "/vendor-bin/openapi-extractor"
- "/vendor-bin/phpunit"
- "/vendor-bin/psalm"
- "/vendor-bin/rector"
schedule:
interval: weekly
day: saturday
time: "03:00"
timezone: Europe/Paris
labels:
- "3. to review"
- "feature: dependencies"
# Main master npm frontend dependencies
- package-ecosystem: npm
directories:
- "/"
- "/build/frontend"
- "/build/frontend-legacy"
schedule:
interval: weekly
day: saturday
time: "03:00"
timezone: Europe/Paris
open-pull-requests-limit: 20
labels:
- "3. to review"
- "feature: dependencies"
# Disable automatic rebasing because without a build CI will likely fail anyway
rebase-strategy: "disabled"
groups:
vite:
patterns:
- "vite"
- "@nextcloud/vite-config"
vitest:
patterns:
- "vitest"
- "@vitest/*"
# Latest stable release
# Composer dependencies for linting and testing
- package-ecosystem: composer
target-branch: stable33
directories:
- "/"
- "/vendor-bin/behat"
- "/vendor-bin/cs-fixer"
- "/vendor-bin/openapi-extractor"
- "/vendor-bin/phpunit"
- "/vendor-bin/psalm"
- "/vendor-bin/rector"
schedule:
interval: weekly
day: saturday
time: "03:30"
timezone: Europe/Paris
labels:
- "3. to review"
- "feature: dependencies"
ignore:
# only patch updates on stable branches
- dependency-name: "*"
update-types: ["version-update:semver-major", "version-update:semver-minor"]
# frontend dependencies
- package-ecosystem: npm
target-branch: stable33
directories:
- "/"
- "/build/frontend"
- "/build/frontend-legacy"
schedule:
interval: weekly
day: saturday
time: "03:30"
timezone: Europe/Paris
open-pull-requests-limit: 20
labels:
- "3. to review"
- "feature: dependencies"
# Disable automatic rebasing because without a build CI will likely fail anyway
rebase-strategy: "disabled"
groups:
vite:
patterns:
- "vite"
- "@nextcloud/vite-config"
vitest:
patterns:
- "vitest"
- "@vitest/*"
ignore:
# no major updates on stable branches
- dependency-name: "*"
update-types: ["version-update:semver-major"]
# Older stable releases
# Composer dependencies for linting and testing
- package-ecosystem: composer
target-branch: stable32
directories:
- "/"
- "/vendor-bin/behat"
- "/vendor-bin/cs-fixer"
- "/vendor-bin/openapi-extractor"
- "/vendor-bin/phpunit"
- "/vendor-bin/psalm"
schedule:
interval: weekly
day: saturday
time: "04:30"
timezone: Europe/Paris
labels:
- "3. to review"
- "feature: dependencies"
ignore:
# only patch updates on stable branches
- dependency-name: "*"
update-types: ["version-update:semver-major", "version-update:semver-minor"]
# frontend dependencies
- package-ecosystem: npm
target-branch: stable32
directory: "/"
schedule:
interval: weekly
day: saturday
time: "04:30"
timezone: Europe/Paris
open-pull-requests-limit: 20
labels:
- "3. to review"
- "feature: dependencies"
# Disable automatic rebasing because without a build CI will likely fail anyway
rebase-strategy: "disabled"
ignore:
# no major updates on stable branches
- dependency-name: "*"
update-types: ["version-update:semver-major"]
-29
View File
@@ -1,29 +0,0 @@
<!--
- 🚨 SECURITY INFO
-
- Before sending a pull request that fixes a security issue please report it via our HackerOne page (https://hackerone.com/nextcloud) following our security policy (https://nextcloud.com/security/). This allows us to coordinate the fix and release without potentially exposing all Nextcloud servers and users in the meantime.
-->
* Resolves: # <!-- related github issue -->
## Summary
## TODO
- [ ] ...
## Checklist
- Code is [properly formatted](https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/continuous_integration.html#linting)
- [Sign-off message](https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md) is added to all commits
- [ ] Tests ([unit](https://docs.nextcloud.com/server/latest/developer_manual/app_development/tutorial.html#unit-tests), [integration](https://docs.nextcloud.com/server/latest/developer_manual/app_development/tutorial.html#integration-tests), api and/or acceptance) are included
- [ ] Screenshots before/after for front-end changes
- [ ] Documentation ([manuals](https://github.com/nextcloud/documentation/) or wiki) has been updated or is not required
- [ ] [Backports requested](https://github.com/nextcloud/backportbot/#usage) where applicable (ex: critical bugfixes)
- [ ] [Labels added](https://github.com/nextcloud/server/labels) where applicable (ex: bug/enhancement, `3. to review`, feature component)
- [ ] [Milestone added](https://github.com/nextcloud/server/milestones) for target branch/version (ex: 32.x for `stable32`)
## AI (if applicable)
- [ ] The content of this PR was partly or fully generated using AI
-2
View File
@@ -1,2 +0,0 @@
SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors
SPDX-License-Identifier: AGPL-3.0-or-later
+33
View File
@@ -0,0 +1,33 @@
# We wait 1 months to check
daysUntilStale: 30
# If no answer after two weeks, we close
daysUntilClose: 14
# Only issues that requires info from the op
onlyLabels:
- "needs info"
# Only if issues that are not triaged
exemptLabels:
- "1. to develop"
- "2. developing"
- "3. to review"
- "4. to release"
- security
# Label to use when marking as stale
staleLabel: stale
# Comment to post when marking as stale. Set to `false` to disable
markComment: >
This issue has been automatically marked as stale because it has not had
recent activity and seems to be missing some essential information.
It will be closed if no further activity occurs. Thank you
for your contributions.
# Limit the number of actions per hour, from 1-30. Default is 30
limitPerRun: 30
# Limit to only `issues` or `pulls`
only: issues
-128
View File
@@ -1,128 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Code checkers
on:
pull_request:
permissions:
contents: read
concurrency:
group: autocheckers-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src }}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- '**.php'
- build/autoloaderchecker.sh
autoloader:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
matrix:
php-versions: ['8.2']
name: PHP checkers
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: none
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Check auto loaders
run: bash ./build/autoloaderchecker.sh
autocheckers:
runs-on: ubuntu-latest-low
strategy:
matrix:
php-versions: ['8.2']
name: Translation and Files checkers
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: none
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Check translations are JSON decodeable
run: php ./build/translation-checker.php
- name: Check translations do not contain triple dot but ellipsis
run: php ./build/triple-dot-checker.php
- name: Check .htaccess does not contain invalid changes
run: php ./build/htaccess-checker.php
- name: Check that all and only expected files are included
run: php ./build/files-checker.php
- name: Check that all shipped apps are linted by psalm
run: sh ./build/psalm-checker.sh
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, autoloader, autocheckers]
if: always()
name: autocheckers-summary
steps:
- name: Summary status
run: if ${{ needs.autocheckers.result != 'success' || (needs.changes.outputs.src != 'false' && needs.autoloader.result != 'success') }}; then exit 1; fi
+12 -31
View File
@@ -2,48 +2,29 @@
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2022-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Block merges for EOL
name: Pull request checks
on: pull_request
permissions:
contents: read
concurrency:
group: block-merge-eol-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
block-merges-eol:
name: Block merges for EOL branches
# Only run on stableXX branches
if: startsWith( github.base_ref, 'stable')
runs-on: ubuntu-latest-low
runs-on: ubuntu-latest
steps:
- name: Set server major version environment
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
const regex = /^stable(\d+)$/
const baseRef = context.payload.pull_request.base.ref
const match = baseRef.match(regex)
if (match) {
console.log('Setting server_major to ' + match[1]);
core.exportVariable('server_major', match[1]);
console.log('Setting current_day to ' + (new Date()).toISOString().substr(0, 10));
core.exportVariable('current_day', (new Date()).toISOString().substr(0, 10));
}
- name: Download updater config
run: curl https://raw.githubusercontent.com/nextcloud/updater_server/production/config/config.php --output config.php
- name: Checking if server ${{ env.server_major }} is EOL
if: ${{ env.server_major != '' }}
- name: Set server major version environment
run: |
curl -s https://raw.githubusercontent.com/nextcloud-releases/updater_server/production/config/major_versions.json \
| jq '.["${{ env.server_major }}"]["eol"] // "9999-99-99" | . >= "${{ env.current_day }}"' \
| grep -q true
# retrieve version number from branch reference
server_major=$(echo "${{ github.base_ref }}" | sed -En 's/stable//p')
echo "server_major=$server_major" >> $GITHUB_ENV
- name: Checking if ${{ env.server_major }} is EOL
run: |
php -r 'echo json_encode(require_once "config.php");' | jq --arg version "${{ env.server_major }}" '.stable[$version]["100"].eol' | grep --silent -i 'false'
-57
View File
@@ -1,57 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2022-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Block merges during freezes
on:
pull_request:
types: [opened, ready_for_review, reopened, synchronize]
permissions:
contents: read
concurrency:
group: block-merge-freeze-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
block-merges-during-freeze:
name: Block merges during freezes
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest-low
steps:
- name: Register server reference to fallback to master branch
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
const baseRef = context.payload.pull_request.base.ref
if (baseRef === 'main' || baseRef === 'master') {
core.exportVariable('server_ref', 'master');
console.log('Setting server_ref to master');
} else {
const regex = /^stable(\d+)$/
const match = baseRef.match(regex)
if (match) {
core.exportVariable('server_ref', match[0]);
console.log('Setting server_ref to ' + match[0]);
} else {
console.log('Not based on master/main/stable*, so skipping freeze check');
}
}
- name: Download version.php from ${{ env.server_ref }}
if: ${{ env.server_ref != '' }}
run: curl 'https://raw.githubusercontent.com/nextcloud/server/${{ env.server_ref }}/version.php' --output version.php
- name: Run check
if: ${{ env.server_ref != '' }}
run: cat version.php | grep 'OC_VersionString' | grep -i -v 'RC'
@@ -1,79 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Block merging with outdated 3rdparty/
on:
pull_request:
types: [opened, ready_for_review, reopened, synchronize]
permissions:
contents: read
concurrency:
group: block-outdated-3rdparty-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
block-outdated-3rdparty:
name: Block merging with outdated 3rdparty/
runs-on: ubuntu-latest-low
steps:
- name: Check requirement
uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '3rdparty'
- 'version.php'
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
- name: 3rdparty commit hash on current branch
id: actual
run: |
echo "commit=$(git submodule status | grep ' 3rdparty' | egrep -o '[a-f0-9]{40}')" >> "$GITHUB_OUTPUT"
- name: Register server reference to fallback to master branch
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
const baseRef = context.payload.pull_request.base.ref
if (baseRef === 'main' || baseRef === 'master') {
core.exportVariable('server_ref', 'master');
console.log('Setting server_ref to master');
} else {
const regex = /^stable(\d+)$/
const match = baseRef.match(regex)
if (match) {
core.exportVariable('server_ref', match[0]);
console.log('Setting server_ref to ' + match[0]);
} else {
console.log('Not based on master/main/stable*, so skipping outdated 3rdparty check');
}
}
- name: Last 3rdparty commit on target branch
if: ${{ env.server_ref != '' }}
id: target
run: |
echo "commit=$(git ls-remote https://github.com/nextcloud/3rdparty refs/heads/${{ env.server_ref }} | awk '{ print $1}')" >> "$GITHUB_OUTPUT"
- name: Compare if 3rdparty commits are different
if: ${{ env.server_ref != '' }}
run: |
echo '3rdparty/ seems to not point to the last commit of the dedicated branch:'
echo 'Branch has: ${{ steps.actual.outputs.commit }}'
echo '${{ env.server_ref }} has: ${{ steps.target.outputs.commit }}'
- name: Fail if 3rdparty commits are different
if: ${{ env.server_ref != '' && steps.changes.outputs.src != 'false' && steps.actual.outputs.commit != steps.target.outputs.commit }}
run: |
exit 1
@@ -1,36 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Block unconventional commits
on:
pull_request:
types: [opened, ready_for_review, reopened, synchronize]
permissions:
contents: read
concurrency:
group: block-unconventional-commits-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
block-unconventional-commits:
name: Block unconventional commits
runs-on: ubuntu-latest-low
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
- uses: webiny/action-conventional-commits@faccb24fc2550dd15c0390d944379d2d8ed9690e # v1.3.1
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-45
View File
@@ -1,45 +0,0 @@
# SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
name: Auto-label bug reports
on:
issues:
types: [opened]
jobs:
add-version-label:
if: contains(github.event.issue.title, '[Bug]')
runs-on: ubuntu-latest
permissions:
issues: write
steps:
- name: Extract version number and apply label
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
script: |
const body = context.payload.issue.body || '';
const normalizedBody = body.replace(/\r\n?/g, '\n');
let label = '';
// Extract Nextcloud Server version number from a block like:
// ### Nextcloud Server version
// 32
const versionMatch = normalizedBody.match(/### Nextcloud Server version\s*\n+([0-9]{1,3})\b/);
let nextcloudVersion = null;
if (versionMatch) {
nextcloudVersion = parseInt(versionMatch[1], 10);
label = nextcloudVersion + '-feedback';
}
if (label) {
try {
await github.rest.issues.addLabels({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
labels: [label]
});
} catch (error) {
core.setFailed(`Failed to add label "${label}": ${error.message || error}`);
}
}
-49
View File
@@ -1,49 +0,0 @@
# SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
name: "CodeQL Advanced"
on:
push:
branches: [ "master", "stable*" ]
pull_request:
branches: [ "master", "stable*" ]
schedule:
- cron: '28 18 * * 1'
jobs:
analyze:
name: Analyze (${{ matrix.language }})
runs-on: ubuntu-latest
permissions:
# required for all workflows
security-events: write
# required to fetch internal or private CodeQL packs
packages: read
strategy:
fail-fast: false
matrix:
include:
- language: actions
build-mode: none
- language: javascript-typescript
build-mode: none
steps:
- name: Checkout repository
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
- name: Initialize CodeQL
uses: github/codeql-action/init@89a39a4e59826350b863aa6b6252a07ad50cf83e # v4.32.4
with:
languages: ${{ matrix.language }}
build-mode: ${{ matrix.build-mode }}
config-file: ./.github/codeql-config.yml
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@89a39a4e59826350b863aa6b6252a07ad50cf83e # v4.32.4
with:
category: "/language:${{matrix.language}}"
-222
View File
@@ -1,222 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Compile Command
on:
issue_comment:
types: [created]
permissions:
contents: read
jobs:
init:
runs-on: ubuntu-latest
# On pull requests and if the comment starts with `/compile`
if: github.event.issue.pull_request != '' && startsWith(github.event.comment.body, '/compile')
outputs:
git_path: ${{ steps.git-path.outputs.path }}
arg1: ${{ steps.command.outputs.arg1 }}
arg2: ${{ steps.command.outputs.arg2 }}
head_ref: ${{ steps.comment-branch.outputs.head_ref }}
base_ref: ${{ steps.comment-branch.outputs.base_ref }}
steps:
- name: Get repository from pull request comment
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
id: get-repository
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
const pull = await github.rest.pulls.get({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.issue.number
});
const repositoryName = pull.data.head?.repo?.full_name
console.log(repositoryName)
return repositoryName
- name: Disabled on forks
if: ${{ fromJSON(steps.get-repository.outputs.result) != github.repository }}
run: |
echo 'Can not execute /compile on forks'
exit 1
- name: Check actor permission
uses: skjnldsv/check-actor-permission@69e92a3c4711150929bca9fcf34448c5bf5526e7 # v2
with:
require: write
- name: Add reaction on start
uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v5.0.0
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
repository: ${{ github.event.repository.full_name }}
comment-id: ${{ github.event.comment.id }}
reactions: '+1'
- name: Parse command
uses: skjnldsv/parse-command-comment@5c955203c52424151e6d0e58fb9de8a9f6a605a1 # v2
id: command
# Init path depending on which command is run
- name: Init path
id: git-path
run: |
if ${{ startsWith(steps.command.outputs.arg1, '/') }}; then
echo "path=${{steps.command.outputs.arg1}}" >> $GITHUB_OUTPUT
else
echo "path=${{steps.command.outputs.arg2}}" >> $GITHUB_OUTPUT
fi
- name: Init branch
uses: xt0rted/pull-request-comment-branch@e8b8daa837e8ea7331c0003c9c316a64c6d8b0b1 # v3.0.0
id: comment-branch
- name: Add reaction on failure
uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v5.0.0
if: failure()
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
repository: ${{ github.event.repository.full_name }}
comment-id: ${{ github.event.comment.id }}
reactions: '-1'
process:
runs-on: ubuntu-latest
needs: init
steps:
- name: Restore cached git repository
uses: buildjet/cache@3e70d19e31d6a8030aeddf6ed8dbe601f94d09f4 # v4.0.2
with:
path: .git
key: git-repo
- name: Checkout ${{ needs.init.outputs.head_ref }}
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
# Needed to allow force push later
persist-credentials: true
token: ${{ secrets.COMMAND_BOT_PAT }}
fetch-depth: 0
ref: ${{ needs.init.outputs.head_ref }}
- name: Setup git
run: |
git config --local user.email 'nextcloud-command@users.noreply.github.com'
git config --local user.name 'nextcloud-command'
- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
id: package-engines-versions
with:
fallbackNode: '^24'
fallbackNpm: '^11.3'
- name: Set up node ${{ steps.package-engines-versions.outputs.nodeVersion }}
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: ${{ steps.package-engines-versions.outputs.nodeVersion }}
cache: npm
- name: Set up npm ${{ steps.package-engines-versions.outputs.npmVersion }}
run: npm i -g 'npm@${{ steps.package-engines-versions.outputs.npmVersion }}'
- name: Rebase to ${{ needs.init.outputs.base_ref }}
if: ${{ contains(needs.init.outputs.arg1, 'rebase') }}
run: |
git fetch origin '${{ needs.init.outputs.base_ref }}:${{ needs.init.outputs.base_ref }}'
# Start the rebase
git rebase 'origin/${{ needs.init.outputs.base_ref }}' || {
# Handle rebase conflicts in a loop
while [ -d .git/rebase-merge ] || [ -d .git/rebase-apply ]; do
echo "Handling rebase conflict..."
# Remove and checkout /dist and /js folders from the base branch
if [ -d "dist" ]; then
rm -rf dist
git checkout origin/${{ needs.init.outputs.base_ref }} -- dist/ 2>/dev/null || echo "No dist folder in base branch"
fi
if [ -d "js" ]; then
rm -rf js
git checkout origin/${{ needs.init.outputs.base_ref }} -- js/ 2>/dev/null || echo "No js folder in base branch"
fi
# Stage all changes
git add .
# Check if there are any changes after resolving conflicts
if git diff --cached --quiet; then
echo "No changes after conflict resolution, skipping commit"
git rebase --skip
else
echo "Changes found, continuing rebase without editing commit message"
git -c core.editor=true rebase --continue
fi
# Break if rebase is complete
if [ ! -d .git/rebase-merge ] && [ ! -d .git/rebase-apply ]; then
break
fi
done
}
- name: Install dependencies & build
env:
CYPRESS_INSTALL_BINARY: 0
PUPPETEER_SKIP_DOWNLOAD: true
run: |
npm ci
npm run build --if-present
- name: Commit default
if: ${{ !contains(needs.init.outputs.arg1, 'fixup') && !contains(needs.init.outputs.arg1, 'amend') }}
run: |
git add '${{ github.workspace }}${{ needs.init.outputs.git_path }}'
git commit --signoff -m 'chore(assets): Recompile assets'
- name: Commit fixup
if: ${{ contains(needs.init.outputs.arg1, 'fixup') }}
run: |
git add '${{ github.workspace }}${{ needs.init.outputs.git_path }}'
git commit --fixup=HEAD --signoff
- name: Commit amend
if: ${{ contains(needs.init.outputs.arg1, 'amend') }}
run: |
git add '${{ github.workspace }}${{ needs.init.outputs.git_path }}'
git commit --amend --no-edit --signoff
# Remove any [skip ci] from the amended commit
git commit --amend -m "$(git log -1 --format='%B' | sed '/\[skip ci\]/d')"
- name: Push normally
if: ${{ !contains(needs.init.outputs.arg1, 'rebase') && !contains(needs.init.outputs.arg1, 'amend') }}
env:
HEAD_REF: ${{ needs.init.outputs.head_ref }}
run: git push origin "$HEAD_REF"
- name: Force push
if: ${{ contains(needs.init.outputs.arg1, 'rebase') || contains(needs.init.outputs.arg1, 'amend') }}
env:
HEAD_REF: ${{ needs.init.outputs.head_ref }}
run: git push --force-with-lease origin "$HEAD_REF"
- name: Add reaction on failure
uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v5.0.0
if: failure()
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
repository: ${{ github.event.repository.full_name }}
comment-id: ${{ github.event.comment.id }}
reactions: '-1'
-100
View File
@@ -1,100 +0,0 @@
# SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Update 3rdparty command
on:
issue_comment:
types: created
permissions:
contents: read
jobs:
rebase:
runs-on: ubuntu-latest
permissions:
contents: none
# On pull requests and if the comment starts with `/update-3rdparty`
if: github.event.issue.pull_request != '' && startsWith(github.event.comment.body, '/update-3rdparty')
steps:
- name: Add reaction on start
uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v3.0.1
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
repository: ${{ github.event.repository.full_name }}
comment-id: ${{ github.event.comment.id }}
reactions: '+1'
- name: Disabled on forks
if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
run: |
echo 'Can not execute /update-3rdparty on forks'
exit 1
- name: Init branch
uses: xt0rted/pull-request-comment-branch@e8b8daa837e8ea7331c0003c9c316a64c6d8b0b1 # v1
id: comment-branch
- name: Checkout ${{ steps.comment-branch.outputs.head_ref }}
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
fetch-depth: 0
token: ${{ secrets.COMMAND_BOT_PAT }}
ref: ${{ steps.comment-branch.outputs.head_ref }}
- name: Register server reference to fallback to master branch
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
const baseRef = context.payload.pull_request.base.ref
if (baseRef === 'main' || baseRef === 'master') {
core.exportVariable('server_ref', 'master');
console.log('Setting server_ref to master');
} else {
const regex = /^stable(\d+)$/
const match = baseRef.match(regex)
if (match) {
core.exportVariable('server_ref', match[0]);
console.log('Setting server_ref to ' + match[0]);
} else {
console.log('Not based on master/main/stable*, so skipping pull 3rdparty command');
}
}
- name: Setup git
run: |
git config --local user.email 'nextcloud-command@users.noreply.github.com'
git config --local user.name 'nextcloud-command'
- name: Add reaction on failure
uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v3.0.1
if: ${{ env.server_ref == '' }}
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
repository: ${{ github.event.repository.full_name }}
comment-id: ${{ github.event.comment.id }}
reactions: '-1'
- name: Pull 3rdparty
if: ${{ env.server_ref != '' }}
run: git submodule foreach 'if [ "$sm_path" == "3rdparty" ]; then git pull origin '"'"'${{ env.server_ref }}'"'"'; fi'
- name: Commit and push changes
if: ${{ env.server_ref != '' }}
run: |
git add 3rdparty
git commit -s -m 'Update submodule 3rdparty to latest ${{ env.server_ref }}'
git push
- name: Add reaction on failure
uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v3.0.1
if: failure()
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
repository: ${{ github.event.repository.full_name }}
comment-id: ${{ github.event.comment.id }}
reactions: '-1'
-237
View File
@@ -1,237 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Cypress
on: pull_request
concurrency:
group: cypress-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
env:
# Adjust APP_NAME if your repository name is different
APP_NAME: ${{ github.event.repository.name }}
# This represents the server branch to checkout.
# Usually it's the base branch of the PR, but for pushes it's the branch itself.
# e.g. 'main', 'stable27' or 'feature/my-feature'
# n.b. server will use head_ref, as we want to test the PR branch.
BRANCH: ${{ github.base_ref || github.ref_name }}
permissions:
contents: read
jobs:
init:
runs-on: ubuntu-latest
outputs:
nodeVersion: ${{ steps.versions.outputs.nodeVersion }}
npmVersion: ${{ steps.versions.outputs.npmVersion }}
env:
# We'll install cypress in the cypress job
CYPRESS_INSTALL_BINARY: 0
PUPPETEER_SKIP_DOWNLOAD: true
steps:
- name: Disabled on forks
if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
run: |
echo 'Can not run cypress on forks'
exit 1
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
# We need to checkout submodules for 3rdparty
submodules: true
- name: Check composer.json
id: check_composer
uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v3.0.0
with:
files: 'composer.json'
- name: Install composer dependencies
if: steps.check_composer.outputs.files_exists == 'true'
run: composer install --no-dev
- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
id: versions
with:
fallbackNode: '^24'
fallbackNpm: '^11.3'
- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: ${{ steps.versions.outputs.nodeVersion }}
- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
- name: Install node dependencies & build app
run: |
npm ci
TESTING=true npm run build --if-present
- name: Save context
uses: buildjet/cache/save@3e70d19e31d6a8030aeddf6ed8dbe601f94d09f4 # v4.0.2
with:
key: cypress-context-${{ github.run_id }}
path: ./
cypress:
runs-on: ubuntu-latest
needs: init
strategy:
fail-fast: false
matrix:
# Run multiple copies of the current job in parallel
# Please increase the number or runners as your tests suite grows (0 based index for e2e tests)
containers: ['setup', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9']
# Hack as strategy.job-total includes the "setup" and GitHub does not allow math expressions
# Always align this number with the total of e2e runners (max. index + 1)
total-containers: [10]
services:
mysql:
# Only start mysql if we are running the setup tests
image: ${{matrix.containers == 'setup' && 'ghcr.io/nextcloud/continuous-integration-mysql-8.4:latest' || ''}} # zizmor: ignore[unpinned-images]
ports:
- '3306/tcp'
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: oc_autotest
options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 10
mariadb:
# Only start mariadb if we are running the setup tests
image: ${{matrix.containers == 'setup' && 'mariadb:11.4' || ''}} # zizmor: ignore[unpinned-images]
ports:
- '3306/tcp'
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: oc_autotest
options: --health-cmd="mariadb-admin ping" --health-interval 5s --health-timeout 2s --health-retries 5
postgres:
# Only start postgres if we are running the setup tests
image: ${{matrix.containers == 'setup' && 'ghcr.io/nextcloud/continuous-integration-postgres-17:latest' || ''}} # zizmor: ignore[unpinned-images]
ports:
- '5432/tcp'
env:
POSTGRES_USER: root
POSTGRES_PASSWORD: rootpassword
POSTGRES_DB: nextcloud
options: --mount type=tmpfs,destination=/var/lib/postgresql/data --health-cmd pg_isready --health-interval 5s --health-timeout 2s --health-retries 5
oracle:
# Only start oracle if we are running the setup tests
image: ${{matrix.containers == 'setup' && 'ghcr.io/gvenzl/oracle-free:23' || ''}} # zizmor: ignore[unpinned-images]
ports:
- '1521'
env:
ORACLE_PASSWORD: oracle
options: --health-cmd healthcheck.sh --health-interval 20s --health-timeout 10s --health-retries 10
name: runner ${{ matrix.containers }}
steps:
- name: Restore context
uses: buildjet/cache/restore@3e70d19e31d6a8030aeddf6ed8dbe601f94d09f4 # v4.0.2
with:
fail-on-cache-miss: true
key: cypress-context-${{ github.run_id }}
path: ./
- name: Set up node ${{ needs.init.outputs.nodeVersion }}
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: ${{ needs.init.outputs.nodeVersion }}
- name: Set up npm ${{ needs.init.outputs.npmVersion }}
run: npm i -g 'npm@${{ needs.init.outputs.npmVersion }}'
- name: Install cypress
run: ./node_modules/cypress/bin/cypress install
- name: Run ${{ matrix.containers == 'component' && 'component' || 'E2E' }} cypress tests
uses: cypress-io/github-action@bc22e01685c56e89e7813fd8e26f33dc47f87e15 # v7.1.5
with:
# We already installed the dependencies in the init job
install: false
component: ${{ matrix.containers == 'component' }}
group: ${{ matrix.use-cypress-cloud && matrix.containers == 'component' && 'Run component' || matrix.use-cypress-cloud && 'Run E2E' || '' }}
# cypress env
ci-build-id: ${{ matrix.use-cypress-cloud && format('{0}-{1}', github.sha, github.run_number) || '' }}
tag: ${{ matrix.use-cypress-cloud && github.event_name || '' }}
env:
# Needs to be prefixed with CYPRESS_
CYPRESS_BRANCH: ${{ env.BRANCH }}
# https://github.com/cypress-io/github-action/issues/124
COMMIT_INFO_MESSAGE: ${{ github.event.pull_request.title }}
# Needed for some specific code workarounds
TESTING: true
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
SPLIT: ${{ matrix.total-containers }}
SPLIT_INDEX: ${{ matrix.containers == 'component' && 0 || matrix.containers }}
SPLIT_RANDOM_SEED: ${{ github.run_id }}
SETUP_TESTING: ${{ matrix.containers == 'setup' && 'true' || '' }}
- name: Upload snapshots and videos
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
if: always()
with:
name: snapshots_${{ matrix.containers }}
path: |
cypress/snapshots
cypress/videos
- name: Show logs
if: failure() && matrix.containers != 'component'
run: |
for id in $(docker ps -aq); do
docker container inspect "$id" --format '=== Logs for container {{.Name}} ==='
docker logs "$id" >> nextcloud.log
done
echo '=== Nextcloud server logs ==='
docker exec nextcloud-e2e-test-server_${{ env.APP_NAME }} cat data/nextcloud.log
- name: Create data dir archive
if: failure() && matrix.containers != 'component'
run: docker exec nextcloud-e2e-test-server_${{ env.APP_NAME }} tar -cvjf - data > data.tar
- name: Upload data archive
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
if: failure() && matrix.containers != 'component'
with:
name: nc_data_${{ matrix.containers }}
path: data.tar
summary:
runs-on: ubuntu-latest-low
needs: [init, cypress]
if: always()
name: cypress-summary
steps:
- name: Summary status
run: if ${{ needs.init.result != 'success' || ( needs.cypress.result != 'success' && needs.cypress.result != 'skipped' ) }}; then exit 1; fi
+12 -41
View File
@@ -2,57 +2,28 @@
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Auto approve Dependabot PRs
name: Dependabot
on:
pull_request_target: # zizmor: ignore[dangerous-triggers]
pull_request_target:
branches:
- main
- master
- stable*
permissions:
contents: read
concurrency:
group: dependabot-approve-merge-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
auto-approve-merge:
if: github.event.pull_request.user.login == 'dependabot[bot]' || github.event.pull_request.user.login == 'renovate[bot]'
runs-on: ubuntu-latest-low
permissions:
# for hmarr/auto-approve-action to approve PRs
pull-requests: write
# for alexwilson/enable-github-automerge-action to approve PRs
contents: write
auto-merge:
runs-on: ubuntu-latest
steps:
- name: Disabled on forks
if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
run: |
echo 'Can not approve PRs from forks'
exit 1
- uses: mdecoleman/pr-branch-name@55795d86b4566d300d237883103f052125cc7508 # v3.0.0
id: branchname
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
# GitHub actions bot approve
- uses: hmarr/auto-approve-action@f0939ea97e9205ef24d872e76833fa908a770363 # v4.0.0
if: startsWith(steps.branchname.outputs.branch, 'dependabot/')
# Default github action approve
- uses: hmarr/auto-approve-action@v2
if: github.actor == 'dependabot[bot]'
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
# Enable GitHub auto merge
- name: Auto merge
uses: alexwilson/enable-github-automerge-action@56e3117d1ae1540309dc8f7a9f2825bc3c5f06ff # v2.0.0
if: startsWith(steps.branchname.outputs.branch, 'dependabot/')
# Nextcloud bot approve and merge request
- uses: ahmadnassri/action-dependabot-auto-merge@v2
if: github.actor == 'dependabot[bot]'
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
target: minor
github-token: ${{ secrets.DEPENDABOT_AUTOMERGE_TOKEN }}
-142
View File
@@ -1,142 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit files_external FTP
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: files-external-ftp-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- 'apps/files/lib/**'
- 'apps/files/tests/**'
- 'apps/files_external/**'
- 'apps/files_sharing/lib/**'
- 'apps/files_sharing/tests/**'
- 'apps/files_trashbin/lib/**'
- 'apps/files_trashbin/tests/**'
- 'apps/files_versions/lib/**'
- 'apps/files_versions/tests/**'
- 'lib/private/Files/**'
- 'lib/public/Files/**'
- 'tests/lib/Files/**'
files-external-ftp:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.2', '8.4']
ftpd: ['proftpd', 'vsftpd', 'pure-ftpd']
include:
- php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-${{ matrix.ftpd }}
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up ftpd
run: |
sudo mkdir /tmp/ftp
sudo chmod -R 0777 /tmp/ftp
if [[ "${{ matrix.ftpd }}" == 'proftpd' ]]; then echo '$6$Q7V2n3q2GRVv5YeQ$/AhLu07H76Asojy7bxGXMY1caKLAbp5Vt82LOZYMkD/8uDzyMAEXwk0c1Bdz1DkBsk2Vh/9SF130mOPavRGMo.' > /tmp/secret.txt; fi
if [[ "${{ matrix.ftpd }}" == 'proftpd' ]]; then echo 'FTP_ROOT=/home/test' > $GITHUB_ENV; fi
if [[ "${{ matrix.ftpd }}" == 'proftpd' ]]; then docker run --name ftp -d --net host -e PASV_ADDRESS=127.0.0.1 -e FTPUSER_NAME=test -v /tmp/secret.txt:/run/secrets/ftp-user-password-secret -v /tmp/ftp:/home/test instantlinux/proftpd; fi
if [[ "${{ matrix.ftpd }}" == 'vsftpd' ]]; then docker run --name ftp -d --net host -e FTP_USER=test -e FTP_PASS=test -e PASV_ADDRESS=127.0.0.1 -v /tmp/ftp:/home/vsftpd/test fauria/vsftpd; fi
if [[ "${{ matrix.ftpd }}" == 'pure-ftpd' ]]; then docker run --name ftp -d --net host -e "PUBLICHOST=localhost" -e FTP_USER_NAME=test -e FTP_USER_PASS=test -e FTP_USER_HOME=/home/test -v /tmp/ftp:/home/test -v /tmp/ftp:/etc/pure-ftpd/passwd stilliard/pure-ftpd; fi
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
run: |
composer install
mkdir data
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ app:enable --force files_external
echo "<?php return ['run' => true,'host' => 'localhost','user' => 'test','password' => 'test', 'root' => '${{ env.FTP_ROOT }}'];" > apps/files_external/tests/config.ftp.php
- name: smoketest ftp
run: |
php -r 'var_dump(file_put_contents("ftp://test:test@localhost${{ env.FTP_ROOT }}/ftp.txt", "asd"));'
php -r 'var_dump(file_get_contents("ftp://test:test@localhost${{ env.FTP_ROOT }}/ftp.txt"));'
php -r 'var_dump(mkdir("ftp://test:test@localhost${{ env.FTP_ROOT }}/asdads"));'
ls -l /tmp/ftp
[ -f /tmp/ftp/ftp.txt ]
- name: PHPUnit
run: composer run test:files_external -- \
apps/files_external/tests/Storage/FtpTest.php \
--log-junit junit.xml \
${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.xml
flags: phpunit-files-external-ftp
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-files-external-ftp
- name: ftpd logs
if: always()
run: |
docker logs ftp
ftp-summary:
runs-on: ubuntu-latest-low
needs: [changes, files-external-ftp]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.files-external-ftp.result != 'success' }}; then exit 1; fi
-225
View File
@@ -1,225 +0,0 @@
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit files_external S3
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: files-external-s3-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- 'apps/files/lib/**'
- 'apps/files/tests/**'
- 'apps/files_external/**'
- 'apps/files_sharing/lib/**'
- 'apps/files_sharing/tests/**'
- 'apps/files_trashbin/lib/**'
- 'apps/files_trashbin/tests/**'
- 'apps/files_versions/lib/**'
- 'apps/files_versions/tests/**'
- 'lib/private/Files/**'
- 'lib/public/Files/**'
- 'tests/lib/Files/**'
files-external-s3-minio:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.2', '8.4']
include:
- php-versions: '8.3'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-s3-minio
services:
minio:
image: bitnami/minio@sha256:50cec18ac4184af4671a78aedd5554942c8ae105d51a465fa82037949046da01 # v2025.4.22
env:
MINIO_ROOT_USER: nextcloud
MINIO_ROOT_PASSWORD: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
MINIO_DEFAULT_BUCKETS: nextcloud
ports:
- '9000:9000'
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
env:
OBJECT_STORE_KEY: nextcloud
OBJECT_STORE_SECRET: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
run: |
composer install
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ app:enable --force files_external
echo "<?php return ['run' => true, 'minio' => true, 'secret' => 'actually-not-secret', 'passwordsalt' => 'actually-not-secret', 'hostname' => 'localhost','key' => '$OBJECT_STORE_KEY','secret' => '$OBJECT_STORE_SECRET', 'bucket' => 'bucket', 'port' => 9000, 'use_ssl' => false, 'autocreate' => true, 'use_path_style' => true];" > apps/files_external/tests/config.amazons3.php
- name: Wait for S3
run: |
curl -f -m 1 --retry-connrefused --retry 10 --retry-delay 10 http://localhost:9000/minio/health/ready
- name: PHPUnit
run: |
composer run test:files_external -- \
--group S3 \
--log-junit junit.xml \
apps/files_external/tests/Storage \
${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.xml
flags: phpunit-files-external-s3
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-files-external-s3
- name: Nextcloud logs
if: always()
run: |
cat data/nextcloud.log
- name: S3 logs
if: always()
run: |
docker ps -a
docker ps -aq | while read container ; do IMAGE=$(docker inspect --format='{{.Config.Image}}' $container); echo $IMAGE; docker logs $container; echo "\n\n" ; done
files-external-s3-localstack:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
matrix:
php-versions: ['8.2', '8.4']
include:
- php-versions: '8.3'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-s3-localstack
services:
localstack:
env:
SERVICES: s3
DEBUG: 1
image: localstack/localstack@sha256:9d4253786e0effe974d77fe3c390358391a56090a4fff83b4600d8a64404d95d # v4.5.0
ports:
- "4566:4566"
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
run: |
composer install
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ app:enable --force files_external
echo "<?php return ['run' => true, 'localstack' => true, 'hostname' => 'localhost','key' => 'ignored','secret' => 'ignored', 'bucket' => 'bucket', 'port' => 4566, 'use_ssl' => false, 'autocreate' => true, 'use_path_style' => true];" > apps/files_external/tests/config.amazons3.php
- name: PHPUnit
run: |
composer run test:files_external -- \
--group S3 \
--log-junit junit.xml \
apps/files_external/tests/Storage \
${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.xml
flags: phpunit-files-external-s3
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-files-external-s3
- name: S3 logs
if: always()
run: |
docker ps -a
docker ps -aq | while read container ; do IMAGE=$(docker inspect --format='{{.Config.Image}}' $container); echo $IMAGE; docker logs $container; echo "\n\n" ; done
s3-external-summary:
runs-on: ubuntu-latest-low
needs: [changes, files-external-s3-minio, files-external-s3-localstack]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && (needs.files-external-s3-minio.result != 'success' || needs.files-external-s3-localstack.result != 'success') }}; then exit 1; fi
-132
View File
@@ -1,132 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit files_external sFTP
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: files-external-sftp-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- 'apps/files/lib/**'
- 'apps/files/tests/**'
- 'apps/files_external/**'
- 'apps/files_sharing/lib/**'
- 'apps/files_sharing/tests/**'
- 'apps/files_trashbin/lib/**'
- 'apps/files_trashbin/tests/**'
- 'apps/files_versions/lib/**'
- 'apps/files_versions/tests/**'
- 'lib/private/Files/**'
- 'lib/public/Files/**'
- 'tests/lib/Files/**'
files-external-sftp:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.2', '8.4']
sftpd: ['openssh']
include:
- php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-${{ matrix.sftpd }}
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up sftpd
run: |
sudo mkdir /tmp/sftp
sudo chown -R 0777 /tmp/sftp
if [[ '${{ matrix.sftpd }}' == 'openssh' ]]; then docker run -p 2222:22 --name sftp -d -v /tmp/sftp:/home/test atmoz/sftp 'test:test:::data'; fi
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
run: |
composer install
mkdir data
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ app:enable --force files_external
echo "<?php return ['run' => true, 'host' => 'localhost:2222','user' => 'test','password' => 'test', 'root' => 'data'];" > apps/files_external/tests/config.sftp.php
- name: PHPUnit
run: composer run test:files_external -- \
apps/files_external/tests/Storage/SftpTest.php \
apps/files_external/tests/Storage/SFTP_KeyTest.php \
--log-junit junit.xml \
${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.xml
flags: phpunit-files-external-sftp
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-files-external-sftp
- name: sftpd logs
if: always()
run: |
ls -l /tmp/sftp
docker logs sftp
sftp-summary:
runs-on: ubuntu-latest-low
needs: [changes, files-external-sftp]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.files-external-sftp.result != 'success' }}; then exit 1; fi
@@ -1,128 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Samba Kerberos SSO
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: files-external-smb-kerberos-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- 'apps/files/lib/**'
- 'apps/files/tests/**'
- 'apps/files_external/**'
- 'apps/files_sharing/lib/**'
- 'apps/files_sharing/tests/**'
- 'apps/files_trashbin/lib/**'
- 'apps/files_trashbin/tests/**'
- 'apps/files_versions/lib/**'
- 'apps/files_versions/tests/**'
- 'lib/private/Files/**'
- 'lib/public/Files/**'
- 'tests/lib/Files/**'
files-external-smb-kerberos:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
name: smb-kerberos-sso
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Checkout user_saml
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
repository: nextcloud/user_saml
path: apps/user_saml
- name: Install user_saml
run: |
cd apps/user_saml
composer i
cd ../..
- name: Pull images
run: |
docker pull ghcr.io/icewind1991/samba-krb-test-dc
docker pull ghcr.io/icewind1991/samba-krb-test-apache-gssapi:8.4
docker pull ghcr.io/icewind1991/samba-krb-test-client
docker tag ghcr.io/icewind1991/samba-krb-test-dc icewind1991/samba-krb-test-dc
docker tag ghcr.io/icewind1991/samba-krb-test-apache-gssapi:8.4 icewind1991/samba-krb-test-apache-gssapi
docker tag ghcr.io/icewind1991/samba-krb-test-client icewind1991/samba-krb-test-client
- name: Setup AD-DC
run: |
DC_IP=$(apps/files_external/tests/sso-setup/start-dc.sh)
sleep 1
apps/files_external/tests/sso-setup/start-apache.sh $DC_IP $PWD
echo "DC_IP=$DC_IP" >> $GITHUB_ENV
- name: Set up Nextcloud
run: |
apps/files_external/tests/sso-setup/setup-sso-nc.sh
- name: Test SSO
run: |
apps/files_external/tests/sso-setup/test-sso-smb.sh ${{ env.DC_IP }}
- name: Show logs DC
if: always()
run: |
docker logs dc
echo "------------"
docker exec dc cat /var/log/samba/log.samba
- name: Show logs Apache
if: always()
run: |
docker logs apache
- name: Show logs
if: always()
run: |
FILEPATH=$(docker exec --user 33 apache ./occ log:file | grep "Log file:" | cut -d' ' -f3)
echo "$FILEPATH:"
docker exec --user 33 apache cat $FILEPATH
smb-kerberos-sso-summary:
runs-on: ubuntu-latest-low
needs: [changes, files-external-smb-kerberos]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.files-external-smb-kerberos.result != 'success' }}; then exit 1; fi
-138
View File
@@ -1,138 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit files_external SMB
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: files-external-smb-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- 'apps/files/lib/**'
- 'apps/files/tests/**'
- 'apps/files_external/**'
- 'apps/files_sharing/lib/**'
- 'apps/files_sharing/tests/**'
- 'apps/files_trashbin/lib/**'
- 'apps/files_trashbin/tests/**'
- 'apps/files_versions/lib/**'
- 'apps/files_versions/tests/**'
- 'lib/private/Files/**'
- 'lib/public/Files/**'
- 'tests/lib/Files/**'
files-external-smb:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
include:
- php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-smb
services:
samba:
image: ghcr.io/servercontainers/samba:smbd-only-a3.18.0-s4.18.2-r0
env:
ACCOUNT_test: test
UID_test: 1000
SAMBA_VOLUME_CONFIG_test: "[public]; path=/tmp; valid users = test; guest ok = no; read only = no; browseable = yes"
options: >-
--health-cmd=true
ports:
- 445:445
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, smbclient, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up smbclient
# This is needed as icewind/smb php library for notify
run: sudo apt-get install -y smbclient
- name: Set up Nextcloud
run: |
composer install
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ config:system:set --value true --type boolean allow_local_remote_servers
./occ app:enable --force files_external
echo "<?php return ['run'=>true, 'host'=>'localhost', 'user'=>'test', 'password'=>'test', 'root'=>'', 'share'=>'public'];" > apps/files_external/tests/config.smb.php
- name: Wait for smb
run: |
apps/files_external/tests/env/wait-for-connection 127.0.0.1 445 60
- name: PHPUnit
run: composer run test:files_external -- \
apps/files_external/tests/Storage/SmbTest.php \
--log-junit junit.xml \
${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.xml
flags: phpunit-files-external-smb
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-files-external-smb
files-external-smb-summary:
runs-on: ubuntu-latest-low
needs: [changes, files-external-smb]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.files-external-smb.result != 'success' }}; then exit 1; fi
-130
View File
@@ -1,130 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit files_external WebDAV
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: files-external-webdav-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- 'apps/files/lib/**'
- 'apps/files/tests/**'
- 'apps/files_external/**'
- 'apps/files_sharing/lib/**'
- 'apps/files_sharing/tests/**'
- 'apps/files_trashbin/lib/**'
- 'apps/files_trashbin/tests/**'
- 'apps/files_versions/lib/**'
- 'apps/files_versions/tests/**'
- 'lib/private/Files/**'
- 'lib/public/Files/**'
- 'tests/lib/Files/**'
files-external-webdav-apache:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.3', '8.4']
include:
- php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-webdav
services:
apache:
image: ghcr.io/nextcloud/continuous-integration-webdav-apache:latest # zizmor: ignore[unpinned-images]
ports:
- 8081:80
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
run: |
composer install
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ config:system:set --value true --type boolean allow_local_remote_servers
./occ app:enable --force files_external
echo "<?php return ['run' => true, 'host' => 'localhost:8081/webdav/', 'user' => 'test', 'password'=>'pass', 'root' => '', 'wait' => 0];" > apps/files_external/tests/config.webdav.php
- name: Wait for WebDAV
run: |
sleep 5
curl -f -m 1 --retry-connrefused --retry 10 --retry-delay 10 http://test:pass@localhost:8081/webdav/
- name: PHPUnit
run: composer run test:files_external -- \
apps/files_external/tests/Storage/WebdavTest.php \
--log-junit junit.xml \
${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.xml
flags: phpunit-files-external-webdav
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-files-external-webdav
files-external-webdav-summary:
runs-on: ubuntu-latest-low
needs: [changes, files-external-webdav-apache]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.files-external-webdav-apache.result != 'success' }}; then exit 1; fi
-119
View File
@@ -1,119 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit files_external generic
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: files-external-generic-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- 'apps/files/lib/**'
- 'apps/files/tests/**'
- 'apps/files_external/**'
- 'apps/files_sharing/lib/**'
- 'apps/files_sharing/tests/**'
- 'apps/files_trashbin/lib/**'
- 'apps/files_trashbin/tests/**'
- 'apps/files_versions/lib/**'
- 'apps/files_versions/tests/**'
- 'lib/private/Files/**'
- 'lib/public/Files/**'
- 'tests/lib/Files/**'
files-external-generic:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.3', '8.4']
include:
- php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-generic
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
env:
OBJECT_STORE_KEY: nextcloud
OBJECT_STORE_SECRET: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
run: |
composer install
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ app:enable --force files_external
- name: PHPUnit
run: composer run test:files_external -- \
--log-junit junit.xml \
${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.xml
flags: phpunit-files-external-generic
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-files-external-generic
files-external-summary:
runs-on: ubuntu-latest-low
needs: [changes, files-external-generic ]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.files-external-generic.result != 'success' }}; then exit 1; fi
+4 -20
View File
@@ -2,35 +2,19 @@
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Block fixup and squash commits
name: Pull request checks
on:
pull_request:
types: [opened, ready_for_review, reopened, synchronize]
permissions:
contents: read
concurrency:
group: fixup-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
on: pull_request
jobs:
commit-message-check:
if: github.event.pull_request.draft == false
permissions:
pull-requests: write
name: Block fixup and squash commits
runs-on: ubuntu-latest-low
runs-on: ubuntu-latest
steps:
- name: Run check
uses: skjnldsv/block-fixup-merge-action@c138ea99e45e186567b64cf065ce90f7158c236a # v2
uses: xt0rted/block-autosquash-commits-action@v2
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
@@ -1,104 +0,0 @@
# SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Generate changelog on release
on:
release:
types: [published]
permissions:
contents: write
jobs:
changelog_generate:
runs-on: ubuntu-latest
# Only allowed to be run on nextcloud-releases repositories
if: ${{ github.repository_owner == 'nextcloud-releases' }}
steps:
- name: Check actor permission
uses: skjnldsv/check-actor-permission@69e92a3c4711150929bca9fcf34448c5bf5526e7 # v3.0
with:
require: write
- name: Checkout github_helper
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
repository: nextcloud/github_helper
path: github_helper
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
path: server
fetch-depth: 0
- name: Get previous tag
shell: bash
run: |
cd server
# Print all tags
git log --decorate --oneline | egrep 'tag: ' | sed -r 's/^.+tag: ([^,\)]+)[,\)].+$/\1/g'
# Get the current tag
TAGS=$(git log --decorate --oneline | egrep 'tag: ' | sed -r 's/^.+tag: ([^,\)]+)[,\)].+$/\1/g')
CURRENT_TAG=$(echo "$TAGS" | head -n 1)
# If current tag is the first beta, we use the previous major RC1
if echo "$CURRENT_TAG" | grep -q 'beta1'; then
MAJOR=$(echo "$CURRENT_TAG" | sed -E 's/^v([0-9]+).*/\1/')
PREV=$((MAJOR - 1))
PREVIOUS_TAG="v${PREV}.0.0rc1"
# Get the previous tag - filter pre-releases only if current tag is stable
elif echo "$CURRENT_TAG" | grep -q 'rc\|beta\|alpha'; then
# Current tag is pre-release, don't filter
PREVIOUS_TAG=$(echo "$TAGS" | sed -n '2p')
else
# Current tag is stable, filter out pre-releases
PREVIOUS_TAG=$(echo "$TAGS" | grep -v 'rc\|beta\|alpha' | sed -n '2p')
fi
echo "CURRENT_TAG=$CURRENT_TAG" >> $GITHUB_ENV
echo "PREVIOUS_TAG=$PREVIOUS_TAG" >> $GITHUB_ENV
# Since this action only runs on nextcloud-releases, ignoring is okay
- name: Verify current tag # zizmor: ignore[template-injection]
run: |
if [ "${{ github.ref_name }}" != "${{ env.CURRENT_TAG }}" ]; then
echo "Current tag does not match the release tag. Exiting."
exit 1
fi
- name: Set up php 8.2
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
timeout-minutes: 5
with:
php-version: 8.2
coverage: none
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set credentials
run: |
echo '{"username": "github-actions"}' > github_helper/credentials.json
# Since this action only runs on nextcloud-releases, ignoring is okay
- name: Generate changelog between ${{ env.PREVIOUS_TAG }} and ${{ github.ref_name }} # zizmor: ignore[template-injection]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
cd github_helper/changelog
composer install
php index.php generate:changelog --no-bots --format=forum server ${{ env.PREVIOUS_TAG }} ${{ github.ref_name }} > changelog.md
# Since this action only runs on nextcloud-releases, ignoring is okay
- name: Set changelog to release # zizmor: ignore[template-injection]
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
cd server
gh release edit ${{ github.ref_name }} --notes-file "../github_helper/changelog/changelog.md" --title "${{ github.ref_name }}"
-129
View File
@@ -1,129 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: DAV integration tests
on:
pull_request:
permissions:
contents: read
concurrency:
group: integration-caldav-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/*.php'
- '**/lib/**'
- '**/tests/**'
- '**/vendor-bin/**'
- 'build/integration/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
integration-caldav:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false' && github.repository_owner != 'nextcloud-gmbh'
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
endpoint: ['old', 'new']
service: ['CalDAV', 'CardDAV']
name: ${{ matrix.service }} (${{ matrix.endpoint }} endpoint) php${{ matrix.php-versions }}
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: 'none'
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Python
uses: LizardByte/actions/actions/setup_python@70bb8d394d1c92f6113aeec6ae9cc959a5763d15 # v2026.227.200013
with:
python-version: '2.7'
- name: Set up CalDAVTester
run: |
git clone --depth=1 https://github.com/apple/ccs-caldavtester.git CalDAVTester
git clone --depth=1 https://github.com/apple/ccs-pycalendar.git pycalendar
- name: Set up Nextcloud
run: |
mkdir data
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
# disable the trashbin, so recurrent deletion of the same object works
./occ config:app:set dav calendarRetentionObligation --value=0
# Prepare users
OC_PASS=user01 ./occ user:add --password-from-env user01
OC_PASS=user02 ./occ user:add --password-from-env user02
# Prepare calendars
./occ dav:create-calendar user01 calendar
./occ dav:create-calendar user01 shared
./occ dav:create-calendar user02 calendar
# Prepare address books
./occ dav:create-addressbook user01 addressbook
./occ dav:create-addressbook user02 addressbook
- name: Run Nextcloud
run: |
php -S localhost:8888 &
- name: Run CalDAVTester
run: |
cp "apps/dav/tests/testsuits/caldavtest/serverinfo-${{ matrix.endpoint }}${{ matrix.endpoint == 'old' && (matrix.service == 'CardDAV' && '-carddav' || '-caldav') || '' }}-endpoint.xml" "apps/dav/tests/testsuits/caldavtest/serverinfo.xml"
pushd CalDAVTester
PYTHONPATH="../pycalendar/src" python testcaldav.py --print-details-onfail --basedir "../apps/dav/tests/testsuits/caldavtest" -o cdt.txt \
"${{ matrix.service }}/current-user-principal.xml" \
"${{ matrix.service }}/sync-report.xml" \
${{ matrix.endpoint == 'new' && format('{0}/sharing-{1}.xml', matrix.service, matrix.service == 'CalDAV' && 'calendars' || 'addressbooks') || ';' }}
popd
- name: Print Nextcloud logs
if: always()
run: |
cat data/nextcloud.log
caldav-integration-summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, integration-caldav]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.integration-caldav.result != 'success' }}; then exit 1; fi
-116
View File
@@ -1,116 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Litmus integration tests
on:
pull_request:
permissions:
contents: read
concurrency:
group: integration-litmus-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/*.php'
- '**/lib/**'
- '**/tests/**'
- '**/vendor-bin/**'
- 'build/integration/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
integration-litmus:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false' && github.repository_owner != 'nextcloud-gmbh'
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
endpoint: ['webdav', 'dav']
name: Litmus WebDAV ${{ matrix.endpoint }}
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: 'none'
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
run: |
mkdir data
./occ maintenance:install \
--verbose \
--database=sqlite \
--database-name=nextcloud \
--database-user=root \
--database-pass=rootpassword \
--admin-user admin \
--admin-pass admin
./occ config:system:set trusted_domains 2 --value=host.docker.internal:8080
- name: Run Nextcloud
run: |
php -S 0.0.0.0:8080 &
- name: Run Litmus test
run: |
docker run \
--rm \
--add-host=host.docker.internal:host-gateway \
ghcr.io/nextcloud/continuous-integration-litmus-php8.3:latest \
bash -c '\
cd /tmp/litmus/litmus-0.13;
make URL=http://host.docker.internal:8080/remote.php/${{ matrix.endpoint }}${{ matrix.endpoint == 'dav' && '/files/admin' || ''}} CREDS="admin admin" TESTS="basic copymove props largefile" check;
status=$?;
cat debug.log;
exit $status;'
- name: Print Nextcloud logs
if: always()
run: cat data/nextcloud.log
integration-litmus-summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, integration-litmus]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.integration-litmus.result != 'success' }}; then exit 1; fi
@@ -1,133 +0,0 @@
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: S3 primary storage integration tests
on:
pull_request:
permissions:
contents: read
concurrency:
group: integration-s3-primary-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- 'build/integration/**'
- 'apps/files/lib/**'
- 'apps/files/tests/**'
- 'apps/files_external/**'
- 'apps/files_sharing/lib/**'
- 'apps/files_sharing/tests/**'
- 'apps/files_trashbin/lib/**'
- 'apps/files_trashbin/tests/**'
- 'apps/files_versions/lib/**'
- 'apps/files_versions/tests/**'
- 'lib/private/Files/**'
- 'lib/public/Files/**'
- 'tests/lib/Files/**'
integration-s3-primary:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false' && github.repository_owner != 'nextcloud-gmbh'
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
key: ['objectstore', 'objectstore_multibucket']
name: php${{ matrix.php-versions }}-${{ matrix.key }}-minio
services:
redis:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
ports:
- 6379:6379/tcp
minio:
image: bitnami/minio@sha256:50cec18ac4184af4671a78aedd5554942c8ae105d51a465fa82037949046da01 # v2025.4.22
env:
MINIO_ROOT_USER: nextcloud
MINIO_ROOT_PASSWORD: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
MINIO_DEFAULT_BUCKETS: nextcloud
ports:
- "9000:9000"
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: 'none'
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Wait for S3
run: |
sleep 10
curl -f -m 1 --retry-connrefused --retry 10 --retry-delay 10 http://localhost:9000/minio/health/ready
- name: Set up Nextcloud
run: |
composer install
mkdir data
echo '<?php $CONFIG=["${{ matrix.key }}" => ["class" => "OC\Files\ObjectStore\S3", "arguments" => ["bucket" => "nextcloud", "autocreate" => true, "key" => "nextcloud", "secret" => "bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=", "hostname" => "localhost", "port" => 9000, "use_ssl" => false, "use_path_style" => true, "uploadPartSize" => 52428800]]];' > config/config.php
echo '<?php $CONFIG=["redis" => ["host" => "localhost", "port" => 6379], "memcache.local" => "\OC\Memcache\Redis", "memcache.distributed" => "\OC\Memcache\Redis"];' > config/redis.config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f index.php
- name: Integration
run: |
cd build/integration
bash run.sh --tags "~@failure-s3" dav_features/webdav-related.feature
- name: S3 logs
if: always()
run: |
cat data/nextcloud.log
docker ps -a
docker ps -aq | while read container ; do IMAGE=$(docker inspect --format='{{.Config.Image}}' $container); echo $IMAGE; docker logs $container; echo "\n\n" ; done
s3-primary-integration-summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, integration-s3-primary]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.integration-s3-primary.result != 'success' }}; then exit 1; fi
-184
View File
@@ -1,184 +0,0 @@
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Integration sqlite
on:
pull_request:
push:
branches:
- main
- master
- stable*
permissions:
contents: read
concurrency:
group: integration-sqlite-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/*.php'
- '**/lib/**'
- '**/tests/**'
- '**/vendor-bin/**'
- 'build/integration/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- 'core/shipped.json'
integration-sqlite:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
fail-fast: false
matrix:
test-suite:
- 'capabilities_features'
- 'collaboration_features'
- 'comments_features'
- 'dav_features'
- 'features'
- 'federation_features'
- '--tags ~@large files_features'
- 'filesdrop_features'
- 'file_conversions'
- 'files_reminders'
- 'openldap_features'
- 'openldap_numerical_features'
- 'ldap_features'
- 'remoteapi_features'
- 'routing_features'
- 'setup_features'
- 'sharees_features'
- 'sharing_features'
- 'theming_features'
- 'videoverification_features'
php-versions: ['8.4']
spreed-versions: ['main']
activity-versions: ['master']
services:
redis:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
ports:
- 6379:6379/tcp
openldap:
image: ghcr.io/nextcloud/continuous-integration-openldap:openldap-8 # zizmor: ignore[unpinned-images]
ports:
- 389:389
- 636:636
env:
SLAPD_DOMAIN: nextcloud.ci
SLAPD_ORGANIZATION: Nextcloud
SLAPD_PASSWORD: admin
SLAPD_ADDITIONAL_MODULES: memberof
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Checkout Talk app
if: ${{ matrix.test-suite == 'videoverification_features' }}
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
repository: nextcloud/spreed
path: apps/spreed
ref: ${{ matrix.spreed-versions }}
- name: Checkout Activity app
if: ${{ matrix.test-suite == 'sharing_features' }}
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
repository: nextcloud/activity
path: apps/activity
ref: ${{ matrix.activity-versions }}
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, imagick, intl, json, ldap, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: none
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: |
composer install
- name: Set up Talk dependencies
if: ${{ matrix.test-suite == 'videoverification_features' }}
working-directory: apps/spreed
run: composer i --no-dev
- name: Set up Nextcloud
run: |
mkdir data
./occ maintenance:install --verbose ${{ contains(matrix.test-suite,'ldap') && '--data-dir=/dev/shm/nc_int' || '' }} --database=sqlite --database-name=nextcloud --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
./occ config:system:set hashing_default_password --value=true --type=boolean
- name: Configure caching
if: ${{ contains(matrix.test-suite,'ldap') }}
run: |
./occ config:system:set redis host --value=localhost
./occ config:system:set redis port --value=6379 --type=integer
./occ config:system:set redis timeout --value=0 --type=integer
./occ config:system:set memcache.local --value='\OC\Memcache\Redis'
./occ config:system:set memcache.distributed --value='\OC\Memcache\Redis'
- name: Run integration
working-directory: build/integration
env:
LDAP_HOST: localhost
run: bash run.sh ${{ matrix.test-suite }} no-tail-log
- name: Print logs
if: always()
run: |
cat $(./occ log:file |grep "Log file"|cut -d" " -f3)
docker ps -a
docker ps -aq | while read container ; do IMAGE=$(docker inspect --format='{{.Config.Image}}' $container); echo $IMAGE; docker logs $container; echo "\n\n" ; done
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, integration-sqlite]
if: always()
name: integration-sqlite-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.integration-sqlite.result != 'success' }}; then exit 1; fi
-100
View File
@@ -1,100 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Lint eslint
on: pull_request
permissions:
contents: read
concurrency:
group: lint-eslint-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '**/src/**'
- '**/appinfo/info.xml'
- 'package.json'
- 'package-lock.json'
- 'tsconfig.json'
- '.eslintrc.*'
- '.eslintignore'
- '**.js'
- '**.ts'
- '**.vue'
lint:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
name: NPM lint
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
id: versions
with:
fallbackNode: '^24'
fallbackNpm: '^11.3'
- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: ${{ steps.versions.outputs.nodeVersion }}
- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
- name: Install dependencies
env:
CYPRESS_INSTALL_BINARY: 0
PUPPETEER_SKIP_DOWNLOAD: true
run: npm ci
- name: Lint
run: npm run lint
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, lint]
if: always()
# This is the summary, we just avoid to rename it so that branch protection rules still match
name: eslint
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.lint.result != 'success' }}; then exit 1; fi
-85
View File
@@ -1,85 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Lint php-cs
on: pull_request
permissions:
contents: read
concurrency:
group: lint-php-cs-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/lib/**'
- '**/tests/**'
- '**/vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
lint:
runs-on: ubuntu-latest
name: php-cs
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
- name: Set up php
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
timeout-minutes: 5
with:
php-version: 8.2
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: none
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Install dependencies
run: composer i
- name: Lint
run: composer run cs:check || ( echo 'Please run `composer run cs:fix` to format your code' && exit 1 )
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, lint]
if: always()
# This is the summary, we just avoid to rename it so that branch protection rules still match
name: php-cs
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.lint.result != 'success' }}; then exit 1; fi
-86
View File
@@ -1,86 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Lint php
on: pull_request
permissions:
contents: read
concurrency:
group: lint-php-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/lib/**'
- '**/tests/**'
- '**/vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
lint:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
matrix:
php-versions: [ '8.2', '8.3', '8.4', '8.5' ]
name: php-lint
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: none
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Lint
run: composer run lint
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, lint]
if: always()
name: php-lint-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.lint.result != 'success' }}; then exit 1; fi
-53
View File
@@ -1,53 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Lint stylelint
on: pull_request
permissions:
contents: read
concurrency:
group: lint-stylelint-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
lint:
runs-on: ubuntu-latest
name: stylelint
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
id: versions
with:
fallbackNode: '^24'
fallbackNpm: '^11.3'
- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: ${{ steps.versions.outputs.nodeVersion }}
- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
- name: Install dependencies
env:
CYPRESS_INSTALL_BINARY: 0
run: npm ci
- name: Lint
run: npm run stylelint
+40
View File
@@ -0,0 +1,40 @@
name: Lint
on: pull_request
jobs:
php-linters:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: ['7.2', '7.3', 7.4]
name: php${{ matrix.php-versions }} lint
steps:
- name: Checkout
uses: actions/checkout@master
- name: Set up php${{ matrix.php-versions }}
uses: shivammathur/setup-php@master
with:
php-version: ${{ matrix.php-versions }}
coverage: none
- name: Lint
run: composer run lint
php-cs-fixer:
name: php-cs check
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@master
- name: Set up php
uses: shivammathur/setup-php@master
with:
php-version: 7.4
coverage: none
tools: cs2pr
- name: Install dependencies
run: composer i
- name: Run coding standards check
run: |
composer run cs:check -- --format=checkstyle | cs2pr
composer run cs:check || ( echo 'Please run `composer run cs:fix` to format your code' && exit 1 )
shell: bash {0}
@@ -1,99 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Node handlebars tests
on:
pull_request:
permissions:
contents: read
concurrency:
group: node-tests-handlebars-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src }}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '**/__tests__/**'
- '**/__mocks__/**'
- 'apps/*/src/**'
- 'apps/*/appinfo/info.xml'
- 'core/src/**'
- 'package.json'
- '**/package-lock.json'
- 'tsconfig.json'
- '**.js'
- '**.ts'
- '**.vue'
handlebars:
runs-on: ubuntu-latest
needs: [changes]
if: needs.changes.outputs.src != 'false'
env:
CYPRESS_INSTALL_BINARY: 0
PUPPETEER_SKIP_DOWNLOAD: true
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
id: versions
with:
fallbackNode: '^24'
fallbackNpm: '^11.3'
- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: ${{ steps.versions.outputs.nodeVersion }}
- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
- name: Install dependencies
run: npm ci
- name: Run compile
run: ./build/compile-handlebars-templates.sh
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, handlebars]
if: always()
name: test-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.handlebars.result != 'success' }}; then exit 1; fi
-109
View File
@@ -1,109 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Node tests
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: node-tests-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '**/__tests__/**'
- '**/__mocks__/**'
- 'apps/*/src/**'
- 'apps/*/appinfo/info.xml'
- 'core/src/**'
- 'package.json'
- '**/package-lock.json'
- 'tsconfig.json'
- '**.js'
- '**.ts'
- '**.vue'
test:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
id: versions
with:
fallbackNode: '^24'
fallbackNpm: '^11.3'
- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: ${{ steps.versions.outputs.nodeVersion }}
- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
- name: Install dependencies
env:
CYPRESS_INSTALL_BINARY: 0
run: |
npm ci
# - name: Test
# run: npm run test --if-present
- name: Test and process coverage
run: npm run test:coverage
- name: Collect coverage
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./coverage/lcov.info,./coverage/legacy/lcov.info
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, test]
if: always()
name: node-test-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.test.result != 'success' }}; then exit 1; fi
+56 -105
View File
@@ -1,117 +1,68 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Node
on: pull_request
permissions:
contents: read
concurrency:
group: node-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
on:
pull_request:
push:
branches:
- master
- stable*
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '**/src/**'
- '**/appinfo/info.xml'
- 'core/css/*'
- 'core/img/**'
- 'package.json'
- '**/package-lock.json'
- 'tsconfig.json'
- '**.js'
- '**.ts'
- '**.vue'
- 'version.php'
build:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
matrix:
node-version: [12.x]
name: NPM build
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/checkout@v2
- name: Use node ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- name: Install dependencies & build
run: |
make clean
npm ci
npm run build --if-present
- name: Check webpack build changes
run: |
bash -c "[[ ! \"`git status --porcelain `\" ]] || ( echo 'Uncommited changes in webpack build' && git status && exit 1 )"
env:
CI: true
test:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12.x]
steps:
- uses: actions/checkout@v2
- name: Use node ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- name: Install dependencies
run: |
npm ci
- name: Test
run: npm run test
handlebars:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12.x]
steps:
- uses: actions/checkout@v2
- name: Use node ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
persist-credentials: false
- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
id: versions
with:
fallbackNode: '^24'
fallbackNpm: '^11.3'
- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: ${{ steps.versions.outputs.nodeVersion }}
- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
# This does not work on server as we have some git dependencies that "npm-package-lock-add-resolved" cannot handle
# - name: Validate package-lock.json # See https://github.com/npm/cli/issues/4460
# run: |
# npm i -g npm-package-lock-add-resolved@1.1.4
# npm-package-lock-add-resolved
# git --no-pager diff --exit-code
- name: Install dependencies & build
env:
CYPRESS_INSTALL_BINARY: 0
PUPPETEER_SKIP_DOWNLOAD: true
node-version: ${{ matrix.node-version }}
- name: Install dependencies
run: |
npm ci
npm run build --if-present
- name: Check build changes
run: |
bash -c "[[ ! \"`git status --porcelain `\" ]] || (echo 'Please recompile and commit the assets, see the section \"Show changes on failure\" for details' && exit 1)"
- name: Show changes on failure
if: failure()
run: |
git status
git --no-pager diff
exit 1 # make it red to grab attention
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, build]
if: always()
# This is the summary, we just avoid to rename it so that branch protection rules still match
name: node
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.build.result != 'success' }}; then exit 1; fi
- name: Run compile
run: ./build/compile-handlebars-templates.sh
-85
View File
@@ -1,85 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Npm audit fix and compile
on:
workflow_dispatch:
schedule:
# At 2:30 on Sundays
- cron: '30 2 * * 0'
permissions:
contents: read
jobs:
build:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
branches:
- ${{ github.event.repository.default_branch }}
- 'stable33'
- 'stable32'
- 'stable31'
name: npm-audit-fix-${{ matrix.branches }}
steps:
- name: Checkout
id: checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
ref: ${{ matrix.branches }}
continue-on-error: true
- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
id: versions
with:
fallbackNode: '^24'
fallbackNpm: '^11.3'
- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: ${{ steps.versions.outputs.nodeVersion }}
- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
- name: Fix npm audit
id: npm-audit
uses: nextcloud-libraries/npm-audit-action@1b1728b2b4a7a78d69de65608efcf4db0e3e42d0 # v0.2.0
- name: Run npm ci and npm run build
if: steps.checkout.outcome == 'success'
env:
CYPRESS_INSTALL_BINARY: 0
run: |
npm ci
npm run build --if-present
- name: Create Pull Request
if: steps.checkout.outcome == 'success'
uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0 # v8.1.0
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
commit-message: 'fix(deps): Fix npm audit'
committer: GitHub <noreply@github.com>
author: nextcloud-command <nextcloud-command@users.noreply.github.com>
signoff: true
branch: automated/noid/${{ matrix.branches }}-fix-npm-audit
title: '[${{ matrix.branches }}] Fix npm audit'
body: ${{ steps.npm-audit.outputs.markdown }}
labels: |
dependencies
3. to review
-145
View File
@@ -1,145 +0,0 @@
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Object storage azure
on:
pull_request:
schedule:
- cron: "15 2 * * *"
permissions:
contents: read
concurrency:
group: object-storage-azure-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- 'apps/files/lib/**'
- 'apps/files/tests/**'
- 'apps/files_external/**'
- 'apps/files_sharing/lib/**'
- 'apps/files_sharing/tests/**'
- 'apps/files_trashbin/lib/**'
- 'apps/files_trashbin/tests/**'
- 'apps/files_versions/lib/**'
- 'apps/files_versions/tests/**'
- 'lib/private/Files/**'
- 'lib/public/Files/**'
- 'tests/lib/Files/**'
azure-primary-tests:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.2', '8.3']
include:
- php-versions: '8.4'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-azure
services:
azurite:
image: mcr.microsoft.com/azure-storage/azurite@sha256:0a47e12e3693483cef5c71f35468b91d751611f172d2f97414e9c69113b106d9 # v3.34.0
env:
AZURITE_ACCOUNTS: nextcloud:bmV4dGNsb3Vk
ports:
- 10000:10000
options: --health-cmd="nc 127.0.0.1 10000 -z" --health-interval=1s --health-retries=30
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
env:
OBJECT_STORE: azure
OBJECT_STORE_KEY: nextcloud
OBJECT_STORE_SECRET: bmV4dGNsb3Vk
run: |
composer install
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
php -f tests/enable_all.php
- name: PHPUnit
env:
OBJECT_STORE: azure
OBJECT_STORE_KEY: nextcloud
OBJECT_STORE_SECRET: bmV4dGNsb3Vk
run: composer run test -- --group PRIMARY-azure --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.xml
flags: phpunit-azure
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-azure
- name: Azurite logs
if: always()
run: |
docker ps -a
docker ps -aq | while read container ; do IMAGE=$(docker inspect --format='{{.Config.Image}}' $container); echo $IMAGE; docker logs $container; echo "\n\n" ; done
azure-primary-summary:
runs-on: ubuntu-latest-low
needs: [changes, azure-primary-tests]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.azure-primary-tests.result != 'success' }}; then exit 1; fi
-151
View File
@@ -1,151 +0,0 @@
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Object storage S3
on:
pull_request:
schedule:
- cron: "15 2 * * *"
permissions:
contents: read
concurrency:
group: object-storage-s3-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- 'apps/files/lib/**'
- 'apps/files/tests/**'
- 'apps/files_external/**'
- 'apps/files_sharing/lib/**'
- 'apps/files_sharing/tests/**'
- 'apps/files_trashbin/lib/**'
- 'apps/files_trashbin/tests/**'
- 'apps/files_versions/lib/**'
- 'apps/files_versions/tests/**'
- 'lib/private/Files/**'
- 'lib/public/Files/**'
- 'tests/lib/Files/**'
s3-primary-tests-minio:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
include:
- php-versions: '8.3'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-s3
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
minio:
image: bitnami/minio@sha256:50cec18ac4184af4671a78aedd5554942c8ae105d51a465fa82037949046da01 # v2025.4.22
env:
MINIO_ROOT_USER: nextcloud
MINIO_ROOT_PASSWORD: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
MINIO_DEFAULT_BUCKETS: nextcloud
ports:
- "9000:9000"
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
env:
OBJECT_STORE: s3
OBJECT_STORE_KEY: nextcloud
OBJECT_STORE_SECRET: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
run: |
composer install
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
php -f tests/enable_all.php
- name: Wait for S3
run: |
sleep 10
curl -f -m 1 --retry-connrefused --retry 10 --retry-delay 10 http://localhost:9000/minio/health/ready
- name: PHPUnit
env:
OBJECT_STORE: s3
OBJECT_STORE_KEY: nextcloud
OBJECT_STORE_SECRET: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
run: composer run test -- --group PRIMARY-s3 --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.xml
flags: phpunit-s3
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-s3
- name: S3 logs
if: always()
run: |
docker ps -a
docker ps -aq | while read container ; do IMAGE=$(docker inspect --format='{{.Config.Image}}' $container); echo $IMAGE; docker logs $container; echo "\n\n" ; done
s3-primary-summary:
runs-on: ubuntu-latest-low
needs: [changes,s3-primary-tests-minio]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.s3-primary-tests-minio.result != 'success' }}; then exit 1; fi
-141
View File
@@ -1,141 +0,0 @@
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Object storage Swift
on:
pull_request:
schedule:
- cron: "15 2 * * *"
permissions:
contents: read
concurrency:
group: object-storage-swift-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- 'apps/files/lib/**'
- 'apps/files/tests/**'
- 'apps/files_external/**'
- 'apps/files_sharing/lib/**'
- 'apps/files_sharing/tests/**'
- 'apps/files_trashbin/lib/**'
- 'apps/files_trashbin/tests/**'
- 'apps/files_versions/lib/**'
- 'apps/files_versions/tests/**'
- 'lib/private/Files/**'
- 'lib/public/Files/**'
- 'tests/lib/Files/**'
swift-primary-tests:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
include:
- php-versions: '8.3'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-swift
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
swift:
image: ghcr.io/cscfi/docker-keystone-swift@sha256:e8b1ec21120ab9adc6ac6a2b98785fd273676439a8633fe898e37f2aea7e0712
ports:
- 5000:5000
- 8080:8080
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
env:
OBJECT_STORE: swift
OBJECT_STORE_SECRET: veryfast
run: |
composer install
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
php -f tests/enable_all.php
- name: PHPUnit
env:
OBJECT_STORE: swift
OBJECT_STORE_SECRET: veryfast
run: composer run test -- --group PRIMARY-swift --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.xml
flags: phpunit-swift
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-swift
- name: Swift logs
if: always()
run: |
docker ps -a
docker ps -aq | while read container ; do IMAGE=$(docker inspect --format='{{.Config.Image}}' $container); echo $IMAGE; docker logs $container; echo "\n\n" ; done
swift-primary-summary:
runs-on: ubuntu-latest-low
needs: [changes,swift-primary-tests]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.swift-primary-tests.result != 'success' }}; then exit 1; fi
+56
View File
@@ -0,0 +1,56 @@
name: PHPUnit
on:
pull_request:
push:
branches:
- master
- stable*
jobs:
phpunit-oci8:
runs-on: ubuntu-latest
strategy:
# do not stop on another job's failure
fail-fast: false
matrix:
php-versions: [ '7.4' ]
databases: [ 'oci' ]
name: php${{ matrix.php-versions }}-${{ matrix.databases }}
services:
oracle:
image: deepdiver/docker-oracle-xe-11g # "wnameless/oracle-xe-11g-r2"
ports:
- "1521:1521"
steps:
- name: Checkout server
uses: actions/checkout@v2
- name: Checkout submodules
shell: bash
run: |
auth_header="$(git config --local --get http.https://github.com/.extraheader)"
git submodule sync --recursive
git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-versions }}
extensions: mbstring, iconv, fileinfo, intl, sqlite, pdo_sqlite, oci8
tools: phpunit:8.5.2
coverage: none
- name: Set up Nextcloud
run: |
mkdir data
./occ maintenance:install --verbose --database=oci --database-name=XE --database-host=127.0.0.1 --database-port=1521 --database-user=autotest --database-pass=owncloud --admin-user admin --admin-pass admin
php -f index.php
- name: PHPUnit
working-directory: tests
run: phpunit --configuration phpunit-autotest.xml --group DB,SLOWDB
-48
View File
@@ -1,48 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-FileCopyrightText: 2024 Arthur Schiwon <blizzz@arthur-schiwon.de>
# SPDX-License-Identifier: MIT
name: OpenAPI
on: pull_request
permissions:
contents: read
concurrency:
group: openapi-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
openapi:
runs-on: ubuntu-latest
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
- name: Set up php
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
timeout-minutes: 5
with:
php-version: '8.2'
extensions: ctype, curl, dom, fileinfo, gd, json, libxml, mbstring, openssl, pcntl, pdo, posix, session, simplexml, xml, xmlreader, xmlwriter, zip, zlib
coverage: none
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: OpenAPI checker
run: build/openapi-checker.sh
-128
View File
@@ -1,128 +0,0 @@
# SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Performance testing
on:
pull_request:
permissions:
contents: read
concurrency:
group: performance-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
performance-testing:
runs-on: ubuntu-latest
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
permissions:
pull-requests: write
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
name: performance-${{ matrix.php-versions }}
steps:
- name: Disabled on forks
if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
run: |
echo 'Can not run performance tests on forks'
exit 1
- name: Checkout server before PR
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
ref: ${{ github.event.pull_request.base.ref }}
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
run: |
mkdir data
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
php -S localhost:8080 &
- name: Apply blueprint
uses: icewind1991/blueprint@00504403f76cb2a09efd0d16793575055e6f63cb # v0.1.2
with:
blueprint: tests/blueprints/basic.toml
ref: ${{ github.event.pull_request.head.ref }}
- name: Run before measurements
uses: nextcloud/profiler@6a74c915048285b35b8e1cd96c0835a635945044
with:
run: |
curl -s -X PROPFIND -u test:test http://localhost:8080/remote.php/dav/files/test
curl -s -u test:test http://localhost:8080/remote.php/dav/files/test/test.txt
curl -s -X PROPFIND -u test:test http://localhost:8080/remote.php/dav/files/test/many_files
curl -s -u test:test -T README.md http://localhost:8080/remote.php/dav/files/test/new_file.txt
curl -s -u test:test -X DELETE http://localhost:8080/remote.php/dav/files/test/new_file.txt
output: before.json
profiler-branch: master
- name: Apply PR # zizmor: ignore[template-injection]
run: |
git remote add pr '${{ github.event.pull_request.head.repo.clone_url }}'
git fetch pr '${{ github.event.pull_request.head.ref }}'
git checkout -b 'pr/${{ github.event.pull_request.head.ref }}'
git submodule update
./occ upgrade
- name: Run after measurements
id: compare
uses: nextcloud/profiler@6a74c915048285b35b8e1cd96c0835a635945044
with:
run: |
curl -s -X PROPFIND -u test:test http://localhost:8080/remote.php/dav/files/test
curl -s -u test:test http://localhost:8080/remote.php/dav/files/test/test.txt
curl -s -X PROPFIND -u test:test http://localhost:8080/remote.php/dav/files/test/many_files
curl -s -u test:test -T README.md http://localhost:8080/remote.php/dav/files/test/new_file.txt
curl -s -u test:test -X DELETE http://localhost:8080/remote.php/dav/files/test/new_file.txt
output: after.json
profiler-branch: master
compare-with: before.json
- name: Upload profiles
if: always()
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f
with:
name: profiles
path: |
before.json
after.json
- uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v7
if: failure() && steps.compare.outcome == 'failure'
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
let comment = `Possible performance regression detected\n`;
comment += `<details><summary>Show Output</summary>
\`\`\`
${{ steps.compare.outputs.compare }}
\`\`\`
</details>`;
github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: comment
})
-59
View File
@@ -1,59 +0,0 @@
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit 32bits
on:
pull_request:
paths:
- "version.php"
- ".github/workflows/phpunit-32bits.yml"
- "tests/phpunit-autotest.xml"
- "lib/private/Snowflake/*"
workflow_dispatch:
schedule:
- cron: "15 1 * * 1-6"
permissions:
contents: read
concurrency:
group: phpunit-32bits-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
phpunit-32bits:
runs-on: ubuntu-latest
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
strategy:
fail-fast: false
matrix:
php-versions: ["8.4"]
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up dependencies
uses: docker://ghcr.io/nextcloud/continuous-integration-php8.4-32bit:latest
with:
args: /bin/sh -c "
git config --global --add safe.directory /github/workspace &&
composer install --no-interaction"
- name: Set up Nextcloud
uses: docker://ghcr.io/nextcloud/continuous-integration-php8.4-32bit:latest
with:
args: /bin/sh -c "
mkdir data &&
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-user=autotest --database-pass=rootpassword --admin-user admin --admin-pass admin &&
php -f tests/enable_all.php"
- name: PHPUnit
uses: docker://ghcr.io/nextcloud/continuous-integration-php8.4-32bit:latest
with:
args: /bin/sh -c "composer run test -- --exclude-group PRIMARY-azure,PRIMARY-s3,PRIMARY-swift,Memcached,Redis,RoutingWeirdness"
-158
View File
@@ -1,158 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit MariaDB
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-mariadb-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
phpunit-mariadb:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
mariadb-versions: ['10.6']
include:
- php-versions: '8.3'
mariadb-versions: '10.11'
coverage: ${{ github.event_name != 'pull_request' }}
- php-versions: '8.4'
mariadb-versions: '11.4'
- php-versions: '8.5'
mariadb-versions: '11.8'
name: MariaDB ${{ matrix.mariadb-versions }} (PHP ${{ matrix.php-versions }}) - database tests
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
mariadb:
image: mariadb:${{ matrix.mariadb-versions }}
ports:
- 4444:3306/tcp
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: oc_autotest
options: --health-cmd="${{ matrix.mariadb-versions <= 10.4 && 'mysqladmin' || 'mariadb-admin'}} ping" --health-interval 5s --health-timeout 2s --health-retries 5
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, mysql, pdo_mysql
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: Enable ONLY_FULL_GROUP_BY MariaDB option
run: |
echo "SET GLOBAL sql_mode=(SELECT CONCAT(@@sql_mode,',ONLY_FULL_GROUP_BY'));" | mysql -h 127.0.0.1 -P 4444 -u root -prootpassword
echo 'SELECT @@sql_mode;' | mysql -h 127.0.0.1 -P 4444 -u root -prootpassword
- name: Set up Nextcloud
env:
DB_PORT: 4444
run: |
mkdir data
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=mysql --database-name=nextcloud --database-host=127.0.0.1 --database-port=$DB_PORT --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: PHPUnit
run: composer run test:db -- --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.db.xml' || '' }}
- name: Upload db code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.db.xml
flags: phpunit-mariadb
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-mariadb
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, phpunit-mariadb]
if: always()
name: phpunit-mariadb-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-mariadb.result != 'success' }}; then exit 1; fi
-135
View File
@@ -1,135 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit memcached
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-memcached-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
phpunit-memcached:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
fail-fast: false
matrix:
php-versions: ['8.3', '8.4', '8.5']
include:
- php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
name: Memcached (PHP ${{ matrix.php-versions }})
services:
memcached:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 11212:11212/tcp
- 11212:11212/udp
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, memcached, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: Set up Nextcloud
run: |
mkdir data
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: PHPUnit memcached tests
run: composer run test -- --group Memcache --group Memcached --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.xml
flags: phpunit-memcached
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-memcached
- name: Print logs
if: always()
run: |
cat data/nextcloud.log
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, phpunit-memcached]
if: always()
name: phpunit-memcached-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-memcached.result != 'success' }}; then exit 1; fi
@@ -1,193 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2022-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit sharding
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-mysql-sharding-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src }}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
phpunit-mysql:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
mysql-versions: ['8.4']
name: Sharding - MySQL ${{ matrix.mysql-versions }} (PHP ${{ matrix.php-versions }}) - database tests
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
mysql:
image: ghcr.io/nextcloud/continuous-integration-mysql-${{ matrix.mysql-versions }}:latest # zizmor: ignore[unpinned-images]
ports:
- 4444:3306/tcp
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: oc_autotest
options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 10
shard1:
image: ghcr.io/nextcloud/continuous-integration-mysql-${{ matrix.mysql-versions }}:latest # zizmor: ignore[unpinned-images]
ports:
- 5001:3306/tcp
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: nextcloud
options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 10
shard2:
image: ghcr.io/nextcloud/continuous-integration-mysql-${{ matrix.mysql-versions }}:latest # zizmor: ignore[unpinned-images]
ports:
- 5002:3306/tcp
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: nextcloud
options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 10
shard3:
image: ghcr.io/nextcloud/continuous-integration-mysql-${{ matrix.mysql-versions }}:latest # zizmor: ignore[unpinned-images]
ports:
- 5003:3306/tcp
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: nextcloud
options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 10
shard4:
image: ghcr.io/nextcloud/continuous-integration-mysql-${{ matrix.mysql-versions }}:latest # zizmor: ignore[unpinned-images]
ports:
- 5004:3306/tcp
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: nextcloud
options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 10
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, mysql, pdo_mysql
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: Enable ONLY_FULL_GROUP_BY MySQL option
run: |
echo "SET GLOBAL sql_mode=(SELECT CONCAT(@@sql_mode,',ONLY_FULL_GROUP_BY'));" | mysql -h 127.0.0.1 -P 4444 -u root -prootpassword
echo "SELECT @@sql_mode;" | mysql -h 127.0.0.1 -P 4444 -u root -prootpassword
- name: Set up Nextcloud
env:
DB_PORT: 4444
SHARDING: 1
run: |
mkdir data
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=mysql --database-name=nextcloud --database-host=127.0.0.1 --database-port=$DB_PORT --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: PHPUnit
run: composer run test:db -- --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.db.xml' || '' }}
- name: Upload db code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.db.xml
flags: phpunit-mysql
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-mysql
- name: Print logs
if: always()
run: |
cat data/nextcloud.log
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, phpunit-mysql]
if: always()
name: phpunit-mysql-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-mysql.result != 'success' }}; then exit 1; fi
-163
View File
@@ -1,163 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2022-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit mysql
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-mysql-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src }}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
phpunit-mysql:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
mysql-versions: ['8.0']
include:
- mysql-versions: '8.0'
php-versions: '8.3'
coverage: ${{ github.event_name != 'pull_request' }}
- mysql-versions: '8.4'
php-versions: '8.4'
- mysql-versions: '8.4'
php-versions: '8.5'
name: MySQL ${{ matrix.mysql-versions }} (PHP ${{ matrix.php-versions }}) - database tests
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
mysql:
image: ghcr.io/nextcloud/continuous-integration-mysql-${{ matrix.mysql-versions }}:latest # zizmor: ignore[unpinned-images]
ports:
- 4444:3306/tcp
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: oc_autotest
options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 10
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, mysql, pdo_mysql
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: Enable ONLY_FULL_GROUP_BY MySQL option
run: |
echo "SET GLOBAL sql_mode=(SELECT CONCAT(@@sql_mode,',ONLY_FULL_GROUP_BY'));" | mysql -h 127.0.0.1 -P 4444 -u root -prootpassword
echo "SELECT @@sql_mode;" | mysql -h 127.0.0.1 -P 4444 -u root -prootpassword
- name: Set up Nextcloud
env:
DB_PORT: 4444
run: |
mkdir data
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=mysql --database-name=nextcloud --database-host=127.0.0.1 --database-port=$DB_PORT --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: PHPUnit
run: composer run test:db -- --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.db.xml' || '' }}
- name: Upload db code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.db.xml
flags: phpunit-mysql
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-mysql
- name: Print logs
if: always()
run: |
cat data/nextcloud.log
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, phpunit-mysql]
if: always()
name: phpunit-mysql-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-mysql.result != 'success' }}; then exit 1; fi
-141
View File
@@ -1,141 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
#
# This is the testsuite running all non-database agnostic unit tests
name: PHPUnit nodb
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-nodb-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src }}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'resources/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
phpunit-nodb:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
fail-fast: false
matrix:
php-versions: ['8.3', '8.4', '8.5']
include:
- php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
name: No DB unit tests (PHP ${{ matrix.php-versions }})
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, imagick, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
# Required for tests that use pcntl
ini-values: disable_functions=""
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: Set up Nextcloud
run: |
mkdir data
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: PHPUnit nodb testsuite
run: composer run test -- --exclude-group DB --exclude-group SLOWDB --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.nodb.xml' || '' }}
- name: Upload nodb code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.nodb.xml
flags: phpunit-nodb
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-nodb
- name: Print logs
if: always()
run: |
cat data/nextcloud.log
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, phpunit-nodb]
if: always()
name: phpunit-nodb-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-nodb.result != 'success' }}; then exit 1; fi
@@ -1,125 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit primary object store
on:
pull_request:
schedule:
- cron: "15 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-object-store-primary-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
object-store-primary-tests-minio:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
key: ['s3', 's3-multibucket']
name: php${{ matrix.php-versions }}-${{ matrix.key }}-minio
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
minio:
image: bitnami/minio@sha256:50cec18ac4184af4671a78aedd5554942c8ae105d51a465fa82037949046da01 # v2025.4.22
env:
MINIO_ROOT_USER: nextcloud
MINIO_ROOT_PASSWORD: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
MINIO_DEFAULT_BUCKETS: nextcloud
ports:
- "9000:9000"
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
env:
OBJECT_STORE: ${{ matrix.key }}
OBJECT_STORE_KEY: nextcloud
OBJECT_STORE_SECRET: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
run: |
composer install
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
php -f tests/enable_all.php
- name: Wait for S3
run: |
sleep 10
curl -f -m 1 --retry-connrefused --retry 10 --retry-delay 10 http://localhost:9000/minio/health/ready
- name: PHPUnit
run: composer run test:db
- name: S3 logs
if: always()
run: |
cat data/nextcloud.log
docker ps -a
docker ps -aq | while read container ; do IMAGE=$(docker inspect --format='{{.Config.Image}}' $container); echo $IMAGE; docker logs $container; echo "\n\n" ; done
object-store-primary-summary:
runs-on: ubuntu-latest-low
needs: [changes,object-store-primary-tests-minio]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.object-store-primary-tests-minio.result != 'success' }}; then exit 1; fi
-162
View File
@@ -1,162 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2022-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit OCI
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-oci-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src }}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
phpunit-oci:
runs-on: ubuntu-latest
needs: changes
if: ${{ needs.changes.outputs.src != 'false' && github.repository_owner != 'nextcloud-gmbh' }}
strategy:
fail-fast: false
matrix:
include:
- oracle-versions: '18'
php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
- oracle-versions: '21'
php-versions: '8.3'
- oracle-versions: '23'
php-versions: '8.4'
- oracle-versions: '23'
php-versions: '8.5'
name: Oracle ${{ matrix.oracle-versions }} (PHP ${{ matrix.php-versions }}) - database tests
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
oracle:
image: ghcr.io/gvenzl/oracle-${{ matrix.oracle-versions < 23 && 'xe' || 'free' }}:${{ matrix.oracle-versions }}
# Provide passwords and other environment variables to container
env:
ORACLE_PASSWORD: oracle
# Forward Oracle port
ports:
- 1521:1521
# Provide healthcheck script options for startup
options: >-
--health-cmd healthcheck.sh
--health-interval 20s
--health-timeout 10s
--health-retries 10
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, oci8
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: Set up Nextcloud
run: |
mkdir data
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=oci --database-name=${{ matrix.oracle-versions < 23 && 'XE' || 'FREE' }} --database-host=127.0.0.1 --database-port=1521 --database-user=system --database-pass=oracle --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: PHPUnit
run: composer run test:db -- --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.db.xml' || '' }}
- name: Upload db code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.db.xml
flags: phpunit-oci
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-oci
- name: Run repair steps
run: |
./occ maintenance:repair --include-expensive
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, phpunit-oci]
if: always()
name: phpunit-oci-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-oci.result != 'success' }}; then exit 1; fi
-162
View File
@@ -1,162 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2022-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit PostgreSQL
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-pgsql-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src }}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
phpunit-pgsql:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
# To keep the matrix smaller we ignore PostgreSQL versions in between as we already test the minimum and the maximum
postgres-versions: ['14']
include:
- php-versions: '8.3'
postgres-versions: '18'
coverage: ${{ github.event_name != 'pull_request' }}
- php-versions: '8.4'
postgres-versions: '18'
- php-versions: '8.5'
postgres-versions: '18'
name: PostgreSQL ${{ matrix.postgres-versions }} (PHP ${{ matrix.php-versions }}) - database tests
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
postgres:
image: ghcr.io/nextcloud/continuous-integration-postgres-${{ matrix.postgres-versions }}:latest # zizmor: ignore[unpinned-images]
ports:
- 4444:5432/tcp
env:
POSTGRES_USER: root
POSTGRES_PASSWORD: rootpassword
POSTGRES_DB: nextcloud
options: --mount type=tmpfs,destination=/var/lib/postgresql --health-cmd pg_isready --health-interval 5s --health-timeout 2s --health-retries 5
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, pgsql, pdo_pgsql
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: Set up Nextcloud
env:
DB_PORT: 4444
run: |
mkdir data
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=pgsql --database-name=nextcloud --database-host=127.0.0.1 --database-port=$DB_PORT --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: PHPUnit database tests
run: composer run test:db -- --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.db.xml' || '' }}
- name: Upload db code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.db.xml
flags: phpunit-postgres
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-postgres
- name: Run repair steps
run: |
./occ maintenance:repair --include-expensive
- name: Print logs
if: always()
run: |
cat data/nextcloud.log
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, phpunit-pgsql]
if: always()
name: phpunit-pgsql-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-pgsql.result != 'success' }}; then exit 1; fi
-147
View File
@@ -1,147 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2022-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit SQLite
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-sqlite-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src }}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
phpunit-sqlite:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
fail-fast: false
matrix:
php-versions: ['8.3', '8.4', '8.5']
include:
- php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
name: SQLite (PHP ${{ matrix.php-versions }})
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- name: Checkout server
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
timeout-minutes: 5
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, imagick, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: |
sudo apt-get update
sudo apt-get install -y ghostscript
composer i
- name: Set up Nextcloud
run: |
mkdir data
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: Nextcloud debug information
run: ./occ app:list && echo "======= System config =======" && ./occ config:list system
- name: PHPUnit database tests
run: composer run test:db -- --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.db.xml' || '' }} tests/lib/Preview/PostscriptTest.php
- name: Upload db code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ./clover.db.xml
flags: phpunit-sqlite
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3 # v1.2.1
with:
flags: phpunit-sqlite
- name: Print logs
if: always()
run: |
gs --version
cat /etc/ImageMagick-6/policy.xml
cat data/nextcloud.log
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, phpunit-sqlite]
if: always()
name: phpunit-sqlite-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-sqlite.result != 'success' }}; then exit 1; fi
-55
View File
@@ -1,55 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
# SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-FileCopyrightText: 2023 Marcel Klehr <mklehr@gmx.net>
# SPDX-FileCopyrightText: 2023 Joas Schilling <213943+nickvergessen@users.noreply.github.com>
# SPDX-FileCopyrightText: 2023 Daniel Kesselberg <mail@danielkesselberg.de>
# SPDX-FileCopyrightText: 2023 Florian Steffens <florian.steffens@nextcloud.com>
# SPDX-License-Identifier: MIT
name: 'Ask for feedback on PRs'
on:
schedule:
- cron: '30 1 * * *'
permissions:
contents: read
pull-requests: write
jobs:
pr-feedback:
if: ${{ github.repository_owner == 'nextcloud' }}
runs-on: ubuntu-latest
steps:
- name: The get-github-handles-from-website action
uses: marcelklehr/get-github-handles-from-website-action@06b2239db0a48fe1484ba0bfd966a3ab81a08308 # v1.0.1
id: scrape
with:
website: 'https://nextcloud.com/team/'
- name: Get blocklist
id: blocklist
run: |
blocklist=$(curl https://raw.githubusercontent.com/nextcloud/.github/master/non-community-usernames.txt | paste -s -d, -)
echo "blocklist=$blocklist" >> "$GITHUB_OUTPUT"
- uses: nextcloud/pr-feedback-action@f0cab224dea8e1f282f9451de322f323c78fc7a5 # main
with:
feedback-message: |
Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
Thank you for contributing to Nextcloud and we hope to hear from you soon!
(If you believe you should not receive this message, you can add yourself to the [blocklist](https://github.com/nextcloud/.github/blob/master/non-community-usernames.txt).)
days-before-feedback: 14
start-date: '2025-06-12'
exempt-authors: '${{ steps.blocklist.outputs.blocklist }},${{ steps.scrape.outputs.users }}'
exempt-bots: true
-70
View File
@@ -1,70 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Apply rector changes
on:
workflow_dispatch:
schedule:
# At 14:30 on Sundays
- cron: '30 14 * * 0'
permissions:
contents: read
jobs:
build:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
php-versions: [ '8.2' ]
name: rector-apply
steps:
- name: Checkout
id: checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
ref: ${{ github.event.repository.default_branch }}
- name: Set up php${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
with:
php-version: ${{ matrix.php-versions }}
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: none
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Install dependencies
run: |
composer remove nextcloud/ocp --dev --no-scripts
composer i
git restore lib/composer/composer
- name: Rector
run: composer run rector
- name: Create Pull Request
uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0 # v8.1.0
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
commit-message: 'refactor: Apply rector changes'
committer: GitHub <noreply@github.com>
author: nextcloud-command <nextcloud-command@users.noreply.github.com>
signoff: true
branch: automated/noid/rector-changes
title: 'Apply rector changes'
labels: |
technical debt
3. to review
-45
View File
@@ -1,45 +0,0 @@
# SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
name: Rector
on:
pull_request:
permissions:
contents: read
concurrency:
group: rector-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
strict:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Set up php
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
with:
php-version: '8.2'
extensions: apcu,ctype,curl,dom,fileinfo,ftp,gd,imagick,intl,json,ldap,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
coverage: none
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Composer install
run: composer i
- name: Rector
run: composer run rector:strict
- name: Show changes
if: always()
run: git diff --exit-code -- . ':!lib/composer'
-27
View File
@@ -1,27 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
# SPDX-FileCopyrightText: 2022 Free Software Foundation Europe e.V. <https://fsfe.org>
#
# SPDX-License-Identifier: CC0-1.0
name: REUSE Compliance Check
on: [pull_request]
permissions:
contents: read
jobs:
reuse-compliance-check:
runs-on: ubuntu-latest-low
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
- name: REUSE Compliance Check
uses: fsfe/reuse-action@676e2d560c9a403aa252096d99fcab3e1132b0f5 # v6.0.0
-37
View File
@@ -1,37 +0,0 @@
# SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Close stale issues
on:
workflow_dispatch:
schedule:
- cron: "0 0 * * *"
permissions:
contents: read
jobs:
stale:
runs-on: ubuntu-latest
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
permissions:
issues: write
steps:
- uses: actions/stale@b5d41d4e1d5dceea10e7104786b73624c18a190f # v9
with:
repo-token: ${{ secrets.COMMAND_BOT_PAT }}
stale-issue-message: >
This issue has been automatically marked as stale because it has not had
recent activity and seems to be missing some essential information.
It will be closed if no further activity occurs. Thank you
for your contributions.
stale-issue-label: 'stale'
only-labels: 'needs info'
exempt-issue-labels: '1. to develop,2. developing,3. to review,4. to release,security'
days-before-stale: 30
days-before-close: 14
# debug-only: true
+26 -177
View File
@@ -1,180 +1,29 @@
# SPDX-FileCopyrightText: 2020 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Psalm static code analysis
name: Static code analysis
on:
pull_request:
push:
branches:
- main
- master
- stable*
paths:
- '.github/workflows/static-code-analysis.yml'
- '**.php'
permissions:
contents: read
concurrency:
group: static-code-analysis-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
on: [pull_request]
jobs:
static-code-analysis:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
with:
persist-credentials: false
submodules: true
- name: Set up php
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: '8.2'
extensions: apcu,ctype,curl,dom,fileinfo,ftp,gd,imagick,intl,json,ldap,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
coverage: none
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Composer install
run: composer i
- name: Psalm
run: composer run psalm -- --threads=1 --monochrome --no-progress --output-format=github --update-baseline
- name: Show potential changes in Psalm baseline
if: always()
run: git diff --exit-code -- . ':!lib/composer'
static-code-analysis-security:
runs-on: ubuntu-latest
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
permissions:
security-events: write
steps:
- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
with:
persist-credentials: false
submodules: true
- name: Set up php
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: '8.2'
extensions: ctype,curl,dom,fileinfo,ftp,gd,imagick,intl,json,ldap,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
coverage: none
- name: Composer install
run: composer i
- name: Psalm taint analysis
run: composer run psalm:security -- --threads=1 --monochrome --no-progress --output-format=github --update-baseline --report=results.sarif
- name: Show potential changes in Psalm baseline
if: always()
run: git diff --exit-code -- . ':!lib/composer'
- name: Upload Security Analysis results to GitHub
if: always()
uses: github/codeql-action/upload-sarif@89a39a4e59826350b863aa6b6252a07ad50cf83e # v3
with:
sarif_file: results.sarif
static-code-analysis-ocp:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
with:
persist-credentials: false
submodules: true
- name: Set up php
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: '8.2'
extensions: ctype,curl,dom,fileinfo,gd,imagick,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
coverage: none
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Composer install
run: composer i
- name: Psalm
run: composer run psalm:ocp -- --threads=1 --monochrome --no-progress --output-format=github --update-baseline
- name: Show potential changes in Psalm baseline
if: always()
run: git diff --exit-code -- . ':!lib/composer'
static-code-analysis-ncu:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
with:
persist-credentials: false
submodules: true
- name: Set up php
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
timeout-minutes: 5
with:
php-version: '8.2'
extensions: ctype,curl,dom,fileinfo,gd,imagick,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
coverage: none
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Composer install
run: composer i
- name: Psalm
run: composer run psalm:ncu -- --threads=1 --monochrome --no-progress --output-format=github
static-code-analysis-strict:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
with:
persist-credentials: false
submodules: true
- name: Set up php
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 #v2.36.0
with:
php-version: '8.2'
extensions: ctype,curl,dom,fileinfo,gd,imagick,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
coverage: none
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Composer install
run: composer i
- name: Psalm
run: composer run psalm:strict -- --threads=1 --monochrome --no-progress --output-format=github
static-code-analysis:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Checkout submodules
shell: bash
run: |
auth_header="$(git config --local --get http.https://github.com/.extraheader)"
git submodule sync --recursive
git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1
- name: Set up php7.4
uses: shivammathur/setup-php@master
with:
php-version: 7.4
coverage: none
- name: Composer install
run: composer i
- name: Psalm
run: composer run psalm -- --monochrome --no-progress --output-format=github --update-baseline || ( git diff -- . ':!lib/composer' && exit 1 )
- name: Check diff
run: git diff -- . ':!lib/composer'
- name: Show potential changes in Psalm baseline
run: |
bash -c "[[ ! \"`git status --porcelain build/psalm-baseline.xml`\" ]] || ( echo 'Uncommited changes in Psalm baseline' && git status && git diff build/psalm-baseline.xml)"
@@ -1,49 +0,0 @@
# SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Update CA certificate bundle
on:
workflow_dispatch:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
jobs:
update-ca-certificate-bundle:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
branches: ['master', 'stable33', 'stable32', 'stable31', 'stable30', 'stable29', 'stable28', 'stable27', 'stable26', 'stable25', 'stable24', 'stable23', 'stable22']
name: update-ca-certificate-bundle-${{ matrix.branches }}
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
ref: ${{ matrix.branches }}
submodules: true
- name: Download CA certificate bundle from curl
run: curl --etag-compare build/ca-bundle-etag.txt --etag-save build/ca-bundle-etag.txt --output resources/config/ca-bundle.crt https://curl.se/ca/cacert.pem
- name: Create Pull Request
uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
commit-message: 'fix(security): Update CA certificate bundle'
committer: GitHub <noreply@github.com>
author: nextcloud-command <nextcloud-command@users.noreply.github.com>
signoff: true
branch: 'automated/noid/${{ matrix.branches }}-update-ca-cert-bundle'
title: '[${{ matrix.branches }}] fix(security): Update CA certificate bundle'
body: |
Auto-generated update of CA certificate bundle from [https://curl.se/docs/caextract.html](https://curl.se/docs/caextract.html)
labels: |
dependencies
3. to review
reviewers: ChristophWurst, miaulalala, nickvergessen
@@ -1,52 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Update code signing revocation list
on:
workflow_dispatch:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
jobs:
update-code-signing-crl:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
branches: ['master', 'stable33', 'stable32', 'stable31', 'stable30', 'stable29', 'stable28', 'stable27', 'stable26', 'stable25', 'stable24', 'stable23', 'stable22']
name: update-code-signing-crl-${{ matrix.branches }}
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
ref: ${{ matrix.branches }}
submodules: true
- name: Download CRL file from Appstore repository
run: curl --output resources/codesigning/root.crl https://raw.githubusercontent.com/nextcloud/appstore/master/nextcloudappstore/certificate/nextcloud.crl
- name: Verify CRL is from CRT
run: openssl crl -verify -in resources/codesigning/root.crl -CAfile resources/codesigning/root.crt -noout
- name: Create Pull Request
uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
commit-message: 'fix(security): Update code signing revocation list'
committer: GitHub <noreply@github.com>
author: nextcloud-command <nextcloud-command@users.noreply.github.com>
signoff: true
branch: 'automated/noid/${{ matrix.branches }}-update-code-signing-crl'
title: '[${{ matrix.branches }}] fix(security): Update code signing revocation list'
body: |
Auto-generated update of code signing revocation list from [Appstore](https://github.com/nextcloud/appstore/commits/master/nextcloudappstore/certificate/nextcloud.crl)
labels: |
dependencies
3. to review
reviewers: mgallien, miaulalala, nickvergessen
@@ -1,128 +0,0 @@
# SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Update min supported desktop version
on:
workflow_dispatch:
schedule:
- cron: "0 0 * * 1"
permissions:
contents: read
jobs:
update-minimum-supported-desktop-version:
runs-on: ubuntu-latest-low
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
submodules: true
- name: Download desktop client version file from 5 years ago
id: download
run: |
# Create a temporary directory for the downloaded file
mkdir -p tmp
# Download the version file from the provided URL
VERSION_FILE_URL="https://github.com/nextcloud/desktop/raw/@%7B5.years.ago%7D/VERSION.cmake"
# Download the file using curl
curl -s -L "$VERSION_FILE_URL" -o tmp/VERSION.cmake
if [ ! -f "tmp/VERSION.cmake" ]; then
echo "Failed to download VERSION.cmake file"
exit 1
fi
echo "VERSION_FILE=tmp/VERSION.cmake" >> $GITHUB_OUTPUT
echo "Downloaded version file to tmp/VERSION.cmake"
- name: Extract version info
id: extract-version
run: |
# Path to the downloaded version file
VERSION_FILE="${{ steps.download.outputs.VERSION_FILE }}"
# Extract major, minor, patch versions
MAJOR=$(grep "VERSION_MAJOR" $VERSION_FILE | grep -o '[0-9]\+')
MINOR=$(grep "VERSION_MINOR" $VERSION_FILE | grep -o '[0-9]\+')
PATCH=$(grep "VERSION_PATCH" $VERSION_FILE | grep -o '[0-9]\+')
# Construct the version string
VERSION="$MAJOR.$MINOR.$PATCH"
# Validate format: xx.xx.xx where each x is a digit
if ! [[ "$VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
echo "Error: Extracted version '$VERSION' does not match required format (xx.xx.xx)"
exit 1
fi
rm -rf tmp
echo "VERSION=$VERSION" >> $GITHUB_OUTPUT
echo "Extracted Version: $VERSION"
- name: Update files with new version ${{ steps.extract-version.outputs.VERSION }}
id: update-files
run: |
VERSION="${{ steps.extract-version.outputs.VERSION }}"
# Define the files to update
DAV_FILE="apps/dav/lib/Connector/Sabre/BlockLegacyClientPlugin.php"
CONFIG_FILE="config/config.sample.php"
# Check if files exist
if [ ! -f "$DAV_FILE" ]; then
echo "Error: DAV file not found at $DAV_FILE"
exit 1
fi
if [ ! -f "$CONFIG_FILE" ]; then
echo "Error: Config file not found at $CONFIG_FILE"
exit 1
fi
# Update the DAV file - replace the version in the specific line
sed -i "s/\('minimum\.supported\.desktop\.version', '\)[0-9]\+\.[0-9]\+\.[0-9]\+'/\1$VERSION'/g" "$DAV_FILE"
echo "Updated $DAV_FILE"
# Update the config sample file
PREV_VERSION=$(grep "'minimum.supported.desktop.version'" "$CONFIG_FILE" | grep -o '[0-9]\+\.[0-9]\+\.[0-9]\+')
sed -i "s/Defaults to \`\`$PREV_VERSION\`\`/Defaults to \`\`$VERSION\`\`/" "$CONFIG_FILE"
sed -i "s/'minimum\.supported\.desktop\.version' => '[0-9]\+\.[0-9]\+\.[0-9]\+'/'minimum.supported.desktop.version' => '$VERSION'/g" "$CONFIG_FILE"
echo "Updated $CONFIG_FILE"
# Check if any changes were made
if [ -n "$(git diff "$DAV_FILE" "$CONFIG_FILE")" ]; then
echo "CHANGES_MADE=true" >> $GITHUB_OUTPUT
echo "Changes were made to the files"
git diff "$DAV_FILE" "$CONFIG_FILE"
else
echo "CHANGES_MADE=false" >> $GITHUB_OUTPUT
echo "No changes were needed (versions might already be up to date)"
fi
- name: Create Pull Request
uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0
if: steps.update-files.outputs.CHANGES_MADE == 'true'
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
commit-message: "chore: Update minimum supported desktop version"
committer: GitHub <noreply@github.com>
author: nextcloud-command <nextcloud-command@users.noreply.github.com>
signoff: true
branch: "automated/noid/${{ matrix.branches }}-update-min-supported-desktop-version"
title: "chore: Update minimum supported desktop version to ${{ steps.extract-version.outputs.VERSION }}"
base: "master"
body: |
Auto-generated update of the minimum supported desktop version using last supported version.
https://github.com/nextcloud/desktop/blob/@%7B5.years.ago%7D/VERSION.cmake
labels: |
client: 💻 desktop
automated
3. to review
reviewers: '@nextcloud/desktop'
@@ -1,69 +0,0 @@
# SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Update PRs titles on stable branches
on:
pull_request:
types: [opened, edited]
branches:
- "stable*"
concurrency:
group: stable-pr-title-${{ github.event.pull_request.number }}
cancel-in-progress: true
jobs:
update-pr-title:
runs-on: ubuntu-latest-low
permissions:
pull-requests: write
contents: read
steps:
- name: Wait for potential title edits
run: sleep 15
- name: Get PR details and update title
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const { data: pr } = await github.rest.pulls.get({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.issue.number,
});
const baseBranch = pr.base.ref;
const currentTitle = pr.title;
// Check if this is a stable branch
// Should not happen as we only trigger on stable* branches 🤷‍♀️
if (!baseBranch.startsWith('stable')) {
console.log(`Not a stable branch: ${baseBranch}`);
return;
}
const prefix = `[${baseBranch}]`;
// Check if title already has the correct prefix and no other stable tags
const correctTagRegex = new RegExp(`^\\[${baseBranch}\\]\\s*`);
const hasOtherStableTags = /\[stable[\d.]*\]/.test(currentTitle.replace(correctTagRegex, ''));
if (correctTagRegex.test(currentTitle) && !hasOtherStableTags) {
console.log(`Title already has correct prefix only: ${currentTitle}`);
return;
}
// Remove all stable tags and add the correct one
const cleanTitle = currentTitle.replace(/\[stable[\d.]*\]\s*/g, '').trim();
const newTitle = `${prefix} ${cleanTitle}`;
console.log(`Updating title from: "${currentTitle}" to: "${newTitle}"`);
await github.rest.pulls.update({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.issue.number,
title: newTitle,
});
+11 -31
View File
@@ -1,7 +1,3 @@
# SPDX-FileCopyrightText: 2016-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-FileCopyrightText: 2011-2016 ownCloud contributors
# SPDX-FileCopyrightText: 2010 ownCloud contributors
# SPDX-License-Identifier: AGPL-3.0-only
# the default generated dir + db file
/data
/config/config.php
@@ -11,12 +7,13 @@
/apps/inc.php
/assets
/.htaccess
node_modules/
/node_modules
/translationfiles
/translationtool.phar
# ignore all apps except core ones
/apps*/*
!/apps/accessibility
!/apps/cloud_federation_api
!/apps/comments
!/apps/contactsinteraction
@@ -28,14 +25,12 @@ node_modules/
!/apps/sharebymail
!/apps/encryption
!/apps/files_external
!/apps/files_reminders
!/apps/files_sharing
!/apps/files_trashbin
!/apps/files_versions
!/apps/lookup_server_connector
!/apps/user_ldap
!/apps/oauth2
!/apps/profile
!/apps/provisioning_api
!/apps/settings
!/apps/systemtags
@@ -46,7 +41,6 @@ node_modules/
!/apps/twofactor_backupcodes
!/apps/user_status
!/apps/weather_status
!/apps/webhook_listeners
!/apps/workflowengine
/apps/files_external/3rdparty/irodsphp/PHPUnitTest
/apps/files_external/3rdparty/irodsphp/web
@@ -55,14 +49,15 @@ node_modules/
/apps/files_external/3rdparty/irodsphp/prods/test*
/apps/files_external/tests/config.*.php
# apps modules
/apps/*/node_modules
# ignore themes except the example and the README
/themes/*
!/themes/example
!/themes/README
# Love to people that develop the updater
/updater
# just sane ignores
.*.sw[po]
*.bak
@@ -79,7 +74,6 @@ CVS/*
RCS/*
*.backup*
.php_cs.cache
.php-cs-fixer.cache
# kdevelop
.kdev
@@ -102,7 +96,6 @@ nbproject
# vscode
.vscode
*.code-workspace
# geany
*.geany
@@ -127,13 +120,16 @@ nbproject
# Tests
/tests/phpunit.xml
# Node Modules
/build/node_modules/
# nodejs
/build/bin
/build/lib/
/build/integration/output/
/build/integration/phpserver.log
/build/jsdocs/
/npm-debug.log
/PhantomJS_*
/build/package-lock.json
# puphpet
puphpet
@@ -144,8 +140,6 @@ Vagrantfile
# Tests - auto-generated files
/data-autotest
/results.sarif
/tests/.phpunit.cache
/tests/.phpunit.result.cache
/tests/coverage*
/tests/css
@@ -160,22 +154,8 @@ Vagrantfile
/config/config-autotest-backup.php
/config/autoconfig.php
clover.xml
/coverage
# Tests - dependencies
tests/acceptance/vendor/
composer.phar
/lib/composer/bin
/lib/composer/bamarni
/vendor-bin/**/vendor
./.htaccess
core/js/mimetypelist.js
# Tests - cypress
cypress/downloads
cypress/snapshots
cypress/videos
/.direnv
-3
View File
@@ -1,6 +1,3 @@
# SPDX-FileCopyrightText: 2016 Nextcloud GmbH and Nextcloud contributors
# SPDX-FileCopyrightText: 2016 ownCloud, Inc.
# SPDX-License-Identifier: AGPL-3.0-only
[submodule "3rdparty"]
path = 3rdparty
url = https://github.com/nextcloud/3rdparty.git
+73 -188
View File
@@ -1,201 +1,86 @@
<IfModule mod_headers.c>
<IfModule mod_setenvif.c>
<IfModule mod_fcgid.c>
SetEnvIfNoCase ^Authorization$ "(.+)" XAUTHORIZATION=$1
RequestHeader set XAuthorization %{XAUTHORIZATION}e env=XAUTHORIZATION
</IfModule>
<IfModule mod_proxy_fcgi.c>
SetEnvIfNoCase Authorization "(.+)" HTTP_AUTHORIZATION=$1
</IfModule>
<IfModule mod_lsapi.c>
SetEnvIfNoCase ^Authorization$ "(.+)" XAUTHORIZATION=$1
RequestHeader set XAuthorization %{XAUTHORIZATION}e env=XAUTHORIZATION
</IfModule>
<IfModule mod_setenvif.c>
<IfModule mod_fcgid.c>
SetEnvIfNoCase ^Authorization$ "(.+)" XAUTHORIZATION=$1
RequestHeader set XAuthorization %{XAUTHORIZATION}e env=XAUTHORIZATION
</IfModule>
<IfModule mod_env.c>
# Add security and privacy related headers
# Avoid doubled headers by unsetting headers in "onsuccess" table,
# then add headers to "always" table: https://github.com/nextcloud/server/pull/19002
<If "%{REQUEST_URI} =~ m#/login$#">
# Only on the login page we need any Origin or Referer header set.
Header onsuccess unset Referrer-Policy
Header always set Referrer-Policy "same-origin"
</If>
<Else>
Header onsuccess unset Referrer-Policy
Header always set Referrer-Policy "no-referrer"
</Else>
Header onsuccess unset X-Content-Type-Options
Header always set X-Content-Type-Options "nosniff"
Header onsuccess unset X-Frame-Options
Header always set X-Frame-Options "SAMEORIGIN"
Header onsuccess unset X-Permitted-Cross-Domain-Policies
Header always set X-Permitted-Cross-Domain-Policies "none"
Header onsuccess unset X-Robots-Tag
Header always set X-Robots-Tag "noindex, nofollow"
SetEnv modHeadersAvailable true
<IfModule mod_proxy_fcgi.c>
SetEnvIfNoCase Authorization "(.+)" HTTP_AUTHORIZATION=$1
</IfModule>
</IfModule>
# Add cache control for static resources
<FilesMatch "\.(css|js|mjs|svg|gif|png|jpg|webp|ico|wasm|tflite)$">
<If "%{QUERY_STRING} =~ /(^|&)v=/">
Header set Cache-Control "max-age=15778463, immutable"
</If>
<Else>
Header set Cache-Control "max-age=15778463"
</Else>
</FilesMatch>
<IfModule mod_env.c>
# Add security and privacy related headers
# Let browsers cache OTF and WOFF files for a week
<FilesMatch "\.(otf|woff2?)$">
Header set Cache-Control "max-age=604800"
</FilesMatch>
# Avoid doubled headers by unsetting headers in "onsuccess" table,
# then add headers to "always" table: https://github.com/nextcloud/server/pull/19002
Header onsuccess unset Referrer-Policy
Header always set Referrer-Policy "no-referrer"
Header onsuccess unset X-Content-Type-Options
Header always set X-Content-Type-Options "nosniff"
Header onsuccess unset X-Download-Options
Header always set X-Download-Options "noopen"
Header onsuccess unset X-Frame-Options
Header always set X-Frame-Options "SAMEORIGIN"
Header onsuccess unset X-Permitted-Cross-Domain-Policies
Header always set X-Permitted-Cross-Domain-Policies "none"
Header onsuccess unset X-Robots-Tag
Header always set X-Robots-Tag "none"
Header onsuccess unset X-XSS-Protection
Header always set X-XSS-Protection "1; mode=block"
SetEnv modHeadersAvailable true
</IfModule>
# Add cache control for static resources
<FilesMatch "\.(css|js|svg|gif|png|jpg|ico)$">
Header set Cache-Control "max-age=15778463"
</FilesMatch>
# Let browsers cache WOFF files for a week
<FilesMatch "\.woff2?$">
Header set Cache-Control "max-age=604800"
</FilesMatch>
</IfModule>
<IfModule mod_php.c>
php_value default_charset 'UTF-8'
php_value output_buffering 0
<IfModule mod_env.c>
SetEnv htaccessWorking true
</IfModule>
<IfModule mod_php7.c>
php_value mbstring.func_overload 0
php_value default_charset 'UTF-8'
php_value output_buffering 0
<IfModule mod_env.c>
SetEnv htaccessWorking true
</IfModule>
</IfModule>
<IfModule mod_mime.c>
AddType image/svg+xml svg svgz
AddType application/wasm wasm
AddEncoding gzip svgz
# Serve ESM javascript files (.mjs) with correct mime type
AddType text/javascript js mjs
</IfModule>
<IfModule mod_dir.c>
DirectoryIndex index.php index.html
</IfModule>
<IfModule pagespeed_module>
ModPagespeed Off
</IfModule>
#############
#### Rewrites
#############
<IfModule mod_rewrite.c>
RewriteEngine on
##
## Rule: Workaround for WebDAV with apache+php-cgi
##
## Context:
## - Sets the environment variable `HTTP_AUTHORIZATION` to the value of the `Authorization` request header
## - Always executed before and along with other rules (no `L` used)
## - XXX: *May* be replaced with an equivalent SetEnvIf in theory
## - XXX: SetEnvIf approach is already in use above for mod_proxy_cgi / mod_lsapi / mod_fcgid
##
RewriteRule .* - [env=HTTP_AUTHORIZATION:%{HTTP:Authorization}]
##
## Rule: Workaround for WebDAV with MS DavClnt
##
## Context:
## - DavClnt attempts an OPTIONS request against `/` instead of the specified endpoint
## - Redirects the client to the endpoint rather than the login page (which confuses DavClnt)
##
RewriteCond %{HTTP_USER_AGENT} DavClnt
RewriteRule ^$ /remote.php/webdav/ [L,R=302]
##
## Rule: Map the RFC 8615 / RFC 6764 compliant well-known URI for CardDAV to our Remote DAV endpoint
##
RewriteRule ^\.well-known/carddav /remote.php/dav/ [R=301,L]
##
## Rule: Map the RFC 8615 / RFC 6764 compliant well-known URI for CalDAV to our Remote DAV endpoint
##
RewriteRule ^\.well-known/caldav /remote.php/dav/ [R=301,L]
##
## Rule: Map /remote* --> /remote.php* including the query string
##
## Context:
## - XXX: `QSA` seems unnecessary (no-op) here (query string is passed by default when the replacement URI doesn't contain a query string)
## - XXX: Is this even used anymore? Seems a relic from <NC12
##
RewriteRule ^remote/(.*) remote.php [QSA,L]
##
## Rule: Prevent access to non-public files
##
RewriteRule ^(?:build|tests|config|lib|3rdparty|templates)/.* - [R=404,L]
##
## Rule: Maps most RFC 8615 compliant well-known URIs to our main frontend controller (/index.php) by default
##
## Context:
## - Intentionally excludes URIs used for HTTPS certificate verifications
## - RFC 8555 / ACME HTTP Challenges (acme-challenge)
## - File-based Validations (pki-validation)
## - XXX: `QSA` seems unnecessary (no-op) here (query string is passed by default when the replacement URI doesn't contain a query string)
## - XXX: Sometimes we are using `/index.php` and other times `index.php` as our replacement URI; this may be incorrect
##
RewriteRule ^\.well-known/(?!acme-challenge|pki-validation) /index.php [QSA,L]
##
## Rule: Map the ocm-provider handling to our main frontend controller (/index.php)
##
## Context:
## - XXX: `QSA` seems unnecessary (no-op) here (query string is passed by default when the replacement URI doesn't contain a query string)
## - XXX: Sometimes we are using `/index.php` and other times `index.php` as our replacement URI; this may be incorrect
##
RewriteRule ^ocm-provider/?$ index.php [QSA,L]
##
## Rule: Prevent access to more non-public files
##
## Context:
## - XXX It may make sense to merge some of these with the others (i.e. the ones that don't need to be last)
##
RewriteRule ^(?:\.(?!well-known)|autotest|occ|issue|indie|db_|console).* - [R=404,L]
RewriteEngine on
RewriteCond %{HTTP_USER_AGENT} DavClnt
RewriteRule ^$ /remote.php/webdav/ [L,R=302]
RewriteRule .* - [env=HTTP_AUTHORIZATION:%{HTTP:Authorization}]
RewriteRule ^\.well-known/host-meta /public.php?service=host-meta [QSA,L]
RewriteRule ^\.well-known/host-meta\.json /public.php?service=host-meta-json [QSA,L]
RewriteRule ^\.well-known/webfinger /public.php?service=webfinger [QSA,L]
RewriteRule ^\.well-known/nodeinfo /public.php?service=nodeinfo [QSA,L]
RewriteRule ^\.well-known/carddav /remote.php/dav/ [R=301,L]
RewriteRule ^\.well-known/caldav /remote.php/dav/ [R=301,L]
RewriteRule ^remote/(.*) remote.php [QSA,L]
RewriteRule ^(?:build|tests|config|lib|3rdparty|templates)/.* - [R=404,L]
RewriteCond %{REQUEST_URI} !^/\.well-known/(acme-challenge|pki-validation)/.*
RewriteRule ^(?:\.|autotest|occ|issue|indie|db_|console).* - [R=404,L]
</IfModule>
# Clients like xDavv5 on Android, or Cyberduck, use chunked requests.
# When FastCGI or FPM is used with apache, requests arrive to Nextcloud without any content.
# This leads to the creation of empty files.
# The following directive will force the problematic requests to be buffered before being forwarded to Nextcloud.
# This way, the "Transfer-Encoding" header is removed, the "Content-Length" header is set, and the request content is proxied to Nextcloud.
# Here are more information about the issue:
# - https://docs.cyberduck.io/mountainduck/issues/fastcgi/
# - https://docs.nextcloud.com/server/latest/admin_manual/issues/general_troubleshooting.html#troubleshooting-webdav
<IfModule mod_setenvif.c>
SetEnvIfNoCase Transfer-Encoding "chunked" proxy-sendcl=1
<IfModule mod_mime.c>
AddType image/svg+xml svg svgz
AddEncoding gzip svgz
</IfModule>
# Apache disabled the sending of the server-side content-length header
# in their 2.4.59 patch updated which breaks some use-cases in Nextcloud.
# Setting ap_trust_cgilike_cl allows to bring back the usual behaviour.
# See https://bz.apache.org/bugzilla/show_bug.cgi?id=68973
<IfModule mod_env.c>
SetEnv ap_trust_cgilike_cl
<IfModule mod_dir.c>
DirectoryIndex index.php index.html
</IfModule>
AddDefaultCharset utf-8
Options -Indexes
<IfModule pagespeed_module>
ModPagespeed Off
</IfModule>
-2
View File
@@ -1,2 +0,0 @@
SPDX-FileCopyrightText: 2014 ownCloud, Inc.
SPDX-License-Identifier: AGPL-3.0-only
+1 -2
View File
@@ -1,5 +1,4 @@
{
"esversion": 11,
"camelcase": true,
"eqeqeq": true,
"immed": true,
@@ -12,10 +11,10 @@
"maxparams": 5,
"curly": true,
"jquery": true,
"maxlen": 120,
"indent": 4,
"browser": true,
"laxbreak": true,
"asi": true,
"globals": {
"console": true,
"it": true,
+3 -10
View File
@@ -82,7 +82,6 @@ Dan Callahan <dan.callahan@gmail.com>
Dan Jones <dan@danneh.org>
Daniel <daniel@mars.(none)>
Daniel Hansson <enoch85@gmail.com>
Daniel Kesselberg <mail@danielkesselberg.de> kesselb <mail@danielkesselberg.de>
Daniel Köb <daniel.koeb@peony.at>
Daniel Molkentin <daniel@molkentin.de>
Daniele E. Domenichelli <daniele.domenichelli@gmail.com>
@@ -165,7 +164,6 @@ ideaship <ideaship@users.noreply.github.com>
Ignacio Daniel Rostagno <ignaciorostagno@vijona.com.ar>
infoneo <infoneo@yahoo.pl>
Insanemal <insanemal@gmail.com>
Tobias Perschon <tobias@perschon.at> Tobias Perschon <tofuSCHNITZEL@users.noreply.github.com>
Tobias Ramforth <tobias@ramforth.com> Tobias Ramforth <tobias.ramforth@udo.edu>
Tobias Ramforth <tobias@ramforth.com> irgsmirx <tobias.ramforth@udo.edu>
Isaac Rosenberg <irosenb7@gmail.com>
@@ -215,7 +213,6 @@ Lennart Rosam <lennart.rosam@medien-systempartner.de>
Sebastian Döll <sebastian.doell@libasys.de> libasys <sebastian.doell@libasys.de>
Lode Hoste <zillode@zillode.be>
lolozere <laurent@chedanne.pro>
Louis Chemineau <louis@chmn.me> Louis Chemineau <6653109+artonge@users.noreply.github.com>
Lorenzo M. Catucci <lorenzo@sancho.ccd.uniroma2.it>
Lukas Reschke <lukas@statuscode.ch> Lukas Reschke <lukas@owncloud.com>
Lukas Reschke <lukas@statuscode.ch> Lukas Reschke <lukas@owncloud.org>
@@ -252,7 +249,6 @@ Michael Monreal <michael.monreal@gmail.com>
Michael Roitzsch <reactorcontrol@icloud.com>
michag86 <micha_g@arcor.de>
Michiel de Jong <michiel@unhosted.org> Michiel@unhosted <michiel@unhosted.org>
Micke Nordin <kano@sunet.se> Mikael Nordin <mickenordin@users.noreply.github.com>
Miguel Prokop <miguel.prokop@vtu.com>
miicha <pfitzner@physik.hu-berlin.de>
Miquel Rodríguez Telep / Michael Rodríguez-Torrent <miquel@designunbound.co.uk>
@@ -361,8 +357,7 @@ Simon Birnbach <simon@simon-birnbach.de>
Simon Könnecke <simonkoennecke@gmail.com>
Simon Whittaker <simon@swbh.net>
Sjors van der Pluijm <sjors@desjors.nl> Sjors van der Pluijm <sjors@youngguns.nl>
John Molakvoæ <skjnldsv@protonmail.com> John Molakvoæ <skjnldsv@users.noreply.github.com>
John Molakvoæ <skjnldsv@protonmail.com> John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> John Molakvoæ <skjnldsv@users.noreply.github.com>
st3so <st3so@server.fake>
Stefan <mu.stefan@googlemail.com>
Stefan Göckeritz <admin@s-goecker.de>
@@ -386,7 +381,6 @@ TheSFReader <TheSFReader@gmail.com>
Thibaut GRIDEL <tgridel@free.fr>
thomas <thomas@thomas-VirtualBox.(none)>
Thomas Citharel <nextcloud@tcit.fr> Thomas Citharel <tcit@tcit.fr>
Thomas Citharel <nextcloud@tcit.fr> Thomas Citharel <github@tcit.fr>
Thomas Müller <thomas.mueller@tmit.eu> Thomas Mueller <thomas.mueller@tmit.eu>
Thomas Müller <thomas.mueller@tmit.eu> Thomas Müller <DeepDiver1975@users.noreply.github.com>
Thomas Olsen <tol@tanghus>
@@ -412,9 +406,8 @@ Victor Dubiniuk <dubiniuk@owncloud.com> Victor Dubiniuk <victor.dubiniuk@gmail.c
Victor Dubiniuk <dubiniuk@owncloud.com> VicDeo <dubiniuk@owncloud.com>
Victor Dubiniuk <dubiniuk@owncloud.com> VicDeo <victor.dubiniuk@gmail.com>
Vincent Cloutier <vincent1cloutier@gmail.com>
Vincent Petry <vincent@nextcloud.com> Vincent Petry <PVince81@yahoo.fr>
Vincent Petry <vincent@nextcloud.com> Vincent Petry <vincent@vvortex.site>
Vincent Petry <vincent@nextcloud.com> Vincent Petry <pvince81@owncloud.com>
Vincent Petry <pvince81@owncloud.com> Vincent Petry <PVince81@yahoo.fr>
Vincent Petry <pvince81@owncloud.com> Vincent Petry <vincent@vvortex.site>
Vinicius Cubas Brand <vinicius@eita.org.br> Vinicius Cubas Brand <viniciuscb@gmail.com>
Vitaly Kuznetsov <vitty@altlinux.ru>
Vladimir Sapronov <vladimir.sapronov@gmail.com>
-29
View File
@@ -1,29 +0,0 @@
# SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-only
# Files removed at build time
# Global exclude
.editorconfig
.git
.git-blame-ignore-revs
.gitattributes
.github
.gitignore
.gitmodules
.idea
.l10nignore
.nextcloudignore
.noopenapi
.tx
cypress
tests
# Server specific
/.devcontainer
/__mocks__
/__tests__
/autotest*.sh
/build
/config/config.php
/contribute
/data
-1
View File
@@ -1 +0,0 @@
**/*.spec.js

Some files were not shown because too many files have changed in this diff Show More