Compare commits

..

1587 Commits

Author SHA1 Message Date
Joas Schilling 23427bfea8 Merge pull request #59181 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2026-03-25 07:36:29 +01:00
nextcloud-command 588160c811 fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2026-03-25 03:12:19 +00:00
Joas Schilling 1d3f3ab521 Merge pull request #59102 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] fix(security): Update CA certificate bundle
2026-03-20 07:44:45 +01:00
nextcloud-command 4572faf6a5 fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2026-03-20 03:07:41 +00:00
Stephan Orbaugh 21f5bdfe9e Merge pull request #59071 from nextcloud/backport/59069/stable24 2026-03-19 18:17:51 +01:00
Côme Chilliet dd8a55b717 fix: Add missing Attribute and fix parameter type in renewpassword route
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-03-19 10:33:02 +00:00
Joas Schilling c5ecd114e6 Merge pull request #58034 from nextcloud/ci/stable24-pin-actions
[stable24] pin actions
2026-02-04 10:26:16 +01:00
Andy Scherzinger 01aebd6809 ci: Pin actions
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2026-02-04 09:53:05 +01:00
Joas Schilling b68ae7ea4c Merge pull request #57947 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2026-01-31 11:18:30 +01:00
nextcloud-command 899ebd4279 fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2026-01-31 03:37:01 +00:00
Joas Schilling ee948013f1 Merge pull request #57383 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2026-01-06 21:54:28 +01:00
nextcloud-command f5f7cb586b fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2026-01-06 15:42:42 +00:00
Joas Schilling e23147e696 Merge pull request #57261 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2025-12-27 12:45:44 +01:00
nextcloud-command c1a2d68caa fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2025-12-27 02:53:10 +00:00
Joas Schilling 9f07221959 Merge pull request #57025 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2025-12-12 07:47:13 +01:00
nextcloud-command 9c5f4f0508 fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2025-12-12 02:43:37 +00:00
Joas Schilling 9d222c0bc7 Merge pull request #56999 from nextcloud/bugfix/noid/disable-old-cert-test
[stable24] test: Disable old cert test
2025-12-11 13:46:40 +01:00
Joas Schilling fd90ed1567 ci(node): Don't download Puppeteer
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-12-11 12:09:48 +01:00
Joas Schilling 0765f8c31c ci: Try updating composer
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-12-11 11:08:35 +01:00
Joas Schilling 7d0f3468f4 Merge pull request #56993 from nextcloud/backport/56982/stable24
[stable24] fix(comments): Check comment object
2025-12-11 10:53:24 +01:00
Joas Schilling 971132d734 test: Disable old cert test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-12-11 10:35:46 +01:00
Joas Schilling c0bd7299fb fix(comments): Check comment object
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-12-11 09:00:10 +01:00
Joas Schilling 5607b54631 Merge pull request #56805 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] fix(security): Update CA certificate bundle
2025-12-03 05:55:21 +01:00
nextcloud-command c4101986c9 fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2025-12-03 02:40:53 +00:00
Joas Schilling 3005dbdbab Merge pull request #56364 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2025-11-11 08:18:55 +01:00
nextcloud-command 9c906b1c9a fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2025-11-11 02:39:53 +00:00
Joas Schilling eefe097a8a Merge pull request #56201 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] fix(security): Update CA certificate bundle
2025-11-05 08:27:05 +01:00
nextcloud-command 5c6bb945c0 fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2025-11-05 02:39:00 +00:00
Joas Schilling f562c42d55 Merge pull request #55453 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2025-10-01 09:39:17 +02:00
nextcloud-command ce9b8a3671 fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2025-10-01 02:39:26 +00:00
Matthieu Gallien f09e7fa3b2 Merge pull request #55057 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2025-09-11 17:15:59 +02:00
nextcloud-command d02086843a fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2025-09-11 15:04:53 +00:00
Andy Scherzinger 842f95650b Merge pull request #54983 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] fix(security): Update CA certificate bundle
2025-09-10 15:09:52 +02:00
nextcloud-command f623c36650 fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2025-09-10 02:32:16 +00:00
Benjamin Gaussorgues 50dcd502cc Merge pull request #54389 from nextcloud/automated/noid/stable24-update-ca-cert-bundle 2025-08-14 10:31:24 +02:00
nextcloud-command 76bd4b5fcd fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2025-08-13 02:40:29 +00:00
Matthieu Gallien 18cd925d66 Merge pull request #54289 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2025-08-06 17:05:47 +02:00
nextcloud-command 0f4565c7f3 fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2025-08-06 14:57:37 +00:00
Joas Schilling 03800bd9bc Merge pull request #53953 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] fix(security): Update CA certificate bundle
2025-07-16 06:45:15 +02:00
nextcloud-command 89ac70e9e6 fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2025-07-16 02:44:57 +00:00
Matthieu Gallien 3668dd3fd0 Merge pull request #53809 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2025-07-03 17:36:14 +02:00
nextcloud-command bf12ff0757 fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2025-07-03 15:33:12 +00:00
Joas Schilling 19191887ca Merge pull request #53329 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2025-06-05 09:54:24 +02:00
nextcloud-command 1b6ed33a73 fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2025-06-05 02:39:49 +00:00
Matthieu Gallien 3b113962c2 Merge pull request #53190 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2025-05-30 09:00:31 +02:00
nextcloud-command fb04a60f89 fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2025-05-30 02:38:53 +00:00
Joas Schilling 06a499c203 Merge pull request #53059 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2025-05-23 09:23:44 +02:00
nextcloud-command 7db6cfd370 fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2025-05-23 02:38:54 +00:00
Joas Schilling dd49a5923b Merge pull request #53010 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] fix(security): Update CA certificate bundle
2025-05-21 07:48:29 +02:00
nextcloud-command a31336eeda fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2025-05-21 02:37:28 +00:00
Joas Schilling 39c066d7dd Merge pull request #52106 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2025-04-11 12:29:33 +02:00
nextcloud-command 6456793a98 fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2025-04-11 02:36:31 +00:00
Joas Schilling c2801337e2 Merge pull request #52022 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2025-04-08 10:34:28 +02:00
nextcloud-command be243c4d1e fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2025-04-08 08:27:26 +00:00
Joas Schilling 1e5b28529d Merge pull request #51966 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2025-04-07 07:59:29 +02:00
nextcloud-command 590685deef fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2025-04-05 02:34:17 +00:00
Arthur Schiwon c2fca998f4 Merge pull request #51424 from nextcloud/backport/51407/stable24
[stable24] fix(lookup-server): disable when not using global scale
2025-03-13 17:07:38 +01:00
Ferdinand Thiessen 97e29cc618 fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-13 14:55:01 +01:00
Ferdinand Thiessen b0f0a45871 fix(lookup-server): do not query data by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-12 15:19:28 +01:00
Ferdinand Thiessen 163b00f9af fix(lookup-server): do not upload data by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-12 15:19:28 +01:00
Joas Schilling bb73ec2f51 Merge pull request #51036 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] fix(security): Update CA certificate bundle
2025-02-26 08:52:53 +01:00
nextcloud-command 7442e804fa fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2025-02-26 02:31:02 +00:00
Joas Schilling 786cd56a8f Merge pull request #50380 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2025-01-24 11:03:05 +01:00
nextcloud-command b8f8ef7311 fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2025-01-24 02:27:43 +00:00
Joas Schilling 1f7360e7c7 Merge pull request #49998 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] fix(security): Update CA certificate bundle
2025-01-01 09:35:11 +01:00
nextcloud-command 6dd0074e38 fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2025-01-01 02:33:09 +00:00
Joas Schilling 862a3b8b01 Merge pull request #49505 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] fix(security): Update CA certificate bundle
2024-11-27 06:48:14 +01:00
nextcloud-command 1fce9bd571 fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2024-11-27 02:34:20 +00:00
Joas Schilling 9323251d39 Merge pull request #48777 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2024-10-19 08:25:02 +02:00
nextcloud-command a8b527794a fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2024-10-19 02:29:18 +00:00
Joas Schilling e7f8a30c06 Merge pull request #48335 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] fix(security): Update CA certificate bundle
2024-09-25 07:03:16 +02:00
nextcloud-command c996c34a45 fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2024-09-25 02:30:55 +00:00
Joas Schilling c7b69ff6bb Merge pull request #48288 from nextcloud/backport/48282/stable24
[stable24] chore: add .git-blame-ignore-revs
2024-09-23 14:43:34 +02:00
Daniel Kesselberg 7c7d2b0798 chore: add .git-blame-ignore-revs
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-23 11:50:47 +00:00
Arthur Schiwon 0d67331891 Merge pull request #46612 from nextcloud/backport/42892/stable24
[stable24] fix undefined method getExtStorageHome()
2024-07-31 14:00:16 +02:00
Arthur Schiwon bfacdd3a8d fix undefined method getExtStorageHome()
- adds a type check
- defines missing method in OfflineUser

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-07-18 13:40:26 +00:00
Joas Schilling 32709333f3 Merge pull request #46406 from nextcloud/backport/46388/stable24
[stable24] fix(workflows): Fix file systemtag cache
2024-07-11 09:25:23 +02:00
Joas Schilling e730cc150c fix(workflows): Fix file systemtag cache
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-11 06:57:12 +02:00
Joas Schilling ae4529debd Merge pull request #46260 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] fix(security): Update CA certificate bundle
2024-07-03 08:48:20 +02:00
nextcloud-command fc92f3329d fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2024-07-03 02:19:43 +00:00
Joas Schilling 1e695f85e5 Merge pull request #46177 from nextcloud/bugfix/noid/fix-autoloader-ci
[stable24] fix(autoloader): Generate autoloader with script
2024-07-01 10:22:43 +02:00
Joas Schilling 8504b8d9a5 fix(CI): Fix oracle image and config
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-01 09:15:23 +02:00
Joas Schilling 644f08c491 fix(autoloader): Generate autoloader with script
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-06-27 16:39:14 +02:00
Joas Schilling afa2bbbaaa Merge pull request #46116 from nextcloud/backport/45858/stable24
[stable24] fix(dav): Rate limit address book creation
2024-06-27 16:38:24 +02:00
Joas Schilling d1ac8fdc9b Merge pull request #46156 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2024-06-27 10:06:00 +02:00
nextcloud-command a490c6cc10 fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2024-06-27 02:21:34 +00:00
Hamza Mahjoubi 1d915ba344 fix(dav): Rate limit address book creation
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-06-25 17:20:39 +02:00
Joas Schilling d30b8052a4 Merge pull request #45923 from nextcloud/backport/45912/stable24
[stable24] ci: use precise ref for 3rdparty check
2024-06-19 12:30:17 +02:00
Arthur Schiwon 7fc36a64b2 ci: use precise ref for 3rdparty check
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-06-17 14:33:33 +00:00
Andy Scherzinger 92e2148966 Merge pull request #45780 from nextcloud/backport/45355/stable24
[stable24] fix: delete user credentials stored in storages_credentials when user gets deleted
2024-06-12 09:11:54 +02:00
yemkareems a019ea0e18 fix: cs:fix ran to fix class file in Server.php
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-06-11 17:00:57 +05:30
yemkareems 758e1e0c1b fix: removed avatar deletion related code
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-06-11 14:44:38 +05:30
yemkareems cc2c5590f1 fix: merge conflict resolved and added BeforeUserDeletedListener.php and changed autoload files accordingly along with adding the listener in Server 2024-06-11 14:20:33 +05:30
Arthur Schiwon 98e8cd6068 Merge pull request #45461 from nextcloud/backport/45321/stable24
[stable24] fix: Correctly check result of function
2024-05-23 10:55:03 +02:00
Arthur Schiwon 07adac5949 Merge pull request #45465 from nextcloud/backport/45340/stable24
[stable24] fix: Extend SVG reference check
2024-05-23 10:45:48 +02:00
Joas Schilling 47a671693a fix: Correctly check result of function
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-05-22 17:47:01 +02:00
Joas Schilling 1eabc0da09 fix: Extend SVG reference check
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-05-22 15:28:35 +00:00
Arthur Schiwon 8d725b110f Merge pull request #44560 from nextcloud/artonge/backport/stable24/44339
[stable24] fix(share): use share owner to confirm reshare
2024-04-24 16:15:04 +02:00
Arthur Schiwon af3930b752 Merge pull request #44895 from nextcloud/backport/stable24-fix-ajax-check-public-remote
[stable24] fix(dav): ajax request check on public remote endpoints
2024-04-24 16:12:21 +02:00
Joas Schilling af11616872 Merge pull request #45009 from nextcloud/backport/44892/stable24
[stable24] fix(files): Also skip cross storage move with access control
2024-04-24 14:03:10 +02:00
Joas Schilling dbff2d5d6b fix(CI): Suppress psalm UndefinedClass
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-24 09:30:56 +00:00
Joas Schilling c432e9e7e3 fix(files): Also skip cross storage move with access control
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-24 09:30:56 +00:00
John Molakvoæ 4ef047f362 fix(dav): ajax request check on public remote endpoints
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-04-17 17:13:19 +02:00
Joas Schilling bf5792a841 Merge pull request #44742 from nextcloud/backport/stable24/44736
[stable24] fix: Fix avatar images
2024-04-17 10:38:21 +02:00
Christopher Ng ebfac5f273 test: Update tests
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-04-08 17:11:52 -07:00
Christopher Ng 0b46e80ac2 fix: Fix avatar images
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-04-08 17:11:52 -07:00
Joas Schilling 31c26104e9 Merge pull request #44687 from nextcloud/backport/44678/stable24
[stable24] fix(3rdparty): Add a CI job to check 3rdparty integrity
2024-04-06 15:13:49 +02:00
Joas Schilling 99b53343c2 fix(3rdparty): Add a CI job to check 3rdparty integrity
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-05 15:16:38 +00:00
Maxence Lange 31382209e7 fix(share): use share owner to confirm reshare
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-28 18:46:40 +01:00
Joas Schilling cbff9a3c60 Merge pull request #44479 from nextcloud/backport/44276/stable24
[stable24] fix(config): Make sure user keys are strings
2024-03-28 16:03:51 +01:00
Joas Schilling 069e41aea2 Merge pull request #44519 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2024-03-28 07:49:30 +01:00
nextcloud-command 08dee902fc fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2024-03-28 02:15:22 +00:00
Christoph Wurst ef024d40e0 fix(config): Make sure user keys are strings
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-26 10:14:43 +00:00
Andy Scherzinger ce431b9d1a Merge pull request #44324 from nextcloud/backport/44309/stable24
[stable24] Forbid tagging readonly files
2024-03-21 12:42:41 +01:00
Côme Chilliet 5dd565dbc0 chore: Remove PHP8 constructor property promotions
25 supports 7.4

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 14:34:18 +00:00
Côme Chilliet e7b3b5e7eb fix(dav): Add missing use for OCP\Constants
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 14:34:18 +00:00
Côme Chilliet fce259127f chore: Break closure call on two lines to make it readable
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 14:34:18 +00:00
Côme Chilliet 3291984903 fix(systemtags): Forbid tagging of readonly files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 14:34:18 +00:00
John Molakvoæ 7015279f27 Merge pull request #43856 from nextcloud/backport/43787/stable24 2024-03-15 17:20:12 +01:00
Joas Schilling 54ce4f5166 Merge pull request #44143 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] fix(security): Update CA certificate bundle
2024-03-12 08:03:53 +01:00
nextcloud-command 4e3de6f96b fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2024-03-12 02:11:07 +00:00
Julius Härtl 024b626b14 fix: Throw instead of yielding nothing when listing local directories
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Max <max@nextcloud.com>
2024-03-07 15:18:37 +01:00
John Molakvoæ dfbddcc22f Merge pull request #43891 from nextcloud/backport/43599/stable24 2024-02-29 08:47:56 +01:00
John Molakvoæ 3f79eb1c12 Merge pull request #43782 from nextcloud/backport/43753/stable24 2024-02-29 08:47:26 +01:00
John Molakvoæ 6be02894bb Merge pull request #43865 from nextcloud/backport/43859/stable24 2024-02-28 18:23:41 +01:00
Louis Chemineau 06c2af4b02 fix(dav): Init ViewOnlyPlugin after auth
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-02-28 14:38:54 +01:00
John Molakvoæ d7cc59b7e6 Merge pull request #43871 from nextcloud/backport/43727/stable24 2024-02-28 12:52:09 +01:00
Joas Schilling 98c0aa6baf fix: Add bruteforce protection to email endpoint
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-28 11:12:02 +00:00
Christoph Wurst bf6563cbd9 fix(dav): Rate limit calendar/subscription creation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-02-28 11:41:42 +01:00
Louis Chemineau 94501dc4ee Check node permissions when restoring a version
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-02-28 10:18:17 +01:00
Louis Chemineau b1abfbb65f Check share attributes when downloading versions
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-02-28 10:16:35 +01:00
John Molakvoæ efc987a4d7 Merge pull request #43748 from nextcloud/backport/40332/stable24 2024-02-24 12:34:12 +01:00
Côme Chilliet 6e6797b593 Remove modern PHP syntax, and apply codesniffer fixes in Share20/Manager.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-22 08:18:58 +00:00
Côme Chilliet 92862be923 Use nullsafe call syntax instead of additionnal check
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2024-02-22 08:18:58 +00:00
Côme Chilliet da391a550f Fix tests, add test for the new feature
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-22 08:18:58 +00:00
Côme Chilliet 99142a67d8 Set files_sharing:hide_disabled_user_shares to 'yes' to hide shares from disabled users
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-22 08:18:57 +00:00
Joas Schilling b94c1f9a41 Merge pull request #43503 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2024-02-10 13:28:08 +01:00
nextcloud-command b89ae8b0cf fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2024-02-10 02:12:22 +00:00
Matthieu Gallien 28e91012bf Merge pull request #43375 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2024-02-07 09:12:16 +01:00
nextcloud-command 54254ba23f fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2024-02-06 02:12:46 +00:00
Matthieu Gallien ebc317bc2e Merge pull request #43072 from nextcloud/automated/noid/stable24-update-code-signing-crl
[stable24] fix(security): Update code signing revocation list
2024-01-24 08:57:46 +01:00
nextcloud-command c9b2d93a84 fix(security): Update code signing revocation list
Signed-off-by: GitHub <noreply@github.com>
2024-01-24 02:20:03 +00:00
Christoph Wurst 23e0f69676 Merge pull request #42910 from nextcloud/fix/caldav/update-acls-deletedcalendarobjectscollection-stable24
[stable24] fix(CalDAV): set acls for DeletedCalendarObjectsCollection
2024-01-22 17:21:23 +01:00
Johannes Merkel bb69c21f9f fix(CalDAV): set acls for DeletedCalendarObjectsCollection
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2024-01-18 08:42:12 +01:00
Arthur Schiwon e695c8f513 Merge pull request #42878 from nextcloud/backport/42563/stable24
[stable24] Update crl after revoke integration_homeassistant.csr
2024-01-17 14:58:08 +01:00
Matthieu Gallien 93c1b2db7c Update crl after revoke integration_homeassistant.csr
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-01-17 10:33:15 +01:00
Matthieu Gallien 0cf5a4a49c Merge pull request #42396 from nextcloud/backport/42140/stable24
[stable24] Update crl after revoke rides.csr
2023-12-20 15:41:06 +01:00
Matthieu Gallien be5d331611 Update crl after revoke rides.csr
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-12-20 11:14:34 +01:00
Arthur Schiwon d1575453b8 Merge pull request #40817 from nextcloud/automated/noid/stable24-fix-npm-audit
[stable24] Fix npm audit
2023-12-14 10:39:32 +01:00
Joas Schilling 9165e55c00 Merge pull request #42191 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] fix(security): Update CA certificate bundle
2023-12-14 06:52:29 +01:00
nextcloud-command a1c9609c98 fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2023-12-13 02:17:38 +00:00
nextcloud-command 815d7046ed chore(deps): fix npm audit
Signed-off-by: GitHub <noreply@github.com>
2023-12-03 02:52:44 +00:00
Arthur Schiwon b4d6db5a88 Merge pull request #41665 from nextcloud/backport/39285/stable24
[stable24] add command do delete orphan shares
2023-11-23 10:38:12 +01:00
Arthur Schiwon ffb4ddf491 Merge pull request #41322 from nextcloud/backport/39924/stable24
[stable24] fix: Set X-Requested-With header on all requests to avoid browser auth dialogs
2023-11-22 21:54:48 +01:00
Julien Veyssier f0f527dfe8 compile assets
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-11-22 17:02:22 +01:00
Julien Veyssier b642d10f8d fix: Set X-Requested-With header on all requests to avoid browser auth dialogs
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-11-22 16:58:41 +01:00
Robin Appelman 1f8ac97a2d add command do delete orphan shares
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-11-22 14:47:07 +01:00
Arthur Schiwon ba87099a85 Merge pull request #41530 from nextcloud/backport/41526/stable24
[stable24] Reverse X-Forwarded-For list to read the correct proxy remote address
2023-11-16 10:43:33 +01:00
Arthur Schiwon 2dd8861ec0 Merge pull request #41524 from nextcloud/backport/41520/stable24
[stable24] Finish password confirmation
2023-11-16 09:55:00 +01:00
Joas Schilling 2fd3a372f7 Reverse X-Forwarded-For list to read the correct proxy remote address
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-16 07:57:06 +01:00
Joas Schilling fca2d33e0a chore(assets): Recompile JS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-16 07:01:41 +01:00
Joas Schilling 613ba659bf fix(workflows): Finish password confirmation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-16 06:59:17 +01:00
Joas Schilling 82b9a77fe3 Merge pull request #41127 from nextcloud/backport/41123/stable24
[stable24] fix(external): Get storage before update it
2023-10-26 08:25:42 +02:00
Joas Schilling b8136c4c44 fix(external): Get storage before update it
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-26 06:58:50 +02:00
Julius Härtl bef7d10e70 Merge pull request #40382 from nextcloud/backport/38808/stable24 2023-10-10 08:23:47 +02:00
Joas Schilling e867ca0c2e Merge pull request #40386 from nextcloud/backport/36830/stable24
[stable24] fix: Avoid failing with duplicate checks
2023-09-19 15:04:14 +02:00
Julius Härtl 0c8b36aa1f fix: Avoid failing with duplicate checks
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-09-12 15:15:42 +02:00
Julius Härtl 8f3e6c755f fix: Only read unencrypted_size when file is actually encrypted
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-09-12 15:07:56 +02:00
Julius Härtl 20de8f5943 fix: Only store unencrypted_size if path should be encrypted
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-09-12 15:07:56 +02:00
Andy Scherzinger 82ec950912 Merge pull request #40317 from nextcloud/backport/40292/stable24
[stable24] fix(CalDAV): check birthday calendar owner
2023-09-07 10:22:29 +02:00
Arthur Schiwon fa9c7e2a5b Merge pull request #40305 from nextcloud/backport/stable24/40293
[stable24] fix(ratelimit): Only use memory cache backend for redis
2023-09-07 09:15:28 +02:00
Anna Larch 5072edf63e fix(CalDAV): check birthday calendar owner
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-09-07 08:31:45 +02:00
Andy Scherzinger cb038f683b Merge pull request #40219 from nextcloud/automated/noid/stable24-fix-npm-audit
[stable24] Fix npm audit
2023-09-06 18:59:38 +02:00
Joas Schilling 9b25e8d5da fix(ratelimit): Only use memory cache backend for redis
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-09-06 18:30:50 +02:00
Arthur Schiwon 13ea82324b Merge pull request #40262 from nextcloud/backport/40234/stable24
[stable24] enh: skip processing for empty response
2023-09-05 19:32:14 +02:00
Daniel Kesselberg 436526fefa enh: skip processing for empty response
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-05 10:05:56 +02:00
nextcloud-command d7bb3c9acc chore(deps): fix npm audit
Signed-off-by: GitHub <noreply@github.com>
2023-09-03 02:53:30 +00:00
John Molakvoæ 91b4e8491f Merge pull request #40004 from nextcloud/automated/noid/stable24-update-ca-cert-bundle 2023-08-23 08:09:30 +02:00
nextcloud-command 4a610accf3 fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2023-08-23 02:09:58 +00:00
Simon L e1426fcf93 Merge pull request #39541 from nextcloud/automated/noid/stable24-fix-npm-audit
[stable24] Fix npm audit
2023-07-28 00:30:21 +02:00
nextcloud-command a484aca80c chore(deps): fix npm audit
Signed-off-by: GitHub <noreply@github.com>
2023-07-23 02:54:12 +00:00
Arthur Schiwon 7d1893eade Merge pull request #39494 from nextcloud/backport/39490/stable24
[stable24] fix(apps): Fix loading info.xml file
2023-07-20 13:36:17 +02:00
Joas Schilling ba54cb201c fix(apps): Fix loading info.xml file
Ref: https://bugs.php.net/bug.php?id=62577

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-20 10:51:46 +02:00
Joas Schilling 008158c816 Merge pull request #39420 from nextcloud/backport/39416/stable24
[sŧable24] fix(core): Add password confirmation requirement for getapppassword
2023-07-17 17:11:40 +02:00
Joas Schilling 0cf387c613 fix(core): Add password confirmation requirement for getapppassword
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-17 12:13:43 +02:00
Andy Scherzinger 287e518383 Merge pull request #39357 from nextcloud/backport/39323/39323-stable24
[stable24] getStorage before remove
2023-07-13 14:21:36 +02:00
Maxence Lange 8e3d9e7a93 getStorage before remove
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-07-13 10:45:27 -01:00
Andy Scherzinger 5e7ea05266 Merge pull request #39347 from nextcloud/ci/sign-drone-stable24
[stable24] chore(CI): Sign .drone.yml file
2023-07-13 12:49:05 +02:00
Joas Schilling baf1e0d3fa chore(CI): Sign .drone.yml file
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-13 11:53:05 +02:00
Simon L d6c490e39a Merge pull request #38985 from nextcloud/automated/noid/stable24-fix-npm-audit
[stable24] Fix npm audit
2023-07-11 23:31:19 +02:00
nextcloud-command 1e3532441b chore(deps): fix npm audit
Signed-off-by: GitHub <noreply@github.com>
2023-07-11 16:06:58 +00:00
Joas Schilling e65b577b4f Merge pull request #39254 from nextcloud/backport/38046/stable24
[stable24] fix(dav): Abort requests with 429 instead of waiting
2023-07-11 06:43:10 +02:00
Julius Härtl dcca2a487c Merge pull request #39033 from nextcloud/backport/38917/stable24 2023-07-10 18:34:15 +02:00
Joas Schilling 4d40b42a91 fix(psalm): Install apcu, ftp and ldap extension like in static-code-analysis-security
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-10 18:08:55 +02:00
Daniel Kesselberg bdc0f840d7 fix: use handleLoginFailed for invalid email address
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-07-10 14:31:43 +02:00
Joas Schilling 7b6a2a041c fix(dav): Abort requests with 429 instead of waiting
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-10 06:41:26 +02:00
Julien Veyssier 62c7dd0d8c Merge pull request #38901 from nextcloud/backport/38773/stable24
[stable24] Add bruteforce protection in OauthApiController
2023-06-28 23:34:27 +02:00
Julien Veyssier 42e08d683d add bruteforce protection in OauthApiController
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-06-28 20:21:36 +02:00
Joas Schilling 66cf085767 fix(l10n): Fix plural issue with different locale and language
We need to use the language code here instead of the locale,
because Symfony does not distinguish between the two and would
otherwise e.g. with locale "Czech" and language "German" try to
pick a non-existing plural rule, because Czech has 4 plural forms
and German only 2.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-27 14:20:49 +02:00
Arthur Schiwon 603d464be8 Merge pull request #38937 from nextcloud/backport/37709/stable24
[stable24] fix: Check for wrapped retriable exceptions to handle deadlocks
2023-06-22 11:42:22 +02:00
Julius Härtl 72cb434e8d fix: Check for wrapped retriable exceptions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-06-21 19:22:31 +00:00
Côme Chilliet a7dc41fb5e Merge pull request #38584 from nextcloud/backport/38206/stable24
[stable24] Increase from 100000 to 600000 iterations for hash_pbkdf2
2023-06-20 17:46:29 +02:00
Côme Chilliet 038c93ebe3 Adapt encryption test to change in generateHeader
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-06-20 10:25:58 +02:00
Côme Chilliet 738d923374 Increase from 100000 to 600000 iterations for hash_pbkdf2
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-06-20 10:24:13 +02:00
Julius Härtl 5f49416424 Merge pull request #38894 from nextcloud/obj-store-copy-list-source-cache-24 2023-06-19 16:56:42 +02:00
Robin Appelman 7895d98bc2 use source cache when listing folder during recursive copy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-06-19 12:29:54 +02:00
Ferdinand Thiessen 935287c75c Merge pull request #38739 from nextcloud/automated/noid/stable24-fix-npm-audit
[stable24] Fix npm audit
2023-06-14 17:24:40 +02:00
nextcloud-command 5d937b5ccb chore(deps): fix npm audit
Signed-off-by: GitHub <noreply@github.com>
2023-06-14 12:16:29 +00:00
Arthur Schiwon 399d0d3d0b Merge pull request #37570 from nextcloud/backport/34375/stable24
[stable24] fix(dav) Handle Calendar trashbin UID conflicts by removing the deleted calendar object
2023-06-12 12:57:44 +02:00
Arthur Schiwon 117a33d6c9 Merge pull request #38592 from nextcloud/backport/38355/stable24
[stable24] fix(trashbin): Truncate long filenames
2023-06-05 17:40:53 +02:00
Arthur Schiwon d4cc8f9571 Merge pull request #38533 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] fix(security): Update CA certificate bundle
2023-06-05 17:36:36 +02:00
nextcloud-command 3840b30274 fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2023-06-04 02:39:17 +00:00
Simon L b862221dd7 Merge pull request #38116 from nextcloud/automated/noid/stable24-fix-npm-audit
[stable24] Fix npm audit
2023-06-03 12:50:31 +02:00
nextcloud-command b52879bfc9 chore(deps): fix npm audit
Signed-off-by: GitHub <noreply@github.com>
2023-06-02 15:24:44 +00:00
Christopher Ng ad1052ddc9 fix(trashbin): Truncate long filenames
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-06-01 18:29:28 +00:00
Nextcloud bot 08758c04e1 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-26 00:18:34 +00:00
Arthur Schiwon 383c8050cc Merge pull request #38462 from nextcloud/fix/read-only-system-addres-book-acls-stable24
[stable24] fix(carddav): Mark system address book as read-only
2023-05-25 16:01:09 +02:00
Arthur Schiwon a63dae5977 Merge pull request #37308 from nextcloud/backport/37006/stable24
[stable24] also unmark deleted ldap user when checking the ldap entry
2023-05-25 12:48:26 +02:00
Arthur Schiwon c7e0cb36af Merge pull request #37455 from nextcloud/backport/36810/stable24
[stable24] do onetime user setup before getting any mount from providers
2023-05-25 12:47:39 +02:00
Arthur Schiwon 0d04ada831 Merge pull request #38072 from nextcloud/backport/37480/stable24
[stable24] fix(ocp): Add deprecation version to ILogFactory::getCustomLogger
2023-05-25 12:40:35 +02:00
Nextcloud bot eddd37d811 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-25 00:20:16 +00:00
Nextcloud bot 76001583bb Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-24 00:18:16 +00:00
Nextcloud bot 46bac95138 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-23 00:17:48 +00:00
Nextcloud bot 65c3ebd089 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-22 00:18:07 +00:00
Nextcloud bot 8cc8d8d357 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-21 00:17:31 +00:00
Nextcloud bot 057cef602c Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-20 00:17:35 +00:00
Nextcloud bot 571353058a Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-19 00:17:43 +00:00
Nextcloud bot f1507eb118 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-18 18:46:55 +00:00
Nextcloud bot c9370f7044 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-18 00:18:14 +00:00
Nextcloud bot a8bdb73c72 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-17 00:17:57 +00:00
Joas Schilling fc3d3bedcf Merge pull request #38277 from nextcloud/backport/38274/stable24
[stable24] fix(middleware): Also abort the request when reaching max delay in af…
2023-05-16 11:31:49 +02:00
Joas Schilling 9c8a373717 Merge pull request #38270 from nextcloud/backport/38267/stable24
[stable24] fix(lostpassword): Also rate limit the setPassword endpoint
2023-05-16 06:35:55 +02:00
Nextcloud bot 27aa0d3a4a Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-16 02:28:50 +00:00
Robin Appelman adc12d1b33 Merge pull request #38283 from nextcloud/session-auth-check-username-24
[24] check the username when doing external storage session auth
2023-05-15 23:49:10 +02:00
Robin Appelman 1efca0406a check the username when doing external storage session auth
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-15 17:05:29 +02:00
Joas Schilling 510fc26600 fix(middleware): Also abort the request when reaching max delay in afterController
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:27:36 +02:00
Joas Schilling 19b7545599 fix(tests): Adjust unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:13:47 +02:00
Joas Schilling 147d523913 fix(lostpassword): Also rate limit the setPassword endpoint
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:02:57 +02:00
Christoph Wurst 4e7f575f91 fix(carddav): Mark system address book as read-only
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-15 10:57:44 +02:00
Nextcloud bot 038c9f2912 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-15 02:28:47 +00:00
Nextcloud bot 581f23685d Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-14 02:28:01 +00:00
Nextcloud bot ba47ffe43f Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-13 02:28:22 +00:00
Nextcloud bot e506623782 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-12 02:28:38 +00:00
Julius Härtl ec89b5c0b1 Merge pull request #38121 from nextcloud/backport/37787/stable24 2023-05-10 09:57:19 +02:00
Nextcloud bot 06c4e94f02 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-10 02:31:51 +00:00
Nextcloud bot 581cb8f4ba Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-09 02:20:15 +00:00
Max b9b862d411 fix: catch ManuallyLockedException and use app context
The files_lock app may throw ManuallyLockedExceptions
when attempting to revert a file that is currently opened.
This would prevent the user from rolling back a opened file.

Text and Richdocuments handle changes of the file while editing.
Allow reverting files even when they are locked by these apps
and let the apps handle the conflict.

Signed-off-by: Max <max@nextcloud.com>
2023-05-08 09:13:41 +02:00
Nextcloud bot 32e7d6acfc Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-08 02:28:34 +00:00
Nextcloud bot d3cff24638 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-07 02:28:40 +00:00
Nextcloud bot 41828fb3fd Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-06 02:28:06 +00:00
Nextcloud bot 2644512109 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-05 02:28:31 +00:00
Christoph Wurst a40f73d67d fix(ocp): Add deprecation version to ILogFactory::getCustomLogger
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-04 09:59:04 -03:00
Arthur Schiwon 93876568f4 Merge pull request #37997 from nextcloud/backport/37909/stable24
[stable24] Update crl after revoke shifts.csr
2023-05-04 10:55:33 +02:00
Nextcloud bot 9a57e18a55 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-04 02:28:32 +00:00
Nextcloud bot ab4719fd26 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-03 02:28:21 +00:00
Nextcloud bot 8c377e02fd Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-02 02:28:07 +00:00
Vitor Mattos d8b81f89ed Update crl after revoke shifts.csr
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-05-01 07:47:08 -03:00
Nextcloud bot af07813a59 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-01 02:29:47 +00:00
Nextcloud bot ec26f34f4d Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-30 02:29:40 +00:00
Simon L 0a3fb6d1c6 Merge pull request #37972 from nextcloud/automated/noid/stable24-fix-npm-audit
[stable24] Fix npm audit
2023-04-29 12:51:38 +02:00
Nextcloud bot 386f9592eb Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-29 02:28:49 +00:00
nextcloud-command 7820389790 chore(deps): fix npm audit
Signed-off-by: GitHub <noreply@github.com>
2023-04-28 17:10:04 +00:00
Nextcloud bot 63622c2a10 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-28 02:29:00 +00:00
Joas Schilling 629177cdad Merge pull request #37843 from nextcloud/bump/guzzle-psr7/stable24
[stable24] sec(deps): Update guzzlehttp/psr7
2023-04-27 09:36:31 +02:00
Louis 20e25e714c Merge pull request #37902 from nextcloud/backport/stable24/artonge/fix/dont_override_stored_credentials_with_saml
[stable24] Do not override stored credentials when login in with SAML
2023-04-27 09:18:14 +02:00
Nextcloud bot 5f7aa0701b Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-27 02:28:58 +00:00
Joas Schilling b107f482f8 sec(deps): Update guzzlehttp/psr7
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-26 15:52:05 +02:00
Louis Chemineau 921ce4a900 Test StorePasswordListener
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-04-26 07:35:40 +00:00
Louis Chemineau a327ad5aef Do not override stored credentials when login in with SAML
When login in with SAML, the password from `$event->getPassword()` is `null`.

This PR makes sure that this `null` value won't be used to override the stored password even though it is different.

This PR also allow for the password and user to be updated even though they were not set before.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-04-26 07:35:40 +00:00
Arthur Schiwon 933359f037 Merge pull request #37920 from nextcloud/backport/stable24/sso-kerberos-fix
[stable24] Update kerberos sso test setup to use new user_saml config system
2023-04-26 09:04:47 +02:00
Nextcloud bot 21df9d391d Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-26 02:28:32 +00:00
Robin Appelman 36c87d669b Update kerberos sso test setup to use new user_saml config system
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-04-25 13:42:24 +02:00
Robin Appelman 693efde1f8 run kerberos sso test when the action is changed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-25 13:42:10 +02:00
Nextcloud bot 03bcc45c00 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-25 02:23:10 +00:00
Nextcloud bot 4559b6a403 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-24 02:29:33 +00:00
Nextcloud bot 1a9ead8eab Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-23 02:29:07 +00:00
Nextcloud bot 1696ae203a Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-22 02:28:34 +00:00
Nextcloud bot 21126bb531 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-21 02:29:05 +00:00
Nextcloud bot 0987e7c8bf Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-20 02:29:39 +00:00
John Molakvoæ 5b79bb15b5 Merge pull request #37784 from nextcloud/release/24.0.12 2023-04-19 18:01:58 +02:00
Nextcloud bot 0102c573d5 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-19 02:28:47 +00:00
John Molakvoæ 84ffe1438b 24.0.12
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-04-18 09:05:37 +02:00
Nextcloud bot dfae9fec53 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-18 02:37:48 +00:00
Nextcloud bot 0160d61086 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-17 02:27:57 +00:00
Nextcloud bot 90a389dd37 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-16 02:28:19 +00:00
Nextcloud bot b676f74cc9 Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-15 02:27:56 +00:00
Robin Appelman f2bd0ab4f5 do onetime user setup before getting any mount from providers
this fixes a race condition where wrappers weren't properly applied if when a mount provider creates the storage instance one mountpoint creation instead of lazily

Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-14 14:23:18 -07:00
Nextcloud bot 4894bf2547 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-14 02:20:07 +00:00
John Molakvoæ a025293e9d Merge pull request #37700 from nextcloud/release/24.0.12_rc1
24.0.12 RC1
2023-04-13 09:16:41 +02:00
John Molakvoæ 0ff17aa91f Merge pull request #37510 from nextcloud/backport/37486/stable24
[stable24] fix default_language doc
2023-04-13 08:19:08 +02:00
John Molakvoæ 701783b130 24.0.12 RC1
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-04-13 08:05:05 +02:00
Nextcloud bot 5d99def28a Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-13 02:28:12 +00:00
Nextcloud bot 0b09dbe38b Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-12 02:28:54 +00:00
Julius Härtl cbe2f8c817 Merge pull request #37668 from nextcloud/backport/37625/stable24 2023-04-11 09:45:46 +02:00
Julius Härtl 2fadf51478 fix: Always create user directory when transfering files to new users
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-11 06:24:27 +00:00
Nextcloud bot 01b8395831 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-11 02:28:46 +00:00
Nextcloud bot 7b0b58cb6e Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-10 02:31:16 +00:00
Nextcloud bot 88c2c1d1d2 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-09 02:27:58 +00:00
Nextcloud bot b0c925ca58 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-08 02:28:09 +00:00
Nextcloud bot 37063d6247 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-07 02:28:55 +00:00
Arthur Schiwon 28d53617ef Merge pull request #37317 from nextcloud/backport/36701/stable24
[stable24] Add parent index on filecache
2023-04-06 17:25:08 +02:00
Louis Chemineau 45e4d590e0 Add parent index on filecache
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-04-06 11:25:20 +00:00
Nextcloud bot 485f338554 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-06 02:29:09 +00:00
Pytal 64f66954d7 Merge pull request #37561 from nextcloud/backport/37497/stable24 2023-04-05 17:40:42 -07:00
Pytal d064cb1854 Merge pull request #37536 from nextcloud/backport/35961/stable24
[stable24] clear encrypted flag when moving away from encrypted storage
2023-04-05 10:42:06 -07:00
Nextcloud bot 22a3623786 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-05 02:30:50 +00:00
Anna Larch 8247afe864 Allow reimporting prev. deleted items by deleting trashbin item
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-04-04 08:25:33 +00:00
Nextcloud bot 0ec7e08bcd Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-04 02:28:51 +00:00
Christopher Ng 4d95ddbfd0 Improve handling of profile fields
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit c2d2ae3c59)
2023-04-03 17:37:47 -07:00
Joas Schilling 422c81948f Merge pull request #37553 from nextcloud/backport/37542/stable24
[stable24] feat(security): Allow to opt-out of ratelimit protection, e.g. for te…
2023-04-03 22:11:17 +02:00
Joas Schilling 0dc8c731c6 fix(backport): Add missing sample config
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-03 15:45:46 +02:00
Joas Schilling 77a956020c feat(security): Allow to opt-out of ratelimit protection, e.g. for testing on CI
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-03 12:48:50 +00:00
Côme Chilliet 24b92b3db5 Merge pull request #37280 from nextcloud/automated/noid/stable24-update-psalm-baseline
[stable24] Update psalm-baseline.xml
2023-04-03 14:48:07 +02:00
Côme Chilliet f8f5bc6f87 Merge pull request #37493 from nextcloud/backport/37448/stable24
[stable24] hide shared files located in group folder's trash bin
2023-04-03 10:55:32 +02:00
nextcloud-command 35b5b3a66c Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2023-04-02 04:51:10 +00:00
Nextcloud bot bd13e97b06 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-02 02:27:29 +00:00
Robin Appelman b93b83c5ee add test for unmarking encrypted file on cross storage move
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-01 16:49:28 +00:00
Robin Appelman 286469a713 clear encrypted flag when moving away from encrypted storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-01 16:49:28 +00:00
Nextcloud bot c332284ae3 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-01 02:27:49 +00:00
Arthur Schiwon 71e20d45b6 fix default_language doc
Since commit 0228bc6e66 the browser
language always is preferred.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-03-31 07:24:54 +00:00
Nextcloud bot 4071b78e99 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-31 02:28:27 +00:00
Arthur Schiwon 3691b8c828 hide shared files located in group folder's trash bin
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-03-30 16:13:46 +00:00
Nextcloud bot 2042371199 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-30 02:28:00 +00:00
Nextcloud bot cfe3b84f2d Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-29 02:28:09 +00:00
Joas Schilling a0e4f92d36 Merge pull request #37443 from nextcloud/backport/37437/stable24
[stable24] fix(docs): Fix RST parsing of the sample config
2023-03-28 15:58:27 +02:00
Joas Schilling 2db7327329 fix(docs): Fix RST parsing of the sample config
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-28 07:37:18 +00:00
Nextcloud bot f76269d3af Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-28 02:19:47 +00:00
Nextcloud bot 7d3e0f1f81 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-27 10:18:41 +00:00
Louis e0bc3b77a3 Merge pull request #37367 from nextcloud/backport/36636/stable24
[stable24] fix OC_Image: Prevent E_WARNING from getimagesize*
2023-03-27 11:51:04 +02:00
Julius Härtl ab5060ff26 Merge pull request #36580 from nextcloud/backport/36509/stable24 2023-03-24 11:56:22 +01:00
Nextcloud bot a778c18842 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-24 02:27:29 +00:00
Marcel Klehr f73ef9731c fix OC_Image: Prevent E_WARNING from getimagesize*
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-03-23 14:18:35 +00:00
Arthur Schiwon 5589071173 Merge pull request #37353 from nextcloud/release/24.0.11
24.0.11
2023-03-23 12:54:02 +01:00
Nextcloud bot a740cc8c9a Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-23 02:27:27 +00:00
Arthur Schiwon 087d95241f 24.0.11
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-03-22 18:05:42 +01:00
Nextcloud bot 12f2406aa2 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-22 02:44:00 +00:00
Nextcloud bot 3b54a608a2 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-21 02:27:43 +00:00
Robin Appelman cde177d54d also unmark deleted ldap user when checking the ldap entry
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-03-20 15:49:08 +00:00
Nextcloud bot a4e1ea8deb Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-20 02:27:42 +00:00
Nextcloud bot 7e32dc13f6 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-19 02:27:51 +00:00
Nextcloud bot ca0e3dc4a5 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-18 02:27:46 +00:00
Nextcloud bot d5e29430f8 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-17 02:27:37 +00:00
Arthur Schiwon 669ba10751 Merge pull request #37204 from nextcloud/release/24.0.11_rc1
24.0.11 RC1
2023-03-16 17:16:29 +01:00
MichaIng 59f4f5cb20 Merge pull request #37250 from nextcloud/backport/37010/stable24
[stable24] Fix Cache-Control header of non-versioned assets
2023-03-16 17:11:44 +01:00
Arthur Schiwon 24b536f92b Merge pull request #37237 from nextcloud/backport/37227/stable24
[stable24] chore: use local variable for remote address
2023-03-16 17:09:13 +01:00
Daniel Kesselberg a561c32f71 chore: use local variable for remote address
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-03-16 14:31:05 +01:00
Arthur Schiwon f6a93148f7 Merge pull request #37256 from nextcloud/backport/37252/stable24
[stable24] fix(workflow): Check tag attribute
2023-03-16 10:29:07 +01:00
Joas Schilling 334400fcaa fix(workflow): Check tag attribute
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-16 08:51:37 +01:00
Nextcloud bot 5ff6536e02 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-16 02:28:32 +00:00
Nicolas Guichard 3b04ae70f0 Fix Cache-Control header of non-versioned assets
Non-cache-busted assets such as /dist/core-main.js also matched the
regex meant for cache-busted assets (note the ? at the end of the
regex).
The FilesMatch directive for cache-busted assets coming after the
non-cache-busted version all assets actually got the immutable flag
in their Cache-Control header. This caused client-side errors on
updates.

Query strings are not actually passed to FilesMatch directives so we
need another way to tell cache-busted/versionned assets apart from
non-versioned assets, here using If/Else directives.

Signed-off-by: Nicolas Guichard <nicolas@guichard.eu>
2023-03-15 23:14:37 +00:00
Arthur Schiwon 7e4853089d Merge pull request #36750 from nextcloud/backport/36689/stable24
[stable24] Change X-Robots-Tag header from "none" to "noindex, nofollow"
2023-03-15 14:50:29 +01:00
Arthur Schiwon a3a05f4a06 Merge pull request #36900 from nextcloud/backport/stable24/36837
[stable24] fix(SystemTagManager): Truncate overlong tag names
2023-03-15 14:41:10 +01:00
Arthur Schiwon 0a9f73caa8 Merge pull request #36743 from nextcloud/backport/35419/stable24
[stable24] Fix login loop if login CSRF fails and user is not logged in
2023-03-15 14:40:02 +01:00
Julien Veyssier 0663c8f775 Merge pull request #35651 from nextcloud/backport/35057/stable24
[stable24] Add brute force protection on all methods wrapped by PublicShareMiddleware
2023-03-15 12:10:46 +01:00
Joas Schilling 6be6fd2291 Merge pull request #37226 from nextcloud/backport/37221/stable24
[stable24] Save some CI time
2023-03-15 10:27:19 +01:00
Julien Veyssier 5b08f8481c manual backport of #35057
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-03-15 10:19:35 +01:00
Joas Schilling cc31b3fa07 Save some CI time
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-15 09:37:43 +01:00
Nextcloud bot d2e444cacd Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-15 02:27:02 +00:00
Simon L ea6b4c69c9 Merge pull request #37004 from nextcloud/backport/36803/stable24
[stable24] [db]: Remove not supported column comments for SQLite
2023-03-14 13:14:06 +01:00
Nextcloud bot 5af2aa1e81 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-14 02:27:33 +00:00
Arthur Schiwon 59a19ecc96 24.0.11 RC1
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-03-13 20:40:13 +01:00
Nextcloud bot ca3400b37b Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-13 02:29:11 +00:00
Nextcloud bot f268b8b003 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-12 02:28:05 +00:00
Nextcloud bot 4c860f6139 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-11 02:28:21 +00:00
Simon L 4bb5f8db2f Merge pull request #37159 from nextcloud/backport/37070/stable24
[stable24] add a check for disk_free_space in Config.php
2023-03-10 16:17:54 +01:00
Nextcloud bot 530df6e551 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-10 02:27:40 +00:00
Simon L 2c6574a728 add a check for disk_free_space in Config.php
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-03-09 23:24:41 +00:00
Nextcloud bot 537a45ad2a Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-09 02:29:40 +00:00
Nextcloud bot 2cbbf37117 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-08 02:29:10 +00:00
Nextcloud bot 82210c9bcd Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-07 02:26:56 +00:00
Julius Härtl 3786c42212 Merge pull request #36888 from nextcloud/backport/36781/stable24
[stable24] fix(CI): Run repair steps against Oracle DB
2023-03-06 12:55:32 +01:00
Julius Härtl 6452b9dd4f Merge pull request #36586 from nextcloud/backport/36552/stable24
[stable24] fix(client-login-flow): Handle missing stateToken gracefully
2023-03-06 12:53:53 +01:00
Nextcloud bot 50d5e5a769 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-06 02:27:27 +00:00
Nextcloud bot f2d5e3e046 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-05 02:28:14 +00:00
Nextcloud bot 8c75d2ac99 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-04 02:27:43 +00:00
Joas Schilling 9a74c62356 Merge pull request #37037 from nextcloud/backport/37023/stable24
[stable24] chore(security): Bump "Expires" of well-known/security.txt
2023-03-03 12:13:23 +01:00
Joas Schilling 31435a038b chore(security): Bump "Expires" of well-known/security.txt
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-03 10:41:23 +00:00
Nextcloud bot a0ef29d8a1 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-03 02:26:52 +00:00
Ferdinand Thiessen 2f0c60dccc tests(db): Add test case to ensure column comments work
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-03-02 11:57:43 +00:00
Ferdinand Thiessen ffbe94480c fix(DB): Remove not supported column comments when using SQLite
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-03-02 11:57:43 +00:00
Nextcloud bot 8ed2d87b1b Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-02 02:30:01 +00:00
Nextcloud bot 8ba7c00a50 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-03-01 02:28:28 +00:00
Joas Schilling 5120c19d0f Neutralize action name
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-28 19:52:41 +01:00
MichaIng f101ef3d4d Merge pull request #36746 from nextcloud/backport/36465/stable24
[stable24] Avoid locking on restore/delete and limit concurrent requests
2023-02-28 18:34:32 +01:00
Marcel Klehr 60395a898e fix(SystemTagManager): Truncate overlong tag names
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-02-28 14:52:47 +01:00
Joas Schilling 0dd3b40260 Fix appconfig compatibility with Oracle DB
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-28 09:16:52 +01:00
Joas Schilling 84e5d349ed fix(OCC): Don't throw in the repair step for phone validation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-28 09:15:52 +01:00
Joas Schilling 51c2a51fed Fail the repair command when an error happened
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-28 09:15:31 +01:00
Joas Schilling dcb5ccac4e First run unit tests so they don't fail
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-28 09:14:08 +01:00
Joas Schilling 63ba618dac fix(CI): Run repair steps against Oracle DB
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-28 09:12:39 +01:00
Nextcloud bot 7e12bda155 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-28 02:28:02 +00:00
MichaIng 6b01e5d140 Merge pull request #36662 from nextcloud/backport/36192/stable24
[stable24] fix(caldav): Fix reminder timezone drift for all-day events
2023-02-27 23:01:07 +01:00
Christoph Wurst 2b868af78b fix(client-login-flow): Handle missing stateToken gracefully
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-02-27 16:09:56 +00:00
Christoph Wurst ba6e13d037 fix(caldav): Fix reminder timezone drift for all-day events
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-02-27 16:16:18 +01:00
Julius Härtl 3a06d335f1 Merge pull request #36762 from nextcloud/bugfix/noid/scss-reset
Avoid scss cacher reset on empty variables
2023-02-27 09:59:04 +01:00
Côme Chilliet def49625ee Merge pull request #36651 from nextcloud/automated/noid/stable24-update-psalm-baseline
[stable24] Update psalm-baseline.xml
2023-02-27 09:40:50 +01:00
Julius Härtl a04ed00f63 fix: Avoid resetting scss cacher when no variables are found
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-27 07:30:50 +00:00
nextcloud-command d9937df208 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2023-02-27 04:20:45 +00:00
Nextcloud bot 1982668738 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-27 02:26:27 +00:00
Julius Härtl 1bbc8ef112 fix(files_trashbin): Remove unnecessary scanner logic when getting versions from trash
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-26 21:52:26 +00:00
Nextcloud bot 5a3754471d Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-26 02:27:44 +00:00
Nextcloud bot f93e0c78d4 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-25 02:43:01 +00:00
MichaIng 43f094445a Merge pull request #36732 from nextcloud/backport/35365/stable24
[stable24] Check for opcache.file_cache_only=1
2023-02-24 19:00:06 +01:00
Simon L a420cb97df Merge pull request #36730 from nextcloud/backport/36691/stable24
[stable24] add a disk_free_space check before writing config
2023-02-24 10:19:48 +01:00
Joas Schilling 9614f6f3c2 Merge pull request #36798 from nextcloud/backport/36795/stable24
[stable24] Avoid extra parenthesis around SQL in IN expressions
2023-02-24 08:11:17 +01:00
Nextcloud bot a694b1e0c2 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-24 02:34:54 +00:00
John Molakvoæ 9fcbbc523e Merge pull request #36686 from nextcloud/release/24.0.10
24.0.10
2023-02-23 09:53:20 +01:00
John Molakvoæ b8e7a42c87 24.0.10
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-02-23 07:45:48 +01:00
John Molakvoæ 5cd6b9850b Merge pull request #36816 from nextcloud/backport/36814/stable24
[stable24] Validate the scope when validating operations
2023-02-23 07:35:26 +01:00
Joas Schilling cd4aad1ab6 Also check the scope when reading operations from the database
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-23 06:18:38 +01:00
Joas Schilling 2be84b5867 Validate the scope when validating operations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-23 06:18:38 +01:00
Nextcloud bot 74f97c80d1 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-23 02:29:30 +00:00
Nextcloud bot 7003a40fe6 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-22 02:26:51 +00:00
Côme Chilliet 5061926573 Avoid extra parenthesis around SQL in IN expressions
The expression builder already suround the SQL with parenthesis when
 using in(), so we must not add another pair, this confuses at least
 sqlite.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-21 16:56:44 +00:00
Nextcloud bot 770a04eb19 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-21 02:26:29 +00:00
Simon L b3a64a9121 fix it for 32-bit
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-02-20 10:15:20 +01:00
Nextcloud bot 2bfbb88ab1 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-20 02:27:00 +00:00
Nextcloud bot 8bb8b883dc Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-19 02:27:23 +00:00
Nextcloud bot 0d34d58c73 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-18 02:27:32 +00:00
Nextcloud bot 5475f6bc88 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-17 02:26:15 +00:00
MichaIng 30c0937205 Change X-Robots-Tag header from "none" to "noindex, nofollow"
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list
https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240

Signed-off-by: MichaIng <micha@dietpi.com>
2023-02-16 10:55:36 +00:00
Christoph Wurst 793dbe2d22 Fix login loop if login CSRF fails and user is not logged in
If CSRF fails but the user is logged in that they probably logged in in
another tab. This is fine. We can just redirect.
If CSRF fails and the user is also not logged in then something is
fishy. E.g. because Nextcloud contantly regenrates the session and the
CSRF token and the user is stuck in an endless login loop.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-02-16 09:39:02 +01:00
Nextcloud bot b8cff5e4e0 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-16 02:26:09 +00:00
MichaIng ceab09ee5e Check for opcache.file_cache_only=1
which disables shared memory based OPcache with disk file cache used only, if enabled. In this case, "opcache.memory_consumption" and others do not apply, so show the correct performance recommendation to enable memory cache.

Signed-off-by: MichaIng <micha@dietpi.com>
2023-02-15 18:58:27 +00:00
Simon L b3fb30b8b0 address review by Joas
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-02-15 17:57:06 +00:00
Simon L a87f45a6ca add a disk_free_space check before writing config
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-02-15 17:57:03 +00:00
Nextcloud bot 776c3cfe07 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-15 02:26:04 +00:00
blizzz 57d94830a2 Merge pull request #36703 from nextcloud/backport/36700/stable24
[stable24] Also copy meta data when converting DataResponse to JSONRe…
2023-02-14 22:05:53 +01:00
Joas Schilling 1010fbd2ed Also copy bruteforce meta data when converting DataResponse to JSONResponse
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-14 19:46:38 +01:00
Nextcloud bot 20b11e4bf0 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-14 02:26:10 +00:00
Nextcloud bot 4cdcf8916d Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-13 02:25:25 +00:00
Nextcloud bot 437332cf67 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-12 02:26:15 +00:00
Nextcloud bot ccb62cb358 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-11 02:26:32 +00:00
Nextcloud bot 00a654847b Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-10 02:26:55 +00:00
blizzz e08c3421d4 Merge pull request #36561 from nextcloud/release/24.0.10_rc1
24.0.10 RC1
2023-02-09 13:58:40 +01:00
blizzz 4d0a68eca1 Merge pull request #36441 from nextcloud/backport/36433/stable24
[stable24] fix(encryption): don't throw on missing file
2023-02-09 13:07:18 +01:00
blizzz 53c94353ff Merge pull request #36413 from nextcloud/backport/36380/stable24
[stable24] fix(caldav): Fix wrong Psalm report for nullable calendar data
2023-02-09 12:29:04 +01:00
blizzz 6ff9ca9bfc Merge pull request #36376 from nextcloud/backport/35894/stable24
[stable24] fix moving files of encrypted local storage to unencrypted local storage
2023-02-09 12:28:48 +01:00
blizzz e3f67b1991 Merge pull request #36318 from nextcloud/backport/36268/stable24
[stable24] Fix double where() usage in resource manager
2023-02-09 12:28:29 +01:00
blizzz 2dbf69409b Merge pull request #35837 from nextcloud/backport/35814/stable24
[stable24] Fix parameter type for EntityCollection::setReadMarker in comments app
2023-02-09 12:28:13 +01:00
Nextcloud bot a57a4ffc17 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-09 02:25:59 +00:00
Louis 58ca8e0e81 Merge pull request #36616 from nextcloud/backport/stable24/36564
[stable24] Restore copy button text on directory fetch error
2023-02-08 20:46:59 +01:00
Louis Chemineau 025bbba0ef Restore copy button text on directory fetch error
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-02-08 16:53:30 +01:00
Daniel 04a1c413cb Merge pull request #36596 from nextcloud/automated/noid/stable24-update-psalm-baseline
[stable24] Update psalm-baseline.xml
2023-02-08 13:02:25 +01:00
Joas Schilling b8509e1950 Merge pull request #36295 from nextcloud/backport/36266/stable24
[stable24] Fix double where in CustomProperiesBackendTest
2023-02-08 09:01:48 +01:00
nextcloud-command d684b524da Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2023-02-08 04:28:16 +00:00
Nextcloud bot 7ac7ad2c13 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-08 02:25:33 +00:00
Richard Steinmetz 18ca00b216 fix(encryption): don't throw on missing file
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2023-02-07 18:12:12 +00:00
Christoph Wurst befee5df6d fix(caldav): Fix wrong Psalm report for nullable calendar data
> Docblock-defined type Sabre\VObject\Component\VCalendar for $vcalendar is never falsy

^ is a lie

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-02-07 18:06:03 +00:00
Robin Appelman 920e8ad21a fix moving files of encrypted local storage to unencrypted local storage
for example when moving encrypted files to a groupfolder

Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-07 18:00:28 +00:00
Joas Schilling fc711c9539 Fix double where() usage in resource manager
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-07 17:59:46 +00:00
Joas Schilling 24d7586318 Fix double where in CustomProperiesBackendTest
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-07 17:58:40 +00:00
blizzz dc737047ce Merge pull request #36558 from nextcloud/backport/36557/stable24
[stable24] perf(federation): Only request root share info for checking availability
2023-02-07 18:57:10 +01:00
Côme Chilliet 7a2903ae20 Fix parameter type for EntityCollection::setReadMarker in comments app
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 17:55:48 +00:00
blizzz 7c6a41488d Merge pull request #36386 from nextcloud/backport/36210/stable24
[stable24] fix(dav): check if principal has email address before accessing it
2023-02-07 18:55:03 +01:00
blizzz 9a2167d3ef Merge pull request #35843 from nextcloud/backport/25768/stable24
[stable24] Use mimetype from cache for workflow checks
2023-02-07 18:52:31 +01:00
Julius Härtl a5a5a78ae1 chore: Add return types
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-07 15:16:51 +01:00
Christoph Wurst 8eb7f01df0 fix(user-management): Fix deleting user in hidden group(s)
E.g. guest_users

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-02-07 10:10:12 +00:00
Louis 94983f6e42 Merge pull request #36563 from nextcloud/backport/33681/stable24
[stable24] Fallback to root if the picker folder doesn't exists
2023-02-07 10:09:40 +01:00
blizzz c81f672200 Merge pull request #36574 from nextcloud/backport/36489/stable24
[stable24] Add bruteforce protection to password reset page
2023-02-07 10:08:02 +01:00
Joas Schilling f89eacbf86 fix(CI): Adjust expected result
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-07 07:44:16 +01:00
Joas Schilling f7a55209dd Add bruteforce protection to password reset page
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-07 07:43:57 +01:00
Nextcloud bot 4de06c581c Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-07 02:26:18 +00:00
John Molakvoæ 8732ba9ac5 Fallback to root if the picker folder doesn't exists
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-02-06 15:03:54 +01:00
Arthur Schiwon 916f5d8d2d 24.0.10 RC1
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-02-06 13:52:24 +01:00
Joas Schilling f3cf079080 Merge pull request #36519 from nextcloud/backport/36511/stable24
[stable24] chore(CI): Opt-out of PHPUnit 10 for now
2023-02-06 11:14:13 +01:00
Julius Härtl eef2cb855b perf(federation): Only request root share info for checking availability
Otherwise this would request a full recursive dirctory listing while the result is never being used

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-06 11:10:22 +01:00
Nextcloud bot b2a8a95a47 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-06 02:25:00 +00:00
Nextcloud bot 15fe44a4f0 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-05 02:25:21 +00:00
Nextcloud bot 4bd0db25be Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-04 02:25:33 +00:00
Joas Schilling eb76fbe8d6 fix(CI): Fix unmockable countUsers() method
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-03 16:11:17 +01:00
Joas Schilling 6761b94f4f Remove failing test that works with mocks only anyway
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-03 15:16:07 +01:00
Joas Schilling 4fb4fc310a chore(CI): Opt-out of PHPUnit 10 for now
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-03 14:27:17 +01:00
Simon L 427c5dfe5b Merge pull request #36467 from nextcloud/backport/36407/stable24
[stable24] add a safeguard for Version23000Date20210721100600.php
2023-02-03 12:58:42 +01:00
Joas Schilling 5bde3e3da5 Merge pull request #36500 from nextcloud/bugfix/noid/green-ci
[stable24] Skip failing avatar test with PHP 8.0
2023-02-03 12:55:49 +01:00
Joas Schilling 8b81770156 Skip failing avatar test with PHP 8.0
The font is placed one pixel off

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-03 09:10:35 +01:00
Nextcloud bot 5e1a714121 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-03 02:27:42 +00:00
Joas Schilling cebaa80052 Merge pull request #36491 from nextcloud/backport/36487/stable24
[stable24] Do not reuse query builder objects in DAV account deletion
2023-02-02 13:10:34 +01:00
Côme Chilliet 621f615bd4 Merge pull request #35976 from nextcloud/automated/noid/stable24-update-psalm-baseline
[stable24] Update psalm-baseline.xml
2023-02-02 12:05:33 +01:00
Joas Schilling d17e87d75f Do not reuse query builder objects in DAV account deletion
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-02 06:11:22 +00:00
nextcloud-command 2008a01c43 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2023-02-02 04:12:15 +00:00
Nextcloud bot c04512b083 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-02 02:26:05 +00:00
Louis 29e86fb8a2 Merge pull request #36472 from nextcloud/backport/stable24/34625
[stable24] Fix icon of encrypted folders in filepicker
2023-02-01 20:29:15 +01:00
Carl Schwan 901a97b485 Fix icon of encrypted folders in filepicker
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-02-01 14:35:14 +01:00
Simon L dcf8eb591f add a safeguard for Version23000Date20210721100600.php
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-02-01 08:05:44 +00:00
Nextcloud bot 6bb260eb97 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-01 02:25:38 +00:00
Nextcloud bot 35477881f7 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-31 02:26:00 +00:00
Nextcloud bot 6f02feaa7e Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-30 02:26:17 +00:00
Nextcloud bot 3735667eb7 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-29 02:27:11 +00:00
Nextcloud bot 973216891f Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-28 02:26:17 +00:00
Simon L 8f3bdbd2b9 Merge pull request #36401 from nextcloud/backport/34152/stable24
[stable24] Do not store generated mysql password if it was not used
2023-01-27 13:39:03 +01:00
Julius Härtl f23532b095 Do not store generated mysql password if it was not used
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-01-27 06:43:39 +00:00
Nextcloud bot 485bc35e74 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-27 02:28:17 +00:00
Richard Steinmetz 6728b4b30b fix(dav): check if principal has email address before accessing it
Ref https://github.com/nextcloud/calendar/issues/4811

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2023-01-26 13:45:46 +00:00
Vincent Petry fb3261a062 Merge pull request #36365 from nextcloud/backport/36352/stable24
[stable24] imaginary - add tiff to supported formats
2023-01-26 09:43:28 +01:00
Nextcloud bot bd9b3c3752 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-26 02:42:01 +00:00
Simon L 664133edbb imaginary - add tiff to supported formats
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-01-25 20:23:44 +00:00
Simon L e1164fd8d5 Merge pull request #36345 from nextcloud/backport/36326/stable24
[stable24] don't translate a variable
2023-01-25 20:59:27 +01:00
Christoph Wurst fa08275ab2 Merge pull request #35824 from nextcloud/backport/35614/stable24
[stable24] Fix array to string conversion in errorlog writer
2023-01-25 19:34:19 +01:00
Simon L eb378aa5cd don't translate a variable
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-01-25 18:28:48 +00:00
Simon L 8be076afed Merge pull request #36336 from nextcloud/backport/36333/stable24
[stable24] Fix default value for files_no_background_scan
2023-01-25 09:23:54 +01:00
Nextcloud bot 05ebbf29df Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-25 02:44:33 +00:00
max-nextcloud 185115ad63 Fix default value for files_no_background_scan
The value is read in https://github.com/nextcloud/server/blob/b888c6146327d842e21988b0d90d6ade4f3a9435/apps/files/lib/BackgroundJob/ScanFiles.php#L105 and the default value is false.

Signed-off-by: max-nextcloud <max@nextcloud.com>
2023-01-24 20:39:44 +00:00
Vincent Petry ffe1405478 Merge pull request #36306 from nextcloud/backport/36094/stable24
[stable24] Only expose storage location to admins
2023-01-24 15:05:47 +01:00
Simon L 446be2316c Merge pull request #36325 from nextcloud/backport/35935/stable24
[stable24] [Fix]: scan-app-data conversion
2023-01-24 10:40:34 +01:00
Vincent Petry d1e09a4d03 Merge pull request #36299 from nextcloud/backport/36113/stable24
[stable24] Extend ViewOnly DAV plugin to versions endpoint
2023-01-24 10:31:51 +01:00
EWouters 75e2431560 [Fix]: scan-app-data conversion
Adapted from sugestions by @Hiyoal in #34283 and @st3iny in #35935.

See https://github.com/nextcloud/server/issues/34283#issuecomment-1288075064
and https://github.com/nextcloud/server/pull/35935#discussion_r1059905594.

Closes #34283.

Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: EWouters <6179932+EWouters@users.noreply.github.com>
2023-01-24 08:14:53 +00:00
Christoph Wurst f9fc4fbdd9 fix(logging): Fix array to string conversion in errorlog writer
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-24 08:54:10 +01:00
Nextcloud bot f3bf55afa0 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-24 02:25:37 +00:00
Vincent Petry 81e775f710 Only expose storage location to admins
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2023-01-23 15:52:14 +00:00
Vincent Petry 96de6170c0 Extend ViewOnly DAV plugin to versions endpoint
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2023-01-23 13:46:41 +00:00
Simon L 75331d5e4a Merge pull request #36293 from nextcloud/backport/36278/stable24
[stable24] Fix interned strings buffer check if 0 free bytes
2023-01-23 12:28:19 +01:00
MichaIng 4018083ccf Fix interned strings buffer check if 0 free bytes
With #32902 it was meant to be avoided to recommend raising the interned strings buffer size above a quarter of the total OPcache size. This works as long as there is at least 1 byte free, but does not apply if the buffer is filled completely.

This commit switches the conditions so that the interned strings buffer size must be smaller than a quarter of the total OPcache size for the warning to be shown. That the buffer must be either filled completely or by more than 90% remains untouched.

Signed-off-by: MichaIng <micha@dietpi.com>
2023-01-23 09:55:36 +00:00
Nextcloud bot fef92a0748 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-23 02:25:43 +00:00
Nextcloud bot 3a7c60cbb5 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-22 02:25:41 +00:00
Nextcloud bot b3049161f3 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-21 02:24:58 +00:00
Nextcloud bot 998e63f67d Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-20 02:29:58 +00:00
Vincent Petry 4852aa4a50 Merge pull request #36107 from nextcloud/backport/36074/stable24
[stable24] Fix inability to re-enter share password after invalid input
2023-01-19 17:43:39 +01:00
Christopher Ng e225b8d77d Fix inability to re-enter share password after invalid input
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-01-19 10:15:28 +01:00
Vincent Petry 617088835f Merge pull request #35946 from nextcloud/backport/33813/stable24
[stable24] Compare lowercase email when updating from ldap
2023-01-19 10:13:10 +01:00
Vincent Petry 608e038e6d Merge pull request #36104 from nextcloud/backport/36095/stable24
[stable24] Limit key names when uploading theme images
2023-01-19 10:10:49 +01:00
Julius Härtl 739d6951f8 Merge pull request #36168 from nextcloud/backport/35970/stable24
[stable24] Improve exception serializing
2023-01-19 10:09:37 +01:00
Vincent Petry a2756bd3e6 Merge pull request #36100 from nextcloud/backport/34924/stable24
[stable24] escape path prefix when doing cache jail search
2023-01-19 10:06:38 +01:00
Nextcloud bot 082fe16eee Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-19 02:27:22 +00:00
Julius Härtl a2073f4d4d fix(ExceptionSerializer): encode arguments before filtering the trace
This will avoid running into a Nesting level too deep error as the
encodeArg calls will limit potential recursive calls on the arguments to
a nesting level of 5

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-01-18 16:34:52 +01:00
Vincent Petry ae03129e06 Merge pull request #36156 from nextcloud/backport/36115/stable24
[stable24] Catch Exceptions when loading storage data of users
2023-01-18 14:14:41 +01:00
Vincent Petry 28f95d7d6e Merge pull request #36175 from nextcloud/enh/noid/ext-storage-default-values/stable24
[stable24] Ext storage configs default value support + enable SSL by default
2023-01-18 14:12:11 +01:00
Vincent Petry 05475e32df Merge pull request #36181 from nextcloud/backport/36093/stable24
[stable24] Improve password generation for link shares
2023-01-18 12:03:53 +01:00
Vincent Petry 18dd9951ca Enable SSL by default in ext storage configs
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2023-01-18 08:32:59 +00:00
Vincent Petry 2fe841a06b Extend ext storage params to contain default value
Extend the external storage configuration parameters definition to allow
to specify a default value

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2023-01-18 08:32:59 +00:00
Nextcloud bot 53f0ee12b4 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-18 02:25:42 +00:00
blizzz b4899ddee1 Merge pull request #36141 from nextcloud/release/24.0.9
24.0.9
2023-01-17 10:04:19 +01:00
Vincent Petry eda78c6d1a Merge pull request #36172 from nextcloud/backport/36161/stable24
[stable24] still include the share target in the cache key for validating share mount
2023-01-17 09:56:08 +01:00
Nextcloud bot 03439f2510 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-17 02:27:09 +00:00
Vincent Petry 2246c894ad Improve password generation for link shares
Use web crypto when generating password for link shares
whenever the password policy app is disabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-01-17 00:22:59 +00:00
Robin Appelman edaf318b6f still include the share target in the cache key for validating share mount
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-01-16 15:22:01 +00:00
Côme Chilliet 418f1a21b5 Tear down in catch of an Exception
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-16 10:56:41 +00:00
Côme Chilliet 0336d31af7 Catch Exceptions when loading storage data of users
This avoids having the whole userlist crashing because a user external
 storage fails to load. With this change only the problematic user
 storage/quota information will be empty.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-16 10:56:41 +00:00
Nextcloud bot 6c1cbda9f0 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-16 02:25:14 +00:00
Nextcloud bot a84b677186 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-15 02:25:03 +00:00
Nextcloud bot b3540e47bf Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-14 02:26:56 +00:00
Arthur Schiwon 729c11b6ff 24.0.9
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-01-13 23:23:03 +01:00
Nextcloud bot c1cf9adfe0 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-13 02:26:50 +00:00
Vincent Petry 21011382b0 Limit key names when uploading theme images
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2023-01-12 10:24:00 +01:00
Nextcloud bot 2e67962e30 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-12 02:24:59 +00:00
Robin Appelman 0bd5bcdaeb escape path prefix when doing cache jail search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-01-11 17:12:40 +00:00
blizzz 151f7195c0 Merge pull request #36080 from nextcloud/release/24.0.9_rc2
24.0.9 RC2
2023-01-11 13:31:51 +01:00
Arthur Schiwon d986bda4b0 24.0.9 RC2
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-01-11 09:40:14 +01:00
Nextcloud bot 8b5831497f Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-11 02:24:59 +00:00
Vincent Petry a3b547d0f6 Merge pull request #36050 from nextcloud/backport/36047/stable24
[stable24] fix cache key used to verify shared mountpoints
2023-01-10 12:37:02 +01:00
Robin Appelman 76e2de2dfa fix cache key used to verify shared mountpoints
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-01-10 09:32:00 +00:00
John Molakvoæ ae75427e6c Merge pull request #36061 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] Update ca-cert bundle
2023-01-10 09:49:16 +01:00
nextcloud-command c3179fba5f Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2023-01-10 04:26:20 +00:00
Nextcloud bot 21e2901120 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-10 02:25:15 +00:00
Nextcloud bot 7fc120a19a Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-09 02:25:04 +00:00
Nextcloud bot e9e8b79a5d Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-08 02:25:00 +00:00
Nextcloud bot dbe6eef946 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-07 02:24:29 +00:00
John Molakvoæ 7ee05bb1a0 Merge pull request #36029 from nextcloud/release/24.0.9_rc1
24.0.9 RC1
2023-01-06 10:18:16 +01:00
John Molakvoæ 467c213795 Merge pull request #35094 from nextcloud/invalidateTokensWhenDeletingOAuthClient
fixes https://github.com/nextcloud/server/issues/35068
2023-01-06 08:52:57 +01:00
John Molakvoæ f155d3b2bf 24.0.9 RC1
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-01-06 08:45:16 +01:00
Nextcloud bot d427849cd3 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-06 02:25:14 +00:00
Vincent Petry b8885981a1 Merge pull request #36018 from nextcloud/backport/35975/stable24
[stable24] Update crl after revoke files_bpm.csr
2023-01-05 16:18:15 +01:00
Vitor Mattos a40ae4550b Update crl after revoke files_bpm.csr
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-01-05 11:23:06 -03:00
Joas Schilling be81443968 Merge pull request #36009 from nextcloud/bugfix/noid/bump-jquery-ui-dist
[stable24] Bump jQuery-UI dist to 1.13.2
2023-01-05 10:10:05 +01:00
Vincent Petry cabe108404 Merge pull request #35818 from nextcloud/backport/35789/stable24
[stable24] Allow additional Sabre plugins in publicwebdav.php
2023-01-05 09:44:04 +01:00
Joas Schilling ecb027cbb3 Recompile
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-05 08:36:16 +01:00
Joas Schilling 187d2f404e Bump jQuery-UI dist to 1.13.2
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-05 08:36:01 +01:00
Joas Schilling a492476e88 Merge pull request #35989 from nextcloud/stable24-audit-fix-json5
[stable24] Bump json5 from 1.0.1-1.0.2 and 2.2.0-2.2.3
2023-01-05 07:17:24 +01:00
Nextcloud bot 9cae3d8ab0 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-01-05 02:24:44 +00:00
Vincent Petry d082373565 Bump json5 from 1.0.1-1.0.2 and 2.2.0-2.2.3
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2023-01-04 14:14:13 +01:00
Vincent Petry 02a9a77001 Merge pull request #35949 from nextcloud/backport/33941/stable24
[stable24] Only normalize data in public shares and not crud
2023-01-04 10:26:25 +01:00
Vincent Petry 00645c6052 Merge pull request #35940 from nextcloud/backport/35734/stable24
[stable24] Quota value as float for 32-bit systems
2023-01-03 10:38:05 +01:00
Julien Veyssier abf8b774ff manual backport of #35789, dispatch BeforeSabrePubliclyLoadedEvent to allow adding additional Sabre plugins in publicwebdav.php
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-01-03 10:12:13 +01:00
Carl Schwan 1027d62a82 Only normalize data in public shares and not crud
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-01-02 16:52:52 +00:00
Julius Härtl 6aae233f56 Merge pull request #35849 from nextcloud/backport/35836/stable24
[stable24] fix: remove other shares from ui when deleted
2023-01-02 17:18:35 +01:00
Louis Chemineau 34a93a0e12 I dug into it again, and the issue is much simpler than I previously though.
- LDAP has an email address with capital letters
- NC store this address in lower case
- When the user logs in, we compare the [stored email with the new lower case email](https://github.com/nextcloud/server/blob/master/lib/private/AllConfig.php#L259-L261) before storing it. Here, both email will be the same, so we won't store the new email address with upper case letters. Which is what we want.
- We then [compare emails as they are before triggering an event](https://github.com/nextcloud/server/blob/master/lib/private/User/User.php#L202-L204), they won't match, so the user will receive an email signaling an email change every time he logs in.

The fix is to compare the old email with the new lower case email before sending the event.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-02 15:30:15 +00:00
Côme Chilliet 6def133792 Remove null from quota type
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-02 15:49:53 +01:00
Côme Chilliet 602cc7260c Silence a warning from psalm with explanation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-02 12:24:29 +01:00
Côme Chilliet 39cb3549be Adapt types of subclasses
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-02 12:24:18 +01:00
Côme Chilliet 5421510b12 Make it clear that file sizes may be float on 32bits
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-02 12:24:05 +01:00
Vincent Petry 82397529ef Remove quota value type for 32-bit systems
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2023-01-02 12:22:07 +01:00
Nextcloud bot 6881d200ad Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-31 02:51:13 +00:00
John Molakvoæ 40fcdc25ea Merge pull request #35879 from nextcloud/automated/noid/stable24-update-psalm-baseline
[stable24] Update psalm-baseline.xml
2022-12-30 11:27:32 +01:00
nextcloud-command 7e8ab000d7 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2022-12-29 04:12:21 +00:00
Nextcloud bot 7236bc2431 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-29 03:10:32 +00:00
Nextcloud bot 09633fc3e3 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-27 02:47:20 +00:00
Nextcloud bot 3b5f4b7717 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-26 02:43:47 +00:00
Nextcloud bot 9a648feacd Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-25 02:49:07 +00:00
Nextcloud bot d8260695ba Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-24 03:02:41 +00:00
Vincent Petry 90681c449a Merge pull request #35865 from nextcloud/stable24-encryption-fix-versions-all
[stable24] allow running encryption:fix-encrypted-version for all users
2022-12-23 12:09:00 +01:00
Anna 68c53d864f Merge pull request #35861 from nextcloud/backport/35761/stable24
[stable24] Remove comment and guests option from Invitations UI
2022-12-23 11:12:59 +01:00
Nextcloud bot 543530187b Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-23 03:05:03 +00:00
Max be2121c64b fix: remove other shares from ui when deleted
Remove the share entry in question
when unsharing a folder
from within the `others with access` section
of a file within that folder.

Using the code from the ShareList view here as well.
Just copying the code here as this is a bugfix
that will need to be backported.

Signed-off-by: Max <max@nextcloud.com>
2022-12-22 18:25:39 +01:00
Robin Appelman 8969453208 allow running encryption:fix-encrypted-version for all users
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-12-22 11:08:50 +01:00
Anna Larch 2a713e6b5a Remove comment and guests option from Invitations UI
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-12-22 09:20:22 +00:00
Nextcloud bot 4d423b0bc1 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-22 02:56:12 +00:00
Julius Härtl 0d5e422b60 Merge pull request #33422 from nextcloud/dependabot/npm_and_yarn/stable24/bootstrap-4.6.2
Bump bootstrap from 4.6.1 to 4.6.2
2022-12-21 08:02:12 +01:00
dependabot[bot] 46cf3d7f2e Bump bootstrap from 4.6.1 to 4.6.2
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.6.1 to 4.6.2.
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](https://github.com/twbs/bootstrap/compare/v4.6.1...v4.6.2)

---
updated-dependencies:
- dependency-name: bootstrap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-12-21 05:03:13 +00:00
Nextcloud bot 569187f5b3 Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-21 02:30:36 +00:00
Artur Neumann c001c4b3ac autoloaderchecker
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2022-12-20 16:26:49 +00:00
Artur Neumann a0788a8bc8 added @since tag
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2022-12-20 16:26:49 +00:00
Artur Neumann bcfd571d83 unit tests for Manager::invalidateTokensOfUser
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2022-12-20 16:26:49 +00:00
Artur Neumann 7f3baddb04 adjust SettingsController tests
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2022-12-20 16:26:49 +00:00
Artur Neumann 0570327c7e public interface to invalidate tokens of user
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2022-12-20 16:26:49 +00:00
Artur Neumann 1a33c71a84 invalidate existing tokens when deleting an oauth client
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2022-12-20 16:26:49 +00:00
Robin Appelman f0b2b2461e add some tests for mimetype check
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-12-20 15:30:41 +00:00
Robin Appelman a2e7f31c77 remove file exists check from cacheAndReturnMimeType
the method is only called if the file exists already

a check against storing the fallback mimetype is added as a safety instead

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-12-20 15:30:39 +00:00
Robin Appelman 783dae94cf use mimetype from cache for workflow if available
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-12-20 15:30:39 +00:00
Nextcloud bot 902d0600ce [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-20 02:22:34 +00:00
Christoph Wurst 125ddf01cc fix(logging): Fix array to string conversion in errorlog writer
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-12-19 13:46:38 +00:00
Louis 8dc6516c22 Merge pull request #35804 from nextcloud/backport/34629/stable24
[stable24] Fix case sensitivity of email when saving settings
2022-12-19 12:43:50 +01:00
Vincent Petry 05d96e0063 Merge pull request #35500 from nextcloud/backport/35107/stable24
[stable24] add migration for encryption keys in wrong location
2022-12-19 12:13:11 +01:00
Vincent Petry 28b8d6b94f Merge pull request #35799 from nextcloud/backport/35780/stable24
[stable24] Fix missing cast of double controller parameters
2022-12-19 12:07:23 +01:00
Vincent Petry e433c68709 Merge pull request #35674 from nextcloud/stable24-audit-fix2
[stable24] Update handlebars-loader update to 1.7.3 + others
2022-12-19 12:06:23 +01:00
Andy Scherzinger b49ec68349 Merge pull request #35800 from nextcloud/backport/35492/stable24
[stable24] Rename personal Groupware settings section to "Availability"
2022-12-19 08:47:40 +01:00
Nextcloud bot 0aa3a348ef [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-19 02:21:46 +00:00
Nextcloud bot a0e6807c5a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-18 02:20:07 +00:00
Nextcloud bot dea7d583b7 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-17 02:19:53 +00:00
Vincent Petry 28aaa5aefc Add unit test for case insensitive email saving
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-12-16 21:56:05 +00:00
Carl Schwan ff6279edab Fix case sensitivity of email when saving settings
Otherwise we detect a email change all the time and since email are
immutable in ldap this prevent updating other fields.

Related: https://github.com/nextcloud/server/pull/33813

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-12-16 21:56:05 +00:00
Joas Schilling dd8887529d Merge pull request #35574 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] Update ca-cert bundle
2022-12-16 19:09:00 +01:00
Vincent Petry 488d10b6fc Merge pull request #35524 from nextcloud/backport/35502/stable24
[stable24] Fix SQL comparison with int array during external storage deletion
2022-12-16 18:16:04 +01:00
Christoph Wurst 80a4abd28c Rename personal Groupware settings section to "Availability"
But leave the internal identifier untouched.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-12-16 16:09:54 +00:00
Vincent Petry b64feafb6f Merge pull request #35520 from nextcloud/backport/35355/stable24
[stable24] Allow to set a custom timeout for ldap connections
2022-12-16 16:57:49 +01:00
Vincent Petry 5967026c2e Update handlebars-loader update to 1.7.3 + others
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-12-16 15:47:56 +00:00
Christoph Wurst 7fceb57843 fix(app framework): Fix missing cast of double controller parameters
``settype`` allows 'double' as alias of 'float'.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-12-16 15:33:51 +00:00
Vincent Petry 07361adb48 Merge pull request #35657 from nextcloud/backport/35649/stable24
[stable24] Update the unencrypted file size when closing streams
2022-12-16 16:33:24 +01:00
Vincent Petry 4f5f46c5d3 Merge pull request #35687 from nextcloud/backport/35399/stable24
[stable24] Fix share admin page
2022-12-16 16:26:23 +01:00
Vincent Petry 1fcffde84e Merge pull request #35796 from nextcloud/backport/35779/stable24
[stable24] [PHP8] check if params given to API are really an array
2022-12-16 16:14:59 +01:00
Robin Appelman cf38cfa189 add migration for encryption keys in wrong location
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-12-16 12:58:36 +00:00
Artur Neumann 8cf9878fd2 check if params given to API are really an array
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2022-12-16 10:50:41 +00:00
nextcloud-command 0b3145c627 Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2022-12-16 04:11:04 +00:00
Nextcloud bot 4a4dbab61a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-16 02:20:08 +00:00
Nextcloud bot 6efe863bfa [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-15 02:19:04 +00:00
Nextcloud bot f07eeb6724 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-14 02:22:12 +00:00
Nextcloud bot 46a7c79d78 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-13 02:33:11 +00:00
Simon L c964f39963 Merge pull request #35735 from nextcloud/backport/35724/stable24
[stable24] ci: update minio image for s3 primary storage tests
2022-12-12 12:44:58 +01:00
Daniel Kesselberg 265d76c5c8 ci: update minio image for s3 primary storage tests
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-12-12 10:07:56 +00:00
Nextcloud bot cb29c3a25b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-12 02:20:09 +00:00
John Molakvoæ ff9c7e5e19 Merge pull request #35729 from nextcloud/backport/35689/stable24 2022-12-11 19:12:51 +01:00
Varun Patil eea1f3c53e preview: fix HEIC orientation
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2022-12-11 11:19:57 +00:00
Nextcloud bot 702ea27392 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-11 02:31:26 +00:00
Nextcloud bot 274272c86d [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-10 02:21:09 +00:00
MichaIng b48f0c7164 Merge pull request #35417 from nextcloud/automated/noid/stable24-update-psalm-baseline
[stable24] Update psalm-baseline.xml
2022-12-09 16:19:36 +01:00
nextcloud-command 7042af2749 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2022-12-09 04:29:12 +00:00
Nextcloud bot da6a15c2a8 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-09 02:35:21 +00:00
Carl Schwan a51c3b3651 Fix share admin page
arrow function don't work that well with jquery

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-12-08 21:52:59 +00:00
blizzz 888ffa498d Merge pull request #35670 from nextcloud/release/24.0.8 2022-12-08 13:05:31 +01:00
Arthur Schiwon b43c00705d 24.0.8
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-12-08 10:33:45 +01:00
Nextcloud bot f05527d08f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-08 02:19:43 +00:00
Julius Härtl d843ba9822 Also update the unencrypted size of files when creating them with empty content
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 21:15:57 +00:00
Julius Härtl da45a807ac Update the unencrypted file size when closing streams
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 21:15:57 +00:00
Nextcloud bot f2f6d52263 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-07 02:20:02 +00:00
Nextcloud bot e37fd1f2cb [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-06 02:26:20 +00:00
MichaIng aee987df08 Merge pull request #35564 from nextcloud/dependabot/composer/build/integration/stable24/behat/behat-approx-3.12.0
Update behat/behat requirement from ~3.11.0 to ~3.12.0 in /build/integration
2022-12-06 00:57:01 +01:00
dependabot[bot] 61c78a08f7 Update behat/behat requirement in /build/integration
Updates the requirements on [behat/behat](https://github.com/Behat/Behat) to permit the latest version.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.11.0...v3.12.0)

---
updated-dependencies:
- dependency-name: behat/behat
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-12-05 19:27:22 +00:00
Simon L 7e1966475b Merge pull request #35607 from nextcloud/backport/35580/stable24
[stable24] downgrade ubuntu in order to fix CI
2022-12-05 17:14:53 +01:00
Simon L 4c8ec2602e downgrade ubuntu in order to fix CI
Signed-off-by: Simon L <szaimen@e.mail.de>
2022-12-05 15:27:47 +01:00
Nextcloud bot f6beef8917 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-05 02:15:40 +00:00
Nextcloud bot 7537612a88 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-04 02:15:07 +00:00
Nextcloud bot ec089490de [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-03 02:15:21 +00:00
Nextcloud bot 41562fa97f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-02 02:15:37 +00:00
blizzz 304aa0f539 Merge pull request #35488 from nextcloud/release/24.0.8_rc2
24.0.8 RC2
2022-12-01 10:07:38 +01:00
Nextcloud bot ef09de47e9 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-01 02:15:37 +00:00
Andy Xheli 775c62860c Fix Executing a query: SQLSTATE[42000]
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>

Fix https://github.com/nextcloud/server/issues/32007#issuecomment-1329405245

Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
2022-11-30 15:04:47 +00:00
Louis Chemineau 24bbc3db43 Allow to set a custom timeout for ldap connections
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-11-30 13:50:43 +00:00
Nextcloud bot 416a3e9630 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-30 02:15:50 +00:00
Arthur Schiwon a80a8c2920 24.0.8 RC2
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-11-29 13:55:00 +01:00
Nextcloud bot 2420e99579 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-29 02:14:42 +00:00
Nextcloud bot 0563a1f9fa [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-28 02:19:41 +00:00
Nextcloud bot d1d529a9b1 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-27 02:18:41 +00:00
Nextcloud bot e02ef68c98 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-26 02:18:32 +00:00
blizzz 6f99f7ef6c Merge pull request #35306 from nextcloud/release/24.08_rc1
24.0.8 RC1
2022-11-25 09:50:32 +01:00
Simon L 87cbbb48d9 Merge pull request #35334 from nextcloud/revert-34032-backport/34019/stable24
Revert "[stable24] Fix quota type to int"
2022-11-25 09:35:21 +01:00
Simon L 7031a4bce4 Merge pull request #35392 from nextcloud/backport/35370/stable24
[stable24] Fix UX of renaming token
2022-11-25 09:01:24 +01:00
Carl Schwan 70facaa6a9 Fix UX of renaming token
Now this get's instant applied and escaping will reset to the previous
state

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-11-25 07:34:02 +00:00
Nextcloud bot e6dbd42ede [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-25 02:19:45 +00:00
blizzz bee43e2ab7 Merge pull request #35100 from nextcloud/backport/35054/stable24
[stable24] Fix HTML entities not decoded in comment just added
2022-11-24 21:18:34 +01:00
Vincent Petry f8e18e5caa Update baseline for some unrelated errors
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-24 21:09:28 +01:00
Vincent Petry c73f11ba4d Float the quota
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-24 21:09:28 +01:00
Vincent Petry 7a66cb84dc Revert "[stable24] Fix quota type to int"
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-24 21:09:28 +01:00
Simon L a79a099508 Merge pull request #35409 from nextcloud/backport/35398/stable24
[stable24] Do not check quota for non Node
2022-11-24 19:24:43 +01:00
nextcloud-command 2bdd9ac194 Compile assets
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-11-24 17:17:08 +00:00
Daniel Calviño Sánchez d3807ea951 Fix HTML entities not decoded in comment just added
The XML data received from the comments endpoint has an inconsistent
encoding; some entities are encoded once and others are encoded twice.
When the comment list is loaded the comments are fetched using
GetComments, which handles all that, and therefore shows the messages
and author names as expected.

However, when a new comment is posted the list is not got again; instead
the new comment is loaded from the comment data returned after posting
it. This is done in NewComment, which did not decode the messages nor
the author names, and therefore showed, for example, "&amp;" instead of
"&".

To solve that now the same decoding logic used in GetComments is applied
too in NewComment.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-11-24 17:20:03 +01:00
Daniel Calviño Sánchez 39a4ba2c2e Extract "decodeHtmlEntities" function to its own file
This will make possible to use it from files other than
"GetComments.js".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-11-24 17:20:03 +01:00
Louis Chemineau 97dbec035b Do not check quota for non Node
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-11-24 15:23:21 +00:00
Vincent Petry 8a30b17030 Merge pull request #35395 from nextcloud/stable24-audit-fix
[stable24] Update some libs
2022-11-24 16:20:09 +01:00
Vincent Petry ca42047ac5 Recompile
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-24 11:00:25 +01:00
Vincent Petry 8a908d8bda Update some libs
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-24 10:23:17 +01:00
blizzz f1a43e3cf9 Merge pull request #35351 from nextcloud/backport/35327/stable24
[stable24] Handle badly named version files more gracefully and log information
2022-11-24 09:41:57 +01:00
Nextcloud bot 75eb325d75 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-24 02:17:51 +00:00
blizzz a2714ac1be Merge pull request #35332 from nextcloud/backport/35232/stable24
[stable24] Check quota on file copy
2022-11-23 21:02:49 +01:00
Louis 8707beb89c Merge pull request #35367 from nextcloud/backport/35353/stable24
[stable24] Update cache when file size === 0
2022-11-23 19:39:59 +01:00
Julius Härtl 1861e98b13 Merge pull request #35349 from nextcloud/backport/35299/stable24 2022-11-23 18:33:02 +01:00
blizzz 99d70e8602 Merge pull request #35356 from nextcloud/backport/35206/stable24
[stable24] Fix forwarding the object id when searching comments
2022-11-23 18:28:05 +01:00
blizzz 65595260e5 Merge pull request #35018 from nextcloud/backport/35000/stable24
[stable24] Only show cron warning after 24h due to time insensitive jobs
2022-11-23 18:25:40 +01:00
Louis Chemineau cadcebf962 Update cache when file size === 0
The conditions were false when $result === 0.
$results here contains the number of written bits.
The correct way of checking for operation success is to check if $result === false

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-11-23 15:04:34 +00:00
Louis abafbd4b6e Merge pull request #35321 from nextcloud/backport/stable24/35187
[stable24] Fix mentions rendering in comment editor
2022-11-23 13:17:33 +01:00
Joas Schilling c892ba43d1 Fix forwarding the object id when searching comments
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-23 10:42:25 +00:00
Côme Chilliet 00c17b2df1 Handle badly named version files more gracefully and log information
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-23 09:52:17 +00:00
Greta 69d59d3f66 Merge pull request #35328 from nextcloud/backport/35009/stable24
[stable24] Check quota on file copy
2022-11-23 10:39:04 +01:00
kavita.sonawane@t-systems.com 3dd01de38a Prevent selection of encrypted folders
Signed-off-by: kavita.sonawane@t-systems.com <kavita.sonawane@t-systems.com>
2022-11-23 10:29:27 +01:00
kavita.sonawane@t-systems.com 323b4a6df1 Prevents the selection of encrypted folder on next page load
Signed-off-by: kavita.sonawane@t-systems.com <kavita.sonawane@t-systems.com>
2022-11-23 10:29:24 +01:00
kavita.sonawane@t-systems.com 4cccb99e09 Prevents the selection of encrypted folder on scroll page
Signed-off-by: kavita.sonawane@t-systems.com <kavita.sonawane@t-systems.com>
2022-11-23 10:29:20 +01:00
kavita.sonawane@t-systems.com 7650732af7 Deactivates the possiblility to checkmark or click on the encrypted folder
Signed-off-by: kavita.sonawane@t-systems.com <kavita.sonawane@t-systems.com>
2022-11-23 10:29:17 +01:00
kavita.sonawane@t-systems.com 29b672bbc4 Add comments for prevents the selection of encrypted folders
Signed-off-by: kavita.sonawane@t-systems.com <kavita.sonawane@t-systems.com>
2022-11-23 10:29:10 +01:00
kavita.sonawane@t-systems.com 5f43439b26 Filelist:-Deselecting all files checkboxes within cells of encrypted folder
Signed-off-by: kavita.sonawane@t-systems.com <kavita.sonawane@t-systems.com>
2022-11-23 10:29:03 +01:00
Nextcloud bot c610950ccd [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-23 02:18:27 +00:00
Côme Chilliet 8e75d2fc85 Apply the same fix as on beforeCopy on beforeMove
Let’s be safe

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-22 13:53:11 +00:00
Robin Appelman 438bc818bb fix dirname usage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-22 13:53:11 +00:00
Côme Chilliet 079a481673 Fix psalm issues
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-22 13:53:10 +00:00
Côme Chilliet 529e6e9914 Check quota on file copy
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-22 13:53:10 +00:00
Côme Chilliet d07c5c6d2d Apply the same fix as on beforeCopy on beforeMove
Let’s be safe

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-22 13:56:31 +01:00
Robin Appelman 8a14131a84 fix dirname usage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-22 13:56:25 +01:00
Côme Chilliet 5aab36a3f6 Fix psalm issues
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-22 13:56:17 +01:00
Côme Chilliet 595d7add27 Check quota on file copy
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-22 13:56:10 +01:00
Côme Chilliet ffdf7834ab Merge pull request #35297 from nextcloud/fix/bump-swiftmailer/swiftmailer-to-6.3.0-in-stable24
Bump swiftmailer/swiftmailer to 6.3.0 in stable24
2022-11-22 11:21:38 +01:00
Louis Chemineau 6a78d3d21b Fix mentions rendering in comment editor
NcRichContentEditable needs an index of users to properly display them. This commit adds a caching logic and provides it to NcRichContentEditable.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-11-22 11:02:04 +01:00
Simon L 293602274a Merge pull request #35313 from nextcloud/stable24-user-mgmt-quota-no-cache
[stable24] Don't use quota cache through user management
2022-11-22 10:46:41 +01:00
Côme Chilliet 017b0f5f63 Merge pull request #35162 from nextcloud/backport/35157/stable24
[stable24] Make sure to not pass null to DateTime::createFromFormat
2022-11-22 10:09:45 +01:00
Côme Chilliet 1643302299 Align 3rdparty with stable24
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-22 09:54:30 +01:00
John Molakvoæ 2066cc4bad Fix version string
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2022-11-22 08:42:15 +01:00
Nextcloud bot 942c439236 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-22 02:19:35 +00:00
Vincent Petry c39caba4a0 Don't use quota cache through user management
When querying the free space through user management APIs, don't use the
cached quota value. The latter is only there to accelerate PROPFINDs.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-21 23:47:10 +01:00
Simon L c56fcca872 Merge pull request #35250 from nextcloud/bugfix/noid/quota-zero
[stable24] Properly compare quota against both float/int values
2022-11-21 18:39:49 +01:00
blizzz 284ba2449c Merge pull request #34966 from nextcloud/backport/34963/stable24
[stable24] Fix invalid date in security.txt
2022-11-21 15:50:03 +01:00
Arthur Schiwon cf95689ff9 24.08 RC1
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-11-21 15:37:14 +01:00
Côme Chilliet fd7f0166b6 Bump swiftmailer/swiftmailer to 6.3.0 in stable24
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-21 11:03:05 +01:00
Côme Chilliet e24df2255d Merge pull request #35141 from nextcloud/backport/34160/stable24
[stable24] Detect weird local ips
2022-11-21 09:33:17 +01:00
Vincent Petry f4d1eee558 Merge pull request #35292 from nextcloud/backport/35185/stable24
[stable24] Hide warning about missing apps for when shipped in the next version
2022-11-21 09:32:48 +01:00
Joas Schilling ce2ce275b3 Hide warning about missing apps for when shipped in the next version
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-21 07:18:44 +00:00
Nextcloud bot db82cc0fcf [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-21 02:15:45 +00:00
Nextcloud bot 02595dfbc3 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-20 02:16:05 +00:00
Joas Schilling 9f8b6e99da Merge pull request #35245 from nextcloud/backport/32288/stable24
[stable24] Fix JSON error when comment has no reactions
2022-11-19 20:44:09 +01:00
Nextcloud bot 77dccd3765 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-19 02:17:53 +00:00
Simon L 0758d81d96 Merge pull request #35266 from nextcloud/backport/35259/stable24
[stable24] Also cancel XHR when cancelling uploads
2022-11-18 21:16:41 +01:00
Vincent Petry 36f2a2d94f Also cancel XHR when cancelling uploads
Fixes issue when cancelling a long list of uploads.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-18 17:19:21 +00:00
Simon L d9ad303158 Merge pull request #35258 from nextcloud/backport/35218/stable24
[stable24] delay updating setup providers untill we register the mounts
2022-11-18 17:42:49 +01:00
Robin Appelman 4b4b80bc1c delay updating setup providers untill we register the mounts
otherwise the fallback to a full setup for a missing cached mount provider will lead to a race condition

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-18 14:38:30 +00:00
Julius Härtl f66226d18e Properly compare quota against both float/int values
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-18 14:12:43 +01:00
Joas Schilling 3f1865b729 Fix JSON error when comment has no reactions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-18 11:13:54 +01:00
Nextcloud bot 55698aa94f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-18 02:13:44 +00:00
Côme Chilliet 5c6c1c0e11 Update 3rdparty to latests stable24
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-17 16:53:57 +01:00
Joas Schilling ff9569256e Merge pull request #35200 from nextcloud/backport/35096/stable24
[stable24] Mark more config values as sensitive
2022-11-17 12:06:03 +01:00
Nextcloud bot 1ff39cf433 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-17 02:14:43 +00:00
Simon L c091ffc3e8 Merge pull request #35215 from nextcloud/backport/35210/stable24
[stable24] Fix settings for setting default expiration date
2022-11-16 23:36:36 +01:00
Vincent Petry 1d627fd1f8 Fix settings for setting default expiration date
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-11-16 15:45:03 +00:00
Joas Schilling 996bb092ff Mark more config values as sensitive
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-16 10:08:04 +01:00
Nextcloud bot ea0fbda1eb [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-16 02:14:57 +00:00
Simon L ce46ba184f Merge pull request #35114 from nextcloud/backport/33631/stable24
[stable24] use the updated mariadb10.6 container in drone
2022-11-15 13:25:20 +01:00
Richard Steinmetz 479aa6fae2 Merge pull request #35115 from nextcloud/backport/35105/stable24
[stable24] Fix distorted previews when using imaginary
2022-11-15 10:58:32 +01:00
Nextcloud bot d3c68c1b18 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-15 02:15:46 +00:00
Côme Chilliet eb8b008b1f Make sure to not pass null to DateTime::createFromFormat
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 18:43:15 +00:00
Joas Schilling 3de4f8fc6e Merge pull request #35140 from nextcloud/revert-35113-backport/35015/stable24
Revert "[stable24] Appropriate length check in Notification.php"
2022-11-14 12:49:52 +01:00
Simon L 8720abf523 Merge pull request #35134 from nextcloud/backport/35093/stable24
[stable24] Run integration tests on 3rdparty bump
2022-11-14 11:51:45 +01:00
Côme Chilliet 9a774bdec3 Add mlocati/ip-lib dependency
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 11:15:39 +01:00
Côme Chilliet 4019ef3405 Fix idn_to_utf8 stub signature
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 11:15:02 +01:00
Joas Schilling 36ea2748be Revert "[stable24] Appropriate length check in Notification.php" 2022-11-14 11:14:57 +01:00
Côme Chilliet e0d588b390 Fix tests for nested v4 in v6
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 11:14:46 +01:00
Côme Chilliet 012576a3f4 Use new dependency to normalize IPs
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 11:14:39 +01:00
Côme Chilliet 1eed8fd539 Add missing urldecode and idn_to_utf8 calls to local address checker
The call to idn_to_utf8 call is actually to apply normalization

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 11:14:29 +01:00
Côme Chilliet e5b4a097e8 Harden tests for local IP detection in URLs
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 11:13:55 +01:00
Simon L 75568b8911 Merge pull request #35131 from nextcloud/backport/35070/stable24
[stable24] [LDAP] always create instance of own user manager
2022-11-14 10:42:05 +01:00
Joas Schilling 9aa3496913 Run integration tests on 3rdparty bump
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
2022-11-14 08:57:28 +00:00
Nextcloud bot 5643a62fcc [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-14 02:15:45 +00:00
Arthur Schiwon 664c4f6c26 [LDAP] always create instance of own user manager
- it is config specific and cannot be shared
- because the Access instance is bound later, it is not obvious from the
  constructor

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-11-13 22:23:10 +00:00
Simon L 80040cb659 Merge pull request #35113 from nextcloud/backport/35015/stable24
[stable24] Appropriate length check in Notification.php
2022-11-13 18:26:07 +01:00
Nextcloud bot b4b206c269 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-13 02:14:45 +00:00
Nextcloud bot 685e0f93f0 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-12 02:15:08 +00:00
Richard Steinmetz 939abffcce Fix distorted previews when using imaginary
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2022-11-11 21:51:43 +00:00
Simon L f82c0d5ee8 use the updated mariadb10.6 container in drone
Signed-off-by: Simon L <szaimen@e.mail.de>
2022-11-11 21:43:48 +01:00
natoponen d4f9b8286a Appropriate length check in Notification.php
There is an issue(bug) when using UTF-8 symbols in any method, which checks the length of string as `isset($id[64])`. You can set only 32 UTF-8 symbols because they are 2 byte, and this "array" check seems inapropriate in this case, as it throws unexpected exceptions.

Signed-off-by: natoponen <57988162+natoponen@users.noreply.github.com>
2022-11-11 20:09:24 +00:00
Joas Schilling 303ede8c8c Merge pull request #35088 from nextcloud/backport/35074/stable24
[stable24] Make sure that path is normalized and then checked,
2022-11-11 15:52:45 +01:00
Joas Schilling 7b7ae291c5 Merge pull request #35101 from nextcloud/backport/35077/stable24
[stable24] Fix PublicKeyTokenProviderTest import and mock
2022-11-11 15:51:54 +01:00
Christoph Wurst b059ea1175 Fix PublicKeyTokenProviderTest import and mock
* IDBConnection import missing
* Atomic doesn't need a mock

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-11 09:39:43 +00:00
Nextcloud bot 152b63f379 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-11 02:14:17 +00:00
Julius Härtl af87f280d0 Merge pull request #35049 from nextcloud/backport/34834/stable24
[stable24] Fix size calculation on copying the skeleton files
2022-11-10 21:31:00 +01:00
Côme Chilliet 4d6fdad722 Make sure that path is normalized and then checked,
and not the other way around

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-10 18:06:07 +00:00
Pytal 97f2518b9e Merge pull request #35065 from nextcloud/backport/35063/stable24
[stable24] Fix top margin in empty versions list
2022-11-10 09:13:19 -08:00
Robin Appelman fd452e51c1 Merge pull request #35039 from nextcloud/backport/32211/stable24
[stable24] Add repair command to fix wrong share ownership
2022-11-10 17:17:23 +01:00
Richard Steinmetz 3989b05832 Fix top margin in empty versions list
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-11-10 09:54:14 +00:00
Christoph Wurst 8f2cf3fb87 Merge pull request #35059 from nextcloud/backport/35042/stable24
[stable24] Add description for calendar uri
2022-11-10 08:32:30 +01:00
Nextcloud bot bd4fe22f52 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-10 02:15:42 +00:00
Pytal 04d1cfe4fe Merge pull request #35061 from nextcloud/backport/35052/stable24 2022-11-09 16:08:09 -08:00
Daniel Calviño Sánchez e606db168a Fix sidebar not automatically hidden in Files app
Although the Files app creates the legacy sidebar (details view) it is
then replaced with the newer Vue app sidebar. Due to this ".detailsView"
no longer finds an element and therefore nothing was hidden when
"hideAppSidebar($('.detailsView'))" was called (for example, when
changing to another section).

However, "OC.Apps.hideAppSidebar()" does not properly work either with
the Vue sidebar used in the Files app (once hidden the sidebar is not
shown again). For simplicity, and to avoid any possible side effect in
other apps from changing "OC.Apps.hideAppSidebar", now
"OC.Files.Sidebar.close()" is used instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-11-09 19:14:49 +00:00
Christopher Ng 6f6e2796de Add description for calendar uri
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-11-09 18:26:02 +00:00
Julius Härtl ed6ef37dd1 Use proper storage method for writing skeleton files
otherwise the filecache will have a wrong size for skeleton files

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-09 13:11:16 +01:00
Nextcloud bot 6b5a8eec4c [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-09 02:14:46 +00:00
Robin Appelman b6f7952d2c update autoloader
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 22:38:42 +00:00
Robin Appelman 5f6c17610f fix repairing non user shares when repairing all shares
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 22:38:39 +00:00
Robin Appelman fe31b6f6cd remove no longer needed code
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 22:38:39 +00:00
Robin Appelman 22e053771a split repairing into two stages to prevent long open transaction
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 22:38:34 +00:00
Robin Appelman 54177019f2 update shares directly in db
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 22:38:33 +00:00
Vincent Petry 52f10b18ee More verbose output for repair share ownership cmd
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-08 22:38:33 +00:00
Robin Appelman a4edde3f70 move share owner repair to occ command
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 22:38:32 +00:00
Louis Chemineau 7dafaf9f13 Add repair step to fix wrong share ownership
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-11-08 22:38:32 +00:00
Simon L 205b99cf08 Merge pull request #35022 from nextcloud/backport/32838/stable24
[stable24] Cast to int
2022-11-08 13:04:38 +01:00
Richard Steinmetz a97d9e85d1 Merge pull request #35019 from nextcloud/backport/34909/stable24
[stable24] Fix duplicate event email notifications
2022-11-08 11:05:12 +01:00
Markus Zeller 09cdccb3d3 Cast to int #32837
Signed-off-by: Markus Zeller <git@markuszeller.com>
2022-11-08 10:01:36 +00:00
Simon L e9e248dd13 Merge pull request #35012 from nextcloud/backport/35007/stable24
[stable24] Fix unsuccessful token login logged as error
2022-11-08 10:50:57 +01:00
Richard Steinmetz af2123093d Fix duplicate event email notifications
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2022-11-08 09:42:56 +01:00
Joas Schilling 68e1a83935 Only show cron warning after 24h due to time insensitive jobs
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-08 09:15:11 +01:00
Nextcloud bot 1f71bfec2d [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-08 02:14:32 +00:00
Christoph Wurst 05a22831e1 Fix unsuccessful token login logged as error
The condition of a non-existent login token can happen for concurrent
requests. Admins can not do anything about this. So this is to be
expected to happen occasionally. This event is only bad if none of the
requests is able to re-acquire a session. Luckily this happens rarely.

If a login loop persists an admin can still lower the log level to find
this info. But a default error log level will no longer write those
infos about the failed cookie login of one request.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-07 17:52:13 +00:00
Simon L 29e31f4da8 Merge pull request #35005 from nextcloud/backport/34937/stable24
[stable24] Avoid a crash when a PHP extension has no version
2022-11-07 17:46:20 +01:00
Côme Chilliet 9d377a1751 Suppress false-positives from psalm, waiting for fix upstream
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-07 13:32:14 +00:00
Côme Chilliet fe5ac24949 Avoid a crash when a PHP extension has no version
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-07 13:32:13 +00:00
Nextcloud bot 3e97bee363 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-07 02:14:25 +00:00
Nextcloud bot 53e4c51583 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-06 02:12:55 +00:00
Nextcloud bot 7e434978bd [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-05 02:15:23 +00:00
Vincent Petry 52c3238959 Merge pull request #33888 from nextcloud/dependabot/composer/build/integration/stable24/guzzlehttp/guzzle-7.5.0
Update guzzlehttp/guzzle requirement from 7.4.5 to 7.5.0 in /build/integration
2022-11-04 17:44:56 +01:00
Vincent Petry 1f730ec9e2 Merge pull request #34659 from nextcloud/backport/34632/stable24
[stable24] Add rate limiting on lost password emails
2022-11-04 17:30:13 +01:00
Vincent Petry 8b4fe66c14 Merge pull request #34855 from nextcloud/backport/34799/stable24
[stable24] Emit typed event when preview is requested
2022-11-04 17:20:43 +01:00
Vincent Petry 89d3c2227e Merge pull request #34942 from nextcloud/backport/34577/stable24
[stable24] Avoid double ldap_unbind in Wizard.php
2022-11-04 17:16:12 +01:00
Vincent Petry 2efb811301 Merge pull request #34947 from nextcloud/backport/34804/stable24
[stable24] Skip general login with email for non-valid addresses and LDAP
2022-11-04 17:13:30 +01:00
Vincent Petry 68a643d5cb Merge pull request #34949 from nextcloud/backport/32663/stable24
[stable24] Cleanup tempfiles after each cron job run
2022-11-04 17:11:37 +01:00
Vincent Petry 719d88c3ac Merge pull request #34952 from nextcloud/backport/34379/stable24
[stable24] Run session token renewals in a database transaction
2022-11-04 17:11:03 +01:00
Joas Schilling e756995768 Fix invalid date in security.txt
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-04 10:14:49 +00:00
Nextcloud bot 4e1ec1c4f4 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-04 02:14:21 +00:00
Côme Chilliet 7dc7d0cb11 Fix LostController test
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-03 17:52:08 +01:00
Côme Chilliet 26574db8ab Add rate limiting on lost password emails
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-03 17:50:59 +01:00
Christoph Wurst 6d2677b2bb Run session token renewals in a database transaction
The session token renewal does
1) Read the old token
2) Write a new token
3) Delete the old token

If two processes succeed to read the old token there can be two new tokens because
the queries were not run in a transaction. This is particularly problematic on
clustered DBs where 1) would go to a read node and 2) and 3) go to a write node.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-03 16:39:41 +01:00
Julius Härtl 2bd6523136 Cleanup tempfiles after each cron job run
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-03 16:01:45 +01:00
Julius Härtl 91a4444c2b Skip general login with email for non-valid addresses and LDAP
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-03 15:40:38 +01:00
Côme Chilliet a78b6767ec Avoid double ldap_unbind in Wizard.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-03 13:18:19 +00:00
Côme Chilliet 56703e9187 Fix code style with codesniffer
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-03 13:18:18 +00:00
blizzz 7f47000def Merge pull request #34914 from nextcloud/release/24.0.7
24.0.7
2022-11-03 10:54:23 +01:00
Nextcloud bot f4da39facc [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-03 02:14:20 +00:00
Nextcloud bot 21ac195305 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-02 02:14:21 +00:00
Arthur Schiwon ea4e66aa66 24.0.7
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-11-01 20:10:58 +01:00
Nextcloud bot 99aa1baf49 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-01 02:14:27 +00:00
Nextcloud bot 6d776051e5 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-31 02:14:05 +00:00
Nextcloud bot d419c69f44 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-30 02:13:53 +00:00
Nextcloud bot 9b027a8b1a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-29 02:15:29 +00:00
Nextcloud bot 8a4e974d7b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-28 02:14:31 +00:00
Julius Härtl 6dc2b162c5 Emit typed event when preview is requested
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-10-27 18:51:53 +02:00
John Molakvoæ e8a69778d3 Merge pull request #34770 from nextcloud/backport/34579/stable24
[stable24] fix null error in getUnencryptedSize
2022-10-27 18:12:46 +02:00
John Molakvoæ 6357b97d0b Merge pull request #34838 from nextcloud/release/24.0.7_rc1
24.0.7 RC1
2022-10-27 18:12:29 +02:00
John Molakvoæ b655bfb14e Merge pull request #34845 from nextcloud/dependaskjnldsv/32413/stable24
[stable24] Fix psalm errors fron the end of the baseline file
2022-10-27 18:00:30 +02:00
Carl Schwan 3ec8dce3cc Fix psalm errors fron the end of the baseline file
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-27 15:50:22 +02:00
John Molakvoæ 04ec0d7f97 Merge pull request #34440 from nextcloud/backport/32635/stable24 2022-10-27 14:26:27 +02:00
Marcel Klehr 7710ea24bf Merge pull request #34798 from nextcloud/backport/33405/stable24 2022-10-27 13:58:58 +02:00
Vincent Petry 1524b5fd25 Merge pull request #34797 from nextcloud/backport/33540/stable24
[stable24] fix updating cached mounts that didn't have their mount provider set previously
2022-10-27 13:36:33 +02:00
Vincent Petry aad2525cf5 Merge pull request #34840 from nextcloud/backport/34502/stable24
[stable24]  Propagate attributes when resharing
2022-10-27 13:20:58 +02:00
John Molakvoæ 220d71d997 Merge pull request #34410 from nextcloud/backport/33566/stable24 2022-10-27 12:29:17 +02:00
John Molakvoæ a117878240 Merge pull request #34032 from nextcloud/backport/34019/stable24
[stable24] Fix quota type to int
2022-10-27 12:10:28 +02:00
John Molakvoæ 986c9c7fdd Merge pull request #34040 from nextcloud/backport/34001/stable24 2022-10-27 12:10:05 +02:00
John Molakvoæ f4a3168244 Merge pull request #34460 from nextcloud/backport/31947/stable24
[stable24] Fix Error: Undefined index: redirect_url
2022-10-27 12:09:28 +02:00
Christopher Ng 7cdc579026 Fix inverted profile picture
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-10-27 10:04:07 +00:00
Andy Xheli 029a9ee39f Update ContactsStoreTest.php
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
2022-10-27 10:04:07 +00:00
Andy Xheli 053a4bdf1f Update lib/private/Contacts/ContactsMenu/ContactsStore.php
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>

Tested no issues.

Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
2022-10-27 10:04:06 +00:00
Andy Xheli a5be8ddf6d Update ContactsStore.php
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
2022-10-27 10:04:06 +00:00
Andy Xheli 98e9414c70 Apply suggestions from code review
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>

Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
2022-10-27 10:04:06 +00:00
Andy Xheli 731e0a0530 Fix User profile picture when performing the search
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>

Before 
![image](https://user-images.githubusercontent.com/59488153/140980158-b9108161-57ab-48b4-ae6f-98ec4e72775a.png)

After




Fix for #31065
2022-10-27 10:04:06 +00:00
Marcel Klehr 67af99e14e DB mounts table: Add index for mount_provider_class
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2022-10-27 11:56:37 +02:00
Vincent Petry c502729d56 Merge pull request #34584 from nextcloud/backport/34438/stable24
[stable24] return proper error code when reporting exception fails in remote.php
2022-10-27 10:54:34 +02:00
Vincent Petry 9ca4d1368d Merge pull request #34447 from nextcloud/backport/34302/stable24
[stable24] Fix: Prevent deadlocks during mtime/size/etag propagation
2022-10-27 10:53:57 +02:00
Carl Schwan 8ba1b3f574 More fixes
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-27 10:49:00 +02:00
Carl Schwan 158b55747b Small progress with fixing unit tests
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-27 10:48:56 +02:00
Carl Schwan ff653f4d76 Propagate attributes when resharing
When updating a share, load the node from the initiator instead of the
owner similar to how this is done when creating the share.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-27 10:48:48 +02:00
Vincent Petry 637a58f18f Merge pull request #34355 from nextcloud/backport/34348/stable24
[stable24] Fix renaming in shared with you file list
2022-10-27 10:46:10 +02:00
John Molakvoæ 9371187faa 24.0.7 RC1
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-10-27 10:21:04 +02:00
Nextcloud bot c4d4751460 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-27 02:14:11 +00:00
dependabot[bot] 48e79c6110 Update guzzlehttp/guzzle requirement in /build/integration
Updates the requirements on [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) to permit the latest version.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/master/CHANGELOG.md)
- [Commits](https://github.com/guzzle/guzzle/compare/7.4.5...7.5.0)

---
updated-dependencies:
- dependency-name: guzzlehttp/guzzle
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-26 19:36:06 +00:00
Julius Härtl d2f436c7c0 Merge pull request #33185 from nextcloud/dependabot/composer/build/integration/stable24/behat/behat-approx-3.11.0 2022-10-26 21:32:51 +02:00
Roeland Jago Douma 16c6d57be2 Merge pull request #34812 from nextcloud/automated/noid/stable24-update-psalm-baseline
[stable24] Update psalm-baseline.xml
2022-10-26 20:00:05 +02:00
Julius Härtl 58da82e76d Merge pull request #34824 from nextcloud/backport/34788/stable24
[stable24] Check share attributes on preview endpoints
2022-10-26 16:49:23 +02:00
Julius Härtl bc3572ebc3 Check share attributes on preview endpoints
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-10-26 13:25:13 +00:00
nextcloud-command 50842d2e71 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2022-10-26 04:30:54 +00:00
Nextcloud bot 7eece690c9 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-26 02:13:58 +00:00
Simon L bf4fbb28c3 Merge pull request #34805 from nextcloud/backport/34706/stable24
[stable24] update notifications for one-click instances
2022-10-25 18:08:47 +02:00
Côme Chilliet 684b3c5a3b Merge pull request #34802 from nextcloud/fix/backport-pre-commit-24
Add pre-commit configuration to stable24 as well
2022-10-25 17:25:38 +02:00
Côme Chilliet 1d778e6ce7 Merge pull request #34795 from nextcloud/backport/34774/stable24
[stable24] Expose mapped user count from LDAP and use that for user limit check
2022-10-25 17:21:50 +02:00
raul bdbacdffc2 Fix unencrypted size calculation for files created before the Encryption storage is enabled
Signed-off-by: raul <raul@nextcloud.com>
2022-10-25 15:08:22 +00:00
raul ba12309f3c Fix: Prevent deadlocks during mtime/size/etag propagation
Signed-off-by: raul <raul@nextcloud.com>
2022-10-25 15:08:22 +00:00
szaimen beaecb2df5 update notifications for one-click instances
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-10-25 14:50:17 +00:00
Côme Chilliet 3d5f2ced64 add .pre-commit-config.yaml to expected files in checker
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-10-25 14:57:07 +02:00
Côme Chilliet 065edd7b9f Fix autoloaders
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-10-25 14:51:03 +02:00
Côme Chilliet 52c96c2ba9 Update lib/public/User/Backend/ICountMappedUsersBackend.php
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2022-10-25 14:51:03 +02:00
Côme Chilliet d51167cf68 Add missing file
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-10-25 14:51:02 +02:00
Côme Chilliet 076765068c Expose mapped user count from LDAP and use that for user limit check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-10-25 14:50:56 +02:00
Vincent Petry 02334ce03a Merge pull request #34730 from nextcloud/backport/33945/stable24
[stable24] LDAP to not register new users when outside of fair use or over limits
2022-10-25 14:49:50 +02:00
Côme Chilliet ed70e643cc Backport pre-commit config from master
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-10-25 14:07:39 +02:00
Daniel d247123d1f Merge pull request #34792 from nextcloud/backport/32859/stable24
[stable24] Fix Uninitialized string offset 0 at GenerateMimetypeFileBuilder.php#39
2022-10-25 14:03:43 +02:00
Robin Appelman 82b915e7bb add tests for cached mount provider migration
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-10-25 10:48:30 +00:00
Robin Appelman dc0dcad920 fix updating cached mounts that didn't have their mount provider set previously
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-10-25 10:48:30 +00:00
Côme Chilliet fa5b0f307d Fix return types of createUser method
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-10-25 12:20:08 +02:00
Daniel Kesselberg a7bf60772a Fix Uninitialized string offset 0 at GenerateMimetypeFileBuilder.php#39
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-10-25 08:31:59 +00:00
Nextcloud bot d48f13a3c6 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-25 02:18:51 +00:00
Robin Appelman 29c359d7e7 fix null error in getUnencryptedSize
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-10-24 13:34:52 +00:00
Côme Chilliet 51b295fad3 Fix createUser return type in docblock to match code
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-10-24 10:20:17 +02:00
Côme Chilliet 0f07e43760 Get rid of calls to OCP\Server which is not available is 24
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-10-24 10:11:06 +02:00
blizzz 2228a7b374 extended hint message
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: blizzz <blizzz@arthur-schiwon.de>
2022-10-24 10:06:57 +02:00
Arthur Schiwon 6bedcfe1f5 improve admin notification experience
- do not stack notifications, replace them
- and replace them once a day only
- with LDAP it might end in total spam terror (also push) otherwise

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-10-24 10:06:49 +02:00
Arthur Schiwon 74322a7631 [LDAP] throw exception only against prov api
- unbreaks functionality for end users when on demand mapping takes
  place

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-10-24 10:06:39 +02:00
Arthur Schiwon 6b220fffb7 LDAP to no register new users when outside of fair use or over limits
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-10-24 10:05:31 +02:00
Nextcloud bot 9751349fce [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-24 02:15:10 +00:00
Simon L c797062e86 Merge pull request #34750 from nextcloud/backport/33087/stable24
[stable24] fix external storages access
2022-10-23 16:54:26 +02:00
szaimen e8440853b1 fix external storages access
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-10-23 09:32:55 +00:00
Nextcloud bot 512dffc341 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-23 02:14:55 +00:00
Nextcloud bot 6d51a695c1 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-22 02:15:58 +00:00
Nextcloud bot 9e79b62bb3 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-21 02:14:53 +00:00
Anna c468d82e8e Merge pull request #34381 from nextcloud/backport/34289/stable24
[stable24] Url encode the web dav url for copying
2022-10-20 11:48:01 +02:00
Nextcloud bot 8ce85123b9 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-20 02:18:47 +00:00
blizzz 65ff575be5 Merge pull request #34454 from nextcloud/backport/33737/stable24
[stable24] Makes untrusted domain error on info
2022-10-19 11:03:20 +02:00
Nextcloud bot 9335ee3a81 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-19 02:14:48 +00:00
Nextcloud bot baa373e40a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-18 02:14:45 +00:00
Nextcloud bot 6599560bf5 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-17 02:14:51 +00:00
Nextcloud bot 19d34ed28e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-16 02:14:47 +00:00
Nextcloud bot b0f5324438 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-15 02:14:41 +00:00
Julien Veyssier 194a2d14ae Merge pull request #34600 from nextcloud/backport/34135/stable24
[stable24] Fix "email changed" activity email check
2022-10-14 18:01:54 +02:00
Robin Appelman 013451cbf4 return proper error code when reporting exception fails in remote.php
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-10-14 16:28:49 +02:00
Julien Veyssier f7b066a6b3 check disable_activity.email_address_changed_by_admin when email is changed by admin via the OCS API
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-10-14 09:24:01 +00:00
Nextcloud bot d28a5957e7 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-14 02:14:56 +00:00
Nextcloud bot a50b34fe19 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-13 02:15:18 +00:00
Vincent Petry 955bd21f7b Merge pull request #34552 from nextcloud/backport/34537/stable24
[stable24] Avoid allocating too much memory for the buffer on s3 uploads
2022-10-12 15:02:06 +02:00
Julius Härtl 19ed7a5bf6 Avoid allocating too much memory for the buffer
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-10-12 08:35:46 +00:00
Louis 38752c9fce Merge pull request #34532 from nextcloud/backport/34500/stable24
[stable24] Fix password length limitation
2022-10-12 09:51:01 +02:00
Nextcloud bot 9b119972aa [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-12 02:14:47 +00:00
Joas Schilling 9943387afd Fix password length limitation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-10-11 16:52:05 +00:00
Joas Schilling 1398a2b49e Merge pull request #34527 from nextcloud/backport/34522/stable24
[stable24] Update security.txt expires field
2022-10-11 15:07:29 +02:00
Joas Schilling ac5ad53db8 Merge pull request #34518 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] Update ca-cert bundle
2022-10-11 11:21:54 +02:00
Joas Schilling 6323f86885 Update security.txt expires field
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-11 08:11:17 +00:00
nextcloud-command 739daa84f1 Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2022-10-11 04:40:29 +00:00
Nextcloud bot 0f03133f3b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-11 02:14:50 +00:00
Louis b6d5600778 Merge pull request #34506 from nextcloud/backport/30608/stable24
[stable24] Harden disk_free_space check in CheckSetupController
2022-10-11 00:23:41 +02:00
acsfer ad311c3bab Harden some PHP functions
To avoid things like https://github.com/nextcloud/server/issues/26034

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-10-10 19:08:34 +00:00
Nextcloud bot ae8e433b4e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-09 02:14:20 +00:00
Nextcloud bot e4872ebdf2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-08 02:14:47 +00:00
Nextcloud bot cb11c680b5 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-07 02:14:26 +00:00
Andy Xheli f948b29ccc Fix Error: Undefined index: redirect_url
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>

Should fix Undefined index: redirect_url at core/templates/twofactorsetupselection.php #21968
2022-10-06 21:57:39 +00:00
Andy Xheli b5f330fc94 Makes untrusted domain error on info
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>

Since https://github.com/nextcloud/server/commit/e6d9ef2e38daffcab808eaa41b18ab16c6253b97 was applied logs get filled up with Trusted domain error. "X.X.X.X tried to access using "X.X.X.X" as host alot of users missed important errors do tohttps://github.com/nextcloud/server/commit/e6d9ef2e38daffcab808eaa41b18ab16c6253b97   please see https://github.com/nextcloud/server/issues/32599

This should fix. 
https://github.com/nextcloud/server/issues/32599#event-7281164903


Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
2022-10-06 16:28:32 +00:00
Robin Appelman 8cf947f0da trigger a rescan when trying to fopen a file that exists in cache but not on disk
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-10-06 14:30:14 +02:00
Robin Appelman 6023dee5ae add test for trying to fopen a file which no longer exists on disk
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-10-06 14:28:00 +02:00
blizzz 3aabb381b9 Merge pull request #34393 from nextcloud/release/24.0.6
24.0.6
2022-10-06 10:30:43 +02:00
Nextcloud bot de5451184e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-06 02:19:08 +00:00
Nextcloud bot 048e49a9e0 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-05 02:14:24 +00:00
Nextcloud bot fd56d3e08f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-04 02:14:33 +00:00
Robin Appelman d230c91677 use filesystem user instead of file owner for creating version
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-10-03 17:49:15 +02:00
Anna Larch a2063d6f6c Url encode the web dav url for copying
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-10-03 10:05:37 +00:00
Arthur Schiwon 13d94d191c 24.0.6
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-10-03 11:06:06 +02:00
Nextcloud bot a78956fb97 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-03 02:17:40 +00:00
Nextcloud bot 986feb4942 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-02 02:17:10 +00:00
Nextcloud bot d2de6eaba5 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-01 02:17:03 +00:00
Vincent Petry f16367a26a Fix renaming in shared with you file list
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-09-30 18:28:35 +00:00
blizzz 2993aaa2b0 Merge pull request #34341 from nextcloud/backport/34328/stable24
[stable24] Correctly handle Redis::keys returning false
2022-09-30 12:56:15 +02:00
Côme Chilliet c99982bae9 Correctly handle Redis::keys returning false
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-30 08:23:33 +00:00
Nextcloud bot be7d54eb13 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-30 02:55:43 +00:00
blizzz 8eac15725d Merge pull request #34275 from nextcloud/release/24.0.6_rc1
24.0.6 RC1
2022-09-29 12:41:30 +02:00
Nextcloud bot 7c052cb256 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-29 02:33:26 +00:00
Nextcloud bot b45010e002 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-28 02:32:54 +00:00
blizzz 2dfd59e5bf Merge pull request #33970 from nextcloud/backport/33804/stable24
[stable24] always use the default fs owner when storing versions
2022-09-27 23:22:58 +02:00
blizzz 38ce082d11 Merge pull request #34228 from nextcloud/backport/34117/stable24
[stable24] Show long names correctly on profile card
2022-09-27 08:51:55 +02:00
blizzz 20cd49c842 Merge pull request #34111 from nextcloud/backport/34073/stable24
[stable24] dont try email login if the provider username is not a valid email
2022-09-27 08:50:47 +02:00
blizzz 1ac1aff613 Merge pull request #34089 from nextcloud/backport/34035/stable24
[stable24] Do not output a warning when a file is not found
2022-09-27 08:49:23 +02:00
blizzz bd9ab80f87 Merge pull request #33798 from nextcloud/backport/33332/stable24
[stable24] Fix handling of internal errors when uploading theming files
2022-09-27 08:46:36 +02:00
blizzz ec349fc4c1 Merge pull request #33791 from nextcloud/backport/stable24-wait-for-the-new-user-form-to-be-visible-in-acceptance-tests
[stable24] Wait for the new user form to be visible in acceptance tests
2022-09-27 08:45:48 +02:00
blizzz 0afc3d597f Merge pull request #33787 from nextcloud/backport/33772/stable24
[stable24] Log if cookie login failed with token mismatch or session unavailability
2022-09-27 08:45:13 +02:00
Arthur Schiwon cb98204f59 24.0.6 RC1
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-09-27 08:24:12 +02:00
Nextcloud bot eb43075240 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-27 02:28:21 +00:00
Vincent Petry 7ced89bcc8 Merge pull request #33423 from nextcloud/dependabot/npm_and_yarn/stable24/moment-2.29.4
[stable24] Bump moment from 2.29.3 to 2.29.4
2022-09-26 21:28:14 +02:00
Joas Schilling 58d3194af5 Recompile
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-09-26 19:27:39 +02:00
Joas Schilling 9db84022bb Bump moment from 2.29.3 to 2.29.4
Bumps [moment](https://github.com/moment/moment) from 2.29.3 to 2.29.4.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](moment/moment@2.29.3...2.29.4)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-09-26 19:25:21 +02:00
Joas Schilling 465a69aa4e Merge pull request #34259 from nextcloud/dependabot/npm_and_yarn/stable24/moment-timezone-0.5.37
[stable24] Bump moment-timezone from 0.5.34 to 0.5.37
2022-09-26 19:22:21 +02:00
Joas Schilling d8a83339a3 Recompile
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-09-26 15:17:12 +02:00
Joas Schilling 336fb4f01f Bump moment-timezone from 0.5.34 to 0.5.37
Bumps [moment-timezone](https://github.com/moment/moment-timezone) from 0.5.34 to 0.5.37.
- [Release notes](https://github.com/moment/moment-timezone/releases)
- [Changelog](https://github.com/moment/moment-timezone/blob/develop/changelog.md)
- [Commits](moment/moment-timezone@0.5.34...0.5.37)

---
updated-dependencies:
- dependency-name: moment-timezone
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-09-26 14:53:33 +02:00
Simon L d5f00400f9 Merge pull request #33805 from nextcloud/backport/33396/stable24
[stable24] #33036 [Bug]: Set default expiration date
2022-09-26 13:40:15 +02:00
Nextcloud bot 637cd0282f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-26 02:33:58 +00:00
Nextcloud bot dfa7711eeb [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-25 02:33:08 +00:00
Nextcloud bot 134f3c3502 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-24 02:34:07 +00:00
Git'Fellow e120e972af Switch to overflow-wrap
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-09-23 17:36:40 +00:00
Git'Fellow 1923ecff49 Show long nomes correctly on profile card
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-09-23 17:05:37 +00:00
Nextcloud bot 0bd62988fe [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-23 02:28:48 +00:00
Côme Chilliet 6d819875d6 Merge pull request #34112 from nextcloud/backport/33819/stable24
[stable24] Fix translation of user exists error server-side
2022-09-22 15:14:02 +02:00
Nextcloud bot 85b5d728f9 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-22 02:32:49 +00:00
Nextcloud bot b7510031ef [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-21 02:27:53 +00:00
Pytal f7411c6252 Merge pull request #34159 from nextcloud/backport/34140/stable24 2022-09-20 09:40:24 -07:00
Carl Schwan e73ef4291d Clear search results when remove search query
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-09-20 10:34:06 +00:00
Vincent Petry 1699b908a5 Merge pull request #34128 from nextcloud/automated/noid/stable24-update-ca-cert-bundle
[stable24] Update ca-cert bundle
2022-09-20 10:17:02 +02:00
nextcloud-command 49652c4024 Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2022-09-20 04:49:55 +00:00
Nextcloud bot 3317f6c910 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-20 02:32:55 +00:00
Christopher Ng d864ea3caa Fix test failure introduced in https://github.com/nextcloud/server/pull/33819
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 4de19e9f85)
2022-09-19 18:25:16 +00:00
Nextcloud bot c2a90ca95c [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-19 02:32:34 +00:00
Nextcloud bot 7b3b711760 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-18 02:26:20 +00:00
Nextcloud bot 8232366c6f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-17 02:32:07 +00:00
Christopher Ng 3efc80d097 Fix translation of user exists error server-side
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-09-16 19:06:05 +00:00
Robin Appelman fbebc4bfe7 dont try email login if the provider username is not a valid email
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-09-16 13:27:10 +00:00
Vincent Petry cb0bfae73e Merge pull request #34106 from nextcloud/backport/34100/stable24
[stable24] Reset global search on files sidebar navigation change
2022-09-16 11:43:17 +02:00
Carl Schwan 5e0906388f Merge pull request #34090 from nextcloud/backport/34067/stable24
[stable24] Convert file_metadata.id from int(11) to bigint(20)
2022-09-16 11:05:50 +02:00
Christopher Ng 5e19bdffad Reset global search on files sidebar navigation change
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-09-16 10:23:44 +02:00
Nextcloud bot f26393013a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-16 02:26:34 +00:00
Vincent Petry c63d861375 Merge pull request #33700 from nextcloud/groupfolder-system-encryption-24
[24] make groupfolders use system wide encryption keys
2022-09-15 22:58:05 +02:00
Robin Appelman aafb4f8d5f make groupfolders use system wide encryption keys
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-09-15 15:30:50 +02:00
timm2k 9f6ad21901 Update Version24000Date20220404230027.php
Signed-off-by: timm2k <timm2k@gmx.de>
2022-09-15 12:08:54 +00:00
timm2k 9f32f34b07 Update ConvertFilecacheBigInt.php
Signed-off-by: timm2k <timm2k@gmx.de>
2022-09-15 12:08:54 +00:00
timm2k 76b1d4c7a3 Update CheckSetupController.php
file_metadata.id needs to be bigint(20).

Signed-off-by: timm2k <timm2k@gmx.de>
2022-09-15 12:08:53 +00:00
Côme Chilliet 3ad3bd3039 Do not output a warning when a file is not found
This would spam log with warnings from Desktop client doing HEAD on
 non-existing path to test them.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-15 11:50:49 +00:00
Nextcloud bot e337551fd8 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-15 02:32:04 +00:00
Nextcloud bot 707535c65b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-14 02:27:02 +00:00
Nextcloud bot 05a6b4c23a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-13 02:27:32 +00:00
Carl Schwan cb8be0c632 Fix quota type to int
Change the quota to int from float, since the quota is a number of bits
and a bits can not be splitted.

Fix #34010

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-12 16:35:07 +02:00
Carl Schwan c1953123fe Fix quota type to int
Change the quota to int from float, since the quota is a number of bits
and a bits can not be splitted.

Fix #34010

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-12 13:20:09 +00:00
Simon L 01c0b31c73 Merge pull request #34021 from nextcloud/backport/33921/stable24
[stable24] Do not empty config.php file if reading failed for any reason
2022-09-12 10:54:37 +02:00
Côme Chilliet 6b8b85a375 Do not empty config.php file if reading failed for any reason
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-12 07:48:03 +00:00
Nextcloud bot eda89d9fc9 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-11 02:31:23 +00:00
Nextcloud bot 924118fbb4 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-10 02:30:40 +00:00
dependabot[bot] 106787e156 Merge pull request #33461 from nextcloud/dependabot/npm_and_yarn/stable24/nextcloud/dialogs-3.1.4 2022-09-09 19:32:45 +00:00
dependabot[bot] 07e041fcf1 Bump @nextcloud/dialogs from 3.1.2 to 3.1.4
Bumps [@nextcloud/dialogs](https://github.com/nextcloud/nextcloud-dialogs) from 3.1.2 to 3.1.4.
- [Release notes](https://github.com/nextcloud/nextcloud-dialogs/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-dialogs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-dialogs/compare/v3.1.2...v3.1.4)

---
updated-dependencies:
- dependency-name: "@nextcloud/dialogs"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-09-09 18:30:36 +00:00
Nextcloud bot 8be1211874 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-09 02:26:37 +00:00
blizzz bdf9b2cfbb Merge pull request #33983 from nextcloud/backport/33788/stable24
[stable24] Improve getting recent files performance
2022-09-08 21:32:20 +02:00
Carl Schwan f072520cbd Filter out old files when trying to get recent files
Only do so when asking for less than 100 files and having an offset
equal to 0.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-08 14:43:57 +00:00
Robin Appelman 0eab20fe02 always use the default fs owner when storing versions
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-09-08 11:56:01 +00:00
blizzz e712fab1da Merge pull request #33912 from nextcloud/release/24.0.5
24.0.5
2022-09-08 11:52:04 +02:00
Nextcloud bot f8a4f8027f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-08 02:26:15 +00:00
blizzz c7a1f64bd7 Merge pull request #33935 from nextcloud/revert-33920-backport/33813/stable24
Revert "[stable24] Compare lowercase email when updating from ldap"
2022-09-07 18:12:56 +02:00
blizzz c5bf31cd24 Revert "[stable24] Compare lowercase email when updating from ldap" 2022-09-07 12:26:16 +02:00
Carl Schwan 96675ccab2 Merge pull request #33920 from nextcloud/backport/33813/stable24
[stable24] Compare lowercase email when updating from ldap
2022-09-07 12:17:57 +02:00
Nextcloud bot 5c9ef92719 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-07 02:25:52 +00:00
Louis Chemineau 7ea5b39e89 I dug into it again, and the issue is much simpler than I previously though.
- LDAP has an email address with capital letters
- NC store this address in lower case
- When the user logs in, we compare the [stored email with the new lower case email](https://github.com/nextcloud/server/blob/master/lib/private/AllConfig.php#L259-L261) before storing it. Here, both email will be the same, so we won't store the new email address with upper case letters. Which is what we want.
- We then [compare emails as they are before triggering an event](https://github.com/nextcloud/server/blob/master/lib/private/User/User.php#L202-L204), they won't match, so the user will receive an email signaling an email change every time he logs in.

The fix is to compare the old email with the new lower case email before sending the event.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-09-06 15:19:52 +00:00
Arthur Schiwon 866be50092 24.0.5
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-09-06 10:28:17 +02:00
Nextcloud bot fbac612fcf [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-06 02:25:13 +00:00
Nextcloud bot 57c17d34f8 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-05 02:25:00 +00:00
Nextcloud bot 01394ee314 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-04 02:24:26 +00:00
Nextcloud bot 43e9ccf057 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-03 02:30:39 +00:00
Nextcloud bot 54d803b946 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-02 02:24:55 +00:00
Xavierando 820df13c5c Update sharing.php 2022-09-01 16:09:54 +00:00
Daniel Calviño Sánchez b045da5233 Fix handling of internal errors when uploading theming files
When a file can not be uploaded in the Theming app due to an expected
error (like an invalid mime type) the response contains a "data.message"
field. However, if the upload fails due to an unexpected error (like an
internal error, for example if the "mime_content_type" function is
disabled) there is no such field, so it should not be used.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-09-01 15:50:31 +00:00
Daniel Calviño Sánchez 33b6740123 Wait for the new user form to be visible
Before it was checked if the new user form was visible, but it was not
waited for it. It seems that it can happen that the new user form is in
the DOM, and therefore found, but not visible yet when the tests run,
which caused them to (randomly) fail. Due to that now it is explicitly
waited until it is visible, rather than assuming that it is visible as
soon as it appears in the DOM.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-09-01 13:47:51 +02:00
blizzz 618bbe7d5c Merge pull request #33761 from nextcloud/release/24.0.5_rc1
24.0.5 RC1
2022-09-01 10:50:54 +02:00
Christoph Wurst c39135a294 Log if cookie login failed with token mismatch or session unavailability
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-09-01 07:35:20 +00:00
blizzz 947328c75a Merge pull request #33782 from nextcloud/backport/33139/stable24
[stable24] Check calendar URI length before creation
2022-09-01 09:28:46 +02:00
Vincent Petry e76bb271ec Merge pull request #33749 from nextcloud/backport/33734/stable24
[stable24] remove leading slash for search results at mountpoint root
2022-09-01 09:27:59 +02:00
Joas Schilling ab113291d6 Check address book URI length before creation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-09-01 05:34:42 +00:00
Anna Larch b09f4dd2cc Check calendar URI length before creation
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-09-01 05:34:41 +00:00
Nextcloud bot 482671efa2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-01 02:37:51 +00:00
Nextcloud bot db2df7e630 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-31 02:24:16 +00:00
blizzz a6be5e0dd7 Merge pull request #33696 from nextcloud/backport/33375/stable24
[stable24] Add back TokenCleanupJob to invalidate old temporary tokens
2022-08-30 17:48:30 +02:00
blizzz 7e980a1f1f Merge pull request #33656 from nextcloud/backport/33574/stable24
[stable24] directly build the search filter for shared storage instead of setting up the source cache
2022-08-30 17:48:11 +02:00
blizzz 2d25bdac2a Merge pull request #33603 from nextcloud/jail-search-post-24
[24] optimize search post-processing for jail wrapper
2022-08-30 17:47:49 +02:00
blizzz 4503adc70d Merge pull request #33514 from nextcloud/backport/33513/stable24
[stable24] Recover installation when creating the database user fails and improve password strength
2022-08-30 17:45:29 +02:00
Arthur Schiwon 282eea58e5 24.0.5 RC1
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-08-30 17:28:56 +02:00
Robin Appelman ee8cabe2ce remove leading slash for search results at mountpoint root
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-30 10:24:30 +00:00
Nextcloud bot ec9a9e5713 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-30 02:24:51 +00:00
Vincent Petry 4154ca6ade Merge pull request #33720 from nextcloud/backport/33713/stable24
[stable24] Fix copy in view-only mode
2022-08-29 09:18:48 +02:00
Nextcloud bot 6929740875 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-29 02:24:59 +00:00
Nextcloud bot 3ca3f0eb86 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-28 02:24:11 +00:00
Nextcloud bot 241edb26f3 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-27 02:24:07 +00:00
Vincent Petry 5fb827d062 Remove copy in file actions when not allowed
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-26 18:04:06 +00:00
Vincent Petry 15416e7305 Fix copy in view-only mode
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-26 18:04:06 +00:00
Vincent Petry 04fac4f540 Add int test for view-only download
Asserts that downloading a view-only document returns 403.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-26 18:04:06 +00:00
Vincent Petry e9b6b6c421 Merge pull request #33604 from nextcloud/search-shared-post-process-filter-24
[24] further pre-filter search result before setting up share source cache
2022-08-26 09:05:47 +02:00
Nextcloud bot b290a6d605 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-26 02:24:58 +00:00
Thomas Citharel 6e9fb83977 Add back TokenCleanupJob to invalidate old temporary tokens
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-08-25 12:05:18 +00:00
Vincent Petry f1301097b0 Merge pull request #33689 from nextcloud/fix/noid/reduce-log-sharepoint
[stable24] logger ignore args of sharepoint-related methods
2022-08-25 13:31:20 +02:00
blizzz a0091fdd3e Merge pull request #33676 from nextcloud/backport/33624/stable24
[stable24] Update CRL
2022-08-25 13:08:52 +02:00
Arthur Schiwon 650900252c logger ignore args of sharepoint-related methods
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-08-25 11:48:03 +02:00
Nextcloud bot 5df9107f50 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-25 02:25:11 +00:00
Carl Schwan 8d7d46eb5b Merge pull request #33642 from nextcloud/dependabot/npm_and_yarn/stable24/marked-4.0.19
Bump marked from 4.0.13 to 4.0.19
2022-08-24 23:01:58 +02:00
blizzz 7f78e745ca Merge pull request #33667 from nextcloud/backport/33639/stable24
[stable24] Fix plural usage in LDAP wizard
2022-08-24 19:23:47 +02:00
Arthur Schiwon 34c460b627 Update CRL
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-08-24 17:27:51 +02:00
Joas Schilling d40ae6fd57 Remove unused method
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-24 09:28:47 +02:00
Joas Schilling bb8ab8ddc4 Fix plural usage in LDAP wizard
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-24 09:28:39 +02:00
Julius Härtl 9de597b277 Merge pull request #33663 from nextcloud/automated/noid/stable24-update-psalm-baseline
[stable24] Update psalm-baseline.xml
2022-08-24 08:24:52 +02:00
nextcloud-command 4552450c65 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2022-08-24 04:48:44 +00:00
Nextcloud bot 13066664c7 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-24 02:27:35 +00:00
Joas Schilling bdbb838256 Merge pull request #33651 from nextcloud/backport/33617/stable24
[stable24] Fix carddav activities
2022-08-23 20:42:15 +02:00
dependabot[bot] f1667b39f3 Bump marked from 4.0.13 to 4.0.19
Bumps [marked](https://github.com/markedjs/marked) from 4.0.13 to 4.0.19.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json)
- [Commits](https://github.com/markedjs/marked/compare/v4.0.13...v4.0.19)

---
updated-dependencies:
- dependency-name: marked
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-08-23 13:25:16 +00:00
Robin Appelman 9cadbe811e directly build the search filter for shared storage instead of setting up the source cache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-23 12:19:14 +00:00
Louis f413456e2f Merge pull request #33636 from nextcloud/backport/33433/stable24
[stable24] Fix encryption:fix-encrypted-version command when encrypted is set to 0
2022-08-23 11:16:32 +02:00
blizzz fcff68a5c2 Merge pull request #33644 from nextcloud/backport/32216/stable24
[stable24] Respect user settings in php.ini if they are big enough
2022-08-23 10:29:36 +02:00
Joas Schilling 68926f5f80 Fix carddav activities
The settings where combined last minute but at the same time the activities
where not adjusted to map an existing setting so the filter was not possible
to even limit it to the types that the activities had.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-23 08:53:16 +02:00
John Molakvoæ 1a92992fc0 Merge pull request #33648 from nextcloud/backport/33643/stable24 2022-08-23 08:49:26 +02:00
Nextcloud bot 6471849a35 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-23 02:24:52 +00:00
Christopher Ng d4abb3396c Improve handling of profile page
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-08-22 23:39:29 +00:00
Micke Nordin 47fd27bc4c Fix suggestions by @artonage
Signed-off-by: Micke Nordin <kano@sunet.se>
2022-08-22 21:36:31 +00:00
Mikael Nordin da6e0d7ddb Simpler version as proposed by @artonage
Co-authored-by: Louis <6653109+artonge@users.noreply.github.com>
Signed-off-by: Micke Nordin <kano@sunet.se>
2022-08-22 21:36:31 +00:00
Micke Nordin ab7a5de793 Respect user settings in php.ini if they are big enough
In the admin guide:
* https://docs.nextcloud.com/server/latest/admin_manual/configuration_files/big_file_upload_configuration.html

it is mentioned that you can tweek:
* max_input_time
* max_execution_time

in order to enable larger file uploads. However, the current codebase
will hard code these values to one hour, no matter what the user sets in
php.ini.

This patch will allow the user to set these settings in php.ini and they
will be respected, if and only if, they are set to something bigger than
3600 seconds.

Signed-off-by: Micke Nordin <kano@sunet.se>
2022-08-22 21:36:31 +00:00
Côme Chilliet 0c1d0ea1fd Adapt test to fixed command output.
No user and non-existing user are now correctly treated as two separated
 cases

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-22 09:16:16 +00:00
Côme Chilliet 6090807d0b Fix encryption:fix-encrypted-version command when encrypted is set to 0
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-22 09:16:16 +00:00
Côme Chilliet 15d8cc1e36 Improve typing in FixEncryptedVersion command
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-22 09:16:16 +00:00
Nextcloud bot 65299288a2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-22 02:24:42 +00:00
Nextcloud bot 80e753d740 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-21 02:24:41 +00:00
Nextcloud bot 2adde1e1e2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-20 02:24:18 +00:00
Robin Appelman d9f73d8fd9 further pre-filter search result before setting up share source cache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-18 13:41:12 +02:00
Robin Appelman 9deae5b17a optimize search post-processing for jail wrapper
don't both asking the wrapped cache if we know it's not in our jail anyway

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-18 13:39:36 +02:00
Nextcloud bot dbab6a648b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-18 02:24:28 +00:00
Louis 49673f491e Merge pull request #33538 from nextcloud/backport/33495/stable24
[stable24] Unify initial and updated quota display
2022-08-17 14:14:50 +02:00
Robin Appelman ba606f1bb3 Merge pull request #33562 from nextcloud/empty-folder-size-24
[24] fix updating size when folder is empty
2022-08-17 11:13:22 +02:00
Nextcloud bot a512a6cceb [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-17 02:25:23 +00:00
Robin Appelman ea9509eaf9 fix updating size when folder is empty
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-16 13:40:45 +02:00
Daniel Calviño Sánchez e720034599 Show usage percenteage in the tooltip
The tooltip of the initial quota display showed the usage percenteage
and the total available space. However, the total available space was
redundant, as it was shown just below. The tooltip of the updated quota
display showed the usage percenteage, but based on the quota rather than
the total available space, so there was a mismatch between the tooltip
and the bar below. Now the tooltip of the initial and the updated quota
display both show just the usage percenteage based on the total
available space.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-08-16 09:35:17 +02:00
Daniel Calviño Sánchez 8b19741020 Use total available space rather than quota when updating the display
The initial quota display uses the total available space rather than the
quota. Moreover, the relative usage is based on the total space rather
than the quota. Due to this now the total available space is also used
when updating the quota display.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-08-16 09:32:08 +02:00
Nextcloud bot 221011199d [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-16 02:25:55 +00:00
Nextcloud bot 65b45998d2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-15 02:24:59 +00:00
Nextcloud bot d260540308 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-14 02:25:03 +00:00
Nextcloud bot dd34ea981a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-13 02:25:09 +00:00
Joas Schilling be5c39321b Create more secure passwords by default
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-12 11:22:48 +02:00
Joas Schilling d09533cf28 Recover installation when creating the user failed
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-12 11:21:27 +02:00
Nextcloud bot bbf7ad45c3 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-12 02:24:41 +00:00
John Molakvoæ fb9510ffed Merge pull request #33504 from nextcloud/release/24.0.4 2022-08-11 09:28:58 +02:00
John Molakvoæ 9d269a23e0 24.0.4
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-08-11 08:27:33 +02:00
Nextcloud bot 0fbe0169a9 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-11 02:24:45 +00:00
John Molakvoæ e1096357dc Merge pull request #33490 from nextcloud/backport/33485/stable24 2022-08-10 12:48:34 +02:00
Nextcloud bot 934e43ae1c [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-10 02:26:22 +00:00
Julius Härtl 874146285f Do not update passwords if nothing changed
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-09 18:54:33 +00:00
Nextcloud bot 333161bcfe [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-09 02:24:39 +00:00
Nextcloud bot e80f406675 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-08 02:23:35 +00:00
Nextcloud bot 277dc0c9a4 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-07 02:28:38 +00:00
Nextcloud bot 8af968790c [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-06 02:25:17 +00:00
Nextcloud bot b189b19d59 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-08-05 08:58:50 +00:00
dependabot[bot] 49b88429f8 Merge pull request #33441 from nextcloud/dependabot/npm_and_yarn/stable24/jquery-ui-1.13.2 2022-08-04 18:46:33 +00:00
blizzz b69631ea57 Merge pull request #33420 from nextcloud/release/24.0.4rc1
24.0.4rc1
2022-08-04 12:34:54 +02:00
blizzz d81e38d296 Merge pull request #32273 from nextcloud/backport/32152/stable24
[stable24] Allow compatibility wrapper on local external storage
2022-08-04 11:42:56 +02:00
Vincent Petry d70c7ecc7b Merge pull request #33455 from nextcloud/backport/32852/stable24
[stable24] Revert "Revert "Remove inefficient fed share scanner""
2022-08-04 10:56:57 +02:00
Vincent Petry d26c098187 Merge pull request #33416 from nextcloud/backport/32482/stable24
[stable24] Add share attributes + prevent download permission
2022-08-04 10:48:56 +02:00
Robin Appelman 1d66a53fab fix external share scanner not propagating locking-opt-out
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-04 07:44:55 +00:00
Carl Schwan c0a18cbb87 Disable locking on federated shares
The old inneficiant code didn't do locking and adding locking is
creating issues

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-04 07:44:55 +00:00
Carl Schwan 5ac96a4b01 Revert "Revert "Remove inefficient fed share scanner""
This reverts commit 6667007bf2.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-04 07:44:55 +00:00
Carl Schwan 843b54ea8c Fix backport
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-03 13:54:37 +02:00
Julius Härtl bdaa8843b4 Fix label for allow download share permission
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-03 13:24:40 +02:00
Carl Schwan aafaa39515 Multiple fixes
- Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
  wrapper)
- Fix resharing

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-03 13:24:38 +02:00
Carl Schwan 146dda4266 Enforcing permission during resharing
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-03 13:24:20 +02:00
Vincent Petry e959b57c31 Inherit hide download from share attributes
When resharing by link, if the download permission was removed through
share attributes, convert it to the hide download flag.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:20 +02:00
Vincent Petry 567b7cc05c Block download when needed on direct download endpoint
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:20 +02:00
Vincent Petry cc7564758b Fix view-only code after code review comments
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:20 +02:00
Julius Härtl ef6e4fc52d Fix adding to empty attributes and duplicate request
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-03 13:24:20 +02:00
Vincent Petry 189b7b1624 Add share attrs + download permission support in frontend
Added download permission checkbox in frontend
Added share attributes parsing and setting in frontend.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:19 +02:00
Vincent Petry 0c468ede91 Add nc:share-attributes Webdav property
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:19 +02:00
Vincent Petry 4b1649fbf3 Don't reset share attributes when not specified
When not specified in the OCS call, don't reset the share attributes.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:19 +02:00
Vincent Petry 9e59a6a731 Attempt to fix sqlite json issue
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:19 +02:00
Vincent Petry cf3d92015b Fix share attribute related tests + code style
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:19 +02:00
Vincent Petry 1eca72d417 Fix share controller to accept share attributes alone
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:18 +02:00
Vincent Petry f1ab964819 Add share attributes + prevent download permission
Makes it possible to store download permission

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 13:24:13 +02:00
blizzz 6088f720bd Merge pull request #33439 from nextcloud/backport/32958/stable24
[stable24] Fix file public link permissions if public upload is not enabled
2022-08-03 11:27:10 +02:00
Vincent Petry 3a3a52de83 Merge pull request #33407 from nextcloud/backport/stable24/one-time-password
[stable24] Handle one time and large passwords
2022-08-03 09:07:54 +02:00
dependabot[bot] ae63edef57 Bump jquery-ui from 1.13.1 to 1.13.2
Bumps [jquery-ui](https://github.com/jquery/jquery-ui) from 1.13.1 to 1.13.2.
- [Release notes](https://github.com/jquery/jquery-ui/releases)
- [Commits](https://github.com/jquery/jquery-ui/compare/1.13.1...1.13.2)

---
updated-dependencies:
- dependency-name: jquery-ui
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-08-03 01:02:06 +00:00
dependabot[bot] 313e336d22 Merge pull request #33438 from nextcloud/dependabot/npm_and_yarn/stable24/clipboard-2.0.11 2022-08-02 18:32:19 +00:00
dependabot[bot] 996cdbf0a7 Bump clipboard from 2.0.10 to 2.0.11
Bumps [clipboard](https://github.com/zenorocha/clipboard.js) from 2.0.10 to 2.0.11.
- [Release notes](https://github.com/zenorocha/clipboard.js/releases)
- [Commits](https://github.com/zenorocha/clipboard.js/compare/v2.0.10...v2.0.11)

---
updated-dependencies:
- dependency-name: clipboard
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-08-02 17:51:56 +00:00
Julien Veyssier 008a9f568d fix share manager tests
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-08-02 14:56:59 +00:00
Julien Veyssier 933bd27ea9 don't reduce file public link permissions if public upload is not enabled
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-08-02 14:56:59 +00:00
dependabot[bot] 8506e44bd6 Merge pull request #33370 from nextcloud/dependabot/npm_and_yarn/stable24/nextcloud/moment-1.2.1 2022-08-02 14:24:43 +00:00
dependabot[bot] 0d286d99d6 Bump @nextcloud/moment from 1.2.0 to 1.2.1
Bumps [@nextcloud/moment](https://github.com/nextcloud/nextcloud-moment) from 1.2.0 to 1.2.1.
- [Release notes](https://github.com/nextcloud/nextcloud-moment/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-moment/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-moment/compare/v1.2.0...v1.2.1)

---
updated-dependencies:
- dependency-name: "@nextcloud/moment"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-08-02 15:29:58 +02:00
blizzz 039fd75a88 Merge pull request #33353 from nextcloud/backport/33031/stable24
[stable24] Improve local IP detection
2022-08-02 12:36:10 +02:00
Côme Chilliet 38eb0df671 Fix autoloader
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-01 15:13:34 +02:00
blizzz 66d4f6744e Merge pull request #33391 from nextcloud/backport/33280/stable24
[stable24] handle AccessDenied error when checking if external s3 support versions
2022-08-01 15:10:36 +02:00
blizzz e70ffdf556 Merge pull request #33382 from nextcloud/backport/33378/stable24
[stable24] don't set `null` as a bundle path
2022-08-01 15:09:54 +02:00
Vincent Petry 9070dbd7af Merge pull request #33096 from nextcloud/dependabot/npm_and_yarn/stable24/handlebars-loader-1.7.2
Bump handlebars-loader from 1.7.1 to 1.7.2
2022-08-01 15:03:11 +02:00
Vincent Petry a760b3452b Merge pull request #32840 from nextcloud/dependabot/npm_and_yarn/stable24/vue-router-3.5.4
Bump vue-router from 3.5.3 to 3.5.4
2022-08-01 15:02:28 +02:00
Arthur Schiwon d9f4c0d081 24.0.4rc1
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-08-01 14:58:18 +02:00
Côme Chilliet 5daf307a0d Remove call to undefined function, fix typing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-01 12:24:39 +02:00
Côme Chilliet ead97ba46d Align copied file with our code style
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-01 11:34:28 +02:00
Côme Chilliet 7d069cd30e Merge pull request #33352 from nextcloud/fix/bump-sabre-dav-to-4.4.0-in-stable24
Bump sabre dav to 4.4.0 in stable24
2022-08-01 11:32:37 +02:00
Côme Chilliet d3a2fd02c2 Copy IpUtils from Symfony to avoid new dependency on backport
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-01 11:30:51 +02:00
Carl Schwan f4795f6dac Handle one time and large passwords
For passwords bigger than 250 characters, use a bigger key since the
performance impact is minor (around one second to encrypt the password).

For passwords bigger than 470 characters, give up earlier and throw
exeception recommanding admin to either enable the previously enabled
configuration or use smaller passwords.

This adds an option to disable storing passwords in the database. This
might be desirable when using single use token as passwords or very
large passwords.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-29 16:15:38 +02:00
Matthieu Gallien 7be4691855 handle AccessDenied error when checking if external s3 support versions
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-07-28 10:27:50 +00:00
dependabot[bot] 1edc51c639 Bump vue-router from 3.5.3 to 3.5.4
Bumps [vue-router](https://github.com/vuejs/router) from 3.5.3 to 3.5.4.
- [Release notes](https://github.com/vuejs/router/releases)
- [Changelog](https://github.com/vuejs/router/blob/main/CHANGELOG.md)
- [Commits](https://github.com/vuejs/router/commits)

---
updated-dependencies:
- dependency-name: vue-router
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-07-27 19:48:40 +00:00
Robin Appelman afdeae2cc2 don't set null as a bundle path
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-07-27 13:46:34 +00:00
dependabot[bot] 6a3cd32a2d Merge pull request #33369 from nextcloud/dependabot/npm_and_yarn/stable24/jsdoc-3.6.11 2022-07-27 00:59:48 +00:00
dependabot[bot] 50ea3ae110 Bump jsdoc from 3.6.10 to 3.6.11
Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.6.10 to 3.6.11.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/3.6.11/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.10...3.6.11)

---
updated-dependencies:
- dependency-name: jsdoc
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-07-26 22:54:37 +00:00
Vincent Petry b21f79e7df Merge pull request #33363 from nextcloud/dependabot/npm_and_yarn/stable24/dompurify-2.3.10
Bump dompurify from 2.3.8 to 2.3.10
2022-07-26 23:17:21 +02:00
Vincent Petry 392327b135 Merge pull request #33132 from nextcloud/backport/33090/stable24
[stable24] DAV custom props: catch Exception and rollback transaction in case
2022-07-26 23:11:14 +02:00
Vincent Petry 19a52f4507 Merge pull request #33350 from nextcloud/backport/33315/stable24
[stable24] Reset user status based on message ID only
2022-07-26 22:49:31 +02:00
Anna 5f743c3c1d Merge pull request #33364 from nextcloud/backport/33341/stable24
[stable24] Don't try to purge objects from the birthday calendar when it doesn't exist
2022-07-26 20:56:34 +02:00
dependabot[bot] 71b106c342 Bump dompurify from 2.3.8 to 2.3.10
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.3.8 to 2.3.10.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](https://github.com/cure53/DOMPurify/compare/2.3.8...2.3.10)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-07-26 17:58:24 +00:00
Thomas Citharel 6d81423c35 Don't try to purge objects from the birthday calendar when it doesn't exist
Doesn't matter much as it's been recreated afterwards with (ensureCalendarExists).

Closes #29617

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-07-26 17:26:01 +00:00
blizzz 91c2a60424 Merge pull request #31984 from nextcloud/dependabot/npm_and_yarn/stable24/underscore-1.12.1
Bump underscore from 1.12.0 to 1.12.1
2022-07-26 19:21:38 +02:00
Vincent Petry b0be67fb74 Fix core tests by stubbing debounce
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-26 15:47:12 +02:00
dependabot[bot] 6c81f543b2 Bump underscore from 1.12.0 to 1.12.1
Bumps [underscore](https://github.com/jashkenas/underscore) from 1.12.0 to 1.12.1.
- [Release notes](https://github.com/jashkenas/underscore/releases)
- [Commits](https://github.com/jashkenas/underscore/compare/1.12.0...1.12.1)

---
updated-dependencies:
- dependency-name: underscore
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-07-26 13:11:29 +00:00
Côme Chilliet d0ceedf054 Use Symfony IpUtils to check for local IP ranges
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-26 09:42:33 +00:00
Côme Chilliet 8cddb75c2b Check for local IPs nested in IPv6 as well
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-26 09:42:32 +00:00
Côme Chilliet 1d0ddcfca1 Refactor local IP if and set strict to true for in_array
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-26 09:42:32 +00:00
Côme Chilliet 7ab50248dc Improve local IP detection
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-26 09:42:32 +00:00
Côme Chilliet 76108a7adb Sync 3rdparty with stable24, bumps sabre/dav to 4.4.0
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-26 10:48:07 +02:00
Joas Schilling da14fde621 Reset user status based on message ID only
Since some statuses (call) can occure with different status
(away and dnd) we need to reset only based on the message id.
But as it can not be set by the user this is still save and okay.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-07-26 08:16:17 +00:00
Joas Schilling 1749771ce3 Merge pull request #33343 from nextcloud/backport/33129/stable24
[stable24] Fix reading blob data as resource
2022-07-26 09:43:54 +02:00
Nextcloud bot 4fbb53e85e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-26 02:27:00 +00:00
Thomas Citharel 618bbb313c Fix reading blob data as resource
PostgreSQL returns data as resource when using IQueryBuilder::PARAM_LOB
(which is used for QBMapper).

Previously we just converted this resource using settype, which produced
things like "Resource id #14" instead of the actual resource data.

Now we read the stream correctly if the returned data is a resource

See context at #22472

Fixes #22439

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-07-25 15:59:36 +00:00
Vincent Petry a2166864d4 Merge pull request #33326 from nextcloud/backport/33308/stable24
[stable24] always triger setup of builtin storage wrappers
2022-07-25 17:04:19 +02:00
Nextcloud bot d2cd3adfea [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-25 02:27:19 +00:00
Nextcloud bot 5cc782f102 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-24 02:27:53 +00:00
Nextcloud bot 7ada3bc39a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-23 02:26:27 +00:00
blizzz 22822a836d Merge pull request #33252 from nextcloud/backport/32963/stable24
[stable24] also use nextcloud certificate bundle when downloading from s3
2022-07-22 23:54:41 +02:00
blizzz f3afffe416 Merge pull request #33178 from nextcloud/backport/33118/stable24
[stable24] Fix empty address books being exported
2022-07-22 23:23:50 +02:00
Robin Appelman 2c6cd0daf8 always triger setup of builtin storage wrappers
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-07-22 20:24:35 +00:00
Nextcloud bot f23472e68f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-22 02:25:24 +00:00
Nextcloud bot 2a73b53c44 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-21 02:26:57 +00:00
Vincent Petry 08dabe975e Merge pull request #33262 from nextcloud/backport/33222/stable24
[stable24] Translate error when user already exists
2022-07-20 12:36:07 +02:00
Nextcloud bot c1d7596143 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-20 02:25:52 +00:00
Jonas 78a3bfd120 Merge pull request #33212 from nextcloud/backport/33211/stable24
[stable24] Fix listening for circle events in SetupManager
2022-07-19 10:25:45 +02:00
blizzz 4cd4378dac Merge pull request #33276 from nextcloud/backport/33270/stable24
[stable24] fix loading legacy app.php with multi app dir
2022-07-19 09:58:04 +02:00
Arthur Schiwon 7af9f2741f fix loading legacy app.php with multi app dir
- requireAppFile() only appends /appinfo/app.php
- without the absolute path, require_once looks into include_path
- the first match in inlcude_path however migth be different from appPath
- fixed by providing the tested(!), full path to the app


Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-07-19 06:18:59 +00:00
Nextcloud bot 4f8e18d4a6 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-19 02:26:00 +00:00
Jonas 786317e1cb Fix listening for circle events in SetupManager
So far, SetupManager listened for deprecated events that are no longer
triggered. Instead, use the circle events that actually get triggered
when adding or removing a circle or circle member. Also, these events
get triggered on each instance of a globalscale setup.

Fixes: #33210

Signed-off-by: Jonas <jonas@freesources.org>
2022-07-18 21:09:37 +01:00
Joas Schilling 636ae8e829 Recompile
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-07-18 15:29:57 +02:00
Joas Schilling 4f0862c431 Translate error when user already exists
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-07-18 15:26:21 +02:00
blizzz 7844c0bce1 Merge pull request #33256 from nextcloud/release/24.0.3
24.0.3
2022-07-18 13:23:32 +02:00
Arthur Schiwon 959c1f3145 24.0.3
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-07-18 12:02:16 +02:00
Robin Appelman d4de68f1d4 only use nextcloud bundle when explicitly enabled
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-07-18 07:54:55 +00:00
Robin Appelman e640ee4720 also use nextcloud certificate bundle when downloading from s3
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-07-18 07:54:54 +00:00
Nextcloud bot 01dd022502 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-18 02:25:09 +00:00
Nextcloud bot 08ad7a465a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-17 02:24:50 +00:00
Nextcloud bot 0858b10c4d [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-16 02:25:44 +00:00
Carl Schwan 1d602044a4 Merge pull request #33149 from nextcloud/automated/noid/stable24-update-psalm-baseline
[stable24] Update psalm-baseline.xml
2022-07-15 09:11:39 +02:00
nextcloud-command 31937f5488 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2022-07-15 04:36:48 +00:00
Nextcloud bot 0c254123f5 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-15 02:27:46 +00:00
Nextcloud bot ce7b2c1329 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-14 02:25:32 +00:00
Nextcloud bot c485a0f9af [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-13 02:24:59 +00:00
Nextcloud bot c6f667fb86 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-12 02:23:37 +00:00
Nextcloud bot d885e9d70b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-11 02:24:41 +00:00
Nextcloud bot 6b5e366500 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-10 02:25:41 +00:00
dependabot[bot] 92b6914cc7 Update behat/behat requirement in /build/integration
Updates the requirements on [behat/behat](https://github.com/Behat/Behat) to permit the latest version.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.10.0...v3.11.0)

---
updated-dependencies:
- dependency-name: behat/behat
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-07-09 02:35:50 +00:00
Nextcloud bot 6b61ae235e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-09 02:24:43 +00:00
Christopher Ng e4674d5402 Fix empty address books being exported
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-07-08 20:17:39 +00:00
John Molakvoæ c01e5d53a1 Merge pull request #33169 from nextcloud/release/24.0.3_rc2 2022-07-08 11:07:05 +02:00
John Molakvoæ 07fbeccb84 24.0.3 RC2
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-07-08 10:06:24 +02:00
John Molakvoæ dec16a9543 Merge pull request #33157 from nextcloud/backport/33153/stable24 2022-07-08 08:28:29 +02:00
Nextcloud bot 09d6d02234 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-08 02:24:48 +00:00
John Molakvoæ f836adecda Merge pull request #33124 from nextcloud/release/24.0.3_rc1 2022-07-07 14:14:49 +02:00
blizzz 2e9429a76f Merge pull request #33138 from nextcloud/fix-branch-selection-in-stable24
[stable24] Fix branch selection
2022-07-07 12:08:43 +02:00
blizzz 3b80d25932 Merge pull request #32850 from nextcloud/backport/31345/stable24
[stable24] Fix deletion of additional emails
2022-07-07 12:07:02 +02:00
John Molakvoæ 3ce8f2dc57 Merge pull request #32654 from nextcloud/backport/32594/stable24 2022-07-07 11:48:27 +02:00
John Molakvoæ b3ee9b7b98 Merge pull request #32983 from nextcloud/backport/32242/stable24 2022-07-07 11:47:34 +02:00
John Molakvoæ 0164dffcd3 Merge pull request #32920 from nextcloud/backport/32874/stable24 2022-07-07 11:47:16 +02:00
John Molakvoæ 7d52ea075c Merge pull request #33155 from nextcloud/backport/33140/stable24 2022-07-07 11:46:21 +02:00
Joas Schilling d306757ffb Only ignore attempts of the same action
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-07-07 09:03:55 +00:00
John Molakvoæ 447a238c59 Merge pull request #32997 from nextcloud/backport/32980/stable24 2022-07-07 10:49:43 +02:00
Christopher Ng eec59e10b6 Fix trashbin expiration notice casing
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-07-07 08:26:52 +00:00
John Molakvoæ 8d8fa86194 Merge pull request #32986 from nextcloud/backport/stable24/31771 2022-07-07 10:26:42 +02:00
Nextcloud bot 5840c12163 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-07 02:24:46 +00:00
Pytal 31cc222daf Merge pull request #33143 from nextcloud/backport/33052/stable24 2022-07-06 15:38:23 -07:00
Joas Schilling 6e628c2097 Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-07-06 20:54:18 +00:00
Christopher Ng 9bd1935d60 Prevent duplicate set display name request
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-07-06 20:54:18 +00:00
Christopher Ng 51e20dd6c5 Do not save invalid display name to the database
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-07-06 20:54:17 +00:00
Pytal 6dd941aba0 Merge pull request #33125 from nextcloud/backport/32993/stable24
[stable24] Fixes for quota text in navigation bar
2022-07-06 12:32:28 -07:00
Pytal 6b90cbed28 Merge pull request #33077 from nextcloud/backport/33068/stable24 2022-07-06 10:27:37 -07:00
Daniel Calviño Sánchez 860f67ae8a Fix branch selection in stable24
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-07-06 17:36:30 +02:00
Carl Schwan 7c1c7ba5bf Merge pull request #32483 from nextcloud/backport/32451/stable24
[stable24] Fix cropped image generated when not asked
2022-07-06 17:33:07 +02:00
Carl Schwan 7bbf44e040 Fix loading groupfolder info when share api is disabled
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-06 17:15:07 +02:00
Arthur Schiwon b2475b606f catch any exception for transaction control
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-07-06 16:14:09 +02:00
Carl Schwan c3621f2a11 Fix cropped image generated when not asked
The $crop parameter was not propagated to the imaginary pipeline and
instead it used the smartcrop algorithm always

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-06 14:33:04 +02:00
blizzz 0cbea21e86 Merge pull request #33119 from nextcloud/backport/33109/stable24
[stable24] Fix translation of home breadcrumb
2022-07-06 14:26:41 +02:00
blizzz f89c017cc6 Merge pull request #33092 from nextcloud/dependabot/composer/build/integration/stable24/sabre/dav-4.4.0
Update sabre/dav requirement from 4.3.1 to 4.4.0 in /build/integration
2022-07-06 14:25:09 +02:00
blizzz 174560f0f8 Merge pull request #33062 from nextcloud/backport/32857/stable24
[stable24] Fix  undefined when no tags
2022-07-06 14:22:48 +02:00
blizzz ef1e4f349d Merge pull request #32882 from nextcloud/backport/32584/stable24
[stable24] Make sure ResetTokenBackgroundJob doesn't execute if config is read-only
2022-07-06 14:19:20 +02:00
Arthur Schiwon f4fd68da4c DAV custom props: catch Exception and rollback transaction in case
- before exceptions were not caught, a started transaction might not have
  been finished
- also resolve depractions and use IQueryBuilder

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-07-06 13:10:01 +02:00
Nextcloud bot f64b78d11b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-06 02:23:47 +00:00
Daniel Calviño Sánchez 14f3029fe5 Fix quota text not updated after copying or moving a file
Note that the quota may change too when files are moved if the file is
moved, for example, to or from a folder shared by other user.

Besides the quota the storage statistics are also updated, similar to
what is done when a file is deleted.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-07-05 20:25:44 +00:00
Daniel Calviño Sánchez edbda9c15b Fix quota text not updated when no quota is set
The JavaScript code that updates the quota text expects the element to
have "quotatext" as id.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-07-05 20:25:44 +00:00
Daniel Calviño Sánchez 79542cf70c Fix quota text shown escaped
"t()" escapes and sanitizes the returned text by default, so strings
like "<" are converted to "&lt;". However, the "jQuery.text()" parameter
does not need to be escaped, as "&lt;" is shown literally as "&lt;"
rather than "<". Now "jQuery.html()" is used instead, which "unescapes"
the given text and sets it as a new text node (as the text in the
parameter does not contain markup for elements, only text).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-07-05 20:25:44 +00:00
John Molakvoæ a45ade5a55 24.0.3 RC1
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-07-05 20:43:12 +02:00
Christopher Ng e29c7061e2 Fix translation of home breadcrumb
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-07-05 18:36:29 +00:00
Carl Schwan e00ef77def Merge pull request #33113 from nextcloud/fix/stable24/ajax-file
[stable24] Remove .php from ajax url
2022-07-05 17:51:40 +02:00
Julien Veyssier bbe3b03aed add missing GET param to getstoragestats url
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
(cherry picked from commit ca6a724503)
2022-07-05 16:39:48 +02:00
Carl Schwan 43efbcff74 Fix 404 when using index.php in the url
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
(cherry picked from commit ee793572cb)
2022-07-05 16:39:39 +02:00
Carl Schwan 93aa618e80 Remove .php from url
Probably here for legacy reasons, but it is a bit weird to call an .php
endpoint that doesn't correspond to a .php file

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
(cherry picked from commit c7931086cc)
2022-07-05 16:39:24 +02:00
blizzz 51afde11db Merge pull request #32974 from nextcloud/backport/32016/stable24
[stable24] Use stored user for PasswordUpdatedEvent
2022-07-05 12:31:55 +02:00
Nextcloud bot a22ecaca70 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-05 02:23:36 +00:00
Nextcloud bot 7e3f811104 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-04 02:23:43 +00:00
dependabot[bot] 4d2f36f2b7 Bump handlebars-loader from 1.7.1 to 1.7.2
Bumps [handlebars-loader](https://github.com/pcardune/handlebars-loader) from 1.7.1 to 1.7.2.
- [Release notes](https://github.com/pcardune/handlebars-loader/releases)
- [Changelog](https://github.com/pcardune/handlebars-loader/blob/main/CHANGELOG.md)
- [Commits](https://github.com/pcardune/handlebars-loader/compare/v1.7.1...v1.7.2)

---
updated-dependencies:
- dependency-name: handlebars-loader
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-07-03 18:06:15 +00:00
Nextcloud bot 2214905c4f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-03 02:22:48 +00:00
Carl Schwan b9412c3382 Merge pull request #33026 from nextcloud/dependabot/npm_and_yarn/stable24/sass-1.50.1
Bump sass from 1.50.0 to 1.50.1
2022-07-02 18:27:43 +02:00
Nextcloud bot adfde4eab8 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-02 02:25:08 +00:00
dependabot[bot] c14e769615 Update sabre/dav requirement from 4.3.1 to 4.4.0 in /build/integration
Updates the requirements on [sabre/dav](https://github.com/sabre-io/dav) to permit the latest version.
- [Release notes](https://github.com/sabre-io/dav/releases)
- [Changelog](https://github.com/sabre-io/dav/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sabre-io/dav/compare/4.3.1...4.4.0)

---
updated-dependencies:
- dependency-name: sabre/dav
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-07-02 02:17:04 +00:00
Carl Schwan ebe3c5b00e Merge pull request #33078 from nextcloud/backport/32924/stable24
[stable24] Enable binary protocol again
2022-07-01 15:07:55 +02:00
Tobias Kaminsky 2dd3cae60a Merge pull request #33058 from nextcloud/backport/33050/stable24
[stable24] Check whether entry is of type ICacheEntry in Cache->remove()
2022-07-01 10:40:40 +02:00
Nextcloud bot dc28ef925f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-07-01 02:34:45 +00:00
Arthur Schiwon 4744a62776 memcached should not throw arbitrary exceptions
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-07-01 00:15:37 +02:00
Carl Schwan f32c53e5a1 Enable binary protocol again
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-01 00:15:28 +02:00
Christopher Ng 6236aefa8e Add trashbin export expiration notice
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-30 16:29:31 +00:00
Jonas aec0899efd Check whether entry is of type ICacheEntry in Cache->remove()
In some scenarios (file not in cache, but partial data of it in the
object), Cache->get() might return an array, which leads to errors like
"Call to a member function getId() on array".

So check whether the returned entry is of type ICacheEntry before doing
operations on it in Cache->remove().

Fixes: #33023

Signed-off-by: Jonas <jonas@freesources.org>
2022-06-30 12:25:26 +00:00
Carl Schwan 47934494f6 Merge pull request #33069 from nextcloud/backport/33065/stable24
[stable24] Fix detection of firefox in ContentSecurityPolicyNonceManager
2022-06-30 10:19:22 +02:00
Nextcloud bot 381ac6a26a [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-30 02:23:59 +00:00
Carl Schwan 467780ff4e Fix detection of firefox in ContentSecurityPolicyNonceManager
Reuse Request::USER_AGENT_FIREFOX, and also update the safari detection
since safari < 12 is not supported anymore and we can remove a bit of
code duplication

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-30 00:46:47 +00:00
Daniel Kesselberg 7abb4c3044 Fix undefined when no tags
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-06-29 13:15:59 +00:00
Carl Schwan 221826c0b0 Merge pull request #33009 from nextcloud/dependabot/composer/stable24/guzzlehttp/guzzle-7.4.5
[stable24] Bump guzzlehttp/guzzle from 7.4.0 to 7.4.5
2022-06-29 13:47:22 +02:00
Carl Schwan 59d8e0385a Bump guzzlehttp/guzzle from 7.4.4 to 7.4.5
See https://github.com/nextcloud/3rdparty/pull/1090

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-29 12:11:30 +02:00
Nextcloud bot af326c810b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-29 02:27:38 +00:00
Arthur Schiwon 771d38918a avoid early DI of IAppManager
- might break install

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-28 23:47:00 +02:00
Carl Schwan 334ed35042 Merge pull request #33049 from nextcloud/backport/32982/stable24
[stable24] Fix metadata extraction
2022-06-28 21:46:42 +02:00
blizzz 64d163bcbf Merge pull request #32791 from nextcloud/backport/32675/stable24
[stable24] Validate custom dashboard background image
2022-06-28 17:02:26 +02:00
blizzz a849c3d444 Merge pull request #33028 from nextcloud/backport/32998/stable24
[stable24] Rename setting name to reduce its length
2022-06-28 16:59:48 +02:00
Carl Schwan de4f7b5c9c Fix metadata extraction
The metadata extraction only happens when the size is not equal to 0,
but due to a regression in FileInfo the size is always zero.

This fix the regression.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-28 13:37:59 +00:00
blizzz e4cbe7b9a3 Merge pull request #32858 from nextcloud/backport/32800/stable24
[stable24] Don't spam the log with fatals when maintenance mode is enabled or an…
2022-06-28 12:09:09 +02:00
Louis Chemineau 82fea7d000 Rename setting name to reduce its length
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-06-28 09:55:45 +00:00
dependabot[bot] f2a7e1f202 Bump sass from 1.50.0 to 1.50.1
Bumps [sass](https://github.com/sass/dart-sass) from 1.50.0 to 1.50.1.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sass/dart-sass/compare/1.50.0...1.50.1)

---
updated-dependencies:
- dependency-name: sass
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-28 08:44:31 +00:00
Carl Schwan ebc4858be0 Merge pull request #33019 from nextcloud/dependabot/composer/build/integration/stable24/guzzlehttp/guzzle-7.4.5
Update guzzlehttp/guzzle requirement from 7.4.4 to 7.4.5 in /build/integration
2022-06-28 10:44:00 +02:00
Nextcloud bot ca316d5454 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-28 02:28:38 +00:00
Christopher Ng 7d4138a0ef Use unique key to prevent email component reuse
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-06-27 19:23:16 +00:00
Simon L f881e41328 Merge pull request #32968 from nextcloud/backport/32902/stable24
[stable24] do not display the buffer_size info if the size is already set to a c…
2022-06-27 14:14:59 +02:00
blizzz 46fd400142 Merge pull request #32819 from nextcloud/dependabot/npm_and_yarn/stable24/webpack-5.72.1
Bump webpack from 5.72.0 to 5.72.1
2022-06-27 11:05:44 +02:00
Nextcloud bot aafd403f05 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-27 02:27:28 +00:00
dependabot[bot] 82567ee8c9 Update guzzlehttp/guzzle requirement in /build/integration
Updates the requirements on [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) to permit the latest version.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/master/CHANGELOG.md)
- [Commits](https://github.com/guzzle/guzzle/compare/7.4.4...7.4.5)

---
updated-dependencies:
- dependency-name: guzzlehttp/guzzle
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-25 02:36:02 +00:00
Nextcloud bot 21c2732253 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-25 02:27:40 +00:00
blizzz ce9dfc20d0 Merge pull request #32990 from nextcloud/backport/32988/stable24
[stable24] Improve local domain detection
2022-06-24 11:29:13 +02:00
blizzz 39b8ea2b76 Merge pull request #32940 from nextcloud/backport/32719/stable24
[stable24] Fix email shares not being shown to other users
2022-06-24 10:53:19 +02:00
blizzz 9910b84a4b Merge pull request #32939 from nextcloud/backport/32910/stable24
[stable24] Fix profiler trying to serialize invalid utf8
2022-06-24 10:20:03 +02:00
Nextcloud bot ffe83675ac [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-24 02:27:23 +00:00
Arthur Schiwon 28eac9c961 load widgets only of enabled apps
- per design, all enabled apps have their registration run
- limitations, e.g. enabled by group, are not considered in that state,
  because we do not have a session (and might need apps?)
- before instantiation of widget it has to be checked whether the providing
  app is actually enabled for the logged in user.
- a public interface is being changed, but it is not meant to be
  implemented or used outside of the core handling. Therefore save to
  backport.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-23 15:48:33 +00:00
Côme Chilliet fc1258cb1c Improve local domain detection
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-23 10:53:49 +00:00
Nextcloud bot bdcd370e07 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-23 02:27:44 +00:00
Carl Schwan b4edbb3af5 Fix hook encryption with cron job
Make sure the setup fs is set before using the Update service

Fix #29674

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-22 22:42:25 +02:00
Thomas Citharel 08035833cf Fix logging data context to file
It was only logged when an exception was provided or when using
logData (which is not being much used).

We make sure the interpolated parameters are not logged.

Only tested with file write logger, but shouldn't work differently.

Crash reporters always had the context.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-06-22 18:26:25 +00:00
dependabot[bot] b9883d8ed8 Bump webpack from 5.72.0 to 5.72.1
Bumps [webpack](https://github.com/webpack/webpack) from 5.72.0 to 5.72.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v5.72.0...v5.72.1)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-06-22 17:58:07 +00:00
Louis Chemineau e6a254641e Use stored user for PasswordUpdatedEvent
When handling PasswordUpdatedEvent event, we are calling getLoginName which does not exists.

This PR adds a condition to use the previously stored user when handling PasswordUpdatedEvent.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-06-22 10:27:37 +00:00
Nextcloud bot c530f8a77c [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-22 02:28:18 +00:00
szaimen 46c7a974d5 do not display the buffer_size info if the size is already set to a certain threshold
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
2022-06-21 19:08:51 +02:00
blizzz e850afb74f Merge pull request #32894 from nextcloud/backport/32878/stable24
[stable24] Fix default toast message for failed uploads with HTTP/2
2022-06-21 18:53:47 +02:00
blizzz 1d186d4863 Merge pull request #32870 from nextcloud/backport/32813/stable24
[stable24] Run php tests when 3rdparty changed
2022-06-21 18:52:44 +02:00
Richard Steinmetz 8e5f381508 Fix email shares not being shown to other users
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2022-06-21 14:19:45 +02:00
Carl Schwan aa8280575a Merge pull request #32824 from nextcloud/automated/noid/stable24-update-psalm-baseline
[stable24] Update psalm-baseline.xml
2022-06-21 10:34:26 +02:00
nextcloud-command a7ee17cc06 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2022-06-21 04:21:04 +00:00
Nextcloud bot 9b9a4f2a67 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-21 02:29:03 +00:00
blizzz 2764c381a0 Merge pull request #32916 from nextcloud/release/24.0.2
24.0.2
2022-06-20 16:59:18 +02:00
Carl Schwan 6beddbc163 Fix profiler trying to serialize invalid utf8
The cookie value contains invalid utf8 characters most of the time so
let's just ignore it as it is also not that interesting to analyse.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-20 10:57:42 +00:00
Arthur Schiwon ef088c6076 24.0.2
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-20 07:39:03 +00:00
Nextcloud bot 7820bd2ff5 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-20 02:27:33 +00:00
Nextcloud bot 05f11310bb [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-19 02:27:58 +00:00
Nextcloud bot b4725bbfab [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-18 02:27:34 +00:00
blizzz a71d33ad91 Merge pull request #32904 from nextcloud/backport/32898/stable24
[stable24] Fix logger overwriting vars in some circumstances
2022-06-17 14:22:32 +02:00
Bill McGonigle 5da13140c2 Mention missing files subdir
Many users are getting confused by the inaccurate error message "Home storage for user $user not writable" because the storage *is* writable.  The actual issue is a missing files/ subdirectory.  cf. https://help.nextcloud.com/t/home-storage-for-user-not-writable/10831/7
By mentioning the possible cause in the error message, users are going to be able to rapidly solve their problem rather than bang their heads against the screen, Google, and eventually forums to find out that the error message is wrong in their case.
Yes, it would be better to detect and precisely describe the fault, or fix the problem automatically, but until then, be kind to the users for the next however many years.
2022-06-17 10:46:38 +00:00
Nextcloud bot bab0753507 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-17 02:27:53 +00:00
Arthur Schiwon 6b8d6de4fc make placeholder a const for reuse
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-16 18:38:40 +00:00
Arthur Schiwon ed4fcf2d17 fix overwriting original vars when logging
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-16 18:38:39 +00:00
Arthur Schiwon fc2a88197f add serializer test
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-16 18:38:39 +00:00
Nextcloud bot a61782c67f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-16 02:27:41 +00:00
Daniel Calviño Sánchez f4949f0fed Fix default toast message for failed uploads with HTTP/2
When an upload fails a toast is shown with either a specific message or
just the textual part of the HTTP error code (which comes from the
upload failure handler and set by "jQuery.ajax()". However, if there
is neither a message nor an error then the toast will show the default
message from the Toastify-js library, which is an undescriptive "Hi
there!".

When HTTP/2 is used Chromium does not provide the textual part of the
HTTP error code, so when an upload fails the toast can receive an empty
message and thus just show "Hi there!". Now an explicit message is
provided as a fallback to prevent that.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-06-15 19:39:45 +00:00
Thomas Citharel dd1ea1354d Update tests after ResetTokenBackgroundJob changes
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-06-15 09:56:20 +00:00
Thomas Citharel 0b6bd9bdcf Use OCP version of TimedJob instead of OC for ResetTokenBackgroundJob
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-06-15 09:56:20 +00:00
Thomas Citharel 77938cfca9 Make sure ResetTokenBackgroundJob doesn't execute if config is read-only
No need to try to delete the config key in config.php if we aren't
allowed to.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-06-15 09:56:19 +00:00
Nextcloud bot 224aed8839 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-15 02:28:05 +00:00
Daniel Kesselberg 873eec289c Run php tests when 3rdparty changed
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-06-14 10:38:01 +00:00
Nextcloud bot 944c792cd4 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-14 02:28:25 +00:00
blizzz 8fe0143d89 Merge pull request #32785 from nextcloud/release/24.0.2_rc1
24.0.2 RC1
2022-06-13 14:08:38 +02:00
blizzz 6ba0fdb8ef Merge pull request #32854 from nextcloud/backport/32843/stable24
[stable24] Correctly log failed attempts
2022-06-13 12:44:44 +02:00
Joas Schilling 9036fc138f Don't spam the log with fatals when maintenance mode is enabled or an upgrade has to be done
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-06-13 11:56:41 +02:00
blizzz 0cf31c277e Merge pull request #32848 from nextcloud/backport/32806/stable24
[stable24] Revert "Remove inefficient fed share scanner"
2022-06-13 11:28:19 +02:00
blizzz 8188ad5928 Merge pull request #32841 from nextcloud/backport-32059-stable24
[stable24] Fix issue #31692 of occ files:scan
2022-06-13 11:26:47 +02:00
Joas Schilling fad69c3058 Correctly log failed attempts
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-06-13 08:29:42 +00:00
Carl Schwan dd27f9b816 Revert "Remove inefficient fed share scanner"
This reverts commit ce31914314.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
(cherry picked from commit 6667007bf2)
2022-06-13 10:07:34 +02:00
blizzz a5b13da95b Merge pull request #32842 from nextcloud/backport/32685/stable24
[stable24] Fix replacing external storage password during debug log
2022-06-13 09:55:02 +02:00
blizzz a1d570b51a Merge pull request #32833 from nextcloud/backport/32799/stable24
[stable24] Fix exception handling when profile data is too long
2022-06-13 09:26:47 +02:00
Christoph Wurst e040734456 Fix replacing external storage password during debug log
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-06-13 06:18:18 +00:00
Nextcloud bot b146d8d405 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-13 02:28:24 +00:00
Richard Steinmetz 23777c9970 Fix issue #31692 of occ files:scan
occ files:scan reports error "Implicit conversion from float XXX to int loses precision"

Signed-off-by: cld4h <20869428+cld4h@users.noreply.github.com>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2022-06-12 19:57:07 +02:00
blizzz ba27191e03 Merge pull request #32444 from nextcloud/backport/32357/stable24
[stable24] remove storage wrappers when deleting the user storage
2022-06-12 19:54:14 +02:00
blizzz 5468a58ba5 Merge pull request #32416 from nextcloud/dependabot/npm_and_yarn/stable24/dompurify-2.3.8
Bump dompurify from 2.3.6 to 2.3.8
2022-06-12 19:53:39 +02:00
dependabot[bot] eed718c833 Bump dompurify from 2.3.6 to 2.3.8
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.3.6 to 2.3.8.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](https://github.com/cure53/DOMPurify/compare/2.3.6...2.3.8)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-06-12 12:33:09 +00:00
Joas Schilling d328e3cd06 Fix exception handling when profile data is too long
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-06-12 13:46:14 +02:00
Nextcloud bot 8274bb3643 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-12 02:28:02 +00:00
blizzz c63c718be4 Merge pull request #32822 from nextcloud/dependabot/composer/build/integration/stable24/guzzlehttp/guzzle-7.4.4
Update guzzlehttp/guzzle requirement from 7.4.3 to 7.4.4 in /build/integration
2022-06-12 02:42:55 +02:00
Nextcloud bot 6a9937a2fe [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-11 02:28:39 +00:00
dependabot[bot] 5e00868f88 Update guzzlehttp/guzzle requirement in /build/integration
Updates the requirements on [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) to permit the latest version.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/master/CHANGELOG.md)
- [Commits](https://github.com/guzzle/guzzle/compare/7.4.3...7.4.4)

---
updated-dependencies:
- dependency-name: guzzlehttp/guzzle
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-11 01:10:55 +00:00
blizzz eeb4de0763 Merge pull request #32708 from nextcloud/unencrypted-size-24
[24] store unencrypted size in the unencrypted_size column
2022-06-11 00:42:34 +02:00
blizzz e2c213a426 Merge pull request #32683 from nextcloud/backport/32371/stable24
[stable24] More meaningfull message when a public authenticated share's password is wrong or has expired.
2022-06-11 00:32:32 +02:00
blizzz 0cbfae6c37 Merge pull request #32603 from nextcloud/backport/32575/stable24
[stable24] Improve warning about missing pnctl
2022-06-11 00:30:28 +02:00
blizzz 5a1185f2fd Merge pull request #32585 from nextcloud/backport/32580/stable24
[stable24] Fix handling events without names in activities
2022-06-11 00:29:15 +02:00
blizzz 35b9f610d0 Merge pull request #32419 from nextcloud/dependabot/npm_and_yarn/stable24/testing-library/vue-5.8.3
Bump @testing-library/vue from 5.8.2 to 5.8.3
2022-06-11 00:27:28 +02:00
Robin Appelman ce23dc3ae6 remove storage wrappers when deleting the user storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-10 15:40:22 +00:00
blizzz 2f2de6276b Merge pull request #32638 from nextcloud/dependabot/composer/build/integration/stable24/guzzlehttp/guzzle-7.4.3
Update guzzlehttp/guzzle requirement from 7.4.2 to 7.4.3 in /build/integration
2022-06-10 15:54:40 +02:00
Vincent Petry 4e870ea41d Merge pull request #32513 from nextcloud/backport/32496/stable24
[stable24] Fix crop condition
2022-06-10 15:39:32 +02:00
Vincent Petry ddac16b6ec Merge pull request #32657 from nextcloud/backport/32655/stable24
[stable24] Handle non existing settings again
2022-06-10 15:31:58 +02:00
Vincent Petry 535b84e4e6 Merge pull request #32668 from nextcloud/backport/32583/stable24
[stable24] Fix Nextcloud Android app not showing proper name
2022-06-10 15:30:56 +02:00
Vincent Petry dbd1b20855 Merge pull request #32674 from nextcloud/backport/32670/stable24
[stable24] Fix share permissions rendering
2022-06-10 15:30:05 +02:00
Vincent Petry e5540f96f4 Merge pull request #32692 from nextcloud/backport/32471/stable24
[stable24] Make sure activities are not created when a deleted calendar object expires
2022-06-10 15:27:45 +02:00
Vincent Petry 7ba6738031 Merge pull request #32801 from nextcloud/backport/32797/stable24
[stable24] fix mounts mounted at the users home
2022-06-10 14:47:03 +02:00
Vincent Petry 8c71df2ef2 Merge pull request #32811 from nextcloud/backport/32768/stable24
[stable24] perform onetime setup earlier to ensure wrappers are registered on time
2022-06-10 14:45:36 +02:00
Robin Appelman 787b10ba2f perform onetime setup earlier to ensure wrappers are registered on time
this fixes an issue with wrappers like encryption not always being applied to mountpoint that create the storage object directly (such as external storage)

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-10 09:26:14 +00:00
Carl Schwan 5b9ec05912 Merge pull request #32758 from nextcloud/backport/stable24/upload-speed
[stable24] Make X-HAS-{MD5/SHA256} opt-in
2022-06-10 11:24:46 +02:00
Vincent Petry 3a3c3b5e1d Merge pull request #32710 from nextcloud/backport/32662/stable24
[stable24] Cleanup temporary files after finishing the write to object storage
2022-06-10 11:09:26 +02:00
Vincent Petry a71b23f9bc Merge pull request #32794 from nextcloud/automated/noid/stable24-update-psalm-baseline
[stable24] Update psalm-baseline.xml
2022-06-10 09:38:13 +02:00
Julius Härtl 241d186a2e Merge pull request #32802 from nextcloud/backport/32412/stable24
[stable24] Properly import maintenance script
2022-06-10 09:03:02 +02:00
nextcloud-command da80b5d21c Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2022-06-10 04:14:32 +00:00
Nextcloud bot e1275e705b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-10 02:34:04 +00:00
Julius Härtl 4da6b1b515 Properly import maintenance script
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-06-09 23:29:47 +00:00
Robin Appelman b110026909 fix mounts mounted at the users home
this fixes external storages with '/' as mountpoint

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-09 23:23:16 +00:00
Joas Schilling 5058c6d3a8 Merge pull request #32786 from nextcloud/backport/32765/stable24
[stable24] Add back the deleted.png file
2022-06-09 23:00:41 +02:00
Christopher Ng 59ca7931e1 Validate custom dashboard background image
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-09 16:00:13 +00:00
Louis Chemineau 8a2b70fe67 Fix share permissions rendering
The `SHARE` permissions falls into the `default` case in the switch case, causing the rendering to look like ` , Upload, Read`.

This PR changes the return value of the `default` case and adds a `filter` to remove those values.

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-06-09 15:06:56 +02:00
Anna Larch 6a9682871b Add back the deleted.png file as SVG forwarding doesn't work for /core/img
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-06-09 12:40:32 +00:00
Arthur Schiwon ba5434fbf3 24.0.2 RC1
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-09 14:28:20 +02:00
Vincent Petry 254cb7ad0c Merge pull request #32770 from nextcloud/backport/32697/stable24
[stable24] Fix get avatar authorization
2022-06-09 12:03:03 +02:00
Vincent Petry 7e819852ee Merge pull request #32776 from nextcloud/backport/32767/stable24
[stable24] handle stream wrappers in SeekableHttpStream
2022-06-09 12:01:59 +02:00
Louis 15649fc974 Merge pull request #32764 from nextcloud/backport/31981/stable24
[stable24] Temporary passwords fixes 31952
2022-06-09 11:07:20 +02:00
Robin Appelman 00e6eb2612 handle stream wrappers in SeekableHttpStream
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-09 07:58:35 +00:00
Vincent Petry 6ed03a9e6f Merge pull request #32705 from nextcloud/backport/32690/stable24
[stable24] Trim mount point before matching in encryption code
2022-06-09 09:55:29 +02:00
Vincent Petry 30654d962d Merge pull request #32752 from nextcloud/backport/32746/stable24
[stable24] Add new share attributes column
2022-06-09 09:54:59 +02:00
Nextcloud bot 270343a602 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-09 02:32:03 +00:00
Christopher Ng 887aa58905 Test all scopes
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-08 23:31:26 +00:00
Christopher Ng a64b1f77c2 Fix get avatar authorization
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-08 23:31:25 +00:00
Cyrille Bollu e35cbd2a6b Various improvements related to the recent implementation of temporary passwords
for mail shares:

1- Changes style of "forgot password?" and "Back" button
2- Adds information about share password's expiration time in the emails sent.
3- Shows password expiration time in the Share menu
4- Fixes an issue when the message "Password expires..." would be shown for non email share types (which don't have temporary passswords)
5- At share's creation, password should only be sent when it's a permanent one

See also https://github.com/nextcloud/server/issues/31952

Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-06-08 13:22:10 +00:00
Joas Schilling 1cf2ed484e Merge pull request #32750 from nextcloud/backport/32744/stable24
[stable24] Always log errors from sending federation api requests to ease debugging
2022-06-08 13:55:00 +02:00
Carl Schwan 43e8f89a21 Make X-HAS-{MD5/SHA256} opt-in
This is not always needed and slow down the upload

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
(cherry picked from commit 1b426eda44)
2022-06-08 13:39:30 +02:00
Vincent Petry 87d8afcb62 Add new share attributes column
To store more extended permissions in the future.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-06-08 09:21:42 +00:00
Joas Schilling c6bb631e2f Always log errors from sending federation api requests to ease debugging
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-06-08 09:20:16 +00:00
Nextcloud bot 84eee97e37 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-08 02:32:35 +00:00
Nextcloud bot a5e4ea7049 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-07 02:31:05 +00:00
Nextcloud bot 90c7779cf5 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-06 02:34:13 +00:00
Nextcloud bot 5296779da1 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-05 02:33:22 +00:00
Nextcloud bot 9124e60da8 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-04 02:32:07 +00:00
Robin Appelman fd2afe604e store unencrypted size in the unencrypted_size column
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-03 15:43:50 +02:00
Joas Schilling da050a3665 Merge pull request #32650 from nextcloud/update-3rdparty-stable24
[stable24] Update 3rdparty for symfony/translation:4.4.41
2022-06-03 15:31:09 +02:00
Nextcloud bot 42e00ee69b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-03 02:34:18 +00:00
Pytal 4ca4228ff6 Merge pull request #32664 from nextcloud/backport/32206/stable24 2022-06-02 11:32:31 -07:00
Christopher Ng a541f97dcc Update calendar estimation
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-02 17:06:55 +00:00
Julius Härtl 109bbf31db Cleanup temporary files after finishing the write to object storage
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-06-02 16:28:20 +00:00
Vincent Petry 3ac93a30e8 Add unit tests for encryption's isSystemWideMountPoint
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-06-02 12:02:22 +00:00
Vincent Petry 1803121428 Trim mount point before matching in encryption code
Often times the mount point has a leading slash.
This fix sanitizes it to make sure matching works.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-06-02 12:02:22 +00:00
Nextcloud bot 01ae33f4bb [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-02 02:33:05 +00:00
Thomas Citharel 3820de977b Make sure activities are not created when a deleted calendar object expires
Closes https://github.com/nextcloud/activity/issues/784

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-06-01 15:05:37 +00:00
blizzz ffaa474514 Merge pull request #32677 from nextcloud/backport/32592/stable24
[stable24] allow use of rememberme cookies for IApacheAuth backends
2022-06-01 12:25:21 +02:00
Carl Schwan d837a02118 Improve warning about missing pnctl
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-01 11:11:36 +02:00
Cyrille Bollu bef2960abf More meaningfull message when a public authenticated share's password is wrong or has expired
Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
2022-06-01 07:08:41 +00:00
John Molakvoæ e7ddf60bab Merge pull request #32510 from nextcloud/fix/theming-colours-primary-24 2022-06-01 07:39:16 +02:00
Nextcloud bot cdaf80809f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-01 02:32:36 +00:00
Arthur Schiwon e395912b0b allow use of rememberme cookies for IApacheAuth backends
- e.g. enables it for SAML backend

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-05-31 21:59:20 +00:00
John Molakvoæ 20efadff5f Properly calculate primary element based on background luminance
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-31 17:27:12 +00:00
jld3103 ad2c4139b7 Fix Nextcloud Android app not showing proper name 2022-05-31 09:23:32 +00:00
Joas Schilling 26050a48f0 Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-31 10:25:34 +02:00
John Molakvoæ 3638e65027 Merge pull request #32619 from nextcloud/backport/32618/stable24
[stable24] Fix status handling
2022-05-31 09:21:13 +02:00
Nextcloud bot 4b2bac3016 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-31 02:33:16 +00:00
Christopher Ng eb70231f70 Update contacts estimation
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-05-31 00:19:14 +00:00
Christopher Ng b85f882c23 Skip avatar on failure
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-05-31 00:19:14 +00:00
Christopher Ng 72fc8c907e Update method name
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-05-31 00:19:13 +00:00
Côme Chilliet 5a7752dcfa Add the ISizeEstimationMigrator interface for method getExportEstimatedSize
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-31 00:19:13 +00:00
Côme Chilliet 4afa609ae2 Move new IMigrator method to a specific interface ISizeEstimationMigrator
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-31 00:19:13 +00:00
Côme Chilliet dde192da4a Implement getExportEstimatedSize in migrators
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-31 00:19:13 +00:00
Côme Chilliet c16b72f588 Add a method to get estimated export size in IMigrator
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-31 00:19:13 +00:00
Carl Schwan 616464b699 Handle non existing settings again
See https://github.com/nextcloud/server/pull/28189#issuecomment-1140874991

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-30 10:57:54 +00:00
Louis 01eda634c6 Merge pull request #32470 from nextcloud/bug/noid/stable24-fix-backgroundjobs-mode
[stable24] Fix backgroundjobs mode
2022-05-30 12:52:17 +02:00
Joas Schilling eb7721c70a Update 3rdparty for symfony/translation:4.4.41
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-30 08:36:10 +02:00
Nextcloud bot 867418f189 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-30 02:32:04 +00:00
Nextcloud bot f976a67408 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-29 02:33:34 +00:00
dependabot[bot] 643cc0fcf2 Update guzzlehttp/guzzle requirement in /build/integration
Updates the requirements on [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) to permit the latest version.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/master/CHANGELOG.md)
- [Commits](https://github.com/guzzle/guzzle/compare/7.4.2...7.4.3)

---
updated-dependencies:
- dependency-name: guzzlehttp/guzzle
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-05-28 02:16:22 +00:00
dependabot[bot] 5a4fed284c Bump @testing-library/vue from 5.8.2 to 5.8.3
Bumps [@testing-library/vue](https://github.com/testing-library/vue-testing-library) from 5.8.2 to 5.8.3.
- [Release notes](https://github.com/testing-library/vue-testing-library/releases)
- [Commits](https://github.com/testing-library/vue-testing-library/compare/v5.8.2...v5.8.3)

---
updated-dependencies:
- dependency-name: "@testing-library/vue"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-05-27 23:26:26 +00:00
Joas Schilling 87ec9ef816 Merge pull request #32621 from nextcloud/backport/32601/stable24
[stable24] Move Gd failed operations to debug level
2022-05-27 13:31:43 +02:00
Joas Schilling 2d34b55afa Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-27 11:36:13 +02:00
Joas Schilling 432d2af3e3 Don't overwrite certain values if the refreshing comes in via short updates
This e.g. happens from the talk participant list which only has the status, message and icon.
Due to the overwriting e.g. the clearAt was overwritten with null
and afterwards the status modal showed "Invalid date" as "Clear at"

Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-27 11:36:13 +02:00
Git'Fellow 95147218d1 Move Gd failed operations to debug level
Instead of error
2022-05-27 09:34:49 +00:00
Joas Schilling 421cbde0eb Fix missing status with predefined status in drop-down
When a predefined status message was used, the status was not "processed"
so it was missing the translated message and the icon in the dropdown and the menu afterwards

Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-27 09:23:54 +00:00
Nextcloud bot 31235cb191 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-27 02:31:16 +00:00
Nextcloud bot 8ecbf0d2a3 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-26 02:31:37 +00:00
Joas Schilling 33d003d032 Also trim the name
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-25 07:19:05 +00:00
Joas Schilling d29bb5ff9d Fix handling events without names in activities
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-25 07:19:04 +00:00
Nextcloud bot a15652aaf7 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-25 02:36:13 +00:00
Nextcloud bot 1ce6592f63 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-24 02:33:01 +00:00
Nextcloud bot c625bb0c56 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-23 02:31:13 +00:00
Nextcloud bot 3df71a441d [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-22 02:31:05 +00:00
Nextcloud bot e34b4c74b2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-21 02:34:07 +00:00
Daniel Kesselberg 575e853c44 Fix backgroundjobs mode radio
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-05-20 14:25:00 +02:00
Carl Schwan 634a15ab71 Fix crop condition
Make sure that when fetching the image from the cache we don't
accidentally fetch the cropped image just because it also start with
256-256

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 11:03:15 +00:00
Nextcloud bot 937f039cab [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-20 02:33:17 +00:00
Simon L 0f52d5e548 Merge pull request #32457 from nextcloud/backport/32439/stable24
[stable24] adjust wording for database checks
2022-05-19 17:52:50 +02:00
blizzz 6beb527353 Merge pull request #32495 from nextcloud/releases/24.0.1/final
24.0.1
2022-05-19 14:04:26 +02:00
Arthur Schiwon 9730f7f5a3 24.0.1
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-05-19 11:48:57 +02:00
blizzz fa13c64776 Merge pull request #32472 from nextcloud/backport/32428/stable24
[stable24] Add Email validation
2022-05-19 11:46:13 +02:00
Nextcloud bot 74f26cc89e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-19 02:32:33 +00:00
Anna Larch afb3d38cb8 Add email validation
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-05-18 09:26:56 +00:00
Nextcloud bot b04eea5663 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-18 02:32:57 +00:00
szaimen 580f090f5e adjust wording for database checks
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-05-17 11:24:09 +00:00
Nextcloud bot 5b7926ee8e [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-17 02:29:41 +00:00
blizzz 55a4282493 Merge pull request #32418 from nextcloud/releases/24.0.1/rc1
24.0.1 RC 1
2022-05-17 00:23:13 +02:00
blizzz 8bb0e1e00c Merge pull request #32437 from nextcloud/bugfix/32256/backport/32220/stable24
Replace isValidEmoji by method in EmojiHelper
2022-05-16 23:41:49 +02:00
blizzz ee89136c9a Merge pull request #32424 from nextcloud/backport/32382/stable24
[stable24] only log diagnostic events if a treshhold is set
2022-05-16 23:41:10 +02:00
blizzz 4efd0cdadf Merge pull request #32123 from nextcloud/backport/32074/stable24
[stable24] tell mysql to ignore the sort index for search queries
2022-05-16 23:36:57 +02:00
Vitor Mattos 12849196ad Replace isValidEmoji by method in EmojiHelper
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-05-16 12:58:58 -03:00
Joas Schilling 762d1ff050 Merge pull request #32414 from nextcloud/backport/32305/stable24
[stable24] Fix user agent trimming on installation
2022-05-16 15:56:48 +02:00
Robin Appelman 30b0a0272b only log diagnostic events if a treshhold is set
this prevents log spam and it's rare that you actually want to very short events logged anyway

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-05-16 14:33:49 +02:00
blizzz 686d16a56b Merge pull request #32415 from nextcloud/backport/32375/stable24
[stable24] Show user account on grant loginflow step
2022-05-16 13:04:03 +02:00
blizzz 91e2a85489 Merge pull request #31985 from nextcloud/dependabot/npm_and_yarn/stable24/karma-spec-reporter-0.0.34
Bump karma-spec-reporter from 0.0.33 to 0.0.34
2022-05-16 12:08:27 +02:00
blizzz 357c4bbed9 Merge pull request #32368 from nextcloud/backport/32318/stable24
[stable24] Increase retry delay on 'Wait for S3' CI job
2022-05-16 11:59:48 +02:00
blizzz 047af51c78 Merge pull request #32329 from nextcloud/backport/32149/stable24
[stable24] fix for transferring ownership of groupfolders
2022-05-16 11:56:14 +02:00
blizzz 5e7d10aa8c Merge pull request #32320 from nextcloud/backport/32315/stable24
[stable24] Fix preview generator trying to recreate an existing folder
2022-05-16 11:55:14 +02:00
Louis d7482c8a39 Merge pull request #32402 from nextcloud/dependabot/npm_and_yarn/stable24/moment-2.29.3
Bump moment from 2.29.2 to 2.29.3
2022-05-16 11:54:02 +02:00
Robin Appelman 32cd1bed38 tell mysql to ignore the sort index for search queries
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-05-16 09:53:43 +00:00
blizzz 525206d6d3 Merge pull request #32256 from nextcloud/backport/32220/stable24
[stable24] Include more emoji chars to test and fixes after include it
2022-05-16 11:52:49 +02:00
blizzz 5b4df735ec Merge pull request #32159 from nextcloud/backport/32155/stable24
[stable24] Fx translations with trailing colon
2022-05-16 11:50:51 +02:00
Arthur Schiwon d15f8d2557 24.0.1 RC1
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-05-16 11:45:36 +02:00
Joas Schilling aea73a24a5 Extend tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-16 09:32:25 +00:00
Joas Schilling 3526babaad Show user account on grant loginflow step
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-16 09:32:23 +00:00
Joas Schilling a397614a8d Fix user agent trimming on installation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-16 09:32:17 +00:00
Nextcloud bot 89b4f5cf8f [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-16 02:29:54 +00:00
dependabot[bot] 4dc75c3e5f Bump moment from 2.29.2 to 2.29.3
Bumps [moment](https://github.com/moment/moment) from 2.29.2 to 2.29.3.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/2.29.3/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.29.2...2.29.3)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-05-15 11:27:29 +00:00
John Molakvoæ 231cbb514f Merge pull request #32386 from nextcloud/dependabot/npm_and_yarn/stable24/karma-6.3.20 2022-05-15 12:10:39 +02:00
Nextcloud bot b67ccec739 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-14 02:29:37 +00:00
John Molakvoæ f02ccc6d29 Merge pull request #32360 from nextcloud/backport/stable24/share_search_tweaks 2022-05-13 20:15:26 +02:00
dependabot[bot] 905a34cf14 Bump karma from 6.3.17 to 6.3.20
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.17 to 6.3.20.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.17...v6.3.20)

---
updated-dependencies:
- dependency-name: karma
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-05-13 15:33:25 +00:00
Carl Schwan 861a787086 Merge pull request #32365 from nextcloud/backport/32335/stable24
[stable24] don't unjail the path when getting the storage info
2022-05-13 13:24:57 +02:00
Nextcloud bot 2d52bda1ed [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-13 02:29:17 +00:00
Git'Fellow 34abed9f7c Increase retry delay on 'Wait for S3' CI job
1 second means 10 seconds before failure (1x10). Increasing to 10x10 before failure.
2022-05-12 21:09:25 +00:00
Robin Appelman cc4aab14d7 don't unjail the path when getting the storage info
the original reason for adding it no longer exist.

This was added with #30985 since then the share source storage was also used, however this was changed with #32076

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-05-12 19:02:45 +00:00
Louis Chemineau 9a131a1cf7 Do not display search option in Shares settings
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-12 15:09:05 +02:00
Louis Chemineau 37a9a6246f Add setting to ignore email during search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-12 15:05:13 +02:00
Louis Chemineau 11bd644251 Use email settings in DAV search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-12 15:05:10 +02:00
Louis Chemineau 55fda0b769 Use share setting in DAV search
shareapi_restrict_user_enumeration_full_match_ignore_second_display_name was introduced to ignore second display name during search from the share panel. But this setting was not respected by search from the calendar application. This fix it.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-12 15:05:05 +02:00
Joas Schilling 8aa4b1377f Merge pull request #32275 from nextcloud/backport/32249/stable24
[stable24] Expose shareWithDisplayNameUnique also on autocomplete endpoint
2022-05-12 11:46:05 +02:00
Vanessa Pertsch 0722ee4a86 fix for transferring ownership of groupfolders
Signed-off-by: Vanessa Pertsch <vanessa.pertsch@nextcloud.com>
2022-05-11 06:45:34 +00:00
Richard Steinmetz 8fcef8848a Fix preview generator trying to recreate an existing folder
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2022-05-10 08:14:40 +00:00
Nextcloud bot 4b97259401 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-10 02:36:36 +00:00
Côme Chilliet f2810d0725 Merge pull request #32282 from nextcloud/backport/32246/stable24
[stable24] Don't use hash to check if binding worked
2022-05-09 09:30:55 +02:00
Nextcloud bot ba927cd185 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-09 02:29:04 +00:00
Nextcloud bot 14b9b6b60b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-08 02:29:01 +00:00
Nextcloud bot 10e4da64f6 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-07 02:28:29 +00:00
Nextcloud bot 414725145b [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-06 02:28:49 +00:00
Carl Schwan a9e674bec0 Don't use slow hashing to check the LDAP binding
Using password_hash is expensive and should be used for hashing
passwords when saving them in the database. Here we just want to see if
the bind was already done with the given password, so use a fast hashing
algorythm.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-05 16:59:26 +00:00
Joas Schilling 2232ff3eb1 Merge pull request #32241 from nextcloud/revert-32239-revert-32214-backport/32212/stable24
Revert "Revert "[stable24] Make the order of reactions reliable""
2022-05-05 18:57:15 +02:00
Joas Schilling 48c6b73f2d Expose shareWithDisplayNameUnique also on autocomplete endpoint
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-05 07:25:54 +00:00
Vincent Petry 4f86a5051f Allow compatibility wrapper on local external storage
The check was likely in place to prevent adding the wrapper on the root
and home storage, which is not possible anyway since the encoding option cannot
be set on that mount.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-05-05 06:22:24 +00:00
Nextcloud bot e295f5a4a2 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-05 02:28:40 +00:00
blizzz ee28bf89ba Merge pull request #32236 from nextcloud/backport/31758/stable24
[stable24] Use sabre function directly rather than duplicating it
2022-05-04 14:46:44 +02:00
Simon L 15bd748709 Merge pull request #32153 from nextcloud/backport/32114/stable24
[stable24] fix showing of all apps are up-to-date in apps management
2022-05-04 10:31:59 +02:00
Simon L 602f44954f Merge pull request #32219 from nextcloud/backport/32218/stable24
[stable24] Revert "Show the child folders in the breadcrumb menu when on a parent entry."
2022-05-04 10:16:23 +02:00
Simon L de4cb6fa5e Merge pull request #32181 from nextcloud/backport/32139/stable24
[stable24] fix social sharing buttons
2022-05-04 10:15:45 +02:00
Simon L b9a1d13724 Merge pull request #32133 from nextcloud/backport/32121/stable24
[stable24] update description of cronjob settings to be aligned to the documenta…
2022-05-04 10:15:07 +02:00
Nextcloud bot c14b3004ee [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-04 02:30:46 +00:00
Vitor Mattos 37a04e6a8b Include more emoji chars to test and fixes after include it
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-05-03 12:58:05 -03:00
Nextcloud bot 10ea56bfe6 [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-03 02:29:02 +00:00
blizzz 5f37aacb31 Merge pull request #32240 from nextcloud/release/final/24.0.0
24.0.0
2022-05-02 16:04:49 +02:00
blizzz f44f022483 Revert "Revert "[stable24] Make the order of reactions reliable"" 2022-05-02 15:32:35 +02:00
blizzz 929c0f80e0 Merge pull request #32239 from nextcloud/revert-32214-backport/32212/stable24
Revert "[stable24] Make the order of reactions reliable"
2022-05-02 15:32:27 +02:00
Nextcloud bot 82dc13c3af [tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-02 13:12:51 +00:00
blizzz dde611b3ed Revert "[stable24] Make the order of reactions reliable" 2022-05-02 14:46:24 +02:00
Arthur Schiwon 6b7255931a 24.0.0
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-05-02 13:58:25 +02:00
Côme Chilliet 7b305c4c77 Restart CI 2022-05-02 11:44:37 +02:00
Vincent Petry 71cb301f97 Update psalm baseline for Sabre decodePath
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-05-02 10:25:28 +02:00
Côme Chilliet 03132f71c0 Trying without the use
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-02 10:25:20 +02:00
Côme Chilliet 281751e264 Use sabre function directly rather than duplicating it
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-02 10:25:08 +02:00
John Molakvoæ 72c4047ce9 Merge pull request #32214 from nextcloud/backport/32212/stable24 2022-04-30 12:43:28 +02:00
Simon L e8f1ad060e Revert "Show the child folders in the breadcrumb menu when on a parent entry."
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-04-29 13:51:56 +00:00
Joas Schilling b806e1f009 Make the order of reactions reliable
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-28 17:43:22 +00:00
blizzz 04055e79c0 Merge pull request #32207 from nextcloud/release/rc3/24
24.0.0 RC3
2022-04-28 14:33:13 +02:00
Vincent Petry 16bc8af0f3 Merge pull request #32193 from nextcloud/backport/32189/stable24
[stable24] Mount Profile view after DOMContentLoaded
2022-04-28 13:08:11 +02:00
Arthur Schiwon 482b42e4c8 24.0.0 RC3
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-04-28 12:22:37 +02:00
Louis Chemineau fafc3ca2e0 Mount profile after DOMContentLoaded
Fix https://github.com/nextcloud/server/issues/32187

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-04-27 17:27:16 +00:00
szaimen 8dd4674ee8 fix social sharing buttons
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-04-27 11:29:13 +00:00
szaimen bde2ca6321 add backport of #32154
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-04-27 09:49:30 +02:00
blizzz 400f378183 Merge pull request #32035 from nextcloud/release/rc2/24.0.0
24.0.0 RC2
2022-04-26 22:05:59 +02:00
Joas Schilling d1dc2a18ee Fix translations with trailing colons
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-26 11:41:15 +00:00
Joas Schilling 0b7ab9c092 Add a unit test for translation with trailing colon
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-26 11:41:15 +00:00
blizzz dd93df22f4 Merge pull request #32141 from nextcloud/backport/32084/stable24
[stable24] only need to setup root for groupfolders
2022-04-26 11:11:00 +02:00
szaimen 2c938d9de8 fix showing of all apps are up-to-date in apps management
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-04-26 08:36:06 +00:00
Robin Appelman aae1769e60 Only need to setup root for groupfolders
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-25 17:39:29 +00:00
Vincent Petry ff64a731b0 Merge pull request #32138 from nextcloud/stable24-directory-listing-optimize-add-submount
[stable24] optimize adding submount info to directory content
2022-04-25 19:33:58 +02:00
Carl Schwan 1bb4d7853f Merge pull request #32134 from nextcloud/backport/32033/stable24
[stable24] Fix scanning app data with metadata
2022-04-25 18:56:52 +02:00
Robin Appelman 9dcc9b50e9 optimize adding submount info to directory content
no need to loop when we can do a hashtable lookup

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-25 16:28:05 +02:00
Vincent Petry af4258436b Merge pull request #32118 from nextcloud/backport/32082/stable24
[stable24] use a lazy user for the file owner when listing a directory
2022-04-25 16:27:28 +02:00
Vincent Petry bce6549588 Merge pull request #32087 from nextcloud/backport/32076/stable24
[stable24] use and cache root storage info if a share can't be resolved
2022-04-25 16:26:11 +02:00
Vincent Petry 59bff4746f Merge pull request #32119 from nextcloud/backport/32112/stable24
[stable24] Add missing index for oc_mounts queries
2022-04-25 16:25:51 +02:00
Carl Schwan 953c8875db Fix scanning app data with metadata
Previously we were listening to change in the appdata folder but an
appdata scan didn't setup the file system, so the view was unavailable.

**Test plan:**

1. rm -rf data/appdata_...../preview data/<user>/Media
2. occ files:scan-app-data
3. occ files:scan <user>

No errors and the files and metadata are correctly removed from the
database too.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-25 13:54:38 +00:00
szaimen a9e2851b7e update description of cronjob settings to be aligned to the documentation update
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-04-25 13:49:12 +00:00
Vincent Petry 8f34bc833c Merge pull request #32116 from nextcloud/backport/32109/stable24
[stable24] Get not only time-sensitive next job from list but any when not in cron-mode
2022-04-25 15:16:28 +02:00
Robin Appelman 79672ed6d6 Use a lazy user for the file owner when listing a directory
Only getUID and getDisplayName are called on the file owner objects anyway
and we can get this information often without DB request

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-25 14:59:29 +02:00
Vincent Petry d1e244b859 Merge pull request #32065 from nextcloud/backport/32047/stable24
[stable24] Cache display name
2022-04-25 14:57:11 +02:00
Joas Schilling 59ce66b9ea Bump version
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-25 12:44:37 +02:00
Joas Schilling c877bd3f7e Fix older migrations to the version pattern
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-25 12:44:05 +02:00
Joas Schilling 723814c0fd Add missing index
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-25 12:44:00 +02:00
Kirill Popov edfba7f151 Get not only time-sensitive next job from list but any
Before the change webcron used to select
**only** time-sensitive tasks.

Signed-off-by: Kirill Popov <kirill.s.popov@gmail.com>
2022-04-25 10:34:09 +00:00
blizzz f0d4716af3 Merge pull request #32083 from nextcloud/backport/32040/stable24
[stable24] only register mounts that are new from providers that are new during a full setup
2022-04-22 23:13:20 +02:00
Robin Appelman b541d0b415 add logging of failed quota info
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-22 19:29:15 +00:00
Robin Appelman 7b604c1516 use and cache root storage info if a share can't be resolved
as is a broken share will never be cached

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-22 19:29:15 +00:00
blizzz ad722411d3 Merge pull request #32075 from nextcloud/backport/32053/stable24
[stable24] cache the verification of the share mountpoint
2022-04-22 17:09:02 +02:00
Robin Appelman c727beba9f only register mounts that are new from providers that are new during a full setup
this fixes cases where during the (partial) setup of a shared mount a full setup is triggered

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-22 15:06:30 +00:00
blizzz 0450512711 Merge pull request #32062 from nextcloud/backport/32048/stable24
[stable24] cache storage info in memcache for 5m
2022-04-22 16:51:27 +02:00
blizzz ec3575c646 Merge pull request #32051 from nextcloud/fix-talk-branch-used-by-integration-tests-in-stable24
[stable24] Fix Talk branch used by integration tests
2022-04-22 16:42:23 +02:00
blizzz 006eaf0e8a Merge pull request #32063 from nextcloud/backport/32049/stable24
[stable24] Add known dav properties to ignore list
2022-04-22 15:49:19 +02:00
blizzz 98a260940f Merge pull request #32066 from nextcloud/backport/32045/stable24
[stable24] cache fullSetupRequired locally
2022-04-22 15:46:09 +02:00
Robin Appelman 6ca689aff8 cache display names in local memory before external memcache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-22 15:22:16 +02:00
Carl Schwan 40ac4e8197 Update cache when display name change
This improve the correctness of the data

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-22 15:22:16 +02:00
Carl Schwan 3d49fe473a Cache display name
This should saves some query in the share backend when displaying the
owner and it's not important if the display name is 10 minutes outdated
as it is very rare that this gets changed.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-22 15:22:16 +02:00
Robin Appelman 41844ea51c cache the verification of the share mountpoint
after the initial verification this can only really be invalidated by a system mount (external/group/etc) being created at the share target since any normal file/folder creation will already conflict with the share

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-22 12:40:48 +00:00
blizzz efde83e07f Merge pull request #32046 from nextcloud/backport/32042/stable24
[stable24] improve optimization for SharedStorage::instanceOfStorage(Common)
2022-04-22 14:34:13 +02:00
blizzz b9bfd5aba8 Merge pull request #32027 from nextcloud/backport/32024/stable24
[stable24] ignore forbidden files while scanning local storage
2022-04-22 11:38:04 +02:00
Robin Appelman f7a0157589 cache fullSetupRequired locally
no need to hit redis every time

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-22 09:36:02 +00:00
John Molakvoæ fdaf6d0db2 Merge pull request #32029 from nextcloud/backport/32021/stable24 2022-04-22 11:29:44 +02:00
John Molakvoæ a3155d8396 Merge pull request #32026 from nextcloud/backport/32022/stable24 2022-04-22 11:29:28 +02:00
Julius Härtl 4bc7f02b57 Add known dav properties to ignore list
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-04-22 10:47:09 +02:00
Robin Appelman b2367f4567 cache storage info in memcache for 5m
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-22 10:43:13 +02:00
Daniel Calviño Sánchez aff45d4af0 Fix Talk branch used by integration tests in stable24
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-04-21 17:25:58 +02:00
Robin Appelman 8fc44d24eb also apply the fix for the other storage types
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-21 14:29:30 +00:00
Robin Appelman 553812d6b6 improve optimization for SharedStorage::instanceOfStorage(Common)
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-21 14:29:30 +00:00
Arthur Schiwon fb9675537a 24.0.0 RC2
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-04-21 11:06:02 +02:00
Christopher Ng 7476e118aa Fix warning
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-04-20 16:23:27 +00:00
Christopher Ng 7be2f5bcdb Update naming of address book exports
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-04-20 16:23:27 +00:00
Christopher Ng add66bc918 Fix export of shared calendars
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-04-20 16:23:27 +00:00
Robin Appelman 29dc5c8cb5 ignore forbidden files while scanning local storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-20 12:39:32 +00:00
Joas Schilling f6e51690a2 Fix test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-20 12:26:41 +00:00
Arthur Schiwon 543277cb43 log stacktrace for 'Backends provided no user object'
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-04-20 12:26:41 +00:00
dependabot[bot] 5208e2cf41 Bump karma-spec-reporter from 0.0.33 to 0.0.34
Bumps [karma-spec-reporter](https://github.com/tmcgee123/karma-spec-reporter) from 0.0.33 to 0.0.34.
- [Release notes](https://github.com/tmcgee123/karma-spec-reporter/releases)
- [Commits](https://github.com/tmcgee123/karma-spec-reporter/compare/v0.0.33...v0.0.34)

---
updated-dependencies:
- dependency-name: karma-spec-reporter
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-04-18 18:10:05 +00:00
13103 changed files with 600178 additions and 856518 deletions
+15
View File
@@ -0,0 +1,15 @@
codecov:
branch: stable24
ci:
- drone.nextcloud.com
- !scrutinizer-ci.com
coverage:
precision: 2
round: down
range: "70...100"
status:
project: off
patch: off
comment: off
+38 -82
View File
@@ -1,91 +1,47 @@
FROM ubuntu:noble
FROM ubuntu:focal
ARG DEBIAN_FRONTEND=noninteractive
# PHP
RUN apt-get update -y && \
apt install -y apache2 vim software-properties-common sudo nano gnupg2 wget curl git \
lsb-release ca-certificates apt-transport-https && \
add-apt-repository ppa:ondrej/php -y && \
apt-get update -y
RUN apt-get update -y
RUN apt-get install --no-install-recommends -y \
php8.4 \
php8.4-common \
php8.4-gd \
php8.4-zip \
php8.4-curl \
php8.4-xml \
php8.4-xmlrpc \
php8.4-mbstring \
php8.4-sqlite \
php8.4-xdebug \
php8.4-pgsql \
php8.4-intl \
php8.4-imagick \
php8.4-gmp \
php8.4-apcu \
php8.4-bcmath \
php8.4-redis \
php8.4-soap \
php8.4-imap \
php8.4-opcache \
php8.4-cli \
php8.4-dev \
libmagickcore-6.q16-7-extra \
php7.4 \
php7.4-gd \
php7.4-zip \
php7.4-curl \
php7.4-xml \
php7.4-mbstring \
php7.4-sqlite \
php7.4-xdebug \
php7.4-pgsql \
php7.4-intl \
php7.4-imagick \
php7.4-gmp \
php7.4-apcu \
php7.4-bcmath \
libmagickcore-6.q16-3-extra \
curl \
vim \
lsof \
make \
unzip
nodejs \
npm
# Composer
RUN curl -sS https://getcomposer.org/installer -o /tmp/composer-setup.php && \
curl -sS https://composer.github.io/installer.sig -o /tmp/composer-setup.sig && \
php -r "if (hash_file('sha384', '/tmp/composer-setup.php') !== trim(file_get_contents('/tmp/composer-setup.sig'))) { echo 'Composer installation failed, invalid hash'; exit(1); }" && \
php /tmp/composer-setup.php --install-dir=/usr/local/bin --filename=composer && \
rm /tmp/composer-setup.php /tmp/composer-setup.sig
RUN echo "xdebug.remote_enable = 1" >> /etc/php/7.4/cli/conf.d/20-xdebug.ini
RUN echo "xdebug.remote_autostart = 1" >> /etc/php/7.4/cli/conf.d/20-xdebug.ini
RUN echo "xdebug.remote_enable = 1" >> /etc/php/8.4/cli/conf.d/20-xdebug.ini && \
echo "xdebug.remote_autostart = 1" >> /etc/php/8.4/cli/conf.d/20-xdebug.ini && \
echo "apc.enable_cli=1" >> /etc/php/8.4/cli/conf.d/20-apcu.ini
# Autostart XDebug for apache
RUN { \
echo "xdebug.mode=debug"; \
echo "xdebug.start_with_request=yes"; \
} >> /etc/php/8.4/apache2/conf.d/20-xdebug.ini
# Increase PHP memory limit to 512mb
RUN sed -i 's/memory_limit = .*/memory_limit = 512M/' /etc/php/8.4/apache2/php.ini
# Docker CLI only (for controlling host Docker via socket)
RUN install -m 0755 -d /etc/apt/keyrings && \
curl -fsSL https://download.docker.com/linux/ubuntu/gpg -o /etc/apt/keyrings/docker.asc && \
chmod a+r /etc/apt/keyrings/docker.asc && \
echo \
"deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/ubuntu \
$(. /etc/os-release && echo "${UBUNTU_CODENAME:-$VERSION_CODENAME}") stable" | \
tee /etc/apt/sources.list.d/docker.list > /dev/null && \
apt-get update -y && \
apt-get install -y docker-ce-cli && \
ln -s /var/run/docker-host.sock /var/run/docker.sock
# Dedicated DevContainer user runs Apache
ENV APACHE_RUN_USER=devcontainer
ENV APACHE_RUN_GROUP=devcontainer
# Delete any existing user/group with UID/GID 1000 first
RUN (getent passwd 1000 && userdel -r $(getent passwd 1000 | cut -d: -f1)) || true && \
(getent group 1000 && groupdel $(getent group 1000 | cut -d: -f1)) || true && \
groupadd -g 1000 ${APACHE_RUN_GROUP} && \
useradd -u 1000 -g 1000 -ms /bin/bash ${APACHE_RUN_USER} && \
adduser ${APACHE_RUN_USER} sudo && \
echo '%sudo ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers && \
sed -ri "s/^export APACHE_RUN_USER=.*$/export APACHE_RUN_USER=${APACHE_RUN_USER}/" "/etc/apache2/envvars" && \
sed -ri "s/^export APACHE_RUN_GROUP=.*$/export APACHE_RUN_GROUP=${APACHE_RUN_GROUP}/" "/etc/apache2/envvars"
USER devcontainer
# NVM
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.0/install.sh | bash
RUN bash --login -i -c 'source /home/devcontainer/.bashrc && nvm install 22'
WORKDIR /var/www/html
# Docker
RUN apt-get -y install \
apt-transport-https \
ca-certificates \
curl \
gnupg-agent \
software-properties-common
RUN curl -fsSL https://download.docker.com/linux/ubuntu/gpg | apt-key add -
RUN add-apt-repository \
"deb [arch=amd64] https://download.docker.com/linux/ubuntu \
$(lsb_release -cs) \
stable"
RUN apt-get update -y
RUN apt-get install -y docker-ce docker-ce-cli containerd.io
RUN ln -s /var/run/docker-host.sock /var/run/docker.sock
-2
View File
@@ -1,2 +0,0 @@
SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
SPDX-License-Identifier: AGPL-3.0-or-later
-76
View File
@@ -1,76 +0,0 @@
<!--
- SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
- SPDX-License-Identifier: AGPL-3.0-or-later
-->
# Nextcloud DevContainer
## Usage
Make sure you have the [VSCode DevContainer](https://code.visualstudio.com/docs/devcontainers/containers) extensions installed. If you open the project, VSCode will ask you if you want to open it inside of the DevContainer. If that's not the case, use <kbd>F1</kbd>&rarr;*Dev Containers: Open Folder in Container*.
Alternatively open the project directly in [GitHub Codespaces](https://github.com/codespaces/new?hide_repo_select=true&ref=master&repo=60243197&skip_quickstart=true).
That's already it. Everything else will be configured automatically by the Containers startup routine.
## Credentials
On first start the Container installs and configures Nextcloud with the following credentials:
**Nextcloud Admin Login**
Username: `admin` <br>
Password: `admin`
**Postgres credentials**
Username: `postgres` <br>
Password: `postgres` <br>
Database: `postgres`
## Services
The following services will be started:
| Service | Local port | Description |
|---------|------------|-------------|
| Nextcloud (served via Apache) | `80` | The main application |
| Mailhog | `8025` | SMTP email delivery for testing |
| Adminer | `8080` | Database viewer. Use credentials from above and connect to `localhost` to get access to the NC database |
## Permissions
The container runs with the user `devcontainer` who is also running the Apache2 process. All mounted source files have
proper permissions so that this user can access everything which is inside the current workspace. If you need to
get root permissions for whatever reason, use `sudo su` or `sudo <command>` (for example `sudo service apache2 restart`).
Everything else (like building the application, adjusting files, ...) should be done as `devcontainer` user.
## NodeJs and NVM
The container comes with [`nvm`](https://github.com/nvm-sh/nvm) and Node 16 installed. This should be sufficient to
build Nextcloud Core sources via `make`. If you need a different Node Version (for example for
app development), you can easily switch between different versions by running:
```bash
# Install and use Node 14
nvm install 14
nvm use 14
# Check version
node -v
# Switch back to Node 16
nvm use 16
# Check version
node -v
```
Note that `nvm` is only installed for the user `devcontainer` and won't work out of the box for
any other user.
## Debugging
The Apache webserver is already configured to automatically try to connect to a debugger process
listening on port `9003`. To start the VSCode debugger process, use the delivered debug profile `Listen for XDebug`.
After you started the VSCode debugger, just navigate to the appropriate Nextcloud URL to get your
debug hits.
+3 -11
View File
@@ -1,11 +1,6 @@
<?php
/**
* SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
$codespaceName = getenv('CODESPACE_NAME');
$codespaceDomain = getenv('GITHUB_CODESPACES_PORT_FORWARDING_DOMAIN');
$cloudEnvironmentId = getenv('CLOUDENV_ENVIRONMENT_ID');
$CONFIG = [
'mail_from_address' => 'no-reply',
@@ -17,10 +12,7 @@ $CONFIG = [
'memcache.local' => '\OC\Memcache\APCu',
];
if(is_string($codespaceName) && !empty($codespaceName) && is_string($codespaceDomain) && !empty($codespaceDomain)) {
$host = $codespaceName . '-80.' . $codespaceDomain;
$CONFIG['overwritehost'] = $host;
$CONFIG['overwrite.cli.url'] = 'https://' . $host;
if($cloudEnvironmentId !== true) {
$CONFIG['overwritehost'] = $cloudEnvironmentId . '-80.apps.codespaces.githubusercontent.com';
$CONFIG['overwriteprotocol'] = 'https';
$CONFIG['trusted_domains'] = [ $host ];
}
+11 -17
View File
@@ -3,26 +3,20 @@
"dockerComposeFile": "docker-compose.yml",
"service": "nextclouddev",
"postCreateCommand": ".devcontainer/setup.sh",
"postStartCommand": ".devcontainer/postStart.sh",
"forwardPorts": [
80,
8080,
8025
],
"customizations": {
"vscode": {
"extensions": [
"felixfbecker.php-debug",
"felixfbecker.php-intellisense",
"ms-azuretools.vscode-docker",
"xdebug.php-debug",
"donjayamanne.githistory"
],
"settings": {
"php.suggest.basic": false
}
}
},
"workspaceFolder": "/var/www/html",
"remoteUser": "devcontainer"
"runArgs": [
"--privileged"
],
"extensions": [
"felixfbecker.php-debug",
"felixfbecker.php-intellisense",
"ms-azuretools.vscode-docker"
],
"settings": {
"php.suggest.basic": false,
}
}
-2
View File
@@ -1,2 +0,0 @@
SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
SPDX-License-Identifier: AGPL-3.0-or-later
+2 -10
View File
@@ -1,13 +1,11 @@
# SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
version: '3'
services:
nextclouddev:
build: .
volumes:
- .:/workspace:cached
- /var/run/docker.sock:/var/run/docker-host.sock
- ..:/var/www/html
command: /var/www/html/.devcontainer/entrypoint.sh
command: /bin/sh -c "while sleep 1000; do :; done"
ports:
- 80:80
- 8080:8080
@@ -18,9 +16,6 @@ services:
restart: always
environment:
POSTGRES_PASSWORD: postgres
PGDATA: /data/postgres
volumes:
- db:/data/postgres
network_mode: service:nextclouddev
adminer:
@@ -32,6 +27,3 @@ services:
image: mailhog/mailhog
restart: always
network_mode: service:nextclouddev
volumes:
db:
-8
View File
@@ -1,8 +0,0 @@
#!/bin/bash
#
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
#
sudo service apache2 start
while sleep 1000; do :; done
-14
View File
@@ -1,14 +0,0 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"name": "Listen for Xdebug",
"type": "php",
"request": "launch",
"port": 9003
}
]
}
-2
View File
@@ -1,2 +0,0 @@
SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
SPDX-License-Identifier: AGPL-3.0-or-later
-13
View File
@@ -1,13 +0,0 @@
#!/bin/bash
#
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
#
# Set git safe.directory
git config --global --add safe.directory /var/www/html
git config --global --add safe.directory /var/www/html/3rdparty
# Ensure devcontainer user has access to docker socket
if [ -S /var/run/docker.sock ]; then
sudo chmod 666 /var/run/docker.sock
fi
-25
View File
@@ -1,33 +1,8 @@
#!/bin/bash
#
# SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
#
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )/../" >/dev/null 2>&1 && pwd )"
cd $DIR/
git submodule update --init
# Codespace config
cp .devcontainer/codespace.config.php config/codespace.config.php
# VSCode debugger profile
mkdir -p .vscode && cp .devcontainer/launch.json .vscode/launch.json
# Onetime installation setup
if [[ ! $(sudo -u ${APACHE_RUN_USER} php occ status) =~ installed:[[:space:]]*true ]]; then
echo "Running NC installation"
sudo -u ${APACHE_RUN_USER} php occ maintenance:install \
--verbose \
--database=pgsql \
--database-name=postgres \
--database-host=127.0.0.1 \
--database-port=5432 \
--database-user=postgres \
--database-pass=postgres \
--admin-user admin \
--admin-pass admin
fi
sudo service apache2 restart
+2039
View File
File diff suppressed because it is too large Load Diff
+4 -15
View File
@@ -1,8 +1,5 @@
# https://editorconfig.org
# SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
root = true
[*]
@@ -13,6 +10,10 @@ indent_style = tab
insert_final_newline = true
trim_trailing_whitespace = true
[*.feature]
indent_size = 2
indent_style = space
[*.yml]
indent_size = 2
indent_style = space
@@ -22,15 +23,3 @@ trim_trailing_whitespace = false
[*.svg]
insert_final_newline = false
[package*.json]
indent_size = 2
indent_style = space
[build/psalm-baseline.xml]
indent_size = 2
indent_style = space
[config/*config.php]
indent_size = 2
indent_style = space
-3
View File
@@ -1,3 +0,0 @@
watch_file lib/versioncheck.php
watch_file package.json
use flake
+11
View File
@@ -0,0 +1,11 @@
# Ignoring folders for eslint
node_modules/
3rdparty/
**/vendor/
**/l10n/
**/js/*
*.config.js
tests/lib/
# TODO: remove when comments files is not using handlebar templates anymore
apps/comments/src/templates.js
+28
View File
@@ -0,0 +1,28 @@
module.exports = {
globals: {
__webpack_nonce__: true,
_: true,
$: true,
moment: true,
escapeHTML: true,
oc_userconfig: true,
dayNames: true,
firstDay: true,
},
extends: ['@nextcloud'],
rules: {
'no-tabs': 'warn',
// TODO: make sure we fix this as this is bad vue coding style.
// Use proper sync modifier
'vue/no-mutating-props': 'warn',
'vue/custom-event-name-casing': ['error', 'kebab-case', {
// allows custom xxxx:xxx events formats
ignores: ['/^[a-z]+(?:-[a-z]+)*:[a-z]+(?:-[a-z]+)*$/u'],
}],
},
settings: {
jsdoc: {
mode: 'typescript',
},
},
}
-21
View File
@@ -2,24 +2,3 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
# Format control structures
caff1023ea72bb2ea94130e18a2a6e2ccf819e5f
# Update to coding-standard 1.1.1
aa5f037af71c915424c6dcfd5ad2dc82797dc0d6
# Update to coding-standard 1.2.3
af6de04e9e141466dc229e444ff3f146f4a34765
0bd284cb81b6866338aaaa67aa1d81ef9bfbb2ab
8af7ecb2576071f170ecbb0aa2311b26581e40e2
# Update to coding-standard 1.3.1
9836e9b16484582d309c8437ab46d82e34956941
# Automated refactorings
49dd79eabb2b8902559a7a4e8f8fcad54f46b604
# @nextcloud/vue import paths
b06f5ba4c47450f355a8903c1a93ac68e8c6cfc2
# Update to coding-standard 1.4.0
5981b7eb512aa411f51cad541d01c5c6e93476f0
# Migrate `and` `or` operators to logical `&&` `||` operators
660f3f6fd1ae5539b8f74bfa48859d1b9f1e6abf
# Migrate to ESLint v9 enforced code style
91f3b6b4ee60e0f8bb6e21f92d5bc52e4cebe657
+1 -5
View File
@@ -1,6 +1,2 @@
# SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
/dist/* binary
/package-lock.json merge=binary
/core/css/*.css* binary
/.devcontainer/*.sh text eol=lf
/package-lock.json binary
+7 -108
View File
@@ -1,111 +1,10 @@
# Fallback owners for code review - ensure all PRs have someone assigned for review.
# (the last match will used so this is only used if there is no more specific code owner below)
# Backend
# is the first and gets everything to make things easier from matching syntax
* @nextcloud/server-backend
# Frontend
# this will override the backend code owners if needed
/__mocks__ @nextcloud/server-frontend
/__tests__ @nextcloud/server-frontend
/dist @nextcloud/server-frontend
/cypress @nextcloud/server-frontend
**/css @nextcloud/server-frontend
**/js @nextcloud/server-frontend
**/src @nextcloud/server-frontend
*.js @nextcloud/server-frontend
*.cjs @nextcloud/server-frontend
*.mjs @nextcloud/server-frontend
*.ts @nextcloud/server-frontend
# dependency management
package.json @nextcloud/server-dependabot @nextcloud/server-frontend
package-lock.json @nextcloud/server-dependabot
# App maintainers
/apps/admin_audit/appinfo/info.xml @luka-nextcloud @blizzz
/apps/cloud_federation_api/appinfo/info.xml @nfebe @mejo-
/apps/comments/appinfo/info.xml @edward-ly @sorbaugh
/apps/contactsinteraction/appinfo/info.xml @kesselb @SebastianKrupinski
/apps/contactsinteraction/lib @kesselb @SebastianKrupinski
/apps/contactsinteraction/tests @kesselb @SebastianKrupinski
/apps/dashboard/appinfo/info.xml @julien-nc @juliusknorr
/apps/dav/lib/CalDAV @st3iny @SebastianKrupinski @tcitworld
/apps/dav/lib/CardDAV @hamza221 @SebastianKrupinski
/apps/dav/tests/unit/CalDAV @st3iny @SebastianKrupinski @tcitworld
/apps/dav/tests/unit/CardDAV @hamza221 @SebastianKrupinski
/apps/encryption/appinfo/info.xml @come-nc @icewind1991
/apps/federatedfilesharing/appinfo/info.xml @icewind1991 @danxuliu
/apps/federation/appinfo/info.xml @nfebe @sorbaugh
/apps/files/appinfo/info.xml @skjnldsv @ArtificialOwl @come-nc @artonge @icewind1991 @szaimen @susnux @nfebe
/apps/files_external/appinfo/info.xml @icewind1991 @artonge
/apps/files_reminders/appinfo/info.xml @skjnldsv @sorbaugh
/apps/files_sharing/appinfo/info.xml @skjnldsv @come-nc
/apps/files_trashbin/appinfo/info.xml @icewind1991 @sorbaugh
/apps/files_versions/appinfo/info.xml @artonge @icewind1991
/apps/oauth2/appinfo/info.xml @julien-nc @ChristophWurst
/apps/provisioning_api/appinfo/info.xml @provokateurin @nickvergessen
/apps/settings/appinfo/info.xml @JuliaKirschenheuter @sorbaugh
/apps/sharebymail/appinfo/info.xml @Altahrim @skjnldsv
/apps/systemtags/appinfo/info.xml @Antreesy @marcelklehr
/apps/theming/appinfo/info.xml @skjnldsv @juliusknorr
/apps/twofactor_backupcodes/appinfo/info.xml @st3iny @miaulalala @ChristophWurst
/apps/updatenotification/appinfo/info.xml @JuliaKirschenheuter @sorbaugh
/apps/user_ldap/appinfo/info.xml @come-nc @blizzz
/apps/user_status/appinfo/info.xml @Antreesy @nickvergessen
/apps/weather_status/appinfo/info.xml @julien-nc @juliusknorr
/apps/webhook_listeners/appinfo/info.xml @come-nc @julien-nc
/apps/workflowengine/appinfo/info.xml @blizzz @juliusknorr
# Files frontend expertise
/apps/files/src* @skjnldsv @nextcloud/server-frontend
/apps/files_external/src* @skjnldsv @nextcloud/server-frontend
/apps/files_reminders/src* @skjnldsv @nextcloud/server-frontend
/apps/files_sharing/src/actions* @skjnldsv @nextcloud/server-frontend
/apps/files_trashbin/src* @skjnldsv @nextcloud/server-frontend
# Security team
/build/psalm-baseline-security.xml @nickvergessen @nextcloud/server-backend
/resources/codesigning @mgallien @miaulalala @nickvergessen
/resources/config/ca-bundle.crt @miaulalala @nickvergessen
*/Activity/* @nickvergessen
*/Notifications/* @nickvergessen
/apps/dav/lib/CalDAV @ChristophWurst @miaulalala @tcitworld
/apps/dav/lib/CardDAV @ChristophWurst @miaulalala @tcitworld
# Two-Factor Authentication
# https://github.com/nextcloud/wg-two-factor-authentication#members
**/TwoFactorAuth @ChristophWurst @miaulalala @nickvergessen @st3iny
/apps/twofactor_backupcodes @ChristophWurst @miaulalala @nickvergessen @st3iny
/core/templates/twofactor* @ChristophWurst @miaulalala @nickvergessen @st3iny
# Limit login to IP
# Watch login routes for https://github.com/nextcloud/limit_login_to_ip
/core/routes.php @Altahrim @nextcloud/server-backend
# OpenAPI
openapi*.json @provokateurin @nextcloud/server-backend
ResponseDefinitions.php @provokateurin @nextcloud/server-backend
# Talk team
/lib/private/Comments @nickvergessen @nextcloud/talk-backend
/lib/private/Federation @nickvergessen @nextcloud/talk-backend @nextcloud/server-backend
/lib/private/Talk @nickvergessen @nextcloud/talk-backend
/lib/public/Comments @nickvergessen @nextcloud/talk-backend
/lib/public/Federation @nickvergessen @nextcloud/talk-backend @nextcloud/server-backend
/lib/public/OCM @nickvergessen @nextcloud/talk-backend @nextcloud/server-backend
/lib/public/Talk @nickvergessen @nextcloud/talk-backend
/lib/public/UserStatus @nickvergessen @nextcloud/talk-backend
*/Notifications/* @nickvergessen @nextcloud/talk-backend
# Groupware team
/build/integration/dav_features/caldav.feature @st3iny @SebastianKrupinski @tcitworld
/build/integration/dav_features/carddav.feature @hamza221 @SebastianKrupinski
/lib/private/Calendar @st3iny @SebastianKrupinski @tcitworld
/lib/private/Contacts @hamza221 @SebastianKrupinski
/lib/public/Calendar @st3iny @SebastianKrupinski @tcitworld
/lib/public/Contacts @hamza221 @SebastianKrupinski
# Desktop client teamn
/apps/dav/lib/Connector/Sabre/BlockLegacyClientPlugin.php @nextcloud/desktop
# Personal interest
*/Activity/* @nickvergessen @nextcloud/server-backend
/apps/workflowengine/lib @nickvergessen @blizzz
/apps/twofactor_backupcodes @ChristophWurst @miaulalala @nickvergessen
*/TwoFactorAuth/* @ChristophWurst @miaulalala @nickvergessen
/core/templates/twofactor* @ChristophWurst @miaulalala @nickvergessen
+6 -17
View File
@@ -1,10 +1,6 @@
<!--
- SPDX-FileCopyrightText: 2016 Nextcloud GmbH and Nextcloud contributors
- SPDX-License-Identifier: AGPL-3.0-or-later
-->
## Submitting issues
If you have questions about how to install or use Nextcloud, please direct these to our [forum][forum]. We are also available on [IRC][irc] (unofficial).
If you have questions about how to install or use Nextcloud, please direct these to our [forum][forum]. We are also available on [IRC][irc].
### Short version
@@ -25,7 +21,7 @@ Help us to maximize the effort we can spend fixing issues and adding new feature
[templates]: ./ISSUE_TEMPLATE
[forum]: https://help.nextcloud.com/
[irc]: https://web.libera.chat/#nextcloud
[irc]: https://webchat.freenode.net/?channels=nextcloud
## Contributing to Source Code
@@ -33,13 +29,6 @@ Thanks for wanting to contribute source code to Nextcloud. That's great!
Please read the [Developer Manuals][devmanual] to learn how to create your first application or how to test the Nextcloud code with PHPUnit.
### Conventional Commits
Please use [Conventional Commits](https://www.conventionalcommits.org) for your commit messages. This helps maintain clarity and consistency across the project, making it easier to understand changes and automate versioning.
```
feat(files_sharing): allow sharing with contacts
```
### Tests
In order to constantly increase the quality of our software we can no longer accept pull request which submit un-tested code.
@@ -48,16 +37,16 @@ In some areas unit testing is hard (aka almost impossible) as of today - in thes
### Sign your work
We use the Developer Certificate of Origin (DCO) as an additional safeguard
We use the Developer Certificate of Origin (DCO) as a additional safeguard
for the Nextcloud project. This is a well established and widely used
mechanism to assure contributors have confirmed their right to license
their contribution under the project's license.
Please read [contribute/developer-certificate-of-origin][dcofile].
If you can certify it, then just add a line to every git commit message:
```
Signed-off-by: Random J Developer <random@developer.example.org>
```
````
Signed-off-by: Random J Developer <random@developer.example.org>
````
Use your real name (sorry, no pseudonyms or anonymous contributions).
If you set your `user.name` and `user.email` git configs, you can sign your
-2
View File
@@ -1,3 +1 @@
# SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
custom: https://nextcloud.com/include/
+27 -34
View File
@@ -1,10 +1,7 @@
# SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
name: "🐛 Bug report: Nextcloud Server"
name: "Bug report: Nextcloud Server"
description: "Submit a report and help us improve Nextcloud Server"
title: "[Bug]: "
labels: ["bug", "0. Needs triage"]
type: "Bug"
body:
- type: markdown
attributes:
@@ -12,14 +9,6 @@ body:
### 👍 Thank you for contributing to our project!
Please note this is a **free and open-source** project. Most people take on their own time to help you, so please, be patient.
You can obtain [Enterprise support](https://nextcloud.com/support/) if you run Nextcloud Server in a mission critical environment.
- type: markdown
attributes:
value: |
### 🚨 SECURITY INFO
If you are reporting a security concern, please report it via [our HackerOne page](https://hackerone.com/nextcloud) instead and review our [security policy](https://nextcloud.com/security/).
This allows us to coordinate the fix and release without potentially exposing all Nextcloud servers and users in the meantime.
It also may qualify your report for a bug bounty reward.
Thank you for helping make Nextcloud more secure!
- type: checkboxes
id: before-posting
attributes:
@@ -28,7 +17,7 @@ body:
options:
- label: This is a **bug**, not a question or a configuration/webserver/proxy issue.
required: true
- label: This issue is **not** already reported on [Github](https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3Abug) OR [Nextcloud Community Forum](https://help.nextcloud.com/) _(I've searched it)_.
- label: This issue is **not** already reported on Github _(I've searched it)_.
required: true
- label: Nextcloud Server **is** up to date. See [Maintenance and Release Schedule](https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule) for supported versions.
required: true
@@ -49,7 +38,7 @@ body:
label: Steps to reproduce
description: |
Describe the steps to reproduce the bug.
The better your description is _(go 'here', click 'there'...)_ the fastest you'll get an _(accurate)_ answer.
The better your description is _(go 'here', click 'there'...)_ the fastest you'll get an _(accurate)_ answer.
value: |
1.
2.
@@ -64,19 +53,20 @@ body:
validations:
required: true
- type: dropdown
id: nextcloud-version
id: install-method
attributes:
label: Nextcloud Server version
label: Installation method
description: |
Select Nextcloud Server version.
_Versions not listed here are not maintained and not supported anymore_
Select installation method you've used.
_Describe the method in the "Additional info" section if you chose "Other"._
options:
- "30"
- "31"
- "32"
- "master"
validations:
required: true
- "Manual installation"
- "Official Docker image"
- "Official VM scripts"
- "Official SNAP package"
- "Official All-in-One appliance"
- "Web installer on a VPS or web space"
- "Other"
- type: dropdown
id: system
attributes:
@@ -96,9 +86,9 @@ body:
Select PHP engine version serving Nextcloud Server.
_Describe in the "Additional info" section if you chose "Other"._
options:
- "PHP 8.4"
- "PHP 8.3"
- "PHP 8.2"
- "PHP 7.3"
- "PHP 7.4"
- "PHP 8.0"
- "PHP 8.1"
- "Other"
- type: dropdown
@@ -111,6 +101,7 @@ body:
options:
- "Apache (supported)"
- "Nginx"
- "Lighttpd"
- "Other"
- type: dropdown
id: database
@@ -133,8 +124,8 @@ body:
description: |
Select if bug is present after an update or on a fresh install.
options:
- "Updated from a MINOR version (ex. 32.0.1 to 32.0.2)"
- "Upgraded to a MAJOR version (ex. 31 to 32)"
- "Updated from a minor version (ex. 22.2.3 to 22.2.4)"
- "Updated to a major version (ex. 22.2.3 to 23.0.1)"
- "Fresh Nextcloud Server install"
- type: dropdown
id: encryption
@@ -169,7 +160,7 @@ body:
./occ config:list system
```
> NOTE: This will be automatically formatted into code for better readability.
render: json
render: shell
- type: textarea
id: apps
attributes:
@@ -184,6 +175,8 @@ body:
```
> NOTE: This will be automatically formatted into code for better readability.
render: shell
validations:
required: true
- type: textarea
id: nextcloud-signingstatus
attributes:
@@ -192,7 +185,7 @@ body:
Provide Nextcloud Signing status.
First, login as Admin user into your Nextcloud, then access this URL:
```shell
https://yournextcloud.tld/index.php/settings/integrity/failed
https://yournextcloud.tld/index.php/settings/integrity/failed
```
> NOTE: This will be automatically formatted into code for better readability.
render: shell
@@ -201,10 +194,10 @@ body:
attributes:
label: Nextcloud Logs
description: |
Provide relevant Nextcloud log entries (e.g. from the time period you reproduced the problem).
Copy full individual entries from `data/nextcloud.log` or use `Copy raw entry` from `/settings/admin/logging` section:
Provide Nextcloud logs lines.
Copy all contents from `data/nextcloud.log` or a RAW from `/settings/admin/logging` section:
> NOTE: This will be automatically formatted into code for better readability.
render: json
render: shell
- type: textarea
id: additional-info
attributes:
@@ -2,8 +2,6 @@
name: 🚀 Feature request
about: Suggest an idea for this project
labels: enhancement, 0. Needs triage
type: "Enhancement"
---
<!--
@@ -1,2 +0,0 @@
SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
SPDX-License-Identifier: AGPL-3.0-or-later
+1 -5
View File
@@ -1,9 +1,5 @@
# SPDX-FileCopyrightText: 2020 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
blank_issues_enabled: false
contact_links:
- name: 🚨 Report a security or privacy issue
url: https://hackerone.com/nextcloud
about: Report security and privacy related issues privately to the Nextcloud team, so we can coordinate the fix and release without potentially exposing all Nextcloud servers and users in the meantime.
- name: ❓ Community Support and Help
url: https://help.nextcloud.com/
about: Configuration, webserver/proxy or performance issues and other questions
-7
View File
@@ -1,7 +0,0 @@
# SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
name: "CodeQL config"
paths-ignore:
- dist
-2
View File
@@ -1,5 +1,3 @@
# SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
firstPRMergeComment: >
Thanks for your first pull request and welcome to the community!
Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
+100 -118
View File
@@ -1,32 +1,37 @@
# SPDX-FileCopyrightText: 2020 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
version: 2
updates:
# GitHub Actions
- package-ecosystem: "github-actions"
# Linting and coding style
- package-ecosystem: composer
directory: "/"
schedule:
interval: monthly
interval: weekly
day: saturday
time: "03:00"
timezone: Europe/Paris
groups:
github-actions:
patterns:
- "*"
labels:
- "3. to review"
- "feature: dependencies"
reviewers:
- "nextcloud/server-dependabot"
# Main composer (linting, testing, openapi)
- package-ecosystem: composer
directories:
- "/"
- "/build/integration"
- "/vendor-bin/cs-fixer"
- "/vendor-bin/openapi-extractor"
- "/vendor-bin/phpunit"
- "/vendor-bin/psalm"
- "/vendor-bin/rector"
# Main master npm
- package-ecosystem: npm
directory: "/"
schedule:
interval: weekly
day: saturday
time: "03:00"
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- "3. to review"
- "feature: dependencies"
reviewers:
- "nextcloud/server-dependabot"
# Testing master npm
- package-ecosystem: npm
directory: "/build"
schedule:
interval: weekly
day: saturday
@@ -36,7 +41,20 @@ updates:
- "3. to review"
- "feature: dependencies"
# Main master npm frontend dependencies
# Testing master composer
- package-ecosystem: composer
directory: "/build/integration"
schedule:
interval: weekly
day: saturday
time: "03:00"
timezone: Europe/Paris
labels:
- "3. to review"
- "feature: dependencies"
# Main stableXX npm
- package-ecosystem: npm
directory: "/"
schedule:
@@ -44,140 +62,104 @@ updates:
day: saturday
time: "03:00"
timezone: Europe/Paris
open-pull-requests-limit: 20
labels:
- "3. to review"
- "feature: dependencies"
# Disable automatic rebasing because without a build CI will likely fail anyway
rebase-strategy: "disabled"
# Latest stable release
# Composer dependencies for linting and testing
- package-ecosystem: composer
target-branch: stable32
directories:
- "/"
- "/build/integration"
- "/vendor-bin/cs-fixer"
- "/vendor-bin/openapi-extractor"
- "/vendor-bin/phpunit"
- "/vendor-bin/psalm"
schedule:
interval: weekly
day: saturday
time: "03:30"
timezone: Europe/Paris
target-branch: stable21
labels:
- "3. to review"
- "feature: dependencies"
reviewers:
- "nextcloud/server-dependabot"
ignore:
# only patch updates on stable branches
# ignore all GitHub linguist patch updates
- dependency-name: "*"
update-types: ["version-update:semver-major", "version-update:semver-minor"]
update-types: ["version-update:semver-major", "version-update:semver-minor", "version-update:semver-patch"]
# Latest stable branch
# frontend dependencies
- package-ecosystem: npm
target-branch: stable32
directory: "/"
schedule:
interval: weekly
day: saturday
time: "03:30"
time: "03:00"
timezone: Europe/Paris
open-pull-requests-limit: 20
target-branch: stable22
labels:
- "3. to review"
- "feature: dependencies"
# Disable automatic rebasing because without a build CI will likely fail anyway
rebase-strategy: "disabled"
reviewers:
- "nextcloud/server-dependabot"
ignore:
# no major updates on stable branches
- dependency-name: "*"
update-types: ["version-update:semver-major"]
# Older stable releases
# Composer dependencies for linting and testing
- package-ecosystem: composer
target-branch: stable31
directories:
- "/"
- "/build/integration"
- "/vendor-bin/cs-fixer"
- "/vendor-bin/openapi-extractor"
- "/vendor-bin/phpunit"
- "/vendor-bin/psalm"
schedule:
interval: weekly
day: saturday
time: "04:00"
timezone: Europe/Paris
labels:
- "3. to review"
- "feature: dependencies"
ignore:
# only patch updates on stable branches
# ignore all GitHub linguist patch updates
- dependency-name: "*"
update-types: ["version-update:semver-major", "version-update:semver-minor"]
- package-ecosystem: composer
target-branch: stable30
directories:
- "/"
- "/build/integration"
- "/vendor-bin/cs-fixer"
- "/vendor-bin/openapi-extractor"
- "/vendor-bin/phpunit"
- "/vendor-bin/psalm"
schedule:
interval: weekly
day: saturday
time: "04:00"
timezone: Europe/Paris
labels:
- "3. to review"
- "feature: dependencies"
ignore:
# only patch updates on stable branches
- dependency-name: "*"
update-types: ["version-update:semver-major", "version-update:semver-minor"]
# frontend dependencies
- package-ecosystem: npm
target-branch: stable31
directory: "/"
schedule:
interval: weekly
day: saturday
time: "04:00"
time: "03:00"
timezone: Europe/Paris
open-pull-requests-limit: 20
target-branch: stable23
labels:
- "3. to review"
- "feature: dependencies"
# Disable automatic rebasing because without a build CI will likely fail anyway
rebase-strategy: "disabled"
reviewers:
- "nextcloud/server-dependabot"
ignore:
# no major updates on stable branches
# ignore all GitHub linguist patch updates
- dependency-name: "*"
update-types: ["version-update:semver-major"]
update-types: ["version-update:semver-major", "version-update:semver-minor"]
- package-ecosystem: npm
target-branch: stable30
directory: "/"
# Testing StableXX composer
- package-ecosystem: composer
directory: "/build/integration"
schedule:
interval: weekly
day: saturday
time: "04:00"
time: "03:00"
timezone: Europe/Paris
open-pull-requests-limit: 20
target-branch: stable21
labels:
- "3. to review"
- "feature: dependencies"
# Disable automatic rebasing because without a build CI will likely fail anyway
rebase-strategy: "disabled"
reviewers:
- "nextcloud/server-dependabot"
ignore:
# no major updates on stable branches
# ignore all GitHub linguist patch updates
- dependency-name: "*"
update-types: ["version-update:semver-major"]
update-types: ["version-update:semver-major", "version-update:semver-minor", "version-update:semver-patch"]
- package-ecosystem: composer
directory: "/build/integration"
schedule:
interval: weekly
day: saturday
time: "03:00"
timezone: Europe/Paris
target-branch: stable22
labels:
- "3. to review"
- "feature: dependencies"
reviewers:
- "nextcloud/server-dependabot"
ignore:
# ignore all GitHub linguist patch updates
- dependency-name: "*"
update-types: ["version-update:semver-major", "version-update:semver-minor"]
- package-ecosystem: composer
directory: "/build/integration"
schedule:
interval: weekly
day: saturday
time: "03:00"
timezone: Europe/Paris
target-branch: stable23
labels:
- "3. to review"
- "feature: dependencies"
reviewers:
- "nextcloud/server-dependabot"
ignore:
# ignore all GitHub linguist patch updates
- dependency-name: "*"
update-types: ["version-update:semver-major", "version-update:semver-minor"]
-25
View File
@@ -1,25 +0,0 @@
<!--
- 🚨 SECURITY INFO
-
- Before sending a pull request that fixes a security issue please report it via our HackerOne page (https://hackerone.com/nextcloud) following our security policy (https://nextcloud.com/security/). This allows us to coordinate the fix and release without potentially exposing all Nextcloud servers and users in the meantime.
-->
* Resolves: # <!-- related github issue -->
## Summary
## TODO
- [ ] ...
## Checklist
- Code is [properly formatted](https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/continuous_integration.html#linting)
- [Sign-off message](https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md) is added to all commits
- [ ] Tests ([unit](https://docs.nextcloud.com/server/latest/developer_manual/app_development/tutorial.html#unit-tests), [integration](https://docs.nextcloud.com/server/latest/developer_manual/app_development/tutorial.html#integration-tests), api and/or acceptance) are included
- [ ] Screenshots before/after for front-end changes
- [ ] Documentation ([manuals](https://github.com/nextcloud/documentation/) or wiki) has been updated or is not required
- [ ] [Backports requested](https://github.com/nextcloud/backportbot/#usage) where applicable (ex: critical bugfixes)
- [ ] [Labels added](https://github.com/nextcloud/server/labels) where applicable (ex: bug/enhancement, `3. to review`, feature component)
- [ ] [Milestone added](https://github.com/nextcloud/server/milestones) for target branch/version (ex: 32.x for `stable32`)
-2
View File
@@ -1,2 +0,0 @@
SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors
SPDX-License-Identifier: AGPL-3.0-or-later
-126
View File
@@ -1,126 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Code checkers
on:
pull_request:
permissions:
contents: read
concurrency:
group: autocheckers-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src }}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- '**.php'
- build/autoloaderchecker.sh
autoloader:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
matrix:
php-versions: ['8.2']
name: PHP checkers
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: none
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Check auto loaders
run: bash ./build/autoloaderchecker.sh
autocheckers:
runs-on: ubuntu-latest-low
strategy:
matrix:
php-versions: ['8.2']
name: Translation and Files checkers
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: none
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Check translations are JSON decodeable
run: php ./build/translation-checker.php
- name: Check translations do not contain triple dot but ellipsis
run: php ./build/triple-dot-checker.php
- name: Check .htaccess does not contain invalid changes
run: php ./build/htaccess-checker.php
- name: Check that all and only expected files are included
run: php ./build/files-checker.php
- name: Check that all shipped apps are linted by psalm
run: sh ./build/psalm-checker.sh
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, autoloader, autocheckers]
if: always()
name: autocheckers-summary
steps:
- name: Summary status
run: if ${{ needs.autocheckers.result != 'success' || (needs.changes.outputs.src != 'false' && needs.autoloader.result != 'success') }}; then exit 1; fi
+12 -31
View File
@@ -2,48 +2,29 @@
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2022-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Block merges for EOL
name: Pull request checks
on: pull_request
permissions:
contents: read
concurrency:
group: block-merge-eol-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
block-merges-eol:
name: Block merges for EOL branches
# Only run on stableXX branches
if: startsWith( github.base_ref, 'stable')
runs-on: ubuntu-latest-low
runs-on: ubuntu-latest
steps:
- name: Set server major version environment
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
const regex = /^stable(\d+)$/
const baseRef = context.payload.pull_request.base.ref
const match = baseRef.match(regex)
if (match) {
console.log('Setting server_major to ' + match[1]);
core.exportVariable('server_major', match[1]);
console.log('Setting current_month to ' + (new Date()).toISOString().substr(0, 7));
core.exportVariable('current_month', (new Date()).toISOString().substr(0, 7));
}
- name: Download updater config
run: curl https://raw.githubusercontent.com/nextcloud/updater_server/production/config/config.php --output config.php
- name: Checking if server ${{ env.server_major }} is EOL
if: ${{ env.server_major != '' }}
- name: Set server major version environment
run: |
curl -s https://raw.githubusercontent.com/nextcloud-releases/updater_server/production/config/major_versions.json \
| jq '.["${{ env.server_major }}"]["eol"] // "9999-99" | . >= "${{ env.current_month }}"' \
| grep -q true
# retrieve version number from branch reference
server_major=$(echo "${{ github.base_ref }}" | sed -En 's/stable//p')
echo "server_major=$server_major" >> $GITHUB_ENV
- name: Checking if ${{ env.server_major }} is EOL
run: |
php -r 'echo json_encode(require_once "config.php");' | jq --arg version "${{ env.server_major }}" '.stable[$version]["100"].eol' | grep --silent -i 'false'
+6 -42
View File
@@ -2,56 +2,20 @@
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2022-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Block merges during freezes
name: Pull request checks
on:
pull_request:
types: [opened, ready_for_review, reopened, synchronize]
permissions:
contents: read
concurrency:
group: block-merge-freeze-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
on: pull_request
jobs:
block-merges-during-freeze:
name: Block merges during freezes
name: Block merges during feature freezes
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest-low
runs-on: ubuntu-latest
steps:
- name: Register server reference to fallback to master branch
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
const baseRef = context.payload.pull_request.base.ref
if (baseRef === 'main' || baseRef === 'master') {
core.exportVariable('server_ref', 'master');
console.log('Setting server_ref to master');
} else {
const regex = /^stable(\d+)$/
const match = baseRef.match(regex)
if (match) {
core.exportVariable('server_ref', match[0]);
console.log('Setting server_ref to ' + match[0]);
} else {
console.log('Not based on master/main/stable*, so skipping freeze check');
}
}
- name: Download version.php from ${{ env.server_ref }}
if: ${{ env.server_ref != '' }}
run: curl 'https://raw.githubusercontent.com/nextcloud/server/${{ env.server_ref }}/version.php' --output version.php
- name: Download version.php from ${{ github.base_ref }}
run: curl https://raw.githubusercontent.com/nextcloud/server/${{ github.base_ref }}/version.php --output version.php
- name: Run check
if: ${{ env.server_ref != '' }}
run: cat version.php | grep 'OC_VersionString' | grep -i -v 'RC'
+6 -32
View File
@@ -1,5 +1,3 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Block merging with outdated 3rdparty/
on:
@@ -21,7 +19,7 @@ jobs:
steps:
- name: Check requirement
uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
uses: dorny/paths-filter@4512585405083f25c027a35db413c2b3b9006d50 # v2.11.1
id: changes
continue-on-error: true
with:
@@ -31,49 +29,25 @@ jobs:
- 'version.php'
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
- name: 3rdparty commit hash on current branch
id: actual
run: |
echo "commit=$(git submodule status | grep ' 3rdparty' | egrep -o '[a-f0-9]{40}')" >> "$GITHUB_OUTPUT"
- name: Register server reference to fallback to master branch
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
const baseRef = context.payload.pull_request.base.ref
if (baseRef === 'main' || baseRef === 'master') {
core.exportVariable('server_ref', 'master');
console.log('Setting server_ref to master');
} else {
const regex = /^stable(\d+)$/
const match = baseRef.match(regex)
if (match) {
core.exportVariable('server_ref', match[0]);
console.log('Setting server_ref to ' + match[0]);
} else {
console.log('Not based on master/main/stable*, so skipping outdated 3rdparty check');
}
}
- name: Last 3rdparty commit on target branch
if: ${{ env.server_ref != '' }}
id: target
run: |
echo "commit=$(git ls-remote https://github.com/nextcloud/3rdparty refs/heads/${{ env.server_ref }} | awk '{ print $1}')" >> "$GITHUB_OUTPUT"
echo "commit=$(git ls-remote https://github.com/nextcloud/3rdparty refs/heads/${{ github.base_ref }} | awk '{ print $1}')" >> "$GITHUB_OUTPUT"
- name: Compare if 3rdparty commits are different
if: ${{ env.server_ref != '' }}
run: |
echo '3rdparty/ seems to not point to the last commit of the dedicated branch:'
echo 'Branch has: ${{ steps.actual.outputs.commit }}'
echo '${{ env.server_ref }} has: ${{ steps.target.outputs.commit }}'
echo "Branch has: ${{ steps.actual.outputs.commit }}"
echo "${{ github.base_ref }} has: ${{ steps.target.outputs.commit }}"
- name: Fail if 3rdparty commits are different
if: ${{ env.server_ref != '' && steps.changes.outputs.src != 'false' && steps.actual.outputs.commit != steps.target.outputs.commit }}
if: ${{ steps.changes.outputs.src != 'false' && steps.actual.outputs.commit != steps.target.outputs.commit }}
run: |
exit 1
@@ -1,36 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Block unconventional commits
on:
pull_request:
types: [opened, ready_for_review, reopened, synchronize]
permissions:
contents: read
concurrency:
group: block-unconventional-commits-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
block-unconventional-commits:
name: Block unconventional commits
runs-on: ubuntu-latest-low
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
- uses: webiny/action-conventional-commits@8bc41ff4e7d423d56fa4905f6ff79209a78776c7 # v1.3.0
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-47
View File
@@ -1,47 +0,0 @@
# SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
name: "CodeQL Advanced"
on:
push:
branches: [ "master", "stable*" ]
pull_request:
branches: [ "master", "stable*" ]
schedule:
- cron: '28 18 * * 1'
jobs:
analyze:
name: Analyze (${{ matrix.language }})
runs-on: ubuntu-latest
permissions:
# required for all workflows
security-events: write
# required to fetch internal or private CodeQL packs
packages: read
strategy:
fail-fast: false
matrix:
include:
- language: actions
build-mode: none
- language: javascript-typescript
build-mode: none
steps:
- name: Checkout repository
uses: actions/checkout@v5
- name: Initialize CodeQL
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
build-mode: ${{ matrix.build-mode }}
config-file: ./.github/codeql-config.yml
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
with:
category: "/language:${{matrix.language}}"
+32 -137
View File
@@ -1,19 +1,8 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Compile Command
on:
issue_comment:
types: [created]
permissions:
contents: read
jobs:
init:
runs-on: ubuntu-latest
@@ -26,197 +15,103 @@ jobs:
arg1: ${{ steps.command.outputs.arg1 }}
arg2: ${{ steps.command.outputs.arg2 }}
head_ref: ${{ steps.comment-branch.outputs.head_ref }}
base_ref: ${{ steps.comment-branch.outputs.base_ref }}
steps:
- name: Get repository from pull request comment
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
id: get-repository
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
const pull = await github.rest.pulls.get({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.issue.number
});
const repositoryName = pull.data.head?.repo?.full_name
console.log(repositoryName)
return repositoryName
- name: Disabled on forks
if: ${{ fromJSON(steps.get-repository.outputs.result) != github.repository }}
run: |
echo 'Can not execute /compile on forks'
exit 1
- name: Check actor permission
uses: skjnldsv/check-actor-permission@69e92a3c4711150929bca9fcf34448c5bf5526e7 # v2
uses: skjnldsv/check-actor-permission@e591dbfe838300c007028e1219ca82cc26e8d7c5 # v2.1
with:
require: write
- name: Add reaction on start
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v4.0.0
uses: peter-evans/create-or-update-comment@a35cf36e5301d70b76f316e867e7788a55a31dae # v1.4.5
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
repository: ${{ github.event.repository.full_name }}
comment-id: ${{ github.event.comment.id }}
reactions: '+1'
reaction-type: "+1"
- name: Parse command
uses: skjnldsv/parse-command-comment@5c955203c52424151e6d0e58fb9de8a9f6a605a1 # v2
uses: skjnldsv/parse-command-comment@7cef1df370a99dfd5bf896d50121390c96785db8 # v2.0
id: command
# Init path depending on which command is run
- name: Init path
id: git-path
run: |
run: |
if ${{ startsWith(steps.command.outputs.arg1, '/') }}; then
echo "path=${{steps.command.outputs.arg1}}" >> $GITHUB_OUTPUT
echo "::set-output name=path::${{ github.workspace }}${{steps.command.outputs.arg1}}"
else
echo "path=${{steps.command.outputs.arg2}}" >> $GITHUB_OUTPUT
echo "::set-output name=path::${{ github.workspace }}${{steps.command.outputs.arg2}}"
fi
- name: Init branch
uses: xt0rted/pull-request-comment-branch@e8b8daa837e8ea7331c0003c9c316a64c6d8b0b1 # v3.0.0
uses: xt0rted/pull-request-comment-branch@653a7d5ca8bd91d3c5cb83286063314d0b063b8e # v1.4.0
id: comment-branch
- name: Add reaction on failure
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v4.0.0
if: failure()
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
repository: ${{ github.event.repository.full_name }}
comment-id: ${{ github.event.comment.id }}
reactions: '-1'
process:
runs-on: ubuntu-latest
needs: init
steps:
- name: Restore cached git repository
uses: buildjet/cache@3e70d19e31d6a8030aeddf6ed8dbe601f94d09f4 # v4.0.2
with:
path: .git
key: git-repo
- name: Checkout ${{ needs.init.outputs.head_ref }}
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
with:
# Needed to allow force push later
persist-credentials: true
token: ${{ secrets.COMMAND_BOT_PAT }}
fetch-depth: 0
ref: ${{ needs.init.outputs.head_ref }}
- name: Setup git
run: |
git config --local user.email 'nextcloud-command@users.noreply.github.com'
git config --local user.name 'nextcloud-command'
git config --local user.email "nextcloud-command@users.noreply.github.com"
git config --local user.name "nextcloud-command"
- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
uses: skjnldsv/read-package-engines-version-actions@1bdcee71fa343c46b18dc6aceffb4cd1e35209c6 # v1.2
id: package-engines-versions
with:
fallbackNode: '^20'
fallbackNpm: '^10'
fallbackNode: '^12'
fallbackNpm: '^6'
- name: Set up node ${{ steps.package-engines-versions.outputs.nodeVersion }}
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
uses: actions/setup-node@7c12f8017d5436eb855f1ed4399f037a36fbd9e8 # v2.5.2
with:
node-version: ${{ steps.package-engines-versions.outputs.nodeVersion }}
cache: npm
- name: Set up npm ${{ steps.package-engines-versions.outputs.npmVersion }}
run: npm i -g 'npm@${{ steps.package-engines-versions.outputs.npmVersion }}'
- name: Rebase to ${{ needs.init.outputs.base_ref }}
if: ${{ contains(needs.init.outputs.arg1, 'rebase') }}
run: |
git fetch origin '${{ needs.init.outputs.base_ref }}:${{ needs.init.outputs.base_ref }}'
# Start the rebase
git rebase 'origin/${{ needs.init.outputs.base_ref }}' || {
# Handle rebase conflicts in a loop
while [ -d .git/rebase-merge ] || [ -d .git/rebase-apply ]; do
echo "Handling rebase conflict..."
# Remove and checkout /dist and /js folders from the base branch
if [ -d "dist" ]; then
rm -rf dist
git checkout origin/${{ needs.init.outputs.base_ref }} -- dist/ 2>/dev/null || echo "No dist folder in base branch"
fi
if [ -d "js" ]; then
rm -rf js
git checkout origin/${{ needs.init.outputs.base_ref }} -- js/ 2>/dev/null || echo "No js folder in base branch"
fi
# Stage all changes
git add .
# Check if there are any changes after resolving conflicts
if git diff --cached --quiet; then
echo "No changes after conflict resolution, skipping commit"
git rebase --skip
else
echo "Changes found, continuing rebase without editing commit message"
git -c core.editor=true rebase --continue
fi
# Break if rebase is complete
if [ ! -d .git/rebase-merge ] && [ ! -d .git/rebase-apply ]; then
break
fi
done
}
run: npm i -g npm@"${{ steps.package-engines-versions.outputs.npmVersion }}"
- name: Install dependencies & build
env:
CYPRESS_INSTALL_BINARY: 0
PUPPETEER_SKIP_DOWNLOAD: true
run: |
npm ci
npm run build --if-present
- name: Commit default
if: ${{ !contains(needs.init.outputs.arg1, 'fixup') && !contains(needs.init.outputs.arg1, 'amend') }}
- name: Commit and push default
if: ${{ needs.init.outputs.arg1 != 'fixup' && needs.init.outputs.arg1 != 'amend' }}
run: |
git add '${{ github.workspace }}${{ needs.init.outputs.git_path }}'
git commit --signoff -m 'chore(assets): Recompile assets'
git add ${{ needs.init.outputs.git_path }}
git commit --signoff -m 'Compile assets'
git push origin ${{ needs.init.outputs.head_ref }}
- name: Commit fixup
if: ${{ contains(needs.init.outputs.arg1, 'fixup') }}
- name: Commit and push fixup
if: ${{ needs.init.outputs.arg1 == 'fixup' }}
run: |
git add '${{ github.workspace }}${{ needs.init.outputs.git_path }}'
git add ${{ needs.init.outputs.git_path }}
git commit --fixup=HEAD --signoff
git push origin ${{ needs.init.outputs.head_ref }}
- name: Commit amend
if: ${{ contains(needs.init.outputs.arg1, 'amend') }}
- name: Commit and push amend
if: ${{ needs.init.outputs.arg1 == 'amend' }}
run: |
git add '${{ github.workspace }}${{ needs.init.outputs.git_path }}'
git add ${{ needs.init.outputs.git_path }}
git commit --amend --no-edit --signoff
# Remove any [skip ci] from the amended commit
git commit --amend -m "$(git log -1 --format='%B' | sed '/\[skip ci\]/d')"
- name: Push normally
if: ${{ !contains(needs.init.outputs.arg1, 'rebase') && !contains(needs.init.outputs.arg1, 'amend') }}
env:
HEAD_REF: ${{ needs.init.outputs.head_ref }}
run: git push origin "$HEAD_REF"
- name: Force push
if: ${{ contains(needs.init.outputs.arg1, 'rebase') || contains(needs.init.outputs.arg1, 'amend') }}
env:
HEAD_REF: ${{ needs.init.outputs.head_ref }}
run: git push --force-with-lease origin "$HEAD_REF"
git push --force origin ${{ needs.init.outputs.head_ref }}
- name: Add reaction on failure
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v4.0.0
uses: peter-evans/create-or-update-comment@a35cf36e5301d70b76f316e867e7788a55a31dae # v1.4.5
if: failure()
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
repository: ${{ github.event.repository.full_name }}
comment-id: ${{ github.event.comment.id }}
reactions: '-1'
reaction-type: "-1"
-100
View File
@@ -1,100 +0,0 @@
# SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Update 3rdparty command
on:
issue_comment:
types: created
permissions:
contents: read
jobs:
rebase:
runs-on: ubuntu-latest
permissions:
contents: none
# On pull requests and if the comment starts with `/update-3rdparty`
if: github.event.issue.pull_request != '' && startsWith(github.event.comment.body, '/update-3rdparty')
steps:
- name: Add reaction on start
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v3.0.1
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
repository: ${{ github.event.repository.full_name }}
comment-id: ${{ github.event.comment.id }}
reactions: '+1'
- name: Disabled on forks
if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
run: |
echo 'Can not execute /update-3rdparty on forks'
exit 1
- name: Init branch
uses: xt0rted/pull-request-comment-branch@e8b8daa837e8ea7331c0003c9c316a64c6d8b0b1 # v1
id: comment-branch
- name: Checkout ${{ steps.comment-branch.outputs.head_ref }}
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
fetch-depth: 0
token: ${{ secrets.COMMAND_BOT_PAT }}
ref: ${{ steps.comment-branch.outputs.head_ref }}
- name: Register server reference to fallback to master branch
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
const baseRef = context.payload.pull_request.base.ref
if (baseRef === 'main' || baseRef === 'master') {
core.exportVariable('server_ref', 'master');
console.log('Setting server_ref to master');
} else {
const regex = /^stable(\d+)$/
const match = baseRef.match(regex)
if (match) {
core.exportVariable('server_ref', match[0]);
console.log('Setting server_ref to ' + match[0]);
} else {
console.log('Not based on master/main/stable*, so skipping pull 3rdparty command');
}
}
- name: Setup git
run: |
git config --local user.email 'nextcloud-command@users.noreply.github.com'
git config --local user.name 'nextcloud-command'
- name: Add reaction on failure
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v3.0.1
if: ${{ env.server_ref == '' }}
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
repository: ${{ github.event.repository.full_name }}
comment-id: ${{ github.event.comment.id }}
reactions: '-1'
- name: Pull 3rdparty
if: ${{ env.server_ref != '' }}
run: git submodule foreach 'if [ "$sm_path" == "3rdparty" ]; then git pull origin '"'"'${{ env.server_ref }}'"'"'; fi'
- name: Commit and push changes
if: ${{ env.server_ref != '' }}
run: |
git add 3rdparty
git commit -s -m 'Update submodule 3rdparty to latest ${{ env.server_ref }}'
git push
- name: Add reaction on failure
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v3.0.1
if: failure()
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
repository: ${{ github.event.repository.full_name }}
comment-id: ${{ github.event.comment.id }}
reactions: '-1'
+46
View File
@@ -0,0 +1,46 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
name: Rebase command
on:
issue_comment:
types: created
jobs:
rebase:
runs-on: ubuntu-latest
# On pull requests and if the comment starts with `/rebase`
if: github.event.issue.pull_request != '' && startsWith(github.event.comment.body, '/rebase')
steps:
- name: Add reaction on start
uses: peter-evans/create-or-update-comment@a35cf36e5301d70b76f316e867e7788a55a31dae # v1.4.5
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
repository: ${{ github.event.repository.full_name }}
comment-id: ${{ github.event.comment.id }}
reaction-type: "+1"
- name: Checkout the latest code
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
with:
fetch-depth: 0
token: ${{ secrets.COMMAND_BOT_PAT }}
- name: Automatic Rebase
uses: cirrus-actions/rebase@c473b716e3fcde0c6bf67416e2c2882830ad40f6 # 1.5
env:
GITHUB_TOKEN: ${{ secrets.COMMAND_BOT_PAT }}
- name: Add reaction on failure
uses: peter-evans/create-or-update-comment@a35cf36e5301d70b76f316e867e7788a55a31dae # v1.4.5
if: failure()
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
repository: ${{ github.event.repository.full_name }}
comment-id: ${{ github.event.comment.id }}
reaction-type: "-1"
-240
View File
@@ -1,240 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Cypress
on: pull_request
concurrency:
group: cypress-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
env:
# Adjust APP_NAME if your repository name is different
APP_NAME: ${{ github.event.repository.name }}
# This represents the server branch to checkout.
# Usually it's the base branch of the PR, but for pushes it's the branch itself.
# e.g. 'main', 'stable27' or 'feature/my-feature'
# n.b. server will use head_ref, as we want to test the PR branch.
BRANCH: ${{ github.head_ref || github.ref_name }}
permissions:
contents: read
jobs:
init:
runs-on: ubuntu-latest
outputs:
nodeVersion: ${{ steps.versions.outputs.nodeVersion }}
npmVersion: ${{ steps.versions.outputs.npmVersion }}
env:
# We'll install cypress in the cypress job
CYPRESS_INSTALL_BINARY: 0
PUPPETEER_SKIP_DOWNLOAD: true
steps:
- name: Disabled on forks
if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
run: |
echo 'Can not run cypress on forks'
exit 1
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
# We need to checkout submodules for 3rdparty
submodules: true
- name: Check composer.json
id: check_composer
uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v3.0.0
with:
files: "composer.json"
- name: Install composer dependencies
if: steps.check_composer.outputs.files_exists == 'true'
run: composer install --no-dev
- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
id: versions
with:
fallbackNode: "^20"
fallbackNpm: "^10"
- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
with:
node-version: ${{ steps.versions.outputs.nodeVersion }}
- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
- name: Install node dependencies & build app
run: |
npm ci
TESTING=true npm run build --if-present
- name: Show cypress version
run: npm run cypress:version
- name: Save context
uses: buildjet/cache/save@3e70d19e31d6a8030aeddf6ed8dbe601f94d09f4 # v4.0.2
with:
key: cypress-context-${{ github.run_id }}
path: ./
cypress:
runs-on: ubuntu-latest
needs: init
strategy:
fail-fast: false
matrix:
# Run multiple copies of the current job in parallel
# Please increase the number or runners as your tests suite grows (0 based index for e2e tests)
containers: ['component', 'setup', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9']
# Hack as strategy.job-total includes the component and GitHub does not allow math expressions
# Always align this number with the total of e2e runners (max. index + 1)
total-containers: [10]
services:
mysql:
# Only start mysql if we are running the setup tests
image: ${{matrix.containers == 'setup' && 'ghcr.io/nextcloud/continuous-integration-mysql-8.4:latest' || ''}}
ports:
- '3306/tcp'
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: oc_autotest
options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 10
mariadb:
# Only start mariadb if we are running the setup tests
image: ${{matrix.containers == 'setup' && 'mariadb:11.4' || ''}}
ports:
- '3306/tcp'
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: oc_autotest
options: --health-cmd="mariadb-admin ping" --health-interval 5s --health-timeout 2s --health-retries 5
postgres:
# Only start postgres if we are running the setup tests
image: ${{matrix.containers == 'setup' && 'ghcr.io/nextcloud/continuous-integration-postgres-17:latest' || ''}}
ports:
- '5432/tcp'
env:
POSTGRES_USER: root
POSTGRES_PASSWORD: rootpassword
POSTGRES_DB: nextcloud
options: --mount type=tmpfs,destination=/var/lib/postgresql/data --health-cmd pg_isready --health-interval 5s --health-timeout 2s --health-retries 5
oracle:
# Only start oracle if we are running the setup tests
image: ${{matrix.containers == 'setup' && 'ghcr.io/gvenzl/oracle-free:23' || ''}}
ports:
- '1521'
env:
ORACLE_PASSWORD: oracle
options: --health-cmd healthcheck.sh --health-interval 20s --health-timeout 10s --health-retries 10
name: runner ${{ matrix.containers }}
steps:
- name: Restore context
uses: buildjet/cache/restore@3e70d19e31d6a8030aeddf6ed8dbe601f94d09f4 # v4.0.2
with:
fail-on-cache-miss: true
key: cypress-context-${{ github.run_id }}
path: ./
- name: Set up node ${{ needs.init.outputs.nodeVersion }}
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
with:
node-version: ${{ needs.init.outputs.nodeVersion }}
- name: Set up npm ${{ needs.init.outputs.npmVersion }}
run: npm i -g 'npm@${{ needs.init.outputs.npmVersion }}'
- name: Install cypress
run: ./node_modules/cypress/bin/cypress install
- name: Run ${{ matrix.containers == 'component' && 'component' || 'E2E' }} cypress tests
uses: cypress-io/github-action@b8ba51a856ba5f4c15cf39007636d4ab04f23e3c # v6.10.2
with:
# We already installed the dependencies in the init job
install: false
component: ${{ matrix.containers == 'component' }}
group: ${{ matrix.use-cypress-cloud && matrix.containers == 'component' && 'Run component' || matrix.use-cypress-cloud && 'Run E2E' || '' }}
# cypress env
ci-build-id: ${{ matrix.use-cypress-cloud && format('{0}-{1}', github.sha, github.run_number) || '' }}
tag: ${{ matrix.use-cypress-cloud && github.event_name || '' }}
env:
# Needs to be prefixed with CYPRESS_
CYPRESS_BRANCH: ${{ env.BRANCH }}
# https://github.com/cypress-io/github-action/issues/124
COMMIT_INFO_MESSAGE: ${{ github.event.pull_request.title }}
# Needed for some specific code workarounds
TESTING: true
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
SPLIT: ${{ matrix.total-containers }}
SPLIT_INDEX: ${{ matrix.containers == 'component' && 0 || matrix.containers }}
SETUP_TESTING: ${{ matrix.containers == 'setup' && 'true' || '' }}
- name: Upload snapshots and videos
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
if: always()
with:
name: snapshots_videos_${{ matrix.containers }}
path: |
cypress/snapshots
cypress/videos
- name: Extract NC logs
if: failure() && matrix.containers != 'component'
run: docker logs nextcloud-cypress-tests_${{ env.APP_NAME }} > nextcloud.log
- name: Upload NC logs
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
if: failure() && matrix.containers != 'component'
with:
name: nc_logs_${{ matrix.containers }}
path: nextcloud.log
- name: Create data dir archive
if: failure() && matrix.containers != 'component'
run: docker exec nextcloud-cypress-tests_${{ env.APP_NAME }} tar -cvjf - data > data.tar
- name: Upload data dir archive
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
if: failure() && matrix.containers != 'component'
with:
name: nc_data_${{ matrix.containers }}
path: data.tar
summary:
runs-on: ubuntu-latest-low
needs: [init, cypress]
if: always()
name: cypress-summary
steps:
- name: Summary status
run: if ${{ needs.init.result != 'success' || ( needs.cypress.result != 'success' && needs.cypress.result != 'skipped' ) }}; then exit 1; fi
+5 -25
View File
@@ -2,48 +2,28 @@
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Dependabot
on:
pull_request_target: # zizmor: ignore[dangerous-triggers]
pull_request_target:
branches:
- main
- master
- stable*
permissions:
contents: read
concurrency:
group: dependabot-approve-merge-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
auto-approve-merge:
if: github.event.pull_request.user.login == 'dependabot[bot]' || github.event.pull_request.user.login == 'renovate[bot]'
runs-on: ubuntu-latest-low
permissions:
# for hmarr/auto-approve-action to approve PRs
pull-requests: write
if: github.actor == 'dependabot[bot]'
runs-on: ubuntu-latest
steps:
- name: Disabled on forks
if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
run: |
echo 'Can not approve PRs from forks'
exit 1
# GitHub actions bot approve
# Github actions bot approve
- uses: hmarr/auto-approve-action@b40d6c9ed2fa10c9a2749eca7eb004418a705501 # v2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
# Nextcloud bot approve and merge request
- uses: ahmadnassri/action-dependabot-auto-merge@45fc124d949b19b6b8bf6645b6c9d55f4f9ac61a # v2
- uses: ahmadnassri/action-dependabot-auto-merge@45fc124d949b19b6b8bf6645b6c9d55f4f9ac61a # v2.6.6
with:
target: minor
github-token: ${{ secrets.DEPENDABOT_AUTOMERGE_TOKEN }}
-131
View File
@@ -1,131 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit files_external FTP
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: files-external-ftp-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'apps/files_external/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- '**.php'
files-external-ftp:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.2', '8.4']
ftpd: ['proftpd', 'vsftpd', 'pure-ftpd']
include:
- php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-${{ matrix.ftpd }}
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up ftpd
run: |
sudo mkdir /tmp/ftp
sudo chmod -R 0777 /tmp/ftp
if [[ "${{ matrix.ftpd }}" == 'proftpd' ]]; then echo '$6$Q7V2n3q2GRVv5YeQ$/AhLu07H76Asojy7bxGXMY1caKLAbp5Vt82LOZYMkD/8uDzyMAEXwk0c1Bdz1DkBsk2Vh/9SF130mOPavRGMo.' > /tmp/secret.txt; fi
if [[ "${{ matrix.ftpd }}" == 'proftpd' ]]; then echo 'FTP_ROOT=/home/test' > $GITHUB_ENV; fi
if [[ "${{ matrix.ftpd }}" == 'proftpd' ]]; then docker run --name ftp -d --net host -e PASV_ADDRESS=127.0.0.1 -e FTPUSER_NAME=test -v /tmp/secret.txt:/run/secrets/ftp-user-password-secret -v /tmp/ftp:/home/test instantlinux/proftpd; fi
if [[ "${{ matrix.ftpd }}" == 'vsftpd' ]]; then docker run --name ftp -d --net host -e FTP_USER=test -e FTP_PASS=test -e PASV_ADDRESS=127.0.0.1 -v /tmp/ftp:/home/vsftpd/test fauria/vsftpd; fi
if [[ "${{ matrix.ftpd }}" == 'pure-ftpd' ]]; then docker run --name ftp -d --net host -e "PUBLICHOST=localhost" -e FTP_USER_NAME=test -e FTP_USER_PASS=test -e FTP_USER_HOME=/home/test -v /tmp/ftp:/home/test -v /tmp/ftp:/etc/pure-ftpd/passwd stilliard/pure-ftpd; fi
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
run: |
composer install
mkdir data
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ app:enable --force files_external
echo "<?php return ['run' => true,'host' => 'localhost','user' => 'test','password' => 'test', 'root' => '${{ env.FTP_ROOT }}'];" > apps/files_external/tests/config.ftp.php
- name: smoketest ftp
run: |
php -r 'var_dump(file_put_contents("ftp://test:test@localhost${{ env.FTP_ROOT }}/ftp.txt", "asd"));'
php -r 'var_dump(file_get_contents("ftp://test:test@localhost${{ env.FTP_ROOT }}/ftp.txt"));'
php -r 'var_dump(mkdir("ftp://test:test@localhost${{ env.FTP_ROOT }}/asdads"));'
ls -l /tmp/ftp
[ -f /tmp/ftp/ftp.txt ]
- name: PHPUnit
run: composer run test:files_external -- \
apps/files_external/tests/Storage/FtpTest.php \
--log-junit junit.xml \
${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.xml
flags: phpunit-files-external-ftp
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-files-external-ftp
- name: ftpd logs
if: always()
run: |
docker logs ftp
ftp-summary:
runs-on: ubuntu-latest-low
needs: [changes, files-external-ftp]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.files-external-ftp.result != 'success' }}; then exit 1; fi
-213
View File
@@ -1,213 +0,0 @@
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit files_external S3
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: files-external-s3-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'apps/files_external/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- '**.php'
files-external-s3-minio:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.2', '8.4']
include:
- php-versions: '8.3'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-s3-minio
services:
minio:
image: bitnami/minio@sha256:50cec18ac4184af4671a78aedd5554942c8ae105d51a465fa82037949046da01 # v2025.4.22
env:
MINIO_ROOT_USER: nextcloud
MINIO_ROOT_PASSWORD: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
MINIO_DEFAULT_BUCKETS: nextcloud
ports:
- '9000:9000'
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
env:
OBJECT_STORE_KEY: nextcloud
OBJECT_STORE_SECRET: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
run: |
composer install
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ app:enable --force files_external
echo "<?php return ['run' => true, 'minio' => true, 'secret' => 'actually-not-secret', 'passwordsalt' => 'actually-not-secret', 'hostname' => 'localhost','key' => '$OBJECT_STORE_KEY','secret' => '$OBJECT_STORE_SECRET', 'bucket' => 'bucket', 'port' => 9000, 'use_ssl' => false, 'autocreate' => true, 'use_path_style' => true];" > apps/files_external/tests/config.amazons3.php
- name: Wait for S3
run: |
curl -f -m 1 --retry-connrefused --retry 10 --retry-delay 10 http://localhost:9000/minio/health/ready
- name: PHPUnit
run: |
composer run test:files_external -- \
--group S3 \
--log-junit junit.xml \
apps/files_external/tests/Storage \
${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.xml
flags: phpunit-files-external-s3
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-files-external-s3
- name: Nextcloud logs
if: always()
run: |
cat data/nextcloud.log
- name: S3 logs
if: always()
run: |
docker ps -a
docker ps -aq | while read container ; do IMAGE=$(docker inspect --format='{{.Config.Image}}' $container); echo $IMAGE; docker logs $container; echo "\n\n" ; done
files-external-s3-localstack:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
matrix:
php-versions: ['8.2', '8.4']
include:
- php-versions: '8.3'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-s3-localstack
services:
localstack:
env:
SERVICES: s3
DEBUG: 1
image: localstack/localstack@sha256:9d4253786e0effe974d77fe3c390358391a56090a4fff83b4600d8a64404d95d # v4.5.0
ports:
- "4566:4566"
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
run: |
composer install
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ app:enable --force files_external
echo "<?php return ['run' => true, 'localstack' => true, 'hostname' => 'localhost','key' => 'ignored','secret' => 'ignored', 'bucket' => 'bucket', 'port' => 4566, 'use_ssl' => false, 'autocreate' => true, 'use_path_style' => true];" > apps/files_external/tests/config.amazons3.php
- name: PHPUnit
run: |
composer run test:files_external -- \
--group S3 \
--log-junit junit.xml \
apps/files_external/tests/Storage \
${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.xml
flags: phpunit-files-external-s3
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-files-external-s3
- name: S3 logs
if: always()
run: |
docker ps -a
docker ps -aq | while read container ; do IMAGE=$(docker inspect --format='{{.Config.Image}}' $container); echo $IMAGE; docker logs $container; echo "\n\n" ; done
s3-external-summary:
runs-on: ubuntu-latest-low
needs: [changes, files-external-s3-minio, files-external-s3-localstack]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && (needs.files-external-s3-minio.result != 'success' || needs.files-external-s3-localstack.result != 'success') }}; then exit 1; fi
-121
View File
@@ -1,121 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit files_external sFTP
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: files-external-sftp-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'apps/files_external/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- '**.php'
files-external-sftp:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.2', '8.4']
sftpd: ['openssh']
include:
- php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-${{ matrix.sftpd }}
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up sftpd
run: |
sudo mkdir /tmp/sftp
sudo chown -R 0777 /tmp/sftp
if [[ '${{ matrix.sftpd }}' == 'openssh' ]]; then docker run -p 2222:22 --name sftp -d -v /tmp/sftp:/home/test atmoz/sftp 'test:test:::data'; fi
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
run: |
composer install
mkdir data
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ app:enable --force files_external
echo "<?php return ['run' => true, 'host' => 'localhost:2222','user' => 'test','password' => 'test', 'root' => 'data'];" > apps/files_external/tests/config.sftp.php
- name: PHPUnit
run: composer run test:files_external -- \
apps/files_external/tests/Storage/SftpTest.php \
apps/files_external/tests/Storage/SFTP_KeyTest.php \
--log-junit junit.xml \
${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.xml
flags: phpunit-files-external-sftp
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-files-external-sftp
- name: sftpd logs
if: always()
run: |
ls -l /tmp/sftp
docker logs sftp
sftp-summary:
runs-on: ubuntu-latest-low
needs: [changes, files-external-sftp]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.files-external-sftp.result != 'success' }}; then exit 1; fi
@@ -1,118 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Samba Kerberos SSO
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: files-external-smb-kerberos-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'apps/files_external/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- '**.php'
files-external-smb-kerberos:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
name: smb-kerberos-sso
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Checkout user_saml
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
repository: nextcloud/user_saml
path: apps/user_saml
- name: Install user_saml
run: |
cd apps/user_saml
composer i
cd ../..
- name: Pull images
run: |
docker pull ghcr.io/icewind1991/samba-krb-test-dc
docker pull ghcr.io/icewind1991/samba-krb-test-apache-gssapi:8.4
docker pull ghcr.io/icewind1991/samba-krb-test-client
docker tag ghcr.io/icewind1991/samba-krb-test-dc icewind1991/samba-krb-test-dc
docker tag ghcr.io/icewind1991/samba-krb-test-apache-gssapi:8.4 icewind1991/samba-krb-test-apache-gssapi
docker tag ghcr.io/icewind1991/samba-krb-test-client icewind1991/samba-krb-test-client
- name: Setup AD-DC
run: |
DC_IP=$(apps/files_external/tests/sso-setup/start-dc.sh)
sleep 1
apps/files_external/tests/sso-setup/start-apache.sh $DC_IP $PWD
echo "DC_IP=$DC_IP" >> $GITHUB_ENV
- name: Set up Nextcloud
run: |
apps/files_external/tests/sso-setup/setup-sso-nc.sh
- name: Test SSO
run: |
apps/files_external/tests/sso-setup/test-sso-smb.sh ${{ env.DC_IP }}
- name: Show logs DC
if: always()
run: |
docker logs dc
echo "------------"
docker exec dc cat /var/log/samba/log.samba
- name: Show logs Apache
if: always()
run: |
docker logs apache
- name: Show logs
if: always()
run: |
FILEPATH=$(docker exec --user 33 apache ./occ log:file | grep "Log file:" | cut -d' ' -f3)
echo "$FILEPATH:"
docker exec --user 33 apache cat $FILEPATH
sftp-summary:
runs-on: ubuntu-latest-low
needs: [changes, files-external-smb-kerberos]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.files-external-smb-kerberos.result != 'success' }}; then exit 1; fi
-121
View File
@@ -1,121 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit files_external SMB
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: files-external-smb-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'apps/files_external/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- '**.php'
files-external-smb:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
include:
- php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-smb
services:
samba:
image: ghcr.io/nextcloud/continuous-integration-samba:latest # zizmor: ignore[unpinned-images]
ports:
- 445:445
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, smbclient, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up smbclient
# This is needed as icewind/smb php library for notify
run: sudo apt-get install -y smbclient
- name: Set up Nextcloud
run: |
composer install
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ config:system:set --value true --type boolean allow_local_remote_servers
./occ app:enable --force files_external
echo "<?php return ['run'=>true, 'host'=>'localhost', 'user'=>'test', 'password'=>'test', 'root'=>'', 'share'=>'public'];" > apps/files_external/tests/config.smb.php
- name: Wait for smb
run: |
apps/files_external/tests/env/wait-for-connection 127.0.0.1 445 60
- name: PHPUnit
run: composer run test:files_external -- \
apps/files_external/tests/Storage/SmbTest.php \
--log-junit junit.xml \
${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.xml
flags: phpunit-files-external-smb
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-files-external-smb
files-external-smb-summary:
runs-on: ubuntu-latest-low
needs: [changes, files-external-smb]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.files-external-smb.result != 'success' }}; then exit 1; fi
-119
View File
@@ -1,119 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit files_external WebDAV
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: files-external-webdav-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'apps/files_external/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
- '**.php'
files-external-webdav-apache:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.3', '8.4']
include:
- php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-webdav
services:
apache:
image: ghcr.io/nextcloud/continuous-integration-webdav-apache:latest # zizmor: ignore[unpinned-images]
ports:
- 8081:80
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
run: |
composer install
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ config:system:set --value true --type boolean allow_local_remote_servers
./occ app:enable --force files_external
echo "<?php return ['run' => true, 'host' => 'localhost:8081/webdav/', 'user' => 'test', 'password'=>'pass', 'root' => '', 'wait' => 0];" > apps/files_external/tests/config.webdav.php
- name: Wait for WebDAV
run: |
sleep 5
curl -f -m 1 --retry-connrefused --retry 10 --retry-delay 10 http://test:pass@localhost:8081/webdav/
- name: PHPUnit
run: composer run test:files_external -- \
apps/files_external/tests/Storage/WebdavTest.php \
--log-junit junit.xml \
${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.xml
flags: phpunit-files-external-webdav
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-files-external-webdav
files-external-webdav-summary:
runs-on: ubuntu-latest-low
needs: [changes, files-external-webdav-apache]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.files-external-webdav-apache.result != 'success' }}; then exit 1; fi
-107
View File
@@ -1,107 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit files_external generic
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: files-external-generic-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- 'apps/files_external/**'
- 'vendor/**'
- 'vendor-bin/**'
- 'composer.json'
- 'composer.lock'
files-external-generic:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.3', '8.4']
include:
- php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
name: php${{ matrix.php-versions }}-generic
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
env:
OBJECT_STORE_KEY: nextcloud
OBJECT_STORE_SECRET: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
run: |
composer install
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ app:enable --force files_external
- name: PHPUnit
run: composer run test:files_external -- \
--log-junit junit.xml \
${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.xml
flags: phpunit-files-external-generic
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-files-external-generic
files-external-summary:
runs-on: ubuntu-latest-low
needs: [changes, files-external-generic ]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.files-external-generic.result != 'success' }}; then exit 1; fi
+4 -20
View File
@@ -2,35 +2,19 @@
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Block fixup and squash commits
name: Pull request checks
on:
pull_request:
types: [opened, ready_for_review, reopened, synchronize]
permissions:
contents: read
concurrency:
group: fixup-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
on: pull_request
jobs:
commit-message-check:
if: github.event.pull_request.draft == false
permissions:
pull-requests: write
name: Block fixup and squash commits
runs-on: ubuntu-latest-low
runs-on: ubuntu-latest
steps:
- name: Run check
uses: skjnldsv/block-fixup-merge-action@c138ea99e45e186567b64cf065ce90f7158c236a # v2
uses: xt0rted/block-autosquash-commits-action@79880c36b4811fe549cfffe20233df88876024e7 # v2.2.0
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
+80
View File
@@ -0,0 +1,80 @@
name: FTP
on:
push:
branches:
- master
- stable*
paths:
- 'apps/files_external/**'
pull_request:
paths:
- 'apps/files_external/**'
env:
APP_NAME: files_external
jobs:
ftp-tests:
runs-on: ubuntu-latest
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
strategy:
# do not stop on another job's failure
fail-fast: false
matrix:
php-versions: ['7.4', '8.0']
ftpd: ['proftpd', 'vsftpd', 'pure-ftpd']
name: php${{ matrix.php-versions }}-${{ matrix.ftpd }}
steps:
- name: Checkout server
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
with:
submodules: true
- name: Set up ftpd
run: |
sudo mkdir /tmp/ftp
sudo chown -R 0777 /tmp/ftp
if [[ "${{ matrix.ftpd }}" == 'proftpd' ]]; then docker run --name ftp -d --net host -e FTP_USERNAME=test -e FTP_PASSWORD=test -v /tmp/ftp:/home/test hauptmedia/proftpd; fi
if [[ "${{ matrix.ftpd }}" == 'vsftpd' ]]; then docker run --name ftp -d --net host -e FTP_USER=test -e FTP_PASS=test -e PASV_ADDRESS=127.0.0.1 -v /tmp/ftp:/home/vsftpd/test fauria/vsftpd; fi
if [[ "${{ matrix.ftpd }}" == 'pure-ftpd' ]]; then docker run --name ftp -d --net host -e "PUBLICHOST=localhost" -e FTP_USER_NAME=test -e FTP_USER_PASS=test -e FTP_USER_HOME=/home/test -v /tmp/ftp2:/home/test -v /tmp/ftp2:/etc/pure-ftpd/passwd stilliard/pure-ftpd; fi
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
with:
php-version: ${{ matrix.php-versions }}
tools: phpunit:9
extensions: mbstring, fileinfo, intl, sqlite, pdo_sqlite, zip, gd
- name: Set up Nextcloud
run: |
mkdir data
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ app:enable --force ${{ env.APP_NAME }}
php -S localhost:8080 &
- name: smoketest ftp
run: |
php -r 'var_dump(file_put_contents("ftp://test:test@localhost/ftp.txt", "asd"));'
php -r 'var_dump(file_get_contents("ftp://test:test@localhost/ftp.txt"));'
php -r 'var_dump(mkdir("ftp://test:test@localhost/asdads"));'
ls -l /tmp/ftp
- name: PHPUnit
run: |
echo "<?php return ['run' => true,'host' => 'localhost','user' => 'test','password' => 'test', 'root' => ''];" > apps/${{ env.APP_NAME }}/tests/config.ftp.php
phpunit --configuration tests/phpunit-autotest-external.xml apps/files_external/tests/Storage/FtpTest.php
- name: ftpd logs
if: always()
run: |
docker logs ftp
ftp-summary:
runs-on: ubuntu-latest
needs: ftp-tests
if: always()
steps:
- name: Summary status
run: if ${{ needs.ftp-tests.result != 'success' }}; then exit 1; fi
@@ -1,103 +0,0 @@
# SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Generate changelog on release
on:
release:
types: [published]
permissions:
contents: write
jobs:
changelog_generate:
runs-on: ubuntu-latest
# Only allowed to be run on nextcloud-releases repositories
if: ${{ github.repository_owner == 'nextcloud-releases' }}
steps:
- name: Check actor permission
uses: skjnldsv/check-actor-permission@69e92a3c4711150929bca9fcf34448c5bf5526e7 # v3.0
with:
require: write
- name: Checkout github_helper
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
repository: nextcloud/github_helper
path: github_helper
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
path: server
fetch-depth: 0
- name: Get previous tag
shell: bash
run: |
cd server
# Print all tags
git log --decorate --oneline | egrep 'tag: ' | sed -r 's/^.+tag: ([^,\)]+)[,\)].+$/\1/g'
# Get the current tag
TAGS=$(git log --decorate --oneline | egrep 'tag: ' | sed -r 's/^.+tag: ([^,\)]+)[,\)].+$/\1/g')
CURRENT_TAG=$(echo "$TAGS" | head -n 1)
# If current tag is the first beta, we use the previous major RC1
if echo "$CURRENT_TAG" | grep -q 'beta1'; then
MAJOR=$(echo "$CURRENT_TAG" | sed -E 's/^v([0-9]+).*/\1/')
PREV=$((MAJOR - 1))
PREVIOUS_TAG="v${PREV}.0.0rc1"
# Get the previous tag - filter pre-releases only if current tag is stable
elif echo "$CURRENT_TAG" | grep -q 'rc\|beta\|alpha'; then
# Current tag is pre-release, don't filter
PREVIOUS_TAG=$(echo "$TAGS" | sed -n '2p')
else
# Current tag is stable, filter out pre-releases
PREVIOUS_TAG=$(echo "$TAGS" | grep -v 'rc\|beta\|alpha' | sed -n '2p')
fi
echo "CURRENT_TAG=$CURRENT_TAG" >> $GITHUB_ENV
echo "PREVIOUS_TAG=$PREVIOUS_TAG" >> $GITHUB_ENV
# Since this action only runs on nextcloud-releases, ignoring is okay
- name: Verify current tag # zizmor: ignore[template-injection]
run: |
if [ "${{ github.ref_name }}" != "${{ env.CURRENT_TAG }}" ]; then
echo "Current tag does not match the release tag. Exiting."
exit 1
fi
- name: Set up php 8.2
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 # v2.35.4
with:
php-version: 8.2
coverage: none
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set credentials
run: |
echo '{"username": "github-actions"}' > github_helper/credentials.json
# Since this action only runs on nextcloud-releases, ignoring is okay
- name: Generate changelog between ${{ env.PREVIOUS_TAG }} and ${{ github.ref_name }} # zizmor: ignore[template-injection]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
cd github_helper/changelog
composer install
php index.php generate:changelog --no-bots --format=forum server ${{ env.PREVIOUS_TAG }} ${{ github.ref_name }} > changelog.md
# Since this action only runs on nextcloud-releases, ignoring is okay
- name: Set changelog to release # zizmor: ignore[template-injection]
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
cd server
gh release edit ${{ github.ref_name }} --notes-file "../github_helper/changelog/changelog.md" --title "${{ github.ref_name }}"
-128
View File
@@ -1,128 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: DAV integration tests
on:
pull_request:
permissions:
contents: read
concurrency:
group: integration-caldav-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/*.php'
- '**/lib/**'
- '**/tests/**'
- '**/vendor-bin/**'
- 'build/integration/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
integration-caldav:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false' && github.repository_owner != 'nextcloud-gmbh'
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
endpoint: ['old', 'new']
service: ['CalDAV', 'CardDAV']
name: ${{ matrix.service }} (${{ matrix.endpoint }} endpoint) php${{ matrix.php-versions }}
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: 'none'
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Python
uses: LizardByte/actions/actions/setup_python@bff0a193747a3ac7930a665fc1d4b23eba583b99 # v2025.814.40518
with:
python-version: '2.7'
- name: Set up CalDAVTester
run: |
git clone --depth=1 https://github.com/apple/ccs-caldavtester.git CalDAVTester
git clone --depth=1 https://github.com/apple/ccs-pycalendar.git pycalendar
- name: Set up Nextcloud
run: |
mkdir data
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
# disable the trashbin, so recurrent deletion of the same object works
./occ config:app:set dav calendarRetentionObligation --value=0
# Prepare users
OC_PASS=user01 ./occ user:add --password-from-env user01
OC_PASS=user02 ./occ user:add --password-from-env user02
# Prepare calendars
./occ dav:create-calendar user01 calendar
./occ dav:create-calendar user01 shared
./occ dav:create-calendar user02 calendar
# Prepare address books
./occ dav:create-addressbook user01 addressbook
./occ dav:create-addressbook user02 addressbook
- name: Run Nextcloud
run: |
php -S localhost:8888 &
- name: Run CalDAVTester
run: |
cp "apps/dav/tests/testsuits/caldavtest/serverinfo-${{ matrix.endpoint }}${{ matrix.endpoint == 'old' && (matrix.service == 'CardDAV' && '-carddav' || '-caldav') || '' }}-endpoint.xml" "apps/dav/tests/testsuits/caldavtest/serverinfo.xml"
pushd CalDAVTester
PYTHONPATH="../pycalendar/src" python testcaldav.py --print-details-onfail --basedir "../apps/dav/tests/testsuits/caldavtest" -o cdt.txt \
"${{ matrix.service }}/current-user-principal.xml" \
"${{ matrix.service }}/sync-report.xml" \
${{ matrix.endpoint == 'new' && format('{0}/sharing-{1}.xml', matrix.service, matrix.service == 'CalDAV' && 'calendars' || 'addressbooks') || ';' }}
popd
- name: Print Nextcloud logs
if: always()
run: |
cat data/nextcloud.log
caldav-integration-summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, integration-caldav]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.integration-caldav.result != 'success' }}; then exit 1; fi
-115
View File
@@ -1,115 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Litmus integration tests
on:
pull_request:
permissions:
contents: read
concurrency:
group: integration-litmus-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/*.php'
- '**/lib/**'
- '**/tests/**'
- '**/vendor-bin/**'
- 'build/integration/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
integration-litmus:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false' && github.repository_owner != 'nextcloud-gmbh'
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
endpoint: ['webdav', 'dav']
name: Litmus WebDAV ${{ matrix.endpoint }}
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: 'none'
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
run: |
mkdir data
./occ maintenance:install \
--verbose \
--database=sqlite \
--database-name=nextcloud \
--database-user=root \
--database-pass=rootpassword \
--admin-user admin \
--admin-pass admin
./occ config:system:set trusted_domains 2 --value=host.docker.internal:8080
- name: Run Nextcloud
run: |
php -S 0.0.0.0:8080 &
- name: Run Litmus test
run: |
docker run \
--rm \
--add-host=host.docker.internal:host-gateway \
ghcr.io/nextcloud/continuous-integration-litmus-php8.3:latest \
bash -c '\
cd /tmp/litmus/litmus-0.13;
make URL=http://host.docker.internal:8080/remote.php/${{ matrix.endpoint }}${{ matrix.endpoint == 'dav' && '/files/admin' || ''}} CREDS="admin admin" TESTS="basic copymove props largefile" check;
status=$?;
cat debug.log;
exit $status;'
- name: Print Nextcloud logs
if: always()
run: cat data/nextcloud.log
integration-litmus-summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, integration-litmus]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.integration-litmus.result != 'success' }}; then exit 1; fi
@@ -1,122 +0,0 @@
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: S3 primary storage integration tests
on:
pull_request:
permissions:
contents: read
concurrency:
group: integration-s3-primary-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/*.php'
- '**/lib/**'
- '**/tests/**'
- '**/vendor-bin/**'
- 'build/integration/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
integration-s3-primary:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false' && github.repository_owner != 'nextcloud-gmbh'
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
key: ['objectstore', 'objectstore_multibucket']
name: php${{ matrix.php-versions }}-${{ matrix.key }}-minio
services:
redis:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
ports:
- 6379:6379/tcp
minio:
image: bitnami/minio@sha256:50cec18ac4184af4671a78aedd5554942c8ae105d51a465fa82037949046da01 # v2025.4.22
env:
MINIO_ROOT_USER: nextcloud
MINIO_ROOT_PASSWORD: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
MINIO_DEFAULT_BUCKETS: nextcloud
ports:
- "9000:9000"
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: 'none'
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Wait for S3
run: |
sleep 10
curl -f -m 1 --retry-connrefused --retry 10 --retry-delay 10 http://localhost:9000/minio/health/ready
- name: Set up Nextcloud
run: |
mkdir data
echo '<?php $CONFIG=["${{ matrix.key }}" => ["class" => "OC\Files\ObjectStore\S3", "arguments" => ["bucket" => "nextcloud", "autocreate" => true, "key" => "nextcloud", "secret" => "bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=", "hostname" => "localhost", "port" => 9000, "use_ssl" => false, "use_path_style" => true, "uploadPartSize" => 52428800]]];' > config/config.php
echo '<?php $CONFIG=["redis" => ["host" => "localhost", "port" => 6379], "memcache.local" => "\OC\Memcache\Redis", "memcache.distributed" => "\OC\Memcache\Redis"];' > config/redis.config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f index.php
- name: Integration
run: |
cd build/integration
bash run.sh --tags "~@failure-s3" dav_features/webdav-related.feature
- name: S3 logs
if: always()
run: |
cat data/nextcloud.log
docker ps -a
docker ps -aq | while read container ; do IMAGE=$(docker inspect --format='{{.Config.Image}}' $container); echo $IMAGE; docker logs $container; echo "\n\n" ; done
s3-primary-integration-summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, integration-s3-primary]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.integration-s3-primary.result != 'success' }}; then exit 1; fi
-184
View File
@@ -1,184 +0,0 @@
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Integration sqlite
on:
pull_request:
push:
branches:
- main
- master
- stable*
permissions:
contents: read
concurrency:
group: integration-sqlite-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/*.php'
- '**/lib/**'
- '**/tests/**'
- '**/vendor-bin/**'
- 'build/integration/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- 'core/shipped.json'
integration-sqlite:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
fail-fast: false
matrix:
test-suite:
- 'capabilities_features'
- 'collaboration_features'
- 'comments_features'
- 'dav_features'
- 'features'
- 'federation_features'
- '--tags ~@large files_features'
- 'filesdrop_features'
- 'file_conversions'
- 'openldap_features'
- 'openldap_numerical_features'
- 'ldap_features'
- 'remoteapi_features'
- 'routing_features'
- 'setup_features'
- 'sharees_features'
- 'sharing_features'
- 'theming_features'
- 'videoverification_features'
php-versions: ['8.4']
spreed-versions: ['main']
activity-versions: ['master']
services:
redis:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
ports:
- 6379:6379/tcp
openldap:
image: ghcr.io/nextcloud/continuous-integration-openldap:openldap-7 # zizmor: ignore[unpinned-images]
ports:
- 389:389
env:
SLAPD_DOMAIN: nextcloud.ci
SLAPD_ORGANIZATION: Nextcloud
SLAPD_PASSWORD: admin
SLAPD_ADDITIONAL_MODULES: memberof
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Checkout Talk app
if: ${{ matrix.test-suite == 'videoverification_features' }}
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
repository: nextcloud/spreed
path: apps/spreed
ref: ${{ matrix.spreed-versions }}
- name: Checkout Activity app
if: ${{ matrix.test-suite == 'sharing_features' }}
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
repository: nextcloud/activity
path: apps/activity
ref: ${{ matrix.activity-versions }}
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, imagick, intl, json, ldap, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: none
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up production dependencies
run: composer i --no-dev
- name: Set up behat dependencies
working-directory: build/integration
run: composer i
- name: Set up Talk dependencies
if: ${{ matrix.test-suite == 'videoverification_features' }}
working-directory: apps/spreed
run: composer i --no-dev
- name: Set up Nextcloud
run: |
mkdir data
./occ maintenance:install --verbose ${{ contains(matrix.test-suite,'ldap') && '--data-dir=/dev/shm/nc_int' || '' }} --database=sqlite --database-name=nextcloud --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
./occ config:system:set hashing_default_password --value=true --type=boolean
- name: Configure caching
if: ${{ contains(matrix.test-suite,'ldap') }}
run: |
./occ config:system:set redis host --value=localhost
./occ config:system:set redis port --value=6379 --type=integer
./occ config:system:set redis timeout --value=0 --type=integer
./occ config:system:set memcache.local --value='\OC\Memcache\Redis'
./occ config:system:set memcache.distributed --value='\OC\Memcache\Redis'
- name: Run integration
working-directory: build/integration
env:
LDAP_HOST: localhost
run: bash run.sh ${{ matrix.test-suite }} no-tail-log
- name: Print logs
if: always()
run: |
cat $(./occ log:file |grep "Log file"|cut -d" " -f3)
docker ps -a
docker ps -aq | while read container ; do IMAGE=$(docker inspect --format='{{.Config.Image}}' $container); echo $IMAGE; docker logs $container; echo "\n\n" ; done
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, integration-sqlite]
if: always()
name: integration-sqlite-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.integration-sqlite.result != 'success' }}; then exit 1; fi
+14 -70
View File
@@ -2,99 +2,43 @@
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Lint eslint
name: Lint
on: pull_request
permissions:
contents: read
concurrency:
group: lint-eslint-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
on:
pull_request:
push:
branches:
- master
- stable*
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '**/src/**'
- '**/appinfo/info.xml'
- 'package.json'
- 'package-lock.json'
- 'tsconfig.json'
- '.eslintrc.*'
- '.eslintignore'
- '**.js'
- '**.ts'
- '**.vue'
lint:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
name: NPM lint
name: eslint
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
uses: skjnldsv/read-package-engines-version-actions@1e2f46e78e31476bc71ebd909105e6e033d5a6f4 # v1.1
id: versions
with:
fallbackNode: '^20'
fallbackNpm: '^10'
fallbackNode: '^12'
fallbackNpm: '^6'
- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
uses: actions/setup-node@7c12f8017d5436eb855f1ed4399f037a36fbd9e8 # v2.5.2
with:
node-version: ${{ steps.versions.outputs.nodeVersion }}
- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
run: npm i -g npm@"${{ steps.versions.outputs.npmVersion }}"
- name: Install dependencies
env:
CYPRESS_INSTALL_BINARY: 0
PUPPETEER_SKIP_DOWNLOAD: true
run: npm ci
- name: Lint
run: npm run lint
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, lint]
if: always()
# This is the summary, we just avoid to rename it so that branch protection rules still match
name: eslint
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.lint.result != 'success' }}; then exit 1; fi
-84
View File
@@ -1,84 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Lint php-cs
on: pull_request
permissions:
contents: read
concurrency:
group: lint-php-cs-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/lib/**'
- '**/tests/**'
- '**/vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
lint:
runs-on: ubuntu-latest
name: PHP CS fixer lint
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
- name: Set up php8.1
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 # v2.35.4
with:
php-version: 8.1
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: none
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Install dependencies
run: composer i
- name: Lint
run: composer run cs:check || ( echo 'Please run `composer run cs:fix` to format your code' && exit 1 )
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, lint]
if: always()
# This is the summary, we just avoid to rename it so that branch protection rules still match
name: php-cs
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.lint.result != 'success' }}; then exit 1; fi
-84
View File
@@ -1,84 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Lint php
on: pull_request
permissions:
contents: read
concurrency:
group: lint-php-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/lib/**'
- '**/tests/**'
- '**/vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
lint:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
matrix:
php-versions: [ '8.2', '8.3', '8.4' ]
name: php-lint
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 # v2.35.4
with:
php-version: ${{ matrix.php-versions }}
coverage: none
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Lint
run: composer run lint
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, lint]
if: always()
name: php-lint-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.lint.result != 'success' }}; then exit 1; fi
-53
View File
@@ -1,53 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Lint stylelint
on: pull_request
permissions:
contents: read
concurrency:
group: lint-stylelint-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
lint:
runs-on: ubuntu-latest
name: stylelint
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
id: versions
with:
fallbackNode: '^20'
fallbackNpm: '^10'
- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
with:
node-version: ${{ steps.versions.outputs.nodeVersion }}
- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
- name: Install dependencies
env:
CYPRESS_INSTALL_BINARY: 0
run: npm ci
- name: Lint
run: npm run stylelint
+42
View File
@@ -0,0 +1,42 @@
name: Lint
on: pull_request
jobs:
php-linters:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: ['7.4', '8.0', '8.1']
name: php${{ matrix.php-versions }} lint
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- name: Set up php${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
with:
php-version: ${{ matrix.php-versions }}
extensions: ctype,curl,dom,fileinfo,gd,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
coverage: none
- name: Lint
run: composer run lint
php-cs-fixer:
name: php-cs check
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- name: Set up php
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
with:
php-version: 7.4
extensions: ctype,curl,dom,fileinfo,gd,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
coverage: none
tools: cs2pr
- name: Install dependencies
run: composer i
- name: Run coding standards check
run: |
composer run cs:check -- --format=checkstyle | cs2pr
composer run cs:check || ( echo 'Please run `composer run cs:fix` to format your code' && exit 1 )
shell: bash
-159
View File
@@ -1,159 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Node tests
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: node-tests-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '**/__tests__/**'
- '**/__mocks__/**'
- 'apps/*/src/**'
- 'apps/*/appinfo/info.xml'
- 'core/src/**'
- 'package.json'
- 'package-lock.json'
- 'tsconfig.json'
- '**.js'
- '**.ts'
- '**.vue'
versions:
runs-on: ubuntu-latest-low
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
outputs:
nodeVersion: ${{ steps.versions.outputs.nodeVersion }}
npmVersion: ${{ steps.versions.outputs.npmVersion }}
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
id: versions
with:
fallbackNode: '^20'
fallbackNpm: '^10'
test:
runs-on: ubuntu-latest
needs: [versions, changes]
if: ${{ needs.versions.result != 'failure' && needs.changes.outputs.src != 'false' }}
env:
CYPRESS_INSTALL_BINARY: 0
PUPPETEER_SKIP_DOWNLOAD: true
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
- name: Set up node ${{ needs.versions.outputs.nodeVersion }}
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
with:
node-version: ${{ needs.versions.outputs.nodeVersion }}
- name: Set up npm ${{ needs.versions.outputs.npmVersion }}
run: npm i -g 'npm@${{ needs.versions.outputs.npmVersion }}'
- name: Install dependencies & build
run: |
npm ci
npm run build --if-present
- name: Test and process coverage
run: npm run test:coverage --if-present
- name: Collect coverage
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./coverage/lcov.info
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
handlebars:
runs-on: ubuntu-latest
needs: [versions, changes]
if: ${{ needs.versions.result != 'failure' && needs.changes.outputs.src != 'false' }}
env:
CYPRESS_INSTALL_BINARY: 0
PUPPETEER_SKIP_DOWNLOAD: true
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
- name: Set up node ${{ needs.versions.outputs.nodeVersion }}
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
with:
node-version: ${{ needs.versions.outputs.nodeVersion }}
- name: Set up npm ${{ needs.versions.outputs.npmVersion }}
run: npm i -g 'npm@${{ needs.versions.outputs.npmVersion }}'
- name: Install dependencies
run: npm ci
- name: Run compile
run: ./build/compile-handlebars-templates.sh
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, test, handlebars]
if: always()
name: node-test-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && (needs.test.result != 'success' || needs.handlebars.result != 'success') }}; then exit 1; fi
+98
View File
@@ -0,0 +1,98 @@
name: Node
on:
pull_request:
push:
branches:
- master
- stable*
jobs:
versions:
runs-on: ubuntu-latest
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
outputs:
nodeVersion: ${{ steps.versions.outputs.nodeVersion }}
npmVersion: ${{ steps.versions.outputs.npmVersion }}
steps:
- name: Checkout
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@1e2f46e78e31476bc71ebd909105e6e033d5a6f4 # v1.1
id: versions
with:
fallbackNode: '^12'
fallbackNpm: '^6'
test:
runs-on: ubuntu-latest
needs: versions
steps:
- name: Checkout
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
- name: Set up node ${{ needs.versions.outputs.nodeVersion }}
uses: actions/setup-node@7c12f8017d5436eb855f1ed4399f037a36fbd9e8 # v2.5.2
with:
node-version: ${{ needs.versions.outputs.nodeVersion }}
- name: Set up npm ${{ needs.versions.outputs.npmVersion }}
run: npm i -g npm@"${{ needs.versions.outputs.npmVersion }}"
- name: Install dependencies
env:
CYPRESS_INSTALL_BINARY: 0
PUPPETEER_SKIP_DOWNLOAD: true
run: npm ci
- name: Test
run: npm run test
jsunit:
runs-on: ubuntu-latest
needs: versions
steps:
- name: Checkout
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
- name: Set up node ${{ needs.versions.outputs.nodeVersion }}
uses: actions/setup-node@7c12f8017d5436eb855f1ed4399f037a36fbd9e8 # v2.5.2
with:
node-version: ${{ needs.versions.outputs.nodeVersion }}
- name: Set up npm ${{ needs.versions.outputs.npmVersion }}
run: npm i -g npm@"${{ needs.versions.outputs.npmVersion }}"
- name: Install dependencies
run: npm ci
- name: Test
run: ./autotest-js.sh
handlebars:
runs-on: ubuntu-latest
needs: versions
steps:
- name: Checkout
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
- name: Set up node ${{ needs.versions.outputs.nodeVersion }}
uses: actions/setup-node@7c12f8017d5436eb855f1ed4399f037a36fbd9e8 # v2.5.2
with:
node-version: ${{ needs.versions.outputs.nodeVersion }}
- name: Set up npm ${{ needs.versions.outputs.npmVersion }}
run: npm i -g npm@"${{ needs.versions.outputs.npmVersion }}"
- name: Install dependencies
run: npm ci
- name: Run compile
run: ./build/compile-handlebars-templates.sh
+14 -72
View File
@@ -2,109 +2,51 @@
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Node
on: pull_request
permissions:
contents: read
concurrency:
group: node-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
on:
pull_request:
push:
branches:
- master
- stable*
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '**/src/**'
- '**/appinfo/info.xml'
- 'package.json'
- 'package-lock.json'
- 'tsconfig.json'
- '**.js'
- '**.ts'
- '**.vue'
- 'core/css/*'
- 'core/img/**'
- 'version.php'
build:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
name: NPM build
name: node
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
uses: skjnldsv/read-package-engines-version-actions@1e2f46e78e31476bc71ebd909105e6e033d5a6f4 # v1.1
id: versions
with:
fallbackNode: '^20'
fallbackNpm: '^10'
fallbackNode: '^12'
fallbackNpm: '^6'
- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
uses: actions/setup-node@7c12f8017d5436eb855f1ed4399f037a36fbd9e8 # v2.5.2
with:
node-version: ${{ steps.versions.outputs.nodeVersion }}
- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
run: npm i -g npm@"${{ steps.versions.outputs.npmVersion }}"
- name: Install dependencies & build
env:
CYPRESS_INSTALL_BINARY: 0
PUPPETEER_SKIP_DOWNLOAD: true
run: |
npm ci
npm run build --if-present
- name: Check webpack build changes
run: |
bash -c "[[ ! \"`git status --porcelain `\" ]] || (echo 'Please recompile and commit the assets, see the section \"Show changes on failure\" for details' && exit 1)"
bash -c "[[ ! \"`git status --porcelain `\" ]] || exit 1"
- name: Show changes on failure
if: failure()
run: |
git status
git --no-pager diff
exit 1 # make it red to grab attention
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, build]
if: always()
# This is the summary, we just avoid to rename it so that branch protection rules still match
name: node
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.build.result != 'success' }}; then exit 1; fi
-81
View File
@@ -1,81 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Npm audit fix and compile
on:
workflow_dispatch:
schedule:
# At 2:30 on Sundays
- cron: '30 2 * * 0'
permissions:
contents: read
jobs:
build:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
branches: ['main', 'master', 'stable32', 'stable31', 'stable30']
name: npm-audit-fix-${{ matrix.branches }}
steps:
- name: Checkout
id: checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
ref: ${{ matrix.branches }}
continue-on-error: true
- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
id: versions
with:
fallbackNode: '^20'
fallbackNpm: '^10'
- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
with:
node-version: ${{ steps.versions.outputs.nodeVersion }}
- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
- name: Fix npm audit
id: npm-audit
uses: nextcloud-libraries/npm-audit-action@1b1728b2b4a7a78d69de65608efcf4db0e3e42d0 # v0.2.0
- name: Run npm ci and npm run build
if: steps.checkout.outcome == 'success'
env:
CYPRESS_INSTALL_BINARY: 0
run: |
npm ci
npm run build --if-present
- name: Create Pull Request
if: steps.checkout.outcome == 'success'
uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e # v7.0.8
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
commit-message: 'fix(deps): Fix npm audit'
committer: GitHub <noreply@github.com>
author: nextcloud-command <nextcloud-command@users.noreply.github.com>
signoff: true
branch: automated/noid/${{ matrix.branches }}-fix-npm-audit
title: '[${{ matrix.branches }}] Fix npm audit'
body: ${{ steps.npm-audit.outputs.markdown }}
labels: |
dependencies
3. to review
-138
View File
@@ -1,138 +0,0 @@
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Object storage azure
on:
pull_request:
schedule:
- cron: "15 2 * * *"
permissions:
contents: read
concurrency:
group: object-storage-azure-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
azure-primary-tests:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.2', '8.3']
include:
- php-versions: '8.4'
coverage: true
name: php${{ matrix.php-versions }}-azure
services:
azurite:
image: mcr.microsoft.com/azure-storage/azurite@sha256:0a47e12e3693483cef5c71f35468b91d751611f172d2f97414e9c69113b106d9 # v3.34.0
env:
AZURITE_ACCOUNTS: nextcloud:bmV4dGNsb3Vk
ports:
- 10000:10000
options: --health-cmd="nc 127.0.0.1 10000 -z" --health-interval=1s --health-retries=30
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
env:
OBJECT_STORE: azure
OBJECT_STORE_KEY: nextcloud
OBJECT_STORE_SECRET: bmV4dGNsb3Vk
run: |
composer install
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
php -f tests/enable_all.php
- name: PHPUnit
env:
OBJECT_STORE: azure
OBJECT_STORE_KEY: nextcloud
OBJECT_STORE_SECRET: bmV4dGNsb3Vk
run: composer run test -- --group PRIMARY-azure --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.xml
flags: phpunit-azure
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-azure
- name: Azurite logs
if: always()
run: |
docker ps -a
docker ps -aq | while read container ; do IMAGE=$(docker inspect --format='{{.Config.Image}}' $container); echo $IMAGE; docker logs $container; echo "\n\n" ; done
azure-primary-summary:
runs-on: ubuntu-latest-low
needs: [changes, azure-primary-tests]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.azure-primary-tests.result != 'success' }}; then exit 1; fi
-144
View File
@@ -1,144 +0,0 @@
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Object storage S3
on:
pull_request:
schedule:
- cron: "15 2 * * *"
permissions:
contents: read
concurrency:
group: object-storage-s3-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
s3-primary-tests-minio:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
include:
- php-versions: '8.3'
coverage: true
name: php${{ matrix.php-versions }}-s3
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
minio:
image: bitnami/minio@sha256:50cec18ac4184af4671a78aedd5554942c8ae105d51a465fa82037949046da01 # v2025.4.22
env:
MINIO_ROOT_USER: nextcloud
MINIO_ROOT_PASSWORD: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
MINIO_DEFAULT_BUCKETS: nextcloud
ports:
- "9000:9000"
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
env:
OBJECT_STORE: s3
OBJECT_STORE_KEY: nextcloud
OBJECT_STORE_SECRET: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
run: |
composer install
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
php -f tests/enable_all.php
- name: Wait for S3
run: |
sleep 10
curl -f -m 1 --retry-connrefused --retry 10 --retry-delay 10 http://localhost:9000/minio/health/ready
- name: PHPUnit
env:
OBJECT_STORE: s3
OBJECT_STORE_KEY: nextcloud
OBJECT_STORE_SECRET: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
run: composer run test -- --group PRIMARY-s3 --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.xml
flags: phpunit-s3
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-s3
- name: S3 logs
if: always()
run: |
docker ps -a
docker ps -aq | while read container ; do IMAGE=$(docker inspect --format='{{.Config.Image}}' $container); echo $IMAGE; docker logs $container; echo "\n\n" ; done
s3-primary-summary:
runs-on: ubuntu-latest-low
needs: [changes,s3-primary-tests-minio]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.s3-primary-tests-minio.result != 'success' }}; then exit 1; fi
-134
View File
@@ -1,134 +0,0 @@
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Object storage Swift
on:
pull_request:
schedule:
- cron: "15 2 * * *"
permissions:
contents: read
concurrency:
group: object-storage-swift-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
swift-primary-tests:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
include:
- php-versions: '8.3'
coverage: true
name: php${{ matrix.php-versions }}-swift
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
swift:
image: ghcr.io/cscfi/docker-keystone-swift@sha256:e8b1ec21120ab9adc6ac6a2b98785fd273676439a8633fe898e37f2aea7e0712
ports:
- 5000:5000
- 8080:8080
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
env:
OBJECT_STORE: swift
OBJECT_STORE_SECRET: veryfast
run: |
composer install
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
php -f tests/enable_all.php
- name: PHPUnit
env:
OBJECT_STORE: swift
OBJECT_STORE_SECRET: veryfast
run: composer run test -- --group PRIMARY-swift --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.xml
flags: phpunit-swift
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-swift
- name: Swift logs
if: always()
run: |
docker ps -a
docker ps -aq | while read container ; do IMAGE=$(docker inspect --format='{{.Config.Image}}' $container); echo $IMAGE; docker logs $container; echo "\n\n" ; done
swift-primary-summary:
runs-on: ubuntu-latest-low
needs: [changes,swift-primary-tests]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.swift-primary-tests.result != 'success' }}; then exit 1; fi
+90
View File
@@ -0,0 +1,90 @@
name: PHPUnit
on:
pull_request:
push:
branches:
- master
- stable*
jobs:
phpunit-oci:
runs-on: ubuntu-20.04
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
strategy:
fail-fast: false
matrix:
php-versions: [ '7.4', '8.0', '8.1']
databases: [ 'oci' ]
name: php${{ matrix.php-versions }}-${{ matrix.databases }}
services:
oracle:
image: ghcr.io/gvenzl/oracle-xe:11
# Provide passwords and other environment variables to container
env:
ORACLE_RANDOM_PASSWORD: true
APP_USER: autotest
APP_USER_PASSWORD: owncloud
# Forward Oracle port
ports:
- 1521:1521/tcp
# Provide healthcheck script options for startup
options: >-
--health-cmd healthcheck.sh
--health-interval 10s
--health-timeout 5s
--health-retries 10
steps:
- name: Checkout server
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
- name: Checkout submodules
shell: bash
run: |
auth_header="$(git config --local --get http.https://github.com/.extraheader)"
git submodule sync --recursive
git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
with:
php-version: ${{ matrix.php-versions }}
extensions: ctype,curl,dom,fileinfo,gd,imagick,intl,json,mbstring,oci8,openssl,pcntl,pdo_sqlite,posix,sqlite,xml,zip
tools: phpunit:9
coverage: none
- name: Set up Nextcloud
run: |
mkdir data
./occ maintenance:install --verbose --database=oci --database-name=XE --database-host=127.0.0.1 --database-port=1521 --database-user=autotest --database-pass=owncloud --admin-user admin --admin-pass admin
php -f index.php
- name: PHPUnit
working-directory: tests
run: phpunit --configuration phpunit-autotest.xml --group DB,SLOWDB
- name: Run repair steps
run: |
./occ maintenance:repair --include-expensive
summary:
permissions:
contents: none
runs-on: ubuntu-latest
needs: phpunit-oci
if: always()
name: phpunit-oci-summary
steps:
- name: Summary status
run: if ${{ needs.phpunit-oci.result != 'success' }}; then exit 1; fi
-47
View File
@@ -1,47 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-FileCopyrightText: 2024 Arthur Schiwon <blizzz@arthur-schiwon.de>
# SPDX-License-Identifier: MIT
name: OpenAPI
on: pull_request
permissions:
contents: read
concurrency:
group: openapi-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
openapi:
runs-on: ubuntu-latest
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
- name: Set up php
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 # v2.35.4
with:
php-version: '8.2'
extensions: ctype, curl, dom, fileinfo, gd, json, libxml, mbstring, openssl, pcntl, pdo, posix, session, simplexml, xml, xmlreader, xmlwriter, zip, zlib
coverage: none
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: OpenAPI checker
run: build/openapi-checker.sh
-127
View File
@@ -1,127 +0,0 @@
# SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Performance testing
on:
pull_request:
permissions:
contents: read
concurrency:
group: performance-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
performance-testing:
runs-on: ubuntu-latest
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
permissions:
pull-requests: write
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
name: performance-${{ matrix.php-versions }}
steps:
- name: Disabled on forks
if: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
run: |
echo 'Can not run performance tests on forks'
exit 1
- name: Checkout server before PR
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
ref: ${{ github.event.pull_request.base.ref }}
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 # v2.35.4
with:
php-version: ${{ matrix.php-versions }}
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
run: |
mkdir data
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
php -S localhost:8080 &
- name: Apply blueprint
uses: icewind1991/blueprint@00504403f76cb2a09efd0d16793575055e6f63cb # v0.1.2
with:
blueprint: tests/blueprints/basic.toml
ref: ${{ github.event.pull_request.head.ref }}
- name: Run before measurements
uses: nextcloud/profiler@6801ee10fc80f10b444388fb6ca9b36ad8a2ea83
with:
run: |
curl -s -X PROPFIND -u test:test http://localhost:8080/remote.php/dav/files/test
curl -s -u test:test http://localhost:8080/remote.php/dav/files/test/test.txt
curl -s -X PROPFIND -u test:test http://localhost:8080/remote.php/dav/files/test/many_files
curl -s -u test:test -T README.md http://localhost:8080/remote.php/dav/files/test/new_file.txt
curl -s -u test:test -X DELETE http://localhost:8080/remote.php/dav/files/test/new_file.txt
output: before.json
profiler-branch: master
- name: Apply PR # zizmor: ignore[template-injection]
run: |
git remote add pr '${{ github.event.pull_request.head.repo.clone_url }}'
git fetch pr '${{ github.event.pull_request.head.ref }}'
git checkout -b 'pr/${{ github.event.pull_request.head.ref }}'
git submodule update
./occ upgrade
- name: Run after measurements
id: compare
uses: nextcloud/profiler@6801ee10fc80f10b444388fb6ca9b36ad8a2ea83
with:
run: |
curl -s -X PROPFIND -u test:test http://localhost:8080/remote.php/dav/files/test
curl -s -u test:test http://localhost:8080/remote.php/dav/files/test/test.txt
curl -s -X PROPFIND -u test:test http://localhost:8080/remote.php/dav/files/test/many_files
curl -s -u test:test -T README.md http://localhost:8080/remote.php/dav/files/test/new_file.txt
curl -s -u test:test -X DELETE http://localhost:8080/remote.php/dav/files/test/new_file.txt
output: after.json
profiler-branch: master
compare-with: before.json
- name: Upload profiles
if: always()
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
with:
name: profiles
path: |
before.json
after.json
- uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7
if: failure() && steps.compare.outcome == 'failure'
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
let comment = `Possible performance regression detected\n`;
comment += `<details><summary>Show Output</summary>
\`\`\`
${{ steps.compare.outputs.compare }}
\`\`\`
</details>`;
github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: comment
})
-71
View File
@@ -1,71 +0,0 @@
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit 32bits
on:
pull_request:
paths:
- 'version.php'
- '.github/workflows/phpunit-32bits.yml'
- 'tests/phpunit-autotest.xml'
workflow_dispatch:
schedule:
- cron: "15 1 * * 1-6"
permissions:
contents: read
concurrency:
group: phpunit-32bits-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
phpunit-32bits:
runs-on: ubuntu-latest
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
container: shivammathur/node:latest-i386
strategy:
fail-fast: false
matrix:
php-versions: ['8.2', '8.3', '8.4']
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Install tools
run: |
sudo apt-get update
sudo apt-get install -y ffmpeg imagemagick libmagickcore-6.q16-3-extra
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, imagick, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite, apcu, ldap
coverage: none
ini-file: development
ini-values:
apc.enabled=on, apc.enable_cli=on, disable_functions= # https://github.com/shivammathur/setup-php/discussions/573
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: Set up Nextcloud
env:
DB_PORT: 4444
run: |
mkdir data
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-port=$DB_PORT --database-user=autotest --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: PHPUnit
run: composer run test -- --exclude-group PRIMARY-azure,PRIMARY-s3,PRIMARY-swift,Memcached,Redis,RoutingWeirdness
-155
View File
@@ -1,155 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit MariaDB
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-mariadb-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
phpunit-mariadb:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
mariadb-versions: ['10.3', '10.6', '10.11', '11.4', '11.8']
include:
- php-versions: '8.3'
mariadb-versions: '10.11'
coverage: ${{ github.event_name != 'pull_request' }}
- php-versions: '8.4'
mariadb-versions: '11.8'
name: MariaDB ${{ matrix.mariadb-versions }} (PHP ${{ matrix.php-versions }}) - database tests
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
mariadb:
image: mariadb:${{ matrix.mariadb-versions }}
ports:
- 4444:3306/tcp
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: oc_autotest
options: --health-cmd="${{ matrix.mariadb-versions <= 10.4 && 'mysqladmin' || 'mariadb-admin'}} ping" --health-interval 5s --health-timeout 2s --health-retries 5
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 # v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, mysql, pdo_mysql
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: Enable ONLY_FULL_GROUP_BY MariaDB option
run: |
echo "SET GLOBAL sql_mode=(SELECT CONCAT(@@sql_mode,',ONLY_FULL_GROUP_BY'));" | mysql -h 127.0.0.1 -P 4444 -u root -prootpassword
echo 'SELECT @@sql_mode;' | mysql -h 127.0.0.1 -P 4444 -u root -prootpassword
- name: Set up Nextcloud
env:
DB_PORT: 4444
run: |
mkdir data
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=mysql --database-name=nextcloud --database-host=127.0.0.1 --database-port=$DB_PORT --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: PHPUnit
run: composer run test:db -- --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.db.xml' || '' }}
- name: Upload db code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.db.xml
flags: phpunit-mariadb
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-mariadb
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, phpunit-mariadb]
if: always()
name: phpunit-mariadb-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-mariadb.result != 'success' }}; then exit 1; fi
-134
View File
@@ -1,134 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit memcached
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-memcached-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
phpunit-memcached:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
fail-fast: false
matrix:
php-versions: ['8.3', '8.4']
include:
- php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
name: Memcached (PHP ${{ matrix.php-versions }})
services:
memcached:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 11212:11212/tcp
- 11212:11212/udp
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, memcached, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: Set up Nextcloud
run: |
mkdir data
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: PHPUnit memcached tests
run: composer run test -- --group Memcache,Memcached --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.xml' || '' }}
- name: Upload code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.xml
flags: phpunit-memcached
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-memcached
- name: Print logs
if: always()
run: |
cat data/nextcloud.log
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, phpunit-memcached]
if: always()
name: phpunit-memcached-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-memcached.result != 'success' }}; then exit 1; fi
@@ -1,192 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2022-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit sharding
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-mysql-sharding-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src }}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
phpunit-mysql:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
mysql-versions: ['8.4']
name: Sharding - MySQL ${{ matrix.mysql-versions }} (PHP ${{ matrix.php-versions }}) - database tests
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
mysql:
image: ghcr.io/nextcloud/continuous-integration-mysql-${{ matrix.mysql-versions }}:latest # zizmor: ignore[unpinned-images]
ports:
- 4444:3306/tcp
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: oc_autotest
options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 10
shard1:
image: ghcr.io/nextcloud/continuous-integration-mysql-${{ matrix.mysql-versions }}:latest # zizmor: ignore[unpinned-images]
ports:
- 5001:3306/tcp
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: nextcloud
options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 10
shard2:
image: ghcr.io/nextcloud/continuous-integration-mysql-${{ matrix.mysql-versions }}:latest # zizmor: ignore[unpinned-images]
ports:
- 5002:3306/tcp
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: nextcloud
options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 10
shard3:
image: ghcr.io/nextcloud/continuous-integration-mysql-${{ matrix.mysql-versions }}:latest # zizmor: ignore[unpinned-images]
ports:
- 5003:3306/tcp
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: nextcloud
options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 10
shard4:
image: ghcr.io/nextcloud/continuous-integration-mysql-${{ matrix.mysql-versions }}:latest # zizmor: ignore[unpinned-images]
ports:
- 5004:3306/tcp
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: nextcloud
options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 10
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, mysql, pdo_mysql
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: Enable ONLY_FULL_GROUP_BY MySQL option
run: |
echo "SET GLOBAL sql_mode=(SELECT CONCAT(@@sql_mode,',ONLY_FULL_GROUP_BY'));" | mysql -h 127.0.0.1 -P 4444 -u root -prootpassword
echo "SELECT @@sql_mode;" | mysql -h 127.0.0.1 -P 4444 -u root -prootpassword
- name: Set up Nextcloud
env:
DB_PORT: 4444
SHARDING: 1
run: |
mkdir data
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=mysql --database-name=nextcloud --database-host=127.0.0.1 --database-port=$DB_PORT --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: PHPUnit
run: composer run test:db -- --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.db.xml' || '' }}
- name: Upload db code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.db.xml
flags: phpunit-mysql
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-mysql
- name: Print logs
if: always()
run: |
cat data/nextcloud.log
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, phpunit-mysql]
if: always()
name: phpunit-mysql-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-mysql.result != 'success' }}; then exit 1; fi
-160
View File
@@ -1,160 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2022-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit mysql
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-mysql-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src }}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
phpunit-mysql:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
mysql-versions: ['8.0', '8.4']
include:
- mysql-versions: '8.0'
php-versions: '8.3'
coverage: ${{ github.event_name != 'pull_request' }}
- mysql-versions: '8.4'
php-versions: '8.4'
name: MySQL ${{ matrix.mysql-versions }} (PHP ${{ matrix.php-versions }}) - database tests
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
mysql:
image: ghcr.io/nextcloud/continuous-integration-mysql-${{ matrix.mysql-versions }}:latest # zizmor: ignore[unpinned-images]
ports:
- 4444:3306/tcp
env:
MYSQL_ROOT_PASSWORD: rootpassword
MYSQL_USER: oc_autotest
MYSQL_PASSWORD: nextcloud
MYSQL_DATABASE: oc_autotest
options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 10
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 # v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, mysql, pdo_mysql
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: Enable ONLY_FULL_GROUP_BY MySQL option
run: |
echo "SET GLOBAL sql_mode=(SELECT CONCAT(@@sql_mode,',ONLY_FULL_GROUP_BY'));" | mysql -h 127.0.0.1 -P 4444 -u root -prootpassword
echo "SELECT @@sql_mode;" | mysql -h 127.0.0.1 -P 4444 -u root -prootpassword
- name: Set up Nextcloud
env:
DB_PORT: 4444
run: |
mkdir data
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=mysql --database-name=nextcloud --database-host=127.0.0.1 --database-port=$DB_PORT --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: PHPUnit
run: composer run test:db -- --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.db.xml' || '' }}
- name: Upload db code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.db.xml
flags: phpunit-mysql
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-mysql
- name: Print logs
if: always()
run: |
cat data/nextcloud.log
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, phpunit-mysql]
if: always()
name: phpunit-mysql-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-mysql.result != 'success' }}; then exit 1; fi
-140
View File
@@ -1,140 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
#
# This is the testsuite running all non-database agnostic unit tests
name: PHPUnit nodb
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-nodb-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src }}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'resources/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
phpunit-nodb:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
fail-fast: false
matrix:
php-versions: ['8.3', '8.4']
include:
- php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
name: No DB unit tests (PHP ${{ matrix.php-versions }})
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, imagick, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
# Required for tests that use pcntl
ini-values: disable_functions=""
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: Set up Nextcloud
run: |
mkdir data
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: PHPUnit nodb testsuite
run: composer run test -- --exclude-group DB,SLOWDB --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.nodb.xml' || '' }}
- name: Upload nodb code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.nodb.xml
flags: phpunit-nodb
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-nodb
- name: Print logs
if: always()
run: |
cat data/nextcloud.log
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, phpunit-nodb]
if: always()
name: phpunit-nodb-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-nodb.result != 'success' }}; then exit 1; fi
@@ -1,124 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit primary object store
on:
pull_request:
schedule:
- cron: "15 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-object-store-primary-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
outputs:
src: ${{ steps.changes.outputs.src}}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
object-store-primary-tests-minio:
runs-on: ubuntu-latest
needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
key: ['s3', 's3-multibucket']
name: php${{ matrix.php-versions }}-${{ matrix.key }}-minio
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
minio:
image: bitnami/minio@sha256:50cec18ac4184af4671a78aedd5554942c8ae105d51a465fa82037949046da01 # v2025.4.22
env:
MINIO_ROOT_USER: nextcloud
MINIO_ROOT_PASSWORD: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
MINIO_DEFAULT_BUCKETS: nextcloud
ports:
- "9000:9000"
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: ${{ matrix.php-versions }}
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Nextcloud
env:
OBJECT_STORE: ${{ matrix.key }}
OBJECT_STORE_KEY: nextcloud
OBJECT_STORE_SECRET: bWluaW8tc2VjcmV0LWtleS1uZXh0Y2xvdWQ=
run: |
composer install
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
php -f tests/enable_all.php
- name: Wait for S3
run: |
sleep 10
curl -f -m 1 --retry-connrefused --retry 10 --retry-delay 10 http://localhost:9000/minio/health/ready
- name: PHPUnit
run: composer run test:db
- name: S3 logs
if: always()
run: |
cat data/nextcloud.log
docker ps -a
docker ps -aq | while read container ; do IMAGE=$(docker inspect --format='{{.Config.Image}}' $container); echo $IMAGE; docker logs $container; echo "\n\n" ; done
object-store-primary-summary:
runs-on: ubuntu-latest-low
needs: [changes,object-store-primary-tests-minio]
if: always()
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.object-store-primary-tests-minio.result != 'success' }}; then exit 1; fi
-163
View File
@@ -1,163 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2022-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit OCI
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-oci-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src }}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
phpunit-oci:
runs-on: ubuntu-latest
needs: changes
if: ${{ needs.changes.outputs.src != 'false' && github.repository_owner != 'nextcloud-gmbh' }}
strategy:
fail-fast: false
matrix:
include:
- oracle-versions: '11'
php-versions: '8.2'
- oracle-versions: '18'
php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
- oracle-versions: '21'
php-versions: '8.2'
- oracle-versions: '23'
php-versions: '8.3'
- oracle-versions: '23'
php-versions: '8.4'
name: Oracle ${{ matrix.oracle-versions }} (PHP ${{ matrix.php-versions }}) - database tests
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
oracle:
image: ghcr.io/gvenzl/oracle-${{ matrix.oracle-versions < 23 && 'xe' || 'free' }}:${{ matrix.oracle-versions }}
# Provide passwords and other environment variables to container
env:
ORACLE_PASSWORD: oracle
# Forward Oracle port
ports:
- 1521:1521
# Provide healthcheck script options for startup
options: >-
--health-cmd healthcheck.sh
--health-interval 20s
--health-timeout 10s
--health-retries 10
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 # v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, oci8
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: Set up Nextcloud
run: |
mkdir data
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=oci --database-name=${{ matrix.oracle-versions < 23 && 'XE' || 'FREE' }} --database-host=127.0.0.1 --database-port=1521 --database-user=system --database-pass=oracle --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: PHPUnit
run: composer run test:db -- --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.db.xml' || '' }}
- name: Upload db code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.db.xml
flags: phpunit-oci
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-oci
- name: Run repair steps
run: |
./occ maintenance:repair --include-expensive
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, phpunit-oci]
if: always()
name: phpunit-oci-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-oci.result != 'success' }}; then exit 1; fi
-159
View File
@@ -1,159 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2022-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit PostgreSQL
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-pgsql-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src }}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
phpunit-pgsql:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
fail-fast: false
matrix:
php-versions: ['8.2']
# To keep the matrix smaller we ignore PostgreSQL versions in between as we already test the minimum and the maximum
postgres-versions: ['13', '17']
include:
- php-versions: '8.3'
postgres-versions: '17'
coverage: ${{ github.event_name != 'pull_request' }}
- php-versions: '8.4'
postgres-versions: '17'
name: PostgreSQL ${{ matrix.postgres-versions }} (PHP ${{ matrix.php-versions }}) - database tests
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
postgres:
image: ghcr.io/nextcloud/continuous-integration-postgres-${{ matrix.postgres-versions }}:latest # zizmor: ignore[unpinned-images]
ports:
- 4444:5432/tcp
env:
POSTGRES_USER: root
POSTGRES_PASSWORD: rootpassword
POSTGRES_DB: nextcloud
options: --mount type=tmpfs,destination=/var/lib/postgresql/data --health-cmd pg_isready --health-interval 5s --health-timeout 2s --health-retries 5
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 # v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, pgsql, pdo_pgsql
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: Set up Nextcloud
env:
DB_PORT: 4444
run: |
mkdir data
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=pgsql --database-name=nextcloud --database-host=127.0.0.1 --database-port=$DB_PORT --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: PHPUnit database tests
run: composer run test:db -- --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.db.xml' || '' }}
- name: Upload db code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.db.xml
flags: phpunit-postgres
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-postgres
- name: Run repair steps
run: |
./occ maintenance:repair --include-expensive
- name: Print logs
if: always()
run: |
cat data/nextcloud.log
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, phpunit-pgsql]
if: always()
name: phpunit-pgsql-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-pgsql.result != 'success' }}; then exit 1; fi
-141
View File
@@ -1,141 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2022-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: PHPUnit SQLite
on:
pull_request:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
concurrency:
group: phpunit-sqlite-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
changes:
runs-on: ubuntu-latest-low
permissions:
contents: read
pull-requests: read
outputs:
src: ${{ steps.changes.outputs.src }}
steps:
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: changes
continue-on-error: true
with:
filters: |
src:
- '.github/workflows/**'
- '3rdparty/**'
- '**/appinfo/**'
- '**/lib/**'
- '**/templates/**'
- '**/tests/**'
- 'vendor/**'
- 'vendor-bin/**'
- '.php-cs-fixer.dist.php'
- 'composer.json'
- 'composer.lock'
- '**.php'
phpunit-sqlite:
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.src != 'false'
strategy:
fail-fast: false
matrix:
php-versions: ['8.3', '8.4']
include:
- php-versions: '8.2'
coverage: ${{ github.event_name != 'pull_request' }}
name: SQLite (PHP ${{ matrix.php-versions }})
services:
cache:
image: ghcr.io/nextcloud/continuous-integration-redis:latest # zizmor: ignore[unpinned-images]
ports:
- 6379:6379/tcp
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
steps:
- name: Checkout server
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 # v2.35.4
with:
php-version: ${{ matrix.php-versions }}
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Set up dependencies
run: composer i
- name: Set up Nextcloud
run: |
mkdir data
cp tests/redis.config.php config/
cp tests/preseed-config.php config/config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin
php -f tests/enable_all.php
- name: Nextcloud debug information
run: ./occ app:list && echo "======= System config =======" && ./occ config:list system
- name: PHPUnit database tests
run: composer run test:db -- --log-junit junit.xml ${{ matrix.coverage && '--coverage-clover ./clover.db.xml' || '' }}
- name: Upload db code coverage
if: ${{ !cancelled() && matrix.coverage }}
uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00 # v5.5.0
with:
files: ./clover.db.xml
flags: phpunit-sqlite
- name: Upload test results
if: ${{ !cancelled() }}
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
with:
flags: phpunit-sqlite
- name: Print logs
if: always()
run: |
cat data/nextcloud.log
summary:
permissions:
contents: none
runs-on: ubuntu-latest-low
needs: [changes, phpunit-sqlite]
if: always()
name: phpunit-sqlite-summary
steps:
- name: Summary status
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-sqlite.result != 'success' }}; then exit 1; fi
-55
View File
@@ -1,55 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
# SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-FileCopyrightText: 2023 Marcel Klehr <mklehr@gmx.net>
# SPDX-FileCopyrightText: 2023 Joas Schilling <213943+nickvergessen@users.noreply.github.com>
# SPDX-FileCopyrightText: 2023 Daniel Kesselberg <mail@danielkesselberg.de>
# SPDX-FileCopyrightText: 2023 Florian Steffens <florian.steffens@nextcloud.com>
# SPDX-License-Identifier: MIT
name: 'Ask for feedback on PRs'
on:
schedule:
- cron: '30 1 * * *'
permissions:
contents: read
pull-requests: write
jobs:
pr-feedback:
if: ${{ github.repository_owner == 'nextcloud' }}
runs-on: ubuntu-latest
steps:
- name: The get-github-handles-from-website action
uses: marcelklehr/get-github-handles-from-website-action@06b2239db0a48fe1484ba0bfd966a3ab81a08308 # v1.0.1
id: scrape
with:
website: 'https://nextcloud.com/team/'
- name: Get blocklist
id: blocklist
run: |
blocklist=$(curl https://raw.githubusercontent.com/nextcloud/.github/master/non-community-usernames.txt | paste -s -d, -)
echo "blocklist=$blocklist" >> "$GITHUB_OUTPUT"
- uses: nextcloud/pr-feedback-action@1883b38a033fb16f576875e0cf45f98b857655c4 # main
with:
feedback-message: |
Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
Thank you for contributing to Nextcloud and we hope to hear from you soon!
(If you believe you should not receive this message, you can add yourself to the [blocklist](https://github.com/nextcloud/.github/blob/master/non-community-usernames.txt).)
days-before-feedback: 14
start-date: '2024-04-30'
exempt-authors: '${{ steps.blocklist.outputs.blocklist }},${{ steps.scrape.outputs.users }}'
exempt-bots: true
+28
View File
@@ -0,0 +1,28 @@
name: Psalm show github
on:
pull_request:
push:
branches:
- master
- stable*
jobs:
psalm:
name: Psalm
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
with:
submodules: recursive
- name: Psalm
uses: docker://vimeo/psalm-github-actions:4.9.3
continue-on-error: true
with:
composer_ignore_platform_reqs: false
report_file: results.sarif
- name: Upload Analysis results to GitHub
uses: github/codeql-action/upload-sarif@231aa2c8a89117b126725a0e11897209b7118144 # v1.1.39
with:
sarif_file: results.sarif
+28
View File
@@ -0,0 +1,28 @@
name: Psalm Security Analysis
on:
pull_request:
push:
branches:
- master
- stable*
jobs:
psalm:
name: Psalm
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
with:
submodules: recursive
- name: Psalm
uses: docker://vimeo/psalm-github-actions:4.9.3
with:
security_analysis: true
composer_ignore_platform_reqs: false
report_file: results.sarif
- name: Upload Security Analysis results to GitHub
uses: github/codeql-action/upload-sarif@231aa2c8a89117b126725a0e11897209b7118144 # v1.1.39
with:
sarif_file: results.sarif
-27
View File
@@ -1,27 +0,0 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
# SPDX-FileCopyrightText: 2022 Free Software Foundation Europe e.V. <https://fsfe.org>
#
# SPDX-License-Identifier: CC0-1.0
name: REUSE Compliance Check
on: [pull_request]
permissions:
contents: read
jobs:
reuse-compliance-check:
runs-on: ubuntu-latest-low
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
- name: REUSE Compliance Check
uses: fsfe/reuse-action@bb774aa972c2a89ff34781233d275075cbddf542 # v5.0.0
+128
View File
@@ -0,0 +1,128 @@
name: S3 External storage
on:
push:
branches:
- master
- stable*
paths:
- 'apps/files_external/**'
pull_request:
paths:
- 'apps/files_external/**'
env:
APP_NAME: files_external
jobs:
s3-external-tests-minio:
runs-on: ubuntu-latest
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
strategy:
# do not stop on another job's failure
fail-fast: false
matrix:
php-versions: ['7.4', '8.0']
name: php${{ matrix.php-versions }}-minio
services:
minio:
env:
MINIO_ACCESS_KEY: minio
MINIO_SECRET_KEY: minio123
image: bitnami/minio:2021.10.6
ports:
- "9000:9000"
steps:
- name: Checkout server
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
with:
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
with:
php-version: ${{ matrix.php-versions }}
tools: phpunit:9
extensions: mbstring, fileinfo, intl, sqlite, pdo_sqlite, zip, gd
- name: Set up Nextcloud
run: |
mkdir data
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ app:enable --force ${{ env.APP_NAME }}
php -S localhost:8080 &
- name: PHPUnit
run: |
echo "<?php return ['run' => true,'hostname' => 'localhost','key' => 'minio','secret' => 'minio123', 'bucket' => 'bucket', 'port' => 9000, 'use_ssl' => false, 'autocreate' => true, 'use_path_style' => true];" > apps/${{ env.APP_NAME }}/tests/config.amazons3.php
phpunit --configuration tests/phpunit-autotest-external.xml apps/files_external/tests/Storage/Amazons3Test.php
phpunit --configuration tests/phpunit-autotest-external.xml apps/files_external/tests/Storage/VersionedAmazonS3Test.php
- name: S3 logs
if: always()
run: |
docker ps -a
docker logs $(docker ps -aq)
s3-external-tests-localstack:
runs-on: ubuntu-latest
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
strategy:
# do not stop on another job's failure
fail-fast: false
matrix:
php-versions: ['7.4', '8.0']
name: php${{ matrix.php-versions }}-localstack
services:
minio:
env:
SERVICES: s3
DEBUG: 1
image: localstack/localstack:0.12.7
ports:
- "4566:4566"
steps:
- name: Checkout server
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
with:
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
with:
php-version: ${{ matrix.php-versions }}
tools: phpunit:9
extensions: mbstring, fileinfo, intl, sqlite, pdo_sqlite, zip, gd
- name: Set up Nextcloud
run: |
mkdir data
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
./occ app:enable --force ${{ env.APP_NAME }}
php -S localhost:8080 &
- name: PHPUnit
run: |
echo "<?php return ['run' => true,'hostname' => 'localhost','key' => 'ignored','secret' => 'ignored', 'bucket' => 'bucket', 'port' => 4566, 'use_ssl' => false, 'autocreate' => true, 'use_path_style' => true];" > apps/${{ env.APP_NAME }}/tests/config.amazons3.php
phpunit --configuration tests/phpunit-autotest-external.xml apps/files_external/tests/Storage/Amazons3Test.php
phpunit --configuration tests/phpunit-autotest-external.xml apps/files_external/tests/Storage/VersionedAmazonS3Test.php
- name: S3 logs
if: always()
run: |
docker ps -a
docker logs $(docker ps -aq)
s3-external-summary:
runs-on: ubuntu-latest
needs: [s3-external-tests-minio, s3-external-tests-localstack]
if: always()
steps:
- name: Summary status
run: if ${{ needs.s3-external-tests-minio.result != 'success' }} || ${{ needs.s3-external-tests-localstack.result != 'success' }}; then exit 1; fi
+76
View File
@@ -0,0 +1,76 @@
name: S3 primary storage
on:
pull_request:
push:
branches:
- master
- stable*
jobs:
s3-primary-tests-minio:
runs-on: ubuntu-20.04
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
strategy:
# do not stop on another job's failure
fail-fast: false
matrix:
php-versions: ['8.0']
key: ['objectstore', 'objectstore_multibucket']
name: php${{ matrix.php-versions }}-${{ matrix.key }}-minio
services:
minio:
env:
MINIO_ACCESS_KEY: minio
MINIO_SECRET_KEY: minio123
image: bitnami/minio:2021.12.29
ports:
- "9000:9000"
steps:
- name: Checkout server
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
with:
submodules: true
- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
with:
php-version: ${{ matrix.php-versions }}
tools: phpunit:9
extensions: mbstring, fileinfo, intl, sqlite, pdo_sqlite, zip, gd
- name: Set up Nextcloud
run: |
mkdir data
echo '<?php $CONFIG=["${{ matrix.key }}" => ["class" => "OC\Files\ObjectStore\S3", "arguments" => ["bucket" => "nextcloud", "autocreate" => true, "key" => "minio", "secret" => "minio123", "hostname" => "localhost", "port" => 9000, "use_ssl" => false, "use_path_style" => true, "uploadPartSize" => 52428800]]];' > config/config.php
./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
php -f index.php
- name: Wait for S3
run: |
sleep 10
curl -f -m 1 --retry-connrefused --retry 10 --retry-delay 10 http://localhost:9000/minio/health/ready
- name: PHPUnit
working-directory: tests
run: phpunit --configuration phpunit-autotest.xml --group DB,SLOWDB
- name: S3 logs
if: always()
run: |
docker ps -a
docker logs $(docker ps -aq)
s3-primary-summary:
runs-on: ubuntu-latest
needs: [s3-primary-tests-minio]
if: always()
steps:
- name: Summary status
run: if ${{ needs.s3-primary-tests-minio.result != 'success' }}; then exit 1; fi
+83
View File
@@ -0,0 +1,83 @@
name: Samba Kerberos SSO
on:
push:
branches:
- master
- stable*
paths:
- "apps/files_external/**"
- ".github/workflows/smb-kerberos.yml"
pull_request:
paths:
- "apps/files_external/**"
- ".github/workflows/smb-kerberos.yml"
jobs:
smb-kerberos-tests:
runs-on: ubuntu-latest
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
strategy:
fail-fast: false
matrix:
php-versions: ["7.4", "8.0"]
name: smb-kerberos-sso
steps:
- name: Checkout server
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
with:
submodules: true
- name: Pull images
run: |
docker pull icewind1991/samba-krb-test-dc
docker pull icewind1991/samba-krb-test-apache
docker pull icewind1991/samba-krb-test-client
- name: Setup AD-DC
run: |
cp apps/files_external/tests/*.sh .
mkdir data
sudo chown -R 33 data apps config
DC_IP=$(./start-dc.sh)
./start-apache.sh $DC_IP $PWD
echo "DC_IP=$DC_IP" >> $GITHUB_ENV
- name: Set up Nextcloud
run: |
docker exec --user 33 apache ./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password
docker exec --user 33 apache ./occ config:system:set trusted_domains 1 --value 'httpd.domain.test'
# setup user_saml
docker exec --user 33 apache ./occ app:enable user_saml --force
docker exec --user 33 apache ./occ config:app:set user_saml type --value 'environment-variable'
docker exec --user 33 apache ./occ saml:config:create
docker exec --user 33 apache ./occ saml:config:set 1 --general-uid_mapping=REMOTE_USER
# setup external storage
docker exec --user 33 apache ./occ app:enable files_external --force
docker exec --user 33 apache ./occ files_external:create smb smb smb::kerberosapache
docker exec --user 33 apache ./occ files_external:config 1 host krb.domain.test
docker exec --user 33 apache ./occ files_external:config 1 share netlogon
docker exec --user 33 apache ./occ files_external:list
- name: Test SSO
run: |
mkdir /tmp/shared/cookies
chmod 0777 /tmp/shared/cookies
echo "SAML login"
./client-cmd.sh ${{ env.DC_IP }} curl -c /shared/cookies/jar -s --negotiate -u testuser@DOMAIN.TEST: --delegation always http://httpd.domain.test/index.php/apps/user_saml/saml/login
echo "Check we are logged in"
CONTENT=$(./client-cmd.sh ${{ env.DC_IP }} curl -b /shared/cookies/jar -s --negotiate -u testuser@DOMAIN.TEST: --delegation always http://httpd.domain.test/remote.php/webdav/smb/test.txt)
CONTENT=$(echo $CONTENT | head -n 1 | tr -d '[:space:]')
[[ $CONTENT == "testfile" ]]
smb-kerberos-summary:
runs-on: ubuntu-latest
needs: smb-kerberos-tests
if: always()
steps:
- name: Summary status
run: if ${{ needs.smb-kerberos-tests.result != 'success' }}; then exit 1; fi
+2 -8
View File
@@ -1,5 +1,3 @@
# SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Close stale issues
on:
@@ -7,9 +5,6 @@ on:
schedule:
- cron: "0 0 * * *"
permissions:
contents: read
jobs:
stale:
runs-on: ubuntu-latest
@@ -20,7 +15,7 @@ jobs:
issues: write
steps:
- uses: actions/stale@3a9db7e6a41a89f618792c92c0e97cc736e1b13f # v9
- uses: actions/stale@f7176fd3007623b69d27091f9b9d4ab7995f0a06 # v5.2.1
with:
repo-token: ${{ secrets.COMMAND_BOT_PAT }}
stale-issue-message: >
@@ -33,5 +28,4 @@ jobs:
exempt-issue-labels: '1. to develop,2. developing,3. to review,4. to release,security'
days-before-stale: 30
days-before-close: 14
# debug-only: true
debug-only: true
+54 -138
View File
@@ -1,146 +1,62 @@
# SPDX-FileCopyrightText: 2020 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Psalm static code analysis
name: Static code analysis
on:
pull_request:
push:
branches:
- main
- master
- stable*
paths:
- '.github/workflows/static-code-analysis.yml'
- '**.php'
permissions:
contents: read
concurrency:
group: static-code-analysis-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
on: [pull_request]
jobs:
static-code-analysis:
runs-on: ubuntu-latest
static-code-analysis:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
with:
persist-credentials: false
submodules: true
steps:
- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
- name: Checkout submodules
shell: bash
run: |
auth_header="$(git config --local --get http.https://github.com/.extraheader)"
git submodule sync --recursive
git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1
- name: Set up php7.4
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
with:
php-version: 7.4
extensions: apcu,ctype,curl,dom,fileinfo,ftp,gd,intl,json,ldap,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
coverage: none
- name: Composer install
run: composer i
- name: Psalm
run: composer run psalm -- --monochrome --no-progress --output-format=github --update-baseline || ( git diff -- . ':!lib/composer' && exit 1 )
- name: Check diff
run: git diff -- . ':!lib/composer'
- name: Show potential changes in Psalm baseline
run: |
bash -c "[[ ! \"`git status --porcelain build/psalm-baseline.xml`\" ]] || ( echo 'Uncommited changes in Psalm baseline' && git status && git diff build/psalm-baseline.xml)"
- name: Set up php
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: '8.2'
extensions: apcu,ctype,curl,dom,fileinfo,ftp,gd,imagick,intl,json,ldap,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
coverage: none
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
static-code-analysis-ocp:
runs-on: ubuntu-latest
- name: Composer install
run: composer i
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
- name: Psalm
run: composer run psalm -- --threads=1 --monochrome --no-progress --output-format=github --update-baseline
- name: Show potential changes in Psalm baseline
if: always()
run: git diff --exit-code -- . ':!lib/composer'
static-code-analysis-security:
runs-on: ubuntu-latest
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
steps:
- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
with:
persist-credentials: false
submodules: true
- name: Set up php
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: '8.2'
extensions: ctype,curl,dom,fileinfo,ftp,gd,imagick,intl,json,ldap,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
coverage: none
- name: Composer install
run: composer i
- name: Psalm taint analysis
run: composer run psalm:security -- --threads=1 --monochrome --no-progress --output-format=github --update-baseline --report=results.sarif
- name: Show potential changes in Psalm baseline
if: always()
run: git diff --exit-code -- . ':!lib/composer'
- name: Upload Security Analysis results to GitHub
if: always()
uses: github/codeql-action/upload-sarif@51f77329afa6477de8c49fc9c7046c15b9a4e79d # v3
with:
sarif_file: results.sarif
static-code-analysis-ocp:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
with:
persist-credentials: false
submodules: true
- name: Set up php
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: '8.2'
extensions: ctype,curl,dom,fileinfo,gd,imagick,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
coverage: none
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Composer install
run: composer i
- name: Psalm
run: composer run psalm:ocp -- --threads=1 --monochrome --no-progress --output-format=github --update-baseline
- name: Show potential changes in Psalm baseline
if: always()
run: git diff --exit-code -- . ':!lib/composer'
static-code-analysis-ncu:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
with:
persist-credentials: false
submodules: true
- name: Set up php
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4 #v2.35.4
with:
php-version: '8.2'
extensions: ctype,curl,dom,fileinfo,gd,imagick,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
coverage: none
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Composer install
run: composer i
- name: Psalm
run: composer run psalm:ncu -- --threads=1 --monochrome --no-progress --output-format=github
steps:
- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
- name: Checkout submodules
shell: bash
run: |
auth_header="$(git config --local --get http.https://github.com/.extraheader)"
git submodule sync --recursive
git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1
- name: Set up php7.4
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
with:
php-version: 7.4
extensions: apcu,ctype,curl,dom,fileinfo,ftp,gd,intl,json,ldap,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
coverage: none
- name: Composer install
run: composer i
- name: Psalm
run: composer run psalm -- -c psalm-ocp.xml --monochrome --no-progress --output-format=github --update-baseline || ( git diff -- . ':!lib/composer' && exit 1 )
- name: Check diff
run: git diff -- . ':!lib/composer'
- name: Show potential changes in Psalm baseline
run: |
bash -c "[[ ! \"`git status --porcelain build/psalm-baseline-ocp.xml`\" ]] || ( echo 'Uncommited changes in Psalm baseline' && git status && git diff build/psalm-baseline.xml)"
@@ -1,49 +0,0 @@
# SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Update CA certificate bundle
on:
workflow_dispatch:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
jobs:
update-ca-certificate-bundle:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
branches: ['master', 'stable32', 'stable31', 'stable30', 'stable29', 'stable28', 'stable27', 'stable26', 'stable25', 'stable24', 'stable23', 'stable22']
name: update-ca-certificate-bundle-${{ matrix.branches }}
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
ref: ${{ matrix.branches }}
submodules: true
- name: Download CA certificate bundle from curl
run: curl --etag-compare build/ca-bundle-etag.txt --etag-save build/ca-bundle-etag.txt --output resources/config/ca-bundle.crt https://curl.se/ca/cacert.pem
- name: Create Pull Request
uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
commit-message: 'fix(security): Update CA certificate bundle'
committer: GitHub <noreply@github.com>
author: nextcloud-command <nextcloud-command@users.noreply.github.com>
signoff: true
branch: 'automated/noid/${{ matrix.branches }}-update-ca-cert-bundle'
title: '[${{ matrix.branches }}] fix(security): Update CA certificate bundle'
body: |
Auto-generated update of CA certificate bundle from [https://curl.se/docs/caextract.html](https://curl.se/docs/caextract.html)
labels: |
dependencies
3. to review
reviewers: ChristophWurst, miaulalala, nickvergessen
@@ -1,52 +0,0 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Update code signing revocation list
on:
workflow_dispatch:
schedule:
- cron: "5 2 * * *"
permissions:
contents: read
jobs:
update-code-signing-crl:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
branches: ['master', 'stable32', 'stable31', 'stable30', 'stable29', 'stable28', 'stable27', 'stable26', 'stable25', 'stable24', 'stable23', 'stable22']
name: update-code-signing-crl-${{ matrix.branches }}
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
ref: ${{ matrix.branches }}
submodules: true
- name: Download CRL file from Appstore repository
run: curl --output resources/codesigning/root.crl https://raw.githubusercontent.com/nextcloud/appstore/master/nextcloudappstore/certificate/nextcloud.crl
- name: Verify CRL is from CRT
run: openssl crl -verify -in resources/codesigning/root.crl -CAfile resources/codesigning/root.crt -noout
- name: Create Pull Request
uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
commit-message: 'fix(security): Update code signing revocation list'
committer: GitHub <noreply@github.com>
author: nextcloud-command <nextcloud-command@users.noreply.github.com>
signoff: true
branch: 'automated/noid/${{ matrix.branches }}-update-code-signing-crl'
title: '[${{ matrix.branches }}] fix(security): Update code signing revocation list'
body: |
Auto-generated update of code signing revocation list from [Appstore](https://github.com/nextcloud/appstore/commits/master/nextcloudappstore/certificate/nextcloud.crl)
labels: |
dependencies
3. to review
reviewers: mgallien, miaulalala, nickvergessen
@@ -1,128 +0,0 @@
# SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Update min supported desktop version
on:
workflow_dispatch:
schedule:
- cron: "0 0 * * 1"
permissions:
contents: read
jobs:
update-minimum-supported-desktop-version:
runs-on: ubuntu-latest-low
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
submodules: true
- name: Download desktop client version file from 5 years ago
id: download
run: |
# Create a temporary directory for the downloaded file
mkdir -p tmp
# Download the version file from the provided URL
VERSION_FILE_URL="https://github.com/nextcloud/desktop/raw/@%7B5.years.ago%7D/VERSION.cmake"
# Download the file using curl
curl -s -L "$VERSION_FILE_URL" -o tmp/VERSION.cmake
if [ ! -f "tmp/VERSION.cmake" ]; then
echo "Failed to download VERSION.cmake file"
exit 1
fi
echo "VERSION_FILE=tmp/VERSION.cmake" >> $GITHUB_OUTPUT
echo "Downloaded version file to tmp/VERSION.cmake"
- name: Extract version info
id: extract-version
run: |
# Path to the downloaded version file
VERSION_FILE="${{ steps.download.outputs.VERSION_FILE }}"
# Extract major, minor, patch versions
MAJOR=$(grep "VERSION_MAJOR" $VERSION_FILE | grep -o '[0-9]\+')
MINOR=$(grep "VERSION_MINOR" $VERSION_FILE | grep -o '[0-9]\+')
PATCH=$(grep "VERSION_PATCH" $VERSION_FILE | grep -o '[0-9]\+')
# Construct the version string
VERSION="$MAJOR.$MINOR.$PATCH"
# Validate format: xx.xx.xx where each x is a digit
if ! [[ "$VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
echo "Error: Extracted version '$VERSION' does not match required format (xx.xx.xx)"
exit 1
fi
rm -rf tmp
echo "VERSION=$VERSION" >> $GITHUB_OUTPUT
echo "Extracted Version: $VERSION"
- name: Update files with new version ${{ steps.extract-version.outputs.VERSION }}
id: update-files
run: |
VERSION="${{ steps.extract-version.outputs.VERSION }}"
# Define the files to update
DAV_FILE="apps/dav/lib/Connector/Sabre/BlockLegacyClientPlugin.php"
CONFIG_FILE="config/config.sample.php"
# Check if files exist
if [ ! -f "$DAV_FILE" ]; then
echo "Error: DAV file not found at $DAV_FILE"
exit 1
fi
if [ ! -f "$CONFIG_FILE" ]; then
echo "Error: Config file not found at $CONFIG_FILE"
exit 1
fi
# Update the DAV file - replace the version in the specific line
sed -i "s/\('minimum\.supported\.desktop\.version', '\)[0-9]\+\.[0-9]\+\.[0-9]\+'/\1$VERSION'/g" "$DAV_FILE"
echo "Updated $DAV_FILE"
# Update the config sample file
PREV_VERSION=$(grep "'minimum.supported.desktop.version'" "$CONFIG_FILE" | grep -o '[0-9]\+\.[0-9]\+\.[0-9]\+')
sed -i "s/Defaults to \`\`$PREV_VERSION\`\`/Defaults to \`\`$VERSION\`\`/" "$CONFIG_FILE"
sed -i "s/'minimum\.supported\.desktop\.version' => '[0-9]\+\.[0-9]\+\.[0-9]\+'/'minimum.supported.desktop.version' => '$VERSION'/g" "$CONFIG_FILE"
echo "Updated $CONFIG_FILE"
# Check if any changes were made
if [ -n "$(git diff "$DAV_FILE" "$CONFIG_FILE")" ]; then
echo "CHANGES_MADE=true" >> $GITHUB_OUTPUT
echo "Changes were made to the files"
git diff "$DAV_FILE" "$CONFIG_FILE"
else
echo "CHANGES_MADE=false" >> $GITHUB_OUTPUT
echo "No changes were needed (versions might already be up to date)"
fi
- name: Create Pull Request
uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e
if: steps.update-files.outputs.CHANGES_MADE == 'true'
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
commit-message: "chore: Update minimum supported desktop version"
committer: GitHub <noreply@github.com>
author: nextcloud-command <nextcloud-command@users.noreply.github.com>
signoff: true
branch: "automated/noid/${{ matrix.branches }}-update-min-supported-desktop-version"
title: "chore: Update minimum supported desktop version to ${{ steps.extract-version.outputs.VERSION }}"
base: "master"
body: |
Auto-generated update of the minimum supported desktop version using last supported version.
https://github.com/nextcloud/desktop/blob/@%7B5.years.ago%7D/VERSION.cmake
labels: |
client: 💻 desktop
automated
3. to review
reviewers: '@nextcloud/desktop'
@@ -0,0 +1,55 @@
name: Update Psalm baseline
on:
workflow_dispatch:
schedule:
- cron: '5 4 * * *'
jobs:
update-psalm-baseline:
runs-on: ubuntu-latest
if: ${{ github.repository_owner != 'nextcloud-gmbh' }}
steps:
- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
with:
submodules: true
- name: Set up php7.4
uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
with:
php-version: 7.4
extensions: ctype,curl,dom,fileinfo,gd,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
coverage: none
- name: Composer install
run: composer install
- name: Psalm
run: composer run psalm -- --monochrome --no-progress --output-format=text --update-baseline
continue-on-error: true
- name: Reset composer
run: |
git clean -f lib/composer
git checkout composer.json composer.lock lib/composer
- name: Create Pull Request
uses: peter-evans/create-pull-request@18f7dc018cc2cd597073088f7c7591b9d1c02672 # v3.14.0
with:
token: ${{ secrets.COMMAND_BOT_PAT }}
commit-message: Update psalm baseline
committer: GitHub <noreply@github.com>
author: nextcloud-command <nextcloud-command@users.noreply.github.com>
signoff: true
branch: automated/noid/psalm-baseline-update
# Make sure we can open multiple PRs
branch-suffix: timestamp
title: '[Automated] Update psalm-baseline.xml'
body: |
Auto-generated update psalm-baseline.xml with fixed psalm warnings
labels: |
automated pr
3. to review
team-reviewers: server-backend
@@ -1,69 +0,0 @@
# SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Update PRs titles on stable branches
on:
pull_request:
types: [opened, edited]
branches:
- "stable*"
concurrency:
group: stable-pr-title-${{ github.event.pull_request.number }}
cancel-in-progress: true
jobs:
update-pr-title:
runs-on: ubuntu-latest-low
permissions:
pull-requests: write
contents: read
steps:
- name: Wait for potential title edits
run: sleep 15
- name: Get PR details and update title
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const { data: pr } = await github.rest.pulls.get({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.issue.number,
});
const baseBranch = pr.base.ref;
const currentTitle = pr.title;
// Check if this is a stable branch
// Should not happen as we only trigger on stable* branches 🤷‍♀️
if (!baseBranch.startsWith('stable')) {
console.log(`Not a stable branch: ${baseBranch}`);
return;
}
const prefix = `[${baseBranch}]`;
// Check if title already has the correct prefix and no other stable tags
const correctTagRegex = new RegExp(`^\\[${baseBranch}\\]\\s*`);
const hasOtherStableTags = /\[stable[\d.]*\]/.test(currentTitle.replace(correctTagRegex, ''));
if (correctTagRegex.test(currentTitle) && !hasOtherStableTags) {
console.log(`Title already has correct prefix only: ${currentTitle}`);
return;
}
// Remove all stable tags and add the correct one
const cleanTitle = currentTitle.replace(/\[stable[\d.]*\]\s*/g, '').trim();
const newTitle = `${prefix} ${cleanTitle}`;
console.log(`Updating title from: "${currentTitle}" to: "${newTitle}"`);
await github.rest.pulls.update({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.issue.number,
title: newTitle,
});
+2 -28
View File
@@ -1,7 +1,3 @@
# SPDX-FileCopyrightText: 2016-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-FileCopyrightText: 2011-2016 ownCloud contributors
# SPDX-FileCopyrightText: 2010 ownCloud contributors
# SPDX-License-Identifier: AGPL-3.0-only
# the default generated dir + db file
/data
/config/config.php
@@ -17,6 +13,7 @@
# ignore all apps except core ones
/apps*/*
!/apps/accessibility
!/apps/cloud_federation_api
!/apps/comments
!/apps/contactsinteraction
@@ -28,14 +25,12 @@
!/apps/sharebymail
!/apps/encryption
!/apps/files_external
!/apps/files_reminders
!/apps/files_sharing
!/apps/files_trashbin
!/apps/files_versions
!/apps/lookup_server_connector
!/apps/user_ldap
!/apps/oauth2
!/apps/profile
!/apps/provisioning_api
!/apps/settings
!/apps/systemtags
@@ -46,7 +41,6 @@
!/apps/twofactor_backupcodes
!/apps/user_status
!/apps/weather_status
!/apps/webhook_listeners
!/apps/workflowengine
/apps/files_external/3rdparty/irodsphp/PHPUnitTest
/apps/files_external/3rdparty/irodsphp/web
@@ -64,9 +58,6 @@
!/themes/example
!/themes/README
# Love to people that develop the updater
/updater
# just sane ignores
.*.sw[po]
*.bak
@@ -83,7 +74,6 @@ CVS/*
RCS/*
*.backup*
.php_cs.cache
.php-cs-fixer.cache
# kdevelop
.kdev
@@ -106,7 +96,6 @@ nbproject
# vscode
.vscode
*.code-workspace
# geany
*.geany
@@ -137,8 +126,7 @@ nbproject
# nodejs
/build/bin
/build/lib/
/build/integration/output/
/build/integration/phpserver.log
/build/jsdocs/
/npm-debug.log
/PhantomJS_*
@@ -151,8 +139,6 @@ Vagrantfile
# Tests - auto-generated files
/data-autotest
/results.sarif
/tests/.phpunit.cache
/tests/.phpunit.result.cache
/tests/coverage*
/tests/css
@@ -167,22 +153,10 @@ Vagrantfile
/config/config-autotest-backup.php
/config/autoconfig.php
clover.xml
/coverage
# Tests - dependencies
tests/acceptance/vendor/
composer.phar
/lib/composer/bin
/lib/composer/bamarni
/vendor-bin/**/vendor
./.htaccess
core/js/mimetypelist.js
# Tests - cypress
cypress/downloads
cypress/snapshots
cypress/videos
/.direnv
-3
View File
@@ -1,6 +1,3 @@
# SPDX-FileCopyrightText: 2016 Nextcloud GmbH and Nextcloud contributors
# SPDX-FileCopyrightText: 2016 ownCloud, Inc.
# SPDX-License-Identifier: AGPL-3.0-only
[submodule "3rdparty"]
path = 3rdparty
url = https://github.com/nextcloud/3rdparty.git
+21 -36
View File
@@ -15,18 +15,11 @@
<IfModule mod_env.c>
# Add security and privacy related headers
# Avoid doubled headers by unsetting headers in "onsuccess" table,
# then add headers to "always" table: https://github.com/nextcloud/server/pull/19002
<If "%{REQUEST_URI} =~ m#/login$#">
# Only on the login page we need any Origin or Referer header set.
Header onsuccess unset Referrer-Policy
Header always set Referrer-Policy "same-origin"
</If>
<Else>
Header onsuccess unset Referrer-Policy
Header always set Referrer-Policy "no-referrer"
</Else>
Header onsuccess unset Referrer-Policy
Header always set Referrer-Policy "no-referrer"
Header onsuccess unset X-Content-Type-Options
Header always set X-Content-Type-Options "nosniff"
@@ -40,11 +33,14 @@
Header onsuccess unset X-Robots-Tag
Header always set X-Robots-Tag "noindex, nofollow"
Header onsuccess unset X-XSS-Protection
Header always set X-XSS-Protection "1; mode=block"
SetEnv modHeadersAvailable true
</IfModule>
# Add cache control for static resources
<FilesMatch "\.(css|js|mjs|svg|gif|png|jpg|webp|ico|wasm|tflite)$">
<FilesMatch "\.(css|js|svg|gif|png|jpg|ico|wasm|tflite)$">
<If "%{QUERY_STRING} =~ /(^|&)v=/">
Header set Cache-Control "max-age=15778463, immutable"
</If>
@@ -53,13 +49,25 @@
</Else>
</FilesMatch>
# Let browsers cache OTF and WOFF files for a week
<FilesMatch "\.(otf|woff2?)$">
# Let browsers cache WOFF files for a week
<FilesMatch "\.woff2?$">
Header set Cache-Control "max-age=604800"
</FilesMatch>
</IfModule>
# PHP 7.x
<IfModule mod_php7.c>
php_value mbstring.func_overload 0
php_value default_charset 'UTF-8'
php_value output_buffering 0
<IfModule mod_env.c>
SetEnv htaccessWorking true
</IfModule>
</IfModule>
# PHP 8+
<IfModule mod_php.c>
php_value mbstring.func_overload 0
php_value default_charset 'UTF-8'
php_value output_buffering 0
<IfModule mod_env.c>
@@ -71,8 +79,6 @@
AddType image/svg+xml svg svgz
AddType application/wasm wasm
AddEncoding gzip svgz
# Serve ESM javascript files (.mjs) with correct mime type
AddType text/javascript js mjs
</IfModule>
<IfModule mod_dir.c>
@@ -93,29 +99,8 @@
RewriteRule ^remote/(.*) remote.php [QSA,L]
RewriteRule ^(?:build|tests|config|lib|3rdparty|templates)/.* - [R=404,L]
RewriteRule ^\.well-known/(?!acme-challenge|pki-validation) /index.php [QSA,L]
RewriteRule ^ocm-provider/?$ index.php [QSA,L]
RewriteRule ^(?:\.(?!well-known)|autotest|occ|issue|indie|db_|console).* - [R=404,L]
</IfModule>
# Clients like xDavv5 on Android, or Cyberduck, use chunked requests.
# When FastCGI or FPM is used with apache, requests arrive to Nextcloud without any content.
# This leads to the creation of empty files.
# The following directive will force the problematic requests to be buffered before being forwarded to Nextcloud.
# This way, the "Transfer-Encoding" header is removed, the "Content-Length" header is set, and the request content is proxied to Nextcloud.
# Here are more information about the issue:
# - https://docs.cyberduck.io/mountainduck/issues/fastcgi/
# - https://docs.nextcloud.com/server/latest/admin_manual/issues/general_troubleshooting.html#troubleshooting-webdav
<IfModule mod_setenvif.c>
SetEnvIfNoCase Transfer-Encoding "chunked" proxy-sendcl=1
</IfModule>
# Apache disabled the sending of the server-side content-length header
# in their 2.4.59 patch updated which breaks some use-cases in Nextcloud.
# Setting ap_trust_cgilike_cl allows to bring back the usual behaviour.
# See https://bz.apache.org/bugzilla/show_bug.cgi?id=68973
<IfModule mod_env.c>
SetEnv ap_trust_cgilike_cl
</IfModule>
AddDefaultCharset utf-8
Options -Indexes
-2
View File
@@ -1,2 +0,0 @@
SPDX-FileCopyrightText: 2014 ownCloud, Inc.
SPDX-License-Identifier: AGPL-3.0-only

Some files were not shown because too many files have changed in this diff Show More