petru/coder-server
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

feat: make readinessProbe and livenessProbe initialDelaySeconds configurable (#18756)

Browse Source 
Makes `initialDelaySeconds` configurable for both `readinessProbe` and
`livenessProbe` in the Helm chart.

**Changes:**
- Added `coder.readinessProbe.initialDelaySeconds` and
`coder.livenessProbe.initialDelaySeconds` to `values.yaml`
- Updated `_coder.tpl` template to use these configurable values
- Defaults to 0 seconds to maintain existing behavior

**Testing:**
- Verified template rendering with default values (0)
- Verified template rendering with custom values (30, 60)
- Both probes correctly use the configured `initialDelaySeconds`

---------

Co-authored-by: blink-so[bot] <211532188+blink-so[bot]@users.noreply.github.com>
Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
This commit is contained in:
blink-so[bot]
2025-07-07 08:37:19 +01:00
committed by GitHub
parent a1c77e36be
commit 65809710e5
48 changed files with 106 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
helm/coder/templates/_coder.tpl
+2
View File
@@ -100,9 +100,11 @@ readinessProbe:
path: /healthz
port: "http"
scheme: "HTTP"
initialDelaySeconds: {{ .Values.coder.readinessProbe.initialDelaySeconds }}
livenessProbe:
httpGet:
path: /healthz
port: "http"
scheme: "HTTP"
initialDelaySeconds: {{ .Values.coder.livenessProbe.initialDelaySeconds }}
{{- end }}
helm/coder/tests/testdata/auto_access_url_1.golden
Vendored
+2
View File
@@ -171,6 +171,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -181,6 +182,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/auto_access_url_1_coder.golden
Vendored
+2
View File
@@ -171,6 +171,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -181,6 +182,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/auto_access_url_2.golden
Vendored
+2
View File
@@ -171,6 +171,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -181,6 +182,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/auto_access_url_2_coder.golden
Vendored
+2
View File
@@ -171,6 +171,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -181,6 +182,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/auto_access_url_3.golden
Vendored
+2
View File
@@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/auto_access_url_3_coder.golden
Vendored
+2
View File
@@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/command.golden
Vendored
+2
View File
@@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/command_args.golden
Vendored
+2
View File
@@ -170,6 +170,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -180,6 +181,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/command_args_coder.golden
Vendored
+2
View File
@@ -170,6 +170,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -180,6 +181,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/command_coder.golden
Vendored
+2
View File
@@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/custom_resources.golden
Vendored
+2
View File
@@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 4000m
helm/coder/tests/testdata/custom_resources_coder.golden
Vendored
+2
View File
@@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 4000m
helm/coder/tests/testdata/default_values.golden
Vendored
+2
View File
@@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/default_values_coder.golden
Vendored
+2
View File
@@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/env_from.golden
Vendored
+2
View File
@@ -181,6 +181,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -191,6 +192,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/env_from_coder.golden
Vendored
+2
View File
@@ -181,6 +181,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -191,6 +192,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/extra_templates.golden
Vendored
+2
View File
@@ -178,6 +178,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -188,6 +189,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/extra_templates_coder.golden
Vendored
+2
View File
@@ -178,6 +178,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -188,6 +189,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/labels_annotations.golden
Vendored
+2
View File
@@ -177,6 +177,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -187,6 +188,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/labels_annotations_coder.golden
Vendored
+2
View File
@@ -177,6 +177,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -187,6 +188,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/partial_resources.golden
Vendored
+2
View File
@@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
requests:
cpu: 1500m
helm/coder/tests/testdata/partial_resources_coder.golden
Vendored
+2
View File
@@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
requests:
cpu: 1500m
helm/coder/tests/testdata/prometheus.golden
Vendored
+2
View File
@@ -170,6 +170,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -183,6 +184,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/prometheus_coder.golden
Vendored
+2
View File
@@ -170,6 +170,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -183,6 +184,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/provisionerd_psk.golden
Vendored
+2
View File
@@ -174,6 +174,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -184,6 +185,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/provisionerd_psk_coder.golden
Vendored
+2
View File
@@ -174,6 +174,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -184,6 +185,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/sa.golden
Vendored
+2
View File
@@ -170,6 +170,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -180,6 +181,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/sa_coder.golden
Vendored
+2
View File
@@ -170,6 +170,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -180,6 +181,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/sa_disabled.golden
Vendored
+2
View File
@@ -155,6 +155,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -165,6 +166,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/sa_disabled_coder.golden
Vendored
+2
View File
@@ -155,6 +155,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -165,6 +166,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/sa_extra_rules.golden
Vendored
+2
View File
@@ -183,6 +183,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -193,6 +194,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/sa_extra_rules_coder.golden
Vendored
+2
View File
@@ -183,6 +183,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -193,6 +194,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/securitycontext.golden
Vendored
+2
View File
@@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/securitycontext_coder.golden
Vendored
+2
View File
@@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/svc_loadbalancer.golden
Vendored
+2
View File
@@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/svc_loadbalancer_class.golden
Vendored
+2
View File
@@ -170,6 +170,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -180,6 +181,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/svc_loadbalancer_class_coder.golden
Vendored
+2
View File
@@ -170,6 +170,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -180,6 +181,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/svc_loadbalancer_coder.golden
Vendored
+2
View File
@@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/svc_nodeport.golden
Vendored
+2
View File
@@ -168,6 +168,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -178,6 +179,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/svc_nodeport_coder.golden
Vendored
+2
View File
@@ -168,6 +168,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -178,6 +179,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/tls.golden
Vendored
+2
View File
@@ -182,6 +182,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -195,6 +196,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/tls_coder.golden
Vendored
+2
View File
@@ -182,6 +182,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -195,6 +196,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/topology.golden
Vendored
+2
View File
@@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/topology_coder.golden
Vendored
+2
View File
@@ -169,6 +169,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -179,6 +180,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/workspace_proxy.golden
Vendored
+2
View File
@@ -177,6 +177,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -187,6 +188,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/tests/testdata/workspace_proxy_coder.golden
Vendored
+2
View File
@@ -177,6 +177,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
name: coder
ports:
- containerPort: 8080
@@ -187,6 +188,7 @@ spec:
path: /healthz
port: http
scheme: HTTP
initialDelaySeconds: 0
resources:
limits:
cpu: 2000m
helm/coder/values.yaml
+12
View File
@@ -206,6 +206,18 @@ coder:
# cpu: 2000m
# memory: 4096Mi
# coder.readinessProbe -- Readiness probe configuration for the Coder container.
readinessProbe:
# coder.readinessProbe.initialDelaySeconds -- Number of seconds after the container
# has started before readiness probes are initiated.
initialDelaySeconds: 0
# coder.livenessProbe -- Liveness probe configuration for the Coder container.
livenessProbe:
# coder.livenessProbe.initialDelaySeconds -- Number of seconds after the container
# has started before liveness probes are initiated.
initialDelaySeconds: 0
# coder.certs -- CA bundles to mount inside the Coder pod.
certs:
# coder.certs.secrets -- A list of CA bundle secrets to mount into the Coder